[mpd-devel] This mailing list will be shut down

[Max Kellermann]

Hi,

this mailing list hasn't been used for any developer discussion for
many years.  After switching MPD to GitHub, all code submissions and
all discussions were handled there.  Even though I don't particularly
like GitHub, it has proven to be an effective tool.  See you over
there!

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Audiolinux MPd

[Max Kellermann]

On 2018/12/26 16:48, antonio  wrote:
> Is this legal?
> 
> http://www.audio-linux.com/

It is perfectly legal to sell MPD for money, but only if you obey the
requirements of the GPL.

If you have a copy of their image, please verify whether it contains a
written offer to receive the MPD source code.  If not, it's illegal.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] upmpdcli is illegal

[Max Kellermann]

Hi Jean-Francois,

today, I came across your project due to a MPD bug report.

I'm sorry I have to tell you that your project is illegal.  You claim
that it is licensed under the terms of the GPL, but your code
repository ships with a C header from the proprietary Spotify API:

 
https://opensourceprojects.eu/p/upmpdcli/code/ci/dcd37d30e1aa074b9ef205872e01e39a6079ee8d/tree/src/mediaserver/cdplugins/spotify/libspotify/api.h

Including this header from upmpdcli makes upmpdcli a "derived work" of
this proprietary library.  This however is what the GPL forbids,
unless the whole "derived work" is made available under the terms of
the GPL.

Since you own most of the copyright of upmpdcli, you obviously don't
violate your own copyright.  But there are more (minor) contributors,
whose copyright you have been violating.

And as a side effect, every redistribution of upmpdcli by others is
illegal.  It is impossible for anybody to contribute to your project.
Linux distributions are forbidden from shipping packages.

By the way, runtime linking to this library (using dlopen()) doesn't
protect you, just in case you were thinking about that.  This is just
a technical detail without legal implications.

Please remove all traces of proprietary code from your repository as
soon as possible.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/03/04 13:34, Max Kellermann <m...@musicpd.org> wrote:
> On 2018/03/01 16:48, Billy Wright <bi...@caryaudio.com> wrote:
> > Attached is the MPD open source code of the DMS-500 in accordance with 
> > conditions of the GPL v2.
> 
> Imported to GitHub: 
> https://github.com/MusicPlayerDaemon/MPD/commit/f4c2fa881b7e506abab1a1255682e0549a93b15b

Note that this is based on commit
250b6a3d521523617ea654d66a5156faa64f6f28 authored by me on February
3rd.

Cary Audio learned about their license termination one week prior to
this (January 25th).

At the time their binaries in question were built, the source code
Billy Wright just gave me didn't yet exist.  This has interesting
implications: Cary Audio indeed did continue to use MPD even after I
terminated their license.

For some time I thought Cary Audio would create a new firmware version
completely without MPD, because the license is terminated.  But it
looks like that's not what they're doing.  They are just going on with
business as if nothing happened, and send this Billy Wright drone to
distract me with his lies and bullshit.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/03/01 16:48, Billy Wright  wrote:
> Attached is the MPD open source code of the DMS-500 in accordance with 
> conditions of the GPL v2.

Imported to GitHub: 
https://github.com/MusicPlayerDaemon/MPD/commit/f4c2fa881b7e506abab1a1255682e0549a93b15b
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/03/01 16:48, Billy Wright  wrote:
> Max,
> 
> Attached is the MPD open source code of the DMS-500 in accordance with 
> conditions of the GPL v2.

No, this is *NOT* in accordance with conditions of the GPL v2.  This
is still not the source code of the two binaries I asked you about.

Now I have two source tarballs from you, two completely different ones
(first one based on 0.20 pre-alpha, and the new one based on 0.21
pre-alpha), but both are wrong and incomplete.

> Also, I tried to call yesterday on 2 numbers I had for you. It just
> rang and rang and no ability to leave a message. I have also
> e-mailed yesterday and today asking a phone number so I could give
> you a call. I have not received any response. Please let me know a
> number and a good time for you so I can give you a call.

You know how to leave me a message.  You just did.  Unfortunately, you
were lying again, and you still:

- havn't given me the source code of the two MPD binaries

- are still actively promoting your DMS-500 product which is still
  based on a pirated copy of my software, making your whole product
  illegal

- fail to understand that your MPD license is T-E-R-M-I-N-A-T-E-D and
  it is in my arbitrary decision to ever reissue a license for you, so
  you better play nice with me

Your behavior is evil and nefarious.  Or you are just extremely
incompetent and still don't realize what you're doing and in what
existential legal and financial danger you're currently bringing the
whole Cary Audio firm.

(Third option: maybe you're just a good troll, because you just made
me repeat the same points AGAIN with your brief and dull email.)

I have no idea what I should be phoning about with a person like you.
Leave me a message (you know how) and explain it to me.  Why should I
phone with you, after what you've been doing to me, after you've been
failing to deliver what I have been asking you, and is your most
primitive obligation as a MPD licensee?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/02/23 09:11, demian...@yahoo.com wrote:
> It may be time to contact a group like this: https://sfconservancy.org/

Yes, that's my favorite option.  They have good experts with lots of
GPL enforcement experience.

I've been waiting with that step for so long because I wanted to give
Cary Audio a more-than-fair chance to recover without horrendous legal
cost.  But in hindsight it looks like my attempts to explain the
problem over and over were just a waste of time.  Cary Audio is either
evil, or very very stupid.

("Never ascribe to malice, that which can be explained by stupidity.")


> IBM, Cisco and Nvidia have figured this out so its not impossible.

Nvidia's trick is that they publish only source code together with a
BLOB; the actual GPL violation (linking this into the kernel) will be
performed by the user, but since copyright law doesn't affect users,
this is not a legal problem.

(All of my computers have AMD or Intel graphics, for a reason.)


> Cary Audio is in over their heads on this. I'm sure the software
> guys are not employees but an outside group he has hired.

It looks like much of the DMS-500 software development was outsourced
to Hong Kong (at least the Java/Android apps).
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/02/22 22:09, Arnold Krille  wrote:
>  - you must completely stop selling(*) products that include MPD
>immidiately until a new firmware is flashed onto these devices
>(*) that includes your partners and resellers

True, that was my point.  Cary Audio does new advertising campaigns
RIGHT NOW on Facebook for the DMS-500, which at this point, contains
MPD and violates my copyright.  And the Cary Audio web shop still
sells the DMS-500, which violates my copyright.

 https://www.facebook.com/caryaudiodesign/
 https://carydirect.com/shop-now/dms-500.html (this link works only
 with a USA IP address)

> > (No, the damage is not repaired by removing MPD.  This just stops
> > causing more damage.  The above list is not "multiple choice"; you
> > don't have a choice.  The only choice you have is: with or without
> > lawyers+court.)
> 
> I may not be a lawyer, I am just a user of MPD getting really pissed
> about your complete disregard of Max's intellectual property and his
> work!

Yes, I'm truly pissed off by Billy Wright's perpetual ignorance.  I
had been thinking for a while that he's honest and really doesn't have
a clue what's going on, so I tried to explain it over and over and
over, but he kept pretending he doesn't understand, and kept ignoring
the important parts.

But he's not some random dumbass; he's the CEO of Cary Audio, after
all.  I wonder if you can be a top-level manager and be so clueless
and incompetent all the time.  No, you can't, I believe.

I don't believe Billy Wright is as stupid as he pretends to be.  This
is intentional ignorance, and he tries to distract and delay us.  Cary
Audio is nefarious and evil.

> Billy, do you hate product piracy? Stop being a thief yourself!

Isn't it funny that Billy Wright complains that I "lifted E-mail
addresses from his Copyrighted website"?  This is so ridiculous (but
again I believe he's trying to distract us, so we make fun of this
obvious stupidness instead of caring about the actual copyright
violation).
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

Billy Wright,

you are still selling the DMS-500 with my copyrighted work, without
having a license.  And you are advertising new products which include
my copyrighted work.

I urge you to STOP SELLING ANY PRODDUCTS WITH MUSIC PLAYER DAEMON
**IMMEDIATELY**.

Your ignorance and dishonesty makes me really angry.  It looks like
you just want to hold me back with your lies, and you don't really
want to solve the problem.  Maybe you think you can get away with
that, but you won't.  Copyright law is on my side.  You overestimate
my patience and you underestimate my will to prosecute your piracy.

Weeks ago, I asked you to make a suggestion how to repair the damage
you have caused, but you never replied to that.  And you continue to
cause more damage, willfully.

And I still don't have the source code.

Everything you do is wrong, from the bottom.

Next week, I'll contact a lawyer to bring your case to court.  You
know this will not end well.

This is your very last chance to repair this quickly, without
expensive legal people.

___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] "one of the biggest steals in all high-performance audio"

[Max Kellermann]

News on Cary Audio's Facebook page:

 "You haven’t really heard your digital music files or internet music
 streaming until you’ve experienced it with the DMS-500. Considered
 one of the biggest steals in all high-performance audio, [...]"

 https://www.facebook.com/caryaudiodesign/posts/1916384668403232

Finally, a honest statement from Cary Audio on their copyright
violation issue ;-)

___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Copyright violation in Cary Audio DMS-500

[Max Kellermann]

On 2018/02/14 11:04, Imre Kiss <stbau...@gmail.com> wrote:
> we have purchased the goods from Cary Audio, by right they are
> liable for any possible infrigment and are liable of any
> consequences of the infrigment.

Be careful with that assumption.  I don't think this is how selling
known-illegal products works.  At least not here in Germany.

It might be a good idea to ask Cary Audio for a guarantee for legal
protection before you sell more of their products.  If they refuse to
give you that guarantee, you should be wary.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

Billy, please stop telling me this bullshit, seriously.  There is a
lot of code owned by Cary Audio you are still holding back.  Because
your software guys have redacted it from the tarball you sent to me.

I told you that already, but you wouldn't listen, you keep ignoring
that part.  Your emails sound like you're rueful, but your actions
demonstrate the contrary.

You say you want transparency, but you deliver only bullshit.  I'm not
saying you are lying to me; you probably (still) have no idea what's
going on, and you only repeat the bullshit your software guys have
been telling you.

Your software guys have thrown you in a deep pit, and you not only
still believe them, but also forward their bullshit to me.

No forgiveness can be granted to you, sorry.

You better remove MPD from your products completely, because it
doesn't look good for your license.


On 2018/02/12 18:26, Billy Wright <bi...@caryaudio.com> wrote:
> Max,
> 
> Our software guys are re-writing our code to be sure there are no issues with 
> MPD. We will e-mail the source code for MPD when it is completed and tested. 
> They tell me it will be the end of the month.
> 
> I am asking for forgiveness for any current and past violations of GPL 
> compliance. It was in no way intentional, and we sincerely apologize.  We 
> had/have no malicious intent, only ignorance to the GPL.  We have no way of 
> stopping usage of code within the boxes already in the field, only correcting 
> and pushing new code to all boxes once we finish with the changes/compliance. 
>  Our intent is to be as transparent as possible and follow any and all rules. 
> As mentioned above, it is being corrected as soon as possible. Once released 
> all units are updated and all previous versions of software are gone. We are 
> not going to release any source code involving our third party partners as 
> this would be clear violations of our agreements with them. This should be 
> respected from any perspective because to do so would  knowingly put us in 
> violation of various agreements. As noted, any violation of the GPL was 
> clearly unintentional, and our intention is to rectify it as soon as we 
> possibly can.  
> 
> We do appreciate your patience.
> 
> Sincerely, 
> 
> 
> 
> Billy Wright | President | LinkedIn
> CARY AUDIO 
> 6301 Chapel Hill Road | Raleigh, NC 27607
> 919-355-0010 PHONE  
> www.caryaudio.com
> www.aebycary.com 
> 
>   
> 
>     
> 
> Click here to sign up to receive our monthly enewsletters!
> 
> 
> -Original Message-
> From: Max Kellermann [mailto:m...@duempel.org] 
> Sent: Saturday, February 10, 2018 10:48 AM
> To: Billy Wright <bi...@caryaudio.com>
> Cc: mpd-devel@musicpd.org; Daryl Berk <da...@caryaudio.com>
> Subject: Re: [mpd-devel] Request for GPL source code of 
> DMS-500_v1.30.9_20170802.zip
> 
> On 2018/02/10 15:57, Billy Wright <bi...@caryaudio.com> wrote:
> > I am taking this issue very seriously. Our software guys have been working 
> > on this since we became aware of the issue. They tell me it will take until 
> > the end of the month to complete and test. I will send you confirmation 
> > immediately.
> 
> Your software guys have been working on finding the source code?  And they 
> will suddenly find it at the end of the month?
> 
> The file you sent to me was heavily redacted.  Your software guys had been 
> very busy deleting the interesting parts.  But the GPL doesn't work that way. 
>  Your software guys have been doing all wrong.
> 
> Your failure to deliver the full source code is an ongoing violation of my 
> copyright.  Deleting stuff from your code isn't going to fix that.  Only 
> sending the full source code of the binary you shipped is going to fix that.
> 
> Again, just in case you still don't understand: even if you one day ship a 
> firmware image with GPL compliance, that's not a solution for my source code 
> request.
> 
> Again, once again: your license to use MPD is terminated.  You have three 
> options:
> 
> 1. seek forgiveness from all MPD copyright holders to reinstate the
>GPL
> 
> 2. choose the GPLv3 instead which allows reinstating the licesen
>without explicit forgiveness (beware of the other implications!)
> 
> 3. stop using MPD at all
> 
> But again again again: that doesn't affect my source code request.
> Unredacted, nothing deleted.  That is what the GPL mandates.  Nothing less.
> 
> I hate repeating myself and this is really annoying, but I have a feeling 
> that you still don't know how deep your hole is, and how incompetent your 
> software guys are.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/02/10 15:57, Billy Wright  wrote:
> I am taking this issue very seriously. Our software guys have been working on 
> this since we became aware of the issue. They tell me it will take until the 
> end of the month to complete and test. I will send you confirmation 
> immediately.

Your software guys have been working on finding the source code?  And
they will suddenly find it at the end of the month?

The file you sent to me was heavily redacted.  Your software guys had
been very busy deleting the interesting parts.  But the GPL doesn't
work that way.  Your software guys have been doing all wrong.

Your failure to deliver the full source code is an ongoing violation
of my copyright.  Deleting stuff from your code isn't going to fix
that.  Only sending the full source code of the binary you shipped is
going to fix that.

Again, just in case you still don't understand: even if you one day
ship a firmware image with GPL compliance, that's not a solution for
my source code request.

Again, once again: your license to use MPD is terminated.  You have
three options:

1. seek forgiveness from all MPD copyright holders to reinstate the
   GPL

2. choose the GPLv3 instead which allows reinstating the licesen
   without explicit forgiveness (beware of the other implications!)

3. stop using MPD at all

But again again again: that doesn't affect my source code request.
Unredacted, nothing deleted.  That is what the GPL mandates.  Nothing
less.

I hate repeating myself and this is really annoying, but I have a
feeling that you still don't know how deep your hole is, and how
incompetent your software guys are.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/02/06 20:53, Max Kellermann <m...@blarg.de> wrote:
> On 2018/02/06 20:44, Billy Wright <bi...@caryaudio.com> wrote:
> > Attached is a file of the MPD source code.
> 
> This is not the full source code of the MPD binary which is
> distributed in your firmware image.  That is really trivial to see.
> Your tarball fails even the most basic test.

I imported the tarball into our git repository, just in case anybody
is curious:

 https://github.com/MusicPlayerDaemon/MPD/commit/caryaudio

(I havn't yet picked the correct base commit, so you see too many
differences.  I'll correct it later.)
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/02/06 20:44, Billy Wright  wrote:
> Attached is a file of the MPD source code.

This is not the full source code of the MPD binary which is
distributed in your firmware image.  That is really trivial to see.
Your tarball fails even the most basic test.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

Dead sir or madam,

I'd like to extend my request for MPD source code.

I downloaded DMS-600_v1.0.4_20180111(X5020).zip from your server
(which you have switched off meanwhile),
SHA-256=18ceea4442a6ed0b9ad5f1a438cf7f83f8cdcc3a9a3a55f528fee2f47d3d103d

It contains a file "bin/mpd",
SHA-256=ddc8e48149e0e9b5ea95bf7277c5b2493b1e3aaa17e305323dc96d7ed4c443e8,
a derived work of Music Player Daemon, of which I am a major copyright
holder.

I demand to receive the full source code of that file until February
8th 2018.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Roon RAAT SDK license

[Max Kellermann]

Thanks so far, Brian; I contacted Cary Audio last week, but did not
get a reply.  All they did was switch off the server which had
firmware downloads, but I was able to pull a mirror of it.

It looks like Cary Audio outsourced the MPD related work to a Chinese
contractor who didn't know or care about copyright.

On 2018/01/31 03:33, Brian Luczkiewicz  wrote:
> It was a surprise to me to learn that our code was being statically linked
> into mpd

Just in case Cary Audio denies it, here's an excerpt from "objdump -d
usr/bin/mpd":

 0019d32c :
   19d32c:   e2403d5dsub r3, r0, #5952   ; 0x1740
   19d330:   e92d4010push{r4, lr}
   19d334:   e2433030sub r3, r3, #48 ; 0x30
   19d338:   e3530ffacmp r3, #1000   ; 0x3e8
   19d33c:   2a1abcs 19d3ac 

   19d340:   e3013771movwr3, #6001   ; 0x1771
   19d344:   e153cmp r0, r3
   19d348:   0a14beq 19d3a0 

   19d34c:   e3013772movwr3, #6002   ; 0x1772
   19d350:   e153cmp r0, r3
   19d354:   0a0bbeq 19d388 

   19d358:   e3013770movwr3, #6000   ; 0x1770
   19d35c:   e153cmp r0, r3
   19d360:   0a0bbeq 19d394 

   19d364:   e59f3064ldr r3, [pc, #100]  ; 19d3d0 

   19d368:   e300221amovwr2, #538 ; 0x21a
   19d36c:   e59f1060ldr r1, [pc, #96]   ; 19d3d4 

   19d370:   e59f0060ldr r0, [pc, #96]   ; 19d3d8 

   19d374:   e08f3003add r3, pc, r3
   19d378:   e08f1001add r1, pc, r1
   19d37c:   e28330c0add r3, r3, #192; 0xc0
   19d380:   e08fadd r0, pc, r0
   19d384:   ebfa0e4cbl  20cbc <__assert_fail@plt>
   19d388:   e59f004cldr r0, [pc, #76]   ; 19d3dc 

   19d38c:   e08fadd r0, pc, r0
   19d390:   e8bd8010pop {r4, pc}
   19d394:   e59f0044ldr r0, [pc, #68]   ; 19d3e0 

   19d398:   e08fadd r0, pc, r0
   19d39c:   e8bd8010pop {r4, pc}
   19d3a0:   e59f003cldr r0, [pc, #60]   ; 19d3e4 

   19d3a4:   e08fadd r0, pc, r0
   19d3a8:   e8bd8010pop {r4, pc}
   19d3ac:   e59f3034ldr r3, [pc, #52]   ; 19d3e8 

   19d3b0:   e3a02f85mov r2, #532 ; 0x214
   19d3b4:   e59f1030ldr r1, [pc, #48]   ; 19d3ec 

   19d3b8:   e59f0030ldr r0, [pc, #48]   ; 19d3f0 

   19d3bc:   e08f3003add r3, pc, r3
   19d3c0:   e08f1001add r1, pc, r1
   19d3c4:   e28330c0add r3, r3, #192; 0xc0
   19d3c8:   e08fadd r0, pc, r0
   19d3cc:   ebfa0e3abl  20cbc <__assert_fail@plt>


This matches the source code in your SDK's raat/raat_client.c.
0x1770, 0x1771 and 0x1772 are RAAT__CLIENT_STATUS_NETWORK_ERROR and so
on.

The contractor forgot to disable assertions for the release build, and
it looks like compiler optimizations were disabled.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] Roon RAAT SDK license

[Max Kellermann]

Hi Roon Labs,

I'm the lead developer (and major copyright holder) of the Music Player
Daemon (MPD), a free music player software which you may have heard of.

I found out that Cary Audio ships your RAAT SDK code with their PMS-500
product (https://www.caryaudio.com/products/dms-500-network-audio-player/).
Your code is linked statically into MPD.

MPD is licensed under the terms of the GPL, which means Cary Audio has put
themselves into the difficult situation that they must release your SDK
under the GPL.  I bet you don't like that.

You may want to contact Cary Audio to discuss the situation.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] Tracking commercial products with MPD

[Max Kellermann]

Hi,

recently, I've been hunting several commercial vendors who were not
aware of the GPL obligations or intentionally violated the GPL, who
knows.

I didn't know MPD was used in so many products, and I lost track of it
a bit.  So I set up a web page:

 https://www.musicpd.org/commercial.html

Got more information?
 -> PR https://github.com/MusicPlayerDaemon/website

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

On 2018/01/25 22:58, Max Kellermann <m...@blarg.de> wrote:
> I downloaded
> http://58.22.61.211/rd3/DMS500/test_package/DMS-500_v1.30.9_20170802.zip
> SHA-256=f56cb2f1ec46a2365fc0a7aa57c451693aa76f6a0ba4b46803e974acf4cd3b04
> 
> That image contains a copy of the Music Player Daemon, of which I am a
> copyright holder.

Some context for the curious: their MPD binary has a MQA decoder
statically linked in.  We know MQA is a bullshit "codec", but AFAIK
there exists no free "decoder".  Anyway, this is the most interesting
GPL violation so far.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] Request for GPL source code of DMS-500_v1.30.9_20170802.zip

[Max Kellermann]

Dear sir or madan,

I downloaded
http://58.22.61.211/rd3/DMS500/test_package/DMS-500_v1.30.9_20170802.zip
SHA-256=f56cb2f1ec46a2365fc0a7aa57c451693aa76f6a0ba4b46803e974acf4cd3b04

That image contains a copy of the Music Player Daemon, of which I am a
copyright holder.

However, what I could not find is a written offer to provide the
source code of these binaries.  Please note that this is required
according to the terms of the GPLv2 section 3.  Which means that your
product violates my copyright.

I assume that not complying part of the GPLv2 was an oversight, and I
can easily forgive that.

What do I insist is that you provide the full source code of the Music
Player Daemon binary, including all the (shared) libraries that are
linked to it.

Note that failure to provide the full source code of both files
constitutes a serious copyright violation.  Additionally, it will
terminate your license according to GPLv2 section 4, rendering all of
your products containing my copyrighted software illegal.

I expect to receive the full source code and full GPL compliance
within two seeks, that is until Feburary 8th 2018.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Delivery Status Notification (Failure)

[Max Kellermann]

On 2018/01/02 17:11, Arnold Krille  wrote:
> They ship a base system that is four years old? And wasn't even one of
> the long-term releases from ubuntu?

So what.  Their MPD is 6 years old.  And isn't even a released
version, but a random commit in the middle of pre-0.17 development.

See here, I imported Aurender's patched MPD sources into our git
repository:

 https://github.com/MusicPlayerDaemon/MPD/commits/auPlayer-6.08.11
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of sMS-200_20170717-V0.4.0.zip

[Max Kellermann]

Thanks. Giving access to SRPMS is an good way to follow the GPL rules.

This is MPD 0.19.14, a branch that is long abandoned, and even within that
branch, it is an old release.  There have been 7 more bug-fix releases up
to 0.19.21 with several rather critical bug fixes.  This means that your
product can be exploited remotely. That worries me.
Even if you had the latest 0.19.21, your product would not be secure,
because as I said this branch has been abandoned a year ago and has not
received any security updates.

The MPD project always maintains one stable branch with feature freeze,
receiving only bug fixes. That may be be the best choice for you. The
current stable branch already has all the "native DSD" features, and you
don't need this third-party patch anymore.

To avoid becoming part of the many IoT botnets these days, please consider
providing proper security updates to your customers.


On Fri, Dec 22, 2017 at 4:24 AM, <may.p...@sotm-audio.com> wrote:

> Dear Max,
>
> Thank you for contacting us, my name is May and I’m working for SOtM as a
> marketing manager.
>
>
>
> This link is the one that you are looking for,
>
> http://www.sotm-audio.com/eunhasu/repo/releases/22/
> SRPMS/mpd-0.19.14-4.fc22.src.rpm
>
>
>
>
>
> Thank you.
>
> Best regards, May
>
>
>
> *From:* Max Kellermann [mailto:max.kellerm...@gmail.com]
> *Sent:* Friday, December 22, 2017 7:43 AM
> *To:* s...@sotm-audio.com; i...@sotm-audio.com
> *Cc:* mpd-devel@musicpd.org
> *Subject:* Request for GPL source code of sMS-200_20170717-V0.4.0.zip
>
>
>
> Dead sir or madam,
>
> I downloaded http://sotm-audio.com/eunhasu/firmware/arm/sMS-200_20170717-
> V0.4.0.zip SHA-256=44dba25b28c1de06713a9a2ec8bb9c
> f22da16b4a5c53103c704c8bc4d940a226
>
> This archive contains the Music Player Daemon, but no source code. Please
> send me the full source code of that binary.
>
> Regards,
>
> Max Kellermann
>
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of your Aurender A10 product

[Max Kellermann]

There are several licenses compatible with GPLv2, for example BSD 2-clause
or LGPLv2. But I'm not a lawyer, I can't give you legal advice - I'm just a
hacker, and I care that commercial entities like you respect the MPD
license. I'm disappointed by your behavior so far, because you already
violated the GPL (and my copyright).

I already told you twice that your MPD source doesn't match your binary.
The rules of the GPL mandate that you must provide the matching source code
for all binaries you distribute. If you can't follow those rules, then your
license is terminated automatically, making your product illegal.

Now I could tell you how I verified the mismatch, but then you'd change
that one piece in the source, and we're going to play endless whack-a-mole
where I can only lose. That's a poor way of solving something that is
naturally only your problem. So no, sorry, I can't let you know right now.
It's your turn, not mine. You need to resolve your copyright problem. I am
the victim, not the defendant.

On Fri, Dec 22, 2017 at 1:55 AM, Aurender <supp...@aurender.com> wrote:

> __
> Type your response ABOVE THIS LINE to reply
> ----------
> *Max Kellermann*
> *Subject:* Request for GPL source code of your Aurender A10 product
> --
> DEC 22, 2017  |  09:55AM KST
> *Eric Shim* replied:
>
> Hello Max,
>
> About the copyright, can we use other than GLPv2 even it is linked with
> GPLv2 binaries?
>
> Also, about MPD source, since you asked about libwimp alone in your last
> email, I assumed mpd source was ok.
> I am not sure how you decide it is same source or not, but it is the
> source code we used.
> We changed the internal version on configure.ac and we found the source
> with that version.
>
> Can you let me know how you decide the source matched with binary?
> Best regards,
> Eric Shim
> --
> DEC 22, 2017  |  09:37AM KST
> * Max * replied:
> Thanks so far, Eric.
> Your tarball does not contain any copyright/licensing information.Can I
> assume that your wimp source code is licensed under GPLv2+, just like MPD?
> When will you get me the source code of the MPD binary in your firmware? As
> I said, the code you sent me does not match.
> --
> DEC 22, 2017  |  09:19AM KST
> *Eric Shim* replied:
>
> Hello Max,
>
> As I explained, we just changed the key part from the libwimp.so.1 source.
> Anyway, I attached the unchanged code.
> Best regards,
> Eric Shim
> --
> DEC 22, 2017  |  09:19AM KST
> * Mail *
> ** 주소를 찾을 수 없음 **
>
> ad...@aurender.com 주소를 찾을 수 없거나 해당 주소에서 메일을 받을 수 없어 메일이 전송되지 않았습니다.
>
> 여기에서 자세히 알아보기: https://support.google.com/mail/?p=NoSuchUser
>
> 응답은 다음과 같습니다.
>
> 550 5.1.1 The email account that you tried to reach does not exist. Please
> try double-checking the recipient's email address for typos or unnecessary
> spaces. Learn more at https://support.google.com/mail/?p=NoSuchUser
> bg10sor8178944plb.54 - gsmtp
> --
> DEC 21, 2017  |  07:22AM KST
> * Max * replied:
> Eric, have your engineers been able to find the GPL-compatible source code
> of "libwimp.so.1"?
>
> Please don't understimate the severity of your situation. The core of your
> product is my software, and it appears that you have been selling it for
> years without my permission.
> --
> DEC 18, 2017  |  05:58PM KST
> * Max * replied:
> It is trivial to see that source on your website does not match the binary
> on my Aurender box. I insist that you send me the matching source code of
> that very binary.
>
> Let's see if your engineers are able to provide the source code of
> libwimp.so.1 with a free license. If not, we'll have serious problems.
> --
> DEC 18, 2017  |  05:35PM KST
> *ericshim...@aurender.com <ericshim%2...@aurender.com>* replied:
>
> Hello Max Kellermann
>
> First of all thank you for choosing Aurender.
> For the MPD source, you can find it from our website download section.
> http://www.aurender.com/page/download
> You can find GPL code center link in the page.
>
> About other source, I will forward this information to our engineers.
> --
> DEC 17, 2017  |  10:15PM KST
> Original message
> * Max * wrote:
>
> Dead sir or madam,
>
> I have an Aurender A10, and it was shipped with a file "local.tar.gz",
> SHA-256
> 32413ec552b27e6d868ced17c7de2423cfd6eeb2b21f72b31196bb9c2e0e5425
>
> This file contains a copy of a software of which I own the copyright, that
> is "bin/mpd", SHA-256
> 83f46f0eefd78e9cf6afa56d4065

Re: [mpd-devel] Request for GPL source code of your Aurender A10 product

[Max Kellermann]

Thanks so far, Eric.
Your tarball does not contain any copyright/licensing information.Can I
assume that your wimp source code is licensed under GPLv2+, just like MPD?
When will you get me the source code of the MPD binary in your firmware? As
I said, the code you sent me does not match.

On Fri, Dec 22, 2017 at 1:19 AM, Aurender <supp...@aurender.com> wrote:

> __
> Type your response ABOVE THIS LINE to reply
> ----------
> *Max Kellermann*
> *Subject:* Request for GPL source code of your Aurender A10 product
> --
> DEC 22, 2017  |  09:19AM KST
> *Eric Shim* replied:
>
> Hello Max,
>
> As I explained, we just changed the key part from the libwimp.so.1 source.
> Anyway, I attached the unchanged code.
> Best regards,
> Eric Shim
> --
> DEC 21, 2017  |  07:22AM KST
> * Max * replied:
> Eric, have your engineers been able to find the GPL-compatible source code
> of "libwimp.so.1"?
>
> Please don't understimate the severity of your situation. The core of your
> product is my software, and it appears that you have been selling it for
> years without my permission.
> --
> DEC 18, 2017  |  05:58PM KST
> * Max * replied:
> It is trivial to see that source on your website does not match the binary
> on my Aurender box. I insist that you send me the matching source code of
> that very binary.
>
> Let's see if your engineers are able to provide the source code of
> libwimp.so.1 with a free license. If not, we'll have serious problems.
> ------
> DEC 18, 2017  |  05:35PM KST
> *ericshim...@aurender.com <ericshim%2...@aurender.com>* replied:
>
> Hello Max Kellermann
>
> First of all thank you for choosing Aurender.
> For the MPD source, you can find it from our website download section.
> http://www.aurender.com/page/download
> You can find GPL code center link in the page.
>
> About other source, I will forward this information to our engineers.
> --
> DEC 17, 2017  |  10:15PM KST
> Original message
> * Max * wrote:
>
> Dead sir or madam,
>
> I have an Aurender A10, and it was shipped with a file "local.tar.gz",
> SHA-256
> 32413ec552b27e6d868ced17c7de2423cfd6eeb2b21f72b31196bb9c2e0e5425
>
> This file contains a copy of a software of which I own the copyright, that
> is "bin/mpd", SHA-256
> 83f46f0eefd78e9cf6afa56d4065688806a73e486a4ffb5b008bbbe72ed3e382
>
> This software has been linked with a library called "lib/libwimp.so.1"
> which is also contained in your USB stick, SHA-256
> 1f9b9a2fd3c06a2e920e0057bc6b5aa43216d1d898e16c9b5df61f1e22cc42c6
>
> However, what I could not find is a written offer to provide the source
> code of these binaries. Please note that this is required
> according to the terms of the GPLv2 section 3. Which means that your
> product violates my copyright.
>
> I assume that not complying part of the GPLv2 was an oversight, and I can
> easily forgive that.
>
> What do I insist is that you provide the full source code of both the "mpd"
> binary and the file "libwimp.so.1".
>
> Note that failure to provide the full source code of both files constitutes
> a serious copyright violation. Additionally, it will terminate your
> license according to GPLv2 section 4, rendering all of your products
> containing my copyrighted software illegal.
>
> I expect to receive the full source code and full GPL compliance within two
> seeks, that is until December 31st 2017.
>
> Regards,
> Max Kellermann
> --
> This message was sent to max.kellerm...@gmail.com in reference to Case #:
> 10707.
> Follow this link to view the status of your case and add additional
> comments:
> http://aurender.desk.com/customer/portal/private/cases/10707
>
> **Important Note on Email Sent to Multiple Recipients*
> If you send or reply to a message with multiple recipients, any responses
> to the thread may show up as part of the case history, even if those
> exchanges aren't directed to you. In essence, the owner of the original
> message also owns all communication associated with that case, regardless
> of who the subsequent senders and recipients are. Our suggestion is to make
> sure that all recipients are aware of this, and that the sending of
> sensitive information is avoided.
> [[a87d3cfaff061513126c4f7baf16c767cfda01e9-1103319561]]
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] Request for GPL source code of sMS-200_20170717-V0.4.0.zip

[Max Kellermann]

Dead sir or madam,

I downloaded
http://sotm-audio.com/eunhasu/firmware/arm/sMS-200_20170717-V0.4.0.zip
SHA-256=44dba25b28c1de06713a9a2ec8bb9cf22da16b4a5c53103c704c8bc4d940a226

This archive contains the Music Player Daemon, but no source code. Please
send me the full source code of that binary.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of your Aurender A10 product

[Max Kellermann]

On 2017/12/18 09:35, supp...@aurender.com wrote:
> http://www.aurender.com/page/download

I identified that this "mpd.tar.gz" is based on MPD commit
7e219c362cf8bca80f60a79b77d95a228ff8ffcb

 
https://github.com/MusicPlayerDaemon/MPD/commit/7e219c362cf8bca80f60a79b77d95a228ff8ffcb

This is a random git commit in the middle of MPD 0.17 development
(more than 6 years ago), and hundreds of later bug fixes are missing.
Yes, Aurender builds their premium product on something that's not
even close to alpha.

I have imported this "mpd.tar.gz" into our git repository, for
everybody to inspect:

 https://github.com/MusicPlayerDaemon/MPD/tree/auPlayer-6.08.11

This includes the (alleged) non-free "libwimp.so" BLOB, which Aurender
pretends to distribute under the GPLv2.  Can't wait to hear their
excuses for not being able to come up with its source code.

I fear that this will not end well for Aurender.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Request for GPL source code of your Aurender A10 product

[Max Kellermann]

It is trivial to see that source on your website does not match the binary
on my Aurender box.  I insist that you send me the matching source code of
that very binary.

Let's see if your engineers are able to provide the source code of
libwimp.so.1 with a free license. If not, we'll have serious problems.

On Mon, Dec 18, 2017 at 9:35 AM, <supp...@aurender.com> wrote:

> __
> Type your response ABOVE THIS LINE to reply
> ----------
> *Max Kellermann*
> *Subject:* Request for GPL source code of your Aurender A10 product
> --
> DEC 18, 2017  |  05:35PM KST
> *ericshim...@aurender.com <ericshim%2...@aurender.com>* replied:
>
> Hello Max Kellermann
>
> First of all thank you for choosing Aurender.
> For the MPD source, you can find it from our website download section.
> http://www.aurender.com/page/download
> You can find GPL code center link in the page.
>
> About other source, I will forward this information to our engineers.
> --
> DEC 17, 2017  |  10:15PM KST
> Original message
>
> * Max * wrote:
>
> Dead sir or madam,
>
> I have an Aurender A10, and it was shipped with a file "local.tar.gz",
> SHA-256
> 32413ec552b27e6d868ced17c7de2423cfd6eeb2b21f72b31196bb9c2e0e5425
>
> This file contains a copy of a software of which I own the copyright, that
> is "bin/mpd", SHA-256
> 83f46f0eefd78e9cf6afa56d4065688806a73e486a4ffb5b008bbbe72ed3e382
>
> This software has been linked with a library called "lib/libwimp.so.1"
> which is also contained in your USB stick, SHA-256
> 1f9b9a2fd3c06a2e920e0057bc6b5aa43216d1d898e16c9b5df61f1e22cc42c6
>
> However, what I could not find is a written offer to provide the source
> code of these binaries. Please note that this is required
> according to the terms of the GPLv2 section 3. Which means that your
> product violates my copyright.
>
> I assume that not complying part of the GPLv2 was an oversight, and I can
> easily forgive that.
>
> What do I insist is that you provide the full source code of both the "mpd"
> binary and the file "libwimp.so.1".
>
> Note that failure to provide the full source code of both files constitutes
> a serious copyright violation. Additionally, it will terminate your
> license according to GPLv2 section 4, rendering all of your products
> containing my copyrighted software illegal.
>
> I expect to receive the full source code and full GPL compliance within two
> seeks, that is until December 31st 2017.
>
> Regards,
> Max Kellermann
> --
> This message was sent to max.kellerm...@gmail.com in reference to Case #:
> 10707.
> Follow this link to view the status of your case and add additional
> comments:
> http://aurender.desk.com/customer/portal/private/cases/10707
>
> **Important Note on Email Sent to Multiple Recipients*
> If you send or reply to a message with multiple recipients, any responses
> to the thread may show up as part of the case history, even if those
> exchanges aren't directed to you. In essence, the owner of the original
> message also owns all communication associated with that case, regardless
> of who the subsequent senders and recipients are. Our suggestion is to make
> sure that all recipients are aware of this, and that the sending of
> sensitive information is avoided.
> [[a87d3cfaff061513126c4f7baf16c767cfda01e9-1103319561]]
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

[mpd-devel] Request for GPL source code of your Aurender A10 product

[Max Kellermann]

Dead sir or madam,

I have an Aurender A10, and it was shipped with a file "local.tar.gz",
SHA-256
32413ec552b27e6d868ced17c7de2423cfd6eeb2b21f72b31196bb9c2e0e5425

This file contains a copy of a software of which I own the copyright, that
is "bin/mpd", SHA-256
83f46f0eefd78e9cf6afa56d4065688806a73e486a4ffb5b008bbbe72ed3e382

This software has been linked with a library called "lib/libwimp.so.1"
which is also contained in your USB stick, SHA-256
1f9b9a2fd3c06a2e920e0057bc6b5aa43216d1d898e16c9b5df61f1e22cc42c6

However, what I could not find is a written offer to provide the source
code of these binaries.  Please note that this is required
according to the terms of the GPLv2 section 3.  Which means that your
product violates my copyright.

I assume that not complying part of the GPLv2 was an oversight, and I can
easily forgive that.

What do I insist is that you provide the full source code of both the "mpd"
binary and the file "libwimp.so.1".

Note that failure to provide the full source code of both files constitutes
a serious copyright violation.  Additionally, it will terminate your
license according to GPLv2 section 4, rendering all of your products
containing my copyrighted software illegal.

I expect to receive the full source code and full GPL compliance within two
seeks, that is until December 31st 2017.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] MPD distribution.

[Max Kellermann]

On 2017/11/27 15:25, RD <rdev...@gmail.com> wrote:
> Hello Mr. Kellermann,
> 
> I am contacting you in behave of audiokernel.org. (and page
> euphony-audio.com)  We offer MPD (Music Player Deamon) in our Euphony music
> management software.
> 
> I am sending you this mail, because our download provider CDN received a
> request from email address "m...@duempel.org" with Max Kellermann reqesting
> to remove image from their server, as we somehow violate GPL licensing
> rules of MPD.
> 
> We think we do not break any GPL rules, as we just offer installation
> services and propriatary management software without any modifications to
> orginal MPD code.
> Also we clearly state licensing terms to end user, and communicate to all
> users that he can download all playback components and use them without
> Euphony management software to their best.
> 
> Generally what we provide is a WEB based music library management system to
> be used with few playback options which can be choosen via web interface
> One of playback solutions is MPD. Other players include Roon, Squezebox and
> Network audio player.
> 
> Euphony music management system is not part of MPD, and it controls MPD
> over MPD network interface, so we did not implement, nor changed any
> additional code in MPD. Same situation is with other players we provide in
> our Euphony image.
> 
> Also we run Euphony on base of standard Arch Linux distribution, which is
> enhanced scheduling system to better control which tasks have priority.
> Both Arch Linux and extensions are not in anyway modified with us, we just
> provide it to users, in code which can be found on official distribution
> pages of Arch Linux.
> 
> Our propriatary management system makes use of MPD and other playback
> system very easy to use.  Our service consists of propriatary software
> (management system) and services which offers easy installation on
> hardware. (software comes preinstalled on SSD disk).
> 
> 
> We would be very happy if you can contact us via this email, so we can get
> more understadning of this situation.

Hi Robert,

thanks for replying.  I tried to contact you via email more than a
month ago (twice), but never got a reply.  I guess my email never
reached you (even though your mail server acknowledged receiving it),
so let's restart this process now.

This was my email:

On 2017/10/25 08:33, Max Kellermann <m...@duempel.org> wrote:
> I just downloaded from your website:
>
>  http://euphonyimage-798b.kxcdn.com/euphony20171019.img.gz
>  SHA256
>  d1b6d64887ad378e0bf7688d44b86159ccd4b3f34af1f4176e01c32166255a00
>
> I hereby request the source code of all GPL and LGPL licensed
> binaries contained therein.
>
> Your image does not contain an offer to provide the source code.
> Please note that this is required according to the terms of the
> GPLv2 section 3.
>
> Note that failure to provide the full source code constitutes a
> copyright violation.  Additionally, it will terminate your license
> according to GPLv2 section 4, rendering your product illegal.

And yes, you already did violate the GPL, as explained in my email.
This formality isn't too important for me, it's just a good indicator
that you didn't care about legal implications at all.  Probably
because you didn't know.

However what is important for me is the rest of your GPL obligations.

When you read up about your GPL obligations, don't overlook that
commercial projects have stricter requirements than free
distributions.

Regards,
Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Formal request for GPL source code of Eupony

[Max Kellermann]

Dead sir or madam,

a month has passed since my request for the source code.

I must hereby declare your license for the Music Player Daemon
*TERMINATED* according to GPLv2 section 4.  Therefore further
redistribution of your firmware (as a download or a hardware sold) is
an act of copyright violation.

I will ask for hosting provider to take down your illegal downloads.

My request for the source code however is not affected by this.  I
still insist on getting it from you.  I expect to receive it within
two weeks from now, that is until December 7th.  After that, I will
introduce a GPL enforcement lawyer to your case.

Regards,
Max Kellermann


On 2017/10/25 08:33, Max Kellermann <m...@duempel.org> wrote:
> Dead sir or madam,
> 
> I just downloaded from your website:
> 
>  http://euphonyimage-798b.kxcdn.com/euphony20171019.img.gz
>  SHA256 d1b6d64887ad378e0bf7688d44b86159ccd4b3f34af1f4176e01c32166255a00
> 
> I hereby request the source code of all GPL and LGPL licensed binaries
> contained therein.
> 
> Your image does not contain an offer to provide the source code.
> Please note that this is required according to the terms of the GPLv2
> section 3.
> 
> Note that failure to provide the full source code constitutes a
> copyright violation.  Additionally, it will terminate your license
> according to GPLv2 section 4, rendering your product illegal.
> 
> Regards,
> Max Kellermann
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Receive command from Named Pipe and treat it as a client PlayerCommand

[Max Kellermann]

On 2017/08/11 20:30, Kurt Van Dijck  wrote:
> Even more nitpicking:
> mkfifo testfifo
> echo hello world > testfifo
> ... wait ...
> cat testfifo
>   now echo has completed.

This has nothing to do with buffering or writes, because a write
hasn't happened at this point.  It doesn't block at write(), it blocks
at open().  It blocks until the "connection" has been established.
After that, the usual pipe buffering applies, and writes do NOT block
(until the pipe buffer is full).
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Receive command from Named Pipe and treat it as a client PlayerCommand

[Max Kellermann]

On 2017/08/11 13:54, Kurt Van Dijck  wrote:
> in order to successfully write() to a fifo, the read() must
> complete.

Nitpicking: that part is not true.  Linux has a pipe buffer as well,
which defaults to 64 kB (configurable).  Maybe other kernels don't
have one, but Linux does.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Receive command from Named Pipe and treat it as a client PlayerCommand

[Max Kellermann]

On 2017/08/11 13:45, ed mcmurray  wrote:
> On the MPD side I'm not so sure where in the code that I should create,
> bind, listen and accept connections, for the socket.

That code already exists.  Why do you believe a change to MPD is
necessary?

> I'm sure this should be more obvious, but any help would be appreciated.

Still nothing here is obvious to me.  I have no idea what you're
trying and why.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Receive command from Named Pipe and treat it as a client PlayerCommand

[Max Kellermann]

On 2017/08/10 17:35, ed mcmurray  wrote:
> From within the MPD application, I would like to access a Linux Named Pipe
> FIFO that has been created in a second application.  The second application
> would  place a STOP command into the Name Pipe, when appropriate.  I would
> like to insert code in MPD to then monitor this Named Pipe for the STOP
> command and act on the command as though it was sent from an mpd
> client.

But ... why?

You can already do that with sockets, which is the core idea of MPD.
Why pipes?  Pipes have serious disadvantages (such as being
unidirectional), but you did not describe any advantages of using them
instead of sockets.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] decoder/ffmpeg: add support for adx

[Max Kellermann]

On 2017/06/01 19:16, Jörg Raftopoulos  wrote:
> Add ffmpeg decoder support for *.adx files (Sega game console)

Your patch contains very strange Unicode characters instead of tabs.
git can't apply that.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Was this change reverted by accident?

[Max Kellermann]

On 2017/02/27 17:22, Eric Wollesen  wrote:
> It was merged, but then immediately it seems to have been reverted in this
> commit:
> 
> 021519f command/QueueCommands: eliminate duplicate code in
> handle_addid()

It was not reverted - look what happens after these lines, now that
the "return" is removed.

Hint: "git show -W 021519f" might be just enough context to understand
this commit.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] ReusableArray: fix build error on GCC7

[Max Kellermann]

On 2017/02/27 03:34, Ben Boeckel  wrote:
> GCC7 outputs the following error without this change:
> 
> src/util/ReusableArray.hxx:61:35: error: no matching function for call to 
> ???swap(size_t&, const size_t&)???
>std::swap(capacity, src.capacity);
> 
> which can be resolved by just using an rvalue-reference rather than a
> const rvalue-reference.

Merged into v0.20.x
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] input/alsa: prevent cpu hogging in nonblocking mode

[Max Kellermann]

On 2017/02/23 21:44, Joerg Raftopoulos  wrote:
> MPD's ALSA input plugin works since
> 791efc171a35848bb062aad0aee41220cd1f62ba in SND_PCM_NONBLOCK mode.
> According to ALSA documentation
> http://www.alsa-project.org/alsa-doc/alsa-lib/group___p_c_m.html#ga4c2c7bd26cf221268d59dc3bbeb9c048
> snd_pcm_readi does not wait in non-blocking mode.

I'm well aware of that, and that was the one and only goal of this
commit.

> This causes a loop, resulting in a high cpu load.

This needs further explanation.  Where's the loop?

Does this mean that the ALSA file descriptor becomes readable over and
over, and DispatchSockets() gets called again and again, but every
time, snd_pcm_readi() returns -EAGAIN?  If that is the case, then
we're seeing an ALSA bug.

Or do I miss something obvious?

> Patch adds wait with 500ms timeout. Thanks to kuikka for
> clarification.

This is illegal.  You must not block the I/O thread!  Whatever problem
your patch aims to fix, this is a bad solution.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] fix build on i686 (config.h import)

[Max Kellermann]

On 2017/02/13 13:16, Profpatsch  wrote:
> It doesn???t build on i686

That's what the other guy said as well, but what does that mean?

"It doesn't build" or "it doesn't work" are the worst problem
descriptions I can imagine.  No information.  I can't understand the
problem that way.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] sidplay plugin (libsidplayfp) load rom images

[Max Kellermann]

On 2017/01/06 21:03, Jörg Raftopoulos  wrote:
> Now without fstream as requested.

There is still no patch description (= commit message).

Did you ensure that your code compiles with the old libsidplay?  It
looks suspicious.

> +   buffer = new char[romSize];

Your code is not exception-safe, and can leak memory.  Better manage
this pointer with std::unique_ptr.

> +   fread(buffer, romSize, 1, rom);

Checks missing.  What if the file is smaller?  What if the file is
larger?  What if a read error occurs?

Also I suggest to use MPD's class FileReader.  Your code uses buffered
I/O, but that buffering is of no use; it only adds unnecessary
overhead.

One more problem with stdio: it is not thread-safe.  As in: leaks file
descriptors, because it doesn't set O_CLOEXEC.  There is a GNU
extension to set O_CLOEXEC, but your code doesn't use it, and anyway
it isn't portable.

> +FormatError(sidplay_domain,
> +"unable to load rom dump %s", path);

Instead of logging an error message, the error condition should be
returned to the caller, so the caller can decide what to do with it.
For example by throwing an exception.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] sidplay plugin (libsidplayfp) load rom images

[Max Kellermann]

On 2017/01/06 22:37, Jacob Thomas Errington  wrote:
> Shouldn't this be spelled "kernel" not "kernal"?

No, it's really "kernal" on C64.  I found this one suspicious, too,
and looked it up.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Fix for priority order bug if reordering in SetRandom()

[Max Kellermann]

On 2016/11/12 02:11, Eugene Baklanov  wrote:
> Resending the patch after I screwed up with git patch formatting.

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] sidplay plugin (libsidplayfp) load rom images

[Max Kellermann]

On 2017/01/03 10:55, Jörg Raftopoulos  wrote:
> Darn webmailer. Patch attached as a zip file.

But... what is it?  No description, no documentation.

Oh, and please don't use iostreams.  It's a bloated mess.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] sidplay plugin (libsidplayfp) load rom images

[Max Kellermann]

On 2017/01/03 00:32, Jörg Raftopoulos  wrote:
> 

No HTML, please.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/1] Fix for priority order bug if reordering in SetRandom().

[Max Kellermann]

On 2016/10/01 06:39, Eugene Baklanov  wrote:
> Fix for the problem where order with priorities gets out of whack in case it's
> reordered by SetRandom() while another song is currently playing.
> What happens is, if some song is already playing and you have set some
> priorities before switching on the random mode, and then turn the mode on, the
> original code swaps position of the first song in the order (i.e., the highest
> priority song) with current, so that current is 0 (which it should be). The
> problem is, the "original" first song then goes to the place "current" song 
> was
> after reordering, wherever that is, instead of going after the "current" song.
> This patch fixes the issue.
> Also the fix makes MoveOrder() public, because why shouldn't it be, anyway.  
> It
> certainly makes more sense than just having SwapOrders() public for some
> reason.

Which MPD version does this apply to?  "git am" is unable to apply
your patch to git master (which hasn't changed since you submitted
your patch).
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] doc: Initial sndio documentation

[Max Kellermann]

On 2016/06/22 18:42, Dimitris Papastamos  wrote:
> From 8fb1e4514752efb4ba42a1d8595c7651c159f456 Mon Sep 17 00:00:00 2001
> From: Dimitris Papastamos 
> Date: Wed, 22 Jun 2016 17:41:06 +0100
> Subject: [PATCH] doc: Initial sndio documentation

Merged
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Trying to set a tag to a song with mpd_song_feed

[Max Kellermann]

On 2016/06/22 13:00, Jörg Krause  wrote:
> I am using libmpdclient (version 2.10) to write a LuaJIT-based MPD
> client. I run into an issue when I am trying to add a comment to a
> radio station URI which I add to the queue. The comment is successfully
> feed to the song as a tag. However, after issueing the play command,
> the tag is gone.

As soon as MPD receives new tags from the stream, it replaces the old
tags.  It does not remember which tags have been sent by the client.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

[Max Kellermann]

On 2016/06/22 11:27, Dimitris Papastamos <s...@2f30.org> wrote:
> On Wed, Jun 22, 2016 at 11:21:02AM +0200, Max Kellermann wrote:
> > On 2016/06/22 11:10, Dimitris Papastamos <s...@2f30.org> wrote:
> > > Must have been an oversight when I looked at other plugin code.
> > > The patch below removes the timer usage.
> > 
> > Please rebase.  I have conflicts.
> 
> Oops, here it is.

Thanks, merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

[Max Kellermann]

On 2016/06/22 11:10, Dimitris Papastamos  wrote:
> Must have been an oversight when I looked at other plugin code.
> The patch below removes the timer usage.

Please rebase.  I have conflicts.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] sndio: Add option to select output device

[Max Kellermann]

On 2016/06/22 10:57, Dimitris Papastamos  wrote:
> >From 43cb9a089363301636317446765f7ca689d6b8c5 Mon Sep 17 00:00:00 2001
> From: sin 
> Date: Wed, 22 Jun 2016 09:41:54 +0100
> Subject: [PATCH] sndio: Add option to select output device

Merged.

I just noticed that you're using a Timer in your plugin code.  Why?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] net/Resolver: correct includes for gettaddrinfo(3)

[Max Kellermann]

Both patches merged, thanks.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] mpd creates two ALBUMARTIST entries

[Max Kellermann]

On 2016/04/19 17:51, Julien Cubizolles  wrote:
> I think mpd shouldn't create two ALBUMARTIST entries in its cache for
> the same file.

And I think you shouldn't create files with two ALBUMARTIST entries.

Shit in, shit out.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] mpd creates two ALBUMARTIST entries

[Max Kellermann]

On 2016/04/19 17:35, Julien Cubizolles  wrote:
> I noticed that music files metadata contain both "ALBUM ARTIST" and
> "ALBUMARTIST" fields. When both are set, mpd creates ALBUMARTIST fields
> in the tag_cache file. That's not a problem for mpd itself but emms gets
> confused and emms-cache-set-from-mpd-all creates entries without any
> artist field, which makes them useless for searching.

... and your point is?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] mpd takes 1.5s to execute previous/next while playing (regression)

[Max Kellermann]

On 2016/04/16 00:58, Calimero  wrote:
> I believe I have discovered an regression where mpd's response times on the 
> control socket got slow while playing.
> `mpc next`, `mpc previous` or `telnet localhost 6600` and typing next or 
> previous can take a whole second and a half before mpd responds with OK.

Intended change.  Previously, "next" and "previous" were asynchronous
- MPD would reply "OK" immediately, even if playback actually failed.
Now those commands wait for completion, and give a useful response.

If you still believe that's a regression, explain why.

> It looks as if mpd is now only polling for commands every second and
> a half, instead of reacting immediately.

Wrong.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Pull request to support TAK files

[Max Kellermann]

On 2016/02/13 06:15, Chris Spiegel  wrote:
> In my git repository:
> 
> https://github.com/cspiegel/mpd
> 
> I've created a branch called tak which adds support for the TAK file
> format (http://www.thbeck.de/Tak/Tak.html) to the FFmpeg plugin.  FFmpeg
> already has TAK support, so it was a trivial matter of adding the
> extension to the list.

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] idle stored_playlist does not notice filesystem changes

[Max Kellermann]

On 2016/02/12 18:34, Gavin Kistner  wrote:
> Using the "idle stored_playlist" command works fine when MPD is used to 
> modify a playlist file. However, idle does not notice if the playlist file is 
> edited by a non-MPD source.
> 
> Is there a .conf setting (similar to "auto_update" for the music_directory) 
> that can allow MPD to notice when a playlist file is touched? If there is no 
> such setting, is there a good reason not to add one?

Editing playlist files behind MPD's back is not a supported thing, and
therefore MPD doesn't even try to watch those files.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] configure.ac: check if libatomic is needed

[Max Kellermann]

On 2016/02/07 22:11, Thomas Petazzoni  
wrote:
> The mpd source code uses the C++11  functionality, which
> internally is implemented using the __atomic_*() gcc built-ins. On
> certain architectures, the __atomic_*() built-ins are implemented in
> the libatomic library that comes with the rest of the gcc runtime. Due
> to this, code using  might need to link against libatomic,
> otherwise one hits build issues such as:

I would expect the C++ compiler to figure out the link-time
dependencies of its own standard library.  Why isn't that happening on
SPARC?  This looks like a toolchain bug, doesn't it?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] mpd hangs, kill -9 necessary

[Max Kellermann]

On 2015/12/27 18:42, richard lucassen  wrote:
> Hello list,
> 
> I run Debian Wheezy with native mpd-0.16.7-2. This has worked fine for
> a few years as long as I do not choose a radiostream that is broken. In that 
> case
> I need to -SIGKILL mpd. This afternoon I compiled a
> vanilla 0.19.12 and the reproducible problem is still there:

This is the wrong place to report bugs.  This list is for developers only.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 2/2] docs: add vlc and mpv to the list of example applications

[Max Kellermann]

On 2015/10/27 03:40, Ben Boeckel  wrote:
> These are other popular clients. In particular, VLC is available on
> mobile devices.

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/2] httpd: add a parameter for playing silence

[Max Kellermann]

On 2015/12/15 21:58, Ben Boeckel  wrote:
> Hmm. How about "play_silence_when_paused". Too long? "_on_pause"? No
> "play_"?

Maybe just "silence_paused"?  That would give a hint on what it's
about.

It's hard to find the perfect name, but "play_silence" sounds bad to
me because it's not about regular "playback".
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/2] httpd: add a parameter for playing silence

[Max Kellermann]

On 2015/10/27 03:40, Ben Boeckel  wrote:
> Some clients act weird in the face of silence and buffer it rather thay
> "playing" it. This causes severe lag when the stream is unpaused.

There are other clients which time out when not getting any data.
(All audio streaming software sucks (and that includes MPD).  No
matter what you do, at least one program breaks.)

Though I find it surprising to buffer silence.  I don't want to
support software that is so obviously broken.  A streaming client
should not care if it's silence or music that's being received - just
play what you get, damnit!

But I understand your desire to control MPD's behavior when the user
presses pause.  Since HTTP streaming is all but a well-defined
protocol, there is no right and no wrong.

> +  
> +
> +  play_silence
> +  PS
> +
> +
> +  If true, silence will be played
> +  while the stream is paused.
> +
> +  

I don't like the option's name, because it's hard to understand what
it does.

Your documentation describes only what it does when configured "yes",
which is the old behavior - but it does not describe the new behavior
at all!  What does it do when "no" is configured?  And what's the
default?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] MPD fails to build if configured with "--disable-inotify"

[Max Kellermann]

On 2015/11/02 10:07, Andreas Mair  wrote:
> Hello,
> 
> the subject says it all.

http://bugs.musicpd.org/
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] find track "1" not working as expected

[Max Kellermann]

On 2015/10/21 08:58, Andreas Mair  wrote:
> Hi Max,
> 
> I've now created a pull request: Filter out this extra data and
> leading zeroes in "track" and "disc" tags.

Merged with a few minor corrections.

By the way, please don't send GitHub pull requests.  Those are very
cumbersome for me to use.  Just post the git:// URL and the branch
name.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Symmetic upsampling support (feature request)

[Max Kellermann]

On 2015/10/19 20:05, Fulco Giovanni  wrote:
> Depending on the quality of the DAC, to upsample the signal via software
> might lead to better results.
> About symmetrical upsampling, the aim is to reduce the computational effort
> (assuming this might really be the case).

It's not.

I wonder why you call it "symmetrical upsampling".  Where's the
symmetry?

> My DACs are not really super high-end, and it seems to me the sound is
> better if I upsample in software, especially with mpd with sox, especially
> when using integer multipliers.

"Might" and "seems" are not good words to argue for merging such a
feature.  I don't buy audiophile voodoo.  So thanks for offering your
code, but I'm not interested (until there is credible proof for
improved sound quality).

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Digital filters handling in MPD protocol

[Max Kellermann]

On 2015/10/16 01:35, Aleksander Trofimowicz  wrote:
> 1. there is a room and willingness to accept such proposal

It is impossible to judge your future proposal until one knows the
proposal.  I, for one, have no idea what this is about.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Digital filters handling in MPD protocol

[Max Kellermann]

On 2015/10/16 11:29, Aleksander Trofimowicz  wrote:
> My aim is to create facilities for a basic filter management: list all
> available filters (or filter sets) and select the current one. I think
> it makes sense to include these to MPD protocol as digital filters
> affect how sound is perceived by users no less than volume levels
> (which are handled by MPD protocol already). And such extensions will
> enable music players to simplify user experience.

MPD has an infrastructure to write filter plugins, and these can be
configured in mpd.conf.  However, the filter plugins you're thinking
of don't exist in MPD currently.

If I understand you correctly, what you're about to propose is NOT
writing new filter plugins, but provide a protocol interface to
configure/select filter plugins at runtime?

I can't comprehend that proposal.  Your reason for this dynamic filter
interface is that you wish to have those digital filters, but your
proposal will NOT make those filters available in MPD.  All it does is
make existing filters dynamic at runtime.  There is a mismatch between
your proposal and your stated reason.

If you want those filters, write filter plugins.  I understood that
you want those filters, even though I never felt I need them.  That's
ok - write a plugin, send it to me, and I'll merge it.

What you did NOT say is why you want to make them available on the MPD
protocol.  Which, however, is the only thing you were going to
implement.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Document API changes between each libmpdclient version

[Max Kellermann]

On 2015/08/27 13:27, Kim Tore Jensen  wrote:
> Hi,
> 
> Attached is a patch which documents API changes between libmpdclient versions,
> making it easier to add client support for old versions of
> libmpdclient.

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] CueParser.cxx: Append pregap to previous track

[Max Kellermann]

On 2015/08/25 12:11, Will Tiffany  wrote:
> Only ignore indexes after first nonzero, preserving pregaps but
> appending them to the previous track instead of prepending to the
> current. The first index of the first track is used for the start time
> regardless of its number. Unneeded bool last_updated removed.

Merged
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] MPD port to Haiku

[Max Kellermann]

On 2015/09/17 22:18, François Revol  wrote:
> Here is an updated patchset for my MPD port to Haiku.
> 
> First 4 patches fix the build.
> 
> Next 5 patches add native resources to the binary.
> 
> Last patch adds a native audio output, which mostly works
> for what I've tested, including showing a GUI notification on SendTag(),
> as in:
> http://revolf.free.fr/beos/shots/shot_haiku_mpd_icon_try1_002.png

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] State file lost on brutal shutdown, needs atomic writes

[Max Kellermann]

On 2015/08/28 19:28, Calimero calimerotek...@free.fr wrote:
 And with the rename() syscall, we replace the old file atomically
 with the new one.

Look what git master is doing.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] CueParser.cxx: ignore INDEX after first per track

[Max Kellermann]

On 2015/08/23 04:19, Will Tiffany will.tiff...@gmail.com wrote:
 Use the first INDEX in each TRACK section, instead of the last, for the
 start time. This preserves the original CD layout (including gaps
 between tracks), and avoids skipping sections of songs in more exotic
 cuesheets (eg musical suite tracks).

Merged.

I thought about the same change, but was worrying that always playing
the pregap might bother other users.  I have a few test CUE sheets
here, and their pregap contains mostly audio data from the preceding
track.

But now I've merged your patch, and we'll see how this turns out.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

[Max Kellermann]

On 2015/08/19 22:26, Kim Tore Jensen k...@incendio.no wrote:
 I propose to add support for the ArtistSort and AlbumArtistSort tags in
 libmpdclient; see attached patch.

These were left out of libmpdclient intentionally, because these tags
appear to make sense only on the server side, for sorting.  Adding
them increases memory usage.  What is your reason to add it?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

[Max Kellermann]

On 2015/08/20 11:36, Kim Tore Jensen k...@incendio.no wrote:
 These tags are much needed in order to sort songs correctly at the client 
 side,
 after having retrieved them from MPD using either a search or retrieving the 
 library.

I understand.  If there was a way to sort search results server-side,
would you still need this feature?

We do need server-side sorting for window to be really useful.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Add support for ArtistSort and AlbumArtistSort tags

[Max Kellermann]

On 2015/08/20 13:21, Kim Tore Jensen k...@incendio.no wrote:
 Actually, yes. It'd be really useful to be able to manipulate search results
 locally in the client. For example: search within a search result with new 
 sort
 parameters; re-sort a search result with new sort order; regular expression
 based searches.

Ok, please resubmit a fixed patch and I'll merge it.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] find track 1 not working as expected

[Max Kellermann]

On 2015/08/12 13:16, Andreas Mair amair@gmail.com wrote:
 Hi Max,
 
 OK, I see. I've changed the patch to cover your suggestion.

Commit message is missing.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] CurlInputPlugin : broken connectionsometimes --Solved patch

[Max Kellermann]

On 2015/08/11 16:19, Ben Boeckel maths...@gmail.com wrote:
 Maybe Max won't spell it out, but instead of attaching the patch, please
 use:
 
 git format-patch 34db35c36d8bb32b2c41640432474f52889cce08..

No, this is not a problem that can be solved with tools.  The problem
is that there is too little explanation, and I don't understand what
this is about and what this patch improves and why it is necessary.

Retrying HTTP requests is not something that sounds like a good idea
to me, so this change must be justified carefully.  In absence of a
good justification, I don't merge it.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] MPC: command: let listall print songs only

[Max Kellermann]

On 2015/07/28 12:09, Thorsten Wißmann e...@thorsten-wissmann.de wrote:
 Formerly, the output of
 
 mpc listall --format ''
 
 included directory paths and not only songs. Attached you can find the
 patch 0001-command-let-listall-print-songs-only.patch which limits the
 output songs (as it is already described by mpc's man page).
 
 You can apply the patch by piping it through git am. Feel free to adjust
 the commit message :-)

Merged
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 0/2] Some improvements for MPC display format

[Max Kellermann]

On 2015/08/09 17:23, Dmitri Vereshchagin dmitri.vereshcha...@gmail.com wrote:
 Hello,
 
 These patches add support for escape characters in format strings and setting
 format string through MPC_FORMAT environment variable.

Merged
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] CurlInputPlugin : broken connection sometimes --Solved patch

[Max Kellermann]

On 2015/08/07 05:18, Alex maon...@qq.com wrote:
 Hi Max,
 
 I am so sorry that it's first time at here, so I don't know how to do that 
 correctly.
 
 My patch was creating from mad-git, the reversion is 
 34db35c36d8bb32b2c41640432474f52889cce08.

I don't understand that.  So you're not the author/copyright holder of
that code?

 If you need any information more, please let me know, sorry again.

Of course I need more information, because the commit message is still
missing, which is what I asked for.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] CurlInputPlugin : broken connectionsometimes --Solved patch

[Max Kellermann]

On 2015/08/07 08:50, Alex maon...@qq.com wrote:
 On 2015/08/07 05:18, Alex maon...@qq.com wrote:
  Hi Max,
  
  I am so sorry that it's first time at here, so I don't know how to do that 
  correctly.
  
  My patch was creating from mad-git, the reversion is 
  34db35c36d8bb32b2c41640432474f52889cce08.
 
 I don't understand that.  So you're not the author/copyright holder of
 that code?
 
 Sure, I am the author of that patch.

But what does this have to do with mad-git?

 OK, the commit message is ' Add retry to CurlInputPlugin to solve issue that 
 connection broken sometimes'

Not enough.

I feel you are wasting my time, because I keep on spending time to
reply to your emails, but this isn't going anywhere.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] CurlInputPlugin : broken connection sometimes -- Solved patch

[Max Kellermann]

On 2015/08/06 11:31, ?? maon...@qq.com wrote:
 Hi All,
 
 Attached is for solving this issue which I was discussing at my last email:
 http://mailman.blarg.de/pipermail/mpd-devel/2015-July/000375.html
 
 
 It seems work fine after I test, and anyone helps me to double check? Thanks.
 
 
 And any feedbacks? Thanks again.

Commit message is missing completely.  I can't do review without
exaplantion in commit message.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] mpd.service: Set the Documentation option

[Max Kellermann]

On 2015/07/17 19:55, Wieland Hoffmann themi...@gmail.com wrote:
 This makes references to mpd(1) and mpd(5) appear in systemd status output.

Merged.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] find track 1 not working as expected

[Max Kellermann]

On 2015/06/28 08:40, Andreas Mair amair@gmail.com wrote:
 I've taken a look at the MPD sources and I think the problem is, that
 MPD tries an exact *string* match. If I use ... find 01/10 it works,
 but I think that's not ideal to work like this because one has to know
 (1)  how many songs an album has and (2) if the number of total tracks
 is stored and (3) if leading zeros are used.

Actually, MPD does not expect the track tag to have something other
than the track number.  The problem is that some tag specifications
(such as ID3) allow the total number of tracks appended to the track
tag.

What MPD should do is filter out this extra data.  And filter out
leading zeroes.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 2/6] tag: Ape/Riff/Aiff/Id3 now use an InputStream

[Max Kellermann]

On 2015/06/05 16:27, Thomas Guillem tho...@gllm.fr wrote:
 This allow to use these scanners for remote InputStream like SMB and
 NFS.

Fails to compile:

test/dump_rva2.cxx: In function 'int main(int, char**)':
dump_rva2.cxx:60:62: error: invalid initialization of non-const reference of 
type 'InputStream' from an rvalue of type 'Path' 
  struct id3_tag *tag = tag_id3_load(Path::FromFS(path), error);
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/6] InputStream: add ReadFull method

[Max Kellermann]

On 2015/06/05 16:27, Thomas Guillem tho...@gllm.fr wrote:
 Convenient method that behave differently than Read, and that will be used by
 tag scanners.
 
 This method will return in case of error, if the whole data is read or is EOF
 is reached.

Merged.  Sorry for being so late.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Emmit a warning if the OutputThread fails to get realtime scheduling

[Max Kellermann]

On 2015/06/18 12:02, Christian Halaszovich chalaszov...@gmail.com wrote:
 This only applies to linux systems. Here, sched_setscheduler() is
 called to get realtime scheduling. With this patch, the return value
 of this function is now checked and a warning and an error message are
 generated if it failed.

Indentation is broken in your code.  Broken as in: does not exist.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/2] SetThreadRealtime() now reports if getting realtime scheduling was successful. (Only meaningful on Linux systems.)

[Max Kellermann]

On 2015/06/17 13:34, Christian Halaszovich chalaszov...@gmail.com wrote:
 Patch 1/2. Check the return value of sched_setscheduler() in
 SetThreadRealtime. Report to the caller, if we were successful. To this end
 SetThreadRealtime now returns false, if ached_setschedluer failed or true
 on all other cases. On non-linux systems SetThreadRealtime does not do
 anything and will always return true.

If you return failure, it should also describe why, for example by
filling out an Error object.

 + * return value: true on success

Misformatted.  Should use doxygen syntax.

 + bool success = true;

Why this variable?

  #ifdef __linux__
   struct sched_param sched_param;
   sched_param.sched_priority = 50;
 @@ -94,8 +96,9 @@ SetThreadRealtime()
   policy |= SCHED_RESET_ON_FORK;
  #endif
 
 - sched_setscheduler(0, policy, sched_param);
 + success = 0==sched_setscheduler(0, policy, sched_param);

 return sched_setscheduler(...) == 0;

  #endif
 + return success; // on non-linux machines we will always pretend it worked

 #else
 return true;
 #endif
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Add Elapsed time in mpc???

[Max Kellermann]

On 2015/06/12 09:29, salorium ??? salor...@hotmail.fr wrote:
 Hello,
 i want a git account for add elapsed time on mpc
[..]
 Elapsed time:
 https://github.com/salorium/mpc

But.. you already have a mpc git repository, why do you want another
one?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] db/update/ExcludeList: implement with std::regex

[Max Kellermann]

On 2015/05/22 09:04, Thomas Guillem tho...@gllm.fr wrote:
 ---
 New version that use std::regex instead of regex.h.

That is an incompatible change, and will break everybody's .mpdignore
files!

___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [Patch] Least unambiguous commands.

[Max Kellermann]

On 2014/11/12 15:19, Rory McNamara pink.banana.f...@gmail.com wrote:
 Good catch, I think I have them all now.

Merged with a few more optimizations.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Add Elapsed time in mpc

[Max Kellermann]

On 2015/05/27 22:08, salorium ¢¾ salor...@hotmail.fr wrote:
 SSH public key(s) (as attachment or URL, do not copy and paste) : 
 http://salorium.com/id_rsa.pubElapsed time :

ERROR 404: Not Found.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] storage/nfs: fix deadlock when connecting

[Max Kellermann]

On 2015/05/09 15:59, Thomas Guillem tho...@gllm.fr wrote:
 The Connect method can be called between Schedule and lock. In that case, when
 locked, the state is already set to CONNECTING of READY and the condition 
 won't
 be signaled anymore.

Good catch.  Merged to v0.19.x
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Workaround: open() ignores 'mode' with O_TMPFILE

[Max Kellermann]

On 2015/05/21 09:02, Yclept Nemo orbisvi...@gmail.com wrote:
  And how do you know the bug is the same on the build machine as on the
  machine running MPD?
 
 
 Hmm, I didn't consider this. The problem is not that the build machine
 suffers the bug while distribution machines don't, but vice verse. First
 scenario, mpd applies unnecessary but harmless fchmod, second scenario my
 patch fails to fix mpd. Can you suggest a better approach?

What you described are two ways to approach this problem:

1) Always do fchmod() (but with a big fat code comment!  And only if
   building with glibc)

2) do nothing, and if users complain, tell them to upgrade their buggy
   C library.  That's not our bug, after all!

I always prefer (2).  MPD uses so many libraries, and if I would add
workarounds for all old versions of all libraries, MPD would be a huge
mess.  Many years ago, I decided I wouldn't add any workarounds for
library bugs, and it turned out bugs really got fixed in those
libraries, and eventually users upgraded their libraries!  That made
such problems go away.

Max
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] Workaround: open() ignores 'mode' with O_TMPFILE

[Max Kellermann]

On 2015/05/21 09:08, Yclept Nemo orbisvi...@gmail.com wrote:
 OK, the test case should be moved from configure.ac into the constructor of
 FileDescriptor.

If you do this test every time a FileDescriptor gets constructed,
what's the advantage of testing it in the first place?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 1/6] InputStream: add ReadFull method

[Max Kellermann]

On 2015/05/21 23:43, Thomas Guillem tho...@gllm.fr wrote:
 Convenient method that behave differently than Read, and that will be used by
 tag scanners.
 
 This method will return in case of error, if the whole data is read or is EOF
 is reached.

But how will the caller know that an error has occurred?
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 2/2] TagStream: continue to scan if a plugin scanned a duration

[Max Kellermann]

On 2015/05/03 16:36, Thomas Guillem tho...@gllm.fr wrote:
 It happens when using mad and ffmpeg. The mad plugin will parse only the
 duration and ScanStream will return true. Therefore, ffmpeg plugin won't be
 used and no tags will be scanned.

This would add a lot of overhead.  What is the reason you want to
invoke multiple plugins for one file?  Your email doesn't explain
that.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH 2/2] TagStream: continue to scan if a plugin scanned a duration

[Max Kellermann]

On 2015/05/04 15:55, Thomas Guillem tho...@gllm.fr wrote:
 I use mpd on android with libnfs (see
 https://github.com/tguillem/mpd/commits/android-2), therefore id3 is not
 available to scan files (because it uses a fd).

Then change the ID3 code to use the stream API.
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] Can't control volume during SACD playback

[Max Kellermann]

On 2015/02/15 23:46, pisymbol . pisym...@gmail.com wrote:
 When using 'mixer_type=software' in my mpd.conf file, volume can not
 be controlled during DSF and SACD ISO playback (ISO support is via
 Maxim Anisiutkin's experimental plugin).

First of all, this mailing list is for developers, not for user
support.  Second: this mailing list is about mainline MPD, not about
some fork.  If you need assistance with a MPD fork, contact its
author.

___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel

Re: [mpd-devel] [PATCH] util: clarify that the error is from mpd

[Max Kellermann]

On 2015/02/08 02:39, Ben Boeckel maths...@gmail.com wrote:
 When mpc prints out 'error: ...', it is ambiguous where it came from.
 When the error comes from the mpd server, the user might be confused by
 something like:

Merged
___
mpd-devel mailing list
mpd-devel@musicpd.org
http://mailman.blarg.de/listinfo/mpd-devel