Review Board 1.0 beta 1 and RBTools 0.2 beta 1 released
Hey everyone, We've just put out a release of Review Board 1.0 beta 1, and our new RBTools 0.2 beta 1. I'm exhausted, so I'm just going to point everyone to the news. http://www.review-board.org/news/2009/03/29/review-board-10-beta-1/ http://www.review-board.org/news/2009/03/29/announcing-rbtools-02-beta-1/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 beta 1 and RBTools 0.2 beta 1 released
On Sun, Mar 29, 2009 at 11:01 AM, Christian Hammond chip...@chipx86.com wrote: Hey everyone, We've just put out a release of Review Board 1.0 beta 1, and our new RBTools 0.2 beta 1. I'm exhausted, so I'm just going to point everyone to the news. Great work! Thank you:) -- Łukasz Jernaś just ignore the smoke and smile - apc --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review Board 1.0 beta 1 and RBTools 0.2 beta 1 released
hi～ I want to ask a question that how to make the setting to let the reviewboard to support the chinese charater input? thanks. 2009-03-29 go2cxg 发件人： Christian Hammond 发送时间： 2009-03-29 17:01:57 收件人： reviewboard 抄送： 主题： Review Board 1.0 beta 1 and RBTools 0.2 beta 1 released Hey everyone, We've just put out a release of Review Board 1.0 beta 1, and our new RBTools 0.2 beta 1. I'm exhausted, so I'm just going to point everyone to the news. http://www.review-board.org/news/2009/03/29/review-board-10-beta-1/ http://www.review-board.org/news/2009/03/29/announcing-rbtools-02-beta-1/ Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review and Windows users
On Sat, Mar 28, 2009 at 22:53, Christian Hammond chip...@chipx86.com wrote: We would love this too, and we're hoping to get some student proposals from Summer of Code that would begin adding better integration on Windows (namely in IDEs, but some of this would likely require better hooks for post-review in Windows). In my opinion, the first Windows integration work should be integration with Explorer: it is ubiquitous, so it is the best bang for buck. It's possible that now, with post-review existing inside the rbtools package, we could add a flag for graphical output that would, using some standard toolkit, notify people of errors or successes, and then when installed on Windows it would register entries for hooking post-review up to the context menu. It probably wouldn't be a ton of work. The advantage of this is that it keeps the code in the same place, and it's possible to generate setup.exe files for a Python package. Sure. Having post-review packaged separately is certainly a step in the right direction. If you could file a feature request for this, it will help us track it. http://code.google.com/p/reviewboard/issues/detail?id=998 Cheers. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
SQL Server support?
Hi folks, Any plans to support SQL Server? TIA Mike --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: post-review and Windows users
David, It is pretty simple to add a context menu item that will launch a command. The attached registry file will add a right-click menu item for folders in windows explorer that will launch a command window and run post-review selected folder. This obviously has several limitations as it is just for folders and is only useful for creating new reviews, not updating existing ones. I have to say this is not something I've used, just something that came to mind when I saw your post. The attached registry file is written on the assumption that post-review is in the path. -Manny On Sun, Mar 29, 2009 at 11:01 AM, David Allouche david.allou...@gmail.comwrote: On Sat, Mar 28, 2009 at 22:53, Christian Hammond chip...@chipx86.com wrote: We would love this too, and we're hoping to get some student proposals from Summer of Code that would begin adding better integration on Windows (namely in IDEs, but some of this would likely require better hooks for post-review in Windows). In my opinion, the first Windows integration work should be integration with Explorer: it is ubiquitous, so it is the best bang for buck. It's possible that now, with post-review existing inside the rbtools package, we could add a flag for graphical output that would, using some standard toolkit, notify people of errors or successes, and then when installed on Windows it would register entries for hooking post-review up to the context menu. It probably wouldn't be a ton of work. The advantage of this is that it keeps the code in the same place, and it's possible to generate setup.exe files for a Python package. Sure. Having post-review packaged separately is certainly a step in the right direction. If you could file a feature request for this, it will help us track it. http://code.google.com/p/reviewboard/issues/detail?id=998 Cheers. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~--- pr.reg Description: Binary data
Re: Problem using post-review when parent_diff has deleted files
I think I have reduced this to a much simpler explanation in the following new issue, if anybody is interested: http://code.google.com/p/reviewboard/issues/detail?id=999 Conclusion: either --parent is slightly broken in how the server processes it, or I'm using it wrong in the first place. If I'm using it wrong, either there's an option I'm missing or I need to add one (thinking --gitsvnparent) if I want to post reviews against SVN branches using git-svn. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Unable to register new account at http://reviews.review-board.org/account/register/
Since your contribution policy requires that all proposed patches go to the Reviewboard instance, I decided to try to register an account. But whenever I visit... http://reviews.review-board.org/account/register/ ...I am simply forwarded back to... http://reviews.review-board.org/account/login/ Is anybody else having this problem? Thanks, Sandy --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to register new account at http://reviews.review-board.org/account/register/
This bit from the Beta 1 Release Notes seems suspect: Added support for disabling user registration. This provides a checkbox in the General Settings page for disabling user registration. This only takes effect when using standard authentication, and will hide the Register link and redirect requests made to /account/ register/ to the /account/login/ page instead. On Mar 29, 11:32 am, Sandy Armstrong sanfordarmstr...@gmail.com wrote: Since your contribution policy requires that all proposed patches go to the Reviewboard instance, I decided to try to register an account. But whenever I visit... http://reviews.review-board.org/account/register/ ...I am simply forwarded back to... http://reviews.review-board.org/account/login/ Is anybody else having this problem? Thanks, Sandy --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to register new account at http://reviews.review-board.org/account/register/
Looks like there's a bug where on an existing install, the Enable registration checkbox is checked, but one of our calls is failing until you save the General Settings page once. Then it works. I'll fix that in SVN. In the meantime, I've re-saved and you should be able to register now. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.review-board.org VMware, Inc. - http://www.vmware.com On Sun, Mar 29, 2009 at 11:32 AM, Sandy Armstrong sanfordarmstr...@gmail.com wrote: Since your contribution policy requires that all proposed patches go to the Reviewboard instance, I decided to try to register an account. But whenever I visit... http://reviews.review-board.org/account/register/ ...I am simply forwarded back to... http://reviews.review-board.org/account/login/ Is anybody else having this problem? Thanks, Sandy --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Unable to register new account at http://reviews.review-board.org/account/register/
Thank you, it's working now and I was able to post a review request. :-) Sandy On Mar 29, 11:35 am, Christian Hammond chip...@chipx86.com wrote: Looks like there's a bug where on an existing install, the Enable registration checkbox is checked, but one of our calls is failing until you save the General Settings page once. Then it works. I'll fix that in SVN. In the meantime, I've re-saved and you should be able to register now. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Sun, Mar 29, 2009 at 11:32 AM, Sandy Armstrong sanfordarmstr...@gmail.com wrote: Since your contribution policy requires that all proposed patches go to the Reviewboard instance, I decided to try to register an account. But whenever I visit... http://reviews.review-board.org/account/register/ ...I am simply forwarded back to... http://reviews.review-board.org/account/login/ Is anybody else having this problem? Thanks, Sandy --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Bazaar configuration
The way we have it set up here is that the repository configured in Review Board is the URL that contains the .bzr directory. In your case, this looks like probably http://a.org/~lead/projects/my_proj_mainline Now if you're diffing against that directory directly, you'd use '/' as your base diff path. Two notes: * the Bazaar code that Ben wrote works a lot better if you have the bzr-diff-revid plugin installed. By default, 'bzr diff' doesn't really give enough information in the diff header to accurately identify that original version. The bzr-diff-revid plugin fixes that. You can install it by cd'ing into your bazaar plugins directory (~/.bazaar/ plugins on UNIX or ~/Application Data\bazaar\2.0\plugins on Windows) and doing 'bzr co lp:bzr-diff-revid diff_revid'. * If you have a branch of my_proj_mainline on a developer box and you want to create a diff of the local commits since you last pushed up to the main branch, you can do 'bzr diff -r submit:'. (It'll work the way you're doing it, too, obviously, but the '-r submit:' method doesn't require two different branches. If you still have problems, maybe you can give me a stack trace or something. Or at least some better description of the problems you're seeing. Thanks, Michael P. On Mar 28, 8:12 pm, Prabhu Ramachandran pra...@aero.iitb.ac.in wrote: Hi Christian, On 03/29/09 02:24, Christian Hammond wrote: Would you mind sharing your configuration (or at least a representation of it) and how you manage updates to the repository, etc? Something we could use as a basis for docs. Sure, it was pretty simple. Here is perhaps a rambling overview of how I use it. I am not sure this is optimal. I hope it helps. cheers, prabhu Development with BZR -- Bazaar is a DVCS. Imagine a setup where there are several developers working on a common project. Each developer maintains an independent branch on which they develop whatever feature they want. They then copy (via rsync/scp or make a symbolic link) their repositories over to their web page, say ``http://a.org/~developer/projects/my_proj`` One of the developers (the lead say) maintains a mainline or official branch which is also exposed on his web page say ``http://a.org/~lead/projects/my_proj_mainline`` Each developer maintains an up-to-date copy of mainline on their machine. Usually this is achieved with a pull like so:: cd my_proj_mainline bzr pullhttp://a.org/~lead/projects/my_proj_mainline Now when the developer is happy with a branch and wants to commit to the mainline they make a diff between the mainline and their branch like so:: cd my_proj bzr diff --old ../my_proj_mainline cool_new_feature.diff Upload this patch to the Review Board site. Setting up Review Board First make sure you are using a recent enough version of bzr. 1.12 works fine with review board's bzr scmtool. Add a new repository as follows: 1. Set the Name of the project, ``my_proj`` in this case. 2. Set the mainline project url to the repository as: ``http://a.org/~lead/projects/my_proj_mainline`` 3. Set the tool to Bazaar. 4. Make any other settings and add the new repository. You're all set. Using review board --- This is pretty standard. Just login, create a new review request, upload your diff ``cool_new_feature.diff``, and set the base directory to ``/`` (which works in my case). Fill in the necessary fields and you should be set for a review. Once the reviewers have approved the diff, someone (the lead usually) applies the diff to mainline and others update their branches and pull from mainline on their official copy. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: can't create comments, javascript error?
same with IE7 --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: can't create comments, javascript error?
phew, good. thank you!
I appreciate your efforts!
On Mar 30, 12:13 am, Christian Hammond chip...@chipx86.com wrote:
Huh, I'm actually seeing this too on one of my installs. I'm looking into it
and will get back to you.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Mar 29, 2009 at 9:11 PM, Martin mkoeb...@gmail.com wrote:
the error points into the js code:
I added [line 361:] which firefox tells me where the error occurs.
/*
* Shows the comment dialog.
*/
showCommentDlg: function() {
var self = this;
if (gCommentDlg == null) {
gCommentDlg = $(#comment-detail)
.commentDlg()
.css(z-index, 999)
.appendTo(body);
}
gCommentDlg
[line 361:] .one(close, function() {
gCommentDlg
.setCommentBlock(self)
.css({
left: $(document).scrollLeft() +
($(window).width() - gCommentDlg.width
()) / 2,
top: self.endRow.offset().top +
self.endRow.height()
})
.open(self.el);
})
.close();
},
On Mar 30, 12:08 am, Martin mkoeb...@gmail.com wrote:
I also restarted memcached.
On Mar 30, 12:06 am, Martin mkoeb...@gmail.com wrote:
I use django 1.0.2 final if that matters.
On Mar 30, 12:05 am, Martin mkoeb...@gmail.com wrote:
after the easy_install I did
[r...@vmcodereview ~]# rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database
Upgrading Review Board from 1.0alpha4 to 1.0beta1
Installing json fixture 'initial_data' from '/usr/lib/python2.4/site-
packages/ReviewBoard-1.0beta1-py2.4.egg/reviewboard/scmtools/
fixtures'.
Installed 6 object(s) from 1 fixture(s)
No evolution required.
On Mar 30, 12:04 am, Martin mkoeb...@gmail.com wrote:
yes, I did.
On Mar 29, 11:59 pm, Christian Hammond chip...@chipx86.com
wrote:
Did you run `rb-site upgrade` on the new site and restart the
Apache server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Mar 29, 2009 at 8:55 PM, Martin mkoeb...@gmail.com
wrote:
Hi,
when I click on a line of code in the diff viewer, I get this
error
message in firefox 3 after upgrading to the first beta release:
Error: gCommentDlg.one(close, function ()
{gCommentDlg.setCommentBlock(self).css({left:
$(document).scrollLeft()
+ ($(window).width() - gCommentDlg.width()) / 2, top:
self.endRow.offset().top + self.endRow.height()}).open
(self.el);}).close is not a function
Source File:
http://codereview/reviewboard/media/rb/js/diffviewer.js?1238384481
Line: 361
I did clear the browser cache.
Please help.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: can't create comments, javascript error?
I also restarted memcached.
On Mar 30, 12:06 am, Martin mkoeb...@gmail.com wrote:
I use django 1.0.2 final if that matters.
On Mar 30, 12:05 am, Martin mkoeb...@gmail.com wrote:
after the easy_install I did
[r...@vmcodereview ~]# rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database
Upgrading Review Board from 1.0alpha4 to 1.0beta1
Installing json fixture 'initial_data' from '/usr/lib/python2.4/site-
packages/ReviewBoard-1.0beta1-py2.4.egg/reviewboard/scmtools/
fixtures'.
Installed 6 object(s) from 1 fixture(s)
No evolution required.
On Mar 30, 12:04 am, Martin mkoeb...@gmail.com wrote:
yes, I did.
On Mar 29, 11:59 pm, Christian Hammond chip...@chipx86.com wrote:
Did you run `rb-site upgrade` on the new site and restart the Apache
server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Mar 29, 2009 at 8:55 PM, Martin mkoeb...@gmail.com wrote:
Hi,
when I click on a line of code in the diff viewer, I get this error
message in firefox 3 after upgrading to the first beta release:
Error: gCommentDlg.one(close, function ()
{gCommentDlg.setCommentBlock(self).css({left: $(document).scrollLeft()
+ ($(window).width() - gCommentDlg.width()) / 2, top:
self.endRow.offset().top + self.endRow.height()}).open
(self.el);}).close is not a function
Source File:
http://codereview/reviewboard/media/rb/js/diffviewer.js?1238384481
Line: 361
I did clear the browser cache.
Please help.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: can't create comments, javascript error?
I use django 1.0.2 final if that matters.
On Mar 30, 12:05 am, Martin mkoeb...@gmail.com wrote:
after the easy_install I did
[r...@vmcodereview ~]# rb-site upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database
Upgrading Review Board from 1.0alpha4 to 1.0beta1
Installing json fixture 'initial_data' from '/usr/lib/python2.4/site-
packages/ReviewBoard-1.0beta1-py2.4.egg/reviewboard/scmtools/
fixtures'.
Installed 6 object(s) from 1 fixture(s)
No evolution required.
On Mar 30, 12:04 am, Martin mkoeb...@gmail.com wrote:
yes, I did.
On Mar 29, 11:59 pm, Christian Hammond chip...@chipx86.com wrote:
Did you run `rb-site upgrade` on the new site and restart the Apache
server?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Mar 29, 2009 at 8:55 PM, Martin mkoeb...@gmail.com wrote:
Hi,
when I click on a line of code in the diff viewer, I get this error
message in firefox 3 after upgrading to the first beta release:
Error: gCommentDlg.one(close, function ()
{gCommentDlg.setCommentBlock(self).css({left: $(document).scrollLeft()
+ ($(window).width() - gCommentDlg.width()) / 2, top:
self.endRow.offset().top + self.endRow.height()}).open
(self.el);}).close is not a function
Source File:
http://codereview/reviewboard/media/rb/js/diffviewer.js?1238384481
Line: 361
I did clear the browser cache.
Please help.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Issue 998 in reviewboard: post-review GUI for Windows Explorer
Status: New Owner: Labels: Type-Defect Priority-Medium New issue 998 by david.allouche: post-review GUI for Windows Explorer http://code.google.com/p/reviewboard/issues/detail?id=998 There should be a GUI for post-review integrated with the Windows Explorer. A lot of Windows users are very uncomfortable using the command line. The poor quality of the standard Windows command line does not help either. Actually, they are so uncomfortable using the command line that it is adoption-blocker. Even a rudimentary user interface that generates a correct diff as a file that can be posted manually through the web interface would be a big improvement over generating the diff with TortoiseSVN or the command line. Ideally, the user story for this should look like: * Download a run a setup.exe. * Right click on a directory icon, or within a directory window, in Explorer to display the contextual menu. * Navigate into the Reviewboard sub-menu. * Select one of Request review of uncommitted changes, Request review of committed changes, etc. * The first time, a wizard interface shows up to allow the user to set up the configuration. The wizard is preferred for the first interaction as it gives room to provide contextual documentation. * On subsequent occurrences, the interaction is done through a single dialog that displays the parameters used and provides an opportunity for changing them. * The interaction should allow both creating a new review, or uploading a new diff to an existing review. * Both successful and failed submission of the diff should display visual feedback. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 999 in reviewboard: post-review broken for git when working on a remote SVN branch (not trunk)
Comment #1 on issue 999 by sanfordarmstrong: post-review broken for git when working on a remote SVN branch (not trunk) http://code.google.com/p/reviewboard/issues/detail?id=999 As I said, I'm not sure if I'm using --parent incorrectly, so here's a patch that adds a --gitsvnparent option. It simplifies things for me by disposing with the parent diff step (which to me makes no sense in the context of --parent=some-svn-branch). So now I can use --gitsvnparent=1.0, and it will simply make a diff against my local 1.0 branch (which for me represents my SVN 1.0 branch). Everything just works because post-review already knows via `git svn info` how to do the svn diff correctly. I think a better approach would be to make --parent a little smarter when dealing with git-svn branches, but I can't think of a way to tell that some git branch represents a clean sync with an SVN branch instead of yet another local branch that has an SVN branch in its ancestry. That's why I opted to make a totally new option Attachments: gitsvnparent-option.patch 1.5 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 996 in reviewboard: post-review broken when run from root of git repo
Comment #8 on issue 996 by chipx86: post-review broken when run from root of git repo http://code.google.com/p/reviewboard/issues/detail?id=996 Oops, had registration turned off :) Try now. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
Issue 1001 in reviewboard: Adding comment to review fails with javascript error
Comment #1 on issue 1001 by bacchusf: Adding comment to review fails with javascript error http://code.google.com/p/reviewboard/issues/detail?id=1001 Same problem. beta1. Installed on Ubuntu 8.04 server Tested on Win Xp, FF 3, Safari 3. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-issues@googlegroups.com To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~--~~~~--~~--~--~---
