Re: problem with post-review when mercurial and clearcase installed on server
It is quite clear what is going on... I wonder if it is considered as an option to move to .reviewboardrc file parameters like: client type (ClearCase, Git, Mercurial etc) ccroot_path viewinfo viewtype On Jul 13, 9:52 pm, Vesterbaek vesterb...@gmail.com wrote: Try doing a post-review -d to better understand what is going on. - Jeppe -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: problem with post-review when mercurial and clearcase installed on server
Look at my (jan.koprowski) patches at http://reviews.reviewboard.org/ to ClearCase. --repository-url allow point ccroot_path On Wed, Jul 14, 2010 at 2:26 PM, Igor xrevol...@gmail.com wrote: It is quite clear what is going on... I wonder if it is considered as an option to move to .reviewboardrc file parameters like: client type (ClearCase, Git, Mercurial etc) ccroot_path viewinfo viewtype On Jul 13, 9:52 pm, Vesterbaek vesterb...@gmail.com wrote: Try doing a post-review -d to better understand what is going on. - Jeppe -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: rb-site install - Review Board is taking a nap
Anyone have any further suggestions on how to debug 'ReviewBoard is
taking a nap' after a fresh install? Maybe there are some diagnostics
I can run on my reviewboard site instance using rb-site manage or
shell?
I've tried validate and test, results are below (there was a problem
running test)
Thanks,
Daniel
% rb-site manage /full/path/to/my/site/ validate
0 errors found
% rb-site manage /full/path/to/my/site/ test
Creating test database 'default'...
Creating table django_admin_log
Creating table auth_permission
Creating table auth_group_permissions
Creating table auth_group
Creating table auth_user_user_permissions
Creating table auth_user_groups
Creating table auth_user
Creating table auth_message
Creating table django_content_type
Creating table django_site
Creating table django_session
Creating table siteconfig_siteconfiguration
Creating table accounts_reviewrequestvisit
Creating table accounts_profile_starred_review_requests
Creating table accounts_profile_starred_groups
Creating table accounts_profile
Creating table changedescs_changedescription
Creating table diffviewer_filediff
Creating table diffviewer_diffset
Creating table diffviewer_diffsethistory
Creating table reviews_group_users
Creating table reviews_group
Creating table reviews_defaultreviewer_repository
Creating table reviews_defaultreviewer_people
Creating table reviews_defaultreviewer_groups
Creating table reviews_defaultreviewer
Creating table reviews_screenshot
Creating table reviews_reviewrequest_changedescs
Creating table reviews_reviewrequest_target_people
Creating table reviews_reviewrequest_inactive_screenshots
Creating table reviews_reviewrequest_screenshots
Creating table reviews_reviewrequest_target_groups
Creating table reviews_reviewrequest
Creating table reviews_reviewrequestdraft_target_people
Creating table reviews_reviewrequestdraft_inactive_screenshots
Creating table reviews_reviewrequestdraft_screenshots
Creating table reviews_reviewrequestdraft_target_groups
Creating table reviews_reviewrequestdraft
Creating table reviews_comment
Creating table reviews_screenshotcomment
Creating table reviews_review_comments
Creating table reviews_review_screenshot_comments
Creating table reviews_review
Creating table scmtools_tool
Creating table scmtools_repository
Creating table django_project_version
Creating table django_evolution
Installing baseline version
Evolutions in diffviewer baseline: add_parent_diffs,
filediff_filenames_1024_chars, diffset_basedir, filediff_status
Evolutions in reviews baseline: change_descriptions,
last_review_timestamp, shipit_count, default_reviewer_repositories
Evolutions in scmtools baseline: bugzilla_url_charfield,
repository_raw_file_url, repository_visible,
repository_path_length_255
Installing custom SQL for accounts.Profile model
Installing custom SQL for reviews.Group model
Installing custom SQL for reviews.ReviewRequest model
Installing index for admin.LogEntry model
Installing index for auth.Permission model
Installing index for auth.Group_permissions model
Installing index for auth.User_user_permissions model
Installing index for auth.User_groups model
Installing index for auth.Message model
Installing index for siteconfig.SiteConfiguration model
Installing index for accounts.ReviewRequestVisit model
Installing index for accounts.Profile_starred_review_requests model
Installing index for accounts.Profile_starred_groups model
Installing index for diffviewer.FileDiff model
Installing index for diffviewer.DiffSet model
Installing index for reviews.Group_users model
Installing index for reviews.DefaultReviewer_repository model
Installing index for reviews.DefaultReviewer_people model
Installing index for reviews.DefaultReviewer_groups model
Installing index for reviews.ReviewRequest_changedescs model
Installing index for reviews.ReviewRequest_target_people model
Installing index for reviews.ReviewRequest_inactive_screenshots model
Installing index for reviews.ReviewRequest_screenshots model
Installing index for reviews.ReviewRequest_target_groups model
Installing index for reviews.ReviewRequest model
Installing index for reviews.ReviewRequestDraft_target_people model
Installing index for reviews.ReviewRequestDraft_inactive_screenshots
model
Installing index for reviews.ReviewRequestDraft_screenshots model
Installing index for reviews.ReviewRequestDraft_target_groups model
Installing index for reviews.ReviewRequestDraft model
Installing index for reviews.Comment model
Installing index for reviews.ScreenshotComment model
Installing index for reviews.Review_comments model
Installing index for reviews.Review_screenshot_comments model
Installing index for reviews.Review model
Installing index for scmtools.Repository model
Installing index for django_evolution.Evolution model
No fixtures found.
No fixtures found.
Traceback (most recent call last):
File /usr/bin/rb-site, line 8, in module
load_entry_point('ReviewBoard==1.5rc1', 'console_scripts', 'rb-
site')()
File
Is git-svn supposed to work with --parent?
I'm new to reviewboard, so maybe I have totally the wrong idea. My
org uses svn, but I'm using git-svn. I have a chain of commits in my
git repos, and I want to post them as separate review requests, but I
can't seem to get post-review to do this.
My git repos looks like this:
O -- change-3
|
O -- change-2
|
O -- change-1
|
O -- master -- remotes/trunk
I want to be able to do something like:
git checkout change-3
post-review --parent=change-2
and post a diff between change-2 and change-3 for review (ideally,
just saying post-review HEAD^ HEAD would be even better), even
though the repository from reviewboard's point of view is SVN.
I've seen some discussion that seems to suggest that this ought to
work:
http://groups.google.com/group/reviewboard/browse_thread/thread/3423e2c8f71c5c3a?pli=1
but it doesn't for me :(. It appears I'm getting empty diffs?
$ git checkout change-3
$ post-review --parent=change-2
Traceback (most recent call last):
File /usr/local/bin/post-review, line 8, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
()
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2861, in main
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2554, in tempt_fate
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 503,
in upload_diff
TypeError: object of type 'NoneType' has no len()
$ post-review --parent=change-2 --output-diff --tracking-branch=trunk
-d
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info: Path: https://dev.pluggd.com/svn, Base path:
/frontend/HtmlClient/Player/trunk, Supports changesets: False
git config --get reviewboard.url
git merge-base change-2 refs/heads/change-3
git diff --no-color --no-prefix -r -u change-2..
git svn find-rev change-2
git diff --no-color --no-prefix -r -u
dae96a154b9f395a9945b833973654d813ea8e5f..change-2
git svn find-rev dae96a154b9f395a9945b833973654d813ea8e5f
None
dae96a.. is change-2, so it makes sense that the diff is empty. It
should also be noted that the git svn find-rev change-2 doesn't
return anything, since change-2 isn't in svn. As a last thrash, I
tried modifying postreview.py's GitClient.make_svn_diff, and added:
if not rev:
rev = execute([git, svn, find-rev,
options.tracking]).strip()
after the first line that tries to find the parent's svn rev. This
makes post-review generate the right diff! But if I post it to review
board, I can't view it, presumably because it's trying to apply it
against the version in svn. Here I gave up.
Is there a solution?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
RE: Error uploading diff: One or more fields had errors (105) - Errors during command execution( p4 login )
Sorry, I was away for a few days, so I didn't reply right away
Here's your debug steps:
On the _SERVER_ side of ReviewBoard, run the command p4 info. It
should connect to perforce and show you something like this:
User name: p4user
Client name: p4clientspecname
Client host: client-hostname
Client root: C:\Perforce\p4clientspecname
Current directory: C:\Perforce\p4clientspecname
Client address: 123.45.67.89
Server address: 98.76.54.32:1666
Server root: D:\Perforce
Server date: 2010/07/14 11:07:16 -0700 Pacific Daylight Time
Server uptime: 12:34:56
Server version: P4D/NTX86/2009.2/238357 (2010/03/15)
Server license: Company Name (Number of Users)
Server license-ip: 98.76.54.32:1666
This will verify that your connection is running.
Note that you MUST be in the EXACT same running conditions as
ReviewBoard: You must have the same username, the same environment, etc.
If you are running on Windows, for example, and running ReviewBoard
under Apache as a service, then you might have severe difficulty trying
to pretend to be the same username that the service runs as!
If you get an error about unable to connect to Perforce, then you are
missing or have incorrect P4PORT, etc environment variables.
If it does work, well, if you can do that part and let us know we can
maybe track down a more complete solution
Dana Lacoste
On Thu, Jul 8, 2010 at 10:37 PM, Chidambar Kulkarni
chidambar.sk http://chidambar.sk/ @gmail.com http://gmail.com/
wrote:
Tried setting these variables but no luck. :(
Please help!!!
On Wed, Jul 7, 2010 at 12:19 AM, Dana Lacoste dlaco...@aperio.com
wrote:
It looks like you're having a server-side Perforce issue.
Basically, the review board server has to be able to talk to Perforce
(not just the client-side) and it's having a login issue.
So you can run p4 commands and it's working fine, but the server is
unable to do so.
You should be able to fix this by setting up P4PORT, P4USER,
P4PASSWD,
and P4CLIENT variables on the server side.
Dana Lacoste
-Original Message-
From: reviewboard@googlegroups.com
[mailto:reviewbo...@googlegroups.com]
On Behalf Of Chidambar
Sent: Tuesday, July 06, 2010 5:03 AM
To: reviewboard
Subject: Error uploading diff: One or more fields had errors (105) -
Errors during command execution( p4 login )
I am unable to post the review. PSB.
...
HTTP POSTing to
http://ESMRB/api/json/reviewrequests/15/diff/new/:
{}
Error uploading diff: One or more fields had errors (105)
{'fields': {'path': ['[P4#run] Errors during command execution(
p4
login )
\n\n\t[Error]: Password invalid.\n\n']}, 'stat': 'fail', 'err':
{'msg': 'One or
more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
Any help would be greatly appreciated.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
mailto:reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
mailto:reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
mailto:reviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Chidambar Kulkarni
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Conversion/Migration tool into ReviewBoard
Thanks for the example. At least for the CVS repositories, I guess both tools seem to agree on the diff formats. In any case, preserving comments (tree style) with just the corresponding raw format diffs while migration can be a very helpful tool. As the community can understand, having a single tool is a lot comfortable than keeping around an obselete and current working servers. I would like to hear what the contributors have to say in this regards. Thanks, Ratnam On Jul 13, 12:56 am, Jan Koprowski jan.koprow...@gmail.com wrote: My company used CodeStriker in the past but when we switched to ReviewBoard we don't try move old CodeStriker reviews to new tool. Problem was: CodeStriker have different format of diffs (native ClearCase diffs) ReviewBoard use unified diffs for all SCMs. On Tue, Jul 13, 2010 at 1:33 AM, Ratnam rtatava...@gmail.com wrote: Hi, My team is using codestriker for the past 7 months and now looking to use ReviewBoard. But the (obvious) catch is how do we get to convert our Codestriker data accumulated? I wanted to know if anyone share the same situation or are aware of any tool/set-of-steps to follow (can invest about 30+ hrs) to migrate/convert my Cosdestiker db to RBs' db? Any insights in this regard are highly appreciated. Thanks, Ratnam -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Conversion/Migration tool into ReviewBoard
Hi, I agree that this would be a great tool to have. However, it's not as straightforward as it may sound. In Review Board, comments are tied to virtual lines in the diff. Rather than being tied to the line number on the left-hand file or right-hand file, it's tied to more of a row number of sorts of the combined diff. CodeStriker, as far as I understand, stores this information differently, instead having comments tied to both a real line number and a side. This means we can't just copy over comments, but instead would have to do some work to figure out where the line numbers really should be and port them over. At the very least, this would require checking out each file from the repository, doing our diffing algorithm, processing the results, and then performing the synchronization. In theory, doable, but it would take a very long time, depending on the number of files with comments. Even when we do that, it's likely that the comments won't have the right context, due to the differences in how CodeStriker and Review Board process diffs. We use different algorithms and so the code may not be aligned the way you would expect. There are also things we probably couldn't port over properly. Passwords for users, for instance, and some of the other features of CodeStriker that we don't support. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 14, 2010 at 12:10 PM, Ratnam rtatava...@gmail.com wrote: Thanks for the example. At least for the CVS repositories, I guess both tools seem to agree on the diff formats. In any case, preserving comments (tree style) with just the corresponding raw format diffs while migration can be a very helpful tool. As the community can understand, having a single tool is a lot comfortable than keeping around an obselete and current working servers. I would like to hear what the contributors have to say in this regards. Thanks, Ratnam On Jul 13, 12:56 am, Jan Koprowski jan.koprow...@gmail.com wrote: My company used CodeStriker in the past but when we switched to ReviewBoard we don't try move old CodeStriker reviews to new tool. Problem was: CodeStriker have different format of diffs (native ClearCase diffs) ReviewBoard use unified diffs for all SCMs. On Tue, Jul 13, 2010 at 1:33 AM, Ratnam rtatava...@gmail.com wrote: Hi, My team is using codestriker for the past 7 months and now looking to use ReviewBoard. But the (obvious) catch is how do we get to convert our Codestriker data accumulated? I wanted to know if anyone share the same situation or are aware of any tool/set-of-steps to follow (can invest about 30+ hrs) to migrate/convert my Cosdestiker db to RBs' db? Any insights in this regard are highly appreciated. Thanks, Ratnam -- Want to help the Review Board project? Donate today athttp:// www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group athttp:// groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: rb-site install - Review Board is taking a nap
Hi Daniel, I've been on vacation, so I'm just now reading this. The test command won't work on an installed site. It requires a development checkout. I'd recommend editing your site's conf/settings_local.py and setting DEBUG to True (note the capital 'T'). Then restart your web server and see what kind of error you're getting. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 14, 2010 at 8:24 AM, Daniel da.s...@gmail.com wrote: Anyone have any further suggestions on how to debug 'ReviewBoard is taking a nap' after a fresh install? Maybe there are some diagnostics I can run on my reviewboard site instance using rb-site manage or shell? I've tried validate and test, results are below (there was a problem running test) Thanks, Daniel % rb-site manage /full/path/to/my/site/ validate 0 errors found % rb-site manage /full/path/to/my/site/ test Creating test database 'default'... Creating table django_admin_log Creating table auth_permission Creating table auth_group_permissions Creating table auth_group Creating table auth_user_user_permissions Creating table auth_user_groups Creating table auth_user Creating table auth_message Creating table django_content_type Creating table django_site Creating table django_session Creating table siteconfig_siteconfiguration Creating table accounts_reviewrequestvisit Creating table accounts_profile_starred_review_requests Creating table accounts_profile_starred_groups Creating table accounts_profile Creating table changedescs_changedescription Creating table diffviewer_filediff Creating table diffviewer_diffset Creating table diffviewer_diffsethistory Creating table reviews_group_users Creating table reviews_group Creating table reviews_defaultreviewer_repository Creating table reviews_defaultreviewer_people Creating table reviews_defaultreviewer_groups Creating table reviews_defaultreviewer Creating table reviews_screenshot Creating table reviews_reviewrequest_changedescs Creating table reviews_reviewrequest_target_people Creating table reviews_reviewrequest_inactive_screenshots Creating table reviews_reviewrequest_screenshots Creating table reviews_reviewrequest_target_groups Creating table reviews_reviewrequest Creating table reviews_reviewrequestdraft_target_people Creating table reviews_reviewrequestdraft_inactive_screenshots Creating table reviews_reviewrequestdraft_screenshots Creating table reviews_reviewrequestdraft_target_groups Creating table reviews_reviewrequestdraft Creating table reviews_comment Creating table reviews_screenshotcomment Creating table reviews_review_comments Creating table reviews_review_screenshot_comments Creating table reviews_review Creating table scmtools_tool Creating table scmtools_repository Creating table django_project_version Creating table django_evolution Installing baseline version Evolutions in diffviewer baseline: add_parent_diffs, filediff_filenames_1024_chars, diffset_basedir, filediff_status Evolutions in reviews baseline: change_descriptions, last_review_timestamp, shipit_count, default_reviewer_repositories Evolutions in scmtools baseline: bugzilla_url_charfield, repository_raw_file_url, repository_visible, repository_path_length_255 Installing custom SQL for accounts.Profile model Installing custom SQL for reviews.Group model Installing custom SQL for reviews.ReviewRequest model Installing index for admin.LogEntry model Installing index for auth.Permission model Installing index for auth.Group_permissions model Installing index for auth.User_user_permissions model Installing index for auth.User_groups model Installing index for auth.Message model Installing index for siteconfig.SiteConfiguration model Installing index for accounts.ReviewRequestVisit model Installing index for accounts.Profile_starred_review_requests model Installing index for accounts.Profile_starred_groups model Installing index for diffviewer.FileDiff model Installing index for diffviewer.DiffSet model Installing index for reviews.Group_users model Installing index for reviews.DefaultReviewer_repository model Installing index for reviews.DefaultReviewer_people model Installing index for reviews.DefaultReviewer_groups model Installing index for reviews.ReviewRequest_changedescs model Installing index for reviews.ReviewRequest_target_people model Installing index for reviews.ReviewRequest_inactive_screenshots model Installing index for reviews.ReviewRequest_screenshots model Installing index for reviews.ReviewRequest_target_groups model Installing index for reviews.ReviewRequest model Installing index for reviews.ReviewRequestDraft_target_people model Installing index for reviews.ReviewRequestDraft_inactive_screenshots model Installing index for reviews.ReviewRequestDraft_screenshots model Installing index for reviews.ReviewRequestDraft_target_groups
.reviewboardrc global placement
Does the .reviewboardrc have to be in the checkout path or can we put this in a centralized area? I ask because we have a dev environment that we are setting up and each user has an account on the system. I would rather just setup this configuration once if possible, rather than for every user. Kyle Hayes Sr. Web Developer | Disney Family Disney Interactive Media Group 818-623-3847 AIM/YIM/gTalk: mrkylehayes It's kind of fun to do the impossible. -Walt Disney -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Question regarding usage of ReviewBoard for review of arbitrary files
Hello, I have a requirement here where I would like to use reviewboard for reviewing files which are arbitrary. By arbitrary, I am referring to files which do not belong to any repository. But I would like to make use of ReviewBoard's features like incremental diffs etc to have a diff between an arbitrary file1 and versions of file2, which is again not part of any repo. From the docs I find that reviewboard mandates the specification of the base diff path for posting files for review. Is there any way to handle the requirement posted here? Also is there a group/support team for RB, to whom I can mail this question? =Arun -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Question about the API info
Hi I am not sure that if this is a doc bug or not: http://www.reviewboard.org/docs/manual/dev/webapi/reference/apicalls/login/#api-login As you said the type of password is Boolean, which is confusing me, could you please check it? BR/Vincent -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
api/json/reviewrequests/{review_request_id}/diff/ not working
Hi,
I need to find out files changed in a review request. I am trying to
use api/json/reviewrequests/{review_request_id}/diff/. however it is
returning following error.
Unable to access http://punereviewsrv/trial/api/json/reviewrequests/79/diff/
(404). The host path may be invali
d
If I use api/json/reviewrequests/{review_request_id}/ is returns the
array.
If I specify http://punereviewsrv/trial/api/json/reviewrequests/79/
diff/ in the browser, I get error as 404 error. However http://
punereviewsrv/trial/api/json/reviewrequests/79/ this works.
Please let me know if there any other way to get list of files changed
in a review request.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about the API info
You're absolutely right. It should be a string. I'll fix it. A boolean would make for the worst password type ever. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 14, 2010 at 7:32 PM, Vincent heroa...@gmail.com wrote: Hi I am not sure that if this is a doc bug or not: http://www.reviewboard.org/docs/manual/dev/webapi/reference/apicalls/login/#api-login As you said the type of password is Boolean, which is confusing me, could you please check it? BR/Vincent -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: api/json/reviewrequests/{review_request_id}/diff/ not working
Hi,
Is that particular review request published?
What version of Review Board are you using?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 14, 2010 at 8:28 PM, Madhavi madhavii.gu...@gmail.com wrote:
Hi,
I need to find out files changed in a review request. I am trying to
use api/json/reviewrequests/{review_request_id}/diff/. however it is
returning following error.
Unable to access
http://punereviewsrv/trial/api/json/reviewrequests/79/diff/
(404). The host path may be invali
d
If I use api/json/reviewrequests/{review_request_id}/ is returns the
array.
If I specify http://punereviewsrv/trial/api/json/reviewrequests/79/
diff/ http://punereviewsrv/trial/api/json/reviewrequests/79/%0Adiff/ in
the browser, I get error as 404 error. However http://
punereviewsrv/trial/api/json/reviewrequests/79/ this works.
Please let me know if there any other way to get list of files changed
in a review request.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question regarding usage of ReviewBoard for review of arbitrary files
Hi, This is the support team, basically. David Trowbridge and I are the main developers of Review Board, and answer the support e-mails (though other people on this list are often great at jumping in with answers too). Review Board currently requires a repository for any files being viewed in the diff viewer. There's not really a way to get around this except to write a custom SCMTool (the interface that knows how to talk to a repository) that somehow fakes it, but this may not be straight-forward and isn't on our TODO list. Support for reviewing arbitrarily uploaded files would be a big change and while I'm not opposed to it, it won't be happening right away. Can you tell me more about what you need here? What kind of file types are you looking to review? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 14, 2010 at 2:52 PM, ArunBalaji arunbalaji1...@gmail.comwrote: Hello, I have a requirement here where I would like to use reviewboard for reviewing files which are arbitrary. By arbitrary, I am referring to files which do not belong to any repository. But I would like to make use of ReviewBoard's features like incremental diffs etc to have a diff between an arbitrary file1 and versions of file2, which is again not part of any repo. From the docs I find that reviewboard mandates the specification of the base diff path for posting files for review. Is there any way to handle the requirement posted here? Also is there a group/support team for RB, to whom I can mail this question? =Arun -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: api/json/reviewrequests/{review_request_id}/diff/ not working
This functionality doesn't exist in 1.0.x. The ability to view the list of
files was added in 1.5.
We're close to releasing 1.5 (we're at RC 1 and are working primarily on
updating the documentation), so now would be a good time to start testing it
and working on support for it. There's also a newer, more flexible API (in
just /api instead of /api/json) that I'd recommend, which can absolutely do
what you need.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 14, 2010 at 8:53 PM, Madhavi madhavii.gu...@gmail.com wrote:
I am on RB 1.0.7 on CentOS 5
I am getting same result for submitted / non-submitted requests.
-Madhavi
On Jul 15, 8:43 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
Is that particular review request published?
What version of Review Board are you using?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Jul 14, 2010 at 8:28 PM, Madhavi madhavii.gu...@gmail.com
wrote:
Hi,
I need to find out files changed in a review request. I am trying to
use api/json/reviewrequests/{review_request_id}/diff/. however it is
returning following error.
Unable to access
http://punereviewsrv/trial/api/json/reviewrequests/79/diff/
(404). The host path may be invali
d
If I use api/json/reviewrequests/{review_request_id}/ is returns the
array.
If I specify http://punereviewsrv/trial/api/json/reviewrequests/79/
diff/ http://punereviewsrv/trial/api/json/reviewrequests/79/%0Adiff/
in
the browser, I get error as 404 error. However http://
punereviewsrv/trial/api/json/reviewrequests/79/ this works.
Please let me know if there any other way to get list of files changed
in a review request.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: api/json/reviewrequests/{review_request_id}/diff/ not working
Great ! Thank you so much. I will download and test it.
On Jul 15, 8:58 am, Christian Hammond chip...@chipx86.com wrote:
This functionality doesn't exist in 1.0.x. The ability to view the list of
files was added in 1.5.
We're close to releasing 1.5 (we're at RC 1 and are working primarily on
updating the documentation), so now would be a good time to start testing it
and working on support for it. There's also a newer, more flexible API (in
just /api instead of /api/json) that I'd recommend, which can absolutely do
what you need.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Jul 14, 2010 at 8:53 PM, Madhavi madhavii.gu...@gmail.com wrote:
I am on RB 1.0.7 on CentOS 5
I am getting same result for submitted / non-submitted requests.
-Madhavi
On Jul 15, 8:43 am, Christian Hammond chip...@chipx86.com wrote:
Hi,
Is that particular review request published?
What version of Review Board are you using?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Jul 14, 2010 at 8:28 PM, Madhavi madhavii.gu...@gmail.com
wrote:
Hi,
I need to find out files changed in a review request. I am trying to
use api/json/reviewrequests/{review_request_id}/diff/. however it is
returning following error.
Unable to access
http://punereviewsrv/trial/api/json/reviewrequests/79/diff/
(404). The host path may be invali
d
If I use api/json/reviewrequests/{review_request_id}/ is returns the
array.
If I specify http://punereviewsrv/trial/api/json/reviewrequests/79/
diff/ http://punereviewsrv/trial/api/json/reviewrequests/79/%0Adiff/
in
the browser, I get error as 404 error. However http://
punereviewsrv/trial/api/json/reviewrequests/79/ this works.
Please let me know if there any other way to get list of files changed
in a review request.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: .reviewboardrc global placement
Kyle and I talked about this one-on-one, but for anyone else interested, I'll relay basically what I said. As of now, we don't have any built-in way to do site configuration. It's something I would like, but we'd have to figure out how to do it. Where does post-review look for the site configuration file? Presumably you'd want it on a network store, but post-review would have to have *some* config telling it where to look. So there are basically two main ways to tackle this today that I'm aware of: 1) Use a global wrapper for post-review. Instead of having users install RBTools/post-review, provide a post-review in a standard, network-wide bin path (assuming your network has one and that users have it in their PATH) and use that to wrap post-review with whatever configuration options are needed. This is used in some large deployments and works fairly well. 2) Supply/generate a .reviewboardrc file on installations that includes a central .reviewboardrc. The .reviewboardrc file is basically just a Python script, so it can import something else that's in the path. The first option is probably the easiest and more hassle-free. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Jul 14, 2010 at 3:00 PM, Hayes, Kyle kyle.ha...@disney.com wrote: Does the *.reviewboardrc* have to be in the checkout path or can we put this in a centralized area? I ask because we have a dev environment that we are setting up and each user has an account on the system. I would rather just setup this configuration once if possible, rather than for every user. * Kyle Hayes* Sr. Web Developer | Disney Family Disney Interactive Media Group 818-623-3847 AIM/YIM/gTalk: mrkylehayes *It's kind of fun to do the impossible.* -Walt Disney -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Is git-svn supposed to work with --parent?
Hi Jared,
Can you tell me if this works when using branches instead of revisions?
I'm not entirely sure if git-svn works with parent branches, but I thought
it did. It *should* be generating a diff between the SVN repository and the
branch and sending that as a parent diff along with the generated diff. You
won't see this parent diff with --output-diff though.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Jul 14, 2010 at 10:55 AM, Jared Roberts jar...@gmail.com wrote:
I'm new to reviewboard, so maybe I have totally the wrong idea. My
org uses svn, but I'm using git-svn. I have a chain of commits in my
git repos, and I want to post them as separate review requests, but I
can't seem to get post-review to do this.
My git repos looks like this:
O -- change-3
|
O -- change-2
|
O -- change-1
|
O -- master -- remotes/trunk
I want to be able to do something like:
git checkout change-3
post-review --parent=change-2
and post a diff between change-2 and change-3 for review (ideally,
just saying post-review HEAD^ HEAD would be even better), even
though the repository from reviewboard's point of view is SVN.
I've seen some discussion that seems to suggest that this ought to
work:
http://groups.google.com/group/reviewboard/browse_thread/thread/3423e2c8f71c5c3a?pli=1
but it doesn't for me :(. It appears I'm getting empty diffs?
$ git checkout change-3
$ post-review --parent=change-2
Traceback (most recent call last):
File /usr/local/bin/post-review, line 8, in module
load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')
()
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2861, in main
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line
2554, in tempt_fate
File build/bdist.linux-x86_64/egg/rbtools/postreview.py, line 503,
in upload_diff
TypeError: object of type 'NoneType' has no len()
$ post-review --parent=change-2 --output-diff --tracking-branch=trunk
-d
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info: Path: https://dev.pluggd.com/svn, Base path:
/frontend/HtmlClient/Player/trunk, Supports changesets: False
git config --get reviewboard.url
git merge-base change-2 refs/heads/change-3
git diff --no-color --no-prefix -r -u change-2..
git svn find-rev change-2
git diff --no-color --no-prefix -r -u
dae96a154b9f395a9945b833973654d813ea8e5f..change-2
git svn find-rev dae96a154b9f395a9945b833973654d813ea8e5f
None
dae96a.. is change-2, so it makes sense that the diff is empty. It
should also be noted that the git svn find-rev change-2 doesn't
return anything, since change-2 isn't in svn. As a last thrash, I
tried modifying postreview.py's GitClient.make_svn_diff, and added:
if not rev:
rev = execute([git, svn, find-rev,
options.tracking]).strip()
after the first line that tries to find the parent's svn rev. This
makes post-review generate the right diff! But if I post it to review
board, I can't view it, presumably because it's trying to apply it
against the version in svn. Here I gave up.
Is there a solution?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
How to set p4 password in repository?
I try to integrate the reviewboard 1.5 rc1 to perforce. When I invoked
post-review, I got the following error.
--
Looking for 'localhost /reviews/' cookie in
/home/test/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board at http://localhost/reviews/
Logging in with username rd1
HTTP POSTing to http://localhost/reviews/api/json/accounts/login/:
{'username': 'rd1', 'password': '**'}
Logged in.
Attempting to create review request on aaa.bbb.ccc.ddd:1666 for None
HTTP POSTing to http://localhost/reviews/api/json/reviewrequests/new/:
{'repository_path': 'perforce.tw.trendnet.org:1666'}
Review request created
Uploading diff, size: 49151
HTTP POSTing to
http://localhost/reviews/api/json/reviewrequests/33/diff/new/: {}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'[P4#run] Errors during command
execution( p4 files //test/test.h#2 )\n\n\t[Error]: Perforce password
(P4PASSWD) invalid or unset.\n\n']}, u'stat': u'fail', u'err': {u'msg':
u'One or more fields had errors', u'code': 105}, u'deprecated':
{u'in_version': u'1.5'}}
Error uploading diff
-
If I changed the password in repository to ticket number, it worked
without error. it seems that there is an issue in the password.
My problem is that the ticket number will be expired after 15 hours. I
must update the ticket number before I create an review request.
Does anyone have ideas to set password correctly?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #10 on issue 46 by arunbalaji1985: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Hi, We also follow certain standards like this in our company. And we have been using review board for quite some time now. Can the review board show margin after 80th column, or allow the admin to configure the limit based on the file extension. It could be a thin vertical line, or a slightly different background color. And/or, lines violating the limit could be highlighted. Any idea of this would be implemented? =Arun -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
Re: Issue 46 in reviewboard: 80-column indicator in diff view
Comment #11 on issue 46 by chipx86: 80-column indicator in diff view http://code.google.com/p/reviewboard/issues/detail?id=46 Arun, this is one of those situations where an easy solution for one group is going to cause complaints for another. In large deployments, different teams may very well have different coding standards, and because of this we need a solution that is a bit more flexible. The trick is to figure out *where* the 80th column is. We need something that is fast but flexible. Doing it server-side is possible and may be speedy enough, but will become part of the cached content, so depending on how we let the users customize it (whether we choose to make it an admin setting or something flexible the user can change) it may or may not be an option. If doing it client-side, we need a way to quickly find the 80th column on each row, which can be slow. We also need to figure out the UI for showing that column. Background color could work. A thin line is a bit more difficult and looks odd on wrapped content. -- You received this message because you are subscribed to the Google Groups reviewboard-issues group. To post to this group, send email to reviewboard-iss...@googlegroups.com. To unsubscribe from this group, send email to reviewboard-issues+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en.
