Reviewing without a Source control Repo: Uploading changes?

2015-06-18 Thread Luciano Moretti
We're trying to evaluate Reviewboard but cannot integrate it with our 
current Source Control system. We are switching source control soon to one 
that can be integrated.

Currently, we've got a review started and the initiator has made changes to 
the files, but we can't figure out how to upload a pre-generated diff to 
the review (or the new version of the file for Reviewboard itself to do the 
diff).

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board 2.0.16 is released, with security fixes and more

2015-06-18 Thread Paul Fee
Hi Christian,

I'm seeing some buggy behaviour around the caching of diffs.  It looks like 
a server side problem as the buggy diff content persists even if I reload 
with CTRL-F5 or switch browsers (e.g. firefox to chromium).

Steps to reproduce:

1. Change some code, I happen to be using SVN.
2. Upload diff to existing review.
$ rbt post -r XXX svn_changelist
3. View the draft interdiff, all it ok at this point.
4. Change the code some more without publishing draft changes.
5. Upload diff again, should change content of draft diff.
$ rbt post -r XXX svn_changelist
6. View the draft interdiff - BUG - diff content on web page is from first 
upload, changes from second rbt post are not displayed.

From the 2.0.16 release notes, If a diff has already been viewed once, by 
anyone, it will be quicker to retrieve and display..  I suspect the draft 
is being cached.  A blunt fix could be to avoid caching diffs for drafts.  
A better fix would be to invalidate caches for draft diffs when a new 
diffset is uploaded.

Hopefully those steps are clear enough for you to reproduce the issue.  Let 
me know if you need more information.

Thanks,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: email issue on RB group vs people

2015-06-18 Thread MoonWalker
it is empty

On Friday, June 19, 2015 at 12:12:44 PM UTC+10, David Trowbridge wrote:

 Please check the group configuration and check that the mailing list 
 field is empty.

 -David
 On Thu, Jun 18, 2015 at 6:02 PM MoonWalker daniel.c...@gmail.com 
 javascript: wrote:

 David,

 I setup the mail server (Settings - Email - EMail Server - Mail 
 Server). I was under the impression that once that I establish the members 
 of a group, RB will send an email to all the group members, but that is not 
 the case. I have to add them to the People to have the expected result. 

 Do I need to configure anything else on RB ? 

 On Friday, June 19, 2015 at 10:14:18 AM UTC+10, David Trowbridge wrote:

 Does the group have a mailing list configured? If so, e-mail to that 
 group will be sent only to the list and not to the group members.

 -David

 On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.c...@gmail.com 
 wrote:

 I have noticed this issue since several versions, not sure if this is a 
 know issue or something else in my configuration, but basically in 
 Reviewers  I need to add each team member to People, because if I add 
 the 
 group they wont receive any email. not sure why.

 All these people are part of the same group, but still not email.

 BTW I am using the latest RB version

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google 
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send 
 an email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: email issue on RB group vs people

2015-06-18 Thread MoonWalker
David,

I setup the mail server (Settings - Email - EMail Server - Mail Server). 
I was under the impression that once that I establish the members of a 
group, RB will send an email to all the group members, but that is not the 
case. I have to add them to the People to have the expected result. 

Do I need to configure anything else on RB ? 

On Friday, June 19, 2015 at 10:14:18 AM UTC+10, David Trowbridge wrote:

 Does the group have a mailing list configured? If so, e-mail to that group 
 will be sent only to the list and not to the group members.

 -David

 On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.c...@gmail.com 
 javascript: wrote:

 I have noticed this issue since several versions, not sure if this is a 
 know issue or something else in my configuration, but basically in 
 Reviewers  I need to add each team member to People, because if I add the 
 group they wont receive any email. not sure why.

 All these people are part of the same group, but still not email.

 BTW I am using the latest RB version

 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard...@googlegroups.com javascript:.
 For more options, visit https://groups.google.com/d/optout.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: email issue on RB group vs people

2015-06-18 Thread David Trowbridge
Please check the group configuration and check that the mailing list
field is empty.

-David
On Thu, Jun 18, 2015 at 6:02 PM MoonWalker daniel.cabrera...@gmail.com
wrote:

 David,

 I setup the mail server (Settings - Email - EMail Server - Mail
 Server). I was under the impression that once that I establish the members
 of a group, RB will send an email to all the group members, but that is not
 the case. I have to add them to the People to have the expected result.

 Do I need to configure anything else on RB ?

 On Friday, June 19, 2015 at 10:14:18 AM UTC+10, David Trowbridge wrote:

 Does the group have a mailing list configured? If so, e-mail to that
 group will be sent only to the list and not to the group members.

 -David

 On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.c...@gmail.com wrote:

 I have noticed this issue since several versions, not sure if this is a
 know issue or something else in my configuration, but basically in
 Reviewers  I need to add each team member to People, because if I add the
 group they wont receive any email. not sure why.

 All these people are part of the same group, but still not email.

 BTW I am using the latest RB version

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.

 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard...@googlegroups.com.


 For more options, visit https://groups.google.com/d/optout.

  --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-18 Thread John Schmitt


On Thursday, June 18, 2015 at 11:04:24 AM UTC-7, Barret Rennie wrote:

 Hi John,

 That import doesn’t specifically import urllib.parse; it imports it from 
 Six, a Python 2 — 3 compatibility layer. Can you verify that importing 
 “six.moves.urllib.parse.urlparse” does not work in terminal?

 Regards,
 Barret Rennie


Hi Barret.  Is this what you mean?

# python
Python 2.7.5 (default, Jun 17 2014, 18:11:42) 
[GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] on linux2
Type help, copyright, credits or license for more information.
 import six.moves.urllib.parse.urlparse
Traceback (most recent call last):
  File stdin, line 1, in module
ImportError: No module named urllib.parse.urlparse




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


ImportError: No module named settings_local

2015-06-18 Thread John Schmitt
I can run

# rb-site manage --help

just fine.  But, taking the help literally, I get this when I try:

# rb-site manage -- --help
 


...
  'manage' command:
Runs a Django management command on the site. Usage: `rb-site manage
path command -- arguments.` Run `manage -- --help` for the list
of commands.


  'upgrade' command:
Upgrades an existing site installation, synchronizing media trees and
upgrading the database, unless otherwise specified.


--no-db-upgrade don't upgrade the database
--all-sites Upgrade all installed sites
[root@dyn40-25-217 reviews.tintri.com]# rb-site manage -- --help
Traceback (most recent call last):
  File /usr/bin/rb-site, line 9, in module
load_entry_point('ReviewBoard==2.0.15', 'console_scripts', 'rb-site')()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1885, in main
command.run()
  File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py, 
line 1808, in run
initialize()
  File /usr/lib/python2.7/site-packages/reviewboard/__init__.py, line 77, 
in initialize
import settings_local
ImportError: No module named settings_local


I do have a settings_local.py in the place in which rb-site created it.




-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Asking about mapping of review board orig to git commit hash

2015-06-18 Thread Barret Rennie
Hi Bach,

It is not always the case that there is a commit ID associated with a review 
request. This is because users can upload arbtitrary .diff files or filter 
their generated diff file with exclude files or included-only files. When there 
is a commit ID associated, it will be in the `changenum` field of the 
`reviewboard.reviews.models.review_request:review_request` model.

Regards,
Barret Rennie
 On Jun 18, 2015, at 1:24 AM, bach...@gmail.com wrote:
 
 Hi,
 
 We are currently studying your tool for our research.
 
 We were wondering from review board code review, how do we know which 
 revision in the revision history of the code base
 is being review? For example, you have the notion of orig, which is the 
 original revision. How do we know what is actually
 the original revision in the git repository, ie., what is the commit hash 
 of this orig?
 
 I look forward to hearing your reply.
 Thanks a lot.
 
 Regards,
 
 Bach.
 
 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/ 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/ https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/ 
 https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com 
 mailto:reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout 
 https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


ImportError: No module named urllib.parse

2015-06-18 Thread John Schmitt
Which module must I install to run rbt?

# which rbt
/usr/bin/rbt
# rpm -q --whatprovides /usr/bin/rbt
RBTools-0.7.2-1.el7.noarch
# rbt --help
Traceback (most recent call last):
  File /usr/bin/rbt, line 9, in module
load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
  File /usr/lib/python2.7/site-packages/pkg_resources.py, line 378
, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
  File /usr/lib/python2.7/site-packages/pkg_resources.py, line 
2566, in load_entry_point
return ep.load()
  File /usr/lib/python2.7/site-packages/pkg_resources.py, line 
2260, in load
entry = __import__(self.module_name, globals(),globals(), [
'__name__'])
  File 
/usr/lib/python2.7/site-packages/rbtools/commands/__init__.py, line 12, in 
module
from six.moves.urllib.parse import urlparse
ImportError: No module named urllib.parse

However, I can import urllib without error:

# python
Python 2.7.5 (default, Jun 17 2014, 18:11:42)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] on linux2
Type help, copyright, credits or license for more 
information.
 import urllib



-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3890 in reviewboard: Didn't apply patch cleanly when using rbt post --parent in mercurial

2015-06-18 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3890 by ronald.c...@visiercorp.com: Didn't apply patch cleanly  
when using rbt post --parent in mercurial

https://code.google.com/p/reviewboard/issues/detail?id=3890

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
site 2.0.15
rbt 0.7.4

What's the URL of the page containing the problem?
http://reviews.internal/r/67/

What steps will reproduce the problem?
1. given a mercurial repository where tip is hash A
2. make two commits locally with hash B, and C
3. rbt post --parent A
4. open in web ui and look at diff

What is the expected output? What do you see instead?
The diff from A to C.

What I see is Didn't apply patch cleanly.  Downloading the patch and  
applying it locally is fine:

cd mercurial-repository
wget -Opatch http://reviews.internal/r/67/diff/raw
hg update -r A
patch -p1  patch

Looking at the contents of the patch we see:
diff -r A -r C filename
...

The problem is -r C, if we remove it and re-upload the patch it diffs  
fine.  This is a but in rbt where it is adding the -r C


Workaround:
rbt diff --parent A | perl -pe 's/^(diff -r \w+) -r \w+/\1/g' patch
upload patch

This means I cannot use rbt post

What operating system are you using? What browser?
Mac OS X
Safari

Please provide any additional information below.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named settings_local

2015-06-18 Thread Christian Hammond
Hi John,

How did you install Review Board?

Christian 

--  
Christian Hammond - christ...@beanbaginc.com  
Review Board - https://www.reviewboard.org  
Beanbag, Inc. - https://www.beanbaginc.com

-Original Message-
From: John Schmitt marmalo...@gmail.com
Reply: reviewboard@googlegroups.com reviewboard@googlegroups.com
Date: June 18, 2015 at 11:53:28 AM
To: reviewboard@googlegroups.com reviewboard@googlegroups.com
Subject:  ImportError: No module named settings_local

 I can run
  
 # rb-site manage --help
  
 just fine. But, taking the help literally, I get this when I try:
  
 # rb-site manage -- --help
  
  
  
 ...
 'manage' command:
 Runs a Django management command on the site. Usage: `rb-site manage
 path command -- arguments.` Run `manage -- --help` for the list
 of commands.
  
  
 'upgrade' command:
 Upgrades an existing site installation, synchronizing media trees and
 upgrading the database, unless otherwise specified.
  
  
 --no-db-upgrade don't upgrade the database
 --all-sites Upgrade all installed sites
 [root@dyn40-25-217 reviews.tintri.com]# rb-site manage -- --help
 Traceback (most recent call last):
 File /usr/bin/rb-site, line 9, in module
 load_entry_point('ReviewBoard==2.0.15', 'console_scripts', 'rb-site')()
 File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1885, in main
 command.run()
 File /usr/lib/python2.7/site-packages/reviewboard/cmdline/rbsite.py,
 line 1808, in run
 initialize()
 File /usr/lib/python2.7/site-packages/reviewboard/__init__.py, line 77,
 in initialize
 import settings_local
 ImportError: No module named settings_local
  
  
 I do have a settings_local.py in the place in which rb-site created it.
  
  
  
  
 --
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups 
 reviewboard
 group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.
  

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Reviewing without a Source control Repo: Uploading changes?

2015-06-18 Thread Barret Rennie
Hi Luciano,

The person who uploaded the review request can update the diff by going to the 
review request page and selecting Update  Update Diff from the top menu (where 
Review, Ship It, etc. are).

Regards,
Barret Rennie
 On Jun 18, 2015, at 8:55 AM, Luciano Moretti luciano.more...@gmail.com 
 wrote:
 
 We're trying to evaluate Reviewboard but cannot integrate it with our current 
 Source Control system. We are switching source control soon to one that can 
 be integrated.
 
 Currently, we've got a review started and the initiator has made changes to 
 the files, but we can't figure out how to upload a pre-generated diff to the 
 review (or the new version of the file for Reviewboard itself to do the diff).
 
 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/ 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/ https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/ 
 https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com 
 mailto:reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout 
 https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-18 Thread Barret Rennie
Hi John,

That import doesn’t specifically import urllib.parse; it imports it from Six, a 
Python 2 — 3 compatibility layer. Can you verify that importing 
“six.moves.urllib.parse.urlparse” does not work in terminal?

Regards,
Barret Rennie
 On Jun 18, 2015, at 12:02 PM, John Schmitt marmalo...@gmail.com wrote:
 
 Which module must I install to run rbt?
 
 # which rbt
 /usr/bin/rbt
 # rpm -q --whatprovides /usr/bin/rbt
 RBTools-0.7.2-1.el7.noarch
 # rbt --help
 Traceback (most recent call last):
   File /usr/bin/rbt, line 9, in module
 load_entry_point('RBTools==0.7.2', 'console_scripts', 'rbt')()
   File /usr/lib/python2.7/site-packages/pkg_resources.py, line 378, 
 in load_entry_point
 return get_distribution(dist).load_entry_point(group, name)
   File /usr/lib/python2.7/site-packages/pkg_resources.py, line 
 2566, in load_entry_point
 return ep.load()
   File /usr/lib/python2.7/site-packages/pkg_resources.py, line 
 2260, in load
 entry = __import__(self.module_name, globals(),globals(), 
 ['__name__'])
   File 
 /usr/lib/python2.7/site-packages/rbtools/commands/__init__.py, line 12, in 
 module
 from six.moves.urllib.parse import urlparse
 ImportError: No module named urllib.parse
 
 However, I can import urllib without error:
 
 # python
 Python 2.7.5 (default, Jun 17 2014, 18:11:42)
 [GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] on linux2
 Type help, copyright, credits or license for more information.
  import urllib
 
 
 
 
 -- 
 Supercharge your Review Board with Power Pack: 
 https://www.reviewboard.org/powerpack/ 
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons: 
 https://rbcommons.com/ https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/ 
 https://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com 
 mailto:reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout 
 https://groups.google.com/d/optout.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard

Status: New
Owner: 
Labels: Type-Defect Priority-Medium

New issue 3891 by rodolfo@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

*** READ THIS BEFORE POSTING!
***
*** You must complete this form in its entirety, or your bug report will be
*** rejected.
***
*** If you have a security issue to report, please send it confidentially
to
*** secur...@reviewboard.org. Posting security-related issues to this bug
*** tracker causes us to have to do an emergency release.
***
*** For customer support, please post to reviewbo...@googlegroups.com
***
*** If you have a patch, please submit it to
http://reviews.reviewboard.org/
***
*** This bug tracker is public. Please check that any logs or other
information
*** that you include has been stripped of confidential information.


What version are you running?
2.0.17

What's the URL of the page containing the problem?
It's internal, not public
https://xxx.oracle.com/reviews/admin/db/scmtools/repository/add/

What steps will reproduce the problem?
1. Just adding a new repository for mercurial
2.
3.

What is the expected output? What do you see instead?
success adding the repository, but I got:
Please correct the error below.
invalid literal for int() with base 10: ''

What operating system are you using? What browser?
Linux RedHat 6

Please provide any additional information below.


Attachments:
error.png  16.6 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard

Updates:
Status: NeedInfo

Comment #1 on issue 3891 by trowb...@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

Can you show us the full contents of the form?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named settings_local

2015-06-18 Thread John Schmitt


On Thursday, June 18, 2015 at 11:54:51 AM UTC-7, Christian Hammond wrote:

 Hi John, 

 How did you install Review Board? 

 Christian  


I'm using the version that is provided by EPEL from Centos 7.

# rpm -q epel-release
epel-release-7-5.noarch
# rpm -q ReviewBoard
ReviewBoard-2.0.15-1.el7.noarch


 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: ImportError: No module named urllib.parse

2015-06-18 Thread John Schmitt


On Thursday, June 18, 2015 at 1:33:55 PM UTC-7, Barret Rennie wrote:

 Hi John, 

 Yes thats what I mean. I’ll take a look at it. 

 Can you tell me what version of six is installed? 

 python-six-1.3.0-4.el7.noarch 

 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #4 on issue 3891 by rodolfo@gmail.com: Error adding new  
mercurial repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

is this good enough?

Attachments:
full.png  118 KB

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #3 on issue 3891 by trowb...@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

OK, I believe the issue is you have an extra : character at the end of the  
hostname in your URL, so it's trying to parse out a port that isn't there.  
If you get rid of that character, it ought to work.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #5 on issue 3891 by rodolfo@gmail.com: Error adding new  
mercurial repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

then, how you define the path through ssh protocol?

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #6 on issue 3891 by trowb...@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

I believe if you do: ssh://xxx.oracle.com/hgroot/... it should work (note  
that you have :// where you should just have /).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #7 on issue 3891 by trowb...@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

I believe if you do: ssh://xxx.oracle.com/hgroot/... it should work (note  
that you have :// where you should just have /).


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard


Comment #8 on issue 3891 by rodolfo@gmail.com: Error adding new  
mercurial repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

my mistake, you are right!
thanks

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


Re: Issue 3891 in reviewboard: Error adding new mercurial repository

2015-06-18 Thread reviewboard

Updates:
Status: New
Labels: EasyFix Component-Admin BetterErrors

Comment #9 on issue 3891 by trowb...@gmail.com: Error adding new mercurial  
repository

https://code.google.com/p/reviewboard/issues/detail?id=3891

I'm going to keep this open because we should have a better error message.

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
reviewboard-issues group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard-issues+unsubscr...@googlegroups.com.
To post to this group, send email to reviewboard-issues@googlegroups.com.
Visit this group at http://groups.google.com/group/reviewboard-issues.
For more options, visit https://groups.google.com/d/optout.


email issue on RB group vs people

2015-06-18 Thread MoonWalker
I have noticed this issue since several versions, not sure if this is a 
know issue or something else in my configuration, but basically in 
Reviewers  I need to add each team member to People, because if I add the 
group they wont receive any email. not sure why.

All these people are part of the same group, but still not email.

BTW I am using the latest RB version

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: email issue on RB group vs people

2015-06-18 Thread David Trowbridge
Does the group have a mailing list configured? If so, e-mail to that group
will be sent only to the list and not to the group members.

-David

On Thu, Jun 18, 2015 at 5:11 PM, MoonWalker daniel.cabrera...@gmail.com
wrote:

 I have noticed this issue since several versions, not sure if this is a
 know issue or something else in my configuration, but basically in
 Reviewers  I need to add each team member to People, because if I add the
 group they wont receive any email. not sure why.

 All these people are part of the same group, but still not email.

 BTW I am using the latest RB version

 --
 Supercharge your Review Board with Power Pack:
 https://www.reviewboard.org/powerpack/
 Want us to host Review Board for you? Check out RBCommons:
 https://rbcommons.com/
 Happy user? Let us know! https://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.


-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Review Board 2.0.16 is released, with security fixes and more

2015-06-18 Thread Paul Fee
Hi Stephen,

The 2.0.17 packages for EPEL7 worked as expected, karma dispensed.

Thanks to all those that contributed to 2.0.16 and 2.0.17, I especially 
liked the fixes to the interdiff version selector as that was bugging me.  
The performance improvements are also nice to see.

Cheers,
Paul

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Asking about mapping of review board orig to git commit hash

2015-06-18 Thread bachldx
Hi,

We are currently studying your tool for our research.

We were wondering from review board code review, how do we know which 
revision in the revision history of the code base
is being review? For example, you have the notion of orig, which is the 
original revision. How do we know what is actually
the original revision in the git repository, ie., what is the commit hash 
of this orig?

I look forward to hearing your reply.
Thanks a lot.

Regards,

Bach.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.