Perforce server security level error when post a review

2009-06-29 Thread Jason Lee

Hi guys,

I met another problem when post a perforce review.

I install the RB on Windows.
The command is : post-review.py -d 118527
And then I met a perforce exception.

The logs are below:

P4Exception at /api/json/reviewrequests/new/

[P4#run] Errors during command execution( "p4 describe -s 118527" )

[Error]: Password not allowed at this server security level, use 'p4
login'.


Request Method: POST
Request URL:http://127.0.0.1:80/api/json/reviewrequests/new/
Exception Type: P4Exception
Exception Value:

[P4#run] Errors during command execution( "p4 describe -s 118527" )

[Error]: Password not allowed at this server security level, use 'p4
login'.


Exception Location: C:\Python25\lib\site-packages\P4.py in run, line
284
Python Executable:  D:\Program Files\Apache Software Foundation
\Apache2.2\bin\httpd.exe
Python Version: 2.5.4
Python Path:
Server time:Fri, 26 Jun 2009 17:56:01 +0800
===

I think that's because of the higher P4 server security level. Because
when I use my own perforce server with default security level, I can
post the review successfully.

Anyone knows how to fix this problem?
Thanks.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Enable Search?

2009-06-29 Thread grimbeaver

Seems it's throwing an exception because the search indexes do not
exist.  What creates these files?  The folder gets created when I
enable search but there are never any files in it.  Did I miss a step?

Environment:

Request Method: GET
Request URL: http://10.10.10.97/r/search/
Django Version: 1.0.2 final
Python Version: 2.6.2
Installed Applications:
['django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.markup',
 'django.contrib.sites',
 'django.contrib.sessions',
 'djblets.datagrid',
 'djblets.feedview',
 'djblets.siteconfig',
 'djblets.util',
 'djblets.webapi',
 'reviewboard.accounts',
 'reviewboard.admin',
 'reviewboard.changedescs',
 'reviewboard.diffviewer',
 'reviewboard.iphone',
 'reviewboard.reports',
 'reviewboard.reviews',
 'reviewboard.scmtools',
 'reviewboard.webapi',
 'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.doc.XViewMiddleware',
 'django.middleware.http.ConditionalGetMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'djblets.siteconfig.middleware.SettingsMiddleware',
 'reviewboard.admin.middleware.LoadSettingsMiddleware',
 'djblets.log.middleware.LoggingMiddleware',
 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')


Traceback:
File "/usr/local/lib/python2.6/dist-packages/Django-1.0.2_final-
py2.6.egg/django/core/handlers/base.py" in get_response
  86. response = callback(request, *callback_args,
**callback_kwargs)
File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/
reviewboard/reviews/views.py" in search
  743. raise e

Exception Type: JavaError at /r/search/
Exception Value: java.io.FileNotFoundException: no segments* file
found in org.apache.lucene.store.FSDirectory@/tmp/rbsearch_index:
files:


On Jun 26, 3:51 pm, Christian Hammond  wrote:
> If you set DEBUG = True in your site's conf/settings_local.py and restart
> Apache, you should be able to get more debug information for the 500.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Fri, Jun 26, 2009 at 6:58 AM, grimbeaver  wrote:
>
> > I removed the packages for PyLucene and JCC.  I downloaded and built
> > the source.  I can enable search now.  However when I try to use it I
> > get an Error 500 and the directory for the index gets created but is
> > empty.  Starting to think about giving up on search for now.
>
> > On Jun 26, 8:03 am, grimbeaver  wrote:
> > > Thanks.  That answers what's wrong.  The PyLucene package in Ubuntu
> > > 9.04 is built against Python 2.5 (http://packages.ubuntu.com/jaunty/
> > > pylucene).  But mod_python is built using Python 2.6 (http://
> > > packages.ubuntu.com/jaunty/libapache2-mod-python).  So much for the
> > > idea of using Ubuntu 9.04 to avoid manually building PyLucene.
> > > Guessing there's no way around this.
>
> > > On Jun 26, 1:39 am, Christian Hammond  wrote:
>
> > > > Hi,
>
> > > > Run python, and type:
>
> > > >     import lucene
>
> > > > That's basically the entire check we use for search. If that fails,
> > then
> > > > PyLucene isn't properly installed.
>
> > > > Also make sure the version of Python that's being used to run Review
> > Board
> > > > matches the version used to install PyLucene.
>
> > > > Christian
>
> > > > --
> > > > Christian Hammond - chip...@chipx86.com
> > > > Review Board -http://www.review-board.org
> > > > VMware, Inc. -http://www.vmware.com
>
> > > > On Thu, Jun 25, 2009 at 11:22 AM, grimbeaver 
> > wrote:
>
> > > > > I've just installed on Ubuntu 9.04.  Everything is working great,
> > > > > included AD.  But I can not get it to allow me to enable search.
> >  I've
> > > > > installed the packages for PyLucene and JCC via APT.  Anyone know
> > what
> > > > > I might be missing?  Where would I look for an error to give me a
> > clue?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Perforce server security level error when post a review

2009-06-29 Thread Tom Sakkos
I wouldn't know where to put this in ReviewBoard, but it's probably
necessary to run "run_login()" on the p4 object immediately after running
"connect()."

-Tom


On Mon, Jun 29, 2009 at 2:13 AM, Jason Lee  wrote:

>
> Hi guys,
>
> I met another problem when post a perforce review.
>
> I install the RB on Windows.
> The command is : post-review.py -d 118527
> And then I met a perforce exception.
>
> The logs are below:
> 
> P4Exception at /api/json/reviewrequests/new/
>
> [P4#run] Errors during command execution( "p4 describe -s 118527" )
>
>[Error]: Password not allowed at this server security level, use 'p4
> login'.
>
>
> Request Method: POST
> Request URL:http://127.0.0.1:80/api/json/reviewrequests/new/
> Exception Type: P4Exception
> Exception Value:
>
> [P4#run] Errors during command execution( "p4 describe -s 118527" )
>
>[Error]: Password not allowed at this server security level, use 'p4
> login'.
>
>
> Exception Location: C:\Python25\lib\site-packages\P4.py in run, line
> 284
> Python Executable:  D:\Program Files\Apache Software Foundation
> \Apache2.2\bin\httpd.exe
> Python Version: 2.5.4
> Python Path:
> Server time:Fri, 26 Jun 2009 17:56:01 +0800
> ===
>
> I think that's because of the higher P4 server security level. Because
> when I use my own perforce server with default security level, I can
> post the review successfully.
>
> Anyone knows how to fix this problem?
> Thanks.
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Diff viewer syntax highlighting for ColdFusion

2009-06-29 Thread Eric P

Hi,

I noticed (not too surprised) that diffs of ColdFusion code doesn't
appear supported in Review Board's diff view.

It *might* be sufficient to have the diff viewer interpret ColdFusion
as HTML.  Would it be possible to have RB throw all .cfm and .cfc
files at the HTML parser?  Where would I look to make that change?

Thanks,
Eric P

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



How do you enable logging without going through dashboard?

2009-06-29 Thread Ankit

Hi,

I am installing the reviewboard for the first time.  After I followed
all the steps, I keep getting 500 - internal server error. Apache's
error log does not show any errors.  The logs folder for the
installation is empty.  Does anyone know how I can enable the logging
given that I can't access the dashboard at all?

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



HTTPS certificate not accepted

2009-06-29 Thread Daniel

Hi,

I am new to ReviewBoard 1.0 and trying to configure RB with SVN. I got
RB installed but when I try to create a new Review Request, it comes
back with an error:

"HTTPS certificate not accepted. Please ensure that the proper
certificate exists in H:\ /.subversion/auth for the user that
reviewboard is running as."

I don't have any idea why it is looking for a certificate on H:\. On
my system there is an environment variable HOMEDRIVE which is set to H:
\. I read somewhere that this might be caused by Apache home directory
points to a wrong place, but not sure where I can change this. I am
able to do all SVN operations outside ReviewBoard

Any clue?

Thanks
Daniel

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: run_describe missing in P4.py

2009-06-29 Thread angeliti

@Christian:

If install P4PythonInstaller using easy_install and run it, it tells
me:

Download the Windows installer at:
http://public.perforce.com/guest/robert_cowham/perforce/API/python/index.html

That is the version I was using previously and which doesn't have the
function "run_describe".


@Paul:

I've gone to the perforce official FTP server (ftp://ftp.perforce.com/
perforce/) and downloaded the latest version (r09.1) of p4python from
there: ftp://ftp.perforce.com/perforce/r09.1/bin.ntx86/p4python25.exe.
However, that version doesn't have the "run_describe" function either.


Can you please check your P4.py file (C:\Python25\Lib\site-packages
\P4.py) and see if you have "run_describe" there?

Thanks!
Angel.-


On Jun 27, 12:41 am, Christian Hammond  wrote:
> You should be able to install the latest by doing:
>
> easy_install P4PythonInstaller
>
> This is our wrapper package that fetches the right version of the P4 Python
> bindings and the C library.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Fri, Jun 26, 2009 at 9:40 PM, Paul Scott  wrote:
>
> > Perforce now officially supports the p4 python API. The version in the
> > public depot is deprecated; you can pick up a current version from
> > Perforce's ftp site 
> > (seehttp://www.perforce.com/perforce/loadsupp.htmlfordetails).
>
> > -- Paul
> > 
> > From: reviewboard@googlegroups.com [reviewbo...@googlegroups.com] On
> > Behalf Of angeliti [angel...@gmail.com]
> > Sent: Friday, June 26, 2009 5:01 PM
> > To: reviewboard
> > Subject: run_describe missing in P4.py
>
> > Hello!
>
> > Line 60 of reviewboard.scmtools.perforce is:
>
> > changeset = self.p4.run_describe('-s', str(changesetid))
>
> > However, the function "run_describe" doesn't exist in p4python
> > (P4.py). This results in a "Error creating review request: The change
> > number specified could not be found (Code 203)" when trying to run
> > post-review.
>
> > Any ideas of what is the problem here? I downloaded the last version
> > of p4python for Windows from here:
>
> >http://public.perforce.com/guest/robert_cowham/perforce/API/python/in...
> > .
>
> > Thank you very much!
> > Angel.-
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Windows install document incomplete?

2009-06-29 Thread MarkJWolff

I'm installing reviewboard on a windows server.  I am going through
the "pre-install" steps with memcached, patch, etc.  Suddenly, the
documentation says "After Installation"  I wasn't actually told to
install reviewboard.

Comparing the Windows install doc to the install UNIX doc, I see that
actual reviewboard install and the connection to a source code system
steps seem to be missing from the Windows version of the document.

Is Windows "more automatic" than the Linux version, or is there just a
documentation gap?

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Enable Search?

2009-06-29 Thread Christian Hammond
You need to run a command periodically to update the search index, through a
scheduled task. Specifically:

rb-site manage /path/to/site index -- --full

(Note the "--" in there. It's important.)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 6:41 AM, grimbeaver  wrote:

>
> Seems it's throwing an exception because the search indexes do not
> exist.  What creates these files?  The folder gets created when I
> enable search but there are never any files in it.  Did I miss a step?
>
> Environment:
>
> Request Method: GET
> Request URL: http://10.10.10.97/r/search/
> Django Version: 1.0.2 final
> Python Version: 2.6.2
> Installed Applications:
> ['django.contrib.admin',
>  'django.contrib.auth',
>  'django.contrib.contenttypes',
>  'django.contrib.markup',
>  'django.contrib.sites',
>  'django.contrib.sessions',
>  'djblets.datagrid',
>  'djblets.feedview',
>  'djblets.siteconfig',
>  'djblets.util',
>  'djblets.webapi',
>  'reviewboard.accounts',
>  'reviewboard.admin',
>  'reviewboard.changedescs',
>  'reviewboard.diffviewer',
>  'reviewboard.iphone',
>  'reviewboard.reports',
>  'reviewboard.reviews',
>  'reviewboard.scmtools',
>  'reviewboard.webapi',
>  'django_evolution']
> Installed Middleware:
> ('django.middleware.gzip.GZipMiddleware',
>  'django.middleware.common.CommonMiddleware',
>  'django.middleware.doc.XViewMiddleware',
>  'django.middleware.http.ConditionalGetMiddleware',
>  'django.middleware.locale.LocaleMiddleware',
>  'django.contrib.sessions.middleware.SessionMiddleware',
>  'django.contrib.auth.middleware.AuthenticationMiddleware',
>  'djblets.siteconfig.middleware.SettingsMiddleware',
>  'reviewboard.admin.middleware.LoadSettingsMiddleware',
>  'djblets.log.middleware.LoggingMiddleware',
>  'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware')
>
>
> Traceback:
> File "/usr/local/lib/python2.6/dist-packages/Django-1.0.2_final-
> py2.6.egg/django/core/handlers/base.py" in get_response
>  86. response = callback(request, *callback_args,
> **callback_kwargs)
> File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0-py2.6.egg/
> reviewboard/reviews/views.py" in search
>  743. raise e
>
> Exception Type: JavaError at /r/search/
> Exception Value: java.io.FileNotFoundException: no segments* file
> found in org.apache.lucene.store.FSDirectory@/tmp/rbsearch_index:
> files:
>
>
> On Jun 26, 3:51 pm, Christian Hammond  wrote:
> > If you set DEBUG = True in your site's conf/settings_local.py and restart
> > Apache, you should be able to get more debug information for the 500.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> >
> >
> > On Fri, Jun 26, 2009 at 6:58 AM, grimbeaver  wrote:
> >
> > > I removed the packages for PyLucene and JCC.  I downloaded and built
> > > the source.  I can enable search now.  However when I try to use it I
> > > get an Error 500 and the directory for the index gets created but is
> > > empty.  Starting to think about giving up on search for now.
> >
> > > On Jun 26, 8:03 am, grimbeaver  wrote:
> > > > Thanks.  That answers what's wrong.  The PyLucene package in Ubuntu
> > > > 9.04 is built against Python 2.5 (http://packages.ubuntu.com/jaunty/
> > > > pylucene).  But mod_python is built using Python 2.6 (http://
> > > > packages.ubuntu.com/jaunty/libapache2-mod-python).  So much for the
> > > > idea of using Ubuntu 9.04 to avoid manually building PyLucene.
> > > > Guessing there's no way around this.
> >
> > > > On Jun 26, 1:39 am, Christian Hammond  wrote:
> >
> > > > > Hi,
> >
> > > > > Run python, and type:
> >
> > > > > import lucene
> >
> > > > > That's basically the entire check we use for search. If that fails,
> > > then
> > > > > PyLucene isn't properly installed.
> >
> > > > > Also make sure the version of Python that's being used to run
> Review
> > > Board
> > > > > matches the version used to install PyLucene.
> >
> > > > > Christian
> >
> > > > > --
> > > > > Christian Hammond - chip...@chipx86.com
> > > > > Review Board -http://www.review-board.org
> > > > > VMware, Inc. -http://www.vmware.com
> >
> > > > > On Thu, Jun 25, 2009 at 11:22 AM, grimbeaver 
> > > wrote:
> >
> > > > > > I've just installed on Ubuntu 9.04.  Everything is working great,
> > > > > > included AD.  But I can not get it to allow me to enable search.
> > >  I've
> > > > > > installed the packages for PyLucene and JCC via APT.  Anyone know
> > > what
> > > > > > I might be missing?  Where would I look for an error to give me a
> > > clue?
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewbo

Re: How do you enable logging without going through dashboard?

2009-06-29 Thread Christian Hammond
Hi,

Go into your site's conf/settings_local.py and set DEBUG to True. Then
restart Apache and you should see a more detailed error page.

You'll want to set this back to False after you figure out what's wrong.
There are small performance hits with having DEBUG on.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 10:34 AM, Ankit  wrote:

>
> Hi,
>
> I am installing the reviewboard for the first time.  After I followed
> all the steps, I keep getting 500 - internal server error. Apache's
> error log does not show any errors.  The logs folder for the
> installation is empty.  Does anyone know how I can enable the logging
> given that I can't access the dashboard at all?
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: HTTPS certificate not accepted

2009-06-29 Thread Christian Hammond
Hi Daniel,

>From what I've seen, it seems tricky to get this to work right through
Apache. What I'd strongly recommend, if possible, is to set a plain http
repository for the path and use the https repository for the mirror path.
The idea being that Review Board would just simply fetch the files from the
http repository and the mirror path would be what Review Board checks when
developers are posting changes for review.

If you can't do this, then I think what you need to do is attempt to access
the server through https using your user and then move your .subversion
directory into wherever Apache is trying to find it. You can probably set an
environment variable in the Apache configuration file (using SetEnv) to
change this path.

I'd like to make this easier in 1.1 or so. I know it's bitten a lot of
people.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 1:34 PM, Daniel  wrote:

>
> Hi,
>
> I am new to ReviewBoard 1.0 and trying to configure RB with SVN. I got
> RB installed but when I try to create a new Review Request, it comes
> back with an error:
>
> "HTTPS certificate not accepted. Please ensure that the proper
> certificate exists in H:\ /.subversion/auth for the user that
> reviewboard is running as."
>
> I don't have any idea why it is looking for a certificate on H:\. On
> my system there is an environment variable HOMEDRIVE which is set to H:
> \. I read somewhere that this might be caused by Apache home directory
> points to a wrong place, but not sure where I can change this. I am
> able to do all SVN operations outside ReviewBoard
>
> Any clue?
>
> Thanks
> Daniel
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Windows install document incomplete?

2009-06-29 Thread Christian Hammond
Looks like there's an installation gap. I'll make a note to fix this.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 1:04 PM, MarkJWolff  wrote:

>
> I'm installing reviewboard on a windows server.  I am going through
> the "pre-install" steps with memcached, patch, etc.  Suddenly, the
> documentation says "After Installation"  I wasn't actually told to
> install reviewboard.
>
> Comparing the Windows install doc to the install UNIX doc, I see that
> actual reviewboard install and the connection to a source code system
> steps seem to be missing from the Windows version of the document.
>
> Is Windows "more automatic" than the Linux version, or is there just a
> documentation gap?
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



RE: run_describe missing in P4.py

2009-06-29 Thread Paul Scott

> Can you please check your P4.py file (C:\Python25\Lib\site-packages\P4.py) 
> and see if you have "run_describe" there?

Ahh, I didn't realize that you were looking for one directly in the source 
file. There isn't an explicit run_describe function to be found. The module 
plays some games with __getattr__ such that any function "run_foo(args)" is 
basically turned into "run(foo, args)". The code which does that is near the 
top of P4ClientHandler.

-- Paul
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: Diff viewer syntax highlighting for ColdFusion

2009-06-29 Thread Christian Hammond
Hi Eric,

Right now, you'd have to hand-modify Pygments (the syntax highlighter
library we use) or part of Review Board to force a particular syntax
highlighter. In 1.1, I'm hoping to provide a setting for forcing
highlighters for file types.

It's probably best to file a bug report with the Pygments guys and ask them
about plans for ColdFusion syntax highlighters.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 9:53 AM, Eric P  wrote:

>
> Hi,
>
> I noticed (not too surprised) that diffs of ColdFusion code doesn't
> appear supported in Review Board's diff view.
>
> It *might* be sufficient to have the diff viewer interpret ColdFusion
> as HTML.  Would it be possible to have RB throw all .cfm and .cfc
> files at the HTML parser?  Where would I look to make that change?
>
> Thanks,
> Eric P
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



View diff is failing

2009-06-29 Thread henriquecoelho

Hi all,

I'm having a problem viewing the diff file that i've upload in new
review request. I've activated the debug level for reviewboard and i'm
getting the following output when i access to view diff in right top
corner:

[Error 2] The system cannot find the file specified

Traceback (most recent call last):
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\views.py", line 152, in view_diff
interdiffset, highlighting, True)
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
large_data=True)
  File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
\util\misc.py", line 143, in cache_memoize
data = lookup_callable()
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 622, in 
enable_syntax_highlighting),
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
new = get_patched_file(old, filediff)
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 109, in patch
stderr=subprocess.STDOUT)
  File "C:\Python25\Lib\subprocess.py", line 594, in __init__
errread, errwrite)
  File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

I'm not sure if this is sufficiently clear to you but if someone havy
an ideia about this please let me know how to workaround this. I think
that this could be due the problem with diff file so the steps that i
made to upload the new review diff file were:

-New review request
-choose the repository (example in my case)
-base diff path : /
-diff: c:\example\

The diff file:

Index: Apache2/conf/httpd.conf
===
--- Apache2/conf/httpd.conf (revision 3)
+++ Apache2/conf/httpd.conf (working copy)
@@ -467,4 +467,29 @@
AllowOverride All
 

+<<< .mine
+#
+#  Order deny,allow
+#  Allow from all
+#
+
+#Alias /moopion "C:\example\source\example\web"
+
+#
+#  AllowOverride All
+#
+
+
+  Order deny,allow
+  Allow from all
+
+
+Alias /sso "C:\example\source\sso\webdir"
+
+
+  AllowOverride All
+
+
+===
+>>> .r3
 AllowEncodedSlashes On

Thanks in advance. Please if you need some specific further
information, let me know.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: View diff is failing

2009-06-29 Thread Christian Hammond
GNU patch.exe must be in the path for this to work. It appears that it's not
able to find this.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 4:33 PM, henriquecoelho wrote:

>
> Hi all,
>
> I'm having a problem viewing the diff file that i've upload in new
> review request. I've activated the debug level for reviewboard and i'm
> getting the following output when i access to view diff in right top
> corner:
>
> [Error 2] The system cannot find the file specified
>
> Traceback (most recent call last):
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\views.py", line 152, in view_diff
>interdiffset, highlighting, True)
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
>large_data=True)
>  File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
> \util\misc.py", line 143, in cache_memoize
>data = lookup_callable()
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\diffutils.py", line 622, in 
>enable_syntax_highlighting),
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
>new = get_patched_file(old, filediff)
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
>return patch(filediff.diff, buffer, filediff.dest_file)
>  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> \reviewboard\diffviewer\diffutils.py", line 109, in patch
>stderr=subprocess.STDOUT)
>  File "C:\Python25\Lib\subprocess.py", line 594, in __init__
>errread, errwrite)
>  File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
>startupinfo)
> WindowsError: [Error 2] The system cannot find the file specified
>
> I'm not sure if this is sufficiently clear to you but if someone havy
> an ideia about this please let me know how to workaround this. I think
> that this could be due the problem with diff file so the steps that i
> made to upload the new review diff file were:
>
> -New review request
> -choose the repository (example in my case)
> -base diff path : /
> -diff: c:\example\
>
> The diff file:
>
> Index: Apache2/conf/httpd.conf
> ===
> --- Apache2/conf/httpd.conf (revision 3)
> +++ Apache2/conf/httpd.conf (working copy)
> @@ -467,4 +467,29 @@
>AllowOverride All
>  
>
> +<<< .mine
> +#
> +#  Order deny,allow
> +#  Allow from all
> +#
> +
> +#Alias /moopion "C:\example\source\example\web"
> +
> +#
> +#  AllowOverride All
> +#
> +
> +
> +  Order deny,allow
> +  Allow from all
> +
> +
> +Alias /sso "C:\example\source\sso\webdir"
> +
> +
> +  AllowOverride All
> +
> +
> +===
> +>>> .r3
>  AllowEncodedSlashes On
>
> Thanks in advance. Please if you need some specific further
> information, let me know.
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: View diff is failing

2009-06-29 Thread henriquecoelho

Thanks for the quick review :)

In fact i had already the GNU patch.exe installed but not in the path.
I've set the C:\Program Files\GnuWin32\bin\ in the path and the
patch.exe is already defined in the environment vars, however the
error still appears. I'm using apache, so after set in environment the
previous path i've restarted the server but without success. Any other
suggestion?

On 30 Jun, 00:37, Christian Hammond  wrote:
> GNU patch.exe must be in the path for this to work. It appears that it's not
> able to find this.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Mon, Jun 29, 2009 at 4:33 PM, henriquecoelho 
> wrote:
>
>
>
> > Hi all,
>
> > I'm having a problem viewing the diff file that i've upload in new
> > review request. I've activated the debug level for reviewboard and i'm
> > getting the following output when i access to view diff in right top
> > corner:
>
> > [Error 2] The system cannot find the file specified
>
> > Traceback (most recent call last):
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\views.py", line 152, in view_diff
> >    interdiffset, highlighting, True)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
> >    large_data=True)
> >  File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
> > \util\misc.py", line 143, in cache_memoize
> >    data = lookup_callable()
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 622, in 
> >    enable_syntax_highlighting),
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
> >    new = get_patched_file(old, filediff)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
> >    return patch(filediff.diff, buffer, filediff.dest_file)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 109, in patch
> >    stderr=subprocess.STDOUT)
> >  File "C:\Python25\Lib\subprocess.py", line 594, in __init__
> >    errread, errwrite)
> >  File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
> >    startupinfo)
> > WindowsError: [Error 2] The system cannot find the file specified
>
> > I'm not sure if this is sufficiently clear to you but if someone havy
> > an ideia about this please let me know how to workaround this. I think
> > that this could be due the problem with diff file so the steps that i
> > made to upload the new review diff file were:
>
> > -New review request
> > -choose the repository (example in my case)
> > -base diff path : /
> > -diff: c:\example\
>
> > The diff file:
>
> > Index: Apache2/conf/httpd.conf
> > ===
> > --- Apache2/conf/httpd.conf     (revision 3)
> > +++ Apache2/conf/httpd.conf     (working copy)
> > @@ -467,4 +467,29 @@
> >        AllowOverride All
> >  
>
> > +<<< .mine
> > +#
> > +#  Order deny,allow
> > +#  Allow from all
> > +#
> > +
> > +#Alias /moopion "C:\example\source\example\web"
> > +
> > +#
> > +#  AllowOverride All
> > +#
> > +
> > +
> > +  Order deny,allow
> > +  Allow from all
> > +
> > +
> > +Alias /sso "C:\example\source\sso\webdir"
> > +
> > +
> > +  AllowOverride All
> > +
> > +
> > +===
> > +>>> .r3
> >  AllowEncodedSlashes On
>
> > Thanks in advance. Please if you need some specific further
> > information, let me know.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: View diff is failing

2009-06-29 Thread henriquecoelho

I should add that the diff file was generated with tortoisesvn,
creating a patch... Is there any known issue creating the diff in this
way?

On 30 Jun, 00:37, Christian Hammond  wrote:
> GNU patch.exe must be in the path for this to work. It appears that it's not
> able to find this.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
> On Mon, Jun 29, 2009 at 4:33 PM, henriquecoelho 
> wrote:
>
>
>
> > Hi all,
>
> > I'm having a problem viewing the diff file that i've upload in new
> > review request. I've activated the debug level for reviewboard and i'm
> > getting the following output when i access to view diff in right top
> > corner:
>
> > [Error 2] The system cannot find the file specified
>
> > Traceback (most recent call last):
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\views.py", line 152, in view_diff
> >    interdiffset, highlighting, True)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
> >    large_data=True)
> >  File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
> > \util\misc.py", line 143, in cache_memoize
> >    data = lookup_callable()
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 622, in 
> >    enable_syntax_highlighting),
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
> >    new = get_patched_file(old, filediff)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
> >    return patch(filediff.diff, buffer, filediff.dest_file)
> >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > \reviewboard\diffviewer\diffutils.py", line 109, in patch
> >    stderr=subprocess.STDOUT)
> >  File "C:\Python25\Lib\subprocess.py", line 594, in __init__
> >    errread, errwrite)
> >  File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
> >    startupinfo)
> > WindowsError: [Error 2] The system cannot find the file specified
>
> > I'm not sure if this is sufficiently clear to you but if someone havy
> > an ideia about this please let me know how to workaround this. I think
> > that this could be due the problem with diff file so the steps that i
> > made to upload the new review diff file were:
>
> > -New review request
> > -choose the repository (example in my case)
> > -base diff path : /
> > -diff: c:\example\
>
> > The diff file:
>
> > Index: Apache2/conf/httpd.conf
> > ===
> > --- Apache2/conf/httpd.conf     (revision 3)
> > +++ Apache2/conf/httpd.conf     (working copy)
> > @@ -467,4 +467,29 @@
> >        AllowOverride All
> >  
>
> > +<<< .mine
> > +#
> > +#  Order deny,allow
> > +#  Allow from all
> > +#
> > +
> > +#Alias /moopion "C:\example\source\example\web"
> > +
> > +#
> > +#  AllowOverride All
> > +#
> > +
> > +
> > +  Order deny,allow
> > +  Allow from all
> > +
> > +
> > +Alias /sso "C:\example\source\sso\webdir"
> > +
> > +
> > +  AllowOverride All
> > +
> > +
> > +===
> > +>>> .r3
> >  AllowEncodedSlashes On
>
> > Thanks in advance. Please if you need some specific further
> > information, let me know.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---



Re: View diff is failing

2009-06-29 Thread Christian Hammond
Yeah, TortoiseSVN definitely won't work. They generate slightly incompatible
diffs. We might be able to work around it at some point, but someone would
probably have to contribute a patch for that.

However, the "the system cannot find the file specified" error is definitely
Apache not finding patch.exe.

Maybe try rebooting? :)

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 29, 2009 at 4:52 PM, henriquecoelho wrote:

>
> I should add that the diff file was generated with tortoisesvn,
> creating a patch... Is there any known issue creating the diff in this
> way?
>
> On 30 Jun, 00:37, Christian Hammond  wrote:
> > GNU patch.exe must be in the path for this to work. It appears that it's
> not
> > able to find this.
> >
> > Christian
> >
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
> >
> > On Mon, Jun 29, 2009 at 4:33 PM, henriquecoelho <
> henrike.coe...@gmail.com>wrote:
> >
> >
> >
> > > Hi all,
> >
> > > I'm having a problem viewing the diff file that i've upload in new
> > > review request. I've activated the debug level for reviewboard and i'm
> > > getting the following output when i access to view diff in right top
> > > corner:
> >
> > > [Error 2] The system cannot find the file specified
> >
> > > Traceback (most recent call last):
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\views.py", line 152, in view_diff
> > >interdiffset, highlighting, True)
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
> > >large_data=True)
> > >  File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
> > > \util\misc.py", line 143, in cache_memoize
> > >data = lookup_callable()
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\diffutils.py", line 622, in 
> > >enable_syntax_highlighting),
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
> > >new = get_patched_file(old, filediff)
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
> > >return patch(filediff.diff, buffer, filediff.dest_file)
> > >  File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
> > > \reviewboard\diffviewer\diffutils.py", line 109, in patch
> > >stderr=subprocess.STDOUT)
> > >  File "C:\Python25\Lib\subprocess.py", line 594, in __init__
> > >errread, errwrite)
> > >  File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
> > >startupinfo)
> > > WindowsError: [Error 2] The system cannot find the file specified
> >
> > > I'm not sure if this is sufficiently clear to you but if someone havy
> > > an ideia about this please let me know how to workaround this. I think
> > > that this could be due the problem with diff file so the steps that i
> > > made to upload the new review diff file were:
> >
> > > -New review request
> > > -choose the repository (example in my case)
> > > -base diff path : /
> > > -diff: c:\example\
> >
> > > The diff file:
> >
> > > Index: Apache2/conf/httpd.conf
> > > ===
> > > --- Apache2/conf/httpd.conf (revision 3)
> > > +++ Apache2/conf/httpd.conf (working copy)
> > > @@ -467,4 +467,29 @@
> > >AllowOverride All
> > >  
> >
> > > +<<< .mine
> > > +#
> > > +#  Order deny,allow
> > > +#  Allow from all
> > > +#
> > > +
> > > +#Alias /moopion "C:\example\source\example\web"
> > > +
> > > +#
> > > +#  AllowOverride All
> > > +#
> > > +
> > > +
> > > +  Order deny,allow
> > > +  Allow from all
> > > +
> > > +
> > > +Alias /sso "C:\example\source\sso\webdir"
> > > +
> > > +
> > > +  AllowOverride All
> > > +
> > > +
> > > +===
> > > +>>> .r3
> > >  AllowEncodedSlashes On
> >
> > > Thanks in advance. Please if you need some specific further
> > > information, let me know.
>
> >
>

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---