Re: Review Request 46751: Ambari metrics API call should allow for early failure

[Sid Wagle]

> On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java,
> >  line 209
> > 
> >
> > should the change be conditional - for FS that can provide high 
> > throughput we have not had the need for these changes. IOW, what are the 
> > downside of these changes?

Not really necessary since this used to be the behavior prior to 2.1.2 / cache 
introduction. We want to fail fast to avoid compounding the timeouts by making 
multiple AMS calls for a single Ambari request.


> On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java,
> >  line 70
> > 
> >
> > How long before timeout is hit?

Timeouts are configurable. Cache miss = 10 seconds, Cache update = 10 (default) 
The update can be tuned to a lower value for a slow performing metrics system.


> On April 28, 2016, 4:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java,
> >  line 92
> > 
> >
> > Typically how long is the delay after which it will throw the exception.

10 seconds.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46751/#review130880
---


On April 27, 2016, 9:47 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46751/
> ---
> 
> (Updated April 27, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16143
> https://issues.apache.org/jira/browse/AMBARI-16143
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of a SocketTimeoutException skip populating the resource with metrics 
> until the next retry.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  939ee7f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
>  8b60c50 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
>  ca20e54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
>  9e343e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
>  e8a2aef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  ce865cf 
> 
> Diff: https://reviews.apache.org/r/46751/diff/
> 
> 
> Testing
> ---
> 
> Added a unit test. Manually verified the patch works on a cluster.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 46751: Ambari metrics API call should allow for early failure

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46751/#review130880
---




ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 (line 209)


should the change be conditional - for FS that can provide high throughput 
we have not had the need for these changes. IOW, what are the downside of these 
changes?



ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
 (line 70)


How long before timeout is hit?



ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
 (line 92)


Typically how long is the delay after which it will throw the exception.


- Sumit Mohanty


On April 27, 2016, 9:47 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46751/
> ---
> 
> (Updated April 27, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16143
> https://issues.apache.org/jira/browse/AMBARI-16143
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case of a SocketTimeoutException skip populating the resource with metrics 
> until the next retry.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  939ee7f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
>  8b60c50 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
>  ca20e54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
>  9e343e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
>  e8a2aef 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
>  ce865cf 
> 
> Diff: https://reviews.apache.org/r/46751/diff/
> 
> 
> Testing
> ---
> 
> Added a unit test. Manually verified the patch works on a cluster.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 46703: Reduce error logs on the Sink path if AMS is down

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46703/#review130881
---


Ship it!




Ship It!

- Sid Wagle


On April 26, 2016, 3:13 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46703/
> ---
> 
> (Updated April 26, 2016, 3:13 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16123
> https://issues.apache.org/jira/browse/AMBARI-16123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should do something similar to AMSPropertyProvider where we print the 
> message every 1000 attempts per thread. Note: Only first message should 
> always be printed.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  5a532c5 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  4c1a2cb 
> 
> Diff: https://reviews.apache.org/r/46703/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/#review130878
---


Ship it!




Fix the issues and ship.

- Sumit Mohanty


On April 28, 2016, 1:41 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46760/
> ---
> 
> (Updated April 28, 2016, 1:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16149
> https://issues.apache.org/jira/browse/AMBARI-16149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Checks LLAP app status by running Hive Server2 " --service llapstatus 
> --name " command.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
> 9f0466c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46760/diff/
> 
> 
> Testing
> ---
> 
> Python UT passes.
> 
> 
> File Attachments
> 
> 
> App in COMPLETE state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
> App in RUNNING_ALL state . Cluster un-Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
> App in LAUNCHING state . Cluster Kerberized.
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 46760: AMBARI-16149. Support for LLAP alert in Ambari

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46760/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
Mohanty.


Bugs: AMBARI-16149
https://issues.apache.org/jira/browse/AMBARI-16149


Repository: ambari


Description
---

- Checks LLAP app status by running Hive Server2 " --service llapstatus --name 
" command.


Diffs
-

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/alerts.json 
9f0466c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_llap_app_status.py
 PRE-CREATION 

Diff: https://reviews.apache.org/r/46760/diff/


Testing
---

Python UT passes.


File Attachments


App in COMPLETE state . Cluster Kerberized.
  
https://reviews.apache.org/media/uploaded/files/2016/04/28/7647a8e8-df5e-4d62-a6a5-0c13d7e47e96__Screen_Shot_2016-04-27_at_6.26.49_PM.png
App in RUNNING_ALL state . Cluster un-Kerberized.
  
https://reviews.apache.org/media/uploaded/files/2016/04/28/deaef102-4b0a-42a0-8262-31d357509048__Screen_Shot_2016-04-27_at_5.59.32_PM.png
App in LAUNCHING state . Cluster Kerberized.
  
https://reviews.apache.org/media/uploaded/files/2016/04/28/7a9c5482-f8e2-43e0-b9f9-08e5a62ed97b__Screen_Shot_2016-04-27_at_6.40.46_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/#review130865
---


Ship it!




Ship It!

- Lav Jain


On April 27, 2016, 11:16 p.m., Goutam Tadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46752/
> ---
> 
> (Updated April 27, 2016, 11:16 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16147
> https://issues.apache.org/jira/browse/AMBARI-16147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When installing HDFS/HIVE/any service the properties that are marked final 
> before installation are marked as de-finalized post installation. This occurs 
> at the last step of installation i.e deploy stage.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard.js 52fb241 
> 
> Diff: https://reviews.apache.org/r/46752/diff/
> 
> 
> Testing
> ---
> 
> Yes, Tested manually.
> 
> 27704 tests complete (25 seconds)
> INFO] 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 57.007s
> [INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
> [INFO] Final Memory: 9M/43M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

(Updated April 27, 2016, 11:16 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs (updated)
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi

Re: Review Request 46714: Prevent Views From Causing a Loss of Service For Ambari

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46714/#review130861
---


Ship it!




Ship It!

- Jayush Luniya


On April 26, 2016, 10:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46714/
> ---
> 
> (Updated April 26, 2016, 10:03 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Nate Cole, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-16131
> https://issues.apache.org/jira/browse/AMBARI-16131
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The underlying problem is that views are accessed off of the REST endpoint 
> ({{/api/v1/views}}). This means that the Ambari REST API connector is going 
> to handle the request from its own threadpool. There is no way to configure 
> Jetty to use a different threadpool for the same connector. As a result, if a 
> request to load a view holds the Jetty thread hostage, eventually we will see 
> thread starvation and loss of service.
> 
> An example of this situation is a view which makes an innocent request to a 
> remote resource. If the view's request has a timeout of 60 seconds, then the 
> Jetty thread is going to be held for that amount of time. With concurrent 
> users and multiple instances of that view deployed, the Jetty threadpool can 
> becomes exhausted quickly.
> 
> Although there are more graceful ways of handling this situation, they mostly 
> involve substantial re-architecture and design:
> - The use of a new connector and threadpool would require binding to another 
> port for view requests. This will cause problems with "local" views and their 
> assumption that if they run on the Ambari server they can share the same 
> session.
> - The use of a 
> [Continuation|https://wiki.eclipse.org/Jetty/Feature/Continuations] in Jetty 
> which can suspend the incoming request. We would need the ability for views 
> to signal that they have completed their work in order to proceed with the 
> suspended request.
> 
> A quicker and far less invasive fix would be to create a filter which 
> intercepts requests for views. It will determine how many executing view 
> requests exist and decide if it will allow the new request through. For 
> example, if configured to allow a maximum of 10 concurrent view requests, 
> then the 11th request would be denied with an {{HTTP 503 - Service 
> Unavailable}}. Although the thread is temporarily used while the filter is 
> processing, it's quickly returned to the Jetty pool when it's determined 
> there are too many other running view requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  5ff6a74 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  dc53172 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 
> b07f7da 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d23fcad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewThrottleFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewThrottleFilterTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46714/diff/
> 
> 
> Testing
> ---
> 
> I modified an existing view to cause it to be very naughty. It held onto the 
> request for 10 seconds. Under normal Ambari operation, this caused two 
> problems:
> - The view partially rendered and needed to wait
> - Ambari's API REST thread was held hostage
> 
> I turned down the number of available threads to only a handful and then had 
> several browsers open. This duplicated the loss of service until the view 
> returned control.
> 
> With the patch in place, Ambari was available and requests to the views 
> beyond the configured limit would return a 503.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

(Updated April 27, 2016, 10:02 p.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
Lav Jain, and Matt.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi

Review Request 46752: Ambari Web Service installation does not comply with Final Attribute. (isFinal is skipped)

[Goutam Tadi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46752/
---

Review request for Ambari.


Bugs: AMBARI-16147
https://issues.apache.org/jira/browse/AMBARI-16147


Repository: ambari


Description
---

When installing HDFS/HIVE/any service the properties that are marked final 
before installation are marked as de-finalized post installation. This occurs 
at the last step of installation i.e deploy stage.


Diffs
-

  ambari-web/app/controllers/wizard.js 52fb241 

Diff: https://reviews.apache.org/r/46752/diff/


Testing
---

Yes, Tested manually.

27704 tests complete (25 seconds)
INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 57.007s
[INFO] Finished at: Wed Apr 27 22:00:48 UTC 2016
[INFO] Final Memory: 9M/43M
[INFO] 


Thanks,

Goutam Tadi

Re: Review Request 46748: Add getDeleteDirectives to org.apache.ambari.server.api.resources.ResourceDefinition

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46748/#review130851
---


Ship it!




Ship It!

- Jayush Luniya


On April 27, 2016, 8:57 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46748/
> ---
> 
> (Updated April 27, 2016, 8:57 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16142
> https://issues.apache.org/jira/browse/AMBARI-16142
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add delete directive to RequestDefinition and handle it in Delete requests. 
> It will be useful for usecases like dry run
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
>  c8bf87d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
>  f98379c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
>  88b8170 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
>  e12cb42 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java
>  d4affea 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
>  0ef4312 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
>  29bd8e9 
> 
> Diff: https://reviews.apache.org/r/46748/diff/
> 
> 
> Testing
> ---
> 
> Unit tests.
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 46750: Add dryrun API for host delete

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46750/#review130850
---


Ship it!




Ship It!

- Jayush Luniya


On April 27, 2016, 9:38 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46750/
> ---
> 
> (Updated April 27, 2016, 9:38 p.m.)
> 
> 
> Review request for Ambari, Nahappan Somasundaram, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16145
> https://issues.apache.org/jira/browse/AMBARI-16145
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> API should be take dry_run directive and check if requested host can be 
> deleted w/o deleting the host and should return error if any, like host is 
> not in delete friendly state.
> It should also support bulk delete format
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java
>  c9b0878 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  4dc47be 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  1c91477 
> 
> Diff: https://reviews.apache.org/r/46750/diff/
> 
> 
> Testing
> ---
> 
> curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true -d 
> '{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
> {
>   "deleteResult" : [
> {
>   "deleted" : {
> "key" : "c6402.ambari.apache.org"
>   }
> },
> {
>   "error" : {
> "key" : "c6401.ambari.apache.org",
> "code" : 500,
> "message" : "org.apache.ambari.server.AmbariException: Cannot remove 
> host c6401.ambari.apache.org from a.  The following roles exist, and these 
> components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
>   }
> }
>   ]
> }
> 
> curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
> 'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6401.ambari.apache.org'
> {
>   "status" : 500,
>   "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
> internal system exception occurred: Cannot remove host 
> c6401.ambari.apache.org from a.  The following roles exist, and these 
> components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
> }
> 
> 
> curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
> 'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6402.ambari.apache.org'
> 
> 200 OK
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Review Request 46751: Ambari metrics API call should allow for early failure

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46751/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, and 
Sumit Mohanty.


Bugs: AMBARI-16143
https://issues.apache.org/jira/browse/AMBARI-16143


Repository: ambari


Description
---

In case of a SocketTimeoutException skip populating the resource with metrics 
until the next retry.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 939ee7f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSReportPropertyProvider.java
 8b60c50 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/MetricsRequestHelper.java
 ca20e54 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCache.java
 9e343e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/cache/TimelineMetricCacheEntryFactory.java
 e8a2aef 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
 ce865cf 

Diff: https://reviews.apache.org/r/46751/diff/


Testing
---

Added a unit test. Manually verified the patch works on a cluster.


Thanks,

Sid Wagle

Review Request 46750: Add dryrun API for host delete

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46750/
---

Review request for Ambari, Nahappan Somasundaram, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-16145
https://issues.apache.org/jira/browse/AMBARI-16145


Repository: ambari


Description
---

API should be take dry_run directive and check if requested host can be deleted 
w/o deleting the host and should return error if any, like host is not in 
delete friendly state.
It should also support bulk delete format


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java
 c9b0878 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 4dc47be 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
 1c91477 

Diff: https://reviews.apache.org/r/46750/diff/


Testing
---

curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true -d 
'{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
{
  "deleteResult" : [
{
  "deleted" : {
"key" : "c6402.ambari.apache.org"
  }
},
{
  "error" : {
"key" : "c6401.ambari.apache.org",
"code" : 500,
"message" : "org.apache.ambari.server.AmbariException: Cannot remove 
host c6401.ambari.apache.org from a.  The following roles exist, and these 
components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
  }
}
  ]
}

curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6401.ambari.apache.org'
{
  "status" : 500,
  "message" : "org.apache.ambari.server.controller.spi.SystemException: An 
internal system exception occurred: Cannot remove host c6401.ambari.apache.org 
from a.  The following roles exist, and these components must be stopped if 
running, and then deleted: ZOOKEEPER_SERVER"
}


curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari' 
'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6402.ambari.apache.org'

200 OK


Thanks,

Ajit Kumar

Review Request 46748: Add getDeleteDirectives to org.apache.ambari.server.api.resources.ResourceDefinition

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46748/
---

Review request for Ambari, Jayush Luniya, Robert Levas, and Sumit Mohanty.


Bugs: AMBARI-16142
https://issues.apache.org/jira/browse/AMBARI-16142


Repository: ambari


Description
---

Add delete directive to RequestDefinition and handle it in Delete requests. It 
will be useful for usecases like dry run


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java
 c8bf87d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java
 f98379c 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java
 88b8170 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java
 e12cb42 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java
 d4affea 
  
ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java
 0ef4312 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java
 29bd8e9 

Diff: https://reviews.apache.org/r/46748/diff/


Testing
---

Unit tests.


Thanks,

Ajit Kumar

Re: Review Request 46460: AMBARI-16002 Integrate Red Hat Satellite option in Ambari Web

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46460/#review130839
---



Ping.  What's the status of this review?

- Nate Cole


On April 26, 2016, 8:11 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46460/
> ---
> 
> (Updated April 26, 2016, 8:11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16002
> https://issues.apache.org/jira/browse/AMBARI-16002
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide RedHat satellite option. It can be used wherever we show redhat6 
> urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
> The API call to update links when using VDF can specify the new property. In 
> order to make it more generic (and default true), it is called 
> "ambari_managed_repositories". API looks like:
> PUT /api/v1/stacks/HDP/versions/2.3/repository_versions/2
> {
>   "RepositoryVersions" : {
> "id" : 2
>   },
>   "operating_systems" : [
> {
>   "OperatingSystems" : {
> "ambari_managed_repositories": false,
> "os_type" : "redhat6",
> "repository_version_id" : 2,
> "stack_name" : "HDP",
> "stack_version" : "2.3"
>   },
>   "repositories" : [
> {
>   "Repositories" : {
> "base_url" : "http://repos.ambari.apache.org/hdp/HDP-2.3.4.14-4;,
> "repo_id" : "HDP-2.3",
> "repo_name" : "HDP"
>   }
> },
> {
>   "Repositories" : {
> "base_url" : 
> "http://repos.ambari.apache.org/hdp/HDP-UTILS-1.1.0.20;,
> "repo_id" : "HDP-UTILS-1.1.0.20",
> "repo_name" : "HDP-UTILS"
>   }
> }
>   ]
> }
>   ]
> }
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> 7a7d050 
>   ambari-web/app/mappers/repository_version_mapper.js 816308b 
>   ambari-web/app/models/stack_version/repository_version.js e02999f 
>   ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 
> 35677ab 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 
> 88bfec2 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 
> 00d7ce8 
> 
> Diff: https://reviews.apache.org/r/46460/diff/
> 
> 
> Testing
> ---
> 
> Modified unit test.
> Local ambari-web test passed.
> 25660 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 22, 2016, 11:19 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 118
> > 
> >
> > There is some additional logic for HAWQ mentioned in 
> > recommendHDFSConfigurations: 
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py#L368-#L370
> >  
> > 
> > I believe this would still work from the HDP 2.3 stack advisor. Would 
> > you like to move it here?

I was a bit hesitant to make changes to the functions for the other components 
but it definitely could be.


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130191
---


On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 22, 2016, 6:27 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  d574d60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> db95fec 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 3a65541 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 539bd25 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 6c9fd46 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46745/#review130836
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 27, 2016, 6:19 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46745/
> ---
> 
> (Updated April 27, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-16140
> https://issues.apache.org/jira/browse/AMBARI-16140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user runs yum upgrade ambari-agent. The preinstall script backs up the 
> stack dir in /var/lib/ambari-agent/cache by renaming it with a stampstamp. 
> The same logic should happen for /var/lib/ambari-agent/cache/common-services.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/package/deb/control/preinst 7265c55 
>   ambari-agent/src/main/package/rpm/preinstall.sh d7419d3 
> 
> Diff: https://reviews.apache.org/r/46745/diff/
> 
> 
> Testing
> ---
> 
> build ambari-agent RPM, run yum upgrade ambari-agent against a trunk cluster, 
> verify /var/lib/ambari-agent/cache/stack and 
> /var/lib/ambari-agent/cache/common-services are backed up.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

[Di Li]

> On April 27, 2016, 7:44 p.m., Alejandro Fernandez wrote:
> > ambari-agent/src/main/package/deb/control/preinst, line 45
> > 
> >
> > According to your comments, it is already backing up 
> > /var/lib/ambari-agent/cache, so why does a subdirectory need to be backuped 
> > too?

sorry, I wasn't being clear. I meant the stack dir under 
/var/lib/ambari-agent/cache/.  The cache dir itself isn't backed up.

Here is what it currently looks like. There is just one cache dir. The 
/var/lib/ambari-agent/cache/stack was backed up as 
/var/lib/ambari-agent/cache/stacks_26_04_16_09_12.old. But 
/var/lib/ambari-agent/cache/common-services does not have a corresponding 
common-services-[timestamp] backup.

So the fix here is to backup the common-services dir just like how agent is 
currently backing up the stack dir.


[root@test1 ambari-agent]# ll
total 76
total 76
-rwx--  1 root root  1123 Apr 23 13:36 ambari-env.sh
-rwxr-xr-x  1 root root  1429 Apr 23 13:36 ambari-python-wrap
-rwxr-xr-x  1 root root  1345 Apr 23 13:36 ambari-sudo.sh
drwxr-xr-x 10 root root  4096 Apr 26 09:15 cache
drwx--  4 root root 36864 Apr 27 12:44 data
-rwx--  1 root root  3169 Apr 23 13:36 install-helper.sh
drwxr-xr-x  2 root root  4096 Apr 23 13:36 keys
drwxr-xr-x  2 root root  4096 Apr 23 13:36 lib
drwxrwxrwx  5 root root  4096 Apr 27 12:45 tmp
-rwx--  1 root root  2291 Apr 23 13:36 upgrade_agent_configs.py

[root@test1 ambari-agent]# ll cache/
total 32
drwxr-xr-x  2 root root 4096 Apr 26 07:21 alerts
drwxr-xr-x  2 root root 4096 Apr 26 07:21 cluster_configuration
drwxr-xr-x 30 root root 4096 Apr 26 09:12 common-services
drwxr-xr-x  3 root root 4096 Apr 26 09:12 custom_actions
drwxr-xr-x  2 root root 4096 Apr 26 09:16 host_scripts
drwxr-xr-x  2 root root 4096 Apr 26 09:15 recovery
drwxr-xr-x  3 root root 4096 Apr 26 09:12 stacks
drwxr-xr-x  3 root root 4096 Apr 26 07:07 stacks_26_04_16_09_12.old


- Di


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46745/#review130833
---


On April 27, 2016, 6:19 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46745/
> ---
> 
> (Updated April 27, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-16140
> https://issues.apache.org/jira/browse/AMBARI-16140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user runs yum upgrade ambari-agent. The preinstall script backs up the 
> stack dir in /var/lib/ambari-agent/cache by renaming it with a stampstamp. 
> The same logic should happen for /var/lib/ambari-agent/cache/common-services.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/package/deb/control/preinst 7265c55 
>   ambari-agent/src/main/package/rpm/preinstall.sh d7419d3 
> 
> Diff: https://reviews.apache.org/r/46745/diff/
> 
> 
> Testing
> ---
> 
> build ambari-agent RPM, run yum upgrade ambari-agent against a trunk cluster, 
> verify /var/lib/ambari-agent/cache/stack and 
> /var/lib/ambari-agent/cache/common-services are backed up.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46745/#review130833
---




ambari-agent/src/main/package/deb/control/preinst (line 45)


According to your comments, it is already backing up 
/var/lib/ambari-agent/cache, so why does a subdirectory need to be backuped too?


- Alejandro Fernandez


On April 27, 2016, 6:19 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46745/
> ---
> 
> (Updated April 27, 2016, 6:19 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-16140
> https://issues.apache.org/jira/browse/AMBARI-16140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a user runs yum upgrade ambari-agent. The preinstall script backs up the 
> stack dir in /var/lib/ambari-agent/cache by renaming it with a stampstamp. 
> The same logic should happen for /var/lib/ambari-agent/cache/common-services.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/package/deb/control/preinst 7265c55 
>   ambari-agent/src/main/package/rpm/preinstall.sh d7419d3 
> 
> Diff: https://reviews.apache.org/r/46745/diff/
> 
> 
> Testing
> ---
> 
> build ambari-agent RPM, run yum upgrade ambari-agent against a trunk cluster, 
> verify /var/lib/ambari-agent/cache/stack and 
> /var/lib/ambari-agent/cache/common-services are backed up.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Review Request 46746: AMBARI-16141 Add configuration dependencies for Logsearch components

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46746/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16141
https://issues.apache.org/jira/browse/AMBARI-16141


Repository: ambari


Description
---

- add configuration dependencies
- remove logfeeder-site configuration
- remove unused properties and logsearch kafka support


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 190ee53 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
 56552f2 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
40c289e 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 7ed5c42 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 50018cb 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 8216587 
  ambari-web/app/data/HDP2/site_properties.js 8851a78 

Diff: https://reviews.apache.org/r/46746/diff/


Testing
---

ambari-web tests:

27448 tests complete (32 seconds)
154 tests pending

ambar-server python tests:

Total run:998
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 46742: Use additional flags for HAWQ Check

[Matt]

> On April 27, 2016, 10:45 a.m., Alexander Denissov wrote:
> > Please add unit tests.

Working on it


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review130816
---


On April 27, 2016, 10:29 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46742/
> ---
> 
> (Updated April 27, 2016, 10:29 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16106
> https://issues.apache.org/jira/browse/AMBARI-16106
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make changes to HAWQ Check implementation based on HAWQ-668
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  15ceaa2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  76a5885 
> 
> Diff: https://reviews.apache.org/r/46742/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Ran unit tests:
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> --
> Ran 35 tests in 0.126s
> 
> OK
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46692: Improvements to DB consistency check

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46692/
---

(Updated Квітень 27, 2016, 6:31 після полудня)


Review request for Ambari, Dmytro Sen and Sumit Mohanty.


Bugs: AMBARI-16094
https://issues.apache.org/jira/browse/AMBARI-16094


Repository: ambari


Description
---

* disable (we can remove later) DatabaseCheck
* Have CheckDatabaseHelper be called as part of ambari-server start
** Modify {{ambari-server start}} to so that it calls {{ambari-server 
check-database}}

*ambari-server check-database improvements*

* On the output modify {{Ambari Server 'check-database' completed 
successfully.}} to {{Ambari Server 'check-database' completed.}} - _remove 
successfully_
* Use “--skip-database-check” (not skip-database-validation) to force 
ambari-server to start despite error
* If there is error when check-database is run then use the following text
{code}
DB configs consistency check failed. Run “ambari-server start 
--skip-database-check” to skip. If you use this “--skip-database-check” option, 
do not make any changes to your cluster topology or perform a cluster upgrade 
until you correct the database consistency issues. See 
"/var/log/ambari-server/ambari-check-database.log" for more details on the 
consistency issues.
{code}

*ambari-server start improvements*
* On Ambari Server start, the output failure text to should mention 
ambari-server.log (in addition to .out file it does today)
* If user has not specified {{--skip-database-check}} fail start command if 
check-database reports error
* When user starts server with --skip-database-check, if there are DB check 
errors, print message:
{code}
Ambari Server is starting with the database consistency check skipped. Do not 
make any changes to your cluster topology or perform a cluster upgrade until 
you correct the database consistency issues. See 
"/var/log/ambari-server/ambari-check-database.log" for more details on the 
consistency issues.
{code}

When using log file paths, make sure to use the right path from log4j.

*Optional*
Modify ambari.properties to add {{database_check_error_skipped=true}} if user 
started with {{--skip-database-check}} and there were errors due to 
database-check. If there are no errors then store 
{{database_check_error_skipped=false}}. Eventually, UI will use this property 
and show warnings to the user and even prevent HDP upgrade or other topology 
modifying operations such as Add Host/Service.


Diffs (updated)
-

  ambari-server/conf/unix/log4j.properties 3cb7fd0 
  ambari-server/conf/windows/log4j.properties 8beba68 
  ambari-server/src/main/conf/log4j.properties 5021c77 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDatabaseHelper.java
 6ed0c08 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 dc53172 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 91d6b4d 
  ambari-server/src/main/python/ambari-server.py d211e9c 
  ambari-server/src/main/python/ambari_server/checkDatabase.py 2b5c735 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py d815365 
  ambari-server/src/main/python/ambari_server_main.py cd0b858 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/CheckDatabaseHelperTest.java
 8d801dc 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 PRE-CREATION 
  ambari-server/src/test/python/TestAmbariServer.py 9f17e91 

Diff: https://reviews.apache.org/r/46692/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 46745: AMBARI-16140: ambari-agent RPM yum update should backup both stack and common-services

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46745/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-16140
https://issues.apache.org/jira/browse/AMBARI-16140


Repository: ambari


Description
---

When a user runs yum upgrade ambari-agent. The preinstall script backs up the 
stack dir in /var/lib/ambari-agent/cache by renaming it with a stampstamp. The 
same logic should happen for /var/lib/ambari-agent/cache/common-services.


Diffs
-

  ambari-agent/src/main/package/deb/control/preinst 7265c55 
  ambari-agent/src/main/package/rpm/preinstall.sh d7419d3 

Diff: https://reviews.apache.org/r/46745/diff/


Testing
---

build ambari-agent RPM, run yum upgrade ambari-agent against a trunk cluster, 
verify /var/lib/ambari-agent/cache/stack and 
/var/lib/ambari-agent/cache/common-services are backed up.


Thanks,

Di Li

Re: Review Request 46741: Config group UI enhancements

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46741/#review130817
---




ambari-web/app/templates/common/configs/service_config.hbs (line 54)


let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config.hbs (line 63)


let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config_wizard.hbs (line 23)


let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config_wizard.hbs (line 31)


let's use bootsrap tooltips for this instead of simple html title


I also added note about description validation in comment in jira.

- Aleksandr Kovalenko


On Апрель 27, 2016, 5:22 п.п., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46741/
> ---
> 
> (Updated Апрель 27, 2016, 5:22 п.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-16022
> https://issues.apache.org/jira/browse/AMBARI-16022
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. The drop-down listing config-groups seems to truncate the group name when 
> the length exceeds 18. If the config group name is longer, the full name is 
> is not visible. The items in the drop-down list also show the partial 
> truncated name. Having a tooltip would allow for the entire name to be 
> displayed.
> 2. In Manage Config Groups, the Description field allows entry of special 
> characters. Need to restrict characters since the description is stored in 
> the Database.
> 3. Save Configuration Group dialog, the message spills outside the inner 
> frame. Need to make the text wrap.
> 
> 
> Fix includes adding validation for config group description field. Also 
> includes adding tooltips to the items in the drop-down listing config-groups 
> and the selected config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> e6e21bc 
>   ambari-web/app/messages.js 8c8b9e5 
>   ambari-web/app/models/configs/config_group.js 44e20d5 
>   ambari-web/app/styles/application.less 8a34462 
>   ambari-web/app/templates/common/configs/service_config.hbs 0b383d1 
>   ambari-web/app/templates/common/configs/service_config_wizard.hbs b297d1d 
>   ambari-web/app/templates/main/service/new_config_group.hbs 44a590d 
>   ambari-web/app/utils/validator.js 490fec5 
>   
> ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js
>  e0ca439 
>   ambari-web/test/models/configs/config_group_test.js b9bc56b 
>   ambari-web/vendor/styles/bootstrap.css cd0d25a 
> 
> Diff: https://reviews.apache.org/r/46741/diff/
> 
> 
> Testing
> ---
> 
> Added testcases in 
> ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js
>  for config group description validation and 
> /ambari-web/test/models/configs/config_group_test.js for tooltip verification.
> 
> Ran mvn test in ambari-web
> 
> 27619 tests complete (38 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 46742: Use additional flags for HAWQ Check

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46742/#review130816
---



Please add unit tests.

- Alexander Denissov


On April 27, 2016, 5:29 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46742/
> ---
> 
> (Updated April 27, 2016, 5:29 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16106
> https://issues.apache.org/jira/browse/AMBARI-16106
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make changes to HAWQ Check implementation based on HAWQ-668
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py
>  15ceaa2 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/params.py
>  76a5885 
> 
> Diff: https://reviews.apache.org/r/46742/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> Ran unit tests:
> test_stop_default (test_hawqmaster.TestHawqMaster) ... ok
> test_configure_default (test_hawqsegment.TestHawqSegment) ... ok
> test_install_default (test_hawqsegment.TestHawqSegment) ... ok
> test_start_default (test_hawqsegment.TestHawqSegment) ... ok
> test_stop_default (test_hawqsegment.TestHawqSegment) ... ok
> test_configure_default (test_hawqstandby.TestHawqStandby) ... ok
> test_install_default (test_hawqstandby.TestHawqStandby) ... ok
> test_start_default (test_hawqstandby.TestHawqStandby) ... ok
> test_stop_default (test_hawqstandby.TestHawqStandby) ... ok
> test_generate_hawq_process_status_cmd (test_utils.TestUtils) ... ok
> 
> --
> Ran 35 tests in 0.126s
> 
> OK
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review130815
---




ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
 (line 24)


Prefer to use named imports



ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 (line 188)


Take a look at how other components do this now.
There's a "feature" check that returns the version a certain feature is 
enabled.



ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 (line 190)


We shouldn't hardcode /usr/hdp, there's a variable to get the stack root.



ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 (line 216)


This variable will be undefined if len is 0.



ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
 (line 22)


Should avoid import * since causes problems in customer environments.


- Alejandro Fernandez


On April 27, 2016, 7:43 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 27, 2016, 7:43 a.m.)
> 
> 
> Review request for Ambari and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  a64f36f 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  19c9a0e 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46619: AMBARI-16085 : Modify Ambari stacks for Ranger (for enabling plugins) to use service keytab for creating repositories and policies

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46619/#review130814
---


Ship it!




Ship It!

- Robert Levas


On April 27, 2016, 6:45 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46619/
> ---
> 
> (Updated April 27, 2016, 6:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Robert Levas, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16085
> https://issues.apache.org/jira/browse/AMBARI-16085
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> In order to allow Ranger plugins to support Kerberos Authentication, make 
> changes in Ranger plugin stacks to create ranger services and policies using 
> component principal / keytab. Also take care of config changes to support 
> plugin communication in Kerberos enabled env.
> 
> **Proposed Solution**
> Update Ranger repository creation calls to use component principal/keytab as 
> well as update config parameters to support Ranger plugin communication.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
>  cf0d5a6 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  3bb0103 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  a7faf3b 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  d8a89e7 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
>  ffd0715 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  e6fd32c 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
>  858044c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  3d6c096 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
>  f51dbab 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  d4ee6f9 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/setup_ranger_kafka.py
>  a99dc76 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  d572aff 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
>  13987c8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  914d63d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  3f9b936 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_ranger_storm.py
>  bef1f02 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  8fbefb2 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
>  21fe8e1 
> 
> Diff: https://reviews.apache.org/r/46619/diff/
> 
> 
> Testing
> ---
> 
> **Verified**
> Added Ranger in a Kerberos enabled environment and verified enable of plugin 
> for supported components.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46729/#review130810
---




ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (line 92)


This should ignore services that are not part of the upgrade pack, or, 
include service with at least one component that has versionAdvertised=true
This is to exclude AMS, SmartSense


- Alejandro Fernandez


On April 27, 2016, 9:49 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46729/
> ---
> 
> (Updated April 27, 2016, 9:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16134
> https://issues.apache.org/jira/browse/AMBARI-16134
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Just checking for service checks that were run within the last hour does not 
> seem to be a warranty of anything. For example, user could install cluster, 
> run service checks once, and then enable security/LDAP/change configuration 
> as required by some pre-upgrade check/whatever, and still have Health Check 
> passing.
> 
> So the current idea is to check configuration change history and compare 
> config change timestamps with last time the service check for related service 
> was run.
> 
> Also log to Ambari log timestamps of latest service checks for services, and 
> timestamps of latest service config changes (INFO level)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  d701bdc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> a1ab1eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46729/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46729/#review130807
---




ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 (line 61)


Change "rerun" to "run again". Rerun is this guy:
https://en.wikipedia.org/wiki/Fred_Berry



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (lines 89 - 91)


Is there no way to get the "current" configs? The ones marked enabled=1 in 
the DB?

That would prevent you from having to iterate over all of them.



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (line 103)


Uhhh ... this could be a lot. Like 300,000 a lot. Maybe you need a 
restriction here to the last X HRCs


- Jonathan Hurley


On April 27, 2016, 5:49 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46729/
> ---
> 
> (Updated April 27, 2016, 5:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16134
> https://issues.apache.org/jira/browse/AMBARI-16134
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Just checking for service checks that were run within the last hour does not 
> seem to be a warranty of anything. For example, user could install cluster, 
> run service checks once, and then enable security/LDAP/change configuration 
> as required by some pre-upgrade check/whatever, and still have Health Check 
> passing.
> 
> So the current idea is to check configuration change history and compare 
> config change timestamps with last time the service check for related service 
> was run.
> 
> Also log to Ambari log timestamps of latest service checks for services, and 
> timestamps of latest service config changes (INFO level)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  d701bdc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> a1ab1eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46729/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

[Nate Cole]

> On April 27, 2016, 12:39 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java,
> >  lines 112-123
> > 
> >
> > I don't think we want a "break;" here - we should probably collect all 
> > the SERVICE_CHECK and give them to the user.

All SERVICE_CHECKs that fail, that is


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46729/#review130804
---


On April 27, 2016, 5:49 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46729/
> ---
> 
> (Updated April 27, 2016, 5:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16134
> https://issues.apache.org/jira/browse/AMBARI-16134
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Just checking for service checks that were run within the last hour does not 
> seem to be a warranty of anything. For example, user could install cluster, 
> run service checks once, and then enable security/LDAP/change configuration 
> as required by some pre-upgrade check/whatever, and still have Health Check 
> passing.
> 
> So the current idea is to check configuration change history and compare 
> config change timestamps with last time the service check for related service 
> was run.
> 
> Also log to Ambari log timestamps of latest service checks for services, and 
> timestamps of latest service config changes (INFO level)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  d701bdc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> a1ab1eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46729/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46729: [preview] Force running service checks for services before upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46729/#review130804
---




ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 (line 58)


"Last Service Check should be more recent than the last configuration 
change for the given service"



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (line 106)


nit: can make static, but this isn't called that much to matter



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (lines 112 - 123)


I don't think we want a "break;" here - we should probably collect all the 
SERVICE_CHECK and give them to the user.



ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 (line 128)


nit: Could just make failedServiceNames a LinkedHashSet<> from the 
beginning.


- Nate Cole


On April 27, 2016, 5:49 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46729/
> ---
> 
> (Updated April 27, 2016, 5:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-16134
> https://issues.apache.org/jira/browse/AMBARI-16134
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Just checking for service checks that were run within the last hour does not 
> seem to be a warranty of anything. For example, user could install cluster, 
> run service checks once, and then enable security/LDAP/change configuration 
> as required by some pre-upgrade check/whatever, and still have Health Check 
> passing.
> 
> So the current idea is to check configuration change history and compare 
> config change timestamps with last time the service check for related service 
> was run.
> 
> Also log to Ambari log timestamps of latest service checks for services, and 
> timestamps of latest service config changes (INFO level)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  d701bdc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> a1ab1eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46729/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46740: Atlas Integration : set atlas.cluster.name in hive-site

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46740/
---

(Updated April 27, 2016, 2:23 p.m.)


Review request for Ambari, John Speidel and Nate Cole.


Bugs: AMBARI-16089 and AMBARI-16090
https://issues.apache.org/jira/browse/AMBARI-16089
https://issues.apache.org/jira/browse/AMBARI-16090


Repository: ambari


Description
---

After deploying Hive+Atlas via Ambari, the value of 'atlas.cluster.name‘ in 
'Advanced hive-site’ is ‘default’. This results in incorrect value in entity 
notifications to Ranger.

Also, to enable login to Atlas UI, following properties have to be manually 
added to ‘Custom application-properties’ in Atlas. 

atlas.login.method=file
atlas.login.credentials.file=/etc/atlas/conf/users-credentials.properties


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 c86dbf9 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
 e56c3e9 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 3d6c096 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
f2e9924 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 99fd20f 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 617f73d 

Diff: https://reviews.apache.org/r/46740/diff/


Testing
---

New stack advisor unit test.

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

(Updated April 27, 2016, 2:16 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs (updated)
-

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/pig/src/main/resources/view.xml 9df91f8 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar

Re: Review Request 46709: Update LogSearch integration layer to use proper query parameter names for LogSearch

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46709/#review130790
---


Ship it!




Ship It!

- Miklos Gergely


On April 27, 2016, 1:49 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46709/
> ---
> 
> (Updated April 27, 2016, 1:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16129
> https://issues.apache.org/jira/browse/AMBARI-16129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-16129.
> 
> In that issue, it was noticed that the LogSearch integration would sometimes 
> return incorrect information for a given component/host combination.  This 
> was caused by the fact that the LogSearch integration was using the "host" 
> query parameter, when in fact "host_name" is the parameter expected by 
> LogSearch.  In addition, the "components_name" LogSearch parameter was 
> renamed to "component_name".  
> 
> This patch implements the following:
> 
> 1. Refactors the usage of the LogSearch-specific query parameters, such that 
> these parameters are only used within the LoggingRequestHelperImpl. This 
> should make maintaining this code simpler over time, since it essentially 
> hides the details of the LogSearch query paramter names.  
> 2. Moved the method to create the log file tail URI to the 
> LoggingRequestHelper interface, to allow the details of this URI creation to 
> be encapsulated within the LoggingRequestHelper implementation (including the 
> query parameter names used).
> 3. Added javadoc on the LoggingRequestHelper interface.
> 4. Added a new unit test to verify this change, and updated existing unit 
> tests to accomodate this change as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
>  eb45c9e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
>  c1afce0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  f80bc6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
>  0a7e8f2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  0d61984 
> 
> Diff: https://reviews.apache.org/r/46709/diff/
> 
> 
> Testing
> ---
> 
> 1. Deployed a 3-node vagrant cluster successfully with LogSearch enabled.  
> Verified that the log file tail URIs generated are using the new query 
> parameter names, and that these query URIs work properly when executed 
> against Ambari's REST interface.
> 2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled.  
> Verified that no LogSearch-related logging or errors appear in 
> ambari-server.log or ambari-server.out.
> 3. Ran the ambari-server "mvn clean test" suite with my changes applied, with 
> the suite passing completely.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46709: Update LogSearch integration layer to use proper query parameter names for LogSearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46709/#review130787
---


Ship it!




Ship It!

- Oliver Szabo


On April 27, 2016, 1:49 p.m., Robert Nettleton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46709/
> ---
> 
> (Updated April 27, 2016, 1:49 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Oliver Szabo, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16129
> https://issues.apache.org/jira/browse/AMBARI-16129
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch resolves AMBARI-16129.
> 
> In that issue, it was noticed that the LogSearch integration would sometimes 
> return incorrect information for a given component/host combination.  This 
> was caused by the fact that the LogSearch integration was using the "host" 
> query parameter, when in fact "host_name" is the parameter expected by 
> LogSearch.  In addition, the "components_name" LogSearch parameter was 
> renamed to "component_name".  
> 
> This patch implements the following:
> 
> 1. Refactors the usage of the LogSearch-specific query parameters, such that 
> these parameters are only used within the LoggingRequestHelperImpl. This 
> should make maintaining this code simpler over time, since it essentially 
> hides the details of the LogSearch query paramter names.  
> 2. Moved the method to create the log file tail URI to the 
> LoggingRequestHelper interface, to allow the details of this URI creation to 
> be encapsulated within the LoggingRequestHelper implementation (including the 
> query parameter names used).
> 3. Added javadoc on the LoggingRequestHelper interface.
> 4. Added a new unit test to verify this change, and updated existing unit 
> tests to accomodate this change as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
>  eb45c9e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
>  c1afce0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  f80bc6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
>  0a7e8f2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
>  0d61984 
> 
> Diff: https://reviews.apache.org/r/46709/diff/
> 
> 
> Testing
> ---
> 
> 1. Deployed a 3-node vagrant cluster successfully with LogSearch enabled.  
> Verified that the log file tail URIs generated are using the new query 
> parameter names, and that these query URIs work properly when executed 
> against Ambari's REST interface.
> 2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled.  
> Verified that no LogSearch-related logging or errors appear in 
> ambari-server.log or ambari-server.out.
> 3. Ran the ambari-server "mvn clean test" suite with my changes applied, with 
> the suite passing completely.
> 
> 
> Thanks,
> 
> Robert Nettleton
> 
>

Re: Review Request 46709: Update LogSearch integration layer to use proper query parameter names for LogSearch

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46709/
---

(Updated April 27, 2016, 1:49 p.m.)


Review request for Ambari, Don Bosco Durai, Oliver Szabo, and Sumit Mohanty.


Changes
---

Updated patch, since changes needed to be rebased on latest trunk.


Bugs: AMBARI-16129
https://issues.apache.org/jira/browse/AMBARI-16129


Repository: ambari


Description
---

This patch resolves AMBARI-16129.

In that issue, it was noticed that the LogSearch integration would sometimes 
return incorrect information for a given component/host combination.  This was 
caused by the fact that the LogSearch integration was using the "host" query 
parameter, when in fact "host_name" is the parameter expected by LogSearch.  In 
addition, the "components_name" LogSearch parameter was renamed to 
"component_name".  

This patch implements the following:

1. Refactors the usage of the LogSearch-specific query parameters, such that 
these parameters are only used within the LoggingRequestHelperImpl. This should 
make maintaining this code simpler over time, since it essentially hides the 
details of the LogSearch query paramter names.  
2. Moved the method to create the log file tail URI to the LoggingRequestHelper 
interface, to allow the details of this URI creation to be encapsulated within 
the LoggingRequestHelper implementation (including the query parameter names 
used).
3. Added javadoc on the LoggingRequestHelper interface.
4. Added a new unit test to verify this change, and updated existing unit tests 
to accomodate this change as well.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
 eb45c9e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
 c1afce0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 f80bc6d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
 0a7e8f2 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
 0d61984 

Diff: https://reviews.apache.org/r/46709/diff/


Testing
---

1. Deployed a 3-node vagrant cluster successfully with LogSearch enabled.  
Verified that the log file tail URIs generated are using the new query 
parameter names, and that these query URIs work properly when executed against 
Ambari's REST interface.
2. Deployed a 3-node vagrant cluster successfully without LogSearch enabled.  
Verified that no LogSearch-related logging or errors appear in 
ambari-server.log or ambari-server.out.
3. Ran the ambari-server "mvn clean test" suite with my changes applied, with 
the suite passing completely.


Thanks,

Robert Nettleton

Re: Review Request 46703: Reduce error logs on the Sink path if AMS is down

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46703/#review130786
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On April 26, 2016, 6:13 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46703/
> ---
> 
> (Updated April 26, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16123
> https://issues.apache.org/jira/browse/AMBARI-16123
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We should do something similar to AMSPropertyProvider where we print the 
> message every 1000 attempts per thread. Note: Only first message should 
> always be printed.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  5a532c5 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  4c1a2cb 
> 
> Diff: https://reviews.apache.org/r/46703/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review130774
---


Ship it!




Ship It!

- Ashwin Rajeev


On April 27, 2016, 12:49 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46738/
> ---
> 
> (Updated April 27, 2016, 12:49 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16138
> https://issues.apache.org/jira/browse/AMBARI-16138
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
> hive auth based on the hive and hdfs service config.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
> 05b55d2 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
>  1442748 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
>  f5e9bcf 
>   contrib/views/hive/src/main/resources/view.xml 8f8a470 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java
>  25db721 
>   contrib/views/tez/readme.md fdb9459 
>   
> contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java
>  440ac65 
>   contrib/views/tez/src/main/resources/view.xml d8105f1 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
>  a8ef43f 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
>  c8ca6cd 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  4518ac6 
>   
> contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
>  455ca20 
> 
> Diff: https://reviews.apache.org/r/46738/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested on local Vm.
> Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16138
https://issues.apache.org/jira/browse/AMBARI-16138


Repository: ambari


Description
---

If view is managed by ambari, then fetching the webhdfsurl, webhdfs auth and 
hive auth based on the hive and hdfs service config.


Diffs
-

  contrib/views/hive/src/main/java/org/apache/ambari/view/hive/HelpService.java 
05b55d2 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/client/ConnectionFactory.java
 1442748 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParserFactory.java
 f5e9bcf 
  contrib/views/hive/src/main/resources/view.xml 8f8a470 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/BaseHiveTest.java 
25db721 
  contrib/views/tez/readme.md fdb9459 
  
contrib/views/tez/src/main/java/org/apache/ambari/view/tez/ViewController.java 
440ac65 
  contrib/views/tez/src/main/resources/view.xml d8105f1 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/Services.java
 a8ef43f 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/AuthConfigurationBuilder.java
 c8ca6cd 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 4518ac6 
  
contrib/views/utils/src/test/java/org/apache/ambari/view/utils/ambari/ServicesTest.java
 455ca20 

Diff: https://reviews.apache.org/r/46738/diff/


Testing
---

Manually Tested on local Vm.
Tested Hive, Pig, Hdfs and Tez views with HDFS HA and kerberos.


Thanks,

Gaurav Nagar

Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not getting reflected at the backend

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130758
---


Ship it!




Ship It!

- Miklos Gergely


On April 26, 2016, 4:24 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> ---
> 
> (Updated April 26, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties 
> and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use 
> PropertiesFile python class for it if the logsearch/logfeeder properties are 
> more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to 
> logsearch_ui_port
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java
>  f892f04 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
>  3fac655 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> c6c324f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  aee3d16 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  8563e28 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml
>  ba6eb06 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  b76e3d1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
>  fb775bf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 0f17672 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  b3817da 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5e12dde 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  3598380 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  1edf16a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  190d4e2 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  be0f259 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  13abc68 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java
>  af84e92 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
>  ceb11d8 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 156a731 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b 
>   ambari-web/app/data/HDP2/site_properties.js 92509d9 
>   ambari-web/app/models/quick_links.js b7ad1ce 
> 
> Diff: https://reviews.apache.org/r/46702/diff/
> 
> 
> Testing
> ---
> 
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46702: AMBARI-16122 Logsearch: Property changes not getting reflected at the backend

[Oliver Szabo]

> On April 27, 2016, 7:23 a.m., Miklos Gergely wrote:
> > Is it intentional that the words of the property names are separated by 
> > dots in the logsearch.properties.xml and logfeeder.properties.xml, but in 
> > the other files are separated by underscores? If there is some kind of 
> > logic behind it than it's fine, otherwise I believe we should have the same 
> > naming style for all the properties.

yes. mostly this is used for site.xml files and we are using underscores for 
environment properties, these are properties, its a convention here


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46702/#review130730
---


On April 26, 2016, 4:24 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46702/
> ---
> 
> (Updated April 26, 2016, 4:24 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16122
> https://issues.apache.org/jira/browse/AMBARI-16122
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - renamed logsearch-site, logsearch-admin-properties to logsearch-porperties 
> and logsearch-admin-json
> - added logfeeder-properties too
> - added to handle custom properties (now its a bit hacky, but later i can use 
> PropertiesFile python class for it if the logsearch/logfeeder properties are 
> more consistent)
> - move logsearch.ui.port into logsearch-env and renamed it to 
> logsearch_ui_port
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 99bc3df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java
>  f892f04 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
>  3fac655 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
> c6c324f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  aee3d16 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
>  8563e28 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-json.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml
>  ba6eb06 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  b76e3d1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
>  fb775bf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 0f17672 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
>  b3817da 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  5e12dde 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  3598380 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  1edf16a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  190d4e2 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  be0f259 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/quicklinks/quicklinks.json
>  13abc68 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java
>  af84e92 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImplTest.java
>  ceb11d8 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 156a731 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 8445c2b 
>   ambari-web/app/data/HDP2/site_properties.js 92509d9 
>   ambari-web/app/models/quick_links.js b7ad1ce 
> 
> Diff: https://reviews.apache.org/r/46702/diff/
> 
> 
> Testing
> ---
> 
> Built own rpms locally and tries to install 4 node cluster with 3 solr
> Unit testing is in progress...
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130753
---


Ship it!




Ship It!

- Sreenath Somarajapuram


On April 27, 2016, 9:45 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 27, 2016, 9:45 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 44704: CapSched View: Revamping the old UI

[Sreenath Somarajapuram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44704/#review130740
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 138)


Where is operation defined?


- Sreenath Somarajapuram


On April 26, 2016, 10:43 a.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44704/
> ---
> 
> (Updated April 26, 2016, 10:43 a.m.)
> 
> 
> Review request for Ambari and Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-15384
> https://issues.apache.org/jira/browse/AMBARI-15384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revamping the old capsched UI into new better one
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 
> ac679b7 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 
> 16b7d0a 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js
>  PRE-CREATION 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 
> 05bb64c 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> a2d50b9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  be79229 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 
> 25e2aa9 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js
>  PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 
> PRE-CREATION 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44704/diff/
> 
> 
> Testing
> ---
> 
> Manual unit testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Review Request 46728: AMBARI-16133: Zeppelin to select only tested Interpreter

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46728/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Pallav Kulshreshtha, and Sumit Mohanty.


Bugs: AMBARI-16133
https://issues.apache.org/jira/browse/AMBARI-16133


Repository: ambari


Description
---

Allowing only those interpreters that are tested with ambari. i.e.;
Spark
Hive
Shell
MarkDown
R
Livy
Phoenix


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 aa799d3 

Diff: https://reviews.apache.org/r/46728/diff/


Testing
---

Manually tested on local machine.


Thanks,

Prabhjyot Singh

Re: Review Request 46475: Provide UI validation for widget_name and description fields in Create/Edit Widget pop-up.

[Andrii Tkach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46475/#review130733
---


Ship it!




Ship It!

- Andrii Tkach


On April 26, 2016, 9:09 p.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46475/
> ---
> 
> (Updated April 26, 2016, 9:09 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach and Di Li.
> 
> 
> Bugs: AMBARI-15979
> https://issues.apache.org/jira/browse/AMBARI-15979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ISSUE:
> The UI validation at present checks only the length of the user input for 
> widget_name and description fields. All characters are allowed to be stored 
> in the database through them. A more strict UI validation that limits the 
> type of characters entered for these fields will provide a good first line of 
> defense. 
> 
> Steps to reproduce:
> 1. Make sure you have Ambari Metrics service installed on your cluster.
> 2. On the Dashboard, select any service that makes use of Ambari Metrics, say 
> HDFS.
> 3. In the "Metrics" section, click the "Actions" button in the top-right 
> corner, and select "Create a new widget" option from the drop-down. 
> (attachment: create_widget_button_location.tiff)
> 4. Create widget pop-up is displayed. 
> 5. On Step-1, select any type for the widget and click "Next". (attachment: 
> create_widget_step1.tiff)
> 6. On Step-2, select any valid metrics parameter and click "Next". 
> (attachment: create_widget_step2.tiff)
> 7. On Step-3, for widget_name and description fields, you can enter any 
> character. No validation is present to check the contents. The only 
> validation present checks the length of the input text. 
> (attachments:
> create_widget_step3.tiff, 
> original_characters_allowed_for_name_and_description.tiff,
> original_length_validation_for_name.tiff,
> original_length_validation_for_description.tiff )
> 
> 
> FIX:
> The UI validation is enhanced by checking the content of the input for name 
> and description.
> The patch attached allows only alphanumeric, underscore, hyphen, space and 
> percentage symbol to be valid characters for both fields.
> The % symbol is added as part of the white-list as there are existing widgets 
> that contain % symbols in their names. In order to keep the characters in the 
> name consistent, this was decided.
> The description could probably have a little more flexibility in terms of 
> characters allowed. Any suggestions to update this validation would be 
> helpful.
> The warning message template is also updated to conform to the existing norms 
> used in several Ambari pop-ups (e.g. Manage Config Groups, Manage Alert 
> Groups).
> 
> The images attached (starting with "fixed_") show how the fix appears with 
> the patch.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/widgets/create/step3_controller.js 
> dd7a93f 
>   ambari-web/app/messages.js 8c8b9e5 
>   ambari-web/app/templates/main/service/widgets/create/step3.hbs 9f431af 
>   ambari-web/app/utils/validator.js 490fec5 
>   
> ambari-web/test/controllers/main/service/widgets/create/step3_controller_test.js
>  6f92142 
> 
> Diff: https://reviews.apache.org/r/46475/diff/
> 
> 
> Testing
> ---
> 
> Tests are added that check the validate functions added for widget name and 
> description.
> Both widget name and description are tested for:
> 1. all valid characters
> 2. invalid characters
> 3. length of input
> 4. empty string
> 
> Ambari-Web tests with the patch:
> 25671 tests complete (33 seconds)
> 154 tests pending
> 
> 
> File Attachments
> 
> 
> AMBARI-15979-inlineError.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/21/03bc972a-b076-4520-948b-3a204082eca0__AMBARI-15979-inlineError.patch
> AMBARI-15979-topError.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/21/8b4e9a7b-96cb-4a17-9c9c-56e59b5fd349__AMBARI-15979-topError.patch
> AMBARI-15979-April-26-updated.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/26/8631c255-73b9-4179-ba70-6372a69ac225__AMBARI-15979-April-26-updated.patch
> 
> 
> Thanks,
> 
> Keta Patel
> 
>

Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

Review request for Ambari and Sumit Mohanty.


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
 a64f36f 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
 19c9a0e 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
 1a6552f 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
 2dda4bb 
  
ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
 4f2563b 
  ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
a5a19f6 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
f7e15aa 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
107ca93 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Review Request 46726: Date Filter editable in History Tab

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46726/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16132
https://issues.apache.org/jira/browse/AMBARI-16132


Repository: ambari


Description
---

- Adding the 'blur' event on from and to dates and handle if the user enter non 
date entry.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/date-range-widget.js
 9e38786 

Diff: https://reviews.apache.org/r/46726/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha