Re: Review Request 42155: AMBARI-14605 '[RAM_DISK]' configured in dfs.datanode.data.dir fails to validate

[yao lei]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42155/
---

(Updated 五月 3, 2016, 4:57 a.m.)


Review request for Ambari and Matt.


Changes
---

I have rebuilt the patch based on the latest codebase of trunk


Bugs: AMBARI-14605
https://issues.apache.org/jira/browse/AMBARI-14605


Repository: ambari


Description
---

HDFS now support four kinds of heterogeneous storage types: ARCHIVE, DISK, SSD 
and RAM_DISK.
If we configure dfs.datanode.data.dir as [RAM_DISK]/anydir,it fails to validate.
please see 
https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/ArchivalStorage.html#Configuration
A


Diffs (updated)
-

  ambari-web/app/utils/validator.js 9d11746 
  ambari-web/test/utils/validator_test.js ef90561 

Diff: https://reviews.apache.org/r/42155/diff/


Testing
---

Manually Tested.
But Ambari Web Unit Test fails in trunk for other reasons described in 
https://builds.apache.org/job/Ambari-trunk-test-patch/4848//artifact/patch-work/testrun_ambari-web.txt


Thanks,

yao lei

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On April 29, 2016, 12:25 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py,
> >  line 45
> > 
> >
> > Will Spark hist server and livy server always allow http calls? Do we 
> > need support for https?
> > 
> > I also think that we can reduce the retries to 5 times. Any reason 
> > service_check should keep on trying 10 times?

https is supported. But user have to enable it manually because ambari seems 
don't have the ability to generate keystore file. 
Will change the retries to 5 times.


> On April 29, 2016, 12:25 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml,
> >  line 44
> > 
> >
> > One hour seems too long. Will it have any impact of start/service check?

It is default setting of livy. It is session timeout, should not related with 
service check.


> On April 29, 2016, 12:25 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml,
> >  line 27
> > 
> >
> > What is the motivation to move these to common-services?

This is for easy code manintance. Considering spark evolve much faster than 
other components, so I put all of the spark code under common-service, the new 
version extend the old version. All the python script is in the oldest one 
1.2.0.2.2.  In the real HDP stack definition, it just either extend from 
common-service or extend from its parent HDP stack.


> On April 29, 2016, 12:25 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json, 
> > line 10
> > 
> >
> > Why does LIVY server need all the four to be started?
> > 
> > Does SPARK service check also need to wait for LIVY server start?

hmm. Seems livy service start doesn't need these depedency. 
And yes spark service check need to wait for livy server start, because spark 
service check include livy service check.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131041
---


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> 

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On April 29, 2016, 10:10 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py,
> >  line 61
> > 
> >
> > get_stack_to_compoent is now been removed and replaced with 
> > get_component_name(). See AMBARI-15609

Will fix it


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131201
---


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On April 29, 2016, 9:53 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml,
> >  line 1
> > 
> >
> > We shouldnt name this as 1.6.x.2.4. Just SPARK/1.6.0. I dont know if a 
> > non-digit charater here will cause any issues. The last 2-digits "2.4" is 
> > really HDP version and should not be added. Yes we have 5-digit numbering 
> > in common-services with HDP version in it but it is incorrect and needs to 
> > be fixed :). In the HDP stack we can override the version in 
> > stacks/HDP/2.4/services/SPARK/metainfo.xml if we want to be specific as say 
> > "1.6.1.2.4"

The non-digit is added in https://issues.apache.org/jira/browse/AMBARI-15497 ,  
I think the purpose is for avoid changing ambari code each time when spark 
version changes because spark evolution very rapidly.  And I notice other 
service under commonservices are all with HDP version at the end. Does it 
really need to be removed ?


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131197
---


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On April 29, 2016, 10:07 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json,
> >  line 1
> > 
> >
> > Having 1.6.x.2.4 and 1.6.x.2.5 is definitely confusing especially for 
> > Non-HDP stack. We really need to make common-services truely HDP agnostic.

As I mentioned above, I think we should create a new ticket for removing HDP 
version for all the services under common-services.


> On April 29, 2016, 10:07 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml,
> >  line 26
> > 
> >
> > Why do we call this 1.6.x.2.4? In the UI we will display version as 
> > 1.6.x.2.4 as well

I think it is OK, this is purpose of AMBARI-15497


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131200
---


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

[Jeff Zhang]

> On April 29, 2016, 9:57 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml,
> >  line 24
> > 
> >
> > We now support reading properties from files. You can put this in 
> > common-services/SPARK/1.6.1/properties/fairscheduler.xml and read from 
> > there. That way you dont have to embed an encoded xml string within the 
> > config xml. See https://issues.apache.org/jira/browse/AMBARI-15842 as an 
> > example.

For this kind of code refactoring, I'd like to do it in another ticket in case 
it would introduce new bugs.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/#review131199
---


On April 29, 2016, 7:45 a.m., Jeff Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46727/
> ---
> 
> (Updated April 29, 2016, 7:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15612
> https://issues.apache.org/jira/browse/AMBARI-15612
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Livy to HDP 2.5 as slave component of Spark.
> 
> Move the spark stack definiation to commoon-services and then
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  abd2212 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  daa97de 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/livy_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/setup_livy.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/status_params.py
>  86e7f7d 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/configuration/spark-thrift-sparkconf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.4/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/configuration/livy-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.x.2.5/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-defaults.xml
>  1a6552f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-fairscheduler.xml
>  2dda4bb 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/configuration/spark-thrift-sparkconf.xml
>  4f2563b 
>   ambari-server/src/main/resources/stacks/HDP/2.4/services/SPARK/metainfo.xml 
> a5a19f6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
> f7e15aa 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
> 107ca93 
> 
> Diff: https://reviews.apache.org/r/46727/diff/
> 
> 
> Testing
> ---
> 
> Manully verify it. Livy is installed correctly in non-secure and secure 
> cluster.
> 
> 
> Thanks,
> 
> Jeff Zhang
> 
>

Re: Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46898/#review131440
---


Ship it!




Awesome !! We definetly needed this.

- Sid Wagle


On May 2, 2016, 6:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46898/
> ---
> 
> (Updated May 2, 2016, 6:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-16207
> https://issues.apache.org/jira/browse/AMBARI-16207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There is currently no way to pass JPA or EclipseLink specific 
> connection/DataSource properties in from {{ambari.properties}}. Although 
> there exists {{Configuration.getDatabaseCustomProperties}}, these are 
> actually _driver specific_ properties and not properties for EclipseLink.
> 
> For example, if I wanted to pass in to the JDBC Driver {{foo=bar}}, then I 
> could set
> {{server.jdbc.properties.foo=bar}} and this will get translated into 
> {{eclipselink.jdbc.property.foo=bar}}.
> 
> However, if I wanted to set any of the EclipseLink or JPA specific DataSource 
> properties (see 
> http://www.eclipse.org/eclipselink/api/2.6/org/eclipse/persistence/config/PersistenceUnitProperties.html)
>  I would not be able to.
> 
> Proposal is to add something similar to the custom driver properties:
> ```
> server.persistence.properties.eclipselink.jdbc.batch-writing.size=25
> ```
> 
> Which could get translated into
> ```
> properties.put("eclipselink.jdbc.batch-writing.size", 25)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0afae97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3506031 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
> 
> Diff: https://reviews.apache.org/r/46898/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On May 2, 2016, 10:31 p.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 581
> > 
> >
> > somehow placing the logic here does not fit well to the method, you can 
> > move this logic to setAdditionalConfigs which imo more appropriate place 
> > and hopefully it will work there too as its used after setting additional 
> > configurations ?

setAdditionalConfigs() (at least intention ) is to simply take 
additionalConfigsMap parameter and transform it in "configs", so it shouldn't 
have some condition logic to modify the parameter.
Instead, we should modify the parameter, additionalConfigsMap beforehand, which 
onLoadConfigs() as you suggested.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131403
---


On May 3, 2016, 12:59 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 3, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
---

(Updated May 3, 2016, 12:59 a.m.)


Review request for Ambari.


Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174


Repository: ambari


Description
---

when RM HA is not enabled, following properties should be updated in 
hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in 
yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha


Diffs (updated)
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 736f467 
  ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
329249c 

Diff: https://reviews.apache.org/r/46860/diff/


Testing
---

Unit test passed
Calling set on destroyed view

  27428 tests complete (35 seconds)
  154 tests pending


Manually tested


Thanks,

jun aoki

Re: Review Request 46903: Atlas Integration : Atlas start failed after removing old version of the atlas and installing new one

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46903/#review131439
---


Ship it!




Ship It!

- Nate Cole


On May 2, 2016, 3:42 p.m., Tom Beerbower wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46903/
> ---
> 
> (Updated May 2, 2016, 3:42 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Nate Cole.
> 
> 
> Bugs: AMBARI-16204
> https://issues.apache.org/jira/browse/AMBARI-16204
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade from HDP 2.3 stack to 2.5. Stop and delete the Atlas service under 
> 2.3 and then reinstall it after you have upgraded to 2.5.
> 
> Atlas creates the /var/lib/atlas/server/webapp folder. After removing old 
> service and installing new version of the service the Atlas war file is 
> updated, but the unpacked folder is not. This causes errors like - Can't find 
> main class.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  f3ea36f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> 5d7766b 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/users-credentials.properties
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  8412fc0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  a2ea7e5 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 92f198a 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> cf18f92 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json d423ce5 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 89ab6f0 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 83d4c5b 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 5188730 
> 
> Diff: https://reviews.apache.org/r/46903/diff/
> 
> 
> Testing
> ---
> 
> Manual test Atlas install.
> 
> Updated unit tests.
> 
> mvn clean test.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Re: Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46898/#review131438
---


Ship it!




Ship It!

- Nate Cole


On May 2, 2016, 2:17 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46898/
> ---
> 
> (Updated May 2, 2016, 2:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Sid Wagle.
> 
> 
> Bugs: AMBARI-16207
> https://issues.apache.org/jira/browse/AMBARI-16207
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> There is currently no way to pass JPA or EclipseLink specific 
> connection/DataSource properties in from {{ambari.properties}}. Although 
> there exists {{Configuration.getDatabaseCustomProperties}}, these are 
> actually _driver specific_ properties and not properties for EclipseLink.
> 
> For example, if I wanted to pass in to the JDBC Driver {{foo=bar}}, then I 
> could set
> {{server.jdbc.properties.foo=bar}} and this will get translated into 
> {{eclipselink.jdbc.property.foo=bar}}.
> 
> However, if I wanted to set any of the EclipseLink or JPA specific DataSource 
> properties (see 
> http://www.eclipse.org/eclipselink/api/2.6/org/eclipse/persistence/config/PersistenceUnitProperties.html)
>  I would not be able to.
> 
> Proposal is to add something similar to the custom driver properties:
> ```
> server.persistence.properties.eclipselink.jdbc.batch-writing.size=25
> ```
> 
> Which could get translated into
> ```
> properties.put("eclipselink.jdbc.batch-writing.size", 25)
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0afae97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3506031 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  99ec786 
> 
> Diff: https://reviews.apache.org/r/46898/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131430
---


Ship it!




Ship It!

- Matt


On April 29, 2016, 5:51 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated April 29, 2016, 5:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
>  b213028 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
>  473b7c3 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume.py
>  9df2ba6 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_check.py
>  25d9a08 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  1333605 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params_windows.py
>  66e9852 
>   
> ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/functions.py
>  02c44f0 
>   
> ambari-server/src/main/resources/common-services/GANGLIA/3.5.0/package/scripts/ganglia.py
>  9a69b72 
>   
> 

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
> You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?
> 
> Matt wrote:
> That sounds better to me. Modify the array after receiving the config.
> If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array 
> value.

I'm checking right now to see if it works.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[Matt]

> On April 29, 2016, 5:21 p.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.
> 
> bhuvnesh chaudhary wrote:
> You can get the configuration as soon you reach onLoadConfigs, and then 
> you can use it which is before the start service ?

That sounds better to me. Modify the array after receiving the config.
If HAWQ is using YARN, append value 'HAWQ' to RESOURCEMANAGER's array value.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 2, 2016, 2:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 2:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

[Juanjo Marron]

> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote:
> > I think we need more testing on this apart from unit tests to ensure all 
> > imports are there.
> 
> Juanjo  Marron wrote:
> Hi Jayush,
> 
> Thanks for the review.
> I'll add this couple of missing imports to ACCUMULO service check
> 
> I reviewed UTs, I did a fresh installation, no service-check run though. 
> Ill do service check as well from now. Any other test you think can be 
> required?
> 
> Also, Atlas installation was failing in trunk (even without this change 
> set) so I would need to retry on top of a stable trunk versions

Please, wait review for now, more test on these services is being performed
Thanks


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46853/#review131209
---


On April 30, 2016, 12:51 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46853/
> ---
> 
> (Updated April 30, 2016, 12:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16175
> https://issues.apache.org/jira/browse/AMBARI-16175
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This  subtask cleans up import * from resource_management and replace it for 
> specific imports for:
> Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
>  09a3d90 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
>  33d3273 
>   
> ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/service_check.py
>  a7067cb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py
>  3c3d804 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  eb1b6d7 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py
>  7fb9715 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_master.py
>  b769a0d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_regionserver.py
>  cf0efef 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase_service.py
>  4d0d7f3 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py
>  a5abe1c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  32b8fdb 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  21b491d 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status_params.py
>  3c4bffc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  2bdb4c0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  43c1ea6 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
>  4b08cbc 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  defd6f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py
>  194a3fb 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py
>  4c54214 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
>  64ace1a 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
>  a201619 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  6277086 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_windows.py
>  b213028 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/service_check.py
>  473b7c3 
>   
> 

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131403
---




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 581)


somehow placing the logic here does not fit well to the method, you can 
move this logic to setAdditionalConfigs which imo more appropriate place and 
hopefully it will work there too as its used after setting additional 
configurations ?


- bhuvnesh chaudhary


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[bhuvnesh chaudhary]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?
> 
> jun aoki wrote:
> I thought it'd be a good idea but data.Cluters won't return enoguh 
> information to decide if HAWQ is on YARN. 
> ```
> data.Clusters.desired_configs["hawq-site"]
> Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
> ```
> Let me know if you have a better idea to find it out.

You can get the configuration as soon you reach onLoadConfigs, and then you can 
use it which is before the start service ?


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > If HAWQ is configured to work on Standalone mode, should HAWQ be in the 
> > list of services to stop/start when some operation is done with YARN 
> > service? Can this be appended to this list based on what type of resource 
> > management HAWQ is relying on?
> > 
> > I would configure HAWQ in standalone mode, and move YARN Resource 
> > Manager - I would not expect HAWQ to be restarted in this case.

@Matt, please my comment on May 2, 2016, 8:57 p.m.


> On May 2, 2016, 10:16 p.m., Matt wrote:
> > ambari-web/app/utils/configs/move_rm_config_initializer.js, line 120
> > 
> >
> > The line numbers on the link does not stick when the file in that 
> > repository gets updated.

It is to a release tag, so hopefuly won't be updated.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131391
---


On May 2, 2016, 9:47 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated May 2, 2016, 9:47 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> 736f467 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 329249c 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Ajit Kumar]

> On May 2, 2016, 9:44 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 837
> > 
> >
> > Othere tables have start_time as the column name. It will be good to 
> > have the same name.
> 
> Nahappan Somasundaram wrote:
> Originally it was start_timestamp and stop_timestamp. One of the reviews 
> was end_timestamp made more sense; this meant that start_timestamp would 
> change to begin_timestamp. (Start<->Stop, Begin<->End).

start time and end time should be fine. You can look at cluster version table 
for example.


- Ajit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131379
---


On May 2, 2016, 9:24 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 2, 2016, 9:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [26.897s]
> [INFO] Ambari Views .. SUCCESS [1.400s]
> [INFO] Ambari Admin View . SUCCESS [9.242s]
> [INFO] ambari-metrics  SUCCESS [0.346s]
> [INFO] Ambari Metrics Common . SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
> [INFO] Ambari Server . SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.194s]
> [INFO] Ambari Agent .. SUCCESS [25.339s]
> [INFO] Ambari Client . SUCCESS [0.047s]
> [INFO] Ambari Python Client .. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.196s]
> [INFO] Ambari Shell .. SUCCESS [0.038s]
> [INFO] Ambari Python Shell ... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
> [INFO] ambari-logsearch .. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
> [INFO] Ambari Logsearch Appender 

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Nahappan Somasundaram]

> On May 2, 2016, 2:44 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 856
> > 
> >
> > missed renaming this.

Fixed.


> On May 2, 2016, 2:44 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 837
> > 
> >
> > Othere tables have start_time as the column name. It will be good to 
> > have the same name.

Originally it was start_timestamp and stop_timestamp. One of the reviews was 
end_timestamp made more sense; this meant that start_timestamp would change to 
begin_timestamp. (Start<->Stop, Begin<->End).


- Nahappan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131379
---


On May 2, 2016, 2:24 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 2, 2016, 2:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [26.897s]
> [INFO] Ambari Views .. SUCCESS [1.400s]
> [INFO] Ambari Admin View . SUCCESS [9.242s]
> [INFO] ambari-metrics  SUCCESS [0.346s]
> [INFO] Ambari Metrics Common . SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
> [INFO] Ambari Server . SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.194s]
> [INFO] Ambari Agent .. SUCCESS [25.339s]
> [INFO] Ambari Client . SUCCESS [0.047s]
> [INFO] Ambari Python Client .. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.196s]
> [INFO] Ambari Shell .. SUCCESS [0.038s]
> [INFO] Ambari Python Shell ... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
> [INFO] ambari-logsearch .. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ... SUCCESS 

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/
---

(Updated May 2, 2016, 9:47 p.m.)


Review request for Ambari.


Bugs: AMBARI-16174
https://issues.apache.org/jira/browse/AMBARI-16174


Repository: ambari


Description
---

when RM HA is not enabled, following properties should be updated in 
hawq-site.xml should be updated.
hawq_rm_yarn_address
hawq_rm_yarn_scheduler_address
When RM HA Is enabled and then a RM is moved, following properties in 
yarn-client.xml should be updated
yarn.resourcemanager.ha
yarn.resourcemanager.scheduler.ha


Diffs (updated)
-

  ambari-web/app/controllers/main/service/reassign/step4_controller.js 736f467 
  ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
  ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
329249c 

Diff: https://reviews.apache.org/r/46860/diff/


Testing
---

Unit test passed
Calling set on destroyed view

  27428 tests complete (35 seconds)
  154 tests pending


Manually tested


Thanks,

jun aoki

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Ajit Kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/#review131379
---




ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 837)


Othere tables have start_time as the column name. It will be good to have 
the same name.



ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql (line 856)


missed renaming this.


- Ajit Kumar


On May 2, 2016, 9:24 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46545/
> ---
> 
> (Updated May 2, 2016, 9:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
> Jayush Luniya, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16029
> https://issues.apache.org/jira/browse/AMBARI-16029
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16029: Ambari version history - Create DB table, constraints and 
> sequence id.
> 
> ** Issue **
> In order to support tracking of ambari version, a DB table is required.
> 
> ** Fix **
> Create ambari_operation_history table to store from version, to version, 
> install type, start and stop timestamps.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
> 319afa579e6f5090588fb90fe619ee7b6bae6d78 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
> 9a20b8c05801f61a91a092afd4424173a94d7f17 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
> e1da7190d6fb929277c834b29cb537107d857bc3 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
> ab1eec42fcba467e0bae19674a7877c79eb77b8e 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> fdba489f2d0759e9c1282dfad38036f9bce3673d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
> a1da8e5c8343ae554b4e95717cda085c7f79bc46 
> 
> Diff: https://reviews.apache.org/r/46545/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [5.113s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [26.897s]
> [INFO] Ambari Views .. SUCCESS [1.400s]
> [INFO] Ambari Admin View . SUCCESS [9.242s]
> [INFO] ambari-metrics  SUCCESS [0.346s]
> [INFO] Ambari Metrics Common . SUCCESS [0.528s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
> [INFO] Ambari Server . SUCCESS [2:58.522s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.194s]
> [INFO] Ambari Agent .. SUCCESS [25.339s]
> [INFO] Ambari Client . SUCCESS [0.047s]
> [INFO] Ambari Python Client .. SUCCESS [0.947s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.196s]
> [INFO] Ambari Shell .. SUCCESS [0.038s]
> [INFO] Ambari Python Shell ... SUCCESS [0.693s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
> [INFO] ambari-logsearch .. SUCCESS [0.253s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.190s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.079s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 

Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46545/
---

(Updated May 2, 2016, 2:24 p.m.)


Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, 
Jayush Luniya, and Sumit Mohanty.


Changes
---

1. Rename ambari_version_history to ambari_operation_history since we intend to 
store more than just install and upgrade information.
2. Use TIMESTAMP/DATETIME for timestamp fields.
3. Add comment field to store JSON formatted information about the operation 
and the outcome.


Bugs: AMBARI-16029
https://issues.apache.org/jira/browse/AMBARI-16029


Repository: ambari


Description (updated)
---

AMBARI-16029: Ambari version history - Create DB table, constraints and 
sequence id.

** Issue **
In order to support tracking of ambari version, a DB table is required.

** Fix **
Create ambari_operation_history table to store from version, to version, 
install type, start and stop timestamps.


Diffs (updated)
-

  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 
319afa579e6f5090588fb90fe619ee7b6bae6d78 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 
9a20b8c05801f61a91a092afd4424173a94d7f17 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 
e1da7190d6fb929277c834b29cb537107d857bc3 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 
ab1eec42fcba467e0bae19674a7877c79eb77b8e 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
bd869f454ae7ec1c84a9cbd418875f10c023a0c2 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
fdba489f2d0759e9c1282dfad38036f9bce3673d 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 
a1da8e5c8343ae554b4e95717cda085c7f79bc46 

Diff: https://reviews.apache.org/r/46545/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [5.113s]
[INFO] Apache Ambari Project POM . SUCCESS [0.038s]
[INFO] Ambari Web  SUCCESS [26.897s]
[INFO] Ambari Views .. SUCCESS [1.400s]
[INFO] Ambari Admin View . SUCCESS [9.242s]
[INFO] ambari-metrics  SUCCESS [0.346s]
[INFO] Ambari Metrics Common . SUCCESS [0.528s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.237s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s]
[INFO] Ambari Metrics Collector .. SUCCESS [7.183s]
[INFO] Ambari Metrics Monitor  SUCCESS [1.853s]
[INFO] Ambari Metrics Grafana  SUCCESS [1.031s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s]
[INFO] Ambari Server . SUCCESS [2:58.522s]
[INFO] Ambari Functional Tests ... SUCCESS [2.194s]
[INFO] Ambari Agent .. SUCCESS [25.339s]
[INFO] Ambari Client . SUCCESS [0.047s]
[INFO] Ambari Python Client .. SUCCESS [0.947s]
[INFO] Ambari Groovy Client .. SUCCESS [2.196s]
[INFO] Ambari Shell .. SUCCESS [0.038s]
[INFO] Ambari Python Shell ... SUCCESS [0.693s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.907s]
[INFO] ambari-logsearch .. SUCCESS [0.253s]
[INFO] Ambari Logsearch Portal ... SUCCESS [7.069s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.190s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.079s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:56.545s
[INFO] Finished at: Thu Apr 21 16:14:34 PDT 2016
[INFO] Final Memory: 274M/1094M
[INFO] 


** 2. Manual testing **
Tested with Ambari-DDL-Postgres-EMBEDDED-CREATE.sql. Copied the SQL script to a 
VM and ran ambari-server reset. Verified the schema:

ambari=> \d+ ambari_version_history
 Table "ambari.ambari_version_history"
 Column  |  Type  | Modifiers | Storage  | 

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

> On April 30, 2016, 12:21 a.m., bhuvnesh chaudhary wrote:
> > ambari-web/app/controllers/main/service/reassign/step4_controller.js, line 
> > 85
> > 
> >
> > Unless HAWQ is using YARN as the scheduler, HAWQ may still be 
> > functional and we may need not restart HAWQ with the move of RM. 
> > So do you think should we restart it only when HAWQ is using 
> > hawq_global_rm_type as yarn ?

I thought it'd be a good idea but data.Cluters won't return enoguh information 
to decide if HAWQ is on YARN. 
```
data.Clusters.desired_configs["hawq-site"]
Object {tag: "TOPOLOGY_RESOLVED", user: "admin", version: 2}
```
Let me know if you have a better idea to find it out.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131231
---


On April 29, 2016, 11:57 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated April 29, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46899: Disable alternate user search functionality by default

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46899/
---

Review request for Ambari, Balázs Bence Sári, Daniel Gergely, Laszlo Puskas, 
Robert Levas, and Sandor Magyari.


Bugs: AMBARI-16205
https://issues.apache.org/jira/browse/AMBARI-16205


Repository: ambari


Description
---

Added `authentication.ldap.alternateUserSearchEnabled` configuration property 
through which it can be controlled if the ldap alternate user search is enabled 
or not. The default value for this property is `false.`


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 87f40d5 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProvider.java
 7b2a95c 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 99ec786 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderForDuplicateUserTest.java
 f5d1412 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariLdapAuthenticationProviderTest.java
 b076e85 

Diff: https://reviews.apache.org/r/46899/diff/


Testing
---

Performed manual testing.

Unit test results:
Results :

Tests run: 4305, Failures: 0, Errors: 0, Skipped: 32


Thanks,

Sebastian Toader

Review Request 46903: Atlas Integration : Atlas start failed after removing old version of the atlas and installing new one

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46903/
---

Review request for Ambari, John Speidel and Nate Cole.


Bugs: AMBARI-16204
https://issues.apache.org/jira/browse/AMBARI-16204


Repository: ambari


Description
---

Upgrade from HDP 2.3 stack to 2.5. Stop and delete the Atlas service under 2.3 
and then reinstall it after you have upgraded to 2.5.

Atlas creates the /var/lib/atlas/server/webapp folder. After removing old 
service and installing new version of the service the Atlas war file is 
updated, but the unpacked folder is not. This causes errors like - Can't find 
main class.


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
 f3ea36f 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
5d7766b 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/files/users-credentials.properties
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 43c1ea6 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 4b08cbc 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 defd6f0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 8412fc0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
 a2ea7e5 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
92f198a 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
cf18f92 
  ambari-server/src/test/python/stacks/2.3/configs/default.json d423ce5 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 89ab6f0 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 83d4c5b 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 5188730 

Diff: https://reviews.apache.org/r/46903/diff/


Testing
---

Manual test Atlas install.

Updated unit tests.

mvn clean test.


Thanks,

Tom Beerbower

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Alexander Denissov]

> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote:
> > Do we have a branch cut with these changes in so that we can test HAWQ and 
> > PXF with this new logic ? After testing the branch can be merged to trunk 
> > and we will avoid any major surprises.
> 
> Tim Thorpe wrote:
> There isn't currently a branch.  Do we really need a branch, wouldn't it 
> be just as easy to just apply the patch over trunk and try it out?  If you 
> think we need a branch then, I'll ask that one get created.
> 
> Alexander Denissov wrote:
> We will be testing this patch with HAWQ to see if it behaves as expected 
> and there are no regressions.
> 
> Tim Thorpe wrote:
> Hi Alex, please let me know when you have validated the patch with HAWQ 
> so I can get it pushed in (after I try it out again over trunk). Thanks

Tim, the guys tried it on Friday and it did not quite work (custom 
recommendations did not come in UI). They are trying to dig deeper and debug 
today to pinpoint where the problem is.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131020
---


On April 29, 2016, 8:11 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 29, 2016, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46860: Move RM wizard should update HAWQ related parameters

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46860/#review131350
---




ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 85)


Good idea. Let me see if I can add HAWQ dynamically at onLoadConfigsTags().



ambari-web/app/controllers/main/service/reassign/step4_controller.js (line 582)


I will keep this logic here as this is the first loation the logic can see 
cluster information and the definitions can get modified.
getConfigUrlParams() is to generate a list of partial URLs. 

The second suggestion is good and I will invert this if statement and 
remove them from the default values.


- jun aoki


On April 29, 2016, 11:57 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46860/
> ---
> 
> (Updated April 29, 2016, 11:57 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16174
> https://issues.apache.org/jira/browse/AMBARI-16174
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when RM HA is not enabled, following properties should be updated in 
> hawq-site.xml should be updated.
> hawq_rm_yarn_address
> hawq_rm_yarn_scheduler_address
> When RM HA Is enabled and then a RM is moved, following properties in 
> yarn-client.xml should be updated
> yarn.resourcemanager.ha
> yarn.resourcemanager.scheduler.ha
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_rm_config_initializer.js f8800de 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46860/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed
> Calling set on destroyed view
> 
>   27428 tests complete (35 seconds)
>   154 tests pending
> 
> 
> Manually tested
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

[Tim Thorpe]

> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote:
> > Do we have a branch cut with these changes in so that we can test HAWQ and 
> > PXF with this new logic ? After testing the branch can be merged to trunk 
> > and we will avoid any major surprises.
> 
> Tim Thorpe wrote:
> There isn't currently a branch.  Do we really need a branch, wouldn't it 
> be just as easy to just apply the patch over trunk and try it out?  If you 
> think we need a branch then, I'll ask that one get created.
> 
> Alexander Denissov wrote:
> We will be testing this patch with HAWQ to see if it behaves as expected 
> and there are no regressions.

Hi Alex, please let me know when you have validated the patch with HAWQ so I 
can get it pushed in (after I try it out again over trunk). Thanks


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131020
---


On April 29, 2016, 8:11 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> ---
> 
> (Updated April 29, 2016, 8:11 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15226
> https://issues.apache.org/jira/browse/AMBARI-15226
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the stack advisor is defined under each stack version such as 
> HDP/2.3. The problem with this is that it restricts the services that can be 
> added to the stack. If a custom service is to be added, they would need to 
> modify the stack advisor. If the configuration recommendation and validation 
> can be done at the service level then the custom service could just include 
> their own recommendations and validations separately.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/assemblies/server.xml e1a4919 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  df65010 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  00c8696 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  ca1968e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  6c6fa91 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  636de37 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  356adb1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> b7e09a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  d27e52a 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 5a2bf84 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> PRE-CREATION 
>   ambari-server/src/main/resources/properties.json eac0dbd 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 1680f21 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> f475798 
>   ambari-server/src/main/resources/stacks/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 9979e7e 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> 2080c52 
> 
> Diff: https://reviews.apache.org/r/44210/diff/
> 
> 
> Testing
> ---
> 
> Ran all the non java unit tests.  
> 
> Total run:945
> Total errors:0
> Total failures:0
> 
> Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure 
> their service advisors were called.
> 
> 
> Thanks,
> 
> Tim Thorpe
> 
>

Re: Review Request 46852: HAWQ Configuration should be updated whenever Namenode is being moved using the move namenode wizard

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46852/#review131348
---


Ship it!




Ship It!

- Alexander Denissov


On April 29, 2016, 8:50 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46852/
> ---
> 
> (Updated April 29, 2016, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16191
> https://issues.apache.org/jira/browse/AMBARI-16191
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HAWQ Configuration should be updated whenever Namenode is being moved using 
> the move namenode wizard.
> Parameters which should be updated
> Case 1: HDFS HA
> hdfs-client parameters under HAWQ service
> dfs.namenode.rpc-address..
> dfs.namenode.http-address..
> Case 2: Non HA HDFS
> hawq-site parmeters under HAWQ service
> hawq_dfs_url
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/reassign/step4_controller.js 
> a20aa82 
>   ambari-web/app/utils/configs/move_namenode_config_initializer.js 160848c 
>   ambari-web/test/controllers/main/service/reassign/step4_controller_test.js 
> 460726b 
> 
> Diff: https://reviews.apache.org/r/46852/diff/
> 
> 
> Testing
> ---
> 
> yes.
>   27472 tests complete (29 seconds)
>   154 tests pending
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 46.556 s
> [INFO] Finished at: 2016-04-29T13:53:51-07:00
> [INFO] Final Memory: 14M/338M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 46898: Provide Ability To Pass JPA / EclipseLink Properties to the DataSource

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46898/
---

Review request for Ambari, Nate Cole and Sid Wagle.


Bugs: AMBARI-16207
https://issues.apache.org/jira/browse/AMBARI-16207


Repository: ambari


Description
---

There is currently no way to pass JPA or EclipseLink specific 
connection/DataSource properties in from {{ambari.properties}}. Although there 
exists {{Configuration.getDatabaseCustomProperties}}, these are actually 
_driver specific_ properties and not properties for EclipseLink.

For example, if I wanted to pass in to the JDBC Driver {{foo=bar}}, then I 
could set
{{server.jdbc.properties.foo=bar}} and this will get translated into 
{{eclipselink.jdbc.property.foo=bar}}.

However, if I wanted to set any of the EclipseLink or JPA specific DataSource 
properties (see 
http://www.eclipse.org/eclipselink/api/2.6/org/eclipse/persistence/config/PersistenceUnitProperties.html)
 I would not be able to.

Proposal is to add something similar to the custom driver properties:
```
server.persistence.properties.eclipselink.jdbc.batch-writing.size=25
```

Which could get translated into
```
properties.put("eclipselink.jdbc.batch-writing.size", 25)
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 0afae97 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 3506031 
  
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
 99ec786 

Diff: https://reviews.apache.org/r/46898/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 46808: Role selection in List view of Manage Ambari page does not work correctly

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review131336
---




ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js
 (line 75)


what happens when permission_label is not None?


- Di Li


On April 29, 2016, 12:41 a.m., Keta Patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> ---
> 
> (Updated April 29, 2016, 12:41 a.m.)
> 
> 
> Review request for Ambari, Di Li and Richard Zang.
> 
> 
> Bugs: AMBARI-15552
> https://issues.apache.org/jira/browse/AMBARI-15552
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reproduction Steps:
> 1. Go to Admin->Manage Ambari
> 2. Create a group with a few users belonging to it. 
> (I have created "mygroup" with "user1", "user2", "user3") 
> (attachments "user1.tiff", "mygroup.tiff" shows samples)
> 3. Go to Clusters->Roles on the left navigation menu.
> 4. The default view is the "Block" view for the roles. Assign "mygroup" a 
> role, say "Cluster User". 
> (attachment "block_view_original.tiff")
> 5. Click on "List" view, it will show Users by default. It correctly shows 
> the role "Cluster User" for each user in "mygroup". 
> (attachment "list_view_users.tiff")
> 6. Now, try adding a new Role, say "Service Operator", to one of the users, 
> say "user3". 
> (attachments "list_view_add_role_to_user_step1.tiff", 
> "list_view_add_role_to_user_step2.tiff")
> 7. After making this change, the role gets added for that user (in our case 
> "user3"), but the roles from other users in its group gets removed. Also, the 
> previous role for the user ("user3") is replaced by the new Role.
> (attachment "list_view_add_role_to_user_step3.tiff")
> 8. You can confirm this from the the "Block" view. 
> (attachment "block_view_after_step3.tiff")
> 
> So, the problem here lies with the List view where it is not able to process 
> the changes in the Roles correctly. A change in the Role of a user causes the 
> following:
> 
> CASE-1: The displayed role (effective privilege) comes from an explicitly 
> assigned role to the user.
> 1.1) The new selected role correctly replaces the existing privilege that was 
> explicitly assigned to the user.
> 1.2) But if the user was assigned multiple roles explicilty (before the fix 
> for AMBARI-16102 got pushed in), then all the other roles, which are of lower 
> privilege than the role that got replaced, are still displayed in the Block 
> view (because those roles are still in the database). So, if the new selected 
> role happened to be of a lower privilege than and existing role of the user, 
> then even though the user sees a success Alert message, the effective 
> privileg he sees is different. For the Ambari user, this behavior is not 
> easily understandable.
> 
> CASE-2: The displayed role (effective privilege) comes from a group the user 
> belongs to.
> 2.1) If the new selected privilege is higher than the effective privilege 
> coming from the user's group(s), then the newly selected role replaces this 
> "group" privilege in the database, insetad of creating a new entry.
> 2.2) As a result of losing the group privilege, all the group members also 
> lose their privileges and they show "None" as their effective privilege.
> 2.3) If the newly selected privilege is lower than effective group privilege, 
> the Alert message shows a success of role change but the effective privilge 
> is still not the one that the Ambari user selected.
> 
> 
> Expected results:
> 1. Updating a Role of a user must replace any/all of the explicit roles it 
> has been assigned through the Block View. (this addresses 1.2)
> Note: Even though AMBARI-16102 has attempted to fix the Block view by 
> allowing only a user to have just one role assigned to it, there could be 
> cases where the earlier version of Block view has already allowed users to 
> have multiple roles. So, taking this into consideration, the fix must address 
> removing any or all of the roles the user was assigned explicitly.
> 2. Adding a Role to a user must not affect the Roles of other users in its 
> group. (addressing 2.1 and 2.2)
> 3. Selecting a "NONE" for a user role shows the Alert "User's role chnaged to 
> None". This  may not reflect the correct privilege status as the user might 
> have some effective privilege coming from its group(s). In the fix, the Alert 
> must show the relevant message.
> 4. Alert messages must show more informative messages of what is happening 
> with the user's privileges and why. (addressing 1.2 and 2.3)
> 
> 
> Diffs
> -
> 
>   
> 

Re: Review Request 46895: Add smartconfig for Logsearch

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46895/#review131328
---


Ship it!




Ship It!

- Miklos Gergely


On May 2, 2016, 1:56 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46895/
> ---
> 
> (Updated May 2, 2016, 1:56 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16200
> https://issues.apache.org/jira/browse/AMBARI-16200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add smartconfig about the most important solr/logsearch properties 
> (theme.json)
> - add mergeFactor as configurable property
> - configurable log4j.properties for solr-client
> - add small property attribute changes
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  8ac7c1f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  694f2db 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  018cffd 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  9dfbaf7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  01dff67 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-client-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  69aead7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 56a5cf9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  6d9d305 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
>  80c5cca 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2
>  67806d7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  eb71d6f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  890a990 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  703792b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  b3e4dbf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-client-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json cab15a4 
>   ambari-web/app/data/HDP2/site_properties.js 9ca0218 
> 
> Diff: https://reviews.apache.org/r/46895/diff/
> 
> 
> Testing
> ---
> 
> ambari-web tests:
> 
> 27544 tests complete (32 seconds)
> 154 tests pending
>   
> ambari-server python tests:
> 
> Total run:998
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46895: Add smartconfig for Logsearch

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46895/#review131311
---


Ship it!




Ship It!

- Sumit Mohanty


On May 2, 2016, 1:56 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46895/
> ---
> 
> (Updated May 2, 2016, 1:56 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16200
> https://issues.apache.org/jira/browse/AMBARI-16200
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - add smartconfig about the most important solr/logsearch properties 
> (theme.json)
> - add mergeFactor as configurable property
> - configurable log4j.properties for solr-client
> - add small property attribute changes
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  8ac7c1f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  694f2db 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  018cffd 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml
>  9dfbaf7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  01dff67 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-client-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  69aead7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 56a5cf9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  6d9d305 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
>  80c5cca 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2
>  67806d7 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  eb71d6f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  890a990 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  703792b 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  b3e4dbf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-client-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json cab15a4 
>   ambari-web/app/data/HDP2/site_properties.js 9ca0218 
> 
> Diff: https://reviews.apache.org/r/46895/diff/
> 
> 
> Testing
> ---
> 
> ambari-web tests:
> 
> 27544 tests complete (32 seconds)
> 154 tests pending
>   
> ambari-server python tests:
> 
> Total run:998
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46889: Improve output of command execution retry logic on agents

[Sandor Magyari]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46889/#review131305
---


Ship it!




Ship It!

- Sandor Magyari


On May 2, 2016, 12:05 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46889/
> ---
> 
> (Updated May 2, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16199
> https://issues.apache.org/jira/browse/AMBARI-16199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When command execution is retried on agent, the output of the command can be 
> misleading if the first try failed, but the second was successful.
> In that case error message remains in the output to indicate that there was a 
> recovered problem.
> 
> Additional information was added here to indicate that a retry happened and a 
> summary line that states whether eventually the command was successful or not.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e 
> 
> Diff: https://reviews.apache.org/r/46889/diff/
> 
> 
> Testing
> ---
> 
> I did manual testing to see the output messages on the UI.
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

[Mugdha Varadkar]

> On April 29, 2016, 6:03 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py,
> >  line 477
> > 
> >
> > In the old logic we used to retry on check_ranger_service() 5 times. 
> > Now we will retry only on create_repo(). What if create_ambari_admin_user() 
> > or get_repo() fail?

create_ambari_admin_user and get_repo, both the functions have @safe_retry. If 
both the functions fails then showing the error and proceed with the flow.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46833/#review131149
---


On May 2, 2016, 12:55 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46833/
> ---
> 
> (Updated May 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Robert Levas, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16182
> https://issues.apache.org/jira/browse/AMBARI-16182
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As Ranger KMS starts using rangerkms as its own identity, need to add this 
> identity to be generated from Ambari.
> 
> Changes include:
> 1) added rangerkms principal / keytab related changes in kerberos.json
> 2) using curl call to get/create repository for Ranger KMS using rangerkms 
> identity.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  9709713 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  9e54649 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  ce136b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  1a5dd7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
>  b652574 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/kerberos.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46833/diff/
> 
> 
> Testing
> ---
> 
> Tested on centos 6 with Ranger KMS installed on Kerberos enabled cluster for 
> stack 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46833: AMBARI-16182 Add new component level identity for RANGER_KMS in kerberos.json for stack 2.5

[Mugdha Varadkar]

> On April 29, 2016, 6:05 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml,
> >  line 52
> > 
> >
> > I am assuming this is a new property in HDP-2.5 and not a property that 
> > was there in a released HDP version that we are renaming.

New property in HDP-2.5


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46833/#review131150
---


On May 2, 2016, 12:55 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46833/
> ---
> 
> (Updated May 2, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Jayush Luniya, Robert Levas, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16182
> https://issues.apache.org/jira/browse/AMBARI-16182
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As Ranger KMS starts using rangerkms as its own identity, need to add this 
> identity to be generated from Ambari.
> 
> Changes include:
> 1) added rangerkms principal / keytab related changes in kerberos.json
> 2) using curl call to get/create repository for Ranger KMS using rangerkms 
> identity.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  9709713 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  9e54649 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  ce136b2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  1a5dd7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml
>  b652574 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/kerberos.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46833/diff/
> 
> 
> Testing
> ---
> 
> Tested on centos 6 with Ranger KMS installed on Kerberos enabled cluster for 
> stack 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46889: Improve output of command execution retry logic on agents

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46889/#review131296
---


Ship it!




Ship It!

- Oliver Szabo


On May 2, 2016, 12:05 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46889/
> ---
> 
> (Updated May 2, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16199
> https://issues.apache.org/jira/browse/AMBARI-16199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When command execution is retried on agent, the output of the command can be 
> misleading if the first try failed, but the second was successful.
> In that case error message remains in the output to indicate that there was a 
> recovered problem.
> 
> Additional information was added here to indicate that a retry happened and a 
> summary line that states whether eventually the command was successful or not.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e 
> 
> Diff: https://reviews.apache.org/r/46889/diff/
> 
> 
> Testing
> ---
> 
> I did manual testing to see the output messages on the UI.
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Re: Review Request 46889: Improve output of command execution retry logic on agents

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46889/#review131294
---


Ship it!




Ship It!

- Sebastian Toader


On May 2, 2016, 2:05 p.m., Daniel Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46889/
> ---
> 
> (Updated May 2, 2016, 2:05 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
> Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16199
> https://issues.apache.org/jira/browse/AMBARI-16199
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When command execution is retried on agent, the output of the command can be 
> misleading if the first try failed, but the second was successful.
> In that case error message remains in the output to indicate that there was a 
> recovered problem.
> 
> Additional information was added here to indicate that a retry happened and a 
> summary line that states whether eventually the command was successful or not.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e 
> 
> Diff: https://reviews.apache.org/r/46889/diff/
> 
> 
> Testing
> ---
> 
> I did manual testing to see the output messages on the UI.
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Review Request 46889: Improve output of command execution retry logic on agents

[Daniel Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46889/
---

Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, Sumit 
Mohanty, and Sebastian Toader.


Bugs: AMBARI-16199
https://issues.apache.org/jira/browse/AMBARI-16199


Repository: ambari


Description
---

When command execution is retried on agent, the output of the command can be 
misleading if the first try failed, but the second was successful.
In that case error message remains in the output to indicate that there was a 
recovered problem.

Additional information was added here to indicate that a retry happened and a 
summary line that states whether eventually the command was successful or not.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py c5340a0 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py bca506e 

Diff: https://reviews.apache.org/r/46889/diff/


Testing
---

I did manual testing to see the output messages on the UI.


Thanks,

Daniel Gergely