date:20160601


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48157/
---

(Updated June 2, 2016, 1:25 a.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Bugs: AMBARI-16994
https://issues.apache.org/jira/browse/AMBARI-16994


Repository: ambari


Description
---

In Ambari 2.4.0.0, we will be added stack_features and stack_tools config 
properties. On upgrade to Ambari 2.4.0.0 these config properties will be 
automatically added because these are new properties.

For all future Ambari upgrades above Ambari 2.4+, we should always update these 
config properties to the latest config property value as defined in the stack. 
The change here is essentially for future proofing beyond Ambari 2.4.0.0 
release.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9a3fa31 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 73c9d97 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
59b2db2 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
 334afaf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
2ae5b72 
  ambari-server/src/test/python/TestVersionSelectUtil.py 807a0e8 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py 9a4dd31 
  ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 

Diff: https://reviews.apache.org/r/48157/diff/


Testing (updated)
---

- Verified that upgrade to Ambari 2.4.0.0 adds stack_features and stack_tools 
config properties
- Verified that upgrading to Ambari 2.4.1.0 updates stack_features and 
stack_tools by adding dummy entries.

There are a few UT failures in trunk not related to this patch. See 
https://builds.apache.org/job/Ambari-trunk-Commit/4982/testReport/


Build Results :

Failed tests:
  StackManagerMiscTest.testCycleDetection:70 expected:<[Cycle detected while 
parsing stack definition]> but was:<[File 
/Users/jluniya/release/trunk2/ambari/ambari-server/target/test-classes/stacks_with_cycle/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml
 didn't pass the validation. Error message is : cvc-complex-type.2.4.a: Invalid 
content was found starting with element 'deletable'. One of '{display-name, 
filename, deleted, on-ambari-upgrade, on-stack-upgrade, property-type, 
value-attributes, depends-on, property_depended_by}' is expected.]>
Tests in error:
  
StackManagerTest.initStack:81->createTestStackManager:86->createTestStackManager:103
 » Ambari
  ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:48 » Ambari File 
/Us...

Tests run: 4394, Failures: 1, Errors: 2, Skipped: 34

[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 1:10:35.104s
[INFO] Finished at: Wed Jun 01 18:14:45 PDT 2016
[INFO] Final Memory: 38M/1011M
[INFO] 


Thanks,

Jayush Luniya

Re: Review Request 48125: AMBARI-16984 Add changes for Ranger Service to get previous_jdbc_jar_name

2016-06-01 Thread Srimanth Gunturi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48125/#review135889
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 (line 38)


Should it be "if params.driver_curl_source is not None and ..."? 

A similar change was made in 
"ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py".

Same comment applies to other changes in this patch which use 
"driver_curl_source"


- Srimanth Gunturi


On June 1, 2016, 12:59 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48125/
> ---
> 
> (Updated June 1, 2016, 12:59 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Srimanth Gunturi, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-16984
> https://issues.apache.org/jira/browse/AMBARI-16984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Copying of jdbc jar for Ranger and Ranger KMS is only done at time of 
> installation and during upgrade of HDP.
> This fix will update the latest jar set by user and delete the previous jar 
> at restart of Ranger and Ranger KMS
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
>  80e5664 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
>  3dc4914 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  665fa48 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  e446c43 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  03c1258 
> 
> Diff: https://reviews.apache.org/r/48125/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger and Ranger KMS fresh installation of jdbc jar and then set a 
> newer version of jar and check everything is working fine.
> Tested ambari upgrade.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47705: AMBARI-16731 Should close file object in security.py

2016-06-01 Thread Masahiro Tanaka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47705/#review135888
---



Could anyone review this? I think this isn't a difficult patch.

- Masahiro Tanaka


On 5月 29, 2016, 2:55 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47705/
> ---
> 
> (Updated 5月 29, 2016, 2:55 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-16731
> https://issues.apache.org/jira/browse/AMBARI-16731
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> reqSignCrt method opens CSR file with open function but that doesn't close it.
> And, loadSrvrCrt method opens a file but this is unclosed too.
> They waste resources and may cause a problem
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 779b85c 
> 
> Diff: https://reviews.apache.org/r/47705/diff/
> 
> 
> Testing
> ---
> 
> mvn -fae clean install
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 48134: Remove logsearch-solr-client dependency from Atlas

2016-06-01 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48134/
---

(Updated June 2, 2016, 12:13 a.m.)


Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Tom Beerbower.


Changes
---

logsearch should use also solr_cloud_util to setup logsearch-solr-client


Bugs: AMBARI-16961
https://issues.apache.org/jira/browse/AMBARI-16961


Repository: ambari


Description
---

removed LOGSEARCH_SOLR_CLIENT dependency from Atlas stack definition to not 
force ambari to install the client (if LOGSEARCH service is not used).
Also I provided a new function in solr_cloud_util to handle permissions on the 
solr client files (set the same as logsearch uses, then we wont run into any 
permission issues)


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 b916f19 
  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 e6e794c 
  ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
d0d73ad 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 a2d78a9 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 573857b 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py
 767e208 
  ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 
ce2528b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
4890f00 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
faa7350 
  ambari-server/src/test/python/stacks/2.3/configs/default.json 157fd7e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 3ad8656 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 6362a4c 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 6839dee 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 0b67405 

Diff: https://reviews.apache.org/r/48134/diff/


Testing
---

unit tests done.

FT: I cannot really test it with HDP 2.5 because on the ATLAS side, in the 
start script it tries to setup collections anyway, so this patch should be 
applied with a fresh ATLAS... so, i opened this review request mostly for only 
review.


Thanks,

Oliver Szabo

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services



> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch?
> 
> Juanjo  Marron wrote:
> Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797.
> Waiting for Hadoop QA review

Patch applied cleanly by Hadoop QA

Hadoop QA added a comment - 6 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12807525/AMBARI-16797.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7124//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7124//console
This message is automatically generated.


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135754
---


On May 26, 2016, 11:04 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47923/
> ---
> 
> (Updated May 26, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
>  bccd714 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
>  eca8534 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  3838061 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
>  9311454 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
> 
> Diff: https://reviews.apache.org/r/47923/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> PIG fresh installation and service check
> 
> Hadoop QA added a comment - 1 hour ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-01 Thread Jeff Zhang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46727/
---

(Updated June 1, 2016, 11:06 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-15612
https://issues.apache.org/jira/browse/AMBARI-15612


Repository: ambari


Description
---

Add Livy to HDP 2.5 as slave component of Spark.

Move the spark stack definiation to commoon-services and then


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 eba1abf 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9a3fa31 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/livy_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
 3f14955 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
 694f046 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_livy.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
 86e7f7d 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 99a3ade 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
d2e0d11 
  ambari-server/src/main/resources/stacks/HDP/2.5/role_command_order.json 
4a7c1d2 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-spark-blacklist.xml
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/metainfo.xml 
d1129cd 

Diff: https://reviews.apache.org/r/46727/diff/


Testing
---

Manully verify it. Livy is installed correctly in non-secure and secure cluster.


Thanks,

Jeff Zhang

Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48157/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Bugs: AMBARI-16994
https://issues.apache.org/jira/browse/AMBARI-16994


Repository: ambari


Description
---

In Ambari 2.4.0.0, we will be added stack_features and stack_tools config 
properties. On upgrade to Ambari 2.4.0.0 these config properties will be 
automatically added because these are new properties.

For all future Ambari upgrades above Ambari 2.4+, we should always update these 
config properties to the latest config property value as defined in the stack. 
The change here is essentially for future proofing beyond Ambari 2.4.0.0 
release.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 9a3fa31 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py
 73c9d97 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
59b2db2 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/FinalUpgradeCatalog.java
 334afaf 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
2ae5b72 
  ambari-server/src/test/python/TestVersionSelectUtil.py 807a0e8 
  ambari-server/src/test/python/custom_actions/test_ru_set_all.py 9a4dd31 
  ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d 
  ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 

Diff: https://reviews.apache.org/r/48157/diff/


Testing
---


Thanks,

Jayush Luniya

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135880
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query



> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line 
> > 161
> > 
> >
> > Typo?
> 
> Jaimin Jetly wrote:
> This is intended change to address scenario 1 stated in description. The 
> change makes an explicit recommendation call when interactive query is again 
> disabled which is needed.

I suppose you were pointing towards the name of the funcion 
sendRequestRorDependentConfigs. It seems to be a typo but its an existing 
function and is being used at many places. I will kep an eye on it and will fix 
the function name in a refactoring task


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48123: Update default ambari view read timeout to a larger value

2016-06-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48123/#review135878
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 1, 2016, 11:37 a.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48123/
> ---
> 
> (Updated June 1, 2016, 11:37 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16981
> https://issues.apache.org/jira/browse/AMBARI-16981
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Increased the ambari connect and read timeout to 30sec and 45sec respectively.
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties e324d764 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  900083f 
> 
> Diff: https://reviews.apache.org/r/48123/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.

2016-06-01 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/#review135877
---


Ship it!




Ship It!

- Oliver Szabo


On June 1, 2016, 7 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48147/
> ---
> 
> (Updated June 1, 2016, 7 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-16991
> https://issues.apache.org/jira/browse/AMBARI-16991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After a recent change the AbstractTimelineMetricsSink class has an abstract 
> function called getZookeeperQuorum(). If the extending class is returning 
> null, then the sink is not working (neither does it if it returns a valid 
> zookeeper connection string). Fixed the first issue, now it is working 
> without a zookeeper connect string.
> 
> Also fixed the name of the misnamed variables called zk_hosts which actually 
> contained a zookeper connect string.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
>  1f86dd0 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  6fb0b0e 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
>  200a603 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
> b6301ca 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
>  076c09c 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
>  afbccca 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  03ff0ff 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
>  14125bc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  147e148 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  007c357 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
>  21c010f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
>  0a94186 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  a2da737 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
>  2805b0b 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
>  0813221 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
>  f814678 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
>  c382c14 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  ca7ccea 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
>  6a52708 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
>  7e649ea 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
>  b31f39b 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 
> 
> Diff: https://reviews.apache.org/r/48147/diff/
> 
> 
> Testing
> ---
> 
> Tested on local cluster.
> 
> ambari-logsearch-solr-client:
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
> 
> ambari-logsearch-logfeeder:
> Tests run: 35, Failures: 0, Errors: 0, Skipped: 0
> 
> ambari-server:
> Total run:1052
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query



> On June 1, 2016, 9:41 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js, 
> > line 152
> > 
> >
> > Typo?

unit test change needed to accomodate the change made in the corresponding part 
of application code.


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135868
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query



> On June 1, 2016, 9:40 p.m., Zhe (Joe) Wang wrote:
> > ambari-web/app/controllers/wizard/step7/assign_master_controller.js, line 
> > 161
> > 
> >
> > Typo?

This is intended change to address scenario 1 stated in description. The change 
makes an explicit recommendation call when interactive query is again disabled 
which is needed.


- Jaimin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 48156: Misc fixes related to slider while enabling interactive query


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/
---

Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.


Bugs: AMBARI-16993
https://issues.apache.org/jira/browse/AMBARI-16993


Repository: ambari


Description
---

*Scenario 1:*
# Install a Ambari-2.2.2 cluster with hive service
# Upgrade to Ambari-2.4.0
# Enable interactive query. A popup asking to install slider service first will 
be shown. Also recommendations for enable interactive query are shown in the bg 
# Dismiss the popup. This again disables interactive query

*Actual behavior:* Recommendations for enabled interactive query remains
*Expected behavior:* Since interactive query is again disabled, recommendations 
for enabled interactive query should go away.


*Scenario 2:*
# Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
client on 2 out of 3 hosts.
# Enable interactive query. Select a host on which slider client is absent for 
HS2 interactive.
#  Save configurations

*Actual behavior:* Install components request has tasks to installs Slider 
client on all 3 hosts
*Expected behavior:* Install components request should install Slider client 
only on 1 host (HS2 interactive host)


Diffs
-

  ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
0907aa7 
  ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
df2f70b 

Diff: https://reviews.apache.org/r/48156/diff/


Testing
---

Verifies that the patch resolves both the stated issues
ambari-web unit tests with the patch:
28524 tests complete (28 seconds)
154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135868
---




ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js (line 
152)


Typo?


- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 48156: Misc fixes related to slider while enabling interactive query

2016-06-01 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135867
---




ambari-web/app/controllers/wizard/step7/assign_master_controller.js (line 161)


Typo?


- Zhe (Joe) Wang


On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48156/
> ---
> 
> (Updated June 1, 2016, 9:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16993
> https://issues.apache.org/jira/browse/AMBARI-16993
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Scenario 1:*
> # Install a Ambari-2.2.2 cluster with hive service
> # Upgrade to Ambari-2.4.0
> # Enable interactive query. A popup asking to install slider service first 
> will be shown. Also recommendations for enable interactive query are shown in 
> the bg 
> # Dismiss the popup. This again disables interactive query
> 
> *Actual behavior:* Recommendations for enabled interactive query remains
> *Expected behavior:* Since interactive query is again disabled, 
> recommendations for enabled interactive query should go away.
> 
> 
> *Scenario 2:*
> # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider 
> client on 2 out of 3 hosts.
> # Enable interactive query. Select a host on which slider client is absent 
> for HS2 interactive.
> #  Save configurations
> 
> *Actual behavior:* Install components request has tasks to installs Slider 
> client on all 3 hosts
> *Expected behavior:* Install components request should install Slider client 
> only on 1 host (HS2 interactive host)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> 0907aa7 
>   ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js 
> df2f70b 
> 
> Diff: https://reviews.apache.org/r/48156/diff/
> 
> 
> Testing
> ---
> 
> Verifies that the patch resolves both the stated issues
> ambari-web unit tests with the patch:
> 28524 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services



> On June 1, 2016, 2:53 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch?

Patch submitted to https://issues.apache.org/jira/browse/AMBARI-16797.
Waiting for Hadoop QA review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47923/#review135754
---


On May 26, 2016, 11:04 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47923/
> ---
> 
> (Updated May 26, 2016, 11:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16797
> https://issues.apache.org/jira/browse/AMBARI-16797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for SPARK service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/job_history_server.py
>  bccd714 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py
>  c5f3eb6 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/service_check.py
>  694f046 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/setup_spark.py
>  eca8534 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_client.py
>  3838061 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/spark_thrift_server.py
>  9311454 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/status_params.py
>  86e7f7d 
> 
> Diff: https://reviews.apache.org/r/47923/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> PIG fresh installation and service check
> 
> Hadoop QA added a comment - 1 hour ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12805785/AMBARI-16797.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6981//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor

2016-06-01 Thread bhuvnesh chaudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48155/#review135863
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On June 1, 2016, 9:02 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48155/
> ---
> 
> (Updated June 1, 2016, 9:02 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16992
> https://issues.apache.org/jira/browse/AMBARI-16992
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Set hawq_rm_nvcore_limit_perseg as the lowest cpu_count across all HAWQ hosts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  94e1854 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 6fbdf45 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> b931dc6 
> 
> Diff: https://reviews.apache.org/r/48155/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> Added unit test:
> ```
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE ... ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ok
> test_getComponentLayoutValidations_sparkts_no_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is not installed ... ok
> test_getComponentLayoutValidations_sparkts_with_hive 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test SparkTS is picked when Hive is installed ... ok
> test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor)

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services



> On June 1, 2016, 2:33 a.m., Jayush Luniya wrote:
> > Patch doesnt apply cleanly. Can you rebase the patch and resolve conflicts?

New patch submitted to https://issues.apache.org/jira/browse/AMBARI-16672.
Waiting for HAdoop QA review


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47653/#review135750
---


On May 20, 2016, 6:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47653/
> ---
> 
> (Updated May 20, 2016, 6:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16672
> https://issues.apache.org/jira/browse/AMBARI-16672
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for OOzie service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
>  b3c6537 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  3060353 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47653/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> OOZIE fresh installation and service check
> 
> Hadoop QA added a comment - 4 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804552/AMBARI-16672.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6920//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

2016-06-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48154/#review135860
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 (line 128)


Indentation of 2 spaces



ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 (line 131)


This is accessing index 1 without first checking the length


- Alejandro Fernandez


On June 1, 2016, 8:49 p.m., Sumit Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48154/
> ---
> 
> (Updated June 1, 2016, 8:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Dmytro Sen.
> 
> 
> Bugs: AMBARI-13820
> https://issues.apache.org/jira/browse/AMBARI-13820
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The default topology file in Knox's config contains a template for webhdfs 
> service hosts and ports that gets incorrectly populated when in HA mode.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  cba388b 
> 
> Diff: https://reviews.apache.org/r/48154/diff/
> 
> 
> Testing
> ---
> 
> Tested end to end with a 3 node cluster that had webhdfs setup for HA and 
> Knox setup for proxying those services in HA. The configuration was incorrect 
> before applying the changes in the patch and correct after applying the 
> changes and restarting the server and agent.
> 
> 
> Thanks,
> 
> Sumit Gupta
> 
>

Review Request 48155: Recommend hawq_rm_nvcore_limit_perseg in HAWQ service advisor

2016-06-01 Thread Matt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48155/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.

Bugs: AMBARI-16992
https://issues.apache.org/jira/browse/AMBARI-16992

Repository: ambari

Description
---

Set hawq_rm_nvcore_limit_perseg as the lowest cpu_count across all HAWQ hosts

Diffs
-

ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
94e1854
ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 6fbdf45
ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py b931dc6

Diff: https://reviews.apache.org/r/48155/diff/

Testing
---

Manually tested.

Added unit test:
```
test_createComponentLayoutRecommendations_hawq_1_Host
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard,
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE
... ok
test_getComponentLayoutValidations_sparkts_no_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor)
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ...
ok
test_recommendHiveConfigurations_with_atlas
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations

Re: Review Request 47858: Cache service advisors when stack advisor is loaded


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/#review135854
---


Ship it!




Ship It!

- Jayush Luniya


On May 27, 2016, 7:11 p.m., Lav Jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47858/
> ---
> 
> (Updated May 27, 2016, 7:11 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush 
> Luniya, Matt, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-16665
> https://issues.apache.org/jira/browse/AMBARI-16665
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the current implementation, service advisors for the same service are 
> loaded multiple times in the stack advisor.
> 
> The service advisors should be cached when the stack advisor is loaded and 
> used where necessary.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 63885d2 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 1d6a85c 
> 
> Diff: https://reviews.apache.org/r/47858/diff/
> 
> 
> Testing
> ---
> 
> Lavs-MacBook-Pro:common ljain$ python -m discover -v
> test_createComponentLayoutRecommendations_hawq_1_Host 
> (test_stack_advisor.TestHDP23StackAdvisor) ... ServiceAdvisor implementation 
> for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSTANDBY is recommended on a 3-node cluster ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT does not get recommended during Add Service Wizard, 
> when HAWQ has already been installed ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
> when HAWQ is selected for installation ... ServiceAdvisor implementation for 
> service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that HAWQSEGMENT gets recommended correctly during Cluster Install 
> Wizard, when HAWQ is selected for installation ... ServiceAdvisor 
> implementation for service HAWQ was loaded
> ok
> test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components ... ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF does not get recommended during Add Service Wizard, when PXF 
> has already been installed ... ServiceAdvisor implementation for service PXF 
> was loaded
> ok
> test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
>  (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Add Service Wizard, when PXF 
> is selected for installation ... ServiceAdvisor implementation for service 
> PXF was loaded
> ok
> test_createComponentLayoutRecommendations_pxf_cluster_install 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test that PXF gets recommended correctly during Cluster Install Wizard, when 
> PXF is selected for installation ... ServiceAdvisor implementation for 
> service PXF was loaded
> ok
> test_getComponentLayoutValidations_hawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test layout validations for HAWQ components on a 3-node cluster ... 
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test validation warning for HAWQ segment not colocated with DATANODE ... 
> ServiceAdvisor implementation for service HAWQ was loaded
> ok
> test_getComponentLayoutValidations_nohawq_3_Hosts 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test no failures when there are no HAWQ components on a 3-node cluster ... ok
> test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test NO warning is generated when PXF is co-located with NAMENODE and 
> DATANODE ... ServiceAdvisor implementation for service PXF was loaded
> ok
> test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
> (test_stack_advisor.TestHDP23StackAdvisor)
> Test warning is generated when PXF is not co-located with NAMENODE or 
> DATANODE ... ServiceAdvisor implementation

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-06-01 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/#review135852
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 30, 2016, 9:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47880/
> ---
> 
> (Updated May 30, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16890
> https://issues.apache.org/jira/browse/AMBARI-16890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 
> - Enable Ranger SSO property as a checkbox
> - Populate query param originalUrl
> 
> - Deleted below properties from ranger-admin-site.xml latest stack and also 
> during upgrade.
>   ranger.sso.cookiename
>   ranger.sso.query.param.originalurl
> 
> - Adding below new properties to ranger-admin-site.xml:
>   ranger.kms.service.user.hdfs – default value "hdfs"
>   ranger.kms.service.user.hive – default value "hive"
> 
> - Updating default value for below properties in latest stack:
>   ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
>   ranger.ldap.user.searchfilter(uid={0})
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
>  daab4ec 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  b358f27 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  91d8093 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
>  c1ffeb6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1130d9a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  4362fe0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 0e0ea1d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> b68354f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  5ccb153 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bc45be6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 658e6aa 
>   ambari-web/app/data/HDP2.3/site_properties.js e04d060 
> 
> Diff: https://reviews.apache.org/r/47880/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/#review135851
---


Ship it!




Ship It!

- Jayush Luniya


On June 1, 2016, 6:26 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48143/
> ---
> 
> (Updated June 1, 2016, 6:26 p.m.)
> 
> 
> Review request for Ambari and Jayush Luniya.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Missing import check_process_status for YARN nodemanager service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  038ccb9 
> 
> Diff: https://reviews.apache.org/r/48143/diff/
> 
> 
> Testing
> ---
> 
> Added after Jayush Luniya comment on https://reviews.apache.org/r/47963
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 48154: Incorrect ports in WebHDFS HA config in Knox

2016-06-01 Thread Sumit Gupta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48154/
---

Review request for Ambari, Alejandro Fernandez and Dmytro Sen.


Bugs: AMBARI-13820
https://issues.apache.org/jira/browse/AMBARI-13820


Repository: ambari


Description
---

The default topology file in Knox's config contains a template for webhdfs 
service hosts and ports that gets incorrectly populated when in HA mode.


Diffs
-

  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 cba388b 

Diff: https://reviews.apache.org/r/48154/diff/


Testing
---

Tested end to end with a 3 node cluster that had webhdfs setup for HA and Knox 
setup for proxying those services in HA. The configuration was incorrect before 
applying the changes in the patch and correct after applying the changes and 
restarting the server and agent.


Thanks,

Sumit Gupta

Re: Review Request 48134: Remove logsearch-solr-client dependency from Atlas

2016-06-01 Thread Tom Beerbower


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48134/#review135849
---


Ship it!




Looks good to me.  Thanks for doing that!

- Tom Beerbower


On June 1, 2016, 4:58 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48134/
> ---
> 
> (Updated June 1, 2016, 4:58 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton, Sumit Mohanty, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-16961
> https://issues.apache.org/jira/browse/AMBARI-16961
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> removed LOGSEARCH_SOLR_CLIENT dependency from Atlas stack definition to not 
> force ambari to install the client (if LOGSEARCH service is not used).
> Also I provided a new function in solr_cloud_util to handle permissions on 
> the solr client files (set the same as logsearch uses, then we wont run into 
> any permission issues)
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  b916f19 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  e6e794c 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> d0d73ad 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  a2d78a9 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  573857b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 
> ce2528b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 4890f00 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> faa7350 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json 157fd7e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 3ad8656 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 6839dee 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 0b67405 
> 
> Diff: https://reviews.apache.org/r/48134/diff/
> 
> 
> Testing
> ---
> 
> unit tests done.
> 
> FT: I cannot really test it with HDP 2.5 because on the ATLAS side, in the 
> start script it tries to setup collections anyway, so this patch should be 
> applied with a fresh ATLAS... so, i opened this review request mostly for 
> only review.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47879: AMBARI-16807: After enabling HTTPS for HDFS, Data Node JVM Metrics on HDFS Heatmaps show NA

2016-06-01 Thread Qin Liu



> On May 26, 2016, 3:11 p.m., Dmytro Sen wrote:
> > Ship It!
> 
> Qin Liu wrote:
> Thank you so much Dmytro!

Hi Sid,
Could you please review the patch at your earliest convenience? Thank you in 
advance!


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47879/#review134989
---


On May 26, 2016, 10:27 a.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47879/
> ---
> 
> (Updated May 26, 2016, 10:27 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16807
> https://issues.apache.org/jira/browse/AMBARI-16807
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After enabling HTTPS for HDFS, "DataNode Garbage Collection Time", "DataNode 
> JVM Heap Memory Used ", and "DataNode JVM Heap Memory Committed" widgets on 
> HDFS Heatmaps show NA. The root cause is that dfs.datanode.http.address 
> rather than dfs.datanode.https.address is used to get JMX metrics. 
> 
> Steps to reproduce:
> 1. install a cluster with default from Ambari Web UI.
> 2. configuring SSL for HDFS, YARN, and MapReduce.
> 3. enable HTTPS for HDFS
> Set the following properties in Advanced hdfs-site from Ambari Web UI:
> dfs.http.policy=HTTPS_ONLY
> dfs.datanode.http.address=0.0.0.0:50075
> dfs.datanode.https.address=0.0.0.0:50475
> 4. "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" widgets on HDFS Heatmaps will show NA.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  30ce19a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  8ef6f0c 
> 
> Diff: https://reviews.apache.org/r/47879/diff/
> 
> 
> Testing
> ---
> 
> 1. The fix has been tested with HDP UI
> "DataNode Garbage Collection Time", "DataNode JVM Heap Memory Used " and 
> "DataNode JVM Heap Memory Committed" metrics show up after apply the fix.
> 
> 2. A new testcase is added in JMXHostProviderTest.java to verify JMX protocol 
> and port for DataNode.
> Test set: org.apache.ambari.server.controller.internal.JMXHostProviderTest
> ---
> Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 111.192 sec 
> - in org.apache.ambari.server.controller.internal.JMXHostProviderTest
> 
> 3. The ambari-server tests:
> The following tests had issues in Hadoop QA testing but they passed in my 
> testing:
> Failed tests: 
>   
> ConfigHelperTest$RunWithInMemoryDefaultTestModule.testCalculateIsStaleConfigsParallel:880
>  null
> Tests in error: 
>   HostResourceProviderTest.testUpdateResourcesAsServiceAdministrator »  
> Unexpect...
> 
> Here are my testing results for above tests:
> Test set: org.apache.ambari.server.state.ConfigHelperTest
> ---
> Tests run: 18, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 160.88 sec - 
> in org.apache.ambari.server.state.ConfigHelperTest
> 
> Test set: 
> org.apache.ambari.server.controller.internal.HostResourceProviderTest
> ---
> Tests run: 31, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.209 sec - 
> in org.apache.ambari.server.controller.internal.HostResourceProviderTest
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 48147: Fix metric sink + rename misnamed zk-connect-string variables.

2016-06-01 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/
---

(Updated June 1, 2016, 6:57 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

added zk connect string renaming to the title too


Summary (updated)
-

Fix metric sink + rename misnamed zk-connect-string variables.


Bugs: AMBARI-16991
https://issues.apache.org/jira/browse/AMBARI-16991


Repository: ambari


Description
---

After a recent change the AbstractTimelineMetricsSink class has an abstract 
function called getZookeeperQuorum(). If the extending class is returning null, 
then the sink is not working (neither does it if it returns a valid zookeeper 
connection string). Fixed the first issue, now it is working without a 
zookeeper connect string.

Also fixed the name of the misnamed variables called zk_hosts which actually 
contained a zookeper connect string.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 1f86dd0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 6fb0b0e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
 200a603 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
b6301ca 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 076c09c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
 afbccca 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 03ff0ff 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 14125bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 007c357 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 21c010f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 0a94186 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 a2da737 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 2805b0b 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 0813221 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
 f814678 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 c382c14 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 ca7ccea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 6a52708 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 7e649ea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 b31f39b 
  ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 

Diff: https://reviews.apache.org/r/48147/diff/


Testing
---

Tested on local cluster.

ambari-logsearch-solr-client:
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

ambari-logsearch-logfeeder:
Tests run: 35, Failures: 0, Errors: 0, Skipped: 0

ambari-server:
Total run:1052
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Review Request 48147: Fix metric sink

2016-06-01 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48147/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-16991
https://issues.apache.org/jira/browse/AMBARI-16991


Repository: ambari


Description
---

After a recent change the AbstractTimelineMetricsSink class has an abstract 
function called getZookeeperQuorum(). If the extending class is returning null, 
then the sink is not working (neither does it if it returns a valid zookeeper 
connection string). Fixed the first issue, now it is working without a 
zookeeper connect string.

Also fixed the name of the misnamed variables called zk_hosts which actually 
contained a zookeper connect string.


Diffs
-

  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/logconfig/FetchConfigFromSolr.java
 1f86dd0 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 6fb0b0e 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SolrUtil.java
 200a603 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/config.json.j2 
b6301ca 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/logfeeder.properties
 076c09c 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/output/OutputSolrTest.java
 afbccca 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 03ff0ff 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 14125bc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 147e148 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 007c357 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrMetricsLoader.java
 21c010f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/resources/logsearch.properties.j2
 0a94186 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 a2da737 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 2805b0b 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 0813221 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetSolrHostsCommand.java
 f814678 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 c382c14 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 ca7ccea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logfeeder.properties.j2
 6a52708 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/logsearch.properties.j2
 7e649ea 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
 b31f39b 
  ambari-server/src/test/python/stacks/2.4/configs/default.json e01bc26 

Diff: https://reviews.apache.org/r/48147/diff/


Testing
---

Tested on local cluster.

ambari-logsearch-solr-client:
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

ambari-logsearch-logfeeder:
Tests run: 35, Failures: 0, Errors: 0, Skipped: 0

ambari-server:
Total run:1052
Total errors:0
Total failures:0


Thanks,

Miklos Gergely

Re: Review Request 48036: Service name shown instead of Host name on popup

2016-06-01 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/#review135840
---


Ship it!




Ship It!

- Nate Cole


On June 1, 2016, 12:01 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48036/
> ---
> 
> (Updated June 1, 2016, 12:01 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-16953
> https://issues.apache.org/jira/browse/AMBARI-16953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> # Deploy ambari with HDP2.2
> # Register and install HDP2.5
> # Click "Upgrade"
> # Look at the Rolling Upgrade checks
> Result: Service name SECONDARY_NAMENODE shown instead of Host name on popup
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  5899370 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
>  4893098 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  9abfa50 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheckTest.java
>  e2617bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServiceCheckValidityCheckTest.java
>  55429bd 
> 
> Diff: https://reviews.apache.org/r/48036/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 47963: clean up import * for YARN service



> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py,
> >  line 91
> > 
> >
> > @Juanjo, it looks like check_process_status is not imported for YARN 
> > nodemanager and will cause problems. Can you submit an addendum patch with 
> > this change?
> 
> Juanjo  Marron wrote:
> Hi Jayush, 
> Yes, ill work on fixing it. Can you tell me when you hit this issue for 
> verification, please?

New patch AMBARI-16849-2.patch added to solve missing import 
check_process_status for YARN nodemanager service:
https://issues.apache.org/jira/browse/AMBARI-16849


Created new review board
https://reviews.apache.org/r/48143/


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
---


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47586: Log Feeder Global exclusion default filter configuration is not effective in the log search indexing.

2016-06-01 Thread Robert Nettleton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47586/#review135836
---


Ship it!




Ship It!

- Robert Nettleton


On June 1, 2016, 6:20 a.m., Dharmesh Makwana wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47586/
> ---
> 
> (Updated June 1, 2016, 6:20 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco 
> Durai, Oliver Szabo, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16760
> https://issues.apache.org/jira/browse/AMBARI-16760
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logfeeder default filter doesn't comes in effect until it is loaded once from 
> UI.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/history/conf/managed-schema
>  062c14f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
>  b5c042d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigMgr.java
>  7a6e3e9 
> 
> Diff: https://reviews.apache.org/r/47586/diff/
> 
> 
> Testing
> ---
> 
> Setup logsearch on 3 node cluster and tested the above features.
> 
> 
> Thanks,
> 
> Dharmesh Makwana
> 
>

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/
---

(Updated June 1, 2016, 6:26 p.m.)


Review request for Ambari and Jayush Luniya.


Summary (updated)
-

Missing import check_process_status for YARN nodemanager service


Bugs: AMBARI-16849
https://issues.apache.org/jira/browse/AMBARI-16849


Repository: ambari


Description (updated)
---

Missing import check_process_status for YARN nodemanager service


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 038ccb9 

Diff: https://reviews.apache.org/r/48143/diff/


Testing
---

Added after Jayush Luniya comment on https://reviews.apache.org/r/47963


Thanks,

Juanjo  Marron

Review Request 48143: Missing import check_process_status for HDFS nodemanager service


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48143/
---

Review request for Ambari and Jayush Luniya.


Bugs: AMBARI-16849
https://issues.apache.org/jira/browse/AMBARI-16849


Repository: ambari


Description
---

Missing import check_process_status for HDFS nodemanager service


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 038ccb9 

Diff: https://reviews.apache.org/r/48143/diff/


Testing
---

Added after Jayush Luniya comment on https://reviews.apache.org/r/47963


Thanks,

Juanjo  Marron

Re: Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48139/#review135828
---


Ship it!




Ship It!

- Dmytro Sen


On Июнь 1, 2016, 6:06 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48139/
> ---
> 
> (Updated Июнь 1, 2016, 6:06 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sandor Magyari, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16986
> https://issues.apache.org/jira/browse/AMBARI-16986
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1) Install old version - 2.1.1
> 2) Enable Mit security
> 3)Make upgrade
> 4)Add smartSense
> Actual results: Required empty config is present after Upgrade from 2.1.2.1 
> to 2.4.0.0 for HIVE and HBASE
> Screenshots were attached
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  1c46a93 
> 
> Diff: https://reviews.apache.org/r/48139/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 48139: Required empty config is present after Upgrade from 2.1.2.1 to 2.4.0.0 for HIVE and HBASE

2016-06-01 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48139/
---

Review request for Ambari, Dmytro Sen, Sandor Magyari, and Sumit Mohanty.


Bugs: AMBARI-16986
https://issues.apache.org/jira/browse/AMBARI-16986


Repository: ambari


Description
---

STR:
1) Install old version - 2.1.1
2) Enable Mit security
3)Make upgrade
4)Add smartSense
Actual results: Required empty config is present after Upgrade from 2.1.2.1 to 
2.4.0.0 for HIVE and HBASE
Screenshots were attached


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 1c46a93 

Diff: https://reviews.apache.org/r/48139/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 48122: History tab takes long to populate when there is more entry in history table.

2016-06-01 Thread Rohit Choudhary


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48122/#review135825
---


Ship it!




Ship It!

- Rohit Choudhary


On June 1, 2016, 1:53 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48122/
> ---
> 
> (Updated June 1, 2016, 1:53 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16980
> https://issues.apache.org/jira/browse/AMBARI-16980
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In this patch:
> 1. the data will continue to be fetched from ATS and DB and merging etc as it 
> is today.
> 2. filtering and sorting will continue to be on client side as it is today.
> 3. (change) only fetching data based on date filter. Only when the date 
> filter changes the jobs will be refetched, but following points will apply.
> 4. (new) To show the latest state of the jobs, we have a polling from client 
> side for refetching the jobs which are not in terminal state. The polling 
> interval is 30 secs. This will also be done everytime the "Refresh" button 
> (new button) is clicked.
> 5. (new) if the "To Date" is today then we will also periodically fetch the 
> latest jobs from ATS everytime the user switches from any other tab to 
> history tab, or when user clicks the "Refresh" button. 
> 6. The initial date filter will be "last 5 days".
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/utils/ItemNotFound.java
>  3b7e51a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  f119ff3 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
>  34f060d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/OperationHandleResourceManager.java
>  f0eecea 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSParser.java
>  c4c85ad 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegate.java
>  02091f8 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/ATSRequestsDelegateImpl.java
>  471645d 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/atsJobs/IATSParser.java
>  f51b880 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/Job.java
>  9afb21a 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobControllerImpl.java
>  f6d6ed6 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobImpl.java
>  437c9ba 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/viewJobs/JobInfo.java
>  PRE-CREATION 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/components/number-range-widget.js
>  5d62b59 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js 
> 8c4ed2f 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> c8bb7d0 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/models/job.js 9079b5a 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
> 0aa3d41 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/history.js 
> PRE-CREATION 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/templates/history.hbs 
> 052498e 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/utils/constants.js 
> 4b9899a 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/ATSParserTest.java
>  d8e60c4 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/jobs/AggregatorTest.java
>  e1f7c7c 
> 
> Diff: https://reviews.apache.org/r/48122/diff/
> 
> 
> Testing
> ---
> 
> updated unit test cases.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 47963: clean up import * for YARN service



> On June 1, 2016, 5:49 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py,
> >  line 91
> > 
> >
> > @Juanjo, it looks like check_process_status is not imported for YARN 
> > nodemanager and will cause problems. Can you submit an addendum patch with 
> > this change?

Hi Jayush, 
Yes, ill work on fixing it. Can you tell me when you hit this issue for 
verification, please?


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
---


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47963: clean up import * for YARN service


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47963/#review135820
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
 (line 90)


@Juanjo, it looks like check_process_status is not imported for YARN 
nodemanager and will cause problems. Can you submit an addendum patch with this 
change?


- Jayush Luniya


On May 27, 2016, 4:33 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47963/
> ---
> 
> (Updated May 27, 2016, 4:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16849
> https://issues.apache.org/jira/browse/AMBARI-16849
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for YARN service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
>  4ec6aa7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
>  34c683a 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/install_jars.py
>  44015bf 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapred_service_check.py
>  13172ee 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
>  3ea3d75 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
>  7be49d5 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager_upgrade.py
>  1c886f9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_windows.py
>  0f8ce73 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  b1179b9 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  792a681 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  0e2c519 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
>  4d65a40 
> 
> Diff: https://reviews.apache.org/r/47963/diff/
> 
> 
> Testing
> ---
> 
> Passed mvn clean test -DskipSurefireTests
> YARN fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806423/AMBARI-16849.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7005//console
> This message is automatically generated.
> Reply
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 48105: AMBARI-16977 VDF: couple UI bugs in Install Wiz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48105/#review135816
---


Ship it!




Ship It!

- Jaimin Jetly


On June 1, 2016, 12:54 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48105/
> ---
> 
> (Updated June 1, 2016, 12:54 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, 
> Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16977
> https://issues.apache.org/jira/browse/AMBARI-16977
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix bugs in the case that public repo is unavailable.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css a8539e8 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  6134535 
>   ambari-web/app/controllers/wizard/step1_controller.js b648b82 
>   ambari-web/app/messages.js 8bea8e8 
>   ambari-web/app/styles/application.less 8a76dfb 
>   ambari-web/app/templates/wizard/step1.hbs e076d66 
>   ambari-web/test/controllers/wizard/step1_test.js 01344cb 
> 
> Diff: https://reviews.apache.org/r/48105/diff/
> 
> 
> Testing
> ---
> 
> ambari-web:
> 28447 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 71 of 71 SUCCESS (0.113 secs / 0.361 secs)
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 48091: Update derivation of hawq_rm_memory_limit_perseg

2016-06-01 Thread Lav Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48091/#review135814
---


Ship it!




Ship It!

- Lav Jain


On May 31, 2016, 8:31 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48091/
> ---
> 
> (Updated May 31, 2016, 8:31 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16970
> https://issues.apache.org/jira/browse/AMBARI-16970
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update derivation of hawq_rm_memory_limit_perseg. It should be calculated 
> based on vm.overcommit_ratio, vm.overcommit_memory and the available system 
> memory. It should also have a default value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  b096702 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  2ec145f 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  a634062 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 1d6a85c 
> 
> Diff: https://reviews.apache.org/r/48091/diff/
> 
> 
> Testing
> ---
> 
> yes test case updated.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 48136: AMBARI-16973 Print out configType has malformed json text as part of the ambari server startup error handling

2016-06-01 Thread Di Li


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48136/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-16973
https://issues.apache.org/jira/browse/AMBARI-16973


Repository: ambari


Description
---

Ambari server loads properties during server start up. If for some reason the 
json string in the database for a given configType is corrupted, ambari server 
prints an error message saying
"com.google.gson.JsonSyntaxException: 
com.google.gson.stream.MalformedJsonException: Expected EOF at line 1 column 
5319"

The error messsage however does not indicate which configType has the malformed 
JSON string.

This JIRA is to update the exception message to include the configType and the 
corresponding config_id so user knows which one to look at in the database.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
 128fef0 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
dbdd5a2 

Diff: https://reviews.apache.org/r/48136/diff/


Testing
---

manually patch a trunk cluster, update the clusterconfig table with malformed 
cluster-env configuration. restart ambari server, verify the ambari-server.log 
now has log entries that shows that loading cluster-env config failed due to 
malformed json err and the error message also shows the config_id


Thanks,

Di Li

Re: Review Request 47964: clean up import * for ZOOKEEPER service