date:20170215


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56704/#review165811
---


Ship it!




Ship It!

- belliraj hb


On Feb. 16, 2017, 6:48 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56704/
> ---
> 
> (Updated Feb. 16, 2017, 6:48 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19979
> https://issues.apache.org/jira/browse/AMBARI-19979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User is not able to reset the coordinator.
> Steps to reproduce :
> 1) Import the attached coordinator.
> 2) Import the same coordinator in different window
> 3) Try to preview the xml or reset the coordinator. The UI is getting hung.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  aa2e791 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less f4869e4 
> 
> Diff: https://reviews.apache.org/r/56704/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56704: Issue while resetting the coordinator


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56704/
---

(Updated Feb. 16, 2017, 6:48 a.m.)


Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19979
https://issues.apache.org/jira/browse/AMBARI-19979


Repository: ambari


Description (updated)
---

User is not able to reset the coordinator.
Steps to reproduce :
1) Import the attached coordinator.
2) Import the same coordinator in different window
3) Try to preview the xml or reset the coordinator. The UI is getting hung.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 aa2e791 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less f4869e4 

Diff: https://reviews.apache.org/r/56704/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56704: Issue while resetting the coordinator

2017-02-15 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56704/#review165810
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 15, 2017, 12:59 p.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56704/
> ---
> 
> (Updated Feb. 15, 2017, 12:59 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19979
> https://issues.apache.org/jira/browse/AMBARI-19979
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> User is not able to reset the coordinator.
> Steps to reproduce :
> 1) Import the attached coordinator.
> 2) Now try to reset the coordinator.
> 3) Content is not reset even after completing reset flow.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
>  aa2e791 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less f4869e4 
> 
> Diff: https://reviews.apache.org/r/56704/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-15 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/#review165804
---



Can we add some unit tests?

- Sumit Mohanty


On Feb. 15, 2017, 11:19 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56727/
> ---
> 
> (Updated Feb. 15, 2017, 11:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-20034
> https://issues.apache.org/jira/browse/AMBARI-20034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  5c4f08e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  3b88ac9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  8a35c98 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13d0993 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  30a1533 
>   ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>  a748b33 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 
> 
> Diff: https://reviews.apache.org/r/56727/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing for Zeppelin.
> ===
> Steps:
> 1. Make changes to 
> /resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
> /resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
> ```xml
> 
>   zeppelin_user
>   zeppelin
> USER
>   User zeppelin daemon runs as
> 
>   user
>   false
>   
>   
>   zeppelin-env
>   zeppelin_group
>   
>   
>   hadoop-env
>   proxyuser_group
>   
>   
> 
> 
> 
> ```
> 
> 2. Deploy a cluster with Zeppelin
> 
> 3. Check commands-json for addition of user_group in hostLevelParams for 
> following scenarios
>   a. Start Zeppelin - AmbariManagementControllerImpl code path
>   b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
>   c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
> path
> 
> [root@mradha22-1 data]# grep user_group command-552.json
> "user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",
> 
> 4. Verify if the user_group map is getting appended to the existing 
> user_group_dict
>   Comment the hard-coded logic for zeppelin user and group in 
> stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
>   #if has_zeppelin_master:
>   #user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
>   #zeppelin_user = 
> config['configurations']['zeppelin-env']["zeppelin_user"]
>   #zeppelin_group = 
> config['configurations']['zeppelin-env']["zeppelin_group"]
> 
>   [root@mradha22-1 data]# grep Madhu output-*.txt
>   output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
> {'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
>   2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
> 'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
> 2017-02-15 22:21:48,576 - User['zeppelin'] {'gid': 'hadoop', 
> 'fetch_nonlocal_groups': True, 'groups': ['zeppelin', 'users']}
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 56727: USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven

2017-02-15 Thread Madhuvanthi Radhakrishnan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56727/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
Mohanty.


Bugs: AMBARI-20034
https://issues.apache.org/jira/browse/AMBARI-20034


Repository: ambari


Description
---

USER to GROUP mapping (hdfs_user -> hadoop_group) should be stack driven


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 5c4f08e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b601893 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 3b88ac9 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 8a35c98 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
13d0993 
  ambari-server/src/main/java/org/apache/ambari/server/state/UserGroupInfo.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 30a1533 
  ambari-server/src/main/resources/configuration-schema.xsd 1019dd9 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
 a748b33 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2a27eca 

Diff: https://reviews.apache.org/r/56727/diff/


Testing
---

Manual Testing for Zeppelin.
===
Steps:
1. Make changes to 
/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml, 
/resources\/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml 
```xml

zeppelin_user
zeppelin
USER
User zeppelin daemon runs as

user
false


zeppelin-env
zeppelin_group


hadoop-env
proxyuser_group





```

2. Deploy a cluster with Zeppelin

3. Check commands-json for addition of user_group in hostLevelParams for 
following scenarios
a. Start Zeppelin - AmbariManagementControllerImpl code path
b. Restart Zeppelin - AmbariCustomCommandExecutionHelper code path
c. ClientConfigResourceProviderTest - ClientConfigResourceProvider code 
path

[root@mradha22-1 data]# grep user_group command-552.json
"user_group": "{\"zeppelin\":[\"zeppelin\",\"users\"]}",

4. Verify if the user_group map is getting appended to the existing 
user_group_dict
Comment the hard-coded logic for zeppelin user and group in 
stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
#if has_zeppelin_master:
#user_to_groups_dict[zeppelin_user] = [zeppelin_group, user_group]
#zeppelin_user = 
config['configurations']['zeppelin-env']["zeppelin_user"]
#zeppelin_group = 
config['configurations']['zeppelin-env']["zeppelin_group"]

[root@mradha22-1 data]# grep Madhu output-*.txt
output-502.txt\:Madhu defaultdict( at 0x13880c8>, 
{'ambari-qa': ['users'], 'zeppelin': ['zeppelin', 'users']})
2017-02-15 22:21:48,575 - User['hdfs'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': ['hadoop']}
2017-02-15 22:21:48,576 - User['zeppelin'] {'gid': 'hadoop', 
'fetch_nonlocal_groups': True, 'groups': ['zeppelin', 'users']}


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 56708: Add delete endpoint for logsearch (service + audit logs)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56708/#review165769
---


Fix it, then Ship it!




Ship It!


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java
 (line 21)


I suggest to rename this class to StatusMessage, because it is the message 
of a status, and not the status of a message.


- Miklos Gergely


On Feb. 15, 2017, 2:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56708/
> ---
> 
> (Updated Feb. 15, 2017, 2:44 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20023
> https://issues.apache.org/jira/browse/AMBARI-20023
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> add delete endpoint for logsearch.
> the actual queries can be used for that just with DELETE command.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  86c1edd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  0568fd7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  caf0636 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  2dc0ef7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  f960250 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
>  d5b6525 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
>  40247a8 
> 
> Diff: https://reviews.apache.org/r/56708/diff/
> 
> 
> Testing
> ---
> 
> testing done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56607: AMBARI-19915 Add Ranger KMS SSL properties in ambari stack


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56607/#review165760
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 14, 2017, 1:18 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56607/
> ---
> 
> (Updated Feb. 14, 2017, 1:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-19915
> https://issues.apache.org/jira/browse/AMBARI-19915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Below SSL properties needs to be added in Ambari for Ranger KMS service
> - ranger.service.https.attrib.keystore.file
> - ranger.service.https.attrib.client.auth
> - ranger.service.https.attrib.keystore.keyalias  
> - ranger.service.https.attrib.keystore.pass
> - ranger.credential.provider.path
> - ranger.service.https.attrib.keystore.credential.alias
> 
> Along with addition of these properties, need to secure password property.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  8fd5c8d 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/metainfo.xml 
> 12fde7e 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml
>  7dea07f 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  742cb93 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  05e8881 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  0fd1766 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 54072ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  31b20cf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 
> 88486e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> 44a9b7c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  4d70156 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 
> 5b92e5f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> 23564ad 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  24db720 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 818a6c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER_KMS/configuration/ranger-kms-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 969c3dd 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> 57f9f34 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 
> b7f8cbb 
> 
> Diff: https://reviews.apache.org/r/56607/diff/
> 
> 
> Testing
> ---
> 
> Test Case:
> 
> Running tests for stack:2.5 service:RANGER_KMS
> test_configure_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,451 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,467 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_configure_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,502 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,518 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> ok
> test_start_default (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,533 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-777, current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,550 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-02-13 19:08:27,555 - Rangeradmin: Skip ranger admin if it's down !
> ok
> test_start_secured (test_kms_server.TestRangerKMS) ... 2017-02-13 
> 19:08:27,568 - Stack Feature Version Info: stack_version=2.5, 
> version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801
> 2017-02-13 19:08:27,597 - Using hadoop conf dir: 
> /usr/hdp/current/hadoop-client/conf
> 2017-02-13 19:08:27,602 - RangeradminV2: Skip ranger admin if it's down !
> 2017-02-13 19:08:27,602 - KMS repository c1_kms exist
> ok
> test_stop_default (test_kms_server.TestRangerKMS) ... 2017-02-13 19:08:27,618 
> - Stack Feature Version Info: stack_version=2.5, version=2.5.0.0-777, 
> current_cluster_version=2.5.0.0-777 -> 2.5.0.0-777
> 2017-02-13 19:08:27,639

Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max

2017-02-15 Thread Swapan Shridhar



> On Feb. 15, 2017, 8:53 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 1037
> > 
> >
> > Please also make this change in YARN 3.0.0.3.0's service advisor.

Done.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/#review165755
---


On Feb. 15, 2017, 8:47 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56718/
> ---
> 
> (Updated Feb. 15, 2017, 8:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20033
> https://issues.apache.org/jira/browse/AMBARI-20033
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them 
> the following configs for recommendation : (1). 'llap_concurrency', (2). 
> 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max 
> value.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4de9a41 
> 
> Diff: https://reviews.apache.org/r/56718/diff/
> 
> 
> Testing
> ---
> 
> Tested on cluster
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max

2017-02-15 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/
---

(Updated Feb. 15, 2017, 9:21 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated changed in Service Advisor.


Bugs: AMBARI-20033
https://issues.apache.org/jira/browse/AMBARI-20033


Repository: ambari


Description
---

AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them 
the following configs for recommendation : (1). 'llap_concurrency', (2). 
'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max 
value.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
 aecf1e3 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
4de9a41 

Diff: https://reviews.apache.org/r/56718/diff/


Testing
---

Tested on cluster
Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 56710: Relax ranger config DB consistency check rules


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 905)


We shouldn't be hardcoding service names or config types in a check like 
this.
If this is preventing the user from starting Ambari Server, then we should 
make this type of check be a warning as opposed to a hard error, or annotate a 
service or config-type with a tag to relax its validation in this check.

Please add Jayush to the code review.


- Alejandro Fernandez


On Feb. 15, 2017, 3:13 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 15, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/#review165755
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
1037)


Please also make this change in YARN 3.0.0.3.0's service advisor.


- Alejandro Fernandez


On Feb. 15, 2017, 8:47 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56718/
> ---
> 
> (Updated Feb. 15, 2017, 8:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20033
> https://issues.apache.org/jira/browse/AMBARI-20033
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them 
> the following configs for recommendation : (1). 'llap_concurrency', (2). 
> 'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max 
> value.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 4de9a41 
> 
> Diff: https://reviews.apache.org/r/56718/diff/
> 
> 
> Testing
> ---
> 
> Tested on cluster
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 56718: AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them the following configs for recommendation : (1). 'llap_concurrency', (2). 'llap_concurrency' max valu

2017-02-15 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56718/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20033
https://issues.apache.org/jira/browse/AMBARI-20033


Repository: ambari


Description
---

AMBARI-20033. Typecasting to 'long' from earlier 'float', before setting them 
the following configs for recommendation : (1). 'llap_concurrency', (2). 
'llap_concurrency' max value and (3). 'hive.llap.daemon.num.executors' max 
value.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
4de9a41 

Diff: https://reviews.apache.org/r/56718/diff/


Testing
---

Tested on cluster
Python UT passes.


Thanks,

Swapan Shridhar

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165754
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 15, 2017, 6:55 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 6:55 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56717: Zeppelin and Atlas Service Checks Are Missing During Express Upgrades

2017-02-15 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56717/#review165753
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 15, 2017, 9:02 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56717/
> ---
> 
> (Updated Feb. 15, 2017, 9:02 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20030
> https://issues.apache.org/jira/browse/AMBARI-20030
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Both Atlas and Zeppelin participate in HDP upgrades from HDP 2.5 onward, but 
> neither of them have service checks after they have upgraded. 
> 
> This issue is isolated to the express upgrade orchestration since rolling 
> upgrades schedules all installed services while express orchestration only 
> runs those specified in the pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  607f444 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  e92b115 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  5786695 
> 
> Diff: https://reviews.apache.org/r/56717/diff/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 15, 2017, 7:58 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

- put documentation before "import params"


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 15, 2017, 7:56 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

wrong patch uploaded - fix it


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 15, 2017, 7:55 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

- add rangerkms, yarn principals
- move get_ranger_plugin_principals function into ranger stack
- add ranger audit permission to atlas
- use orderedDict instead of simple map -> as we are asserting the call during 
upgrade, its needed to have the same order every time
- upgrade tests


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 86c1edd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 0568fd7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 caf0636 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
 d5b6525 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 40247a8 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 15, 2017, 5:36 p.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py,
> >  line 679
> > 
> >
> > Please add defaults for atlas, yarn and kms. For kms the default 
> > principal name is rangerkms.

thanks, i forget to add yarn and used wrong default principal for kms. actually 
atlas is not needed because that is done on atlas side (also atlas needs other 
permissions as well to access its own collections)


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165727
---


On Feb. 15, 2017, 2:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ae49c4f 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1bbf75e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 15, 2017, 7:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml,
> >  line 103
> > 
> >
> > If the user simply upgrades Ambari and not the stack, should these 
> > properties be added?

yes, this should be added during ambari upgrade


> On Feb. 15, 2017, 7:31 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py,
> >  line 218
> > 
> >
> > Add some documentation to the new functions.

it only dispatches to solr_cloud_util.secure_znode function which already has 
the documentation.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165749
---


On Feb. 15, 2017, 2:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ae49c4f 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165749
---




ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 (line 89)


If the user simply upgrades Ambari and not the stack, should these 
properties be added?



ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 (line 218)


Add some documentation to the new functions.


- Alejandro Fernandez


On Feb. 15, 2017, 2:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ae49c4f 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1bbf75e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
>

Re: Review Request 56659: Add "Manage alert notifications" authorization


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165747
---


Ship it!




Ship It!

- Robert Levas


On Feb. 15, 2017, 11:55 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56717: Zeppelin and Atlas Service Checks Are Missing During Express Upgrades


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56717/#review165748
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 15, 2017, 7:02 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56717/
> ---
> 
> (Updated Feb. 15, 2017, 7:02 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
> 
> 
> Bugs: AMBARI-20030
> https://issues.apache.org/jira/browse/AMBARI-20030
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Both Atlas and Zeppelin participate in HDP upgrades from HDP 2.5 onward, but 
> neither of them have service checks after they have upgraded. 
> 
> This issue is isolated to the express upgrade orchestration since rolling 
> upgrades schedules all installed services while express orchestration only 
> runs those specified in the pack.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  607f444 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  e92b115 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  5786695 
> 
> Diff: https://reviews.apache.org/r/56717/diff/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 56678: PixieDust - Decrease Service Check running time under 3 mins

2017-02-15 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/#review165744
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 769)


Can you break out the value and the equality check into 2 different lines - 
makes it easier to debug.

Also, if the value isn't present, this will throw a NPE, right? Can you use 
StringUtils to ensure a safe comparison?



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 771)


Should there be a default minimum that we don't go below? Just dividing by 
2 seems a little strict, especially if the values are already low.



ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
(line 301)


Should we capitalize this, or at least make it more descriptive? Something 
like, "Service Check Type" or "Service Check Level"


- Jonathan Hurley


On Feb. 14, 2017, 3:07 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56678/
> ---
> 
> (Updated Feb. 14, 2017, 3:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20017
> https://issues.apache.org/jira/browse/AMBARI-20017
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now, Ambari has a timeout of 5-10 mins for Service Checks.
> We need to ensure service checks pass in less than 3 mins for all services.
> 
> This means we need to potentially use a different configuration property if 
> one doesn't exist already so that QE can set it during the Ambari devdeploy 
> tests (in order to speed up the tests).
> 
> This will likely result in bugs in either the Ambari python scripts or the 
> actual services, for which we will create Jiras and assign to the appropriate 
> stack team.
> 
> This patch implements cluster_env/strict_service_check_type property. 
> Possible values are minimal (handled inside service check, runs shorter 
> service check action) and full (default action). If value is minimal, I also 
> reduce service check timeout when generating command on server in 2 times. 
> This way we adapt to service check timeouts that may be different for 
> different services. If service check takes 9 minutes of 10-minute timeout to 
> pass on our non-busy cluster, then it will probably take more then 10 minutes 
> on customers real cluster, and that is bad thing (bug).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13d0993 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3af8f08 
> 
> Diff: https://reviews.apache.org/r/56678/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 56717: Zeppelin and Atlas Service Checks Are Missing During Express Upgrades

2017-02-15 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56717/
---

Review request for Ambari, Dmitro Lisnichenko and Nate Cole.


Bugs: AMBARI-20030
https://issues.apache.org/jira/browse/AMBARI-20030


Repository: ambari


Description
---

Both Atlas and Zeppelin participate in HDP upgrades from HDP 2.5 onward, but 
neither of them have service checks after they have upgraded. 

This issue is isolated to the express upgrade orchestration since rolling 
upgrades schedules all installed services while express orchestration only runs 
those specified in the pack.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 607f444 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
 e92b115 
  
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
 5786695 

Diff: https://reviews.apache.org/r/56717/diff/


Testing
---

PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 56715: Operations do not show up in the operations list without a refresh

2017-02-15 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56715/#review165742
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 15, 2017, 6:16 п.п., Denys Buzhor wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56715/
> ---
> 
> (Updated Фев. 15, 2017, 6:16 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20028
> https://issues.apache.org/jira/browse/AMBARI-20028
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart attempted from the host page. 
> Ambari asks for a confirmation, shows the operations screen, but doesn't take 
> any action.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/service/info/configs.js c49bfaef86 
>   ambari-web/app/mixins/common/track_request_mixin.js 07eaf6e289 
>   ambari-web/app/routes/main.js 9ed2dd10c4 
> 
> Diff: https://reviews.apache.org/r/56715/diff/
> 
> 
> Testing
> ---
> 
> 20340 passing (25s)
>   153 pending
> 
> 
> Thanks,
> 
> Denys Buzhor
> 
>

Review Request 56715: Operations do not show up in the operations list without a refresh

2017-02-15 Thread Denys Buzhor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56715/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20028
https://issues.apache.org/jira/browse/AMBARI-20028


Repository: ambari


Description
---

Restart attempted from the host page. 
Ambari asks for a confirmation, shows the operations screen, but doesn't take 
any action.


Diffs
-

  ambari-web/app/controllers/main/service/info/configs.js c49bfaef86 
  ambari-web/app/mixins/common/track_request_mixin.js 07eaf6e289 
  ambari-web/app/routes/main.js 9ed2dd10c4 

Diff: https://reviews.apache.org/r/56715/diff/


Testing
---

20340 passing (25s)
  153 pending


Thanks,

Denys Buzhor

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

2017-02-15 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165727
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 (line 679)


Please add defaults for atlas, yarn and kms. For kms the default principal 
name is rangerkms.


- Mugdha Varadkar


On Feb. 15, 2017, 2:36 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  ae49c4f 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1bbf75e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> db9cbb9 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 
> b01e7da 
>   ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 
>

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/#review165725
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 15, 2017, 5:55 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56659/
> ---
> 
> (Updated Feb. 15, 2017, 5:55 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
> Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20008
> https://issues.apache.org/jira/browse/AMBARI-20008
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add "Manage alert notifications" authorization and protect resoure with it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  4010528 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
>  969772f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  5e929e3 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  f4212d6 
> 
> Diff: https://reviews.apache.org/r/56659/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56659/
---

(Updated Feb. 15, 2017, 4:55 p.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Dmitro 
Lisnichenko, Laszlo Puskas, Robert Levas, Sebastian Toader, and Vitalyi 
Brodetskyi.


Changes
---

added upgrade code.


Bugs: AMBARI-20008
https://issues.apache.org/jira/browse/AMBARI-20008


Repository: ambari


Description
---

Add "Manage alert notifications" authorization and protect resoure with it.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 4010528 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java
 969772f 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 5e929e3 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql c7d7990 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql de79328 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 16c5864 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 91610bb 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql aebbcb0 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d3eaa6c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 f4212d6 

Diff: https://reviews.apache.org/r/56659/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56713/#review165718
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 15, 2017, 4:24 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56713/
> ---
> 
> (Updated Feb. 15, 2017, 4:24 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20026
> https://issues.apache.org/jira/browse/AMBARI-20026
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When ambari-server start is issued, It returns prematurely before the view 
> extraction is complete.
> because of this we have introduced sleep of 3mins before ambari-server stop 
> for the view extraction to complete.
> Ambari server should report start completed only after view extraction is 
> completed
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py d3bfa70 
>   ambari-server/src/main/python/ambari_server/utils.py f65ceed 
>   ambari-server/src/main/python/ambari_server_main.py df1b0a1 
>   ambari-server/src/test/python/TestAmbariServer.py 8692030 
> 
> Diff: https://reviews.apache.org/r/56713/diff/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [4.125s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.006s]
> [INFO] utility ... SUCCESS [2.523s]
> [INFO] Ambari Agent .. SUCCESS [34.664s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 56714: Override property popup: Redundant scrollbars in config groups list

2017-02-15 Thread Oleg Nechiporenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56714/#review165720
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Feb. 15, 2017, 4:02 p.m., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56714/
> ---
> 
> (Updated Feb. 15, 2017, 4:02 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-20027
> https://issues.apache.org/jira/browse/AMBARI-20027
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> #STR#
> 1. Create service config group
> 2. Proceed with overriding any property
> 3. Open existing config groups combobox in displayed popup.
> 
> #Result#
> Displayed list has redundant horizontal and vertical scrollbars.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/application.less 612c09c 
> 
> Diff: https://reviews.apache.org/r/56714/diff/
> 
> 
> Testing
> ---
> 
> 20340 passing (20s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Laszlo Puskas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56713/#review165719
---


Ship it!




Ship It!

- Laszlo Puskas


On Feb. 15, 2017, 3:24 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56713/
> ---
> 
> (Updated Feb. 15, 2017, 3:24 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Sebastian Toader, Sid Wagle, and 
> Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-20026
> https://issues.apache.org/jira/browse/AMBARI-20026
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When ambari-server start is issued, It returns prematurely before the view 
> extraction is complete.
> because of this we have introduced sleep of 3mins before ambari-server stop 
> for the view extraction to complete.
> Ambari server should report start completed only after view extraction is 
> completed
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py d3bfa70 
>   ambari-server/src/main/python/ambari_server/utils.py f65ceed 
>   ambari-server/src/main/python/ambari_server_main.py df1b0a1 
>   ambari-server/src/test/python/TestAmbariServer.py 8692030 
> 
> Diff: https://reviews.apache.org/r/56713/diff/
> 
> 
> Testing
> ---
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ... SUCCESS [4.125s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.006s]
> [INFO] utility ... SUCCESS [2.523s]
> [INFO] Ambari Agent .. SUCCESS [34.664s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 56714: Override property popup: Redundant scrollbars in config groups list

2017-02-15 Thread Andriy Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56714/
---

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-20027
https://issues.apache.org/jira/browse/AMBARI-20027


Repository: ambari


Description
---

#STR#
1. Create service config group
2. Proceed with overriding any property
3. Open existing config groups combobox in displayed popup.

#Result#
Displayed list has redundant horizontal and vertical scrollbars.


Diffs
-

  ambari-web/app/styles/application.less 612c09c 

Diff: https://reviews.apache.org/r/56714/diff/


Testing
---

20340 passing (20s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56678: PixieDust - Decrease Service Check running time under 3 mins

2017-02-15 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/#review165715
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
(line 303)


Be a bit more descriptive (I'm assuming the two values are "minimal" and 
"full" here):

"Indicates the complexity of the service check.  Valid values are 'minimal' 
or 'full'."


- Nate Cole


On Feb. 14, 2017, 3:07 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56678/
> ---
> 
> (Updated Feb. 14, 2017, 3:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20017
> https://issues.apache.org/jira/browse/AMBARI-20017
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now, Ambari has a timeout of 5-10 mins for Service Checks.
> We need to ensure service checks pass in less than 3 mins for all services.
> 
> This means we need to potentially use a different configuration property if 
> one doesn't exist already so that QE can set it during the Ambari devdeploy 
> tests (in order to speed up the tests).
> 
> This will likely result in bugs in either the Ambari python scripts or the 
> actual services, for which we will create Jiras and assign to the appropriate 
> stack team.
> 
> This patch implements cluster_env/strict_service_check_type property. 
> Possible values are minimal (handled inside service check, runs shorter 
> service check action) and full (default action). If value is minimal, I also 
> reduce service check timeout when generating command on server in 2 times. 
> This way we adapt to service check timeouts that may be different for 
> different services. If service check takes 9 minutes of 10-minute timeout to 
> pass on our non-busy cluster, then it will probably take more then 10 minutes 
> on customers real cluster, and that is bad thing (bug).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13d0993 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3af8f08 
> 
> Diff: https://reviews.apache.org/r/56678/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/
---

(Updated Feb. 15, 2017, 3:43 p.m.)

Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley,
Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.

Changes
---

Fixed a few more issues.

Bugs: AMBARI-19957
https://issues.apache.org/jira/browse/AMBARI-19957

Repository: ambari

Description
---

Postgres allows multiple schemas on a database user's search path, that is
users can query from tables in different schemas without the need of prefixing
the tables in the query.

This can lead to confusion when after an unsuccessful upgrade DBA's restore the
tables into a different schema (e.g. public) to Ambari's configured one. As a
result, Ambari server may see different data than indended.

New consistency checks on server startup warn the user in such situations.

Diffs (updated)
-

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
7aa8652

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
PRE-CREATION

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
2dd

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
1704546
ambari-server/src/main/python/ambari_server_main.py 7a21333

ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
f73562d

Diff: https://reviews.apache.org/r/56540/diff/

Testing
---

- Wrote new unit tests
- Run all tests for ambari-server (all passed)
- Performed manual testing

Thanks,

Balázs Bence Sári

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56713/
---

(Updated Фев. 15, 2017, 3:24 п.п.)


Review request for Ambari, Laszlo Puskas, Sebastian Toader, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20026
https://issues.apache.org/jira/browse/AMBARI-20026


Repository: ambari


Description
---

When ambari-server start is issued, It returns prematurely before the view 
extraction is complete.
because of this we have introduced sleep of 3mins before ambari-server stop for 
the view extraction to complete.
Ambari server should report start completed only after view extraction is 
completed


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverConfiguration.py d3bfa70 
  ambari-server/src/main/python/ambari_server/utils.py f65ceed 
  ambari-server/src/main/python/ambari_server_main.py df1b0a1 
  ambari-server/src/test/python/TestAmbariServer.py 8692030 

Diff: https://reviews.apache.org/r/56713/diff/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [4.125s]
[INFO] Apache Ambari Project POM . SUCCESS [0.006s]
[INFO] utility ... SUCCESS [2.523s]
[INFO] Ambari Agent .. SUCCESS [34.664s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Re: Review Request 56712: Incorrect work of filters on Versions page of Admin View

2017-02-15 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56712/#review165713
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 15, 2017, 3:22 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56712/
> ---
> 
> (Updated Фев. 15, 2017, 3:22 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20025
> https://issues.apache.org/jira/browse/AMBARI-20025
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Filter by cluster name doesn't work (while being enabled, showing versions 
> that are not installed on cluster)
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
>  1de8817 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 84d7b33 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackversionsListCtrl_test.js
>  6f168db 
> 
> Diff: https://reviews.apache.org/r/56712/diff/
> 
> 
> Testing
> ---
> 
> Executed 81 of 81 SUCCESS (0.466 secs / 0.461 secs)
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false

2017-02-15 Thread Sebastian Toader


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56685/#review165714
---


Ship it!




Ship It!

- Sebastian Toader


On Feb. 15, 2017, 4:02 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56685/
> ---
> 
> (Updated Feb. 15, 2017, 4:02 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20018
> https://issues.apache.org/jira/browse/AMBARI-20018
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Document security issue related to setting security.agent.hostname.validate 
> to "false".
> 
> If set to "false", invalid hostnames may be used in OpenSSL commands used to 
> create the agent-side certificates when 2-way SSL is enabled. This could lead 
> to issues when executing OpenSSL as described in CVE-2014-3582. See 
> https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 50864f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  5020790 
> 
> Diff: https://reviews.apache.org/r/56685/diff/
> 
> 
> Testing
> ---
> 
> No testing necessary.  Documentation change, only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56713/
---

Review request for Ambari, Laszlo Puskas, Sebastian Toader, Sid Wagle, and 
Vitalyi Brodetskyi.


Bugs: AMBARI-20026
https://issues.apache.org/jira/browse/AMBARI-20026


Repository: ambari


Description
---

When ambari-server start is issued, It returns prematurely before the view 
extraction is complete.
because of this we have introduced sleep of 3mins before ambari-server stop for 
the view extraction to complete.
Ambari server should report start completed only after view extraction is 
completed


Diffs
-

  ambari-server/src/main/python/ambari_server_main.py 7a21333 

Diff: https://reviews.apache.org/r/56713/diff/


Testing
---

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Main ... SUCCESS [4.125s]
[INFO] Apache Ambari Project POM . SUCCESS [0.006s]
[INFO] utility ... SUCCESS [2.523s]
[INFO] Ambari Agent .. SUCCESS [34.664s]
[INFO] 
[INFO] BUILD SUCCESS


Thanks,

Dmytro Sen

Re: Review Request 56706: Log Search allow installation without portal



> On Feb. 15, 2017, 3:08 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py, 
> > line 1032
> > 
> >
> > Should the number of shards be hard-coded here?
> 
> Miklos Gergely wrote:
> Unfortunately at this point we have no way of knowing the number of 
> shards, as the user who installed the portal may have altered the name of the 
> service / audit logs collecitons. Setting it to 2 ensures that it will work 
> as there are at least 2 shars. The user who installs the logfeeders have the 
> option to set up the proper value, just like they have the option to set up 
> the proper collection names and split intervals.
> 
> In the future we plan that the portal should create two znode ssomething 
> like this:
> 
> /infra_solr/service_logs_info.json:
> {
>   "collection_name": "hadoop_logs",
>   "number_of_shards": "3",
>   "split_interval: "!5"
> }
> 
> /infra_solr/audit_logs_info.json:
> {
>   "collection_name": "audit_logs",
>   "number_of_shards": "2",
>   "split_interval: "!5"
> }
> 
> Then the Log Feeders will get all these infos from ZooKeeper irrelevant 
> of the portal location (same cluster, different cluster), and then the 
> logfeeder-only install could hide all the logsearch properties.

Thanks for clarifying this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56706/#review165708
---


On Feb. 15, 2017, 1:09 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56706/
> ---
> 
> (Updated Feb. 15, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20022
> https://issues.apache.org/jira/browse/AMBARI-20022
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the choice to install Log Search without a portal, i.e. to install only 
> Log Feeders which load the entries into an external solr which are viewable 
> via an external portal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 5e0fa5e 
> 
> Diff: https://reviews.apache.org/r/56706/diff/
> 
> 
> Testing
> ---
> 
> Tested two local Vagrant clusters.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56627: Cluster deployment fails if cluster template has fewer host_groups than that in blueprint

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56627/#review165711
---

Fix it, then Ship it!

Overall, the patch looks fine, but I do have some concerns about whether this 
scenario should be treated as a failure condition, or if the exception 
mentioned in this review is a symptom of another bug.

Could you please add Sandor Magyari to this review, as he is another expert in 
this area of the code?  It would be good to get a second opinion on this, to 
make sure I'm interpreting this correctly.

Thanks.

ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 (line 236)

I have some concerns about this change.

While on the surface it would appear that this is the correct handling of 
this Blueprint deployment scenario, I'm a little concerned that this would 
preclude the following scenario:

1. Blueprint is POST-ed with 4 host-groups
2. Cluster Creation occurs, matching 3 hosts to 3 of the 4 host groups.
3. At a later point, an Add Host REST call might be made, to add a new 
worker node based on the hostgroup that is not matched in the initial 
deployment.

I might be mis-understanding the intent of the original code, so we should 
probably have another reviewing take a look as well to confirm.

- Robert Nettleton

On Feb. 14, 2017, 12:37 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56627/
> ---
> 
> (Updated Feb. 14, 2017, 12:37 a.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Nettleton.
> 
> 
> Bugs: AMBARI-19991
> https://issues.apache.org/jira/browse/AMBARI-19991
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Cluster creation REST API request gets accepted when, cluster template does 
> not list all the host_groups mentioned in the blueprint. But cluster 
> deployment fails showing error message in the logs
> Caused by: java.lang.IllegalArgumentException: 
> TopologyManager.ConfigureClusterTask - prerequisites for config request 
> processing not yet satisfied
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:908)
> at 
> org.apache.ambari.server.topology.TopologyManager$ConfigureClusterTask.call(TopologyManager.java:889)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  d0a4df9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterTopologyImplTest.java
>  1f31d05 
> 
> Diff: https://reviews.apache.org/r/56627/diff/
> 
> 
> Testing
> ---
> 
> Tested manually, updated test cases
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Review Request 56712: Incorrect work of filters on Versions page of Admin View

2017-02-15 Thread Andriy Babiichuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56712/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20025
https://issues.apache.org/jira/browse/AMBARI-20025


Repository: ambari


Description
---

Filter by cluster name doesn't work (while being enabled, showing versions that 
are not installed on cluster)


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
 1de8817 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
84d7b33 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackversionsListCtrl_test.js
 6f168db 

Diff: https://reviews.apache.org/r/56712/diff/


Testing
---

Executed 81 of 81 SUCCESS (0.466 secs / 0.461 secs)


Thanks,

Andriy Babiichuk

Re: Review Request 56706: Log Search allow installation without portal

> On Feb. 15, 2017, 3:08 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py, 
> > line 1032
> > 
> >
> > Should the number of shards be hard-coded here?

Unfortunately at this point we have no way of knowing the number of shards, as 
the user who installed the portal may have altered the name of the service / 
audit logs collecitons. Setting it to 2 ensures that it will work as there are 
at least 2 shars. The user who installs the logfeeders have the option to set 
up the proper value, just like they have the option to set up the proper 
collection names and split intervals.

In the future we plan that the portal should create two znode ssomething like 
this:

/infra_solr/service_logs_info.json:
{
  "collection_name": "hadoop_logs",
  "number_of_shards": "3",
  "split_interval: "!5"
}

/infra_solr/audit_logs_info.json:
{
  "collection_name": "audit_logs",
  "number_of_shards": "2",
  "split_interval: "!5"
}

Then the Log Feeders will get all these infos from ZooKeeper irrelevant of the 
portal location (same cluster, different cluster), and then the logfeeder-only 
install could hide all the logsearch properties.

- Miklos

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56706/#review165708
---

On Feb. 15, 2017, 1:09 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56706/
> ---
> 
> (Updated Feb. 15, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20022
> https://issues.apache.org/jira/browse/AMBARI-20022
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the choice to install Log Search without a portal, i.e. to install only 
> Log Feeders which load the entries into an external solr which are viewable 
> via an external portal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 5e0fa5e 
> 
> Diff: https://reviews.apache.org/r/56706/diff/
> 
> 
> Testing
> ---
> 
> Tested two local Vagrant clusters.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 15, 2017, 6:45 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json,
> >  line 75
> > 
> >
> > 0.6.0 version is extended from stack 2.5 which is released. 
> > If user upgrading to ambari with this fix, will infra-solr principal 
> > get generated for ranger-admin host after ambari upgrade ?
> 
> Oliver Szabo wrote:
> it can be a possible issue because i do not think so any restart will 
> regenerate keytabs. (on update you need to restart ambari managed services). 
> regenerating keytabs will be needed after upgrade

Ambari will not create the missing Kerberos identities on restart. The user 
will need to manually perform a "Regenerate Keytabs" operation (selecting the 
"missing only" option) in order to create the new Kerberos identities and 
distribute the keytab files where needed.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165686
---


On Feb. 15, 2017, 9:36 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 9:36 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  0b4532b 
>   
>

Review Request 56710: Relax ranger config DB consistency check rules

2017-02-15 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024


Repository: ambari


Description
---


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 878d0fa 

Diff: https://reviews.apache.org/r/56710/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56706: Log Search allow installation without portal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56706/#review165708
---


Fix it, then Ship it!




Overall, the patch looks fine to me, just a minor question about the hard-coded 
configuration for the number of shards.  

This hard-coding may be fine, since the Solr instance is external in this case, 
but I just wanted to verify that this was done intentionally, since perhaps 
there is no other way to obtain the configuration at this point.

Thanks.


ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 
1032)


Should the number of shards be hard-coded here?


- Robert Nettleton


On Feb. 15, 2017, 1:09 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56706/
> ---
> 
> (Updated Feb. 15, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20022
> https://issues.apache.org/jira/browse/AMBARI-20022
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the choice to install Log Search without a portal, i.e. to install only 
> Log Feeders which load the entries into an external solr which are viewable 
> via an external portal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 5e0fa5e 
> 
> Diff: https://reviews.apache.org/r/56706/diff/
> 
> 
> Testing
> ---
> 
> Tested two local Vagrant clusters.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 56708: Add delete endpoint for logsearch (service + audit logs)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56708/#review165707
---


Ship it!




Ship It!

- Robert Nettleton


On Feb. 15, 2017, 2:44 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56708/
> ---
> 
> (Updated Feb. 15, 2017, 2:44 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20023
> https://issues.apache.org/jira/browse/AMBARI-20023
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> add delete endpoint for logsearch.
> the actual queries can be used for that just with DELETE command.
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
>  86c1edd 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
>  0568fd7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
>  caf0636 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
>  2dc0ef7 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  f960250 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
>  d5b6525 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
>  40247a8 
> 
> Diff: https://reviews.apache.org/r/56708/diff/
> 
> 
> Testing
> ---
> 
> testing done.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56685/
---

(Updated Feb. 15, 2017, 10:02 a.m.)


Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, 
Laszlo Puskas, and Sebastian Toader.


Changes
---

Update the doc to include the URL to Ambari Vunerabilities Wiki page where 
CVE-2014-3582 is declared.


Bugs: AMBARI-20018
https://issues.apache.org/jira/browse/AMBARI-20018


Repository: ambari


Description
---

Document security issue related to setting security.agent.hostname.validate to 
"false".

If set to "false", invalid hostnames may be used in OpenSSL commands used to 
create the agent-side certificates when 2-way SSL is enabled. This could lead 
to issues when executing OpenSSL as described in CVE-2014-3582. See 
https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities.


Diffs (updated)
-

  ambari-server/docs/configuration/index.md 50864f2 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 5020790 

Diff: https://reviews.apache.org/r/56685/diff/


Testing
---

No testing necessary.  Documentation change, only.


Thanks,

Robert Levas

Re: Review Request 56231: AMBARI-19829: Several HDFS/YARN widgets on Heatmaps show N/A

2017-02-15 Thread Qin Liu



> On Feb. 13, 2017, 11:53 p.m., Aravindan Vijayan wrote:
> > Ship It!
> 
> Qin Liu wrote:
> Thank you so much Aravindan!

Hi Aravindan, I would really appreciate if you can commit the changes to 
trunk.:-)


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56231/#review165406
---


On Feb. 14, 2017, 2:38 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56231/
> ---
> 
> (Updated Feb. 14, 2017, 2:38 p.m.)
> 
> 
> Review request for Ambari, Andrii Tkach, Aravindan Vijayan, and Dmytro Sen.
> 
> 
> Bugs: AMBARI-19829
> https://issues.apache.org/jira/browse/AMBARI-19829
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following HDFS/YARN widgets on Heatmaps show N/A:
> 1. HDFS - HDFS Bytes Written, HDFS Bytes Read, DataNode Process Disk I/O 
> Utilization, and DataNode Process Network I/O Utilization
> 2. YARN - Container Failures
> 
> The issue was introduced by AMBARI-15835 "Rate metrics requesting widgets do 
> not show up on Ambari" which introduced rate metrics and applied rate metrics 
> to several HBASE/HDFS/YARN widgets on Summary pages as well as Heatmap pages. 
> Rate metrics work fine on Summary pages but they don't work on Heatmap pages 
> because current Heatmap design can only show point-in-time metrics and rate 
> metrics need a time range.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 
> bcfb2cc 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/YARN_widgets.json
>  4b76a17 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/YARN_widgets.json
>  782f21d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/widgets.json 
> 4a645b0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/YARN_widgets.json
>  782f21d 
> 
> Diff: https://reviews.apache.org/r/56231/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in UI.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer process is still alive after switching AMS to embedded mode

2017-02-15 Thread Qin Liu



> On Feb. 13, 2017, 7:39 p.m., Aravindan Vijayan wrote:
> > Ship It!
> 
> Qin Liu wrote:
> Thank you very much Aravindan!

Hi Aravindan, I would really appreciate if you can commit the changes to trunk.


- Qin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
---


On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> ---
> 
> (Updated Feb. 13, 2017, 7:22 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After switching AMS to embedded mode, AMS HBase region server process from 
> previous AMS configs is still alive.
> 
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from 
> previous AMS distributed configs is still alive
> 
> The fix is when AMS is in embedded mode, make sure no residual region server 
> process is running at collector stop.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py
>  f423165 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py
>  7df74bf 
> 
> Diff: https://reviews.apache.org/r/56603/diff/
> 
> 
> Testing
> ---
> 
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the 
> change.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false

2017-02-15 Thread Eugene Chekanskiy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56685/#review165704
---


Ship it!




Ship It!

- Eugene Chekanskiy


On Feb. 14, 2017, 10:06 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56685/
> ---
> 
> (Updated Feb. 14, 2017, 10:06 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20018
> https://issues.apache.org/jira/browse/AMBARI-20018
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Document security issue related to setting security.agent.hostname.validate 
> to "false".
> 
> If set to "false", invalid hostnames may be used in OpenSSL commands used to 
> create the agent-side certificates when 2-way SSL is enabled. This could lead 
> to issues when executing OpenSSL as described in CVE-2014-3582. See 
> https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 50864f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  5020790 
> 
> Diff: https://reviews.apache.org/r/56685/diff/
> 
> 
> Testing
> ---
> 
> No testing necessary.  Documentation change, only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 56708: Add delete endpoint for logsearch (service + audit logs)


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56708/
---

Review request for Ambari, Miklos Gergely and Robert Nettleton.


Bugs: AMBARI-20023
https://issues.apache.org/jira/browse/AMBARI-20023


Repository: ambari


Description
---

add delete endpoint for logsearch.
the actual queries can be used for that just with DELETE command.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageStatus.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApiDocConfig.java
 86c1edd 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 0568fd7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 caf0636 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
 2dc0ef7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
 f960250 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/AuditLogsResource.java
 d5b6525 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsResource.java
 40247a8 

Diff: https://reviews.apache.org/r/56708/diff/


Testing
---

testing done.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165702
---


Ship it!




Ship It!

- Miklos Gergely


On Feb. 15, 2017, 12:27 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 15, 2017, 12:27 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain ranger fixes (it will, that review is mosly 
> for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  2232bb2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  682fc9f 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 1bbf75e 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 15, 2017, 2:36 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

- add changes to ranger admin
- put back check znode for logsearch
- add "dev" role for atlas/ranger users


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description (updated)
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 0b4532b 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 ae49c4f 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py db9cbb9 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py b01e7da 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 8dda363 

Diff: https://reviews.apache.org/r/56671/diff/


Testing (updated)
---

unit tests done.


Thanks,

Oliver Szabo

Re: Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable

2017-02-15 Thread Aleksandr Kovalenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56679/#review165701
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 14, 2017, 8:29 п.п., Andrii Tkach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56679/
> ---
> 
> (Updated Фев. 14, 2017, 8:29 п.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20016
> https://issues.apache.org/jira/browse/AMBARI-20016
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> On a 1000-node cluster, go to Hosts page
> Set the page size to 100 (shows hosts 1-100)
> Using the paging controls, go to the next page (shows hosts 101-200) - this 
> takes several seconds
> Using the paging controls, go to the next page (shows hosts 201-300) - this 
> takes longer
> Repeat showing the next set of hosts. This gets progressively slower. I gave 
> up when I hit 701-800 since the page got totally stuck after waiting for 3 
> minutes.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main.js 87a483e 
>   ambari-web/app/controllers/main/service/add_controller.js f312a5a 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 4cf22d4 
>   ambari-web/app/controllers/wizard/step7_controller.js 1d24ee3 
>   ambari-web/app/mappers/alert_definition_summary_mapper.js 8b59c7c 
>   ambari-web/app/mappers/alert_definitions_mapper.js c400b89 
>   ambari-web/app/mappers/alert_groups_mapper.js c079c21 
>   ambari-web/app/mappers/alert_instances_mapper.js 269941b 
>   ambari-web/app/mappers/alert_notification_mapper.js 9567c77 
>   ambari-web/app/mappers/cluster_mapper.js 5689867 
>   ambari-web/app/mappers/components_state_mapper.js 89d5af2 
>   ambari-web/app/mappers/configs/config_groups_mapper.js fe3d7a1 
>   ambari-web/app/mappers/configs/service_config_version_mapper.js 68bf235 
>   ambari-web/app/mappers/configs/themes_mapper.js 8ad51bd 
>   ambari-web/app/mappers/hosts_mapper.js 3c7dd70 
>   ambari-web/app/mappers/quicklinks_mapper.js 6cb1fe0 
>   ambari-web/app/mappers/repository_version_mapper.js 48e460b 
>   ambari-web/app/mappers/root_service_mapper.js 1e0e070 
>   ambari-web/app/mappers/server_data_mapper.js a99d8ae 
>   ambari-web/app/mappers/service_mapper.js 9a330f9 
>   ambari-web/app/mappers/service_metrics_mapper.js c4f37df 
>   ambari-web/app/mappers/stack_mapper.js b1a5faf 
>   ambari-web/app/mappers/stack_service_mapper.js 21c4db9 
>   ambari-web/app/mappers/stack_upgrade_history_mapper.js 823ae80 
>   ambari-web/app/mappers/stack_version_mapper.js bd37288 
>   ambari-web/app/mappers/target_cluster_mapper.js f774213 
>   ambari-web/app/mappers/users_mapper.js 80d7feb 
>   ambari-web/app/mappers/widget_mapper.js 0991d4f 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 93dea5f 
>   ambari-web/app/mixins/main/service/groups_mapping.js 0781aa3 
>   ambari-web/app/models/user.js 4dde8ec 
>   ambari-web/app/utils/http_client.js 9b8346c 
>   ambari-web/test/controllers/main/admin_test.js b2828d0 
>   ambari-web/test/controllers/main/host/details_test.js 17b1eec 
>   ambari-web/test/controllers/main/service/add_controller_test.js 715f46a 
>   ambari-web/test/controllers/main/service/item_test.js 6430ab6 
>   ambari-web/test/mappers/alert_groups_mapper_test.js 9480e3d 
>   ambari-web/test/mixins/main/service/configs/config_overridable_test.js 
> b1eb099 
>   ambari-web/test/models/host_component_test.js d577005 
>   ambari-web/test/models/host_stack_version_test.js 702e284 
>   ambari-web/test/models/rack_test.js a63eaba 
>   ambari-web/test/models/stack_service_test.js bc101e0 
>   ambari-web/test/utils/http_client_test.js 589c44e 
> 
> Diff: https://reviews.apache.org/r/56679/diff/
> 
> 
> Testing
> ---
> 
> 20340 passing (34s)
>   153 pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>

Re: Review Request 56706: Log Search allow installation without portal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56706/#review165694
---


Ship it!




Ship It!

- Oliver Szabo


On Feb. 15, 2017, 1:09 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56706/
> ---
> 
> (Updated Feb. 15, 2017, 1:09 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-20022
> https://issues.apache.org/jira/browse/AMBARI-20022
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Allow the choice to install Log Search without a portal, i.e. to install only 
> Log Feeders which load the entries into an external solr which are viewable 
> via an external portal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 245a94d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
> 5e0fa5e 
> 
> Diff: https://reviews.apache.org/r/56706/diff/
> 
> 
> Testing
> ---
> 
> Tested two local Vagrant clusters.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Review Request 56706: Log Search allow installation without portal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56706/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-20022
https://issues.apache.org/jira/browse/AMBARI-20022


Repository: ambari


Description
---

Allow the choice to install Log Search without a portal, i.e. to install only 
Log Feeders which load the entries into an external solr which are viewable via 
an external portal.


Diffs
-

  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
245a94d 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
5e0fa5e 

Diff: https://reviews.apache.org/r/56706/diff/


Testing
---

Tested two local Vagrant clusters.


Thanks,

Miklos Gergely

Review Request 56705: Hive server error on view navigation when wire encryption is enabled

2017-02-15 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56705/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Rohit Choudhary.


Bugs: AMBARI-20021
https://issues.apache.org/jira/browse/AMBARI-20021


Repository: ambari


Description
---

in ambari views : removed exclusion of httpcore and httpclient libraries and 
added in dependencyManagement to version 4.4


Diffs
-

  contrib/views/commons/pom.xml 9dd18ac 
  contrib/views/files/pom.xml 2e742df 
  contrib/views/hive-next/pom.xml 19f55ee 
  contrib/views/hive20/pom.xml cf5fdde 
  contrib/views/pig/pom.xml 738d410 
  contrib/views/pom.xml c8a88cb 
  contrib/views/utils/pom.xml ead33b2 
  contrib/views/wfmanager/pom.xml 06fbfeb 

Diff: https://reviews.apache.org/r/56705/diff/


Testing
---

manual testing done on cluster with hdfs and s3 support


Thanks,

Nitiraj Rathore

Review Request 56704: Issue while resetting the coordinator


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56704/
---

Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj 
Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19979
https://issues.apache.org/jira/browse/AMBARI-19979


Repository: ambari


Description
---

User is not able to reset the coordinator.
Steps to reproduce :
1) Import the attached coordinator.
2) Now try to reset the coordinator.
3) Content is not reset even after completing reset flow.


Diffs
-

  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 aa2e791 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less f4869e4 

Diff: https://reviews.apache.org/r/56704/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56703: Ambari-server restart --debug failed

2017-02-15 Thread Vitalyi Brodetskyi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56703/#review165690
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Лют. 15, 2017, 12:34 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56703/
> ---
> 
> (Updated Лют. 15, 2017, 12:34 після полудня)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20020
> https://issues.apache.org/jira/browse/AMBARI-20020
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Artifacts:  /test-logs/ambari-hv-r-upg/ambaritestartifacts/artifacts/screenshots/com.hw.am
> bari.ui.tests.monitoring.admin_page.rolling_express_upgrade.TestRUPrechecksSki
> p/test040_PrerequisitesCheck/_30_1_55_48_Element_has_not_been_found_within_30_
> seconds__/>
> 
> 
> 
> 
> Sending command [ambari-server restart --debug]
> [OUTPUT STREAM]
> Using python  /usr/bin/python
> Restarting ambari-server
> Waiting for server stop...
> Ambari-server failed to stop
> Ambari Server stopped
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server start.
> Unable to determine server PID. Retrying...
> ..
> Unable to determine server PID. Retrying...
> ..
> Unable to determine server PID. Retrying...
> DB configs consistency check: no errors and warnings were found.
> ERROR: Exiting with exit code -1. 
> REASON: Ambari Server java process died with exitcode 2. Check 
> /var/log/ambari-server/ambari-server.out for more information.
> 
> [ERROR STREAM]
> 
> 
> ambari-server.out
> 
> 
> 
> OpenJDK 64-Bit Server VM warning: ignoring option PermSize=1024m; support 
> was removed in 8.0
> OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; 
> support was removed in 8.0
> OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; 
> support was removed in 8.0
> ERROR: transport error 202: bind failed: Address already in use
> ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
> JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports 
> initialized [debugInit.c:750]
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari-server.py e7ffe4e 
> 
> Diff: https://reviews.apache.org/r/56703/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 56703: Ambari-server restart --debug failed

2017-02-15 Thread Andrew Onischuk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56703/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20020
https://issues.apache.org/jira/browse/AMBARI-20020


Repository: ambari


Description
---

Artifacts: 




Sending command [ambari-server restart --debug]
[OUTPUT STREAM]
Using python  /usr/bin/python
Restarting ambari-server
Waiting for server stop...
Ambari-server failed to stop
Ambari Server stopped
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
Ambari database consistency check started...
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /var/log/ambari-server/ambari-server.out
Server log at: /var/log/ambari-server/ambari-server.log
Waiting for server start.
Unable to determine server PID. Retrying...
..
Unable to determine server PID. Retrying...
..
Unable to determine server PID. Retrying...
DB configs consistency check: no errors and warnings were found.
ERROR: Exiting with exit code -1. 
REASON: Ambari Server java process died with exitcode 2. Check 
/var/log/ambari-server/ambari-server.out for more information.

[ERROR STREAM]


ambari-server.out



OpenJDK 64-Bit Server VM warning: ignoring option PermSize=1024m; support 
was removed in 8.0
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=1024m; 
support was removed in 8.0
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support 
was removed in 8.0
ERROR: transport error 202: bind failed: Address already in use
ERROR: JDWP Transport dt_socket failed to initialize, TRANSPORT_INIT(510)
JDWP exit error AGENT_ERROR_TRANSPORT_INIT(197): No transports initialized 
[debugInit.c:750]


Diffs
-

  ambari-server/src/main/python/ambari-server.py e7ffe4e 

Diff: https://reviews.apache.org/r/56703/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/
---

(Updated Feb. 15, 2017, 12:22 p.m.)


Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
Nettleton.


Changes
---

- use custom-security.json if not empty
- add role & securing znode changes to atlas stack


Bugs: AMBARI-20013
https://issues.apache.org/jira/browse/AMBARI-20013


Repository: ambari


Description
---

- make sure solr keytab and solr user is created on logsearch/ranger/atlas hosts
- created a new solr_cloud_util method called add roles (curl for adding user 
roles)
- updated secure znode method (adding infra-solr by default)
- move generated security.json into a static file
- added a custom security.json which can be used instead of the generated 
security.json

This patch still does not contain atlas/ranger fixes (it will, that review is 
mosly for review, i will include ranger/atlas changes later).

In ranger/atlas stack, the following calls can be used for securing znode and 
update user-roles:

solr_cloud_util.secure_znode(config=params.config, 
zookeeper_quorum=params.zookeeper_quorum,
 
solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
 jaas_file=params.logsearch_jaas_file,
 java64_home=params.java64_home, 
sasl_users=["myuser1@HOST", "myuser2"])
 
and 

solr_cloud_util.add_solr_roles(params.config,
   roles = ["ranger_audit_user"],
   new_service_principals = ["audituser1", 
"audituser2"])
   
about ranger plugins:

there is a way to use these methods in other services like storm etc. , the 
problem is its needed to infra-solr be started, so if we include these in a lot 
of other services, it can really slows down the deployment. that is the reason 
why i kept the property dependencies in infra-solr-security-json config. other 
then that, with the changes ranger can start successfully if its added later to 
the cluster, and for plugins, infra-solr will be flagged to be restarted.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 4628211 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
 e193a8c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 ab9aa61 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 8d72f42 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
 ed764f0 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
 2232bb2 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 682fc9f 
  
ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json 
bc8e351 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
49d1b10 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 fecd802 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 ba91e20 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
253e32e 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
1bbf75e 
  ambari-server/src/test/python/stacks/2.3/configs/secure.json 4501b81 
  ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
cd88fec 

Diff: https://reviews.apache.org/r/56671/diff/


Testing
---

unit tests done, still writing unit tests for atlas/ranger additions.


Thanks,

Oliver Szabo

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 15, 2017, 11:45 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json,
> >  line 75
> > 
> >
> > 0.6.0 version is extended from stack 2.5 which is released. 
> > If user upgrading to ambari with this fix, will infra-solr principal 
> > get generated for ranger-admin host after ambari upgrade ?

it can be a possible issue because i do not think so any restart will 
regenerate keytabs. (on update you need to restart ambari managed services). 
regenerating keytabs will be needed after upgrade


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165686
---


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

2017-02-15 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165686
---




ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
(line 75)


0.6.0 version is extended from stack 2.5 which is released. 
If user upgrading to ambari with this fix, will infra-solr principal get 
generated for ranger-admin host after ambari upgrade ?


- Mugdha Varadkar


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion



> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 724-726
> > 
> >
> > Use logging here, not System.out.println(...)
> 
> Balázs Bence Sári wrote:
> I copied existing behavior. I think the reason why it is here that the 
> python script checks the standard out, so the intention is to make sure this 
> line appears there, irrespectively of the logging config.
> 
> Balázs Bence Sári wrote:
> I reduced the occasions of System.out.println's in Ambari Server (a lot 
> of them existed in the original version). I am hesitating to completely 
> removing them as in this case the explicit intention is to make that line 
> appear on System.out, not the application log (as the python script relies on 
> the console output) and I think the most reliable way to achieve that is to 
> use System.out.println.
> If I try to achieve that with loggers:
> 1. Users may reconfigure logging, in that case the python script will 
> miss the output.
> 2. Previously (not sure if it is still the case) Java server apps 
> suffered from loggers sometimes not getting flushed when System.exit() was 
> called.

I removed my new method containing println(). Also reduced the number of 
printlns() in the original code as much as possible (respecting the python 
script).


> On Feb. 10, 2017, 2:18 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  lines 715-729
> > 
> >
> > This is strange - why not make the DatabaseConsistencyCheckHelper do 
> > this exception handling/logic and call it directly instead of having yet 
> > another method call in AmbariServer?  Separation of concerns would be 
> > helpful.
> 
> Balázs Bence Sári wrote:
> I agree with this finding. I copied existing behavior that's why it is 
> here. I'll move it to DB checker.
> 
> Balázs Bence Sári wrote:
> Please have look at the new implementation. I simplified error handling 
> here, however not completely removed. I left DB Consistency checker's concern 
> to provide a check result and AmbariServer's concern to decide what to do 
> with the check result (e.g. exit with 1 exit code if errors occured in the 
> checks). However, I greatly simplified the overcomplicated logic there.

I removed my new method and simplified the original check-result handling.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165122
---


On Feb. 15, 2017, 11:33 a.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 15, 2017, 11:33 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup



> On Feb. 15, 2017, 11:31 a.m., Mugdha Varadkar wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py,
> >  line 75
> > 
> >
> > How is this going to get uploaded to zookeeper node ? or is this a 
> > manual task for user using custom-security.json ?
> > 
> > If infra-solr is restarted the custom-security.json will get override 
> > with static security.json template

yes you are right, thanks.
if the custom-security.json is not empty, i will use that instead of the 
template one in solr_cloud_util.setup_kerberos_plugin function


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165683
---


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/
---

(Updated Feb. 15, 2017, 11:33 a.m.)

Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley,
Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.

Changes
---

Fixed review comments.

Bugs: AMBARI-19957
https://issues.apache.org/jira/browse/AMBARI-19957

Repository: ambari

Description
---

Postgres allows multiple schemas on a database user's search path, that is
users can query from tables in different schemas without the need of prefixing
the tables in the query.

New consistency checks on server startup warn the user in such situations.

Diffs (updated)
-

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
7aa8652

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
PRE-CREATION

ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
2dd

ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
1704546
ambari-server/src/main/python/ambari_server_main.py 7a21333

ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
f73562d

Diff: https://reviews.apache.org/r/56540/diff/

Testing
---

- Wrote new unit tests
- Run all tests for ambari-server (all passed)
- Performed manual testing

Thanks,

Balázs Bence Sári

Re: Review Request 56671: Add Solr authorization settings during LogSearch/Atlas/Ranger startup

2017-02-15 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56671/#review165683
---




ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 (line 75)


How is this going to get uploaded to zookeeper node ? or is this a manual 
task for user using custom-security.json ?

If infra-solr is restarted the custom-security.json will get override with 
static security.json template


- Mugdha Varadkar


On Feb. 14, 2017, 7:06 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56671/
> ---
> 
> (Updated Feb. 14, 2017, 7:06 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Mugdha Varadkar, and Robert 
> Nettleton.
> 
> 
> Bugs: AMBARI-20013
> https://issues.apache.org/jira/browse/AMBARI-20013
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - make sure solr keytab and solr user is created on logsearch/ranger/atlas 
> hosts
> - created a new solr_cloud_util method called add roles (curl for adding user 
> roles)
> - updated secure znode method (adding infra-solr by default)
> - move generated security.json into a static file
> - added a custom security.json which can be used instead of the generated 
> security.json
> 
> This patch still does not contain atlas/ranger fixes (it will, that review is 
> mosly for review, i will include ranger/atlas changes later).
> 
> In ranger/atlas stack, the following calls can be used for securing znode and 
> update user-roles:
> 
> solr_cloud_util.secure_znode(config=params.config, 
> zookeeper_quorum=params.zookeeper_quorum,
>  
> solr_znode=format("{infra_solr_znode}/collections/mycollectionznode"),
>  jaas_file=params.logsearch_jaas_file,
>  java64_home=params.java64_home, 
> sasl_users=["myuser1@HOST", "myuser2"])
>  
> and 
> 
> solr_cloud_util.add_solr_roles(params.config,
>roles = ["ranger_audit_user"],
>new_service_principals = ["audituser1", 
> "audituser2"])
>
> about ranger plugins:
> 
> there is a way to use these methods in other services like storm etc. , the 
> problem is its needed to infra-solr be started, so if we include these in a 
> lot of other services, it can really slows down the deployment. that is the 
> reason why i kept the property dependencies in infra-solr-security-json 
> config. other then that, with the changes ranger can start successfully if 
> its added later to the cluster, and for plugins, infra-solr will be flagged 
> to be restarted.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
>  4628211 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-security-json.xml
>  e193a8c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
>  ab9aa61 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
>  8d72f42 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/templates/infra-solr-security.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-security.json.j2
>  ed764f0 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.7.0.2.5/kerberos.json
>  bc8e351 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json
>  49d1b10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  fecd802 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  ba91e20 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 253e32e 
>   ambari-server/src/test/python/stacks/2.4/AMBARI_INFRA/test_infra_solr.py 
> cd88fec 
> 
> Diff: https://reviews.apache.org/r/56671/diff/
> 
> 
> Testing
> ---
> 
> unit tests done, still writing unit tests for atlas/ranger additions.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items not working properly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/#review165679
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 9:59 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56701/
> ---
> 
> (Updated Feb. 15, 2017, 9:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20019
> https://issues.apache.org/jira/browse/AMBARI-20019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added condition to disable kill for a succeeded job. 
> Disabled kill action when the kill button is disabled.
> Added tooltips for all action buttons
> Added a loader icon when action request is in progress
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
> 2a5fc22 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  e9bc44f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> 714de66 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js
>  9760ddb 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js
>  95d06fc 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  a4a0cc2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs
>  be9310e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  eccc95d 
> 
> Diff: https://reviews.apache.org/r/56701/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56699: AMBARI-20007:Args value is not retained for ssh node


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56699/#review165678
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 6:55 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56699/
> ---
> 
> (Updated Feb. 15, 2017, 6:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20007
> https://issues.apache.org/jira/browse/AMBARI-20007
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified the handling of args while switching the arg ang args radio buttons.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 9d43fe7 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 
> d879a0c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs
>  2cd8207 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs
>  64f3906 
> 
> Diff: https://reviews.apache.org/r/56699/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56698: AMBARI-20003:Not able to preview the workflow xml


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56698/#review165677
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 6:09 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56698/
> ---
> 
> (Updated Feb. 15, 2017, 6:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20003
> https://issues.apache.org/jira/browse/AMBARI-20003
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified sqoop action model and sqoop action job handler to handle arg field
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 13eb6e5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 2a82c24 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  fb59149 
> 
> Diff: https://reviews.apache.org/r/56698/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56660: AMBARI-20005:Credentials from one workflow are getting associated across other workflow


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56660/#review165676
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 14, 2017, 1:06 p.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56660/
> ---
> 
> (Updated Feb. 14, 2017, 1:06 p.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20005
> https://issues.apache.org/jira/browse/AMBARI-20005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed by clearing credentials array when creating a workflow
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> 1f02426 
> 
> Diff: https://reviews.apache.org/r/56660/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false



> On Feb. 15, 2017, 2:14 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 513
> > 
> >
> > I searched for ```CVE-2014-3582``` on the web but couldn't find a 
> > detailed description of this vulnerability. Should a direct link be listed 
> > here that points to the detailed description.

I thought about this too.  I can add 
https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities to 
the doc. 

When I do a Google search for CVE-2014-3582, I get the above link as the 7th 
item in the list of results.  I am not really sure why it isn't closer to the 
top.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56685/#review165657
---


On Feb. 14, 2017, 5:06 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56685/
> ---
> 
> (Updated Feb. 14, 2017, 5:06 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20018
> https://issues.apache.org/jira/browse/AMBARI-20018
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Document security issue related to setting security.agent.hostname.validate 
> to "false".
> 
> If set to "false", invalid hostnames may be used in OpenSSL commands used to 
> create the agent-side certificates when 2-way SSL is enabled. This could lead 
> to issues when executing OpenSSL as described in CVE-2014-3582. See 
> https://cwiki.apache.org/confluence/display/AMBARI/Ambari+Vulnerabilities.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md 50864f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  5020790 
> 
> Diff: https://reviews.apache.org/r/56685/diff/
> 
> 
> Testing
> ---
> 
> No testing necessary.  Documentation change, only.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items not working properly


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/#review165674
---


Ship it!




Ship It!

- belliraj hb


On Feb. 15, 2017, 9:59 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56701/
> ---
> 
> (Updated Feb. 15, 2017, 9:59 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20019
> https://issues.apache.org/jira/browse/AMBARI-20019
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added condition to disable kill for a succeeded job. 
> Disabled kill action when the kill button is disabled.
> Added tooltips for all action buttons
> Added a loader icon when action request is in progress
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
> 2a5fc22 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
>  e9bc44f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
> 714de66 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js
>  9760ddb 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js
>  95d06fc 
>   contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
>  a4a0cc2 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs
>  be9310e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
>  eccc95d 
> 
> Diff: https://reviews.apache.org/r/56701/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56696/#review165673
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 6:07 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56696/
> ---
> 
> (Updated Feb. 15, 2017, 6:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19978
> https://issues.apache.org/jira/browse/AMBARI-19978
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified the ordering of properties in the coordinator object and modified 
> the xml generation in par with the xsd.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 658cbc0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 39b9d11 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js
>  cbefa99 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  ddb2b43 
> 
> Diff: https://reviews.apache.org/r/56696/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Review Request 56701: AMBARI-20019:WFM Dashboard Actions menu items not working properly

2017-02-15 Thread Padma Priya N


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56701/
---

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20019
https://issues.apache.org/jira/browse/AMBARI-20019


Repository: ambari


Description
---

Added condition to disable kill for a succeeded job. 
Disabled kill action when the kill button is disabled.
Added tooltips for all action buttons
Added a loader icon when action request is in progress


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/job-row.js 
2a5fc22 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/search-create-new-bar.js
 e9bc44f 
  contrib/views/wfmanager/src/main/resources/ui/app/components/search-table.js 
714de66 
  
contrib/views/wfmanager/src/main/resources/ui/app/controllers/design/dashboardtab.js
 9760ddb 
  
contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 
95d06fc 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 3f24000 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 a4a0cc2 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/job-row.hbs
 be9310e 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/search-table.hbs
 eccc95d 

Diff: https://reviews.apache.org/r/56701/diff/


Testing
---

Manual Testing


Thanks,

Padma Priya N

Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/#review165672
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 15, 2017, 9:06 a.m., venkat sairam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56661/
> ---
> 
> (Updated Feb. 15, 2017, 9:06 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20009
> https://issues.apache.org/jira/browse/AMBARI-20009
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Tables are not listed when we select the database and the process selection 
> of database is not clear
> 
> 
> Diffs
> -
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 
> 5a869c2 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 88202ff 
> 
> Diff: https://reviews.apache.org/r/56661/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56678: PixieDust - Decrease Service Check running time under 3 mins

2017-02-15 Thread Dmitro Lisnichenko



> On Feb. 14, 2017, 10:35 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java,
> >  line 771
> > 
> >
> > Is there also a command param to instruct the python file whether it is 
> > full or minimal?
> > This way, the python script can perform different behavior.

it's a part of cluster-env config and is accessible from parameters


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56678/#review165569
---


On Feb. 14, 2017, 10:07 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56678/
> ---
> 
> (Updated Feb. 14, 2017, 10:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-20017
> https://issues.apache.org/jira/browse/AMBARI-20017
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Right now, Ambari has a timeout of 5-10 mins for Service Checks.
> We need to ensure service checks pass in less than 3 mins for all services.
> 
> This means we need to potentially use a different configuration property if 
> one doesn't exist already so that QE can set it during the Ambari devdeploy 
> tests (in order to speed up the tests).
> 
> This will likely result in bugs in either the Ambari python scripts or the 
> actual services, for which we will create Jiras and assign to the appropriate 
> stack team.
> 
> This patch implements cluster_env/strict_service_check_type property. 
> Possible values are minimal (handled inside service check, runs shorter 
> service check action) and full (default action). If value is minimal, I also 
> reduce service check timeout when generating command on server in 2 times. 
> This way we adapt to service check timeouts that may be different for 
> different services. If service check takes 9 minutes of 10-minute timeout to 
> pass on our non-busy cluster, then it will probably take more then 10 minutes 
> on customers real cluster, and that is bad thing (bug).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  b601893 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 13d0993 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3af8f08 
> 
> Diff: https://reviews.apache.org/r/56678/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion



> On Feb. 14, 2017, 4:54 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java,
> >  lines 22-25
> > 
> >
> > Any specific reason for a new Exception class?  There's remarkable 
> > changed that isn't covered by a "regular" AmbariException.

Will revert this. Probably a remainder of a previous - since then discarded - 
error handling mechanism.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/#review165527
---


On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56540/
> ---
> 
> (Updated Feb. 14, 2017, 3:27 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
> Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19957
> https://issues.apache.org/jira/browse/AMBARI-19957
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Postgres allows multiple schemas on a database user's search path, that is 
> users can query from tables in different schemas without the need of 
> prefixing the tables in the query. 
> 
> This can lead to confusion when after an unsuccessful upgrade DBA's restore 
> the tables into a different schema (e.g. public) to Ambari's configured one. 
> As a result, Ambari server may see different data than indended.
> 
> New consistency checks on server startup warn the user in such situations.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7aa8652 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
>  2dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  1704546 
>   ambari-server/src/main/python/ambari_server_main.py 7a21333 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
>  f73562d 
> 
> Diff: https://reviews.apache.org/r/56540/diff/
> 
> 
> Testing
> ---
> 
> - Wrote new unit tests
> - Run all tests for ambari-server (all passed)
> - Performed manual testing
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56661/
---

(Updated Feb. 15, 2017, 9:06 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and 
Pallav Kulshreshtha.


Bugs: AMBARI-20009
https://issues.apache.org/jira/browse/AMBARI-20009


Repository: ambari


Description
---

Tables are not listed when we select the database and the process selection of 
database is not clear


Diffs (updated)
-

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/new.js 5a869c2 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
88202ff 

Diff: https://reviews.apache.org/r/56661/diff/


Testing
---

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56696: AMBARI-19978:Coordinator tag sequence is not maintained


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56696/#review165668
---


Ship it!




Ship It!

- belliraj hb


On Feb. 15, 2017, 6:07 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56696/
> ---
> 
> (Updated Feb. 15, 2017, 6:07 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19978
> https://issues.apache.org/jira/browse/AMBARI-19978
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified the ordering of properties in the coordinator object and modified 
> the xml generation in par with the xsd.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 
> 658cbc0 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 39b9d11 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js
>  cbefa99 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  ddb2b43 
> 
> Diff: https://reviews.apache.org/r/56696/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56698: AMBARI-20003:Not able to preview the workflow xml


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56698/#review165667
---


Ship it!




Ship It!

- belliraj hb


On Feb. 15, 2017, 6:09 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56698/
> ---
> 
> (Updated Feb. 15, 2017, 6:09 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20003
> https://issues.apache.org/jira/browse/AMBARI-20003
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified sqoop action model and sqoop action job handler to handle arg field
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 13eb6e5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 
> 2a82c24 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sqoop-action.hbs
>  fb59149 
> 
> Diff: https://reviews.apache.org/r/56698/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56699: AMBARI-20007:Args value is not retained for ssh node


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56699/#review165666
---


Ship it!




Ship It!

- belliraj hb


On Feb. 15, 2017, 6:55 a.m., Padma Priya N wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56699/
> ---
> 
> (Updated Feb. 15, 2017, 6:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and 
> Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-20007
> https://issues.apache.org/jira/browse/AMBARI-20007
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Modified the handling of args while switching the arg ang args radio buttons.
> 
> 
> Diffs
> -
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/java-action.js 
> 9d43fe7 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/ssh-action.js 
> d879a0c 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/shell-action.hbs
>  2cd8207 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/ssh-action.hbs
>  64f3906 
> 
> Diff: https://reviews.apache.org/r/56699/diff/
> 
> 
> Testing
> ---
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>

Re: Review Request 56661: HiveView2.0: Table list under DB panel on Query tab appears only if clicked on db name and Not clear how to set the database