Review Request 53505: AMBARI-18805 Bulk delete hosts: sending a force option to delete all components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53505/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18805 https://issues.apache.org/jira/browse/AMBARI-18805 Repository: ambari Description --- Send a force option to delete all components when delete hosts Diffs - ambari-web/app/utils/ajax/ajax.js d263ba0 Diff: https://reviews.apache.org/r/53505/diff/ Testing --- Local ambari-web test passed. 30351 tests complete (34 seconds) 151 tests pending Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 50014: AMBARI-17703 - Hosts page: after component filter hosts have wrong list of components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50014/#review155001 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 4, 2016, 9:55 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50014/ > --- > > (Updated Nov. 4, 2016, 9:55 p.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17703 > https://issues.apache.org/jira/browse/AMBARI-17703 > > > Repository: ambari > > > Description > --- > > Enable preload for host component related filters > > > Diffs > - > > ambari-web/app/controllers/global/update_controller.js fda1704 > ambari-web/app/controllers/main/host.js cea40cb > > Diff: https://reviews.apache.org/r/50014/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > 29021 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 53404: Component actions confirmation window (from host details page) don't have the details about action to be confirmed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53404/#review154988 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 2, 2016, 8:45 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53404/ > --- > > (Updated Nov. 2, 2016, 8:45 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18777 > https://issues.apache.org/jira/browse/AMBARI-18777 > > > Repository: ambari > > > Description > --- > > Component actions confirmation modal window (from host details page) don't > have the details about action to be confirmed. > > The window asks the user "Are you sure" only for any action selected except > delete e.g Stop, Start, Turn On Maintenance Mode, Restart. > > Steps to reproduce the issue: > 1. Login to Ambari > 2. Navigate to Hosts Tab > 3. Click on Service action drop down of any service available > 4. Click on any component action e.g Restart/Stop/Start > 5. The confirmation window should have the action to be performed E.g In Case > of Restart, "You are about to Restart Service NodeManager, Confirm?". > But it just have text "Are you sure" for any action selected except delete > > > Diffs > - > > ambari-web/app/controllers/main/host/details.js 848e6f8 > ambari-web/app/messages.js b0ebddd > > Diff: https://reviews.apache.org/r/53404/diff/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass. > 30323 tests complete (28 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 53364: AMBARI-18767 - E2E Integration for Manage JournalNode Wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53364/#review154619 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 2, 2016, 1:31 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53364/ > --- > > (Updated Nov. 2, 2016, 1:31 a.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18767 > https://issues.apache.org/jira/browse/AMBARI-18767 > > > Repository: ambari > > > Description > --- > > E2E Integration for Manage JournalNode Wizard. > 2 more step has been added to ensure data consistency of HDFS. > > > Diffs > - > > ambari-web/app/controllers.js e576d6c > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step1_controller.js > 0da5264 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step2_controller.js > 920bbd1e > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step4_controller.js > 39a074e > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step6_controller.js > a0425c8 > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step7_controller.js > PRE-CREATION > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/step8_controller.js > PRE-CREATION > > ambari-web/app/controllers/main/admin/highAvailability/journalNode/wizard_controller.js > 56b6ff5 > ambari-web/app/messages.js 45dfc2c > ambari-web/app/routes/manage_journalnode_routes.js 4803ca7 > ambari-web/app/styles/application.less d0eebce > ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs > ae01f46 > ambari-web/app/templates/main/admin/highAvailability/journalNode/step7.hbs > PRE-CREATION > ambari-web/app/templates/main/admin/highAvailability/journalNode/step8.hbs > PRE-CREATION > ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs > e654c50 > ambari-web/app/views.js 2dda9dd > ambari-web/app/views/main/admin/highAvailability/journalNode/step2_view.js > c32bd74 > ambari-web/app/views/main/admin/highAvailability/journalNode/step3_view.js > cac4a7e > ambari-web/app/views/main/admin/highAvailability/journalNode/step5_view.js > 651cabd > ambari-web/app/views/main/admin/highAvailability/journalNode/step7_view.js > PRE-CREATION > ambari-web/app/views/main/admin/highAvailability/journalNode/step8_view.js > PRE-CREATION > ambari-web/app/views/main/admin/highAvailability/journalNode/wizard_view.js > 434971b > > Diff: https://reviews.apache.org/r/53364/diff/ > > > Testing > --- > > Manually tested on live cluster. All unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 53332: Improve wizard styles and apply on Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53332/#review154351 --- Ship it! Ship It! - Zhe (Joe) Wang On Nov. 1, 2016, 12:04 a.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53332/ > --- > > (Updated Nov. 1, 2016, 12:04 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang and Richard Zang. > > > Repository: ambari > > > Description > --- > > Wizard improvements on Ambari UI: > The footer of the wizard (back & next button area) should be separated, not > with the content panel > The content panel should be on a white canvas, separated from step > title/description. > > Changes from the style guides: > 1. Narrow down wizard nav items. > 2. In wizard header and footer, should reduce the padding > 3. In wizard content, there should be no border for content panel, also > should reduce step title margin > > > Diffs > - > > ambari-web/app/templates/common/assign_master_components.hbs a9da3e5 > ambari-web/app/templates/common/progress.hbs 90a85a9 > ambari-web/app/templates/installer.hbs 4cac80c > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step1.hbs > 47f9dc2 > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/step2.hbs > 984df84 > > ambari-web/app/templates/main/admin/highAvailability/hawq/activateStandby/wizard.hbs > 23cfcf0 > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/step1.hbs > 2e315e3 > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/step3.hbs > 02ed51b > > ambari-web/app/templates/main/admin/highAvailability/hawq/addStandby/wizard.hbs > 7c21df4 > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step1.hbs > 02ceb03 > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/step2.hbs > 014c25a > > ambari-web/app/templates/main/admin/highAvailability/hawq/removeStandby/wizard.hbs > 13714df > ambari-web/app/templates/main/admin/highAvailability/journalNode/step1.hbs > e9e6fec > ambari-web/app/templates/main/admin/highAvailability/journalNode/step2.hbs > 67a63fd > ambari-web/app/templates/main/admin/highAvailability/journalNode/step3.hbs > b87497f > ambari-web/app/templates/main/admin/highAvailability/journalNode/step5.hbs > 53634cd > ambari-web/app/templates/main/admin/highAvailability/journalNode/wizard.hbs > c191d50 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/rollback_wizard.hbs > 9d325c6 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step1.hbs > 16330b9 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step2.hbs > 10b14d1 > > ambari-web/app/templates/main/admin/highAvailability/nameNode/rollbackHA/step3.hbs > 850b4e3 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step1.hbs > 63793e8 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs > 0536898 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step4.hbs > b864a39 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step6.hbs > 441f94c > ambari-web/app/templates/main/admin/highAvailability/nameNode/step8.hbs > f52b0ba > ambari-web/app/templates/main/admin/highAvailability/nameNode/wizard.hbs > a9d5d5c > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step1.hbs > ac248d0 > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/step3.hbs > c229662 > ambari-web/app/templates/main/admin/highAvailability/rangerAdmin/wizard.hbs > b5b6897 > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/step1.hbs > e3e115b > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs > de5ed63 > > ambari-web/app/templates/main/admin/highAvailability/resourceManager/wizard.hbs > 34de9e7 > ambari-web/app/templates/main/admin/kerberos/step1.hbs 7f8979b > ambari-web/app/templates/main/admin/kerberos/step2.hbs 47632a8 > ambari-web/app/templates/main/admin/kerberos/step3.hbs 4fd35a0 > ambari-web/app/templates/main/admin/kerberos/step4.hbs 1c5d281 > ambari-web/app/templates/main/admin/kerberos/step5.hbs 1e5af83 > ambari-w
Re: Review Request 53312: Popover dialog displays raw html instead of rendering it
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53312/#review154315 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 31, 2016, 7:27 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53312/ > --- > > (Updated Oct. 31, 2016, 7:27 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18752 > https://issues.apache.org/jira/browse/AMBARI-18752 > > > Repository: ambari > > > Description > --- > > Popover dialog displays raw html instead of rendering it > > > Diffs > - > > ambari-web/app/utils/helper.js 52dcd23 > > Diff: https://reviews.apache.org/r/53312/diff/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass. > > 30368 tests complete (28 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/#review154074 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 27, 2016, 10:58 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53178/ > --- > > (Updated Oct. 27, 2016, 10:58 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18696 > https://issues.apache.org/jira/browse/AMBARI-18696 > > > Repository: ambari > > > Description > --- > > Add Hive View Links to Hive Summary Page. > Fix some name typo. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/summary.js 6752bbf > ambari-web/app/messages.js 1770624 > ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 37225e1 > ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs f73e2bb > ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs eabb6dc > ambari-web/app/templates/main/service/item.hbs 5eb4e5b > ambari-web/app/templates/main/service/services/hive.hbs 23a2347 > ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f > ambari-web/app/views/common/quick_view_link_view.js 2678c1c > ambari-web/app/views/main/service/services/hive.js 2530e42 > > Diff: https://reviews.apache.org/r/53178/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 25699 tests complete (24 seconds) > 57 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 53178: AMBARI-18696 - Add Hive View Links to Hive Summary Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53178/#review153941 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 26, 2016, 9:03 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53178/ > --- > > (Updated Oct. 26, 2016, 9:03 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18696 > https://issues.apache.org/jira/browse/AMBARI-18696 > > > Repository: ambari > > > Description > --- > > Add Hive View Links to Hive Summary Page. > Fix some name typo. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/summary.js c16bb3f > ambari-web/app/messages.js 8f49cce > ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs cb97978 > ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 96f64ba > ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs 884f322 > ambari-web/app/templates/main/service/item.hbs 43fb3dd > ambari-web/app/templates/main/service/services/hive.hbs 23a2347 > ambari-web/app/views/common/log_search_ui_link_view.js 8227b7f > ambari-web/app/views/common/quick_view_link_view.js 17d7c04 > ambari-web/app/views/main/service/services/hive.js 2530e42 > > Diff: https://reviews.apache.org/r/53178/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 25699 tests complete (24 seconds) > 57 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 53205: AMBARI-18709 - Javascript Error When Using ComponentState Filter On Host Page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53205/#review153938 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 26, 2016, 8:37 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53205/ > --- > > (Updated Oct. 26, 2016, 8:37 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18709 > https://issues.apache.org/jira/browse/AMBARI-18709 > > > Repository: ambari > > > Description > --- > > Fix missing var statement. > > > Diffs > - > > ambari-web/app/controllers/main/host/combo_search_box.js 4ab3b7c > > Diff: https://reviews.apache.org/r/53205/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 30371 tests complete (30 seconds) > 151 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 18, 2016, 11:37 p.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs (updated) - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-admin/src/main/resources/ui/admin-web/package.json 42f584e ambari-web/app/styles/common.less a053d28 ambari-web/karma.conf.js 7442b95 ambari-web/package.json 94ded60 ambari-web/pom.xml d3de055 contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hive/pom.xml 20b23f6 contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing --- Ran "mvn clean package", Ambari Server failed, which is irralevant to this patch. Then run "mvn clean install" individually: Ambari Web: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 3:08.144s [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 [INFO] Final Memory: 16M/407M [INFO] 30366 tests complete (27 seconds) 151 tests pending Ambari Admin: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.924s [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 [INFO] Final Memory: 20M/284M [INFO] PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 secs) contrib/views/ modules: [INFO] [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] [INFO] Ambari View Utils . SUCCESS [4.714s] [INFO] Ambari View Commons ... SUCCESS [0.286s] [INFO] Files . SUCCESS [52.631s] [INFO] Jobs .. SUCCESS [6.712s] [INFO] Pig ... SUCCESS [1:07.799s] [INFO] Slider SUCCESS [36.043s] [INFO] Capacity Scheduler SUCCESS [53.446s] [INFO] Tez ... SUCCESS [3.659s] [INFO] HAWQ .. SUCCESS [2:24.060s] [INFO] Storm_Monitoring .. SUCCESS [0.432s] [INFO] Zeppelin .. SUCCESS [2.080s] [INFO] hueambarimigration SUCCESS [20.801s] [INFO] Hive Jdbc . SUCCESS [1:00.664s] [INFO] WF Manager View ... SUCCESS [32.911s] [INFO] Hive .. SUCCESS [51.542s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 9:58.964s [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 [INFO] Final Memory: 90M/404M [INFO] -------- Thanks, Zhe (Joe) Wang
Re: Review Request 52850: Icons don't display in Windows 10 Microsoft Edge or Internet Explorer 11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52850/#review152960 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 14, 2016, 12:07 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52850/ > --- > > (Updated Oct. 14, 2016, 12:07 a.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18595 > https://issues.apache.org/jira/browse/AMBARI-18595 > > > Repository: ambari > > > Description > --- > > Icons do not display in any page as shown in the screen-shot attached. > > > Diffs > - > > ambari-web/pom.xml 759b63e > > Diff: https://reviews.apache.org/r/52850/diff/ > > > Testing > --- > > Verified Manually in the latest versions of Google Chrome Mac OS X, Google > Chrome Windows 10, Microsoft Internet Explorer 11 and Microsoft Edge. > Ambari web unit tests pass. > 30374 tests complete (30 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49838/#review152958 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 13, 2016, 12:35 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49838/ > --- > > (Updated Oct. 13, 2016, 12:35 a.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, > Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-17636 > https://issues.apache.org/jira/browse/AMBARI-17636 > > > Repository: ambari > > > Description > --- > > * Go to Service->Configs page (that have more than ~ 30 versions) > * Open versions dropdown > > *Result:* > Number of visible versions limited by window height. > > > Diffs > - > > ambari-web/app/styles/config_history_flow.less 0b6dc3f > ambari-web/app/templates/common/configs/config_history_flow.hbs fa67786 > ambari-web/app/views/common/configs/config_history_flow.js 5ad65ac > > Diff: https://reviews.apache.org/r/49838/diff/ > > > Testing > --- > > Local Ambari web test passed. > 28944 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > Local Ambari-web tests pass. > 30364 tests complete (27 seconds) > 151 tests pending > Verified manually > > > File Attachments > > > Gif of latest changes > > https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52710/ --- (Updated Oct. 12, 2016, 12:07 a.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18566 https://issues.apache.org/jira/browse/AMBARI-18566 Repository: ambari Description --- *STR:* # Got to select versions page # Choose "Use Local Repository" option and then choose "Use RedHat Satellite/Spacewalk" option # Next button will get enabled. click on next button. *Expected Result:* wizard goes to next page *Actual Result:* On clicking next button, next button gets disabled and wizard does not go to next page. Diffs (updated) - ambari-web/app/controllers/installer.js f8f70a0 ambari-web/app/views/wizard/step1_view.js 2b80ad5 Diff: https://reviews.apache.org/r/52710/diff/ Testing --- Local ambari-web test passed. 30374 tests complete (27 seconds) 151 tests pending Manual testing done Thanks, Zhe (Joe) Wang
Review Request 52710: AMBARI-18566 Installer wizard-> Select Versions page: Selecting Red Hat Satellite option and clicking next button makes wizard stuck
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52710/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18566 https://issues.apache.org/jira/browse/AMBARI-18566 Repository: ambari Description --- *STR:* # Got to select versions page # Choose "Use Local Repository" option and then choose "Use RedHat Satellite/Spacewalk" option # Next button will get enabled. click on next button. *Expected Result:* wizard goes to next page *Actual Result:* On clicking next button, next button gets disabled and wizard does not go to next page. Diffs - ambari-web/app/controllers/installer.js f8f70a0 Diff: https://reviews.apache.org/r/52710/diff/ Testing --- Local ambari-web test passed. 30374 tests complete (27 seconds) 151 tests pending Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52654/#review152075 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 7, 2016, 10:14 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52654/ > --- > > (Updated Oct. 7, 2016, 10:14 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18559 > https://issues.apache.org/jira/browse/AMBARI-18559 > > > Repository: ambari > > > Description > --- > > - Typically being in "Add Service Wizard", user expects the INSTALL and START > of sevices components. > - However, if user clicks on the close (X) on the wizard, the service will > only get INSTALLED not STARTED. > > - Either apprising the user that only INSTALL will take place and START will > be skipped will help OR even if the close (X) on the wizard is hit, context > for START is still maintained. > > > Diffs > - > > ambari-web/app/messages.js 5eafad2 > ambari-web/app/routes/add_service_routes.js 30c8e07 > > Diff: https://reviews.apache.org/r/52654/diff/ > > > Testing > --- > > Verified Manually. > Ambari-web unit tests pass. > 30374 tests complete (26 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 52535: Advanced storm-atlas-application.properties panel is not opened by default upon filtering
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52535/#review151551 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 4, 2016, 11:46 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52535/ > --- > > (Updated Oct. 4, 2016, 11:46 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18534 > https://issues.apache.org/jira/browse/AMBARI-18534 > > > Repository: ambari > > > Description > --- > > - Navigate to Storm configs page > - Type "hook" in the property filter > - Its expected that Advanced storm-atlas-application.properties panel opens > up by default > - Actual: its still closed. please see the screenshot attached > > > Diffs > - > > ambari-web/app/views/common/configs/service_configs_by_category_view.js > 3eebfea > > Diff: https://reviews.apache.org/r/52535/diff/ > > > Testing > --- > > Verified manually. > Ambari-web unit test pass. > 30374 tests complete (27 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52555/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18535 https://issues.apache.org/jira/browse/AMBARI-18535 Repository: ambari Description --- During fresh deployment, if HDP-2.4 is chosen then Ambari does not default to the latest 2.4 release, HDP-2.4.2. This is likely because VDF files do not exist for HDP-2.4 release and the older mechanism of picking the latest repo URL form the hdp_urlinfo.json does not work. HDP-2.4.0 is chosen where as the latest is HDP-2.4.2 Diffs - ambari-web/app/controllers/installer.js f8f70a0 Diff: https://reviews.apache.org/r/52555/diff/ Testing --- Local ambari-web test passed. 30374 tests complete (27 seconds) 151 tests pending Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
> On Oct. 3, 2016, 10:57 p.m., Yusaku Sako wrote: > > When you say "local testing done", what did that entail? > > Also, did you explicitly build all the contrib/views modules with the > > change? Added the details. Thank you. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/#review151248 --- On Oct. 4, 2016, 12:51 a.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52495/ > --- > > (Updated Oct. 4, 2016, 12:51 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-18245 > https://issues.apache.org/jira/browse/AMBARI-18245 > > > Repository: ambari > > > Description > --- > > We are currently using 0.10, which is very old and going EOL 2016-10-01: > https://github.com/nodejs/LTS > We should upgrade to Node 4.x: > Upgrade Node on Ambari Web > Upgrade Node on Ambari Admin > Upgrade Node on contrib/views/* modules > > > Diffs > - > > .gitignore d9f23de > ambari-admin/pom.xml e057178 > ambari-web/app/styles/common.less bc11d4d > ambari-web/package.json 6702471 > ambari-web/pom.xml 759b63e > contrib/views/capacity-scheduler/pom.xml cd97dcf > contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 > contrib/views/files/pom.xml 383d90d > contrib/views/hawq/pom.xml 9a563f6 > contrib/views/hive-next/pom.xml 921990a > contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hive/pom.xml 20b23f6 > contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 > contrib/views/hueambarimigration/pom.xml 3b28276 > contrib/views/jobs/pom.xml bd01753 > contrib/views/pig/pom.xml 595537a > contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 > contrib/views/wfmanager/pom.xml 389dc6c > > Diff: https://reviews.apache.org/r/52495/diff/ > > > Testing > --- > > Ran "mvn clean package", Ambari Server failed, which is irralevant to this > patch. > Then run "mvn clean install" individually: > > Ambari Web: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3:08.144s > [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 > [INFO] Final Memory: 16M/407M > [INFO] > > > 30366 tests complete (27 seconds) > 151 tests pending > > Ambari Admin: > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 14.924s > [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 > [INFO] Final Memory: 20M/284M > [INFO] > > > PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 > secs) > > contrib/views/ modules: > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] > [INFO] Ambari View Utils . SUCCESS [4.714s] > [INFO] Ambari View Commons ... SUCCESS [0.286s] > [INFO] Files . SUCCESS [52.631s] > [INFO] Jobs .. SUCCESS [6.712s] > [INFO] Pig ... SUCCESS [1:07.799s] > [INFO] Slider SUCCESS [36.043s] > [INFO] Capacity Scheduler SUCCESS [53.446s] > [INFO] Tez ... SUCCESS [3.659s] > [INFO] HAWQ .. SUCCESS [2:24.060s] > [INFO] Storm_Monitoring .. SUCCESS [0.432s] > [INFO] Zeppelin .. SUCCESS [2.080s] > [INFO] hueambarimigration .
Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- (Updated Oct. 4, 2016, 12:51 a.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs (updated) - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-web/app/styles/common.less bc11d4d ambari-web/package.json 6702471 ambari-web/pom.xml 759b63e contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hive/pom.xml 20b23f6 contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing (updated) --- Ran "mvn clean package", Ambari Server failed, which is irralevant to this patch. Then run "mvn clean install" individually: Ambari Web: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 3:08.144s [INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016 [INFO] Final Memory: 16M/407M [INFO] 30366 tests complete (27 seconds) 151 tests pending Ambari Admin: [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.924s [INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016 [INFO] Final Memory: 20M/284M [INFO] PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 secs) contrib/views/ modules: [INFO] [INFO] Reactor Summary: [INFO] [INFO] Ambari Contrib Views .. SUCCESS [1:00.758s] [INFO] Ambari View Utils . SUCCESS [4.714s] [INFO] Ambari View Commons ... SUCCESS [0.286s] [INFO] Files . SUCCESS [52.631s] [INFO] Jobs .. SUCCESS [6.712s] [INFO] Pig ... SUCCESS [1:07.799s] [INFO] Slider SUCCESS [36.043s] [INFO] Capacity Scheduler SUCCESS [53.446s] [INFO] Tez ... SUCCESS [3.659s] [INFO] HAWQ .. SUCCESS [2:24.060s] [INFO] Storm_Monitoring .. SUCCESS [0.432s] [INFO] Zeppelin .. SUCCESS [2.080s] [INFO] hueambarimigration SUCCESS [20.801s] [INFO] Hive Jdbc . SUCCESS [1:00.664s] [INFO] WF Manager View ... SUCCESS [32.911s] [INFO] Hive .. SUCCESS [51.542s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 9:58.964s [INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016 [INFO] Final Memory: 90M/404M [INFO] -------- Thanks, Zhe (Joe) Wang
Re: Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52497/#review151265 --- Ship it! Ship It! - Zhe (Joe) Wang On Oct. 3, 2016, 11:13 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52497/ > --- > > (Updated Oct. 3, 2016, 11:13 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-18519 > https://issues.apache.org/jira/browse/AMBARI-18519 > > > Repository: ambari > > > Description > --- > > Enable Add/Remove JournalNode on NNHA Wizard Step 2 > > > Diffs > - > > > ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js > b8d7978 > ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs > 27653d3 > > Diff: https://reviews.apache.org/r/52497/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > 30366 tests complete (30 seconds) > 151 tests pending > > > Thanks, > > Richard Zang > >
Review Request 52495: AMBARI-18245 Upgrade node to version 4.x
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52495/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18245 https://issues.apache.org/jira/browse/AMBARI-18245 Repository: ambari Description --- We are currently using 0.10, which is very old and going EOL 2016-10-01: https://github.com/nodejs/LTS We should upgrade to Node 4.x: Upgrade Node on Ambari Web Upgrade Node on Ambari Admin Upgrade Node on contrib/views/* modules Diffs - .gitignore d9f23de ambari-admin/pom.xml e057178 ambari-web/app/styles/common.less bc11d4d ambari-web/package.json 6702471 ambari-web/pom.xml 759b63e contrib/views/capacity-scheduler/pom.xml cd97dcf contrib/views/files/pom.xml 383d90d contrib/views/hawq/pom.xml 9a563f6 contrib/views/hive-next/pom.xml 921990a contrib/views/hive/pom.xml 20b23f6 contrib/views/hueambarimigration/pom.xml 3b28276 contrib/views/jobs/pom.xml bd01753 contrib/views/pig/pom.xml 595537a contrib/views/wfmanager/pom.xml 389dc6c Diff: https://reviews.apache.org/r/52495/diff/ Testing --- Local test passed. Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 51702: Ambari UI: Memory leak while adding and removing property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51702/#review150758 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 27, 2016, 11:42 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51702/ > --- > > (Updated Sept. 27, 2016, 11:42 p.m.) > > > Review request for Ambari, Andrii Tkach, Zhe (Joe) Wang, Richard Zang, and > Yusaku Sako. > > > Bugs: AMBARI-18308 > https://issues.apache.org/jira/browse/AMBARI-18308 > > > Repository: ambari > > > Description > --- > > Go to any of the service config screen ( for e.x Hive ) and add and remove > multiple properties one after another (without using bulk add). > This results in javascript memory leak. > > > Diffs > - > > ambari-web/app/views/common/configs/service_configs_by_category_view.js > ad1a2f9 > > ambari-web/test/views/common/configs/service_configs_by_category_view_test.js > 7b6c451 > > Diff: https://reviews.apache.org/r/51702/diff/ > > > Testing > --- > > tested the patch manually to resolve the issue. > verified that all ambari-web unit tests passes with the patch: > > 29244 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 52178: Ambari create widget does not show what the error is
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52178/#review150111 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 22, 2016, 11:55 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52178/ > --- > > (Updated Sept. 22, 2016, 11:55 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18449 > https://issues.apache.org/jira/browse/AMBARI-18449 > > > Repository: ambari > > > Description > --- > > Tried to create a custom widget but the next button was disabled. However the > UI did not show what the error was > > > Diffs > - > > ambari-web/app/controllers/main/service/widgets/create/step2_controller.js > 4e3ab91 > ambari-web/app/templates/main/service/widgets/create/expression.hbs 826cb43 > ambari-web/app/templates/main/service/widgets/create/step2_graph.hbs > 17e4790 > ambari-web/app/templates/main/service/widgets/create/step2_number.hbs > 27fd7e4 > ambari-web/app/templates/main/service/widgets/create/step2_template.hbs > 6a8a469 > ambari-web/app/views/main/service/widgets/create/expression_view.js 32c664f > > Diff: https://reviews.apache.org/r/52178/diff/ > > > Testing > --- > > Verified manually. > > Ambari-web unit tests pass. > 30368 tests complete (27 seconds) > 151 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 52130: Add service wizard: Customize service page keeps showing spinner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52130/#review149894 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 21, 2016, 7:24 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52130/ > --- > > (Updated Sept. 21, 2016, 7:24 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Yusaku Sako. > > > Bugs: AMBARI-18436 > https://issues.apache.org/jira/browse/AMBARI-18436 > > > Repository: ambari > > > Description > --- > > When there is an installed service that has no config, it results in JS error > while navigating to > "Customize Services" page > STR: > Install a blueprint provisioned cluster with a custom service that has one > config-type for example: x-site.xml. Keep this site empty with no properties > After cluster installation, try to add Slider service. > Expected Result: User should be able to add Slider service. > Actual Result: While navigating to "Customize Services" page, spinner keeps > showing. JS error noticed in dev console > > > Diffs > - > > ambari-web/app/controllers/wizard/step7_controller.js a35ea00 > > Diff: https://reviews.apache.org/r/52130/diff/ > > > Testing > --- > > Tested the patch manually on a cluster > Verified that all unit tests passes with the patch: > > 29243 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/#review149764 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 21, 2016, 12:04 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52102/ > --- > > (Updated Sept. 21, 2016, 12:04 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-15059 > https://issues.apache.org/jira/browse/AMBARI-15059 > > > Repository: ambari > > > Description > --- > > Add extra handling logic for navigating out and save button. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js > 582b68b > > ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html > ee5d860 > > Diff: https://reviews.apache.org/r/52102/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 > secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 52102: UI for user home directory creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52102/#review149757 --- ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js (line 24) <https://reviews.apache.org/r/52102/#comment217457> Indent? - Zhe (Joe) Wang On Sept. 20, 2016, 10:59 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52102/ > --- > > (Updated Sept. 20, 2016, 10:59 p.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-15059 > https://issues.apache.org/jira/browse/AMBARI-15059 > > > Repository: ambari > > > Description > --- > > Add extra handling logic for navigating out and save button. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/loginActivities/HomeDirectoryCtrl.js > 582b68b > > ambari-admin/src/main/resources/ui/admin-web/app/views/loginActivities/homeDirectory.html > ee5d860 > > Diff: https://reviews.apache.org/r/52102/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.408 > secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 51937: Configuration Groups popup: Tooltip over properties number has too much content
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51937/#review149155
---
ambari-web/app/controllers/main/service/manage_config_groups_controller.js
(line 174)
<https://reviews.apache.org/r/51937/#comment216673>
If "selectedConfigGroup" will not affect this value, except
"propertiesList" property, maybe just watch
".property('selectedConfigGroup.propertiesList')" is enough?
- Zhe (Joe) Wang
On Sept. 15, 2016, 10:09 p.m., Vivek Ratnavel Subramanian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51937/
> ---
>
> (Updated Sept. 15, 2016, 10:09 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-18408
> https://issues.apache.org/jira/browse/AMBARI-18408
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Configuration Groups popup contains a link with number of overridden
> properties for every group. On click all these properties are listed in
> popup, while on hover the same info is contained in tooltip. In some cases
> there's too much content for tooltip.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/service/manage_config_groups_controller.js
> e6e21bc
> ambari-web/app/templates/main/service/manage_configuration_groups_popup.hbs
> d0fd103
>
> Diff: https://reviews.apache.org/r/51937/diff/
>
>
> Testing
> ---
>
> Verified manually.
> Ambari-web unit tests pass.
> 30365 tests complete (32 seconds)
> 151 tests pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/#review148963 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 14, 2016, 8:40 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51897/ > --- > > (Updated Sept. 14, 2016, 8:40 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and > Yusaku Sako. > > > Bugs: AMBARI-18389 > https://issues.apache.org/jira/browse/AMBARI-18389 > > > Repository: ambari > > > Description > --- > > "placeholder" only make sense when config is editable. > > > Diffs > - > > ambari-web/app/models/configs/objects/service_config_property.js 0c7673d > ambari-web/test/models/configs/objects/service_config_property_test.js > a6772d3 > > Diff: https://reviews.apache.org/r/51897/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 51897: Config compare shows incorrect value after enabling kerberos
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51897/#review148956 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 14, 2016, 7:27 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51897/ > --- > > (Updated Sept. 14, 2016, 7:27 p.m.) > > > Review request for Ambari, Andrii Tkach, Jaimin Jetly, Zhe (Joe) Wang, and > Yusaku Sako. > > > Bugs: AMBARI-18389 > https://issues.apache.org/jira/browse/AMBARI-18389 > > > Repository: ambari > > > Description > --- > > "placeholder" only make sense when config is editable. > > > Diffs > - > > ambari-web/app/models/configs/objects/service_config_property.js 0c7673d > ambari-web/test/models/configs/objects/service_config_property_test.js > a6772d3 > > Diff: https://reviews.apache.org/r/51897/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/#review148777 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 13, 2016, 8:40 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51859/ > --- > > (Updated Sept. 13, 2016, 8:40 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-18382 > https://issues.apache.org/jira/browse/AMBARI-18382 > > > Repository: ambari > > > Description > --- > > This happens due to incorrect config property update of Ambari metrics service > > > Diffs > - > > ambari-web/app/controllers/main/admin/kerberos/step4_controller.js 91a40dd > > Diff: https://reviews.apache.org/r/51859/diff/ > > > Testing > --- > > Verified that patch fixes the issue on a cluster. > Verified that all ambari-web unit tests passes: > 29244 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 51540: Expose Disabling of Alert Targets in Web Client
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51540/#review148775 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 9, 2016, 10:07 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51540/ > --- > > (Updated Sept. 9, 2016, 10:07 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: Ambari-18281 > https://issues.apache.org/jira/browse/Ambari-18281 > > > Repository: ambari > > > Description > --- > > Add an option to Enable/ Disable alert notifications in Manage Notifications > popup. > > > Diffs > - > > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > f3f0387 > ambari-web/app/styles/modal_popups.less a2343e0 > > Diff: https://reviews.apache.org/r/51540/diff/ > > > Testing > --- > > Verified manually. > Ambari-web unit tests pass. > 30014 tests complete (26 seconds) > 154 tests pending > > > File Attachments > > > v1 > > https://reviews.apache.org/media/uploaded/files/2016/08/31/ad971a3a-3430-4caa-9e7f-df60cc75872c__AMBARI-18281.v1.patch > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 51772: Ambari Dashboard UI does not load intermittently
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51772/#review148398 --- Ship it! Ship It! - Zhe (Joe) Wang On Sept. 10, 2016, 5:06 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51772/ > --- > > (Updated Sept. 10, 2016, 5:06 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Oleg Nechiporenko, and Yusaku Sako. > > > Bugs: AMBARI-18353 > https://issues.apache.org/jira/browse/AMBARI-18353 > > > Repository: ambari > > > Description > --- > > This seems to happen when using set function of Ember data record right after > loading the model type by using loadMany function. As a fix, patch waits for > the model record to be loaded before attempting to set any property on it. > > > Diffs > - > > ambari-web/app/mappers/service_mapper.js 9c21789 > ambari-web/app/models/service.js c648e93 > > Diff: https://reviews.apache.org/r/51772/diff/ > > > Testing > --- > > Verified that the patch does not introduce any regression > Verified that the patch passes all unit tests: > > 29244 tests complete (32 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 51744: SmartSense Mandatory Install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51744/#review148372 --- ambari-web/app/mappers/stack_service_mapper.js (line 122) <https://reviews.apache.org/r/51744/#comment215830> Since the logic here is that if this variable is true, that means this service is either disabled or it's installed, using the name "isDisabled" will mask partial fact. In another way to sayit, people may be confused about why a service is "disabled" when it's just acctually installed. So maybe call it something like "installedOrDisabled"? - Zhe (Joe) Wang On Sept. 8, 2016, 8:09 p.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51744/ > --- > > (Updated Sept. 8, 2016, 8:09 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-18346 > https://issues.apache.org/jira/browse/AMBARI-18346 > > > Repository: ambari > > > Description > --- > > Perform a UI hack to force selection of SmartSense for HDP stacks (the user > cannot deselect). > > > Diffs > - > > ambari-web/app/controllers/wizard/step4_controller.js 04e6784 > ambari-web/app/mappers/stack_service_mapper.js c800e83 > ambari-web/app/models/stack_service.js 9cf9d49 > ambari-web/app/templates/wizard/step4.hbs c62d369 > > Diff: https://reviews.apache.org/r/51744/diff/ > > > Testing > --- > > Verified manually. > Ambari-web unit test pass. > 29244 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
Review Request 51538: AMBARI-18280 Ambari widget graph is not aggregating the data correctly for Total Request Count
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51538/ --- Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18280 https://issues.apache.org/jira/browse/AMBARI-18280 Repository: ambari Description --- *PROBLEM:* Total Request Count is not growing exponentially *IMPACT:* User is not able to monitor the data correctly. Diffs - ambari-web/app/utils/ajax/ajax.js dd15f9f ambari-web/app/views/main/service/info/metrics/ambari_metrics/regionserver_requests.js fe8ea70 Diff: https://reviews.apache.org/r/51538/diff/ Testing --- Local ambari-web test passed. 30014 tests complete (27 seconds) 154 tests pending Manual testing don Thanks, Zhe (Joe) Wang
Review Request 51356: AMBARI-18247 Capacity scheduler's dependent config suggestion is incomprehensible
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51356/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18247 https://issues.apache.org/jira/browse/AMBARI-18247 Repository: ambari Description --- Dependent configs dialog shows recommended values for capacity scheduler which is incomprehensible to read. It will be good to breakdown the specific changes into separate rows. Diffs - ambari-web/app/mixins/common/configs/config_recommendations.js 398cf55 ambari-web/app/templates/common/modal_popups/dependent_configs_list.hbs 0fe073c ambari-web/app/utils/config.js 7e1f5b8 ambari-web/config.coffee 4a29e73 ambari-web/karma.conf.js 013cc2e ambari-web/test/mixins/common/configs/config_recommendations_test.js 3f7d6b1 ambari-web/vendor/scripts/difflib.js PRE-CREATION ambari-web/vendor/scripts/diffview.js PRE-CREATION ambari-web/vendor/styles/diffview.css PRE-CREATION Diff: https://reviews.apache.org/r/51356/diff/ Testing --- Modified unit test. Local ambari-web test passed. 29244 tests complete (25 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 51259: Namenode start failed on moving namenode on a HA cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51259/#review146242 --- Ship it! Ship It! - Zhe (Joe) Wang On Aug. 20, 2016, 7:31 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51259/ > --- > > (Updated Aug. 20, 2016, 7:31 p.m.) > > > Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, Zhe (Joe) > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18220 > https://issues.apache.org/jira/browse/AMBARI-18220 > > > Repository: ambari > > > Description > --- > > *STR:* > 1. Enable NameNode HA > 2. Launch "move namendode" wizard > > *Actual Result:* On the page "Configure Component" at the step to start > namenode, both namenodes are started. This leads to failure of the request > intermittently > *Expected Result:* Only one namenode "the one which is not being moved" > should be started > > > Diffs > - > > ambari-web/app/controllers/main/service/reassign/step4_controller.js > d853039 > ambari-web/app/views/main/service/reassign/step5_view.js 066b23b > ambari-web/test/controllers/main/service/reassign/step4_controller_test.js > 8898849 > > Diff: https://reviews.apache.org/r/51259/diff/ > > > Testing > --- > > maually verified the patch > Verified that ambari-web unit tests passes with the patch: > > 29244 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 50825: AMBARI-18032 UI:Warning message is not present and "Next button" is enabled when all HDP links is empty on Select Version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50825/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-18032 https://issues.apache.org/jira/browse/AMBARI-18032 Repository: ambari Description --- STR: 1) Navigate on select stack page 2)Remo all HDP urls Actual result: Warning message is not present and "Next button" is enabled when all HDP links is empty on Select Version page Expected behaviour: 1) Warning message should appear : "Repository Base URLs of at least one OS are REQUIRED before you can proceed." 2) Next button should be disabled while some URLS are not posted for one OS at least Diffs - ambari-web/app/models/operating_system.js b137108 ambari-web/app/views/wizard/step1_view.js c3a5aac Diff: https://reviews.apache.org/r/50825/diff/ Testing --- Modified unit test. Local ambari-web test passed. 29246 tests complete (25 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 50809: Hive HSI number of daemons label does not refresh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50809/#review144785 --- Ship it! Ship It! - Zhe (Joe) Wang On Aug. 4, 2016, 4:52 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50809/ > --- > > (Updated Aug. 4, 2016, 4:52 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Swapan Shridhar, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-18027 > https://issues.apache.org/jira/browse/AMBARI-18027 > > > Repository: ambari > > > Description > --- > > I tried enabling HiveServer Interactive by doing the following steps > STR: > Iteration 1 > 1) Adjusted slider for "% Cluster Capacity" to 83% > 2) Adjusted slider for "Maximum Concurrent Queries" to 4 > 3) Based on some computation "Number of LLAP Daemons" is chosen as 7 > Iteration 2 > 4) Moved "% Cluster Capacity" to 90% > 5) Moved "Maximum Concurrent Queries" to 4 > 6) "Number of LLAP Daemons" is now chosen 6 > Actual Result: The combination of configs set with new values after iteration > 2 seems to be incorrect > > > Diffs > - > > ambari-web/app/views/common/controls_view.js 4e90ead > > Diff: https://reviews.apache.org/r/50809/diff/ > > > Testing > --- > > Verified that the patch resolves the issue on a deployed cluster. > Verified that all ambari-web unit tests passes with the patch: > 29246 tests complete (30 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 50542: AMBARI-17936 Log search tab seems to be visible for all user roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50542/ --- Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17936 https://issues.apache.org/jira/browse/AMBARI-17936 Repository: ambari Description --- Log search tabs (in host details page) must be only visible for service admin user and above. Right now it is visible to all roles including cluster user. Diffs - ambari-web/app/views/main/host/menu.js 07d9def ambari-web/test/views/main/host/menu_test.js f7d35a4 Diff: https://reviews.apache.org/r/50542/diff/ Testing --- Modified unit test. Local ambari-web test passed. 29414 tests complete (26 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 50470: AMBARI-17907 On AMS collector move the webapp address does not change
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50470/
---
Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel
Subramanian, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-17907
https://issues.apache.org/jira/browse/AMBARI-17907
Repository: ambari
Description
---
Move collector to a different host. Collector start fails because following
property is not modified:
{quote}timeline.metrics.service.webapp.address{quote}
Diffs
-
ambari-web/app/controllers/main/service/reassign/step4_controller.js d8f0394
ambari-web/test/controllers/main/service/reassign/step4_controller_test.js
d6ef9dc
Diff: https://reviews.apache.org/r/50470/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
29371 tests complete (25 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Review Request 50358: AMBARI-17865 incorrect text for disabled "Change Password" button
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50358/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17865 https://issues.apache.org/jira/browse/AMBARI-17865 Repository: ambari Description --- Incorrect "users.changePassword" Diffs - ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html a1b4c95 Diff: https://reviews.apache.org/r/50358/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.166 secs / 0.381 secs) Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 50306: UI does not allow to delete service is some host components are in INSTALLED_FAILED state
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50306/#review143135 --- Ship it! Ship It! - Zhe (Joe) Wang On July 21, 2016, 7:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50306/ > --- > > (Updated July 21, 2016, 7:36 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Vivek Ratnavel > Subramanian, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-17841 > https://issues.apache.org/jira/browse/AMBARI-17841 > > > Repository: ambari > > > Description > --- > > *STR:* > # Deploy a service ad abort installation in the middle in a way such that > some of its slave host components remains in INSTALLED_FAILED state but no all > # Try deleting service > > *Expected Result:* UI should allow service deletion as API allows it in this > scenario > *Actual Result:* UI shows a warning popup in green color and does not let > user delete a service. screenshot attached > > > Diffs > - > > ambari-web/app/models/client_component.js 3902227 > ambari-web/app/models/host_component.js 91642c9 > ambari-web/app/models/service.js c648e93 > ambari-web/test/models/service_test.js e527e1e > > Diff: https://reviews.apache.org/r/50306/diff/ > > > Testing > --- > > Verified that the patch fixes the issue on a cluster > Verified that ambari-web unit tests passes with the patch > 29219 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 50275: AMBARI-17821 Atlas: Add Service Customize Services Page Issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50275/#review143035 --- Ship it! Ship It! - Zhe (Joe) Wang On July 20, 2016, 11:44 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50275/ > --- > > (Updated July 20, 2016, 11:44 p.m.) > > > Review request for Ambari, Andrii Tkach and Zhe (Joe) Wang. > > > Bugs: AMBARI-17821 > https://issues.apache.org/jira/browse/AMBARI-17821 > > > Repository: ambari > > > Description > --- > > Push UI after recommendation finish > > > Diffs > - > > ambari-web/app/views/common/configs/service_config_container_view.js > 8b6a9ce > ambari-web/test/views/common/configs/service_config_container_view_test.js > e7aaa62 > > Diff: https://reviews.apache.org/r/50275/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > 29292 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50165/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-1 https://issues.apache.org/jira/browse/AMBARI-1 Repository: ambari Description --- STR: # Go to SelectVersion page # Clear any input with Base URL (for ex. ubuntu14) # Click on next button Expected: input has now red borders and warning message appears below "Attention: All repo URLs are required before you can proceed." Actually: Next button became to disabled state. Next page wasn't loaded. Diffs - ambari-web/app/controllers/installer.js 037e555 ambari-web/app/models/operating_system.js c2588fe Diff: https://reviews.apache.org/r/50165/diff/ Testing --- Local ambari-web test passed. 29285 tests complete (25 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49838/#review142419 --- Ship it! Ship It! - Zhe (Joe) Wang On July 15, 2016, 1:55 a.m., Vivek Ratnavel Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49838/ > --- > > (Updated July 15, 2016, 1:55 a.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-17636 > https://issues.apache.org/jira/browse/AMBARI-17636 > > > Repository: ambari > > > Description > --- > > * Go to Service->Configs page (that have more than ~ 30 versions) > * Open versions dropdown > > *Result:* > Number of visible versions limited by window height. > > > Diffs > - > > ambari-web/app/styles/config_history_flow.less fff3151 > ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs > PRE-CREATION > ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913 > ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab > > Diff: https://reviews.apache.org/r/49838/diff/ > > > Testing > --- > > Local Ambari web test passed. > 28944 tests complete (25 seconds) > 154 tests pending > Manual testing done. > > > File Attachments > > > Gif of latest changes > > https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif > > > Thanks, > > Vivek Ratnavel Subramanian > >
Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/#review142302
---
ambari-web/app/views/common/configs/config_history_flow.js (line 305)
<https://reviews.apache.org/r/49838/#comment207871>
this.get('hoveredServiceVersion.version')
- Zhe (Joe) Wang
On July 14, 2016, 10:21 p.m., Vivek Ratnavel Subramanian wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49838/
> ---
>
> (Updated July 14, 2016, 10:21 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-17636
> https://issues.apache.org/jira/browse/AMBARI-17636
>
>
> Repository: ambari
>
>
> Description
> ---
>
> * Go to Service->Configs page (that have more than ~ 30 versions)
> * Open versions dropdown
>
> *Result:*
> Number of visible versions limited by window height.
>
>
> Diffs
> -
>
> ambari-web/app/styles/config_history_flow.less fff3151
> ambari-web/app/templates/common/configs/config_history_dropdown_row.hbs
> PRE-CREATION
> ambari-web/app/templates/common/configs/config_history_flow.hbs 73d6913
> ambari-web/app/views/common/configs/config_history_flow.js ad2b1ab
>
> Diff: https://reviews.apache.org/r/49838/diff/
>
>
> Testing
> ---
>
> Local Ambari web test passed.
> 28944 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>
Re: Review Request 50014: AMBARI-17703 - Hosts page: after component filter hosts have wrong list of components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50014/#review142186 --- Ship it! Ship It! - Zhe (Joe) Wang On July 14, 2016, 1:37 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50014/ > --- > > (Updated July 14, 2016, 1:37 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17703 > https://issues.apache.org/jira/browse/AMBARI-17703 > > > Repository: ambari > > > Description > --- > > Enable preload for host component related filters > > > Diffs > - > > ambari-web/app/controllers/global/update_controller.js 98f528f > ambari-web/app/controllers/main/host.js cea40cb > > Diff: https://reviews.apache.org/r/50014/diff/ > > > Testing > --- > > Manually tested on live cluster, all unit tests passed. > 29021 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 50013: Deleting the selected llap queue breaks the UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50013/#review142176 --- Ship it! Ship It! - Zhe (Joe) Wang On July 14, 2016, 12:41 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50013/ > --- > > (Updated July 14, 2016, 12:41 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-17701 > https://issues.apache.org/jira/browse/AMBARI-17701 > > > Repository: ambari > > > Description > --- > > Steps to reproduce. > 1. Enable Interactive Query and Select llap as the queue. > 2. In the YARN CS view. Delete the LLAP queue. Add a testqueue at the same > level as root. (rootCap=20, testQueueCap=80). Create sub-queues under > testQuee -> Leaf1 (80), Leaf2(20). > 3. Go back to the Hive Smart config page. > Actual Result: The combobox shows warning but does not show other options > which are valid values > > > Diffs > - > > ambari-web/app/messages.js ce3177f > ambari-web/app/views/common/configs/widgets/combo_config_widget_view.js > ce9de0e > > Diff: https://reviews.apache.org/r/50013/diff/ > > > Testing > --- > > Verified that patch fixes the issue on the cluster. Attached snapshots to the > ticket. > ambari-web unit tests passes successfully with the patch: > 28956 tests complete (30 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 49931: AMBARI-17663 - Hosts page: JS error when sorting
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49931/#review141803 --- Ship it! Ship It! - Zhe (Joe) Wang On July 11, 2016, 11:42 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49931/ > --- > > (Updated July 11, 2016, 11:42 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang and Xi Wang. > > > Bugs: AMBARI-17663 > https://issues.apache.org/jira/browse/AMBARI-17663 > > > Repository: ambari > > > Description > --- > > Fix undefined reference. > > > Diffs > - > > ambari-web/app/views/common/sort_view.js bbb6004 > > Diff: https://reviews.apache.org/r/49931/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 29018 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Review Request 49727: AMBARI-17598 Permission mismatch b/w 'Cluster user' and 'read only user' from older ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49727/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17598 https://issues.apache.org/jira/browse/AMBARI-17598 Repository: ambari Description --- In ambari 2.2.2 "Show only my widgets" check box was not shown for 'read only' user. But in ambari-2.4.0, cluster user is being shown with this particular checkbox. Steps to reproduce : 1) Create a cluster user. 2) Login as cluster user. 3) Go to browse widget. 4) Check that "Show only my widgets" is not shown for cluster user. Since 'read only user' in ambari 2.2.2 corresponds to the cluster user in 2.4.0, even the permissions should remain intact. Diffs - ambari-web/app/templates/common/modal_popups/widget_browser_footer.hbs 3d58948 ambari-web/app/templates/common/modal_popups/widget_browser_popup.hbs 2b94e9d Diff: https://reviews.apache.org/r/49727/diff/ Testing --- Local ambari-web test passed. 28944 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 49677: YARN Summary Panel shows ResourceManager heap incorrectly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49677/#review140923 --- Ship it! Ship It! - Zhe (Joe) Wang On July 6, 2016, 1:13 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49677/ > --- > > (Updated July 6, 2016, 1:13 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang and Xi Wang. > > > Bugs: AMBARI-17574 > https://issues.apache.org/jira/browse/AMBARI-17574 > > > Repository: ambari > > > Description > --- > > Use correct template. > > > Diffs > - > > ambari-web/app/messages.js dcf0426 > ambari-web/app/views/main/service/services/yarn.js 7ccbfcf > > Diff: https://reviews.apache.org/r/49677/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 28941 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 49664: HDFS Summary Panel is not showing the NameNode heap size correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49664/#review140893 --- Ship it! Ship It! - Zhe (Joe) Wang On July 5, 2016, 11:10 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49664/ > --- > > (Updated July 5, 2016, 11:10 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang and Xi Wang. > > > Bugs: AMBARI-17572 > https://issues.apache.org/jira/browse/AMBARI-17572 > > > Repository: ambari > > > Description > --- > > Fix parameter name. > > > Diffs > - > > ambari-web/app/views/main/service/services/hdfs.js 4bc2cce > > Diff: https://reviews.apache.org/r/49664/diff/ > > > Testing > --- > > Manually tested on live cluster. All unit tests passed. > > 28941 tests complete (30 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 49645: With wire-encryption enabled, quick links in ambari UI points to incorrect atlas web url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49645/#review140870 --- Ship it! Ship It! - Zhe (Joe) Wang On July 5, 2016, 6:42 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49645/ > --- > > (Updated July 5, 2016, 6:42 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17565 > https://issues.apache.org/jira/browse/AMBARI-17565 > > > Repository: ambari > > > Description > --- > > With wire-encryption enabled, quick links in ambari UI points to incorrect > atlas web url. > > Currently ambari points to http://:21000/. where as > wire-encryption enabled atlas runs on port 21443, so the correct url is > https://:21443/. > > > The issue occured becaue the property deciding Atlas to be configured for > HTTPS or not was renamed from metadata.enableTLS to atlas.enableTLS > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml > 88c1915 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/quicklinks/quicklinks.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/49645/diff/ > > > Testing > --- > > Tested manually on a cluster that patch fixes the issue. > The patch only includes metadata changes in the Atlas stack definitions and > so does not require unit tests. > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 49126: AMBARI-17388 - Add Service Wizard stuck on Customize Services step
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49126/#review139192 --- Ship it! Ship It! - Zhe (Joe) Wang On June 23, 2016, 12:34 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49126/ > --- > > (Updated June 23, 2016, 12:34 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17388 > https://issues.apache.org/jira/browse/AMBARI-17388 > > > Repository: ambari > > > Description > --- > > Add null check. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7_controller.js 3211974 > > Diff: https://reviews.apache.org/r/49126/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit test passed. > 28972 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Review Request 49124: AMBARI-17387 Changing HDP repo URL does not leads to sending written URL to ambari-server while registering new HDP version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49124/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17387 https://issues.apache.org/jira/browse/AMBARI-17387 Repository: ambari Description --- STR: Deploy cluster HDP 2.3 Register HDP 2.5.0.0 latest (e.g 2.5.0.0-664) Try to register 2.5.0.0, but with other URL (e.g for HDP 2.5.0.0-569) Result: internal server error " Base url http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-664 is already defined for another repository version" But in this case we were trying to register http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-569 Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 6cf6849 ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js f896c02 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 1131041 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html ea577f6 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 6268030 Diff: https://reviews.apache.org/r/49124/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.128 secs / 0.378 secs) Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 48998: AMBARI-17326 - Mark the role "(from group)" if there is no specific user level role set.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48998/#review138885 --- Ship it! Ship It! - Zhe (Joe) Wang On June 21, 2016, 2:38 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48998/ > --- > > (Updated June 21, 2016, 2:38 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17326 > https://issues.apache.org/jira/browse/AMBARI-17326 > > > Repository: ambari > > > Description > --- > > Mark the role "(from group)" if there is no specific user level role set. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > b4138b3 > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html > c0f6144 > > Diff: https://reviews.apache.org/r/48998/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > > Thanks, > > Richard Zang > >
Re: Review Request 48888: AMBARI-17305 - Local User not displaying in View All option in Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review138354 --- Ship it! Ship It! - Zhe (Joe) Wang On June 17, 2016, 11:37 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4/ > --- > > (Updated June 17, 2016, 11:37 p.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17305 > https://issues.apache.org/jira/browse/AMBARI-17305 > > > Repository: ambari > > > Description > --- > > JWT type will be supported from 2.4 so remove support flag. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 39a8e9c > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js > 6318814 > > Diff: https://reviews.apache.org/r/4/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.13 secs / 0.379 secs) > > > Thanks, > > Richard Zang > >
Review Request 48834: AMBARI-17289 VDF: UI Edits #2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48834/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17289 https://issues.apache.org/jira/browse/AMBARI-17289 Repository: ambari Description --- The CSS styling for Name on Register Version cleanup Diffs - ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 542177d ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html e7bf01d Diff: https://reviews.apache.org/r/48834/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.15 secs / 0.358 secs) Manual testing done Thanks, Zhe (Joe) Wang
Re: Review Request 48831: UI: 'llap' queue is not shown in dropdown even though recommendation says so. Shows 'llap' queue after save.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48831/#review138133 --- Ship it! Ship It! - Zhe (Joe) Wang On June 17, 2016, 12:30 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48831/ > --- > > (Updated June 17, 2016, 12:30 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-17287 > https://issues.apache.org/jira/browse/AMBARI-17287 > > > Repository: ambari > > > Description > --- > > This issue happens because even though options of configs are updated from > stack advisor response, options of combobox widget view are not updated > dynamically after the view is rendered once. > > > Diffs > - > > ambari-web/app/views/common/configs/widgets/combo_config_widget_view.js > 14504ae > > Diff: https://reviews.apache.org/r/48831/diff/ > > > Testing > --- > > Verified that patch fixes the issue on a cluster. > Verified that ambar-web unit tests passes successfully: > 28633 tests complete (29 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 48830: AMBARI-17288 Redundant element on create version page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48830/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. Bugs: AMBARI-17288 https://issues.apache.org/jira/browse/AMBARI-17288 Repository: ambari Description --- Redundant element on create version page Diffs - ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html e7bf01d Diff: https://reviews.apache.org/r/48830/diff/ Testing --- ambari-admin: Executed 76 of 76 SUCCESS (0.121 secs / 0.368 secs) Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 48827: AMBARI-17286 Service config links should use public host name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48827/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. Bugs: AMBARI-17286 https://issues.apache.org/jira/browse/AMBARI-17286 Repository: ambari Description --- Service config links (e.g. tez.tez-ui.history-url.base) need to use the Ambari server's public name / IP instead of the private one. (Since tez.tez-ui.history-url.base is used to navigate from RM UI to Tez View.) Diffs - ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 038a6c3 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py c32306d ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 318f184 ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 1bd385f Diff: https://reviews.apache.org/r/48827/diff/ Testing --- Unit tests for stack advisor passed Total run:162 Total errors:0 Total failures:0 OK Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48809: AMBARI-17266 - StackDeploys: Suse: after enabling ranger plugin save button is always present
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48809/#review138070 --- Ship it! Ship It! - Zhe (Joe) Wang On June 16, 2016, 7:23 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48809/ > --- > > (Updated June 16, 2016, 7:23 p.m.) > > > Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. > > > Bugs: AMBARI-17266 > https://issues.apache.org/jira/browse/AMBARI-17266 > > > Repository: ambari > > > Description > --- > > This issue is caused by mergeWithStackProperties creating extra config with > attribute isNotSaved=true > Filter out 'test-db-connection' since it's only related to enhanced config > theme. > > > Diffs > - > > ambari-web/app/utils/config.js 840e3c2 > > Diff: https://reviews.apache.org/r/48809/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 28635 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 48709: Nothing shows on the role section when user has the same role as its group
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48709/#review137598 --- Ship it! Ship It! - Zhe (Joe) Wang On June 14, 2016, 10:39 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48709/ > --- > > (Updated June 14, 2016, 10:39 p.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17239 > https://issues.apache.org/jira/browse/AMBARI-17239 > > > Repository: ambari > > > Description > --- > > Only show highest role. Fix ng-repeat usage to avoid error caused by > duplicated items. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersShowCtrl.js > 69a15bd > ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html > 18df5fa > > Diff: https://reviews.apache.org/r/48709/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > PhantomJS 1.9.7 (Mac OS X): Executed 76 of 76 SUCCESS (0.191 secs / 0.409 > secs) > > > Thanks, > > Richard Zang > >
Review Request 48698: AMBARI-17230 VDF: when registering version using Default Vers Def, need to set Name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48698/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17230 https://issues.apache.org/jira/browse/AMBARI-17230 Repository: ambari Description --- When Registering a Version (in Admin UI), will need way to set the Name when using the Default Version Definition. This is for backwards compat, plus since the user might use the Default Version Def multiple times (in cases they don't have a VDF). Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js cc42abb ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js 26b3558 ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 7e76859 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 83f54fd Diff: https://reviews.apache.org/r/48698/diff/ Testing --- ambari-admin: Executed 71 of 71 SUCCESS (0.164 secs / 0.379 secs) Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48569: On Enabling HS Interactive default queue shown for llap is 'default' queue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48569/#review137090 --- Ship it! Ship It! - Zhe (Joe) Wang On June 11, 2016, 12:07 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48569/ > --- > > (Updated June 11, 2016, 12:07 a.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-17175 > https://issues.apache.org/jira/browse/AMBARI-17175 > > > Repository: ambari > > > Description > --- > > 1. Deploy ambari secure cluster > 2. Enable HSI > Expected: llap queue is created by ambari and is set as default for llap > Actual: ldap queue is not created and default queue is set for ldap > > > Diffs > - > > ambari-web/app/views/common/configs/widgets/combo_config_widget_view.js > 0bf05f6 > > Diff: https://reviews.apache.org/r/48569/diff/ > > > Testing > --- > > Verified that the patch fixes the issue on a cluster > ambari-web unit tests passes successfully with the patch: > 28668 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 48568: AMBARI-17176 VDF: include default version definition in list, even if Internet Access is available
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48568/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17176 https://issues.apache.org/jira/browse/AMBARI-17176 Repository: ambari Description --- We need to include the Default Version Definition in the list of dropdown Versions along with the discovered versions. Current experience: we only include Default if we believe we do not have internet access New experience: include Default in the list regardless of internet or not. This is for backwards compatibility, and in the case where the user "just does not know" their version (and therefore, needs Ambari to just figure it out best it can). Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 5433bd6 ambari-web/app/controllers/wizard/step1_controller.js 3af28de ambari-web/app/templates/wizard/step1.hbs 59ff21b Diff: https://reviews.apache.org/r/48568/diff/ Testing --- ambari-web: 28670 tests complete (24 seconds) 154 tests pending ambari-admin: Executed 71 of 71 SUCCESS (0.142 secs / 0.356 secs) Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/#review136917 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 10:24 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48517/ > --- > > (Updated June 9, 2016, 10:24 p.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17154 > https://issues.apache.org/jira/browse/AMBARI-17154 > > > Repository: ambari > > > Description > --- > > Fix warning text > > > Diffs > - > > ambari-web/app/messages.js 6c25357 > > Diff: https://reviews.apache.org/r/48517/diff/ > > > Testing > --- > > Manually tested on live cluster. > > All unit tests passed. > > 28649 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48456/#review136850 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 1:49 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48456/ > --- > > (Updated June 9, 2016, 1:49 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17134 > https://issues.apache.org/jira/browse/AMBARI-17134 > > > Repository: ambari > > > Description > --- > > Add support flag for user type 'JWT' > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/app.js 47b87c4 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersListCtrl.js > 4eb3633 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/users/UsersListCtrl.js > 3c5e7b2 > > Diff: https://reviews.apache.org/r/48456/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.12 secs / 0.368 secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 48451: AMBARI-17132 - Typing the whole component name vs selecting drop down filter in hosts page gives 2 different results
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48451/#review136734 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 12:09 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48451/ > --- > > (Updated June 9, 2016, 12:09 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17132 > https://issues.apache.org/jira/browse/AMBARI-17132 > > > Repository: ambari > > > Description > --- > > Add facet validation check before search > > > Diffs > - > > ambari-web/app/messages.js 02da1f6 > ambari-web/app/templates/main/host/combo_search_box.hbs 6ff9640 > ambari-web/app/views/main/host/combo_search_box.js c6ac3bd > > Diff: https://reviews.apache.org/r/48451/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 28664 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Review Request 48382: AMBARI-17101 Select Stack Page : "Next" button disabled for blank repo fields
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48382/ --- Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17101 https://issues.apache.org/jira/browse/AMBARI-17101 Repository: ambari Description --- 1. Provide better regex and checking. Make it more clear to handle blanks and bad URLs (missing protocol, etc) 2. Treat blank entries as removed, when the user hits Next, as long as they complete ONE OS (or choose Satellite). Diffs - ambari-web/app/controllers/installer.js 251daad ambari-web/app/messages.js 2ea1560 ambari-web/app/models/operating_system.js 31f8922 ambari-web/app/models/repository.js 6fc5731 ambari-web/app/templates/wizard/step1.hbs 4eaef8e ambari-web/app/utils/validator.js d29a6bb ambari-web/app/views/wizard/step1_view.js efdae76 ambari-web/test/controllers/installer_test.js e799467 ambari-web/test/utils/validator_test.js f70d1ba ambari-web/test/views/wizard/step1_view_test.js 3621aa9 Diff: https://reviews.apache.org/r/48382/diff/ Testing --- Modified unit test. Local ambari-web test passed. 28665 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48361: VDF: install wizard "Select Version" UI issues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48361/#review136541 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 9:08 p.m., Xi Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48361/ > --- > > (Updated June 7, 2016, 9:08 p.m.) > > > Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, and Yusaku Sako. > > > Bugs: AMBARI-17022 > https://issues.apache.org/jira/browse/AMBARI-17022 > > > Repository: ambari > > > Description > --- > > Fixed several issues in Installer wizard step 1 when selecting version. > > > Diffs > - > > ambari-web/app/models/stack.js df217f2 > ambari-web/app/styles/application.less 5ee09cc > ambari-web/app/styles/common.less 738edce > > Diff: https://reviews.apache.org/r/48361/diff/ > > > Testing > --- > > 28646 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Xi Wang > >
Re: Review Request 48306: AMBARI-17077 - Unable to change user role in list view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48306/#review136498 --- Ship it! Ship It! - Zhe (Joe) Wang On June 7, 2016, 2:29 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48306/ > --- > > (Updated June 7, 2016, 2:29 a.m.) > > > Review request for Ambari and Zhe (Joe) Wang. > > > Bugs: AMBARI-17077 > https://issues.apache.org/jira/browse/AMBARI-17077 > > > Repository: ambari > > > Description > --- > > Fix role update logic > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js > cd72ca6 > > Diff: https://reviews.apache.org/r/48306/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > PhantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.151 secs / 0.399 > secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 48296: AMBARI-17073 HDF Management install does not allow one to select public repo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48296/ --- (Updated June 7, 2016, 12:36 a.m.) Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17073 https://issues.apache.org/jira/browse/AMBARI-17073 Repository: ambari Description --- To fulfill the requirement of enforcing users to choose local repo when they don’t have internet access, in FE we use the logic of checking whether all versions are stack_default versions. That logic is true for HDP for now, but not for HDF. Diffs (updated) - ambari-web/app/messages.js e8ca9ae ambari-web/app/templates/wizard/step1.hbs 72a2099 ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs 25cf49f ambari-web/app/views/wizard/step1_view.js 503d5ef Diff: https://reviews.apache.org/r/48296/diff/ Testing --- Local ambari-web test passed. 28646 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/ --- (Updated June 6, 2016, 6:22 p.m.) Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-10908 https://issues.apache.org/jira/browse/AMBARI-10908 Repository: ambari Description --- On Hosts page, provide ability to delete hosts in bulk. Diffs (updated) - ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 ambari-web/app/messages.js e8ca9ae ambari-web/app/styles/application.less 5ee09cc ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs PRE-CREATION ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs PRE-CREATION ambari-web/app/utils/ajax/ajax.js 195dab4 ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 Diff: https://reviews.apache.org/r/48289/diff/ Testing --- Local ambari-web test passed. 28648 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 48289: AMBARI-10908 Usability: ability to perform bulk delete host
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48289/ --- Review request for Ambari, Ajit Kumar, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-10908 https://issues.apache.org/jira/browse/AMBARI-10908 Repository: ambari Description --- On Hosts page, provide ability to delete hosts in bulk. Diffs - ambari-web/app/controllers/main/host/bulk_operations_controller.js 09d6a52 ambari-web/app/messages.js ffc6eb2 ambari-web/app/styles/application.less 5ee09cc ambari-web/app/templates/main/host/delete_hosts_dry_run_popup.hbs PRE-CREATION ambari-web/app/templates/main/host/delete_hosts_popup.hbs PRE-CREATION ambari-web/app/templates/main/host/delete_hosts_result_popup.hbs PRE-CREATION ambari-web/app/utils/ajax/ajax.js 195dab4 ambari-web/app/views/main/host/hosts_table_menu_view.js 5e4b0e0 Diff: https://reviews.apache.org/r/48289/diff/ Testing --- Local ambari-web test passed. 28648 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48177: AMBARI-17016 Removing OS doesn't work
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48177/ --- (Updated June 2, 2016, 11:05 p.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17016 https://issues.apache.org/jira/browse/AMBARI-17016 Repository: ambari Description --- Install a cluster. Remove some OSes on step1 of installer. Once the installation is finished, when you go to edit repo page or ambari admin versions page, and try to edit the version, you will see the removed OS. Diffs (updated) - ambari-web/app/controllers/installer.js ed1e2c1 Diff: https://reviews.apache.org/r/48177/diff/ Testing --- Local ambari-web test passed. 28632 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48185: Enabling interactive query in kerberized cluster after re-login results in HS2 interactive installation failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48185/#review135992 --- Ship it! Ship It! - Zhe (Joe) Wang On June 2, 2016, 8:44 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48185/ > --- > > (Updated June 2, 2016, 8:44 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-16996 > https://issues.apache.org/jira/browse/AMBARI-16996 > > > Repository: ambari > > > Description > --- > > #Steps to Reproduce: > 1. Install a cluster with hive > 2. Kerberize the cluster > 3. Log out of the cluster > 4. Log in back to the cluster > 5. Enable interactive query for hive service. > 6. Save configurations for Hive service > > *Expected Result*: On saving configurations, HS2 interactive and other > dependencies are installed and started successfully > *Actual Result*: On saving configurations, HS2 interactive install task fails > > > The failure happens because of missing KDC credentials. As part of the fix > when selecting HS2 interactive host if KDC credentials are missing then the > generic popup for "Missing KDC credentials" will be shown and user is > expected to enter the credential. > > > Diffs > - > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js cf04bf2 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > d453ded > > Diff: https://reviews.apache.org/r/48185/diff/ > > > Testing > --- > > Verified that the patch fixes the issue. > ambari-web unit tests passes with the fix: > > 28644 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 48177: AMBARI-17016 Removing OS doesn't work
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48177/ --- (Updated June 2, 2016, 6:30 p.m.) Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17016 https://issues.apache.org/jira/browse/AMBARI-17016 Repository: ambari Description --- Install a cluster. Remove some OSes on step1 of installer. Once the installation is finished, when you go to edit repo page or ambari admin versions page, and try to edit the version, you will see the removed OS. Diffs (updated) - ambari-web/app/controllers/installer.js 36dcfb3 ambari-web/app/utils/db.js a4e96a0 Diff: https://reviews.apache.org/r/48177/diff/ Testing --- Local ambari-web test passed. 28632 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 48177: AMBARI-17016 Removing OS doesn't work
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48177/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-17016 https://issues.apache.org/jira/browse/AMBARI-17016 Repository: ambari Description --- Install a cluster. Remove some OSes on step1 of installer. Once the installation is finished, when you go to edit repo page or ambari admin versions page, and try to edit the version, you will see the removed OS. Diffs - ambari-web/app/controllers/installer.js 36dcfb3 ambari-web/app/utils/db.js a4e96a0 Diff: https://reviews.apache.org/r/48177/diff/ Testing --- Local ambari-web test passed. 28632 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 48156: Misc fixes related to slider while enabling interactive query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135880 --- Ship it! Ship It! - Zhe (Joe) Wang On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48156/ > --- > > (Updated June 1, 2016, 9:36 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-16993 > https://issues.apache.org/jira/browse/AMBARI-16993 > > > Repository: ambari > > > Description > --- > > *Scenario 1:* > # Install a Ambari-2.2.2 cluster with hive service > # Upgrade to Ambari-2.4.0 > # Enable interactive query. A popup asking to install slider service first > will be shown. Also recommendations for enable interactive query are shown in > the bg > # Dismiss the popup. This again disables interactive query > > *Actual behavior:* Recommendations for enabled interactive query remains > *Expected behavior:* Since interactive query is again disabled, > recommendations for enabled interactive query should go away. > > > *Scenario 2:* > # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider > client on 2 out of 3 hosts. > # Enable interactive query. Select a host on which slider client is absent > for HS2 interactive. > # Save configurations > > *Actual behavior:* Install components request has tasks to installs Slider > client on all 3 hosts > *Expected behavior:* Install components request should install Slider client > only on 1 host (HS2 interactive host) > > > Diffs > - > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 0907aa7 > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js > df2f70b > > Diff: https://reviews.apache.org/r/48156/diff/ > > > Testing > --- > > Verifies that the patch resolves both the stated issues > ambari-web unit tests with the patch: > 28524 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 48156: Misc fixes related to slider while enabling interactive query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135868 --- ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js (line 152) <https://reviews.apache.org/r/48156/#comment200892> Typo? - Zhe (Joe) Wang On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48156/ > --- > > (Updated June 1, 2016, 9:36 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-16993 > https://issues.apache.org/jira/browse/AMBARI-16993 > > > Repository: ambari > > > Description > --- > > *Scenario 1:* > # Install a Ambari-2.2.2 cluster with hive service > # Upgrade to Ambari-2.4.0 > # Enable interactive query. A popup asking to install slider service first > will be shown. Also recommendations for enable interactive query are shown in > the bg > # Dismiss the popup. This again disables interactive query > > *Actual behavior:* Recommendations for enabled interactive query remains > *Expected behavior:* Since interactive query is again disabled, > recommendations for enabled interactive query should go away. > > > *Scenario 2:* > # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider > client on 2 out of 3 hosts. > # Enable interactive query. Select a host on which slider client is absent > for HS2 interactive. > # Save configurations > > *Actual behavior:* Install components request has tasks to installs Slider > client on all 3 hosts > *Expected behavior:* Install components request should install Slider client > only on 1 host (HS2 interactive host) > > > Diffs > - > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 0907aa7 > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js > df2f70b > > Diff: https://reviews.apache.org/r/48156/diff/ > > > Testing > --- > > Verifies that the patch resolves both the stated issues > ambari-web unit tests with the patch: > 28524 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 48156: Misc fixes related to slider while enabling interactive query
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48156/#review135867 --- ambari-web/app/controllers/wizard/step7/assign_master_controller.js (line 161) <https://reviews.apache.org/r/48156/#comment200891> Typo? - Zhe (Joe) Wang On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48156/ > --- > > (Updated June 1, 2016, 9:36 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-16993 > https://issues.apache.org/jira/browse/AMBARI-16993 > > > Repository: ambari > > > Description > --- > > *Scenario 1:* > # Install a Ambari-2.2.2 cluster with hive service > # Upgrade to Ambari-2.4.0 > # Enable interactive query. A popup asking to install slider service first > will be shown. Also recommendations for enable interactive query are shown in > the bg > # Dismiss the popup. This again disables interactive query > > *Actual behavior:* Recommendations for enabled interactive query remains > *Expected behavior:* Since interactive query is again disabled, > recommendations for enabled interactive query should go away. > > > *Scenario 2:* > # Install a 3 host Ambari-2.4.0 cluster with hive service. Install slider > client on 2 out of 3 hosts. > # Enable interactive query. Select a host on which slider client is absent > for HS2 interactive. > # Save configurations > > *Actual behavior:* Install components request has tasks to installs Slider > client on all 3 hosts > *Expected behavior:* Install components request should install Slider client > only on 1 host (HS2 interactive host) > > > Diffs > - > > ambari-web/app/controllers/wizard/step7/assign_master_controller.js c0654a8 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 0907aa7 > ambari-web/test/controllers/wizard/step7/assign_master_controller_test.js > df2f70b > > Diff: https://reviews.apache.org/r/48156/diff/ > > > Testing > --- > > Verifies that the patch resolves both the stated issues > ambari-web unit tests with the patch: > 28524 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 48105: AMBARI-16977 VDF: couple UI bugs in Install Wiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48105/ --- Review request for Ambari, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16977 https://issues.apache.org/jira/browse/AMBARI-16977 Repository: ambari Description --- Fix bugs in the case that public repo is unavailable. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css a8539e8 ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 6134535 ambari-web/app/controllers/wizard/step1_controller.js b648b82 ambari-web/app/messages.js 8bea8e8 ambari-web/app/styles/application.less 8a76dfb ambari-web/app/templates/wizard/step1.hbs e076d66 ambari-web/test/controllers/wizard/step1_test.js 01344cb Diff: https://reviews.apache.org/r/48105/diff/ Testing --- ambari-web: 28447 tests complete (24 seconds) 154 tests pending ambari-admin: Executed 71 of 71 SUCCESS (0.113 secs / 0.361 secs) Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 48089: AMBARI-16972 Strange behavior of Add Version functionality
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48089/ --- Review request for Ambari, Aleksandr Kovalenko, Jaimin Jetly, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16972 https://issues.apache.org/jira/browse/AMBARI-16972 Repository: ambari Description --- STR: 1. Install cluster. 2. Go to Manage Ambari > Versions > Register Version. 3. Click Add Version for HDP-2.5, type URL for some version (for example http://s3.amazonaws.com/dev.hortonworks.com/HDP/centos6/2.x/BUILDS/2.5.0.0-427/HDP-2.5.0.0-427.xml) and click Add Version Info. As a result version from VDF file will be loaded as selected, but if you open select box you will see current installed version and HDP-2.5 (Default Version Definition) instead of version, that you typed. If you will add version with the same VDF file, it will be added. But what is HDP-2.5 (Default Version Definition) and why it appears in combo box after first version adding. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js 0af7004 Diff: https://reviews.apache.org/r/48089/diff/ Testing --- ambari-admin: Executed 71 of 71 SUCCESS (0.13 secs / 0.35 secs) Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 47993: VDF: support for selecting enabled + default Stacks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47993/#review135348 --- Ship it! Ship It! - Zhe (Joe) Wang On May 27, 2016, 11:14 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47993/ > --- > > (Updated May 27, 2016, 11:14 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. > > > Bugs: AMBARI-16940 > https://issues.apache.org/jira/browse/AMBARI-16940 > > > Repository: ambari > > > Description > --- > > The work revamps the UX for leveraging VDF(Version Definition File) feature > of ambari. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js > 47b72e6 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js > 22ec5ae > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js > 3a8233a > ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js > 2d51ece > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/ConfirmationModal.js > 4576a40 > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js > 96f9c9f > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Utility.js > PRE-CREATION > ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4434908 > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/ConfirmationModal.html > b11f6bb > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/publicRepoDisabled.html > PRE-CREATION > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html > 3de92c1 > > ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html > f3f2d86 > ambari-web/app/assets/test/tests.js c654dac > ambari-web/app/controllers/installer.js 43a5e4a > ambari-web/app/controllers/wizard/step0_controller.js aa3541a > ambari-web/app/controllers/wizard/step1_controller.js 3eb5d1b > ambari-web/app/controllers/wizard/step3_controller.js 38bb5d7 > ambari-web/app/controllers/wizard/step4_controller.js 0575f07 > ambari-web/app/controllers/wizard/step7_controller.js c3b98b5 > ambari-web/app/mappers/stack_mapper.js ab1d6a8 > ambari-web/app/messages.js 29ca44c > ambari-web/app/models/repository.js 8ad20ce > ambari-web/app/models/stack.js 6023566 > ambari-web/app/models/stack_version/service_simple.js 13ca381 > ambari-web/app/routes/installer.js b8b9532 > ambari-web/app/styles/application.less 32c88fd > ambari-web/app/styles/common.less 326d404 > ambari-web/app/templates/wizard/step1.hbs 56c62a2 > > ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs > PRE-CREATION > ambari-web/app/templates/wizard/step1/vdf_upload.hbs PRE-CREATION > ambari-web/app/utils/array_utils.js 643ed67 > ambari-web/app/views/wizard/step1_view.js a7af383 > ambari-web/karma.conf.js 1a03381 > ambari-web/test/controllers/installer_test.js 303c8a4 > ambari-web/test/controllers/wizard/step1_test.js PRE-CREATION > ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js > 8572772 > ambari-web/test/utils/array_utils_test.js ec7c5d8 > ambari-web/test/views/common/host_progress_popup_body_view_test.js 282d31c > ambari-web/test/views/wizard/step1_view_test.js 070cb59 > > Diff: https://reviews.apache.org/r/47993/diff/ > > > Testing > --- > > Tested ambari-web and ambari-admin view manually: > Verified that unit tests for ambari-web and ambari-admin passes successfully > > ambari-web: > 27900 tests complete (29 seconds) > 154 tests pending > > ambari-admin: > phantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.467 secs / 0.454 > secs) > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/ --- (Updated May 18, 2016, 6:24 p.m.) Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16723 https://issues.apache.org/jira/browse/AMBARI-16723 Repository: ambari Description --- For default stacks, stack id contains stack name and stack version, while for others, it should be "stack + "-" + stack_version + "-" + vdf_version" Diffs (updated) - ambari-web/app/controllers/installer.js 421f2dc ambari-web/app/mappers/stack_mapper.js 473c466 Diff: https://reviews.apache.org/r/47513/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47523/ --- Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16725 https://issues.apache.org/jira/browse/AMBARI-16725 Repository: ambari Description --- RECOVERY alert types do not have a connection timeout, therefore, this should not be shown in the UI (and not have an error because it's blank). Diffs - ambari-web/app/controllers/main/alerts/definition_configs_controller.js 617f7cc Diff: https://reviews.apache.org/r/47523/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (24 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 47517: AMBARI-16724 Allow customizing Connection Timeout for METRIC Alerts
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47517/
---
(Updated May 18, 2016, 6:09 a.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-16724
https://issues.apache.org/jira/browse/AMBARI-16724
Repository: ambari
Description
---
METRIC alert types have a connection timeout in their definition but that value
is not exposed in the Ambari Web UI (like WEB alerts are).
"uri" : {
"http" : "{{ams-hbase-site/hbase.master.info.port}}",
"default_port" : 61310.0,
"connection_timeout" : 5.0
}
Include exposing the Connection Timeout critical threshold in Ambari Web for
METRIC alert types.
Diffs
-
ambari-web/app/controllers/main/alerts/definition_configs_controller.js
617f7cc
ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js
f3cf28c
Diff: https://reviews.apache.org/r/47517/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
27819 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47513/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16723 https://issues.apache.org/jira/browse/AMBARI-16723 Repository: ambari Description --- For default stacks, stack id contains stack name and stack version, while for others, it should be "stack + "-" + stack_version + "-" + vdf_version" Diffs - ambari-web/app/controllers/installer.js 421f2dc ambari-web/app/mappers/stack_mapper.js 473c466 Diff: https://reviews.apache.org/r/47513/diff/ Testing --- Local ambari-web test passed. 27819 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 47508: AMBARI-16721 - Host Filters : 'Alerts' value for 'HOST STATUS' filter is absent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47508/#review133698 --- Ship it! Ship It! - Zhe (Joe) Wang On May 18, 2016, 1:31 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47508/ > --- > > (Updated May 18, 2016, 1:31 a.m.) > > > Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. > > > Bugs: AMBARI-16721 > https://issues.apache.org/jira/browse/AMBARI-16721 > > > Repository: ambari > > > Description > --- > > Add "Alert" option back. Refactor existing filter logic. Move specific filter > logic out of common mixin. > > > Diffs > - > > ambari-web/app/controllers/main/host/combo_search_box.js 2fa4479 > ambari-web/app/data/host/categories.js 03e2fee > ambari-web/app/mixins/common/table_server_view_mixin.js 66f886a > ambari-web/app/views/main/host/combo_search_box.js caf200f > > Diff: https://reviews.apache.org/r/47508/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 27819 tests complete (33 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 47439: Enabling/Disabling interactive query should sustain browser refreshes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47439/#review133575
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 17, 2016, 12:57 a.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47439/
> ---
>
> (Updated May 17, 2016, 12:57 a.m.)
>
>
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-16696
> https://issues.apache.org/jira/browse/AMBARI-16696
>
>
> Repository: ambari
>
>
> Description
> ---
>
> #STR:#
> 1 Enable interactive query and save the hive configs
> 2 This will create requests that can be tracked in background ops
> 3 While a task "Restart LLAP" or "Install Components" is ongoing, Refresh
> the browser
>
> #Expected Result:# The ongoing request should be completed and subsequent
> requests ("Start HiveServer2 Interactive") should be triggered
> #Actual Result:# The ongoing request is completed but the subsequent request
> is not triggered.
>
>
> Diffs
> -
>
> ambari-web/app/controllers/main/host/details.js 374b077
> ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js
> 5e1eb50
> ambari-web/app/utils/ajax/ajax.js e7059e7
> ambari-web/app/utils/batch_scheduled_requests.js 7274fdc
>
> Diff: https://reviews.apache.org/r/47439/diff/
>
>
> Testing
> ---
>
> Verified manually that the patch addresses the issue on a cluster
> Verified that all ambari-web unit tests works:
>
> 27817 tests complete (31 seconds)
> 154 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 47422: AMBARI-16688: Ambari users page is not showing type for users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47422/#review133434 --- Ship it! Ship It! - Zhe (Joe) Wang On May 16, 2016, 7:08 p.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47422/ > --- > > (Updated May 16, 2016, 7:08 p.m.) > > > Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. > > > Bugs: AMBARI-16688 > https://issues.apache.org/jira/browse/AMBARI-16688 > > > Repository: ambari > > > Description > --- > > Login to ambari > Navigate to Users page > Add few users > Verify type is displayed for each User > Actual: Type is displayed as blank for users currently. > > > Diffs > - > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/User.js > c6765d0 > > Diff: https://reviews.apache.org/r/47422/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > PhantomJS 1.9.7 (Mac OS X): Executed 70 of 70 SUCCESS (0.502 secs / 0.499 > secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 47206: AMBARI-16441: RBAC UI Edits #6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47206/#review132589 --- Ship it! Ship It! - Zhe (Joe) Wang On May 11, 2016, 12:30 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47206/ > --- > > (Updated May 11, 2016, 12:30 a.m.) > > > Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. > > > Bugs: AMBARI-16441 > https://issues.apache.org/jira/browse/AMBARI-16441 > > > Repository: ambari > > > Description > --- > > Add help page popup on user listing page as well. > Add close button on help page header. > > > Diffs > - > > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/ClustersManageAccessCtrl.js > c92374b > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js > 32f46c1 > > ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RoleDetailsModal.js > eced664 > > ambari-admin/src/main/resources/ui/admin-web/app/views/clusters/userAccessList.html > e3bbcdc > > ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html > 74a1807 > > Diff: https://reviews.apache.org/r/47206/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > > PhantomJS 1.9.7 (Mac OS X): Executed 64 of 64 SUCCESS (0.211 secs / 0.418 > secs) > > > Thanks, > > Richard Zang > >
Re: Review Request 47152: AMBARI-16414: Clients are not present in Hosts filter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47152/#review132364 --- Ship it! Ship It! - Zhe (Joe) Wang On May 10, 2016, 1:45 a.m., Richard Zang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47152/ > --- > > (Updated May 10, 2016, 1:45 a.m.) > > > Review request for Ambari, Jaimin Jetly and Zhe (Joe) Wang. > > > Bugs: AMBARI-16414 > https://issues.apache.org/jira/browse/AMBARI-16414 > > > Repository: ambari > > > Description > --- > > Deploy a cluster with default configs for Ambari-2.4.0.0 > Navigate to Hosts Page > In the new filter there is no choice to filter a Client component > filtering client components was possible in old design of dropdown action > menu (Ambari-2.2.2 and earlier). After the page is redesigned, this feature > is missing. > > > Diffs > - > > ambari-web/app/views/main/host/combo_search_box.js 0b8c95b > > Diff: https://reviews.apache.org/r/47152/diff/ > > > Testing > --- > > Manually tested on live cluster. > All unit tests passed. > 27721 tests complete (31 seconds) > 154 tests pending > > > Thanks, > > Richard Zang > >
Re: Review Request 47139: Ranger issues on summary page and config page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47139/#review132348 --- Ship it! Ship It! - Zhe (Joe) Wang On May 9, 2016, 11:30 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47139/ > --- > > (Updated May 9, 2016, 11:30 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16409 > https://issues.apache.org/jira/browse/AMBARI-16409 > > > Repository: ambari > > > Description > --- > > # Ranger Admin Tab shows incorrect red badge with 1 error count > # Ranger summary page shows Kafka plugin status twice > > > Diffs > - > > ambari-web/app/controllers/main/service/info/summary.js 3a71cb3 > ambari-web/app/models/configs/objects/service_config_property.js 24f648b > > Diff: https://reviews.apache.org/r/47139/diff/ > > > Testing > --- > > Verified that patch resolves the issues on cluster > Verified that ambari-web unit tests passes with the patch: > 27721 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 47079: Disabling and enabling back HiveServer2 Interactive does not show Assign Master popup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47079/#review132112 --- Ship it! Ship It! - Zhe (Joe) Wang On May 6, 2016, 10:34 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47079/ > --- > > (Updated May 6, 2016, 10:34 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16294 > https://issues.apache.org/jira/browse/AMBARI-16294 > > > Repository: ambari > > > Description > --- > > *STR:* > # Deploy a cluster with Hive service and Interactive query enabled > # Post deployment navigate to Hive service config page and Disable > interactive query > # Wait for all operations to complete > # Enable it again > > *Expected Result:* UI should show "Assign Master" popup for HSI selection > *Actual Result:* UI does not show assign master popup and takes the previous > selection of the HSI > > *Reason of the bug:* App.HostComponent model is not updated on the service > summary/config pages. So although HSI is deleted on disabling interactive > query on server, UI does not know about this via App.HostComponent model > > > Diffs > - > > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 93cac29 > > Diff: https://reviews.apache.org/r/47079/diff/ > > > Testing > --- > > Manually verified that patch resolves the issue > Verified that ambari-web unit tests passes with the patch: > 27718 tests complete (36 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Review Request 47047: AMBARI-16282 Refactor the VDF installer code to handle multi-stack and multi-version scenario
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47047/ --- Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16282 https://issues.apache.org/jira/browse/AMBARI-16282 Repository: ambari Description --- Current code assumes that there is only one stack and one public version situation. We need to handle multi-stack and multi-version scenario, while some stacks have no public version. Diffs - ambari-web/app/controllers/installer.js 369e319 ambari-web/app/mappers/stack_mapper.js a430ea5 ambari-web/app/views/wizard/step1_view.js 96dcf39 ambari-web/test/mappers/stack_mapper_test.js 63f7516 Diff: https://reviews.apache.org/r/47047/diff/ Testing --- Modified unit test. Local ambari-web test passed. 27718 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Review Request 46998: AMBARI-16264 Clean up local DB when get back to step 0 of installer wizard
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46998/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Bugs: AMBARI-16264 https://issues.apache.org/jira/browse/AMBARI-16264 Repository: ambari Description --- After setting some options and then go back and next, all user inputs should be reset to default values, but now some settings are restored and some are reset. For example try to enable Skip Repository Base URL validation (Advanced) and Use RedHat Satellite/Spacewalk checkboxes, then go back and next and you will see, that first checkbox is still checked and second one is unchecked, this is confusing. Diffs - ambari-web/app/controllers/wizard/step1_controller.js dc95a45 ambari-web/app/routes/installer.js f280049 Diff: https://reviews.apache.org/r/46998/diff/ Testing --- Local ambari-web test passed. 27529 tests complete (23 seconds) 154 tests pending Manual testing done. Thanks, Zhe (Joe) Wang
Re: Review Request 46987: Show the connect string with the HiveServer instance
> On May 4, 2016, 8:04 p.m., Zhe (Joe) Wang wrote: > > The width of the field for this string seems be too small. I can only see > > "jdbc:hive2://c6402". > > Jaimin Jetly wrote: > Thats intentional as the string can be long depending upon zookeeper > quorom value. so it is ellipses with "...". However "copy to clipboard" > action is supposed to copy entire actual string. Yeah. That's what I figured may be. Makes sense. - Zhe (Joe) --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46987/#review131733 --- On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46987/ > --- > > (Updated May 4, 2016, 5:52 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16244 > https://issues.apache.org/jira/browse/AMBARI-16244 > > > Repository: ambari > > > Description > --- > > If Zookeeper based service discovery is used, then Hive summary page should > show JDBC connect string for HiveServer2 and HiveServer2 Interactive > instances. > The semantics for this will be > jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace= > > > Diffs > - > > LICENSE.txt f92b489 > ambari-web/app/assets/img/clippy.svg PRE-CREATION > ambari-web/app/controllers/global/configuration_controller.js 1f5675f > ambari-web/app/controllers/main/service/info/summary.js f1740a7 > ambari-web/app/messages.js c5e1145 > ambari-web/app/templates/main/service/services/hive.hbs 617f6ce > ambari-web/app/views/main/service/info/summary.js 7e0d0bb > ambari-web/app/views/main/service/services/hive.js c1a0f58 > ambari-web/test/views/main/service/services/hive_test.js a31ba62 > ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/46987/diff/ > > > Testing > --- > > Verified the patch to work manually. > Verified that ambari-web unit tests passes with the patch: > 27525 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 46987: Show the connect string with the HiveServer instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46987/#review131733 --- The width of the field for this string seems be too small. I can only see "jdbc:hive2://c6402". - Zhe (Joe) Wang On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46987/ > --- > > (Updated May 4, 2016, 5:52 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Richard Zang, and Srimanth Gunturi. > > > Bugs: AMBARI-16244 > https://issues.apache.org/jira/browse/AMBARI-16244 > > > Repository: ambari > > > Description > --- > > If Zookeeper based service discovery is used, then Hive summary page should > show JDBC connect string for HiveServer2 and HiveServer2 Interactive > instances. > The semantics for this will be > jdbc:hive2:///;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace= > > > Diffs > - > > LICENSE.txt f92b489 > ambari-web/app/assets/img/clippy.svg PRE-CREATION > ambari-web/app/controllers/global/configuration_controller.js 1f5675f > ambari-web/app/controllers/main/service/info/summary.js f1740a7 > ambari-web/app/messages.js c5e1145 > ambari-web/app/templates/main/service/services/hive.hbs 617f6ce > ambari-web/app/views/main/service/info/summary.js 7e0d0bb > ambari-web/app/views/main/service/services/hive.js c1a0f58 > ambari-web/test/views/main/service/services/hive_test.js a31ba62 > ambari-web/vendor/scripts/clipboard.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/46987/diff/ > > > Testing > --- > > Verified the patch to work manually. > Verified that ambari-web unit tests passes with the patch: > 27525 tests complete (27 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
