[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8681 ) Change subject: KUDU-1097: Implement a "safe eviction" policy .. Patch Set 2: (2 comments) > (2 comments) > > > Uploaded patch set 2: Patch Set 1 was rebased. > > I'm not sure we need this sort of logic in the new scheme: what > particular use case does it address? > > The only issue I see with the current logic is to allow evicting > failed non-voters, so we would not end up with dead non-voters in > all possible new locations. I take it back. The new scheme addresses the case when the newly added voters fail one after another. However, in addition to the update on CanEvictReplica() it was necessary to update the catalog manager's logic as well, swapping the order of calls to IsUnderReplicated() and CanEvictReplica(). http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@9 PS2, Line 9: We should respect the same kinds of policies for 3-4-3 eviction as we : use for 3-2-3 eviction as implemented in the SafeToEvict() function > Why? What sort of issue do you try to address with that? After some consideration I found it makes sense. http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@11 PS2, Line 11: Specifically, we should only evict a node (voter or otherwise) if we are : reasonably confident that the resulting configuration can be committed : by enough healthy voters to form a majority. > It's already so in the current code. Actually, there is a stronger conditi Now it's SGTM. -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 30 Nov 2017 06:59:49 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has uploaded a new patch set (#4) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8681 ) Change subject: KUDU-1097: Implement a "safe eviction" policy .. KUDU-1097: Implement a "safe eviction" policy We should respect the same kinds of policies for 3-4-3 eviction as we use for 3-2-3 eviction as implemented in the SafeToEvict() function. Specifically, we should only evict a node (voter or otherwise) if we are reasonably confident that the resulting configuration can be committed by enough healthy voters to form a majority. Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/master/catalog_manager.cc 4 files changed, 236 insertions(+), 75 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/8681/4 -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 4 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] KUDU-1097. master: strip health reports from cstate before persisting
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8683 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. KUDU-1097. master: strip health reports from cstate before persisting The master should not persist configs with health reports in them because the health reports are inherently transient information. This patch strips the health reports from the cstate included in each leader tablet report before persisting them. Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 --- M src/kudu/master/catalog_manager.cc 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/8683/3 -- To view, visit http://gerrit.cloudera.org:8080/8683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8683 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.6.x) Update version to 1.6.0
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8697 ) Change subject: Update version to 1.6.0 .. Patch Set 1: Verified+1 Code-Review+2 updating version for 1.6.0 as RM -- To view, visit http://gerrit.cloudera.org:8080/8697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: comment Gerrit-Change-Id: I893e4aec71590328d654b908b845ac7c5155548b Gerrit-Change-Number: 8697 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 06:41:50 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Update version to 1.6.0
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8697 ) Change subject: Update version to 1.6.0 .. Update version to 1.6.0 Change-Id: I893e4aec71590328d654b908b845ac7c5155548b Reviewed-on: http://gerrit.cloudera.org:8080/8697 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M version.txt 11 files changed, 11 insertions(+), 11 deletions(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I893e4aec71590328d654b908b845ac7c5155548b Gerrit-Change-Number: 8697 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-1.6.x) Update version to 1.6.0
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8697 Change subject: Update version to 1.6.0 .. Update version to 1.6.0 Change-Id: I893e4aec71590328d654b908b845ac7c5155548b --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M version.txt 11 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/8697/1 -- To view, visit http://gerrit.cloudera.org:8080/8697 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: newchange Gerrit-Change-Id: I893e4aec71590328d654b908b845ac7c5155548b Gerrit-Change-Number: 8697 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] KUDU-1097. master: strip health reports from cstate before persisting
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8683 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc@3466 PS1, Line 3466: it > nit: drop Done http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc@3474 PS1, Line 3474: if (peer->has_health_report()) > nit: drop this for clarity since clear_health_report() is idempotent Done -- To view, visit http://gerrit.cloudera.org:8080/8683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8683 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 30 Nov 2017 05:23:07 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. master: strip health reports from cstate before persisting
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8683 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. KUDU-1097. master: strip health reports from cstate before persisting The master should not persist configs with health reports in them because the health reports are inherently transient information. This patch strips the health reports from the cstate included in each leader tablet report before persisting them. Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 --- M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/master/catalog_manager.cc 2 files changed, 22 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/8683/2 -- To view, visit http://gerrit.cloudera.org:8080/8683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8683 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8681 ) Change subject: KUDU-1097: Implement a "safe eviction" policy .. KUDU-1097: Implement a "safe eviction" policy We should respect the same kinds of policies for 3-4-3 eviction as we use for 3-2-3 eviction as implemented in the SafeToEvict() function. Specifically, we should only evict a node (voter or otherwise) if we are reasonably confident that the resulting configuration can be committed by enough healthy voters to form a majority. Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/master/catalog_manager.cc 3 files changed, 183 insertions(+), 65 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/8681/3 -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] Update version to 1.7.0-SNAPSHOT
Jean-Daniel Cryans has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8694 ) Change subject: Update version to 1.7.0-SNAPSHOT .. Update version to 1.7.0-SNAPSHOT Change-Id: I9aea0e983c07bba98905faf2dd034fe6f455eabf Reviewed-on: http://gerrit.cloudera.org:8080/8694 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 12 files changed, 12 insertions(+), 12 deletions(-) Approvals: Kudu Jenkins: Verified Jean-Daniel Cryans: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9aea0e983c07bba98905faf2dd034fe6f455eabf Gerrit-Change-Number: 8694 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Update version to 1.7.0-SNAPSHOT
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8694 ) Change subject: Update version to 1.7.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aea0e983c07bba98905faf2dd034fe6f455eabf Gerrit-Change-Number: 8694 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 30 Nov 2017 04:14:10 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Add util/array view.h to rat excludes file
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8696 ) Change subject: Add util/array_view.h to rat excludes file .. Add util/array_view.h to rat excludes file In 142464e8bb76ccb42006c9f2fceb39119d895a53 we added util/array_view.h with a non-ASF license, so we need to exclude it from our Release Audit Tool output as well. Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Reviewed-on: http://gerrit.cloudera.org:8080/8696 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M build-support/release/rat_exclude_files.txt 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: merged Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8696 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR](branch-1.6.x) Add util/array view.h to rat excludes file
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8696 ) Change subject: Add util/array_view.h to rat excludes file .. Patch Set 1: Verified+1 Code-Review+2 approving with release manager magic -- To view, visit http://gerrit.cloudera.org:8080/8696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: comment Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8696 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 04:08:09 + Gerrit-HasComments: No
[kudu-CR] Add util/array view.h to rat excludes file
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8695 ) Change subject: Add util/array_view.h to rat excludes file .. Add util/array_view.h to rat excludes file In 142464e8bb76ccb42006c9f2fceb39119d895a53 we added util/array_view.h with a non-ASF license, so we need to exclude it from our Release Audit Tool output as well. Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Reviewed-on: http://gerrit.cloudera.org:8080/8695 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M build-support/release/rat_exclude_files.txt 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8695 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] Add util/array view.h to rat excludes file
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8695 ) Change subject: Add util/array_view.h to rat excludes file .. Patch Set 1: Verified+1 Code-Review+2 approving with release manager magic -- To view, visit http://gerrit.cloudera.org:8080/8695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8695 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 04:07:47 + Gerrit-HasComments: No
[kudu-CR](branch-1.6.x) Add util/array view.h to rat excludes file
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8696 Change subject: Add util/array_view.h to rat excludes file .. Add util/array_view.h to rat excludes file In 142464e8bb76ccb42006c9f2fceb39119d895a53 we added util/array_view.h with a non-ASF license, so we need to exclude it from our Release Audit Tool output as well. Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 --- M build-support/release/rat_exclude_files.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/8696/1 -- To view, visit http://gerrit.cloudera.org:8080/8696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.6.x Gerrit-MessageType: newchange Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8696 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] Add util/array view.h to rat excludes file
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8695 Change subject: Add util/array_view.h to rat excludes file .. Add util/array_view.h to rat excludes file In 142464e8bb76ccb42006c9f2fceb39119d895a53 we added util/array_view.h with a non-ASF license, so we need to exclude it from our Release Audit Tool output as well. Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 --- M build-support/release/rat_exclude_files.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/8695/1 -- To view, visit http://gerrit.cloudera.org:8080/8695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43b27d5b9fdadb711a712d63c7496983f6ef8469 Gerrit-Change-Number: 8695 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] Update version to 1.7.0-SNAPSHOT
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8694 Change subject: Update version to 1.7.0-SNAPSHOT .. Update version to 1.7.0-SNAPSHOT Change-Id: I9aea0e983c07bba98905faf2dd034fe6f455eabf --- M java/gradle.properties M java/kudu-client-tools/pom.xml M java/kudu-client/pom.xml M java/kudu-flume-sink/pom.xml M java/kudu-hive/pom.xml M java/kudu-jepsen/pom.xml M java/kudu-mapreduce/pom.xml M java/kudu-spark-tools/pom.xml M java/kudu-spark/pom.xml M java/pom.xml M python/setup.py M version.txt 12 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/8694/1 -- To view, visit http://gerrit.cloudera.org:8080/8694 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I9aea0e983c07bba98905faf2dd034fe6f455eabf Gerrit-Change-Number: 8694 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8692 Change subject: KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client .. KUDU-2191 (5/n): Add Kerberos SASL support to the HMS client The bulk of this commit is adding a new Thrift transport type, SaslClientTransport, which facilitates SASL GSSAPI negotiation, as well as integrity/privacy channel protection. The new transport is based on Impala's version with some significant changes: - Impala has a client and server SASL transport, necessitating a common superclass (SaslTransport). Since we only need a client transport, I collapsed all of the logic into a single class, which I think makes the code easier to follow. - The transport uses Kudu helper types where possible, e.g., faststring buffers, and our existing SASL utility infrastructure. - Integrity and privacy channel protection are implemented. There are no standlone unit-tests for the transport, since that would require implementing the server-specific counterpart. Instead, the class is tested indirectly through using the HMS client to communicate with a Kerberos-enabled HMS instance. Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345 --- M src/kudu/hms/CMakeLists.txt M src/kudu/hms/hms_client-test.cc M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h A src/kudu/hms/sasl_client_transport.cc A src/kudu/hms/sasl_client_transport.h M src/kudu/mini-cluster/external_mini_cluster-test.cc M src/kudu/mini-cluster/external_mini_cluster.cc M src/kudu/rpc/client_negotiation.cc M src/kudu/rpc/sasl_common.cc M src/kudu/rpc/sasl_common.h M src/kudu/rpc/server_negotiation.cc 14 files changed, 820 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/8692/1 -- To view, visit http://gerrit.cloudera.org:8080/8692 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f217ae05fd36c8ee88fe20eeccd73d49233a345 Gerrit-Change-Number: 8692 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert
[kudu-CR] KUDU-2191 (4/n): HMS Thrift client fault handling
Hello Tidy Bot, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8494 to look at the new patch set (#4). Change subject: KUDU-2191 (4/n): HMS Thrift client fault handling .. KUDU-2191 (4/n): HMS Thrift client fault handling This commit improves the new HMS Thrift client's ability to handle faults. In particular: - The client now uses send, receive, and connect timeouts so that a non-responsive HMS instance will not block the client indefinitely. - The Thrift logging callback is hooked up to glog so that we get proper log messages from Thrift. - The HmsClient class and method docs include information about behavior when errors are encountered. In the part 2 review, Todd also brought up the prospect of creating a wrapper Thrift socket or transport to inject slow log warning messages automatically. I've held off doing this for now, because I haven't been able to figure out a way to do that which can associate the slowness with higher-level operations like 'create database', as opposed to lower-level like 'socket write'. I've made sure to apply the slow warning calls uniformly across the HmsClient methods, and I don't think it will be too onerous to keep them consistent in the future. Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d --- M src/kudu/hms/hms_client-test.cc M src/kudu/hms/hms_client.cc M src/kudu/hms/hms_client.h M src/kudu/hms/mini_hms.cc M src/kudu/hms/mini_hms.h 5 files changed, 178 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/8494/4 -- To view, visit http://gerrit.cloudera.org:8080/8494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic48bbb833bbae39b383ae239054b9710da3c746d Gerrit-Change-Number: 8494 Gerrit-PatchSet: 4 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2191: bump Hive package
Dan Burkert has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8691 Change subject: KUDU-2191: bump Hive package .. KUDU-2191: bump Hive package Bumps the packaged Hive version in order to fix a logging bug (HIVE-16939). Also strips a few more unnecessary jars, and switches to console logging for the mini HMS. Change-Id: I4ba17eb76761b2977cd8f643eebb87bcec49034e --- M src/kudu/hms/mini_hms.cc M thirdparty/package-hive.sh M thirdparty/vars.sh 3 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/8691/1 -- To view, visit http://gerrit.cloudera.org:8080/8691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4ba17eb76761b2977cd8f643eebb87bcec49034e Gerrit-Change-Number: 8691 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert
[kudu-CR] [catalog manager] introduce replica type filter
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica type filter .. Patch Set 10: Verified+1 unrelated flake in flags-test -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 30 Nov 2017 01:39:23 + Gerrit-HasComments: No
[kudu-CR] [catalog manager] introduce replica type filter
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica type filter .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1097. Never evict a leader
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8680 ) Change subject: KUDU-1097. Never evict a leader .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@628 PS2, Line 628: const string& node : > nit (just for better readability): Done http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@629 PS2, Line 629: RaftConfigPB config; : AddPeer(&config, nodes[0], V, '+'); : AddPeer(&config, nodes[1], V, '+'); : AddPeer(&config, nodes[2], V, '+'); : AddPeer(&config, nodes[3], V, '+'); > nit: move this out of the loop -- this part is static. Done -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 30 Nov 2017 01:36:08 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. Never evict a leader
Alexey Serbin has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8680 ) Change subject: KUDU-1097. Never evict a leader .. KUDU-1097. Never evict a leader The master should never try to evict the leader replica when the tablet is over-replicated and arbitrary voters are eligible for eviction. This patch ensures that is the case. Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/consensus/quorum_util.h M src/kudu/master/catalog_manager.cc 4 files changed, 79 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/8680/3 -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [client] expose non-voter replicas for kudu CLI tool
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8586 ) Change subject: [client] expose non-voter replicas for kudu CLI tool .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc File src/kudu/tools/ksck-test.cc: http://gerrit.cloudera.org:8080/#/c/8586/4/src/kudu/tools/ksck-test.cc@214 PS4, Line 214: void CreateAndFillTablet(shared_ptr& tablet, int num_replicas, > warning: non-const reference parameter 'tablet', make it const or use a poi I'm going to ignore this. That fix is better to publish as a separate patch, IMO. -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 30 Nov 2017 01:09:13 + Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] introduce replica type filter
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica type filter .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG@9 PS8, Line 9: replica type filter policy > s/policy//; a replica type filter Done http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG@11 PS8, Line 11: locate > include Done -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 30 Nov 2017 00:52:50 + Gerrit-HasComments: Yes
[kudu-CR] [catalog manager] introduce replica type filter
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8161 to look at the new patch set (#10). Change subject: [catalog manager] introduce replica type filter .. [catalog manager] introduce replica type filter Introduced a replica type filter for GetTabletLocations RPC and various wrapper methods used in master, catalog manager, and tests. The filter is used to specify what type of tablet replicas to include while populating the result of the GetTabletLocations RPC. When not specified otherwise or when using earlier versions of the GetTable[t]LocationsRequestPB protobuf messages, VOTER_REPLICA policy is used. To locate all replicas, specify ANY_REPLICA policy in the 'replica_type_filter' field of the GetTable[t]LocationsRequestPB. The latter is done now unconditionally for already existing non-voter replica-related tests. This will change by a follow-up commit: the 'regular' client operations should work with voter replicas only, so the use cases for getting all tablet replicas will be just the following: * the kudu CLI tool fetching that information to report on replica membership status for listings in 'table list --tablets' and 'ksck' sub-commands. * various tests exercising the functionality related to non-voter tablet replicas Added an integration test to verify the functionality of the replica type filter for GetTableLocations and GetTabletLocations RPC. Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 --- M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc 18 files changed, 242 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/8161/10 -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 10 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-1097. Only add/evict when processing leader tablet reports
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8682 ) Change subject: KUDU-1097. Only add/evict when processing leader tablet reports .. KUDU-1097. Only add/evict when processing leader tablet reports The leader replica is the only replica that sends a health report. The master needs the health report to make an eviction decision. Thus, we should only consider eviction or addition of a new replica if the tablet report received contains a health report. There is no standalone test for this but this patch is required for the following patch, "Never evict a leader", to pass due to the DCHECK introduced in that patch. Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1 --- M src/kudu/master/catalog_manager.cc 1 file changed, 18 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/8682/2 -- To view, visit http://gerrit.cloudera.org:8080/8682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1 Gerrit-Change-Number: 8682 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1097. Only add/evict when processing leader tablet reports
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8682 )
Change subject: KUDU-1097. Only add/evict when processing leader tablet reports
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8682/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8682/1/src/kudu/master/catalog_manager.cc@3491
PS1, Line 3491: if (FLAGS_raft_prepare_replacement_before_eviction &&
: !cstate.leader_uuid().empty() &&
: cstate.committed_config().peers_size() > 0 &&
:
cstate.committed_config().peers(0).has_health_report()) {
: // An alternative scheme of managing tablet replicas:
the catalog
: // manager processes the health-related info on
replicas from the tablet
: // report and initiates appropriate modifications for
the tablet Raft
: // configuration: evict an already-replaced failed
voter replica or add
: // a new non-voter replica marked for promotion as a
replacement.
: //
: // We only run this code path when receiving a leader's
tablet report,
: // since the leader is the only node that sends a
health report for the
: // peers.
: const RaftConfigPB& config = cstate.committed_config();
: string to_evict;
: if (IsUnderReplicated(config, replication_factor)) {
: rpcs.emplace_back(new AsyncAddReplicaTask(
: master_, tablet, cstate, RaftPeerPB::NON_VOTER,
&rng_));
: } else if
(PREDICT_TRUE(FLAGS_catalog_manager_evict_excess_replicas) &&
:CanEvictReplica(config, replication_factor,
&to_evict)) {
: DCHECK(!to_evict.empty());
: rpcs.emplace_back(new AsyncEvictReplicaTask(
: master_, tablet, cstate, std::move(to_evict)));
: }
: } else if (consensus_state_updated &&
: FLAGS_master_add_server_when_underreplicated &&
: CountVoters(cstate.committed_config()) <
replication_factor) {
: // Add a server to the config if it is under-replicated.
: //
: // This is an idempotent operation due to a CAS
enforced on the
: // committed config's opid_index.
: rpcs.emplace_back(new AsyncAddReplicaTask(
: master_, tablet, cstate, RaftPeerPB::VOTER, &rng_));
: }
> I think there is a logic error in the updated code. The FLAGS_raft_prepare
Done
--
To view, visit http://gerrit.cloudera.org:8080/8682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1
Gerrit-Change-Number: 8682
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:44:10 +
Gerrit-HasComments: Yes
[kudu-CR] exactly once writes-itest for faulty disks
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8388 ) Change subject: exactly_once_writes-itest for faulty disks .. Patch Set 7: Retriggered. Failed due to clock sync issues. -- To view, visit http://gerrit.cloudera.org:8080/8388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966b41b71e39827f8f78fcca59a2208f13f71e53 Gerrit-Change-Number: 8388 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Thu, 30 Nov 2017 00:27:39 + Gerrit-HasComments: No
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 6: Verified+1 self-verifying since it's just a release note -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 00:22:05 + Gerrit-HasComments: No
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Reviewed-on: http://gerrit.cloudera.org:8080/8686 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M docs/release_notes.adoc 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: 1.6 release notes for new data dir features
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53 PS4, Line 53: e ex > mind mentioning that fact here in the release note? Done -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 00:15:28 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 00:15:59 + Gerrit-HasComments: No
[kudu-CR] [client] expose non-voter replicas for kudu CLI tool
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8586 )
Change subject: [client] expose non-voter replicas for kudu CLI tool
..
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc
File src/kudu/client/client.cc:
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@a340
PS3, Line 340:
> Is there a reason for removing these parens?
They are not needed in C++ default constructors. Also, it's less symbols total
:)
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/client.cc@550
PS3, Line 550: bool is_leader = r.role() == consensus::RaftPeerPB::LEADER;
> Would you mind adding a TODO comment to try to go back and use member_type
Done
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h
File src/kudu/client/replica_controller.h:
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@27
PS3, Line 27: namespace internal {
> Based on recent convention, I think these files (.h and .cc) should also be
Done
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@29
PS3, Line 29: which
> nit: whose
Done
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@20
PS3, Line 20: #include
> warning: #includes are not sorted properly [llvm-include-order]
Done
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc
File src/kudu/tools/ksck-test.cc:
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck-test.cc@214
PS3, Line 214: void CreateAndFillTablet(shared_ptr& tablet, int
num_replicas,
> warning: non-const reference parameter 'tablet', make it const or use a poi
ignoring
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:
http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/tools/ksck.cc@74
PS3, Line 74: using std::right;
> warning: using decl 'right' is unused [misc-unused-using-decls]
Done
--
To view, visit http://gerrit.cloudera.org:8080/8586
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20
Gerrit-Change-Number: 8586
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Thu, 30 Nov 2017 00:14:43 +
Gerrit-HasComments: Yes
[kudu-CR] [client] expose non-voter replicas for kudu CLI tool
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8586 to look at the new patch set (#4). Change subject: [client] expose non-voter replicas for kudu CLI tool .. [client] expose non-voter replicas for kudu CLI tool Added private interface to expose non-voter replica in the kudu CLI tools. Also, use that functionality to list table's replicas. Updated output of ksck to include information on non-voters replicas: * renamed column 'Voters' into 'Replicas' * a non-voter is displayed with '~' extra suffix, e.g. in the example below two non-voter replicas, B and C, are in the config along with leader replica A: Config source | Replicas | Current term | Config index | Committed? ---+--+--+--+--- master| A* B~ C~ | | | Yes A | A* B~ C~ | 4| 5| Yes B | A* B~ C~ | 4| 5| Yes C | A* B~ C~ | 4| 5| Yes I also updated the format of output to make it more readable. An example of new output for 'kudu table list --list_tablets': loadgen_auto_1e5f57a73dd34fa7bde7465219bd1866 T 69e22ffecb5b459db8a7fbf2f751a76f L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872 N f2e726948d3143e184097cd953dd2230 127.0.0.1:9878 N 3ae7fdf107cf424dbf9c5e33c33eafd0 127.0.0.1:9876 T 662bae40e4ec46588e90670bec16b2b5 L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872 T 5ba95da9b2f9455db9d690bdd35ae5cb L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874 T 528ae88cce1e4415a0d075dead5c983c L 20e66417713446039c22987fec13b800 127.0.0.1:9870 T 157ea108357e469e8fee001aec521d7e L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872 T 9c6a4d493fff4bda9bfe8f158cb08e69 L 5acf108a9d364178b1aa672e52214ab8 127.0.0.1:9872 T 36d03adab6ad494ea4e769ef92ef5577 L df8296cf97df42eaacd78e794c028c79 127.0.0.1:9874 T 7ce6d42984734614bd627d872e99c833 L 20e66417713446039c22987fec13b800 127.0.0.1:9870 Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 --- M src/kudu/client/CMakeLists.txt M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/client_builder-internal.cc M src/kudu/client/client_builder-internal.h M src/kudu/client/meta_cache.cc M src/kudu/client/meta_cache.h M src/kudu/client/replica-internal.cc M src/kudu/client/replica-internal.h A src/kudu/client/replica_controller-internal.cc A src/kudu/client/replica_controller-internal.h M src/kudu/client/scan_token-internal.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_table.cc 19 files changed, 429 insertions(+), 150 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8586/4 -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] [catalog manager] introduce replica type filter
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8161 to look at the new patch set (#9). Change subject: [catalog manager] introduce replica type filter .. [catalog manager] introduce replica type filter Introduced replica type filter policy for GetTabletLocations RPC and various wrapper methods used in master, catalog manager, and tests. The filter is used to specify what type of tablet replicas to locate while populating the result of the GetTabletLocations RPC. When not specified otherwise or when using earlier versions of the GetTable[t]LocationsRequestPB protobuf messages, VOTER_REPLICA policy is used. To locate all replicas, specify ANY_REPLICA policy in the 'replica_type_filter' field of the GetTable[t]LocationsRequestPB. The latter is done now unconditionally for already existing non-voter replica-related tests. This will change by a follow-up commit: the 'regular' client operations should work with voter replicas only, so the use cases for getting all tablet replicas will be just the following: * the kudu CLI tool fetching that information to report on replica membership status for listings in 'table list --tablets' and 'ksck' sub-commands. * various tests exercising the functionality related to non-voter tablet replicas Added an integration test to verify the functionality of the replica type filter for GetTableLocations and GetTabletLocations RPC. Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 --- M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc 18 files changed, 242 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/8161/9 -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53 PS4, Line 53: e ex > the default is to create groups containing all available disks. mind mentioning that fact here in the release note? -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Thu, 30 Nov 2017 00:11:13 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8686 to look at the new patch set (#6). Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/6 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] [catalog manager] introduce replica type filter
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica type filter .. Patch Set 8: (2 comments) oops, just a couple more commit message nits http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG@9 PS8, Line 9: replica type filter policy s/policy//; a replica type filter http://gerrit.cloudera.org:8080/#/c/8161/8//COMMIT_MSG@11 PS8, Line 11: locate include -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 30 Nov 2017 00:09:23 + Gerrit-HasComments: Yes
[kudu-CR] exactly once writes-itest for faulty disks
Hello Tidy Bot, David Ribeiro Alves, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8388 to look at the new patch set (#7). Change subject: exactly_once_writes-itest for faulty disks .. exactly_once_writes-itest for faulty disks This patch adds an ExactlyOnceWrites test that exercises intermittently crashy disks. This serves to not only test disk failures during writes, but also test disk failures during tablet copies, all while maintaining exactly-once semantics. exactly_once_writes-itest is also updated to use std::thread instead of kudu::Thread, and to favor returning Status instead of void. Change-Id: I966b41b71e39827f8f78fcca59a2208f13f71e53 --- M src/kudu/integration-tests/exactly_once_writes-itest.cc M src/kudu/util/test_macros.h 2 files changed, 229 insertions(+), 115 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8388/7 -- To view, visit http://gerrit.cloudera.org:8080/8388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I966b41b71e39827f8f78fcca59a2208f13f71e53 Gerrit-Change-Number: 8388 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot
[kudu-CR] [catalog manager] introduce replica type filter
Hello Tidy Bot, Mike Percy, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8161 to look at the new patch set (#8). Change subject: [catalog manager] introduce replica type filter .. [catalog manager] introduce replica type filter Introduced replica type filter policy for GetTabletLocations RPC and various wrapper methods used in master, catalog manager, and tests. The filter is used to specify what type of tablet replicas to locate while populating the result of the GetTabletLocations RPC. When not specified otherwise or when using earlier versions of the GetTable[t]LocationsRequestPB protobuf messages, VOTER_REPLICA policy is used. To locate all replicas, specify ANY_REPLICA policy in the 'replica_type_filter' field of the GetTable[t]LocationsRequestPB. The latter is done now unconditionally for already existing non-voter replica-related tests. This will change by a follow-up commit: the 'regular' client operations should work with voter replicas only, so the use cases for getting all tablet replicas will be just the following: * the kudu CLI tool fetching that information to report on replica membership status for listings in 'table list --tablets' and 'ksck' sub-commands. * various tests exercising the functionality related to non-voter tablet replicas Added an integration test to verify the functionality of the replica type filter for GetTableLocations and GetTabletLocations RPC. Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 --- M src/kudu/client/meta_cache.cc M src/kudu/integration-tests/cluster_itest_util.cc M src/kudu/integration-tests/cluster_itest_util.h M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/registration-test.cc M src/kudu/integration-tests/table_locations-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tombstoned_voting-itest.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/master/catalog_manager.cc M src/kudu/master/catalog_manager.h M src/kudu/master/master.proto M src/kudu/master/master_service.cc M src/kudu/tools/kudu-admin-test.cc 18 files changed, 243 insertions(+), 66 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/8161/8 -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [catalog manager] introduce replica type filter
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8161 ) Change subject: [catalog manager] introduce replica type filter .. Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@198 PS7, Line 198: GetTabletLocation > GetTabletLocations Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@722 PS7, Line 722: include_non_voters > flag name changed Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@723 PS7, Line 723: inconsistency > unclear to me what this means yeah, it reads better without that detail, given that the InvalidArgument most likely corresponds to a programming error. http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/catalog_manager.h@727 PS7, Line 727: sel > how about naming this 'filter' ? Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto File src/kudu/master/master.proto: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@366 PS7, Line 366: ReplicaMatchPolicy > How about ReplicaTypeFilter Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@378 PS7, Line 378: match_policy > replica_type_filter ? Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master.proto@463 PS7, Line 463: match_policy > same Done http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/8161/7/src/kudu/master/master_service.cc@241 PS7, Line 241: unknown > todd (per https://github.com/apache/kudu/blame/master/src/kudu/master/maste Done -- To view, visit http://gerrit.cloudera.org:8080/8161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I303a6d158184575a9a105c2d2bf26961ae8b3e93 Gerrit-Change-Number: 8161 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 29 Nov 2017 23:44:52 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@48 PS4, Line 48: is now enabled by default and > is now enabled by default and has been extended to handle data disk failure Done http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49 PS4, Line 49: he event o > a failed Done http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49 PS4, Line 49: ures at > any tablet Done http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@50 PS4, Line 50: k failure at runtime, any tablets with data on a failed disk will be > will be shut down and restarted on a different tablet server Done http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@52 PS4, Line 52: ly added tablet's tole > ability to parallelize reads Done http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53 PS4, Line 53: e ex > (what is the default at the time of writing?) the default is to create groups containing all available disks. -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 23:33:24 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8686 to look at the new patch set (#5). Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/5 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@48 PS4, Line 48: has been extended past startup is now enabled by default and has been extended to handle data disk failures at runtime http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49 PS4, Line 49: the failed a failed http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@49 PS4, Line 49: tablets any tablet http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@50 PS4, Line 50: will be stopped from doing further I/O and will be replicated as needed will be shut down and restarted on a different tablet server http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@52 PS4, Line 52: parallelization of I/O ability to parallelize reads http://gerrit.cloudera.org:8080/#/c/8686/4/docs/release_notes.adoc@53 PS4, Line 53: flag (what is the default at the time of writing?) -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 23:25:15 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc@55 PS3, Line 55: parallelism. Note that the first configured data directory and the WAL > This is now enabled by default and so I think we can call it a new feature Done -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 23:18:17 + Gerrit-HasComments: Yes
[kudu-CR] docs: 1.6 release notes for new data dir features
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8686 to look at the new patch set (#4). Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/4 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: 1.6 release notes for new data dir features
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for new data dir features .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/8686/3/docs/release_notes.adoc@55 PS3, Line 55: * Tablet servers' experimental tolerance of disk failures has been extended This is now enabled by default and so I think we can call it a new feature and not experimental -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 23:12:05 + Gerrit-HasComments: Yes
[kudu-CR] disk failure: turn handling on by default
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8687 ) Change subject: disk failure: turn handling on by default .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I29683c74850b9be38a5fccef0b762b89f8fcef9b Gerrit-Change-Number: 8687 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 23:11:18 + Gerrit-HasComments: No
[kudu-CR] disk failure: turn handling on by default
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8687 ) Change subject: disk failure: turn handling on by default .. disk failure: turn handling on by default Change-Id: I29683c74850b9be38a5fccef0b762b89f8fcef9b Reviewed-on: http://gerrit.cloudera.org:8080/8687 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy --- M src/kudu/util/env_posix.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/8687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29683c74850b9be38a5fccef0b762b89f8fcef9b Gerrit-Change-Number: 8687 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: 1.6 release notes for new data dir features
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8686 to look at the new patch set (#3). Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/3 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] disk failure: turn handling on by default
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8687 Change subject: disk failure: turn handling on by default .. disk failure: turn handling on by default Change-Id: I29683c74850b9be38a5fccef0b762b89f8fcef9b --- M src/kudu/util/env_posix.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/8687/1 -- To view, visit http://gerrit.cloudera.org:8080/8687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I29683c74850b9be38a5fccef0b762b89f8fcef9b Gerrit-Change-Number: 8687 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] docs: 1.6 release notes for new data dir features
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8686 to look at the new patch set (#2). Change subject: docs: 1.6 release notes for new data dir features .. docs: 1.6 release notes for new data dir features Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/2 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: 1.6 release notes for disk failure
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8686 ) Change subject: docs: 1.6 release notes for disk failure .. Patch Set 1: I copied and adjusted the note from 1.5 (https://kudu.apache.org/docs/release_notes.html). Could shorten it to basically just the first sentence if we don't want to duplicate the comment on limitations/tradeoffs. -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 21:16:39 + Gerrit-HasComments: No
[kudu-CR] docs: 1.6 release notes for disk failure
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8686 Change subject: docs: 1.6 release notes for disk failure .. docs: 1.6 release notes for disk failure Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 --- M docs/release_notes.adoc 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/8686/1 -- To view, visit http://gerrit.cloudera.org:8080/8686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I611cb203ea61ee3936cec7622663fc054ae4d115 Gerrit-Change-Number: 8686 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8681 )
Change subject: KUDU-1097: Implement a "safe eviction" policy
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc@493
PS2, Line 493: EXPECT_TRUE(CanEvictReplica(config, "A", 3, &uuid_to_evict));
: EXPECT_EQ("D", uuid_to_evict);
> I don't think this make sense.
ah, ignore that -- it seems i confused D as being a non-voter replica.
But anyway, it's a good question -- what should we do here. The previous
approach was to be conservative about that. The replica C might be the replica
which has been brought up instead of D, but it's not responsive.
--
To view, visit http://gerrit.cloudera.org:8080/8681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620
Gerrit-Change-Number: 8681
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 29 Nov 2017 20:46:12 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. Never evict a leader
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8680 ) Change subject: KUDU-1097. Never evict a leader .. Patch Set 2: (2 comments) looks good, just some nits http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc File src/kudu/consensus/quorum_util-test.cc: http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@628 PS2, Line 628: const string& node : nit (just for better readability): const auto& leader_node: http://gerrit.cloudera.org:8080/#/c/8680/2/src/kudu/consensus/quorum_util-test.cc@629 PS2, Line 629: RaftConfigPB config; : AddPeer(&config, nodes[0], V, '+'); : AddPeer(&config, nodes[1], V, '+'); : AddPeer(&config, nodes[2], V, '+'); : AddPeer(&config, nodes[3], V, '+'); nit: move this out of the loop -- this part is static. -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 29 Nov 2017 20:32:19 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8681 )
Change subject: KUDU-1097: Implement a "safe eviction" policy
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8681/2/src/kudu/consensus/quorum_util-test.cc@493
PS2, Line 493: EXPECT_TRUE(CanEvictReplica(config, "A", 3, &uuid_to_evict));
: EXPECT_EQ("D", uuid_to_evict);
I don't think this make sense.
The replica C might be actually failed, and evicting a non-voter in good health
(especially if it's in almost-caught-up state) is counter-productive in such a
situation.
--
To view, visit http://gerrit.cloudera.org:8080/8681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620
Gerrit-Change-Number: 8681
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Comment-Date: Wed, 29 Nov 2017 20:23:03 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8681 ) Change subject: KUDU-1097: Implement a "safe eviction" policy .. Patch Set 2: (2 comments) > Uploaded patch set 2: Patch Set 1 was rebased. I'm not sure we need this sort of logic in the new scheme: what particular use case does it address? The only issue I see with the current logic is to allow evicting failed non-voters, so we would not end up with dead non-voters in all possible new locations. http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@9 PS2, Line 9: We should respect the same kinds of policies for 3-4-3 eviction as we : use for 3-2-3 eviction as implemented in the SafeToEvict() function Why? What sort of issue do you try to address with that? http://gerrit.cloudera.org:8080/#/c/8681/2//COMMIT_MSG@11 PS2, Line 11: Specifically, we should only evict a node (voter or otherwise) if we are : reasonably confident that the resulting configuration can be committed : by enough healthy voters to form a majority. It's already so in the current code. Actually, there is a stronger condition now -- the number of healthy voter replicas should be not less than the replication factor. -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Comment-Date: Wed, 29 Nov 2017 20:15:52 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. Only add/evict when processing leader tablet reports
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8682 ) Change subject: KUDU-1097. Only add/evict when processing leader tablet reports .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8682/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8682/1//COMMIT_MSG@14 PS1, Line 14: test for this I think we can add the patch later, sure. Thank you for addressing the issue. -- To view, visit http://gerrit.cloudera.org:8080/8682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1 Gerrit-Change-Number: 8682 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 29 Nov 2017 20:00:58 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. Only add/evict when processing leader tablet reports
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8682 )
Change subject: KUDU-1097. Only add/evict when processing leader tablet reports
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8682/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8682/1/src/kudu/master/catalog_manager.cc@3491
PS1, Line 3491: if (FLAGS_raft_prepare_replacement_before_eviction &&
: !cstate.leader_uuid().empty() &&
: cstate.committed_config().peers_size() > 0 &&
:
cstate.committed_config().peers(0).has_health_report()) {
: // An alternative scheme of managing tablet replicas:
the catalog
: // manager processes the health-related info on
replicas from the tablet
: // report and initiates appropriate modifications for
the tablet Raft
: // configuration: evict an already-replaced failed
voter replica or add
: // a new non-voter replica marked for promotion as a
replacement.
: //
: // We only run this code path when receiving a leader's
tablet report,
: // since the leader is the only node that sends a
health report for the
: // peers.
: const RaftConfigPB& config = cstate.committed_config();
: string to_evict;
: if (IsUnderReplicated(config, replication_factor)) {
: rpcs.emplace_back(new AsyncAddReplicaTask(
: master_, tablet, cstate, RaftPeerPB::NON_VOTER,
&rng_));
: } else if
(PREDICT_TRUE(FLAGS_catalog_manager_evict_excess_replicas) &&
:CanEvictReplica(config, replication_factor,
&to_evict)) {
: DCHECK(!to_evict.empty());
: rpcs.emplace_back(new AsyncEvictReplicaTask(
: master_, tablet, cstate, std::move(to_evict)));
: }
: } else if (consensus_state_updated &&
: FLAGS_master_add_server_when_underreplicated &&
: CountVoters(cstate.committed_config()) <
replication_factor) {
: // Add a server to the config if it is under-replicated.
: //
: // This is an idempotent operation due to a CAS
enforced on the
: // committed config's opid_index.
: rpcs.emplace_back(new AsyncAddReplicaTask(
: master_, tablet, cstate, RaftPeerPB::VOTER, &rng_));
: }
I think there is a logic error in the updated code. The
FLAGS_raft_prepare_replacement_before_eviction was used as a kill switch, but
now it's not. What if FLAGS_raft_prepare_replacement_before_eviction == true
and one of the newly added criteria yields false? Then code related to old
replica management scheme will be executed, but that's not what is needed.
--
To view, visit http://gerrit.cloudera.org:8080/8682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1
Gerrit-Change-Number: 8682
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 29 Nov 2017 19:58:55 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. master: strip health reports from cstate before persisting
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8683 ) Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc@3466 PS1, Line 3466: it nit: drop http://gerrit.cloudera.org:8080/#/c/8683/1/src/kudu/master/catalog_manager.cc@3474 PS1, Line 3474: if (peer->has_health_report()) nit: drop this for clarity since clear_health_report() is idempotent -- To view, visit http://gerrit.cloudera.org:8080/8683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8683 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 29 Nov 2017 19:56:05 + Gerrit-HasComments: Yes
[kudu-CR] [client] expose non-voter replicas for kudu CLI tool
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/8586 ) Change subject: [client] expose non-voter replicas for kudu CLI tool .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h File src/kudu/client/replica_controller.h: http://gerrit.cloudera.org:8080/#/c/8586/3/src/kudu/client/replica_controller.h@29 PS3, Line 29: which nit: whose -- To view, visit http://gerrit.cloudera.org:8080/8586 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19317fdf5a2d5c8bb5f37b27bb83067a4df4ea20 Gerrit-Change-Number: 8586 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 29 Nov 2017 16:42:57 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097. master: strip health reports from cstate before persisting
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8683 to review the following change. Change subject: KUDU-1097. master: strip health reports from cstate before persisting .. KUDU-1097. master: strip health reports from cstate before persisting The master should not persist configs with health reports in them because the health reports are inherently transient information. This patch strips the health reports from the cstate included in each leader tablet report before persisting them. Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 --- M src/kudu/master/catalog_manager.cc 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/8683/1 -- To view, visit http://gerrit.cloudera.org:8080/8683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3e0b076146d888d01676442f6ab3f67cca6bacd6 Gerrit-Change-Number: 8683 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin
[kudu-CR] KUDU-1097. Never evict a leader
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8680 to look at the new patch set (#2). Change subject: KUDU-1097. Never evict a leader .. KUDU-1097. Never evict a leader The master should never try to evict the leader replica when the tablet is over-replicated arbitrary voters are eligible for eviction. This patch ensures that is the case. Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/consensus/quorum_util.h M src/kudu/master/catalog_manager.cc 4 files changed, 74 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/8680/2 -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1097. Only add/evict when processing leader tablet reports
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8682 to review the following change. Change subject: KUDU-1097. Only add/evict when processing leader tablet reports .. KUDU-1097. Only add/evict when processing leader tablet reports The leader replica is the only replica that sends a health report. The master needs the health report to make an eviction decision. Thus, we should only consider eviction or addition of a new replica if the tablet report received contains a health report. There is no standalone test for this but this patch is required for the following patch, "Never evict a leader", to pass due to the DCHECK introduced in that patch. Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1 --- M src/kudu/master/catalog_manager.cc 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/8682/1 -- To view, visit http://gerrit.cloudera.org:8080/8682 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If7e318e042cd27ff4544bc5aae76db4ab9e51da1 Gerrit-Change-Number: 8682 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin
[kudu-CR] KUDU-1097: Implement a "safe eviction" policy
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8681 to review the following change. Change subject: KUDU-1097: Implement a "safe eviction" policy .. KUDU-1097: Implement a "safe eviction" policy We should respect the same kinds of policies for 3-4-3 eviction as we use for 3-2-3 eviction as implemented in the SafeToEvict() function. Specifically, we should only evict a node (voter or otherwise) if we are reasonably confident that the resulting configuration can be committed by enough healthy voters to form a majority. Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc 2 files changed, 38 insertions(+), 45 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/8681/1 -- To view, visit http://gerrit.cloudera.org:8080/8681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8abeafd9d404aa80730b07b9bf218e82b8ff1620 Gerrit-Change-Number: 8681 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin
[kudu-CR] consensus: The master should never evict a leader
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/8680 to review the following change. Change subject: consensus: The master should never evict a leader .. consensus: The master should never evict a leader The master should never try to evict the leader replica when the tablet is over-replicated. This patch ensures that is the case. Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/consensus/quorum_util.h M src/kudu/master/catalog_manager.cc 4 files changed, 74 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/8680/1 -- To view, visit http://gerrit.cloudera.org:8080/8680 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I57adc8c4c4a6a3b5ad0c0b9202407a4dd9e1e8b0 Gerrit-Change-Number: 8680 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Alexey Serbin
[kudu-CR] KUDU-1097: scenario for fallen-behind-the-WAL replica
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8675 ) Change subject: KUDU-1097: scenario for fallen-behind-the-WAL replica .. KUDU-1097: scenario for fallen-behind-the-WAL replica Added end-to-end test scenario for the case when an existing follower replica falls behind the WAL GC threshold. First, the system attempts to replace it with a non-voter where tablet copying fails. As soon as that detected, a new non-voter replica is added and the replacement succeeds, so the tablet configuration eventually gets rid of failed replicas and contains exactly 3 healthy replicas. Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Reviewed-on: http://gerrit.cloudera.org:8080/8675 Reviewed-by: Mike Percy Tested-by: Kudu Jenkins --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest-base.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/tablet_copy_service.cc 9 files changed, 202 insertions(+), 15 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] WIP [itest] one more test for 3-4-3 re-replication scheme
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8679 Change subject: WIP [itest] one more test for 3-4-3 re-replication scheme .. WIP [itest] one more test for 3-4-3 re-replication scheme This is a new test (disabled for a while) to make sure the system is able to recover from the situation when a first attempt to replica a failed replica fails at every tablet server. WIP: make it work Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc 2 files changed, 104 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8679/1 -- To view, visit http://gerrit.cloudera.org:8080/8679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2062c2963fface43062b3154bf5ffa61b4fa684f Gerrit-Change-Number: 8679 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
[kudu-CR] KUDU-1097: scenario for fallen-behind-the-WAL replica
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8675 ) Change subject: KUDU-1097: scenario for fallen-behind-the-WAL replica .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 10:05:49 + Gerrit-HasComments: No
[kudu-CR] KUDU-1097: scenario for fallen-behind-the-WAL replica
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/8675 )
Change subject: KUDU-1097: scenario for fallen-behind-the-WAL replica
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG@7
PS3, Line 7: WIP [itests] more tests for 3-4-3 re-replication
> update commit message
Done
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc@622
PS3, Line 622: // TODO(aserbin): clarify how to deal with the case below: it
seems
> mind splitting this into a separate patch?
Done
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1310
PS3, Line 1310: //NO_FATALS(cluster_->AssertNoCrashes());
> remove this?
Done
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1317
PS3, Line 1317: TEST_F(RaftConsensusNonVoterITest,
DISABLED_FailedTabletCopyAllServers) {
> mind splitting this into a separate patch?
Done
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc@3154
PS3, Line 3154: if (FLAGS_raft_prepare_replacement_before_eviction) {
> we should only do this if we're adding a NON_VOTER
right -- good catch!
--
To view, visit http://gerrit.cloudera.org:8080/8675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af
Gerrit-Change-Number: 8675
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 29 Nov 2017 10:02:07 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1097: scenario for fallen-behind-the-WAL replica
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8675 to look at the new patch set (#4). Change subject: KUDU-1097: scenario for fallen-behind-the-WAL replica .. KUDU-1097: scenario for fallen-behind-the-WAL replica Added end-to-end test scenario for the case when an existing follower replica falls behind the WAL GC threshold. First, the system attempts to replace it with a non-voter where tablet copying fails. As soon as that detected, a new non-voter replica is added and the replacement succeeds, so the tablet configuration eventually gets rid of failed replicas and contains exactly 3 healthy replicas. Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest-base.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/tablet_copy_service.cc 9 files changed, 202 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/8675/4 -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] WIP [itests] more tests for 3-4-3 re-replication
Mike Percy has posted comments on this change. (
http://gerrit.cloudera.org:8080/8675 )
Change subject: WIP [itests] more tests for 3-4-3 re-replication
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/master/catalog_manager.cc@3154
PS3, Line 3154: if (FLAGS_raft_prepare_replacement_before_eviction) {
we should only do this if we're adding a NON_VOTER
--
To view, visit http://gerrit.cloudera.org:8080/8675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af
Gerrit-Change-Number: 8675
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 29 Nov 2017 09:43:28 +
Gerrit-HasComments: Yes
[kudu-CR] WIP [itests] more tests for 3-4-3 re-replication
Mike Percy has posted comments on this change. (
http://gerrit.cloudera.org:8080/8675 )
Change subject: WIP [itests] more tests for 3-4-3 re-replication
..
Patch Set 3: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8675/3//COMMIT_MSG@7
PS3, Line 7: WIP [itests] more tests for 3-4-3 re-replication
update commit message
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc
File src/kudu/consensus/quorum_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/consensus/quorum_util-test.cc@622
PS3, Line 622: // TODO(aserbin): clarify how to deal with the case below: it
seems
mind splitting this into a separate patch?
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1310
PS3, Line 1310: //NO_FATALS(cluster_->AssertNoCrashes());
remove this?
http://gerrit.cloudera.org:8080/#/c/8675/3/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@1317
PS3, Line 1317: TEST_F(RaftConsensusNonVoterITest,
DISABLED_FailedTabletCopyAllServers) {
mind splitting this into a separate patch?
--
To view, visit http://gerrit.cloudera.org:8080/8675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af
Gerrit-Change-Number: 8675
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy
Gerrit-Comment-Date: Wed, 29 Nov 2017 09:41:46 +
Gerrit-HasComments: Yes
[kudu-CR] WIP [itests] more tests for 3-4-3 re-replication
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8675 to look at the new patch set (#3). Change subject: WIP [itests] more tests for 3-4-3 re-replication .. WIP [itests] more tests for 3-4-3 re-replication WIP: make them work Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest-base.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/master/catalog_manager.cc M src/kudu/tserver/tablet_copy_service.cc 9 files changed, 310 insertions(+), 15 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/8675/3 -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] WIP [itests] more tests for 3-4-3 re-replication
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8675 to look at the new patch set (#2). Change subject: WIP [itests] more tests for 3-4-3 re-replication .. WIP [itests] more tests for 3-4-3 re-replication WIP: make them work Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af --- M src/kudu/consensus/quorum_util-test.cc M src/kudu/consensus/quorum_util.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest-base.h M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_election-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/tserver/tablet_copy_service.cc 8 files changed, 287 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/8675/2 -- To view, visit http://gerrit.cloudera.org:8080/8675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifcaff45c9fa3beb51d99dc53d88138da7dc120af Gerrit-Change-Number: 8675 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: Update to more recent jekyll
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8678 ) Change subject: docs: Update to more recent jekyll .. docs: Update to more recent jekyll Since it's not possible for docs generation to work on both macOS and RHEL 6, let's drop RHEL 6 and move to RHEL 7 as the minimum on Linux to build the docs. This also allows us to upgrade the version of yajl-ruby, for which there is a CVE on versions <= 1.2.2 and 1.3.0. See https://nvd.nist.gov/vuln/detail/CVE-2017-16516 Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb Reviewed-on: http://gerrit.cloudera.org:8080/8678 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M docs/support/scripts/Gemfile M docs/support/scripts/Gemfile.lock M docs/support/scripts/make_site.sh 3 files changed, 67 insertions(+), 59 deletions(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb Gerrit-Change-Number: 8678 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: Update to more recent jekyll
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8678 ) Change subject: docs: Update to more recent jekyll .. Patch Set 2: Verified+1 Code-Review+2 1.6 release stuff -- To view, visit http://gerrit.cloudera.org:8080/8678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb Gerrit-Change-Number: 8678 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 08:23:00 + Gerrit-HasComments: No
[kudu-CR] docs: Update to more recent jekyll
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8678 to look at the new patch set (#2). Change subject: docs: Update to more recent jekyll .. docs: Update to more recent jekyll Since it's not possible for docs generation to work on both macOS and RHEL 6, let's drop RHEL 6 and move to RHEL 7 as the minimum on Linux to build the docs. This also allows us to upgrade the version of yajl-ruby, for which there is a CVE on versions <= 1.2.2 and 1.3.0. See https://nvd.nist.gov/vuln/detail/CVE-2017-16516 Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb --- M docs/support/scripts/Gemfile M docs/support/scripts/Gemfile.lock M docs/support/scripts/make_site.sh 3 files changed, 67 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/8678/2 -- To view, visit http://gerrit.cloudera.org:8080/8678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb Gerrit-Change-Number: 8678 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Improve make site.sh validation checks for git remotes
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8677 ) Change subject: Improve make_site.sh validation checks for git remotes .. Patch Set 1: Verified+1 Code-Review+2 release stuff -- To view, visit http://gerrit.cloudera.org:8080/8677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42 Gerrit-Change-Number: 8677 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Comment-Date: Wed, 29 Nov 2017 08:02:46 + Gerrit-HasComments: No
[kudu-CR] Improve make site.sh validation checks for git remotes
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8677 Change subject: Improve make_site.sh validation checks for git remotes .. Improve make_site.sh validation checks for git remotes This was using the "apache" remote and giving a confusing error when it was not set. We'll use "origin" and do a better job of validating that it's set. Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42 --- M docs/support/scripts/make_site.sh 1 file changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/8677/1 -- To view, visit http://gerrit.cloudera.org:8080/8677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42 Gerrit-Change-Number: 8677 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
[kudu-CR] Improve make site.sh validation checks for git remotes
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8677 ) Change subject: Improve make_site.sh validation checks for git remotes .. Improve make_site.sh validation checks for git remotes This was using the "apache" remote and giving a confusing error when it was not set. We'll use "origin" and do a better job of validating that it's set. Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42 Reviewed-on: http://gerrit.cloudera.org:8080/8677 Reviewed-by: Mike Percy Tested-by: Mike Percy --- M docs/support/scripts/make_site.sh 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/8677 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42 Gerrit-Change-Number: 8677 Gerrit-PatchSet: 2 Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] docs: Update to more recent jekyll
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8678 Change subject: docs: Update to more recent jekyll .. docs: Update to more recent jekyll Since it's not possible for docs generation to work on both macOS and RHEL 6, let's drop RHEL 6 and move to RHEL 7 as the minimum on Linux to build the docs. This also allows us to upgrade the version of yajl-ruby, for which there is a CVE on versions <= 1.2.2 and 1.3.0. See https://nvd.nist.gov/vuln/detail/CVE-2017-16516 Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb --- M docs/support/scripts/Gemfile M docs/support/scripts/Gemfile.lock M docs/support/scripts/make_site.sh 3 files changed, 67 insertions(+), 59 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/8678/1 -- To view, visit http://gerrit.cloudera.org:8080/8678 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If3733d1daec263a3ffd1bcd6976d8cd4ba11ddeb Gerrit-Change-Number: 8678 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Percy
