Re: Review Request 35799: Support mounting relative paths with docker.
On June 24, 2015, 3:13 a.m., Bernd Mathiske wrote: src/tests/docker_tests.cpp, line 374 https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line374 Use Flags::docker_sandbox_directory (or a constant that the flag also uses for its default value) instead. Not only will this fix the naked constant problem, it will also explain what this parameter does and make readers understand the test code much more quickly. I know this is copy-paste-induced, but the original is really, really bad. Please either fix now, or leave a TODO and a tech debt ticket. Timothy Chen wrote: We actually put anything here, so I just put the default settings. I can just use /tmp/sandbox if that makes it more obvious? What you have put there now (directory.get()) does not provide the user with an idea what is going on without looking up the definition of the parameters of Docker::run() (nor would /tmp/sandbox). This may seem like a moot point, since it is indeed arbitrary what to put there. But conveying that information to the reader is actually the real point in question. So this fix is worse than the original IMHO. The previous string constant actually gave more of a hint and now I understand now why you named it /mnt/mesos/sandbox. This kinda stands for /arbitrary/mount/point/in/docker/for/the/Mesos/sandbox. Sorry for opening the issue in the first place! Please revert to /mnt/mesos/sandbox. (Maybe add a helpful source code comment? :-) - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review89147 --- On June 26, 2015, 4:26 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/ --- (Updated June 26, 2015, 4:26 p.m.) Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff. Bugs: MESOS-2374 https://issues.apache.org/jira/browse/MESOS-2374 Repository: mesos Description --- Support mounting relative paths with docker. Diffs - src/docker/docker.cpp 62aac2773d8b74e19619cf593064165892b03ba6 src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c Diff: https://reviews.apache.org/r/35799/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89723 --- Ship it! Looks great! Just a few formatting/wrapping nits, but I can fix those before committing this. src/slave/containerizer/mesos/containerizer.cpp (lines 1335 - 1343) https://reviews.apache.org/r/35721/#comment142437 FYI, we generally wrap at a consistent 70 characters in comments, rather than waiting for punctuation. I would reformat this before committing. src/slave/containerizer/mesos/containerizer.cpp (lines 1346 - 1348) https://reviews.apache.org/r/35721/#comment142440 ' + : should just be ': Also, these three lines could fit on two. We wrap code at 80 chars. src/slave/containerizer/mesos/containerizer.cpp (line 1351) https://reviews.apache.org/r/35721/#comment142445 I guess we don't need to care about the value of `flags.switch_user` here, since the sandbox will always be set to the correct permissions, regardless of whether `switch_user` is enabled. Nice solution. src/slave/containerizer/mesos/containerizer.cpp (lines 1353 - 1356) https://reviews.apache.org/r/35721/#comment142438 These four lines could easily fit on two. We wrap code at 80 chars. - Adam B On June 28, 2015, 7:36 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 28, 2015, 7:36 p.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the ownership of persistent volume to match the sandbox directory. Diffs - src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 --- Looks great. I think you're covering all the places where roles are specified now. But I'd like to see the validate() method move onto a Role/Roles class somewhere like Resources, rather than freestanding in an internal namespace. src/common/validation.hpp (lines 27 - 34) https://reviews.apache.org/r/35711/#comment142465 I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource protobuf message and a Resources class with parse() and validate(), we should also have a Roles::validate(). src/common/validation.cpp (lines 20 - 26) https://reviews.apache.org/r/35711/#comment142489 Unused? src/common/validation.cpp (lines 43 - 44) https://reviews.apache.org/r/35711/#comment142285 I suppose role name .. would also be invalid by similar logic (cannot `mkdir ..`) src/common/validation.cpp (lines 50 - 55) https://reviews.apache.org/r/35711/#comment142468 s/space characters/whitespace/ src/common/validation.cpp (line 58) https://reviews.apache.org/r/35711/#comment142491 What is `\x20`? You didn't comment it. src/common/validation.cpp (line 61) https://reviews.apache.org/r/35711/#comment142467 s/space/whitespace/ src/master/flags.cpp (line 189) https://reviews.apache.org/r/35711/#comment142493 This could be a quick Roles::parse() src/master/flags.cpp (lines 194 - 196) https://reviews.apache.org/r/35711/#comment142471 Check for the `*` first, then the other check can just `return Role::validate(role);`. src/slave/flags.cpp (line 52) https://reviews.apache.org/r/35711/#comment142474 s/value/resourcesString/ since 'value' is referenced as something else in the help string above. src/slave/flags.cpp (lines 61 - 62) https://reviews.apache.org/r/35711/#comment142477 How about `return Resources::validate(parsed.get());` src/tests/common/validation_tests.cpp (lines 38 - 40) https://reviews.apache.org/r/35711/#comment142482 Where are these being used? src/tests/common/validation_tests.cpp (line 50) https://reviews.apache.org/r/35711/#comment142484 s/name/names/ s/contains/contain/ src/tests/common/validation_tests.cpp (lines 59 - 60) https://reviews.apache.org/r/35711/#comment142480 Please add tests for strings starting with and strings containing a `-`. src/tests/common/validation_tests.cpp (line 63) https://reviews.apache.org/r/35711/#comment142481 Test `\n` as well? - Adam B On June 27, 2015, 4:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 4:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 35985: Consistent capitalization of NOTE in documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89726 --- Ship it! Ship It! - Bernd Mathiske On June 28, 2015, 3:45 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/ --- (Updated June 28, 2015, 3:45 a.m.) Review request for mesos, Bernd Mathiske and Michael Park. Repository: mesos Description --- Consistent capitalization of NOTE in documentation Diffs - docs/mesos-markdown-style-guide.md d5b7804d685e9351c7043611e84dd3498643724c Diff: https://reviews.apache.org/r/35985/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 29507: Added Configurable Slave Ping Timeouts
On June 24, 2015, 6:41 p.m., Ben Mahler wrote: Actually, we should think about one more thing, how does this interact with the zookeeper session timeout? Adam B wrote: The hardcoded individual ping timeout (15secs) was previously longer than the default zk session timeout (10secs), but the zk session timeout is already configurable with no bounds/validation, so users could already change it to be longer than an individual ping timeout, or even the total ping timeout. Is this a bad idea? What would this mean? This is mostly relevant to the slave-side (as a leader detector), in that a slave may timeout and decide to check for a new leading master to reregister with, but the zk session may have recently gone bad but not yet timed out. Since a zk session could go bad/timeout at any point along the way, I don't think making the ping timeout configurable will introduce any new potential errors. Rather, it would just be advisable to keep the zk session timeouts reasonably small so that the zk session is likely to be healthy whenever a slave needs to detect a new leader. We could introduce validation that the zk_session_timeout is shorter than the (total) ping timeout, but I'm not sure that's even necessary. Does this make sense? I'm no ZK expert, so I defer to those with more experience. Ben Mahler wrote: Right, the ZK timeout is negotiated with ZooKeeper, so it gets bounded based on the ZK server configuration: http://zookeeper.apache.org/doc/r3.3.1/zookeeperAdmin.html Validating that the session timeout is less than the total ping timeout might be nice, otherwise every session expiration slave-side will trigger useless re-registration attempts. Mind just adding a NOTE that reflects this in the flag help? The validation might be nice, but the ZK session timeout is only really determined after negotation anyway.. Noted in the flag help. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review89305 --- On June 26, 2015, 3:12 a.m., Adam B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated June 26, 2015, 3:12 a.m.) Review request for mesos, Ben Mahler and Niklas Nielsen. Bugs: MESOS-2110 https://issues.apache.org/jira/browse/MESOS-2110 Repository: mesos Description --- Added new --slave_ping_timeout and --max_slave_ping_timeouts flags to mesos-master to supplement the DEFAULT_SLAVE_PING_TIMEOUT (15secs) and DEFAULT_MAX_SLAVE_PING_TIMEOUTS (5). These can be extended if slaves are expected/allowed to be down for longer than a minute or two. Slave will receive master's ping timeout in SlaveRe[re]gisteredMessage. Beware that this affects recovery from network timeouts as well as actual slave node/process failover. Also fixed the log message in recoveredSlavesTimeout() to correctly reference flags.slave_reregister_timeout instead of the unrelated ping timeouts. Diffs - docs/configuration.md aaf65bf docs/upgrades.md 73e503c src/master/constants.hpp 072d59c src/master/constants.cpp 997b792 src/master/flags.hpp 55ed3a9 src/master/flags.cpp 4377715 src/master/master.cpp 0782b54 src/messages/messages.proto 1c8d79e src/slave/constants.hpp 84927e5 src/slave/constants.cpp d8d2f98 src/slave/slave.hpp f1cf3b8 src/slave/slave.cpp b3e1ccc src/tests/partition_tests.cpp f7ee3ab src/tests/slave_recovery_tests.cpp c036e9c src/tests/slave_tests.cpp e9002e8 Diff: https://reviews.apache.org/r/29507/diff/ Testing --- Manually tested slave failover/shutdown with master using different --slave_ping_timeout and --max_slave_ping_timeouts. Ran unit tests with shorter non-default values for ping timeouts. `make check` with new unit tests: ShortPingTimeoutUnreachableMaster and ShortPingTimeoutUnreachableSlave Thanks, Adam B
Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89728 --- Patch looks great! Reviews applied: [35919] All tests passed. - Mesos ReviewBot On June 29, 2015, 10:21 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 29, 2015, 10:21 a.m.) Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-2877 https://issues.apache.org/jira/browse/MESOS-2877 Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/include/process/firewall.hpp f71d6541e48e2481c69f401b388977b153503962 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e Diff: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/#review89735 --- Patch looks great! Reviews applied: [35998] All tests passed. - Mesos ReviewBot On June 29, 2015, 11:43 a.m., Till Toenshoff wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/ --- (Updated June 29, 2015, 11:43 a.m.) Review request for mesos, Bernd Mathiske and Joerg Schad. Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp a4afdad0b5f053186ace4d6a37b41cd02e7d415b Diff: https://reviews.apache.org/r/35998/diff/ Testing --- Thanks, Till Toenshoff
Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35998/ --- Review request for mesos, Bernd Mathiske and Joerg Schad. Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp a4afdad0b5f053186ace4d6a37b41cd02e7d415b Diff: https://reviews.apache.org/r/35998/diff/ Testing --- Thanks, Till Toenshoff
Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 29, 2015, 12:21 p.m.) Review request for mesos, Adam B and Till Toenshoff. Changes --- Adresses till's comments. Bugs: MESOS-2877 https://issues.apache.org/jira/browse/MESOS-2877 Repository: mesos Description --- see summary. Diffs (updated) - 3rdparty/libprocess/include/process/firewall.hpp f71d6541e48e2481c69f401b388977b153503962 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e Diff: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 35961: Include protobuf classes in generated Javadoc.
On June 27, 2015, 6:59 p.m., Adam B wrote:
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in, lines 27-36
https://reviews.apache.org/r/35961/diff/1/?file=993816#file993816line27
Did you verify that the curly-braces are properly handled here? I read
on http://stackoverflow.com/a/13512524/4056606 that the `{@code` tag will
interpret the first closing brace as its own ending brace. In fact, @code
may only be necessary for wrapping Generic `something` declarations. You
could additionally/instead use the old-style `code` tag to print
everything in code-font. I would hope this would be easier, but parsing
code within docs within code must be difficult. Don't even try to put `/*`
block comments inside your code example, or the compiler will get confused
too.
Yes, it does seem to work. Here is the output as rendered by my up-to-date
Google Chrome browser on OS X:
[](http://s15.postimg.org/p44aqh2e2/Screen_Shot_2015_06_29_at_07_47_24.jpg)
However, I personally find the `code/code` markup more readable than the
dangling closing curling brace. I will update this to use the plain HTML tag
style.
On June 27, 2015, 6:59 p.m., Adam B wrote:
src/java/mesos.pom.in, line 134
https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134
Is `${project.basedir}/generated` any better/different than
`@abs_top_builddir@/src/java/generated`
Probably not, will update to use `@abs_top_builddir@` instead.
On June 27, 2015, 6:59 p.m., Adam B wrote:
src/java/src/org/apache/mesos/MesosExecutorDriver.java, line 31
https://reviews.apache.org/r/35961/diff/1/?file=993818#file993818line31
Oracle docs (and wikipedia) claim that javadoc only uses the opening
p tag, without the closing /p tag. Did you find that this rendered
incorrectly?
Good point. I ran the build with JAVA_HOME pointing to Java 8, which is much
more stringent regarding Javadoc errors. Without this change, the build
actually fails with Java 8. I will verify that this still works with Java 8.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89629
---
On June 27, 2015, 1:18 a.m., Connor Doyle wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/
---
(Updated June 27, 2015, 1:18 a.m.)
Review request for mesos, Adam B and Ben Whitehead.
Bugs: MESOS-1552
https://issues.apache.org/jira/browse/MESOS-1552
Repository: mesos-incubating
Description
---
Updates the Java POM to include the generated Java protobuf classes.
Diffs
-
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903
src/java/mesos.pom.in 138da55
src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60
Diff: https://reviews.apache.org/r/35961/diff/
Testing
---
- configure
- make
- Manual verification of generated Javadoc HTML
Thanks,
Connor Doyle
Re: Review Request 35961: Include protobuf classes in generated Javadoc.
On June 27, 2015, 6:59 p.m., Adam B wrote: Thanks for doing this Connor! Just a couple of questions about javadoc parsing of html (I'm no expert, just googled a few things). Do we need to do a pass over our protos now to convert any `//` or `/*` block comments to `/**` comments? Worth a follow-up JIRA/patch? Most of mesos.proto looks fine, except TrafficControlStatistics and ResourceStatistics. And I'm not sure how public these need to be, but messages.proto is all `//` style, or completely missing comments. I think it makes sense to modify the comment style in a follow-up patch. As you mentioned the classes generated from mesos.proto already look pretty good. - Connor --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89629 --- On June 29, 2015, 3:53 p.m., Connor Doyle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/ --- (Updated June 29, 2015, 3:53 p.m.) Review request for mesos, Adam B and Ben Whitehead. Bugs: MESOS-1552 https://issues.apache.org/jira/browse/MESOS-1552 Repository: mesos-incubating Description --- Updates the Java POM to include the generated Java protobuf classes. Diffs - src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903 src/java/mesos.pom.in 138da55 src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60 Diff: https://reviews.apache.org/r/35961/diff/ Testing --- - configure - make - Manual verification of generated Javadoc HTML Thanks, Connor Doyle
Re: Review Request 35961: Include protobuf classes in generated Javadoc.
On June 27, 2015, 6:59 p.m., Adam B wrote:
src/java/mesos.pom.in, line 134
https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134
Is `${project.basedir}/generated` any better/different than
`@abs_top_builddir@/src/java/generated`
Connor Doyle wrote:
Probably not, will update to use `@abs_top_builddir@` instead.
Updated and verified.
- Connor
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89629
---
On June 29, 2015, 3:53 p.m., Connor Doyle wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/
---
(Updated June 29, 2015, 3:53 p.m.)
Review request for mesos, Adam B and Ben Whitehead.
Bugs: MESOS-1552
https://issues.apache.org/jira/browse/MESOS-1552
Repository: mesos-incubating
Description
---
Updates the Java POM to include the generated Java protobuf classes.
Diffs
-
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903
src/java/mesos.pom.in 138da55
src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60
Diff: https://reviews.apache.org/r/35961/diff/
Testing
---
- configure
- make
- Manual verification of generated Javadoc HTML
Thanks,
Connor Doyle
Review Request 36003: WIP: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- See summary. Diffs - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35711: Disallow special characters in role name.
On June 29, 2015, 11:17 a.m., Adam B wrote: src/common/validation.hpp, lines 27-34 https://reviews.apache.org/r/35711/diff/7/?file=993941#file993941line27 I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource protobuf message and a Resources class with parse() and validate(), we should also have a Roles::validate(). +1 Initially, the patch only contains validation at the master's side, and that's the reason I sugguested to put that into master/validation.hpp|cpp. I agree with Adam that putting that in Roles. Sorry about that! - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 --- On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Review Request 36009: Updated CHANGELOG about the acceptOffers API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36009/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2481 https://issues.apache.org/jira/browse/MESOS-2481 Repository: mesos Description --- Updated CHANGELOG about the acceptOffers API. Diffs - CHANGELOG bf383ab15fa974b5b649bb28637bf6f502e1f46d Diff: https://reviews.apache.org/r/36009/diff/ Testing --- Thanks, Jie Yu
Review Request 36005: Removed obsolete ec2 scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2640 https://issues.apache.org/jira/browse/MESOS-2640 Repository: mesos Description --- See summary. Diffs - docs/ec2-scripts.md 4866e2123eab0503bcc7fa130432bd41296d4b36 ec2/Makefile.am 8c64f485888df1599697eb181fc76aa83206da07 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/core-site.xml 565f54dd933a89eb966fb8b01c589e1008d543bf ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hadoop-env.sh 4e1e6991591e09f8860ab130948b0e787fce2b42 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hdfs-site.xml 43e68aa3e2ecbb53bd3b0a99d33b11aadda2cca7 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/mapred-site.xml b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/masters d26a1943aeb47ceeff904e593793e08c07eee9cc ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/mesos-ec2/cluster-url fcf8b41aed4b47a7b78d0c5a0042678f40059a5f ec2/deploy.amazon64-old/root/mesos-ec2/copy-dir 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc ec2/deploy.amazon64-old/root/mesos-ec2/create-swap 9ab32f841411f1053c29f0fa48f0cf2bbf468e82 ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/core-site.xml 818ed1030d3dd97467c4d4c83735cb7bda5afa80 ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh ca227b460e9d6b89a2fe3692a74eb1c267bc7b7f ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 0ffa92f115d66adc9e370f4030850216545ade38 ec2/deploy.amazon64-old/root/mesos-ec2/haproxy+apache/haproxy.config.template 957c3f6a6b2a2f658e076337d88e69447b2a3341 ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile fd5921e57d7985e128622ed132c9a24c7cd21d1b ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/hypertable.cfg b4d5b7475fab3d4a842e4b0f459abc5ca316996a ec2/deploy.amazon64-old/root/mesos-ec2/masters c531652dc1ef9e6d6ca73cec389b6433f35ae9cf ec2/deploy.amazon64-old/root/mesos-ec2/mesos-daemon 20ec099f521c97af569b98555ef67964cdcf97cc ec2/deploy.amazon64-old/root/mesos-ec2/redeploy-mesos 941d783d82f0708a6da0f4677c3364537dfded63 ec2/deploy.amazon64-old/root/mesos-ec2/setup 2165f90139d179d57b3d3b243d96fbea20a50b2c ec2/deploy.amazon64-old/root/mesos-ec2/setup-slave 436f417bc5a746ad74cc88c27e630a91d55b0b23 ec2/deploy.amazon64-old/root/mesos-ec2/setup-torque 2ac8fd3546063d3ba391147383de53b7824c7c8c ec2/deploy.amazon64-old/root/mesos-ec2/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/mesos-ec2/ssh-no-keychecking 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a ec2/deploy.amazon64-old/root/mesos-ec2/start-hypertable af16c2d7bd615cb0c98f6ba65ff5c69859678850 ec2/deploy.amazon64-old/root/mesos-ec2/start-mesos cc309cc44ecf5b67536f275083dca22948926f6b ec2/deploy.amazon64-old/root/mesos-ec2/stop-hypertable 7280dc11bfc53ae84b7ecaba34c84810461ed7f4 ec2/deploy.amazon64-old/root/mesos-ec2/stop-mesos 9fdb8753dffc5115f94582753e0860538be6232b ec2/deploy.amazon64-old/root/mesos-ec2/zoo efc961b502f30a6f187f7e50c2b92b302203d89e ec2/deploy.amazon64-old/root/persistent-hdfs/conf/core-site.xml b23aef258a13e4bc4cbf27099f7aa68419ab0825 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hadoop-env.sh b38ba01817e3b9c9715a476ecb692bac68983f50 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hdfs-site.xml ec000cb2f306232a29cf701b10f230685d2662c9 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/mapred-site.xml b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b ec2/deploy.amazon64-old/root/persistent-hdfs/conf/masters d26a1943aeb47ceeff904e593793e08c07eee9cc ec2/deploy.amazon64-old/root/persistent-hdfs/conf/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/spark/conf/spark-env.sh 86da7f832d03dfc6cc0be5e479fea7d8f92541e0 ec2/deploy.amazon64/root/ephemeral-hdfs/conf/core-site.xml 565f54dd933a89eb966fb8b01c589e1008d543bf ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hadoop-env.sh 4e1e6991591e09f8860ab130948b0e787fce2b42 ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hdfs-site.xml 43e68aa3e2ecbb53bd3b0a99d33b11aadda2cca7 ec2/deploy.amazon64/root/ephemeral-hdfs/conf/mapred-site.xml b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b ec2/deploy.amazon64/root/ephemeral-hdfs/conf/masters d26a1943aeb47ceeff904e593793e08c07eee9cc ec2/deploy.amazon64/root/ephemeral-hdfs/conf/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64/root/mesos-ec2/cluster-url fcf8b41aed4b47a7b78d0c5a0042678f40059a5f ec2/deploy.amazon64/root/mesos-ec2/copy-dir 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc ec2/deploy.amazon64/root/mesos-ec2/create-swap
Re: Review Request 36003: WIP: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89756 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406, 31207, 36003] All tests passed. - Mesos ReviewBot On June 29, 2015, 5:22 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 5:22 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- See summary. Diffs - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35985: Consistent capitalization of NOTE in documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89733 --- Ship it! Ship It! - Alexander Rojas On June 28, 2015, 12:45 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/ --- (Updated June 28, 2015, 12:45 p.m.) Review request for mesos, Bernd Mathiske and Michael Park. Repository: mesos Description --- Consistent capitalization of NOTE in documentation Diffs - docs/mesos-markdown-style-guide.md d5b7804d685e9351c7043611e84dd3498643724c Diff: https://reviews.apache.org/r/35985/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/#review89775 --- Ship it! Ship It! - Ian Downes On June 29, 2015, 11:58 a.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/ --- (Updated June 29, 2015, 11:58 a.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2956 https://issues.apache.org/jira/browse/MESOS-2956 Repository: mesos Description --- Fixed stack trace in isolator tests on Linux VM Diffs - src/tests/isolator_tests.cpp 525a5a88b8ab0681a89c5f7451d9ca9031c793af Diff: https://reviews.apache.org/r/36014/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 35981: Added persistent volume user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89773 --- Ship it! LGTM overall! Thanks a lot, mpark! docs/persistent-volume.md (lines 23 - 24) https://reviews.apache.org/r/35981/#comment142569 We don't store 'principal' in DiskInfo yet. Maybe add a coming soon somewhere as well? docs/persistent-volume.md (line 29) https://reviews.apache.org/r/35981/#comment142571 via the `acceptOffers` API (or the `ACCEPT` call in the new API). docs/persistent-volume.md (lines 63 - 64) https://reviews.apache.org/r/35981/#comment142574 by sending the following `Offer::Operation` message via the `acceptOffers` API. docs/persistent-volume.md (lines 67 - 69) https://reviews.apache.org/r/35981/#comment142576 The numbering is not correct:) docs/persistent-volume.md (line 68) https://reviews.apache.org/r/35981/#comment142577 We only support non nested relative container path right now. docs/persistent-volume.md (line 69) https://reviews.apache.org/r/35981/#comment142579 Please call out that 'RO' is not supported yet. docs/persistent-volume.md (line 168) https://reviews.apache.org/r/35981/#comment142580 sending the `Offer::Operation` message via the `acceptOffers` API. - Jie Yu On June 28, 2015, 3:35 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated June 28, 2015, 3:35 a.m.) Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Bugs: MESOS-2405 https://issues.apache.org/jira/browse/MESOS-2405 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) Diffs - docs/persistent-volume.md PRE-CREATION Diff: https://reviews.apache.org/r/35981/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 33090: Removed unmaintained frameworks code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/ --- (Updated June 29, 2015, 11:11 a.m.) Review request for mesos and Vinod Kone. Changes --- Also removed docs/using-the-mesos-submit-tool.md, NNRF. Bugs: MESOS-2640 https://issues.apache.org/jira/browse/MESOS-2640 Repository: mesos Description (updated) --- See summary. Diffs (updated) - docs/using-the-mesos-submit-tool.md 2ba4acc7423dae7ff67c1bc64ba3982aa1318b53 frameworks/deploy_jar/README.txt 37ccc1733a0689ab0eea802b91e76d8d7eb71a82 frameworks/deploy_jar/daemon_executor.py 4720a6e972308ef324f3f84642607072f0e69f3b frameworks/deploy_jar/daemon_executor.sh ac54d73fbcd225463e47fbad8ca5c4ffac48ca93 frameworks/deploy_jar/daemon_framework 2bb9107791ffe8fd0bd7a97667f6a2c85993e511 frameworks/deploy_jar/daemon_scheduler.py a919717a25b050b465202c1de7be6dfeb5720cfa frameworks/deploy_jar/haproxy.config.template 4d537e9abf29c34f9b709384a5f259c6108d05a2 frameworks/deploy_jar/hw.jar aa134596f5d4f8dd4c7a2b3c99b7ba9f18159965 frameworks/haproxy+apache/README.txt 37ccc1733a0689ab0eea802b91e76d8d7eb71a82 frameworks/haproxy+apache/haproxy+apache 05b975989fbec97d13eb0a181cd9d85c8c7c564e frameworks/haproxy+apache/haproxy+apache.py 39d4e7ba681b6437e978fadbf58e92e7e32345f1 frameworks/haproxy+apache/haproxy.config.template ca82ba998d645dbfb3b057afa873d1379543ff43 frameworks/haproxy+apache/startapache.py dce0ddd0e5bd655f9d745e88eefab1603a6a5e62 frameworks/haproxy+apache/startapache.sh 6eb24560130f5aa6eafb1ed6abecd8ab804e1e85 frameworks/mesos-submit/executor dd8b98c8a1971dd4b1a5504ba607f2d052837f22 frameworks/mesos-submit/executor.py 38813b9f9d151fa5293b710bc077075a5b1571cf frameworks/mesos-submit/mesos-submit 8cd5a674ced6a0441eb692db3bbf67a0f2bb7dfd frameworks/mesos-submit/mesos_submit.py 94d6232da504a86aca558b3655b3dc881e6d981d frameworks/torque/README.txt dd671e221dc448f89f593017fdcc81fae2ab9aa8 frameworks/torque/hpl-24node.qsub 3df1a45126e71c17fd642e90352eca733fbd0006 frameworks/torque/hpl-48node.qsub 105a7bbe4d4fdafd4984ec170790591a1a11160f frameworks/torque/hpl-8node-small.qsub b14dc95a172bcb61d3c631968106689dcc8b5172 frameworks/torque/hpl-8node.qsub b14dc95a172bcb61d3c631968106689dcc8b5172 frameworks/torque/mesos-hpl/24node/HPL.dat e9ab3fdc2295419a84540b9f0bd03b09a1527758 frameworks/torque/mesos-hpl/48node/HPL.dat d5c3e85b171698d86c8f588502b6a3839d23d248 frameworks/torque/mesos-hpl/8node-small/HPL.dat 941726c1d77534928d01cdbc5fc1a74c91cd635f frameworks/torque/mesos-hpl/8node/HPL.dat 250563c4d5a021119d89578110b32d4d031c3d04 frameworks/torque/mesos-hpl/Make.Linux_PII_CBLAS de646bab3bb26edbc086b245b407c190c6bbd77f frameworks/torque/mesos-hpl/README 17b7b3be298f2e9d8802e9a64b792a83a66551da frameworks/torque/mpi_example.c 3f3bcd08978aee7dc6803fabdbf171353a6728e8 frameworks/torque/start_pbs_mom.py ef8ed7cd8df8ff7d8c5e7720a823be6e967b121c frameworks/torque/start_pbs_mom.sh e0c81d0899e1f7a01590fec11cbc61e299ebef57 frameworks/torque/test_date_sleep_date_1node.qsub 99d91da292e950b72ca527fc6d94b924b1a57ea4 frameworks/torque/test_date_sleep_date_2node.qsub bd7ea0f6d737c5ec30f0930538e9484b691e0066 frameworks/torque/test_date_sleep_date_3node.qsub b8391da262ce2d5d01e63a4427b0614aeb59c2f3 frameworks/torque/test_date_sleep_date_5node_10sec.qsub c0e6d28e24b514d6b440f4b54b4db96ba55777a0 frameworks/torque/test_date_sleep_date_5node_60sec.qsub 17cd352ebeac5bbf5a68ed2d06e99a032ded35e4 frameworks/torque/torquelib.py b69df1c528c7ce32103d23e16bee8276cf3bffaf frameworks/torque/torquesched.py c22ef9180c3aaf447c0288ee4948d0c8067791b7 frameworks/torque/torquesched.sh a40c7eafd71a11c8f974aa49a612fa81d0016102 Diff: https://reviews.apache.org/r/33090/diff/ Testing --- make check Thanks, Jiang Yan Xu
Review Request 36010: Updated upgrades.md about Resource API changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36010/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2123 https://issues.apache.org/jira/browse/MESOS-2123 Repository: mesos Description --- Updated upgrades.md about Resource API changes. Diffs - docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c Diff: https://reviews.apache.org/r/36010/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36010: Updated upgrades.md about Resource API changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36010/#review89759 --- Ship it! Looking pretty good. Minor suggestions. docs/upgrades.md (line 17) https://reviews.apache.org/r/36010/#comment142552 s/meta data/metadata/g s/reservation/reservations/ s/object/objects/ Is this a Please do not or a you cannot or you must not? Will it error? Will things break? - Adam B On June 29, 2015, 11:16 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36010/ --- (Updated June 29, 2015, 11:16 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2123 https://issues.apache.org/jira/browse/MESOS-2123 Repository: mesos Description --- Updated upgrades.md about Resource API changes. Diffs - docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c Diff: https://reviews.apache.org/r/36010/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 6:49 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- minor touch-ups. Summary (updated) - MESOS-2942: Documentation for SSL. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- See summary. Diffs (updated) - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Review Request 36011: Updated CHANGELOG about the Resource API changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36011/ --- Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2123 https://issues.apache.org/jira/browse/MESOS-2123 Repository: mesos Description --- Updated CHANGELOG about the Resource API changes. Diffs - CHANGELOG bf383ab15fa974b5b649bb28637bf6f502e1f46d Diff: https://reviews.apache.org/r/36011/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36008: Updated upgrades.md about the new 'acceptOffers' API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36008/#review89758 --- Ship it! Looks good to me, although I wouldn't mind a mention of the decline API. docs/upgrades.md (line 15) https://reviews.apache.org/r/36008/#comment142549 Might also want to mention how (implicitly) declining full/partial offers plays into this API. Or is there fuller documentation/doxygen you could reference/link to? - Adam B On June 29, 2015, 10:58 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36008/ --- (Updated June 29, 2015, 10:58 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2481 https://issues.apache.org/jira/browse/MESOS-2481 Repository: mesos Description --- Updated upgrades.md about the new 'acceptOffers' API. Diffs - docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c Diff: https://reviews.apache.org/r/36008/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36008: Updated upgrades.md about the new 'acceptOffers' API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36008/ --- (Updated June 29, 2015, 6:30 p.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Changes --- Adam's comments. Bugs: MESOS-2481 https://issues.apache.org/jira/browse/MESOS-2481 Repository: mesos Description --- Updated upgrades.md about the new 'acceptOffers' API. Diffs (updated) - docs/upgrades.md 35e893cf7a1ad01d6298c0e7ecfa3bb084807f1c Diff: https://reviews.apache.org/r/36008/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36011: Updated CHANGELOG about the Resource API changes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36011/#review89760 --- Ship it! Fix the ordering, then we can ShipIt! CHANGELOG (lines 15 - 19) https://reviews.apache.org/r/36011/#comment142553 We usually order these numerically, rather than grouping them by feature/theme. - Adam B On June 29, 2015, 11:17 a.m., Jie Yu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36011/ --- (Updated June 29, 2015, 11:17 a.m.) Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone. Bugs: MESOS-2123 https://issues.apache.org/jira/browse/MESOS-2123 Repository: mesos Description --- Updated CHANGELOG about the Resource API changes. Diffs - CHANGELOG bf383ab15fa974b5b649bb28637bf6f502e1f46d Diff: https://reviews.apache.org/r/36011/diff/ Testing --- Thanks, Jie Yu
Re: Review Request 36005: Removed obsolete ec2 scripts.
On June 29, 2015, 11:42 a.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [36005] Failed command: ./bootstrap Error: autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --warnings=all -I m4 autoreconf: configure.ac: tracing configure.ac:46: warning: back quotes and double quotes must not be escaped in: unrecognized option: $[1] configure.ac:46: Try \`$[0] --help' for more information. aclocal.m4:625: LT_OUTPUT is expanded from... configure.ac:46: the top level configure.ac:46: warning: back quotes and double quotes must not be escaped in: unrecognized argument: $[1] configure.ac:46: Try \`$[0] --help' for more information. aclocal.m4:625: LT_OUTPUT is expanded from... configure.ac:46: the top level configure.ac:512: warning: cannot check for file existence when cross compiling ../../lib/autoconf/general.m4:2777: AC_CHECK_FILE is expanded from... configure.ac:512: the top level autoreconf: configure.ac: adding subdirectory 3rdparty/libprocess to autoreconf autoreconf: Entering directory `3rdparty/libprocess' configure.ac:29: warning: back quotes and double quotes must not be escaped in: unrecognized option: $[1] configure.ac:29: Try \`$[0] --help' for more information. aclocal.m4:625: LT_OUTPUT is expanded from... configure.ac:29: the top level configure.ac:29: warning: back quotes and double quotes must not be escaped in: unrecognized argument: $[1] configure.ac:29: Try \`$[0] --help' for more information. aclocal.m4:625: LT_OUTPUT is expanded from... configure.ac:29: the top level configure.ac:532: warning: cannot check for file existence when cross compiling ../../lib/autoconf/general.m4:2777: AC_CHECK_FILE is expanded from... configure.ac:532: the top level autoreconf: configure.ac: adding subdirectory 3rdparty/stout to autoreconf autoreconf: Entering directory `3rdparty/stout' autoreconf: running: aclocal --warnings=all autoreconf: configure.ac: not using Libtool autoreconf: running: /usr/bin/autoconf --warnings=all autoreconf: configure.ac: not using Autoheader autoreconf: running: automake --add-missing --copy --no-force --warnings=all configure.ac:10: installing './missing' autoreconf: Leaving directory `3rdparty/stout' autoreconf: running: libtoolize --copy libtoolize: putting auxiliary files in `.'. libtoolize: copying file `./ltmain.sh' libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'. libtoolize: copying file `m4/libtool.m4' libtoolize: copying file `m4/ltoptions.m4' libtoolize: copying file `m4/ltsugar.m4' libtoolize: copying file `m4/ltversion.m4' libtoolize: copying file `m4/lt~obsolete.m4' configure.ac:29: warning: back quotes and double quotes must not be escaped in: unrecognized option: $[1] configure.ac:29: Try \`$[0] --help' for more information. m4/libtool.m4:609: LT_OUTPUT is expanded from... configure.ac:29: the top level configure.ac:29: warning: back quotes and double quotes must not be escaped in: unrecognized argument: $[1] configure.ac:29: Try \`$[0] --help' for more information. m4/libtool.m4:609: LT_OUTPUT is expanded from... configure.ac:29: the top level configure.ac:532: warning: cannot check for file existence when cross compiling ../../lib/autoconf/general.m4:2777: AC_CHECK_FILE is expanded from... configure.ac:532: the top level configure.ac:22: installing './ar-lib' configure.ac:22: installing './compile' configure.ac:8: installing './config.guess' configure.ac:8: installing './config.sub' configure.ac:19: installing './missing' 3rdparty/Makefile.am:73: warning: source file '$(RY_HTTP_PARSER)/http_parser.c' is in a subdirectory, 3rdparty/Makefile.am:73: but option 'subdir-objects' is disabled automake: warning: possible forward-incompatibility. automake: At least a source file is in a subdirectory, but the 'subdir-objects' automake: automake option hasn't been enabled. For now, the corresponding output automake: object file(s) will be placed in the top-level directory. However, automake: this behaviour will change in future Automake versions: they will automake: unconditionally cause object files to be placed in the same subdirectory automake: of the corresponding sources. automake: You are advised to start using 'subdir-objects' option throughout your automake: project, to avoid future incompatibilities. 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/base64_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/bits_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but option 'subdir-objects' is disabled 3rdparty/Makefile.am:145: warning: source file '$(STOUT)/tests/bytes_tests.cpp' is in a subdirectory, 3rdparty/Makefile.am:145: but
Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 6:49 p.m.) Review request for mesos and Benjamin Hindman. Changes --- Factor out (now) un-used process reference from link_connect. Cleanup. Bugs: MESOS-2085 https://issues.apache.org/jira/browse/MESOS-2085 Repository: mesos Description --- Add a flag SSL_SUPPORT_DOWNGRADE which allows: 1. an SSL accepting socket to peek at the incoming data. If the hello handshake bits are not set, then accept as a Socket::POLL socket instead. 2. When calling Process::link or Process:send(Message), if a new connection is required, allow a second attempt using Socket::POLL if an SSL connection was first attempted. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff308 3rdparty/libprocess/src/libevent_ssl_socket.hpp 4f2cd357bfdb5268d2bae2df5d7138ff14064bf6 3rdparty/libprocess/src/libevent_ssl_socket.cpp 2920e0e1a5643118b14911d77fb682e60958b4e6 3rdparty/libprocess/src/openssl.hpp 60c7b078b891e09d53d82508bb2965addf359d68 3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8 3rdparty/libprocess/src/poll_socket.hpp 553aa641525d587a44608d7c6c4f16b09b47cfe0 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e 3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22 Diff: https://reviews.apache.org/r/31207/diff/ Testing --- Running with: 1) An SSL master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework 2) A non-ssl master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework Thanks, Joris Van Remoortere
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 9:50 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- Add section for webui and certificates. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description (updated) --- [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github rendered version Diffs (updated) - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 36022: Remove http specific protocol from master browse in webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/#review89797 --- Ship it! Ship It! - Adam B On June 29, 2015, 2:03 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/ --- (Updated June 29, 2015, 2:03 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47 Diff: https://reviews.apache.org/r/36022/diff/ Testing --- hit browse endpoint download button and verified in chrome tools that the url did not have `http:`. Thanks, Joris Van Remoortere
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 11:03 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Changes --- Fixed another typo. Repository: mesos Description --- See summary. Diffs (updated) - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89818 --- Ship it! Ship It! - Joris Van Remoortere On June 29, 2015, 11:03 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 11:03 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89788 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406, 31207, 36003] All tests passed. - Mesos ReviewBot On June 29, 2015, 6:49 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 6:49 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- See summary. Diffs - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89819 --- Ship it! Ship It! - Kapil Arya On June 29, 2015, 7:03 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 7:03 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Review Request 36018: Remove http specific protocol from master redirect.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36018/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - src/master/http.cpp 350383362311cfbc830965e1155a8515f0dfb332 Diff: https://reviews.apache.org/r/36018/diff/ Testing --- Still trying to set up an env to test this. Thanks, Joris Van Remoortere
Re: Review Request 36021: Disabled flaky HookTest::VerifySlaveLaunchExecutorHook test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36021/#review89801 --- Ship it! Ship It! - Ben Mahler On June 29, 2015, 9:02 p.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36021/ --- (Updated June 29, 2015, 9:02 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-2226 https://issues.apache.org/jira/browse/MESOS-2226 Repository: mesos Description --- The test is still flaky. Disabling it for now. Need to figure out a way to reproduce the failure locally. Diffs - src/tests/hook_tests.cpp 806ba039a23ab202075c530b184a6edb22ed9c3d Diff: https://reviews.apache.org/r/36021/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 10:21 p.m.) Review request for mesos and Benjamin Hindman. Changes --- updated swap_implementing_socket comment. Bugs: MESOS-2085 https://issues.apache.org/jira/browse/MESOS-2085 Repository: mesos Description --- Add a flag SSL_SUPPORT_DOWNGRADE which allows: 1. an SSL accepting socket to peek at the incoming data. If the hello handshake bits are not set, then accept as a Socket::POLL socket instead. 2. When calling Process::link or Process:send(Message), if a new connection is required, allow a second attempt using Socket::POLL if an SSL connection was first attempted. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff308 3rdparty/libprocess/src/libevent_ssl_socket.hpp 4f2cd357bfdb5268d2bae2df5d7138ff14064bf6 3rdparty/libprocess/src/libevent_ssl_socket.cpp 2920e0e1a5643118b14911d77fb682e60958b4e6 3rdparty/libprocess/src/openssl.hpp 60c7b078b891e09d53d82508bb2965addf359d68 3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8 3rdparty/libprocess/src/poll_socket.hpp 553aa641525d587a44608d7c6c4f16b09b47cfe0 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e 3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22 Diff: https://reviews.apache.org/r/31207/diff/ Testing --- Running with: 1) An SSL master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework 2) A non-ssl master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework Thanks, Joris Van Remoortere
Re: Review Request 36005: Removed obsolete ec2 scripts.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/#review89806 --- Patch looks great! Reviews applied: [36005] All tests passed. - Mesos ReviewBot On June 29, 2015, 7:20 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/ --- (Updated June 29, 2015, 7:20 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2640 https://issues.apache.org/jira/browse/MESOS-2640 Repository: mesos Description --- See summary. Diffs - Makefile.am dcd0cb474944ae9c882e6cbdb64a33b4be5b9083 configure.ac 92909580ea735a1ccffbe03a2eb44e3d07566488 docs/ec2-scripts.md 4866e2123eab0503bcc7fa130432bd41296d4b36 docs/tools.md f485abb9ff498c4faf51a4b84b23f438da3fc0d1 ec2/Makefile.am 8c64f485888df1599697eb181fc76aa83206da07 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/core-site.xml 565f54dd933a89eb966fb8b01c589e1008d543bf ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hadoop-env.sh 4e1e6991591e09f8860ab130948b0e787fce2b42 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/hdfs-site.xml 43e68aa3e2ecbb53bd3b0a99d33b11aadda2cca7 ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/mapred-site.xml b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/masters d26a1943aeb47ceeff904e593793e08c07eee9cc ec2/deploy.amazon64-old/root/ephemeral-hdfs/conf/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/mesos-ec2/cluster-url fcf8b41aed4b47a7b78d0c5a0042678f40059a5f ec2/deploy.amazon64-old/root/mesos-ec2/copy-dir 02b6e642f6348b3b4cdc4ff5adb2b0070c1dc1cc ec2/deploy.amazon64-old/root/mesos-ec2/create-swap 9ab32f841411f1053c29f0fa48f0cf2bbf468e82 ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/core-site.xml 818ed1030d3dd97467c4d4c83735cb7bda5afa80 ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/hadoop-env.sh ca227b460e9d6b89a2fe3692a74eb1c267bc7b7f ec2/deploy.amazon64-old/root/mesos-ec2/hadoop-framework-conf/mapred-site.xml 0ffa92f115d66adc9e370f4030850216545ade38 ec2/deploy.amazon64-old/root/mesos-ec2/haproxy+apache/haproxy.config.template 957c3f6a6b2a2f658e076337d88e69447b2a3341 ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/Capfile fd5921e57d7985e128622ed132c9a24c7cd21d1b ec2/deploy.amazon64-old/root/mesos-ec2/hypertable/hypertable.cfg b4d5b7475fab3d4a842e4b0f459abc5ca316996a ec2/deploy.amazon64-old/root/mesos-ec2/masters c531652dc1ef9e6d6ca73cec389b6433f35ae9cf ec2/deploy.amazon64-old/root/mesos-ec2/mesos-daemon 20ec099f521c97af569b98555ef67964cdcf97cc ec2/deploy.amazon64-old/root/mesos-ec2/redeploy-mesos 941d783d82f0708a6da0f4677c3364537dfded63 ec2/deploy.amazon64-old/root/mesos-ec2/setup 2165f90139d179d57b3d3b243d96fbea20a50b2c ec2/deploy.amazon64-old/root/mesos-ec2/setup-slave 436f417bc5a746ad74cc88c27e630a91d55b0b23 ec2/deploy.amazon64-old/root/mesos-ec2/setup-torque 2ac8fd3546063d3ba391147383de53b7824c7c8c ec2/deploy.amazon64-old/root/mesos-ec2/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/mesos-ec2/ssh-no-keychecking 3daf46fe988b4b7dac4879f4ea31b6ffca1dc02a ec2/deploy.amazon64-old/root/mesos-ec2/start-hypertable af16c2d7bd615cb0c98f6ba65ff5c69859678850 ec2/deploy.amazon64-old/root/mesos-ec2/start-mesos cc309cc44ecf5b67536f275083dca22948926f6b ec2/deploy.amazon64-old/root/mesos-ec2/stop-hypertable 7280dc11bfc53ae84b7ecaba34c84810461ed7f4 ec2/deploy.amazon64-old/root/mesos-ec2/stop-mesos 9fdb8753dffc5115f94582753e0860538be6232b ec2/deploy.amazon64-old/root/mesos-ec2/zoo efc961b502f30a6f187f7e50c2b92b302203d89e ec2/deploy.amazon64-old/root/persistent-hdfs/conf/core-site.xml b23aef258a13e4bc4cbf27099f7aa68419ab0825 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hadoop-env.sh b38ba01817e3b9c9715a476ecb692bac68983f50 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/hdfs-site.xml ec000cb2f306232a29cf701b10f230685d2662c9 ec2/deploy.amazon64-old/root/persistent-hdfs/conf/mapred-site.xml b1637dc8ce9cb49ebaa684a182cc8c94ac7c1b7b ec2/deploy.amazon64-old/root/persistent-hdfs/conf/masters d26a1943aeb47ceeff904e593793e08c07eee9cc ec2/deploy.amazon64-old/root/persistent-hdfs/conf/slaves 05f969e0c667629041099e97dd8d6a8168e211a1 ec2/deploy.amazon64-old/root/spark/conf/spark-env.sh 86da7f832d03dfc6cc0be5e479fea7d8f92541e0 ec2/deploy.amazon64/root/ephemeral-hdfs/conf/core-site.xml 565f54dd933a89eb966fb8b01c589e1008d543bf ec2/deploy.amazon64/root/ephemeral-hdfs/conf/hadoop-env.sh
Review Request 36022: Remove http specific protocol from master browse in webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47 Diff: https://reviews.apache.org/r/36022/diff/ Testing --- hit browse endpoint download button and verified in chrome tools that the url did not have `http:`. Thanks, Joris Van Remoortere
Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36023/ --- Review request for mesos and Ian Downes. Repository: mesos Description --- Improved the documentation of Containerizer::launch() to clarify the failure cases. Diffs - src/slave/containerizer/containerizer.hpp 0ee17e6bc52d1e3acefad6bda3a1b7ba64a8a54b Diff: https://reviews.apache.org/r/36023/diff/ Testing --- N/A Thanks, Jiang Yan Xu
Review Request 36021: Disabled flaky HookTest::VerifySlaveLaunchExecutorHook test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36021/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2226 https://issues.apache.org/jira/browse/MESOS-2226 Repository: mesos Description --- The test is still flaky. Disabling it for now. Need to figure out a way to reproduce the failure locally. Diffs - src/tests/hook_tests.cpp 806ba039a23ab202075c530b184a6edb22ed9c3d Diff: https://reviews.apache.org/r/36021/diff/ Testing --- Thanks, Kapil Arya
Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/#review89795 --- Patch looks great! Reviews applied: [36014] All tests passed. - Mesos ReviewBot On June 29, 2015, 6:58 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/ --- (Updated June 29, 2015, 6:58 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2956 https://issues.apache.org/jira/browse/MESOS-2956 Repository: mesos Description --- Fixed stack trace in isolator tests on Linux VM Diffs - src/tests/isolator_tests.cpp 525a5a88b8ab0681a89c5f7451d9ca9031c793af Diff: https://reviews.apache.org/r/36014/diff/ Testing --- sudo make check Thanks, Paul Brett
Re: Review Request 36022: Remove http specific protocol from master browse in webui.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/#review89813 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406, 31207, 36003, 36018, 36022] All tests passed. - Mesos ReviewBot On June 29, 2015, 9:03 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36022/ --- (Updated June 29, 2015, 9:03 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos Description --- See summary. Diffs - src/webui/master/static/browse.html ce55d6b56b37f8884b82d92a1e10fd9a59140f47 Diff: https://reviews.apache.org/r/36022/diff/ Testing --- hit browse endpoint download button and verified in chrome tools that the url did not have `http:`. Thanks, Joris Van Remoortere
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89817 --- src/slave/flags.cpp (line 284) https://reviews.apache.org/r/36026/#comment142611 s/that // or s/that the/ that of the/ - Kapil Arya On June 29, 2015, 6:56 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 6:56 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89816 --- Valid typo. Improper fix. You could try again, or I could just push the right fix. src/slave/flags.cpp (line 284) https://reviews.apache.org/r/36026/#comment142610 s/that // - Adam B On June 29, 2015, 3:56 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 3:56 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 6:36 a.m.) Review request for mesos and Benjamin Hindman. Changes --- Prevent ExitedEvents and update socketmanager data transition during socket downgrade. Bugs: MESOS-2085 https://issues.apache.org/jira/browse/MESOS-2085 Repository: mesos Description --- Add a flag SSL_SUPPORT_DOWNGRADE which allows: 1. an SSL accepting socket to peek at the incoming data. If the hello handshake bits are not set, then accept as a Socket::POLL socket instead. 2. When calling Process::link or Process:send(Message), if a new connection is required, allow a second attempt using Socket::POLL if an SSL connection was first attempted. Diffs (updated) - 3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff308 3rdparty/libprocess/src/libevent_ssl_socket.hpp 4f2cd357bfdb5268d2bae2df5d7138ff14064bf6 3rdparty/libprocess/src/libevent_ssl_socket.cpp 2920e0e1a5643118b14911d77fb682e60958b4e6 3rdparty/libprocess/src/openssl.hpp 60c7b078b891e09d53d82508bb2965addf359d68 3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8 3rdparty/libprocess/src/poll_socket.hpp 553aa641525d587a44608d7c6c4f16b09b47cfe0 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e 3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22 Diff: https://reviews.apache.org/r/31207/diff/ Testing --- Running with: 1) An SSL master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework 2) A non-ssl master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework Thanks, Joris Van Remoortere
Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.
On June 25, 2015, 7:30 p.m., Adam B wrote: Nice work! So, running the command as root first will guarantee that lt-mesos-executor exists before trying to run the task as the test-user `nobody`? We might be able to fix this in a cleaner way, but this looks good enough to me. Just fix the few minor points I raised and update the comments, and then I'll commit it. Please fill out the Testing Done section to explain how you verified that this test failed before your change and now passes. haosdent huang wrote: @adam-mesos, Thank you very much for your review. You metioned that `We might be able to fix this in a cleaner way`, could you tell me more details about it? I think use a more cleaner way to fix this problem could make us maintain this test case more easier. I'm not sure exactly how we would do this cleaner yet. Maybe use a SetUp/TearDown method that could create `lt-mesos-executor` before the test and then remove it afterwards. But I would call this shippable for now since it does indeed fix the test. We could clean it up later if we come up with something more elegant. - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/#review89458 --- On June 27, 2015, 9:37 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 27, 2015, 9:37 a.m.) Review request for mesos and Adam B. Bugs: MESOS-2199 https://issues.apache.org/jira/browse/MESOS-2199 Repository: mesos Description --- Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser. Diffs - src/tests/slave_tests.cpp e9002e807b500503c5bccf7ce638d98643f229ed Diff: https://reviews.apache.org/r/35728/diff/ Testing --- ### 1. Reproduce problem in old code ```bash # Enter mesos source directory and remove build directory cd mesos rm -rf build # Rebuild mesos mkdir -p build ./bootstrap cd build ../configure # Run the single test make -j8 check GTEST_FILTER=SlaveTest.ROOT_RunTaskWithCommandInfoWithUser ``` When running this test case, the mesos containier running under user `nobody`. And when the containier start `build/src/mesos-executor`, `build/src/mesos-executor` would check the `build/src/.libs/lt-mesos-executor` exists or not. Because we never running other test cases before, `build/src/.libs/lt-mesos-executor` is not exists here. And then `build/src/mesos-executor` would try to compile and generate `build/src/.libs/lt-mesos-executor`. Because `build/src/mesos-executor` is running under user `nobody`, it don't have permissions to output files to `build` directory. This test cases failed finally. ### 2. My way to fix this problem I start a prepare task with root first. And after this task finished with success, we could sure that `build/src/.libs/lt-mesos-executor` is exists. So when we start `build/src/mesos-executor` with user `nobody`, it not need to generate `build/src/.libs/lt-mesos-executor`. And then it could finish its tasks successfully. Thanks, haosdent huang
Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035 https://issues.apache.org/jira/browse/MESOS-2035 Repository: mesos Description --- [WIP] -need to add documentation -need to add test -not all potential paths are covered. It is not clear whether isolator sees event before the kill, see first comment in CgroupsMemIsolatorProcess::oom in mem.cpp. Diffs (updated) - docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b include/mesos/containerizer/containerizer.proto f16ccc89f83da28c413ccfa0687a06b7515a605c include/mesos/mesos.proto 81008ed85daea798ed19d1031de8421a7dc3fb19 include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 src/slave/slave.cpp b8591116eadcd68b8db2a629fbcf793e6b394f14 src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad
Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89715 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 2017) https://reviews.apache.org/r/35919/#comment142395 Might return all kinds of HTTP return codes, no? 3rdparty/libprocess/src/process.cpp (line 2019) https://reviews.apache.org/r/35919/#comment142396 Use that HTTP status code here instead of `body` to make sure we always (also in the future) get a nice log output (mind there may even be HTML within the body). 3rdparty/libprocess/src/process.cpp (line 2029) https://reviews.apache.org/r/35919/#comment142400 How about adding a `CHECK(rejection.get() != NULL)` here somewhere? - Till Toenshoff On June 26, 2015, 10:18 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 26, 2015, 10:18 a.m.) Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-2877 https://issues.apache.org/jira/browse/MESOS-2877 Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/include/process/firewall.hpp f71d6541e48e2481c69f401b388977b153503962 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e Diff: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.
On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/containerizer/containerizer.proto, lines 87-89 https://reviews.apache.org/r/35927/diff/1/?file=993029#file993029line87 Why do we need a deprecation cycle for this? AFAIK, it's part of the containerizer API only and I'm not aware of any third-party containers. Joerg Schad wrote: I believe we need more discussion on how that will effect upgradedabilty. Created [Mesos-2954](https://issues.apache.org/jira/browse/MESOS-2954) for further discussion. Maybe you're right, it's a `required` field. Let's discuss it on JIRA; dropping for now. On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/slave/isolator.hpp, line 64 https://reviews.apache.org/r/35927/diff/1/?file=993031#file993031line64 AFAIK, techinally, limitation does not necessarily end in termination, though it is so for `MesosContainerizer`. Also, I'm not sure that reusing `TaskStatus::Reason` enum is a good idea: it includes much more stuff that is not related to limitations. Joerg Schad wrote: If I understand the description of Limitation correctly, it indicates a termination of the executor (see https://github.com/apache/mesos/blob/1a82a3fb2bc717c468218384190a115b770f88c3/include/mesos/slave/isolator.hpp#L42). BTW fixed the typo. It's true, but take a look at how the isolation is implemented: an isolator watches executor, generates a limitation, which triggers `limited()` callback on containerizer. I still would argue that we should separate two concepts: limitation event and reaction to it (which is termination in case of `MesosContainerizer`, but it's up to `limited()` callback). - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89667 --- On June 29, 2015, 7:22 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035 https://issues.apache.org/jira/browse/MESOS-2035 Repository: mesos Description --- [WIP] -need to add documentation -need to add test -not all potential paths are covered. It is not clear whether isolator sees event before the kill, see first comment in CgroupsMemIsolatorProcess::oom in mem.cpp. Diffs - docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b include/mesos/containerizer/containerizer.proto f16ccc89f83da28c413ccfa0687a06b7515a605c include/mesos/mesos.proto 81008ed85daea798ed19d1031de8421a7dc3fb19 include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 src/slave/slave.cpp b8591116eadcd68b8db2a629fbcf793e6b394f14 src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad
Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89717 --- Patch looks great! Reviews applied: [35927] All tests passed. - Mesos ReviewBot On June 29, 2015, 7:22 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035 https://issues.apache.org/jira/browse/MESOS-2035 Repository: mesos Description --- [WIP] -need to add documentation -need to add test -not all potential paths are covered. It is not clear whether isolator sees event before the kill, see first comment in CgroupsMemIsolatorProcess::oom in mem.cpp. Diffs - docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b include/mesos/containerizer/containerizer.proto f16ccc89f83da28c413ccfa0687a06b7515a605c include/mesos/mesos.proto 81008ed85daea798ed19d1031de8421a7dc3fb19 include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 src/slave/slave.cpp b8591116eadcd68b8db2a629fbcf793e6b394f14 src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad
Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89710 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529, 29530, 29531, 29532, 29533, 29534, 29535, 29536, 29538, 29539, 29540, 29569, 28763, 29406, 31207] All tests passed. - Mesos ReviewBot On June 29, 2015, 6:36 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 6:36 a.m.) Review request for mesos and Benjamin Hindman. Bugs: MESOS-2085 https://issues.apache.org/jira/browse/MESOS-2085 Repository: mesos Description --- Add a flag SSL_SUPPORT_DOWNGRADE which allows: 1. an SSL accepting socket to peek at the incoming data. If the hello handshake bits are not set, then accept as a Socket::POLL socket instead. 2. When calling Process::link or Process:send(Message), if a new connection is required, allow a second attempt using Socket::POLL if an SSL connection was first attempted. Diffs - 3rdparty/libprocess/include/process/socket.hpp f53d2e1dbb31e135c8951145d379cbbff308 3rdparty/libprocess/src/libevent_ssl_socket.hpp 4f2cd357bfdb5268d2bae2df5d7138ff14064bf6 3rdparty/libprocess/src/libevent_ssl_socket.cpp 2920e0e1a5643118b14911d77fb682e60958b4e6 3rdparty/libprocess/src/openssl.hpp 60c7b078b891e09d53d82508bb2965addf359d68 3rdparty/libprocess/src/openssl.cpp 6ff4adb4c9792ff10d8c6ed2f3b2f3d8d0d7f1a8 3rdparty/libprocess/src/poll_socket.hpp 553aa641525d587a44608d7c6c4f16b09b47cfe0 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e 3rdparty/libprocess/src/tests/ssl_tests.cpp c077aaeaecbe2cdcdad2b042741eeb8906699a22 Diff: https://reviews.apache.org/r/31207/diff/ Testing --- Running with: 1) An SSL master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework 2) A non-ssl master - connect a non-ssl slave - connect a non-ssl framework - connect an ssl slave - connect an ssl framework Thanks, Joris Van Remoortere
Re: Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36023/#review89825 --- Patch looks great! Reviews applied: [36023] All tests passed. - Mesos ReviewBot On June 29, 2015, 9:29 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36023/ --- (Updated June 29, 2015, 9:29 p.m.) Review request for mesos and Ian Downes. Repository: mesos Description --- Improved the documentation of Containerizer::launch() to clarify the failure cases. Diffs - src/slave/containerizer/containerizer.hpp 0ee17e6bc52d1e3acefad6bda3a1b7ba64a8a54b Diff: https://reviews.apache.org/r/36023/diff/ Testing --- N/A Thanks, Jiang Yan Xu
Re: Review Request 32982: Added reservation user guide.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89824 --- Looks great! I know this is already committed, but I had a few questions/clarifications. Maybe you've answered these elsewhere, but I've been out of the loop for a while. docs/reservation.md (line 108) https://reviews.apache.org/r/32982/#comment142624 I know that we'll want to explicitly specify the role to support future multi-role frameworks, but why does this need to be included now? docs/reservation.md (lines 109 - 110) https://reviews.apache.org/r/32982/#comment142623 Shouldn't the master be able to determine the principal that this frameworkId is currently authenticated as? Why even allow the framework to specify a different principal if you're just going to Error? docs/reservation.md (line 196) https://reviews.apache.org/r/32982/#comment142625 Could also only unreserve a subset, right? docs/reservation.md (line 248) https://reviews.apache.org/r/32982/#comment142626 Again, if we're already authenticating as a certain principal in the request, why do we need to explicitly specify a (potentially different?) principal in the resources message? docs/reservation.md (line 309) https://reviews.apache.org/r/32982/#comment142627 How can there be insufficient resources to unreserve? - Adam B On June 27, 2015, 8:33 p.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 27, 2015, 8:33 p.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md) Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 36026: Fixed typo in slave flags.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/#review89820 --- Ship it! Ship It! - Adam B On June 29, 2015, 4:03 p.m., Brendan Chang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36026/ --- (Updated June 29, 2015, 4:03 p.m.) Review request for mesos, Benjamin Hindman and Joris Van Remoortere. Repository: mesos Description --- See summary. Diffs - src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 Diff: https://reviews.apache.org/r/36026/diff/ Testing --- Thanks, Brendan Chang
Re: Review Request 35981: Added persistent volume user guide.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/#review89827
---
Nice work! Just a few cleanups and questions/clarifications.
docs/persistent-volume.md (line 16)
https://reviews.apache.org/r/35981/#comment142630
s/containig/containing/
docs/persistent-volume.md (line 20)
https://reviews.apache.org/r/35981/#comment142631
s/Reservation/the Reservation doc/
docs/persistent-volume.md (line 56)
https://reviews.apache.org/r/35981/#comment142632
Can a volume/reservation created by one framework principal only be
destroyed/unreserved by a framework scheduler using the same principal? If the
principal is different, then the operation would fail, even if the role or even
frameworkId is identical?
docs/persistent-volume.md (lines 67 - 69)
https://reviews.apache.org/r/35981/#comment142633
You might need a blank line preceding this, and/or some indentation for it
to show up as a numbered list. Doesn't render properly as is.
Unique per role per slave? So I could use the same volumeId for related
volume instances (e.g. my 'logging' or 'data' volumes), up to a max of one per
slave? But if I happen to launch another executor/task on a slave where one of
those volumes is already created/mounted, then I have to rename it ('data2')?
docs/persistent-volume.md (lines 120 - 122)
https://reviews.apache.org/r/35981/#comment142635
Any chance it could return the host_path too? Or do I have to go digging
through slave logs to figure out where my volume was created?
docs/persistent-volume.md (lines 135 - 136)
https://reviews.apache.org/r/35981/#comment142637
Even after you destroy the volume, it still won't be garbage-collected in
0.23. Coming Soon: https://issues.apache.org/jira/browse/MESOS-2408
docs/persistent-volume.md (line 169)
https://reviews.apache.org/r/35981/#comment142641
There is no `volumes` field. Just a `resources` field, where each resource
in the list must contain a `disk.volume` to be destroyed.
- Adam B
On June 27, 2015, 8:35 p.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/
---
(Updated June 27, 2015, 8:35 p.m.)
Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
Bugs: MESOS-2405
https://issues.apache.org/jira/browse/MESOS-2405
Repository: mesos
Description
---
The Github rendered version is available [here](
https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md)
Diffs
-
docs/persistent-volume.md PRE-CREATION
Diff: https://reviews.apache.org/r/35981/diff/
Testing
---
Documentation.
Thanks,
Michael Park
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89833 --- Great job! Some minor suggestions/rewordings, but I'd say it's nearly shippable. docs/mesos-ssl.md (line 8) https://reviews.apache.org/r/36003/#comment142655 fetching? How about When building Mesos from source, s/0.23/0.23.0/ docs/mesos-ssl.md (line 15) https://reviews.apache.org/r/36003/#comment142659 `Framework` or `Framework Scheduler/Executor`? docs/mesos-ssl.md (line 21) https://reviews.apache.org/r/36003/#comment142663 If this is enabled __on the accepting side__, then the accepting side will downgrade... What is the default value? (for this and other variables?) docs/mesos-ssl.md (line 30) https://reviews.apache.org/r/36003/#comment142665 s/This is overridden...required./When `SSL_REQUIRE_CERT` is true, `SSL_VERIFY_CERT` is overridden and all certificates will be verified _and_ required./ docs/mesos-ssl.md (line 33) https://reviews.apache.org/r/36003/#comment142667 s/grabbing/hitting/ docs/mesos-ssl.md (line 36) https://reviews.apache.org/r/36003/#comment142668 s/,// s/admins/administrator/ s/for why/to learn why/ docs/mesos-ssl.md (line 42) https://reviews.apache.org/r/36003/#comment142669 s/Thefile/The file/ docs/mesos-ssl.md (line 45) https://reviews.apache.org/r/36003/#comment142670 s/`:` separated/`:`-separated/ docs/mesos-ssl.md (lines 58 - 59) https://reviews.apache.org/r/36003/#comment142671 Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well) docs/mesos-ssl.md (line 64) https://reviews.apache.org/r/36003/#comment142672 code s/'openssl`/`openssl`/ /code docs/mesos-ssl.md (line 83) https://reviews.apache.org/r/36003/#comment142673 s/in-secure/insecure/ docs/mesos-ssl.md (line 85) https://reviews.apache.org/r/36003/#comment142674 s/Webui/WebUI/ docs/mesos-ssl.md (line 86) https://reviews.apache.org/r/36003/#comment142675 s/SSL enabled/SSL-enabled/ s/or not// - Adam B On June 29, 2015, 2:50 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 29, 2015, 2:50 p.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github rendered version Diffs - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35961: Include protobuf classes in generated Javadoc.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/#review89839 --- Ship it! Ship It! - Adam B On June 29, 2015, 8:53 a.m., Connor Doyle wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35961/ --- (Updated June 29, 2015, 8:53 a.m.) Review request for mesos, Adam B and Ben Whitehead. Bugs: MESOS-1552 https://issues.apache.org/jira/browse/MESOS-1552 Repository: mesos-incubating Description --- Updates the Java POM to include the generated Java protobuf classes. Diffs - src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903 src/java/mesos.pom.in 138da55 src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60 Diff: https://reviews.apache.org/r/35961/diff/ Testing --- - configure - make - Manual verification of generated Javadoc HTML Thanks, Connor Doyle
Re: Review Request 34646: Redirect to the leader master when current master is not a leader.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review89799 --- Looks great, thanks! I still wonder if we can remove some of the duplication between redirect() and redirectRequestToLeader(). Otherwise just minor feedback. src/master/http.cpp (line 424) https://reviews.apache.org/r/34646/#comment142698 Is there a way you could reuse all or part of Http::redirect()? Seems like a lot of copy/paste. src/master/http.cpp (line 427) https://reviews.apache.org/r/34646/#comment142694 Nit: Comments should end in punctuation. src/master/http.cpp (lines 429 - 433) https://reviews.apache.org/r/34646/#comment142695 Please wrap at 80 characters. Suggested rewording: Current master is not elected as leader, and leader information is unavailable. Failed to redirect the request url: request.url src/master/http.cpp (line 434) https://reviews.apache.org/r/34646/#comment142696 Why not a 503 Service Unavailable, meaning The server is currently unavailable (because it is overloaded or down for maintenance). Generally, this is a temporary state.? src/master/http.cpp (lines 438 - 441) https://reviews.apache.org/r/34646/#comment142697 Please wrap at 80 characters. Suggested rewording: Current master is not elected leader. Redirecting the request url request.url to the leading master hostname src/master/http.cpp (line 454) https://reviews.apache.org/r/34646/#comment142596 Remove http:, like we're doing for the rest of https/SSL support. See https://reviews.apache.org/r/36018/diff src/master/http.cpp (line 471) https://reviews.apache.org/r/34646/#comment142699 s/leader master/leading master/g src/master/master.hpp (line 1096) https://reviews.apache.org/r/34646/#comment142700 s/Reredirect/Redirect/ s/leader master/leading master/ - Adam B On June 1, 2015, 8:07 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/ --- (Updated June 1, 2015, 8:07 a.m.) Review request for mesos and Adam B. Bugs: MESOS-1865 https://issues.apache.org/jira/browse/MESOS-1865 Repository: mesos Description --- Return empty task list when current master is not a leader. Diffs - src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 Diff: https://reviews.apache.org/r/34646/diff/ Testing --- make check when current master is not a leader, it would redirect to the leader master. ``` $ curl -i http://master1:5050/master/tasks.json HTTP/1.1 307 Temporary Redirect Date: Mon, 01 Jun 2015 06:30:08 GMT Location: http://master2:5050//master/tasks.json Content-Length: 0 ``` Thanks, haosdent huang
Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.
On June 29, 2015, 6:41 p.m., Jie Yu wrote: Thanks guys! haosdent, can you follow up with a unit test for this change? Sure. Let me write it now. Thank you for your help again. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89766 --- On June 29, 2015, 2:36 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 29, 2015, 2:36 a.m.) Review request for mesos, Adam B, Jie Yu, and Marco Massenzio. Bugs: MESOS-2603 https://issues.apache.org/jira/browse/MESOS-2603 Repository: mesos Description --- Set the ownership of persistent volume to match the sandbox directory. Diffs - src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 Diff: https://reviews.apache.org/r/35721/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 35711: Disallow special characters in role name.
On June 29, 2015, 11:17 a.m., Adam B wrote: src/common/validation.hpp, lines 27-34 https://reviews.apache.org/r/35711/diff/7/?file=993941#file993941line27 I'm not convinced this is the right namespace/scope for a freestanding validate() function. Maybe, like we have a Resource protobuf message and a Resources class with parse() and validate(), we should also have a Roles::validate(). Jie Yu wrote: +1 Initially, the patch only contains validation at the master's side, and that's the reason I sugguested to put that into master/validation.hpp|cpp. I agree with Adam that putting that in Roles. Sorry about that! Thank you for your review. Let me update it. @jieyu @adam-mesos - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 --- On June 27, 2015, 11:35 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 27, 2015, 11:35 a.m.) Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2210 https://issues.apache.org/jira/browse/MESOS-2210 Repository: mesos Description --- Disallow special characters in role name. Diffs - src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 src/common/validation.hpp PRE-CREATION src/common/validation.cpp PRE-CREATION src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 src/tests/common/validation_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e Diff: https://reviews.apache.org/r/35711/diff/ Testing --- make -j8 check Thanks, haosdent huang
Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review89425
---
src/slave/containerizer/mesos/launch.cpp (lines 64 - 65)
https://reviews.apache.org/r/31444/#comment142621
must be relative to is really is interpreted as relative to right?
Just wanted be sure clarify:
1) Should the user specify an absolute path with a preceding /?
2) The directory path as observed by processes outside the choot jail is
`path::join(rootfs, directory)` right?
src/slave/containerizer/mesos/launch.cpp (lines 259 - 260)
https://reviews.apache.org/r/31444/#comment142612
This must be an absolute path
As in, if the flags specifies a path without a preceding slash this throws
an error?
This is not enforced is it?
- Jiang Yan Xu
On June 22, 2015, 9:38 a.m., Ian Downes wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/
---
(Updated June 22, 2015, 9:38 a.m.)
Review request for mesos, Chi Zhang, Dominic Hamon, Jay Buffington, Jie Yu,
and James Peach.
Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350
Repository: mesos
Description
---
Optionally take a path that the launch helper should chroot to before
exec'ing the executor. It is assumed that the work directory is mounted to
the appropriate location under the chroot. In particular, the path to the
executor must be relative to the chroot.
Configuration that should be private to the chroot is done during the launch,
e.g. mounting proc and statically configuring basic devices. It is assumed
that other configuration, e.g., preparing the image, mounting in volumes or
persistent resources, is done by the caller.
Mounts can be made to the chroot (e.g., updating the volumes or persistent
resources) and they will propagate in to the container but mounts made inside
the container will not propagate out to the host.
It currently assumes that at least {{chroot}}/tmp is writeable and that mount
points {{chroot}}/{tmp,dev,proc,sys} exist in the chroot.
This is specific to Linux.
Diffs
-
src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573
src/linux/fs.cpp 568565f878b34708170a886dc4d62849aa01f263
src/slave/containerizer/mesos/launch.hpp
7c8b535746b5ce9add00afef86fdb6faefb5620e
src/slave/containerizer/mesos/launch.cpp
2f2d60e2011f60ec711d3b29fd2c157e30c83c34
src/tests/launch_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/31444/diff/
Testing
---
Manual testing only so far. This is harder to automate because we need a
self-contained chroot to execute something in... Suggestions welcome.
Thanks,
Ian Downes
Re: Review Request 35958: Updated SlaveTest.PingTimeoutNoPings test to use custom timeout values.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35958/#review89843 --- Ship it! Thank you! src/tests/slave_tests.cpp (lines 1467 - 1472) https://reviews.apache.org/r/35958/#comment142684 Any reason not to just be explicit and use: ``` // Set custom timeout values to verify the 'Connection' message. master::Flags masterFlags = CreateMasterFlags(); masterFlags.slave_ping_timeout = Seconds(10); masterFlags.max_slave_ping_timeouts = 2u; ``` Avoids the need for math in the comment :) src/tests/slave_tests.cpp (lines 1471 - 1472) https://reviews.apache.org/r/35958/#comment142685 Mind moving this down or just inlining it in the EXPECT below? If you keep it, how about s/masterTimeout/totalTimeout/ ? src/tests/slave_tests.cpp (lines 1490 - 1491) https://reviews.apache.org/r/35958/#comment142687 How about pulling out Connection? ``` ASSERT_TRUE(slaveRegisteredMessage.get().has_connection()); MasterSlaveConnection connection = slaveRegisteredMessage.get().connection(); EXPECT_EQ(totalTimeout, Duration(connection.total_ping_timeout_seconds()); ``` - Ben Mahler On June 27, 2015, 12:46 a.m., Adam B wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35958/ --- (Updated June 27, 2015, 12:46 a.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- Updated SlaveTest.PingTimeoutNoPings test to use custom timeout values. Diffs - src/tests/slave_tests.cpp e9002e807b500503c5bccf7ce638d98643f229ed Diff: https://reviews.apache.org/r/35958/diff/ Testing --- Modified test passes after configurable ping timeout patch is applied. Thanks, Adam B
Re: Review Request 32982: Added reservation user guide.
On June 28, 2015, 11:36 p.m., Benjamin Hindman wrote: I made a few minor tweaks here before committing. (1) Replaced the fenced code blocks with indented code blocks so that the doxygen generated markdown was readable. (2) Made all the 'Coming Soon' be styled consistently (I went with one _, if you'd prefer the ___ underscore instead we can swap). (3) Made the shell examples be copyable to an actual shell by adding line continuations, i.e., \. Thanks for doing that Ben, (1) Thanks, (2) Yeah, I left it as _ in the header because the boldness part didn't seem to have any effect in its rendering. I would probably prefer the ___ since that's what we use in `Getting Started` as well for (___Recommended___) and, (___Advanced Users Only___) (3) Sweet! - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89689 --- On June 28, 2015, 3:33 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/ --- (Updated June 28, 2015, 3:33 a.m.) Review request for mesos, Alexander Rukletsov, Jie Yu, and Timothy Chen. Bugs: MESOS-2205 https://issues.apache.org/jira/browse/MESOS-2205 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/reservation.md) Diffs - docs/reservation.md PRE-CREATION Diff: https://reviews.apache.org/r/32982/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 30, 2015, 5:47 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Changes --- address wording issues. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github rendered version Diffs (updated) - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 35981: Added persistent volume user guide.
On June 29, 2015, 7:09 p.m., Jie Yu wrote: docs/persistent-volume.md, lines 23-24 https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line23 We don't store 'principal' in DiskInfo yet. Maybe add a coming soon somewhere as well? I put it at the end actually. Do you think it would read better if we maybe put it at the beginning? Persistent volumes can be created by __operators__ and authorized __frameworks__. We require a `principal` from the operator or framework in order to authenticate/authorize the operations. [Authorization](authorization.md) is specified via the existing ACL mechanism. (___Coming Soon___) Persistent volumes can be created by __operators__ and authorized __frameworks__. ___Coming Soon___: We require a `principal` from the operator or framework in order to authenticate/authorize the operations. [Authorization](authorization.md) is specified via the existing ACL mechanism. On June 29, 2015, 7:09 p.m., Jie Yu wrote: docs/persistent-volume.md, lines 67-69 https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line67 The numbering is not correct:) This is actually a markdown feature I learned about: ``` It’s important to note that the actual numbers you use to mark the list have no effect on the HTML output Markdown produces. The HTML Markdown produces from the above list is: ol liBird/li liMcHale/li liParish/li /ol If you instead wrote the list in Markdown like this: 1. Bird 1. McHale 1. Parish or even: 3. Bird 1. McHale 8. Parish you’d get the exact same HTML output. ``` It allows us to not have to update all of the other numbers if we were to add more items, remove an item or even rearrange them. It's already used in `docs/release-guide.md` at the end: `Update external tooling`. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89773 --- On June 28, 2015, 3:35 a.m., Michael Park wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/ --- (Updated June 28, 2015, 3:35 a.m.) Review request for mesos, Adam B, Jie Yu, and Timothy Chen. Bugs: MESOS-2405 https://issues.apache.org/jira/browse/MESOS-2405 Repository: mesos Description --- The Github rendered version is available [here]( https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md) Diffs - docs/persistent-volume.md PRE-CREATION Diff: https://reviews.apache.org/r/35981/diff/ Testing --- Documentation. Thanks, Michael Park
Re: Review Request 35981: Added persistent volume user guide.
On June 30, 2015, 12:14 a.m., Adam B wrote:
docs/persistent-volume.md, line 169
https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line169
There is no `volumes` field. Just a `resources` field, where each
resource in the list must contain a `disk.volume` to be destroyed.
I was actually referring to:
```
message Create {
repeated Resource volumes = 1;
}
```
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/#review89827
---
On June 30, 2015, 5:50 a.m., Michael Park wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/
---
(Updated June 30, 2015, 5:50 a.m.)
Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
Bugs: MESOS-2405
https://issues.apache.org/jira/browse/MESOS-2405
Repository: mesos
Description
---
The Github rendered version is available [here](
https://github.com/mesosphere/mesos/blob/user-docs/docs/persistent-volume.md)
Diffs
-
docs/persistent-volume.md PRE-CREATION
Diff: https://reviews.apache.org/r/35981/diff/
Testing
---
Documentation.
Thanks,
Michael Park
Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89854 --- Ship it! Minor points, but otherwise shippable. I guess I'm still a little confused by the motivation. When would the firewall filter rule have more information about how to respond than the caller would? Can you give an example? 3rdparty/libprocess/include/process/firewall.hpp (line 57) https://reviews.apache.org/r/35919/#comment142703 s/and/an/ s/option/Option/ Maybe worth clarifying that you do not return 200 OK for rules that apply cleanly. 3rdparty/libprocess/include/process/firewall.hpp (line 59) https://reviews.apache.org/r/35919/#comment142707 So if the caller wants to override the Response, they should check for a specific response type, extract the error message, and then handle it appropriately? 3rdparty/libprocess/include/process/firewall.hpp (line 86) https://reviews.apache.org/r/35919/#comment142711 How about `Forbidden(Endpoint ' + request.path + ' is disabled)` so you don't start the message with a path. 3rdparty/libprocess/src/process.cpp (lines 2019 - 2020) https://reviews.apache.org/r/35919/#comment142712 You're not logging the Response body anymore? - Adam B On June 29, 2015, 3:21 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 29, 2015, 3:21 a.m.) Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-2877 https://issues.apache.org/jira/browse/MESOS-2877 Repository: mesos Description --- see summary. Diffs - 3rdparty/libprocess/include/process/firewall.hpp f71d6541e48e2481c69f401b388977b153503962 3rdparty/libprocess/src/process.cpp 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e Diff: https://reviews.apache.org/r/35919/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36003: MESOS-2942: Documentation for SSL.
On June 30, 2015, 12:57 a.m., Adam B wrote: docs/mesos-ssl.md, lines 58-59 https://reviews.apache.org/r/36003/diff/3/?file=995165#file995165line58 Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well) I'm reluctant to add the instructions as I can't easily verify the version of these packages on those systems. I wasn't worried about it as much on OSX because those won't be used to run production servers, and it makes it easier for people to try it out. I'd rather remove the instructions for OSX and suggest building libevent-2.0.22-stable and the newest stable release of openssl from source. What do you think? - Joris --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89833 --- On June 30, 2015, 5:47 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 30, 2015, 5:47 a.m.) Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-2942 https://issues.apache.org/jira/browse/MESOS-2942 Repository: mesos Description --- [Here](https://gist.github.com/jmlvanre/82f30d9ea1ea4d815736) is a Github rendered version Diffs - docs/mesos-ssl.md PRE-CREATION Diff: https://reviews.apache.org/r/36003/diff/ Testing --- Thanks, Joris Van Remoortere
Re: Review Request 33090: Removed unmaintained frameworks code.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/#review89781 --- Patch looks great! Reviews applied: [33090] All tests passed. - Mesos ReviewBot On June 29, 2015, 6:11 p.m., Jiang Yan Xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33090/ --- (Updated June 29, 2015, 6:11 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2640 https://issues.apache.org/jira/browse/MESOS-2640 Repository: mesos Description --- See summary. Diffs - docs/using-the-mesos-submit-tool.md 2ba4acc7423dae7ff67c1bc64ba3982aa1318b53 frameworks/deploy_jar/README.txt 37ccc1733a0689ab0eea802b91e76d8d7eb71a82 frameworks/deploy_jar/daemon_executor.py 4720a6e972308ef324f3f84642607072f0e69f3b frameworks/deploy_jar/daemon_executor.sh ac54d73fbcd225463e47fbad8ca5c4ffac48ca93 frameworks/deploy_jar/daemon_framework 2bb9107791ffe8fd0bd7a97667f6a2c85993e511 frameworks/deploy_jar/daemon_scheduler.py a919717a25b050b465202c1de7be6dfeb5720cfa frameworks/deploy_jar/haproxy.config.template 4d537e9abf29c34f9b709384a5f259c6108d05a2 frameworks/deploy_jar/hw.jar aa134596f5d4f8dd4c7a2b3c99b7ba9f18159965 frameworks/haproxy+apache/README.txt 37ccc1733a0689ab0eea802b91e76d8d7eb71a82 frameworks/haproxy+apache/haproxy+apache 05b975989fbec97d13eb0a181cd9d85c8c7c564e frameworks/haproxy+apache/haproxy+apache.py 39d4e7ba681b6437e978fadbf58e92e7e32345f1 frameworks/haproxy+apache/haproxy.config.template ca82ba998d645dbfb3b057afa873d1379543ff43 frameworks/haproxy+apache/startapache.py dce0ddd0e5bd655f9d745e88eefab1603a6a5e62 frameworks/haproxy+apache/startapache.sh 6eb24560130f5aa6eafb1ed6abecd8ab804e1e85 frameworks/mesos-submit/executor dd8b98c8a1971dd4b1a5504ba607f2d052837f22 frameworks/mesos-submit/executor.py 38813b9f9d151fa5293b710bc077075a5b1571cf frameworks/mesos-submit/mesos-submit 8cd5a674ced6a0441eb692db3bbf67a0f2bb7dfd frameworks/mesos-submit/mesos_submit.py 94d6232da504a86aca558b3655b3dc881e6d981d frameworks/torque/README.txt dd671e221dc448f89f593017fdcc81fae2ab9aa8 frameworks/torque/hpl-24node.qsub 3df1a45126e71c17fd642e90352eca733fbd0006 frameworks/torque/hpl-48node.qsub 105a7bbe4d4fdafd4984ec170790591a1a11160f frameworks/torque/hpl-8node-small.qsub b14dc95a172bcb61d3c631968106689dcc8b5172 frameworks/torque/hpl-8node.qsub b14dc95a172bcb61d3c631968106689dcc8b5172 frameworks/torque/mesos-hpl/24node/HPL.dat e9ab3fdc2295419a84540b9f0bd03b09a1527758 frameworks/torque/mesos-hpl/48node/HPL.dat d5c3e85b171698d86c8f588502b6a3839d23d248 frameworks/torque/mesos-hpl/8node-small/HPL.dat 941726c1d77534928d01cdbc5fc1a74c91cd635f frameworks/torque/mesos-hpl/8node/HPL.dat 250563c4d5a021119d89578110b32d4d031c3d04 frameworks/torque/mesos-hpl/Make.Linux_PII_CBLAS de646bab3bb26edbc086b245b407c190c6bbd77f frameworks/torque/mesos-hpl/README 17b7b3be298f2e9d8802e9a64b792a83a66551da frameworks/torque/mpi_example.c 3f3bcd08978aee7dc6803fabdbf171353a6728e8 frameworks/torque/start_pbs_mom.py ef8ed7cd8df8ff7d8c5e7720a823be6e967b121c frameworks/torque/start_pbs_mom.sh e0c81d0899e1f7a01590fec11cbc61e299ebef57 frameworks/torque/test_date_sleep_date_1node.qsub 99d91da292e950b72ca527fc6d94b924b1a57ea4 frameworks/torque/test_date_sleep_date_2node.qsub bd7ea0f6d737c5ec30f0930538e9484b691e0066 frameworks/torque/test_date_sleep_date_3node.qsub b8391da262ce2d5d01e63a4427b0614aeb59c2f3 frameworks/torque/test_date_sleep_date_5node_10sec.qsub c0e6d28e24b514d6b440f4b54b4db96ba55777a0 frameworks/torque/test_date_sleep_date_5node_60sec.qsub 17cd352ebeac5bbf5a68ed2d06e99a032ded35e4 frameworks/torque/torquelib.py b69df1c528c7ce32103d23e16bee8276cf3bffaf frameworks/torque/torquesched.py c22ef9180c3aaf447c0288ee4948d0c8067791b7 frameworks/torque/torquesched.sh a40c7eafd71a11c8f974aa49a612fa81d0016102 Diff: https://reviews.apache.org/r/33090/diff/ Testing --- make check Thanks, Jiang Yan Xu
Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89779 --- Thanks Joerg! See my detailed comments. I suggest you take a look at the discussion in https://reviews.apache.org/r/34720/ first. include/mesos/mesos.proto (lines 888 - 889) https://reviews.apache.org/r/35927/#comment142583 Not sure if that's needed. I think REASON_CONTAINER_LAUNCH_ERROR with proper message should be sufficient? cc @tnachen src/slave/containerizer/docker.cpp (line 1301) https://reviews.apache.org/r/35927/#comment142585 See my above comments. The slave is the one that should set executor-reason to be REASON_CONTAINER_LAUNCH_ERROR. The containerizer just need to properly set the messages. src/slave/containerizer/mesos/containerizer.cpp (line 1152) https://reviews.apache.org/r/35927/#comment142586 We could follow up with patches to remove 'killed' in both docker and mesos containerizer. src/slave/slave.cpp (lines 4452 - 4469) https://reviews.apache.org/r/35927/#comment142584 Please take a look at the discussion in this review (2nd comments) https://reviews.apache.org/r/34720/ There's some subtleness involved for command executors. The slave also needs to set executor-reason to be REASON_CONTAINER_LAUNCH_ERROR when containerizer-launch returns a failure. - Jie Yu On June 29, 2015, 7:22 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/ --- (Updated June 29, 2015, 7:22 a.m.) Review request for mesos and Alexander Rukletsov. Bugs: MESOS-2035 https://issues.apache.org/jira/browse/MESOS-2035 Repository: mesos Description --- [WIP] -need to add documentation -need to add test -not all potential paths are covered. It is not clear whether isolator sees event before the kill, see first comment in CgroupsMemIsolatorProcess::oom in mem.cpp. Diffs - docs/external-containerizer.md 96932189b74dce1ae28e0bd73d5543d1afaffb0b include/mesos/containerizer/containerizer.proto f16ccc89f83da28c413ccfa0687a06b7515a605c include/mesos/mesos.proto 81008ed85daea798ed19d1031de8421a7dc3fb19 include/mesos/slave/isolator.hpp ef2205dd7f4619e53e6cca7cac301f874d08c036 src/slave/containerizer/docker.cpp 6eb1c84b1a6ef17c3e2ea2028e2f2d75110176ba src/slave/containerizer/isolators/cgroups/mem.cpp b0e343fdc7088b2895d5dc8bb416dbcbf241cae5 src/slave/containerizer/isolators/posix/disk.cpp b2f995cba36b1399db48af1de49d76c607f80abd src/slave/containerizer/mesos/containerizer.cpp 313e9b74d3a0157609226041246575d2c4a503f8 src/slave/slave.cpp b8591116eadcd68b8db2a629fbcf793e6b394f14 src/tests/docker_containerizer_tests.cpp 3a983c6813dab6fa03ccb2c87e1ea71866766d6e Diff: https://reviews.apache.org/r/35927/diff/ Testing --- make check (including docker tests) Thanks, Joerg Schad
Re: Review Request 34137: Add support for container image provisioners.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review89293 --- src/slave/containerizer/mesos/containerizer.hpp (lines 319 - 320) https://reviews.apache.org/r/34137/#comment142551 Why not store ContainerInfo directly? src/slave/containerizer/mesos/containerizer.cpp (lines 642 - 646) https://reviews.apache.org/r/34137/#comment142560 Indent two more spaces. src/slave/containerizer/mesos/containerizer.cpp (lines 789 - 790) https://reviews.apache.org/r/34137/#comment142225 ``` mapstring, string env = executorEnvironment( executorInfo, containers_[containerId]-rootfs.isSome() ? flags.sandbox_directory : directory, slaveId, slavePid, checkpoint, flags.recovery_timeout); ``` ? Just a comment, not an issue. src/slave/containerizer/mesos/containerizer.cpp (lines 815 - 816) https://reviews.apache.org/r/34137/#comment142224 Does ``` containers_[containerId]-rootfs.isSome() ? flags.sandbox_directory : directory; ``` look better? Just thought this boarders too much jaggedness in the sytle guilde. src/slave/containerizer/mesos/containerizer.cpp (lines 1254 - 1259) https://reviews.apache.org/r/34137/#comment142213 Shift one more space to the right for alignment. src/slave/containerizer/mesos/containerizer.cpp (lines 1278 - 1280) https://reviews.apache.org/r/34137/#comment142214 Four space indentation. src/slave/containerizer/mesos/containerizer.cpp (line 1279) https://reviews.apache.org/r/34137/#comment142223 s/ :/: / src/slave/containerizer/provisioner.cpp (lines 46 - 47) https://reviews.apache.org/r/34137/#comment142194 Seems like this belongs to a later patch. AppcProvisioner is not introduced yet. src/slave/paths.cpp (lines 243 - 247) https://reviews.apache.org/r/34137/#comment141883 Indent two more spaces. src/tests/containerizer_tests.cpp (line 344) https://reviews.apache.org/r/34137/#comment142215 Kill empty line. - Jiang Yan Xu On June 22, 2015, 9:44 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/ --- (Updated June 22, 2015, 9:44 a.m.) Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone. Repository: mesos Description --- The MesosContainerizer can optionally provision a root filesystem for the containers. Diffs - include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 src/slave/containerizer/provisioner.hpp PRE-CREATION src/slave/containerizer/provisioner.cpp PRE-CREATION src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 src/slave/paths.hpp 00476f107ed8233123a6eab0925c9f28aac0a86f src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5 src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian Downes
