Re: Review Request 39559: Windows: Implemented `os::mkdtemp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39559/#review103815
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
34)


`strlen()` might be better/more-readable.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
36 - 41)


The posix spec says that `XX` suffix is required, so 
`strings::endsWith` would be a better check.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (line 
48)


That `- 1` doesn't match the "size" described by the variable name.  Seems 
like you're describing the `max_alphabet_index`.



3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp (lines 
62 - 74)


If you use `strings::endsWith` above, you won't need this validation.


- Joseph Wu


On Oct. 22, 2015, 11:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39559/
> ---
> 
> (Updated Oct. 22, 2015, 11:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::mkdtemp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/mkdtemp.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39559/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

> On Oct. 23, 2015, 11:42 a.m., Neil Conway wrote:
> > src/slave/containerizer/linux_launcher.cpp, line 189
> > 
> >
> > You could simplify this to "return freezer.isSome();". Clearly more 
> > concise; debatable whether it is more reasonable, although I'd say it would 
> > be an improvement.

Indeed! Thank you!


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103823
---


On Oct. 23, 2015, 11:50 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> ---
> 
> (Updated Oct. 23, 2015, 11:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> ---
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
b6afe0e76366d0bc68d37097ced83a1e14828d84 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
3e6f2aafd0f541f512025dfa683ab4178701f7c4 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39583/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Added `WindowsError` to parallel `ErrnoError`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
fdd33512c8d8752093f72f597a7d647eb5e3c285 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/39583/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/
---

(Updated 十月 23, 2015, 9:05 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Address Anand's comments per IRC discussion


Bugs: MESOS-3733
https://issues.apache.org/jira/browse/MESOS-3733


Repository: mesos


Description (updated)
---

Root Cause: The reason is that the DECLINE call set filter as 1hr,
the Clock::advance set as 100m. A race condition is that both DECLINE
and SUPPRESS started up in different threads and the call Clock::advance
may be called before SUPPRESS finished. The clock advanced for 100m which
is greater than 1hr, this caused the allocator start to allocate resource
again and ASSERT_TRUE(event.isPending()) will be failed.

Solution: Make SUPPRESS call is finished before call Clock::advance


Diffs (updated)
-

  src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 

Diff: https://reviews.apache.org/r/39548/diff/


Testing
---

Platform: Ubuntu 14.04
make 
make check
bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
--gtest_repeat=-1 --gtest_break_on_failure


Thanks,

Guangya Liu

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/
---

(Updated Oct. 23, 2015, 11:50 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, and Kapil Arya.


Repository: mesos


Description
---

We recently switched to using LinuxLauncher by default 
(https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
 This causes problems with running the slave in a Docker container. 

This patch introduces a function for checking whether the machine is suited for 
running Linux launcher. For the time being it checks whether the freezer cgroup 
subsystem enabled, as the Linux launcher evolves we might want to add more 
checks.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.hpp 
35b3315498d690ed66616617aa7d51455371fb5b 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 

Diff: https://reviews.apache.org/r/39604/diff/


Testing
---

- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).


Thanks,

Artem Harutyunyan

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103745
---

Ship it!


LGTM !

- Anand Mazumdar


On Oct. 23, 2015, 9:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 9:05 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Make SUPPRESS call is finished before call Clock::advance
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39583/#review103746
---



3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 34)


This doesn't use any instance data so could probably be either `const`, 
`static`, or a free function.


- Benjamin Bannier


On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39583/
> ---
> 
> (Updated Oct. 23, 2015, 8:57 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `WindowsError` to parallel `ErrnoError`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> fdd33512c8d8752093f72f597a7d647eb5e3c285 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39583/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39583: Windows: Added `WindowsError` to parallel `ErrnoError`.

[Alex Clemmer]

> On Oct. 23, 2015, 9:15 a.m., Benjamin Bannier wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 34
> > 
> >
> > This doesn't use any instance data so could probably be either `const`, 
> > `static`, or a free function.

Ah, thanks, Benjamin! I'm a complete C++ noob, unforunately. :)


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39583/#review103746
---


On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39583/
> ---
> 
> (Updated Oct. 23, 2015, 8:57 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added `WindowsError` to parallel `ErrnoError`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 
> fdd33512c8d8752093f72f597a7d647eb5e3c285 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39583/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39592/#review103767
---


Patch looks great!

Reviews applied: [39590, 39591, 39592]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 2:57 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39592/
> ---
> 
> (Updated Oct. 23, 2015, 2:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit is the result of running
> 
> for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
>   sed -i -E '1 s~^\/\*\*~\/\*~' $f
> done
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/examples/example.cpp 
> 22ae083d8b5bf59cf52e18405e005cfe94edb81d 
>   3rdparty/libprocess/include/process/address.hpp 
> 7b94979716fed0e2e93967335112835c4b6720a6 
>   3rdparty/libprocess/include/process/async.hpp 
> 676aa4c6849487b2d91b4a2ce458c719396f22f0 
>   3rdparty/libprocess/include/process/check.hpp 
> 4b43b704d6a87725bdde040cbc981dd2da1ad709 
>   3rdparty/libprocess/include/process/clock.hpp 
> 1107a329caf77f15901d87808eee72818601510c 
>   3rdparty/libprocess/include/process/collect.hpp 
> 2a8547b939dda08ce1debbf422654fa9f4593125 
>   3rdparty/libprocess/include/process/defer.hpp 
> c9caf58aab58c5ed8b5288a43405f88ba3b19c03 
>   3rdparty/libprocess/include/process/deferred.hpp 
> 00072e014159761c18aa7b21fa15dfdbb95f2271 
>   3rdparty/libprocess/include/process/delay.hpp 
> 65e316e12b96f96058292faa4fc7a7f34c5c1c73 
>   3rdparty/libprocess/include/process/dispatch.hpp 
> c5b8137586113016d702451260c18ff5cfa7c0a2 
>   3rdparty/libprocess/include/process/event.hpp 
> 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
>   3rdparty/libprocess/include/process/executor.hpp 
> 0693e4e362aafe208847651bcf83956c26643de7 
>   3rdparty/libprocess/include/process/filter.hpp 
> db0dfc7ae89245b748337c53e524f3cb352ed301 
>   3rdparty/libprocess/include/process/firewall.hpp 
> b5c7d9976b7a5cbf3cc621559dc361e15059ee67 
>   3rdparty/libprocess/include/process/future.hpp 
> 3916150691e9a0880b8b826734fa74bd33d18cfd 
>   3rdparty/libprocess/include/process/gc.hpp 
> 72fde54ce2f727c89ca49485a0dfee124cb6fc2f 
>   3rdparty/libprocess/include/process/gmock.hpp 
> 575f1ecb3dfbfb7d8f011d408c1e24619406c2b0 
>   3rdparty/libprocess/include/process/gtest.hpp 
> 2ae2a5a16e61304c969c4802990b31beb3964f25 
>   3rdparty/libprocess/include/process/help.hpp 
> 2412db913207b8d6953297870e41a657c742b2a1 
>   3rdparty/libprocess/include/process/http.hpp 
> 591c1a959057155e1bf0f5bd73352e78d1c15cb3 
>   3rdparty/libprocess/include/process/id.hpp 
> a0bb5dbd93bc7e2f245e012032d54969eefd1d3e 
>   3rdparty/libprocess/include/process/io.hpp 
> 73bf30b97c342632e753658fb1f283aa362ce48b 
>   3rdparty/libprocess/include/process/latch.hpp 
> 8a9d12165ea7442ddc68d20d15c8458b388bb679 
>   3rdparty/libprocess/include/process/limiter.hpp 
> f2efe84212e3a98e5a29e2ec07adc73b5da1ad14 
>   3rdparty/libprocess/include/process/logging.hpp 
> 03fb1bd51e105d0070760af6232dab03e85127d2 
>   3rdparty/libprocess/include/process/message.hpp 
> e9c7e050a771ff88cbec49f5adb37c04138479be 
>   3rdparty/libprocess/include/process/metrics/counter.hpp 
> fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
>   3rdparty/libprocess/include/process/metrics/gauge.hpp 
> 13934b8c48012a4ef38ba587deb1bce058425ccc 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 
> c5e61df09b06ff13695646eb97c69235a4fe8d56 
>   3rdparty/libprocess/include/process/metrics/metrics.hpp 
> f2e84d8e62df58812b660c858eb3b0366db4 
>   3rdparty/libprocess/include/process/metrics/timer.hpp 
> 08f16b89b436eda86418974c5ef16c6ad0e74a5d 
>   3rdparty/libprocess/include/process/mime.hpp 
> decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
>   3rdparty/libprocess/include/process/mutex.hpp 
> 46e25df66325b029cb3e9bbc5e94d66aa5bac4e8 
>   3rdparty/libprocess/include/process/network.hpp 
> 61bfa8243728dc19ab0e6fb43d33ca83fb3709c3 
>   3rdparty/libprocess/include/process/once.hpp 
> cbb18680037bac148d7e915081c484791bd6f892 
>   3rdparty/libprocess/include/process/owned.hpp 
> 1b41477d555ce567c58033f8993dc2ae0ac80a05 
>   3rdparty/libprocess/include/process/pid.hpp 
> e87cfcaf0f93cd9dd0ce7df7299a58fa58982fa7 
>   3rdparty/libprocess/include/process/process.hpp 
> 8b086f296c80a43be2edaf496a04dadf0c64251a 
>   3rdparty/libprocess/include/process/profiler.hpp 
> 4082b8ae579aa11c688da961e126a94d8f121762 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> 91b51b0ffbdbe791183afacd3fd16238f3af135e 
>   3rdparty/libprocess/include/process/queue.hpp 
> 

Re: Review Request 39597: Add Newbie guide.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39597/#review103781
---


I'm pretty sure that Mesos only builds with the bundled GLog and GTest. At 
least I've always been unsuccessful in building against unbundled versions of 
those components.

- James Peach


On Oct. 23, 2015, 3:08 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39597/
> ---
> 
> (Updated Oct. 23, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3224
> https://issues.apache.org/jira/browse/MESOS-3224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Newbie guide.
> 
> 
> Diffs
> -
> 
>   docs/NewbieQuickStart.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39597/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Marco Massenzio]

> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote:
> > support/apply-reviews.py, line 160
> > 
> >
> > you don't really need to escape the quotes, just take advantage of 
> > Python being able to use single and double quotes interchangeably (or even 
> > use """ if you really want to be hip :)
> 
> Artem Harutyunyan wrote:
> I actually do need to escape the quotes becasue {message} is multiline 
> and I am executing the `cmd` in a shell.
> 
> Marco Massenzio wrote:
> I don't understand your comment, I'm afraid. What I did mean was that you 
> can write:
> ```
> cmd = "git commit --author '{author}' -am '{message}'".format(author = 
> review['author'], ...)
> ```
> and this will have the exact same meaning as your code (whether that's 
> correctly escaped and executed in the shell, I really can't say).
> 
> Artem Harutyunyan wrote:
> I see what you're saying. I am using single quotes throughout the code, 
> that's why I preferred quoting to switching to double quotes for these 
> particular instances.

ah - that sounds reasonable (although, you'll be relieved to know that PEP8 is 
silent on that point :)
The general approach is to use both, being consistent across "usage classes."


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
---


On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 23, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39518: Changed write api.

[Jojy Varghese]

> On Oct. 23, 2015, 8:02 a.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 638
> > 
> >
> > Did we ever find out why before we just use another interface?

I realized that since the registry client refactor already takes care of 
buffered write (and inadvertantly uses the '''write(fd, char* , size_t) ''' 
API, I dont need this patch for now and will wait for the refactor patches. The 
patch that does this is https://reviews.apache.org/r/39340/


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103740
---


On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39518/
> ---
> 
> (Updated Oct. 21, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3773
> https://issues.apache.org/jira/browse/MESOS-3773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3773.
> 
> Change:
> io::write(fd, string) has been having issues with junk being written to the
> file. Using io::write(fd, void*, size_t) does not have this issue.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39518/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/#review103778
---

Ship it!


Ship It!

- Marco Massenzio


On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38883/
> ---
> 
> (Updated Oct. 23, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38883/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

> On Oct. 22, 2015, 10:25 a.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, lines 71-72
> > 
> >
> > How about initializing `role` with QuotaInfo.role? Or we agreed not to 
> > send role as part of the JSON request?

According to the current design doc no.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/#review103539
---


On Oct. 22, 2015, 4:38 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39285/
> ---
> 
> (Updated Oct. 22, 2015, 4:38 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3199
> https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Quota Request Validation.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39285/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103779
---

Ship it!


Thanks for the "Better Bash" :)

- Marco Massenzio


On Oct. 23, 2015, 6:58 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 23, 2015, 6:58 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

and updating the C++ style guide.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
  include/mesos/v1/scheduler/scheduler.hpp 
eaf9f90fc9da4d03871145874599bb6d4b781567 
  include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/authentication/cram_md5/authenticatee.hpp 
9d6293c32722272228652d0241c59c7eeb88d0a3 
  src/authentication/cram_md5/authenticatee.cpp 
b03b44a924632edf4424cfef1ae4163c4abc7b1a 
  src/authentication/cram_md5/authenticator.hpp 
e75469a2e50167582711308b301802c9dfd9fb97 
  src/authentication/cram_md5/authenticator.cpp 
f238872476d422856db48bd845d5941911fdf2b0 
  src/authentication/cram_md5/auxprop.hpp 
0fa87f45a40bdb99a5f8088c0d55144ffc2804db 
  src/authentication/cram_md5/auxprop.cpp 
abf0f8dfb7367342d11c2d7a99b9fc73d09b57a8 
  src/authorizer/authorizer.cpp e1b7057701b6219ee5f74885b364fdaf4bfe7843 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/cli/resolve.cpp dcb1d37a79a43c4692e7da21f9c95d79c539d095 
  src/common/attributes.cpp 

Review Request 39591: [stout]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39591/
---

Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
2b003d26d6b6b65b1d7b1dd6396f808c35b53177 
  3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp 
27087041d8255b96159bb10c184f00cf5bc9c34e 
  3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 
4893e7ba0b7d83fd3ba36bf18aa541c60293cc23 
  3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp 
b9a9c20125229c8150660e5969e136b07cecb169 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
e9cf85637157f98a0eac166096bb18fa5652c669 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
0d51c8d418acb49b52cebfb644ee0476d6ec4502 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 
b550bfee696c85c0ade3feaf5d38e20eb4c1ce78 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
e58ee43623d72b52dd8682e3d976da74e8bec9e8 
  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
5d0970fe9f712d7162eec522c83905292892c94d 
  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
12ba1ca861114e60f8276c0ee91c543abcfc2519 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
38dabd45aa1d7f02e9991ce4ae28b44cd39db87c 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp 
ab609a0d7922298eaf89648200fabd843f8201e0 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 
3c320a319edce83af0287b0b014234f7e7ec6e0b 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
a289f8303740394ec1a0900e643d33e3c18a831d 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
7cf4feff87dd08201a410596d2862383c29021af 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
25252015d04884dae7238129e2d7313a615967ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
d9d0fd4febd540252ae53fb4af7eb061983d0133 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
642bd4ce640cfdbf3c122cec64d72c9434d89fa3 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
f766359fdd5a75e3a80d19be3e5c233e87357bde 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
85c773ac675c88b313dffda7a9c32bac42ebe62d 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
51ec75868e614042c339ab0eaa995c9996ddf124 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
d207dc5ad7558818da7fd0d04c6ef8df217b78c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
9625894b69417faa796be5c4313b759cbcc1ce90 
  3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp 
6cbb2ac50dd23d78465e8690112fc01114ada07b 
  3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 
89340fd79167a311c698740454db19e83c286952 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
5748c9e6d39551eee287f3e9804505cb2fd3fdd0 
  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
52d1eea6d04092caa8eba39ad69c2a474f854a8d 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp 
ce94fef4aeeb098668decc36606ee667915a15cd 
  3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp 
95b730c83ec357b33afae0d04182f7a72ffd28c4 
  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
ddd3dd9e015c583e04d72ac9a9b5a5ed6f1d49d5 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
db5e33220844d20ef08a7324f641eeb1ff6d2052 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp 
75b4f9f249ee362e4e12070c1699a8bcd15385e9 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 
b6925962ae65ad9d41bf9fff77973c1117afcbd2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 
91d82a8fae27c002458cad0bbdc45b312d2ec70d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/exists.hpp 
6eb7f8f2be208e591d43088b2541d030a272f328 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/fcntl.hpp 

Review Request 39592: [libprocess]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39592/
---

Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done


Diffs
-

  3rdparty/libprocess/examples/example.cpp 
22ae083d8b5bf59cf52e18405e005cfe94edb81d 
  3rdparty/libprocess/include/process/address.hpp 
7b94979716fed0e2e93967335112835c4b6720a6 
  3rdparty/libprocess/include/process/async.hpp 
676aa4c6849487b2d91b4a2ce458c719396f22f0 
  3rdparty/libprocess/include/process/check.hpp 
4b43b704d6a87725bdde040cbc981dd2da1ad709 
  3rdparty/libprocess/include/process/clock.hpp 
1107a329caf77f15901d87808eee72818601510c 
  3rdparty/libprocess/include/process/collect.hpp 
2a8547b939dda08ce1debbf422654fa9f4593125 
  3rdparty/libprocess/include/process/defer.hpp 
c9caf58aab58c5ed8b5288a43405f88ba3b19c03 
  3rdparty/libprocess/include/process/deferred.hpp 
00072e014159761c18aa7b21fa15dfdbb95f2271 
  3rdparty/libprocess/include/process/delay.hpp 
65e316e12b96f96058292faa4fc7a7f34c5c1c73 
  3rdparty/libprocess/include/process/dispatch.hpp 
c5b8137586113016d702451260c18ff5cfa7c0a2 
  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/include/process/executor.hpp 
0693e4e362aafe208847651bcf83956c26643de7 
  3rdparty/libprocess/include/process/filter.hpp 
db0dfc7ae89245b748337c53e524f3cb352ed301 
  3rdparty/libprocess/include/process/firewall.hpp 
b5c7d9976b7a5cbf3cc621559dc361e15059ee67 
  3rdparty/libprocess/include/process/future.hpp 
3916150691e9a0880b8b826734fa74bd33d18cfd 
  3rdparty/libprocess/include/process/gc.hpp 
72fde54ce2f727c89ca49485a0dfee124cb6fc2f 
  3rdparty/libprocess/include/process/gmock.hpp 
575f1ecb3dfbfb7d8f011d408c1e24619406c2b0 
  3rdparty/libprocess/include/process/gtest.hpp 
2ae2a5a16e61304c969c4802990b31beb3964f25 
  3rdparty/libprocess/include/process/help.hpp 
2412db913207b8d6953297870e41a657c742b2a1 
  3rdparty/libprocess/include/process/http.hpp 
591c1a959057155e1bf0f5bd73352e78d1c15cb3 
  3rdparty/libprocess/include/process/id.hpp 
a0bb5dbd93bc7e2f245e012032d54969eefd1d3e 
  3rdparty/libprocess/include/process/io.hpp 
73bf30b97c342632e753658fb1f283aa362ce48b 
  3rdparty/libprocess/include/process/latch.hpp 
8a9d12165ea7442ddc68d20d15c8458b388bb679 
  3rdparty/libprocess/include/process/limiter.hpp 
f2efe84212e3a98e5a29e2ec07adc73b5da1ad14 
  3rdparty/libprocess/include/process/logging.hpp 
03fb1bd51e105d0070760af6232dab03e85127d2 
  3rdparty/libprocess/include/process/message.hpp 
e9c7e050a771ff88cbec49f5adb37c04138479be 
  3rdparty/libprocess/include/process/metrics/counter.hpp 
fd8be32dec79cb5ac372c80fcf4a581c8396c1b5 
  3rdparty/libprocess/include/process/metrics/gauge.hpp 
13934b8c48012a4ef38ba587deb1bce058425ccc 
  3rdparty/libprocess/include/process/metrics/metric.hpp 
c5e61df09b06ff13695646eb97c69235a4fe8d56 
  3rdparty/libprocess/include/process/metrics/metrics.hpp 
f2e84d8e62df58812b660c858eb3b0366db4 
  3rdparty/libprocess/include/process/metrics/timer.hpp 
08f16b89b436eda86418974c5ef16c6ad0e74a5d 
  3rdparty/libprocess/include/process/mime.hpp 
decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
  3rdparty/libprocess/include/process/mutex.hpp 
46e25df66325b029cb3e9bbc5e94d66aa5bac4e8 
  3rdparty/libprocess/include/process/network.hpp 
61bfa8243728dc19ab0e6fb43d33ca83fb3709c3 
  3rdparty/libprocess/include/process/once.hpp 
cbb18680037bac148d7e915081c484791bd6f892 
  3rdparty/libprocess/include/process/owned.hpp 
1b41477d555ce567c58033f8993dc2ae0ac80a05 
  3rdparty/libprocess/include/process/pid.hpp 
e87cfcaf0f93cd9dd0ce7df7299a58fa58982fa7 
  3rdparty/libprocess/include/process/process.hpp 
8b086f296c80a43be2edaf496a04dadf0c64251a 
  3rdparty/libprocess/include/process/profiler.hpp 
4082b8ae579aa11c688da961e126a94d8f121762 
  3rdparty/libprocess/include/process/protobuf.hpp 
91b51b0ffbdbe791183afacd3fd16238f3af135e 
  3rdparty/libprocess/include/process/queue.hpp 
7e3538763659dd3ca6c8cd61d17abb3af32bb01b 
  3rdparty/libprocess/include/process/reap.hpp 
ca5acc4c8f5a62a49b7fde83946e283ea40baa65 
  3rdparty/libprocess/include/process/run.hpp 
98de0fd30cc1dc5561c924a0e5e5fc18e24cf7a1 
  3rdparty/libprocess/include/process/sequence.hpp 
41da6978c7f2ec198587f024f0fc02f882082cc5 
  3rdparty/libprocess/include/process/shared.hpp 
4f602cc8d6b0d07c8796ffe09772b72a4ce5ddd2 
  3rdparty/libprocess/include/process/socket.hpp 
ebee78909feb5a4032da68f51d08dbf11b03b332 
  3rdparty/libprocess/include/process/ssl/gtest.hpp 
91991f509e480a94de00c6bf20ff0abf083dda8a 
  3rdparty/libprocess/include/process/ssl/utilities.hpp 

Re: Review Request 39579: Updated docker registry client to check HTTP code.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/#review103748
---


Patch looks great!

Reviews applied: [38416, 38779, 39579]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 7:58 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39579/
> ---
> 
> (Updated Oct. 23, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker registry client to check HTTP code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39579/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103752
---


Patch looks great!

Reviews applied: [39548]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 9:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 9:05 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Make SUPPRESS call is finished before call Clock::advance
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review103749
---


Bad patch!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584]

Failed command: ./support/apply-review.sh -n -r 39584

Error:
 2015-10-23 09:51:38 URL:https://reviews.apache.org/r/39584/diff/raw/ 
[13792/13792] -> "39584.patch" [1]
Successfully applied: Windows: Implemented `os::rmdir.hpp`.

Windows: Implemented `os::rmdir.hpp`.


Review: https://reviews.apache.org/r/39584
Checking 6 files using filter 
--filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp:28:  
Lines should very rarely be longer than 100 characters  
[whitespace/line_length] [4]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Oct. 23, 2015, 8:57 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Oct. 23, 2015, 8:57 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39401: Quota: Updated allocate() in the hierarchical allocator to support quota.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39401/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 

Diff: https://reviews.apache.org/r/39401/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/#review103793
---


Confirmed that mktemp logic was unchanged.


3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 213 - 217)


Do you need this one?



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 223 - 227)


Why is this function body different than all the other alias-like functions?

i.e. You could comment that stout/mktemp needs an open file, or similar.


- Joseph Wu


On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39539/
> ---
> 
> (Updated Oct. 21, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39539/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39383/#review103805
---


Confirmed that `mkdir` logic is essentially unchanged.


3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp (line 19)


We usually write constants like this:
```
const std::string DIRECTORY_SEPARATOR = "/";
```


- Joseph Wu


On Oct. 22, 2015, 10:40 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39383/
> ---
> 
> (Updated Oct. 22, 2015, 10:40 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39383/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/
---

(Updated Oct. 23, 2015, 4:30 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Implemented `os::rmdir.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
b6afe0e76366d0bc68d37097ced83a1e14828d84 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
3e6f2aafd0f541f512025dfa683ab4178701f7c4 

Diff: https://reviews.apache.org/r/39584/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/hierarchical_allocator_tests.cpp 
505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 

Diff: https://reviews.apache.org/r/39450/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39400: Quota: Implemented quota API.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
cfd937ba306273c24fb5337dfeb1a15e1545169b 
  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 

Diff: https://reviews.apache.org/r/39400/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 38218: Quota: Extended the Allocator interface with quota-related methods.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38218/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3716
https://issues.apache.org/jira/browse/MESOS-3716


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  src/master/allocator/mesos/allocator.hpp 
c5375aa89b210e46c41ac7d68d119749de15d2f5 
  src/master/allocator/mesos/hierarchical.hpp 
cfd937ba306273c24fb5337dfeb1a15e1545169b 
  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
  src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 

Diff: https://reviews.apache.org/r/38218/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39285: Added Quota Request Validation.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39285/
---

(Updated Oct. 23, 2015, 4:52 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Added Quota Request Validation.


Diffs (updated)
-

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39285/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 38580: Added docker registry RemotePuller

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38580/
---

(Updated Oct. 23, 2015, 4:57 p.m.)


Review request for mesos, Jie Yu, Timothy Chen, and Jiang Yan Xu.


Changes
---

minor changes.


Repository: mesos


Description
---

Integrated remote puller with store. Tests will follow.


Diffs (updated)
-

  src/CMakeLists.txt 98e76cee81ab206f3ffe7989711abc38f49c4352 
  src/Makefile.am 96ce73b301c55d23bf4a5292e3d028148426a878 
  src/slave/containerizer/provisioner/docker/local_puller.hpp 
4574e8a04663482625d7b54f765741f221ec13e0 
  src/slave/containerizer/provisioner/docker/local_puller.cpp 
74d0e1ead7d630e65a7e75cb6123139b9197efef 
  src/slave/containerizer/provisioner/docker/puller.hpp 
105b4e75439c2ad4c08e2fd364f288f1d39b9b59 
  src/slave/containerizer/provisioner/docker/puller.cpp 
cb05324689ffa26ce830b513e2d71b55517da3cb 
  src/slave/containerizer/provisioner/docker/registry_client.hpp 
1d3377e7462908246dfac90aa0c56314406529c9 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/slave/containerizer/provisioner/docker/remote_puller.hpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/remote_puller.cpp PRE-CREATION 
  src/slave/containerizer/provisioner/docker/store.cpp 
637c97c0973bda492826803a962c99635647692d 
  src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 
  src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 
  src/tests/containerizer/provisioner_docker_tests.cpp 
822aa77d0be0797ab62a5798527618b2cc4f6bf0 

Diff: https://reviews.apache.org/r/38580/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103810
---

Ship it!


Ship It!

- Vinod Kone


On Oct. 23, 2015, 9:05 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 9:05 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Make SUPPRESS call is finished before call Clock::advance
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39518: Changed write api.

[Jojy Varghese]

> On Oct. 23, 2015, 7:59 a.m., Benjamin Bannier wrote:
> > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 642
> > 
> >
> > Wouldn't this potentially cause data loss if the called `write` 
> > function cannot dump everything in the `fd`?

Good point. Didnt realize that write could return unfinished. Addressed in 
https://reviews.apache.org/r/39340/


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103739
---


On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39518/
> ---
> 
> (Updated Oct. 21, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3773
> https://issues.apache.org/jira/browse/MESOS-3773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3773.
> 
> Change:
> io::write(fd, string) has been having issues with junk being written to the
> file. Using io::write(fd, void*, size_t) does not have this issue.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39518/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Oct. 23, 2015, 5:20 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

removed defers


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38654: Added digest verifier for image blobs

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
---

(Updated Oct. 23, 2015, 5:31 p.m.)


Review request for mesos, Gilbert Song and Timothy Chen.


Repository: mesos


Description
---

Provides interface for verifying a blob of data for its digest and given digest 
type.


Diffs
-

  src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac 
  src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
1b0c30450a07d01d1a38d460bc7d921c80be7e3b 

Diff: https://reviews.apache.org/r/38654/diff/


Testing
---


Thanks,

Jojy Varghese

Re: Review Request 39595: Took mtime into account in the fetcher cache.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/#review103813
---


Patch looks great!

Reviews applied: [39594, 39595]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 3:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39595/
> ---
> 
> (Updated Oct. 23, 2015, 3:05 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
> https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also added function to query mtime of HDFS resource.
> 
> 
> Diffs
> -
> 
>   src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf 
>   src/slave/containerizer/fetcher.hpp 
> c7518a36f6344841880dbb11bfce603fd2791fc0 
>   src/slave/containerizer/fetcher.cpp 
> e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
>   src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 
> 
> Diff: https://reviews.apache.org/r/39595/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39399/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
cfd937ba306273c24fb5337dfeb1a15e1545169b 
  src/master/allocator/mesos/hierarchical.cpp 
f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 

Diff: https://reviews.apache.org/r/39399/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 39579: Updated docker registry client to check HTTP code.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/#review103795
---



src/slave/containerizer/provisioner/docker/registry_client.cpp (line 360)


We are refactoring this code and have split the method into small chunks. I 
was expecting this change  as part of that.


- Jojy Varghese


On Oct. 23, 2015, 7:58 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39579/
> ---
> 
> (Updated Oct. 23, 2015, 7:58 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docker registry client to check HTTP code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39579/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39540/#review103800
---

Ship it!


Confirmed that `getcwd` logic is unchanged.


3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp (line 17)


This isn't used, is it?


- Joseph Wu


On Oct. 21, 2015, 8:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
> ---
> 
> (Updated Oct. 21, 2015, 8:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39540/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39541: Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39541/#review103802
---

Ship it!


Confirmed that `chdir` logic is unchanged.

- Joseph Wu


On Oct. 21, 2015, 8:36 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39541/
> ---
> 
> (Updated Oct. 21, 2015, 8:36 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::chdir` to its own file, `stout/os/chdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/chdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39541/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.

[Alex Clemmer]

> On Oct. 23, 2015, 4:56 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp, line 17
> > 
> >
> > This isn't used, is it?

Ah, yes, I remember thinking that we _should_ make `getcwd` return a `Try`, but 
forgetting to pull this out later. Oops.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39540/#review103800
---


On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
> ---
> 
> (Updated Oct. 22, 2015, 3:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39540/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Quota: Moved QuotaInfo protobuf into a separate package.


Diffs
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 39340: RegistryClient: Added streaming response read

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39340/
---

(Updated Oct. 23, 2015, 4:55 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Fixed offset based write


Repository: mesos


Description
---

RegistryClient: Added streaming response read


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 

Diff: https://reviews.apache.org/r/39340/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38747: Adding digest utilities

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38747/
---

(Updated Oct. 23, 2015, 4:56 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Changes
---

Added support for more digests


Repository: mesos


Description
---

Added SHA256, SHA512 implementation.


Diffs (updated)
-

  3rdparty/libprocess/Makefile.am eb7393904988afc0bc5e9f7dadd545e0d6c04e5f 
  3rdparty/libprocess/include/Makefile.am 
fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e 
  3rdparty/libprocess/include/process/digest.hpp PRE-CREATION 
  3rdparty/libprocess/src/tests/CMakeLists.txt 
99c9754b6a5c7ceb12808a782da9cb9fb3fc731e 
  3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/38747/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 38654: Added digest verifier for image blobs

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38654/
---

(Updated Oct. 23, 2015, 5:30 p.m.)


Review request for mesos, Gilbert Song and Timothy Chen.


Repository: mesos


Description
---

Provides interface for verifying a blob of data for its digest and given digest 
type.


Diffs
-

  src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac 
  src/slave/containerizer/provisioner/verifier/digest_verifier.hpp PRE-CREATION 
  src/tests/containerizer/provisioner_docker_tests.cpp 
1b0c30450a07d01d1a38d460bc7d921c80be7e3b 

Diff: https://reviews.apache.org/r/38654/diff/


Testing
---


Thanks,

Jojy Varghese

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review103891
---


Patch looks great!

Reviews applied: [39493]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 11:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Oct. 23, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `yum update nss` to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review103894
---



docs/getting-started.md (line 61)


How about add nss through install. Because install also would update if the 
package installed.


- haosdent huang


On Oct. 23, 2015, 11:58 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Oct. 23, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `yum update nss` to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/
---

(Updated Oct. 23, 2015, 7:21 p.m.)


Review request for mesos, Benjamin Hindman and Kapil Arya.


Changes
---

- Removed JSON model() implementation for NetworkInfo in favor of inlined usage 
of JSON::Protobuf().
- Clarified wording in the NetworkInfo banner comment.
- Updated Mesos versions in inline deprecation comments.


Bugs: MESOS-3788
https://issues.apache.org/jira/browse/MESOS-3788


Repository: mesos


Description
---

In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This message 
allows framework authors to communicate with network isolation modules via a 
first-class message type to request IP addresses and network group isolation 
policies.

Unfortunately, the structure is somewhat confusing to both framework authors 
and module implementors.

1) It's unclear how IP addresses map to virtual interfaces inside the container.
2) It's difficult for application developers to understand the final policy 
when multiple IP addresses can be assigned with differing isolation policies.


Diffs (updated)
-

  docs/networking-for-mesos-managed-containers.md 33568a8 
  include/mesos/mesos.proto 9400434 
  include/mesos/v1/mesos.proto 8131778 
  src/common/http.hpp 0cc98a8 
  src/common/http.cpp f56d8a1 
  src/docker/executor.cpp 1e49013 
  src/examples/test_hook_module.cpp 43d6cb9 
  src/slave/slave.cpp e9f2d1b 
  src/tests/common/http_tests.cpp c2e7704 
  src/tests/hook_tests.cpp 5a5d019 

Diff: https://reviews.apache.org/r/39531/diff/


Testing
---

make && make check


Thanks,

Connor Doyle

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38627/#review103837
---


LGTM - Kapil, any thoughts?

- Niklas Nielsen


On Oct. 21, 2015, 5:52 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38627/
> ---
> 
> (Updated Oct. 21, 2015, 5:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Bernd Mathiske, Niklas Nielsen, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3072
> https://issues.apache.org/jira/browse/MESOS-3072
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allows developers to provide their own parameters when loading modules 
> instead of using the ones provided by the user when loading Mesos. This helps 
> to deal with default modules (those used when the user doesn't provide any), 
> and for testing of the modules.
> 
> 
> Diffs
> -
> 
>   src/examples/example_module_impl.cpp 
> db015cea130701a4e0a6fcb890c79fbb0c02c1ce 
>   src/examples/test_module.hpp 0514963b6100a6e9a834f2b9670cebc310918fb8 
>   src/module/manager.hpp 302eb409fb8ef53b9cef8d2ecbe7b7f452b095ef 
>   src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
>   src/tests/module_tests.cpp 60497aac3200ab9a679a81a593b5bf0d02fd4b50 
> 
> Diff: https://reviews.apache.org/r/38627/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39597: Add Newbie guide.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39597/#review103835
---


Patch looks great!

Reviews applied: [39597]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 3:08 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39597/
> ---
> 
> (Updated Oct. 23, 2015, 3:08 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3224
> https://issues.apache.org/jira/browse/MESOS-3224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add Newbie guide.
> 
> 
> Diffs
> -
> 
>   docs/NewbieQuickStart.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39597/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 23, 2015, 12:06 a.m., Niklas Nielsen wrote:
> > include/mesos/mesos.proto, line 1389
> > 
> >
> > 'the actual assigned IP adress' reads a bit odd. How about something 
> > like: "A user can request an automatically assigned IP (for example, 
> > through an IPAM service) or a specific IP"
> > 
> > No biggie; if you don't like the suggestion, feel free to drop

Updated, hopefully it's more clear now.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103690
---


On Oct. 23, 2015, 7:21 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 23, 2015, 7:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> 
> Diffs
> -
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.hpp 0cc98a8 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39531: Clarify NetworkInfo semantics for IP addresses and group policies.

[Connor Doyle]

> On Oct. 23, 2015, 12:06 a.m., Niklas Nielsen wrote:
> > include/mesos/v1/mesos.proto, line 1343
> > 
> >
> > As a non-native speaker; what's the consistency around capitalizing 
> > framework :)

I personally find all occurrences of capitalized Master, Framework, Agent, etc 
to be strange because they're not proper nouns (where does it end... should 
Isolator also be capitalized?)  In any case let's be internally consistent and 
capitalize Framework here.  Will fix.


- Connor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39531/#review103690
---


On Oct. 22, 2015, 11:30 p.m., Connor Doyle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39531/
> ---
> 
> (Updated Oct. 22, 2015, 11:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kapil Arya.
> 
> 
> Bugs: MESOS-3788
> https://issues.apache.org/jira/browse/MESOS-3788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In Mesos 0.25.0, a new message called NetworkInfo was introduced.  This 
> message allows framework authors to communicate with network isolation 
> modules via a first-class message type to request IP addresses and network 
> group isolation policies.
> 
> Unfortunately, the structure is somewhat confusing to both framework authors 
> and module implementors.
> 
> 1) It's unclear how IP addresses map to virtual interfaces inside the 
> container.
> 2) It's difficult for application developers to understand the final policy 
> when multiple IP addresses can be assigned with differing isolation policies.
> 
> 
> Diffs
> -
> 
>   docs/networking-for-mesos-managed-containers.md 33568a8 
>   include/mesos/mesos.proto 9400434 
>   include/mesos/v1/mesos.proto 8131778 
>   src/common/http.cpp f56d8a1 
>   src/docker/executor.cpp 1e49013 
>   src/examples/test_hook_module.cpp 43d6cb9 
>   src/slave/slave.cpp e9f2d1b 
>   src/tests/common/http_tests.cpp c2e7704 
>   src/tests/hook_tests.cpp 5a5d019 
> 
> Diff: https://reviews.apache.org/r/39531/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Re: Review Request 39614: Quota: Added Status Validation Tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review103890
---


Patch looks great!

Reviews applied: [39317, 38218, 36913, 38059, 39285, 38110, 38956, 39223, 
39492, 39614]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 10:35 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> ---
> 
> (Updated Oct. 23, 2015, 10:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 39594: [stout]: Added function to simultaneously query size and mtime of URI.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/
---

Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

[stout]: Added function to simultaneously query size and mtime of URI.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 

Diff: https://reviews.apache.org/r/39594/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Review Request 39595: Took mtime into account in the fetcher cache.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39595/
---

Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.


Bugs: MESOS-3785
https://issues.apache.org/jira/browse/MESOS-3785


Repository: mesos


Description
---

Also added function to query mtime of HDFS resource.


Diffs
-

  src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf 
  src/slave/containerizer/fetcher.hpp c7518a36f6344841880dbb11bfce603fd2791fc0 
  src/slave/containerizer/fetcher.cpp e0d02d5f8f4f6e930a2ae6abe365548af6d1b01f 
  src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b 

Diff: https://reviews.apache.org/r/39595/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Review Request 39597: Add Newbie guide.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39597/
---

Review request for mesos and Timothy Chen.


Bugs: MESOS-3224
https://issues.apache.org/jira/browse/MESOS-3224


Repository: mesos


Description
---

Add Newbie guide.


Diffs
-

  docs/NewbieQuickStart.md PRE-CREATION 

Diff: https://reviews.apache.org/r/39597/diff/


Testing
---


Thanks,

Diana Arroyo

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Oct. 22, 2015, 11:19 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs (updated)
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38874/#review103723
---

Ship it!


Thanks for the patience and for reworking the patches!

I think the CHECK_SOME in Executor::send is problematic, see below. I made some 
adjustments based on my comments in the review, please have a look over the 
commit diff!


src/slave/slave.hpp (line 637)


Doesn't look like this should be a CHECK_SOME given the possibility of both 
being None, mind just logging a warning when we drop the message instead of the 
CHECK_SOME?



src/slave/slave.hpp (line 685)


How about s/Unknown/Not known yet/ to suggest that we find out later?



src/slave/slave.hpp 


Hm.. doesn't this still need to be in the header? How do the output 
operations in Executor above compile?



src/slave/slave.cpp (line 4114)


It looks like this call can trip the CHECK_SOME in Executor::send? :(



src/slave/slave.cpp (line 5399)


The "at IP:PORT" should be sufficient, no need to say of type PID.



src/slave/slave.cpp (line 5404)


how about "(via HTTP)"



src/slave/slave.cpp (line 5406)


I think this will come out confusing in the logs, if I just read "of type: 
Unknown" it's not clear what the meaning of type is here. Would suggest saying 
nothing here.


- Ben Mahler


On Oct. 23, 2015, 1:34 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38874/
> ---
> 
> (Updated Oct. 23, 2015, 1:34 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3480
> https://issues.apache.org/jira/browse/MESOS-3480
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change refactors the Executor struct on Agent and adds support for 
> Executors to connect via the `api/v1/executor` endpoint on Agent. This is 
> similar to the change done in Master for the Scheduler HTTP API.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp d81a9c4d09d3f6be417120e412324258f19604a3 
>   src/slave/slave.cpp e9f2d1bf7978450f0cd471bdb5606305092fc98a 
> 
> Diff: https://reviews.apache.org/r/38874/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/
---

(Updated Oct. 22, 2015, 11:58 p.m.)


Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, and 
Vinod Kone.


Changes
---

More readable apply-review.sh.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added '--parent' option and made apply-review.sh call apply-reviews.py.


Diffs (updated)
-

  support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39420/diff/


Testing
---

Tested with python 2.7.

- with and without '-p'.
- Tested reviews with and without parents.


Thanks,

Artem Harutyunyan

Re: Review Request 39548: SchedulerTest.Suppress is flaky

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39548/#review103735
---


Patch looks great!

Reviews applied: [39548]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 5:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39548/
> ---
> 
> (Updated Oct. 23, 2015, 5:29 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3733
> https://issues.apache.org/jira/browse/MESOS-3733
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Root Cause: The reason is that the DECLINE call set filter as 1hr,
> the Clock::advance set as 100m. A race condition is that both DECLINE
> and SUPPRESS started up in different threads and the call Clock::advance
> may be called before SUPPRESS finished. The clock advanced for 100m which
> is greater than 1hr, this caused the allocator start to allocate resource
> again and ASSERT_TRUE(event.isPending()) will be failed.
> 
> Solution: Call SUPPRESS first, and make sure SUPPRESS call ready before
> call DECLINE.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp 7946cb48d62f4ed6d0fdbc771746518e31921f97 
> 
> Diff: https://reviews.apache.org/r/39548/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu 14.04
> make 
> make check
> bin/mesos-tests.sh --gtest_filter="ContentType/SchedulerTest.Suppress/*"  
> --gtest_repeat=-1 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103731
---

Ship it!


This looks great - a really few minor nits, but then it's good to go!


support/apply-reviews.py (lines 47 - 48)


s/cerror/error

However, I think it'd read better as
```
# Trailing slash required by ReviewBoard's REST API
```



support/apply-reviews.py (line 49)


```
if 'review_id' in options:
```
is more pythonic
(also below: `elif 'github' in options`)



support/apply-reviews.py (line 262)


you don't need the trailing \
also, please indent the second row, keeping the opening quotes aligned:
```
description='foo bar baz '
'jump the fox')
```



support/apply-reviews.py (lines 287 - 290)


does this work? (I really am curious, I didn't know about the 'mutually 
exclusive' option!)

in other words, don't you get an exception by trying to access **both** 
`args.github` AND `args.review_id` (because one of the two is missing)?


- Marco Massenzio


On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 23, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote:
> > support/apply-reviews.py, line 160
> > 
> >
> > you don't really need to escape the quotes, just take advantage of 
> > Python being able to use single and double quotes interchangeably (or even 
> > use """ if you really want to be hip :)
> 
> Artem Harutyunyan wrote:
> I actually do need to escape the quotes becasue {message} is multiline 
> and I am executing the `cmd` in a shell.
> 
> Marco Massenzio wrote:
> I don't understand your comment, I'm afraid. What I did mean was that you 
> can write:
> ```
> cmd = "git commit --author '{author}' -am '{message}'".format(author = 
> review['author'], ...)
> ```
> and this will have the exact same meaning as your code (whether that's 
> correctly escaped and executed in the shell, I really can't say).

I see what you're saying. I am using single quotes throughout the code, that's 
why I preferred quoting to switching to double quotes for these particular 
instances.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
---


On Oct. 22, 2015, 11:18 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 22, 2015, 11:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38883/
---

(Updated Oct. 22, 2015, 11:18 p.m.)


Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
and Vinod Kone.


Changes
---

Rebased.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/38883/diff/


Testing
---

Tested the script with python 2.7.


Thanks,

Artem Harutyunyan

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Artem Harutyunyan]

> On Oct. 22, 2015, 11:48 p.m., Marco Massenzio wrote:
> > Looks good - I'd still be happier with "Better Bash" :) would you mind 
> > "fixing" apply-review.sh?
> > 
> > Thanks!

Done.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
---


On Oct. 22, 2015, 11:58 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 22, 2015, 11:58 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote:
> > support/apply-reviews.py, lines 277-282
> > 
> >
> > this code look familiar and I remember already commenting about 
> > `applied` :)
> 
> Artem Harutyunyan wrote:
> Yep, it used to be a `dict`, and I changed it to a `set`. Did I miss 
> anything?
> 
> Marco Massenzio wrote:
> sorry - I wasn't paying attention.
> all good.

Nope, I just wanted to make sure that I did not miss anything :).


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
---


On Oct. 22, 2015, 11:18 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 22, 2015, 11:18 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

[Artem Harutyunyan]

> On Oct. 22, 2015, 2:20 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 25
> > 
> >
> > s/extract_//

Marco commented earlier on this one `nit: you are 'masking' the global builtin 
id() here - that's a PEP8 violation, could you please rename to something like 
rid?`.


> On Oct. 22, 2015, 2:20 p.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 32
> > 
> >
> > s/parent_review/review_chain/ ?

That's exactly what I renamed that function to two reviews down the chain.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38705/#review103656
---


On Oct. 22, 2015, 11:16 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38705/
> ---
> 
> (Updated Oct. 22, 2015, 11:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, Joseph Wu, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38705/diff/
> 
> 
> Testing
> ---
> 
> Tested the script with python 2.7.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103729
---

Ship it!


Looks good - I'd still be happier with "Better Bash" :) would you mind "fixing" 
apply-review.sh?

Thanks!

- Marco Massenzio


On Oct. 23, 2015, 6:19 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 23, 2015, 6:19 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Marco Massenzio]

> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote:
> > support/apply-reviews.py, line 106
> > 
> >
> > it would be really nice if we could make our code work under both 2.7 
> > and 3.x Python ;)
> 
> Artem Harutyunyan wrote:
> replaced this with `print(output)`, that should work in 3.x, correct?

yes, but only by mistake :)
(`(output)` is interpreted as a 1-tuple in 2.7 and `print` is still assumed to 
be without parentheses - in 3.4, as a paren-surrounded string)

You will need to add (as the VERY FIRST line after the shebang):
```
from __future__ import print_function
```


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103208
---


On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 23, 2015, 6:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/
---

(Updated Oct. 23, 2015, 3:21 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
Arya.


Bugs: MESOS-3800
https://issues.apache.org/jira/browse/MESOS-3800


Repository: mesos


Description
---

We recently switched to using LinuxLauncher by default 
(https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
 This causes problems with running the slave in a Docker container. 

This patch introduces a function for checking whether the machine is suited for 
running Linux launcher. For the time being it checks whether the freezer cgroup 
subsystem enabled, as the Linux launcher evolves we might want to add more 
checks.


Diffs
-

  src/slave/containerizer/linux_launcher.hpp 
35b3315498d690ed66616617aa7d51455371fb5b 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 

Diff: https://reviews.apache.org/r/39604/diff/


Testing
---

- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).


Thanks,

Artem Harutyunyan

Review Request 39614: Quota: Added Status Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/
---

Review request for mesos, Alexander Rukletsov and Bernd Mathiske.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Quota: Added Status Validation Tests.


Diffs
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39614/diff/


Testing
---

make check


Thanks,

Joerg Schad

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---

(Updated Oct. 23, 2015, 10:34 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description (updated)
---

Added status handling for quota master endpoint.
Tests are in next Review.


Diffs
-

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
---

Test output: 
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39325/#review103873
---


Looks good to me except the last test. Looks quite ugly to me:( Still thinking 
about better solutions.

The code part looks good to me, we can commit that first (with one more unit 
test to test the coordinator election logic with IGNORE responses).


src/log/consensus.cpp (line 334)


'type' is optional. Do you need to check `has_type()`?



src/log/consensus.cpp (line 356)


This is a little hard to read. Can you introduce a small helper:
```
bool isReject(const Response& response)
{
  if (response.has_type()) {
// new replica
return response.type() == PromiseResponse::REJECT;
  } else {
// old replica
return !response.okay();
  }
}
```

To be consistent, you might wanna introduce `isIgnore` as well.



src/log/coordinator.cpp (line 197)


Please add a CHECK(response.has_type())?



src/messages/log.proto (line 142)


s/old master/old coordinator/



src/messages/log.proto (line 163)


Could you please put 'type' field right below 'okay' field?



src/messages/log.proto (line 213)


Ditto. Please put it right below 'okay' field.



src/tests/log_tests.cpp (line 643)


2 lines apart.



src/tests/log_tests.cpp (line 647)


I think we put `:` in the next line.



src/tests/log_tests.cpp (line 703)


No snake_case please. Also, we try not to use tailing underscore for member 
fields if possible.



src/tests/log_tests.cpp (line 733)


Please add a brief descrption about what this test is doing (instead of 
just a JIRA number).


- Jie Yu


On Oct. 20, 2015, 8:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39325/
> ---
> 
> (Updated Oct. 20, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Bugs: MESOS-3280
> https://issues.apache.org/jira/browse/MESOS-3280
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3280. The basic problem is that replicas silently ignore inbound Promise
> and Write requests if they have not finished the recovery protocol yet 
> (because
> they can't safely vote on such requests). Hence, if we try to do a Paxos round
> while a quorum of nodes have not finished recovering, the Paxos round will 
> never
> complete. In particular, this might happen during coordinator election:
> coordinator election (which is implemented as performing a full Paxos round)
> starts as soon as the candidate coordinator replica has finished the recovery
> protocol. If several nodes start concurrently, a quorum of those nodes might
> still be executing the recovery protocol, and hence the coordinator will never
> be elected.
> 
> To address this, add "ignored" responses to the Promise and Write 
> sub-protocols:
> if a proposer sees a quorum of "ignored" responses to a promise or write 
> request
> it has issued, it knows the request will never succeed.  When used for
> coordinator election, the current coding will retry immediately (without a
> backoff).
> 
> Note that replicas will still silently drop promise/write requests if another
> kind of problem occurs (e.g., an I/O error prevents reading/writing log
> data). We might consider changing this, although it will require some thought:
> e.g., if a replica's disk is broken, sending an "ignored" message on every
> request might flood the network.
> 
> CODE REVIEW TO DISCUSS / FIX:
> 
> * Test mock is incredibly ugly: it works, but we clearly need a better 
> approach
>   before committing this. I've been chatting with @tnachen to find a better
>   approach but haven't got anything that works yet.
> 
> * Should we add a backoff when retrying after a failed coordinator election?
> 
> * Should we also send back an "ignored" response if an I/O error occurs?
> 
> 
> Diffs
> -
> 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   

Re: Review Request 39325: Fixed race between coordinator election and recovery in replicated log.

[Neil Conway]

> On Oct. 23, 2015, 11:52 p.m., Jie Yu wrote:
> > Looks good to me except the last test. Looks quite ugly to me:( Still 
> > thinking about better solutions.
> > 
> > The code part looks good to me, we can commit that first (with one more 
> > unit test to test the coordinator election logic with IGNORE responses).

Thanks for the review!

Re test mock, yes it is awful as written (not intended to be committed). I 
played around with using some GMock magic here: 
https://gist.github.com/neilconway/96a94661e485dcade2ad -- it _should_ work but 
it doesn't compile for some reason (see comment on gist). I'll try again soon, 
although help from someone who knows FutureResult and friends would be helpful.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39325/#review103873
---


On Oct. 20, 2015, 8:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39325/
> ---
> 
> (Updated Oct. 20, 2015, 8:45 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, and Timothy Chen.
> 
> 
> Bugs: MESOS-3280
> https://issues.apache.org/jira/browse/MESOS-3280
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3280. The basic problem is that replicas silently ignore inbound Promise
> and Write requests if they have not finished the recovery protocol yet 
> (because
> they can't safely vote on such requests). Hence, if we try to do a Paxos round
> while a quorum of nodes have not finished recovering, the Paxos round will 
> never
> complete. In particular, this might happen during coordinator election:
> coordinator election (which is implemented as performing a full Paxos round)
> starts as soon as the candidate coordinator replica has finished the recovery
> protocol. If several nodes start concurrently, a quorum of those nodes might
> still be executing the recovery protocol, and hence the coordinator will never
> be elected.
> 
> To address this, add "ignored" responses to the Promise and Write 
> sub-protocols:
> if a proposer sees a quorum of "ignored" responses to a promise or write 
> request
> it has issued, it knows the request will never succeed.  When used for
> coordinator election, the current coding will retry immediately (without a
> backoff).
> 
> Note that replicas will still silently drop promise/write requests if another
> kind of problem occurs (e.g., an I/O error prevents reading/writing log
> data). We might consider changing this, although it will require some thought:
> e.g., if a replica's disk is broken, sending an "ignored" message on every
> request might flood the network.
> 
> CODE REVIEW TO DISCUSS / FIX:
> 
> * Test mock is incredibly ugly: it works, but we clearly need a better 
> approach
>   before committing this. I've been chatting with @tnachen to find a better
>   approach but haven't got anything that works yet.
> 
> * Should we add a backoff when retrying after a failed coordinator election?
> 
> * Should we also send back an "ignored" response if an I/O error occurs?
> 
> 
> Diffs
> -
> 
>   src/log/consensus.cpp 59f80d02d1d3c11683631f3fc5f6e923b5ebdf96 
>   src/log/coordinator.cpp 5500bca77f3020e0051010c5c178a20a3c7ad44a 
>   src/log/replica.hpp 33d3f1d9e89035936c67739898e73a06b391fcd0 
>   src/log/replica.cpp 75d39ff56822bf00fce9daf5c1e3befb75f2e039 
>   src/messages/log.proto d73b33f865963292af580945659ad0e800f2a204 
>   src/tests/log_tests.cpp f2dd47cfbe73fb18c360a637db009b7d391a782e 
> 
> Diff: https://reviews.apache.org/r/39325/diff/
> 
> 
> Testing
> ---
> 
> "make check" passes, including a new test that uses a newly constructed mock 
> to ensure we're testing the message schedule described above.
> 
> I also wrote a script stops and starts mesos-master in a loop, removing the 
> replicated log each time. Without the patch, this occasionally fails with a 
> "registry fetch" timeout; with the patch, you can observe several scenarios 
> where coordinator election is reborted and retried because a quorum of 
> ignored responses is seen. Note that in some cases, we need to retry 
> coordinator election up to ~70 times (!), because we don't currently use a 
> backoff; that should probably be fixed, per comments above. But the important 
> point is that election eventually succeeds and we don't hang.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39493: Added `yum update nss` to CentOS 6.6 install docs.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/
---

(Updated Oct. 23, 2015, 11:58 p.m.)


Review request for mesos, Adam B and haosdent huang.


Changes
---

Changed to just update nss and dependencies.


Summary (updated)
-

Added `yum update nss` to CentOS 6.6 install docs.


Bugs: MESOS-3506
https://issues.apache.org/jira/browse/MESOS-3506


Repository: mesos


Description (updated)
---

Added `yum update nss` to CentOS 6.6 install docs.


Diffs (updated)
-

  docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 

Diff: https://reviews.apache.org/r/39493/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39230: Added prevention of SASL deprecation warnings all around its invocations on OS X.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39230/#review103885
---

Ship it!


Ship It!

- Michael Park


On Oct. 22, 2015, 10:02 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39230/
> ---
> 
> (Updated Oct. 22, 2015, 10:02 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3030
> https://issues.apache.org/jira/browse/MESOS-3030
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   configure.ac 66f9b32 
>   src/authentication/cram_md5/authenticatee.cpp b03b44a 
>   src/authentication/cram_md5/authenticator.cpp f238872 
>   src/authentication/cram_md5/auxprop.cpp abf0f8d 
> 
> Diff: https://reviews.apache.org/r/39230/diff/
> 
> 
> Testing
> ---
> 
> ./configure && make check 
> OSX, clang3.7 + gcc4.9
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 39591: [stout]: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39591/
---

(Updated Oct. 24, 2015, 12:06 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Also applied patchset with manual changes.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/abort.hpp 
2b003d26d6b6b65b1d7b1dd6396f808c35b53177 
  3rdparty/libprocess/3rdparty/stout/include/stout/attributes.hpp 
27087041d8255b96159bb10c184f00cf5bc9c34e 
  3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 
4893e7ba0b7d83fd3ba36bf18aa541c60293cc23 
  3rdparty/libprocess/3rdparty/stout/include/stout/bits.hpp 
b9a9c20125229c8150660e5969e136b07cecb169 
  3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 
e9cf85637157f98a0eac166096bb18fa5652c669 
  3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 
0d51c8d418acb49b52cebfb644ee0476d6ec4502 
  3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp 
b550bfee696c85c0ade3feaf5d38e20eb4c1ce78 
  3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 
e58ee43623d72b52dd8682e3d976da74e8bec9e8 
  3rdparty/libprocess/3rdparty/stout/include/stout/dynamiclibrary.hpp 
5d0970fe9f712d7162eec522c83905292892c94d 
  3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 
12ba1ca861114e60f8276c0ee91c543abcfc2519 
  3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp 
38dabd45aa1d7f02e9991ce4ae28b44cd39db87c 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp 
ab609a0d7922298eaf89648200fabd843f8201e0 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 
3c320a319edce83af0287b0b014234f7e7ec6e0b 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
a289f8303740394ec1a0900e643d33e3c18a831d 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
7cf4feff87dd08201a410596d2862383c29021af 
  3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 
25252015d04884dae7238129e2d7313a615967ca 
  3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 
d9d0fd4febd540252ae53fb4af7eb061983d0133 
  3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp 
642bd4ce640cfdbf3c122cec64d72c9434d89fa3 
  3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
311b00b41398a9fd7374f3847190468ba59c1dc9 
  3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 
f766359fdd5a75e3a80d19be3e5c233e87357bde 
  3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp 
85c773ac675c88b313dffda7a9c32bac42ebe62d 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp 
51ec75868e614042c339ab0eaa995c9996ddf124 
  3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 
1839d28638cd82dae10ba9b0f99c1a97cf34f9c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/interval.hpp 
d207dc5ad7558818da7fd0d04c6ef8df217b78c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
dc7c6522b283916b975a77957909f6cdc02944d3 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
9625894b69417faa796be5c4313b759cbcc1ce90 
  3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp 
6cbb2ac50dd23d78465e8690112fc01114ada07b 
  3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp 
89340fd79167a311c698740454db19e83c286952 
  3rdparty/libprocess/3rdparty/stout/include/stout/list.hpp 
60f0c8c67317872883857a1cd8f39d6d6a45d0c1 
  3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 
9428717fac4655898d7768957f02937592e1a398 
  3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 
5748c9e6d39551eee287f3e9804505cb2fd3fdd0 
  3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 
52d1eea6d04092caa8eba39ad69c2a474f854a8d 
  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
e49783a438157706b1be9745436bf666f45cab8b 
  3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp 
ce94fef4aeeb098668decc36606ee667915a15cd 
  3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp 
95b730c83ec357b33afae0d04182f7a72ffd28c4 
  3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 
ddd3dd9e015c583e04d72ac9a9b5a5ed6f1d49d5 
  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
db5e33220844d20ef08a7324f641eeb1ff6d2052 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/bootid.hpp 
75b4f9f249ee362e4e12070c1699a8bcd15385e9 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 
b6925962ae65ad9d41bf9fff77973c1117afcbd2 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/environment.hpp 

Re: Review Request 39590: Made license-headers doxygen-compatible.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Oct. 24, 2015, 12:06 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Also applied patchset with manual changes.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

and updating the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
  include/mesos/v1/scheduler/scheduler.hpp 
eaf9f90fc9da4d03871145874599bb6d4b781567 
  include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/authentication/cram_md5/authenticatee.hpp 
9d6293c32722272228652d0241c59c7eeb88d0a3 
  src/authentication/cram_md5/authenticatee.cpp 
b03b44a924632edf4424cfef1ae4163c4abc7b1a 
  src/authentication/cram_md5/authenticator.hpp 
e75469a2e50167582711308b301802c9dfd9fb97 
  src/authentication/cram_md5/authenticator.cpp 
f238872476d422856db48bd845d5941911fdf2b0 
  src/authentication/cram_md5/auxprop.hpp 
0fa87f45a40bdb99a5f8088c0d55144ffc2804db 
  src/authentication/cram_md5/auxprop.cpp 
abf0f8dfb7367342d11c2d7a99b9fc73d09b57a8 
  src/authorizer/authorizer.cpp e1b7057701b6219ee5f74885b364fdaf4bfe7843 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
  src/cli/mesos.cpp 

Re: Review Request 39399: Quota: Refactored hierarchical allocator in preparation for quota.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39399/#review103888
---

Ship it!


Ship It!

- Klaus Ma


On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39399/
> ---
> 
> (Updated Oct. 24, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39399/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/#review103889
---


Patch looks great!

Reviews applied: [39604, 37787]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 9:43 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37787/
> ---
> 
> (Updated Oct. 23, 2015, 9:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.
> 
> 
> Bugs: MESOS-3313
> https://issues.apache.org/jira/browse/MESOS-3313
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
>   support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
>   support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
>   support/jenkins_build_docker.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37787/diff/
> 
> 
> Testing
> ---
> 
> `jenkins-build-docker.sh` is a reworked version of the original 
> `jenkins-build.sh` that is ran by Jenkins buildbot for building and testing 
> Mesos distributions. 
> 
> Features:
>  * Runs libevent, SSL and ROOT tests.
>  * Easily add OS/compiler Docker images for testing Mesos.
>  * Exclude tests on per-image basis.
>  * Easily reproduce the test image locally.
>  * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, 
> ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).
> 
> How to run
> 
> The following environment variables have to be set for the script to run:
>  * OS - OS name/version. Currently images are available for ubuntu-14.04, 
> ubuntu-12.04, centos-7.1.
>  * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
>  * COMPILER - Compiler name/version. Currently available images include 
> gcc-4.8 (default value) on all platforms, clang-3.6 on ubuntu-14.04.
> 
> Examples:
> `OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' 
> COMPILER=clang-3.6 ./jenkins_build_docker.sh`
> `OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' 
> ./jenkins_build_docker.sh`
> 
> Working integration with [ASF 
> Jenkins](https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/)
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

> On Oct. 23, 2015, 12:18 a.m., Marco Massenzio wrote:
> > support/apply-reviews.py, lines 287-290
> > 
> >
> > does this work? (I really am curious, I didn't know about the 'mutually 
> > exclusive' option!)
> > 
> > in other words, don't you get an exception by trying to access **both** 
> > `args.github` AND `args.review_id` (because one of the two is missing)?

It does :-). `args` sets the value of the missing option to `None`.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/#review103731
---


On Oct. 23, 2015, 4:13 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39410/
> ---
> 
> (Updated Oct. 23, 2015, 4:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
> Massenzio, and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added support for github to apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39410/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39410: Added support for github to apply-reviews.py.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39410/
---

(Updated Oct. 23, 2015, 4:13 p.m.)


Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco 
Massenzio, and Vinod Kone.


Changes
---

Addressed comments.


Bugs: MESOS-3468
https://issues.apache.org/jira/browse/MESOS-3468


Repository: mesos


Description
---

Added support for github to apply-reviews.py.


Diffs (updated)
-

  support/apply-reviews.py PRE-CREATION 

Diff: https://reviews.apache.org/r/39410/diff/


Testing
---

Tested with python 2.7


Thanks,

Artem Harutyunyan

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103875
---



src/slave/containerizer/linux_launcher.cpp (lines 187 - 190)


It is pretty well readable already, hence this point is VERY minor...

I believe this should be formatted like any other boolean expression, not a 
function definition or invocation.
Please see 
http://google.github.io/styleguide/cppguide.html#Boolean_Expressions which we 
inherit here.


- Till Toenshoff


On Oct. 23, 2015, 10:21 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> ---
> 
> (Updated Oct. 23, 2015, 10:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-3800
> https://issues.apache.org/jira/browse/MESOS-3800
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> ---
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Till Toenshoff]

> On Oct. 23, 2015, 11:18 p.m., Till Toenshoff wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 187-190
> > 
> >
> > It is pretty well readable already, hence this point is VERY minor...
> > 
> > I believe this should be formatted like any other boolean expression, 
> > not a function definition or invocation.
> > Please see 
> > http://google.github.io/styleguide/cppguide.html#Boolean_Expressions which 
> > we inherit here.

```
  return ::geteuid() == 0 && cgroups::enabled() &&
 cgroups::hierarchy("freezer").isSome();
```

or 

```
  return ::geteuid() == 0 &&
 cgroups::enabled() &&
 cgroups::hierarchy("freezer").isSome();
```


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103875
---


On Oct. 23, 2015, 10:21 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> ---
> 
> (Updated Oct. 23, 2015, 10:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-3800
> https://issues.apache.org/jira/browse/MESOS-3800
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> ---
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103880
---



src/slave/containerizer/linux_launcher.cpp (line 181)


Nit: Wrap '{' to next line, like all function implementations


- Adam B


On Oct. 23, 2015, 3:21 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> ---
> 
> (Updated Oct. 23, 2015, 3:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
> Arya.
> 
> 
> Bugs: MESOS-3800
> https://issues.apache.org/jira/browse/MESOS-3800
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> ---
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/
---

(Updated Oct. 23, 2015, 4:48 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
Arya.


Changes
---

Addressed comments.


Bugs: MESOS-3800
https://issues.apache.org/jira/browse/MESOS-3800


Repository: mesos


Description
---

We recently switched to using LinuxLauncher by default 
(https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
 This causes problems with running the slave in a Docker container. 

This patch introduces a function for checking whether the machine is suited for 
running Linux launcher. For the time being it checks whether the freezer cgroup 
subsystem enabled, as the Linux launcher evolves we might want to add more 
checks.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.hpp 
35b3315498d690ed66616617aa7d51455371fb5b 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 

Diff: https://reviews.apache.org/r/39604/diff/


Testing
---

- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).


Thanks,

Artem Harutyunyan

Re: Review Request 39223: WIP Added Quota Request Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/
---

(Updated Oct. 23, 2015, 9:10 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description
---

Right now intented for TDD.


Diffs (updated)
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39223/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 39223: Added Quota Request Validation Tests.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/
---

(Updated Oct. 23, 2015, 9:10 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Summary (updated)
-

Added Quota Request Validation Tests.


Bugs: MESOS-3199
https://issues.apache.org/jira/browse/MESOS-3199


Repository: mesos


Description (updated)
---

see Summary.


Diffs
-

  src/tests/master_quota_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39223/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 39492: Added status endpoint for quota master endpoint.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/
---

(Updated Oct. 23, 2015, 9:32 p.m.)


Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
Remoortere.


Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073


Repository: mesos


Description
---

Added status handling for quota master endpoint.


Diffs (updated)
-

  src/master/master.hpp e7b16fdd21a8caa77a39956a8520cf1381186598 
  src/master/quota_handler.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39492/diff/


Testing
---

Test output: 
{"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]}


Thanks,

Joerg Schad

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/
---

(Updated Oct. 23, 2015, 2:43 p.m.)


Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.


Bugs: MESOS-3313
https://issues.apache.org/jira/browse/MESOS-3313


Repository: mesos


Description
---

See summary.


Diffs
-

  Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
  support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/jenkins_build_docker.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/37787/diff/


Testing (updated)
---

`jenkins-build-docker.sh` is a reworked version of the original 
`jenkins-build.sh` that is ran by Jenkins buildbot for building and testing 
Mesos distributions. 

Features:
 * Runs libevent, SSL and ROOT tests.
 * Easily add OS/compiler Docker images for testing Mesos.
 * Exclude tests on per-image basis.
 * Easily reproduce the test image locally.
 * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, 
ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).

How to run

The following environment variables have to be set for the script to run:
 * OS - OS name/version. Currently images are available for ubuntu-14.04, 
ubuntu-12.04, centos-7.1.
 * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
 * COMPILER - Compiler name/version. Currently available images include gcc-4.8 
(default value) on all platforms, clang-3.6 on ubuntu-14.04.

Examples:
`OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' 
COMPILER=clang-3.6 ./jenkins_build_docker.sh`
`OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' 
./jenkins_build_docker.sh`

Working integration with [ASF 
Jenkins](https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/)


Thanks,

Artem Harutyunyan

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/
---

(Updated Oct. 23, 2015, 2:58 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
Arya.


Repository: mesos


Description
---

We recently switched to using LinuxLauncher by default 
(https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
 This causes problems with running the slave in a Docker container. 

This patch introduces a function for checking whether the machine is suited for 
running Linux launcher. For the time being it checks whether the freezer cgroup 
subsystem enabled, as the Linux launcher evolves we might want to add more 
checks.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.hpp 
35b3315498d690ed66616617aa7d51455371fb5b 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 

Diff: https://reviews.apache.org/r/39604/diff/


Testing
---

- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).


Thanks,

Artem Harutyunyan

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/#review103872
---

Ship it!


Ship It!

- Kapil Arya


On Oct. 23, 2015, 5:58 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39604/
> ---
> 
> (Updated Oct. 23, 2015, 5:58 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, and Kapil 
> Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We recently switched to using LinuxLauncher by default 
> (https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
>  This causes problems with running the slave in a Docker container. 
> 
> This patch introduces a function for checking whether the machine is suited 
> for running Linux launcher. For the time being it checks whether the freezer 
> cgroup subsystem enabled, as the Linux launcher evolves we might want to add 
> more checks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.hpp 
> 35b3315498d690ed66616617aa7d51455371fb5b 
>   src/slave/containerizer/linux_launcher.cpp 
> c03b89eb0678825b03a052874d6262f377a39e13 
>   src/slave/containerizer/mesos/containerizer.cpp 
> d1fc5a460e7313828014eea999cf4e63dde01921 
> 
> Diff: https://reviews.apache.org/r/39604/diff/
> 
> 
> Testing
> ---
> 
> - Ran Mesoss tests in a Docker container where cgroup was not available.
> - Ran the new Jenkins script (https://reviews.apache.org/r/37787/).
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39450: Quota: Added hierarchical allocator-specific tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39450/#review103874
---


Patch looks great!

Reviews applied: [39317, 38218, 39399, 39400, 39401, 39450]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39450/
> ---
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 
> 
> Diff: https://reviews.apache.org/r/39450/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39584: Windows: Implemented `os::rmdir.hpp`.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39584/#review103858
---


Patch looks great!

Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 
39560, 39583, 39584]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 4:30 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39584/
> ---
> 
> (Updated Oct. 23, 2015, 4:30 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Implemented `os::rmdir.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> b6afe0e76366d0bc68d37097ced83a1e14828d84 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 3e6f2aafd0f541f512025dfa683ab4178701f7c4 
> 
> Diff: https://reviews.apache.org/r/39584/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39604: Added function that verifies prerequisites for using Linux launcher.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39604/
---

(Updated Oct. 23, 2015, 2:35 p.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, and Kapil Arya.


Changes
---

Addressed comments.


Repository: mesos


Description
---

We recently switched to using LinuxLauncher by default 
(https://github.com/apache/mesos/blame/master/src/slave/containerizer/mesos/containerizer.cpp#L217-L234).
 This causes problems with running the slave in a Docker container. 

This patch introduces a function for checking whether the machine is suited for 
running Linux launcher. For the time being it checks whether the freezer cgroup 
subsystem enabled, as the Linux launcher evolves we might want to add more 
checks.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.hpp 
35b3315498d690ed66616617aa7d51455371fb5b 
  src/slave/containerizer/linux_launcher.cpp 
c03b89eb0678825b03a052874d6262f377a39e13 
  src/slave/containerizer/mesos/containerizer.cpp 
d1fc5a460e7313828014eea999cf4e63dde01921 

Diff: https://reviews.apache.org/r/39604/diff/


Testing
---

- Ran Mesoss tests in a Docker container where cgroup was not available.
- Ran the new Jenkins script (https://reviews.apache.org/r/37787/).


Thanks,

Artem Harutyunyan

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/
---

(Updated Oct. 23, 2015, 2:41 p.m.)


Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.


Changes
---

Fixed exclusion filters for all platforms. Got Jenkins working 
https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/.


Bugs: MESOS-3313
https://issues.apache.org/jira/browse/MESOS-3313


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  Dockerfile 35abf25aa77ef3f8a68b803eb8ff18ad90a0ff7b 
  support/docker/centos-7.1-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-12.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-clang-3.6/Dockerfile PRE-CREATION 
  support/docker/ubuntu-14.04-gcc-4.8/Dockerfile PRE-CREATION 
  support/jenkins_build_docker.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/37787/diff/


Testing (updated)
---

`jenkins-build-docker.sh` is a reworked version of the original 
`jenkins-build.sh` that is ran by Jenkins buildbot for building and testing 
Mesos distributions. 

Features:
 * Runs libevent, SSL and ROOT tests.
 * Easily add OS/compiler Docker images for testing Mesos.
 * Exclude tests on per-image basis.
 * Easily reproduce the test image locally.
 * Three new test images (ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, 
ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8).

How to run

The following environment variables have to be set for the script to run:
 * OS - OS name/version. Currently images are available for ubuntu-14.04, 
ubuntu-12.04, centos-7.1.
 * CONFIGURATION - ./configure flags (e.g. '--enable-libevent').
 * COMPILER - Compiler name/version. Currently available images include gcc-4.8 
(default value) on all platforms, clang-3.6 on ubuntu-14.04.

Examples:
`OS=ubuntu-14.04 CONFIGURATION='--enable-ssl --enable-libevent' 
COMPILER=clang-3.6 ./jenkins_build_docker.sh`
`OS=centos-7.1 CONFIGURATION='--enable-ssl --enable-libevent' 
./jenkins_build_docker.sh`

Working integration with Jenkins: 
https://builds.apache.org/view/All/job/Mesos%20new%20jenkins/15/


Thanks,

Artem Harutyunyan

Re: Review Request 39005: stout: Added thread-safe replacement for strerror.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/
---

(Updated Oct. 23, 2015, 7:49 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
---

Incorporated Alexander's review comments.


Bugs: MESOS-3551
https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
---

This adds a thread-safe wrapper around strerror_r which has semantics similar 
to strerror. We plan to use this at call sites currently relying on strerror.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff 

Diff: https://reviews.apache.org/r/39005/diff/


Testing
---

make check


Thanks,

Benjamin Bannier

Review Request 39579: Updated docker registry client to check HTTP code.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39579/
---

Review request for mesos, Gilbert Song and Jojy Varghese.


Repository: mesos


Description
---

Updated docker registry client to check HTTP code.


Diffs
-

  src/slave/containerizer/provisioner/docker/registry_client.cpp 
24aa95c5800ff4dfb37465b71421b014b5dd5998 

Diff: https://reviews.apache.org/r/39579/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 39518: Changed write api.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103739
---



src/slave/containerizer/provisioner/docker/registry_client.cpp (line 615)


I find it surprising that this would need to be handled here since I would 
have expected a proper `write` to deal with that correctly.

Are you trying to work-around a bug elsewhere?



src/slave/containerizer/provisioner/docker/registry_client.cpp (line 633)


This seems to be happen in `write(int fd, void* data, size_t size)` already 
anyway.



src/slave/containerizer/provisioner/docker/registry_client.cpp (line 641)


Wouldn't this potentially cause data loss if the called `write` function 
cannot dump everything in the `fd`?


- Benjamin Bannier


On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39518/
> ---
> 
> (Updated Oct. 21, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3773
> https://issues.apache.org/jira/browse/MESOS-3773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3773.
> 
> Change:
> io::write(fd, string) has been having issues with junk being written to the
> file. Using io::write(fd, void*, size_t) does not have this issue.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39518/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39420/#review103742
---


Patch looks great!

Reviews applied: [38705, 38883, 39410, 39420]

All tests passed.

- Mesos ReviewBot


On Oct. 23, 2015, 6:58 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39420/
> ---
> 
> (Updated Oct. 23, 2015, 6:58 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere, Joseph Wu, Marco Massenzio, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3468
> https://issues.apache.org/jira/browse/MESOS-3468
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '--parent' option and made apply-review.sh call apply-reviews.py.
> 
> 
> Diffs
> -
> 
>   support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3 
>   support/apply-reviews.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39420/diff/
> 
> 
> Testing
> ---
> 
> Tested with python 2.7.
> 
> - with and without '-p'.
> - Tested reviews with and without parents.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 39518: Changed write api.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39518/#review103740
---



src/slave/containerizer/provisioner/docker/registry_client.cpp (line 637)


Did we ever find out why before we just use another interface?


- Timothy Chen


On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39518/
> ---
> 
> (Updated Oct. 21, 2015, 6:13 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3773
> https://issues.apache.org/jira/browse/MESOS-3773
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See MESOS-3773.
> 
> Change:
> io::write(fd, string) has been having issues with junk being written to the
> file. Using io::write(fd, void*, size_t) does not have this issue.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 24aa95c5800ff4dfb37465b71421b014b5dd5998 
> 
> Diff: https://reviews.apache.org/r/39518/diff/
> 
> 
> Testing
> ---
> 
> Make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>