Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review167341
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On July 20, 2016, 6:10 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated July 20, 2016, 6:10 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> ffe3382da8b1199e257a72ca9034fbccec9494b1 
> 
> 
> Diff: https://reviews.apache.org/r/47095/diff/7/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review143034
---



@Shuai, did you pull the master upstream before rebasing?

- Gilbert Song


On July 19, 2016, 11:10 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated July 19, 2016, 11:10 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> ffe3382da8b1199e257a72ca9034fbccec9494b1 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated July 20, 2016, 6:10 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Rebase again.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
  src/tests/containerizer/provisioner_docker_tests.cpp 
ffe3382da8b1199e257a72ca9034fbccec9494b1 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

> On 七月 13, 2016, 1:32 p.m., Guangya Liu wrote:
> > @Lin Shuai, can you please help rebase this?

I did some clean up before for 
src/tests/containerizer/filesystem_isolator_tests.cpp here 
https://reviews.apache.org/r/44160/ , for the new added test cases, instead of 
keeping consistent, what about use the latest style before we clean up other 
old style issues?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review142061
---


On 七月 13, 2016, 4:16 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated 七月 13, 2016, 4:16 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> ffe3382da8b1199e257a72ca9034fbccec9494b1 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review142113
---


Ship it!




Ship It!

- Gilbert Song


On July 13, 2016, 9:16 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated July 13, 2016, 9:16 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> ffe3382da8b1199e257a72ca9034fbccec9494b1 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated July 13, 2016, 4:16 p.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Rebased onto latest master.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
  src/tests/containerizer/provisioner_docker_tests.cpp 
ffe3382da8b1199e257a72ca9034fbccec9494b1 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On July 13, 2016, 1:32 p.m., Guangya Liu wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1104
> > 
> >
> > ```javascript
> > EXPECT_TRUE(wait->has_status());
> > ```

All the other code in the tests use `wait.get()`, so i guess we better follow 
it here.


> On July 13, 2016, 1:32 p.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 578
> > 
> >
> > ```javascript
> > SlaveID slaveId = slaveRegisteredMessage->slave_id();
> > ```

Again, all the other code in the tests use `slaveRegisteredMessage.get()`.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review142061
---


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review142061
---



@Lin Shuai, can you please help rebase this?


src/tests/containerizer/mesos_containerizer_tests.cpp (line 1104)


```javascript
EXPECT_TRUE(wait->has_status());
```



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1105)


```javascript
EXPECT_EQ(0, wait->status());
```



src/tests/containerizer/provisioner_docker_tests.cpp (line 578)


```javascript
SlaveID slaveId = slaveRegisteredMessage->slave_id();
```


- Guangya Liu


On 五月 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated 五月 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review137265
---



Yu Jie, can you please help check if we can merge this? Thanks.

- Guangya Liu


On 五月 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated 五月 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133296
---


Ship it!




Ship It!

- Guangya Liu


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133285
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On May 14, 2016, 2:30 p.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, lines 606-609
> > 
> >
> > It seems a bit confuse for me: You are setting shell as false above, 
> > but here for the command using shell again.
> > 
> > I try to update code as following:
> > CommandInfo command;
> > command.set_shell(false);
> > command.set_value("/bin/echo");
> > command.add_arguments("echo");
> > command.add_arguments("-n");
> > command.add_arguments("$MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");
> > 
> > But test failed, seems the env.txt was not generated:
> > I0514 10:16:05.751787 21127 master.cpp:6827] Removing task 
> > d9820712-987a-4a7b-997a-498d38a95c60 with resources cpus(*):1; mem(*):128 
> > of framework a40a88ba-f3cb-45ad-95b8-a1892f583495- on agent 
> > a40a88ba-f3cb-45ad-95b8-a1892f583495-S0 at slave(1)@9.21.51.124:52999 
> > (mesos-24.eng.platformlab.ibm.com)
> > ../../src/tests/containerizer/provisioner_docker_tests.cpp:654: Failure
> > os::read(envfile): Failed to open file 
> > '/tmp/ProvisionerSandboxTest_ROOT_INTERNET_CURL_MesosSandboxEnv_IxqEbu/slaves/a40a88ba-f3cb-45ad-95b8-a1892f583495-S0/frameworks/a40a88ba-f3cb-45ad-95b8-a1892f583495-/executors/d9820712-987a-4a7b-997a-498d38a95c60/runs/latest/env.txt':
> >  No such file or directory
> > 
> > Do you know why?

Because we need to redirect the output to the `env.txt` file. To do that we 
need a shell :)


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133273
---


On May 14, 2016, 4:30 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 4:30 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 14, 2016, 4:30 p.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Address gyliu's comments.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133273
---




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)


s/roots/rootfs



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1107)


s/roots/rootfs



src/tests/containerizer/provisioner_docker_tests.cpp (line 604)


Can you please add some comments here to clairfy why setting the shell as 
false?

// NOTE: We use a non-shell command here because 'sh' might not be
// in the PATH. 'alpine' does not specify env PATH in the image. On
// some linux distribution, '/bin' is not in the PATH by default.



src/tests/containerizer/provisioner_docker_tests.cpp (lines 606 - 609)


It seems a bit confuse for me: You are setting shell as false above, but 
here for the command using shell again.

I try to update code as following:
CommandInfo command;
command.set_shell(false);
command.set_value("/bin/echo");
command.add_arguments("echo");
command.add_arguments("-n");
command.add_arguments("$MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");

But test failed, seems the env.txt was not generated:
I0514 10:16:05.751787 21127 master.cpp:6827] Removing task 
d9820712-987a-4a7b-997a-498d38a95c60 with resources cpus(*):1; mem(*):128 of 
framework a40a88ba-f3cb-45ad-95b8-a1892f583495- on agent 
a40a88ba-f3cb-45ad-95b8-a1892f583495-S0 at slave(1)@9.21.51.124:52999 
(mesos-24.eng.platformlab.ibm.com)
../../src/tests/containerizer/provisioner_docker_tests.cpp:654: Failure
os::read(envfile): Failed to open file 
'/tmp/ProvisionerSandboxTest_ROOT_INTERNET_CURL_MesosSandboxEnv_IxqEbu/slaves/a40a88ba-f3cb-45ad-95b8-a1892f583495-S0/frameworks/a40a88ba-f3cb-45ad-95b8-a1892f583495-/executors/d9820712-987a-4a7b-997a-498d38a95c60/runs/latest/env.txt':
 No such file or directory

Do you know why?


- Guangya Liu


On May 14, 2016, 8:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review133269
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 8:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 14, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 14, 2016, 8:55 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Fix the tests on CentOS.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132881
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 604
> > 
> >
> > This test may fail on CentOS 7, please refer to 
> > https://reviews.apache.org/r/44985/ and 
> > https://issues.apache.org/jira/browse/MESOS-4810
> 
> Shuai Lin wrote:
> It's a bit awkward to use redirection if I use shell=false for the 
> `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it 
> would work. Can you give it a try on centos?
> 
> Guangya Liu wrote:
> It will not work if you do not set shell as false, the reason is that 
> your command will be run as `sh -c command` and `sh` cannot be found.
> 
> I did some test with your patch on centos 7, failed as expected.
> 
> I0512 00:05:14.570722  2907 exec.cpp:535] Executor sending status update 
> TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
> cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
> 3d0009ac-5e31-41eb-a98a-db83e50a30bc-
> I0512 00:05:14.571805  2838 slave.cpp:3221] Handling status update 
> TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
> cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
> 3d0009ac-5e31-41eb-a98a-db83e50a30bc- from executor(1)@9.21.51.124:54983
> sh -c '/bin/echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt'
> Failed to exec: No such file or directory

Thanks, I'll fix it then.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
---


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

> On May 10, 2016, 8:34 a.m., Guangya Liu wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 604
> > 
> >
> > This test may fail on CentOS 7, please refer to 
> > https://reviews.apache.org/r/44985/ and 
> > https://issues.apache.org/jira/browse/MESOS-4810
> 
> Shuai Lin wrote:
> It's a bit awkward to use redirection if I use shell=false for the 
> `CommandInfo`, so I change `echo -n ...` to `/bin/echo -n ...`, hopefully it 
> would work. Can you give it a try on centos?

It will not work if you do not set shell as false, the reason is that your 
command will be run as `sh -c command` and `sh` cannot be found.

I did some test with your patch on centos 7, failed as expected.

I0512 00:05:14.570722  2907 exec.cpp:535] Executor sending status update 
TASK_RUNNING (UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc-
I0512 00:05:14.571805  2838 slave.cpp:3221] Handling status update TASK_RUNNING 
(UUID: cb95db8a-8c1b-4276-9aae-5744790b3540) for task 
cd090f3e-7d59-4529-87e0-72cc000bead3 of framework 
3d0009ac-5e31-41eb-a98a-db83e50a30bc- from executor(1)@9.21.51.124:54983
sh -c '/bin/echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt'
Failed to exec: No such file or directory


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
---


On May 12, 2016, 1:42 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 12, 2016, 1:42 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 12, 2016, 1:42 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

address review comments


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132207
---


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

> On May 9, 2016, 5:59 a.m., Guangya Liu wrote:
> > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1065
> > 
> >
> > s/SandboxEnv/ContainerSandboxEnv ?

I prefer `MesosSandboxEnv`, since that's what's being tested.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132207
---


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132393
---




src/tests/containerizer/provisioner_docker_tests.cpp (line 604)


This test may fail on CentOS 7, please refer to 
https://reviews.apache.org/r/44985/ and 
https://issues.apache.org/jira/browse/MESOS-4810


- Guangya Liu


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132207
---




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1065)


s/SandboxEnv/ContainerSandboxEnv ?



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1083)


const string command



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1110)


4 spaces



src/tests/containerizer/provisioner_docker_tests.cpp (line 561)


s/ROOT_INTERNET_CURL_MesosSandboxEnv/ROOT_INTERNET_CURL_ContainerSandboxEnv



src/tests/containerizer/provisioner_docker_tests.cpp (lines 580 - 582)


MockScheduler sched;

MesosSchedulerDriver driver(
,
frameworkInfo,
master.get()->pid,
DEFAULT_CREDENTIAL);



src/tests/containerizer/provisioner_docker_tests.cpp (lines 630 - 638)


4 spaces



src/tests/containerizer/provisioner_docker_tests.cpp (line 640)


s/MESOS_SANDBOX/`MESOS_SANDBOX`


- Guangya Liu


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132204
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 9, 2016, 3:51 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 9, 2016, 3:51 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

(Updated May 9, 2016, 3:51 a.m.)


Review request for mesos, Guangya Liu and Jie Yu.


Changes
---

Address gyliu's comments.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs (updated)
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132192
---




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)


What about 

s/docker/appc images/rootfs ?

The OCI and other image spec may be introduced later, using `rootfs` may be 
more accurate?



src/tests/containerizer/mesos_containerizer_tests.cpp (line 1107)


s/normal tasks/tasks without rootfs



src/tests/containerizer/provisioner_docker_tests.cpp (line 559)


s/MESOS_SANDBOX/`MESOS_SANDBOX`



src/tests/containerizer/provisioner_docker_tests.cpp (line 644)


s/MESOS_SANDBOX/`MESOS_SANDBOX`


- Guangya Liu


On 五月 8, 2016, 11:47 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated 五月 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132190
---




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)


s/MESOS_SANDBOX/`MESOS_SANDBOX`



src/tests/containerizer/provisioner_docker_tests.cpp (line 560)


s/ROOT_MesosSandboxEnv/ROOT_INTERNET_CURL_MesosSandboxEnv

The test will be failed in China due to GFW, so we need to add INTERNET 
filter here.



src/tests/containerizer/provisioner_docker_tests.cpp (line 571)


we can remove this as it is the default value



src/tests/containerizer/provisioner_docker_tests.cpp (lines 601 - 608)


You can use below to replace it.

TaskInfo task = createTask(
offer.slave_id(),
Resources::parse("cpus:1;mem:128").get(),
"echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");


- Guangya Liu


On 五月 8, 2016, 11:47 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated 五月 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132174
---



Patch looks great!

Reviews applied: [47095]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 8, 2016, 11:47 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> ---
> 
> (Updated May 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
> https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> ---
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 47095: Added tests for MESOS_SANDBOX env for unified containerizer.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/
---

Review request for mesos, Guangya Liu and Jie Yu.


Bugs: MESOS-5312
https://issues.apache.org/jira/browse/MESOS-5312


Repository: mesos


Description
---

Added tests for MESOS_SANDBOX env for unified containerizer.


Diffs
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 
  src/tests/containerizer/provisioner_docker_tests.cpp 
69505c922617273effc2eb52b0c567a3c01bf640 

Diff: https://reviews.apache.org/r/47095/diff/


Testing
---

"make check" on ubuntu 14.04 64bit with gcc 4.8.4


Thanks,

Shuai Lin