Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by irl):

 Replying to [comment:24 iwakeh]:
 > The dot file should not be in the 'web/images' folder as it is only the
 source for the png.  The png should always be committed (same process as
 with our generated spec jsps, for example), because these depend on the
 dot implementation used.  Even with a future Ant task at hand that limits
 dependencies for building the war file.  Regarding dot file location: what
 about `src/main/resources/doc/ecosystem.dot` or
 `src/main/resources/doc/ecosystem/ecosystem.dot`?

 Having reviewed the man page for dot, I noticed the standard file
 extension is actually .gv so I've changed that and moved the source to
 `src/main/resources/graphviz`. The idea would be that this serves as a
 common directory for any graphviz source files and then they are installed
 into `src/main/resources/web/images` with the "generate-graphviz-pngs" Ant
 task (added in a separate commit).

 > A second thought about this graph, which I like and understand, but it
 might cause confusion for the 'uninitiated' as it is not really described
 fully.  And, the metrics-lib oval is kind of dangling in the air and the
 "via metrics-lib" label used three times.  I first thought of making it a
 different shape (see attachment),
 > [[Image(https://trac.torproject.org/projects/tor/attachment/ticket/23169
 /another-overview.png)]]
 > but then noticed that this also is not at all self-explanatory.  So,
 maybe leave the picture out unless we describe the graph a little more?

 I've removed the floating metrics-lib and instead added 3 smaller boxes on
 the paths between CollecTor and the consuming services. I've also added an
 additional paragraph above the image that should help to explain it
 further. If people want to learn additional information, they should read
 the relevant pages that are linked in the text, this is only meant to be a
 quick primer.

 > Should we think about removing Schneier's quote from the header now (as
 was requested before)?
 > It's on the about page now.

 I've created #25411 (as a subticket of #25404) for this.

 Changes are rebased and pushed to my
 [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/23169|task/23169]] branch.

 I would be particularly interested in feedback on my Ant, as I haven't
 done much Ant and learning what I'm doing wrong is good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25412 [Core Tor/Tor]: TrackHostExits option in torrc file not working as documented

2018-03-02 Thread Tor Bug Tracker & Wiki
#25412: TrackHostExits option in torrc file not working as documented
---+
 Reporter:  LittleTorFanAnnie  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+

Comment (by arma):

 Replying to [ticket:25412 LittleTorFanAnnie]:
 > Version: Tor 7.5 (The versions in the picker are massively out of date -
 not a good sign.)

 Btw, the explanation for this one is that you mean Tor Browser 7.5. Tor
 Browser and Tor are different programs.

 https://blog.torproject.org/tor-browser-75-released
 links to the Tor Browser changelog:
 https://gitweb.torproject.org/builders/tor-browser-
 build.git/plain/projects/tor-browser/Bundle-
 Data/Docs/ChangeLog.txt?h=maint-7.5
 which tells you that the Tor version is 0.3.2.9.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25412 [Core Tor/Tor]: TrackHostExits option in torrc file not working as documented

2018-03-02 Thread Tor Bug Tracker & Wiki
#25412: TrackHostExits option in torrc file not working as documented
---+
 Reporter:  LittleTorFanAnnie  |  Owner:  (none)
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Core Tor/Tor   |Version:
 Severity:  Normal | Resolution:
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by arma):

 * component:  - Select a component => Core Tor/Tor


Comment:

 Note that Tor Browser configures its Tor in a nonstandard way, by using
 the socks isolation feature to separate each socks request (browser tab)
 to a different circuit.

 I suggest you start by taking a standard Tor, run by itself and not as
 part of Tor Browser, and see if TrackHostExits works for you there. (It
 looks like you're on Windows? In that case you probably want the Windows
 Expert Bundle.)

 If using it on a vanilla Tor works, then the bug is that TrackHostExits
 and IsolateSOCKSAuth don't play well together, and maybe we fix it by
 documenting the difference better, or maybe there's some better fix.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25412 [- Select a component]: TrackHostExits option in torrc file not working as documented

2018-03-02 Thread Tor Bug Tracker & Wiki
#25412: TrackHostExits option in torrc file not working as documented
--+
 Reporter:  LittleTorFanAnnie |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  - Select a component  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 1. Shut down Tor
 2. Edit torrc file at c:\Program Files (x86)\Tor
 Browser\Browser\TorBrowser\Data\Tor\torrc so that it has the line:

 TrackHostExits .

 According to docs, this should mean to use the same exit node for all
 websites.

 3. Launch Tor, and open any two websites - let's say
 https://duckduckgo.com/ and https://www.nasa.gov/
 4. Note that the exit node for each website may differ.  If not
 reproducing, try using the IP addresses rather than URLs.

 Why is this a problem?  Some sites will generate a link that only works
 from the same IP as the original page.  (In my case, one link is an IP
 that cannot be resolved to a URL, so using a URL isn't an option.)

 Version: Tor 7.5 (The versions in the picker are massively out of date -
 not a good sign.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25411 [Metrics/Website]: Remove quote from header

2018-03-02 Thread Tor Bug Tracker & Wiki
#25411: Remove quote from header
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:  #25404
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 This has been previously requested to reduce the header size make better
 use of the space on the screen. The quote is featured in full on the about
 page, so we're not removing it entirely.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

2018-03-02 Thread Tor Bug Tracker & Wiki
#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+

Comment (by ahf):

 This is related to the PT windows code I'm looking at, but we can still
 rip this out if nobody is using it.

 Also see: https://lists.torproject.org/pipermail/tor-
 relays/2017-April/012198.html - only one response here so I think it's
 safe to remove.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21765 [Core Tor/Tor]: PortForwardingHelper stdout/stderr log forwarding seems fragile

2018-03-02 Thread Tor Bug Tracker & Wiki
#21765: PortForwardingHelper stdout/stderr log forwarding seems fragile
-+-
 Reporter:  ahf  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  0.3.4.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  technical-debt,  |  Actual Points:
  031-deferred-20170425, 032-unreached   |
Parent ID:  #25409   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  031-deferred-20170425, 032-unreached => technical-debt,
 031-deferred-20170425, 032-unreached
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #21765 [Core Tor/Tor]: PortForwardingHelper stdout/stderr log forwarding seems fragile

2018-03-02 Thread Tor Bug Tracker & Wiki
#21765: PortForwardingHelper stdout/stderr log forwarding seems fragile
-+-
 Reporter:  ahf  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Low  |  Milestone:  Tor:
 |  unspecified
Component:  Core Tor/Tor |Version:  Tor:
 |  unspecified
 Severity:  Normal   | Resolution:
 Keywords:  031-deferred-20170425,   |  Actual Points:
  032-unreached  |
Parent ID:  #25409   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * parent:   => #25409


Comment:

 #25409 will fix this issue by removing the option.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

2018-03-02 Thread Tor Bug Tracker & Wiki
#25409: rip out PortForwarding options
+
 Reporter:  arma|  Owner:  (none)
 Type:  enhancement | Status:  new
 Priority:  Medium  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * keywords:   => technical-debt
 * points:   => 0.5
 * milestone:   => Tor: 0.3.4.x-final


Comment:

 Let's deprecate it in 0.3.4 then?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25410 [Applications/Tor Browser]: The Tor browser button icon and no script icon are low resolution

2018-03-02 Thread Tor Bug Tracker & Wiki
#25410: The Tor browser button icon and no script icon are low resolution
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--

Comment (by Dbryrtfbcbhgf):

 The attached photo
 
[[Image(https://trac.torproject.org/projects/tor/attachment/ticket/25410/issue.png)]]
 shows the icons I'm referring too.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25410 [Applications/Tor Browser]: The Tor browser button icon and no script icon are low resolution

2018-03-02 Thread Tor Bug Tracker & Wiki
#25410: The Tor browser button icon and no script icon are low resolution
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+--
Changes (by Dbryrtfbcbhgf):

 * Attachment "issue.png" added.


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25410 [Applications/Tor Browser]: The Tor browser button icon and no script icon are low resolution

2018-03-02 Thread Tor Bug Tracker & Wiki
#25410: The Tor browser button icon and no script icon are low resolution
--+--
 Reporter:  Dbryrtfbcbhgf |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 The Tor browser button icon and no script icon are low resolution and the
 Tor onion on {{{about:tor}}} also looks low resolution. I have a screen
 resolution of 13.3-inch (2560 x 1600) and I'm running macOS 10.13.3
 (17D102)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

2018-03-02 Thread Tor Bug Tracker & Wiki
#25409: rip out PortForwarding options
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by nickm):

 IIUC, one of yawning's findings was that a depressingly large number of
 consumer routers can't actually be used this way, since they tend to brick
 themselves when upnp'd too hard.

 I would be okay with removing this option only if we first deprecate it
 for a full release cycle.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25409 [Core Tor/Tor]: rip out PortForwarding options

2018-03-02 Thread Tor Bug Tracker & Wiki
#25409: rip out PortForwarding options
--+
 Reporter:  arma  |  Owner:  (none)
 Type:  enhancement   | Status:  new
 Priority:  Medium|  Milestone:
Component:  Core Tor/Tor  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+
 A relay operator on tor-relays@ just got snookered into setting
 PortForwarding to 1, probably because he thought it would help him get
 port forwarding working on his relay.

 I think the reality is that almost nobody uses this option, and also we
 don't recommend it.

 Yawning rewrote the crappy dangerous C upnp apps in go:
 https://gitweb.torproject.org/tor.git/tree/src/tools/tor-fw-helper/README
 https://gitweb.torproject.org/tor-fw-helper.git/tree/README.md

 But I don't think we've taken any steps to get that go version into any
 user's hands.

 Also, our past use case, where Vidalia would launch Tor and want to let
 ordinary users turn themselves into relays or bridges, is long deprecated.

 Alternatives to "rip it out" would be "get yawning's go stuff packaged
 properly in Debian", or "add yawning's go stuff to the tor tarball and
 build it and ship it too".

 See also #21765 and its great phrase "I wonder how long this has been
 broken for".

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25408 [Applications/Tor Browser]: torbrowser doesn't download files properly

2018-03-02 Thread Tor Bug Tracker & Wiki
#25408: torbrowser doesn't download files properly
--+--
 Reporter:  cypherpunks   |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Critical  |   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 go to https://github.com/raspberrypi/linux/wiki/config.txt
 save page as...
 the default filename uses ยท bullet points as dividers and the downloaded
 file is 0 bytes, replace the bullet points with a normal dash (-) and the
 file downloads correctly
 this is torbrowser 7.5 on linux

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by karsten):

 I'll leave the file/path discussion to you two. I trust iwakeh to have a
 better idea of where things should go in the project structure!

 I like both graphs and could imagine adding either of the two. I also
 agree that adding some more description wouldn't hurt. But if that's
 difficult now, I'd rather want to merge what we have here than delay it
 only because the graph could use more explanations. We can always make it
 better later.

 Regarding the quote from the header, I think we should do it. But wasn't
 that difficult from a web design point of view? I mean, it's certainly
 easy to remove the text, but that might make the header look oversized.
 Note that the full quote has always been on the About page since we
 redesigned the website. Maybe we should move this part to another ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25314 [Applications/Tor Mail]: Build error during Windows (32- and 64-bit builds) of Thunderbird

2018-03-02 Thread Tor Bug Tracker & Wiki
#25314: Build error during Windows (32- and 64-bit builds) of Thunderbird
---+
 Reporter:  sukhbir|  Owner:  (none)
 Type:  defect | Status:  closed
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Mail  |Version:
 Severity:  Normal | Resolution:  fixed
 Keywords: |  Actual Points:
Parent ID: | Points:
 Reviewer: |Sponsor:
---+
Changes (by sukhbir):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Patch submitted and merged upstream in
 https://bugzilla.mozilla.org/show_bug.cgi?id=1442648

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25407 [Applications/Tor Browser]: Unable to retrieve tor settings - Please ensure Tor is running

2018-03-02 Thread Tor Bug Tracker & Wiki
#25407: Unable to retrieve tor settings - Please ensure Tor is running
--+--
 Reporter:  Toro  |  Owner:  tbb-team
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal|   Keywords:
Actual Points:|  Parent ID:
   Points:|   Reviewer:
  Sponsor:|
--+--
 I use TorBrowser (7.5 FF 52.6.0 64-bit) with an independent Tor (0.3.2.9)
 process. Linux 4.13.9-1-ARCH

 Configs:

 in .bashrc :
 export TOR_SKIP_LAUNCH=1

 in start-tor-browser :
 setControlPortPasswd ${TOR_CONTROL_PASSWD:='""'}

 and every configuration suggested in start-tor-browser modified in
 about:config

 This always worked fine for browsing, but with one inconvenience: I wasn't
 able to use the option "Tor Network Settings..." at the TorButton menu, it
 always gives the error "Unable to retrieve tor settings - Please ensure
 Tor is running".


 Checking the logs, I've found that TorButton gets the right password for
 control connection, but TorLauncher receives the password with extra
 double quotes
 TorButton connects with no problem, but TorLauncher doesn't.


 Here's the log:

 [03-02 18:41:18] TorLauncher DBUG: Opening control connection to
 127.0.0.1:9151
 [03-02 18:41:18] TorLauncher DBUG: Sending Tor command: AUTHENTICATE
 "\"\""
 [03-02 18:41:18] TorLauncher DBUG: Command response: 515 Authentication
 failed: Password did not match HashedControlPassword value from
 configuration
 [03-02 18:41:18] TorLauncher NOTE: authenticate failed
 [03-02 18:41:18] TorLauncher DBUG: Opening control connection to
 127.0.0.1:9151
 [03-02 18:41:18] TorLauncher DBUG: Sending Tor command: AUTHENTICATE
 "\"\""
 [03-02 18:41:18] TorLauncher DBUG: Command response: 515 Authentication
 failed: Password did not match HashedControlPassword value from
 configuration
 [03-02 18:41:18] TorLauncher NOTE: authenticate failed
 [03-02 18:41:18] TorLauncher DBUG: readTorSettings done; didSucceed: false
 [03-02 18:41:18] TorLauncher DBUG: initDialog done

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25400 [Core Tor/Tor]: CIRC_BW event miscounts, should count all circ data

2018-03-02 Thread Tor Bug Tracker & Wiki
#25400: CIRC_BW event miscounts, should count all circ data
--+
 Reporter:  mikeperry |  Owner:  mikeperry
 Type:  defect| Status:  needs_review
 Priority:  Medium|  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tor-stats |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+

Comment (by atagar):

 > atagar may also have more information on CIRC_BW usage by Nyx and other
 stem apps

 Stem and Nyx don't use CIRC_BW. Stem has parsing code for the events, but
 that's all.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25406 [Webpages]: Indicate that Gitian is no longer used in https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/BuildingWithGitian

2018-03-02 Thread Tor Bug Tracker & Wiki
#25406: Indicate that Gitian is no longer used in
https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/BuildingWithGitian
-+
 Reporter:  cypherpunks  |  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Webpages |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+
 Indicate that Gitian is no longer used in
 https://trac.torproject.org/projects/tor/wiki/doc/TorBrowser/BuildingWithGitian

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25383 [Metrics/Website]: Deprecate stats.html and stats/*.csv files

2018-03-02 Thread Tor Bug Tracker & Wiki
#25383: Deprecate stats.html and stats/*.csv files
-+--
 Reporter:  karsten  |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by dcf):

 Today I wanted to make a graph that uses userstats-combined.csv, like in
 comment:5:ticket:20495. The graph shows, for one transport, the top
 countries that use that transport. (It's the opposite of
 https://metrics.torproject.org/userstats-bridge-combined.html, which
 shows, for one country, the top transports used by that country.) It would
 be less convenient to make my graph without userstats-combined.csv.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by iwakeh):

 Yes, this is a nice Metrics-About page!

 Some remarks/questions:
 The dot file should not be in the 'web/images' folder as it is only the
 source for the png.  The png should always be committed (same process as
 with our generated spec jsps, for example), because these depend on the
 dot implementation used.  Even with a future Ant task at hand that limits
 dependencies for building the war file.  Regarding dot file location: what
 about `src/main/resources/doc/ecosystem.dot` or
 `src/main/resources/doc/ecosystem/ecosystem.dot`?

 A second thought about this graph, which I like and understand, but it
 might cause confusion for the 'uninitiated' as it is not really described
 fully.  And, the metrics-lib oval is kind of dangling in the air and the
 "via metrics-lib" label used three times.  I first thought of making it a
 different shape (see attachment),
 [[Image(https://trac.torproject.org/projects/tor/attachment/ticket/23169
 /another-overview.png)]]
 but then noticed that this also is not at all self-explanatory.  So, maybe
 leave the picture out unless we describe the graph a little more?

 Should we think about removing Schneier's quote from the header now (as
 was requested before)?
 It's on the about page now.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--
Changes (by iwakeh):

 * Attachment "another-overview.png" added.

 ecosystem with metrics-lib box

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by iwakeh):

 Replying to [comment:21 karsten]:
 > Thanks! I like it. Please find [https://gitweb.torproject.org/karsten
 /metrics-
 web.git/commit/?h=irl/task/23169=400161ee4bce4d53244713025d335cb27dc30295
 commit 400161e in my irl/task/23169 branch] with a small layout fix.
 >
 > iwakeh, did you also want to do a review?

 Yes, starting with the latest changes from comment:22.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib clients, e.g., those using DescriptorIndexCollector

2018-03-02 Thread Tor Bug Tracker & Wiki
#24290: Configure timeout for metrics-lib clients, e.g., those using
DescriptorIndexCollector
-+
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  defect   | Status:  needs_revision
 Priority:  High |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Great that you were able to track this down!

 Regarding the suggested solution, leaving this as JVM property feels a bit
 ugly to me. First, with every config option we're making it harder to
 remember how to run our tools. And in this case, if somebody forgets to
 set the option, they'll end up with a bad default value. Second, this
 timeout is something that we should decide as developers and not leave up
 to operators. If we don't know what a good value is, how do the operators?
 And it's not that environments vary by that much.

 Should we simply hard-code five minutes? It's way better than waiting
 infinitely, and five seconds seems possibly too short. And if we find out
 that five minutes is a bad value, we can further tweak it in the future.
 Of course, we should document this timeout in the relevant documentation.
 And then it should be okay to hard-code it.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22594 [Metrics/Onionoo]: Escape characters in contact lines break hourly updater

2018-03-02 Thread Tor Bug Tracker & Wiki
#22594: Escape characters in contact lines break hourly updater
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Onionoo  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  new => accepted
 * owner:  metrics-team => iwakeh


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by irl):

 Ah, good catch. I've fixed the layout and rebased to squash the commit.
 I've done it slightly differently to avoid needing to depend on wrapping
 behaviour of blocks. It should make the result more reliable.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

2018-03-02 Thread Tor Bug Tracker & Wiki
#23136: moat integration (fetch bridges for the user)
+--
 Reporter:  mcs |  Owner:  brade
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R, ux-team  |  Actual Points:
Parent ID:  #24689  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by mcs):

 Replying to [comment:76 gk]:
 > I don't think 1) and 2) have necessarily the same root causes. I agree
 with you that if I am using, say, meek-azure right now and then do request
 bridges bad things will happen. Could you open a new ticket for that
 scenario? (in case there is none already that covers it).

 I opened #25405. What I meant by "the same root cause" in this case is
 that the Moat meek client usage and other meek client usage interfere with
 each other. In other words, if we fix the interference both problems will
 disappear. But I have more to say below.

 > However, 1) as I tested it is different. As I said me using meek has
 been minutes, hours, days etc. ago and I am now surfing without any
 bridges. Still, as soon as I want to request bridges from TPO things go
 wrong. Not sure where exactly the bug is but meek should not be running
 anymore as soon as I am not using it anymore. I wonder if we could tackle
 that one while we are at it. Open a new ticket, too? 2) is more like my
 case 1) because strictly speaking we are done using meek requesting the
 bridges (and should *not* be using it in parallel anymore).

 Thank you for the clarification. What you said makes sense. The behavior
 Kathy and I see is that after tor uses a meek PT the meek-client-
 torbrowser process (and the associated meek-client and firefox processes)
 stay running until tor is either shutdown or it receives a SIGHUP. I don't
 know why the PT process is kept running or if there is a timeout after
 which point it will be killed, and so far I didn't find the tor code that
 handles PT process lifetime. I do see the same behavior with obfs4proxy
 (that process stays running after it has been removed from the tor
 configuration).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20234 [Metrics/Website]: Add CollecTor's file-structure protocol

2018-03-02 Thread Tor Bug Tracker & Wiki
#20234: Add CollecTor's file-structure protocol
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

Comment (by karsten):

 Looks good. Merged!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--

Comment (by karsten):

 Thanks! I like it. Please find [https://gitweb.torproject.org/karsten
 /metrics-
 web.git/commit/?h=irl/task/23169=400161ee4bce4d53244713025d335cb27dc30295
 commit 400161e in my irl/task/23169 branch] with a small layout fix.

 iwakeh, did you also want to do a review?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25405 [Applications/Tor Launcher]: cannot use Moat if a meek bridge is configured

2018-03-02 Thread Tor Bug Tracker & Wiki
#25405: cannot use Moat if a meek bridge is configured
---+---
 Reporter:  mcs|  Owner:  brade
 Type:  defect | Status:  new
 Priority:  Medium |  Milestone:
Component:  Applications/Tor Launcher  |Version:
 Severity:  Normal |   Keywords:
Actual Points: |  Parent ID:
   Points: |   Reviewer:
  Sponsor:  Sponsor4   |
---+---
 If Tor Browser is configured to use a meek transport (e.g., meek-amazon or
 meek-azure), the Moat interface cannot be used to request bridges from
 BridgeDB. The root cause is that Tor Launcher's Moat implementation uses
 the same meek client programs and configuration as the built-in meek
 bridges use, which means when Moat starts up it starts an "invisible"
 firefox that tries to use the profile.meek-http-helper profile (which is
 already in use).

 Ideas for fixing this (from ticket:23136#comment:55):
 a) Use a separate browser profile for the meek browser when it is used for
 Moat (this requires a fix for #12716 and possibly other things inside
 meek-client-torbrowser).
 b) Give up on using the secondary browser and use meek-client to
 obfs4proxy's meek_lite mode for Moat. This has the downside that the TLS
 fingerprint will not match Firefox's when doing Moat).
 c) Modify Tor Launcher to kill the tor daemon before using Moat. But this
 might have undesirable side effects because some other part of the browser
 may be using the Tor network (e.g., for a file download). Also, while Tor
 Launcher knows how to restart tor if it is killed, it might be difficult
 to make sure we kill and restart tor in a robust fashion when we are in
 the middle of configuring settings.

 Kathy and I are currently in favor of pursuing a) but could be convinced
 to do something else.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20234 [Metrics/Website]: Add CollecTor's file-structure protocol

2018-03-02 Thread Tor Bug Tracker & Wiki
#20234: Add CollecTor's file-structure protocol
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  needs_review
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  accepted => needs_review


Comment:

 Please review the additions to CollecTor's file protocol description for
 webstats on
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit?h=task-20234
 this branch].
 This mainly refers to the webstats spec in order to avoid duplication.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20287 [Metrics/Website]: Perform another review of CollecTor's file protocol and fix any remaining differences to the code

2018-03-02 Thread Tor Bug Tracker & Wiki
#20287: Perform another review of CollecTor's file protocol and fix any 
remaining
differences to the code
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:  #20234   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  accepted => needs_review


Comment:

 Seems the repeatedly interrupted work on this ticket was cause for some
 confusion.

 The torperf/onionperf issue was already cleared before the first merge to
 master, i.e., nothing left to do about the topic mentioned in comment:7,
 cf.
 
[https://gitweb.torproject.org/collector.git/tree/src/main/resources/docs/PROTOCOL#n143
 collector.git].

 The topic from comment:9 and the initial description mention are the same
 issue, which is
 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-20287
 patched here].

 I couldn't identify any other issues.

 Please review.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25398 [Core Tor/Tor]: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set

2018-03-02 Thread Tor Bug Tracker & Wiki
#25398: tests fail if COMPAT_HAS_MMAN_AND_PAGESIZE is not set
-+
 Reporter:  Hello71  |  Owner:  (none)
 Type:  defect   | Status:  needs_review
 Priority:  Low  |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Minor| Resolution:
 Keywords:  easy intro tor-test  |  Actual Points:
Parent ID:   | Points:  0.1
 Reviewer:   |Sponsor:
-+
Changes (by Hello71):

 * status:  new => needs_review


Comment:

 https://cgit.alxu.ca/tor.git/commit/?h=bug25398

 I think it is better to remove rather than fix. this code doesn't even
 compile in tests, so clearly nobody actually checks to see if it works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

2018-03-02 Thread Tor Bug Tracker & Wiki
#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  needs_review
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+
Changes (by Hello71):

 * status:  new => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25399 [Core Tor/Tor]: mmap length doesn't need to be page-aligned

2018-03-02 Thread Tor Bug Tracker & Wiki
#25399: mmap length doesn't need to be page-aligned
--+
 Reporter:  Hello71   |  Owner:  (none)
 Type:  defect| Status:  new
 Priority:  Low   |  Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Minor | Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  0.5
 Reviewer:|Sponsor:
--+

Comment (by Hello71):

 https://cgit.alxu.ca/tor.git/commit/?h=bug25399

 removes cruft, very slightly increases performance.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] [Tor Bug Tracker & Wiki] Batch modify: #23973, #24422

2018-03-02 Thread Tor Bug Tracker & Wiki
Batch modification to #23973, #24422 by irl:
parent to #25404

Comment:
It may be worthwhile doing this at the same time as #25404 to save duplicating 
effort.

--
Tickets URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25404 [Metrics/Website]: Update design to use new styleguide (bootstrap 4)

2018-03-02 Thread Tor Bug Tracker & Wiki
#25404: Update design to use new styleguide (bootstrap 4)
-+--
 Reporter:  irl  |  Owner:  metrics-team
 Type:  project  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:  ux-team
Actual Points:   |  Parent ID:
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 https://styleguide.torproject.org/ provides a Bootstrap fork customised
 for Tor Project to provide a consistent visual identity across
 subprojects. Bootstrap 3 is no longer maintained and at some point we will
 need to update to Bootstrap 4 anyway to avoid any brokenness in browsers
 that may appear (we have already seen brokenness that we've had to patch
 manually in #25254).

 While implementing this, we may also choose to make other design changes
 or to reorganise navigation on the site. It would probably be worthwhile
 to hold off making any large changes to the current structure of the site
 until it has been considered how it would work with the new styles.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20234 [Metrics/Website]: Add CollecTor's file-structure protocol

2018-03-02 Thread Tor Bug Tracker & Wiki
#20234: Add CollecTor's file-structure protocol
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  enhancement  | Status:  accepted
 Priority:  Low  |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  assigned => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25403 [Metrics/Website]: Create jsp with bgp documentation

2018-03-02 Thread Tor Bug Tracker & Wiki
#25403: Create jsp with bgp documentation
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:  #24229
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 Use the provided html, cf parent ticket.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

[tor-bugs] #25402 [Metrics/Website]: Add `contrib` section to CollecTor's file structure protocol

2018-03-02 Thread Tor Bug Tracker & Wiki
#25402: Add `contrib` section to CollecTor's file structure protocol
-+--
 Reporter:  iwakeh   |  Owner:  metrics-team
 Type:  enhancement  | Status:  new
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   |   Keywords:
Actual Points:   |  Parent ID:  #24229
   Points:   |   Reviewer:
  Sponsor:   |
-+--
 
[https://gitweb.torproject.org/collector.git/tree/src/main/resources/docs/PROTOCOL
 CollecTor's file structure protocol]

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #20287 [Metrics/Website]: Perform another review of CollecTor's file protocol and fix any remaining differences to the code

2018-03-02 Thread Tor Bug Tracker & Wiki
#20287: Perform another review of CollecTor's file protocol and fix any 
remaining
differences to the code
-+--
 Reporter:  iwakeh   |  Owner:  iwakeh
 Type:  defect   | Status:  accepted
 Priority:  High |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:  #20234   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * owner:  metrics-team => iwakeh
 * status:  assigned => accepted


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24217 [Metrics/Statistics]: Specify data format and aggregation process of statistics offered by metrics.tp.o (was: Specify data format and aggregation process of new IPv6 relay statis

2018-03-02 Thread Tor Bug Tracker & Wiki
#24217: Specify data format and aggregation process of statistics offered by
metrics.tp.o
+--
 Reporter:  karsten |  Owner:  karsten
 Type:  enhancement | Status:  needs_review
 Priority:  High|  Milestone:
Component:  Metrics/Statistics  |Version:
 Severity:  Normal  | Resolution:
 Keywords:  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  iwakeh  |Sponsor:
+--

Comment (by iwakeh):

 Yes, the summary ought to be changed.  Attempted a generalization.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:19 karsten]:
 > New suggestion:

 Ok, I've implemented the suggestion.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib clients, e.g., those using DescriptorIndexCollector (was: Configure timeout for metrics-lib client, e.g., those using DescriptorIndex

2018-03-02 Thread Tor Bug Tracker & Wiki
#24290: Configure timeout for metrics-lib clients, e.g., those using
DescriptorIndexCollector
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib client, e.g., those using DescriptorIndexCollector (was: Use timeout for fetching remote index.json in DescriptorIndexCollector)

2018-03-02 Thread Tor Bug Tracker & Wiki
#24290: Configure timeout for metrics-lib client, e.g., those using
DescriptorIndexCollector
-+--
 Reporter:  karsten  |  Owner:  iwakeh
 Type:  defect   | Status:  needs_review
 Priority:  High |  Milestone:
Component:  Metrics  |Version:
 Severity:  Normal   | Resolution:
 Keywords:   |  Actual Points:
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+--
Changes (by iwakeh):

 * status:  accepted => needs_review
 * component:  Metrics/Library => Metrics


Comment:

 Moving this to component Metrics because all metrics-lib clients are
 concerned.

 I could reproduce the exact thread stack trace above.  The waiting there
 would indeed be stopped using a read timeout.
 Apparently, there is some connect timeout in place already (probably in
 the socket implementation) as can be viewed in CollecTor2's logs:
 {{{
 WARN o.t.d.i.DescriptorIndexCollector:77 Cannot fetch index file
 https://collector.torproject.org/index/index.json and hence cannot
 determine which remote files to fetch.  Aborting descriptor collection.
 java.net.ConnectException: Connection timed out (Connection timed out)
 at java.net.PlainSocketImpl.socketConnect(Native Method)
 at
 java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:350)
 at
 
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206)
 at
 java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188)
 at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
 at java.net.Socket.connect(Socket.java:589)
 at sun.security.ssl.SSLSocketImpl.connect(SSLSocketImpl.java:673)
 at
 sun.security.ssl.BaseSSLSocketImpl.connect(BaseSSLSocketImpl.java:173)
 at sun.net.NetworkClient.doConnect(NetworkClient.java:180)
 at sun.net.www.http.HttpClient.openServer(HttpClient.java:463)
...
 
sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:263)
 at java.net.URL.openStream(URL.java:1045)
 at
 org.torproject.descriptor.index.IndexNode.fetchIndex(IndexNode.java:101)
 at
 
org.torproject.descriptor.index.DescriptorIndexCollector.collectDescriptors(DescriptorIndexCollector.java:74)
 at
 
org.torproject.collector.sync.SyncManager.collectFromOtherInstances(SyncManager.java:59)
 at
 org.torproject.collector.sync.SyncManager.merge(SyncManager.java:43)
 at
 org.torproject.collector.cron.CollecTorMain.run(CollecTorMain.java:76)
 ...
 at java.lang.Thread.run(Thread.java:748)
 }}}
 Today I've noticed similar traces in the Onionoo logs.

 So in general, this is a java configuration not an implementation issue.
 The timeouts should not be hard-coded as the need for shorter or longer
 settings depends on the environment.

 As remedy two jvm properties need to be set
 {{{
 -Dsun.net.client.defaultConnectTimeout=5000
 -Dsun.net.client.defaultReadTimeout=5000
 }}}

 The read timeout fixes the problem reported in the description.  Setting
 the connect timeout, too, in order to be consistent.  Five seconds should
 be ok?

 (Slightly related: For the ftp implementation the timeout got changed from
 infinite to five minutes in
 [http://www.oracle.com/technetwork/java/javase/8u151-relnotes-3850493.html
 JDK 8u151].)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Hmm, the technical issue is fixed, but the gray box still uses too much
 space, in my opinion. I'm also less worried about "Welcome to Tor
 Metrics!" being redundant, because the navigation bar is far away at the
 top and not where most visitors will start reading.

 I'm also not sure whether "Open Data, Visualizations, and Tools for Tor!"
 should be the new motto of Tor Metrics. It's not wrong, but I haven't
 thought enough about it to say that it's exactly what we should be saying
 as first thing about Tor Metrics.

 New suggestion:

 {{{
 Welcome to Tor Metrics!

 The Tor network   Analyzing a live
 is one of the anonymity...
 largest...   Learn more >>
 }}}

 Working on the Ant task in a separate ticket and on the things related to
 #23973 as part of that ticket sounds good.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25394 [Applications/Tor Browser]: Clean up projects/debootstrap-image/config

2018-03-02 Thread Tor Bug Tracker & Wiki
#25394: Clean up projects/debootstrap-image/config
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R, boklm201803,  |  Actual Points:
  tbb-rbm|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Looks good. It's commit ee58c17648e4c71d799096467ae6b9a617af9f9f on
 `master`.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+--
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_review
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+--
Changes (by irl):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:17 karsten]:
 >  - I see where the "portal" comes from. I'd say let's wait for those
 other portals to exist before deciding about re-introducing that term for
 Tor Metrics.

 This sounds good.

 >  - Building the ecosystem diagram should indeed be an Ant task. But we
 should also check in the PNG file, so that one doesn't have to use
 graphviz in order to build the website. In any case, we can still add that
 Ant task after merging.

 Ok, I'll make a new ticket for this once this is merged.

 >  - The new "Open Data, Visualizations, and Tools for Tor!" is really
 huge. And at a resolution of ~768..991 it overlaps with the text on the
 right. How about we just write "Welcome to Tor Metrics" there? (Untested
 how that would look like.)

 "Welcome to Tor Metrics" seems redundant, it already says Tor Metrics in
 the header. I've worked out why it was overlapping for you though, you
 must not be loading the Tor Styleguide Approved Fonts. I've fixed this now
 so that the responsiveness works when you don't have the fonts loaded and
 are using the default fonts for Tor Browser on High Security mode.

 If it still overlaps for you, then you must be using some other font for
 some reason that I haven't thought of.

 >  - The "Learn more >>" button looks a little bit lost there. It's also
 not as important for most visitors, in particular returning visitors.
 Maybe we can tone it down by turning it into a common link in the second
 paragraph? Like, a link from "great care", or so.

 I've reduced the size of the button and moved it to be joined to the
 smaller text.

 >  - I like how the six boxes to Users, Servers, etc. are summarized under
 "Analysis", which was something that we discussed on #23973 for the
 navigation in general. Wouldn't it also make sense to pick "Services" as
 title for the three new boxes? They are direct links to Services subpages,
 just as Users, Servers, etc. will be direct links to Analysis subpages.
 And if we say "Services" there, we can use the cogs symbol, which looks a
 bit nicer than the circled question mark.

 This is now renamed.

 >  - Somewhat unrelated to this change, we should consider changing the
 navigation group in the secondary navbar (on extra small devices) from
 "Metrics" to "Analysis". Just reduce your browser size to a minimum and
 click on the donut to see what I mean. This could be part of #23973, too,
 though.

 I think this is better part of #23973.

 >  - Entirely unrelated, I found that the copyright in the footer still
 says 2017. If you like, feel free to update that, too. If not, we'll do it
 afterwards.

 Done.

 >  - If you rebase, be sure to rebase to current master. I made some more
 changes yesterday.

 Done.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25394 [Applications/Tor Browser]: Clean up projects/debootstrap-image/config

2018-03-02 Thread Tor Bug Tracker & Wiki
#25394: Clean up projects/debootstrap-image/config
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:
 Keywords:  TorBrowserTeam201803R, boklm201803,  |  Actual Points:
  tbb-rbm|
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201803, boklm201803, tbb-rbm =>
 TorBrowserTeam201803R, boklm201803, tbb-rbm


Comment:

 There is a patch for review in branch `bug_25394`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25394=ee58c17648e4c71d799096467ae6b9a617af9f9f

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25306 [Core Tor/Tor]: tor_assertion_failed_(): Bug: ../src/or/hs_service.c:1985: rotate_all_descriptors: Assertion service->desc_current failed; aborting.

2018-03-02 Thread Tor Bug Tracker & Wiki
#25306: tor_assertion_failed_(): Bug: ../src/or/hs_service.c:1985:
rotate_all_descriptors: Assertion service->desc_current failed; aborting.
+--
 Reporter:  cypherpunks |  Owner:  dgoulet
 Type:  defect  | Status:
|  merge_ready
 Priority:  Medium  |  Milestone:  Tor:
|  0.3.3.x-final
Component:  Core Tor/Tor|Version:  Tor:
|  0.3.3.2-alpha
 Severity:  Normal  | Resolution:
 Keywords:  tor-hs crash 033-must 032-backport  |  Actual Points:
Parent ID:  | Points:
 Reviewer:  asn |Sponsor:
+--
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

 (I don't really like that the new check is nested inside an old check, but
 fixing that would introduce non-trivial changes (but still pretty easy to
 do). Feel free to fix that if you want or not.)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25339 [Applications/Tor Browser]: Install python 3.6 for building HTTPS-Everywhere

2018-03-02 Thread Tor Bug Tracker & Wiki
#25339: Install python 3.6 for building HTTPS-Everywhere
-+-
 Reporter:  boklm|  Owner:  tbb-
 |  team
 Type:  task | Status:  closed
 Priority:  Medium   |  Milestone:
Component:  Applications/Tor Browser |Version:
 Severity:  Normal   | Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201803R,  |  Actual Points:
  boklm201802, tbb-backport  |
Parent ID:   | Points:
 Reviewer:   |Sponsor:
-+-
Changes (by gk):

 * status:  needs_review => closed
 * keywords:  tbb-rbm, TorBrowserTeam201803R, boklm201802 => tbb-rbm,
 TorBrowserTeam201803R, boklm201802, tbb-backport
 * resolution:   => fixed


Comment:

 Thanks. Looks good. Let's test it in the next alpha and then think about a
 backport. Merged to `master` (commit
 7f6cb4caa95b7818e4482f41fd333f5a2a8d60f1).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

2018-03-02 Thread Tor Bug Tracker & Wiki
#23136: moat integration (fetch bridges for the user)
+--
 Reporter:  mcs |  Owner:  brade
 Type:  defect  | Status:  closed
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:  fixed
 Keywords:  TorBrowserTeam201803R, ux-team  |  Actual Points:
Parent ID:  #24689  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:74 mcs]:
 > I should have mentioned that we have not yet addressed items 1) and 2)
 from comment:49. The root cause of both problems is the same: we cannot do
 Moat things while tor has a meek client running. As I mentioned in
 comment:55, there is no simple solution for that issue.

 I don't think 1) and 2) have necessarily the same root causes. I agree
 with you that if I am using, say, meek-azure right now and then do request
 bridges bad things will happen. Could you open a new ticket for that
 scenario? (in case there is none already that covers it).

 However, 1) as I tested it is different. As I said me using meek has been
 minutes, hours, days etc. ago and I am now surfing without any bridges.
 Still, as soon as I want to request bridges from TPO things go wrong. Not
 sure where exactly the bug is but meek should not be running anymore as
 soon as I am not using it anymore. I wonder if we could tackle that one
 while we are at it. Open a new ticket, too? 2) is more like my case 1)
 because strictly speaking we are done using meek requesting the bridges
 (and should *not* be using it in parallel anymore).

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #24642 [Obfuscation/meek]: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser

2018-03-02 Thread Tor Bug Tracker & Wiki
#24642: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser
--+
 Reporter:  mcs   |  Owner:  dcf
 Type:  defect| Status:  closed
 Priority:  Medium|  Milestone:
Component:  Obfuscation/meek  |Version:
 Severity:  Normal| Resolution:  fixed
 Keywords:|  Actual Points:
Parent ID:  #24689| Points:
 Reviewer:|Sponsor:
--+
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 We are done here as it works. dcf: I guess you want to open a new ticket
 for your preferred fix?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

2018-03-02 Thread Tor Bug Tracker & Wiki
#23136: moat integration (fetch bridges for the user)
+--
 Reporter:  mcs |  Owner:  brade
 Type:  defect  | Status:  needs_review
 Priority:  Very High   |  Milestone:
Component:  Applications/Tor Launcher   |Version:
 Severity:  Normal  | Resolution:
 Keywords:  TorBrowserTeam201803R, ux-team  |  Actual Points:
Parent ID:  #24689  | Points:
 Reviewer:  |Sponsor:  Sponsor4
+--

Comment (by gk):

 Replying to [comment:73 mcs]:
 > A new patch that addresses the items found during review is here:
 > https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug23136-05
 >
 > To see our recent changes, you can look at the "squash!" commits on
 brade's bug23136-04 branch:
 > https://gitweb.torproject.org/user/brade/tor-
 launcher.git/log/?h=bug23136-04

 Looks good, great work! Applied to `master` (commit
 e921bb15681ac54c9e937b564d31a2a6ec2ceb33). \o/

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25380 [Core Tor/Tor]: Transparent proxy not working with linux kernel 4.15.6

2018-03-02 Thread Tor Bug Tracker & Wiki
#25380: Transparent proxy not working with linux kernel 4.15.6
-+-
 Reporter:  vafan|  Owner:  (none)
 Type:  defect   | Status:  new
 Priority:  High |  Milestone:  Tor:
 |  0.3.3.x-final
Component:  Core Tor/Tor |Version:  Tor:
 |  0.3.2.9
 Severity:  Major| Resolution:
 Keywords:  033-must, hang, 032-backport, 031|  Actual Points:
  -backport-maybe, 029-backport-maybe, 025   |
  -backport-maybe|
Parent ID:   | Points:  0.5
 Reviewer:   |Sponsor:
-+-
Changes (by teor):

 * keywords:  033-must, hang =>
 033-must, hang, 032-backport, 031-backport-maybe, 029-backport-maybe,
 025-backport-maybe
 * version:  Tor: 0.3.3.2-alpha => Tor: 0.3.2.9


Comment:

 This also affects multiple versions, perhaps all Tor versions.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25401 [Core Tor/Tor]: Transparent proxy stopped working after Linux kernel update to version 4.4.118 that fixes Spectre variant 1

2018-03-02 Thread Tor Bug Tracker & Wiki
#25401: Transparent proxy stopped working after Linux kernel update to version
4.4.118 that fixes Spectre variant 1
--+
 Reporter:  FlinchX   |  Owner:  (none)
 Type:  defect| Status:  closed
 Priority:  High  |  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |Version:  Tor: 0.3.2.9
 Severity:  Major | Resolution:  duplicate
 Keywords:|  Actual Points:
Parent ID:  #25380| Points:
 Reviewer:|Sponsor:
--+
Changes (by teor):

 * status:  new => closed
 * severity:  Blocker => Major
 * parent:   => #25380
 * priority:  Immediate => High
 * milestone:   => Tor: 0.3.3.x-final
 * keywords:  transparent proxy TransPort =>
 * resolution:   => duplicate


Comment:

 Looks like this is a duplicate of #25380

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #25380 [Core Tor/Tor]: Transparent proxy not working with linux kernel 4.15.6

2018-03-02 Thread Tor Bug Tracker & Wiki
#25380: Transparent proxy not working with linux kernel 4.15.6
+
 Reporter:  vafan   |  Owner:  (none)
 Type:  defect  | Status:  new
 Priority:  High|  Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor|Version:  Tor: 0.3.3.2-alpha
 Severity:  Major   | Resolution:
 Keywords:  033-must, hang  |  Actual Points:
Parent ID:  | Points:  0.5
 Reviewer:  |Sponsor:
+
Changes (by teor):

 * priority:  Medium => High
 * severity:  Normal => Major


Comment:

 A few users are experiencing this issue, see #25401

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22584 [Applications/Tor Browser]: More RWX memory pages for TBB on some Windows versions

2018-03-02 Thread Tor Bug Tracker & Wiki
#22584: More RWX memory pages for TBB on some Windows versions
--+---
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cypherpunks):

 Replying to [comment:17 gk]:
 > Replying to [comment:16 cypherpunks]:
 > > Please add #22917 as `--enable-auto-import` is still making holes.
 >
 > Which holes are due to `--enable-auto-import`? I.e. they go away if
 compiled with `--disable-auto-import`?
 Unfortunately, Arthur's patch of `--enable-auto-import` isn't sufficient.
 Disabling this bug-or-feature is the right way to go.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+

Comment (by karsten):

 Thanks for making those changes! Some more feedback:

  - I see where the "portal" comes from. I'd say let's wait for those other
 portals to exist before deciding about re-introducing that term for Tor
 Metrics.
  - Building the ecosystem diagram should indeed be an Ant task. But we
 should also check in the PNG file, so that one doesn't have to use
 graphviz in order to build the website. In any case, we can still add that
 Ant task after merging.
  - The new "Open Data, Visualizations, and Tools for Tor!" is really huge.
 And at a resolution of ~768..991 it overlaps with the text on the right.
 How about we just write "Welcome to Tor Metrics" there? (Untested how that
 would look like.)
  - The "Learn more >>" button looks a little bit lost there. It's also not
 as important for most visitors, in particular returning visitors. Maybe we
 can tone it down by turning it into a common link in the second paragraph?
 Like, a link from "great care", or so.
  - I like how the six boxes to Users, Servers, etc. are summarized under
 "Analysis", which was something that we discussed on #23973 for the
 navigation in general. Wouldn't it also make sense to pick "Services" as
 title for the three new boxes? They are direct links to Services subpages,
 just as Users, Servers, etc. will be direct links to Analysis subpages.
 And if we say "Services" there, we can use the cogs symbol, which looks a
 bit nicer than the circled question mark.
  - Somewhat unrelated to this change, we should consider changing the
 navigation group in the secondary navbar (on extra small devices) from
 "Metrics" to "Analysis". Just reduce your browser size to a minimum and
 click on the donut to see what I mean. This could be part of #23973, too,
 though.
  - Entirely unrelated, I found that the copyright in the footer still says
 2017. If you like, feel free to update that, too. If not, we'll do it
 afterwards.
  - If you rebase, be sure to rebase to current master. I made some more
 changes yesterday.

 Thanks!

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22584 [Applications/Tor Browser]: More RWX memory pages for TBB on some Windows versions

2018-03-02 Thread Tor Bug Tracker & Wiki
#22584: More RWX memory pages for TBB on some Windows versions
--+---
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by gk):

 Replying to [comment:16 cypherpunks]:
 > Please add #22917 as `--enable-auto-import` is still making holes.

 Which holes are due to `--enable-auto-import`? I.e. they go away if
 compiled with `--disable-auto-import`?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #22584 [Applications/Tor Browser]: More RWX memory pages for TBB on some Windows versions

2018-03-02 Thread Tor Bug Tracker & Wiki
#22584: More RWX memory pages for TBB on some Windows versions
--+---
 Reporter:  arthuredelstein   |  Owner:  tbb-team
 Type:  defect| Status:  needs_information
 Priority:  Medium|  Milestone:
Component:  Applications/Tor Browser  |Version:
 Severity:  Normal| Resolution:
 Keywords:  tbb-security  |  Actual Points:
Parent ID:| Points:
 Reviewer:|Sponsor:
--+---

Comment (by cypherpunks):

 Please add #22917 as `--enable-auto-import` is still making holes.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #23169 [Metrics/Website]: Explain why metrics are important and what we do to make sure they're safe

2018-03-02 Thread Tor Bug Tracker & Wiki
#23169: Explain why metrics are important and what we do to make sure they're 
safe
-+
 Reporter:  arma |  Owner:  irl
 Type:  defect   | Status:  needs_revision
 Priority:  Medium   |  Milestone:
Component:  Metrics/Website  |Version:
 Severity:  Normal   | Resolution:
 Keywords:  metrics-2018 |  Actual Points:
Parent ID:   | Points:  2
 Reviewer:  iwakeh, karsten  |Sponsor:
-+

Comment (by irl):

 Replying to [comment:14 karsten]:
 >  - The text really reads well! In the first pass I didn't spot anything
 incorrect or misleading. Great stuff!

 Yay (:

 >  - When looking at the locally built website, I noticed that the home
 page now starts with a lot of text. This might be a bit intimidating for
 new users and slightly annoying for returning users. Don't get me wrong,
 the text is useful, it's the presentation that we might still be able to
 improve. Maybe split up paragraphs and use paragraph titles?
 >  - Related to the point above, the two columns on the start page should
 have the same length.

 I've made some changes that hopefully make the home page more friendly.

 >  - You're saying "Tor Metrics Portal" in at least one place, but I think
 we stopped calling it a portal a while ago. We're referring to the website
 as "Tor Metrics" or "Tor Metrics website".

 Oops. I've removed references to the "Metrics Portal". I think I've used
 this because there is also the Community, Support and Research portals
 that the UX team have been working on.

 >  - The descriptions under Philosophy look a bit like they could benefit
 from some more whitespace. I guess we did not style them when we redid the
 website last year, because we didn't use description lists before. Maybe
 we should just add a little bit of space before the `` part? We could
 ask antonela.

 I have formatted them as "horizontal definition lists" as opposed to their
 default formatting, which does look to have improved things.

 >  - The dependencies diagram on the About page is really neat! Are there
 instructions anywhere how I would build that?

 {{{
 apt install graphviz
 dot -Tpng src/main/resources/web/images/ecosystem.dot >
 src/main/resources/web/images/ecosystem.png
 }}}

 Maybe the source should be in `src/main/resources/dot/ecosystem.dot` and
 that building the png for inclusion in the war could be an Ant task.

 >  - That diagram should also include Consensus Health, which fetches data
 from the directory authorities without help of metrics-lib, and which we
 could say is made for users, not primarily researchers or developers.

 This is now added.

 > All in all, I really like what you wrote there! Let's see if we can
 tweak it some more, and let's also hear what iwakeh has to add. Maybe we
 can even deploy this in the next days.

 Awesome! The changes I've made are in seperate commits for now so it's
 clear what has changed, but I'd like to rebase before merging.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs