Change in vdsm[master]: Ship the version file with the tarballs

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Ship the version file with the tarballs
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#833425 Change cpu topology source to /sys.
..


Patch Set 12: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Check if libvirtd.upstart is present before copying
..


Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: remove validation to reload config

[dougsland]

Douglas Schilling Landgraf has abandoned this change.

Change subject: vdsmd.init: remove validation to reload config
..


Patch Set 1: Abandoned

http://gerrit.ovirt.org/#/c/7375/ replaces this patch.

--
To view, visit http://gerrit.ovirt.org/4479
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7ea03070bf2849e10c74d7921eac9401e2768502
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#849542 bootstrap: set system time as soon as possible

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#849542 bootstrap: set system time as soon as possible
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7380
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15f2ae43dfacf3bd38c860985d572c7513a1ee6d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec: Adding hostname as Require

[dougsland]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec: Adding hostname as Require
..

vdsm.spec: Adding hostname as Require

vdsm-gencerts.sh requires hostname

Change-Id: Ibd6f45c2c9bb87a16170d20914e7a73eaef84903
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/7385/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 892eee3..fd5873b 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -91,6 +91,7 @@
 Requires: selinux-policy-targeted = 3.7.19-80.el6
 Requires: pyparted
 Requires(post): /usr/sbin/saslpasswd2
+Requires(post): /bin/hostname
 
 %description
 The VDSM service is required by a Virtualization Manager to manage the


--
To view, visit http://gerrit.ovirt.org/7385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd6f45c2c9bb87a16170d20914e7a73eaef84903
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec: Adding hostname as Require

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec: Adding hostname as Require
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/7385
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd6f45c2c9bb87a16170d20914e7a73eaef84903
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Ship the version file with the tarballs

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Ship the version file with the tarballs
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b72a1740803a9401e4b5a4504a4faa07c29f2b9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: infra: adding debug log to vdsm daemon init script
..


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/vdsmd.init.in
Line 161: for srv in $NEEDED_SERVICES
Line 162: do
Line 163: if ! /sbin/service $srv status  /dev/null 21; # Verify 
that status is inactive
Line 164: then
Line 165:   echo Starting $srv...
Looks like a lost tab here.
Line 166: /sbin/service $srv start
Line 167: ret_val=$?
Line 168: if [ $ret_val -ne 0 ]
Line 169: then


--
To view, visit http://gerrit.ovirt.org/7340
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eli Mesika emes...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: use python scripts from ovirtnode
..


Patch Set 3: (2 inline comments)

I need to execute new tests, ASAP I will update here.


File vdsm_reg/vdsm-upgrade
Line 15: import logging.config
Line 16: from time import strftime
Line 17: from config import config
Line 18: import deployUtil
Line 19: from ovirtnode.install import *
Sure, new patch will fix that.
Line 20: 
Line 21: VDSM_REG_CONF_FILE = '/etc/vdsm-reg/vdsm-reg.conf'
Line 22: VDSM_CONF_FILE = '/etc/vdsm/vdsm.conf'
Line 23: log_filename = 
'/var/log/vdsm-reg/vds_bootstrap_upgrade.'+strftime(%Y%m%d_%H%M%S)+'.log'


Line 88: def doUpgrade(config):
Line 89: fReturn = True
Line 90: 
Line 91: install = Install()
Line 92: if install.ovirt_boot_setup():
looking the code, I see it's inside a try.
Line 93: msg = BSTRAP component='doUpgrade' status='OK' 
message='Upgrade Succeeded. Rebooting'/
Line 94: print (msg)
Line 95: logging.debug(msg)
Line 96: else:


--
To view, visit http://gerrit.ovirt.org/7074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#848843 Check if libvirtd.upstart is present before copyin...

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#848843 Check if libvirtd.upstart is present before copying
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: infra: adding debug log to vdsm daemon init script

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: infra: adding debug log to vdsm daemon init script
..


Patch Set 5: I would prefer that you didn't submit this

(2 inline comments)


File vdsm/vdsmd.init.in
Line 160: 
Line 161: for srv in $NEEDED_SERVICES
Line 162: do
Line 163: if ! /sbin/service $srv status  /dev/null 21; # Verify 
that status is inactive
Line 164: then
looks like an additional space
Line 165:   echo Starting $srv...
Line 166: /sbin/service $srv start
Line 167: ret_val=$?
Line 168: if [ $ret_val -ne 0 ]


Line 179: test_lo() {
Line 180: if ! LC_ALL=C /sbin/ifconfig lo | /bin/grep -q UP;
Line 181: then
Line 182: log_failure_msg VDSMD: lo interface is down, can't run !
Line 183: echo VDSMD: lo interface is down, can't run !  /dev/kmsg   
 
looks like an additional space
Line 184: return 1
Line 185: fi
Line 186: return 0
Line 187: }


--
To view, visit http://gerrit.ovirt.org/7340
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39ef7e19ede6eaed5c3f27b8c46f6f2b14dd08bd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eli Mesika emes...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: use python scripts from ovirtnode

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: use python scripts from ovirtnode
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/7074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8b5770bdd4f09c3374176dbf2bb2b9afebd65e3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..


Patch Set 9: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/vdsmd.init.in
Line 402: # run service for restart instead of using initctl, both works
Line 403: # the same and works on fedora and rhel
Line 404: # /sbin/initctl restart libvirtd 2/dev/null || :
Line 405: debug_log running restart for libvirt
Line 406: /sbin/service libvirtd restart
Hi Yaniv,

 Why don't we us if ! upstart_libvirt; then service libvirt... else 
initctl ?
I think most of vdsmd.init script already uses like that.
Line 407: }
Line 408: 
Line 409: 
Line 410: RETVAL=0


--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#734847- vdsmd always restarts libvirtd upon start-up

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#734847- vdsmd always restarts libvirtd upon start-up
..


Patch Set 9: (1 inline comment)


File vdsm/vdsmd.init.in
Line 425: }
Line 426: 
Line 427: stop_libvirtd_sysv() {
Line 428: # stop libvirt SysV service if we intend to configure upstart
Line 429: if ! upstart_libvirt; then
humm, reading the comment looks like ! is not required. Better check with Dan.
Line 430: debug_log stopping libvirt service..
Line 431: /sbin/chkconfig libvirtd off
Line 432: /sbin/service libvirtd stop
Line 433: fi


--
To view, visit http://gerrit.ovirt.org/7331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f5207ac6ed7a9b01907b31d9ac7992aafb118ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tc: add to PEP8_WHITELIST

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: tc: add to PEP8_WHITELIST
..


Patch Set 1: I would prefer that you didn't submit this

Dan, not sure if this happened with you as well (with a clean repo):

git fetch git://gerrit.ovirt.org/vdsm refs/changes/26/7426/1  git cherry-pick 
FETCH_HEAD

error: could not apply 9c2ac6d... tc: add to PEP8_WHITELIST
hint: after resolving the conflicts, mark the corrected paths

-1 = since I have a question and maybe rebase is needed.

--
To view, visit http://gerrit.ovirt.org/7426
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b3b1d8de08ea8fac5cd3debb53f22d7a7a8ad87
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: make vdsm/libvirtvm.py PEP 8 clean

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: make vdsm/libvirtvm.py PEP 8 clean
..


Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/6561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12735cc8fdaeb91c77f63e16a262b0cd8acfbba4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Check if libvirtd.upstart is present before copying
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configNet: grant proper selinux context to ifcfg-*

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: configNet: grant proper selinux context to ifcfg-*
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7478
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3cb63872794367a7c6fa76cc753698c9402b449
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: survive missing ntpq

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: survive missing ntpq
..


Patch Set 1: I would prefer that you didn't submit this

The vdsm.spec requires ntp, which provides ntpq. Any failure during vdsm 
installation?

-1 = since I have a question

--
To view, visit http://gerrit.ovirt.org/7597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: survive missing ntpq

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: survive missing ntpq
..


Patch Set 1: Looks good to me, but someone else must approve

Hi, 

I see the point and agree with your comments. Indeed, you moved the 
oDeploy.setSystemTime() in one of your previous patches so will be very early 
in the deploy.. +1 now

About your -1 comment, agreed, 0 is ok for me.

Thanks
Douglas

--
To view, visit http://gerrit.ovirt.org/7597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: survive missing ntpq

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: survive missing ntpq
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7597
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87505b0d008bd7914fb673d6a38eccca1bbf83e2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: node id: consider bonding MAC addresses as well

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: node id: consider bonding MAC addresses as well
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7596
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0713f95c25e3e05b24bf8254499e4cd8e64d10
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Check if libvirtd.upstart is present before copying

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Check if libvirtd.upstart is present before copying
..


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/7375
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba7d52d21e2a072b99ffc9055327d217c78e8fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#833425 Change cpu topology source to /sys.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#833425 Change cpu topology source to /sys.
..


Patch Set 13:

I still prefer the libvirt approach. We already depend of libvirt, why not use 
functions that libvirt already contain? Anyway, the code looks good to me.

--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove superfluous macros in the specfile

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Remove superfluous macros in the specfile
..


Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6af1c10fc35d2e30c2ef9ba319d035631cf7108
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Remove superfluous macros in the specfile

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Remove superfluous macros in the specfile
..


Patch Set 1:

I meant, 1) I have tested installed vdsm by rpm. 2) I have executed make 
install inside vdsm-hooks. Sorry, I didn't specified the tests before.

--
To view, visit http://gerrit.ovirt.org/7651
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6af1c10fc35d2e30c2ef9ba319d035631cf7108
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: sync utils.getHostUUID() with deployUtil.getHostI...

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: sync utils.getHostUUID() with deployUtil.getHostID()
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7659
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c99fb4e99ca951e1daf4e856fc473ba82088d1c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: add is_libvirtd_run method and improve comments.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: add is_libvirtd_run method and improve comments.
..


Patch Set 2: (1 inline comment)


File vdsm/vdsmd.init.in
Line 441: return 1
Line 442: }
Line 443: 
Line 444: is_libvirtd_run(){
Line 445: pgrep libvirtd  /dev/null 21
Just a suggestion, after the command add the below return to collect the last 
command status 
return $?
Line 446: }
Line 447: 
Line 448: start_libvirtd() {
Line 449: local packaged target


--
To view, visit http://gerrit.ovirt.org/7673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e900186ee2ebf89838dcab77cbe64d9abc6be9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
..


Patch Set 7: (1 inline comment)


File vdsm-tool/load_needed_modules.py.in
Line 42: def _enable_bond_dev():
Line 43: REQUIRED = set(['bond0', 'bond1', 'bond2', 'bond3', 'bond4'])
Line 44: MASTER_FILE = '/sys/class/net/bonding_masters'
Line 45: 
Line 46: # RHEV-M currently assumes that all bonding devices pre-exist
I would suggest @ENGINENAME@
Line 47: existing = set(file(MASTER_FILE).read().split())
Line 48: with open(MASTER_FILE) as f:
Line 49: for bond in REQUIRED - existing:
Line 50: f.write('+%s\n' % bond)


--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: add is_libvirtd_run method and improve comments.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: add is_libvirtd_run method and improve comments.
..


Patch Set 2: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e900186ee2ebf89838dcab77cbe64d9abc6be9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: changed upstart_libvirt function name

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: changed upstart_libvirt function name
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b773b04766346ab9b00fba6a1f083cffd89
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
..


Patch Set 7: I would prefer that you didn't submit this

--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: nfs-check: check if temp dir exists

[dougsland]

Douglas Schilling Landgraf has abandoned this change.

Change subject: nfs-check: check if temp dir exists
..


Patch Set 4: Abandoned

--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If364f703b1ab2223d194c4e300da824e0696d50b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
..


Patch Set 7: (1 inline comment)


File vdsm-tool/load_needed_modules.py.in
Line 42: def _enable_bond_dev():
Line 43: REQUIRED = set(['bond0', 'bond1', 'bond2', 'bond3', 'bond4'])
Line 44: MASTER_FILE = '/sys/class/net/bonding_masters'
Line 45: 
Line 46: # RHEV-M currently assumes that all bonding devices pre-exist
Hi Wenyi, Yaniv is correct. I am suggesting you to replace RHEV-M string to 
@ENGINENAME@. For tests, you can change the .in file and then executeo 
./autogen --system you will notice that the .py will have Engine instead of 
RHEV-M. This kind of trick helps maintainers for backport work too.

Thanks!
Line 47: existing = set(file(MASTER_FILE).read().split())
Line 48: with open(MASTER_FILE) as f:
Line 49: for bond in REQUIRED - existing:
Line 50: f.write('+%s\n' % bond)


--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Move load_needed_modules to vdsm-tool

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Move load_needed_modules to vdsm-tool
..


Patch Set 8: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Wenyi Gao we...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Trigger reboot automatically after upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Trigger reboot automatically after upgrade
..


Patch Set 2:

I have just changed the call to use the full argument.

--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fccf8c7c60f51b32a17cedeb6f365ac45d14a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd: set nwfilter on ovirt-node

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd: set nwfilter on ovirt-node
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e9a3526f6ec70ef40f586319259903e9e1f5fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd: set nwfilter on ovirt-node

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd: set nwfilter on ovirt-node
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/7821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35e9a3526f6ec70ef40f586319259903e9e1f5fe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
..


Patch Set 4: (1 inline comment)


File vdsm_reg/deployUtil.py.in
Line 1420: RHEVM_CERT_FILE = /ca.crt
Line 1421: rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422: if rhevmCert:
Line 1423: nodeCleanup()
Line 1424: dirName = os.path.dirname(CACERT)
Dan, can you please clarify to me: Do you prefer download the cert with a 
different name and after that remove/unpersist the current cert and rename the 
downloaded cert to cacert?
Line 1425: if not os.path.exists(dirName):
Line 1426: os.makedirs(dirName)
Line 1427: crt = file(CACERT, w+)
Line 1428: try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Trigger reboot automatically after upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Trigger reboot automatically after upgrade
..


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/7778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fccf8c7c60f51b32a17cedeb6f365ac45d14a0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add the autotools support in the spec file

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add the autotools support in the spec file
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7925
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23703d299b639d55714b71567bc04c154fc21fc0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fail if Password doesn't match

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fail if Password doesn't match
..


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fail if Password doesn't match

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fail if Password doesn't match
..


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fail if Password doesn't match

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fail if Password doesn't match
..


Patch Set 3: (1 inline comment)

About:

 One more thought; do we have to worry about how
 password_check() behaves on older ovirt-nodes?

I have checked some previous code and I cannot see any problem.

Thanks 
Douglas


File vdsm_reg/engine.py.in
Line 230: compatPort, sslPort = compatiblePort(enginePort)
Line 231: 
Line 232: # Show error if the password informed by user doesn't match
Line 233: if self.pw_resp == PASSWORD_DOESNT_MATCH and 
len(self.root_password_1.value())  0 or \
Line 234: self.pw_resp == PASSWORD_DOESNT_MATCH and 
len(self.root_password_2.value())  0:
We cannot skip. The ovirt node API returns 1 in case users don't want to set  
the password:

def password_check(password_1, password_2, min_length=1):
  if len(password_1) is 0 and min_length is not 0:
return (1, \n\n\n\n\n)
Line 235: 
Line 236: # Required since we now are verifying if the Confirm 
Password were filled
Line 237: # and Password field not
Line 238: if self.pw_pcheck_msg.strip(\n) == :


--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-reg-setup: get hostname with gethostname()

[dougsland]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm-reg-setup: get hostname with gethostname()
..

vdsm-reg-setup: get hostname with gethostname()

Currently, if Node users use TUI to replace the hostname, it trigger the
inclusion of the new hostname in /etc/hosts for 127.0.0.1 entry.
Adding the new hostname as alias for 127.0.0.1 will make socket.getfqdn()
locate the first alias available in /etc/hosts, in that case 
localhost.localdomain.

This patch will fix the report replacing the socket.getfqdn() to 
socket.gethostname().

Test
=
* Install oVirt Node 2.5.1-1.0
* Set Network (default it will be localhost.localdomain)
* Select Network again, and change Hostname (supernode.linux.com)
* Register the Node into Engine
- At this moment, Engine will show localhost.localdomain instead of 
supernode.linux.com

The manual workaround is remove the new hostname from /etc/hosts in 127.0.0.1 
entry.

Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm_reg/vdsm-reg-setup.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/7939/1

diff --git a/vdsm_reg/vdsm-reg-setup.in b/vdsm_reg/vdsm-reg-setup.in
index 0f3e896..492e38d 100644
--- a/vdsm_reg/vdsm-reg-setup.in
+++ b/vdsm_reg/vdsm-reg-setup.in
@@ -48,7 +48,7 @@
 self.vdsmDir = config.get('vars', 'vdsm_dir')
 if self.vdcURL != None:
 self.ovirtURL = deployUtil.getMGTIP(self.vdsmDir, self.vdcName)
-self.ovirtName = socket.getfqdn()
+self.ovirtName = socket.gethostname()
 self.ovirtUID = deployUtil.getHostID()
 else:
 self.ovirtURL = None


--
To view, visit http://gerrit.ovirt.org/7939
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-reg-setup: get hostname with gethostname()

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-reg-setup: get hostname with gethostname()
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/7939
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38ec4c570d7f250d64e62e01b91cd2828780c45b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Replace 'ovirt Engine' string with @ENGINENAME@

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Replace 'ovirt Engine' string with @ENGINENAME@
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7941
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23f0b6346a14f94268180db46855920e8e355f17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fail if Password doesn't match

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fail if Password doesn't match
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/7917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I143906eb6ce61037418eac25567496c6628aede9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Joey Boggs jbo...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setNetworking(): return bridge status

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: setNetworking(): return bridge status
..


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfea98ed31b536699e9d3d6485f5cb62791adcd5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setNetworking(): return bridge status

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: setNetworking(): return bridge status
..


Patch Set 2: I would prefer that you didn't submit this

new patch will come with WARN not FAIL

--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfea98ed31b536699e9d3d6485f5cb62791adcd5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setNetworking(): return bridge status

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: setNetworking(): return bridge status
..


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/6875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfea98ed31b536699e9d3d6485f5cb62791adcd5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: add is_libvirtd_run method and improve comments.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: add is_libvirtd_run method and improve comments.
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/7673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9e900186ee2ebf89838dcab77cbe64d9abc6be9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec.in: Requires: python-libguestfs

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec.in: Requires: python-libguestfs
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8004
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0a98614b4220747e4dfbaf3c58e756b44e7e280
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Amador Pahim apa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Verify downloaded CA certificate
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Parse correctly the management_server parameter
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74d658902d3421c0ac554c5c2634ddc8c6a28b21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Verify downloaded CA certificate

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Verify downloaded CA certificate
..


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 1: (1 inline comment)


File vdsm_reg/vdsm-upgrade
Line 153: logging.error(BSTRAP component='RHEV_INSTALL' 
status='FAIL'/)
Line 154: else:
Line 155: msg = BSTRAP component='RHEV_INSTALL' status='OK'/
Line 156: logging.debug(BSTRAP component='RHEV_INSTALL' 
status='OK'/)
Line 157: # Stop vdsm to avoid communication with @ENGINENAME@ before 
the reboot happens
new version won't use @ENGINENAME@, it's not an .in file :-P
Line 158: deployUtil._logExec([constants.EXT_SERVICE, 'vdsmd', 'stop'])
Line 159: 
Line 160: print (msg)
Line 161: 


--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Parse correctly the management_server parameter

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Parse correctly the management_server parameter
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8022
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74d658902d3421c0ac554c5c2634ddc8c6a28b21
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Validate downloaded SSH public key

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Validate downloaded SSH public key
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Validate downloaded CA certificate

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Validate downloaded CA certificate
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Logging shouldn't reach the terminal console

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Logging shouldn't reach the terminal console
..


Patch Set 1: I would prefer that you didn't submit this

Following federico -1... to avoid showing this patch for review in my queue at 
this moment.

--
To view, visit http://gerrit.ovirt.org/7980
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I749a58362db5daec44ed5b0f7f116e14eadd6043
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: BZ#856167 - Store engine CA cert in enginecacert.pem

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem
..


Patch Set 2: Looks good to me, but someone else must approve

(1 inline comment)


File vdsm_reg/deployUtil.py.in
Line 1447: dt = datetime.datetime.now()
Line 1448: backupTime = dt.strftime(%Y-%m-%d_%H%M%S)
Line 1449: 
Line 1450: for pemFile in certs:
Line 1451: if os.path.exists(pemFile):
hopefully the certs will exists from the before certPaths(''), line 1464 but 
good call.
Line 1452: certName = os.path.basename(pemFile)
Line 1453: dirName  = os.path.dirname(pemFile)
Line 1454: 
Line 1455: bkpCertName = dirName + /bkp- + backupTime + '_' + 
certName


--
To view, visit http://gerrit.ovirt.org/8038
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I127bf44cbcde90f7dae26a3bd3127f3eac2ca53c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 3: (2 inline comments)


File vdsm_reg/vdsm-upgrade
Line 133: # Checking the current status of vdsm
Line 134: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 
'vdsmd', 'status'])
Line 135: if ret == 0:
Line 136:# Stop vdsm to avoid any communication with Engine before the 
reboot happens
Line 137: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 
'vdsmd', 'stop'])
agreed. /me forgot the additional one.. argh :-/
Line 138: else:
Line 139: msg = BSTRAP component='RHEL_INSTALL' status='FAIL' 
message='vdsm daemon \
Line 140:is down before we stop it for upgrade, please 
verify!'/
Line 141: logging.debug(msg)


Line 138: else:
Line 139: msg = BSTRAP component='RHEL_INSTALL' status='FAIL' 
message='vdsm daemon \
Line 140:is down before we stop it for upgrade, please 
verify!'/
Line 141: logging.debug(msg)
Line 142: print(msg)
It's not a problem, it's a note.
Line 143: 
Line 144: try:
Line 145: config.read(VDSM_REG_CONF_FILE)
Line 146: 


--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 3: (1 inline comment)


File vdsm_reg/vdsm-upgrade
Line 135: if ret == 0:
Line 136:# Stop vdsm to avoid any communication with Engine before the 
reboot happens
Line 137: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 
'vdsmd', 'stop'])
Line 138: else:
Line 139: msg = BSTRAP component='RHEL_INSTALL' status='FAIL' 
message='vdsm daemon \
in that case I will move to status=WARN and remove from the msg please 
verify
Line 140:is down before we stop it for upgrade, please 
verify!'/
Line 141: logging.debug(msg)
Line 142: print(msg)
Line 143: 


--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: stressCheckTest fails because it passes the rlimit

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: stressCheckTest fails because it passes the rlimit
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3236f0b160406e3d9d5ecb782f7493f4ea0461
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec.in: use locale LC_ALL

[dougsland]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsm.spec.in: use locale LC_ALL
..

vdsm.spec.in: use locale LC_ALL

During VDSM instalation, we verify if SELinux booleans are
enabled with return of semanage command, output like: on or off.
These are English words and if the system contains a different
locale, example pt_BR the validation will fail.

Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=857556

This patch will change the locale for English (C) while
installation VDSM.

Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm.spec.in
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/8068/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index ca678da..41885c2 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -408,6 +408,9 @@
 rm -rf %{buildroot}
 
 %pre
+# Force standard locale behavior (English)
+export LC_ALL=C
+
 /usr/bin/getent passwd %{vdsm_user} /dev/null || \
 /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
 -s /sbin/nologin -c Node Virtualization Manager %{vdsm_user}
@@ -419,6 +422,7 @@
 virtNFS=$(/usr/sbin/semanage boolean -l | /bin/grep virt_use_nfs | cut -d ',' 
-f 2)
 virtSANLOCK=$(/usr/sbin/semanage boolean -l | /bin/grep virt_use_sanlock | cut 
-d ',' -f 2)
 
+# Set the booleans and persist it across reboots
 if [[ ${virtNFS} == *off* || ${virtSANLOCK} == *off* ]]; then
 /usr/sbin/semanage boolean -m -S targeted -F /dev/stdin   _EOF
 virt_use_nfs=1
@@ -426,6 +430,7 @@
 _EOF
 fi
 
+# Change the current state of SELinux
 if /usr/sbin/selinuxenabled; then
 /usr/sbin/setsebool virt_use_nfs on
 /usr/sbin/setsebool virt_use_sanlock on


--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec.in: use locale LC_ALL

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec.in: use locale LC_ALL
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 5: Verified

--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm-upgrade: stop vdsm when complete upgrade

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-upgrade: stop vdsm when complete upgrade
..


Patch Set 4: (1 inline comment)


File vdsm_reg/vdsm-upgrade
Line 130: fOK = True
Line 131: fMounted = False
Line 132: 
Line 133: # Checking the current status of vdsm
Line 134: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 
'vdsmd', 'status'])
Done
Line 135: if ret == 0:
Line 136:# Stop vdsm to avoid any communication with Engine before the 
reboot happens
Line 137: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 
'vdsmd', 'stop'])
Line 138: if ret != 0:


--
To view, visit http://gerrit.ovirt.org/8029
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Validate downloaded CA certificate

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Validate downloaded CA certificate
..


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: add and use hypervisor autodetection in bootstrap.
..


Patch Set 4: I would prefer that you didn't submit this

Looking the current comments, new version will be available.

--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@gmail.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@gmail.com
Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm.spec.in: use locale LC_ALL=C

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec.in: use locale LC_ALL=C
..


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/8068
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22b5706e02c71f463200ce20eb0e426e1bfee6e6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add input parameter to _logExec

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add input parameter to _logExec
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8095
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7538464da071fec7a93934f7734abc4b15d707cf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix vdsm-reg service name

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fix vdsm-reg service name
..


Patch Set 3: (2 inline comments)

Hi Fernando, IMO, you could split your patch. Also, fell free to add your name 
into AUTHORS.

Thanks
Douglas


File vdsm_reg/vdsm-config
Line 22:/bin/systemctl stop vdsm-reg.service  /dev/null 21
Line 23:elif [ -x /sbin/service ] ; then
Line 24:/sbin/service vdsm-reg stop  /dev/null 21
Line 25:fi
Line 26: 
I understood the point but I do believe that if we stop a service which is 
running, after the changes, we need to start it again (/me point of view).
Line 27: set_vars() {
Line 28:echo [vars]  $VDSM_CONFIG #Adding ts for the coming scripts.
Line 29:echo trust_store_path =  `$GETCONFITEM $VDSM_CONFIG vars 
trust_store_path /etc/pki/vdsm`  $VDSM_CONFIG
Line 30:echo ssl =  `$GETCONFITEM $VDSM_CONFIG vars ssl true`  
$VDSM_CONFIG



File vdsm.spec.in
Line 535: /sbin/chkconfig --add vdsm-reg
Line 536: fi
Line 537: %else
Line 538: if [ $1 -eq 1 ] ; then
Line 539: /bin/systemctl enable vdsm-reg.service /dev/null 21 || :
ouch, nice catch!
Line 540: /bin/systemctl daemon-reload /dev/null 21 || :
Line 541: fi
Line 542: exit 0
Line 543: %endif


--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f6c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Validate downloaded CA certificate

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Validate downloaded CA certificate
..


Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5d3b3aeca42e4bc4b621b1acb861bfb1ac383e6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Validate downloaded SSH public key

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Validate downloaded SSH public key
..


Patch Set 5: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: Unifying engine and vdsm commit templates

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Unifying engine and vdsm commit templates
..


Patch Set 4: Looks good to me, but someone else must approve

+1 Based on mailing list discussion.

--
To view, visit http://gerrit.ovirt.org/7699
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8769fbf65ceab391443a4fbe2eb0fcdec5d6f4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Livnat Peer lp...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd: await for libvirt with systemd, too.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd: await for libvirt with systemd, too.
..


Patch Set 1:

Hi Dan, looks correct your change but it doesn't resolve the 
https://bugzilla.redhat.com/859483. At least, in my tests. I am going to dig 
here to see what's missing...

--
To view, visit http://gerrit.ovirt.org/8162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78c29ebf8e6a97e44c272f2101f54283c934d4a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: vdsmd.init: verify if libvirt socket file exists
..

vdsmd.init: verify if libvirt socket file exists

Currently, VDSM init script checks if libvirt daemon is up with pgrep command.
However, libvirt daemon shows up before the socket file be ready.

This patch will replace the validation from pgrep to a validation which checks 
if
the socket file is really exists.

Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Bug-Url: https://bugzilla.redhat.com/859483
Signed-off-by: Douglas Schilling Landgraf dougsl...@redhat.com
---
M vdsm/vdsmd.init.in
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/8175/1

diff --git a/vdsm/vdsmd.init.in b/vdsm/vdsmd.init.in
index e32c3e5..23ee7d3 100755
--- a/vdsm/vdsmd.init.in
+++ b/vdsm/vdsmd.init.in
@@ -402,8 +402,7 @@
 
 for i in {1..50}
 do
-if pgrep libvirtd  /dev/null 21;
-then
+if [ -S /var/run/libvirt/libvirt-sock ]; then
 return 0
 fi
 sleep 0.2


--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 1: Verified

--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd: await for libvirt with systemd, too.

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd: await for libvirt with systemd, too.
..


Patch Set 2: Verified

Dan, your patch + http://gerrit.ovirt.org/#/c/8175/  make vdsm work again after 
the reboot.

--
To view, visit http://gerrit.ovirt.org/8162
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78c29ebf8e6a97e44c272f2101f54283c934d4a4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bootstrap: use yum API

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: bootstrap: use yum API
..


Patch Set 6: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Juan Hernandez juan.hernan...@redhat.com
Gerrit-Reviewer: Pradipta Banerjee bpra...@in.ibm.com
Gerrit-Reviewer: Rodrigo Trujillo trujillo.unic...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 2: Verified

--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 2:

Hi Dan, your comment make sense, thanks for this catch! New patch available for 
review.

--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 2: (1 inline comment)


File vdsm/vdsmd.init.in
Line 401: # this workaround should be removed.
Line 402: 
Line 403: for i in {1..50}
Line 404: do
Line 405: if [[ -S /var/run/libvirt/libvirt-sock ]]  [[ `pgrep 
libvirtd` ]]; then
 was this actually verified?
Yes.

Simple test, from bash (without need to reboot):
# cat test.sh 

if [[ -S /var/run/libvirt/libvirt-sock ]]  [[ `pgrep libvirtd` ]]; then
echo libvirt is running
fi

# bash test.sh 

libvirt is running

# killall -9 libvirtd

# bash test.sh 

#

  [[ -S /var/run/libvirt/libvirt-sock ]]  pgrep libvirtd  /dev/null 21
 would have been syntactically better.

Well, you are the maintainer, you decide which style is better to maintain

 p.s. you know how much I love short lines...

Indeed, what about add a git hook to fail git commit with patches  80 chars?
Line 406: return 0
Line 407: fi
Line 408: sleep 0.2
Line 409: done


--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 3: Verified

--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsmd.init: verify if libvirt socket file exists

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsmd.init: verify if libvirt socket file exists
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix vdsm-reg service name

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fix vdsm-reg service name
..


Patch Set 4: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f6c1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Fix vdsm-reg service name

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Fix vdsm-reg service name
..


Patch Set 4: Verified

--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f6c1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
Gerrit-Reviewer: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Support for the new polkit rules

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Support for the new polkit rules
..


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5de52881c60c54cd4874a8801d2705d0681f0824
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Add load_needed_modules.py to gitignore

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Add load_needed_modules.py to gitignore
..


Patch Set 1: Verified; Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ad667c7243ffd3e6ae48aebcbc249b757f5ffd2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: engine.py: fix nodeCleanup() call

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: engine.py: fix nodeCleanup() call
..


Patch Set 4: (1 inline comment)


File vdsm_reg/deployUtil.py.in
Line 1420: RHEVM_CERT_FILE = /ca.crt
Line 1421: rhevmCert = getRemoteFile(str(IP), str(port), RHEVM_CERT_FILE)
Line 1422: if rhevmCert:
Line 1423: nodeCleanup()
Line 1424: dirName = os.path.dirname(CACERT)
Hi Dan, can we get this patch since Juan's patch has been merged: (Validate 
downloaded CA certificate) ?
http://gerrit.ovirt.org/#/c/8021/

It's important fix for node side. 

Thanks
Douglas
Line 1425: if not os.path.exists(dirName):
Line 1426: os.makedirs(dirName)
Line 1427: crt = file(CACERT, w+)
Line 1428: try:


--
To view, visit http://gerrit.ovirt.org/6859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I62e86e354b3a588ce6113d7b308ece801af22917
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Use 'yum clean expire-cache' instead of 'yum clean all'

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Use 'yum clean expire-cache' instead of 'yum clean all'
..


Patch Set 1: Looks good to me, but someone else must approve

Doron/Dan might have additional comments to share but looks sane for me.

--
To view, visit http://gerrit.ovirt.org/8206
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1019690e4a27caeff923655f9562892ce7f909af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu wu...@linux.vnet.ibm.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Greg Padgett gpadg...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Include vds_name parameter for node registration

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: Include vds_name parameter for node registration
..


Patch Set 3: Looks good to me, but someone else must approve

--
To view, visit http://gerrit.ovirt.org/8036
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1b0bcc473ef1a034736f80e1424e211ddf02946
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Fernando Granha Jeronimo fgra...@linux.vnet.ibm.com
Gerrit-Reviewer: Michael Burns mbu...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: Use virsh to check if libvirt is up

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Use virsh to check if libvirt is up
..


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)


File vdsm/vdsmd.init.in
Line 401: # this workaround should be removed.
Line 402: 
Line 403: for i in {1..50}
Line 404: do
Line 405: if virsh -r version  /dev/null 21 
If we are going to use virsh, we might want to add to spec file libvirt-client 
require. Also, I understood that virsh is a valid/nice tool to check if libvirt 
is running, however I have seen in the past virsh segmentation fault errors.. 
we want to depend of external tool/component to check if libvirt is up instead 
of checking the socket file? (just question)
Line 406: pgrep libvirtd  /dev/null 21; then
Line 407: return 0
Line 408: fi
Line 409: sleep 0.2


--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2844070ca0816525851b3b495b3dfe3096058a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: setup: configure selinux for sanlock on nfs

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: setup: configure selinux for sanlock on nfs
..


Patch Set 1: I would prefer that you didn't submit this

-1 since I have a question: Should'n we add the selinux boolean for preun as 
well? (since we have it for existing booleans)

From %preun
===

/usr/sbin/semanage boolean -m -S targeted -F /dev/stdin   _EOF
virt_use_nfs=0
virt_use_sanlock=0
_EOF

--
To view, visit http://gerrit.ovirt.org/8255
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9005d23d009c65770b7836feb81ab97206e9a8a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vdsm: Use virsh to check if libvirt is up

[dougsland]

Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm: Use virsh to check if libvirt is up
..


Patch Set 2: Verified; Looks good to me, but someone else must approve

Alright guys, that's ok. From my tests it worked nice.

--
To view, visit http://gerrit.ovirt.org/8245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2844070ca0816525851b3b495b3dfe3096058a9
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com
Gerrit-Reviewer: Igor Lvovsky ilvov...@redhat.com
Gerrit-Reviewer: Moti Asayag masa...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches