[webkit-changes] [295261] trunk/Source/WebCore/layout/formattingContexts/flex/ FlexLayout.cpp
Title: [295261] trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
Revision 295261
Author jh718.p...@samsung.com
Date 2022-06-04 03:12:20 -0700 (Sat, 04 Jun 2022)
Log Message
Unreviewed. Fix the build warning below since r295039.
warning: variable ‘accumulatedWidth’ set but not used [-Wunused-but-set-variable]
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::computeLogicalWidthForStretchingFlexItems):
Modified Paths
trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
Diff
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp (295260 => 295261)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-04 08:30:21 UTC (rev 295260)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp 2022-06-04 10:12:20 UTC (rev 295261)
@@ -182,7 +182,6 @@
// This is where we compute how much space the flexing boxes take up if we just
// let them flex by their flex-grow value. Note that we can't size them below their minimum content width.
// Such flex items are removed from the final overflow distribution.
-auto accumulatedWidth = LayoutUnit { };
while (true) {
auto didFreeze = false;
for (auto& stretchingFlex : stretchingItems) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [293772] trunk/Source/WTF
Title: [293772] trunk/Source/WTF Revision 293772 Author jh718.p...@samsung.com Date 2022-05-04 07:23:18 -0700 (Wed, 04 May 2022) Log Message Unreviewed. Remove the build warning below since r293729. warning: redundant move in return statement [-Wredundant-move] * wtf/DateMath.cpp: (WTF::validateTimeZone): Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/DateMath.cpp Diff Modified: trunk/Source/WTF/ChangeLog (293771 => 293772) --- trunk/Source/WTF/ChangeLog 2022-05-04 10:43:28 UTC (rev 293771) +++ trunk/Source/WTF/ChangeLog 2022-05-04 14:23:18 UTC (rev 293772) @@ -1,3 +1,11 @@ +2022-05-04 Joonghun Park + +Unreviewed. Remove the build warning below since r293729. +warning: redundant move in return statement [-Wredundant-move] + +* wtf/DateMath.cpp: +(WTF::validateTimeZone): + 2022-05-03 Yusuke Suzuki [WTF] Initialize emptyString and nullString data at compile time Modified: trunk/Source/WTF/wtf/DateMath.cpp (293771 => 293772) --- trunk/Source/WTF/wtf/DateMath.cpp 2022-05-04 10:43:28 UTC (rev 293771) +++ trunk/Source/WTF/wtf/DateMath.cpp 2022-05-04 14:23:18 UTC (rev 293772) @@ -1038,7 +1038,7 @@ auto status = callBufferProducingFunction(ucal_getCanonicalTimeZoneID, buffer.data(), buffer.size(), canonicalBuffer, nullptr); if (!U_SUCCESS(status)) return std::nullopt; -return WTFMove(canonicalBuffer); +return canonicalBuffer; } bool isTimeZoneValid(StringView timeZone) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289997] trunk
Title: [289997] trunk
Revision 289997
Author jh718.p...@samsung.com
Date 2022-02-16 22:05:05 -0800 (Wed, 16 Feb 2022)
Log Message
Change the canonical unit for time category from ms to s.
https://bugs.webkit.org/show_bug.cgi?id=236631
Reviewed by Darin Adler.
According to the spec, https://drafts.csswg.org/css-values-4/#time,
the canonical unit for is Seconds.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-values/minmax-time-serialize-expected.txt:
Source/WebCore:
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):
* css/CSSUnits.cpp:
(WebCore::canonicalUnitTypeForCategory):
* css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::canonicalUnitTypeForCalculationCategory):
LayoutTests:
* fast/css/calc-with-angle-time-frequency-expected.txt:
* fast/css/calc-with-angle-time-frequency.html:
* fast/css/getFloatValueForUnit-expected.txt:
* fast/css/getFloatValueForUnit.html:
* fast/css/transition-delay-calculated-value-expected.txt:
* fast/css/transition-delay-calculated-value.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/calc-with-angle-time-frequency-expected.txt
trunk/LayoutTests/fast/css/calc-with-angle-time-frequency.html
trunk/LayoutTests/fast/css/getFloatValueForUnit-expected.txt
trunk/LayoutTests/fast/css/getFloatValueForUnit.html
trunk/LayoutTests/fast/css/transition-delay-calculated-value-expected.txt
trunk/LayoutTests/fast/css/transition-delay-calculated-value.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/minmax-time-serialize-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValue.cpp
trunk/Source/WebCore/css/CSSUnits.cpp
trunk/Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (289996 => 289997)
--- trunk/LayoutTests/ChangeLog 2022-02-17 04:25:14 UTC (rev 289996)
+++ trunk/LayoutTests/ChangeLog 2022-02-17 06:05:05 UTC (rev 289997)
@@ -1,3 +1,20 @@
+2022-02-16 Joonghun Park
+
+Change the canonical unit for time category from ms to s.
+https://bugs.webkit.org/show_bug.cgi?id=236631
+
+Reviewed by Darin Adler.
+
+According to the spec, https://drafts.csswg.org/css-values-4/#time,
+the canonical unit for is Seconds.
+
+* fast/css/calc-with-angle-time-frequency-expected.txt:
+* fast/css/calc-with-angle-time-frequency.html:
+* fast/css/getFloatValueForUnit-expected.txt:
+* fast/css/getFloatValueForUnit.html:
+* fast/css/transition-delay-calculated-value-expected.txt:
+* fast/css/transition-delay-calculated-value.html:
+
2022-02-16 Alan Bujtas
REGRESSION(r285885) Unable to exit Trip Details in Amtrak app
Modified: trunk/LayoutTests/fast/css/calc-with-angle-time-frequency-expected.txt (289996 => 289997)
--- trunk/LayoutTests/fast/css/calc-with-angle-time-frequency-expected.txt 2022-02-17 04:25:14 UTC (rev 289996)
+++ trunk/LayoutTests/fast/css/calc-with-angle-time-frequency-expected.txt 2022-02-17 06:05:05 UTC (rev 289997)
@@ -25,22 +25,22 @@
PASS testDiv.style['-webkit-filter'] is "hue-rotate(calc(1080deg))"
PASS window.getComputedStyle(testDiv).getPropertyValue('-webkit-filter') is "hue-rotate(1080deg)"
testDiv.style['transition-delay'] = 'calc(300ms/2)'
-PASS testDiv.style['transition-delay'] is "calc(150ms)"
+PASS testDiv.style['transition-delay'] is "calc(0.15s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "0.15s"
testDiv.style['transition-delay'] = 'calc(300s/2)'
-PASS testDiv.style['transition-delay'] is "calc(15ms)"
+PASS testDiv.style['transition-delay'] is "calc(150s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "150s"
testDiv.style['transition-delay'] = 'calc(10s + 100ms)'
-PASS testDiv.style['transition-delay'] is "calc(10100ms)"
+PASS testDiv.style['transition-delay'] is "calc(10.1s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "10.1s"
testDiv.style['transition-delay'] = 'calc(100ms + 10s)'
-PASS testDiv.style['transition-delay'] is "calc(10100ms)"
+PASS testDiv.style['transition-delay'] is "calc(10.1s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "10.1s"
testDiv.style['transition-delay'] = 'calc(4s + 1s)'
-PASS testDiv.style['transition-delay'] is "calc(5000ms)"
+PASS testDiv.style['transition-delay'] is "calc(5s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "5s"
testDiv.style['transition-delay'] = 'calc(4ms + 1ms)'
-PASS testDiv.style['transition-delay'] is "calc(5ms)"
+PASS testDiv.style['transition-delay'] is "calc(0.005s)"
PASS window.getComputedStyle(testDiv).getPropertyValue('transition-delay') is "0.005s"
testDiv.style['width'] = 'calc(300Hz/2)'
PASS testDiv.style['width'] is ""
Modified: trunk/LayoutTests/fast/css/calc-with-angle-time-frequency.html
[webkit-changes] [289208] trunk/Source/WebCore
Title: [289208] trunk/Source/WebCore Revision 289208 Author jh718.p...@samsung.com Date 2022-02-07 05:49:21 -0800 (Mon, 07 Feb 2022) Log Message Remove unused CSSCalcExpressionNodeParser::parseValueTerm from CSSCalcExpressionNodeParser.h. https://bugs.webkit.org/show_bug.cgi?id=236226 Reviewed by Darin Adler. CSSCalcExpressionNodeParser::parseCalcValue replaces CSSCalcExpressionNodeParser::parseValueTerm in r253079, but parseValueTerm still remains in CSSCalcExpressionNodeParser.h. No new tests, no new behaviors. * css/calc/CSSCalcExpressionNodeParser.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h Diff Modified: trunk/Source/WebCore/ChangeLog (289207 => 289208) --- trunk/Source/WebCore/ChangeLog 2022-02-07 12:51:20 UTC (rev 289207) +++ trunk/Source/WebCore/ChangeLog 2022-02-07 13:49:21 UTC (rev 289208) @@ -1,3 +1,17 @@ +2022-02-07 Joonghun Park + +Remove unused CSSCalcExpressionNodeParser::parseValueTerm from CSSCalcExpressionNodeParser.h. +https://bugs.webkit.org/show_bug.cgi?id=236226 + +Reviewed by Darin Adler. + +CSSCalcExpressionNodeParser::parseCalcValue replaces CSSCalcExpressionNodeParser::parseValueTerm +in r253079, but parseValueTerm still remains in CSSCalcExpressionNodeParser.h. + +No new tests, no new behaviors. + +* css/calc/CSSCalcExpressionNodeParser.h: + 2022-02-07 Nikolas Zimmermann [LBSE] Apply position / size to SVG layers Modified: trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h (289207 => 289208) --- trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h 2022-02-07 12:51:20 UTC (rev 289207) +++ trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h 2022-02-07 13:49:21 UTC (rev 289208) @@ -50,7 +50,6 @@ char operatorValue(const CSSParserToken&); bool parseValue(CSSParserTokenRange&, CSSValueID, RefPtr&); -bool parseValueTerm(CSSParserTokenRange&, CSSValueID, int depth, RefPtr&); bool parseCalcFunction(CSSParserTokenRange&, CSSValueID, int depth, RefPtr&); bool parseCalcSum(CSSParserTokenRange&, CSSValueID, int depth, RefPtr&); bool parseCalcProduct(CSSParserTokenRange&, CSSValueID, int depth, RefPtr&); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287127] trunk/LayoutTests/imported/w3c
Title: [287127] trunk/LayoutTests/imported/w3c
Revision 287127
Author jh718.p...@samsung.com
Date 2021-12-16 02:52:35 -0800 (Thu, 16 Dec 2021)
Log Message
Unreviewed. Import updated table-child-percentage-height-with-border-box-expected.html
The wpt expected file was fixed accroding to the spec,
https://drafts.csswg.org/css-tables-3/#table-cell-content-relayout.
The corresponding wpt issue is https://github.com/web-platform-tests/wpt/pull/32089.
* web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287126 => 287127)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-16 07:08:17 UTC (rev 287126)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-16 10:52:35 UTC (rev 287127)
@@ -1,3 +1,14 @@
+2021-12-16 Joonghun Park
+
+Unreviewed. Import updated table-child-percentage-height-with-border-box-expected.html
+
+The wpt expected file was fixed accroding to the spec,
+https://drafts.csswg.org/css-tables-3/#table-cell-content-relayout.
+
+The corresponding wpt issue is https://github.com/web-platform-tests/wpt/pull/32089.
+
+* web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html:
+
2021-12-13 Sergio Villar Senin
[css-flexbox] Absolutely positioned children should be aligned using the margin box
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html (287126 => 287127)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html 2021-12-16 07:08:17 UTC (rev 287126)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html 2021-12-16 10:52:35 UTC (rev 287127)
@@ -9,7 +9,6 @@
}
body {
box-sizing: border-box;
-display: table;
margin: 0 auto;
width: 100%;
height: 100%;
@@ -16,13 +15,12 @@
}
.content {
box-sizing: border-box;
-display: table-row;
width: 100%;
height: 100%;
background-color: red;
}
.wrapper {
-box-sizing: content-box;
+box-sizing: border-box;
width: 100%;
height: 100%;
background-color: green;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287063] trunk
Title: [287063] trunk Revision 287063 Author jh718.p...@samsung.com Date 2021-12-14 22:53:53 -0800 (Tue, 14 Dec 2021) Log Message Fix that height is calculated incorrectly when using display:table, box-sizing:border-box and padding. https://bugs.webkit.org/show_bug.cgi?id=196175 Reviewed by Darin Adler. Currently, box sizing type check is missing, so the height of display:table element's percent height child is subtracted by its border and padding even when its 'box-sizing' is not 'content-box'. This patch adds the missing box sizing type check. LayoutTests/imported/w3c: * web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html: Added. * web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html: Added. Source/WebCore: Test: imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html * rendering/RenderBox.cpp: (WebCore::RenderBox::computePercentageLogicalHeight const): LayoutTests: * platform/gtk/fast/table/003-expected.txt: * platform/gtk/tables/mozilla/bugs/bug30692-expected.txt: * platform/ios/tables/mozilla/bugs/bug30692-expected.txt: * platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt: * platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt: * platform/mac/fast/table/003-expected.txt: * platform/mac/tables/mozilla/bugs/bug30692-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/platform/gtk/fast/table/003-expected.txt trunk/LayoutTests/platform/gtk/tables/mozilla/bugs/bug30692-expected.txt trunk/LayoutTests/platform/ios/tables/mozilla/bugs/bug30692-expected.txt trunk/LayoutTests/platform/mac/fast/table/003-expected.txt trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt trunk/LayoutTests/platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt trunk/LayoutTests/platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html Diff Modified: trunk/LayoutTests/ChangeLog (287062 => 287063) --- trunk/LayoutTests/ChangeLog 2021-12-15 05:44:52 UTC (rev 287062) +++ trunk/LayoutTests/ChangeLog 2021-12-15 06:53:53 UTC (rev 287063) @@ -1,3 +1,23 @@ +2021-12-14 Joonghun Park + +Fix that height is calculated incorrectly when using display:table, box-sizing:border-box and padding. +https://bugs.webkit.org/show_bug.cgi?id=196175 + +Reviewed by Darin Adler. + +Currently, box sizing type check is missing, so the height of display:table element's percent height child +is subtracted by its border and padding even when its 'box-sizing' is not 'content-box'. + +This patch adds the missing box sizing type check. + +* platform/gtk/fast/table/003-expected.txt: +* platform/gtk/tables/mozilla/bugs/bug30692-expected.txt: +* platform/ios/tables/mozilla/bugs/bug30692-expected.txt: +* platform/mac-catalina/tables/mozilla/bugs/bug30692-expected.txt: +* platform/mac-mojave/tables/mozilla/bugs/bug30692-expected.txt: +* platform/mac/fast/table/003-expected.txt: +* platform/mac/tables/mozilla/bugs/bug30692-expected.txt: + 2021-12-14 Ryan Haddad REGRESSION (r286982): ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287062 => 287063) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-15 05:44:52 UTC (rev 287062) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-15 06:53:53 UTC (rev 287063) @@ -1,3 +1,18 @@ +2021-12-14 Joonghun Park + +Fix that height is calculated incorrectly when using display:table, box-sizing:border-box and padding. +https://bugs.webkit.org/show_bug.cgi?id=196175 + +Reviewed by Darin Adler. + +Currently, box sizing type check is missing, so the height of display:table element's percent height child +is subtracted by its border and padding even when its 'box-sizing' is not 'content-box'. + +This patch adds the missing box sizing type check. + +* web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html: Added. +* web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box.html: Added. + 2021-12-14 Alex Christensen Revert r284816 Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-sizing/table-child-percentage-height-with-border-box-expected.html (0 => 287063) ---
[webkit-changes] [286947] trunk/Source/WebKit
Title: [286947] trunk/Source/WebKit
Revision 286947
Author jh718.p...@samsung.com
Date 2021-12-13 07:18:11 -0800 (Mon, 13 Dec 2021)
Log Message
Unreviewed. Fix build error since r286946.
ClientOrigin should be forward declared as struct, not class.
* NetworkProcess/storage/SessionStorageManager.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (286946 => 286947)
--- trunk/Source/WebKit/ChangeLog 2021-12-13 13:42:48 UTC (rev 286946)
+++ trunk/Source/WebKit/ChangeLog 2021-12-13 15:18:11 UTC (rev 286947)
@@ -1,3 +1,11 @@
+2021-12-13 Joonghun Park
+
+Unreviewed. Fix build error since r286946.
+
+ClientOrigin should be forward declared as struct, not class.
+
+* NetworkProcess/storage/SessionStorageManager.h:
+
2021-12-13 Adrian Perez de Castro
Unreviewed build fix after r286936
Modified: trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h (286946 => 286947)
--- trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h 2021-12-13 13:42:48 UTC (rev 286946)
+++ trunk/Source/WebKit/NetworkProcess/storage/SessionStorageManager.h 2021-12-13 15:18:11 UTC (rev 286947)
@@ -30,7 +30,7 @@
#include "StorageNamespaceIdentifier.h"
namespace WebCore {
-class ClientOrigin;
+struct ClientOrigin;
} // namespace WebCore
namespace WebKit {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286909] trunk/Source/WebCore
Title: [286909] trunk/Source/WebCore
Revision 286909
Author jh718.p...@samsung.com
Date 2021-12-11 05:36:37 -0800 (Sat, 11 Dec 2021)
Log Message
Unreviewed. CSSCalcOperationNode::allowsNegativePercentageReference() should be const member function.
In r286897, the above method's const keyword was missed out, so add it.
No new tests, no new behaviours.
* css/calc/CSSCalcOperationNode.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (286908 => 286909)
--- trunk/Source/WebCore/ChangeLog 2021-12-11 09:00:51 UTC (rev 286908)
+++ trunk/Source/WebCore/ChangeLog 2021-12-11 13:36:37 UTC (rev 286909)
@@ -1,3 +1,13 @@
+2021-12-11 Joonghun Park
+
+Unreviewed. CSSCalcOperationNode::allowsNegativePercentageReference() should be const member function.
+
+In r286897, the above method's const keyword was missed out, so add it.
+
+No new tests, no new behaviours.
+
+* css/calc/CSSCalcOperationNode.h:
+
2021-12-11 Jer Noble
Add an experimental trackConfiguration accessor on AudioTrack & VideoTrack.
Modified: trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h (286908 => 286909)
--- trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h 2021-12-11 09:00:51 UTC (rev 286908)
+++ trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h 2021-12-11 13:36:37 UTC (rev 286909)
@@ -73,7 +73,7 @@
bool canCombineAllChildren() const;
-bool allowsNegativePercentageReference() { return m_allowsNegativePercentageReference; }
+bool allowsNegativePercentageReference() const { return m_allowsNegativePercentageReference; }
void setAllowsNegativePercentageReference() { m_allowsNegativePercentageReference = true; }
bool isIdentity() const { return m_children.size() == 1 && (m_operator == CalcOperator::Min || m_operator == CalcOperator::Max || m_operator == CalcOperator::Add || m_operator == CalcOperator::Multiply); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [286897] trunk
Title: [286897] trunk Revision 286897 Author jh718.p...@samsung.com Date 2021-12-10 18:45:31 -0800 (Fri, 10 Dec 2021) Log Message Don't do simplification for percentage comparison resolution against negative reference values. https://bugs.webkit.org/show_bug.cgi?id=233987 Reviewed by Darin Adler. A percentage may be resolved against a negative value, which is allowed only in 'background-position' property. Currently in CSSCalcExpressionNodeParser::parseCalc, it creates CSSCalcExpressionNode tree result and does simplification for it. But during it, e.g. min(50%, 10%) is simplified to min(10%) and max(50%, 10%) is simplified to max(50%), which is the opposite result what should be done against negative basis. With this patch, the percentage comparison resolution against nagative basis is done correctly. The corresponding spec is step 4's note described below in https://drafts.csswg.org/css-values-4/#simplify-a-calculation-tree. 'If a percentage is left at this point, it will usually block simplification of the node, since it needs to be resolved against another value using information not currently available. (Otherwise, it would have been converted to a different value in an earlier step.) This includes operations such as "min", since percentages might resolve against a negative basis, and thus end up with an opposite comparative relationship than the raw percentage value would seem to indicate.' LayoutTests/imported/w3c: * web-platform-tests/css/css-values/minmax-percentage-serialize-expected.txt: Source/WebCore: * css/calc/CSSCalcExpressionNodeParser.cpp: (WebCore::CSSCalcExpressionNodeParser::parseCalc): * css/calc/CSSCalcExpressionNodeParser.h: * css/calc/CSSCalcOperationNode.cpp: (WebCore::CSSCalcOperationNode::combineChildren): * css/calc/CSSCalcOperationNode.h: * css/calc/CSSCalcValue.cpp: (WebCore::CSSCalcValue::create): * css/calc/CSSCalcValue.h: * css/parser/CSSPropertyParser.cpp: (WebCore::consumeBackgroundPosition): * css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::CalcParser::CalcParser): (WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent): (WebCore::CSSPropertyParserHelpers::consumePositionComponent): (WebCore::CSSPropertyParserHelpers::consumePositionCoordinates): * css/parser/CSSPropertyParserHelpers.h: LayoutTests: * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-values/minmax-percentage-serialize-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.cpp trunk/Source/WebCore/css/calc/CSSCalcExpressionNodeParser.h trunk/Source/WebCore/css/calc/CSSCalcOperationNode.cpp trunk/Source/WebCore/css/calc/CSSCalcOperationNode.h trunk/Source/WebCore/css/calc/CSSCalcValue.cpp trunk/Source/WebCore/css/calc/CSSCalcValue.h trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.h Diff Modified: trunk/LayoutTests/ChangeLog (286896 => 286897) --- trunk/LayoutTests/ChangeLog 2021-12-11 02:32:03 UTC (rev 286896) +++ trunk/LayoutTests/ChangeLog 2021-12-11 02:45:31 UTC (rev 286897) @@ -1,3 +1,30 @@ +2021-12-10 Joonghun Park + +Don't do simplification for percentage comparison resolution against negative reference values. +https://bugs.webkit.org/show_bug.cgi?id=233987 + +Reviewed by Darin Adler. + +A percentage may be resolved against a negative value, which is allowed only in 'background-position' property. + +Currently in CSSCalcExpressionNodeParser::parseCalc, +it creates CSSCalcExpressionNode tree result and does simplification for it. +But during it, e.g. min(50%, 10%) is simplified to min(10%) and max(50%, 10%) is simplified to max(50%), +which is the opposite result what should be done against negative basis. + +With this patch, the percentage comparison resolution against nagative basis is done correctly. + +The corresponding spec is step 4's note described below in +https://drafts.csswg.org/css-values-4/#simplify-a-calculation-tree. + +'If a percentage is left at this point, it will usually block simplification of the node, +since it needs to be resolved against another value using information not currently available. +(Otherwise, it would have been converted to a different value in an earlier step.) +This includes operations such as "min", since percentages might resolve against a negative basis, +and thus end up with an opposite comparative relationship than the raw percentage value would seem to indicate.' + +* TestExpectations: + 2021-12-10 Devin Rousso WKWebView doesn’t respond to -copyFont: and -pasteFont: Modified: trunk/LayoutTests/TestExpectations (286896 => 286897)
[webkit-changes] [285915] trunk
Title: [285915] trunk Revision 285915 Author jh718.p...@samsung.com Date 2021-11-16 21:53:07 -0800 (Tue, 16 Nov 2021) Log Message border-radius inline style should serialize with valid syntax https://bugs.webkit.org/show_bug.cgi?id=183994 This patch have border-radius property serializes in canonical order as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add css wide keywords test case results. * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add css wide keywords test cases. Source/WebCore: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): * css/StyleProperties.h: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleProperties.h Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285914 => 285915) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 04:27:08 UTC (rev 285914) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-17 05:53:07 UTC (rev 285915) @@ -1,3 +1,16 @@ +2021-11-16 Joonghun Park + +border-radius inline style should serialize with valid syntax +https://bugs.webkit.org/show_bug.cgi?id=183994 + +This patch have border-radius property serializes in canonical order +as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add css wide keywords test case results. +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add css wide keywords test cases. + 2021-11-16 Sihui Liu Implement FileSystemFileHandle.getFile() Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt (285914 => 285915) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-17 04:27:08 UTC (rev 285914) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-17 05:53:07 UTC (rev 285915) @@ -1,19 +1,23 @@ +PASS e.style['border-radius'] = "initial" should set the property value +PASS e.style['border-radius'] = "inherit" should set the property value +PASS e.style['border-radius'] = "unset" should set the property value +PASS e.style['border-radius'] = "revert" should set the property value PASS e.style['border-radius'] = "1px" should set the property value PASS e.style['border-radius'] = "1px 5%" should set the property value PASS e.style['border-radius'] = "1px 2% 3px" should set the property value PASS e.style['border-radius'] = "1px 2% 3px 4%" should set the property value -FAIL e.style['border-radius'] = "1px / 2px" should set the property value assert_equals: serialization should be canonical expected "1px / 2px" but got "1px 2px" -FAIL e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value assert_equals: serialization should be canonical expected "5em / 1px 2% 3px 4%" but got "5em 1px 5em 2% 5em 3px 5em 4%" -FAIL e.style['border-radius'] = "1px 2% / 3px 4px" should set the property value assert_equals: serialization should be canonical expected "1px 2% / 3px 4px" but got "1px 3px 2% 4px" -FAIL e.style['border-radius'] = "1px 2px 3em / 1px 2px 3%" should set the property value assert_equals: serialization should be canonical expected "1px 2px 3em / 1px 2px 3%" but got "1px 2px 3em 3%" -FAIL e.style['border-radius'] = "1px 2% / 2px 3em 4px 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% / 2px 3em 4px 5em" but got "1px 2px 2% 3em 1px 4px 2% 5em" -FAIL e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% 3px 4% / 5em" but got "1px 5em 2% 5em 3px 5em 4% 5em" -FAIL e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 1px 1px 2% / 1px 2%" but got "1px 1px 2% 1px 2%" -FAIL e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value assert_equals: serialization should be canonical expected "1px / 1px 1px 2%" but got "1px 1px 1px 2%" +PASS e.style['border-radius'] = "1px / 2px" should set the property value +PASS e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value +PASS
[webkit-changes] [285383] trunk
Title: [285383] trunk Revision 285383 Author jh718.p...@samsung.com Date 2021-11-06 16:07:22 -0700 (Sat, 06 Nov 2021) Log Message font-synthesis inline/computed style should be in canonical order. https://bugs.webkit.org/show_bug.cgi?id=186344 Reviewed by Myles C. Maxfield. Per the spec, https://drafts.csswg.org/css-fonts/#font-synthesis. LayoutTests/imported/w3c: * web-platform-tests/css/css-fonts/inheritance-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-synthesis-computed-expected.txt: * web-platform-tests/css/css-fonts/parsing/font-synthesis-valid-expected.txt: * web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt: * web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: Source/WebCore: * css/CSSComputedStyleDeclaration.cpp: (WebCore::fontSynthesisFromStyle): * css/parser/CSSPropertyParser.cpp: (WebCore::consumeFontSynthesis): LayoutTests: * fast/css/getComputedStyle/computed-style-expected.txt: * fast/css/getComputedStyle/computed-style-font-family-expected.txt: * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * fast/css3-text/font-synthesis-parse-expected.txt: * fast/css3-text/font-synthesis-parse.html: * fast/text/font-synthesis-parsing-expected.txt: * fast/text/font-synthesis-parsing.html: * platform/glib/fast/css/getComputedStyle/computed-style-expected.txt: * platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt: * platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/glib/svg/css/getComputedStyle-basic-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-font-family-expected.txt: * platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/ios/svg/css/getComputedStyle-basic-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-font-family-expected.txt: * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: * platform/mac/svg/css/getComputedStyle-basic-expected.txt: * svg/css/getComputedStyle-basic-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/fast/css3-text/font-synthesis-parse-expected.txt trunk/LayoutTests/fast/css3-text/font-synthesis-parse.html trunk/LayoutTests/fast/text/font-synthesis-parsing-expected.txt trunk/LayoutTests/fast/text/font-synthesis-parsing.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/inheritance-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-synthesis-computed-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-synthesis-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/glib/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/ios/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/cssom/cssstyledeclaration-csstext-expected.txt trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-expected.txt trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-font-family-expected.txt trunk/LayoutTests/platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt trunk/LayoutTests/platform/mac/svg/css/getComputedStyle-basic-expected.txt trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt
[webkit-changes] [285235] trunk
Title: [285235] trunk Revision 285235 Author jh718.p...@samsung.com Date 2021-11-03 15:18:37 -0700 (Wed, 03 Nov 2021) Log Message border-radius inline style should serialize with valid syntax https://bugs.webkit.org/show_bug.cgi?id=183994 This patch have border-radius property serializes in canonical order as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. Reviewed by Darin Adler. LayoutTests/imported/w3c: * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add more test case results. * web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add more test cases. Source/WebCore: * css/StyleProperties.cpp: (WebCore::StyleProperties::getPropertyValue const): (WebCore::StyleProperties::borderRadiusValue const): * css/StyleProperties.h: * css/parser/CSSPropertyParser.cpp: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/StyleProperties.cpp trunk/Source/WebCore/css/StyleProperties.h trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (285234 => 285235) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 22:07:25 UTC (rev 285234) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-11-03 22:18:37 UTC (rev 285235) @@ -1,3 +1,16 @@ +2021-11-03 Joonghun Park + +border-radius inline style should serialize with valid syntax +https://bugs.webkit.org/show_bug.cgi?id=183994 + +This patch have border-radius property serializes in canonical order +as specified in https://drafts.csswg.org/css-backgrounds/#border-radius. + +Reviewed by Darin Adler. + +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt: Add more test case results. +* web-platform-tests/css/css-backgrounds/parsing/border-radius-valid.html: Add more test cases. + 2021-11-03 Chris Dumez _javascript_ URLs do not run in the right context when using frame targeting Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt (285234 => 285235) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-03 22:07:25 UTC (rev 285234) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-radius-valid-expected.txt 2021-11-03 22:18:37 UTC (rev 285235) @@ -1,13 +1,19 @@ PASS e.style['border-radius'] = "1px" should set the property value +PASS e.style['border-radius'] = "1px 5%" should set the property value +PASS e.style['border-radius'] = "1px 2% 3px" should set the property value PASS e.style['border-radius'] = "1px 2% 3px 4%" should set the property value -FAIL e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value assert_equals: serialization should be canonical expected "5em / 1px 2% 3px 4%" but got "5em 1px 5em 2% 5em 3px 5em 4%" -FAIL e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value assert_equals: serialization should be canonical expected "1px 2% 3px 4% / 5em" but got "1px 5em 2% 5em 3px 5em 4% 5em" -FAIL e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 1px 1px 2% / 1px 2%" but got "1px 1px 2% 1px 2%" -FAIL e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value assert_equals: serialization should be canonical expected "1px / 1px 1px 2%" but got "1px 1px 1px 2%" +PASS e.style['border-radius'] = "1px / 2px" should set the property value +PASS e.style['border-radius'] = "5em / 1px 2% 3px 4%" should set the property value +PASS e.style['border-radius'] = "1px 2% / 3px 4px" should set the property value +PASS e.style['border-radius'] = "1px 2px 3em / 1px 2px 3%" should set the property value +PASS e.style['border-radius'] = "1px 2% / 2px 3em 4px 5em" should set the property value +PASS e.style['border-radius'] = "1px 2% 3px 4% / 5em" should set the property value +PASS e.style['border-radius'] = "1px 1px 1px 2% / 1px 2% 1px 2%" should set the property value +PASS e.style['border-radius'] = "1px 1px 1px 1px / 1px 1px 2% 1px" should set the property value PASS e.style['border-radius'] = "1px 1px 2% 2%" should set the property value PASS e.style['border-radius'] = "1px 2% 1px 1px" should set the property value -FAIL e.style['border-radius'] = "1px 2% 2% 2% / 1px 2% 3px 2%" should set the property value assert_equals: serialization should be canonical expected "1px 2% 2% / 1px 2% 3px" but got "1px 2% 2% 3px" +PASS e.style['border-radius'] = "1px 2% 2% 2% / 1px 2% 3px 2%" should set the
[webkit-changes] [283865] trunk
Title: [283865] trunk Revision 283865 Author jh718.p...@samsung.com Date 2021-10-08 23:48:53 -0700 (Fri, 08 Oct 2021) Log Message Unreviewed. Add github username for Joonghun Park. * metadata/contributors.json: Modified Paths trunk/ChangeLog trunk/metadata/contributors.json Diff Modified: trunk/ChangeLog (283864 => 283865) --- trunk/ChangeLog 2021-10-09 06:24:30 UTC (rev 283864) +++ trunk/ChangeLog 2021-10-09 06:48:53 UTC (rev 283865) @@ -1,3 +1,9 @@ +2021-10-08 Joonghun Park + +Unreviewed. Add github username for Joonghun Park. + +* metadata/contributors.json: + 2021-10-08 Jonathan Bedard Add github username for Michael Catanzaro Modified: trunk/metadata/contributors.json (283864 => 283865) --- trunk/metadata/contributors.json 2021-10-09 06:24:30 UTC (rev 283864) +++ trunk/metadata/contributors.json 2021-10-09 06:48:53 UTC (rev 283865) @@ -3598,6 +3598,7 @@ "jh718.p...@gmail.com", "pjh0...@gmail.com" ], + "github" : "joonghunpark", "name" : "Joonghun Park", "nicks" : [ "joonghunpark" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282898] trunk
Title: [282898] trunk Revision 282898 Author jh718.p...@samsung.com Date 2021-09-22 17:40:13 -0700 (Wed, 22 Sep 2021) Log Message Fix the behavior that setting text field input's value content attribute to the same value moves caret to the end of the input. https://bugs.webkit.org/show_bug.cgi?id=191255 Reviewed by Simon Fraser. This patch changes the behavior specified above to make WebKit's behavior interoperable according to the spec below at https://html.spec.whatwg.org/multipage/form-elements.html#dom-textarea-value. '4. If the new API value is different from oldAPIValue, then move the text entry cursor position to the end of the text control, unselecting any selected text and resetting the selection direction to "none".' LayoutTests/imported/w3c: * web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt: * web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt: * web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt: Source/WebCore: * html/TextFieldInputType.cpp: (WebCore::TextFieldInputType::setValue): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/TextFieldInputType.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282897 => 282898) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-23 00:39:19 UTC (rev 282897) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-23 00:40:13 UTC (rev 282898) @@ -1,3 +1,22 @@ +2021-09-22 Joonghun Park + +Fix the behavior that setting text field input's value content attribute to the same value moves caret to the end of the input. +https://bugs.webkit.org/show_bug.cgi?id=191255 + +Reviewed by Simon Fraser. + +This patch changes the behavior specified above to make WebKit's behavior interoperable +according to the spec below at +https://html.spec.whatwg.org/multipage/form-elements.html#dom-textarea-value. + +'4. If the new API value is different from oldAPIValue, +then move the text entry cursor position to the end of the text control, +unselecting any selected text and resetting the selection direction to "none".' + +* web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt: +* web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt: +* web-platform-tests/html/semantics/forms/textfieldselection/selection-value-interactions-expected.txt: + 2021-09-21 Myles C. Maxfield Parsing support for font-palette Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt (282897 => 282898) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt 2021-09-23 00:39:19 UTC (rev 282897) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/defaultSelection-expected.txt 2021-09-23 00:40:13 UTC (rev 282898) @@ -4,6 +4,6 @@ PASS selectionStart and selectionEnd do not change when same value set again for [object HTMLTextAreaElement] FAIL selectionStart and selectionEnd change when value changed to upper case for [object HTMLTextAreaElement] assert_equals: expected 3 but got 0 PASS Default selectionStart and selectionEnd for [object HTMLInputElement] -FAIL selectionStart and selectionEnd do not change when same value set again for [object HTMLInputElement] assert_equals: expected 0 but got 3 +PASS selectionStart and selectionEnd do not change when same value set again for [object HTMLInputElement] PASS selectionStart and selectionEnd change when value changed to upper case for [object HTMLInputElement] Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt (282897 => 282898) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt 2021-09-23 00:39:19 UTC (rev 282897) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt 2021-09-23 00:40:13 UTC (rev 282898) @@ -1,14 +1,14 @@ -FAIL input out of document: selection must not change when setting the same value assert_equals: selectionStart must not change expected 1 but got 5 +PASS input out of document:
[webkit-changes] [282359] trunk
Title: [282359] trunk Revision 282359 Author jh718.p...@samsung.com Date 2021-09-13 14:32:57 -0700 (Mon, 13 Sep 2021) Log Message transform-origin should not accept 4 lengths https://bugs.webkit.org/show_bug.cgi?id=186965 transform-origin accepts 1, 2, or 3 values per the spec below. https://drafts.csswg.org/css-transforms/#propdef-transform-origin Reviewed by Simon Fraser. LayoutTests/imported/w3c: * web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt: Source/WebCore: * css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::consumeTransformOrigin): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (282358 => 282359) --- trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-13 21:20:16 UTC (rev 282358) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-09-13 21:32:57 UTC (rev 282359) @@ -1,3 +1,15 @@ +2021-09-13 Joonghun Park + +transform-origin should not accept 4 lengths +https://bugs.webkit.org/show_bug.cgi?id=186965 + +transform-origin accepts 1, 2, or 3 values per the spec below. +https://drafts.csswg.org/css-transforms/#propdef-transform-origin + +Reviewed by Simon Fraser. + +* web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt: + 2021-09-13 Sam Sneddon Move ENABLE_RESOLUTION_MEDIA_QUERY to a runtime flag, start running tests again Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt (282358 => 282359) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt 2021-09-13 21:20:16 UTC (rev 282358) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/parsing/transform-origin-invalid-expected.txt 2021-09-13 21:32:57 UTC (rev 282359) @@ -1,7 +1,7 @@ PASS e.style['transform-origin'] = "1px 2px 3%" should not set the property value PASS e.style['transform-origin'] = "1px 2px left" should not set the property value -FAIL e.style['transform-origin'] = "1px 2px 3px 4px" should not set the property value assert_equals: expected "" but got "1px 2px 3px" +PASS e.style['transform-origin'] = "1px 2px 3px 4px" should not set the property value PASS e.style['transform-origin'] = "1px left" should not set the property value PASS e.style['transform-origin'] = "top 1px" should not set the property value PASS e.style['transform-origin'] = "right left" should not set the property value Modified: trunk/Source/WebCore/ChangeLog (282358 => 282359) --- trunk/Source/WebCore/ChangeLog 2021-09-13 21:20:16 UTC (rev 282358) +++ trunk/Source/WebCore/ChangeLog 2021-09-13 21:32:57 UTC (rev 282359) @@ -1,3 +1,16 @@ +2021-09-13 Joonghun Park + +transform-origin should not accept 4 lengths +https://bugs.webkit.org/show_bug.cgi?id=186965 + +transform-origin accepts 1, 2, or 3 values per the spec below. +https://drafts.csswg.org/css-transforms/#propdef-transform-origin + +Reviewed by Simon Fraser. + +* css/parser/CSSPropertyParser.cpp: +(WebCore::CSSPropertyParser::consumeTransformOrigin): + 2021-09-13 Tyler Wilcock AX: Make PDFs loaded via accessible Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (282358 => 282359) --- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-09-13 21:20:16 UTC (rev 282358) +++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-09-13 21:32:57 UTC (rev 282359) @@ -357,7 +357,7 @@ bool atEnd = m_range.atEnd(); auto resultZ = consumeLength(m_range, m_context.mode, ValueRange::All); bool hasZ = resultZ; -if (!hasZ && !atEnd) +if ((!hasZ && !atEnd) || !m_range.atEnd()) return false; addProperty(CSSPropertyTransformOriginX, CSSPropertyTransformOrigin, WTFMove(resultXY->x), important); addProperty(CSSPropertyTransformOriginY, CSSPropertyTransformOrigin, WTFMove(resultXY->y), important); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281740] trunk/Source/WebKit
Title: [281740] trunk/Source/WebKit Revision 281740 Author jh718.p...@samsung.com Date 2021-08-29 02:27:02 -0700 (Sun, 29 Aug 2021) Log Message Unreviewed. Remove the build warning below since r281096. No new tests, no new behavioral changes. * UIProcess/AuxiliaryProcessProxy.cpp: (WebKit::AuxiliaryProcessProxy::stateString const): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (281739 => 281740) --- trunk/Source/WebKit/ChangeLog 2021-08-29 09:18:56 UTC (rev 281739) +++ trunk/Source/WebKit/ChangeLog 2021-08-29 09:27:02 UTC (rev 281740) @@ -1,3 +1,12 @@ +2021-08-29 Joonghun Park + +Unreviewed. Remove the build warning below since r281096. + +No new tests, no new behavioral changes. + +* UIProcess/AuxiliaryProcessProxy.cpp: +(WebKit::AuxiliaryProcessProxy::stateString const): + 2021-08-28 Cameron McCormack Miscellaneous typo fixes Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (281739 => 281740) --- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2021-08-29 09:18:56 UTC (rev 281739) +++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2021-08-29 09:27:02 UTC (rev 281740) @@ -150,6 +150,8 @@ return "Running"_s; case AuxiliaryProcessProxy::State::Terminated: return "Terminated"_s; +default: +RELEASE_ASSERT_NOT_REACHED(); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281739] trunk/Source/WebCore
Title: [281739] trunk/Source/WebCore Revision 281739 Author jh718.p...@samsung.com Date 2021-08-29 02:18:56 -0700 (Sun, 29 Aug 2021) Log Message Unreviewed. Remove the build warning below since r280958. warning: control reaches end of non-void function [-Wreturn-type] No new tests, no new behavioral changes. * Modules/mediastream/RTCRtpSFrameTransform.cpp: (WebCore::errorTypeFromInformation): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (281738 => 281739) --- trunk/Source/WebCore/ChangeLog 2021-08-29 09:07:16 UTC (rev 281738) +++ trunk/Source/WebCore/ChangeLog 2021-08-29 09:18:56 UTC (rev 281739) @@ -1,3 +1,13 @@ +2021-08-29 Joonghun Park + +Unreviewed. Remove the build warning below since r280958. +warning: control reaches end of non-void function [-Wreturn-type] + +No new tests, no new behavioral changes. + +* Modules/mediastream/RTCRtpSFrameTransform.cpp: +(WebCore::errorTypeFromInformation): + 2021-08-28 Cameron McCormack Miscellaneous typo fixes Modified: trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp (281738 => 281739) --- trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp 2021-08-29 09:07:16 UTC (rev 281738) +++ trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.cpp 2021-08-29 09:18:56 UTC (rev 281739) @@ -112,6 +112,8 @@ return RTCRtpSFrameTransformErrorEvent::Type::Syntax; case RTCRtpSFrameTransformer::Error::Other: return RTCRtpSFrameTransformErrorEvent::Type::Other; +default: +RELEASE_ASSERT_NOT_REACHED(); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281738] trunk/Source/JavaScriptCore
Title: [281738] trunk/Source/_javascript_Core Revision 281738 Author jh718.p...@samsung.com Date 2021-08-29 02:07:16 -0700 (Sun, 29 Aug 2021) Log Message Unreviewed. Remove the build warning below since r281615. warning: control reaches end of non-void function [-Wreturn-type] * bytecode/PutByStatus.cpp: (JSC::PutByStatus::makesCalls const): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (281737 => 281738) --- trunk/Source/_javascript_Core/ChangeLog 2021-08-29 01:48:21 UTC (rev 281737) +++ trunk/Source/_javascript_Core/ChangeLog 2021-08-29 09:07:16 UTC (rev 281738) @@ -1,3 +1,11 @@ +2021-08-29 Joonghun Park + +Unreviewed. Remove the build warning below since r281615. +warning: control reaches end of non-void function [-Wreturn-type] + +* bytecode/PutByStatus.cpp: +(JSC::PutByStatus::makesCalls const): + 2021-08-28 Cameron McCormack Miscellaneous typo fixes Modified: trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp (281737 => 281738) --- trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp 2021-08-29 01:48:21 UTC (rev 281737) +++ trunk/Source/_javascript_Core/bytecode/PutByStatus.cpp 2021-08-29 09:07:16 UTC (rev 281738) @@ -424,6 +424,8 @@ } return false; } +default: +RELEASE_ASSERT_NOT_REACHED(); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280513] trunk/Source/JavaScriptCore
Title: [280513] trunk/Source/_javascript_Core
Revision 280513
Author jh718.p...@samsung.com
Date 2021-07-31 01:29:25 -0700 (Sat, 31 Jul 2021)
Log Message
Unreviewed. Remove the build warning below since r280493.
warning: variable ‘block’ set but not used [-Wunused-but-set-variable]
* b3/B3CanonicalizePrePostIncrements.cpp:
(JSC::B3::canonicalizePrePostIncrements):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3CanonicalizePrePostIncrements.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280512 => 280513)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-31 08:06:04 UTC (rev 280512)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-31 08:29:25 UTC (rev 280513)
@@ -1,3 +1,11 @@
+2021-07-31 Joonghun Park
+
+Unreviewed. Remove the build warning below since r280493.
+warning: variable ‘block’ set but not used [-Wunused-but-set-variable]
+
+* b3/B3CanonicalizePrePostIncrements.cpp:
+(JSC::B3::canonicalizePrePostIncrements):
+
2021-07-30 Yusuke Suzuki
[JSC] branchTest8 should not emit tst for Zero/NonZero cases
Modified: trunk/Source/_javascript_Core/b3/B3CanonicalizePrePostIncrements.cpp (280512 => 280513)
--- trunk/Source/_javascript_Core/b3/B3CanonicalizePrePostIncrements.cpp 2021-07-31 08:06:04 UTC (rev 280512)
+++ trunk/Source/_javascript_Core/b3/B3CanonicalizePrePostIncrements.cpp 2021-07-31 08:29:25 UTC (rev 280513)
@@ -52,7 +52,6 @@
InsertionSet insertionSet { proc };
BlockInsertionSet blockInsertionSet { proc };
-BasicBlock* block { nullptr };
unsigned index { 0 };
Dominators& dominators = proc.dominators();
@@ -129,7 +128,6 @@
};
for (BasicBlock* basicBlock : proc.blocksInPreOrder()) {
-block = basicBlock;
for (index = 0; index < basicBlock->size(); ++index) {
Value* value = basicBlock->at(index);
tryPrePostIndex(value);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280376] trunk/Source/WebCore
Title: [280376] trunk/Source/WebCore
Revision 280376
Author jh718.p...@samsung.com
Date 2021-07-27 22:55:23 -0700 (Tue, 27 Jul 2021)
Log Message
Unreviewed. Remove the build warning below since r280332.
warning: redundant move in return statement [-Wredundant-move]
No new tests, no new behaviors.
* html/DOMFormData.cpp:
(WebCore::DOMFormData::create):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMFormData.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (280375 => 280376)
--- trunk/Source/WebCore/ChangeLog 2021-07-28 04:35:15 UTC (rev 280375)
+++ trunk/Source/WebCore/ChangeLog 2021-07-28 05:55:23 UTC (rev 280376)
@@ -1,3 +1,13 @@
+2021-07-27 Joonghun Park
+
+Unreviewed. Remove the build warning below since r280332.
+warning: redundant move in return statement [-Wredundant-move]
+
+No new tests, no new behaviors.
+
+* html/DOMFormData.cpp:
+(WebCore::DOMFormData::create):
+
2021-07-27 Devin Rousso
[Modern Media Controls] [macOS] Overflow button still shows as `on` even after contextmenu is dismissed
Modified: trunk/Source/WebCore/html/DOMFormData.cpp (280375 => 280376)
--- trunk/Source/WebCore/html/DOMFormData.cpp 2021-07-28 04:35:15 UTC (rev 280375)
+++ trunk/Source/WebCore/html/DOMFormData.cpp 2021-07-28 05:55:23 UTC (rev 280376)
@@ -45,7 +45,7 @@
{
auto formData = adoptRef(*new DOMFormData);
if (!form)
-return WTFMove(formData);
+return formData;
auto result = form->constructEntryList(WTFMove(formData), nullptr, HTMLFormElement::IsMultipartForm::Yes);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279972] trunk/Source/WTF
Title: [279972] trunk/Source/WTF
Revision 279972
Author jh718.p...@samsung.com
Date 2021-07-15 18:25:20 -0700 (Thu, 15 Jul 2021)
Log Message
Unreviewed. Fix the build warning below since r279895.
warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
* wtf/URL.cpp:
(WTF::URL::setPath):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (279971 => 279972)
--- trunk/Source/WTF/ChangeLog 2021-07-16 00:36:39 UTC (rev 279971)
+++ trunk/Source/WTF/ChangeLog 2021-07-16 01:25:20 UTC (rev 279972)
@@ -1,3 +1,11 @@
+2021-07-15 Joonghun Park
+
+Unreviewed. Fix the build warning below since r279895.
+warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
+
+* wtf/URL.cpp:
+(WTF::URL::setPath):
+
2021-07-15 Chris Dumez
Add initial support for BroadcastChannel behind a runtime flag
Modified: trunk/Source/WTF/wtf/URL.cpp (279971 => 279972)
--- trunk/Source/WTF/wtf/URL.cpp 2021-07-16 00:36:39 UTC (rev 279971)
+++ trunk/Source/WTF/wtf/URL.cpp 2021-07-16 01:25:20 UTC (rev 279972)
@@ -682,7 +682,7 @@
parse(makeString(
StringView(m_string).left(pathStart()),
-path.startsWith('/') || (path.startsWith('\\') && (hasSpecialScheme() || protocolIs("file"))) || (!hasSpecialScheme() && path.isEmpty() && m_schemeEnd + 1 < pathStart()) ? "" : "/",
+path.startsWith('/') || (path.startsWith('\\') && (hasSpecialScheme() || protocolIs("file"))) || (!hasSpecialScheme() && path.isEmpty() && m_schemeEnd + 1U < pathStart()) ? "" : "/",
!hasSpecialScheme() && host().isEmpty() && path.startsWith("//") && path.length() > 2 ? "/." : "",
escapePathWithoutCopying(path),
StringView(m_string).substring(m_pathEnd)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279530] trunk/Source/WebCore
Title: [279530] trunk/Source/WebCore Revision 279530 Author jh718.p...@samsung.com Date 2021-07-02 19:50:52 -0700 (Fri, 02 Jul 2021) Log Message Unreviewed. Remove the build warning below since r279498. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behavioral changes. * css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (279529 => 279530) --- trunk/Source/WebCore/ChangeLog 2021-07-03 01:24:12 UTC (rev 279529) +++ trunk/Source/WebCore/ChangeLog 2021-07-03 02:50:52 UTC (rev 279530) @@ -1,3 +1,13 @@ +2021-07-02 Joonghun Park + +Unreviewed. Remove the build warning below since r279498. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behavioral changes. + +* css/parser/CSSPropertyParserWorkerSafe.cpp: +(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceUnicodeRange): + 2021-07-02 Chris Dumez [MacOS wk1] crypto/workers/subtle/hrsa-postMessage-worker.html is a flaky failure Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp (279529 => 279530) --- trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-07-03 01:24:12 UTC (rev 279529) +++ trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-07-03 02:50:52 UTC (rev 279530) @@ -512,7 +512,7 @@ return nullptr; values->append(CSSUnicodeRangeValue::create(unicodeRange->start, unicodeRange->end)); } while (CSSPropertyParserHelpers::consumeCommaIncludingWhitespace(range)); -return WTFMove(values); +return values; } static RefPtr consumeFontFeatureTag(CSSParserTokenRange& range) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279393] trunk/Source/JavaScriptCore
Title: [279393] trunk/Source/_javascript_Core
Revision 279393
Author jh718.p...@samsung.com
Date 2021-06-29 16:48:45 -0700 (Tue, 29 Jun 2021)
Log Message
Remove "function declared ‘static’ but never defined" build warnings since r278971.
https://bugs.webkit.org/show_bug.cgi?id=227436
This patch removes the build warnings below.
warning: ‘bool JSC::cannotBeIdentPartOrEscapeStart(LChar)’ declared ‘static’ but never defined [-Wunused-function]
Reviewed by Michael Catanzaro.
* runtime/LiteralParser.cpp: Add definitions for cannotBeIdentPartOrEscapeStart.
(JSC::cannotBeIdentPartOrEscapeStart):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/LiteralParser.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (279392 => 279393)
--- trunk/Source/_javascript_Core/ChangeLog 2021-06-29 22:50:17 UTC (rev 279392)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-06-29 23:48:45 UTC (rev 279393)
@@ -1,3 +1,16 @@
+2021-06-29 Joonghun Park
+
+Remove "function declared ‘static’ but never defined" build warnings since r278971.
+https://bugs.webkit.org/show_bug.cgi?id=227436
+
+This patch removes the build warnings below.
+warning: ‘bool JSC::cannotBeIdentPartOrEscapeStart(LChar)’ declared ‘static’ but never defined [-Wunused-function]
+
+Reviewed by Michael Catanzaro.
+
+* runtime/LiteralParser.cpp: Add definitions for cannotBeIdentPartOrEscapeStart.
+(JSC::cannotBeIdentPartOrEscapeStart):
+
2021-06-29 Yijia Huang
Add a new pattern to instruction selector to use SBX and SBFIZ supported by ARM64
Modified: trunk/Source/_javascript_Core/runtime/LiteralParser.cpp (279392 => 279393)
--- trunk/Source/_javascript_Core/runtime/LiteralParser.cpp 2021-06-29 22:50:17 UTC (rev 279392)
+++ trunk/Source/_javascript_Core/runtime/LiteralParser.cpp 2021-06-29 23:48:45 UTC (rev 279393)
@@ -189,6 +189,16 @@
return result;
}
+static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(LChar)
+{
+RELEASE_ASSERT_NOT_REACHED();
+}
+
+static ALWAYS_INLINE bool cannotBeIdentPartOrEscapeStart(UChar)
+{
+RELEASE_ASSERT_NOT_REACHED();
+}
+
// 256 Latin-1 codes
static constexpr const TokenType tokenTypesOfLatin1Characters[256] = {
/* 0 - Null */ TokError,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279311] trunk/Source/WebCore
Title: [279311] trunk/Source/WebCore Revision 279311 Author jh718.p...@samsung.com Date 2021-06-26 22:42:32 -0700 (Sat, 26 Jun 2021) Log Message Unreviewed. Remove the build warnings below since r279050. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behavioral changes. * css/parser/CSSPropertyParser.cpp: (WebCore::consumeCounterStyleAdditiveSymbols): * css/parser/CSSPropertyParserWorkerSafe.cpp: (WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (279310 => 279311) --- trunk/Source/WebCore/ChangeLog 2021-06-27 02:06:45 UTC (rev 279310) +++ trunk/Source/WebCore/ChangeLog 2021-06-27 05:42:32 UTC (rev 279311) @@ -1,3 +1,15 @@ +2021-06-26 Joonghun Park + +Unreviewed. Remove the build warnings below since r279050. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behavioral changes. + +* css/parser/CSSPropertyParser.cpp: +(WebCore::consumeCounterStyleAdditiveSymbols): +* css/parser/CSSPropertyParserWorkerSafe.cpp: +(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrcURI): + 2021-06-26 Sam Weinig [Modern Media Controls] Modern media controls should not need to know about specific platforms in shared code Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (279310 => 279311) --- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-06-27 02:06:45 UTC (rev 279310) +++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2021-06-27 05:42:32 UTC (rev 279311) @@ -4703,7 +4703,7 @@ } while (consumeCommaIncludingWhitespace(range)); if (!range.atEnd() || !values->length()) return nullptr; -return WTFMove(values); +return values; } // https://www.w3.org/TR/css-counter-styles-3/#counter-style-speak-as Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp (279310 => 279311) --- trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-06-27 02:06:45 UTC (rev 279310) +++ trunk/Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp 2021-06-27 05:42:32 UTC (rev 279311) @@ -220,7 +220,7 @@ // FIXME: Change CSSFontFaceSrcValue::create to take format so we don't need a separate setFormat call. auto srcValue = CSSFontFaceSrcValue::create(location, context.isContentOpaque ? LoadedFromOpaqueSource::Yes : LoadedFromOpaqueSource::No); srcValue->setFormat(format); -return WTFMove(srcValue); +return srcValue; } static RefPtr consumeFontFaceSrcLocal(CSSParserTokenRange& range) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270531] trunk/Source/WebCore
Title: [270531] trunk/Source/WebCore Revision 270531 Author jh718.p...@samsung.com Date 2020-12-08 01:49:46 -0800 (Tue, 08 Dec 2020) Log Message Unreviewed. Remove the build warning below since r270526. warning: unused parameter ‘mediaType’ [-Wunused-parameter] No new tests, no new behaviors. * platform/network/DataURLDecoder.cpp: (WebCore::DataURLDecoder::shouldRemoveFragmentIdentifier): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/DataURLDecoder.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (270530 => 270531) --- trunk/Source/WebCore/ChangeLog 2020-12-08 07:50:27 UTC (rev 270530) +++ trunk/Source/WebCore/ChangeLog 2020-12-08 09:49:46 UTC (rev 270531) @@ -1,3 +1,13 @@ +2020-12-08 Joonghun Park + +Unreviewed. Remove the build warning below since r270526. +warning: unused parameter ‘mediaType’ [-Wunused-parameter] + +No new tests, no new behaviors. + +* platform/network/DataURLDecoder.cpp: +(WebCore::DataURLDecoder::shouldRemoveFragmentIdentifier): + 2020-12-07 Fujii Hironori Unreviewed sort-Xcode-project-file Modified: trunk/Source/WebCore/platform/network/DataURLDecoder.cpp (270530 => 270531) --- trunk/Source/WebCore/platform/network/DataURLDecoder.cpp 2020-12-08 07:50:27 UTC (rev 270530) +++ trunk/Source/WebCore/platform/network/DataURLDecoder.cpp 2020-12-08 09:49:46 UTC (rev 270531) @@ -57,6 +57,7 @@ && !equalLettersIgnoringASCIICase(mediaType, "application/x-mpegurl") && !equalLettersIgnoringASCIICase(mediaType, "vnd.apple.mpegurl"); #else +UNUSED_PARAM(mediaType); return false; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270498] trunk/Source/WebKit
Title: [270498] trunk/Source/WebKit Revision 270498 Author jh718.p...@samsung.com Date 2020-12-07 02:09:07 -0800 (Mon, 07 Dec 2020) Log Message Unreviewed. Add the switch case handling missed out from r270415. This change removes the build warning below. warning: enumeration value ‘RequestedByGPUProcess’ not handled in switch [-Wswitch] No new tests, no new behaviors. * UIProcess/API/glib/WebKitNavigationClient.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (270497 => 270498) --- trunk/Source/WebKit/ChangeLog 2020-12-07 09:38:18 UTC (rev 270497) +++ trunk/Source/WebKit/ChangeLog 2020-12-07 10:09:07 UTC (rev 270498) @@ -1,3 +1,14 @@ +2020-12-07 Joonghun Park + +Unreviewed. Add the switch case handling missed out from r270415. + +This change removes the build warning below. +warning: enumeration value ‘RequestedByGPUProcess’ not handled in switch [-Wswitch] + +No new tests, no new behaviors. + +* UIProcess/API/glib/WebKitNavigationClient.cpp: + 2020-12-06 Samuel Thibault [WebKit] Fix use of std::max_align_t Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp (270497 => 270498) --- trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp 2020-12-07 09:38:18 UTC (rev 270497) +++ trunk/Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp 2020-12-07 10:09:07 UTC (rev 270498) @@ -117,6 +117,7 @@ return true; case ProcessTerminationReason::ExceededCPULimit: case ProcessTerminationReason::RequestedByClient: +case ProcessTerminationReason::RequestedByGPUProcess: case ProcessTerminationReason::RequestedByNetworkProcess: case ProcessTerminationReason::NavigationSwap: break; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270494] trunk/Source/WebCore
Title: [270494] trunk/Source/WebCore Revision 270494 Author jh718.p...@samsung.com Date 2020-12-06 20:54:42 -0800 (Sun, 06 Dec 2020) Log Message Unreviewed. Remove the build warning below since r270414. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behaviors. * contentextensions/NFAToDFA.cpp: (WebCore::ContentExtensions::NFAToDFA::convert): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/contentextensions/NFAToDFA.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (270493 => 270494) --- trunk/Source/WebCore/ChangeLog 2020-12-07 04:31:48 UTC (rev 270493) +++ trunk/Source/WebCore/ChangeLog 2020-12-07 04:54:42 UTC (rev 270494) @@ -1,5 +1,15 @@ 2020-12-06 Joonghun Park +Unreviewed. Remove the build warning below since r270414. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behaviors. + +* contentextensions/NFAToDFA.cpp: +(WebCore::ContentExtensions::NFAToDFA::convert): + +2020-12-06 Joonghun Park + Unreviewed. Remove the build warnings below since r270400. warning: unused parameter ‘foo’ [-Wunused-parameter] Modified: trunk/Source/WebCore/contentextensions/NFAToDFA.cpp (270493 => 270494) --- trunk/Source/WebCore/contentextensions/NFAToDFA.cpp 2020-12-07 04:31:48 UTC (rev 270493) +++ trunk/Source/WebCore/contentextensions/NFAToDFA.cpp 2020-12-07 04:54:42 UTC (rev 270494) @@ -361,7 +361,7 @@ dfaSourceNode.setTransitions(transitionsStart, static_cast(transitionsLength)); } while (!unprocessedNodes.isEmpty()); -return WTFMove(dfa); +return dfa; } } // namespace ContentExtensions ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270493] trunk/Source/WebCore
Title: [270493] trunk/Source/WebCore Revision 270493 Author jh718.p...@samsung.com Date 2020-12-06 20:31:48 -0800 (Sun, 06 Dec 2020) Log Message Unreviewed. Remove the build warnings below since r270400. warning: unused parameter ‘foo’ [-Wunused-parameter] No new tests, no new behaviors. * platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp: (WebCore::GraphicsContextGLOpenGL::getActiveUniforms): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (270492 => 270493) --- trunk/Source/WebCore/ChangeLog 2020-12-07 03:03:36 UTC (rev 270492) +++ trunk/Source/WebCore/ChangeLog 2020-12-07 04:31:48 UTC (rev 270493) @@ -1,3 +1,13 @@ +2020-12-06 Joonghun Park + +Unreviewed. Remove the build warnings below since r270400. +warning: unused parameter ‘foo’ [-Wunused-parameter] + +No new tests, no new behaviors. + +* platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp: +(WebCore::GraphicsContextGLOpenGL::getActiveUniforms): + 2020-12-06 Simon Fraser Use WTF_MAKE_FAST_ALLOCATED for some scrolling-related objects Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp (270492 => 270493) --- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp 2020-12-07 03:03:36 UTC (rev 270492) +++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp 2020-12-07 04:31:48 UTC (rev 270493) @@ -2867,6 +2867,9 @@ return result; ::glGetActiveUniformsiv(program, uniformIndices.size(), uniformIndices.data(), pname, result.data()); +#else +UNUSED_PARAM(program); +UNUSED_PARAM(pname); #endif return result; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269762] trunk/Source/WebCore
Title: [269762] trunk/Source/WebCore Revision 269762 Author jh718.p...@samsung.com Date 2020-11-12 19:15:44 -0800 (Thu, 12 Nov 2020) Log Message Unreviewed. Fix the build warning below since r269753. warning: unused parameter ‘spacing’ [-Wunused-parameter] No new tests, no new behaviors. * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawPlatformPattern): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (269761 => 269762) --- trunk/Source/WebCore/ChangeLog 2020-11-13 00:34:07 UTC (rev 269761) +++ trunk/Source/WebCore/ChangeLog 2020-11-13 03:15:44 UTC (rev 269762) @@ -1,3 +1,13 @@ +2020-11-12 Joonghun Park + +Unreviewed. Fix the build warning below since r269753. +warning: unused parameter ‘spacing’ [-Wunused-parameter] + +No new tests, no new behaviors. + +* platform/graphics/cairo/GraphicsContextCairo.cpp: +(WebCore::GraphicsContext::drawPlatformPattern): + 2020-11-12 Sam Weinig Move more WebKitLegacy specific settings usage to WebPreferences.yaml Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp (269761 => 269762) --- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2020-11-13 00:34:07 UTC (rev 269761) +++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp 2020-11-13 03:15:44 UTC (rev 269762) @@ -661,6 +661,7 @@ return; ASSERT(hasPlatformContext()); +UNUSED_PARAM(spacing); Cairo::drawPattern(*platformContext(), image.get(), IntSize(imageSize), destRect, tileRect, patternTransform, phase, options); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269580] trunk/Source/WebKit
Title: [269580] trunk/Source/WebKit Revision 269580 Author jh718.p...@samsung.com Date 2020-11-09 02:30:41 -0800 (Mon, 09 Nov 2020) Log Message Unreviewed. Fix the build warning below since r269525. warning: control reaches end of non-void function [-Wreturn-type] No new tests, no new behaviors. * WebProcess/GPU/graphics/RemoteImageBufferProxy.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h Diff Modified: trunk/Source/WebKit/ChangeLog (269579 => 269580) --- trunk/Source/WebKit/ChangeLog 2020-11-09 10:20:55 UTC (rev 269579) +++ trunk/Source/WebKit/ChangeLog 2020-11-09 10:30:41 UTC (rev 269580) @@ -1,3 +1,12 @@ +2020-11-09 Joonghun Park + +Unreviewed. Fix the build warning below since r269525. +warning: control reaches end of non-void function [-Wreturn-type] + +No new tests, no new behaviors. + +* WebProcess/GPU/graphics/RemoteImageBufferProxy.h: + 2020-11-09 Zan Dobersek [WPE] ScrollGestureController should only handle complete touch interactions Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h (269579 => 269580) --- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2020-11-09 10:20:55 UTC (rev 269579) +++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h 2020-11-09 10:30:41 UTC (rev 269580) @@ -282,6 +282,10 @@ case WebCore::DisplayList::ItemType::StrokeLine: case WebCore::DisplayList::ItemType::Translate: RELEASE_ASSERT_NOT_REACHED(); +return nullptr; +default: +RELEASE_ASSERT_NOT_REACHED(); +return nullptr; } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268663] trunk/Source/WebCore
Title: [268663] trunk/Source/WebCore
Revision 268663
Author jh718.p...@samsung.com
Date 2020-10-18 20:51:24 -0700 (Sun, 18 Oct 2020)
Log Message
Unreviewed. Remove the duplicated IGNORE_WARNINGS_BEGIN("frame-address") calls from r268661.
No new tests, no new behaviors.
* domjit/JSDocumentDOMJIT.cpp:
(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (268662 => 268663)
--- trunk/Source/WebCore/ChangeLog 2020-10-19 03:45:59 UTC (rev 268662)
+++ trunk/Source/WebCore/ChangeLog 2020-10-19 03:51:24 UTC (rev 268663)
@@ -1,5 +1,14 @@
2020-10-18 Joonghun Park
+Unreviewed. Remove the duplicated IGNORE_WARNINGS_BEGIN("frame-address") calls from r268661.
+
+No new tests, no new behaviors.
+
+* domjit/JSDocumentDOMJIT.cpp:
+(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):
+
+2020-10-18 Joonghun Park
+
Unreviewed. Remove the build warning below since r267727.
warning: calling ‘void* __builtin_frame_address(unsigned int)’ with a nonzero argument is unsafe [-Wframe-address]
Modified: trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp (268662 => 268663)
--- trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp 2020-10-19 03:45:59 UTC (rev 268662)
+++ trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp 2020-10-19 03:51:24 UTC (rev 268663)
@@ -38,6 +38,8 @@
#include <_javascript_Core/Snippet.h>
#include <_javascript_Core/SnippetParams.h>
+IGNORE_WARNINGS_BEGIN("frame-address");
+
namespace WebCore {
using namespace JSC;
@@ -147,7 +149,6 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
-IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -158,7 +159,6 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
-IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -169,7 +169,6 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
-IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -180,7 +179,6 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
-IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -191,12 +189,13 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
-IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
}
-} }
+} } // namespace WebCore::DOMJIT
-#endif
+IGNORE_WARNINGS_END
+
+#endif // ENABLE(JIT)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268661] trunk/Source/WebCore
Title: [268661] trunk/Source/WebCore
Revision 268661
Author jh718.p...@samsung.com
Date 2020-10-18 20:05:46 -0700 (Sun, 18 Oct 2020)
Log Message
Unreviewed. Remove the build warning below since r267727.
warning: calling ‘void* __builtin_frame_address(unsigned int)’ with a nonzero argument is unsafe [-Wframe-address]
No new tests, no new behaviors.
* domjit/JSDocumentDOMJIT.cpp:
(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (268660 => 268661)
--- trunk/Source/WebCore/ChangeLog 2020-10-18 18:45:52 UTC (rev 268660)
+++ trunk/Source/WebCore/ChangeLog 2020-10-19 03:05:46 UTC (rev 268661)
@@ -1,3 +1,13 @@
+2020-10-18 Joonghun Park
+
+Unreviewed. Remove the build warning below since r267727.
+warning: calling ‘void* __builtin_frame_address(unsigned int)’ with a nonzero argument is unsafe [-Wframe-address]
+
+No new tests, no new behaviors.
+
+* domjit/JSDocumentDOMJIT.cpp:
+(WebCore::DOMJIT::JSC_DEFINE_JIT_OPERATION):
+
2020-10-18 Zalan Bujtas
[LFC][IFC][Quirk] No soft wrapping opportunity before/after image content when the root is a table cell
Modified: trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp (268660 => 268661)
--- trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp 2020-10-18 18:45:52 UTC (rev 268660)
+++ trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp 2020-10-19 03:05:46 UTC (rev 268661)
@@ -147,6 +147,7 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
+IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -157,6 +158,7 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
+IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -167,6 +169,7 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
+IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -177,6 +180,7 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
+IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
@@ -187,6 +191,7 @@
ASSERT(result);
ASSERT(globalObject);
JSC::VM& vm = globalObject->vm();
+IGNORE_WARNINGS_BEGIN("frame-address");
JSC::CallFrame* callFrame = DECLARE_CALL_FRAME(vm);
JSC::JITOperationPrologueCallFrameTracer tracer(vm, callFrame);
return DOMJIT::toWrapperSlowImpl(globalObject, result);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268449] trunk/Source/WebKit
Title: [268449] trunk/Source/WebKit Revision 268449 Author jh718.p...@samsung.com Date 2020-10-14 03:38:11 -0700 (Wed, 14 Oct 2020) Log Message Unreviewed. Fix the build warning below since r268312. warning: control reaches end of non-void function [-Wreturn-type] No new tests, no new behaviors. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::numberOfConnectedGamepadsForTesting): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebProcessPool.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (268448 => 268449) --- trunk/Source/WebKit/ChangeLog 2020-10-14 10:03:33 UTC (rev 268448) +++ trunk/Source/WebKit/ChangeLog 2020-10-14 10:38:11 UTC (rev 268449) @@ -1,5 +1,15 @@ 2020-10-14 Joonghun Park +Unreviewed. Fix the build warning below since r268312. +warning: control reaches end of non-void function [-Wreturn-type] + +No new tests, no new behaviors. + +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::numberOfConnectedGamepadsForTesting): + +2020-10-14 Joonghun Park + Unreviewed. Fix the build warning below since r33. warning: redundant move in return statement [-Wredundant-move] Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (268448 => 268449) --- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2020-10-14 10:03:33 UTC (rev 268448) +++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2020-10-14 10:38:11 UTC (rev 268449) @@ -1578,6 +1578,8 @@ case GamepadType::HID: case GamepadType::GameControllerFramework: return 0; +default: +return 0; #endif } #else ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268448] trunk/Source/WebKit
Title: [268448] trunk/Source/WebKit Revision 268448 Author jh718.p...@samsung.com Date 2020-10-14 03:03:33 -0700 (Wed, 14 Oct 2020) Log Message Unreviewed. Fix the build warning below since r33. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behaviors. * Shared/Gamepad/GamepadData.cpp: (WebKit::GamepadData::decode): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/Gamepad/GamepadData.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (268447 => 268448) --- trunk/Source/WebKit/ChangeLog 2020-10-14 09:33:24 UTC (rev 268447) +++ trunk/Source/WebKit/ChangeLog 2020-10-14 10:03:33 UTC (rev 268448) @@ -1,3 +1,13 @@ +2020-10-14 Joonghun Park + +Unreviewed. Fix the build warning below since r33. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behaviors. + +* Shared/Gamepad/GamepadData.cpp: +(WebKit::GamepadData::decode): + 2020-10-13 Julian Gonzalez Null dereference in PDFPlugin::snapshot() Modified: trunk/Source/WebKit/Shared/Gamepad/GamepadData.cpp (268447 => 268448) --- trunk/Source/WebKit/Shared/Gamepad/GamepadData.cpp 2020-10-14 09:33:24 UTC (rev 268447) +++ trunk/Source/WebKit/Shared/Gamepad/GamepadData.cpp 2020-10-14 10:03:33 UTC (rev 268448) @@ -81,7 +81,7 @@ if (!decoder.decode(data.m_lastUpdateTime)) return WTF::nullopt; -return WTFMove(data); +return data; } #if !LOG_DISABLED ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268172] trunk/Source/WebKit
Title: [268172] trunk/Source/WebKit Revision 268172 Author jh718.p...@samsung.com Date 2020-10-07 22:26:51 -0700 (Wed, 07 Oct 2020) Log Message Unreviewed. Remove the build warning below since r238330. warning: unused variable ‘connectionIdentifier’ [-Wunused-variable] No new tests, no new behaviors. * WebProcess/Inspector/WebInspectorUI.cpp: (WebKit::WebInspectorUI::updateConnection): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (268171 => 268172) --- trunk/Source/WebKit/ChangeLog 2020-10-08 04:56:46 UTC (rev 268171) +++ trunk/Source/WebKit/ChangeLog 2020-10-08 05:26:51 UTC (rev 268172) @@ -1,3 +1,13 @@ +2020-10-07 Joonghun Park + +Unreviewed. Remove the build warning below since r238330. +warning: unused variable ‘connectionIdentifier’ [-Wunused-variable] + +No new tests, no new behaviors. + +* WebProcess/Inspector/WebInspectorUI.cpp: +(WebKit::WebInspectorUI::updateConnection): + 2020-10-07 Keith Rollin Update post-processing rules for headers to not unnecessarily change timestamps Modified: trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp (268171 => 268172) --- trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2020-10-08 04:56:46 UTC (rev 268171) +++ trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2020-10-08 05:26:51 UTC (rev 268172) @@ -85,6 +85,7 @@ #if USE(UNIX_DOMAIN_SOCKETS) IPC::Connection::SocketPair socketPair = IPC::Connection::createPlatformConnection(); IPC::Connection::Identifier connectionIdentifier(socketPair.server); +UNUSED_PARAM(connectionIdentifier); IPC::Attachment connectionClientPort(socketPair.client); #elif OS(DARWIN) mach_port_t listeningPort = MACH_PORT_NULL; @@ -95,6 +96,7 @@ CRASH(); IPC::Connection::Identifier connectionIdentifier(listeningPort); +UNUSED_PARAM(connectionIdentifier); IPC::Attachment connectionClientPort(listeningPort, MACH_MSG_TYPE_MOVE_SEND); #elif PLATFORM(WIN) IPC::Connection::Identifier connectionIdentifier, connClient; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [267080] trunk/Source/JavaScriptCore
Title: [267080] trunk/Source/_javascript_Core
Revision 267080
Author jh718.p...@samsung.com
Date 2020-09-15 01:55:42 -0700 (Tue, 15 Sep 2020)
Log Message
Unreviewed. Remove the build warning below since r228533.
warning: ‘%40s’ directive argument is null [-Wformat-overflow=]
Since gcc which has version >= 9 is stricter about passing null string
pointers to printf-like functions, add null string pointer check
to fix the warning proactively.
* jsc.cpp:
(runJSC):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (267079 => 267080)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-15 07:13:51 UTC (rev 267079)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-15 08:55:42 UTC (rev 267080)
@@ -1,3 +1,15 @@
+2020-09-15 Joonghun Park
+
+Unreviewed. Remove the build warning below since r228533.
+warning: ‘%40s’ directive argument is null [-Wformat-overflow=]
+
+Since gcc which has version >= 9 is stricter about passing null string
+pointers to printf-like functions, add null string pointer check
+to fix the warning proactively.
+
+* jsc.cpp:
+(runJSC):
+
2020-09-14 Keith Miller
BytecodeParser should GetLocal op_ret's value even if it's unused by the caller
Modified: trunk/Source/_javascript_Core/jsc.cpp (267079 => 267080)
--- trunk/Source/_javascript_Core/jsc.cpp 2020-09-15 07:13:51 UTC (rev 267079)
+++ trunk/Source/_javascript_Core/jsc.cpp 2020-09-15 08:55:42 UTC (rev 267080)
@@ -3341,8 +3341,10 @@
for (auto& entry : compileTimeStats)
compileTimeKeys.append(entry.key);
std::sort(compileTimeKeys.begin(), compileTimeKeys.end());
-for (const CString& key : compileTimeKeys)
-printf("%40s: %.3lf ms\n", key.data(), compileTimeStats.get(key).milliseconds());
+for (const CString& key : compileTimeKeys) {
+if (key.data())
+printf("%40s: %.3lf ms\n", key.data(), compileTimeStats.get(key).milliseconds());
+}
if (Options::reportTotalPhaseTimes())
logTotalPhaseTimes();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266902] trunk/Source
Title: [266902] trunk/Source
Revision 266902
Author jh718.p...@samsung.com
Date 2020-09-10 17:41:50 -0700 (Thu, 10 Sep 2020)
Log Message
Unreviewed. Remove the build warning below since r266885.
warning: redundant move in return statement [-Wredundant-move]
Because return statement already returns rvalue reference,
we don't need WTFMove at return.
Source/_javascript_Core:
* inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::getBasicBlocks):
Source/WebCore:
No new tests, no new behaviors.
* inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getSupportedSystemFontFamilyNames):
* inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::requestClientNodes):
* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::getSupportedEventNames):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getSearchResults):
* inspector/agents/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
* inspector/agents/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
* inspector/agents/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
* inspector/agents/page/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::getLoggingChannels):
Source/WebKit:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::getSessionPermissions):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorDatabaseAgent.cpp
trunk/Source/WebCore/inspector/agents/InspectorLayerTreeAgent.cpp
trunk/Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266901 => 266902)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-11 00:32:46 UTC (rev 266901)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-11 00:41:50 UTC (rev 266902)
@@ -1,3 +1,15 @@
+2020-09-10 Joonghun Park
+
+Unreviewed. Remove the build warning below since r266885.
+warning: redundant move in return statement [-Wredundant-move]
+
+Because return statement already returns rvalue reference,
+we don't need WTFMove at return.
+
+* inspector/agents/InspectorRuntimeAgent.cpp:
+(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
+(Inspector::InspectorRuntimeAgent::getBasicBlocks):
+
2020-09-10 Alexey Shvayka
Promise.prototype.finally should perform PromiseResolve
Modified: trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp (266901 => 266902)
--- trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp 2020-09-11 00:32:46 UTC (rev 266901)
+++ trunk/Source/_javascript_Core/inspector/agents/InspectorRuntimeAgent.cpp 2020-09-11 00:41:50 UTC (rev 266902)
@@ -348,7 +348,7 @@
if (!savedResultIndex)
return makeUnexpected(errorString);
-return WTFMove(savedResultIndex);
+return savedResultIndex;
}
Protocol::ErrorStringOr InspectorRuntimeAgent::setSavedResultAlias(const String& savedResultAlias)
@@ -426,7 +426,7 @@
if (verbose)
dataLogF("Inspector::getRuntimeTypesForVariablesAtOffsets took %lfms\n", (end - start).milliseconds());
-return WTFMove(types);
+return types;
}
void InspectorRuntimeAgent::didCreateFrontendAndBackend(Inspector::FrontendRouter*, Inspector::BackendDispatcher*)
@@ -513,7 +513,7 @@
.release();
basicBlocks->addItem(WTFMove(location));
}
-return WTFMove(basicBlocks);
+return basicBlocks;
}
} // namespace Inspector
Modified: trunk/Source/WebCore/ChangeLog (266901 => 266902)
--- trunk/Source/WebCore/ChangeLog 2020-09-11 00:32:46 UTC (rev 266901)
+++ trunk/Source/WebCore/ChangeLog 2020-09-11 00:41:50 UTC (rev 266902)
@@ -1,3 +1,35 @@
+2020-09-10 Joonghun Park
+
+Unreviewed. Remove the build warning below since r266885.
+warning: redundant move in return statement [-Wredundant-move]
+
+Because return statement already returns rvalue reference,
+we don't need WTFMove at return.
+
+No new tests, no new
[webkit-changes] [266694] trunk/Source/JavaScriptCore
Title: [266694] trunk/Source/_javascript_Core
Revision 266694
Author jh718.p...@samsung.com
Date 2020-09-07 01:28:41 -0700 (Mon, 07 Sep 2020)
Log Message
Unreviewed. Remove the build warning below since r266567.
warning: parameter ‘hint’ set but not used [-Wunused-but-set-parameter]
* runtime/JSObject.cpp:
(JSC::callToPrimitiveFunction):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (266693 => 266694)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-07 06:19:36 UTC (rev 266693)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-07 08:28:41 UTC (rev 266694)
@@ -1,3 +1,11 @@
+2020-09-07 Joonghun Park
+
+Unreviewed. Remove the build warning below since r266567.
+warning: parameter ‘hint’ set but not used [-Wunused-but-set-parameter]
+
+* runtime/JSObject.cpp:
+(JSC::callToPrimitiveFunction):
+
2020-09-06 Darin Adler
TextCodec refinements
Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (266693 => 266694)
--- trunk/Source/_javascript_Core/runtime/JSObject.cpp 2020-09-07 06:19:36 UTC (rev 266693)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp 2020-09-07 08:28:41 UTC (rev 266694)
@@ -2197,6 +2197,8 @@
break;
}
callArgs.append(hintString);
+} else {
+UNUSED_PARAM(hint);
}
ASSERT(!callArgs.hasOverflowed());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266373] trunk/Source/WebCore
Title: [266373] trunk/Source/WebCore Revision 266373 Author jh718.p...@samsung.com Date 2020-08-31 16:19:19 -0700 (Mon, 31 Aug 2020) Log Message Unreviewed. Remove the unused variable build warning since r238538. No new tests, no new behaviors. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLImageElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (266372 => 266373) --- trunk/Source/WebCore/ChangeLog 2020-08-31 23:16:18 UTC (rev 266372) +++ trunk/Source/WebCore/ChangeLog 2020-08-31 23:19:19 UTC (rev 266373) @@ -1,3 +1,12 @@ +2020-08-31 Joonghun Park + +Unreviewed. Remove the unused variable build warning since r238538. + +No new tests, no new behaviors. + +* html/HTMLImageElement.cpp: +(WebCore::HTMLImageElement::copyNonAttributePropertiesFromElement): + 2020-08-31 James Darpinian Implement WEBGL_compressed_texture_s3tc_srgb extension Modified: trunk/Source/WebCore/html/HTMLImageElement.cpp (266372 => 266373) --- trunk/Source/WebCore/html/HTMLImageElement.cpp 2020-08-31 23:16:18 UTC (rev 266372) +++ trunk/Source/WebCore/html/HTMLImageElement.cpp 2020-08-31 23:19:19 UTC (rev 266373) @@ -814,6 +814,8 @@ auto& sourceImage = static_cast(source); #if ENABLE(ATTACHMENT_ELEMENT) m_pendingClonedAttachmentID = !sourceImage.m_pendingClonedAttachmentID.isEmpty() ? sourceImage.m_pendingClonedAttachmentID : sourceImage.attachmentIdentifier(); +#else +UNUSED_PARAM(sourceImage); #endif Element::copyNonAttributePropertiesFromElement(source); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266253] trunk
Title: [266253] trunk
Revision 266253
Author jh718.p...@samsung.com
Date 2020-08-27 14:10:20 -0700 (Thu, 27 Aug 2020)
Log Message
Implement @supports selector().
https://bugs.webkit.org/show_bug.cgi?id=199237
Reviewed by Antti Koivisto.
This feature allows authors to test if the browser supports the tested selector syntax.
The corresponding spec is https://drafts.csswg.org/css-conditional-4/#at-supports-ext.
And unknown -webkit- pseudo elements are not supported according to the spec,
https://drafts.csswg.org/css-conditional-4/#support-definition-ext.
LayoutTests/imported/w3c:
* web-platform-tests/css/cssom/CSS-expected.txt:
Source/WebCore:
Tests: css3/conditional/w3c/at-supports-040.html
css3/conditional/w3c/at-supports-041.html
css3/conditional/w3c/at-supports-042.html
* css/CSSValueKeywords.in:
* css/parser/CSSParserImpl.h:
(WebCore::CSSParserImpl::context const):
* css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::supportsComplexSelector):
(WebCore::CSSSelectorParser::containsUnknownWebKitPseudoElements):
* css/parser/CSSSupportsParser.cpp:
(WebCore::CSSSupportsParser::supportsCondition):
(WebCore::CSSSupportsParser::consumeCondition):
(WebCore::CSSSupportsParser::consumeNegation):
(WebCore::CSSSupportsParser::consumeSupportsFeatureOrGeneralEnclosed):
(WebCore::CSSSupportsParser::consumeSupportsSelectorFunction):
(WebCore::CSSSupportsParser::consumeConditionInParenthesis):
(WebCore::CSSSupportsParser::consumeDeclarationConditionOrGeneralEnclosed): Deleted.
* css/parser/CSSSupportsParser.h:
LayoutTests:
* css3/conditional/w3c/at-supports-040-expected.html: Added.
* css3/conditional/w3c/at-supports-040.html: Added.
* css3/conditional/w3c/at-supports-041-expected.html: Added.
* css3/conditional/w3c/at-supports-041.html: Added.
* css3/conditional/w3c/at-supports-042-expected.html: Added.
* css3/conditional/w3c/at-supports-042.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/CSS-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/parser/CSSParserImpl.h
trunk/Source/WebCore/css/parser/CSSSelectorParser.cpp
trunk/Source/WebCore/css/parser/CSSSupportsParser.cpp
trunk/Source/WebCore/css/parser/CSSSupportsParser.h
Added Paths
trunk/LayoutTests/css3/conditional/w3c/at-supports-040-expected.html
trunk/LayoutTests/css3/conditional/w3c/at-supports-040.html
trunk/LayoutTests/css3/conditional/w3c/at-supports-041-expected.html
trunk/LayoutTests/css3/conditional/w3c/at-supports-041.html
trunk/LayoutTests/css3/conditional/w3c/at-supports-042-expected.html
trunk/LayoutTests/css3/conditional/w3c/at-supports-042.html
Diff
Modified: trunk/LayoutTests/ChangeLog (266252 => 266253)
--- trunk/LayoutTests/ChangeLog 2020-08-27 21:02:09 UTC (rev 266252)
+++ trunk/LayoutTests/ChangeLog 2020-08-27 21:10:20 UTC (rev 266253)
@@ -1,3 +1,23 @@
+2020-08-27 Joonghun Park
+
+Implement @supports selector().
+https://bugs.webkit.org/show_bug.cgi?id=199237
+
+Reviewed by Antti Koivisto.
+
+This feature allows authors to test if the browser supports the tested selector syntax.
+The corresponding spec is https://drafts.csswg.org/css-conditional-4/#at-supports-ext.
+
+And unknown -webkit- pseudo elements are not supported according to the spec,
+https://drafts.csswg.org/css-conditional-4/#support-definition-ext.
+
+* css3/conditional/w3c/at-supports-040-expected.html: Added.
+* css3/conditional/w3c/at-supports-040.html: Added.
+* css3/conditional/w3c/at-supports-041-expected.html: Added.
+* css3/conditional/w3c/at-supports-041.html: Added.
+* css3/conditional/w3c/at-supports-042-expected.html: Added.
+* css3/conditional/w3c/at-supports-042.html: Added.
+
2020-08-27 Wenson Hsieh
Occasional crashes when restoring replaced text under Editor::changeBackToReplacedString
Added: trunk/LayoutTests/css3/conditional/w3c/at-supports-040-expected.html (0 => 266253)
--- trunk/LayoutTests/css3/conditional/w3c/at-supports-040-expected.html (rev 0)
+++ trunk/LayoutTests/css3/conditional/w3c/at-supports-040-expected.html 2020-08-27 21:10:20 UTC (rev 266253)
@@ -0,0 +1,18 @@
+
+
+
+ CSS Reftest Reference
+
+ div {
+background-color:green;
+height:100px;
+width:100px;
+ }
+
+
+
+ Test passes if there is a filled green square and no red.
+
+
+
Added: trunk/LayoutTests/css3/conditional/w3c/at-supports-040.html (0 => 266253)
--- trunk/LayoutTests/css3/conditional/w3c/at-supports-040.html (rev 0)
+++ trunk/LayoutTests/css3/conditional/w3c/at-supports-040.html 2020-08-27 21:10:20 UTC (rev 266253)
@@ -0,0 +1,18 @@
+
+CSS Conditional Test: @supports selector() with pseudo-elements.
+
+
+ div {
+background-color:red;
+height:100px;
+
[webkit-changes] [265407] trunk/Source/WTF
Title: [265407] trunk/Source/WTF
Revision 265407
Author jh718.p...@samsung.com
Date 2020-08-08 03:54:01 -0700 (Sat, 08 Aug 2020)
Log Message
[WTF] Remove the build warning since r265344.
https://bugs.webkit.org/show_bug.cgi?id=215269
warning: parameter ‘integer’ set but not used [-Wunused-but-set-parameter]
* wtf/text/IntegerToStringConversion.h:
(WTF::lengthOfIntegerAsString):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/IntegerToStringConversion.h
Diff
Modified: trunk/Source/WTF/ChangeLog (265406 => 265407)
--- trunk/Source/WTF/ChangeLog 2020-08-08 10:37:04 UTC (rev 265406)
+++ trunk/Source/WTF/ChangeLog 2020-08-08 10:54:01 UTC (rev 265407)
@@ -1,3 +1,13 @@
+2020-08-08 Joonghun Park
+
+[WTF] Remove the build warning since r265344.
+https://bugs.webkit.org/show_bug.cgi?id=215269
+
+warning: parameter ‘integer’ set but not used [-Wunused-but-set-parameter]
+
+* wtf/text/IntegerToStringConversion.h:
+(WTF::lengthOfIntegerAsString):
+
2020-08-07 John Wilander
Experimental: Cap the expiry of persistent cookies set in 3rd-party CNAME cloaked HTTP responses
Modified: trunk/Source/WTF/wtf/text/IntegerToStringConversion.h (265406 => 265407)
--- trunk/Source/WTF/wtf/text/IntegerToStringConversion.h 2020-08-08 10:37:04 UTC (rev 265406)
+++ trunk/Source/WTF/wtf/text/IntegerToStringConversion.h 2020-08-08 10:54:01 UTC (rev 265407)
@@ -115,8 +115,10 @@
inline unsigned lengthOfIntegerAsString(IntegerType integer)
{
static_assert(std::is_integral_v);
-if constexpr (std::is_same_v)
+if constexpr (std::is_same_v) {
+UNUSED_PARAM(integer);
return 1;
+}
else if constexpr (std::is_signed_v) {
if (integer < 0)
return lengthOfIntegerAsStringImpl, NegativeNumber>(-integer);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [265182] trunk/Source/WebCore
Title: [265182] trunk/Source/WebCore Revision 265182 Author jh718.p...@samsung.com Date 2020-08-01 18:50:08 -0700 (Sat, 01 Aug 2020) Log Message Unreviewed. Remove the build warnings below since r265150. warning: unused parameter ‘foo’ [-Wunused-parameter] No new tests, no new behaviors. * workers/service/server/SWServerJobQueue.cpp: (WebCore::doCertificatesMatch): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (265181 => 265182) --- trunk/Source/WebCore/ChangeLog 2020-08-02 01:18:20 UTC (rev 265181) +++ trunk/Source/WebCore/ChangeLog 2020-08-02 01:50:08 UTC (rev 265182) @@ -1,3 +1,13 @@ +2020-08-01 Joonghun Park + +Unreviewed. Remove the build warnings below since r265150. +warning: unused parameter ‘foo’ [-Wunused-parameter] + +No new tests, no new behaviors. + +* workers/service/server/SWServerJobQueue.cpp: +(WebCore::doCertificatesMatch): + 2020-08-01 Brady Eidson Special HID mapping for the Google Stadia controller Modified: trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp (265181 => 265182) --- trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp 2020-08-02 01:18:20 UTC (rev 265181) +++ trunk/Source/WebCore/workers/service/server/SWServerJobQueue.cpp 2020-08-02 01:50:08 UTC (rev 265182) @@ -63,6 +63,8 @@ return first.trust() == second.trust() || certificatesMatch(first.trust(), second.trust()); #else // FIXME: Add support for certificate matching in CertificateInfo. +UNUSED_PARAM(first); +UNUSED_PARAM(second); return true; #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [265075] trunk/Source/WebCore
Title: [265075] trunk/Source/WebCore
Revision 265075
Author jh718.p...@samsung.com
Date 2020-07-29 22:43:26 -0700 (Wed, 29 Jul 2020)
Log Message
Unreviewed. Remove the build warning below since r265062.
warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]
No new tests, no new behaviors.
* Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::copyFromChannel):
(WebCore::AudioBuffer::copyToChannel):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (265074 => 265075)
--- trunk/Source/WebCore/ChangeLog 2020-07-30 04:42:46 UTC (rev 265074)
+++ trunk/Source/WebCore/ChangeLog 2020-07-30 05:43:26 UTC (rev 265075)
@@ -1,3 +1,14 @@
+2020-07-29 Joonghun Park
+
+Unreviewed. Remove the build warning below since r265062.
+warning: comparison of unsigned _expression_ < 0 is always false [-Wtype-limits]
+
+No new tests, no new behaviors.
+
+* Modules/webaudio/AudioBuffer.cpp:
+(WebCore::AudioBuffer::copyFromChannel):
+(WebCore::AudioBuffer::copyToChannel):
+
2020-07-29 Jer Noble
Support HDR decode in SW VP9
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp (265074 => 265075)
--- trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp 2020-07-30 04:42:46 UTC (rev 265074)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp 2020-07-30 05:43:26 UTC (rev 265075)
@@ -130,7 +130,7 @@
if (destination->isShared())
return Exception { TypeError, "Destination may not be a shared buffer."_s };
-if (channelNumber < 0 || channelNumber >= m_channels.size())
+if (channelNumber >= m_channels.size())
return Exception { IndexSizeError, "Not a valid channelNumber."_s };
Float32Array* channelData = m_channels[channelNumber].get();
@@ -158,7 +158,7 @@
if (source->isShared())
return Exception { TypeError, "Source may not be a shared buffer."_s };
-if (channelNumber < 0 || channelNumber >= m_channels.size())
+if (channelNumber >= m_channels.size())
return Exception { IndexSizeError, "Not a valid channelNumber."_s };
Float32Array* channelData = m_channels[channelNumber].get();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264510] trunk/Source/WebCore
Title: [264510] trunk/Source/WebCore Revision 264510 Author jh718.p...@samsung.com Date 2020-07-17 08:37:10 -0700 (Fri, 17 Jul 2020) Log Message Unreviewed. Remove the build warning below since r264280. warning: redundant move in return statement [-Wredundant-move] No new tests, no new behaviors. * platform/graphics/Gradient.h: (WebCore::Gradient::decode): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Gradient.h Diff Modified: trunk/Source/WebCore/ChangeLog (264509 => 264510) --- trunk/Source/WebCore/ChangeLog 2020-07-17 15:23:34 UTC (rev 264509) +++ trunk/Source/WebCore/ChangeLog 2020-07-17 15:37:10 UTC (rev 264510) @@ -1,5 +1,15 @@ 2020-07-17 Joonghun Park +Unreviewed. Remove the build warning below since r264280. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behaviors. + +* platform/graphics/Gradient.h: +(WebCore::Gradient::decode): + +2020-07-17 Joonghun Park + Unreviewed. Remove the build warning below and redundant spaces since r264381. warning: this statement may fall through [-Wimplicit-fallthrough=] Modified: trunk/Source/WebCore/platform/graphics/Gradient.h (264509 => 264510) --- trunk/Source/WebCore/platform/graphics/Gradient.h 2020-07-17 15:23:34 UTC (rev 264509) +++ trunk/Source/WebCore/platform/graphics/Gradient.h 2020-07-17 15:37:10 UTC (rev 264510) @@ -313,7 +313,7 @@ return WTF::nullopt; gradient->setGradientSpaceTransform(WTFMove(*gradientSpaceTransformation)); -return WTFMove(gradient); +return gradient; } } // namespace WebCore ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264509] trunk/Source/WebCore
Title: [264509] trunk/Source/WebCore
Revision 264509
Author jh718.p...@samsung.com
Date 2020-07-17 08:23:34 -0700 (Fri, 17 Jul 2020)
Log Message
Unreviewed. Remove the build warning below and redundant spaces since r264381.
warning: this statement may fall through [-Wimplicit-fallthrough=]
No new tests, no new behaviors.
* html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (264508 => 264509)
--- trunk/Source/WebCore/ChangeLog 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/ChangeLog 2020-07-17 15:23:34 UTC (rev 264509)
@@ -1,5 +1,18 @@
2020-07-17 Joonghun Park
+Unreviewed. Remove the build warning below and redundant spaces since r264381.
+warning: this statement may fall through [-Wimplicit-fallthrough=]
+
+No new tests, no new behaviors.
+
+* html/canvas/WebGL2RenderingContext.cpp:
+(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
+* html/canvas/WebGLRenderingContextBase.cpp:
+(WebCore::WebGLRenderingContextBase::getVertexAttrib):
+(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
+
+2020-07-17 Joonghun Park
+
Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move]
Modified: trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp (264508 => 264509)
--- trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/html/canvas/WebGL2RenderingContext.cpp 2020-07-17 15:23:34 UTC (rev 264509)
@@ -1611,7 +1611,7 @@
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "vertexAttribI4iv", "no array");
return;
}
-
+
int size = list.length();
if (size < 4) {
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, "vertexAttribI4iv", "array too small");
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp (264508 => 264509)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-07-17 14:34:39 UTC (rev 264508)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp 2020-07-17 15:23:34 UTC (rev 264509)
@@ -3601,7 +3601,7 @@
return state.originalStride;
case GraphicsContextGL::VERTEX_ATTRIB_ARRAY_TYPE:
return state.type;
-case GraphicsContextGL::CURRENT_VERTEX_ATTRIB:
+case GraphicsContextGL::CURRENT_VERTEX_ATTRIB: {
switch (m_vertexAttribValue[index].type) {
case GraphicsContextGL::FLOAT:
return Float32Array::tryCreate(m_vertexAttribValue[index].fValue, 4);
@@ -3609,7 +3609,12 @@
return Int32Array::tryCreate(m_vertexAttribValue[index].iValue, 4);
case GraphicsContextGL::UNSIGNED_INT:
return Uint32Array::tryCreate(m_vertexAttribValue[index].uiValue, 4);
+default:
+ASSERT_NOT_REACHED();
+break;
}
+return nullptr;
+}
default:
synthesizeGLError(GraphicsContextGL::INVALID_ENUM, "getVertexAttrib", "invalid parameter name");
return nullptr;
@@ -7007,7 +7012,7 @@
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, functionName, "no array");
return;
}
-
+
int size = list.length();
if (size < expectedSize) {
synthesizeGLError(GraphicsContextGL::INVALID_VALUE, functionName, "invalid size");
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264508] trunk/Source/WebCore
Title: [264508] trunk/Source/WebCore
Revision 264508
Author jh718.p...@samsung.com
Date 2020-07-17 07:34:39 -0700 (Fri, 17 Jul 2020)
Log Message
Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move]
No new tests, no new behaviors.
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::create):
(WebCore::PannerNode::PannerNode):
* Modules/webaudio/PannerNode.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioNode.h
trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp
trunk/Source/WebCore/Modules/webaudio/PannerNode.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (264507 => 264508)
--- trunk/Source/WebCore/ChangeLog 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/ChangeLog 2020-07-17 14:34:39 UTC (rev 264508)
@@ -1,3 +1,16 @@
+2020-07-17 Joonghun Park
+
+Remove the build warning below and redundant spaces since r263985.
+warning: redundant move in return statement [-Wredundant-move]
+
+No new tests, no new behaviors.
+
+* Modules/webaudio/AudioNode.h:
+* Modules/webaudio/PannerNode.cpp:
+(WebCore::PannerNode::create):
+(WebCore::PannerNode::PannerNode):
+* Modules/webaudio/PannerNode.h:
+
2020-07-16 Rob Buis
Make DocumentParser.ParserState an enum class
Modified: trunk/Source/WebCore/Modules/webaudio/AudioNode.h (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/AudioNode.h 2020-07-17 14:34:39 UTC (rev 264508)
@@ -210,10 +210,10 @@
volatile bool m_isInitialized { false };
NodeType m_nodeType { NodeTypeUnknown };
Ref m_context;
-
+
// FIXME: Remove m_sampleRate once old constructor is removed.
float m_sampleRate;
-
+
Vector> m_inputs;
Vector> m_outputs;
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp 2020-07-17 14:34:39 UTC (rev 264508)
@@ -97,32 +97,32 @@
auto result = panner->setMaxDistance(options.maxDistance);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setRefDistance(options.refDistance);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setRolloffFactor(options.rolloffFactor);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setConeOuterGain(options.coneOuterGain);
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelCount(options.channelCount.valueOr(2));
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelCountMode(options.channelCountMode.valueOr(ChannelCountMode::ClampedMax));
if (result.hasException())
return result.releaseException();
-
+
result = panner->setChannelInterpretation(options.channelInterpretation.valueOr(ChannelInterpretation::Speakers));
if (result.hasException())
return result.releaseException();
-
-return WTFMove(panner);
+
+return panner;
}
PannerNode::PannerNode(BaseAudioContext& context, const PannerOptions& options)
@@ -143,10 +143,10 @@
setConeInnerAngle(options.coneInnerAngle);
setConeOuterAngle(options.coneOuterAngle);
setNodeType(NodeTypePanner);
-
+
addInput(makeUnique(this));
addOutput(makeUnique(this, 2));
-
+
initialize();
}
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.h (264507 => 264508)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2020-07-17 14:29:30 UTC (rev 264507)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.h 2020-07-17 14:34:39 UTC (rev 264508)
@@ -51,7 +51,7 @@
virtual float dopplerRate() = 0;
protected:
-
+
// FIXME: Remove once dependencies on old constructor are removed
PannerNodeBase(BaseAudioContext&, float sampleRate);
PannerNodeBase(BaseAudioContext&);
@@ -72,9 +72,9 @@
{
return adoptRef(*new PannerNode(context, sampleRate));
}
-
+
static ExceptionOr> create(BaseAudioContext&, const PannerOptions& = { });
-
+
virtual ~PannerNode();
// AudioNode
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263228] trunk/Tools
Title: [263228] trunk/Tools
Revision 263228
Author jh718.p...@samsung.com
Date 2020-06-18 13:54:44 -0700 (Thu, 18 Jun 2020)
Log Message
Unreviewed. Remove the build warning below since r262971.
warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
* WebKitTestRunner/TestController.cpp:
(WTR::getAllStorageAccessEntriesCallback):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp
Diff
Modified: trunk/Tools/ChangeLog (263227 => 263228)
--- trunk/Tools/ChangeLog 2020-06-18 20:48:50 UTC (rev 263227)
+++ trunk/Tools/ChangeLog 2020-06-18 20:54:44 UTC (rev 263228)
@@ -1,3 +1,11 @@
+2020-06-18 Joonghun Park
+
+Unreviewed. Remove the build warning below since r262971.
+warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::getAllStorageAccessEntriesCallback):
+
2020-06-18 Ross Kirsling
[Intl] Enable RelativeTimeFormat and Locale by default
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (263227 => 263228)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-06-18 20:48:50 UTC (rev 263227)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-06-18 20:54:44 UTC (rev 263228)
@@ -3185,7 +3185,7 @@
auto* context = static_cast(userData);
Vector resultDomains;
-for (int i = 0; i < WKArrayGetSize(domainList); i++) {
+for (unsigned i = 0; i < WKArrayGetSize(domainList); i++) {
auto domain = reinterpret_cast(WKArrayGetItemAtIndex(domainList, i));
auto buffer = std::vector(WKStringGetMaximumUTF8CStringSize(domain));
auto stringLength = WKStringGetUTF8CString(domain, buffer.data(), buffer.size());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260896] trunk/Source/WebCore
Title: [260896] trunk/Source/WebCore
Revision 260896
Author jh718.p...@samsung.com
Date 2020-04-29 07:55:55 -0700 (Wed, 29 Apr 2020)
Log Message
Unreviewed. Remove no longer used variable and the build warning below.
warning: unused variable ‘view’ [-Wunused-variable]
No new tests, no new behaviour changes.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (260895 => 260896)
--- trunk/Source/WebCore/ChangeLog 2020-04-29 14:49:03 UTC (rev 260895)
+++ trunk/Source/WebCore/ChangeLog 2020-04-29 14:55:55 UTC (rev 260896)
@@ -1,3 +1,13 @@
+2020-04-29 Joonghun Park
+
+Unreviewed. Remove no longer used variable and the build warning below.
+warning: unused variable ‘view’ [-Wunused-variable]
+
+No new tests, no new behaviour changes.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleMousePressEvent):
+
2020-04-29 Alicia Boya García
PlatformMediaResourceLoader should be destroyed on the main thread
Modified: trunk/Source/WebCore/page/EventHandler.cpp (260895 => 260896)
--- trunk/Source/WebCore/page/EventHandler.cpp 2020-04-29 14:49:03 UTC (rev 260895)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2020-04-29 14:55:55 UTC (rev 260896)
@@ -1786,16 +1786,14 @@
return false;
}
-if (FrameView* view = m_frame.view()) {
-RenderLayer* layer = m_clickNode->renderer() ? m_clickNode->renderer()->enclosingLayer() : nullptr;
-auto localPoint = roundedIntPoint(mouseEvent.hitTestResult().localPoint());
-if (layer && layer->isPointInResizeControl(localPoint)) {
-layer->setInResizeMode(true);
-m_resizeLayer = layer;
-m_offsetFromResizeCorner = layer->offsetFromResizeCorner(localPoint);
-invalidateClick();
-return true;
-}
+RenderLayer* layer = m_clickNode->renderer() ? m_clickNode->renderer()->enclosingLayer() : nullptr;
+auto localPoint = roundedIntPoint(mouseEvent.hitTestResult().localPoint());
+if (layer && layer->isPointInResizeControl(localPoint)) {
+layer->setInResizeMode(true);
+m_resizeLayer = layer;
+m_offsetFromResizeCorner = layer->offsetFromResizeCorner(localPoint);
+invalidateClick();
+return true;
}
m_frame.selection().setCaretBlinkingSuspended(true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260727] trunk/Source/WTF
Title: [260727] trunk/Source/WTF
Revision 260727
Author jh718.p...@samsung.com
Date 2020-04-26 11:55:20 -0700 (Sun, 26 Apr 2020)
Log Message
[WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
https://bugs.webkit.org/show_bug.cgi?id=211044
Reviewed by Darin Adler.
* wtf/URL.cpp:
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (260726 => 260727)
--- trunk/Source/WTF/ChangeLog 2020-04-26 16:34:24 UTC (rev 260726)
+++ trunk/Source/WTF/ChangeLog 2020-04-26 18:55:20 UTC (rev 260727)
@@ -1,3 +1,16 @@
+2020-04-26 Joonghun Park
+
+[WTF] Workaround gcc bug for unsigned bitfield related usual arithmetic conversions
+https://bugs.webkit.org/show_bug.cgi?id=211044
+
+Reviewed by Darin Adler.
+
+* wtf/URL.cpp:
+(WTF::URL::setHost):
+(WTF::URL::setHostAndPort):
+(WTF::URL::setUser):
+(WTF::URL::setPassword):
+
2020-04-25 Joonghun Park
Unreviewed. Remove the bulid warnings below since r260707.
Modified: trunk/Source/WTF/wtf/URL.cpp (260726 => 260727)
--- trunk/Source/WTF/wtf/URL.cpp 2020-04-26 16:34:24 UTC (rev 260726)
+++ trunk/Source/WTF/wtf/URL.cpp 2020-04-26 18:55:20 UTC (rev 260727)
@@ -436,7 +436,7 @@
if (!appendEncodedHostname(encodedHostName, newHost))
return;
-bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
+bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
parse(makeString(
StringView(m_string).left(hostStart()),
slashSlashNeeded ? "//" : "",
@@ -486,7 +486,7 @@
if (!appendEncodedHostname(encodedHostName, hostName))
return;
-bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
+bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
parse(makeString(
StringView(m_string).left(hostStart()),
slashSlashNeeded ? "//" : "",
@@ -547,7 +547,7 @@
unsigned end = m_userEnd;
if (!newUser.isEmpty()) {
-bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
+bool slashSlashNeeded = m_userStart == m_schemeEnd + 1U;
bool needSeparator = end == m_hostEnd || (end == m_passwordEnd && m_string[end] != '@');
parse(makeString(
StringView(m_string).left(m_userStart),
@@ -570,7 +570,7 @@
return;
if (!newPassword.isEmpty()) {
-bool needLeadingSlashes = m_userEnd == static_cast(m_schemeEnd + 1);
+bool needLeadingSlashes = m_userEnd == m_schemeEnd + 1U;
parse(makeString(
StringView(m_string).left(m_userEnd),
needLeadingSlashes ? "//:" : ":",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260715] trunk/Source/WTF
Title: [260715] trunk/Source/WTF
Revision 260715
Author jh718.p...@samsung.com
Date 2020-04-25 18:01:52 -0700 (Sat, 25 Apr 2020)
Log Message
Unreviewed. Remove the bulid warnings below since r260707.
warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
* wtf/URL.cpp:
(WTF::URL::setHost):
(WTF::URL::setHostAndPort):
(WTF::URL::setUser):
(WTF::URL::setPassword):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/URL.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (260714 => 260715)
--- trunk/Source/WTF/ChangeLog 2020-04-26 00:31:57 UTC (rev 260714)
+++ trunk/Source/WTF/ChangeLog 2020-04-26 01:01:52 UTC (rev 260715)
@@ -1,3 +1,14 @@
+2020-04-25 Joonghun Park
+
+Unreviewed. Remove the bulid warnings below since r260707.
+warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
+
+* wtf/URL.cpp:
+(WTF::URL::setHost):
+(WTF::URL::setHostAndPort):
+(WTF::URL::setUser):
+(WTF::URL::setPassword):
+
2020-04-25 Darin Adler
[Cocoa] Deal with another round of Xcode upgrade checks
Modified: trunk/Source/WTF/wtf/URL.cpp (260714 => 260715)
--- trunk/Source/WTF/wtf/URL.cpp 2020-04-26 00:31:57 UTC (rev 260714)
+++ trunk/Source/WTF/wtf/URL.cpp 2020-04-26 01:01:52 UTC (rev 260715)
@@ -436,7 +436,7 @@
if (!appendEncodedHostname(encodedHostName, newHost))
return;
-bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
parse(makeString(
StringView(m_string).left(hostStart()),
slashSlashNeeded ? "//" : "",
@@ -486,7 +486,7 @@
if (!appendEncodedHostname(encodedHostName, hostName))
return;
-bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
parse(makeString(
StringView(m_string).left(hostStart()),
slashSlashNeeded ? "//" : "",
@@ -547,7 +547,7 @@
unsigned end = m_userEnd;
if (!newUser.isEmpty()) {
-bool slashSlashNeeded = m_userStart == m_schemeEnd + 1;
+bool slashSlashNeeded = m_userStart == static_cast(m_schemeEnd + 1);
bool needSeparator = end == m_hostEnd || (end == m_passwordEnd && m_string[end] != '@');
parse(makeString(
StringView(m_string).left(m_userStart),
@@ -570,7 +570,7 @@
return;
if (!newPassword.isEmpty()) {
-bool needLeadingSlashes = m_userEnd == m_schemeEnd + 1;
+bool needLeadingSlashes = m_userEnd == static_cast(m_schemeEnd + 1);
parse(makeString(
StringView(m_string).left(m_userEnd),
needLeadingSlashes ? "//:" : ":",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260699] trunk/Source/WebCore
Title: [260699] trunk/Source/WebCore
Revision 260699
Author jh718.p...@samsung.com
Date 2020-04-25 05:05:59 -0700 (Sat, 25 Apr 2020)
Log Message
Unreviewed. Remove the build warning below since r260247.
warning: unused parameter ‘foo’ [-Wunused-parameter]
No new tests, no new behaviors.
* testing/Internals.cpp:
(WebCore::Internals::hasSandboxIOKitOpenAccessToClass):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (260698 => 260699)
--- trunk/Source/WebCore/ChangeLog 2020-04-25 09:23:30 UTC (rev 260698)
+++ trunk/Source/WebCore/ChangeLog 2020-04-25 12:05:59 UTC (rev 260699)
@@ -1,3 +1,13 @@
+2020-04-25 Joonghun Park
+
+Unreviewed. Remove the build warning below since r260247.
+warning: unused parameter ‘foo’ [-Wunused-parameter]
+
+No new tests, no new behaviors.
+
+* testing/Internals.cpp:
+(WebCore::Internals::hasSandboxIOKitOpenAccessToClass):
+
2020-04-24 Chris Dumez
[iOS] Unable to sign up on twitter.com
Modified: trunk/Source/WebCore/testing/Internals.cpp (260698 => 260699)
--- trunk/Source/WebCore/testing/Internals.cpp 2020-04-25 09:23:30 UTC (rev 260698)
+++ trunk/Source/WebCore/testing/Internals.cpp 2020-04-25 12:05:59 UTC (rev 260699)
@@ -5628,6 +5628,8 @@
bool Internals::hasSandboxIOKitOpenAccessToClass(const String& process, const String& ioKitClass)
{
+UNUSED_PARAM(process);
+UNUSED_PARAM(ioKitClass);
return false;
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [260014] trunk/Source
Title: [260014] trunk/Source Revision 260014 Author jh718.p...@samsung.com Date 2020-04-13 09:40:04 -0700 (Mon, 13 Apr 2020) Log Message Unreviewed. Remove redundant move in return statement. Return statement already returns rvalue, so we don't need move here. This patch removes the build warning below since r259922. warning: redundant move in return statement [-Wredundant-move] Source/WebCore: No new tests, no new behaviours. * page/csp/ContentSecurityPolicyResponseHeaders.h: (WebCore::ContentSecurityPolicyResponseHeaders::decode): * platform/network/cf/CertificateInfoCFNet.cpp: (WTF::Persistence::decodeSecTrustRef): Source/WebKit: * NetworkProcess/cache/NetworkCacheCoders.cpp: (WTF::Persistence::Coder::decode): Source/WTF: * wtf/persistence/PersistentCoders.cpp: (WTF::Persistence::Coder::decode): (WTF::Persistence::decodeStringText): (WTF::Persistence::Coder::decode): * wtf/persistence/PersistentCoders.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp trunk/Source/WTF/wtf/persistence/PersistentCoders.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/csp/ContentSecurityPolicyResponseHeaders.h trunk/Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheCoders.cpp Diff Modified: trunk/Source/WTF/ChangeLog (260013 => 260014) --- trunk/Source/WTF/ChangeLog 2020-04-13 16:35:31 UTC (rev 260013) +++ trunk/Source/WTF/ChangeLog 2020-04-13 16:40:04 UTC (rev 260014) @@ -1,3 +1,19 @@ +2020-04-13 Joonghun Park + +Unreviewed. Remove redundant move in return statement. + +Return statement already returns rvalue, +so we don't need move here. + +This patch removes the build warning below since r259922. +warning: redundant move in return statement [-Wredundant-move] + +* wtf/persistence/PersistentCoders.cpp: +(WTF::Persistence::Coder::decode): +(WTF::Persistence::decodeStringText): +(WTF::Persistence::Coder::decode): +* wtf/persistence/PersistentCoders.h: + 2020-04-12 Mark Lam Enable the ability to build the ASM LLInt for ARMv7k. Modified: trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp (260013 => 260014) --- trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp 2020-04-13 16:35:31 UTC (rev 260013) +++ trunk/Source/WTF/wtf/persistence/PersistentCoders.cpp 2020-04-13 16:40:04 UTC (rev 260014) @@ -81,7 +81,7 @@ if (!decoder.decodeFixedLengthData(reinterpret_cast(buffer), *length)) return WTF::nullopt; -return WTFMove(string); +return string; } void Coder::encode(Encoder& encoder, const String& string) @@ -115,7 +115,7 @@ if (!decoder.decodeFixedLengthData(reinterpret_cast(buffer), length * sizeof(CharacterType))) return WTF::nullopt; -return WTFMove(string); +return string; } Optional Coder::decode(Decoder& decoder) @@ -150,7 +150,7 @@ SHA1::Digest tmp; if (!decoder.decodeFixedLengthData(tmp.data(), sizeof(tmp))) return WTF::nullopt; -return WTFMove(tmp); +return tmp; } } Modified: trunk/Source/WTF/wtf/persistence/PersistentCoders.h (260013 => 260014) --- trunk/Source/WTF/wtf/persistence/PersistentCoders.h 2020-04-13 16:35:31 UTC (rev 260013) +++ trunk/Source/WTF/wtf/persistence/PersistentCoders.h 2020-04-13 16:40:04 UTC (rev 260014) @@ -141,7 +141,7 @@ } tmp.shrinkToFit(); -return WTFMove(tmp); +return tmp; } }; @@ -176,7 +176,7 @@ if (!decoder.decodeFixedLengthData(reinterpret_cast(temp.data()), size * sizeof(T))) return WTF::nullopt; -return WTFMove(temp); +return temp; } }; @@ -217,7 +217,7 @@ } } -return WTFMove(tempHashMap); +return tempHashMap; } }; @@ -251,7 +251,7 @@ } } -return WTFMove(tempHashSet); +return tempHashSet; } }; Modified: trunk/Source/WebCore/ChangeLog (260013 => 260014) --- trunk/Source/WebCore/ChangeLog 2020-04-13 16:35:31 UTC (rev 260013) +++ trunk/Source/WebCore/ChangeLog 2020-04-13 16:40:04 UTC (rev 260014) @@ -1,3 +1,20 @@ +2020-04-13 Joonghun Park + +Unreviewed. Remove redundant move in return statement. + +Return statement already returns rvalue, +so we don't need move here. + +This patch removes the build warning below since r259922. +warning: redundant move in return statement [-Wredundant-move] + +No new tests, no new behaviours. + +* page/csp/ContentSecurityPolicyResponseHeaders.h: +(WebCore::ContentSecurityPolicyResponseHeaders::decode): +* platform/network/cf/CertificateInfoCFNet.cpp: +(WTF::Persistence::decodeSecTrustRef): + 2020-04-13 Youenn Fablet Fix mute/unmute of CoreAudioCapture sources after revision 257914 Modified:
[webkit-changes] [259698] trunk/Source/WebCore
Title: [259698] trunk/Source/WebCore
Revision 259698
Author jh718.p...@samsung.com
Date 2020-04-07 17:59:37 -0700 (Tue, 07 Apr 2020)
Log Message
Unreviewed. remove the build warning below since r243033.
warning: unused parameter ‘pageMuted’ [-Wunused-parameter]
No new tests, no new behaviors.
* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::setInterrupted):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (259697 => 259698)
--- trunk/Source/WebCore/ChangeLog 2020-04-08 00:43:18 UTC (rev 259697)
+++ trunk/Source/WebCore/ChangeLog 2020-04-08 00:59:37 UTC (rev 259698)
@@ -1,3 +1,13 @@
+2020-04-07 Joonghun Park
+
+Unreviewed. remove the build warning below since r243033.
+warning: unused parameter ‘pageMuted’ [-Wunused-parameter]
+
+No new tests, no new behaviors.
+
+* platform/mediastream/RealtimeMediaSource.cpp:
+(WebCore::RealtimeMediaSource::setInterrupted):
+
2020-04-07 Chris Fleizach
AX: VoiceOver can't activate combobox when textfield is inside it
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (259697 => 259698)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2020-04-08 00:43:18 UTC (rev 259697)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2020-04-08 00:59:37 UTC (rev 259698)
@@ -76,6 +76,10 @@
void RealtimeMediaSource::setInterrupted(bool interrupted, bool pageMuted)
{
+#if RELEASE_LOG_DISABLED
+UNUSED_PARAM(pageMuted);
+#endif
+
ALWAYS_LOG_IF(m_logger, LOGIDENTIFIER, interrupted, ", page muted : ", pageMuted);
setMuted(interrupted);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259688] trunk/Source/WebKit
Title: [259688] trunk/Source/WebKit
Revision 259688
Author jh718.p...@samsung.com
Date 2020-04-07 17:32:13 -0700 (Tue, 07 Apr 2020)
Log Message
Move the misplaced statement to the proper place where in
RESOURCE_LOAD_STATISTICS macro.
This patch removes the build warning below since r259275.
warning: unused variable ‘sameSiteStrictEnforcementEnabled’ [-Wunused-variable]
No new tests, no new behavior changes.
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (259687 => 259688)
--- trunk/Source/WebKit/ChangeLog 2020-04-07 23:43:29 UTC (rev 259687)
+++ trunk/Source/WebKit/ChangeLog 2020-04-08 00:32:13 UTC (rev 259688)
@@ -1,3 +1,16 @@
+2020-04-07 Joonghun Park
+
+Move the misplaced statement to the proper place where in
+RESOURCE_LOAD_STATISTICS macro.
+
+This patch removes the build warning below since r259275.
+warning: unused variable ‘sameSiteStrictEnforcementEnabled’ [-Wunused-variable]
+
+No new tests, no new behavior changes.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::ensureNetworkProcess):
+
2020-04-07 Jiewen Tan
[WebAuthn] Cancel WebAuthn requests when users cancel LocalAuthentication prompts
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (259687 => 259688)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2020-04-07 23:43:29 UTC (rev 259687)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2020-04-08 00:32:13 UTC (rev 259688)
@@ -600,9 +600,9 @@
bool enableResourceLoadStatisticsDebugMode = false;
#if ENABLE(RESOURCE_LOAD_STATISTICS)
WebCore::ThirdPartyCookieBlockingMode thirdPartyCookieBlockingMode = WebCore::ThirdPartyCookieBlockingMode::All;
+WebCore::SameSiteStrictEnforcementEnabled sameSiteStrictEnforcementEnabled = WebCore::SameSiteStrictEnforcementEnabled::No;
#endif
WebCore::FirstPartyWebsiteDataRemovalMode firstPartyWebsiteDataRemovalMode = WebCore::FirstPartyWebsiteDataRemovalMode::AllButCookies;
-WebCore::SameSiteStrictEnforcementEnabled sameSiteStrictEnforcementEnabled = WebCore::SameSiteStrictEnforcementEnabled::No;
WebCore::RegistrableDomain manualPrevalentResource { };
WEB_PROCESS_POOL_ADDITIONS_2
if (withWebsiteDataStore) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
