[webkit-changes] [276513] trunk/Source/WebCore
Title: [276513] trunk/Source/WebCore
Revision 276513
Author mcatanz...@igalia.com
Date 2021-04-23 12:51:44 -0700 (Fri, 23 Apr 2021)
Log Message
Remove virtual function calls in GraphicsLayer destructors
https://bugs.webkit.org/show_bug.cgi?id=180232
Reviewed by Adrian Perez de Castro.
I notice that ~CoordinatedGraphicsLayer makes a virtual function call to
GraphicsLayer::willBeDestroyed, which makes a virtual function call to
CoordinatedGraphicsLayer::removeFromParent. I think that the functions are being called as
intended, because ~CoordinatedGraphicsLayer has not yet been fully destroyed. However, I'm
reminded of Effective C++ item #9: Never call virtual functions during construction or
destruction ("because such calls will never go to a more derived class than that of the
currently executing constructor or destructor"). This code is almost certain to break if
anyone tries in the future to subclass any of the existing subclasses of GraphicsLayer, so
let's refactor it a bit. This doesn't fix anything, but my hope is that it will make the
code a bit harder to break, and not the opposite.
The main risk here is that some reordering of operations is necessary. The derived class
portion of removeFromParent must now be executed before willBeDestroyed. It can't happen
after, because parent would already be unset by that point. It's hard to be certain that
this won't break anything, but I think it should be fine.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::willBeDestroyed):
(WebCore::GraphicsLayer::removeFromParentInternal):
(WebCore::GraphicsLayer::removeFromParent):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore::GraphicsLayerCA::willBeDestroyed): Deleted.
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (276512 => 276513)
--- trunk/Source/WebCore/ChangeLog 2021-04-23 19:34:35 UTC (rev 276512)
+++ trunk/Source/WebCore/ChangeLog 2021-04-23 19:51:44 UTC (rev 276513)
@@ -1,3 +1,38 @@
+2021-04-23 Michael Catanzaro
+
+Remove virtual function calls in GraphicsLayer destructors
+https://bugs.webkit.org/show_bug.cgi?id=180232
+
+Reviewed by Adrian Perez de Castro.
+
+I notice that ~CoordinatedGraphicsLayer makes a virtual function call to
+GraphicsLayer::willBeDestroyed, which makes a virtual function call to
+CoordinatedGraphicsLayer::removeFromParent. I think that the functions are being called as
+intended, because ~CoordinatedGraphicsLayer has not yet been fully destroyed. However, I'm
+reminded of Effective C++ item #9: Never call virtual functions during construction or
+destruction ("because such calls will never go to a more derived class than that of the
+currently executing constructor or destructor"). This code is almost certain to break if
+anyone tries in the future to subclass any of the existing subclasses of GraphicsLayer, so
+let's refactor it a bit. This doesn't fix anything, but my hope is that it will make the
+code a bit harder to break, and not the opposite.
+
+The main risk here is that some reordering of operations is necessary. The derived class
+portion of removeFromParent must now be executed before willBeDestroyed. It can't happen
+after, because parent would already be unset by that point. It's hard to be certain that
+this won't break anything, but I think it should be fine.
+
+* platform/graphics/GraphicsLayer.cpp:
+(WebCore::GraphicsLayer::willBeDestroyed):
+(WebCore::GraphicsLayer::removeFromParentInternal):
+(WebCore::GraphicsLayer::removeFromParent):
+* platform/graphics/GraphicsLayer.h:
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
+(WebCore::GraphicsLayerCA::willBeDestroyed): Deleted.
+* platform/graphics/ca/GraphicsLayerCA.h:
+* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
+(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
+
2021-04-23 Darin Adler
Remove decoder memory allocations based on untrusted data (sizes) in the stream; related changes
Modified: trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp (276512 => 276513)
--- trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp 2021-04-23
[webkit-changes] [250217] trunk/Source/WebKit
Title: [250217] trunk/Source/WebKit
Revision 250217
Author mcatanz...@igalia.com
Date 2019-09-23 02:05:16 -0700 (Mon, 23 Sep 2019)
Log Message
[SOUP] Stop setting G_TLS_GNUTLS_PRIORITY
https://bugs.webkit.org/show_bug.cgi?id=172154
Reviewed by Carlos Garcia Campos.
Nowadays, I maintain glib-networking. WebKit doesn't need to override its defaults to be
secure anymore. By overriding glib-networking's default priority, WebKit is force-reenabling
TLS 1.0 and TLS 1.1 even when glib-networking has disabled them.
* NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
(main):
* WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp
trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (250216 => 250217)
--- trunk/Source/WebKit/ChangeLog 2019-09-23 08:49:11 UTC (rev 250216)
+++ trunk/Source/WebKit/ChangeLog 2019-09-23 09:05:16 UTC (rev 250217)
@@ -1,3 +1,19 @@
+2019-09-23 Michael Catanzaro
+
+[SOUP] Stop setting G_TLS_GNUTLS_PRIORITY
+https://bugs.webkit.org/show_bug.cgi?id=172154
+
+Reviewed by Carlos Garcia Campos.
+
+Nowadays, I maintain glib-networking. WebKit doesn't need to override its defaults to be
+secure anymore. By overriding glib-networking's default priority, WebKit is force-reenabling
+TLS 1.0 and TLS 1.1 even when glib-networking has disabled them.
+
+* NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
+(main):
+* WebProcess/EntryPoint/unix/WebProcessMain.cpp:
+(main):
+
2019-09-21 Dan Bernstein
Fix an assertion failure introduced in r250186.
Modified: trunk/Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp (250216 => 250217)
--- trunk/Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp 2019-09-23 08:49:11 UTC (rev 250216)
+++ trunk/Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp 2019-09-23 09:05:16 UTC (rev 250217)
@@ -35,16 +35,6 @@
int main(int argc, char** argv)
{
-// Disable SSLv3 very early because it is practically impossible to safely
-// use setenv() when multiple threads are running, as another thread calling
-// getenv() could cause a crash, and many functions use getenv() internally.
-// This workaround will stop working if glib-networking switches away from
-// GnuTLS or simply stops parsing this variable. We intentionally do not
-// overwrite this priority string if it's already set by the user.
-// https://bugzilla.gnome.org/show_bug.cgi?id=738633
-// WARNING: This needs to be KEPT IN SYNC with WebProcessMain.cpp.
-setenv("G_TLS_GNUTLS_PRIORITY", "NORMAL:%COMPAT:!VERS-SSL3.0:!ARCFOUR-128", 0);
-
#if USE(GCRYPT)
PAL::GCrypt::initialize();
#endif
Modified: trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp (250216 => 250217)
--- trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp 2019-09-23 08:49:11 UTC (rev 250216)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp 2019-09-23 09:05:16 UTC (rev 250217)
@@ -35,16 +35,6 @@
int main(int argc, char** argv)
{
-// Disable SSLv3 very early because it is practically impossible to safely
-// use setenv() when multiple threads are running, as another thread calling
-// getenv() could cause a crash, and many functions use getenv() internally.
-// This workaround will stop working if glib-networking switches away from
-// GnuTLS or simply stops parsing this variable. We intentionally do not
-// overwrite this priority string if it's already set by the user.
-// https://bugzilla.gnome.org/show_bug.cgi?id=738633
-// WARNING: This needs to be KEPT IN SYNC with WebProcessMain.cpp.
-setenv("G_TLS_GNUTLS_PRIORITY", "NORMAL:%COMPAT:!VERS-SSL3.0:!ARCFOUR-128", 0);
-
#if USE(GCRYPT)
PAL::GCrypt::initialize();
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [249806] trunk/Source/WebKit
Title: [249806] trunk/Source/WebKit
Revision 249806
Author mcatanz...@igalia.com
Date 2019-09-12 06:52:59 -0700 (Thu, 12 Sep 2019)
Log Message
Fix accidental copies in NetworkLoadChecker.cpp
https://bugs.webkit.org/show_bug.cgi?id=199528
Reviewed by Youenn Fablet.
Coverity noticed that we are copying a ResourceRequest and a ContentExtensionResultOrError
in NetworkLoadChecker::checkRequest by mistake, when the intent was to move them as rvalue
references.
* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::checkRequest):
* NetworkProcess/NetworkLoadChecker.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (249805 => 249806)
--- trunk/Source/WebKit/ChangeLog 2019-09-12 10:59:09 UTC (rev 249805)
+++ trunk/Source/WebKit/ChangeLog 2019-09-12 13:52:59 UTC (rev 249806)
@@ -1,3 +1,18 @@
+2019-09-12 Michael Catanzaro
+
+Fix accidental copies in NetworkLoadChecker.cpp
+https://bugs.webkit.org/show_bug.cgi?id=199528
+
+Reviewed by Youenn Fablet.
+
+Coverity noticed that we are copying a ResourceRequest and a ContentExtensionResultOrError
+in NetworkLoadChecker::checkRequest by mistake, when the intent was to move them as rvalue
+references.
+
+* NetworkProcess/NetworkLoadChecker.cpp:
+(WebKit::NetworkLoadChecker::checkRequest):
+* NetworkProcess/NetworkLoadChecker.h:
+
2019-09-12 Joseph Pecoraro
Web Inspector: Crashes when intercept response continues with original content
Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp (249805 => 249806)
--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp 2019-09-12 10:59:09 UTC (rev 249805)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp 2019-09-12 13:52:59 UTC (rev 249806)
@@ -225,7 +225,7 @@
{
ResourceRequest originalRequest = request;
-applyHTTPSUpgradeIfNeeded(WTFMove(request), [this, weakThis = makeWeakPtr(*this), client, handler = WTFMove(handler), originalRequest = WTFMove(originalRequest)](auto request) mutable {
+applyHTTPSUpgradeIfNeeded(WTFMove(request), [this, weakThis = makeWeakPtr(*this), client, handler = WTFMove(handler), originalRequest = WTFMove(originalRequest)](auto&& request) mutable {
if (!weakThis)
return handler({ ResourceError { ResourceError::Type::Cancellation }});
@@ -241,7 +241,7 @@
}
#if ENABLE(CONTENT_EXTENSIONS)
-this->processContentRuleListsForLoad(WTFMove(request), [this, weakThis = WTFMove(weakThis), handler = WTFMove(handler), originalRequest = WTFMove(originalRequest)](auto result) mutable {
+this->processContentRuleListsForLoad(WTFMove(request), [this, weakThis = WTFMove(weakThis), handler = WTFMove(handler), originalRequest = WTFMove(originalRequest)](auto&& result) mutable {
if (!result.has_value()) {
ASSERT(result.error().isCancellation());
handler(WTFMove(result.error()));
Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h (249805 => 249806)
--- trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h 2019-09-12 10:59:09 UTC (rev 249805)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h 2019-09-12 13:52:59 UTC (rev 249806)
@@ -118,7 +118,7 @@
const WebCore::ContentRuleListResults& results;
};
using ContentExtensionResultOrError = Expected;
-using ContentExtensionCallback = CompletionHandler;
+using ContentExtensionCallback = CompletionHandler;
void processContentRuleListsForLoad(WebCore::ResourceRequest&&, ContentExtensionCallback&&);
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [249711] trunk/Tools
Title: [249711] trunk/Tools Revision 249711 Author mcatanz...@igalia.com Date 2019-09-10 05:47:07 -0700 (Tue, 10 Sep 2019) Log Message Unreviewed, remove myself from watchlists * Scripts/webkitpy/common/config/watchlist: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/config/watchlist Diff Modified: trunk/Tools/ChangeLog (249710 => 249711) --- trunk/Tools/ChangeLog 2019-09-10 12:04:45 UTC (rev 249710) +++ trunk/Tools/ChangeLog 2019-09-10 12:47:07 UTC (rev 249711) @@ -1,3 +1,9 @@ +2019-09-10 Michael Catanzaro + +Unreviewed, remove myself from watchlists + +* Scripts/webkitpy/common/config/watchlist: + 2019-09-09 Alex Christensen Rebase API test after r249675 Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (249710 => 249711) --- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2019-09-10 12:04:45 UTC (rev 249710) +++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2019-09-10 12:47:07 UTC (rev 249711) @@ -398,7 +398,7 @@ "Animation" : [ "simon.fra...@apple.com", "d...@apple.com", "dstockw...@chromium.org" ], "MotionMark" : [ "sabouhall...@apple.com" ], "BindingsScripts": [ "cdu...@apple.com" ], -"CMake": [ "rak...@webkit.org", "gyuyoung@webkit.org", "ryuan.c...@navercorp.com", "ser...@correia.cc", "mcatanz...@gnome.org", "annu...@yandex.ru" ], +"CMake": [ "rak...@webkit.org", "gyuyoung@webkit.org", "ryuan.c...@navercorp.com", "ser...@correia.cc", "annu...@yandex.ru" ], "CoordinatedGraphics" : [ "n...@webkit.org", "z...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "ryuan.c...@navercorp.com", "ser...@correia.cc", "gyuyoung@webkit.org" ], "ConsoleUsage" : [ "mk...@chromium.org" ], "ContentSecurityPolicyFiles|ContentSecurityPolicyUsage" : [ "mk...@chromium.org", "dba...@webkit.org" ], @@ -417,7 +417,7 @@ "GraphicsLayer": [ "simon.fra...@apple.com", "kondapallykal...@gmail.com", "ser...@correia.cc" ], "GStreamerGraphics": [ "men...@kde.org", "pnorm...@igalia.com", "g...@gnome.org", "cgar...@igalia.com", "calva...@igalia.com", "vjaq...@igalia.com" ], "GStreamerAudio": [ "pnorm...@igalia.com", "ser...@correia.cc", "calva...@igalia.com", "vjaq...@igalia.com" ], -"GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "be...@igalia.com", "mcatanz...@gnome.org" ], +"GtkWebKit2PublicAPI": [ "cgar...@igalia.com", "g...@gnome.org", "be...@igalia.com" ], "HTML": [ "esprehn+aut...@chromium.org", "gyuyoung@webkit.org", "cdu...@apple.com" ], "History": [ "cdu...@apple.com" ], "IndexedDB": [ "beid...@apple.com", "alecfl...@chromium.org", "jsb...@chromium.org" ], @@ -440,7 +440,7 @@ "SVNScripts": [ "dba...@webkit.org" ], "ScrollingCoordinator": [ "jam...@chromium.org", "toniki...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "fred.w...@free.fr" ], "Selectors": [ "allan.jen...@digia.com" ], -"SoupNetwork": [ "g...@gnome.org", "cgar...@igalia.com", "be...@igalia.com", "mcatanz...@gnome.org" ], +"SoupNetwork": [ "g...@gnome.org", "cgar...@igalia.com", "be...@igalia.com" ], "TextureMapper" : [ "n...@webkit.org", "cmarc...@webkit.org", "l...@webkit.org", "kondapallykal...@gmail.com" ], "TouchAdjustment" : [ "allan.jen...@digia.com" ], "WTF": [ "benja...@webkit.org", "cmarc...@webkit.org", "cdu...@apple.com", "dba...@webkit.org" ], @@ -453,7 +453,7 @@ "JSBuiltinsGenerator": [ "bb...@apple.com" ], "WPEDependencies": [ "ape...@igalia.com", "clo...@igalia.com" ], "WebKitGTKDependencies": [ "ago...@igalia.com", "lti...@igalia.com", "clo...@igalia.com" ], -"WebKitGTKTranslations": [ "g...@gnome.org", "be...@igalia.com", "cgar...@igalia.com", "mcatanz...@gnome.org" ], +"WebKitGTKTranslations": [ "g...@gnome.org", "be...@igalia.com", "cgar...@igalia.com" ], "WebSocket": [ "yu...@chromium.org", "toyos...@chromium.org" ], "XSS": [ "dba...@webkit.org" ], "webkitperl": [ "dba...@webkit.org" ], ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [249532] trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Title: [249532] trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Revision 249532
Author mcatanz...@igalia.com
Date 2019-09-05 10:01:36 -0700 (Thu, 05 Sep 2019)
Log Message
Unreviewed, update contributors.json
People are having trouble CCing me on Bugzilla.
I'm still at Igalia, but no longer working on WebKit.
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (249531 => 249532)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2019-09-05 16:56:25 UTC (rev 249531)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2019-09-05 17:01:36 UTC (rev 249532)
@@ -3886,8 +3886,8 @@
},
"Michael Catanzaro" : {
"emails" : [
- "mcatanz...@igalia.com",
- "mcatanz...@gnome.org"
+ "mcatanz...@gnome.org",
+ "mcatanz...@igalia.com"
],
"expertise" : "The WebKitGTK Port, Epiphany, Soup HTTP Backend",
"nicks" : [
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [248408] releases/WebKitGTK/webkit-2.24/Source/WebCore
Title: [248408] releases/WebKitGTK/webkit-2.24/Source/WebCore
Revision 248408
Author mcatanz...@igalia.com
Date 2019-08-08 07:53:40 -0700 (Thu, 08 Aug 2019)
Log Message
Merge r248405 - [GTK] WebKitWebProcess crashes when viewing an HTML with a element referencing unknown file
https://bugs.webkit.org/show_bug.cgi?id=200530
Reviewed by Xabier Rodriguez-Calvar.
Not amenable to unit testing.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
Modified Paths
releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog (248407 => 248408)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-08-08 14:20:19 UTC (rev 248407)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog 2019-08-08 14:53:40 UTC (rev 248408)
@@ -1,3 +1,15 @@
+2019-08-08 Charlie Turner
+
+[GTK] WebKitWebProcess crashes when viewing an HTML with a element referencing unknown file
+https://bugs.webkit.org/show_bug.cgi?id=200530
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Not amenable to unit testing.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
+
2019-08-02 Ryosuke Niwa
Harden NodeRareData::m_connectedFrameCount
Modified: releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (248407 => 248408)
--- releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-08-08 14:20:19 UTC (rev 248407)
+++ releases/WebKitGTK/webkit-2.24/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2019-08-08 14:53:40 UTC (rev 248408)
@@ -1667,6 +1667,12 @@
void MediaPlayerPrivateGStreamer::fillTimerFired()
{
+if (m_errorOccured) {
+GST_DEBUG_OBJECT(pipeline(), "[Buffering] An error occurred, disabling the fill timer");
+m_fillTimer.stop();
+return;
+}
+
GRefPtr query = adoptGRef(gst_query_new_buffering(GST_FORMAT_PERCENT));
double fillStatus = 100.0;
GstBufferingMode mode = GST_BUFFERING_DOWNLOAD;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [248260] releases/WebKitGTK/webkit-2.24
Title: [248260] releases/WebKitGTK/webkit-2.24
Revision 248260
Author mcatanz...@igalia.com
Date 2019-08-03 20:24:25 -0700 (Sat, 03 Aug 2019)
Log Message
Merge r248172 - Document::resume should delay resetting of form control elements.
https://bugs.webkit.org/show_bug.cgi?id=200376
Reviewed by Geoffrey Garen.
Source/WebCore:
Delay the execution of form control element resets until the next task
to avoid synchronously mutating DOM during page cache restoration.
Test: fast/frames/restoring-page-cache-should-not-run-scripts.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::resumeFromDocumentSuspension):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::resumeFromDocumentSuspension):
LayoutTests:
Added a regression test.
* fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt: Added.
* fast/frames/restoring-page-cache-should-not-run-scripts.html: Added.
* platform/win/TestExpectations: Skip this test on Windows since navigating to blob fails on Windows.
Modified Paths
releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.24/Source/WebCore/html/HTMLFormElement.cpp
releases/WebKitGTK/webkit-2.24/Source/WebCore/html/HTMLInputElement.cpp
Added Paths
releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt
releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html
Diff
Modified: releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog (248259 => 248260)
--- releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog 2019-08-04 03:24:21 UTC (rev 248259)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/ChangeLog 2019-08-04 03:24:25 UTC (rev 248260)
@@ -1,3 +1,16 @@
+2019-08-02 Ryosuke Niwa
+
+Document::resume should delay resetting of form control elements.
+https://bugs.webkit.org/show_bug.cgi?id=200376
+
+Reviewed by Geoffrey Garen.
+
+Added a regression test.
+
+* fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt: Added.
+* fast/frames/restoring-page-cache-should-not-run-scripts.html: Added.
+* platform/win/TestExpectations: Skip this test on Windows since navigating to blob fails on Windows.
+
2019-07-17 Olivier Blin
Web Inspector: application/xml content not shown
Added: releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt (0 => 248260)
--- releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt (rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts-expected.txt 2019-08-04 03:24:25 UTC (rev 248260)
@@ -0,0 +1,3 @@
+This tests that pageshow event is fired before the focus elements are reset when a document in the page cache is restored.
+
+PASS
Added: releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html (0 => 248260)
--- releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html (rev 0)
+++ releases/WebKitGTK/webkit-2.24/LayoutTests/fast/frames/restoring-page-cache-should-not-run-scripts.html 2019-08-04 03:24:25 UTC (rev 248260)
@@ -0,0 +1,73 @@
+
+
+
+This tests that pageshow event is fired before the focus elements are reset when a document in the page cache is restored.
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+testRunner.setCanOpenWindows();
+testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
+}
+
+let newWindow;
+function start() {
+result.textContent = 'Running...';
+newWindow = window.open(URL.createObjectURL(newPage));
+}
+
+const newPage = new Blob([`
+
+
+hello, this is a test.
+
+