[OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

Hi Phil, I have added public evaluation in bug. Please review. Thanks, Jay From: Philip Race Sent: Friday, November 13, 2015 12:11 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review request for JDK-6967419 : IndexOutOfBoundsException when

Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

alue, will not result in IndexOutOfBoundsException and ios.close() will be performed properly. Please let us know your inputs. Thanks, Jay From: Phil Race Sent: Tuesday, November 17, 2015 3:22 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review req

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

regarding the typo in "spacing". Please find updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.06/ Please review so that we can push the change. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:03 PM To: Jayathirth D

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hi Vadim, Thanks for the review. I have made suggested changes. Updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.05/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Friday, October 16, 2015 8:15 PM To: Jayathirth D V; Sergey Bylokhov

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Please review following fix in jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-7182758 Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.00/ Bug : BMPMetadata returns invalid PhysicalPixelSpacing Root cause : Whenever XPixelsPerMter or

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Can I get one more review please. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, October 15, 2015 6:05 PM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race Subject: Re: Review request for JDK-7182758: BMPMetadata returns invalid

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

rchamyal/jay/7182758/webrev.07/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:50 PM To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hi Sergey, I have made suggested changes. Please find updated Webrev link: http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.03/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, October 13, 2015 9:06 PM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Made small change on how we need to represent floating point constant in Java(1000.0 -> 1000.0F). Please find updated Webrev link: Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.01/ Please review. Thanks, Jay From: Jayathirth D V S

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hello All, Gentle Reminder. Please review the changes. Thanks, Jay On 10/6/2015 12:57 PM, Jayathirth D v wrote: Hello All, We noticed that jtreg tag "@run" was not matching main class name for test file. So made relevant change only in comment's section of test file. Please fi

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Removed Trailing whitespace present in code. Please find updated webrev link: http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.02/ Thanks, Jay From: Jayathirth D V Sent: Monday, October 12, 2015 2:15 PM To: 2d-dev@openjdk.java.net; Philip Race; Sergey

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hi Sergey, Thanks for review. Hello All, I need one more review for this patch. Please review. Thanks, Jay On 10/5/2015 7:01 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review following fix in jdk9:_ _Bug

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

15 9:51 AM, Jayathirth D v wrote: Hi Sergey, Thanks for review. Hello All, I need one more review for this patch. Please review. Thanks, Jay On 10/5/2015 7:01 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review fol

[OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hello All, _Please review following fix in jdk9:_ _Bug:_ https://bugs.openjdk.java.net/browse/JDK-8066904/ _Webrev:_ http://cr.openjdk.java.net/~rchamyal/jay/8066904/webrev.00/ _Bug:_ NullPointerException when calling

[OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

- From: Sergey Bylokhov Sent: Wednesday, December 02, 2015 12:43 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs Hi, Jay. Can you please check other writers and confirm

Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

Fix looks good to me.   From: prasanta sadhukhan Sent: Thursday, December 10, 2015 1:40 PM To: Philip Race; Sergey Bylokhov Cc: 2d-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with

Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

one Doc Flavor).   By doing this we will avoid NPE. Also having user to select another printer from dialog(if selected printer is not available) is better than throwing NPE. Present changes are fine.   Thanks, Jay   From: Jayathirth D V Sent: Thursday, December 10, 2015 5:10 PM To: Prasanta

Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

Thanks for the review Phil. Can I get one more review for new webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8143562/webrev.01/"http://cr.openjdk.java.net/~jdv/8143562/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, December 16, 2015 12:00 AM To: Jayathirth

[OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

Hi, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8143562 Webrev : http://cr.openjdk.java.net/~jdv/8143562/webrev.00/ Issue : We are getting null for ImageTypeSpecifier when we use getRawImageType() API for YCbCr Image. Root cause : When

[OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

Hi Phil/Prasanta, Please review following fix in jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8074967 Webrev : http://cr.openjdk.java.net/~rchamyal/jay/8074967/webrev.00/ Bug : JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata Root cause :

[OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

/8074967/webrev.01/ Please review. Thanks, Jay From: Jayathirth D V Sent: Thursday, November 19, 2015 3:19 PM To: Philip Race; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hello All, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling. Root

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 4:43 PM To: Jayathirth D V; 2d-dev

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 5:15 PM To: Jayathirth D V Cc: Philip Race; 2d-dev@openjdk.java.net Subject

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

: Tuesday, November 24, 2015 2:08 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header Rather than adding a comment block, it seems you need to edit the preceding one

[OpenJDK 2D-Dev] Review request for JDK-8144744 : ImageWriter.replacePixels() specification is incorrect regarding null ImageWriteParam

Hi, Please review a simple fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8144744 Webrev : http://cr.openjdk.java.net/~jdv/8144744/webrev.00/ Issue : Specification of ImageWriter.replacePixels() mentions that Illegal argument exception will be thrown if argument

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

ion can contain data which will be similar to EOI,SOI or other markers(FF XX). Thanks, Jay -Original Message- From: Jim Graham Sent: Friday, June 10, 2016 5:28 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exce

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

/ Thanks, Jay -Original Message- From: Jim Graham Sent: Friday, June 03, 2016 2:25 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods I just noticed a hashCode

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

ted webrev for review: http://cr.openjdk.java.net/~jdv/8152672/webrev.01/ Thanks, Jay -Original Message- From: Jim Graham Sent: Saturday, June 11, 2016 3:07 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Excep

[OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-6386906 Webrev : http://cr.openjdk.java.net/~jdv/6386906/webrev.00/ Issue : We are dividing an integer with another integer and trying to perform ceil() on resultant value which will be

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

Hi Jim, Thanks for your review. I have updated the changes mentioned by you. Please find the updated webrev for review: http://cr.openjdk.java.net/~jdv/6386906/webrev.01/ Thanks, Jay -Original Message- From: Jim Graham Sent: Tuesday, June 14, 2016 12:34 AM To: Jayathirth D V; 2d-dev

Re: [OpenJDK 2D-Dev] Review Request for JDK-6386906 : Faulty rounding code in BMPImageReader.decodeRLE4()

Hi Jim, Thanks for the review. I have updated the webrev for reference: http://cr.openjdk.java.net/~jdv/6386906/webrev.02/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 4:15 AM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race Subject: Re

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail

, Jay -Original Message- From: Jim Graham Sent: Thursday, June 02, 2016 2:08 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail I'm a little disturbed that we are just

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Hi Jim, Thanks for your valuable inputs. I have made recommended changes. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/7107905/webrev.08/ Thanks, Jay -Original Message- From: Jim Graham Sent: Friday, May 27, 2016 11:52 PM To: Jayathirth D V; Philip Race Cc

Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable: docs/api/javax/print/package-summary.html

Hi Prasanta, Changes are fine. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Monday, May 30, 2016 11:20 PM To: prasanta sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4957035:Code given in api is not compilable:

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

iday, May 27, 2016 2:18 PM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods Hi Jay, .equals() should not be comparing any fields that are computed from other fi

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Fixed typo. From: Jayathirth D V Sent: Thursday, June 02, 2016 5:08 PM To: Philip Race Cc: Jim Graham; 2d-dev@openjdk.java.net Subject: RE: Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail Hi Phil, We have two kind

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

getting inside APP1 and APP2 markers also. Thanks, Jay From: Phil Race Sent: Thursday, June 02, 2016 4:05 AM To: Jayathirth D V Cc: Jim Graham; 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumb

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Sent: Wednesday, June 01, 2016 10:06 PM To: Jayathirth D V Cc: Jim Graham; 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods Please post the updated webrev. -phil. On 6/1/16, 12:02 AM, Jayathirth D V wrote

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Hi, Gentle reminder. Please review updated fix: http://cr.openjdk.java.net/~jdv/7107905/webrev.07/ Thanks, Jay -Original Message- From: Jayathirth D V Sent: Thursday, May 19, 2016 6:43 PM To: Philip Race; Jim Graham Cc: 2d-dev@openjdk.java.net Subject: Review Request for JDK-7107905

[OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8152672 Webrev : http://cr.openjdk.java.net/~jdv/8152672/webrev.00/ Issue : When we are trying to get properties related to second image in JPEG file we are getting IIOException

[OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Updated bug title in JBS as it was misleading. From: Jayathirth D V Sent: Wednesday, June 01, 2016 12:48 PM To: Philip Race; Jim Graham Cc: 2d-dev@openjdk.java.net Subject: Review Request for JDK-8152672 : Exception getting thumbnail size for JPEG with embedded thumbnail Hi, Please

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

Hi Prasanta,   One more thing I missed, there are many unneeded imports in test case. Please remove them also.   Thanks, Jay   From: Jayathirth D V Sent: Friday, June 17, 2016 2:45 PM To: Prasanta Sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

Hi Prasanta,   I tried to run the test but it looks like you are not creating object for proper class in test case : 88 pj.setPrintable(new PrintableDemo(), pf);     I think it should be test class name : 88 pj.setPrintable(new PrintTestLexmarkIQ(), pf);   After we

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

Hi Prasanta,   Changes are working fine. Please convert multiple single line comments to multi-line comments both in code change in test case. In test case there are some places where lines are ending with more than 80 characters. No need for review. Please change it before check-in.  

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Hi Phil, Gentle remainder for review. Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 10:01 AM To: Jayathirth D V; Phil Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Hi Phil, Gentle reminder for review. Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, June 15, 2016 10:01 AM To: Jayathirth D V; Phil Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image

[OpenJDK 2D-Dev] Review Request for JDK-8153943 : In PixelInterLeavedSampleModel and BandedSampleModel we dont need hashCode() method

also have a >> meaningless override of super.equals/hashCode(). >> >> And all of these classes suffer from casting to the specific type >> before verifying its class as I mentioned in the ICM.equals() review... >> >> ...jim >> >> On 4/25

[OpenJDK 2D-Dev] Review request for JDK - 8146972 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi, This is backport of fix from JDK 9 bug : https://bugs.openjdk.java.net/browse/JDK-8041501 to JDK 8u. Changes in JDK9 are already checked in. Please review the fix: Bug : https://bugs.openjdk.java.net/browse/JDK-8146972 Webrev :

Re: [OpenJDK 2D-Dev] Review Request for JDK-8152672 : Exception while getting second image properties for JPEG with embedded thumbnail

Hi Brian, Thanks for your inputs. I have updated the new bug https://bugs.openjdk.java.net/browse/JDK-8160327 with same comment. Thanks, Jay From: Brian Burkhalter Sent: Tuesday, June 28, 2016 12:41 AM To: Philip Race Cc: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

Hi Prasanta,   Changes are fine.   Thanks, Jay   From: prasanta sadhukhan Sent: Friday, June 17, 2016 3:37 PM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6966350:Empty pages when printing on Lexmark E352dn PS3 with "1200 IQ" setting

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

approval? Thanks, Jay -Original Message- From: Alexander Scherbatiy Sent: Friday, January 22, 2016 5:05 PM To: Jim Graham; Phil Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

: Friday, February 12, 2016 4:05 AM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED Hi Jayathirth, Did you do any performance analysis

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

Hi Jim, Gentle reminder. Please let me your inputs after testing. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Tuesday, February 16, 2016 10:03 PM To: Jim Graham Cc: 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan Subject: RE: [OpenJDK 2D-Dev] Review Request

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Jim thanks for the review. Prasanta I have updated the webrev to address indentation issues. Please review: http://cr.openjdk.java.net/~jdv/8139183/webrev.06/ Thanks, Jay -Original Message- From: Jim Graham Sent: Thursday, March 10, 2016 5:28 AM To: Jayathirth D V Cc: 2d-dev

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-6379088, , Suboptimal expression in javax.imageio.ImageTypeSpecifier.getBitsPerBand(int)

Change is fine. Looks like this is the only place in ImageTypeSpecifier where we are not using short-circuit logical "or". -Original Message- From: prasanta sadhukhan Sent: Tuesday, March 15, 2016 5:36 PM To: Sergey Bylokhov; Jayathirth D V; 2d-dev@openjdk.java.net Subject: [9

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

gey Bylokhov Sent: Friday, March 18, 2016 12:24 AM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream On 17.03.16 21:14, Jayathirth D V wrote: >

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8151621, , [TEST_BUG] java/awt/print/PrinterJob/MultiMonPrintDlgTest.java doesn't work with jtreg

Changes are fine. -Original Message- From: Yuri Nesterenko Sent: Friday, March 11, 2016 5:26 PM To: prasanta sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8151621, , [TEST_BUG] java/awt/print/PrinterJob/MultiMonPrintDlgTest.java doesn't work with jtreg

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi Jim, I have made changes mentioned by you. Please find updated webrev: http://cr.openjdk.java.net/~jdv/8139183/webrev.05/ Thanks, Jay -Original Message- From: Jim Graham Sent: Wednesday, March 09, 2016 3:23 AM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream The test writes out into "test.src". I believe that you should treat that as a "read-only" location.

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

HI Prasanta,   Changes are fine. Both the print dialogs are coming and there is no NPE. In test case please change copyright year to 2016 and also it is better to have jtreg comments before import statements for readability.   Thanks, Jay   From: Phil Race Sent: Wednesday, March 16,

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest/HighResTest.java

Looks good to go.   Thanks, Jay   From: prasanta sadhukhan Sent: Wednesday, March 16, 2016 2:17 PM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8066139, , Null return from PrintJob.getGraphics() running closed/java/awt/PrintJob/HighResTest

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

, 2016 2:38 AM To: prasanta sadhukhan; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel Yes, that is the only issue I see now as well... ...jim On 3/9/16 10:39 PM, prasanta

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

Hi Sergey, It will be pushed after removing the redundant code. Please find the webrev: http://cr.openjdk.java.net/~jdv/8044289/webrev.07/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, April 05, 2016 8:05 PM To: Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

tructed ICM instances are equals() == true, tested with one of each of the constructors... - I have made changes to test case for verifying all constructors with same ICM. Also added verification for hashCode value. ...jim On 4/6/2016 4:47 AM, Jayathirth D V wrote:

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

inal Message- From: Phil Race Sent: Wednesday, April 13, 2016 1:49 AM To: Jim Graham Cc: Jayathirth D V; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not st

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

To: Jayathirth D V; Philip Race; Prasanta Sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict Hi Jay, There was one thing I pointed out in the first review that got

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

Sure Sergey after technical review is done I will raise CCC for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, April 08, 2016 12:42 AM To: Jim Graham; Jayathirth D V; Philip Race; Prasanta Sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

Graham Sent: Friday, April 08, 2016 12:28 AM To: Jayathirth D V; Philip Race; Prasanta Sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict Hi Jayathirth

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

Hi Sergey, For the second approach I have created webrev for review. Please review updated webrev : http://cr.openjdk.java.net/~jdv/8044289/webrev.02/ Thanks, Jay -Original Message- From: Jayathirth D V Sent: Friday, March 18, 2016 2:23 PM To: Sergey Bylokhov Cc: 2d-dev

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

for review: http://cr.openjdk.java.net/~jdv/8044289/webrev.03/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, March 22, 2016 7:39 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

Thanks for the review Sergey. Can I get +1 for this please? -Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, March 22, 2016 9:52 PM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

h 24, 2016 5:10 AM To: Jayathirth D V Cc: Sergey Bylokhov; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream I don't think this is ready and we need to discuss whether to rework it. In general I

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

) Removed setColor() with transparent color for AlphaComposite.Clear as it is not needed. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8139183/webrev.04/ Thanks, Jay -Original Message- From: Jim Graham Sent: Tuesday, March 08, 2016 6:00 AM To: Jayathirth D V Cc: 2d

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

To: Jayathirth D V; Sergey Bylokhov Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel Hi Jay, The new code looks good except for one minor indentation problem on the argument list of the method after you added

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8058316, , lookupDefaultPrintService returns null on Solaris 11

Fix looks fine. Please add relevant noreg label in bug before resolving it, since there is no test case. Thanks, Jay -Original Message- From: Phil Race Sent: Saturday, March 05, 2016 1:00 AM To: prasanta sadhukhan Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9]: RFR

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8138749, , Revisited: PrinterJob.printDialog() does not support multi-mon, always displayed on primary

Hi Prasanta, Fix looks fine to me. We are taking care of both having the dialog within proper monitor and also making sure that it stays within the window bounds and also consistent with native print dialog. Thanks, Jay -Original Message- From: Philip Race Sent: Wednesday, March 02,

Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel The logic here has mixed up the opacities and what needs to be done about them. If the source image is opaque

[OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8139183 Webrev : http://cr.openjdk.java.net/~jdv/8139183/webrev.00/ Issue : When we scale any buffered image using drawImage() API which takes scale coordinates we are losing alpha

[OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi, I have updated the changes to select proper Buffer Image type based on source transparency and not just using ARGB directly. Please find the updated webrev for review: http://cr.openjdk.java.net/~jdv/8139183/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Wednesday

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-6357905, , java.awt.JobAttributes.getFromPage() and getToPage() always returns "1".

Hi Prasanta, Changes are fine and test case looks good. Please make proper indentation for jtreg comments before checkin. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, April 01, 2016 10:47 PM To: prasanta sadhukhan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9]: RFR

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

ril 05, 2016 2:59 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev Subject: Re: Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method This looks fine although I am unable to work out how a JCK test detected the duplication -phil. On

Re: [OpenJDK 2D-Dev] [9] RFR: JDK-8061258, , [macosx] PrinterJob's native Print Dialog does not reflect specified Copies or Page Ranges

. As we discussed it looks like only PageRanges is not working. You can update the bug regarding the same with Fix version as 9.   Thanks, Jay   From: prasanta sadhukhan Sent: Wednesday, March 30, 2016 12:18 PM To: Phil Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [9] RFR: JDK

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8042713, , [macosx] Print dialog does not update attribute set with page range

sadhukhan Sent: Wednesday, March 30, 2016 12:34 PM To: Phil Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [9] RFR JDK-8042713,,[macosx] Print dialog does not update attribute set with page range Hi Phil, Yes, the combination of this fix plus 8061258 works with both the testcase I

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

/webrev.05/ Thanks, Jay From: prasanta sadhukhan Sent: Tuesday, March 29, 2016 2:21 PM To: Jayathirth D V Cc: Philip Race; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream +1

[OpenJDK 2D-Dev] Review Request for JDK-8153363: Redundant check for number of components in PackedColorModel.equals() method

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8153363 Webrev : http://cr.openjdk.java.net/~jdv/8153363/webrev.00/ Issue : We have redundant check for equality of number of components in PackedColorModel. Solution : Number of

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

, March 29, 2016 10:38 PM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream This is OK but you ought to remember that read() and write() only HAPPEN

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

om: Sergey Bylokhov Sent: Tuesday, March 29, 2016 6:11 PM To: Philip Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream I am not sure what is the reason of this

Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

will indicate that we are not able to create required stream. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, March 17, 2016 7:27 PM To: Phil Race Cc: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

ely and > then rewrite the whole tail end of the loop body from 291 to the end > of the loop as: > > if (i == 0) { > if (r > delta) return false; > } else { > if (r < 255-delta) return false; > } > // 2 more similar tests for j/g and k/b > > Then &quo

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

-Original Message- From: Jim Graham Sent: Saturday, April 23, 2016 7:30 AM To: Phil Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method in IndexColorModel doesnt exist and it relies on ColorModel.equals() which is not strict

relevant changes in its subclasses and sent review in its thread. Thanks, Jay -Original Message- From: Jim Graham Sent: Thursday, April 14, 2016 2:57 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7107905: equals() method

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

toring RGB colors in color-map as it can vary if user provides custom color-map. This looks like completely different issue of not extracting proper value for white color. Thanks, Jay -Original Message- From: Jim Graham Sent: Saturday, April 30, 2016 4:43 AM To: Jayathirth D V; Philip R

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6509729: javax.print.ServiceUI.printDialog Border/Margin Evaluation is bugged

Hi Prasanta, Changes are working fine. +1. Thanks, Jay -Original Message- From: Phil Race Sent: Thursday, May 19, 2016 3:53 AM To: prasanta sadhukhan; 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-6509729: javax.print.ServiceUI.printDialog Border/Margin Evaluation

[OpenJDK 2D-Dev] Review Request for JDK-7107905: ColorModel subclasses are missing hashCode() or equals() or both methods

Hi, Previously for this bug we were making changes related only to IndexColorModel. Since we are expanding to include hashCode() or equals() method from PackedColorModel and ComponentColorModel, I have created single webrev for review under the same bug id. Now the "getclass()==" check is

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6601097:Margins are not reset to hardware margins when width/height is 0 or -ve alongwith x, y

Hi Prasanta, Verified the changes and even in case of -ve width/height now we are using hardware margins and not java defined 1 inch margin. +1. Thanks, Jay -Original Message- From: prasanta sadhukhan Sent: Thursday, May 19, 2016 3:30 PM To: Phil Race; 2d-dev@openjdk.java.net Subject:

Re: [OpenJDK 2D-Dev] [2D-Dev] Review Request: JDK-8015070: Antialiased text on translucent backgrounds gets bright artifacts

Hi Prahalad, Changes are working fine.+1. In test case please make jtreg comments as multiline comments and move them below copyright and above import statements for readability before pushing. Thanks, Jay -Original Message- From: Jim Graham Sent: Tuesday, May 03, 2016 1:42 AM To:

[OpenJDK 2D-Dev] equals() and hashCode() verification in java.awt.image.ComponentSampleModel and its subclassses

Hi Jim, I am trying to modify/add equals()/hashCode() methods in java.awt.image.ComponentSampleModel() and its subclasses. In BandedSampleModel and PixelInterleavedSampleModel I see that we have just hashCode() functions and not equals() and these hashCode() function are returning just

Re: [OpenJDK 2D-Dev] Review Request for JDK-8153943 : In java.awt.image package some of the classes are missing hashCode() or equals() method

e Java like the other methods here. >> >> PixelInterleavedSampleModel and BandedSampleModel also have a >> meaningless override of super.equals/hashCode(). >> >> And all of these classes suffer from casting to the specific type >> before verifying its cl

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

Hi, Gentle reminder. Please review. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Monday, May 02, 2016 4:05 PM To: Jim Graham; Philip Race Cc: 2d-dev@openjdk.java.net Subject: RE: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting

  1   2   3   4   5   >