Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Sergey Bylokhov
Hi,Phil. According to these CR macosx check should be: .contains(OS X). http://monaco.sfbay.sun.com/detail.jsf?cr=7147461 http://monaco.sfbay.sun.com/detail.jsf?cr=7130404 On 19.06.2012 20:13, Phil Race wrote: 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

Re: [OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null

2012-06-19 Thread Sergey Bylokhov
(Win) is a common pattern. So I don't agree with the advice anyway. -phil. On 6/19/2012 9:36 AM, Sergey Bylokhov wrote: Hi,Phil. According to these CR macosx check should be: .contains(OS X). http://monaco.sfbay.sun.com/detail.jsf?cr=7147461 http://monaco.sfbay.sun.com/detail.jsf?cr=7130404

[OpenJDK 2D-Dev] [8] Review request for 7181438: [OGL] Incorrect alpha used, during blit from SW to the texture.

2012-07-09 Thread Sergey Bylokhov
Hi Everyone, Please review the fix for 7181438. This bug was introduced in 7u4b11, when macosx-port was integrated to jdku7 by this changeset: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9dfe50f456be Note that now we always set format to GL_RGBA. So opaque surface has an alpha channel.

Re: [OpenJDK 2D-Dev] [8] Review request for 7181438: [OGL] Incorrect alpha used, during blit from SW to the texture.

2012-07-09 Thread Sergey Bylokhov
explicitly documented and/or made conditional for specific platforms. Thanks, Chris P.S. Good to see some activity on the OGL pipeline. I don't get paid to worry about these things anymore though, so perhaps I should just crawl back in my hole now :) On Jul 9, 2012, at 4:35 AM, Sergey Bylokhov

[OpenJDK 2D-Dev] [7u6] Review request for 7181438: [OGL] Incorrect alpha used, during blit from SW to the texture.

2012-07-16 Thread Sergey Bylokhov
Hi Everyone, Please review the fix for 7181438. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7181438 Webrev can be found at:http://cr.openjdk.java.net/~serb/7181438/webrev.01/ Discussion for jdk8 review: http://mail.openjdk.java.net/pipermail/2d-dev/2012-July/002630.html jdk8

Re: [OpenJDK 2D-Dev] hg: macosx-port/macosx-port/jdk: Some cleanup in CAOpenGLLayer prototype (including extracting layer code into CGLLayer.h|m and removing stale code)

2012-10-11 Thread Sergey Bylokhov
Hi Mike, Phil, Dmitry, Scott. I have a question about our CALayer implementation. According to the code below we use layer-backed NSView. AWTView.m: [self setWantsLayer: YES]; [self.layer addSublayer: (CALayer *)cglLayer]; But in the documentation for NSView.setWantsLayer: When

[OpenJDK 2D-Dev] [8] Request for review: 7124219 [macosx] Unable to draw images to fullscreen

2012-11-16 Thread Sergey Bylokhov
Hi Everyone, Please review the fix. This is not a direct forward port from jdk 7. Changes description: 1 All stuff related to the backbuffer now located in CGLGraphicsConfig. Implementation was synchronized with the version on windows and linux. 2 LWCanvasPeer, LWWindowPeer , CPlatform :

[OpenJDK 2D-Dev] clip with negative width or height in Graphics2D

2012-12-12 Thread Sergey Bylokhov
Hello 2d team, I have a question about clipping in our implementation of SunGraphics2D. Currently if I set usrClip to Rectangle(100,100,-100,-100) the real clip will be clipRegion = 100,100,100,100; But if I set clip to Rectangle2D with the same coordinates the real clip will be clipRegion =

[OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-13 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. Change description: 1 transformShape now symmetric to untransformShape() (setFrameFromDiagonal was removed). 2 getClipBounds now always uses getBounds2D which does not return empty Rectangle if the userclip has negative width or height. Note that if the

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-15 Thread Sergey Bylokhov
that is rotated by a multiple of 90 degrees or is flipped horizontally or vertically. Those cases will result in an empty clip, but the clip was not empty coming in... ...jim On 12/13/2012 3:08 AM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. Change description: 1

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-20 Thread Sergey Bylokhov
20.12.2012 14:12, Sergey Bylokhov пишет: 20.12.2012 13:49, Jim Graham wrote: More to the point, if you substitute a 0x0 clip when an incoming clip is an empty rectangle then it will always be empty under any kind of transform. This could be done by performing a max(w,0);max(h,0); operation

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-20 Thread Sergey Bylokhov
we can revert back this operation? ...jim On 12/20/2012 9:52 AM, Sergey Bylokhov wrote: 20.12.2012 14:12, Sergey Bylokhov пишет: 20.12.2012 13:49, Jim Graham wrote: More to the point, if you substitute a 0x0 clip when an incoming clip is an empty rectangle then it will always

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-20 Thread Sergey Bylokhov
21.12.2012 3:26, Sergey Bylokhov пишет: Hi, Jim. 21.12.2012 1:42, Jim Graham wrote: Hi Sergey, Avoiding the transform only works if they read it back in the same coordinate system that they set it. It will fail if they do: setClip or clip(...); scale(5, 5); getClip(); So

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-20 Thread Sergey Bylokhov
Hi, Jim. 21.12.2012 4:59, Jim Graham wrote: The Object.equals() method is not intended to compare geometries. While Area.equals() attempts to perform geometric comparison I think that was a bad idea in retrospect for many reasons: - In practice you can only really compare within a tolerance

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2012-12-21 Thread Sergey Bylokhov
21.12.2012 6:05, Sergey Bylokhov пишет: Hi, Jim. 21.12.2012 4:59, Jim Graham wrote: The Object.equals() method is not intended to compare geometries. While Area.equals() attempts to perform geometric comparison I think that was a bad idea in retrospect for many reasons: - In practice you can

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException

2013-01-09 Thread Sergey Bylokhov
know this. I found ~400 of tests contain this text. Where I can find this rule? Thanks. -phil. On 1/9/13 8:41 AM, Sergey Bylokhov wrote: Hi, Jim. Please review updated version of the fix. http://cr.openjdk.java.net/~serb/8004821/webrev.01 05.01.2013 23:21, Jim Graham wrote: Hi Sergey, Does

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004821 Graphics2D.drawPolygon() fails with IllegalPathStateException

2013-01-10 Thread Sergey Bylokhov
libraries which have GPL v2 + CP. So *not* having the classpath is actually the default/norm. Its just that we mostly work with the class libs so thing its the other way around .. -phil On 1/9/13 9:17 AM, Sergey Bylokhov wrote: Hi, Phil. 09.01.2013 21:07, Phil Race wrote: Are you implicitly answering

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-01-14 Thread Sergey Bylokhov
we can fix bugs in there without worrying about possibly changing the behavior for other apps that may have started to rely on what we see as bugs. ...jim On 12/21/2012 3:21 AM, Sergey Bylokhov wrote: 21.12.2012 6:05, Sergey Bylokhov пишет: Hi, Jim. 21.12.2012 4:59, Jim Graham

[OpenJDK 2D-Dev] [8] Request for review: 8008660 : Failure in 2D Queue Flusher thread on Mac

2013-02-22 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. Fix will be ported to jdk7 as well. There is a few problems: 1 To eliminate the crash we should check that the system return correct CGLConfigInfofrom in CGLGraphicsConfig.getConfig(). (see http://bugs.sun.com/view_bug.do?bug_id=6755274) 2 Requested

[OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-26 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. Change adds initial support of hidpi(mostly on 2d side). In the fix scale was added to the surface data/CGraphicsDevice /CGLLayer. This scale factor maps virtual coordinates to physical pixels. This change doesn't add support of hidpi to aqua lf and

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-27 Thread Sergey Bylokhov
On 3/27/13 4:12 PM, Denis S. Fokin wrote: Hi Sergey, why we do not use Math.round() here? Region.java: 153 return (int) Math.floor(newv + 0.5); Just because it one additional call. Thank you, Denis. On 3/26/2013 7:33 PM, Sergey Bylokhov wrote: Hello, Please review the fix

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-27 Thread Sergey Bylokhov
this change, applets unsuitable for use in hidpi mode under quartz-debug(our sqe use it also). Moreover I assume, that the display bounds constrain is incorrect anyway. -- best regards, Anthony On 3/26/2013 19:33, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. Change adds initial

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-28 Thread Sergey Bylokhov
On 3/28/13 1:04 PM, Denis S. Fokin wrote: Hi Sergey, actually, the round function has a little bit more complicated implementation because of 6430675. Thanks for pointing this, I'll change the code. Thank you, Denis. On 3/27/2013 7:15 PM, Sergey Bylokhov wrote: On 3/27/13 4:12 PM

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-28 Thread Sergey Bylokhov
On 3/28/13 1:04 PM, Denis S. Fokin wrote: Hi Sergey, actually, the round function has a little bit more complicated implementation because of 6430675. Here is the new version: http://cr.openjdk.java.net/~serb/8000629/webrev.07 Thank you, Denis. On 3/27/2013 7:15 PM, Sergey Bylokhov

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-03-28 Thread Sergey Bylokhov
. Therefore I believe that this particular change deserves a separate CR. Could you file one please and remove the change from your current fix? Yes I'll rework it later, for now I create CR for it 8010999. -- best regards, Anthony -- best regards, Anthony On 3/26/2013 19:33, Sergey Bylokhov wrote

Re: [OpenJDK 2D-Dev] [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-05 Thread Sergey Bylokhov
Hi, Jim. I assume, that you haven't additional comments? Can I consider you as the second reviewer? Note that I plan push it to awt-dev because, my other fixes depend on it. On 3/26/13 7:33 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. Change adds initial support of hidpi

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-09 Thread Sergey Bylokhov
also change the performance as I'm just speculating from how I remember the optimizations work...) When it was written, I was impressed by a code in the 2D. ...jim On 4/8/2013 6:10 AM, Sergey Bylokhov wrote: Hi, Phil, JIm. New version of the fix: http://cr.openjdk.java.net/~serb

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-09 Thread Sergey Bylokhov
the optimizations work...) ...jim On 4/8/2013 6:10 AM, Sergey Bylokhov wrote: Hi, Phil, JIm. New version of the fix: http://cr.openjdk.java.net/~serb/8000629/webrev.08 - Assumption that we should scale all native surfaces was wrong. In case of managed Bufferedimage we shouldn't scale

Re: [OpenJDK 2D-Dev] AAShapePipe concurrency memory waste

2013-04-10 Thread Sergey Bylokhov
Hi, Laurent. I am not an expert here but just my 50 cents. This optimization shall take place only if it is really hotspot. But if it is a really hotspot - probably it would be better to remove these array/object allocation at all and use plane bytes? I see that some methods which take it as

Re: [OpenJDK 2D-Dev] AWT Dev [8] Request for review: 8000629 [macosx] Blurry rendering with Java 7 on Retina display

2013-04-10 Thread Sergey Bylokhov
Hi, Jim, Phil. Once again=) I assume, that you haven't additional comments? Can I consider you as the reviewers? Note that I plan push it to awt-dev because, my other fixes depend on it. On 4/5/13 10:10 PM, Sergey Bylokhov wrote: Hi, Phil. Could you please send me a screenshot and steps

Re: [OpenJDK 2D-Dev] AAShapePipe concurrency memory waste

2013-04-10 Thread Sergey Bylokhov
On 4/10/13 11:46 PM, Laurent Bourgès wrote: I see that some methods which take it as argument doesn't use them. And most of the time we pass AATileGenerator and abox[] to the same methods, so it could be merged? For now I did not want to modify the AAShapePipe signatures: abox[] is filled by

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-04-18 Thread Sergey Bylokhov
Hello Jim. On 1/17/13 4:56 AM, Jim Graham wrote: The original code in getClipBounds would end up returning a new Rectangle() if the clip was an empty rectangle due to the way that Rectangle2D/Path2D.getBounds() works. You now use setFrame(getBounds2D()) which will attempt to preserve the

Re: [OpenJDK 2D-Dev] Bug ID 7190349

2013-05-17 Thread Sergey Bylokhov
Hi, Patrick. I'll take a look to this issue. On 17.05.2013 21:45, Patrick Flaherty wrote: Hi, Our application (an applet) has suffered from a bug in Oracle Java implementation on the MaxOSX platform. The bug has been submitted for a while with no fix yet. The bug is Bug ID 7190349 and

[OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Sergey Bylokhov
Hello, Please review the fix for jdk 8. On OSX advanceY in the glyphInfo is inverted. It is used to increment position when the glyph is drawn as part of a string of text: @see DrawGlyphList.c.setupBlitVector(): for (g=0; glen; g++) { ginfo = (GlyphInfo*)imagePtrs[g];

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-21 Thread Sergey Bylokhov
also flip the sign of the y advance as it is stored as the image y advance. It looks like this was just missing here. This change should then only affect the final glyph rendering. -phil. On 5/21/2013 12:40 PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. On OSX advanceY

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-22 Thread Sergey Bylokhov
PM, Sergey Bylokhov wrote: Hello, Please review the fix for jdk 8. On OSX advanceY in the glyphInfo is inverted. It is used to increment position when the glyph is drawn as part of a string of text: @see DrawGlyphList.c.setupBlitVector(): for (g=0; glen; g++) { ginfo

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 [macosx] Text (Label) in a JTabbedPane is incorrectly drawn

2013-05-22 Thread Sergey Bylokhov
which won't benefit from a fix in JRSFontGetAdvancesForGlyphsAndStyle since that was invented for JDK 7. And I doubt Apple want to fix JDK 6 now. -phil. On 5/22/2013 10:42 AM, Sergey Bylokhov wrote: Hi, Phil, Mike. Looks like I found the root cause of this bug. It is caused by the different

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-06-06 Thread Sergey Bylokhov
don't think so... ...jim On 4/18/13 6:24 AM, Sergey Bylokhov wrote: Hello Jim. On 1/17/13 4:56 AM, Jim Graham wrote: The original code in getClipBounds would end up returning a new Rectangle() if the clip was an empty rectangle due to the way that Rectangle2D/Path2D.getBounds() works

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-06-10 Thread Sergey Bylokhov
Hello. Additional note is that this fix is targeted to 7u40. On 06.06.2013 22:38, Sergey Bylokhov wrote: HI, Jim. Can you review the updated version of the fix: http://cr.openjdk.java.net/~serb/8004859/webrev.03 I decided to implement an option, where transformed graphics (identity, translated

Re: [OpenJDK 2D-Dev] [8] Request for review: 8004859 Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform.

2013-07-02 Thread Sergey Bylokhov
Thanks, Jim! The second reviewer still needed. On 02.07.2013 6:40, Jim Graham wrote: Hi Sergey, This looks good to go... ...jim On 6/26/13 5:07 AM, Sergey Bylokhov wrote: Hello. No volunteers to review the fix? Thanks. On 10.06.2013 16:49, Sergey Bylokhov wrote: Hello

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8004859: Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform

2013-07-03 Thread sergey . bylokhov
Changeset: cacfc77655c8 Author:serb Date: 2013-07-03 19:00 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cacfc77655c8 8004859: Graphics.getClipBounds/getClip return difference nonequivalent bounds, depending from transform Reviewed-by: prr, flar !

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-03 Thread Sergey Bylokhov
Hi, Phil. On 03.07.2013 3:29, Phil Race wrote: This is fine with me, although we have an odd mixture of JRS and non JRS functions here and as you and others have asked or implied, I am not sure why we need any JRS functions in this part of the code. What do they do that we can't find from

Re: [OpenJDK 2D-Dev] [8] Request for review: 7190349 and 8013569.

2013-07-22 Thread Sergey Bylokhov
Hi, Phil. Can I push the fix? Because nobody have an additional comments. Deep testing of these changes is required, and I would like to start it earlier, than later. On 03.07.2013 3:29, Phil Race wrote: On 7/1/2013 7:57 AM, Sergey Bylokhov wrote: Hello. Can you take a look to the fix

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7190349: [macosx] Text (Label) is incorrectly drawn with a rotated g2d; ...

2013-07-26 Thread sergey . bylokhov
Changeset: a8b9df782017 Author:serb Date: 2013-07-26 21:18 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a8b9df782017 7190349: [macosx] Text (Label) is incorrectly drawn with a rotated g2d 8013569: [macosx] JLabel preferred size incorrect on retina displays with

Re: [OpenJDK 2D-Dev] Bug with stringWidth on Retina

2013-09-13 Thread Sergey Bylokhov
Hi. Konstantin. I guess this is a duplicate of http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013569 which was fixed in jdk8. can you try and confirm this? Thanks. On 13.09.2013 5:14, Konstantin Bulenkov wrote: Hi everyone, I've got a problem with the latest release of JDK7 (1.7.0_40-b43).

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-10-29 Thread Sergey Bylokhov
Hi, Alexander. The fix looks fine to me in general. But there is at least one issue. I build you fix and test it: - Consuming of cpu increased by 500 times Java2Demo on images tab. - FPS is dropped from 220(jdk8)/35(jdk7u40) to 15 in guimark2. Note that jdk6 has the same FPS(15) on my

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-06 Thread Sergey Bylokhov
On 07.11.2013 4:05, Clemens Eisserer wrote: getScaledImage() returns a scaled reference (not a copy) of the original image. So when the original image is changed, the scaled instance has to change too. When this is overriden like you suggest, this changes semantics of the API. In case

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-06 Thread Sergey Bylokhov
On 07.11.2013 4:09, Jim Graham wrote: On 11/6/13 3:09 PM, Sergey Bylokhov wrote: Hi , Jim. On 07.11.2013 1:40, Jim Graham wrote: On 11/6/13 5:19 AM, Alexander Scherbatiy wrote: On 11/6/2013 5:39 AM, Jim Graham wrote: Why is getScaledInstance() being consulted here? It seems a misuse

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-06 Thread Sergey Bylokhov
On 07.11.2013 6:01, Jim Graham wrote: On 11/6/13 5:20 PM, Sergey Bylokhov wrote: In other words: package sun.awt.image; public interface MultiResImage { public Image getResolutionVariant(float resolution); } public class MacImage extends Image implements MultiResImage { public

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-07 Thread Sergey Bylokhov
On 07.11.2013 11:01, Jim Graham wrote: On 11/6/13 6:15 PM, Sergey Bylokhov wrote: In this example there is a problem. For example we have 2 BufferedImages/ToolkiImagest A and B; Both wants be scaled perfectly. - Image A draws to the image B - Image B draws to the window. When window

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-13 Thread Sergey Bylokhov
On 12.11.2013 23:43, Jim Graham wrote: Hi Alexander, Some minor issues with this fix: - It looks like the transform is used in SG2D to decide if the hiDPI image should be used. I'm not familiar with the Mac's native use of @2x, but I thought that they hinged the decision off of the retina

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-13 Thread Sergey Bylokhov
On 13.11.2013 22:49, Jim Graham wrote: On 11/13/13 4:33 AM, Sergey Bylokhov wrote: On 12.11.2013 23:43, Jim Graham wrote: - The logic in using the transform is also a bit murky. I think if you set the scale on a retina display to exactly 1/2 it would use the HiDPI version even though

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-13 Thread Sergey Bylokhov
On 13.11.2013 23:25, Sergey Bylokhov wrote: - The logic in using the transform is also a bit murky. I think if you set the scale on a retina display to exactly 1/2 it would use the HiDPI version even though the scale was 1:1. Since I support not examining the transform there, I'm going

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-13 Thread Sergey Bylokhov
Hello, Jim. On 13.11.2013 22:49, Jim Graham wrote: That's could be a problem. Is it possible to wrap imageObserver, which was passed to the drawImage, and replace one image to another in the WrapperImageObserver.imageUpdate()? It's possible - the things to watch out for: - they could hand

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

2013-11-20 Thread Sergey Bylokhov
Hi, Sergey. Looks like in some cases, it is possible to replace p to the /p and close previous p tag. And I had a question to a 2D team. Is duplication in the header of [1] intended? [1] http://download.java.net/jdk8/docs/api/javax/print/attribute/standard/Sides.html Like: SINGLE_DOCUMENT

Re: [OpenJDK 2D-Dev] AWT Dev RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-26 Thread Sergey Bylokhov
has been already answered by Iris (thanks Iris). Thank you and best regards, Volker On Tuesday, November 26, 2013, Sergey Bylokhov wrote: On 26.11.2013 21:03, Alan Bateman wrote: On 26/11/2013 16:23, Volker Simonis wrote: Hi, thanks to everybody

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-27 Thread Sergey Bylokhov
Hello. Probably we are in a point when it is necessary to stop and move out all extensions to the separate bugs. We should give a time to our sqe to test these changes. Actually current version looks good to me. On 26.11.2013 2:31, Jim Graham wrote: On 11/25/13 5:51 AM, Alexander Scherbatiy

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-27 Thread Sergey Bylokhov
On 27.11.2013 15:12, Sergey Bylokhov wrote: Hello. Probably we are in a point when it is necessary to stop and move out all extensions to the separate bugs. We should give a time to our sqe to test these changes. Actually current version looks good to me. Small additional notes, It would

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-12-05 Thread Sergey Bylokhov
Hi, Alexander. Count me as a second reviewer. On 12/4/13 10:16 PM, Jim Graham wrote: Hi Alexander, It looks good to go. I only skimmed the other parts of the fix on the assumption that they haven't changed in a few revisions, but it all looked good. Glad to see you fixed the dimension

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-12 Thread Sergey Bylokhov
On 12/12/13 7:16 PM, Anton V. Tarasov wrote: [cc'ing to j2d] On 11.12.2013 14:38, Sergey Bylokhov wrote: On 11.12.2013 13:18, Anton V. Tarasov wrote: Hi Sergey, On 11.12.2013 3:26, Sergey Bylokhov wrote: Hi, Anton. My expectation was that everything should work automatically, if you get

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-12 Thread Sergey Bylokhov
On 12/12/13 11:27 PM, Jim Graham wrote: On 12/12/13 11:19 AM, Sergey Bylokhov wrote: On 12/12/13 7:16 PM, Anton V. Tarasov wrote: On 11.12.2013 14:38, Sergey Bylokhov wrote: On 11.12.2013 13:18, Anton V. Tarasov wrote: With Nimus, at some moment, when the nimbus.AbstractRegionPainter.paint

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-13 Thread Sergey Bylokhov
bother about getRGB for now) eliminates the need to translate to layout bounds in SG2D and unifies the code. So, I'm going this way... Thanks, Anton. On 12/13/13 2:54 AM, Jim Graham wrote: On 12/12/13 2:33 PM, Sergey Bylokhov wrote: On 12/12/13 11:27 PM, Jim Graham wrote: The only real

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2013-12-17 Thread Sergey Bylokhov
Hi, Anton. Since OffScreenHiDPIImage looks similar to VolatileImage. Why we cannot use VolatileImage inside Swing everywhere? What happens if the graphicsConfig for the particular offscreen image will be changed/remoed/disposed? I suppose Volatile should became invalid in this case.

Re: [OpenJDK 2D-Dev] AWT Dev JDK 9 RFR of JDK-8031082 Fix non-missing doclint problems in client libraries

2014-01-08 Thread Sergey Bylokhov
Hello, Joe. Why @see tag was removed in the ComponentPeer.java? In the JLabel.java @exception was removed is this change of specifications? It would be good to split the changed line in the MouseInfoPeer.java. On 09.01.2014 5:08, Joseph Darcy wrote: Happy new year! Happy new year! In case

Re: [OpenJDK 2D-Dev] AWT Dev JDK 9 RFR of JDK-8031082 Fix non-missing doclint problems in client libraries

2014-01-10 Thread Sergey Bylokhov
On 09.01.2014 23:56, Joe Darcy wrote: Hello Sergey, On 1/8/2014 11:53 PM, Sergey Bylokhov wrote: Hello, Joe. Why @see tag was removed in the ComponentPeer.java? Because they were resulting in error: reference not found messages. The syntax appears correct, but the error is generated anyway

Re: [OpenJDK 2D-Dev] AWT Dev JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Sergey Bylokhov
Hello, Joe. Some comments: - in the SunDropTargetContextPeer.java file header changed only - Incorrect modification of if statement in D3DSurfaceDataProxy.java - It is not necessary to use class name in StyledEditorKit.java and HTMLEditorKit.java, because defaultActions is a private static

Re: [OpenJDK 2D-Dev] AWT Dev JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Sergey Bylokhov
Hello, Joe. Thanks. The fix looks good. On 17.01.2014 23:30, Joe Darcy wrote: Hi Sergey, On 01/17/2014 02:28 AM, Sergey Bylokhov wrote: Hello, Joe. Some comments: - in the SunDropTargetContextPeer.java file header changed only Reverted. - Incorrect modification of if statement

Re: [OpenJDK 2D-Dev] AWT Dev JDK 9 RFR of JDK-8032047: Fix static lint warnings in client libraries

2014-01-17 Thread Sergey Bylokhov
. Petr. 18 янв. 2014 г., в 1:47 до полудня, Sergey Bylokhov sergey.bylok...@oracle.com написал(а): Hello, Joe. This version looks good to me too. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

2014-01-31 Thread Sergey Bylokhov
On 26.01.2014 13:30, Alan Bateman wrote: As a side point, client changes have been going into jdk9/client rather than jdk9/dev so I just wonder if there might be changes backed up in jdk9/client that might cause issues when merged. It will be really good to push all fixes related to client to

Re: [OpenJDK 2D-Dev] RFR: Fix for 8032693 : javax.print.PrintService does not find any CUPS-Printers on Linux

2014-02-07 Thread Sergey Bylokhov
Hi , Phil. Why we catch Throwable(OutOfMemoryError)? Probably we can use java generics in defaultMap in CUPSPrinter? Code from the test: 42 if (!os.equals(linux)) { 43 System.out.println(Linux specific test. No need to continue); 44 } No need to continue... and

Re: [OpenJDK 2D-Dev] RFR: Fix for 8032693 : javax.print.PrintService does not find any CUPS-Printers on Linux

2014-02-07 Thread Sergey Bylokhov
On 08.02.2014 0:35, Phil Race wrote: 42 if (!os.equals(linux)) { 43 System.out.println(Linux specific test. No need to continue); 44 } No need to continue... and continue anyway? Oops. Meant to have a return there :) I'll fix before I push. Anything else ? No. The fix

Re: [OpenJDK 2D-Dev] [PATCH] Re: JDK-8012351

2014-02-10 Thread Sergey Bylokhov
Hi, Phil. - Should we catch situations, when the getParentFile will return null, and change 'return newDir.equals(existDir)' to 'return Objects.equals(newDir, existDir)'? - I suppose it was a typo = in SunFontManager? Otherwise the fix looks good, but note that I'm not an expert in this

[OpenJDK 2D-Dev] [9] Review Request: 8037868 The build is broken after the JDK-8035630

2014-03-19 Thread Sergey Bylokhov
Please review the small fix: diff -r fe79a65a51d8 src/windows/native/sun/font/fontpath.c --- a/src/windows/native/sun/font/fontpath.cWed Mar 19 16:13:59 2014 +0400 +++ b/src/windows/native/sun/font/fontpath.cWed Mar 19 20:40:44 2014 +0400 @@ -155,7 +155,7 @@ if (fullname == NULL)

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-03-20 Thread Sergey Bylokhov
Hi, Alexander. Probably it will be better to provide device transform to the user instead of float logicalDPIX, float logicalDPIY? It is unclear what does it mean width for example. It is initial width of the image, or width after transformation? On 3/20/14 6:52 PM, Alexander Scherbatiy

Re: [OpenJDK 2D-Dev] [9] request for review: 8036022: D3D: rendering with XOR composite causes InternalError.

2014-03-20 Thread Sergey Bylokhov
Hi, Andrew. The fix looks good to me too. On 3/20/14 4:51 AM, Jim Graham wrote: Hi Andrew, revalidateAll() unconditionally calls validatePipe() which will do all of the work for choosing pipelines again anyway (I don't think any implementations of validatePipe try to share too much, do

Re: [OpenJDK 2D-Dev] RFR: 6 backports pf JNI fixes for OS X from JDK9 to 8u20

2014-03-31 Thread Sergey Bylokhov
Hi, Phil. Looks fine. On 30.03.2014 2:00, Phil Race wrote: Sergey Jennifer, Please review/check 6 MacOSX backports of JNI correctness fixes of changes you previously reviewed approved for JDK 9. They are all one per-file and exact copies of what was pushed into jdk9/client. I have tested

Re: [OpenJDK 2D-Dev] RFR: 8u20 backport of 8029008: JNI warning in sun/font

2014-03-31 Thread Sergey Bylokhov
Hi, Phil. looks good. On 29.03.2014 1:12, Phil Race wrote: Please sanity check this backport .. Code : http://cr.openjdk.java.net/~prr/8029008.8u20/ Bug https://bugs.openjdk.java.net/browse/JDK-8029008 JDK 9 changeset :- http://hg.openjdk.java.net/jdk9/client/jdk/rev/f0f8960831c1 Note that

Re: [OpenJDK 2D-Dev] RFR 3 windows related JNI correctness backports to jdk8u20

2014-04-03 Thread Sergey Bylokhov
Hi, Phil. looks good. On 4/2/14 1:34 AM, Phil Race wrote: Sergey Jennifer, Please review 3 mostly windows related JNI correctness backports to jdk8u20 that you previously approved for JDK 9 Bug link: https://bugs.openjdk.java.net/browse/JDK-8035623 Synopsis: [parfait] JNI exception pending

[OpenJDK 2D-Dev] [9] Review Request: 8032219 [macosx] Scrollbars looks bad under retina in Motif and Metal LF

2014-04-04 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. The problem became visible, when we draw a border across the component using drawLine, and expected that fillRect will clear a border of the component. This is incorrect, because in case of the scaled graphics(retina) some part of the line can be placed

Re: [OpenJDK 2D-Dev] RFR: JDK8u20 backport of 8035569: JNI correctness fixes in WPrinterJob.cpp

2014-04-05 Thread Sergey Bylokhov
Hi, Phil. Looks like webrev/jbslink for JDK8u20 are for other fix. On 4/5/14 12:34 AM, Jennifer Godinez wrote: Looks good. Jennifer On 4/4/2014 12:01 PM, Phil Race wrote: Jennifer Sergey, Please check the identical JDK8u20 backport of the fix for the JNI corrrectness fix in WPrinterJob.cpp

Re: [OpenJDK 2D-Dev] RFR: JDK8u20 backport of 8031095: warning from jdk/src/solaris/native/sun/awt/awt_Font.c: memory leak

2014-04-05 Thread Sergey Bylokhov
Hi, Phil. looks good. On 4/4/14 10:29 PM, Phil Race wrote: Jennifer Andrew, Please check the identical JDK8u20 backport of the fix for the (theoretical) memory leak in awt_Font.c that you approved for JDK9 Bug link: https://bugs.openjdk.java.net/browse/JDK-8031095 Synopsis: [Parfait]

Re: [OpenJDK 2D-Dev] RFR: JDK8u20 backport of 8035569: JNI correctness fixes in WPrinterJob.cpp

2014-04-07 Thread Sergey Bylokhov
Hi, Phil. Looks fine. On 07.04.2014 1:31, Phil Race wrote: On 4/5/14 8:14 AM, Sergey Bylokhov wrote: Hi, Phil. Looks like webrev/jbslink for JDK8u20 are for other fix. I think that's because I hand-edited the URL in thunderbird and it changed the visible text but not the actual link :-( So

[OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

2014-04-08 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call. [1]: JNIEXPORT void JNICALL Transform_GetInfo(JNIEnv *env, jobject txform, TransformInfo *pTxInfo) { pTxInfo-dxdx =

[OpenJDK 2D-Dev] [9] Review Request: 8039774 [OGL] Image painting is broken if 'sun.java2d.accthreshold' is set to 0

2014-04-10 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. The bug occurs, when we try to call drawImageBg with scale and 'sun.java2d.accthreshold' is set to 0. The bug exists in the DrawImage.renderImageXform(). This method is called, when all our attempts to scale the image fails, and we create a buffered

[OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-21 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. This issue initially was found in FX[1], and there is description of this problem. In the fix the flip operation is done using memcpy after the whole image was moved from gpu to cpu. [1] https://javafx-jira.kenai.com/browse/RT-30035 Bug:

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-21 Thread Sergey Bylokhov
, the fast path skips j2d_glPixelStorei(GL_PACK_SKIP_ROWS, dsty). Could you please clarify why? I think that initial value of dsty (dstInfo.bounds.y1) can be non-zero, and this operation seem to be required... Thanks, Andrew On 4/21/2014 6:17 PM, Sergey Bylokhov wrote: Hello. Please review

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-21 Thread Sergey Bylokhov
clarify why? I think that initial value of dsty (dstInfo.bounds.y1) can be non-zero, and this operation seem to be required... Thanks, Andrew On 4/21/2014 6:17 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This issue initially was found in FX[1], and there is description

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-21 Thread Sergey Bylokhov
. ...jim On 4/21/14 7:17 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This issue initially was found in FX[1], and there is description of this problem. In the fix the flip operation is done using memcpy after the whole image was moved from gpu to cpu. [1] https

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-23 Thread Sergey Bylokhov
, and this operation seem to be required... Thanks, Andrew On 4/21/2014 6:17 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This issue initially was found in FX[1], and there is description of this problem. In the fix the flip operation is done using memcpy after the whole

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-24 Thread Sergey Bylokhov
worry that we are being inconsistent in whether or not we set the SKIP_ values. This function sets them back to 0 when done, but can we assume that about all code that uses these methods? ...jim On 4/23/14 1:46 PM, Sergey Bylokhov wrote: Hello. Please review an updated version

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-25 Thread Sergey Bylokhov
by default means it has some issues. Moreover I think it is better to run all tests with -Dsun.java2d.opengl=True when needed. Thanks, Andrew On 4/24/2014 10:43 PM, Sergey Bylokhov wrote: Hi, Jim. Yes, we shouldn't depend on default values of SKIP_** The new version of the fix: http

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-04-29 Thread Sergey Bylokhov
are being inconsistent in whether or not we set the SKIP_ values. This function sets them back to 0 when done, but can we assume that about all code that uses these methods? ...jim On 4/23/14 1:46 PM, Sergey Bylokhov wrote: Hello. Please review an updated version of the fix. Bugs

[OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

2014-04-30 Thread Sergey Bylokhov
Hello. Please review the small fix for jdk 9. Makefile and README were fixed. Bug: https://bugs.openjdk.java.net/browse/JDK-8042199 Webrev can be found at: http://cr.openjdk.java.net/~serb/8042199/webrev.00 -- Best regards, Sergey.

[OpenJDK 2D-Dev] [9] Review Request: 8042103 Deserialization of empty java.awt.geom.Path2D will cause an exception

2014-04-30 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. needRoom() method does not take into account that current array of types can be empty. In this case it fails to increase it. I handle this case and increase the size of the array by 1 instead of INIT_SIZE, because I assume that the user intentionally try

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042103 Deserialization of empty java.awt.geom.Path2D will cause an exception

2014-05-05 Thread Sergey Bylokhov
for that. ...jim On 4/30/14 8:52 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. needRoom() method does not take into account that current array of types can be empty. In this case it fails to increase it. I handle this case and increase the size of the array by 1

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

2014-05-07 Thread Sergey Bylokhov
). 2008080 - when I draw to BI_ARGB_PRE via transparent VI(on d3d and gdi)? Who is right? On 29.04.2014 23:25, Sergey Bylokhov wrote: Hello, Jim. I have started working with another issue, which touches the same code. https://bugs.openjdk.java.net/browse/JDK-8017626 The problem is clear our surface

[OpenJDK 2D-Dev] [9] Review Request: 8041129 and 8017626

2014-05-12 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. This a second iteration of the fix for 8041129, because it was changed to cover 8017626 as well. Description of the problem: 8041129: [OGL] surface-sw blit is extremely slow - The problem is in the glReadPixels(), which is really slow and we call it

Re: [OpenJDK 2D-Dev] AWT Dev JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-13 Thread Sergey Bylokhov
Hi, Paul. adding 2d-dev@ media: sound/awt/swing part looks fine. Note that this part of the fix should be pushed to client forest. On 5/12/14 2:03 PM, Paul Sandoz wrote: Hi, This is a request for review of Otavio's patch replacing StringBuffer with StringBuilder within OpenJDK. (I also need

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: JDK-8029455 JLightweightFrame: support scaled painting

2014-05-13 Thread Sergey Bylokhov
On 5/13/14 9:29 PM, Anthony Petrov wrote: Hi Jim, Sergey, and Anton, I'd like to revive this old thread and finally push this fix, which has been reviewed and approved on this mailing list back in February. The only additional change that I want to introduce, is the addition of default

Re: [OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

2014-05-14 Thread Sergey Bylokhov
Hi, Andrew. The fix looks good. On 5/9/14 2:27 AM, Andrew Brygin wrote: Hello Phil, I have corrected both occurrences of the typo: http://cr.openjdk.java.net/~bae/6945174/9/webrev.01/ Thanks, Andrew On 5/9/2014 2:04 AM, Phil Race wrote: Looks OK but please fix the typo in the exception

  1   2   3   4   5   6   7   >