ktop/share/classes/javax/sound/sampled/TargetDataLine.java
> src/java.desktop/share/classes/javax/swing/SizeSequence.java
>
> --alex
>
> On 05/04/2017 18:15, Sergey Bylokhov wrote:
> > Hello,
> > Please review the fix for jdk9-dev.
> > This fix is a part of the effort t
Vote: yes
- philip.r...@oracle.com wrote:
>
I hereby nominate Laurent Bourges to membership in the 2D group.
>
> Laurent is the principal (almost sole) author of the Marlin Renderer
> contributed
> into OpenJDK via the Graphics Rasterizer project [1] and integrated into JDK
> 9
> via
n "Image" without
> even realizing that it is an MRI in the first place so this is only
> for those who want to manipulate MRIs)...
>
> ...jim
>
> On 3/29/17 1:22 PM, Sergey Bylokhov wrote:
> > Hi, Jim, Phil.
> > I have started to use MR
va/awt/font/TextAttribute.html
- philip.r...@oracle.com wrote:
> Adding 2d-dev because a number of the files are 2D.
>
> What is the general reason for changing the appearance of the tables?
>
> -phil.
>
> On 5/12/17, 4:25 PM, Sergey Bylokhov wrote:
> > Hello,
> > Pl
all the table summaries removed ?
>
> -phil.
>
> On 5/12/17, 4:52 PM, Sergey Bylokhov wrote:
> > This is because I use the same style for most of the tables
> 'class="striped"', which apply the same/unified style for all(most) of
> our tables.
> > Also this i
; to
> >>>> be visible when we were fine without.
> >>>>
> >>>> But being there and invisible may be pointless unless screen
> >>>> readers look for it even if invisible.
> >>>>
> >>>> But if its not doing a
Hello,
Please review the fix for jdk9.
This fix is a part of the effort to opensource the tests in jdk.
In the fix a number of tests for ImageIO are moved to the open ws.
Note that most of the code moved as-is, and probably can be improved in the
future, but I tried to limit the number of changes
rights for the image just
> to ensure the intended functionality is tested.
>
> Thanks
> Have a good day
>
> Prahalad N.
>
> -Original Message-
> From: Sergey Bylokhov
> Sent: Saturday, May 20, 2017 7:51 AM
> To: Jayathirth D V; Philip R Race
> Cc: 2d-De
Hi,
The question is related to Java2D API and 2d-dev (cc).
- timo.vander.sch...@globalrelay.net wrote:
> Hi,
>
> The front-end generates a base64 encoded image of a graph and send it
> to the backend to use it with pdfbox to create a pdf file.
> Are there any security concerns with in partic
Hi, Sean.
The correct mailing list for discussion of such issues is: 2d-dev (cc).
- srei...@seanreilly.com wrote:
> There seems to be a big printing problem using recent JDKs when
> running within the macOS sandbox as of 10.12.4.
>
> Looking at the jdk8 sources, CUPSfuncs.c seems to ignore t
> The fix is fine but rather than deleting the test just mark it @ignore
>
> .. it can be then updated
> with a new version of the fix.
+1
>
>
> -phil.
>
> On 6/1/17, 11:19 AM, Anton Litvinov wrote:
> > Hello,
> >
> > Could you please review the following fix for the bug.
> >
> > Bug: https:/
t;> Caption sounds like a title so it might actually be more
> > >>>> appropriate than summary
> > >>>> for the text we have except that its not clear why we'd want
> it
> > to
> > >>>> be visible when we were fine without.
>
I did not check the all code, but small comment: Note that all Swing components
should be always accessed on EDT. If InvokeAnDWait does not work then you can
use InvokeLater().
>
> The manual test template that I received from the team seems buggy and an
> older version it seems. I have modif
I know that HTML parsers are usually forgiving such things. But sometimes it
may make thing worse:
>
https://stackoverflow.com/questions/7125354/what-are-the-actual-problems-of-not-closing-tags-and-attributes-in-html/7135378#7135378
Thanks,
Alexander.
> On 05/06/2017 06:23, Sergey Bylokh
Hello,
Please review the fix for jdk9-dev.
A few types of links were fixed:
- The fix for JDK-8178412 missed some links to IMF.
- The links to jar.html#service_provider were changed to {@link ServiceLoader}
- The links to a.html were changed to «{@docRoot}/specs/jar.html» see
JDK-8150681
Bug:
Hi, Mandy.
I rechecked this fix on top of JDK-8150681, and found that the jar/jar.html
was not copied to the "/images/docs/specs/« but for example «serialization» is
copied.
>> - The links to a.html were changed to «{@docRoot}/specs/jar.html» see
>> JDK-8150681
>>
>> Bug: https://bugs.open
It seems that there is an issue in generation of html files from .md. But I
have verified the new links by creating specs/jar/jar.html manually:
http://cr.openjdk.java.net/~serb/8181894/webrev.01
>
> Hi, Mandy.
> I rechecked this fix on top of JDK-8150681, and found that the jar/jar.html
> was
Hello,
Please review the fix for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8183576
Webrev can be found at: http://cr.openjdk.java.net/~serb/8183576/webrev.00
The method setRGB(int x, int y, int rgb) in BufferedImage is synchronized, but
all other methods in this class are not. For exa
I guess the only change which is needed is to wrap the test() method in the try
catch and
add "Files.delete(file.toPath());fos.close();" to the finally block. It seems
will have less code. It is unclear why the test was changed to the manual?
- prahalad.kumar.naraya...@oracle.com wrote:
>
Hi Shashi.
I suggest to add a finally to the try block in the test() method and delete the
file, close the stream and close the reader there.
- shashidhara.veerabhadra...@oracle.com wrote:
> [10]JDK-8183341:Better cleanup for javax/imageio/AllowSearch.java
Hi All,
Please review a fix
Wednesday, July 12, 2017 11:46 AM
> To: Sergey Bylokhov; Prahalad Kumar Narayanan
> Cc: 2d-dev@openjdk.java.net
> Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8183349: Better cleanup for
> jdk/test/javax/imageio/plugins/shared/CanWriteSequence.java and
> WriteAfterAbort.java
>
>
+1
On 12.07.2017 22:27, Prahalad Kumar Narayanan wrote:
Hello Jay
Minor changes have been added.
Looks good.
Thank you
Have a good day
Prahalad N.
-Original Message-
From: Jayathirth D V
Sent: Wednesday, July 12, 2017 4:05 PM
To: Sergey Bylokhov; Prahalad Kumar Narayanan
Cc: 2d-dev
Hello,
Please review the fix for jdk10.
The cleanup was done in the same way as for datatransfer, sound and
accessibility packages(see links in the CR).
I suggest to check the specdiff first, because for some methods the
specification was reworked. CSR will be filed after technical review.
B
Hello,
Please review the fix for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8185093
Webrev can be found at: http://cr.openjdk.java.net/~serb/8185093/webrev.00
jmh test: http://cr.openjdk.java.net/~serb/8185093/LocalGEproblem.java
While working on some other bug I found a performance is
rst call there was not any
synchronization(like in case of "synchronized" and "volatile").
Here some additional information which I used:
https://shipilev.net/blog/2014/safe-public-construction/
...jim
On 7/24/17 5:09 PM, Sergey Bylokhov wrote:
Hello
On 25.07.2017 15:03, Jim Graham wrote:
On 7/25/17 12:53 PM, Sergey Bylokhov wrote:
In this variant the field should be volatile, and this will introduce
some synchronization. Otherwise it will be possible to read non-null
value in localEnv while the constructor of GraphicsEnvironment was not
DRAFT version of CSR:
https://bugs.openjdk.java.net/browse/JDK-8185542
- philip.r...@oracle.com wrote:
> On 07/24/2017 05:09 PM, Sergey Bylokhov wrote:
> >
> >
> > The main issue which I would like to clarify is it possible to
> remove
> >
Hi, Shashi.
As far as I understand the "width/height" in the IconCanvas is a size of the
TrayIcon in pixels. So on the normal screen it is should be 24(TRAY_ICON_WIDTH)
pixels and on a HiDPI screen it should be 24*ScreenScale. The
IconCanvas.width/height fields should reflect this size.
I am no
Any volunteers? =)
On 16.07.2017 16:42, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The cleanup was done in the same way as for datatransfer, sound and
accessibility packages(see links in the CR).
I suggest to check the specdiff first, because for some methods the
Looks fine.
On 07.08.2017 2:31, Dmitry Batrak wrote:
Hello,
I'd like to propose a fix for JDK-8174744.
bug: https://bugs.openjdk.java.net/browse/JDK-8174744
webrev: http://cr.openjdk.java.net/~dbatrak/8174744/webrev.00/
I don't have a Committer status, so I'll require a sponsor.
The fix
intService.java 47 * output in a format useful in
other contexts. StreamPrintService's should have {@code
StreamPrintService} This is what I have looked so far.
Fixed.
Regards
Prasanta
On 7/17/2017 5:12 AM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The cleanup was done
t the window configuration of the tray icon ( because metacity WM
provides rectangular window instead of a square w in dow ) .
Thanks and regards,
Shashi
-----Original Message-
> From: Sergey Bylokhov
> Sent: Wednesday, August 2, 2017 2:45 AM
> To: Shashidhara Veerabhadraia
On 13.08.2017 23:23, Prasanta Sadhukhan wrote:
In that case, will this be required to have 2nd part?
43 * {@link DocFlavor DocFlavor}
There are manyof them in other files too like DocFlavor.java
1206 * stream ({@link java.io.Reader java.io.Reader} Other than that, it
looks ok to me (btw, I have
+1
- philip.r...@oracle.com wrote:
> For the record I fixed both of those :
> http://cr.openjdk.java.net/~prr/8184135.1/
>
> -phil.
>
> On 08/15/2017 10:41 PM, Prasanta Sadhukhan wrote:
> > Just some nits
> >
> > XToolkit.java
> >
> > 2176 * If backing store is not available on at leas
Hello.
CSR is created:
https://bugs.openjdk.java.net/browse/JDK-8186753
On 21.08.17 20:03, Sergey Bylokhov wrote:
On 13.08.2017 23:23, Prasanta Sadhukhan wrote:
In that case, will this be required to have 2nd part?
43 * {@link DocFlavor DocFlavor}
There are manyof them in other files too
+1
On 8/31/17 12:21, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8183351
Webrev: http://cr.openjdk.java.net/~prr/8183351/
This bug caused an internal test system to report a failure of this test
when the userid used to run the tests changed due to lack of this cleanup,
so I'd
+1
On 9/2/17 04:24, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
Request your time in reviewing the bug fix for
. JDK-8187113test/javax/imageio/plugins/png/PngCreationTimeTest.java fails
Root cause:
. The Jtreg test- PngCreationTimeTest.java, requires an input image fil
Hello,
Please review the fix for jdk10.
This is the first step to cleanup these warnings:
http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html
Bug: https://bugs.openjdk.java.net/browse/JDK-8184219
Webrev can be found at: http://cr.openjdk.java.net/~serb/8184219/webre
Hello,
Please review the trivial cleanup for jdk10.
Bug: https://bugs.openjdk.java.net/browse/JDK-6238123
Webrev can be found at: http://cr.openjdk.java.net/~serb/6238123/webrev.00
--
Best regards, Sergey.
Hello,
Please review the fix for jdk10.
Some of the tidy warnings were fixed.
Report is here:
http://cr.openjdk.java.net/~jjg/doc-report/jdk-by-module/java.desktop/report.html
Description:
- java/awt/Desktop.java: the links to "developer.apple.com" were
removed, it seems that the URLs for thes
developer docs"
to find out what
that and Info.plist are .. even if it not a direct link.
-phil.
On 09/13/2017 03:39 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
Some of the tidy warnings were fixed.
Report is here:
http://cr.openjdk.java.net/~jjg/doc-report/j
Hi, Semyon.
Is it possible to write a test case for this issue? It will be helpful
to understand the bug and a fix.
On 9/18/17 09:36, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK10 (in Swing and Java2D):
bug: https://bugs.openjdk.java.net/browse/JDK-8187367
webrev: http://cr.open
Looks fine.
I guess we should update TestLayoutVsICU.java test which was added as
part of harfbuzz integration. I assumed that it should compares behavior
against icu, but it seems it is never executed.
On 12/10/2017 10:45, Steven R. Loomis wrote:
approve
On Wed, Oct 11, 2017 at 9:59 AM, Phi
FYI.
The fix was updated based on offline comments from Jonathan Gibbons(he
approved the fix).
http://cr.openjdk.java.net/~serb/8184219/webrev.02
On 02/09/2017 17:58, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
This is the first step to cleanup these warnings:
http
Hello.
If there are no other comments I'll push the .01 version of fix.
On 13/10/2017 01:04, Alexander Zvegintsev wrote:
+1
Thanks,
Alexander.
On 16/09/2017 07:16, Sergey Bylokhov wrote:
That's of course a stylistic issue, but I think that the keywords(not
necessary a java) look b
Hello,
Please review the fix for.
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.html
8183508: multi_tsc.html should be updated
8181289: Invalid HTML 5 in AWT/Swing docs
Description:
- Illegal characters were removed.
- Unsupported tags/properties were r
attribute works with any element.
For example:
Definitions
should be
Definitions
--Semyon
On 10/23/2017 02:42 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for.
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.htm
Hi, Phil.
Should we update help.m4 as well and add a message for fontconfig like
we do for cups and others?
cups)
PKGHANDLER_COMMAND="sudo apt-get install libcups2-dev" ;;
cups)
PKGHANDLER_COMMAND="sudo yum install cups-devel" ;;
On 24/10/2017 14:15, Philip Race wrote:
Bug
On 24/10/2017 14:56, Semyon Sadetsky wrote:
On 10/24/2017 12:02 PM, Sergey Bylokhov wrote:
Hi, Semyon
I guess I did not add a new tags, it seems that this tag is used
as an anchor everywhere and since it is allowed in html5 its usage was
preserved.
Starting version 9 JDK supports the html5
Hi, Prahalad.
Can you please add a stack trace which include a line numbers to the bug
report? Currently it is unclear in what line an exception is occurred.
On 25/10/2017 21:07, Prahalad Kumar Narayanan wrote:
Hello Everyone
Good day to you.
Kindly review a fix for the bug
Bug ID: JDK-
Looks fine.
On 26/10/2017 07:28, Mario Torre wrote:
2017-09-27 15:52 GMT+02:00 Mario Torre :
Hi all,
I would like to propose a fix for
https://bugs.openjdk.java.net/browse/JDK-8188030.
The issue is basically that CFF fonts are considered better match than
Type 1, but are discarded, leaving th
ence of the exception at
FilteredImageSource.java: 181.
. The image also shows the test passing with JDK10 containing the
fix on VM running Linux Ubuntu x64.
Thank you
Have a good day
Prahalad N.
-Original Message-----
From: Sergey Bylokhov
Sent: Thursday, October 26, 2017 12:05 PM
To: Prah
Looks fine.
On 01/11/2017 11:09, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8190280
Webrev: http://cr.openjdk.java.net/~prr/8190280/
This is a JDK8 version of the bug
https://bugs.openjdk.java.net/browse/JDK-8172967
which affected harfbuzz in JDK 9
It is triggered by a
Hi, Pankaj.
The BufferedImage class is a raster in the memory which should be
unrelated to any grpahics config on the system. So this class should not
be changed, but instead you should create a correct BI-as a back buffer
which takes into account the size of the window and the scale of the GC.
Hello,
Please review the fix for jdk10.
Description:
The tests were reworked to use only 2d api. The check for VolatileImage
is added just to improve code coverage and it is executed only in
headful mode.
This is a request to move the update tests to the open ws.
I have checked that the updat
Hi, Pankaj.
This version will creates back-buffer every time the paint/update is
fail, but before the fix it was created only once before painting.
On 06/11/2017 04:23, Pankaj Bansal wrote:
I tested this on a machine which supports D3D pipeline. It fails with uiScale >
1.0 with -Dsun.java2d.d
Thanks for clarification. Looks fine.
One more thing which can improve the fix is to add "uiScale > 1.0" as an
additional @run step to the tests, so these tests will fail before the
fix even on common lowdpi(100%) systems.
On 06/11/2017 23:20, Pankaj Bansal wrote:
I am assuming you are talkin
the additional @run with uiScale in 5 tests that fail without
fix and PerPixelTranslucentSwing.java as this is a test problem and this test
fails when corrected
Webrev:
http://cr.openjdk.java.net/~pbansal/8164811/webrev.03/
Regards,
Pankaj Bansal
-Original Message-
From: Sergey Byl
-
From: Pankaj Bansal
Sent: Wednesday, November 8, 2017 8:09 PM
To: Sergey Bylokhov; awt-...@openjdk.java.net; 2d-dev@openjdk.java.net; Philip
Race
Subject: RE: [10] Review Request: JDK-8159142 : Visible artifacts in
sun/java2d/SunGraphics2D/DrawImageBilinear.java
+ 2d-dev, Phil.
Regards
Looks fine.
I guess we should do same cleanup in the closed repo as well.
On 07/11/2017 15:08, Philip Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8186306
webrev: http://cr.openjdk.java.net/~prr/8186306/
This fix removes the pisces rasterizer code since it is superseded by
marlin.
be re-visited if we
subsequently find problems as a result of this fix.
done.
-phil.
On 09/19/2017 07:58 AM, Semyon Sadetsky wrote:
On 09/18/2017 12:01 PM, Sergey Bylokhov wrote:
Hi, Semyon.
Is it possible to write a test case for this issue? It will be
helpful to understand the bug and
Hi, Laurent.
On 14/11/2017 14:03, Laurent Bourgès wrote:
PS: I added the new ClipShapeTests with special jtreg tags: what is the
default timeout ? The complete tests are slow ~ 20mins, so I added
@ignore but it marks the test as failed.
Why not split it across the threads? 5~7 minutes is not a
On 15/11/2017 00:50, Laurent Bourgès wrote:
Good idea but it can not work:
- I use specific a system property to enable/disable Marlin clipping
support at runtime
- it is by nature not thread safe !
You can generate a number of images using a few threads when the flag is
on then switch it of
et you know.
Regards,
Pankaj Bansal
-Original Message-
From: Prahalad Kumar Narayanan
Sent: Tuesday, November 14, 2017 3:15 PM
To: Sergey Bylokhov; Pankaj Bansal; awt-...@openjdk.java.net;
2d-dev@openjdk.java.net; Philip Race
Subject: RE: [OpenJDK 2D-Dev] [10] Review Request: JDK-8159142
If there are no other comments about this review, I'll push the first
version(.00) of the fix.
On 23/10/2017 14:42, Sergey Bylokhov wrote:
Hello,
Please review the fix for.
8182410: missing 'title' in
api/javax/swing/plaf/synth/doc-files/componentProperties.html
8183508:
Hi,Prahalad.
On 24/11/2017 21:40, Prahalad Kumar Narayanan wrote:
Based on discussions with Sergey, I 've now updated the fix with a test case.
The changes are available for review under:
http://cr.openjdk.java.net/~pnarayanan/8188083/webrev.01/
This version of the test is always passed before
On 27/11/2017 14:02, Semyon Sadetsky wrote:
> The current changes get my "+1" as comformant HTML5.
This is not true. The empty tags produce warnings in HTML5 validator:
https://validator.w3.org/nu/?doc=http%3A%2F%2Fcr.openjdk.java.net%2F~ssadetsky%2F8181289%2Fjdoc%2FmodB-summary.html
The w
e-out.
Thank you once again for your time
Have a good day
Prahalad
-Original Message-----
From: Sergey Bylokhov
Sent: Monday, November 27, 2017 9:11 PM
To: Prahalad Kumar Narayanan; 2d-dev
Cc: Philip Race
Subject: Re: [OpenJDK 2D-Dev] [10]
ctly from user code, the result is un-defined.
Since our JTreg test cases cannot violate the documented guide, I refrained
from attaching the test case in the first webrev.
Kindly let me know your views to this.
Thank you once again
Have a good day
Prahalad
-Original Message-----
Fr
u for your time
Have a good day
Prahalad
-Original Message-----
From: Sergey Bylokhov
Sent: Tuesday, November 28, 2017 11:14 PM
To: Prahalad Kumar Narayanan; 2d-dev
Cc: Philip Race
Subject: Re: [OpenJDK 2D-Dev] [10] RFR: JDK-8188083- NPE in
java.awt.image.FilteredImageSource.startProduction
T
+1
On 28/11/2017 07:39, Anton Litvinov wrote:
Hello Phil,
Thank you very much for review and approval of this fix.
Thank you,
Anton
On 27/11/2017 23:13, Phil Race wrote:
Hi,
getPageFormatFromAttributes(..) was added to fix some mac specific
issues :
https://bugs.openjdk.java.net/browse/JDK
Looks fine.
On 01/12/2017 14:58, Paul Sandoz wrote:
On 1 Dec 2017, at 13:19, Phil Race wrote:
This is a doc-only fix to point to ServiceLoader to explain how service
providers work
replacing the local incomplete documentation in these Image I/O classes.
The existing docs pre-date the exist
An update to the new Harfbuzz looks fine.
On 30/11/2017 11:01, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8188836
Webrev : http://cr.openjdk.java.net/~prr/8188836/
harfbuzz is the OpenType font layout engine in JDK 9
JDK 9 uses harfbuzz 1.5.1 and JDK 10 should update to the
Hi, Laurent.
On 29/11/2017 14:30, Laurent Bourgès wrote:
- added new ClipShapeTest (jtreg) that checks all possible combinations
of (cap / join) for random polyline (Stroker) and polygons (Filler)
comparing image outputs rendered with clipping enabled vs disabled
I have only one note that the
2ms
now => gain is high.
A possible success condition would be: clipping gain > 10 or 50.
Regards,
Laurent
Le 4 déc. 2017 11:11 PM, "Sergey Bylokhov"
mailto:sergey.bylok...@oracle.com>> a
écrit :
Hi, Laurent.
On 29/11/2017 14:3
Hi, Phil.
The new code will calculate the logical bounds this way:
541 new Rectangle2D.Float(0f, ascent, width, height);
But previously it was:
2613 new Rectangle2D.Float(0, -tl.getAscent(), tl.getAdvance(),
2614 tl.getAscent() + tl.getDescent() +
2615
(0f, ascent, width, height);
http://cr.openjdk.java.net/~prr/8189809.1/
-phil.
On 12/11/2017 02:12 PM, Sergey Bylokhov wrote:
Hi, Phil.
The new code will calculate the logical bounds this way:
541 new Rectangle2D.Float(0f, ascent, width, height);
But previously it was:
2613 new
It looks fine, but I wonder why
metadata.PLTE_present == false
is used instead of
!metadata.PLTE_present
On 13/12/2017 02:50, Jayathirth D V wrote:
Hello Prahalad,
Thanks for your inputs.
I have updated the code based on your inputs.
Please find updated webrev for review:
http://cr.openjdk.jav
The .02 version looks fine.
On 18/12/2017 20:55, Jayathirth D V wrote:
Hi Sergey,
Could you please provide your inputs and review the fix.
Thanks,
Jay
-Original Message-
From: Jayathirth D V
Sent: Thursday, December 14, 2017 9:47 AM
To: Sergey Bylokhov; Prahalad Kumar Narayanan; 2d
Hi, Prahalad.
Not an expert here, but have a small question about implementation of
this method in the parent class(ComponentSampleModel).
Currently the parent class has a similar implementation of
createDataBuffer(), but instead of "scanlineStride * height" it uses
"getBufferSize()". And this
Probably we can use Math.multiplyExact()? The current exception text
wrapped a few times "Pixel stride times width must be less than or equal
to the scanline stride" is not strictly correct because it is possible
that the image itself has correct data, but we cannot handle it because
of overflo
Just small comment(for a discussion), about a performance of these
methods. How much faster these methods from the case when the
TextMeasure is created from scratch? I mean that if they are much faster
and the insertChar() method works already, then probably we can support
this in deleteChar as
r exception as per ImageIO specification.
Please find updated webrev for review:
http://cr.openjdk.java.net/~jdv/8191174/webrev.02/
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Saturday, January 06, 2018 2:45 PM
To: Prahalad Kumar Narayanan; Jayathirth D V; 2d-dev
Subje
webrev:
http://cr.openjdk.java.net/~jdv/8191174/webrev.03/
Thanks,
Jay
-Original Message-
From: Sergey Bylokhov
Sent: Saturday, January 13, 2018 9:00 AM
To: Jayathirth D V; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws
IllegalArgumentException because ScanlineStride
On 22/01/2018 23:17, Prahalad Kumar Narayanan wrote:
My suggestion was to -
. 'Generate' CRC from Chunk data and compare it with the retrieved value at
Line 731 'before' proceeding to process any of the chunks.
. In mal-formed chunks (corrupted chunk length /or chunk data), the CRC check
will f
FYI: Review for those fix was not completed:
http://mail.openjdk.java.net/pipermail/2d-dev/2015-December/006130.html
On 25/01/2018 13:31, Bill York wrote:
Could someone let me know if there are plans to fix this bug?
1. In the OpenJDK code base?
2. In the Oracle JDK?
The next release where
y 25, 2018 3:23 PM
To: Sergey Bylokhov; Jayathirth D V; 2d-dev
Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws
NegativeArraySizeException when keyword length exceeds chunk size
Hello Jay
Kindly ignore the point mentioned below with ( >) when you follow-up.
Lines 431 and
Looks fine.
On 26/01/2018 15:20, Philip Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8193483
webrev; http://cr.openjdk.java.net/~prr/8193483/
An update to the ProblemList to exclude most of the tests that fail on
Windows.
There are still a number of tests that have "errors" like
Looks fine.
On 30/01/2018 16:07, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8196468
Webrev: http://cr.openjdk.java.net/~prr/8196468/
There's some noise in here as I moved the swing tests added last time to
be listed
next to other swing tests and grouped a few other tests t
ude a test under one ID .. even
if failures are on different platforms and the causes are unrelated.
Maybe we can create RFE for jtreg?
On 01/30/2018 06:30 PM, Sergey Bylokhov wrote:
Looks fine.
On 30/01/2018 16:07, Phil Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8196468
W
Hi, Erik.
Why XCode 9 was selected? It seems that 9.2 is the latest one.
9.2 produces some additional warnings even after this fix.
On 05/02/2018 14:54, Erik Joelsson wrote:
When building with Xcode 9, we get some warnings triggered in jdk
libraries. This patch tries to fix them. See bug descrip
Hi, Alexey.
Two small comments:
- It looks like that after the fix we will reset the value to "null"
even if it was set by the user, for example the user may want to
minimize the memory footprint if he knows that application limite the
size of the windows.
- setDoubleBufferMaximumSize include
Hi, Prahalad, Phil.
Maybe it is possible to add a log from jtr file to the bug report,
usually it contains a stack trace on timeout. I am not sure that it is a
good idea to update any tests without reproducing it, when we know that
at least on one system it could be reproduced. The reasons mayb
Looks fine.
Thank you.
On 13/02/2018 05:19, Alexey Ushakov wrote:
Hi Sergey,
Thanks for the comments. Here is updated version of the fix:
Webrev: http://cr.openjdk.java.net/~avu/JDK-8197499/webrev.02/
Best Regards,
Alexey
On 12 Feb 2018, at 21:29, Sergey Bylokhov <mailto:sergey.by
using
one pipeline.
-phil
On 02/13/2018 12:43 PM, Sergey Bylokhov wrote:
Hi, Prahalad, Phil.
Maybe it is possible to add a log from jtr file to the bug report,
usually it contains a stack trace on timeout. I am not sure that it is
a good idea to update any tests without reproducing it, wh
never required in future. The keywords approach helps to address both. Hence
this proposed fix.
Kindly let me know your views.
Thank you once again for your time
Have a good day
Prahalad N.
-Original Message-
From: Sergey Bylokhov
Sent: Wednesday, February 14, 2018 3:51 AM
To: Phil
Hello.
Please review update of the tests for jdk11.
The goal is to make our testing as stable as possible and exclude any
unstable tests(I have started from the tests which may be run in the
headless mode).
Bug: https://bugs.openjdk.java.net/browse/JDK-8198333
Webrev can be found at: http://c
(1);
Should we not remove that as it might hamper jtreg run?
I also think that this bugid needs to be added to all updated tests.
Regards
Prasanta
On 2/21/2018 1:33 AM, Phil Race wrote:
+1
-phil
On 02/20/2018 07:10 AM, Sergey Bylokhov wrote:
Hello.
Please review update of the tests for jd
will rewrite
the test completely or add some new steps to check(But it likely will be
an RFE)
On 21/02/2018 07:49, Prasanta Sadhukhan wrote:
looks ok. Only thing is the tests do not have the current bugid appended.
Regards
Prasanta
On 2/21/2018 9:15 PM, Sergey Bylokhov wrote:
Hi, Prasanta.
I
On 21/02/2018 08:49, Philip Race wrote:
I am not sure it has mac specific code, I'll reevaluate this test in
JDK-8198406.
This is mac-specific. It looks for specific fonts by name that exist
only on MacOS.
And moreover the table handling in the implementation is relevant only
for Apple AAT fo
1 - 100 of 1491 matches
Mail list logo
