On 5/10/24 10:54 AM, Hans Boehm wrote:
I'm not convinced this helps.
The isAlive() spec says:
"A thread is alive if it has been started and has not yet terminated."
Clearly an object is reachable if it can be accessed by a thread that will be started in the
future. Is that part of a
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Wed, 8 May 2024 08:33:31 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> small grammar fixes
>
> src/java.base/share/classes/java/lang/ref/Cleaner.java line
On Fri, 23 Feb 2024 14:37:20 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> VM -> virtual machine; also fix misspelling
>
> src/java.base/share/classes/ja
On Sat, 27 Apr 2024 11:58:52 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> new section for finalizer memviz
>
> src/java.base/share/classes/java/lang/
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Sat, 27 Apr 2024 11:57:23 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> new section for finalizer memviz
>
> src/java.base/share/classes/java/lang/
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Thu, 25 Apr 2024 08:25:39 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> package spec updates, mostly about reference queues and dequeueing
>
> src/java.ba
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Fri, 5 Apr 2024 23:13:39 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during re
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Mon, 25 Mar 2024 19:26:41 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during re
On Fri, 22 Mar 2024 09:28:02 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Elaborate on 'surprising and undesirable effects' in reachabilityFence()
>
> src/jav
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Sat, 16 Mar 2024 04:20:44 GMT, Stuart Marks wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further tweaks to reachability
>
> src/java.base/share/classes/java/lang/ref/Refe
On Sat, 16 Mar 2024 04:21:55 GMT, Stuart Marks wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> further tweaks to reachability
>
> src/java.base/share/classes/java/lang/ref/package
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Thu, 22 Feb 2024 23:14:37 GMT, Brent Christian wrote:
>> I note that the adjective(s) (un)successful and the adverb(s)
>> (un)successfully are used at several places in these comments, it might
>> makes sense to use those terms here as well such that the documentation
On Thu, 22 Feb 2024 18:24:39 GMT, Y. Srinivas Ramakrishna
wrote:
>> or, better yet, `fails`
>
> I note that the adjective(s) (un)successful and the adverb(s)
> (un)successfully are used at several places in these comments, it might makes
> sense to use those terms here as well such that the
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Wed, 21 Feb 2024 01:52:57 GMT, David Holmes wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to reachabilityFence()
>
> src/java.base/share/classes/java/lang/ref/package
On Wed, 14 Feb 2024 18:09:15 GMT, Per Minborg wrote:
>> This PR proposes to remove the use of `Unsafe` in the class
>> `XEmbeddingContainer ` and replace it with the supported FFM API.
>>
>> I tried to make this PR as small as possible while opening up for migration
>> of other classes later
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
Vote: Yes
On 2/19/24 3:40 PM, Stuart Marks wrote:
I hereby nominate Viktor Klang [6] to Membership in the Core Libraries Group
[4].
Vote: Yes
On 2/13/2024 12:25 PM, Brian Burkhalter wrote:
I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group.
Raffaello has been working in the Core Library team at Oracle since April,
2022. He has authored more than 50 contributions to OpenJDK in a number of
On Mon, 27 Nov 2023 22:52:10 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/package
On Mon, 27 Nov 2023 21:51:01 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/package
On Thu, 30 Nov 2023 22:39:26 GMT, Brent Christian wrote:
>> IMO, the core of the semantics here are that the reachabilityFence() call
>> happens before clearing or enqueueing of any References to the argument. I
>> think it's the call itself, not the end of the argument.
On Mon, 27 Nov 2023 22:33:16 GMT, Hans Boehm wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates to clear() and enqueue()
>
> src/java.base/share/classes/java/lang/ref/Refe
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Tue, 23 Jan 2024 11:40:00 GMT, Kim Barrett wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Tweak Reference.enqueue memory consistency effects wording
>
> src/java.ba
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Wed, 10 Jan 2024 16:09:14 GMT, Viktor Klang wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add links to new Memory Consistency section in package doc
>
> src/java.ba
On Sat, 18 Nov 2023 01:56:11 GMT, Mandy Chung wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove hyphen in 'strongly reachable' in Cleaner
>
> src/java.base/share/classes/jav
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Thu, 14 Dec 2023 21:50:01 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but
On Thu, 14 Dec 2023 21:50:01 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but
On Wed, 6 Dec 2023 01:24:51 GMT, Brent Christian wrote:
>> Perhaps in each of these places add a link to #Memory Consistency Properties
>
> I can flesh out the new Memory Consistency Properties section in the package
> info to cover the whole chain. Adding links to it sounds l
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Tue, 21 Nov 2023 09:16:17 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 564:
>>
>>> 562: * {@code reachabilityFence(x)}
>>> 563: * >> href="{@docRoot}/java.base/java/util/concurrent/package-summary.html#MemoryVisibility">happen-before
>>>
> guarantees made for finalizers in [JLS
> 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> _"There is a happens-before edge from the end of a constructor of an object
> to the start of a finalizer (§12.6) for that object."_
Brent Christ
On Wed, 15 Nov 2023 22:45:46 GMT, Stuart Marks wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Tue, 21 Nov 2023 22:58:09 GMT, Roger Riggs wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Tue, 21 Nov 2023 09:13:59 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 505:
>>
>>> 503: * to return this reference even though the referent is still
>>> strongly
>>> 504: * reachable. That is, before the referent has reached the
On Tue, 21 Nov 2023 22:46:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/ref/Reference.java line 489:
>>
>>> 487: * If this reference was already enqueued (by the garbage
>>> collector, or a
>>> 488: * previous call to {@code enqueue}), this method is not
>>>
On Tue, 21 Nov 2023 09:12:49 GMT, Viktor Klang wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Sat, 18 Nov 2023 01:55:00 GMT, Mandy Chung wrote:
>> Perhaps it's sufficient to say simply that, _"the garbage collector will no
>> longer enqueue this object."_
>
> Is this sentence needed? Excluding the race scenario as described in the
> javadoc, it would be equivalent as if the
On Tue, 21 Nov 2023 09:08:06 GMT, Viktor Klang wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Tue, 14 Nov 2023 14:06:29 GMT, Alan Bateman wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
>>
On Mon, 13 Nov 2023 11:08:13 GMT, Maurizio Cimadamore
wrote:
> Silently ignoring exceptions seems bad, but something that is forced when
> using a Cleaner
I also don't like that Cleaner ignores exceptions.
One idea I have: [8305979 : UncaughtExceptionHandler for Cleaner
Classes in the `java.lang.ref` package would benefit from an update to bring
the spec in line with how the VM already behaves. The changes would focus on
_happens-before_ edges at some key points during reference processing.
A couple key things we want to be able to say are:
-
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `L
On Mon, 18 Sep 2023 21:12:44 GMT, Stuart Marks wrote:
> Wording changes to make clear that the scenarios described are merely
> examples and are not normative requirements.
Looks good.
-
Marked as reviewed by bchristi (Reviewer).
PR Review:
On Fri, 22 Sep 2023 17:32:32 GMT, Mandy Chung wrote:
>> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
>> intends to change the initial batch size only for a stack walker with an
>> estimated stack depth. For stack walkers without user-supplied estimated
>> stack
On Thu, 14 Sep 2023 21:15:48 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/StackStreamFactory.java line 544:
>>
>>> 542: return walker.estimateDepth() == 0
>>> 543: ? SMALL_BATCH
>>> 544: :
On Thu, 14 Sep 2023 17:06:53 GMT, Mandy Chung wrote:
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack
On Thu, 14 Sep 2023 17:06:53 GMT, Mandy Chung wrote:
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack
On Tue, 12 Sep 2023 21:09:25 GMT, Mandy Chung wrote:
>> test/micro/org/openjdk/bench/java/lang/CallerClassBench.java line 45:
>>
>>> 43: public class CallerClassBench {
>>> 44: static final StackWalker INST =
>>> StackWalker.getInstance(StackWalker.Option.RETAIN_CLASS_REFERENCE);
>>> 45:
On Mon, 11 Sep 2023 17:52:56 GMT, Mandy Chung wrote:
>> Typically it will find the caller class at the second stack frame from the
>> frame of executing `StackWalker::getCallerClass`. The initial size of the
>> buffer can be changed from 8 to 4 (the top 2 elements are reserved for
>>
On Fri, 8 Sep 2023 08:03:51 GMT, Alan Bateman wrote:
> > We could do this mid-term in some follow up action.
>
> It shouldn't be hard to try it. If it works out then it would mean this old
> crufty code goes away and the JDK is in a better place. If it doesn't work
> out then the a plan B
On Thu, 7 Sep 2023 18:22:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Tue, 5 Sep 2023 17:52:44 GMT, Mandy Chung wrote:
>> test/micro/org/openjdk/bench/java/lang/StackWalkBench.java line 64:
>>
>>> 62: default -> throw new IllegalArgumentException(name);
>>> 63: };
>>> 64: }
>>
>> The previous `WALKER_DEFAULT` would not have retained
On Thu, 31 Aug 2023 17:09:40 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Tue, 29 Aug 2023 20:51:56 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
Vote: Yes
On 8/25/23 8:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
On Thu, 24 Aug 2023 22:03:53 GMT, Mandy Chung wrote:
> I like separating this from `Option` as it specifies what information to be
> collected from each frame whereas `Option` controls everything else such as
> what frames to be filtered
In my mind, `Option` _already_ can control what
On Thu, 24 Aug 2023 18:44:14 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Tue, 22 Aug 2023 19:01:53 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `L
On Mon, 26 Jun 2023 23:13:19 GMT, Mandy Chung wrote:
>> This PR updates the spec of `Lookup::findClass` to reflect the current
>> behavior that requires a binary name or a string representing an array class
>> in the form as returned by `Class::getName`.
>>
>>
On Fri, 16 Jun 2023 15:30:55 GMT, Roger Riggs wrote:
>> Can I get a preliminary review of the wording for Deque.reversed()? If the
>> text is good, I'll make corresponding changes to the implSpecs of the other
>> reversed() default methods, namely those in List, SortedMap, and SortedSet
>>
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `L
On Wed, 7 Jun 2023 19:03:31 GMT, Mandy Chung wrote:
> Trivial fix. The deploy modules no longer exist. The tests are updated
> not to reference them.
Looks fine.
-
Marked as reviewed by bchristi (Reviewer).
PR Review:
On Fri, 2 Jun 2023 01:12:32 GMT, Stuart Marks wrote:
> Create and use new NullableKeyValueHolder class to accommodate map entries
> whose key or value might be null.
Changes look good.
An observation:
`TreeMap` implements `SequencedMap`, and I see that its `firstEntry()` and
related
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `L
On Thu, 27 Apr 2023 13:54:53 GMT, Roger Riggs wrote:
>> It appears that -Xcomp causes the relative timing of the commands to be
>> disturbed enough to prevent the correct operation of the test. The test
>> should not be run with -Xcomp
>
> Roger Riggs has updated the pull request incrementally
On Tue, 25 Apr 2023 21:43:54 GMT, Roger Riggs wrote:
> It appears that -Xcomp causes the relative timing of the commands to be
> disturbed enough to prevent the correct operation of the test. The test
> should not be run with -Xcomp
Changes requested by bchristi (Reviewer).
On Fri, 21 Apr 2023 16:22:02 GMT, Naoto Sato wrote:
>> The current macro assumes the argument is `jint` because all locations pass
>> `jint`. However, this would not work if a wider type such as `jlong` is
>> passed. Removing the `unsigned` cast and make the condition explicit would
>> make
On Thu, 20 Apr 2023 18:39:29 GMT, Naoto Sato wrote:
> The current macro assumes the argument is `jint` because all locations pass
> `jint`. However, this would not work if a wider type such as `jlong` is
> passed. Removing the `unsigned` cast and make the condition explicit would
> make the
On Tue, 11 Apr 2023 23:55:50 GMT, Brent Christian wrote:
> With the removal of the AltFinalizer mechanism from `FileInputStream` and
> `FileOutputStream` in
> [JDK-8192939](https://bugs.openjdk.org/browse/JDK-8192939), this portion of
> the Implementation Requirement in the c
On Sat, 15 Apr 2023 07:10:46 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updates, per review comments
>
> src/java.base/share/classes/java/io/FileInpu
1 - 100 of 838 matches
Mail list logo
