se I'll make
the required change and push it.
--
Thanking You,
Darshit Shah
pgpkNVuEMu3DE.pgp
Description: PGP signature
how this works.
Note 1: We have strcasecmp and strncasecmp functions in src/cmpt.c
that could be removed.
Note 2: As gnulib is providing them, the mswindows.h defining would be
unnecessary.
--- end quoted text ---
--
Thanking You,
Darshit Shah
pgppXimISmior.pgp
Description: PGP signature
On 11/19, Tim Rühsen wrote:
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
On 11/18, Tim Rühsen wrote:
>This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
>may prevent from compiling with MSVC.
>
>There are still some warnings "ISO C forb
dded wcat convenience wrapper
---
contrib/wcat | 10 ++
1 file changed, 10 insertions(+)
create mode 100755 contrib/wcat
diff --git a/contrib/wcat b/contrib/wcat
new file mode 100755
index 000..3477d88
--- /dev/null
+++ b/contrib/wcat
@@ -0,0 +1,10 @@
+#!/bin/sh
+WGET=`which wget 2>/dev/null`
+if [ ! -x "${WGET}" ]; then
+ echo "No wget executable found in PATH"
+ exit 127
+fi
+
+"${WGET}" -q -O - "$@"
+
+# vim: tabstop=2 shiftwidth=2
--
2.0.4
--- end quoted text ---
--
Thanking You,
Darshit Shah
pgphe0kwGfXCN.pgp
Description: PGP signature
On Thu, Nov 20, 2014 at 1:26 PM, Ángel González wrote:
> On 20/11/14 06:13, Darshit Shah wrote:
>>
>> @Tim: Please just add that include statement one line above, or else I'll
>> make the required change and push it.
>>
> You can copy that block from my patch i
How does this look for another attempt at the configure file?
On Tue, Nov 18, 2014 at 3:55 PM, Darshit Shah wrote:
> On 11/18, Tim Rühsen wrote:
>>
>> On Tuesday 18 November 2014 09:51:18 Darshit Shah wrote:
>>>
>>> On 11/17, Tim Rühsen wrote:
>>> &g
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 11:52:40 Darshit Shah wrote:
On 11/19, Tim Rühsen wrote:
>Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
>> On 11/18, Tim Rühsen wrote:
>> >This patch fixes most C89 warnings for me (-std=c89 -pedanti
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll also push the patch that adds -Wextra to
the default CFLAGS.
--
Thanking You,
Darshit
On 11/20, Tim Rühsen wrote:
On Wednesday 19 November 2014 23:01:22 Darshit Shah wrote:
On 11/09, Ángel González wrote:
>On 07/11/14 06:12, Darshit Shah wrote:
>>Because real life is catching up, I've very little time till the end of
>>this year. But I'm going to try and
This autoreconf invokation will disable
assertions in your compiled executables. Please explicitly enable assertions
before continuing to hack on Wget.
--
Thanking You,
Darshit Shah
From ebb6c180efb803d4117a4067561c703ca86cd4aa Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Thu, 20 Nov 2014 19:
ecause these functions will be called a very large number of times when
updating the progress bar. And simple things should ideally just get inlined.
--
Thanking You,
Darshit Shah
pgpTBCS9k8XMG.pgp
Description: PGP signature
On 11/20, Ãngel González wrote:
On 20/11/14 15:29, Darshit Shah wrote:
--- a/src/progress.c
+++ b/src/progress.c
@@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double
dl_total_time, bool done)
{
int percentage = 100.0 * size / bp->total_length;
ass
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 15:36:57 Darshit Shah wrote:
On 11/20, Darshit Shah wrote:
>How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll
s interesting output ... but I could not find any documentation.
That's true. There's sadly almost no documentation for make syntax-check.
Tim
-- Thanking You,
Darshit Shah
pgpl8s8385RK7.pgp
Description: PGP signature
were to exceed 127 for any reason, such checks will be the least of the problems
for Wget.
I pushed this patch after adding the required ChangeLog entry. (Another ancient
relic, I want to get rid of)
--
Thanking You,
Darshit Shah
pgpAGk7TA8YjL.pgp
Description: PGP signature
Arrgh!! I didn't realize that.
I'll revert this commit immediately.
On Fri, Nov 21, 2014 at 2:12 PM, Tim Ruehsen wrote:
> On Friday 21 November 2014 13:56:01 Darshit Shah wrote:
>> On 11/21, Daniel Stenberg wrote:
>> >Hey
>> >
>> >Attached is a t
On 11/21, Tim Rühsen wrote:
On Friday 21 November 2014 13:19:18 Darshit Shah wrote:
On 11/20, Ángel González wrote:
>On 20/11/14 15:29, Darshit Shah wrote:
>>--- a/src/progress.c
>>+++ b/src/progress.c
>>@@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double
You,
Darshit Shah
From c223d276ce40a25f7c0e0b5ae305ad60cf7043d1 Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Fri, 21 Nov 2014 16:51:16 +0530
Subject: [PATCH 1/2] Declare externs for generated strings in version.c
---
src/ChangeLog | 6 ++
src/Makefile.am | 18 ++
src
On 11/21, Tim Rühsen wrote:
On Friday 21 November 2014 17:13:22 Darshit Shah wrote:
Clang provides some warnings for missing extern declarations for non-static
variables. The following two patches clear most of them. I can currently see
only more such warning which is caused by build_info.c. To
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 21-Nov-2014 8:45 pm, "Tim Ruehsen" wrote:
>
> I had two issues with the above mentioned test.
>
> 1. XFAIL is not common to people - we had some confusion on the mailing
list.
Xfail is standard
On 11/21, Tim Rühsen wrote:
On Friday 21 November 2014 19:58:46 Darshit Shah wrote:
On 11/21, Tim Rühsen wrote:
>On Friday 21 November 2014 17:13:22 Darshit Shah wrote:
>> Clang provides some warnings for missing extern declarations for
>> non-static
>> variables. The
ion.h is static, so it should go into git and not being created.
Tim
Am Freitag, 21. November 2014, 23:24:49 schrieb Darshit Shah:
On 11/21, Tim Rühsen wrote:
>On Friday 21 November 2014 19:58:46 Darshit Shah wrote:
>> On 11/21, Tim Rühsen wrote:
>> >On Friday 21 November 2014 17
On 11/21, Tim Rühsen wrote:
Let's get this patch through first and others to handle the old assertions
can flow in over the next week.
Yes, looks good to me. Go push it.
More comments below.
Tim
On Friday 21 November 2014 15:46:36 Darshit Shah wrote:
On 11/21, Tim Rühsen wrote:
>O
/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-22 Darshit Shah
+
+ * build-aux/build_info.pl: Include version.h in the final C file
generated
+ by the script.
+
2014-11-20 Darshit Shah
* configure.ac: Change option to --enable-assert. Assertions are
disabled by
diff
/ChangeLog b/src/ChangeLog
index d49e6ca..e912cf9 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,13 @@
2014-11-22 Darshit Shah
+ * version.h: New file. Add extern declarations for globally shared
strings
+ * Makefile.am: Have version.c import version.h
+ * main.c
---
src/ChangeLog | 7 +++
src/utils.c | 6 +++---
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index 120e82e..d49e6ca 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2014-11-22 Darshit Shah
+
+ * utils.c
This is a new set pf patches to eliminate some more compiler warnings.
[PATCH 1/8] Mark unused paramter in utils.c
[PATCH 2/8] Add extern declaration for version.c strings
[PATCH 3/8] Fix missing extern declaration error for build_info.pl
[PATCH 4/8] Declare extern numurls in common header
[PATCH
---
src/ChangeLog | 5 +
src/cookies.c | 8 +++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index 4a2b1b9..c0d6466 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,10 @@
2014-11-22 Darshit Shah
+ * cookies.c
Shah
+ * retr.h: Declare extern variable numurls
+ * http.c: Remove extern declaration for numurls
+ * ftp.c: Same
+
+2014-11-22 Darshit Shah
+
* version.h: Add extern for compilation_string
* main: Remove declaration for compilation_String
diff --git a/src
++
src/test.c| 2 +-
src/warc.c| 4
src/wget.h| 1 +
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/src/ChangeLog b/src/ChangeLog
index b5de3e1..4a2b1b9 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,11 @@
2014-11-22 Darshit Shah
+ * wget.h
---
src/ChangeLog | 4
src/wget.h| 1 +
2 files changed, 5 insertions(+)
diff --git a/src/ChangeLog b/src/ChangeLog
index 97f19f4..b5de3e1 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,9 @@
2014-11-22 Darshit Shah
+ * wget.h: Make extern declaration for
---
src/ChangeLog | 5 +
src/host.c| 6 ++
2 files changed, 11 insertions(+)
diff --git a/src/ChangeLog b/src/ChangeLog
index c0d6466..51ce88b 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,5 +1,10 @@
2014-11-22 Darshit Shah
+ * hosts.c (address_list_set_faulty
On 11/22, Tim Rühsen wrote:
Am Freitag, 21. November 2014, 21:13:45 schrieb Darshit Shah:
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 21-Nov-2014 8:45 pm, "Tim Ruehsen" wrote:
> I had two issues with the above mentioned test.
>
> 1. XFA
On 11/22, Tim Rühsen wrote:
Am Samstag, 22. November 2014, 14:52:14 schrieb Darshit Shah:
This is a new set pf patches to eliminate some more compiler warnings.
[PATCH 1/8] Mark unused paramter in utils.c
[PATCH 2/8] Add extern declaration for version.c strings
[PATCH 3/8] Fix missing extern
tication parameters.
Also, do take a look at this mailing list thread:
http://lists.w3.org/Archives/Public/ietf-http-wg/2009OctDec/0295.html
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 22-Nov-2014 11:26 pm, "Tim Rühsen" wrote:
> Am Samstag, 22. N
n the README files, the
configure script **MUST** check for it before continuing. Hence, I'd like to
push this patch which checks for the existence of flex before continuing.
--
Thanking You,
Darshit Shah
From 57a5cef8556f497511c2320f8f8295fae23a4c6b Mon Sep 17 00:00:00 2001
From: Darshit Shah
Damn.. I didn't think of searching for that.
We should use AC_PROG_LEX
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 23-Nov-2014 9:18 pm, "Tim Rühsen" wrote:
> Am Sonntag, 23. November 2014, 16:46:07 schrieb Darshit Shah:
> > I've
Good point. I'll amend this check and add it to bootstrap
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 24-Nov-2014 7:07 pm, "Giuseppe Scrivano" wrote:
> Darshit Shah writes:
>
> > Damn.. I didn't think of searching for that.
&
The argstring in a normal program execution isn't a constant but is
constructed dynamically from the command line options.
The way the argstring is constructed, this var cannot be a const.
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 24-Nov-2014 7:
On 11/24, Darshit Shah wrote:
Good point. I'll amend this check and add it to bootstrap
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 24-Nov-2014 7:07 pm, "Giuseppe Scrivano" wrote:
Darshit Shah writes:
> Damn.. I didn't think of sea
something
like this:
--progress-bar:rtol and --progress=bar:ltor for switching between the two
scrolling styles, with rtol (Right to Left) being the default.
--
Thanking You,
Darshit Shah
From d020b51aeb4bf281fd6722a85489c6c9cbdcd3bc Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Thu, 27 Nov
And that is precisely why I've been gunning for getting a good CI setup in
place.
The above patch worked for me flawlessly, but is causing problems on the
MSVC compiler.
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 27-Nov-2014 11:01 pm, "Gisle Van
Thanks! But it's been fixed in the current git version and will available
in the next release version.
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 28-Nov-2014 3:13 am, "ed" wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
Hi Tim,
I don't know if it's my email client, but I see no patch attached. Could
you please check?
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 28-Nov-2014 4:00 pm, "Tim Ruehsen" wrote:
> We do not need gettext.h.
> We only need _
On 11/27, Darshit Shah wrote:
A couple of days ago, Giuseppe suggested (on IRC) that maybe we should
reverse the direction in which the filename in the progressbar
scrolls.
His reasoning was that the last part of the file is the most important
for most people / use cases. This use case is
I'll push it in a while after adding the ChangeLog entry.
Though I noticed a Patch 1/2 in the git mail header. Is there any other
patch that we should know about?
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 02-Dec-2014 9:36 pm, "Tim Ruehsen"
EGD is not set.
Without doing so, Wget will start behaving differently from what is expected by
the end-user.
if (RAND_status ())
return;
It's good to know that Wget otherwise compiles and runs just about fine with
LibreSSL too.
--
Thanking You,
Darshit Shah
pgpvP0OGw5ZqT.pgp
Description: PGP signature
On 12/04, Tim Rühsen wrote:
On Tuesday 02 December 2014 17:52:48 Darshit Shah wrote:
On 11/27, Darshit Shah wrote:
>A couple of days ago, Giuseppe suggested (on IRC) that maybe we should
>reverse the direction in which the filename in the progressbar
>scrolls.
>
>His reasoning wa
make distcheck -j5
+ done
+done
+
+END=$(date +%s.%N)
+echo "Duration: "$(echo "$END - $START" | bc)
--
2.1.3
Also, this script seems to have a whitespace issue on line 28. My git complained
about it before fixing it and merging with the local tree.
Else, this looks good.
--
Thanking You,
Darshit Shah
pgpsZEvnSW3QZ.pgp
Description: PGP signature
new release
through the gitlog script.
--
Thanking You,
Darshit Shah
vers the case where
>> the Mac user has pkg-config installed. Pkg-config doesn't come with OSX or
>> the Apple dev tools. Up through wget 1.16, the pkgconfigless Mac user
>> could rely on --with-libssl-prefix to point wget to the right place.
>
> Please see the output of ./configure --help.
> If you don't have pkg-config installed, please try the following
> Add "-I/usr/local/ssl/include" to your CFLAGS
> and add "-L/usr/local/ssl/lib" to your LDFLAGS.
> export both and ./configure.
>
But shouldn't openssl detection work without pkg-config too? We did
retain the old detection code as a fallback mechanism in case
pkg-config didn't work.
Given the number of complains we've received about this, I think its
time to look back into configure.ac and figure out where that
detection is going wrong. Users shouldn't have to do all these
shenanigans to get Wget to compile.
--
Thanking You,
Darshit Shah
t; Hello,
>
> Here is the patch for this long-standing bug.
>
>
> See also:
> https://bugs.debian.org/144076
>
> Regards
>
> --
> Mathieu Parent
--
Thanking You,
Darshit Shah
one has objections I'll push this in a few days
--
Thanking You,
Darshit Shah
From 58dad2a61ea370e99b596c1d361ce8735d10b6ab Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Sun, 18 Jan 2015 15:18:14 +0530
Subject: [PATCH] progress bar: Allow display on stderr alongwith -o
This commit cause
On Tue, Jan 20, 2015 at 2:37 PM, Tim Ruehsen wrote:
> On Sunday 18 January 2015 15:57:47 Darshit Shah wrote:
>> This patch causes --show-progress to display the progress bar to the
>> screen even when the --logfile option is provided to Wget.
>>
>> If the --show-progre
Aah! Thanks a bunch for pulling the details.
I'll look into this (mostly) over the next weekend. Shouldn't be too hard.
On Tue, Jan 20, 2015 at 4:38 PM, Tim Ruehsen wrote:
> On Tuesday 20 January 2015 14:45:50 Darshit Shah wrote:
>> On Tue, Jan 20, 2015 at 2:37 PM, Tim Rueh
p getting the same error
which leads me to believe that the issue is in the savannah servers.
I've opened a support ticket, but if someone is able to push to the
repository, please push this commit.
On Tue, Jan 20, 2015 at 4:41 PM, Darshit Shah wrote:
> Aah! Thanks a bunch for pulling the d
ou become great by wanting to
> do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>
--
Thanking You,
Darshit Shah
efore we can merge this patch into our
codebase.
P.S.: Please ensure that all discussion occurs on-list here and not
off-list in a GitHub repository that none of us even look at.
--
Thanking You,
Darshit Shah
oad-strategy. Maybe we can have a short option
for the same too.
I'd like to keep it something that's a bit generic so that in the
future we can add more such strategies and have the switch still make
sense
>
> Tim
--
Thanking You,
Darshit Shah
e the copyright
>
>>You will be required to sign the copyright assignment agreement with the FSF
>>before we can merge this patch into our codebase.
>
> sounds like a lot of work. i release the copyright. i dont care
I wish it were that easy. I've sent you the copyright assignment form.
You'll have to fill that and send it in first.
--
Thanking You,
Darshit Shah
s that the Wget
downloads files in the correct order as expected.
i added a test that fail unless the browser queue order is used
--
Thanking You,
Darshit Shah
pgpaZTM7vKUlH.pgp
Description: PGP signature
anking You,
Darshit Shah
pgpAKHbWGeiy5.pgp
Description: PGP signature
3.01.2015 um 02:52 schrieb Darshit Shah :
>>
>> I guess we should. Since Wget 1.16.1 we have seen a few configure and
>> make bug fixes submitted, and also a couple of new features.
>>
>> @Giuseppe: maybe we can tag Wget 1.16.2 beta and allow the translators
>> to
use the format:
>>
>> * blah/file (function): Describe what changed.
>>
>> Otherwise use the format:
>>
>> one short line to describe the change
>>
>> * blah/file1 (foo): Describe what changed here.
>> * blah/file2 (bar): And here.
>>
>> More about the ChangeLog style here:
>>
>> https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
>>
>
> Changes are made to
>
> - Follow GNU Changelog style commit message.
> - Update the 2nd patch so that no color codes will be printed when
> the stdout is not a tty-like device.
>
>
> yousong
>
>> Thanks,
>> Giuseppe
--
Thanking You,
Darshit Shah
x27;
>
> is it possible to save output as 'aty3dm9msc2013.zip' rather than '2290'?
>
> Thanks in advance,
> Dmitry
>
>
--
Thanking You,
Darshit Shah
is there a place where you
> are having this discussion that i can join in? or should we consider
> starting a new dicsussion someplace?
>
> I have several conrete ideas about how this can be useful to the free
> software ecosystem more broadly.
>
> --dkg
--
Thanking You,
Darshit Shah
Hi Tim,
I'm getting a page does not exist for the link you provided. Can you please
check it?
@dkg: I guess a separate mailing list would be perfect. We'd need one
anyways for maintaining this library.
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 0
new feature --content-on-error is enabled. Did you use it ?
>> What do /etc/wgetrc and ~./wgetrc look like ? And very important: what is
>> the
>> output of 'wget --version' ?
>>
>> > Is this a bug? I signed up for the mailing list, for wget bug reports
>> > but
>> > never heard back. Or is this expected behavior?
>>
>> When you sign up for the mailing list, you should get an email very soon
>> with
>> further instructions. Just try it again.
>>
>> Tim
>
>
--
Thanking You,
Darshit Shah
human_readable (opt.quota, 10, 1));
> }
>
> + /* Print size when --spider is passed except when spidering websites */
> + if (opt.spider && total_downloaded_bytes == 0)
> +logprintf (LOG_NOTQUIET,
> + _("Total expected download size: %s\n"),
> + total_download_size > 0 ? human_readable
> (total_download_size, 10, 1)
> + : "unspecified");
> +
>if (opt.cookies_output)
> save_cookies ();
>
> --
> 2.3.0
>
>
--
Thanking You,
Darshit Shah
rball, and no other file mentions
> about this.
>
> How about mention it in README ?
>
>
> --- Kiyoshi
>
--
Thanking You,
Darshit Shah
writes:
>
>> Hi Darshit,
>>
>> Am Mittwoch, 18. Februar 2015, 22:39:18 schrieb Darshit Shah:
>>> Readme.checkout is a file that is only available in the git
>>> repository. I guess this is a side effect of having
>>> gitlog-to-changelog generate out cha
available at https://scan.coverity.com/projects/555
Analysis Summary:
New defects found: 0
Defects eliminated: 0
--
Thanking You,
Darshit Shah
Earlier today, I ran Coverity on the latest HEAD of Wget. I've fixed some of the
potential memory leaks that Coverity reported. Please take a look
--
Thanking You,
Darshit Shah
From e96c668c7b403e4ab6e54764284cfa209cc848e5 Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Sun, 1 Mar 2015
thod as such to
understand the code base?
Thanks
--
Smriti Gambhir
Department of Computer Science
BITS Pilani K.K. Birla Goa Campus
--- end quoted text ---
--
Thanking You,
Darshit Shah
pgp6zXCze7IZy.pgp
Description: PGP signature
Mon, Mar 2, 2015 at 9:57 PM, Darshit Shah wrote:
Hi Smriti,
The FTP Server for Test Suite is a relatively open ended idea. Have you
gone through the existing test suite code base in the testenv/ directory?
With this project, we're really looking for students to come up with their
own ide
through the Test
> Suite,I would like to pick up Secure Cookie Management.
> Best,
> Smriti
>
> On Mon, Mar 2, 2015 at 11:06 PM, Darshit Shah wrote:
>>
>> For the FTP Server specifically, you get to start from a (nearly) blank
>> slate! There's no prior code base
Any updates on these patches?
On Sun, Mar 1, 2015 at 7:48 PM, Darshit Shah wrote:
> Earlier today, I ran Coverity on the latest HEAD of Wget. I've fixed some of
> the potential memory leaks that Coverity reported. Please take a look
>
> --
> Thanking You,
> Darshit S
On Tue, Mar 3, 2015 at 3:20 PM, Tim Ruehsen wrote:
> On Tuesday 03 March 2015 15:10:39 Darshit Shah wrote:
>> Any updates on these patches?
>>
>> On Sun, Mar 1, 2015 at 7:48 PM, Darshit Shah wrote:
>> > Earlier today, I ran Coverity on the latest HEAD of Wge
x27;re
trying to move away from it.
P.S.: You should really be sending such emails to the mailing list.
Directly messaging people is generally considered bad etiquette.
--
Thanking You,
Darshit Shah
least one patch to Wget, since it allows
us to see how well you have understood the code base and saves a lot of time
later.
By the way, I can provide references if needed, just ask for them.
The only references we need are the ones that come from your work for Wget and
your interac
>
> --
> Smriti Gambhir
> Department of Computer Science
> BITS Pilani K.K. Birla Goa Campus
--
Thanking You,
Darshit Shah
he mailing list. Discussing a bug
report and a future patch is best done there.
Thanking You,
Darshit Shah
Sent from mobile device. Please excuse my brevity
On 05-Mar-2015 12:19 am, "Elita Lobo" wrote:
> Respected Sir,
>
> I was try to fix this particular bug [1] and after studying
Can someone please take a look at the language and see if it is clear enough?
--
Thanking You,
Darshit Shah
From 42dd4835d2247d8c030a711ee80e42730a9cb321 Mon Sep 17 00:00:00 2001
From: Darshit Shah
Date: Fri, 6 Mar 2015 22:00:24 +0530
Subject: [PATCH] Docs: --post-file is binary data
Wget
Any updates? Else I push this patch on Monday morning.
On Tue, Mar 3, 2015 at 4:43 PM, Darshit Shah wrote:
> On Tue, Mar 3, 2015 at 3:20 PM, Tim Ruehsen wrote:
>> On Tuesday 03 March 2015 15:10:39 Darshit Shah wrote:
>>> Any updates on these patches?
>>>
>>
Something like this?
On Sun, Mar 8, 2015 at 7:11 PM, Ander Juaristi wrote:
>
> On 03/06/2015 05:35 PM, Darshit Shah wrote:
>>
>> Can someone please take a look at the language and see if it is clear
>> enough?
>>
>
> I would add an extra line emphasizing t
y updates on this?
>
> --
> Regards,
> - AJ
>
--
Thanking You,
Darshit Shah
proposal
> draft. In the meantime, I will start reading the codebase and try fixing
> small bugs, as already suggested in the list.
I'm assuming you've seen the GitHub wiki page for GSoC '15? You've
started out on the right track towards your proposal. Eventually it
will require a more detailed discussion and a timeline. But we will
work on those things later.
>
> Many thanks in advance,
>
> Laura
--
Thanking You,
Darshit Shah
Pushed!
On Mon, Mar 9, 2015 at 3:36 PM, Giuseppe Scrivano wrote:
> Darshit Shah writes:
>
>> From aaedc68bcff5a9311ed806d972ce88a1d2c12a96 Mon Sep 17 00:00:00 2001
>> From: Darshit Shah
>> Date: Fri, 6 Mar 2015 22:00:24 +0530
>> Subject: [PATCH] Docs: --post-
l and having more regular contributors
amongst us!
[1]: https://github.com/darnir/wget/wiki/GSoC-2015
[2]: https://github.com/darnir/wget/wiki/GSoC-2015:-Proposal-Format
--
Thanking You,
Darshit Shah
pgpY0c5xgIYxf.pgp
Description: PGP signature
Pushed all 4 patches.
On 03/07, Darshit Shah wrote:
Any updates? Else I push this patch on Monday morning.
On Tue, Mar 3, 2015 at 4:43 PM, Darshit Shah wrote:
On Tue, Mar 3, 2015 at 3:20 PM, Tim Ruehsen wrote:
On Tuesday 03 March 2015 15:10:39 Darshit Shah wrote:
Any updates on these
end a Retry-After Header and test if Wget waits for
the specified length of time before retrying. This test should fail and we will
add it to the XFAIL_TESTS as something that we need to fix in Wget.
If you'd like to move on to something else, that is perfectly alright and we'll
consider your current patch as valid test case.
--
Thanking You,
Darshit Shah
pgpPmL2eIvzHu.pgp
Description: PGP signature
a lot of value to the test when it explains some of the background
information.
Also, could you please edit your commit message to be in sync with the GNU
ChangeLog style commit messages? Take a look at the existing commit messages for
ideas.
--
Thanking You,
Darshit Shah
pgpRKvT4tGa2
GENERIC_ERROR);
+ }
+ }
}
if (opt.warc_filename != 0)
Miquel Llobet
--- end quoted text ---
--
Thanking You,
Darshit Shah
pgpwEWhuSr1sj.pgp
Description: PGP signature
{
+ logfp = fopen (file, appendp ? "a" : "w");
+ if (!logfp)
+{
+ fprintf (stderr, "%s: %s: %s\n", exec_name, file, strerror
(errno));
+ exit (WGET_EXIT_GENERIC_ERROR);
+}
}
}
else
Miquel Llobet
--- end quoted text ---
--
Thanking You,
Darshit Shah
pgp3Gvsl2FM7E.pgp
Description: PGP signature
I just had another question. When -o- is passed to Wget, should the progress bar
still be printed to stderr? If not, we need to take care of that condition too.
On 03/15, Darshit Shah wrote:
Another good patch Miquel.
However, I must say, I support your first version more. It's okay
https://savannah.gnu.org/bugs/download.php?file_id=29593
--
Thanking You,
Darshit Shah
pgpjAjUizsp6A.pgp
Description: PGP signature
ing else please point it out .
We'll begin merging your patches once you complete the FSF Copyright
Assignments.
--
Thanking You,
Darshit Shah
pgpP01uN78ZIl.pgp
Description: PGP signature
quoted text ---
--
Thanking You,
Darshit Shah
pgpegkd6UbX0V.pgp
Description: PGP signature
O- would be large enough for an entire GSoC Project.
Instead I think it is better to stick to the basics and simply reject such
combinations of options
--
Thanking You,
Darshit Shah
pgpeurIeMgUpd.pgp
Description: PGP signature
##
+File1 = "12345678910"
+File2 = "2345678910"
+
+File1_rules = {
+"SendHeader" : {
+"Response" : 206
+}
+}
+
+A_File = WgetFile("File1", File1, rules=File1_rules)
+B_File = WgetFile("File1", File2)
+
+WGET_OPTIONS = "--start-pos=1"
+WGET_URLS = [["File1"]]
+
+Files = [[A_File]]
+
+ExpectedReturnCode = 0
+ExpectedDownloadedFiles = [B_File]
+
I think this test is only a subset of the previous one and hence a bit
redundant. What do you think?
Sorry if I come across as being a little too mean, but I'm a bit picky when it
comes to well formatted commits. Zihang can tell more about that. :)
--
Thanking You,
Darshit Shah
pgp0sJOIsb6X1.pgp
Description: PGP signature
401 - 500 of 872 matches
Mail list logo
