Nice work Kevin.
On Sat, Mar 10, 2018 at 09:56 Kevin Darbyshire-Bryant <
ke...@darbyshire-bryant.me.uk> wrote:
>
>
> > On 8 Mar 2018, at 11:21, Toke Høiland-Jørgensen wrote:
> >
> >>
> >> Oh and curiously the bad values go away if you ask for json output
> >> it’s much better.
> On 8 Mar 2018, at 11:21, Toke Høiland-Jørgensen wrote:
>
>>
>> Oh and curiously the bad values go away if you ask for json output
>> it’s much better. Which rather points at a ‘feature’ of the
>> ‘print_string’ behaviour.
>
> Right. Well, the print_* functions are behind
> On Mar 7, 2018, at 12:26 PM, Dave Taht wrote:
>
> For those that haven't been tracking https://www.facebook.com/dtaht -
>
> I bought an old 35' sailboat in the santa cruz, ca, harbor in December
> for 1 BTC. I figured living aboard would be cheaper than california
>
I am currently testing on my router, Archlinux with kernels
4.14.24/4.15.7, sch_cake from cobalt and tc-adv but it is behaving as
it should:
==8<==
qdisc cake 8001: dev ens4 root refcnt 2 bandwidth 12200Kbit besteffort
dual-dsthost wash ingress rtt 100.0ms noatm overhead 18mpu 64
Kevin Darbyshire-Bryant writes:
>> On 8 Mar 2018, at 11:09, Kevin Darbyshire-Bryant
>> wrote:
>>
>>
>>
>>> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen wrote:
>>>
>>> Kevin Darbyshire-Bryant
> On 8 Mar 2018, at 10:57, Toke Høiland-Jørgensen wrote:
>
> Kevin Darbyshire-Bryant writes:
>
>> Archer c7 v2. master branch of openwrt
>
> Ah, great; I actually have one of those sitting on my desk that I could
> potentially reflash without
Kevin Darbyshire-Bryant writes:
> Archer c7 v2. master branch of openwrt
Ah, great; I actually have one of those sitting on my desk that I could
potentially reflash without breaking anything too important.
In the meantime; do you get the same weird output on the
> On 8 Mar 2018, at 00:49, Jonathan Morton wrote:
>
>> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote:
>>
>> Ah, totally missed that those were wrong as well. The values for
>> dropped, overlimits and requeues are not printed by the
> On 7 Mar, 2018, at 11:34 pm, Toke Høiland-Jørgensen wrote:
>
> Ah, totally missed that those were wrong as well. The values for
> dropped, overlimits and requeues are not printed by the cake-specific
> code at all, so there is something else dubious going on.
Could they be
> On 7 Mar, 2018, at 8:27 pm, Kevin Darbyshire-Bryant
> wrote:
>
>> Are you using the latest kernel code? Those values were added in an
>> incompatible manner, so if you don't have userspace and kernel code in
>> sync they'll be garbage, basically…
>
> I’m using
> On 7 Mar 2018, at 18:27, Kevin Darbyshire-Bryant
> wrote:
>
>
>
>> On 7 Mar 2018, at 12:59, Toke Høiland-Jørgensen wrote:
>>
>>
>>> qdisc cake 8004: root refcnt 4486780 bandwidth 19900Kbit diffserv3
>>> dual-srchost nat rtt 100.0ms ptm
On Wed, Mar 7, 2018 at 7:52 AM, Toke Høiland-Jørgensen wrote:
> Dave Taht writes:
>
>> So it sounds like all the individual pieces are sync'd again?
>>
>> 4.16-rc4 is out, so there are several weeks left to make the net-next
>> window. I note that I don't feel
Dave Taht writes:
> So it sounds like all the individual pieces are sync'd again?
>
> 4.16-rc4 is out, so there are several weeks left to make the net-next
> window. I note that I don't feel strongly (never had) that I should be
> the one to make the net-next submission,
So it sounds like all the individual pieces are sync'd again?
4.16-rc4 is out, so there are several weeks left to make the net-next
window. I note that I don't feel strongly (never had) that I should be
the one to make the net-next submission, just so long as it now gets
through checkpatch (?)...
Sebastian Moeller writes:
>> diff --git a/tc/q_cake.c b/tc/q_cake.c
>> index e21552e8..95301b41 100644
>> --- a/tc/q_cake.c
>> +++ b/tc/q_cake.c
>> @@ -243,12 +243,22 @@ static int cake_parse_opt(struct qdisc_util *qu, int
>> argc, char **argv,
>>/* Typical
Kevin Darbyshire-Bryant writes:
> I don’t the column alignment can be correct because the print lines don’t
> include a leading space, so columns can run into each other.
>
> fprintf(f, "%12u", tst->unresponse_flows);
> v
> fprintf(f, " %12u",
I don’t the column alignment can be correct because the print lines don’t
include a leading space, so columns can run into each other.
fprintf(f, "%12u", tst->unresponse_flows);
v
fprintf(f, " %12u", tst->unresponse_flows);
The header lines are probably wrong. Should be as per
Kevin Darbyshire-Bryant writes:
>> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote:
>>
>>>
>>
>> Please don't put something different into LEDE than what we're working
>> on upstreaming. It is difficult enough to keep track of the different
Kevin Darbyshire-Bryant writes:
> There were some useful stats column re-alignment changes as well,
> wonder if you got those?
Probably not, as that code is not longer directly diff'able,
unfortunately... The json-related changes were fairly intrusive...
Hi Kevin,
> On Mar 7, 2018, at 12:07, Kevin Darbyshire-Bryant
> wrote:
>
>
>
>> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote:
>>
>>>
>>
>> Please don't put something different into LEDE than what we're working
>> on upstreaming. It
There were some useful stats column re-alignment changes as well, wonder if you
got those?
> On 7 Mar 2018, at 10:36, Toke Høiland-Jørgensen wrote:
>
> Toke Høiland-Jørgensen writes:
>
>> Kevin Darbyshire-Bryant writes:
>>
>>> Hi
> On 7 Mar 2018, at 10:31, Toke Høiland-Jørgensen wrote:
>
>>
>
> Please don't put something different into LEDE than what we're working
> on upstreaming. It is difficult enough to keep track of the different
> versions as they are. The tc-adv repo is already rebased on the
Toke Høiland-Jørgensen writes:
> Kevin Darbyshire-Bryant writes:
>
>> Hi All,
>>
>>
>>
>>> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote:
>>>
>>> Jonathan Morton writes:
>>>
> On 6 Mar, 2018, at
Kevin Darbyshire-Bryant writes:
> Hi All,
>
>
>
>> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote:
>>
>> Jonathan Morton writes:
>>
On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote:
Hi All,
> On 7 Mar 2018, at 08:50, Toke Høiland-Jørgensen wrote:
>
> Jonathan Morton writes:
>
>>> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote:
>>>
>>> ...on the iproute2 side the only
>>> thing missing before we can attempt
Jonathan Morton writes:
>> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote:
>>
>> ...on the iproute2 side the only
>> thing missing before we can attempt an upstream submission is an update
>> of the man page, as far as I can tell. Any volunteers
> On 6 Mar, 2018, at 11:06 pm, Toke Høiland-Jørgensen wrote:
>
> ...on the iproute2 side the only
> thing missing before we can attempt an upstream submission is an update
> of the man page, as far as I can tell. Any volunteers to do that? :)
I could look into that tomorrow.
-
Toke Høiland-Jørgensen writes:
> Stephen Hemminger writes:
>
>> On Sun, 11 Feb 2018 18:26:18 +0100
>> Toke Høiland-Jørgensen wrote:
>>
>>> This updates tc to understand the updated cake xstats structure (which
>>> splits out the tin stats
Stephen Hemminger writes:
> On Sun, 11 Feb 2018 18:26:18 +0100
> Toke Høiland-Jørgensen wrote:
>
>> This updates tc to understand the updated cake xstats structure (which
>> splits out the tin stats in a separate structure the length of which is
>>
On Sun, 11 Feb 2018 18:26:18 +0100
Toke Høiland-Jørgensen wrote:
> This updates tc to understand the updated cake xstats structure (which
> splits out the tin stats in a separate structure the length of which is
> included in the containing struct).
>
> Old versions of the cake
Hi Jonathan,
> On Mar 6, 2018, at 14:08, Jonathan Morton wrote:
>
>> On 6 Mar, 2018, at 2:10 pm, Sebastian Moeller wrote:
>>
>> Question: am I right to assume that the _adj values are what you pass in as
>> the true packet size into cake's
> On 6 Mar, 2018, at 2:10 pm, Sebastian Moeller wrote:
>
> Question: am I right to assume that the _adj values are what you pass in as
> the true packet size into cake's calculation?
Yes, exactly. They include ATM, PTM and MPU factors when relevant.
> I believe that before
Hi Jonathan,
> On Mar 6, 2018, at 12:46, Jonathan Morton wrote:
>
>> On 6 Mar, 2018, at 1:17 pm, Toke Høiland-Jørgensen wrote:
>>
>>> So far it looks like everything is working fine and behaving as it
>>> should (on a plain Ethernet interface). The one
> On 6 Mar, 2018, at 1:17 pm, Toke Høiland-Jørgensen wrote:
>
>> So far it looks like everything is working fine and behaving as it
>> should (on a plain Ethernet interface). The one wrinkle is that it
>> takes a few thousand packets for the avg_off value to converge on the
>>
Jonathan Morton writes:
>> On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote:
>>
>> BTW, my testing so far with the latest tc-adv did not result in any crashes,
>> but I also did not research whether the overhead account behaves like
>> expected...
>
> On 1 Mar, 2018, at 1:06 pm, Sebastian Moeller wrote:
>
> BTW, my testing so far with the latest tc-adv did not result in any crashes,
> but I also did not research whether the overhead account behaves like
> expected...
I've just added the relevant stats output. This
Toke Høiland-Jørgensen writes:
> Jonathan Morton writes:
>
>>> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen wrote:
>>>
>>> This updates tc to understand the updated cake xstats structure (which
>>> splits out the tin stats in a
Dear All,
I am a bit confused now which tc repository is the one to track.
I believe Jonathan made changes to https://github.com/dtaht/tc-adv
while https://github.com/dtaht/iproute2-cake-next seems overall more recent
(modulo Jonathan's changes)
So which one is it?
BTW, my testing so far
> On 11 Feb, 2018, at 7:26 pm, Toke Høiland-Jørgensen wrote:
>
> This updates tc to understand the updated cake xstats structure (which
> splits out the tin stats in a separate structure the length of which is
> included in the containing struct).
>
> Old versions of the cake
This updates tc to understand the updated cake xstats structure (which
splits out the tin stats in a separate structure the length of which is
included in the containing struct).
Old versions of the cake stats will no longer be understood by the
resulting version of tc.
Signed-off-by: Toke
40 matches
Mail list logo