Right, but the rating average doesn't take that into account.
Avi
On Fri, Dec 11, 2009 at 12:59 PM, Dirk Pranke dpra...@google.com wrote:
If I'm running on Windows, I know to ignore the latter. That's a
pretty big difference.
-- Dirk
On Fri, Dec 11, 2009 at 7:39 AM, Avi Drissman
Andy sent me a CL for review about an extension crashing (
http://crbug.com/29584). Turns out the cause was a failure to load a Windows
.dll on the Mac.
Huh? Then I went to look at the docs (
http://code.google.com/chrome/extensions/npapi.html):
{
name: My extension,
...
*plugins: [
{
Filed http://code.google.com/p/chromium/issues/detail?id=30052 .
Avi
On Thu, Dec 10, 2009 at 7:03 PM, Avi Drissman a...@chromium.org wrote:
Andy sent me a CL for review about an extension crashing (
http://crbug.com/29584). Turns out the cause was a failure to load a
Windows .dll on the Mac
this extension because it is damaged) Or is
it expected, since we're just likely hitting a library for a different
platform?
Avi
On Thu, Dec 10, 2009 at 7:12 PM, Aaron Boodman a...@google.com wrote:
On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman a...@chromium.org wrote:
Andy sent me a CL
. (Even if we do have a
manifest syntax for it, the extension package becomes bloated with plugin
binaries for other platforms.) But I didn't realize that it could cause a
crash. I'll definitely have to figure something out soon.
On Thu, Dec 10, 2009 at 4:03 PM, Avi Drissman a...@chromium.org wrote
:25 PM, Aaron Boodman a...@google.com wrote:
It is good that we can avoid the crash. We do need to get some kind of
syntax in the manifest.
- a
On Thu, Dec 10, 2009 at 4:18 PM, Avi Drissman a...@google.com wrote:
The crash is fixed. But the fact that we're now expecting random dll
loads
Is there a timetable? http://crbug.com/14936 has been Mstone-Xed since June.
Avi
On Thu, Dec 10, 2009 at 7:30 PM, Aaron Boodman a...@google.com wrote:
On Thu, Dec 10, 2009 at 4:27 PM, Avi Drissman a...@google.com wrote:
Can we have the syntax say platform x loads x.dll, platform y loads
On Thu, Dec 10, 2009 at 7:36 PM, Evan Martin ev...@google.com wrote:
Distributing binaries on Linux = sadness, as the Flash guys will tell
you.
[...]
In summary, all I offer you is more problems and the plea that we
should really really deter people from doing this kind of thing. I
imagine
On Thu, Dec 10, 2009 at 7:55 PM, Ojan Vafai o...@google.com wrote:
I think we can wait to see what percentage of extensions actually include
binaries before devoting too much time to this. Our expectation is that this
will be a very small percentage, right?
Quick, look at
On Thu, Dec 10, 2009 at 8:00 PM, Ojan Vafai o...@chromium.org wrote:
I think we can wait to see what percentage of extensions actually include
binaries before devoting too much time to this. Our expectation is that this
will be a very small percentage, right?
If we give people the
We do? I didn't know that. Then we should enforce some kind of labeling.
Avi
On Thu, Dec 10, 2009 at 8:12 PM, Peter Kasting pkast...@google.com wrote:
On Thu, Dec 10, 2009 at 5:02 PM, Avi Drissman a...@google.com wrote:
Q: Can't we have the extensions gallery warn that it won't work
I'm working on some UI related to downloads, and I need a clean indication
that a download is finished. Not just finished but Finished. And I've found
we're getting two notifications: one before auto-opening happens, and one
after it happens.
If we look at
On Mon, Nov 30, 2009 at 7:19 PM, Jens Alfke s...@google.com wrote:
second best would be a menu command
to explicitly zap whitespace in the file being edited.
That's there. Select all, and then from the scripts menu Google there's a
fix whitespace command.
Avi
--
Chromium Developers
That showed up when I fixed a bug upstream by custom constructing a
CGDataProvider. It seems that internally when you do that, CG uses that
obsolete function. It's nothing we're doing directly.
Does it still do that for 10.6?
I can ask Apple.
Avi
On Thu, Nov 19, 2009 at 10:44 PM, Nico Weber
I'm OK with that.
Just make it clear that the sheriff does have authority. One time when I was
sheriff I wanted to revert a broken patch. The author insisted on patching
it over and over. He finally got it working about about seven patches and
nearly three hours or so, when I was insisting on
Many of our HTML files have CSS in them (about_credits.html,
about_memory.html, etc) which needs to be tweaked per-platform (more
specifically, using an appropriate sans-serif font; see
http://crbug.com/21458). We already do templating with jstemplate, but from
what I can tell it can't swap out
On Mon, Oct 26, 2009 at 5:44 PM, Evan Martin e...@chromium.org wrote:
Why not use sans-serif in the HTML, and then rely on the appropriate
platform specific mapping of sans-serif - font of choice in the
WebKit prefs?
Good question. If the page is considered our UI then we would have an issue
The latter in fact is how it's implemented on the Mac, though without the
renaming of the checkbox that would make it clear what's going on. I'd
support either version, and would alter my code to make it happen.
Avi
On Tue, Oct 20, 2009 at 4:01 PM, Evan Stade est...@chromium.org wrote:
You found it.
At the beginning of the function you see:
*static* NSButtonCell *buttonCell;
//...
if (!buttonCell) {
There is only one cell created ever, and it's reused.
Avi
On Fri, Oct 9, 2009 at 4:20 PM, hap 497 hap...@gmail.com wrote:
Hi,
Does Chromium MacOSX always
Oh, and google.com has custom buttons which may or may not go through that
function at all (I haven't checked).
Avi
On Fri, Oct 9, 2009 at 4:44 PM, Avi Drissman a...@chromium.org wrote:
You found it.
At the beginning of the function you see:
*static* NSButtonCell *buttonCell
On Tue, Oct 6, 2009 at 6:18 PM, Glen Murphy g...@chromium.org wrote:
External protocol dialog should remain a dialog - I see it whenever I
click on links to stuff in the iTunes store, and having it show as an
infobar would be unpleasant.
OT: Use the Mac version; you can set the always allow
Will do first thing tomorrow.
Avi
/who figured it was OK since the string was already in the grd file
On Tue, Oct 6, 2009 at 6:25 PM, Ben Goodger (Google) b...@chromium.orgwrote:
Can you make sure a bug is filed to get this into the other platforms?
-Ben
On Tue, Oct 6, 2009 at 3:20 PM, Avi
I'm turning on the Mac pixel tests today. There's two parts to this. First
is the new expectations (http://codereview.chromium.org/249043) which just
adds IMAGE failures and won't affect anything. The second is telling the
bots to run the pixel tests (http://codereview.chromium.org/242099) and
/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/4845/steps/webkit_tests/logs/stdio
I think that'll do it. Let's let this run for a few cycles and throw flaky
tests into the expectations.
Avi
On Fri, Oct 2, 2009 at 9:52 AM, Avi Drissman a...@google.com wrote:
I'm turning on the Mac pixel tests
Latest Mac pixel test result is here:
http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Mac10.5/builds/4420/steps/webkit_tests/logs/stdio
:
Regressions: Unexpected failures (2):
LayoutTests/svg/custom/js-late-marker-and-object-creation.svg = FAIL
be surprised if
window position varied across unit test runs.
I think my main point here wasn't to drop everything you're doing to
track this down. I'm just saying that it's a dangerous bug to throw
into the supression list and forget about.
Erik
On Tue, Sep 22, 2009 at 11:11 AM, Avi Drissman
.
Ojan
On Thu, Oct 1, 2009 at 11:20 AM, Avi Drissman a...@google.com wrote:
The output of a test run of the Mac pixel tests is at:
http://build.chromium.org/buildbot/try-server/builders/layout_mac/builds/85/steps/webkit_tests/logs/stdio
What's weird is the line:
Missing expected results
/layout_tests/layout_package/compare_failures.py.
Specifically, take test_failures.FailureImageHashMismatch out of
FAILURE_TYPES and add an IMAGE_FAILURE_TYPE and use it below.
Ojan
On Wed, Sep 23, 2009 at 12:16 PM, Avi Drissman a...@google.com
wrote:
I've been looking into the pixel test
Right--the question is for the long term if this will be a useful feature to
keep around or if we'll be dropping it once the Mac tests work. I'll take
the change either way but I can appreciate the extra granularity that this
would provide.
Pam:
having a way to say oh, it's 'only' the image
I've been looking into the pixel test situation on the Mac, and it isn't bad
at all. Of ~5300 tests that have png results, we're failing ~800, most of
which fall into huge buckets of easily-separable fail.
Is there a way to specify that we're expecting an image compare to fail but
still want the
I'm new to the test runner (and to python in general). Can you give me a
pointer where I should start?
Avi
On Wed, Sep 23, 2009 at 3:22 PM, Dirk Pranke dpra...@google.com wrote:
No, there's no way to do that but it would be easy enough to add.
-- Dirk
On Wed, Sep 23, 2009 at 12:16 PM, Avi
BTW, would we want this to be temporary? I was thinking so, but then again,
being able to suppress a pixel failure separately from the layout failure
might be useful.
Avi
On Wed, Sep 23, 2009 at 3:24 PM, Avi Drissman a...@google.com wrote:
I'm new to the test runner (and to python in general
, or for memory errors where
it's been demonstrated that the result of the error is benign (like
the UMRs in parts of Microsoft's STL implementation), but it doesn't
seem like this fits into that case.
Erik
On Mon, Sep 21, 2009 at 1:15 PM, Avi Drissman a...@google.com wrote:
I have no evidence
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep down that ends up in sseCGSFill8by1, which looks like it
sometimes scribbles off the end of some buffer. I have no idea what we could
be doing wrong
, 2009 at 12:27 PM, Avi Drissman a...@google.com wrote:
crbug.com/18189
crbug.com/18539
I got the first because it involved the status bubble; I got the second
because I got the first.
NSRectFill(). Deep down that ends up in sseCGSFill8by1, which looks like
it
sometimes scribbles off
And on behalf of many of the other Mac folks, I have to thank Mark for
tearing into the problem and doing a lot of detective and coding work to
make it happen. He's incredible, and that's why we keep him working on
infrastructure work rather than actual Chromium coding; we don't want to
embarrass
OK, here's a more interesting backtrace (bp on -[NSScroller
setKnobProportion:]:
#00x960957e1 in -[NSScroller setKnobProportion:]
#10x95fb0de3 in -[NSScrollView reflectScrolledClipView:]
#20x009a4aef in -[WebDynamicScrollBarsView(WebInternal)
reflectScrolledClipView:] at
Is that metrics for the layout rectangles or the pixels?
Avi
On Tue, Sep 8, 2009 at 2:57 PM, Evan Martin e...@chromium.org wrote:
On Tue, Sep 8, 2009 at 11:51 AM, Mark Mentovaim...@chromium.org wrote:
Avi Drissman wrote:
Screw #2: The actual scrollbar is drawn just a wee bit shorter. Cocoa
Actively tracing through DumpRenderTree in WebCore. Getting layout info and
pixels that show I'm in the right file, and the png has scrollbars. But I
can't get gdb to break on ScrollbarThemeMac::paint and putting everything
from Debugger() to asm(int3) as the first statement in it isn't catching.
Grabowski j...@chromium.org wrote:
Use --gdb with test shell.
jrg
On Mon, Aug 31, 2009 at 2:38 PM, Avi Drissman a...@google.com wrote:
Quite a few of those issues are now moot...
Anyway, I'm trying to debug TestShell. I'm starting it with
--testshell-startup-dialog, and attaching, but GDB
, Avi Drissman a...@google.com wrote:
Aha! Thanks.
Does anyone remember poking at scrollbars? I'm only hitting scrollbar code
on the TestShell destructor, when we're loading about:blank to clear out
WebCore. I'm getting some metric calculation calls but no painting...
Still investigating
I've heard people proclaim the principle of being able to copy a profile
across systems as being a deciding factor for certain changes (e.g. the
history epoch change). However, it doesn't seem to be universally held or
obeyed, and I'm not sure to the extent to which it can be obeyed. So some
Then password management would also fall under the category of can't be
made portable and that's fine.
It's just that I've heard profile platform independence tossed around as
being a guiding principle and I was surprised that some people treated it as
so.
Avi
/who wonders how it fits into
On Wed, Aug 26, 2009 at 2:31 PM, Ben Goodger (Google) b...@chromium.orgwrote:
Note that even upgrading Windows OS from XP to Vista involves changing
paths:
c:\Documents and Settings - c:\Users
Do we ever write paths such as this?
Yes.
From my Preferences file on Windows:
id:
On Wed, Aug 12, 2009 at 9:41 AM, Meok meok...@gmail.com wrote:
I guess it shouldn't be
too hard then to pass that info onto the gallery page and keep
everything online.
I think that would be a bad idea even if it weren't too hard. What theme I'm
using is no one's business.
When I was
On Mon, Aug 10, 2009 at 7:46 AM, Mohamed Mansour m...@chromium.org wrote:
I have been told that once you installed a new theme, the old theme will
not be archived (stored on the system), so switching themes would be harder
when the CL comes in.
That isn't the case today; that may be the case
On Wed, Jul 29, 2009 at 11:52 AM, Mike Pinkerton pinker...@chromium.orgwrote:
Don't we farm out a separate process for favicon decoding? And for
theme image decoding as well?
There are two things done by the utility process. Unpacking of themes (not
just images but the unzipping of the
for more detail.
Avi
On Wed, Jul 29, 2009 at 12:00 PM, Avi Drissman a...@chromium.org wrote:
On Wed, Jul 29, 2009 at 11:52 AM, Mike Pinkerton
pinker...@chromium.orgwrote:
Don't we farm out a separate process for favicon decoding? And for
theme image decoding as well?
There are two
http://code.google.com/p/chromium/issues/detail?id=17015 was the layout
failures from a merge, and I got assigned them because I'd checked in a
small Mac-only change. Turns out that many of them are due to the failure to
red-dotted-underline misspelled words and slight differences in the
selection
I'm playing around fixing the rough edges of the Mac theme implementation
and I'm hitting areas where it doesn't seem to be implemented for any
platform.
First, you said that you were going to make it so that when you install one
theme it uninstalls all others. Is that coming soon?
I ask because
On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
First, you said that you were going to make it so that when you install
one theme it uninstalls all others. Is that coming soon?
I don't know
...@google.com wrote:
On Wed, Jul 15, 2009 at 11:09 AM, Erik Kay erik...@chromium.org wrote:
On Wed, Jul 15, 2009 at 7:44 AM, Avi Drissman a...@google.com wrote:
First, you said that you were going to make it so that when you install
one theme it uninstalls all others. Is that coming soon?
I
We re-encode the pngs in themes. Somewhere in the the process we break them;
we're encoding them off by one pixel, so that we have a vertical line on the
left, one pixel wide, that's transparent. It isn't obvious on Windows (but
it is there; look for it!) but it's glaringly obvious on the Mac. I'm
I'm building an extension with a jpg source. If it gets the column then it's
an encoder issue, else decoder issue. I'll let you know as soon as I find
out.
Avi
On Fri, Jul 10, 2009 at 12:18 PM, Glen Murphy g...@chromium.org wrote:
This may be a PNGEncoder/Decoder bounce issue, and I don't
Even with a jpg source we get column 0 invisible, so it's a PNG encoder
issue. In addition, in an imaged editor it looks like the image is shifted
over one pixel, not that the first column was overwritten.
Avi
On Fri, Jul 10, 2009 at 12:21 PM, Avi Drissman a...@google.com wrote:
I'm building
::CGImageToSkBitmap carefully. It does the
conversion by drawing the image into the bitmap...
Avi
On Fri, Jul 10, 2009 at 3:38 PM, Avi Drissman a...@google.com wrote:
Even with a jpg source we get column 0 invisible, so it's a PNG encoder
issue. In addition, in an imaged editor it looks like the image
Nailed: http://codereview.chromium.org/149473
Avi
On Fri, Jul 10, 2009 at 4:15 PM, Amanda Walker ama...@chromium.org wrote:
On Fri, Jul 10, 2009 at 3:54 PM, Avi Drissmana...@google.com wrote:
Two things. First, this doesn't happen on Windows. Second, how do you get
an
image shifted one
PNG is lossless, so we should be good there.
Avi
On Fri, Jul 10, 2009 at 4:30 PM, Aaron Boodman a...@chromium.org wrote:
On this same subject -- do we do any lossy compression in our png
encoding? I think we should *not*. Developers will be peeved if their
carefully compressed images come
http://crbug.com/14609 ...
In the renderer we need to run Cocoa on a non-main thread. To pump
windowserver events we need to pump on the main thread. And when we do so
timers and notifications fire, screwing us over. I think the timers and
notifications were not fired before, right?
In the short
Core Graphics is a level lower than Cocoa, and as the main way to draw on
the Mac would be OK to use. I don't know what we use Cocoa for. I think
widget rendering but I could be wrong.
Avi
On Fri, Jun 19, 2009 at 10:58 AM, Evan Martin e...@chromium.org wrote:
On Fri, Jun 19, 2009 at 6:44 AM,
Very interesting writeup. Some thoughts:
You don't touch on how Safari on the Mac handles this case. It seems to
overlap with some of the work that Jeremy was doing based on his discoveries
in WebKit's WebHTMLView.mm. Where does its _interceptEditingKeyEvent get
called?
Synthesizing CHAR events
There is one message for forwarding any type of input event. Trace backwards
and forwards from RenderWidgetHost::ForwardInputEvent().
Avi
On Tue, Jun 2, 2009 at 3:48 PM, meryl silverburgh.me...@gmail.com wrote:
Hi,
I am reading the messaging between renderer and browser:
On Wed, May 20, 2009 at 6:44 PM, Mark Mentovai m...@chromium.org wrote:
Avi and I found that the Exposé funkiness, present on his Leopard
machine and my Leopard laptop last week, is all of the sudden gone on
my Leopard laptop this week. The difference? 10.5.7, most likely.
Experimenting on
A visitor to IRC pointed me today to http://crbug.com/11319 , where
renderers are marked as not responding. He pointed out that this is not
just a cosmetic issue, since things like spindump run which kills
performance on non-quad core machines (that we all have).
I thought about just pumping
:54 AM, Avi Drissman a...@google.com wrote:
A visitor to IRC pointed me today to http://crbug.com/11319 , where
renderers are marked as not responding. He pointed out that this is
not
just a cosmetic issue, since things like spindump run which kills
performance on non-quad core machines
set a clip rect (on the canvas) to the invalidation
sub-rect.
- And then we call WebWidget::Paint() with the canvas and the
sub-rect.
Anything smells fishy in there?
BYE
MAD
On Thu, May 14, 2009 at 3:14 PM, Avi Drissman a...@chromium.org wrote:
We haven't
On Wed, May 13, 2009 at 2:27 PM, Avi Drissman a...@google.com wrote:
OK, so this was r15790. The code already exists to set the focus to the
location bar if it already had it, though.
Avi
On Wed, May 13, 2009 at 2:24 PM, Avi Drissman a...@google.com wrote:
I'm implementing save
OK, so this was
r15790http://src.chromium.org/viewvc/chrome?view=revrevision=15790.
The code already exists to set the focus to the location bar if it already
had it, though.
Avi
On Wed, May 13, 2009 at 2:24 PM, Avi Drissman a...@google.com wrote:
I'm implementing save/restore focus when
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
multisheet
disables x and - (there is no +, but I assume it'd be disabled too).
It shouldn't disable - and +.
I don't think I have control over that. I don't think that Cocoa's support
for child windows putting up sheets
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
Hit login, then play with Exposé. The show me my desktop function
leaves the sheet hanging; the show me my app's windows and show me
all windows functions send the sheet offscreen.
These are all fixed by the system in
, but icky where you own the code is preferable
to icky where you're having to reverse-engineer someone else's code.
-scott
On Fri, May 8, 2009 at 11:20 AM, Avi Drissman a...@google.com wrote:
On Thu, May 7, 2009 at 9:49 AM, Mark Mentovai m...@chromium.org wrote:
Hit login, then play with Exposé
Thanks.
So I fiddled with the hiding sheets part, and now leave the sheet in place
but make it fully transparent. That helps a lot with some expose issues (and
all the ones still left are fixed in SL). That leaves the fact that the
shouldterminate delegate call is broken and that event handling
, and the behavior looks right. Nice
job! I vote for continuing with this approach.
--Amanda
On Thu, May 7, 2009 at 12:17 AM, Avi Drissman a...@google.com wrote:
OK, so attached is my proof of concept. The code is pretty clear, though
if
you have questions, please let me know.
+maf: Your
Having signed up for the login dialog, I'm seeing that it's a pretty
interesting subject. If you try out a page with HTTP auth, you'll see that
you get what looks like a dialog for the username and password. But if you
click around, you find that you can switch tabs, and that the dialog is
.
A Mac-style sheet would be consistent with other tab-related UI like
the find bar.
On Tue, May 5, 2009 at 2:40 PM, Avi Drissman a...@google.com wrote:
Having signed up for the login dialog, I'm seeing that it's a pretty
interesting subject. If you try out a page with HTTP auth, you'll see
. There's also some stuff Jeremy was
doing in Gears that involved doing interesting things with login
prompts that may (or may not) be relevant. It would certainly be nice
to keep things tab-modal, even though Cocoa doesn't really grok that
idea.
--Amanda
On Tue, May 5, 2009 at 5:40 PM, Avi
On Mon, Apr 27, 2009 at 11:21 AM, Evan Martin e...@chromium.org wrote:
That leaves process_util for Linux and Mac, which uses fuser (or
something similar) and that is a hack. However, it's only used for ui
tests, I believe -- it's not needed in normal usage.
The Mac uses ps -xw, but the
Erik—
I don't understand why in http://codereview.chromium.org/17243 you defined
Extension() to have a leading dot. It's easier to add a dot than take one
off, and I don't understand why you insist on the equivalence you describe.
How is ensuring that you could append the string values of the
I'm still a little lost in this discussion. I'm repeatedly reading the code
and the patch, and I'll get back to you when I fully understand it. But what
I wanted to say is that there is a significant difference in the paint
pipeline as it currently exists on the Mac compared to Win/Lin.
On Win,
On Mon, Apr 13, 2009 at 12:13 PM, Darin Fisher da...@chromium.org wrote:
You need to change the Mac implementation to flush to the screen when
DidPaintRect is not called withing drawRect / GetBackingStore.
I'll put it on my list of things to do. (First is fixing a bug that is
causing drawing
http://dev.chromium.org/developers/design-documents/ui-localizationdescribes
the process of adding a resource. It goes something like this:
1. Add the key to a .grd file
2. ???
3. Translations show up in .xtb files
I need to split an existing key, though (one that is actually two strings in
the
will just fall back to the English
translation in generated_resources.grd. The magic ids won't match anymore
since you changed the English string so everything will just default to the
English text.
On Tue, Apr 7, 2009 at 10:27 AM, Avi Drissman a...@chromium.org wrote:
I don't need
Last week I complained about svn being slow on Windows, and Peter K (IIRC)
suggested that I keep my drive defragged. I did so, and things are now
zippy. Thanks!
If you use Windows, I'd highly recommend setting up a task to keep your
drive clean. Follow the instructions at
In re to http://codereview.chromium.org/48103/show:
I like where you went, but this leaves me in a tough spot. I was
implementing them in http://codereview.chromium.org/45040/show and now I'm a
bit stuck.
RWHV lives inside a view, and self-destructs when it's removed from the
view. Its lifetime
Oh! CreateNewWidgetInternal is virtual! That's... useful.
Avi
On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman a...@chromium.org wrote:
In re to http://codereview.chromium.org/48103/show:
I like where you went, but this leaves me in a tough spot. I was
implementing them in http
On Wed, Mar 25, 2009 at 2:02 PM, Avi Drissman a...@chromium.org wrote:
Oh! CreateNewWidgetInternal is virtual! That's... useful.
Avi
On Wed, Mar 25, 2009 at 4:58 PM, Avi Drissman a...@chromium.org wrote:
In re to http://codereview.chromium.org/48103/show:
I like where you went
On Sun, Mar 22, 2009 at 5:10 PM, Adam Langley a...@chromium.org wrote:
struct s a = {0}; will initialise all members of the structure to zero.
Correct. The C++ Standard, §12.6.1 (Explicit initialization) paragraph 2
says:
When an aggregate (whether class or array) contains members of class
a breakpoint in
OnGetRootWindowRect please and see if clicking on a link in an
email in gmail passes a HWND of null at all?
Thank you,
--Craig
On Thu, Mar 19, 2009 at 7:33 PM, Avi Drissman a...@google.com wrote:
We've been seeing calls to ResourceMessageFilter::OnGet(Root)WindowRect
http://codereview.chromium.org/47002
http://crbug.com/9060
Avi
On Fri, Mar 20, 2009 at 10:58 AM, Avi Drissman a...@google.com wrote:
I don't disagree with the statement you shouldn't let the renderer crash
the browser but I'm trying to understand if a null window ref is an
expected value
The term activatable, as seen in RenderWidgetHostViewWin, etc, is not
clearly defined. The only explanation I've found is:
Autocomplete popup windows for example cannot be activated.
Can someone provide a meaning? Does that mean that it can never become the
focus for keystrokes? I get a vague
Ah. Thanks.
Avi
On Fri, Mar 20, 2009 at 5:07 PM, Peter Kasting pkast...@google.com wrote:
On Fri, Mar 20, 2009 at 2:03 PM, Avi Drissman a...@google.com wrote:
The term activatable, as seen in RenderWidgetHostViewWin, etc, is not
clearly defined.
Windows has two concepts relating to focus
We've been seeing calls to ResourceMessageFilter::OnGet(Root)WindowRect for
NULL windows. agl put in a fix for GTK with
http://codereview.chromium.org/42356 and I'm seeing the same problem on the
Mac.
1. Why isn't Windows seeing this? What happens when you pass a null HWND
into ::GetAncestor and
Uh. Wow.
Wow.
+5 for awesome.
Avi
On Sun, Mar 15, 2009 at 9:54 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Hello!
A lot of people told me that they did not like the waterfall, mainly
because it's hard
to find out where and when a change is tested, and what the result is. (It
Right. So the idea is a child window, borderless, with custom drawing.
Shouldn't be too hard, and I'm envisioning some use of Core Animation to do
things like the fading...
Avi
On Fri, Mar 13, 2009 at 9:17 AM, Amanda Walker ama...@chromium.org wrote:
On Fri, Mar 13, 2009 at 8:17 AM, Dean
OK, so there's this nifty SendWithTimeout on SyncChannel. Awesome. And
RenderViewHost just has to call it, just like it calls Send() today for
other calls.
This is where things are falling apart for me.
For Send(), RenderViewHost calls (via RWH) its Send(), which calls
RenderProcessHost's
window, and drop the pop out of the
main window behavior, or to special-case it when you move the mouse
over it but pop it back in if you start dragging the window. In any
case, what I have done (a popup window that appears topmost) is not
what I think we want.
On Thu, Mar 12, 2009 at 1:57 PM, Avi
Now that the Clipboard change is in, I was about to land a quick, small
patch to turn on copy/paste, when I ran into an interesting problem. If you
copy something from the webpage you're viewing, and try to paste it into the
URL box, we die. In digging, I found out what's going on.
When we copy,
Walker awal...@google.com wrote:
For the URL field, I think that (1) is the best solution until we
replace it with a real omnibox, at which point things could get
complicated (since it'll need attributes for color etc. at the very
least).
--Amanda
On Wed, Mar 11, 2009 at 10:29 AM, Avi
Let's be precise here. The problem is when an NSAttributedString is
initialized with HTML. It's not a general NSAttributedString problem.
Avi
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email
differently for us, but conveniently named-mangled the same
so they link?
--Amanda
On Wed, Mar 11, 2009 at 10:49 AM, Mark Mentovai mmento...@google.com
wrote:
Avi Drissman wrote:
4. Figure out why system WebKit doesn't get along with our WebCore. I'm
not
sure where to start.
Obj-C
1 - 100 of 133 matches
Mail list logo
