[Reposting from wrong mailing list, sorry for dupe.]
On Mac/Linux, IPC::Channel uses socketpairs (or in some cases named
pipes), with one end passed through the spawn to the child process.
Right now the interfaces don't expose this dependency, so I'm thinking
of refactoring things a bit to do
On Wed, Feb 4, 2009 at 11:02 AM, Darin Fisher da...@chromium.org wrote:
On Wed, Feb 4, 2009 at 10:54 AM, Scott Hess sh...@chromium.org wrote:
On Mac/Linux, IPC::Channel uses socketpairs (or in some cases named
pipes), with one end passed through the spawn to the child process.
Right now
On Wed, Feb 4, 2009 at 11:10 AM, Thomas Van Lenten
thoma...@chromium.org wrote:
On Wed, Feb 4, 2009 at 2:02 PM, Darin Fisher da...@chromium.org wrote:
On Wed, Feb 4, 2009 at 10:54 AM, Scott Hess sh...@chromium.org wrote:
[Reposting from wrong mailing list, sorry for dupe.]
On Mac/Linux, IPC
On Thu, Feb 19, 2009 at 4:53 AM, Dean McNamee de...@chromium.org wrote:
I've started working on a GTK omnibox widget. I'll let you know when
I have some more progress.
I've been trying to figure out omnibox from the Mac side. I don't see
anyone else having claimed it, let me know if I'm
On the Mac, code like this:
namespace {
class MyTest : public testing::Test {
};
} // namespace
TEST_F(MyTest, ATest) {
}
generates errors like this:
warning: ‘MyTest_ATest_Test’ has a field
‘MyTest_ATest_Test::anonymous’ whose type uses the anonymous
namespace
warning: ‘MyTest_ATest_Test’
If SQLite is crashing due to corruption in the database, we should be
able to get Dr Hipp to help fix it. But we'd need a repeatable case
to send to him. If we had a database which demonstrated this, I could
certainly see about crafting a simplified database of example data to
replicate the
, Darin Fisher da...@chromium.org wrote:
On Tue, Mar 3, 2009 at 3:55 PM, Scott Hess sh...@chromium.org wrote:
On the Mac, code like this:
namespace {
class MyTest : public testing::Test {
};
} // namespace
TEST_F(MyTest, ATest) {
}
generates errors like this:
warning: 'MyTest_ATest_Test
2009/3/6 William Chan (陈智昌) willc...@chromium.org:
2009/3/6 Scott Hess sh...@chromium.org:
I just wanted to make sure I understood your proposal.
Right now, test classes want to be in the anonymous namespace so that
unit test files do not have to coordinate with each other in the
naming
I'm refactoring my Omnibox code towards something I'm willing to put
up for review, and am realizing that I need to find a way to rule on
whether I should have thick Objective-C helpers or thin ones. Say for
instance that I have an NSTableView, I'll need a data source for that,
which needs to be
is to leverage the --user-data-dir command line switch to force the chrome
instance launched by the ui_tests to use a dedicated user data directory.
We toss that directory prior to each test case IIRC.
-Darin
On Wed, Apr 8, 2009 at 11:10 AM, Scott Hess sh...@chromium.org wrote:
I posted this on the irc
On Fri, Apr 24, 2009 at 10:19 PM, Brett Wilson bre...@chromium.org wrote:
On Fri, Apr 24, 2009 at 10:10 PM, Aaron Boodman a...@chromium.org wrote:
Is it possible to enforce these rules with code rather than capital letters?
I don't think I've made this particular error, but it's something I
On Fri, May 1, 2009 at 11:17 AM, Aaron Boodman a...@chromium.org wrote:
We can use DuplicateHandle() to get the input file handle in, but I am
not sure what to do about getting the directory sturcture out.
Crazy-talk: Have the renderer unpack the zip into a SQLite database.
HEROIC!
On Fri, May 1, 2009 at 2:38 PM, Dimitri Glazkov dglaz...@chromium.org wrote:
Hello all,
This is kind of a momentous occasion. For the first time -- ever, our
WebKit Canary bot (the one that pulls directly from WebKit upstream)
has built successfully and was able to run tests:
I agree with the earlier argument about not larding startup with
things like writing new files to id the coming-up Chrome to
late-coming instances. An alternative might be to acquire a lock to
protect the profile, and write an id asynchronously after startup.
The late-coming instance would see
The why is probably because I misunderstood something. With an
NSTextField there, we can't set the selection without having focus,
which may have confused me into grabbing focus in cases where it isn't
needed (or requested). I've been spending some time figuring out
where all that code can get
This post made me think that we should have infrastructure so that
certain unit tests can opt to run in a restricted environment to
enforce that someone doesn't come along and add filesystem-access code
or other known-bad synchronous APIs.
I realize that that is probably hard, and that patches
If this is the only reason gmock needs boost, it seems like a better
idea would be to push a copy of tuple.h into gmock and submit a patch
to make it more self-contained in the first place.
-scott
On Fri, May 15, 2009 at 11:17 AM, Albert J. Wong (王重傑)
ajw...@chromium.org wrote:
One other idea
I think the headers and footers are confusing (everywhere). Why not
just a single popup for each selection which displays a real-time view
of each thing? So it might have items like:
Header: Bonsai Kitten
http://www.shorty.com/bonsaikitten/;
Footer: Page 1 of 2
?
-- Mohamed Mansour
On Tue, Jun 2, 2009 at 3:48 PM, Scott Hess sh...@chromium.org wrote:
I think the headers and footers are confusing (everywhere). Why not
just a single popup for each selection which displays a real-time view
of each thing? So it might have items like:
Header: Bonsai
there, rather
than having to go into printer options...
-ian
2009/6/2 Scott Hess sh...@chromium.org
What I meant was to have a popup full of formatted choices which look
like the thing you want to have. So instead of Page # of #, which
is pretty abstract, Page 1 of 2. Also, instead of have six
In my experience, taking code which assumes a low number of file
descriptors and just ramping up the file descriptor limits to
accommodate a particular case doesn't work out well. You end up
finding out that there are three or four other edge cases which cause
problems, things like O(N^2) code
about:crash is quite naturally one of our top crashers. When the Mac
dev channel went out, I saw this an entered http://crbug.com/13453 ,
thinking that the fact that we were receiving those crashes probably
meant we'd forgot to disable something before executing the handler.
But, no, it's also a
On Tue, Jun 16, 2009 at 3:37 PM, Stuart Morganstuartmor...@chromium.org wrote:
On Tue, Jun 16, 2009 at 2:32 PM, Scott Hesssh...@chromium.org wrote:
So, I'm inclined to mark it WontFix, except that then searches in the
Issues database won't find it.
Do we think it's something people are
Against that, I sometimes use git to manage breaking reviews up. I'm
always a bit unhappy to get a review which includes one bit of complex
stuff that needs a bunch of back-and-forth, and another few bits of
uncontentious stuff which is easy to +1. I'd rather see those
separately, so that the
As a general observation on large development teams, infrastructure
can get less love, because everyone comes to the team to work on the
exciting main product, not the more mundane build infrastructure. If
you have ideas on how to fix this stuff, I think it would be perfectly
reasonable to put
On Mon, Jul 13, 2009 at 10:10 AM, Jeremy Orlowjor...@chromium.org wrote:
On Mon, Jul 13, 2009 at 10:08 AM, Brett Wilson bre...@chromium.org wrote:
Yes, I think NullableString16 is better than passing a separate bool.
Can anyone think of a better name for it?
What's wrong with
If I understand right, simply serving the auto-refresh requests is
substantial? At least for the main page, a reverse in accelerator
mode could turn that into a constant load.
[I'd offer to help, but I don't know what kind of technology we're
talking about, here.]
-scott
On Tue, Jul 14, 2009
Looks to me like the code in question wouldn't be compiled into
release builds in the first place (it's under NDEBUG). So it might be
problematic to match it to a known bug, since the known bugs would
mostly look different.
The general case of Started typing in omnibox and crashed is
obviously
+1.
There are tabs which I am using and will use consistently all the time
(mail, calendar, things like that). For awhile on Firefox I had those
pinned and turned into favicon-only tabs using extensions, and it
mostly worked well. Then there are collections of on deck tabs
associated with
I don't think it's reasonable to require the user to specify which
tabs to suspend, except, perhaps, if we develop a metric for
power-hungry tabs and expose that.
I think there is some potential for UI geared towards particular
use-cases which could be overloaded to also allow more aggressive
If reverting RELEASE_NOTE really becomes a big problem, someone could
write a wrapper script to manage that. That seems more sensible than
adding a manually-maintained file.
I'm not really sure if the right solution would be to drop
RELEASE_NOTE for items which are reverted. If they are
The stuff I'm implementing is important to _me_, but is it important
enough to be in the release notes?
Maybe we should have a tag for the issue-tracker which indicates that
the issue is release-note-worthy, and we could use action on those
bugs to help figure out which items are worthy of being
BTW: if people aren't annotating their CL's with bugs, they SURELY
won't annotate them with release notes or update the change log. Just
aiming for the path of least resistance, here.
-scott
On Wed, Jul 22, 2009 at 11:46 AM, Scott Hesssh...@chromium.org wrote:
The stuff I'm implementing is
On Thu, Jul 23, 2009 at 9:01 AM, Nicolas Sylvainnsylv...@chromium.org wrote:
On Thu, Jul 23, 2009 at 8:53 AM, Evan Martin e...@chromium.org wrote:
On Thu, Jul 23, 2009 at 7:47 AM, Nicolas Sylvainnsylv...@chromium.org
wrote:
gclient has nothing to do with this case. svn update src/ was
Would it be possible/reasonable to use distcc plus a farm of
cross-compiler machines to let you do faster self-hosted builds? It's
not the right solution, but in the past I've found it to sometimes
be an easier path to take in the short term while you're working on
fixing all the little
fts uses what is effectively a form of compression for the index, so
most any stream of data will decode at some level. My bet in this
case is that the segdir is referencing a segment block which doesn't
exist, so someone inappropriately tries to decode NULL.
From what I recall of debugging
Another alternative would be a ping type call to say I'm
unresponsive, and I mean it. Like a watchdog timer. The plug-in
could still effectively be hung, but at least it has to have things
together enough to call the watchdog.
-scott
On Fri, Sep 11, 2009 at 3:37 PM, John Abd-El-Malek
.)
That avoids the need to have a plugin be trusted in any way, but keeps
the UI simple unless the plugin knows it wants to display it and get
debugged. You'd still have to deal with the dialog once but after that
it would get out of your way.
--Mike
On Fri, Sep 11, 2009 at 3:41 PM, Scott Hess sh
On Wed, Sep 16, 2009 at 1:07 PM, Mike Mammarella m...@chromium.org wrote:
On Wed, Sep 16, 2009 at 12:59 PM, Evan Martin e...@chromium.org wrote:
On Wed, Sep 16, 2009 at 12:44 PM, spotrh spo...@gmail.com wrote:
On 09/16/2009 02:23 PM, Evan Martin wrote:
What is the error message? I wonder if
Also, if you search for chromium 26042, then the paths all start
with branches/195/src/
-scott
On Thu, Sep 17, 2009 at 2:15 PM, Amanda Walker ama...@chromium.org wrote:
On Thu, Sep 17, 2009 at 5:10 PM, Rozenkraft rozenkr...@gmail.com wrote:
Ok, it makes sense now, sorry. I was confused
Why is cocoa_test_helper.mm listed in the browser library? This
results in the class being linked into Google Chrome Framework
(meaning it ships). Doesn't seem appropriate to me. This came up
because I have some helper code I was listing in the unit_tests
section of chrome.gyp. Since it's in
I think we should be willing to take a temporary performance hit on the dev
channel in the interests of generating data which will eventually improve
stability.
Could we set jemalloc on selected renderer processes? I realize that
wouldn't necessarily only impact the target domains, but it might
On Thu, Oct 1, 2009 at 11:32 AM, Mike Belshe mbel...@google.com wrote:
On Thu, Oct 1, 2009 at 11:27 AM, Scott Hess sh...@chromium.org wrote:
Could we set jemalloc on selected renderer processes? I realize that
wouldn't necessarily only impact the target domains, but it might be
better than
Our use of exclusive locking and page-cache preloading may open us up
more to this kind of shenanigans. Basically SQLite will trust those
pages which we faulted into memory days ago. We could mitigate
against that somewhat, but this problem reaches into areas we cannot
materially impact, such
On Tue, Oct 6, 2009 at 5:09 PM, Jeremy Orlow jor...@chromium.org wrote:
On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote:
On Tue, Oct 6, 2009 at 4:30 PM, Carlos Pizano c...@google.com wrote:
On Tue, Oct 6, 2009 at 4:14 PM, John Abd-El-Malek j...@chromium.org wrote:
On Tue, Oct 6, 2009 at 5:24 PM, Dan Kegel d...@kegel.com wrote:
1) zfs was right: checksums are a good idea. Can we add them to sqlite?
I believe so, but I'm still working through the details. And by
working I mean thinking. The challenge is in finding places to
tuck things away where they
You could replace the favicon with a spinning clock or something. It
might also be interesting to provide indicators for high memory usage
(or perhaps if the recent memory growth is high), or IPC issues.
Then again, many users might prefer not to have their tabs attracting
attention needlessly.
In fixing a Mac bug, I recently added a layer to intercept
-[NSApplication sendAction:to:from:] and make sure a certain message
wasn't forwarded if the target was known to be freed. Since this is
sort of a core function for event dispatch, now we're seeing
crashdumps with my new method on the
Of course, it didn't ACTUALLY get better until I got annoyed enough to
figure out how to upgrade my system's version of flash. I went out
and followed web instructions for apt-removing the older version and
installed the newer deb from Adobe.
Of course, that didn't fix it either. Eventually it
On Fri, Oct 9, 2009 at 8:55 AM, Evan Martin e...@chromium.org wrote:
We de-duplicate multiple instances of the same file. If you have
multiple copies of the same file we attempt to prioritize
non-nspluginwrapper versions over nspluginwrapper-wrapped versions.
After that, the list of plugins
. Unfortunately, right
// now, the same dictionary is used for both Breakpad's parameters AND
// the Upload parameters.
If you look at the code that logs URLs you'll note that a URL is split over
several keys.
Best regards,
Jeremy
On Wed, Oct 7, 2009 at 10:48 PM, Scott Hess sh...@chromium.org wrote
Does this relate to receiving crashbot emails adding Crash labels on
closed-out bugs where the backtrace doesn't apparently have any
relevance to the original backtraces involved with the bug? I've
gotten a couple of these in the past week.
-scott
[Unfortunately, I don't remember the earlier
On Mon, Oct 12, 2009 at 7:44 AM, Nicolas Sylvain nsylv...@chromium.org wrote:
On Sun, Oct 11, 2009 at 11:33 AM, Jeremy Orlow jor...@chromium.org wrote:
Is there documentation anywhere for all the parameters you can feed into
the buildbot webpage? If not, a cheat sheet would be really helpful.
On Linux what about mmap() and then madvise() with MADV_WILLNEED? [or
posix_fadvise() with POSIX_FADV_WILLNEED on the file descriptor).
-scott
On Thu, Oct 22, 2009 at 2:06 PM, Steve Vandebogart vand...@chromium.org wrote:
If you plan to read the entire file, mmap()ing it, then faulting it in
posix_fadvise should give the same speeds as read()ing
it into memory. IIRC though, posix_fadvise will only read so much in a
single request and will let readahead handle the rest after that.
--
Steve
On Thu, Oct 22, 2009 at 2:27 PM, Scott Hess sh...@chromium.org wrote:
On Linux what about mmap
the best way
is to fadvise() it in, then mmap() it and use it from there.
--
Steve
On Thu, Oct 22, 2009 at 2:52 PM, Scott Hess sh...@chromium.org wrote:
Faulting it in by hand is only helpful if we're right! If we're
wrong, it could evict other stuff from memory to support a feature
which a user
Just to be clear for those of us who are wobbly on C++, this is
because during the constructor or destructor, your object is of the
class in question, NOT of the class it will finally be, because in the
constructor the subclass has not been constructed, yet, and in the
destructor the subclass was
On Fri, Oct 30, 2009 at 3:54 PM, Jeremy Orlow jor...@chromium.org wrote:
On Fri, Oct 30, 2009 at 3:46 PM, Scott Hess sh...@chromium.org wrote:
Just to be clear for those of us who are wobbly on C++, this is
because during the constructor or destructor, your object is of the
class in question
...@chromium.org wrote:
I've heard this suggested a few times (not just in this thread) - is there
an advantage to running Carbon Emacs instead of
plain-old-GNU-Emacs-in-a-terminal?
-atw
On Tue, Nov 3, 2009 at 1:14 PM, Scott Hess sh...@chromium.org wrote:
+1. I found Aquamacs weird/annoying
+100.
This is very similar to getting paged about a production problem.
Sometimes you get sucked into wasting an hour on easy fixes which
don't fix anything. That sets you up for stupid mistakes.
So, you broke the build. Take it like a man/woman, revert your
change, and land it again when
On Thu, Nov 5, 2009 at 1:33 PM, Antoine Labour pi...@google.com wrote:
On Thu, Nov 5, 2009 at 12:44 PM, Ben Goodger (Google) b...@chromium.org
wrote:
it'd be nice to have a gclient config lean or something like that.
It'd be nice for it to be the default in fact.
As long as we're on
Applying incorrect journal files would be bad. SQLite uses a sync
cookie to do some tricks WRT keeping the cache warm. I'm somewhat
surprised that the same thing isn't used to prevent applying journal
files inappropriately.
[I don't know this, and should not be spending time verifying it just
On Mon, Nov 9, 2009 at 6:40 PM, Scott Hess sh...@chromium.org wrote:
Applying incorrect journal files would be bad. SQLite uses a sync
cookie to do some tricks WRT keeping the cache warm. I'm somewhat
surprised that the same thing isn't used to prevent applying journal
files inappropriately
lucky, it will just be
the Extensions dir or Extensions Cookies file.
-scott
On Wed, Nov 11, 2009 at 1:35 AM, PhistucK phist...@chromium.org wrote:
I have a corrupt profile.
Scott Hess wanted to know about these kinds of things, so I e-mailed him
more than a week ago, but he did not answer
Long ago when developing fts1, I experimented with using zlib
compression as part of the implementation. It fell by the wayside
because it really didn't provide enough performance improvement (I
needed an order of magnitude, it didn't provide it), and because of
licensing issues (fts1/2/3 are
On Thu, Dec 10, 2009 at 10:58 AM, Peter Kasting pkast...@google.com wrote:
On Thu, Dec 10, 2009 at 10:45 AM, Jonathan Dixon j...@chromium.org wrote:
In essence:
return DoWork(foo)
#if defined(OS_POSIX)
DoWork(posix_specific)
#endif
; // -- Lint complains about this guy
I'd
On Fri, Dec 11, 2009 at 10:43 AM, Glen Murphy g...@chromium.org wrote:
As for the info bar/modal dialog: I've been thinking for a bit, and I'm
not sure this is enough. We have plenty of data that shows users often
leave browsers open for a very long time. The main risk is that someone
sets
On Thu, Dec 31, 2009 at 1:11 AM, Berend-Jan Wever skyli...@chromium.org wrote:
It would be nice if we could name all threads, so you know what you're
looking at.
It would be nice if threads were required to be given a name as part
of creation, perhaps with a central registry to make sure things
On Sat, Jan 9, 2010 at 3:06 PM, Victor Khimenko k...@google.com wrote:
P.S. There are interesting fact related to specifically colon and MacOS.
Classic MacOS uses colon as delimeter and you can use slash in filename.
when they used POSIX-compliat kernel they needed some way to resolve thus
On Thu, Jan 14, 2010 at 1:31 AM, Victor Khimenko k...@google.com wrote:
Consider this attack vector: URL file on Desktop. Chrome will be started
from known directory, now we need to put malicious file there. Hmm. Easy:
create archive with some valuable data AND file http:/www.google.com (as
On Thu, Jan 14, 2010 at 6:56 AM, Victor Khimenko k...@google.com wrote:
On Thu, Jan 14, 2010 at 5:38 PM, Scott Hess sh...@google.com wrote:
On Thu, Jan 14, 2010 at 1:31 AM, Victor Khimenko k...@google.com wrote:
Consider this attack vector: URL file on Desktop. Chrome will be started
from
would understand what we're talking about
could trivially write a shell script or alias to handle it, if they
care to.]
On Thu, Jan 14, 2010 at 9:15 AM, Scott Hess sh...@google.com wrote:
On Thu, Jan 14, 2010 at 6:56 AM, Victor Khimenko k...@google.com wrote:
On Thu, Jan 14, 2010 at 5:38 PM, Scott
On Thu, Jan 14, 2010 at 1:16 PM, Peter Kasting pkast...@google.com wrote:
On Thu, Jan 14, 2010 at 9:19 AM, Scott Hess sh...@google.com wrote:
[BTW, don't take my argument as support for allowing relative paths on
the command-line. It's such a low-volume use-case that I'd be
perfectly fine
BTW, AFAICT on both Mac and Linux, chrome-cmd file.html opens
file:///path/to/cwd/file.html. Mac works for opening relative
http:/file.html. Since http: is not a valid filename for Windows,
I'd say making them all consistent would make sense.
On Thu, Jan 14, 2010 at 1:55 PM, Scott Hess sh
74 matches
Mail list logo
