Thanks for the report! I'll try to reproduce and fix it.
Which ARM toolchain are you using?
Andrew
On Fri, Dec 18, 2009 at 5:01 AM, Richard Zhao linux...@gmail.com wrote:
Default branding is Chromium.
source/config/ChromiumOS/linux/arm/config.h define HAVE_NEON,
but from ffmpeg.gyp, neon
Anyhow, what's our best practices for disabling tests? I think ideally we'd
always log a tracking bug and add a comment, akin to what we do in the
test_expectations file for layout tests. This might be too much of a burden
on sheriffs, so an alternative is for people who are working on
I've written a document describing our current implementation of the audio
and video tags:
http://sites.google.com/a/chromium.org/dev/developers/design-documents/video
If you're interested in helping out, feel free to reply to me privately or
take a look at our
(resending to chromium-dev)
Sheriffing the PST time zone is usually the worst. We could experiment with
tweaking the scheduling algorithm to have two PST sheriffs and one non-PST
sheriff per shift.
Other than that -- fixing flaky tests would go a long way to making the job
easier. Right now
Something that would have been immensely helpful to me when I started was a
talk explaining the interaction between the javascript bindings,
HTMLFooElement classes and RenderFoo classes.
I'd volunteer, but I still don't know enough about this stuff myself --
other than when Foo == Media :)
TextMate is pretty solid and very customizable. I wonder if we can get gyp
to generate .tmproj files :P
I also like it's command line tool mate for opening files from the
Terminal.
On Tue, Nov 3, 2009 at 9:56 AM, Paweł Hajdan Jr. phajdan...@chromium.orgwrote:
Recently I started working more
Very cool!
Could this idea be done in the render process? We try to keep the media
processing code off the render thread but we've been bitten using cached
MessageLoops which have been destructed (usually on tab close when the
render thread goes away).
On Mon, Nov 2, 2009 at 9:50 PM, John
I believe git-svn is incapable of handling svn properties. I usually do a
follow-up TBR CL using svn to set properties, which is annoying.
git-cl relies on git-svn to do the actual committing, so I think we'd be
patching up git-svn to support properties.
On Thu, Oct 29, 2009 at 5:13 PM, John
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote:
On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote:
If you add the junk to your ~/.subversion/config that's specified on this
page
http://dev.chromium.org/developers/coding-style
then git will do the
I'm preparing to land a change to the Chromium XP and Google Chrome FYI
build bots that make sure all Windows DLL and EXE files were built with
/NXCOMPAT and /DYNAMICBASE. You can read about these neat security features
here:
On Sat, Oct 24, 2009 at 6:35 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Fri, Oct 23, 2009 at 2:16 PM, Andrew Scherkus scher...@chromium.orgwrote:
On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain
nsylv...@chromium.orgwrote:
On Fri, Oct 23, 2009 at 12:21 PM, Andrew Scherkus
I've been trying to get the media layout tests passing consistently, but
WebKit Linux (dbg)(3) takes an absurdly longer time to run tests and I don't
know why.
For example:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=video-played
To
:02 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Fri, Oct 23, 2009 at 11:59 AM, Andrew Scherkus
scher...@chromium.orgwrote:
I've been trying to get the media layout tests passing consistently, but
WebKit Linux (dbg)(3) takes an absurdly longer time to run tests and I don't
know why
On Fri, Oct 23, 2009 at 12:28 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
On Fri, Oct 23, 2009 at 12:21 PM, Andrew Scherkus
scher...@chromium.orgwrote:
I've never witnessed these tests taking an extra 10-20 seconds on my local
machine, no.
I don't doubt that some of the tests might
If you roll WebKit DEPS and media layout tests start failing, don't fret!
Mark them as PASS FAIL and assign them to bug 13907. Don't worry about
specifying the operating system or release/debug -- our code is mostly
platform agnostic so if it flakily fails on one bot, it's only a matter of
time
Interesting development with the media timeout failures. Whenever you start
skipping some, different media layout tests start timing out! Looks like
there's some nasty threading/racing issue at play...
http://code.google.com/p/chromium/issues/detail?id=25094
On Fri, Oct 16, 2009 at 3:45 PM,
Hrmm... it looks your script assumes depot_tools is in your PATH -- if it
can't find it the script crashes.
Trying to figure out a workaround. If all else fails I can always give in
and add depot_tools to my PATH :)
On Wed, Oct 14, 2009 at 11:08 PM, Aaron Boodman a...@chromium.org wrote:
On Thu, Oct 15, 2009 at 11:03 AM, Chase Phillips ch...@chromium.org wrote:
Hi Andrew,
On Wed, Oct 14, 2009 at 11:31 PM, Andrew Scherkus
scher...@chromium.orgwrote:
Hrmm... it looks your script assumes depot_tools is in your PATH -- if it
can't find it the script crashes.
Thanks
I'll take on the media ones.
On Thu, Oct 15, 2009 at 6:38 PM, Ojan Vafai o...@google.com wrote:
There are a lot of tests that consistently (i.e. not flaky) timeout. They
eat up significant percentage (~10%!) of the cycle time for the test bots
(e.g., 1 minute on Windows release). If LTTF folk
On Tue, Oct 13, 2009 at 3:55 PM, Ojan Vafai o...@chromium.org wrote:
On Tue, Oct 13, 2009 at 3:50 PM, Andrew Scherkus scher...@chromium.orgwrote:
What's happening is loadstart fires and the video reloads which should
cause an abort event. For some reason load will occasionally fire after
This might only apply to the media layout tests, but I'll give the heads up
anyway...
We found flakiness even when using load if the test is explicitly trying to
test for stalled/progress/abort events before the load is completed:
It'd be nice to have a non-distracting visual indicator, but to play the
devil's advocate...
What about intentionally CPU intensive sites that use canvas, video,
WebGL?
What about scenarios where it's a plugin that's gone haywire?
Could this be accomplished by an extension that displays a little
On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
We just noticed that the Chromium Helper.app cannot locate the ffmpeg
binaries (libav*.dylib) in Mac Chromium. This leads to the video feature
being disabled. :(
Where should the ffmpeg binaries go? Should they
The thing about the media layout tests is ~2 weeks ago all of them were
failing. We've flipped switched to get them running and even after
disabling a bunch due to flakiness we're still ahead -- just need to keep up
the fixes.
Andrew
On Wed, Oct 7, 2009 at 9:36 AM, Peter Kasting
On Tue, Oct 6, 2009 at 1:07 PM, Peter Kasting pkast...@google.com wrote:
This is your friendly Chromium sheriff. I've been adding tons of
suppressions to test_expectations.txt over the last two days and they mainly
fall into three buckets. Could someone take a look at these, please, since
On Thu, Oct 1, 2009 at 1:22 PM, Anthony LaForge lafo...@google.com wrote:
A bit of fall cleaning. In order to clean-up the issue tracker labels a
bit and make some of the feature areas a bit more clear, I've made the
following changes:
- Type-Task, Type-Review, and Type-Other have been
I'm doing some video UI refactoring to use GraphicsContext but noticed
drawPath() is unimplemented (causes linker error).
What's a good practice to implementing something no one has ever used
before? Do we strive to be pixel perfect to GraphicsContextCG's
implementation? I don't want to cause
On Wed, Sep 30, 2009 at 12:38 AM, Brett Wilson bre...@chromium.org wrote:
On Wed, Sep 30, 2009 at 12:18 AM, Andrew Scherkus scher...@chromium.org
wrote:
I'm doing some video UI refactoring to use GraphicsContext but noticed
drawPath() is unimplemented (causes linker error).
What's a good
UI is a decent amount of custom drawing code
inside RenderThemeChromium[Skia/Mac] and maintaining both versions is
painful.
Or, were you planning on moving portions of rendering
into WebMediaPlayerClientImpl?
-Darin
On Wed, Sep 30, 2009 at 12:18 AM, Andrew Scherkus
scher
I've read somewhere before that you should do as little as possible inside
DllMain. Something like this comes to mind:
http://blogs.msdn.com/oldnewthing/archive/2007/09/04/4731478.aspx
Is it worth trying to defer calling OleInitialize?
For those that use third_party/WebKit as a full WebKit checkout, you'll need
to add the following line to your .gclient:
src/third_party/WebKit/WebKit/chromium: None,
Andrew
On Fri, Sep 25, 2009 at 11:51 AM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Yep, I specified one directory too deep.
/a/chromium.org/dev/developers/contributing-to-webkit
On Fri, Sep 25, 2009 at 12:14 PM, Andrew Scherkus
scher...@chromium.orgwrote:
For those that use third_party/WebKit as a full WebKit checkout, you'll
need to add the following line to your .gclient:
src/third_party/WebKit/WebKit
I'm not familiar with the code either, but if people are fine making
URLRequest::status() virtual, you can use gmock and be done. I have a hunch
there might be some push back :)
If you're really interested in deterministic results, the longer way looks
like you'd call
Queue complaints about audio :P
On Thu, Sep 17, 2009 at 10:35 AM, Aaron Boodman a...@chromium.org wrote:
I was stoked to play SMB III, but without music it isn't the same :-/.
- a
On Thu, Sep 17, 2009 at 10:14 AM, Peter Kasting pkast...@google.comwrote:
We use FFmpeg for HTML5 audio/video. I haven't fully tested a 64-bit build
of it under Linux yet. If you're interested in building the libraries you
can read through the instructions:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/README.chromium?revision=25428view=markup
The media tests are highly platform specific at the moment due to
differences in codec support. Keeping them lumped together under one bug
works for me.
Andrew
On Thu, Aug 27, 2009 at 1:55 PM, Dimitri Glazkov dglaz...@chromium.orgwrote:
Tests only pass if they are actually not loading any
microseconds :-/.
Explicit conversion as suggested doesn't seem that painful IMO.
Jim
On Thu, Aug 20, 2009 at 4:02 PM, Peter Kasting
pkast...@chromium.orgwrote:
On Thu, Aug 20, 2009 at 3:33 PM, Andrew Scherkus
scher...@chromium.org wrote:
Any opposition to globally declaring an operator ostream
Any opposition to globally declaring an operator ostream overload for
TimeDelta in base/time.h?
According to style guide it needs to be fully justified, but it'd be nice to
use DCHECK_xx/EXEPCT_xx/ASSERT_xx with TimeDeltas.
Andrew
--~--~-~--~~~---~--~~
Chromium
seem that painful IMO.
Jim
On Thu, Aug 20, 2009 at 4:02 PM, Peter Kasting pkast...@chromium.orgwrote:
On Thu, Aug 20, 2009 at 3:33 PM, Andrew Scherkus
scher...@chromium.orgwrote:
Any opposition to globally declaring an operator ostream overload for
TimeDelta in base/time.h
Right. Chromium only supports the Ogg container with Vorbis audio and
Theora video.
On Tue, Aug 18, 2009 at 5:43 PM, loligoth loligo...@gmail.com wrote:
you mean Ogg/Theora right? I think Ogg/Vorbis is an auido codec, not a
video codec.
On Aug 4, 9:55 am, Albert J. Wong (王重傑)
Every so often I like peeking at the test coverage stats, but I'm seeing
403 Forbidden at the moment:http://build.chromium.org/buildbot/coverage/
Andrew
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change
Great -- thanks!
Andrew
On Wed, Aug 19, 2009 at 4:07 PM, Bev Cristobal b...@chromium.org wrote:
Hi Andrew.
This has been fixed.
- Bev
On Wed, Aug 19, 2009 at 2:00 PM, Andrew Scherkus scher...@chromium.orgwrote:
Every so often I like peeking at the test coverage stats, but I'm seeing
picky, perhaps HTML5 is the wrong
name for this? Maybe OWP would be better since HTML5 is only a subset of
OWP?-Darin
On Fri, Aug 14, 2009 at 4:19 PM, Andrew Scherkus scher...@chromium.orgwrote:
Jon and I were going through the video bugs this morning and realized that
there is no way
FYI the issue should resolve itself next time you run gclient sync with
cygwin svn:http://src.chromium.org/viewvc/chrome?view=revrevision=23035
Let me know if you run into any issues.
On Mon, Aug 10, 2009 at 3:34 PM, Andrew Scherkus scher...@chromium.orgwrote:
This thread couldn't have been
My experience with this is that it's either all-or-nothing when it comes to
using cygwin tools. My main git-svn checkout was created using cygwin
svn+python, so I now need to comment out the lines in gclient that tries to
run the .bat file :\
Overall I think I'm happier with my all-cygwin
This thread couldn't have been more appropriately timed. I ran into the
Error 34 issue again checking out a fresh client :\
Never again...
http://codereview.chromium.org/164281
On Mon, Aug 10, 2009 at 11:17 AM, Jens Alfke s...@google.com wrote:
On Aug 7, 2009, at 5:25 PM, Peter Kasting
I think it'd interesting to try. I imagine we'd need some helper gmock
actions to take care of executing/deleting tasks.
Out of curiosity, would adding a HasPendingTasks() method solve your current
testing issue?
On Tue, Aug 4, 2009 at 6:28 AM, Marc-Antoine Ruel mar...@chromium.orgwrote:
I'm
In command form:
cd /path/to/chrome/src
./tools/gyp/gyp_chromium build/all.gyp
On Fri, Jul 24, 2009 at 6:54 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
It seems like there's some bad interaction between gclient and gyp's make
build generator that got uncovered when the gyp DEPS were
Even though git-cl doesn't have presubmit checks per se, I do like how it
forces your first line to = 100 characters (rietveld limitation, I
believe).
gcl gets around this issue by truncating your description and adding an
ellipsis.
On Wed, Jul 22, 2009 at 2:52 PM, Darin Fisher
On a related note, Frank (cc'd) ran into an issue where the mac try bots
have a less-strict compiler warning error than the build bots, which led to
a broken build once he checked in: http://codereview.chromium.org/155834
Probably a simple config tweak somewhere, but interesting nonetheless.
On Wed, Jul 22, 2009 at 7:07 PM, Dan Kegel d...@kegel.com wrote:
That's consistent with trybots doing debug builds.
Uninitialized var warnings only show up in optimized builds,
nothing we can do there but turn on optimizations.
Gotcha -- thanks for the explanation!
Andrew
On Thu, Jul
it didn't compile or get run.
Let's wait one more run and see if things fix themselves.
Ping again if the problem continues.
jrg
On Thu, Jul 16, 2009 at 3:38 PM, Andrew Scherkus scher...@chromium.orgwrote:
I think we're getting confused by time zones here.
I checked in at Wednesday at 18:26
Thanks for spotting this! Figures it happened in one of the files I didn't
write a unit test for :)
Fix is up for review: http://codereview.chromium.org/155703
Andrew
On Fri, Jul 17, 2009 at 10:19 AM, Jeremy Orlow jor...@chromium.org wrote:
Hi ffmpeg, :-)
Chromium doesn't accept patches
So I checked in a change that did some refactoring and added unit tests for
two classes that were previously not tested:
http://src.chromium.org/viewvc/chrome?view=revrevision=20836
According to the coverage graphs, that change actually brought both the
source code and test code coverage *down*.
:
The bottom of the link says that coverage information was generated
Wednesday. Your checkin was Thursday. Would that have something to do
with it?
- nick
On Thu, Jul 16, 2009 at 12:43 PM, Andrew Scherkus
scher...@chromium.orgwrote:
So I checked in a change that did some refactoring and added
Right now there's a bunch of unexpected passing media layout tests, but they
should start failing again as soon as the WebKit builder bot is clobbered
(we're temporarily expecting them to fail until we sort out some issues).
Andrew
On Tue, Jul 14, 2009 at 5:50 PM, Drew Wilson
Since Subversion checkouts are hermetic, you can save yourself a ton time if
you manually move your LayoutTest directory to the new location before
running gclient sync.
On Mon, Jul 13, 2009 at 5:05 PM, Peter Kasting pkast...@google.com wrote:
On Mon, Jul 13, 2009 at 1:45 PM, Victor Wang
Before we jump into debugging, where did you get your FFmpeg source code?
The version and building instructions we use are documented here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/ffmpeg/
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/mingw/
Andrew
On Thu, Jul
Quick question because I have no clue where/how watchlists are
implemented...
According to the watchlist file, brettw is watching base from /src. kylep
sent me a code review that only modifies touches files in /src/media/base,
however brettw got added to the cc list.
Is this intended behavior
I have a changelist in the works that should prevent ffmpeg_binaries from
showing up.
Andrew
On Sun, Jul 5, 2009 at 9:50 PM, Bradley Nelson bradnel...@google.comwrote:
In the case of cygwin and lastchange I think know what's going on, and
unfortunately these currently expect to always get
I just checked in a Chromium-specific version of FFmpeg that only includes
Ogg+Theora+Vorbis support.
If you previously had any binaries located in third_party/ffmpeg/binaries,
you may have to clobber that entire directory and force sync:
rm -rf third_party/ffmpeg/binaries
svn co
On Mon, Jul 6, 2009 at 1:54 PM, Evan Martin e...@chromium.org wrote:
third_party/ffmpeg/binaries is an extra 6mb of download for our source
checkout, even on platforms that can't use these binaries. If you
multiply by 3 for Mac/Linux it'll become 18mb.
In the past we've used conditional
Assuming Windows, you'll need to have built FFmpeg as well (our mac/linux
support is a little unstable at the moment).
Chromium will not enable audio and video unless the DLLs are alongside
chrome.exe.
You can find instructions on how to build FFmpeg here:
as
well.
-BradN
On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus
scher...@chromium.org
wrote:
I'll see if I can repro this again before filing a bug, but similar to
what Daniel and John reported, when I right click on test_shell and
say
Build it builds the minimal set required
I'll see if I can repro this again before filing a bug, but similar to what
Daniel and John reported, when I right click on test_shell and say Build it
builds the minimal set required to fully build+link test_shell.exe
However when I set test_shell as the start-up project and launch the
debugger,
My only quick suggestion would be: did you try a clobber build? My
experience with bindings is they never seem to incrementally build or link
very well :(
On Thu, Jun 18, 2009 at 4:05 PM, kylep ky...@chromium.org wrote:
Ok, so. So far I've created a new file
V8HTMLAudioElementConstructor.cpp
overspecified dependencies as well.
-BradN
On Thu, Jun 18, 2009 at 3:49 PM, Andrew Scherkus scher...@chromium.orgwrote:
I'll see if I can repro this again before filing a bug, but similar to
what Daniel and John reported, when I right click on test_shell and say
Build it builds the minimal set
Posting so others can benefit.
Last week I started getting this error and haven't been able to find a way
to get around it:
$ gclient sync
svn: Working copy 'C:\cygwin\home\scherkus\depot_tools' locked
svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details)
svn: Working copy
On Fri, Jun 12, 2009 at 4:50 PM, Eric Seidel esei...@chromium.org wrote:
Can we do something nice like WebKit does and copy the dlls (from the
installed Chrome or wherever) to next to the build test_shell before
running?
Recalling from memory... you should be able to specify a gyp
BufferedDataSource acts as a sliding window and only buffers a portion of
the media file in memory.
Hope that helps,
Andrew
On Fri, Jun 5, 2009 at 3:50 AM, mr mary.ri...@gmail.com wrote:
Does buffered data source cache entire media data, e.g. a 2GB file? or
just part of it?
BR
Mary
Hooray!! Getting closer...
Andrew
On Thu, May 21, 2009 at 1:27 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:
As of r16639, the linux build now requires ALSA to build.
src/build/install-build-deps.sh has been updated with the dependency.
Please run that if the compiler starts
I like best practices or gotcha sections, especially when there are
multiple ways to accomplish the same task.
For example, what's the best way to limit files to each platform? Include
them all then exclude with a regexp, include the common files then include
the platform-specific ones, or what
platform.
-Darin
On Wed, May 6, 2009 at 10:40 AM, Darin Fisher da...@chromium.org wrote:
Please see WebCanvas in the WebKit API. It was designed for this.
-Darin
On Tue, May 5, 2009 at 5:40 PM, Andrew Scherkus
scher...@chromium.orgwrote:
WebKit's MediaPlayerPrivate interface is a bit
On Tue, May 5, 2009 at 9:49 PM, Albert J. Wong (王重傑) ajw...@chromium.orgwrote:
On Tue, May 5, 2009 at 9:38 PM, Amanda Walker ama...@chromium.org wrote:
Ah, I see. Hmm, going in that direction (from a GraphicsContext back
up to the PlatformCanvas that wraps it) is an interesting question
WebKit's MediaPlayerPrivate interface is a bit backwards where they pass in
a GraphicsContext:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/graphics/MediaPlayer.h?view=markup
We currently forward the MediaPlayerPrivate::paint(GraphicsContext* p, const
I once went on a mission to change Value to use UTF-8 strings, and
hilariously enough after doing a few of those changes we ended up with
string16. Maybe I'll go on another crusade to change Value to use
string16...
Anyway, the tricky part is that it's the Dictionary Value type forcing
wstring.
I might have missed this memo, but why are we splitting documentation across
dev.chromium.org and code.google.com?
Andrew
On Wed, Apr 22, 2009 at 11:37 AM, Evan Martin e...@chromium.org wrote:
Since Pinkerton just lost some hours to this and I did again:
The secret to getting LOG(INFO) to
Sweet -- I love developer view!
One question: what does the personalized for... text box do? Whatever I
enter into it seems to throw a server side exception.
Thanks,
Andrew
On Sat, Apr 18, 2009 at 2:33 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:
Hello,
Since almost everyone prefers the
Hi peng! I'm one of the programmers working on that code.
You can see how it's used by looking at the renderer process:
/src/renderer/webmediaplayer_delegate_impl.cc
/src/renderer/media/audio_renderer_impl.cc
/src/renderer/media/data_source_impl.cc
/src/renderer/media/video_renderer_impl.cc
about the native widget set on
Windows to offer ideas on implementation differences.
Does this make sense, or did I miss your point?
jrg
On Mon, Mar 23, 2009 at 2:35 PM, Andrew Scherkus scher...@chromium.orgwrote:
There was a panel at SXSW last week on web form elements and the
joys/pains
I think specifying the reviewer's responsibility in the description/message
is a good start. It might also help when requesting specific feedback about
design details as opposed to checking code style.
Andrew
On Tue, Jan 27, 2009 at 10:13 PM, Amanda Walker ama...@chromium.org wrote:
On Wed,
Great! I'm really interested in using shared FDs.
Just to clarify, we're unsure whether this works for Linux?
Thanks again,
Andrew
On Mon, Jan 26, 2009 at 2:17 PM, Jeremy Moskovich jer...@chromium.orgwrote:
There's been discussion recently about sending FDs between processes so
that renderer
Anyone a Skia expert and know if it supports YUV?
From poking around it looks like SkBitmap assumes planar RGB and
SkColorMatrix has a YUV - RGB matrix but I can't find any examples of how
to use it.
Thanks,
Andrew
--~--~-~--~~~---~--~~
Chromium Developers mailing
Just to confirm, today I checked out two new clients on two fresh machines
(Mac, Windows) and haven't had issues.
Sounds like a gclient issue to me (either the configuration or the script
itself).
On Fri, Dec 19, 2008 at 1:09 PM, Mark Larson (Google) m...@chromium.orgwrote:
On Fri, Dec 19,
Awesome! I love lint!
On Wed, Dec 17, 2008 at 10:36 AM, Mohamed Mansour
m0.interact...@gmail.comwrote:
Would be nice to make a gcl lint feature :)
gcl lint [mychangelist] before we submit it to codereview
On Wed, Dec 17, 2008 at 1:33 PM, Marc-Antoine Ruel mar...@chromium.orgwrote:
Yep,
Looking through some of the code again it gets a bit scary when there's code
checking for TYPE_WSTRING but not the other.
So how about:
CreateStringValue accepts std::string and std::wstring
SetString accepts std::string and std::wstring
GetString can return std::string or std::wstring and uses
I do like how the horizontal versions give you extra typing room and have a
bit of the long horizontal look of the tab bar, omnibox bar and bookmark
bar.
Just my $0.02!
Andrew
On Tue, Dec 9, 2008 at 6:30 PM, Brett Wilson [EMAIL PROTECTED] wrote:
Hi Simon,
Thanks for the thoughtful mocks. I
8, 2008 at 6:41 PM, Andrew Scherkus [EMAIL PROTECTED]
wrote:
Darin touched upon this, who said to document that std::string should
refer to UTF-8 strings.
How about:
- CreateStringValue creates a StringValue object that returns
TYPE_UTF8_STRING and has a DCHECK(IsStringUTF8(foo
On Mon, Dec 8, 2008 at 8:53 PM, Brett Wilson [EMAIL PROTECTED] wrote:
On Mon, Dec 8, 2008 at 8:32 PM, Andrew Scherkus [EMAIL PROTECTED]
wrote:
Somewhat in line with the Google style guide, the overloaded
CreateStringValue/GetString do accomplish the same thing (variant string
type), just
There are some dependency scans you can skip if you're hacking away in a
single file:http://www.scons.org/doc/0.96.96/HTML/scons-user/x933.html
I've found they cut down the start up time significantly, but need to be
used with caution.
On Fri, Nov 14, 2008 at 11:23 AM, Darin Fisher [EMAIL
90 matches
Mail list logo
