lburgazzoli commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1967175001
it is more for knowledge sharing so everyone knows why we merged something
with failing tests and we can check the issue to be solved when moving to the
new architecture
--
This
squakez commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1967143408
> do we have an issue to track the flaky test ?
Probably not. This is happening because some sync problem in github actions
OS when running the --dev and watching files. We've
lburgazzoli commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1967119380
do we have an issue to track the flaky test ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
squakez commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1967098477
Known flaky check failure. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
squakez merged PR #5186:
URL: https://github.com/apache/camel-k/pull/5186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1966609455
:heavy_check_mark: Unit test coverage report - coverage increased from 36%
to 36.2% (**+0.2%**)
--
This is an automated message from the Apache Git Service.
To respond to
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1504275112
##
pkg/apis/camel/v1/knative/types.go:
##
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string`json:"url,omitempty"`
squakez commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1966600297
If tests are green and @lburgazzoli is fine with the development, we can
merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1504270563
##
pkg/trait/trait_types.go:
##
@@ -511,8 +510,9 @@ func (e *Environment) configureVolumesAndMounts(vols
*[]corev1.Volume, mnts *[]c
// Resources (likely
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1504270223
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1504269478
##
pkg/apis/camel/v1/knative/types.go:
##
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string`json:"url,omitempty"`
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503837869
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503827752
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503827620
##
pkg/apis/camel/v1/knative/types.go:
##
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string`json:"url,omitempty"`
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503821804
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503812719
##
pkg/trait/camel.go:
##
@@ -200,10 +207,10 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503811034
##
pkg/trait/trait_types.go:
##
@@ -511,8 +510,9 @@ func (e *Environment) configureVolumesAndMounts(vols
*[]corev1.Volume, mnts *[]c
// Resources (likely
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503809906
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503809358
##
pkg/apis/camel/v1/knative/types.go:
##
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string`json:"url,omitempty"`
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503805698
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503806109
##
pkg/trait/camel.go:
##
@@ -200,10 +207,10 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503803832
##
pkg/trait/trait_types.go:
##
@@ -511,8 +510,9 @@ func (e *Environment) configureVolumesAndMounts(vols
*[]corev1.Volume, mnts *[]c
// Resources (likely
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503803832
##
pkg/trait/trait_types.go:
##
@@ -511,8 +510,9 @@ func (e *Environment) configureVolumesAndMounts(vols
*[]corev1.Volume, mnts *[]c
// Resources (likely
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503800482
##
pkg/util/camel/camel_runtime_catalog.go:
##
@@ -26,6 +26,18 @@ import (
// NewRuntimeCatalog creates a runtime catalog with the given catalog.
func
squakez commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503800278
##
pkg/trait/camel.go:
##
@@ -200,10 +207,10 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503796994
##
pkg/trait/camel.go:
##
@@ -200,10 +207,10 @@ func (t *camelTrait) computeConfigMaps(e *Environment)
[]ctrl.Object {
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503785575
##
pkg/trait/camel.go:
##
@@ -33,6 +33,13 @@ import (
"github.com/apache/camel-k/v2/pkg/util/property"
)
+const (
+ camelSourceLanguageAnnotation
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503792088
##
pkg/apis/camel/v1/knative/types.go:
##
@@ -38,6 +38,7 @@ type CamelServiceDefinition struct {
URL string`json:"url,omitempty"`
lburgazzoli commented on code in PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#discussion_r1503785575
##
pkg/trait/camel.go:
##
@@ -33,6 +33,13 @@ import (
"github.com/apache/camel-k/v2/pkg/util/property"
)
+const (
+ camelSourceLanguageAnnotation
github-actions[bot] commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1965950910
:heavy_check_mark: Unit test coverage report - coverage increased from 36%
to 36.2% (**+0.2%**)
--
This is an automated message from the Apache Git Service.
To respond to
squakez commented on PR #5186:
URL: https://github.com/apache/camel-k/pull/5186#issuecomment-1965936553
Part of https://github.com/apache/camel-k/pull/5090 - @lburgazzoli please,
have a look and confirm if this part is good.
--
This is an automated message from the Apache Git Service.
To
squakez opened a new pull request, #5186:
URL: https://github.com/apache/camel-k/pull/5186
With this PR we move the configuration from the env var to the properties.
**Release Note**
```release-note
chore(knative): configure via properties
```
--
32 matches
Mail list logo
