Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-11 Thread via GitHub
soumyava merged PR #15939: URL: https://github.com/apache/druid/pull/15939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated (313da988794 -> 85ee775390c)

2024-03-11 Thread soumyava
This is an automated email from the ASF dual-hosted git repository. soumyava pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 313da988794 decouple column serializer compression closers from SegmentWriteoutMedium to optionally allow

Re: [PR] Rewrite exotic LAST_VALUE/FIRST_VALUE to self-reference. (druid)

2024-03-11 Thread via GitHub
soumyava commented on code in PR #16063: URL: https://github.com/apache/druid/pull/16063#discussion_r1520252343 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -136,6 +136,24 @@ public void validateWindow(SqlNode windowOrId,

Re: [PR] Rewrite exotic LAST_VALUE/FIRST_VALUE to self-reference. (druid)

2024-03-11 Thread via GitHub
soumyava commented on code in PR #16063: URL: https://github.com/apache/druid/pull/16063#discussion_r1520257677 ## sql/src/main/java/org/apache/druid/sql/calcite/rule/RewriteFirstValueLastValueRule.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation

(druid) branch master updated: Remove `@JsonIgnore` annotations for private members of `TaskAction` classes (#16099)

2024-03-11 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 8084f2206b0 Remove `@JsonIgnore` annotations

Re: [PR] Rewrite exotic LAST_VALUE/FIRST_VALUE to self-reference. (druid)

2024-03-11 Thread via GitHub
soumyava commented on code in PR #16063: URL: https://github.com/apache/druid/pull/16063#discussion_r1520252343 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -136,6 +136,24 @@ public void validateWindow(SqlNode windowOrId,

Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-11 Thread via GitHub
clintropolis commented on code in PR #15939: URL: https://github.com/apache/druid/pull/15939#discussion_r1520376162 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -15336,4 +15336,34 @@ public void testFilterParseLongNullable()

Re: [PR] Geo spatial interfaces (druid)

2024-03-11 Thread via GitHub
github-advanced-security[bot] commented on code in PR #16029: URL: https://github.com/apache/druid/pull/16029#discussion_r1520486780 ## processing/src/test/java/org/apache/druid/collections/spatial/search/RectangularBoundTest.java: ## @@ -31,23 +33,84 @@ public void

Re: [PR] Release notes for 29.0.1 hotfix (druid)

2024-03-11 Thread via GitHub
317brian commented on code in PR #15960: URL: https://github.com/apache/druid/pull/15960#discussion_r1520502744 ## docs/release-info/release-notes.md: ## @@ -24,6 +24,30 @@ title: "Release notes" +## Druid 29.0.1 + +Apache Druid 29.0.1 is a patch release that fixes some

Re: [PR] decouple column serializer compression closers from SegmentWriteOutMedium (druid)

2024-03-11 Thread via GitHub
clintropolis merged PR #16076: URL: https://github.com/apache/druid/pull/16076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: decouple column serializer compression closers from SegmentWriteoutMedium to optionally allow serializers to release direct memory allocated for compression earlier than

2024-03-11 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 313da988794 decouple column serializer

[PR] Update `maxRowsInMemory` and `maxBytesInMemory` description (druid)

2024-03-11 Thread via GitHub
ektravel opened a new pull request, #16104: URL: https://github.com/apache/druid/pull/16104 This PR updates the description for `maxRowsInMemory` and `maxBytesInMemory`. This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To

[PR] Fix `numSegmentsKilled` metric (druid)

2024-03-11 Thread via GitHub
abhishekrb19 opened a new pull request, #16103: URL: https://github.com/apache/druid/pull/16103 Prior to this patch, the KillTaskReport contained the `numSegmentsKilled` metric, representing the size of unused segments nuked from the metadata store, rather than the actual number of

Re: [PR] Remove `@JsonIgnore` annotations for private members of `TaskAction` classes (druid)

2024-03-11 Thread via GitHub
abhishekrb19 merged PR #16099: URL: https://github.com/apache/druid/pull/16099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix flaky tests in multiple modules due to non-deterministic specification of HashSet and JSON objects (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #15418: URL: https://github.com/apache/druid/pull/15418#issuecomment-1989680645 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Make WindowFrames more specific (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #15668: URL: https://github.com/apache/druid/pull/15668#issuecomment-1989680707 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] Add pair Latest/Earliest aggregators (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14195: Add pair Latest/Earliest aggregators URL: https://github.com/apache/druid/pull/14195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add pair Latest/Earliest aggregators (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14195: URL: https://github.com/apache/druid/pull/14195#issuecomment-1989680188 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [I] SQL AND clause with lookup are not well translated to native queries (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed issue #14199: SQL AND clause with lookup are not well translated to native queries URL: https://github.com/apache/druid/issues/14199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add more logging for query timeouts and errors during broker parallel merge (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14204: URL: https://github.com/apache/druid/pull/14204#issuecomment-1989680228 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [I] SQL AND clause with lookup are not well translated to native queries (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on issue #14199: URL: https://github.com/apache/druid/issues/14199#issuecomment-1989680208 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time.

Re: [PR] Add more logging for query timeouts and errors during broker parallel merge (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14204: Add more logging for query timeouts and errors during broker parallel merge URL: https://github.com/apache/druid/pull/14204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Remove `giant` lock from Overlord TaskQueue (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14293: URL: https://github.com/apache/druid/pull/14293#issuecomment-1989680282 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Remove `giant` lock from Overlord TaskQueue (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14293: Remove `giant` lock from Overlord TaskQueue URL: https://github.com/apache/druid/pull/14293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] write factory.json use utf-8 (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14331: URL: https://github.com/apache/druid/pull/14331#issuecomment-1989680308 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] write factory.json use utf-8 (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14331: write factory.json use utf-8 URL: https://github.com/apache/druid/pull/14331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] switch to front-coded v1 bucket size 4 by default (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14351: URL: https://github.com/apache/druid/pull/14351#issuecomment-1989680327 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] switch to front-coded v1 bucket size 4 by default (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14351: switch to front-coded v1 bucket size 4 by default URL: https://github.com/apache/druid/pull/14351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix `numSegmentsKilled` metric (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on PR #16103: URL: https://github.com/apache/druid/pull/16103#issuecomment-1990275073 > LGTM, question: in this case, how does the orphaned segment whose metadata was deleted but data remaings in deep storage get cleaned up from deep storage, does it ever? Or is this

[PR] fix sql results mixed array and scalar values (druid)

2024-03-11 Thread via GitHub
clintropolis opened a new pull request, #16105: URL: https://github.com/apache/druid/pull/16105 ### Description Fixes an issue which can occur when using schema discovery on columns with a mix of array and scalar values and querying with scan queries, where SQL result coercion does not

[PR] switch to front-coded v1 bucket size 4 by default (druid)

2024-03-11 Thread via GitHub
clintropolis opened a new pull request, #14351: URL: https://github.com/apache/druid/pull/14351 ### Description I think we should consider switching the `IndexSpec` default value of `stringDictionaryEncoding` to `{"type":"frontCoded", "bucketSize":4, "formatVersion":1}`. Based on

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1520857627 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -619,6 +639,13 @@ private Query> buildSegmentsTableQuery(

Re: [PR] Initialise boolean array (druid)

2024-03-11 Thread via GitHub
clintropolis commented on code in PR #16093: URL: https://github.com/apache/druid/pull/16093#discussion_r1520645193 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidRexExecutor.java: ## @@ -176,6 +176,17 @@ public void reduce( }

(druid) branch 29.0.1 updated: [Backport] Only use ExprEval in ConstantExpr if its known that it will be safe (#15694) (#16100)

2024-03-11 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 51c8f65f05f [Backport] Only use ExprEval in

Re: [PR] [Backport] Only use ExprEval in ConstantExpr if its known that it will be safe (#15694) (druid)

2024-03-11 Thread via GitHub
cryptoe merged PR #16100: URL: https://github.com/apache/druid/pull/16100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] refactor numeric primitive aggregators in sql compatible mode (druid)

2024-03-11 Thread via GitHub
clintropolis opened a new pull request, #10666: URL: https://github.com/apache/druid/pull/10666 ### Description #10219 added `hasNulls` to `ColumnCapabilities`, allowing things to know if a column has any null values in SQL compatible mode

Re: [PR] Web console: upgrade axios and follow-redirects (druid)

2024-03-11 Thread via GitHub
vogievetsky merged PR #16087: URL: https://github.com/apache/druid/pull/16087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
zachjsh commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1520798465 ## server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java: ## @@ -619,6 +639,13 @@ private Query> buildSegmentsTableQuery(

Re: [PR] escape smoosh file names, fix bug with empty json paths (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #13079: URL: https://github.com/apache/druid/pull/13079#issuecomment-1989680046 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] add EVAL function to run arbitrary native expressions in SQL (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #13336: URL: https://github.com/apache/druid/pull/13336#issuecomment-1989680080 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] log if segment needs compaction at debug level. (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14152: URL: https://github.com/apache/druid/pull/14152#issuecomment-1989680124 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] log if segment needs compaction at debug level. (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14152: log if segment needs compaction at debug level. URL: https://github.com/apache/druid/pull/14152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Adding EitherException to prevent nested error in Either usage. (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #14171: URL: https://github.com/apache/druid/pull/14171#issuecomment-1989680155 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

Re: [PR] Adding EitherException to prevent nested error in Either usage. (druid)

2024-03-11 Thread via GitHub
github-actions[bot] closed pull request #14171: Adding EitherException to prevent nested error in Either usage. URL: https://github.com/apache/druid/pull/14171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] specialized FixedIndexed implementations for java value types (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #12846: URL: https://github.com/apache/druid/pull/12846#issuecomment-1989679984 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

Re: [PR] add missing information to topn and groupby cache keys (druid)

2024-03-11 Thread via GitHub
github-actions[bot] commented on PR #12855: URL: https://github.com/apache/druid/pull/12855#issuecomment-1989680013 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

(druid) branch master updated: Fix bug where numSegmentsKilled is reported incorrectly. Also, add a unit test. (#16103)

2024-03-11 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 0a615f16de3 Fix bug where numSegmentsKilled

Re: [PR] Fix `numSegmentsKilled` metric (druid)

2024-03-11 Thread via GitHub
abhishekrb19 merged PR #16103: URL: https://github.com/apache/druid/pull/16103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update Calcite*Test to use junit5 (druid)

2024-03-11 Thread via GitHub
kgyrtkirk opened a new pull request, #16106: URL: https://github.com/apache/druid/pull/16106 * change the way temp dirs are handled * add openrewrite workflow to safeguard upgrade; possibly make future changes easier * replace junitparamrunner with standard junit5 parametered tests

Re: [PR] Fix `numSegmentsKilled` metric (druid)

2024-03-11 Thread via GitHub
zachjsh commented on PR #16103: URL: https://github.com/apache/druid/pull/16103#issuecomment-1990031747 LGTM, question: in this case, how does the orphaned segment whose metadata was deleted but data remaings in deep storage get cleaned up from deep storage, does it ever? Or is this a

(druid) branch master updated: netty 4.1.107 (#16027)

2024-03-11 Thread asdf2014
This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 148ad32e756 netty 4.1.107 (#16027) 148ad32e756

Re: [PR] netty 4.1.107 (druid)

2024-03-11 Thread via GitHub
asdf2014 merged PR #16027: URL: https://github.com/apache/druid/pull/16027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
kfaraz commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519243525 ## indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java: ## @@ -40,6 +40,9 @@ public class

Re: [PR] Fixup KillUnusedSegmentsTest (druid)

2024-03-11 Thread via GitHub
kfaraz merged PR #16094: URL: https://github.com/apache/druid/pull/16094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Fixup KillUnusedSegmentsTest (#16094)

2024-03-11 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new c7f1872bd1b Fixup KillUnusedSegmentsTest

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519321119 ## server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java: ## @@ -124,6 +127,7 @@ default Collection

(druid) branch master updated: docs refinement: json format (#16080)

2024-03-11 Thread asdf2014
This is an automated email from the ASF dual-hosted git repository. asdf2014 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 2d62b4f09bd docs refinement: json format

Re: [PR] docs refinement: json format (druid)

2024-03-11 Thread via GitHub
asdf2014 merged PR #16080: URL: https://github.com/apache/druid/pull/16080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Calcite tests remove expected exception (druid)

2024-03-11 Thread via GitHub
kgyrtkirk commented on code in PR #16046: URL: https://github.com/apache/druid/pull/16046#discussion_r1519268656 ## sql/src/test/java/org/apache/druid/sql/calcite/BaseCalciteQueryTest.java: ## @@ -295,15 +298,11 @@ public static Map getTimeseriesContextWithFloorTime( public

(druid) branch master updated: Calcite tests remove expected exception (#16046)

2024-03-11 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 2eb7d7a89b8 Calcite tests remove expected

(druid) branch 29.0.1 updated: Remove exception on failure response from GCS delete API (#16047) (#16095)

2024-03-11 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new c43fbf3ed79 Remove exception on failure

Re: [PR] [Backport 29.0.1] Remove exception on failure response from GCS delete API (druid)

2024-03-11 Thread via GitHub
abhishekrb19 merged PR #16095: URL: https://github.com/apache/druid/pull/16095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Calcite tests remove expected exception (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on PR #16046: URL: https://github.com/apache/druid/pull/16046#issuecomment-1987811257 The rule ordering cleanup changes can come in a later patch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Calcite tests remove expected exception (druid)

2024-03-11 Thread via GitHub
abhishekrb19 merged PR #16046: URL: https://github.com/apache/druid/pull/16046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] interpretation of cannotVectorize in tests may stop further processing of the testcase (druid)

2024-03-11 Thread via GitHub
abhishekrb19 closed issue #15423: interpretation of cannotVectorize in tests may stop further processing of the testcase URL: https://github.com/apache/druid/issues/15423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519313320 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java: ## @@ -207,20 +226,17 @@ public TaskStatus

[PR] Fix incorrect header names for certain export queries (druid)

2024-03-11 Thread via GitHub
adarshsanjeev opened a new pull request, #16096: URL: https://github.com/apache/druid/pull/16096 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis

(druid) branch 29.0.1 updated: fix NestedCommonFormatColumnHandler to use nullable comparator when castToType is set (#15921) (#16053)

2024-03-11 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new e59bba1d545 fix NestedCommonFormatColumnHandler

(druid) branch 29.0.1 updated: Bump org.postgresql:postgresql from 42.6.0 to 42.7.2 (#15931) (#16056)

2024-03-11 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 309fed039da Bump org.postgresql:postgresql from

Re: [PR] [Backport] fix bug with expression virtual column indexes on missing columns for expressions that turn null values into not null values (druid)

2024-03-11 Thread via GitHub
cryptoe merged PR #16055: URL: https://github.com/apache/druid/pull/16055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Backport] fix NestedCommonFormatColumnHandler to use nullable comparator when castToType is set (druid)

2024-03-11 Thread via GitHub
cryptoe merged PR #16053: URL: https://github.com/apache/druid/pull/16053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Backport] Bump org.postgresql:postgresql from 42.6.0 to 42.7.2 (druid)

2024-03-11 Thread via GitHub
cryptoe merged PR #16056: URL: https://github.com/apache/druid/pull/16056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fetch active tasks from memory in SeekableStreamSupervisor (druid)

2024-03-11 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #16098: URL: https://github.com/apache/druid/pull/16098 - Fetch active tasks using the TaskQueue in Streaming supervisors TODO This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency

Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-11 Thread via GitHub
rohangarg commented on code in PR #15939: URL: https://github.com/apache/druid/pull/15939#discussion_r1519468335 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -15336,4 +15336,34 @@ public void testFilterParseLongNullable()

[PR] Correct the API used to fetch the version for a GCS object (druid)

2024-03-11 Thread via GitHub
gargvishesh opened a new pull request, #16097: URL: https://github.com/apache/druid/pull/16097 Current API used to fetch the version for a GCS object is incorrect. This PR fixes that API. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
kfaraz commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519397596 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java: ## @@ -207,20 +226,17 @@ public TaskStatus runTask(TaskToolbox

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519431702 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java: ## @@ -207,20 +226,17 @@ public TaskStatus

Re: [PR] Fetch active tasks from memory in SeekableStreamSupervisor (druid)

2024-03-11 Thread via GitHub
abhishekagarwal87 commented on PR #16098: URL: https://github.com/apache/druid/pull/16098#issuecomment-1988114751 What problems does this PR address? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(druid) branch 29.0.1 updated: fix bug with expression virtual column indexes on missing columns for expressions that turn null values into not null values (#15959) (#16055)

2024-03-11 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch 29.0.1 in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/29.0.1 by this push: new 8195634e9af fix bug with expression virtual

Re: [PR] Fetch active tasks from memory in SeekableStreamSupervisor (druid)

2024-03-11 Thread via GitHub
AmatyaAvadhanula commented on PR #16098: URL: https://github.com/apache/druid/pull/16098#issuecomment-1988193388 The SeekableStreamSupervisor fetches the task payloads for every active task in its datasource twice every RunNotice. In large clusters, this may cause the RunNotice to take a

(druid) branch master updated: Correct the API used to fetch the version for a GCS object (#16097)

2024-03-11 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 2dd8b16467e Correct the API used to fetch the

[PR] Remove `@JsonIgnore` annotations for private members of `TaskAction` classes (druid)

2024-03-11 Thread via GitHub
abhishekrb19 opened a new pull request, #16099: URL: https://github.com/apache/druid/pull/16099 Remove `@JsonIgnore` annotations from the private members of the various `TaskAction` classes. This is likely just a remnant of a legacy pattern, as the fields are intended to be serialized, as

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519568883 ## indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java: ## @@ -40,6 +40,9 @@ public class

Re: [I] Auto-kill doesn't delete segments outside the range [0000-01-01/10000-01-01) (druid)

2024-03-11 Thread via GitHub
abhishekrb19 closed issue #15951: Auto-kill doesn't delete segments outside the range [-01-01/1-01-01) URL: https://github.com/apache/druid/issues/15951 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Auto-kill doesn't delete segments outside the range [0000-01-01/10000-01-01) (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on issue #15951: URL: https://github.com/apache/druid/issues/15951#issuecomment-1988279908 Closing this as it's a non-issue. Please see https://github.com/apache/druid/pull/16094 for more information. -- This is an automated message from the Apache Git Service. To

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
kfaraz commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519609784 ## indexing-service/src/test/java/org/apache/druid/indexing/common/actions/RetrieveSegmentsActionsTest.java: ## @@ -98,31 +102,37 @@ public void

Re: [I] Druid: KILL Task doesn't cleanup the datasource from deep storage and UI shows after the KILL operation also (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on issue #16030: URL: https://github.com/apache/druid/issues/16030#issuecomment-1988308932 @micomahesh1982, you can enable auto-kill, please see these docs - https://druid.apache.org/docs/latest/operations/clean-metadata-store/#configure-automated-metadata-cleanup

[PR] [Backport] Only use ExprEval in ConstantExpr if its known that it will be safe (#15694) (druid)

2024-03-11 Thread via GitHub
cryptoe opened a new pull request, #16100: URL: https://github.com/apache/druid/pull/16100 Only use ExprEval in ConstantExpr if its known that it will be safe (#15694) * which creates a singleThreaded version of the actual expression (caching ExprEval is allowed) * to make a

Re: [PR] Remove `@JsonIgnore` annotations for private members of `TaskAction` classes (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on PR #16099: URL: https://github.com/apache/druid/pull/16099#issuecomment-1988331679 > Just to be on the safe side, could you please try running Druid and some ingestion to make sure that the serde of these task actions is working as expected. @kfaraz, yes,

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519568883 ## indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java: ## @@ -40,6 +40,9 @@ public class

Re: [PR] Release notes for 29.0.1 hotfix (druid)

2024-03-11 Thread via GitHub
cryptoe commented on code in PR #15960: URL: https://github.com/apache/druid/pull/15960#discussion_r1519579002 ## docs/release-info/release-notes.md: ## @@ -24,6 +24,26 @@ title: "Release notes" +## Druid 29.0.1 + +Apache Druid 29.0.1 is a patch release that fixes some

Re: [PR] Kill segments by versions (druid)

2024-03-11 Thread via GitHub
abhishekrb19 commented on code in PR #15994: URL: https://github.com/apache/druid/pull/15994#discussion_r1519642996 ## indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUnusedSegmentsAction.java: ## @@ -40,6 +40,9 @@ public class

Re: [PR] Correct the API used to fetch the version for a GCS object (druid)

2024-03-11 Thread via GitHub
abhishekagarwal87 merged PR #16097: URL: https://github.com/apache/druid/pull/16097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add deep storage segment metric (druid)

2024-03-11 Thread via GitHub
georgew5656 merged PR #16072: URL: https://github.com/apache/druid/pull/16072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Add deep storage segment metric (#16072)

2024-03-11 Thread georgew5656
This is an automated email from the ASF dual-hosted git repository. georgew5656 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 94d2a28465c Add deep storage segment metric

[PR] [Backport-29.0.1] Correct the API used to fetch the version for a GCS object (druid)

2024-03-11 Thread via GitHub
gargvishesh opened a new pull request, #16101: URL: https://github.com/apache/druid/pull/16101 PR: https://github.com/apache/druid/pull/16097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(druid) branch dependabot/maven/org.apache.commons-commons-compress-1.26.0 deleted (was 27b7127d6c0)

2024-03-11 Thread xvrl
This is an automated email from the ASF dual-hosted git repository. xvrl pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.26.0 in repository https://gitbox.apache.org/repos/asf/druid.git was 27b7127d6c0 Update License The revisions that were on this branch

Re: [PR] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.0 (druid)

2024-03-11 Thread via GitHub
dependabot[bot] commented on PR #15932: URL: https://github.com/apache/druid/pull/15932#issuecomment-1988804070 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] Handling latest_by and earliest_by on numeric columns correctly (druid)

2024-03-11 Thread via GitHub
somu-imply commented on code in PR #15939: URL: https://github.com/apache/druid/pull/15939#discussion_r1519989478 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -15336,4 +15336,34 @@ public void testFilterParseLongNullable()

Re: [PR] Fix toString for SingleThreadSpecializable ConstantExprs (druid)

2024-03-11 Thread via GitHub
kgyrtkirk commented on code in PR #16084: URL: https://github.com/apache/druid/pull/16084#discussion_r1519996775 ## processing/src/main/java/org/apache/druid/math/expr/ConstantExpr.java: ## @@ -145,6 +152,18 @@ protected ExprEval realEval() return eval; } +

  1   2   >