[GitHub] [incubator-hudi] bhasudha commented on issue #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bhasudha commented on issue #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-552075607 Thanks @nsivabalan. LGTM overall. Can approve after the above comments are addressed. --

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bvaradar commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344432963 ## File path: docker/demo/presto-batch1.commands ## @@ -0,0 +1,6 @@ +select symbol, max(

[GitHub] [incubator-hudi] bvaradar commented on issue #1003: [HUDI-218] Adding Presto support to Integration Test

bvaradar commented on issue #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#issuecomment-552074659 thought I was adding myself and ended up adding @vinothchandar :) Will review this -

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344432746 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bhasudha commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344432040 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430980 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -366,10

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344431161 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -366,10

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344431116 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -1110,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430720 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -159,7

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430790 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430927 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344430730 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344431046 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@ -325,6

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bvaradar commented on a change in pull request #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#discussion_r344431628 ## File path: hudi-client/src/test/java/org/apache/hudi/TestHoodieClientOnCopyOnWriteStorage.java ##

[GitHub] [incubator-hudi] bhasudha commented on issue #1002: [chinese][docs] sync updates in quickstart page

bhasudha commented on issue #1002: [chinese][docs] sync updates in quickstart page URL: https://github.com/apache/incubator-hudi/pull/1002#issuecomment-552071668 Thanks @leesf This is an automated message from the Apache Git

[jira] [Comment Edited] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970732#comment-16970732 ] sivabalan narayanan edited comment on HUDI-15 at 11/9/19 6:12 AM:

[jira] [Comment Edited] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970732#comment-16970732 ] sivabalan narayanan edited comment on HUDI-15 at 11/9/19 6:11 AM:

[jira] [Commented] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970732#comment-16970732 ] sivabalan narayanan commented on HUDI-15: - I have a question on usability stand poin

[GitHub] [incubator-hudi] bvaradar commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types

bvaradar commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005#issuecomment-552069612 @n3nash : Can you and Modi review this PR

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #93

See Changes: -- [...truncated 2.19 KB...] m2.conf mvn mvn.cmd mvnDebug mvnDebug.cmd mvnyjp /home/jenkins/tools/maven/apache-maven-3.5.4/boot: plexus-classworlds-2.5.2.jar /

[GitHub] [incubator-hudi] bhasudha commented on issue #1004: [HUDI-15] Adding delete api to HoodieWriteClient

bhasudha commented on issue #1004: [HUDI-15] Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004#issuecomment-552051881 Will take a look at this later tonight! This is an automated m

[GitHub] [incubator-hudi] umehrot2 closed pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types

umehrot2 closed pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005 -

[GitHub] [incubator-hudi] umehrot2 opened a new pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date typ

umehrot2 opened a new pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005 Sending this PR out early to get feedback. Have not yet l

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344420778 ## File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestBase.java ## @@

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344420590 ## File path: docker/demo/presto-batch2-after-compaction.commands ## @@ -0,0 +1,4 @@ +se

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344421039 ## File path: docker/demo/presto-batch1.commands ## @@ -0,0 +1,6 @@ +select symbol, max(

[GitHub] [incubator-hudi] umehrot2 commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types

umehrot2 commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005#issuecomment-552051388 > Sending this PR out early to get feedba

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344420562 ## File path: docker/demo/presto-batch1.commands ## @@ -0,0 +1,6 @@ +select symbol, max(

[GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test

bhasudha commented on a change in pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003#discussion_r344420572 ## File path: docker/demo/presto-batch1.commands ## @@ -0,0 +1,6 @@ +select symbol, max(

[GitHub] [incubator-hudi] umehrot2 opened a new pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date typ

umehrot2 opened a new pull request #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005 ---

[jira] [Updated] (HUDI-91) Replace Databricks spark-avro with native spark-avro #628

[ https://issues.apache.org/jira/browse/HUDI-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-91: --- Labels: pull-request-available (was: ) > Replace Databricks spark-avro with native spark-avro #628 > --

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #626: Adding documentation for hudi test suite

n3nash commented on a change in pull request #626: Adding documentation for hudi test suite URL: https://github.com/apache/incubator-hudi/pull/626#discussion_r344415528 ## File path: docs/test_suite.md ## @@ -0,0 +1,155 @@ +--- +title: Test Suite +keywords: test suite +sid

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #626: Adding documentation for hudi test suite

n3nash commented on a change in pull request #626: Adding documentation for hudi test suite URL: https://github.com/apache/incubator-hudi/pull/626#discussion_r344415492 ## File path: docs/docker_demo.md ## @@ -1081,6 +1081,34 @@ presto:default> This brings the demo to a

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #996: Fixes to ensure MOR incr pull provides consistent results

n3nash commented on a change in pull request #996: Fixes to ensure MOR incr pull provides consistent results URL: https://github.com/apache/incubator-hudi/pull/996#discussion_r344365431 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeli

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #996: Fixes to ensure MOR incr pull provides consistent results

n3nash commented on a change in pull request #996: Fixes to ensure MOR incr pull provides consistent results URL: https://github.com/apache/incubator-hudi/pull/996#discussion_r344364466 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeli

[GitHub] [incubator-hudi] n3nash commented on issue #994: [HUDI-151] Enable HiveOnSpark queries for RT tables

n3nash commented on issue #994: [HUDI-151] Enable HiveOnSpark queries for RT tables URL: https://github.com/apache/incubator-hudi/pull/994#issuecomment-551985984 @vinothchandar @bvaradar Addressed your comments and made some more changes, please take another pass before we can land this.

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344361011 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/DFSDeltaWriterAdapter.java ## @@ -0,0 +1,66 @@ +/* + *

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360985 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/DagNode.java ## @@ -0,0 +1,125 @@ +/* + * Lice

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344361003 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/writer/AvroDeltaInputWriter.java ## @@ -0,0 +1,119 @@ +/

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360967 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/configuration/DeltaConfig.java ## @@ -0,0 +1,273 @@ +/*

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360974 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/helpers/HiveServerWrapper.java ## @@ -0,0 +1,67 @@ +/* +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360935 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/reader/SparkBasedReader.java ## @@ -0,0 +1,68 @@ +/* + *

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360949 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/job/HudiTestSuiteJob.java ## @@ -0,0 +1,183 @@ +/* + * L

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360960 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/helpers/HiveServerWrapper.java ## @@ -0,0 +1,67 @@ +/* +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360901 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/helpers/HiveServerWrapper.java ## @@ -0,0 +1,67 @@ +/* +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360912 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/WorkflowDagGenerator.java ## @@ -0,0 +1,70 @@ +/* +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360927 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/reader/DFSParquetDeltaInputReader.java ## @@ -0,0 +1,92

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360671 ## File path: docker/hoodie/hadoop/hive_base/Dockerfile ## @@ -56,6 +56,7 @@ ENV HUDI_HADOOP_BUNDLE=/var/hoodie/ws/do

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360688 ## File path: docker/demo/config/bench/complex-workflow-dag-cow.yaml ## @@ -0,0 +1,71 @@ +first_insert: + config: +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360623 ## File path: docker/demo/config/bench/complex-workflow-dag-mor.yaml ## @@ -0,0 +1,104 @@ +first_insert: Review com

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360883 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/helpers/DFSTestSuitePathSelector.java ## @@ -0,0 +1,92 @

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360649 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java ## @@ -79

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360659 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/HiveSyncNode.java ## @@ -0,0 +1,46 @@ +/* + *

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360666 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/WorkflowDagGenerator.java ## @@ -0,0 +1,70 @@ +/* +

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360865 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/DeltaSinkType.java ## @@ -0,0 +1,26 @@ +/* + * Licensed t

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor)

n3nash commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344360830 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/DagUtils.java ## @@ -0,0 +1,247 @@ +/* + * Licensed t

[jira] [Commented] (HUDI-114) Allow for clients to overwrite the payload implementation in hoodie.properties

[ https://issues.apache.org/jira/browse/HUDI-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970427#comment-16970427 ] Nishith Agarwal commented on HUDI-114: -- [~Pratyaksh] The payload class could be a cust

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #995: [HUDI-253]: added validations for schema provider class

pratyakshsharma commented on a change in pull request #995: [HUDI-253]: added validations for schema provider class URL: https://github.com/apache/incubator-hudi/pull/995#discussion_r344251459 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/InputBatch.j

[jira] [Commented] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970359#comment-16970359 ] sivabalan narayanan commented on HUDI-15: - Schema: yes. you are right.  btw, I have

[jira] [Comment Edited] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970359#comment-16970359 ] sivabalan narayanan edited comment on HUDI-15 at 11/8/19 4:13 PM:

[GitHub] [incubator-hudi] nsivabalan opened a new pull request #1004: Adding delete api to HoodieWriteClient

nsivabalan opened a new pull request #1004: Adding delete api to HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/1004 Adding a delete api to HoodieWriteClient that takes in a bunch of HoodieKeys to be delete from Hoodie. --

[jira] [Assigned] (HUDI-117) Write Unit-Test Case to test recovery lease handling in HoodieLogFormatWriter

[ https://issues.apache.org/jira/browse/HUDI-117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Balaji Varadarajan reassigned HUDI-117: --- Assignee: Pratyaksh Sharma > Write Unit-Test Case to test recovery lease handling in H

[jira] [Commented] (HUDI-117) Write Unit-Test Case to test recovery lease handling in HoodieLogFormatWriter

[ https://issues.apache.org/jira/browse/HUDI-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970336#comment-16970336 ] Balaji Varadarajan commented on HUDI-117: - Awesome. Assigned to you > Write Unit-T

[jira] [Commented] (HUDI-117) Write Unit-Test Case to test recovery lease handling in HoodieLogFormatWriter

[ https://issues.apache.org/jira/browse/HUDI-117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970312#comment-16970312 ] Pratyaksh Sharma commented on HUDI-117: --- Hi [~vbalaji], I would like to take it up. P

[jira] [Commented] (HUDI-118) Provide CLI Option for passing properties to Compactor, Cleaner and ParquetImporter

[ https://issues.apache.org/jira/browse/HUDI-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970310#comment-16970310 ] Pratyaksh Sharma commented on HUDI-118: --- Hi [~yanghua], are you working on this? Can

[jira] [Updated] (HUDI-218) Add Presto demo commands to hoodie-integ-test/ITTHoodieDemo

[ https://issues.apache.org/jira/browse/HUDI-218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-218: Labels: pull-request-available (was: ) > Add Presto demo commands to hoodie-integ-test/ITTHoodieDemo

[GitHub] [incubator-hudi] nsivabalan opened a new pull request #1003: [HUDI-218] Adding Presto support to Integration Test

nsivabalan opened a new pull request #1003: [HUDI-218] Adding Presto support to Integration Test URL: https://github.com/apache/incubator-hudi/pull/1003 Adding presto commands to integration test suite This is an automated me

[GitHub] [incubator-hudi] leesf opened a new pull request #1002: [chinese][docs] sync updates in quickstart page

leesf opened a new pull request #1002: [chinese][docs] sync updates in quickstart page URL: https://github.com/apache/incubator-hudi/pull/1002 It is a follow up PR to sync updates of PR(https://github.com/apache/incubator-hudi/pull/986) @yihua PTAL. Thanks.

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r343908648 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/WorkflowDagGenerator.java ## @@ -0,0 +1,70 @@ +/*

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r343898667 ## File path: docker/hoodie/hadoop/hive_base/Dockerfile ## @@ -56,6 +56,7 @@ ENV HUDI_HADOOP_BUNDLE=/var/hoodie/ws/

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344032810 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java ## @@ -

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344047546 ## File path: docker/demo/config/bench/complex-workflow-dag-mor.yaml ## @@ -0,0 +1,104 @@ +first_insert: Review c

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r343870238 ## File path: docker/demo/config/bench/complex-workflow-dag-cow.yaml ## @@ -0,0 +1,71 @@ +first_insert: + config: +

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344032847 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/keygen/TimestampBasedKeyGenerator.java ## @@ -

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r343909095 ## File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/HiveSyncNode.java ## @@ -0,0 +1,46 @@ +/* +

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor)

bvaradar commented on a change in pull request #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r344033213 ## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/AvroDFSSource.java ## @@ -40,9 +42,11

[jira] [Commented] (HUDI-114) Allow for clients to overwrite the payload implementation in hoodie.properties

[ https://issues.apache.org/jira/browse/HUDI-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969936#comment-16969936 ] Pratyaksh Sharma commented on HUDI-114: --- Hi [~nishith29], Here is how I plan to do it