[GitHub] [incubator-tvm] corehalt edited a comment on issue #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite

corehalt edited a comment on issue #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919#issuecomment-591286696 > I have a feeling you may be able to get around this problem by using bind_params_by_name. I have

[GitHub] [incubator-tvm] corehalt commented on issue #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite

corehalt commented on issue #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919#issuecomment-591286696 > I have a feeling you may be able to get around this problem by using bind_params_by_name. I have to do

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime

liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime URL: https://github.com/apache/incubator-tvm/pull/3934#discussion_r384315312 ## File path: src/runtime/crt/graph_runtime.h ## @@ -0,0 +1,517 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime

liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime URL: https://github.com/apache/incubator-tvm/pull/3934#discussion_r384315210 ## File path: src/runtime/crt/graph_runtime.c ## @@ -0,0 +1,375 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime

liangfu commented on a change in pull request #3934: [Runtime] MISRA-C compliant TVM runtime URL: https://github.com/apache/incubator-tvm/pull/3934#discussion_r384315132 ## File path: src/runtime/crt/c_backend_api.c ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-tvm] vv1133 opened a new pull request #4945: [RELAY] fix error message

vv1133 opened a new pull request #4945: [RELAY] fix error message URL: https://github.com/apache/incubator-tvm/pull/4945 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] alexwong commented on issue #4944: [Relay, Torch] Clean up and refactor PyTorch frontend

alexwong commented on issue #4944: [Relay, Torch] Clean up and refactor PyTorch frontend URL: https://github.com/apache/incubator-tvm/pull/4944#issuecomment-591253337 Thanks for doing this and looking forward to seeing the coming, additional PyTorch support :)

[GitHub] [incubator-tvm] masahi commented on issue #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on issue #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#issuecomment-591250270 Thanks @alexwong @zhiics @comaniac @kevinthesun @yzhliu This is an

[incubator-tvm] branch master updated (b1428bc -> 61bea50)

This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b1428bc Bump up dev version (#4941) add 61bea50 [Tutorial] Add a tutorial for PyTorch (#4936) No new

[GitHub] [incubator-tvm] masahi merged pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi merged pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen merged pull request #4941: Bump up dev version

tqchen merged pull request #4941: Bump up dev version URL: https://github.com/apache/incubator-tvm/pull/4941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-tvm] branch master updated (b598c54 -> b1428bc)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b598c54 [DOCS] Fix Sphinx Warning: the target found for cross-reference (#4925) add b1428bc Bump up

[GitHub] [incubator-tvm] masahi opened a new pull request #4944: [Relay, Torch] Clean up and refactor PyTorch frontend

masahi opened a new pull request #4944: [Relay, Torch] Clean up and refactor PyTorch frontend URL: https://github.com/apache/incubator-tvm/pull/4944 cc @alexwong it seems mobilenet v2 bug has been fixed after the op strategy PR was merged. TODO - [ ] Write description - [ ]

[GitHub] [incubator-tvm] FrozenGene commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod

FrozenGene commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-591239652 > @kumasento @FrozenGene can you followup on this PR? Sure. I am waiting @kumasento 's new

[GitHub] [incubator-tvm] tqchen commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod

tqchen commented on issue #4847: Return empty CSourceModule when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-591235513 @kumasento @FrozenGene can you followup on this PR?

[GitHub] [incubator-tvm] tqchen commented on issue #4940: Build issues

tqchen commented on issue #4940: Build issues URL: https://github.com/apache/incubator-tvm/issues/4940#issuecomment-591234159 Please open a new trouble shooting thread on https://discuss.tvm.ai/ This is an automated message

[GitHub] [incubator-tvm] tqchen closed issue #4940: Build issues

tqchen closed issue #4940: Build issues URL: https://github.com/apache/incubator-tvm/issues/4940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-tvm] tqchen opened a new pull request #4943: [REFACTOR][PY][API-CHANGE] Remove legacy python files.

tqchen opened a new pull request #4943: [REFACTOR][PY][API-CHANGE] Remove legacy python files. URL: https://github.com/apache/incubator-tvm/pull/4943 Remove legacy python files. Use the te namespace for most of the tensor expression primitives. - tvm.create_schedule ->

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4651: Tensor Expression Debug Display (TEDD)

tqchen edited a comment on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-591231104 Sorry about the delay. Thanks @yongfeng-nv @Hzfengsy this PR is now merged!

[GitHub] [incubator-tvm] tqchen commented on issue #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference

tqchen commented on issue #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference URL: https://github.com/apache/incubator-tvm/pull/4925#issuecomment-591231586 Thansk @comaniac @cchung100m This is an

[GitHub] [incubator-tvm] tqchen merged pull request #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference

tqchen merged pull request #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference URL: https://github.com/apache/incubator-tvm/pull/4925 This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (b0b1e7d -> b598c54)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b0b1e7d Tensor Expression Debug Display (TEDD) (#4651) add b598c54 [DOCS] Fix Sphinx Warning: the

[GitHub] [incubator-tvm] tqchen commented on issue #4651: Tensor Expression Debug Display (TEDD)

tqchen commented on issue #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651#issuecomment-591231104 Thanks @yongfeng-nv @Hzfengsy this PR is now merged! This is an automated

[incubator-tvm] branch master updated (b422f6a -> b0b1e7d)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from b422f6a [WIP] Fixing an Infinite Loop case in UnmatchedChecker. (#4881) add b0b1e7d Tensor Expression

[GitHub] [incubator-tvm] tqchen merged pull request #4651: Tensor Expression Debug Display (TEDD)

tqchen merged pull request #4651: Tensor Expression Debug Display (TEDD) URL: https://github.com/apache/incubator-tvm/pull/4651 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4648: [RFC] Unify IR Node and Reference Class Naming Convention

tqchen edited a comment on issue #4648: [RFC] Unify IR Node and Reference Class Naming Convention URL: https://github.com/apache/incubator-tvm/issues/4648#issuecomment-576818889 NOTE: as of now, we have updated the names in the ir namespace to conform to the standard. We still need

[GitHub] [incubator-tvm] tqchen commented on issue #4648: [RFC] Unify IR Node and Reference Class Naming Convention

tqchen commented on issue #4648: [RFC] Unify IR Node and Reference Class Naming Convention URL: https://github.com/apache/incubator-tvm/issues/4648#issuecomment-591197271 Update, the TIR namespace is already updated. but we have yet updated all nodes in the relay namespace

[GitHub] [incubator-tvm] comaniac opened a new pull request #4942: Move Ops in relay.op.contrib.*

comaniac opened a new pull request #4942: Move Ops in relay.op.contrib.* URL: https://github.com/apache/incubator-tvm/pull/4942 According to the discussion in https://github.com/apache/incubator-tvm/pull/4933, we should move the level 10 ops out of `relay.op.contrib`. This PR

[incubator-tvm] branch master updated (545f6ea -> b422f6a)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 545f6ea [Fix] remove unnecessary spliting in the cached chunk (#4935) add b422f6a [WIP] Fixing an

[GitHub] [incubator-tvm] jroesch merged pull request #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker.

jroesch merged pull request #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker. URL: https://github.com/apache/incubator-tvm/pull/4881 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] jroesch commented on issue #4845: [DEV] TVM v0.7 Roadmap

jroesch commented on issue #4845: [DEV] TVM v0.7 Roadmap URL: https://github.com/apache/incubator-tvm/issues/4845#issuecomment-591189423 > I am currently working on some end-to-end model stuff, and Relay's optimization pass are too slow. Any plans on improving the compilation speed?

[GitHub] [incubator-tvm] jroesch commented on issue #4933: [Relay] Target annotation for external codegen

jroesch commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591188629 After reading the RFC and implementation I'm not sure if per operator is the right way to do validation for the HW platform. I'll

[GitHub] [incubator-tvm] cchung100m commented on issue #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference

cchung100m commented on issue #4925: [DOCS] Fix Sphinx Warning: the target found for cross-reference URL: https://github.com/apache/incubator-tvm/pull/4925#issuecomment-591186879 @tqchen @comaniac Thanks for the review and feedback. :)

[GitHub] [incubator-tvm] icemelon9 commented on issue #4941: Bump up dev version

icemelon9 commented on issue #4941: Bump up dev version URL: https://github.com/apache/incubator-tvm/pull/4941#issuecomment-591171149 @comaniac Thanks for the reminder. Updated now. This is an automated message from the

[GitHub] [incubator-tvm] soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591170273 @comaniac @zhiics that's a great idea. I'll keep these fixes locally for now. Thanks a lot for

[GitHub] [incubator-tvm] soiferj closed pull request #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

soiferj closed pull request #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939 This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591169900 @comaniac This sounds like a good proposal and it will not block @soiferj @soiferj thoughts?

[GitHub] [incubator-tvm] zhiics commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh

zhiics commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-591168801 Adding it to `required_pass` sounds good to me as well since users definitely need to know what they do exactly in this

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384210241 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384209950 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384209523 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591159545 IMHO, since both @soiferj and @zhiics made great points from different perspective, I have another

[GitHub] [incubator-tvm] huajsj commented on issue #4887: [VTA] YoloV3 Support

huajsj commented on issue #4887: [VTA] YoloV3 Support URL: https://github.com/apache/incubator-tvm/pull/4887#issuecomment-591159785 > Would you please also rename the files as requested above, see [#4887 (comment)](https://github.com/apache/incubator-tvm/pull/4887#issuecomment-588119735)

[GitHub] [incubator-tvm] liangfu commented on issue #4887: [VTA] YoloV3 Support

liangfu commented on issue #4887: [VTA] YoloV3 Support URL: https://github.com/apache/incubator-tvm/pull/4887#issuecomment-591156060 Would you please also rename the files as requested above, see https://github.com/apache/incubator-tvm/pull/4887#issuecomment-588119735

[GitHub] [incubator-tvm] zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591146998 @comaniac @tqchen @mbaret What do you think?

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384197125 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384196893 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384196294 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384195258 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384194277 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384193796 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay

zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384192593 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] zhiics commented on issue #4922: [Relay][pass] call graph for relay

zhiics commented on issue #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#issuecomment-591135041 @anijain2305 Thanks for reviewing. Call graph is usually used for inter-procedural level analysis. For example, you might have multiple

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4885: Split node min range is not stringent.

yongfeng-nv commented on issue #4885: Split node min range is not stringent. URL: https://github.com/apache/incubator-tvm/pull/4885#issuecomment-591133137 @Hzfengsy, I am going to close this PR without merging it, because it revealed more failures after our discussion. Those failures

[GitHub] [incubator-tvm] yongfeng-nv closed pull request #4885: Split node min range is not stringent.

yongfeng-nv closed pull request #4885: Split node min range is not stringent. URL: https://github.com/apache/incubator-tvm/pull/4885 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

masahi commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384188051 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay

zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384188206 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384180991 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384181103 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384183704 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384182155 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384180369 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384180446 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay

anijain2305 commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384183756 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #4941: Bump up dev version

icemelon9 opened a new pull request #4941: Bump up dev version URL: https://github.com/apache/incubator-tvm/pull/4941 Not for release purpose. This is only for convenience purposes to differentiate TVM with and w/o op strategy. cc @tqchen @comaniac

[GitHub] [incubator-tvm] yongfeng-nv commented on issue #4931: Tighten split's extent

yongfeng-nv commented on issue #4931: Tighten split's extent URL: https://github.com/apache/incubator-tvm/pull/4931#issuecomment-591127743 @merrymercy, I have updated this PR description and refactor the code. All tests are clear. Please review it. Thank you.

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384167453 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,171 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] zhiics commented on issue #4933: [Relay] Target annotation for external codegen

zhiics commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591105578 @mbaret Thanks for all discussions. I think this is actually a separate issue to this PR. We probably want to have an RFC for it. We

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

yzhliu commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384162338 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,171 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay

zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384160228 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay

zhiics commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384160228 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] yzhliu commented on a change in pull request #4922: [Relay][pass] call graph for relay

yzhliu commented on a change in pull request #4922: [Relay][pass] call graph for relay URL: https://github.com/apache/incubator-tvm/pull/4922#discussion_r384153634 ## File path: src/relay/pass/call_graph.cc ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-tvm] mbaret commented on issue #4933: [Relay] Target annotation for external codegen

mbaret commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591083262 The motivation behind merge composite was to make it so that this annotation mechanism could handle the case where there's a

[GitHub] [incubator-tvm] kamathhrishi commented on issue #4940: Build issues

kamathhrishi commented on issue #4940: Build issues URL: https://github.com/apache/incubator-tvm/issues/4940#issuecomment-591081176 Further ```[ 87%] Building CXX object CMakeFiles/tvm.dir/src/runtime/rpc/rpc_device_api.cc.o [ 87%] Building CXX object

[GitHub] [incubator-tvm] kamathhrishi opened a new issue #4940: Build issues

kamathhrishi opened a new issue #4940: Build issues URL: https://github.com/apache/incubator-tvm/issues/4940 I tried to install TVM with SGX support. When building using CMake the versions seem fine. This was on Ubuntu 18.04. ```(tf2) hrishikesh~/tvm/build$ cmake .. --

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4933: [Relay] Target annotation for external codegen

comaniac commented on a change in pull request #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#discussion_r384136754 ## File path: python/tvm/relay/op/contrib/__init__.py ## @@ -15,7 +15,8 @@ # specific

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #4933: [Relay] Target annotation for external codegen

icemelon9 commented on a change in pull request #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#discussion_r384133372 ## File path: python/tvm/relay/op/contrib/__init__.py ## @@ -15,7 +15,8 @@ # specific

[GitHub] [incubator-tvm] comaniac commented on issue #4933: [Relay] Target annotation for external codegen

comaniac commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591073220 IMHO, if you want to define a pattern by yourself, you should be clear about what can be supported and specify it in the pattern.

[GitHub] [incubator-tvm] yzhliu merged pull request #4935: [Fix] remove unnecessary spliting in the cached chunk

yzhliu merged pull request #4935: [Fix] remove unnecessary spliting in the cached chunk URL: https://github.com/apache/incubator-tvm/pull/4935 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (588523d -> 545f6ea)

This is an automated email from the ASF dual-hosted git repository. liuyizhi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 588523d [LLVM] Fix build breaks from StringRef changes (#4923) add 545f6ea [Fix] remove unnecessary

[GitHub] [incubator-tvm] mbaret commented on issue #4933: [Relay] Target annotation for external codegen

mbaret commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591065765 To give an example, we match qnn.conv_2d -> bias_add -> requantize to a composite convolution (which represents a tflite quantized

[GitHub] [incubator-tvm] soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

soiferj edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591064120 I definitely agree that we'll want that eventually. However, improved pattern matching won't

[GitHub] [incubator-tvm] comaniac commented on issue #4933: [Relay] Target annotation for external codegen

comaniac commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591063851 More specifically, ```python auto op = call->op; if (op.as()) { # Check function attribute "composite" which

[GitHub] [incubator-tvm] soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591064120 I definitely agree that we'll want that eventually. However, improved pattern matching won't change

[GitHub] [incubator-tvm] zhiics commented on issue #4933: [Relay] Target annotation for external codegen

zhiics commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591062207 I probably missed something, but we already have a function because the composite pass has been executed, right?

[GitHub] [incubator-tvm] zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591052375 Yeah, my point is that we probably want to think a bit to make patter matcher a little stronger or have

[GitHub] [incubator-tvm] anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh

anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-591052536 I investigated more. I am also little uncomfortable about adding another Relay build config option. It changes API of

[GitHub] [incubator-tvm] mbaret commented on issue #4933: [Relay] Target annotation for external codegen

mbaret commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591051986 But if we want to register a check that depends on the attrs/args, then we will need to provide a function here.

[GitHub] [incubator-tvm] zhiics commented on issue #4933: [Relay] Target annotation for external codegen

zhiics commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591051281 no need to register if we don't have an op for it. They are annotated already.

[GitHub] [incubator-tvm] mbaret commented on issue #4933: [Relay] Target annotation for external codegen

mbaret commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591047600 Where will we register the composite equivalent of FTVMAnnotateTarget?

[GitHub] [incubator-tvm] soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591040506 Thanks, @zhiics. This fix is not intended to solve the ordering of pattern matching, but rather to

[GitHub] [incubator-tvm] zhiics edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

zhiics edited a comment on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591032603 IMHO, this might seem like a workaround, but I think it doesn't really solve the ordering

[GitHub] [incubator-tvm] zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

zhiics commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591032603 IMHO, this might seem like a workaround, but I think it doesn't really solve the ordering problem of

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #4930: [Frontend] [MXNet] make_loss operator support

maheshambule commented on a change in pull request #4930: [Frontend] [MXNet] make_loss operator support URL: https://github.com/apache/incubator-tvm/pull/4930#discussion_r384082327 ## File path: python/tvm/relay/frontend/mxnet.py ## @@ -646,6 +646,11 @@ def

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker.

zhiics commented on a change in pull request #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker. URL: https://github.com/apache/incubator-tvm/pull/4881#discussion_r384077999 ## File path: tests/python/relay/test_pass_unmatched_cases.py ## @@ -273,3 +274,27 @@

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch

alexwong commented on a change in pull request #4936: [Tutorial] Add a tutorial for PyTorch URL: https://github.com/apache/incubator-tvm/pull/4936#discussion_r384073516 ## File path: tutorials/frontend/from_pytorch.py ## @@ -0,0 +1,166 @@ +# Licensed to the Apache

[GitHub] [incubator-tvm] MarisaKirisame commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker.

MarisaKirisame commented on issue #4881: [WIP] Fixing an Infinite Loop case in UnmatchedChecker. URL: https://github.com/apache/incubator-tvm/pull/4881#issuecomment-591021694 @slyubomirsky @zhiics @junrushao1994 can you guys review?

[GitHub] [incubator-tvm] huajsj commented on a change in pull request #4887: [VTA] YoloV3 Support

huajsj commented on a change in pull request #4887: [VTA] YoloV3 Support URL: https://github.com/apache/incubator-tvm/pull/4887#discussion_r384070679 ## File path: vta/tutorials/frontend/deploy_detection_on_vta.py ## @@ -0,0 +1,334 @@ +# Licensed to the Apache Software

[GitHub] [incubator-tvm] comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically

comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591017348 In my opinion, we should try to simplify the task of Relay passes. If we let the merge composite pass

[GitHub] [incubator-tvm] huajsj commented on issue #4887: [VTA] YoloV3 Support

huajsj commented on issue #4887: [VTA] YoloV3 Support URL: https://github.com/apache/incubator-tvm/pull/4887#issuecomment-591017634 Hi @liangfu, nice to know the tutorial worked in your environment, and thanks for the kindly follow up , all review comments get addressed, please check.

  1   2   >