[GitHub] [calcite] wangzzu commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka

wangzzu commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka URL: https://github.com/apache/calcite/pull/1127#issuecomment-493353494 @XuMingmin :+1: This is an automated message from the Apache Git Service. To

[GitHub] [calcite] ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function

ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function URL: https://github.com/apache/calcite/pull/1209#issuecomment-493369354 > The error says `AppVeyor was unable to build non-mergable pull request`. So you should resolve conflicts first. BTW, you commit message is

[GitHub] [calcite] ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function

ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function URL: https://github.com/apache/calcite/pull/1209#issuecomment-493358746 Is conflicts lead `AppVeyor was unable to build `? If I resolved the conflicts, then it’s not good to go to squash commits to one. thanks

[GitHub] [calcite] chunweilei commented on issue #1209: [CALCITE-2601] Add REVERSE function

chunweilei commented on issue #1209: [CALCITE-2601] Add REVERSE function URL: https://github.com/apache/calcite/pull/1209#issuecomment-493367664 The error says `AppVeyor was unable to build non-mergable pull request`. So you should resolve conflicts first. BTW, you commit message is

[GitHub] [calcite] ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function

ambition119 commented on issue #1209: [CALCITE-2601] Add REVERSE function URL: https://github.com/apache/calcite/pull/1209#issuecomment-493357275 > Please: > > * fix build fail I PR `mvn clean install` build success, now I can observe that I have submitted the failed display,

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285152631 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285155247 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] chunweilei edited a comment on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join

chunweilei edited a comment on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-493450385 Squash commits and update the commit message. This

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285152631 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect

danny0405 commented on a change in pull request #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect URL: https://github.com/apache/calcite/pull/1216#discussion_r285165919 ## File path:

[GitHub] [calcite] chunweilei commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join

chunweilei commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-493450385 Squash commits. This is an automated message from the

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285157917 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285096244 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285096984 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ##

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285105435 ## File path:

[calcite] branch master updated: [CALCITE-2712] Add rule to remove null-generating side of a Join

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 996579a [CALCITE-2712] Add rule to remove

[GitHub] [calcite] chunweilei merged pull request #1160: [CALCITE-2712] Add rule to remove unnecessary outer join

chunweilei merged pull request #1160: [CALCITE-2712] Add rule to remove unnecessary outer join URL: https://github.com/apache/calcite/pull/1160 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285269949 ## File path:

[GitHub] [calcite] zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

zabetak commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285288047 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] amaliujia commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs

amaliujia commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs URL: https://github.com/apache/calcite/pull/1083#issuecomment-493611099 Ping! This is an automated message

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285290481 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285230725 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285290030 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdDistinctRowCount.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285231506 ## File path: core/src/main/java/org/apache/calcite/rel/core/EquiJoin.java ## @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285296030 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285293098 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285230529 ## File path: core/src/main/java/org/apache/calcite/rel/core/RelFactories.java ##

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285291567 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java

[GitHub] [calcite] hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

hsyuan commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285229897 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ## @@

[GitHub] [calcite] asereda-gs commented on a change in pull request #1184: [CALCITE-3027] Support like query in Elasticsearch

asereda-gs commented on a change in pull request #1184: [CALCITE-3027] Support like query in Elasticsearch URL: https://github.com/apache/calcite/pull/1184#discussion_r283065720 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285322095 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285322216 ## File path:

[GitHub] [calcite] danny0405 commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#issuecomment-493635538 > Does Correlate still work after the change? It looks like EnumerableCorrelate is no longer in the plans.

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324373 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324792 ## File path: core/src/main/java/org/apache/calcite/rel/core/EquiJoin.java ## @@

[GitHub] [calcite] danny0405 commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect

danny0405 commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect URL: https://github.com/apache/calcite/pull/1216#issuecomment-493642794 +1, LGMT This is an automated message from

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285322638 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] danny0405 edited a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 edited a comment on issue #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#issuecomment-490381828 > hi @danny0405, `RelDecorrelator` does not handle `SemiJoin` before, which is handled by `Frame

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324095 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324183 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285322574 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed

danny0405 commented on a change in pull request #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed URL: https://github.com/apache/calcite/pull/1215#discussion_r285325816 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed

danny0405 commented on a change in pull request #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed URL: https://github.com/apache/calcite/pull/1215#discussion_r285326303 ## File path:

[GitHub] [calcite] laurentgo commented on a change in pull request #765: [CALCITE-2421] Improve RexSimplify when unknownAsFalse is true

laurentgo commented on a change in pull request #765: [CALCITE-2421] Improve RexSimplify when unknownAsFalse is true URL: https://github.com/apache/calcite/pull/765#discussion_r285308244 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -312,7

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285322574 ## File path: core/src/main/java/org/apache/calcite/rel/core/JoinRelType.java ##

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324655 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324721 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java ## @@

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#discussion_r285324733 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions URL: https://github.com/apache/calcite/pull/1157#discussion_r285324792 ## File path: core/src/main/java/org/apache/calcite/rel/core/EquiJoin.java ## @@

[GitHub] [calcite] zhztheplayer commented on issue #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on issue #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#issuecomment-493639674 Also, please add and verify the email address used in your commit on GitHub. See the

[GitHub] [calcite] DonnyZone commented on a change in pull request #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect

DonnyZone commented on a change in pull request #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect URL: https://github.com/apache/calcite/pull/1216#discussion_r285325702 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#discussion_r285324733 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#discussion_r285324733 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#discussion_r285324733 ## File path:

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

zhztheplayer commented on a change in pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218#discussion_r285324733 ## File path: