[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

zhangyue19921010 commented on a change in pull request #10688: URL: https://github.com/apache/druid/pull/10688#discussion_r553173623 ## File path: core/src/main/java/org/apache/druid/coordination/CommonCallback.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

zhangyue19921010 commented on a change in pull request #10688: URL: https://github.com/apache/druid/pull/10688#discussion_r553173560 ## File path: processing/src/main/java/org/apache/druid/segment/IndexIO.java ## @@ -644,7 +649,7 @@ public QueryableIndex load(File inDir,

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

zhangyue19921010 commented on a change in pull request #10688: URL: https://github.com/apache/druid/pull/10688#discussion_r553175079 ## File path: core/src/main/java/org/apache/druid/coordination/CommonCallback.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] zhangyue19921010 commented on a change in pull request #10688: Historical lazy on start enhancement with segment files check

zhangyue19921010 commented on a change in pull request #10688: URL: https://github.com/apache/druid/pull/10688#discussion_r553173245 ## File path: core/src/main/java/org/apache/druid/coordination/CommonCallback.java ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] leventov commented on pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

leventov commented on pull request #10448: URL: https://github.com/apache/druid/pull/10448#issuecomment-755968409 > Hi @leventov, as test coverage is not very great for Druid metrics system, I'm wondering how much the CronScheduler is well-tested in production environment, especially when

[GitHub] [druid] zhangyue19921010 commented on pull request #10688: Historical reloads damaged segments automatically when lazy on start.

zhangyue19921010 commented on pull request #10688: URL: https://github.com/apache/druid/pull/10688#issuecomment-755971510 @kaijianding and @clintropolis Thanks for your review! The code has been modified and UTs added. This

[GitHub] [druid] ivan-demchenkov opened a new issue #10735: Misleading info about tsColumn in the lookups-cached-global docs

ivan-demchenkov opened a new issue #10735: URL: https://github.com/apache/druid/issues/10735 According to the [docs](https://github.com/apache/druid/blob/master/docs/development/extensions-core/lookups-cached-global.md) the extension uses tsColumn to pull only new values: > The

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553515681 ## File path: extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java ## @@ -296,14 +279,22 @@

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553586787 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/common/OrderedPartitionableRecord.java ## @@ -74,7 +74,7 @@ public

[GitHub] [druid] suneet-s edited a comment on pull request #10710: fix web-console show json bug

suneet-s edited a comment on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-756281498 @bananaaggle Thanks for this fix - can you please add a test that catches parsing these large numbers in the web-console so that future refactorings don't accidentally

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553587776 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java ## @@ -199,41 +199,41 @@

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553516275 ## File path: extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java ## @@ -296,14 +279,22 @@

[GitHub] [druid] jihoonson opened a new pull request #10736: Fix potential deadlock in batch ingestion

jihoonson opened a new pull request #10736: URL: https://github.com/apache/druid/pull/10736 ### Description `AbstractBatchIndexTask.tryTimeChunkLock()` is called `isReady()` which is called in the Overlord to check if the task is ready for execution. Since the Overlord only checks

[GitHub] [druid] gianm commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

gianm commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553572213 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/common/OrderedPartitionableRecord.java ## @@ -74,7 +74,7 @@ public

[GitHub] [druid] gianm commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

gianm commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553572213 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/common/OrderedPartitionableRecord.java ## @@ -74,7 +74,7 @@ public

[GitHub] [druid] loquisgon commented on a change in pull request #10736: Fix potential deadlock in batch ingestion

loquisgon commented on a change in pull request #10736: URL: https://github.com/apache/druid/pull/10736#discussion_r553578192 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -409,13 +413,19 @@ protected

[GitHub] [druid] jihoonson commented on pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

jihoonson commented on pull request #10448: URL: https://github.com/apache/druid/pull/10448#issuecomment-756367474 @leventov yeah, I understand the motivation behind making the CronScheduler. I'm just worried about its maturity because every cluster will be impacted after upgrade if there

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553586787 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/common/OrderedPartitionableRecord.java ## @@ -74,7 +74,7 @@ public

[GitHub] [druid] jihoonson commented on a change in pull request #10448: Added CronScheduler support as a proof to clock drift while emitting metrics

jihoonson commented on a change in pull request #10448: URL: https://github.com/apache/druid/pull/10448#discussion_r553607855 ## File path: server/src/main/java/org/apache/druid/server/metrics/MetricsModule.java ## @@ -108,10 +108,10 @@ public MonitorScheduler

[GitHub] [druid] jihoonson edited a comment on pull request #10650: Historical load Segments enhancement

jihoonson edited a comment on pull request #10650: URL: https://github.com/apache/druid/pull/10650#issuecomment-756513426 @zhangyue19921010 thank you for the PR! I added some missing unit tests in this PR in https://github.com/apache/druid/pull/10737.

[druid] branch master updated (1905b80 -> c7f2d3f)

This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 1905b80 Update badge for travis in README.md (#10717) add c7f2d3f Update deps for CVE-2020-28168 and

[GitHub] [druid] gianm merged pull request #10715: reuse DataSegment object when a segment found on another server

gianm merged pull request #10715: URL: https://github.com/apache/druid/pull/10715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (c7f2d3f -> 01e25f1)

This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from c7f2d3f Update deps for CVE-2020-28168 and CVE-2020-28052 (#10733) add 01e25f1 reuse DataSegment object when a

[GitHub] [druid] gianm commented on pull request #10695: Add documentation re alphabetical sorted of MV dimensions

gianm commented on pull request #10695: URL: https://github.com/apache/druid/pull/10695#issuecomment-756569626 > To someone more intune with Druid's inner workings: Do we really want alphabetical sorted to be the default for MV dimensions? Would it not be better to default to `ARRAY` in

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553770529 ## File path: core/src/test/java/org/apache/druid/utils/CloseableUtilsTest.java ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] bananaaggle edited a comment on pull request #10710: fix web-console show json bug

bananaaggle edited a comment on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-756582449 > @bananaaggle Thanks for this fix - can you please add a test that catches parsing these large numbers in the web-console so that future refactorings don't

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553768204 ## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ## @@ -1376,6 +1382,6 @@ long

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553772142 ## File path: processing/src/main/java/org/apache/druid/segment/data/BlockLayoutColumnarDoublesSupplier.java ## @@ -168,7 +168,7 @@ public void get(final

[GitHub] [druid] jihoonson commented on a change in pull request #10736: Fix potential deadlock in batch ingestion

jihoonson commented on a change in pull request #10736: URL: https://github.com/apache/druid/pull/10736#discussion_r553712831 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java ## @@ -409,13 +413,19 @@ protected

[GitHub] [druid] clintropolis commented on pull request #10230: Adding bitwise expressions

clintropolis commented on pull request #10230: URL: https://github.com/apache/druid/pull/10230#issuecomment-756536305 Ah, this one can be closed actually, i picked up the commit from here and added tests in #10605 This is

[GitHub] [druid] clintropolis closed pull request #10230: Adding bitwise expressions

clintropolis closed pull request #10230: URL: https://github.com/apache/druid/pull/10230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] clintropolis merged pull request #10733: Update deps for CVE-2020-28168 and CVE-2020-28052

clintropolis merged pull request #10733: URL: https://github.com/apache/druid/pull/10733 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] gianm commented on pull request #10738: Fix collision between #10689 and #10593.

gianm commented on pull request #10738: URL: https://github.com/apache/druid/pull/10738#issuecomment-756586965 LGTM failed because it couldn't build master. I guess that check isn't going to be helpful. Let's see what Travis says.

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553768704 ## File path: processing/src/main/java/org/apache/druid/segment/join/HashJoinSegment.java ## @@ -122,15 +122,14 @@ public void close() throws IOException

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553768375 ## File path: processing/src/test/java/org/apache/druid/segment/data/V3CompressedVSizeColumnarMultiIntsSerializerTest.java ## @@ -322,7 +322,7 @@ private

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553771533 ## File path: processing/src/main/java/org/apache/druid/segment/QueryableIndexIndexableAdapter.java ## @@ -280,7 +281,7 @@ public boolean

[GitHub] [druid] gianm commented on a change in pull request #10605: bitwise math function expressions

gianm commented on a change in pull request #10605: URL: https://github.com/apache/druid/pull/10605#discussion_r553775571 ## File path: core/src/main/java/org/apache/druid/math/expr/Evals.java ## @@ -71,4 +71,14 @@ public static boolean asBoolean(@Nullable String x) {

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553710889 ## File path: extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java ## @@ -199,41 +199,41 @@

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553770448 ## File path: core/src/test/java/org/apache/druid/utils/CloseableUtilsTest.java ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [druid] bananaaggle commented on pull request #10710: fix web-console show json bug

bananaaggle commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-756582449 > @bananaaggle Thanks for this fix - can you please add a test that catches parsing these large numbers in the web-console so that future refactorings don't accidentally

[GitHub] [druid] jihoonson commented on pull request #10650: Historical load Segments enhancement

jihoonson commented on pull request #10650: URL: https://github.com/apache/druid/pull/10650#issuecomment-756513426 @zhangyue19921010 thank you for the PR! I added some missing unit tests in https://github.com/apache/druid/pull/10737.

[GitHub] [druid] jihoonson commented on pull request #10724: Coordinator Dynamic Config changes to ease upgrading with new config value

jihoonson commented on pull request #10724: URL: https://github.com/apache/druid/pull/10724#issuecomment-756519969 @capistrant the code changes LGTM, but could you add a unit test that verifies JSON deserialization of `CoordinatorDynamicConfig` with missing

[GitHub] [druid] gianm commented on a change in pull request #10714: use actual dataInterval in cache key

gianm commented on a change in pull request #10714: URL: https://github.com/apache/druid/pull/10714#discussion_r553755667 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java ## @@ -230,10 +232,15 @@ public

[GitHub] [druid] gianm commented on pull request #10582: Fix scm tag for 0.20

gianm commented on pull request #10582: URL: https://github.com/apache/druid/pull/10582#issuecomment-756573431 Any idea what this does? It's been out of sync at various points in the past and nothing bad seems to happen. I have never been sure if it matters.

[GitHub] [druid] gianm opened a new pull request #10738: Fix collision between #10689 and #10593.

gianm opened a new pull request #10738: URL: https://github.com/apache/druid/pull/10738 Master is busted right now due to in-flight collision between two recent patches. This is an automated message from the Apache Git

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553772787 ## File path: processing/src/main/java/org/apache/druid/segment/data/GenericIndexed.java ## @@ -530,13 +530,13 @@ public void close()

[GitHub] [druid] jihoonson opened a new pull request #10737: Add missing unit tests for segment loading in historicals

jihoonson opened a new pull request #10737: URL: https://github.com/apache/druid/pull/10737 ### Description This PR adds missing unit tests for the changes made in https://github.com/apache/druid/pull/10650. This PR has: - [x] been self-reviewed. - [ ] using

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553771195 ## File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java ## @@ -329,9 +329,8 @@ public boolean

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553770934 ## File path: processing/src/main/java/org/apache/druid/query/groupby/strategy/GroupByStrategyV2.java ## @@ -329,9 +329,8 @@ public boolean

[GitHub] [druid] gianm commented on a change in pull request #10695: Add documentation re alphabetical sorted of MV dimensions

gianm commented on a change in pull request #10695: URL: https://github.com/apache/druid/pull/10695#discussion_r553758074 ## File path: docs/querying/multi-value-dimensions.md ## @@ -25,7 +25,7 @@ title: "Multi-value dimensions" Apache Druid supports "multi-value" string

[GitHub] [druid] gianm closed issue #10494: Remove redundant `IncrementalIndex.Builder`

gianm closed issue #10494: URL: https://github.com/apache/druid/issues/10494 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] gianm merged pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

gianm merged pull request #10593: URL: https://github.com/apache/druid/pull/10593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] gianm commented on pull request #10593: IncrementalIndex Tests and Benchmarks Parametrization

gianm commented on pull request #10593: URL: https://github.com/apache/druid/pull/10593#issuecomment-756572540 > Can we proceed to merge this PR? I haven't studied the patch, but the description makes sense to me (thanks for the detailed description), @a2l007 has reviewed it, and it

[GitHub] [druid] gianm commented on a change in pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on a change in pull request #10247: URL: https://github.com/apache/druid/pull/10247#discussion_r553772428 ## File path: processing/src/main/java/org/apache/druid/segment/data/BlockLayoutColumnarDoublesSupplier.java ## @@ -168,7 +168,7 @@ public void get(final

[GitHub] [druid] suneet-s commented on issue #10691: Integration Tests Broken/Flaky in TravisCI

suneet-s commented on issue #10691: URL: https://github.com/apache/druid/issues/10691#issuecomment-756493337 I've noticed (Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test - has also been flaky recently, but haven't had the time to dig into

[GitHub] [druid] suneet-s edited a comment on issue #10691: Integration Tests Broken/Flaky in TravisCI

suneet-s edited a comment on issue #10691: URL: https://github.com/apache/druid/issues/10691#issuecomment-756493337 I've noticed `(Compile=openjdk8, Run=openjdk8, Cluster Build On K8s) ITNestedQueryPushDownTest integration test` has also been flaky recently, but haven't had the time to

[GitHub] [druid] gianm opened a new pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm opened a new pull request #10247: URL: https://github.com/apache/druid/pull/10247 `CloseQuietly.close` is a method that closes something. It suppresses and logs any IOExceptions it gets, but re-throws any non-IOExceptions. It is used extensively and it seems likely to me that

[GitHub] [druid] gianm commented on pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

gianm commented on pull request #10247: URL: https://github.com/apache/druid/pull/10247#issuecomment-756506222 nice try, stalebot This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [druid] stale[bot] commented on pull request #10247: Remove CloseQuietly and migrate its usages to other methods.

stale[bot] commented on pull request #10247: URL: https://github.com/apache/druid/pull/10247#issuecomment-756506233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [druid] stale[bot] commented on pull request #10230: Adding bitwise expressions

stale[bot] commented on pull request #10230: URL: https://github.com/apache/druid/pull/10230#issuecomment-756507178 This issue is no longer marked as stale. This is an automated message from the Apache Git Service. To

[GitHub] [druid] gianm commented on pull request #10230: Adding bitwise expressions

gianm commented on pull request #10230: URL: https://github.com/apache/druid/pull/10230#issuecomment-756507167 Let's keep this one open, stalebot. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553707941 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java ## @@ -119,15 +120,16 @@ public

[GitHub] [druid] gianm commented on a change in pull request #10722: fix message gap not reported when thrownAway

gianm commented on a change in pull request #10722: URL: https://github.com/apache/druid/pull/10722#discussion_r553707999 ## File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorPlumber.java ## @@ -153,6 +153,7 @@ public

[GitHub] [druid] gianm merged pull request #10717: Update badge for travis in README.md

gianm merged pull request #10717: URL: https://github.com/apache/druid/pull/10717 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[druid] branch master updated (c7b1212 -> 1905b80)

This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from c7b1212 AWS RDS token based password provider (#9518) add 1905b80 Update badge for travis in README.md (#10717)

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553708446 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java ## @@ -119,15 +120,16 @@ public

[GitHub] [druid] gianm commented on pull request #10717: Update badge for travis in README.md

gianm commented on pull request #10717: URL: https://github.com/apache/druid/pull/10717#issuecomment-756509631 LGTM. I think the failure was a false alarm, because no code was changed. Thanks! This is an automated message

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553708247 ## File path: extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java ## @@ -296,14 +279,22 @@

[GitHub] [druid] zhangyue19921010 commented on pull request #10688: Historical reloads damaged segments automatically when lazy on start.

zhangyue19921010 commented on pull request #10688: URL: https://github.com/apache/druid/pull/10688#issuecomment-756510200 code coverage is passed on my laptop. Will re-run the CI now. ``` Diff coverage statistics:

[GitHub] [druid] xvrl commented on a change in pull request #10730: Introduce KafkaRecordEntity to support Kafka headers in InputFormats

xvrl commented on a change in pull request #10730: URL: https://github.com/apache/druid/pull/10730#discussion_r553486280 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaRecordSupplier.java ## @@ -119,15 +120,16 @@ public

[GitHub] [druid] suneet-s commented on a change in pull request #10724: Coordinator Dynamic Config changes to ease upgrading with new config value

suneet-s commented on a change in pull request #10724: URL: https://github.com/apache/druid/pull/10724#discussion_r553486535 ## File path: server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java ## @@ -96,7 +99,7 @@ public

[GitHub] [druid] suneet-s commented on pull request #10710: fix web-console show json bug

suneet-s commented on pull request #10710: URL: https://github.com/apache/druid/pull/10710#issuecomment-756281498 @zhangyue19921010 Thanks for this fix - can you please add a test that catches parsing these large numbers in the web-console so that future refactorings don't accidentally