[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389277#comment-17389277 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * c3bdfdd1e47790f46f4263a7fb5242c01dd02188 UNKNOWN * 40cbb91efb34e6360849a42056de6343cc1251d6 UNKNOWN *

[GitHub] [hudi] codope commented on issue #3358: [SUPPORT] Hudi hive dependency conflicts with flink hive catalog dependency

2021-07-28 Thread GitBox
codope commented on issue #3358: URL: https://github.com/apache/hudi/issues/3358#issuecomment-888434589 @swuferhong Can you please take a look? Wasn't this recently fixed in https://issues.apache.org/jira/browse/HUDI-2136 cc: @danny0405 -- This is an automated message from the

[GitHub] [hudi] vinothchandar commented on issue #3280: [SUPPORT] Use structedstreaming to consume kafka to write to hudi error

2021-07-28 Thread GitBox
vinothchandar commented on issue #3280: URL: https://github.com/apache/hudi/issues/3280#issuecomment-888415505 @codope can we do a git blame of the spark bundle to see what has changed since? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hudi] nmukerje commented on issue #3321: [SUPPORT] Setting _hoodie_is_deleted column is not deleting records when using Spark DataSource.

2021-07-28 Thread GitBox
nmukerje commented on issue #3321: URL: https://github.com/apache/hudi/issues/3321#issuecomment-888485324 Interesting! Trying it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [hudi] nmukerje edited a comment on issue #3321: [SUPPORT] Setting _hoodie_is_deleted column is not deleting records when using Spark DataSource.

2021-07-28 Thread GitBox
nmukerje edited a comment on issue #3321: URL: https://github.com/apache/hudi/issues/3321#issuecomment-888485324 @codope Interesting! Trying it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * f243dba0eb83068ee8ec39f1e3f703c4d20ee39e Azure:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678625840 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -87,6 +93,20 @@

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * b624c142628ec6b780bc124dbd5c9d0a9d5e1fdc Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389042#comment-17389042 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389055#comment-17389055 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389061#comment-17389061 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678643058 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java ## @@ -132,17 +140,27 @@ public void

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678651147 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java ## @@ -324,6 +324,14 @@ public void

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389070#comment-17389070 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] jintaoguan commented on pull request #3356: [MINOR] move metrics implementation to hudi-common

2021-07-28 Thread GitBox
jintaoguan commented on pull request #3356: URL: https://github.com/apache/hudi/pull/3356#issuecomment-888595878 @garyli1019 We might need to think about the plan for moving the implementations of metrics. So I will just abandon this PR for now. Thank you for reviewing. -- This is an

[GitHub] [hudi] jintaoguan closed pull request #3356: [MINOR] move metrics implementation to hudi-common

2021-07-28 Thread GitBox
jintaoguan closed pull request #3356: URL: https://github.com/apache/hudi/pull/3356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389046#comment-17389046 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389044#comment-17389044 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on issue #3336: [SUPPORT] Delete not functioning with deltastreamer

2021-07-28 Thread GitBox
nsivabalan commented on issue #3336: URL: https://github.com/apache/hudi/issues/3336#issuecomment-888606723 It would be a regression if its failing in 0.8.0 bcoz, don't think we touched this path in 0.8.0. @codope : Can you please test it out w/ 0.8.0. -- This is an automated message

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389071#comment-17389071 ] ASF GitHub Bot commented on HUDI-2177: -- vinothchandar commented on a change in pull request #3315:

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678651491 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -87,6 +93,20 @@

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389080#comment-17389080 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678660798 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/SpillableMapUtils.java ## @@ -110,8 +110,15 @@ public static long

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678658288 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java ## @@ -302,7 +310,12 @@ private void

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389038#comment-17389038 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389039#comment-17389039 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389043#comment-17389043 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678628690 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java ## @@ -34,49 +36,73 @@ */ public interface

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678628690 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java ## @@ -34,49 +36,73 @@ */ public interface

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389054#comment-17389054 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678634080 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java ## @@ -60,7 +60,7 @@ public static String

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678649799 ## File path: hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java ## @@ -171,6 +171,33 @@ public static

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389069#comment-17389069 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678628690 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java ## @@ -34,49 +36,73 @@ */ public interface

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678633348 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java ## @@ -82,6 +82,13 @@ public static final int

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389073#comment-17389073 ] ASF GitHub Bot commented on HUDI-2177: -- vinothchandar commented on a change in pull request #3315:

[GitHub] [hudi] vinothchandar commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678653856 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/RealtimeSplit.java ## @@ -34,49 +36,73 @@ */ public interface

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389076#comment-17389076 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678658288 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java ## @@ -302,7 +310,12 @@ private void

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389082#comment-17389082 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389089#comment-17389089 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * b624c142628ec6b780bc124dbd5c9d0a9d5e1fdc Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389117#comment-17389117 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 1eed53e2e882b8cf296a99df0664845f99c8b264 Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389126#comment-17389126 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] mithalee commented on issue #3336: [SUPPORT] Delete not functioning with deltastreamer

2021-07-28 Thread GitBox
mithalee commented on issue #3336: URL: https://github.com/apache/hudi/issues/3336#issuecomment-888699402 > @mithalee Can you try with the latest master branch? I built the master code and tried to reproduce the scenario in a local docker environment. It runs fine. For example, after

[jira] [Commented] (HUDI-2242) Add inference logic to few Hudi configs

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389151#comment-17389151 ] ASF GitHub Bot commented on HUDI-2242: -- hudi-bot edited a comment on pull request #3359: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389150#comment-17389150 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678682342 ## File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeInputFormatUtils.java ## @@ -206,16 +206,28 @@ private static

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * b624c142628ec6b780bc124dbd5c9d0a9d5e1fdc Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389092#comment-17389092 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389098#comment-17389098 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678696181 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java ## @@ -36,11 +38,14 @@ private Iterator>

[GitHub] [hudi] hudi-bot edited a comment on pull request #3359: [HUDI-2242] Add configuration inference logic for few options

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3359: URL: https://github.com/apache/hudi/pull/3359#issuecomment-888073098 ## CI report: * faccbc85679d36b30ddeabd36b98a8b225880667 Azure:

[jira] [Commented] (HUDI-2242) Add inference logic to few Hudi configs

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389120#comment-17389120 ] ASF GitHub Bot commented on HUDI-2242: -- hudi-bot edited a comment on pull request #3359: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3359: [HUDI-2242] Add configuration inference logic for few options

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3359: URL: https://github.com/apache/hudi/pull/3359#issuecomment-888073098 ## CI report: * faccbc85679d36b30ddeabd36b98a8b225880667 Azure:

[jira] [Commented] (HUDI-2242) Add inference logic to few Hudi configs

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389122#comment-17389122 ] ASF GitHub Bot commented on HUDI-2242: -- hudi-bot edited a comment on pull request #3359: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 1eed53e2e882b8cf296a99df0664845f99c8b264 Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389127#comment-17389127 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2893: [HUDI-1371] [HUDI-1893] Support metadata based listing for Spark DataSource and Spark SQL

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #2893: URL: https://github.com/apache/hudi/pull/2893#issuecomment-863021428 ## CI report: * 0d885a5956a38f1509a4317193dba7de5b51d235 Azure:

[jira] [Commented] (HUDI-1371) Support file listing using metadata for Spark DataSource and Spark SQL queries

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389130#comment-17389130 ] ASF GitHub Bot commented on HUDI-1371: -- hudi-bot edited a comment on pull request #2893: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389143#comment-17389143 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678736586 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordScanner.java ## @@ -302,7 +310,12 @@ private void

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 5c6f69320207cff8459082975140f3d8d4f4ce25 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3359: [HUDI-2242] Add configuration inference logic for few options

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3359: URL: https://github.com/apache/hudi/pull/3359#issuecomment-888073098 ## CI report: * 307a60591e5e250215e4224558273dae412e53ae Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389093#comment-17389093 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 1eed53e2e882b8cf296a99df0664845f99c8b264 Azure:

[jira] [Commented] (HUDI-1371) Support file listing using metadata for Spark DataSource and Spark SQL queries

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389128#comment-17389128 ] ASF GitHub Bot commented on HUDI-1371: -- hudi-bot edited a comment on pull request #2893: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2893: [HUDI-1371] [HUDI-1893] Support metadata based listing for Spark DataSource and Spark SQL

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #2893: URL: https://github.com/apache/hudi/pull/2893#issuecomment-863021428 ## CI report: * 0d885a5956a38f1509a4317193dba7de5b51d235 Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389131#comment-17389131 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678729363 ## File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala ## @@ -532,8 +539,8 @@ object

[jira] [Commented] (HUDI-1425) Performance loss with the additional hoodieRecords.isEmpty() in HoodieSparkSqlWriter#write

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389134#comment-17389134 ] ASF GitHub Bot commented on HUDI-1425: -- vinothchandar commented on a change in pull request #2296:

[GitHub] [hudi] vinothchandar commented on a change in pull request #2296: [HUDI-1425] Performance loss with the additional hoodieRecords.isEmpty() in HoodieSparkSqlWriter#write

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #2296: URL: https://github.com/apache/hudi/pull/2296#discussion_r678732748 ## File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java ## @@ -366,6 +366,11 @@

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389137#comment-17389137 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389136#comment-17389136 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on a change in pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 1eed53e2e882b8cf296a99df0664845f99c8b264 Azure:

[GitHub] [hudi] nsivabalan commented on a change in pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on a change in pull request #3315: URL: https://github.com/apache/hudi/pull/3315#discussion_r678696181 ## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieFileSliceReader.java ## @@ -36,11 +38,14 @@ private Iterator>

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389140#comment-17389140 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 5c6f69320207cff8459082975140f3d8d4f4ce25 Azure:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 5c6f69320207cff8459082975140f3d8d4f4ce25 Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389148#comment-17389148 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] nsivabalan commented on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
nsivabalan commented on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-888706822 @vinothchandar : addressed all feedback and left comments for some. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389149#comment-17389149 ] ASF GitHub Bot commented on HUDI-2177: -- nsivabalan commented on pull request #3315: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * 5c6f69320207cff8459082975140f3d8d4f4ce25 Azure:

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389153#comment-17389153 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[jira] [Commented] (HUDI-1371) Support file listing using metadata for Spark DataSource and Spark SQL queries

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389154#comment-17389154 ] ASF GitHub Bot commented on HUDI-1371: -- hudi-bot edited a comment on pull request #2893: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #2893: [HUDI-1371] [HUDI-1893] Support metadata based listing for Spark DataSource and Spark SQL

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #2893: URL: https://github.com/apache/hudi/pull/2893#issuecomment-863021428 ## CI report: * 25302f80c8ff5fc109b3d51027f4443b31e868cf Azure:

[jira] [Updated] (HUDI-1478) Introduce HoodieBloomIndex to hudi-java-client

2021-07-28 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra updated HUDI-1478: Fix Version/s: 0.9.0 > Introduce HoodieBloomIndex to hudi-java-client >

[jira] [Resolved] (HUDI-1478) Introduce HoodieBloomIndex to hudi-java-client

2021-07-28 Thread Udit Mehrotra (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Udit Mehrotra resolved HUDI-1478. - Resolution: Fixed Resolved with https://github.com/apache/hudi/pull/2608 > Introduce

[jira] [Commented] (HUDI-1771) Propagate CDC format for hoodie

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389159#comment-17389159 ] ASF GitHub Bot commented on HUDI-1771: -- vinothchandar commented on pull request #3285: URL:

[GitHub] [hudi] hudi-bot edited a comment on pull request #3315: [HUDI-2177][HUDI-2200] Adding virtual keys support for MOR

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #3315: URL: https://github.com/apache/hudi/pull/3315#issuecomment-883851530 ## CI report: * c3bdfdd1e47790f46f4263a7fb5242c01dd02188 UNKNOWN * 40cbb91efb34e6360849a42056de6343cc1251d6 UNKNOWN *

[jira] [Commented] (HUDI-2177) Virtual keys support for Compaction

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389160#comment-17389160 ] ASF GitHub Bot commented on HUDI-2177: -- hudi-bot edited a comment on pull request #3315: URL:

[GitHub] [hudi] vinothchandar commented on a change in pull request #3329: [HUDI-2090] Ensure Disk Maps create a subfolder with appropriate prefixes and cleans them up on close

2021-07-28 Thread GitBox
vinothchandar commented on a change in pull request #3329: URL: https://github.com/apache/hudi/pull/3329#discussion_r678764756 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java ## @@ -61,13 +61,15 @@ * * Inspired by

[jira] [Commented] (HUDI-2090) when hudi metadata is enabled, use different user to query table, the query will failed

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389161#comment-17389161 ] ASF GitHub Bot commented on HUDI-2090: -- vinothchandar commented on a change in pull request #3329:

[hudi] branch master updated: [HUDI-2241] Explicit parallelism for flink bulk insert (#3357)

2021-07-28 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new efbbb67 [HUDI-2241] Explicit parallelism for

[jira] [Commented] (HUDI-2241) Explicit parallelism for flink bulk insert

2021-07-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17389163#comment-17389163 ] ASF GitHub Bot commented on HUDI-2241: -- danny0405 merged pull request #3357: URL:

[GitHub] [hudi] danny0405 merged pull request #3357: [HUDI-2241] Explicit parallelism for flink bulk insert

2021-07-28 Thread GitBox
danny0405 merged pull request #3357: URL: https://github.com/apache/hudi/pull/3357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HUDI-2241) Explicit parallelism for flink bulk insert

2021-07-28 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/HUDI-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chen resolved HUDI-2241. -- Resolution: Fixed Fixed via master branch: efbbb67420b7082a3960f3d32215dabd959f5525 > Explicit

[GitHub] [hudi] hudi-bot edited a comment on pull request #2893: [HUDI-1371] [HUDI-1893] Support metadata based listing for Spark DataSource and Spark SQL

2021-07-28 Thread GitBox
hudi-bot edited a comment on pull request #2893: URL: https://github.com/apache/hudi/pull/2893#issuecomment-863021428 ## CI report: * 25302f80c8ff5fc109b3d51027f4443b31e868cf Azure:

  1   2   3   4   >