JDK 9 RFR of JDK-8039038: Fix serial lint warnings in com.sun.jmx.snmp

2014-04-02 Thread Joe Darcy
Hello, *fingers crossed* The patch below should be the last change needed to fully clear the JDK 9 jdk repo of serialization warnings. Thanks, -Joe diff -r b6997dd0667e src/share/classes/com/sun/jmx/snmp/Enumerated.java --- a/src/share/classes/com/sun/jmx/snmp/Enumerated.javaTue Apr 01

Re: JDK 9 RFR of 8039022: Fix serial lint warnings in sun.tools.java

2014-04-02 Thread Alan Bateman
On 02/04/2014 00:20, Joe Darcy wrote: Hello, The plague of serial warnings in the jdk repo is nearly eradicated. Please review the fix below if address to a few of the holdouts. This looks okay, assuming of course that none of these types leak into the serialized form by some other means.

Re: JDK 9 RFR of 8039027: Fix serial lint warnings in jconsole and jstat

2014-04-02 Thread Alan Bateman
On 02/04/2014 02:20, Joe Darcy wrote: Hello, With the serial warnings cleanup of the JDK drawing to completion, please review the patch below which addresses some lingering issues in jconsole and jstat. This looks okay too. -Alan

Re: JDK 9 RFR of JDK-8039038: Fix serial lint warnings in com.sun.jmx.snmp

2014-04-02 Thread Alan Bateman
On 02/04/2014 07:39, Joe Darcy wrote: Hello, *fingers crossed* The patch below should be the last change needed to fully clear the JDK 9 jdk repo of serialization warnings. Thanks, -Joe This looks okay too. -Alan

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-02 Thread Alan Bateman
On 01/04/2014 23:40, Martin Buchholz wrote: So I rather like having different LaunchMechanisms available on different platforms - just the default would be different. fork should work everywhere. I agree that is important to keep the ability to configure this, it was particularly useful with

Re: JDK 9 RFR of JDK-8039038: Fix serial lint warnings in com.sun.jmx.snmp

2014-04-02 Thread Daniel Fuchs
On 4/2/14 8:39 AM, Joe Darcy wrote: Hello, *fingers crossed* The patch below should be the last change needed to fully clear the JDK 9 jdk repo of serialization warnings. Looks good Joe! best regards, -- daniel Thanks, -Joe diff -r b6997dd0667e

Re: Implicit 'this' return for void methods

2014-04-02 Thread Andrew Haley
On 04/01/2014 10:20 PM, Eirik Lygre wrote: What is the relationship between this naked dot proposal and the chaining of void methods proposal? The reason for asking is not to be negative, but rather to find out if these issues are best dealt with together, or as independent proposals. I

RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

2014-04-02 Thread Seán Coffey
I'm looking to port this fix from JDK 8 to 9. Other changes were made for JDK 9 given that we have access to the javaAwtAccess.getAppletContext() method when using JDK 8 as the boot strap JDK for CORBA. Direct access to the sun.awt.AppContect class has been removed. bug :

Re: JDK 9 RFR of JDK-8039038: Fix serial lint warnings in com.sun.jmx.snmp

2014-04-02 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Apr 2, 2014, at 2:39 AM, Joe Darcy joe.da...@oracle.com wrote: Hello, *fingers crossed* The patch below

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-02 Thread Peter Levart
On 04/01/2014 09:47 PM, roger riggs wrote: Hi, A minor point, but the Enum for LaunchMechanism can be simpler; the defined enum values (1,2,3) are never used and can be removed along with the extra constructor. They are used for the mode parameter of forkAndExec() native method. With the

RFR: 8038306: (tz) Support tzdata2014b

2014-04-02 Thread Aleksej Efimov
Hello, Can I have a review for the latest (2014b) TZ data integration to JDK9. The webrev can be located here [1]. The following set of tests were executed without failures: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/sun/util/calendar

Re: Implicit 'this' return for void methods

2014-04-02 Thread Ulf Zibis
Hi, Am 02.04.2014 11:08, schrieb Andrew Haley: On 04/01/2014 10:20 PM, Eirik Lygre wrote: What is the relationship between this naked dot proposal and the chaining of void methods proposal? The reason for asking is not to be negative, but rather to find out if these issues are best dealt with

Re: Implicit 'this' return for void methods

2014-04-02 Thread Andrew Haley
On 04/02/2014 11:58 AM, Ulf Zibis wrote: Hi, Am 02.04.2014 11:08, schrieb Andrew Haley: On 04/01/2014 10:20 PM, Eirik Lygre wrote: What is the relationship between this naked dot proposal and the chaining of void methods proposal? The reason for asking is not to be negative, but rather to

Re: i18n dev RFR: 8038306: (tz) Support tzdata2014b

2014-04-02 Thread Seán Coffey
Looks fine to me. regards, Sean. On 02/04/14 11:55, Aleksej Efimov wrote: Hello, Can I have a review for the latest (2014b) TZ data integration to JDK9. The webrev can be located here [1]. The following set of tests were executed without failures: test/sun/util/calendar

Re: Implicit 'this' return for void methods

2014-04-02 Thread Marek Kozieł
In my opinion Project Coin was meant only to push some earlier chosen changes into language. Naked dot in language where long name are preferred is pure evil: I would have to look pairing ; for every dot ? someVeryLongName()/* explanation*/.otherLongNameMethod(); someVeryLongName();/*

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-02 Thread roger riggs
Hi, On 4/2/2014 6:49 AM, Peter Levart wrote: On 04/01/2014 09:47 PM, roger riggs wrote: Hi, A minor point, but the Enum for LaunchMechanism can be simpler; the defined enum values (1,2,3) are never used and can be removed along with the extra constructor. They are used for the mode

Re: RFR: tests for JDK-8032884

2014-04-02 Thread Miroslav Kos
In the test, I need to do following steps: 1. compile schema file using xjc tool 2. compile generated sources 3. load generated class and via reflection API verify generated methods Although I know how to run tool directly from the test, it seems to me not very elegant to run compiler directly

Re: RFR: tests for JDK-8032884

2014-04-02 Thread Chris Hegarty
On 02/04/14 14:32, Miroslav Kos wrote: In the test, I need to do following steps: 1. compile schema file using xjc tool 2. compile generated sources 3. load generated class and via reflection API verify generated methods In which case, what you have is fine then. Although I know how to run

Re: Implicit 'this' return for void methods

2014-04-02 Thread Patrick Wright
Hi, Just adding some perspective after following these language-feature discussions for several years now. In my opinion Project Coin was meant only to push some earlier chosen changes into language. The initial Project Coin process actually invited proposals from the community. There were

Re: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

2014-04-02 Thread Alan Bateman
On 02/04/2014 11:42, Seán Coffey wrote: I'm looking to port this fix from JDK 8 to 9. Other changes were made for JDK 9 given that we have access to the javaAwtAccess.getAppletContext() method when using JDK 8 as the boot strap JDK for CORBA. Direct access to the sun.awt.AppContect class has

Re: [9] RFR (M): 8037209: Improvements and cleanups to bytecode assembly for lambda forms

2014-04-02 Thread Paul Sandoz
On Apr 1, 2014, at 6:21 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: On 4/1/14 7:29 PM, Paul Sandoz wrote: On Apr 1, 2014, at 4:10 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com wrote: Paul, Unfortunately, additional profiling doesn't work for Accessor.checkCast case.

Re: Implicit 'this' return for void methods

2014-04-02 Thread Andrew Haley
On 04/02/2014 12:05 PM, Andrew Haley wrote: On 04/02/2014 11:58 AM, Ulf Zibis wrote: Hi, Am 02.04.2014 11:08, schrieb Andrew Haley: On 04/01/2014 10:20 PM, Eirik Lygre wrote: What is the relationship between this naked dot proposal and the chaining of void methods proposal? The reason for

Re: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

2014-04-02 Thread Seán Coffey
On 02/04/14 15:05, Alan Bateman wrote: On 02/04/2014 11:42, Seán Coffey wrote: I'm looking to port this fix from JDK 8 to 9. Other changes were made for JDK 9 given that we have access to the javaAwtAccess.getAppletContext() method when using JDK 8 as the boot strap JDK for CORBA. Direct

RFR 8039088: Fix broken URLs in package.html

2014-04-02 Thread Lance Andersen
Good morning, Here is another trivial change to address some broken links Best Lance ljanders-mac:sql ljanders$ hg diff diff -r 31541b9a5a4a src/share/classes/java/sql/package.html --- a/src/share/classes/java/sql/package.html Wed Apr 02 10:20:14 2014 -0400 +++

Re: RFR 8039088: Fix broken URLs in package.html

2014-04-02 Thread Chris Hegarty
Looks ok to me Lance. -Chris. On 02/04/14 15:53, Lance Andersen wrote: Good morning, Here is another trivial change to address some broken links Best Lance ljanders-mac:sql ljanders$ hg diff diff -r 31541b9a5a4a src/share/classes/java/sql/package.html ---

Re: Improve timezone mapping for AIX platform

2014-04-02 Thread Volker Simonis
Hi Jonathan, thanks for updating the change. Please find my comments inline: On Tue, Apr 1, 2014 at 4:52 PM, Jonathan Lu luc...@linux.vnet.ibm.com wrote: Hi Volker, Masayoshi, Thanks a lot for your review, here's the updated patch, could you pls take a look?

Re: RFR: 8038306: (tz) Support tzdata2014b

2014-04-02 Thread Xueming Shen
looks fine. On 4/2/14 3:55 AM, Aleksej Efimov wrote: Hello, Can I have a review for the latest (2014b) TZ data integration to JDK9. The webrev can be located here [1]. The following set of tests were executed without failures: test/sun/util/calendar test/java/util/Calendar

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-02 Thread Alan Bateman
On 01/04/2014 18:04, Peter Levart wrote: Hi Roger, Well, it turns out the methods would like to stay in Os (renamed to Platform), but there is no need for per-enum-instance subclasses. Using enum constructor parameters and switch statements makes code even more compact and easy to follow...

Re: RFR: 8035618 : Four api/org_omg/CORBA TCK tests fail under plugin only

2014-04-02 Thread Mandy Chung
On 4/2/2014 7:44 AM, Seán Coffey wrote: On 02/04/14 15:05, Alan Bateman wrote: On 02/04/2014 11:42, Seán Coffey wrote: I'm looking to port this fix from JDK 8 to 9. Other changes were made for JDK 9 given that we have access to the javaAwtAccess.getAppletContext() method when using JDK 8 as

Re: RFR: 8000975: (process) Merge UNIXProcess.java.bsd UNIXProcess.java.linux ( .solaris .aix)

2014-04-02 Thread Peter Levart
On 04/02/2014 03:17 PM, roger riggs wrote: Hi, On 4/2/2014 6:49 AM, Peter Levart wrote: On 04/01/2014 09:47 PM, roger riggs wrote: Hi, A minor point, but the Enum for LaunchMechanism can be simpler; the defined enum values (1,2,3) are never used and can be removed along with the extra

Re: Improve timezone mapping for AIX platform

2014-04-02 Thread Jonathan Lu
Hi Volker, On 2014年04月02日 23:07, Volker Simonis wrote: Hi Jonathan, thanks for updating the change. Please find my comments inline: On Tue, Apr 1, 2014 at 4:52 PM, Jonathan Lu luc...@linux.vnet.ibm.com luc...@linux.vnet.ibm.com wrote: Hi Volker, Masayoshi, Thanks a lot for your review,

Re: [9] RFR (M): 8037209: Improvements and cleanups to bytecode assembly for lambda forms

2014-04-02 Thread Paul Sandoz
On Apr 2, 2014, at 4:16 PM, Paul Sandoz paul.san...@oracle.com wrote: Regarding redundant null check, do you have a test case so I can play with it myself? I will send something to you later today or tomorrow. Still plan to send you something today :-) but later on... See below

Re: Implicit 'this' return for void methods

2014-04-02 Thread Peter Levart
On 04/01/2014 11:28 AM, Bruce Chapman wrote: Slightly preceding Ulf's coin proposal by a few hours was http://mail.openjdk.java.net/pipermail/coin-dev/2009-March/001134.html Where I suggested the naked dot notation (coined in