On Tue, 14 Jun 2022 12:18:52 GMT, Matthias Baesken wrote:
>> When trying to construct an LdapURL object with a bad input string (in this
>> example the _ in ad_jbs is causing issues), and not using
>> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we
>> run into the
On Fri, 10 Jun 2022 12:16:17 GMT, Matthias Baesken wrote:
> When trying to construct an LdapURL object with a bad input string (in this
> example the _ in ad_jbs is causing issues), and not using
> the backward compatibility flag -Dcom.sun.jndi.ldapURLParsing="legacy" we run
> into the
On Sun, 29 May 2022 20:22:55 GMT, Andrey Turbanov wrote:
> In [JDK-8273098](https://bugs.openjdk.java.net/browse/JDK-8273098) I missed
> one place, where Vector could be replaced with ArrayList.
> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to
> use `ArrayList` if
On Thu, 2 Jun 2022 13:59:50 GMT, Сергей Цыпанов wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
>
On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
Changes to `net` and `http` look good.
-
Marked as reviewed by dfuchs
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
Marked as
On Fri, 27 May 2022 15:24:46 GMT, Rob McKenna wrote:
> Test change to silently pass if the test environment encounters a
> NoRouteToHostException. These are intermittent at the moment but I will
> attempt to find an alternative to the use of example.com in some follow up
> work.
On Fri, 6 May 2022 22:05:35 GMT, liach wrote:
>> Explicitly implement `remove` and `replace` in `IdentityHashMap` to compare
>> values by identity. Updated API documentation of these two methods
>>
On Thu, 26 May 2022 18:50:07 GMT, Xue-Lei Andrew Fan wrote:
> Hi,
>
> May I have this test update reviewed?
>
> The ForceGC could be enhanced by using smaller wait/sleep time, and shared
> cleaner.
>
> Thanks,
> Xuelei
LGTM - but it may be good to have an other reviewer (@mlchung ?)
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote:
> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>
> This is a non-final API that provides a gentle on-ramp to structure a task as
> a family of concurrent subtasks, and to coordinate the subtasks as a unit.
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Logging/JNDI OK
-
Marked as
On Fri, 13 May 2022 14:36:02 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the failure
>> handler command `dmesg` on macOS?
>>
>> As noted in the JBS issue, the command currently fails with permission
>> error. The commit in this PR uses `sudo` as
On Fri, 13 May 2022 12:06:45 GMT, Jorn Vernee wrote:
>> Address possible lossy conversion warning in `ProgrammableInvoker`.
>>
>> Testing: `run-test-jdk_foreign`, testing with patch from
>> https://github.com/openjdk/jdk/pull/8599 to see if the warning is gone.
>
> Jorn Vernee has updated the
On Fri, 13 May 2022 10:04:36 GMT, Jorn Vernee wrote:
> Address possible lossy conversion warning in `ProgrammableInvoker`.
>
> Testing: `run-test-jdk_foreign`, testing with patch from
> https://github.com/openjdk/jdk/pull/8599 to see if the warning is gone.
On Thu, 12 May 2022 16:47:43 GMT, Roger Riggs wrote:
> Updates to modules java.rmi and java.smartcardio to remove warnings about
> lossy-conversions introduced by PR#8599.
>
> Explicit casts are inserted where implicit casts occur.
>
> 8286393: Address possibly lossy conversions in java.rmi
>
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On 10/05/2022 14:39, Remi Forax wrote:
This is not a big problem but I have seen peaks with suddenly many, many
threads (in test code) where many HttpClients were created for single use
and I was wondering if it was ever considered to add a method for disposing
the threads explicitly?
You can
On Tue, 10 May 2022 11:31:16 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java line
>> 230:
>>
>>> 228: List l = new ArrayList<>();
>>> 229: for (Class c : categoryMap.keySet()) {
>>> 230: if
Hi Rafael,
On 09/05/2022 22:43, Rafael Winterhalter wrote:
Hello,
looking at thread dumps, I realized that the HttpClient implementation does
not offer an explicit way to release its threads. Currently, the client:
1. maintains a cached thread pool with a retention size of 60 seconds. If
many
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Mon, 2 May 2022 13:01:40 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: Tests updated
LGTM
-
On Fri, 29 Apr 2022 18:28:45 GMT, Weijun Wang wrote:
>> Shouldn't the comparison be better implemented by the caller then, who will
>> know whether spaces are important or not? That's why I had suggested taking
>> a `Predicate` that could be called with each line removed, and the
>> caller
On Fri, 29 Apr 2022 13:02:06 GMT, Weijun Wang wrote:
>> Also calling trim() assumes that white spaces are not significant. This
>> might not be the case in the general case (for instance - think of markdown
>> files were leading spaces are significant).
>
> The comparison is intentionally made
On Fri, 29 Apr 2022 12:35:59 GMT, Daniel Fuchs wrote:
>> Sibabrata Sahoo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8285452: updated to use lines()
>
> test/lib/jdk/test/lib/util/FileUtils.java line 3
On Fri, 29 Apr 2022 12:29:35 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8285452: updated to use lines()
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses
> https://bugs.openjdk.java.net/browse/JDK-8285915?
>
> With this change, the environment details collected by the failure handler
> will now include the contents of the
On Fri, 29 Apr 2022 09:03:58 GMT, Pavel Rappo wrote:
> * Syntactically improves a few cases from 8285676
> (https://github.com/openjdk/jdk/pull/8410)
> * Fixes a few misspelled `@param` tags for elements that, although are not
> included in the API Documentation, are visible in and processed
Hi,
Thanks for the pointers.
> Just to mention a few:
>
https://urldefense.com/v3/__https://www.baeldung.com/java-9-http-client__;!!ACWV5N9M2RV99hQ!MbomkSmr-rXolK88z_JdINs3IEG8MTH_B7DHDq6wYgUeJQvZNGT7Iwb3yFswd57S1l85R53Yo_zq8zIvWdw$
>
Hi,
java.net.http.HttpClient only supports Basic authentication out
of the box.
Which tutorials are claiming that Digest authentication is supported?
Can you send some links?
At the moment there is no plan to support digest authentication out of
the box. It can be easily implemented at the
On Thu, 28 Apr 2022 01:34:19 GMT, Joe Darcy wrote:
>> To enable more complete doclint checking (courtesy @jonathan-gibbons),
>> please review this PR to add type-level @param tags where they are missing.
>>
>> To the maintainers of java.util.concurrent, those changes could be separated
>> out
On Wed, 27 Apr 2022 14:24:20 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Tue, 26 Apr 2022 22:24:26 GMT, Joe Darcy wrote:
> To enable more complete doclint checking (courtesy @jonathan-gibbons), please
> review this PR to add type-level @param tags where they are missing.
>
> To the maintainers of java.util.concurrent, those changes could be separated
> out in
On Tue, 26 Apr 2022 19:35:19 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList two tests from JDK-8285671 on macosx-x64.
LGTM Dan. Thanks for taking care of that!
-
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8406
On Tue, 26 Apr 2022 17:27:35 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
>> JDK version to target.
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in
On Mon, 25 Apr 2022 13:30:05 GMT, Daniel Fuchs wrote:
> Hi,
>
> Please find enclosed a patch to fix a rare intermittent failure that was
> detected while testing virtual threads.
> The issue has nothing to do with virtual threads, the test is simply missing
> a reachability
On Mon, 25 Apr 2022 13:48:47 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year again
>
> test/jdk/java/util/logging/Logger/logrb/TestLogrbResou
rbage
> collected until its child logger is created.
>
> best regards,
>
> -- daniel
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year again
-
Changes:
- all: https://git.openjdk.jav
Hi,
Please find enclosed a patch to fix a rare intermittent failure that was
detected while testing virtual thread.
The issue has nothing to do with virtual thread, the test is simply missing a
reachability fence to make sure that the parent logger is not garbage collected
until its child
On Fri, 22 Apr 2022 14:35:14 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
On Fri, 22 Apr 2022 12:36:15 GMT, Sibabrata Sahoo wrote:
>> A new API to support replacing selective lines with desired content.
>
> Sibabrata Sahoo has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update FileUtils.java
On Thu, 21 Apr 2022 14:03:39 GMT, Daniel Fuchs wrote:
>> I ran `codespell` on modules owned by the serviceability team
>> (`java.instrument java.management.rmi java.management jdk.attach
>> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
>> j
On Thu, 21 Apr 2022 11:22:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on modules owned by the serviceability team
> (`java.instrument java.management.rmi java.management jdk.attach
> jdk.hotspot.agent jdk.internal.jvmstat jdk.jcmd jdk.jconsole jdk.jdi
> jdk.jdwp.agent jdk.jstatd
On Wed, 20 Apr 2022 00:32:25 GMT, Brent Christian wrote:
> Please review this change to replace the finalizer in
> `AbstractLdapNamingEnumeration` with a Cleaner.
>
> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
> res`, and `LdapClient enumClnt`) are moved to a
On Wed, 20 Apr 2022 15:33:26 GMT, Brian Burkhalter wrote:
>> Remove the `synchronized` keyword from the `mark(int)` and `reset()` methods
>> of `java.io.FilterInputStream`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
On Wed, 20 Apr 2022 11:56:20 GMT, Jaikiran Pai wrote:
> As for the changes to `FilterInputStream`, would this change require a CSR?
There might be a case where a subclass of `FilterInputStream` has overridden
all other methods to add `synchronized` but has not overridden `mark` and
`reset`,
On Wed, 13 Apr 2022 19:28:08 GMT, Stuart Marks wrote:
> Reviewers for i18n, net, nio, and security, please review call site changes
> in your areas. Thanks.
Changes to `java.net.http` look good to me. I haven't spotted anything
obviously wrong in the rest, but should defer to reviewers of
On Tue, 12 Apr 2022 13:02:44 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/BufferedReader.java line 101:
>>
>>> 99: */
>>> 100: public BufferedReader(Reader in, int sz) {
>>> 101: Objects.requireNonNull(in);
>>
>> Not sure if that even matters - but there
On Tue, 12 Apr 2022 01:17:37 GMT, Andrew John Hughes wrote:
> What's the status of this? The last comment reads as if this is good to go.
I believe we're still waiting for Martin to reply to the last comment:
> Maybe, you could also log a bug for a test addition and describe in it an
>
On Fri, 8 Apr 2022 13:43:39 GMT, Alan Bateman wrote:
> This is the implementation of JEP 425: Virtual Threads (Preview); TBD which
> JDK version to target.
>
> We will refresh this PR periodically to pick up changes and fixes from the
> loom repo.
>
> Most of the new mechanisms in the
On Fri, 8 Apr 2022 16:37:07 GMT, Daniel Fuchs wrote:
> Please find enclosed a patch for
> `8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
>
> My analysis is that the test fails intermittently because the `FileChannel`
> created by the test is garbag
On Fri, 8 Apr 2022 17:09:42 GMT, Alan Bateman wrote:
> Looks fine, you can drop use of getAbsolutePath if you want to, not important
> here.
Done - used `File::toPath` since `lock` is a `File`.
-
PR: https://git.openjdk.java.net/jdk/pull/8168
hat tries to cleanup the files at the end.
>
> Though I haven't been able to reproduce the exact failure yet, I haven't
> observed the new version of the test failing either.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last re
hat tries to cleanup the files at the end.
>
> Though I haven't been able to reproduce the exact failure yet, I haven't
> observed the new version of the test failing either.
Daniel Fuchs has updated the pull request incrementally with one additional
commit since the last re
On Fri, 8 Apr 2022 16:50:45 GMT, Alan Bateman wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Incorporated review comments
>
> test/jdk/java/util/logging/CheckZombieLoc
Please find enclosed a patch for
`8283719: java/util/logging/CheckZombieLockTest.java failing intermittently`
My analysis is that the test fails intermittently because the `FileChannel`
created by the test is garbage collected too early, which releases the
associated lock before the
On Tue, 29 Mar 2022 16:07:18 GMT, Stuart Marks wrote:
>> Pretty much just what it says.
>
> Stuart Marks has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adjust nonfinal CSMs and rework error reporting in CheckCSMs.java test
Nice update to
On Tue, 29 Mar 2022 01:07:33 GMT, Stuart Marks wrote:
> Pretty much just what it says.
Yes - it looks like jdk/internal/reflect/CallerSensitive/CheckCSMs.java needs
to be updated.
-
PR: https://git.openjdk.java.net/jdk/pull/8009
On Tue, 22 Mar 2022 17:59:15 GMT, Brent Christian wrote:
> Please review this change to the java/util/prefs/AddNodeChangeListener.jar
> test.
>
> Although the test specifies "-Djava.util.prefs.userRoot=." to ensure a fresh
> Preferences on each test run, MacOS does not seem to honor this, and
On Tue, 22 Mar 2022 00:01:59 GMT, Joe Darcy wrote:
> As part of updating the core libraries to be sealed, the package-access
> AbstractStringBuilder, implementation superclass of StringBuilder and
> StringBuffer, can be marked as sealed with those two subclasses on its
> permits list.
LGTM.
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote:
>> We propose to provide a runtime anonymous carrier class object generator;
>> java.lang.runtime.Carrier. This generator class is designed to share
>> anonymous classes when shapes are similar. For example, if several clients
>> require
On Fri, 11 Mar 2022 19:18:55 GMT, Carter Kozak wrote:
>> 8283049: Fix non-singleton LoggerFinder error message: s/on/one
>
> Carter Kozak has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add 8283049 to LoggerFinderLoaderTest @bug docs
On Thu, 10 Mar 2022 22:28:14 GMT, Carter Kozak wrote:
> 8283049: Fix non-singleton LoggerFinder error message: s/on/one
I changed the bug title to match the PR title.
test/jdk/java/lang/System/LoggerFinder/internal/LoggerFinderLoaderTest/LoggerFinderLoaderTest.java
line 233:
> 231:
Hi Carter,
I have created https://bugs.openjdk.java.net/browse/JDK-8283049
I will sponsor the changed after it's been reviewed and integrated.
best regards,
-- daniel
On 11/03/2022 15:42, Carter Kozak wrote:
When multiple LoggerFinder implementations are found, a ServiceConfigurationError
On Thu, 10 Mar 2022 17:00:09 GMT, Naoto Sato wrote:
> IIRC, localized resource files should have the same copyright year as the
> base English one. That's what I was told by the l10n engineer when I had the
> same comment.
Thanks Naoto! I have no objection then.
-
PR:
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
For simple webserver resource files - should the copyright year be 2022?
-
PR: https://git.openjdk.java.net/jdk/pull/7765
On Mon, 7 Mar 2022 15:11:50 GMT, Сергей Цыпанов wrote:
> `List.of()` along with `Set.of()` create unmodifiable `List/Set` but with
> smaller footprint comparing to `Arrays.asList()` / `new HashSet()` when
> called with vararg of size 0, 1, 2.
>
> In general replacement of `Arrays.asList()`
On Tue, 1 Mar 2022 08:13:57 GMT, Chris Hegarty wrote:
>> The module finder implementation incorrectly uses the path-separator
>> character from the default file system, when mapping the relative path
>> of an entry in an exploded module to a package name. This causes
>> problems on Windows [*]
On Mon, 28 Feb 2022 11:12:17 GMT, Chris Hegarty wrote:
> The module finder implementation incorrectly uses the path-separator
> character from the default file system, when mapping the relative path
> of an entry in an exploded module to a package name. This causes
> problems on Windows [*] when
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change to the javadoc of
> `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8282190?
LGTM
-
Marked as reviewed
On Mon, 14 Feb 2022 05:27:39 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8281634?
>
> The commit introduces the missing `err.invalid.filters` key in the jdeps
> resource bundle. I have
On Thu, 10 Feb 2022 15:25:09 GMT, Aleksei Efimov wrote:
> I'm ok with pushing the fix without a test given that the user will verify it
> in his real environment.
> Maybe, you could also log a bug for a test addition and describe in it an
> environment, and sort of a high-level scenario of how
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
On Wed, 20 Oct 2021 13:35:22 GMT, Martin Balao wrote:
> I'd like to propose a fix for JDK-8275535. This fix reverts the behavior to
> the state previous to JDK-8160768, where an authentication failure stops from
> trying other LDAP servers with the same credentials [1]. After JDK-8160768 we
>
Hi Jaikiran,
Thanks for working on this and apologies for the long silence.
I believe your analysis of the issue is very valuable.
Unless there is some clever trick we could do to allow to unlink
the file from the file system before deleting it, so that the file
path can be reused, it seems
On Fri, 4 Feb 2022 15:36:35 GMT, Aleksei Efimov wrote:
> Hi,
>
> JNDI's `DnsClient` can fail with `UncheckedIOException` during `connect` or
> `disconnect` method calls. It is a [know
> behavior](https://bugs.openjdk.java.net/browse/JDK-8236076) of
> `DatagramSocket`.
>
> Currently,
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
Hi Tobias,
Regardless of whether this is a bug or not, JarIndex has been disabled
by default in JDK 18, in the hope to eventually remove it in the
future.
See https://bugs.openjdk.java.net/browse/JDK-8273473
best regards,
-- daniel
On 27/01/2022 18:41, Tobias Stadler wrote:
Hello everyone,
On Thu, 27 Jan 2022 18:05:25 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Wed, 26 Jan 2022 19:00:14 GMT, Weijun Wang wrote:
>> test/jdk/sun/security/krb5/auto/HttpsCB.java line 201:
>>
>>> 199: return reader.readLine().equals(CONTENT);
>>> 200: } catch (Exception e) {
>>> 201: return false;
>>
>> Should we log that we have received
On Wed, 26 Jan 2022 16:02:09 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Tue, 25 Jan 2022 10:30:20 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Mon, 24 Jan 2022 13:36:47 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by dfuchs (Reviewer).
LGTM. I hope in the future IDEs will pick that rule up and offer some help when
writing `{@link }` `@see`...
-
PR:
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get
On Fri, 21 Jan 2022 16:02:29 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 13:06:40 GMT, Rob McKenna wrote:
>> This fix attemps to resolve an issue where threads can stack up on each
>> other while waiting to get a connection from the ldap pool to an unreachable
>> server. It does this by having each thread start a countdown prior to
>> holding
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 15:26:33 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Fri, 21 Jan 2022 15:08:58 GMT, Michael McMahon wrote:
>> It was being handled elsewhere as "never". But, I agree it would be clearer
>> to normalise it to "never" here.
>
> Sorry, I should have checked back to the source rather than the snippet
> quoted. The problem is that the logError
On Thu, 20 Jan 2022 10:58:27 GMT, Michael McMahon wrote:
>> Hi,
>>
>> This change adds Channel Binding Token (CBT) support to HTTPS
>> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO,
>> Kerberos) authentication scheme. When enabled, the implementation
>> preemptively
On Wed, 19 Jan 2022 15:13:57 GMT, Rob McKenna wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/pool/PooledConnectionFactory.java
>> line 54:
>>
>>> 52: * @param timeout the connection timeout
>>> 53: */
>>> 54: public abstract PooledConnection
>>>
On Mon, 17 Jan 2022 06:32:13 GMT, Prasadrao Koppula
wrote:
>> This system property should only be used for TLS, and the CBT can be used in
>> both the SPNEGO mechanism and the Kerberos 5 mechanism. Therefore I suggest
>> the name should probably contain "tls" (or maybe "https") and
On Sat, 15 Jan 2022 00:49:05 GMT, Weijun Wang wrote:
>> Argh - you're right I missed the fact that the 3 expressions where included
>> in parenthesis. I read it as
>>
>> ! (s.equals("always")) || ...
>
> Shall we log a message if the value is not one of the 3 forms?
Usually malformed values
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a
On Mon, 10 Jan 2022 20:46:36 GMT, Andrey Turbanov wrote:
> `Properties.load` uses `java.util.Properties.LineReader`. LineReader already
> buffers input stream. Hence wrapping InputStream in BufferedInputStream is
> redundant.
Changes to `java.util.logging` look fine.
-
PR:
On Fri, 14 Jan 2022 10:03:37 GMT, Michael McMahon wrote:
>> src/java.base/share/classes/sun/net/www/http/HttpClient.java line 180:
>>
>>> 178: static String normalizeCBT(String s) {
>>> 179: if (s == null || ! (s.equals("always") ||
>>> 180: s.equals("never") ||
On Thu, 13 Jan 2022 12:10:11 GMT, Michael McMahon wrote:
> Hi,
>
> This change adds Channel Binding Token (CBT) support to HTTPS
> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos)
> authentication scheme. When enabled, the implementation preemptively includes
> a
On Thu, 13 Jan 2022 10:09:45 GMT, Daniel Fuchs wrote:
>> src/java.naming/share/classes/com/sun/jndi/ldap/LdapClientFactory.java line
>> 70:
>>
>>> 68: public PooledConnection createPooledConnection(PoolCallback pcb,
>>> long timeout)
>>>
1 - 100 of 1534 matches
Mail list logo
