uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Wed, 1 Jun 2022 05:09:42 GMT, ExE Boss wrote:
>> Or `AbstractMethodError`, which is what `Executable::getParameterCount()`
>> does:
>> https://github.com/openjdk/jdk/blob/e751b7b1b6f7269a1fe20c07748c726536388f6d/src/java.base/share/classes/java/lang/reflect/Executable.java#L248-L258
>
>
On Tue, 14 Jun 2022 01:40:53 GMT, liach wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make mask fields final in ModuleDescriptor.
>
> src/java.base/share/classes/java/lang/re
On Tue, 31 May 2022 17:23:18 GMT, Rémi Forax wrote:
>> For completeness, I think including SUPER is reasonable, even though has
>> been a no-op for some time. (Some time in the future, there could be a class
>> file version aware additions to this enum class.) Well spotted omission.
>
>
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Tue, 31 May 2022 17:20:08 GMT, Rémi Forax wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 32 additional
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Wed, 13 Apr 2022 21:21:25 GMT, liach wrote:
>> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 167:
>>
>>> 165: * but is optional in the dynamic phase, during execution.
>>> 166: */
>>> 167: STATIC(AccessFlag.STATIC.mask()),
>>
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Tue, 15 Feb 2022 09:06:02 GMT, ExE Boss wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to more review feedback.
>
> src/java.base/share/classes/java/lang/reflect/Acces
On Sat, 11 Jun 2022 00:35:52 GMT, Joe Darcy wrote:
> 8288173: JDK-8202449 fix causes conformance test failure :
> api/java_util/Random/RandomGenerator/NextFloat.html
This pull request has now been integrated.
Changeset: f4b05a11
Author: Joe Darcy
URL:
https://git.openjdk.org
8288173: JDK-8202449 fix causes conformance test failure :
api/java_util/Random/RandomGenerator/NextFloat.html
-
Commit messages:
- Backport da2339cf6971532593e4f1b5ebbce8d1ed2e83b2
Changes: https://git.openjdk.org/jdk19/pull/5/files
Webrev:
On Fri, 10 Jun 2022 08:36:57 GMT, Raffaello Giulietti
wrote:
> This fixes a bug introduced with JDK-8202449.
Changes look okay, but please do a follow-up fix to add some regression tests
for this condition.
-
Marked as reviewed by darcy (Reviewer).
PR:
On Fri, 10 Jun 2022 16:15:36 GMT, Joe Darcy wrote:
> There are many instanceof checks in the sun.reflection.annotation code; these
> would be improved by using pattern matching for instanceof.
This pull request has now been integrated.
Changeset: aaa89714
Author: Joe Darc
There are many instanceof checks in the sun.reflection.annotation code; these
would be improved by using pattern matching for instanceof.
-
Commit messages:
- JDK-8288227: Refactor annotation implementation to use pattern matching for
instanceo
Changes:
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote:
> Time to start getting ready for JDK 20...
This pull request has now been integrated.
Changeset: edff51e5
Author: Joe Darcy
Committer: Erik Joelsson
URL:
https://git.openjdk.org/jdk/commit/edff51e5fdb5282830ecfb3792a88c7b28ca6
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 44 additional commits since the
last revis
On Fri, 27 May 2022 22:59:47 GMT, Raffaello Giulietti
wrote:
>> BigDecimal(String) currently fails to accept some strings produced by
>> BigDecimal.toString(). This PR removes this limitation.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit
On Tue, 24 May 2022 12:58:45 GMT, Raffaello Giulietti
wrote:
>> Extend the range of Random.doubles(double, double) and similar methods.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8202449: overflow handling in
On Wed, 25 May 2022 00:19:41 GMT, Joe Darcy wrote:
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
This pull request has now been integrated.
Changeset:
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
On Thu, 2 Jun 2022 08:22:11 GMT, Raffaello Giulietti
wrote:
>> src/java.base/share/classes/java/lang/Math.java line 823:
>>
>>> 821: * @apiNote
>>> 822: * This method corresponds to the convertTowardPositive operation
>>> 823: * defined in IEEE 754.
>>
>> Probably what is meant
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increment
On Sun, 5 Jun 2022 21:19:37 GMT, Joe Darcy wrote:
> Various code blocks in Float and Double would be better as snippets.
This pull request has now been integrated.
Changeset: 0e06bf3b
Author: Joe Darcy
URL:
https://git.openjdk.java.net/jdk/com
On Mon, 6 Jun 2022 05:29:24 GMT, Alan Bateman wrote:
> One other thing you could do is link Pattern.matches in the snippet to the
> matches method.
Suggestion made in subsequent push; thanks.
> src/java.base/share/classes/java/lang/Double.java line 683:
>
>> 681: *
> Various code blocks in Float and Double would be better as snippets.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Use idiom for shorter lines
- Respond to review feedback.
-
Changes:
- all: ht
Various code blocks in Float and Double would be better as snippets.
-
Commit messages:
- JDK-8287838: Update Float and Double to use snippets
Changes: https://git.openjdk.java.net/jdk/pull/9034/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=9034=00
Issue:
On Thu, 2 Jun 2022 11:25:36 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>>
>> This is a non-final API that provides a gentle on-ramp to structure a task
>> as a family of concurrent subtasks, and to coordinate the subtasks as a unit.
>
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 40 additional commits since the
last revis
On Wed, 1 Jun 2022 10:37:23 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 38 additional commits since the
last revis
On Wed, 25 May 2022 08:56:27 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contai
On Wed, 1 Jun 2022 02:05:40 GMT, Joe Darcy wrote:
>> Generally add apiNote's to map from Java library methods to particular IEEE
>> 754 operations. For now, I only added such notes to java.lang.Math and not
>> java.lang.StrictMath.
>
> Joe Darcy has updated the pull r
> Generally add apiNote's to map from Java library methods to particular IEEE
> 754 operations. For now, I only added such notes to java.lang.Math and not
> java.lang.StrictMath.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The increment
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 36 additional commits since the
last revis
On Fri, 27 May 2022 21:53:38 GMT, Roger Riggs wrote:
> As for retaining SUPER, both SUPER and IDENTITY have location class and
> according to the BasicAccessFlagTest, the bit patterns should be disjoint
If the defined set of class locations, considered over time, have non-disjoint
On Thu, 26 May 2022 18:02:14 GMT, Raffaello Giulietti
wrote:
> BigDecimal(String) currently fails to accept some strings produced by
> BigDecimal.toString(). This PR removes this limitation.
test/jdk/java/math/BigDecimal/StringConstructor.java line 69:
> 67:
On Wed, 18 May 2022 11:45:46 GMT, Anthony Vanelverdinghe
wrote:
> The change is trivial, but I'll need help from someone to create a JBS issue
> & sponsor this PR.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8766
On Tue, 24 May 2022 15:15:43 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>>
>> This is a non-final API that provides a gentle on-ramp to structure a task
>> as a family of concurrent subtasks, and to coordinate the subtasks as a unit.
On Wed, 25 May 2022 19:22:51 GMT, Roger Riggs wrote:
> AccessFlags.SUPER can/should be removed; it is unused and will be redefined
> in the [Value Objects JEP](https://openjdk.java.net/jeps/8277163). It will be
> a cleaner transition if there is no opportunity to create a dependency on the
>
On Thu, 26 May 2022 22:38:12 GMT, David Holmes wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/jdk/internal/org/objectwe
> Time to start getting ready for JDK 20...
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8236/files
- new: ht
On Thu, 26 May 2022 22:40:59 GMT, Kevin Rushforth wrote:
> You also need to change the JBS version from 19 to 20 in
> [`.jcheck/conf`](https://github.com/openjdk/jdk/blob/6a33974a6b8a629744c6d76c3b4fa1f772e52ac8/.jcheck/conf#L4):
Acknowledged; will fix in the next push. Thanks.
-
Time to start getting ready for JDK 20...
-
Commit messages:
- Update symbol information for JDK 19 b24.
- Merge branch 'master' into JDK-8284858
- Merge branch 'master' into JDK-8284858
- Merge branch 'master' into JDK-8284858
- Merge branch 'master' into JDK-8284858
- Merge
On Thu, 14 Apr 2022 05:09:14 GMT, Joe Darcy wrote:
> Time to start getting ready for JDK 20...
The expected kinds of updates to start up JDK 20.
-
PR: https://git.openjdk.java.net/jdk/pull/8236
On Fri, 20 May 2022 22:18:42 GMT, liach wrote:
>> Simplify opcode handling, use `final` in `PrimitiveTypeInfo`, and replace
>> the hash map with a simple lookup, similar to what's done in
>> [JDK-8284880](https://bugs.openjdk.java.net/browse/JDK-8284880) (#8242)
>
> liach has updated the pull
On Tue, 3 May 2022 21:35:48 GMT, Joe Darcy wrote:
>> This is an early review of changes to better model JVM access flags, that is
>> "modifiers" like public, protected, etc. but explicitly at a VM level.
>>
>> Language level modifiers and JVM leve
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
Generally add apiNote's to map from Java library methods to particular IEEE 754
operations. For now, I only added such notes to java.lang.Math and not
java.lang.StrictMath.
-
Commit messages:
- Add floor and ceil.
- JDK-8273346: Examine use of "rounding mode" and "rounding
On Tue, 24 May 2022 09:26:44 GMT, Maurizio Cimadamore
wrote:
> This patch tweaks the foreign API to use the newly added
> `WrongThreadException` instead of `IllegalStateException` to report
> confinement errors.
Marked as reviewed by darcy (Reviewer).
-
PR:
On Thu, 19 May 2022 13:05:54 GMT, Alan Bateman wrote:
> This is the implementation of JEP 428: Structured Concurrency (Incubator).
>
> This is a non-final API that provides a gentle on-ramp to structure a task as
> a family of concurrent subtasks, and to coordinate the subtasks as a unit.
On Tue, 10 May 2022 13:47:35 GMT, Raffaello Giulietti
wrote:
>> Add a family of "safe" cast methods.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8279986: methods Math::asXExact for safely checked primitive
On Wed, 18 May 2022 14:56:47 GMT, Christian Stein wrote:
> This PR adds an optional description accessor on `ToolProvider` interface.
>
> This PR also adds short description for each of the listed tool:
> - `jar`
> - `javac`
> - `javadoc`
> - `javap` and `jdeps`
> - `jlink` and `jmod`
> -
On Sun, 15 May 2022 18:36:07 GMT, Joe Darcy wrote:
> Make the javadoc in the InputStream and OutputStream subclasses in core libs
> DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
> client libs will be done another a separate bug.) When the time comes, will
On Tue, 17 May 2022 11:15:19 GMT, Alan Bateman wrote:
> This is a test fix. ThreadAPI.testGetStackTrace3 tests Thread::getStackTrace
> on a thread doing a selection operation. The test is not reliable as it
> expects to see the "select" method in the stack trace after waiting 200ms.
> The
On Mon, 16 May 2022 17:53:17 GMT, Alan Bateman wrote:
> thanks for the updates.
Updated the CSR to match this version.
-
PR: https://git.openjdk.java.net/jdk/pull/8717
On Mon, 16 May 2022 21:29:22 GMT, Brian Burkhalter wrote:
> Add constant `java.math.BigDecimal.TWO`.
Looks fine.
-
Marked as reviewed by darcy (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8735
[JDK-8286200.
>
> Please also review the CSR to cover the introduction of implspec and implNote
> tags: https://bugs.openjdk.java.net/browse/JDK-8286784
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Add @Override's request
On Sun, 15 May 2022 21:16:53 GMT, Pavel Rappo wrote:
> 1. One the one hand, it's not clear to me what criterion was used for adding
> `@Override` annotations. On the other hand, the more `@Override` annotations
> a codebase has, the better.
>
> 2. Have you compared the resulting
[JDK-8286200.
>
> Please also review the CSR to cover the introduction of implspec and implNote
> tags: https://bugs.openjdk.java.net/browse/JDK-8286784
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Update copyrig
[JDK-8286200.
>
> Please also review the CSR to cover the introduction of implspec and implNote
> tags: https://bugs.openjdk.java.net/browse/JDK-8286784
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The pull request now contains two commits:
-
On Mon, 16 May 2022 15:54:25 GMT, Raffaello Giulietti
wrote:
>> Please review these simple changes in jdk.internal.math.[Double|Float]Consts
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8286810: Use public
On Fri, 13 May 2022 21:17:22 GMT, Joe Darcy wrote:
> Update reference to the latest "Effective Java" version and switch to cite
> tags.
This pull request has now been integrated.
Changeset: 4bc7b7df
Author:Joe Darcy
URL:
https://git.openjdk.jav
Make the javadoc in the InputStream and OutputStream subclasses in core libs
DRY-er by use of inheritDoc. (Any analagous changes to AudioInputStream in
client libs will be done another a separate bug.) When the time comes, will do
any necessary merging for the changes in[JDK-8286200.
Please
On Sat, 14 May 2022 00:30:00 GMT, Tim Prinzing wrote:
> The Class::forName behavior change to match JNI FindClass is a compatible
> change and seems pretty attractive as it would be expected that
> Class::forName would give the same behavior as FindClass which uses the
> system classloader.
Update reference to the latest "Effective Java" version and switch to cite tags.
-
Commit messages:
- JDK-8286760: Update citation of "Effective Java" second edition to third
edition
Changes: https://git.openjdk.java.net/jdk/pull/8707/files
Webrev:
On Wed, 11 May 2022 20:40:30 GMT, Joe Darcy wrote:
> While doing a CSR review of another issue, I noticed some cases in
> InputStream and OutputStream what would benefit from being upgraded to
> implSpec and related javadoc tags.
>
> The "A subclass must provi
On Thu, 12 May 2022 20:04:33 GMT, Joe Darcy wrote:
>> While doing a CSR review of another issue, I noticed some cases in
>> InputStream and OutputStream what would benefit from being upgraded to
>> implSpec and related javadoc tags.
>>
>> The "A subc
On Wed, 11 May 2022 22:43:43 GMT, liach wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/io/OutputStream.java line 151
veral abstract methods don't add much value, but I chose to leave them in
> for this request.
>
> Please also review the corresponding CSR:
> https://bugs.openjdk.java.net/browse/JDK-8286605
Joe Darcy has updated the pull request incrementally with one additional commit
since
On Thu, 12 May 2022 12:24:17 GMT, Alan Bateman wrote:
>> While doing a CSR review of another issue, I noticed some cases in
>> InputStream and OutputStream what would benefit from being upgraded to
>> implSpec and related javadoc tags.
>>
>> The "A subclass must provide an implementation of
On Thu, 12 May 2022 00:10:28 GMT, Joe Darcy wrote:
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
This pull request has now been integrated.
Changes
> Noticed by inspection during a CSR review, small refactoring to use a
> message-cause exception constructor when one is available.
>
> Will update the copyright before a push.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revisio
Noticed by inspection during a CSR review, small refactoring to use a
message-cause exception constructor when one is available.
Will update the copyright before a push.
-
Commit messages:
- JDK-8286615: Small refactor to SerializedLambda
Changes:
While doing a CSR review of another issue, I noticed some cases in InputStream
and OutputStream what would benefit from being upgraded to implSpec and related
javadoc tags.
The "A subclass must provide an implementation of this method." statements on
several abstract methods don't add much
On Tue, 10 May 2022 15:50:26 GMT, Raffaello Giulietti
wrote:
> `[Float|Double]ToDecimal` do not have access to `AbstractStringBuilder`, so
> have to fail over `Appendable`, which can throw `IOException` in `append(*)`
> methods.
>
> I have to find another way if this wrapping to make the
On Mon, 9 May 2022 09:26:58 GMT, Raffaello Giulietti
wrote:
>> Add a family of "safe" cast methods.
>
> Raffaello Giulietti has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase.
On Mon, 9 May 2022 12:38:48 GMT, Raffaello Giulietti
wrote:
>> Hello,
>>
>> here's a PR for a patch submitted on March 2020
>> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was
>> a thing.
>>
>> The patch has been edited to adhere to OpenJDK code conventions about
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand
On Mon, 9 May 2022 15:26:20 GMT, Brian Burkhalter wrote:
> Add missing `@since 19` tag.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8598
On Fri, 6 May 2022 23:30:44 GMT, Jonathan Gibbons wrote:
> Please review a small doc fix to update incorrect use of `{@link}` on arrays
> of primitive types.
Looks fine in and of itself, but not sure how it will interact with the
(presumed) integration of JEP 424: "Foreign Function & Memory
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote:
> Add a new system property, java.specification.maintenance.version, to return
> the maintenance release number of the Java SE specification being
> implemented. The property is unset, optional in the terminology of
> System.g
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>
> I'll update copyright years before an integration.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes
On Thu, 5 May 2022 09:35:42 GMT, Alan Bateman wrote:
>> This is the implementation of JEP 425: Virtual Threads (Preview).
>>
>> We will refresh this PR periodically to pick up changes and fixes from the
>> loom repo.
>>
>> Most of the new mechanisms in the HotSpot VM are disabled by default
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote:
> Trivial fix to 3rd party copyright notices.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8558
On Mon, 2 May 2022 20:31:18 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>&
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>
> I'll update copyright years before an integration.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes
On Sun, 1 May 2022 17:48:39 GMT, Yasser Bazzi wrote:
>> Hi, could i get a review on this implementation proposed by Stuart Marks, i
>> decided to use the
>> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html
>> interface to create the default
On Fri, 29 Apr 2022 20:34:21 GMT, Mandy Chung wrote:
> I took a closer look at the proposed APIs. I think it's in a good state to
> target for 19. I skimmed on the existing JDK usage of `getModifiers` other
> than a trivial test e.g. is public, final, etc and the proposed API works
> well
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
> Please review the addition of @-see links from classes that mention the IEEE
> 754 floating-point standard to an IEEE page about the standard. The URL in
> the initial version of the PR is the top search result on the IEEE
On Tue, 3 May 2022 08:25:30 GMT, Raffaello Giulietti
wrote:
> What about the DOI URL? Probably even more stable.
> https://doi.org/10.1109/IEEESTD.2019.8766229
Hmm. I'd rather use the IEEE URL for now; if that turns out to problematic, we
can switch to the DOI one.
-
PR:
nother candidate page to use is
>
> https://ieeexplore.ieee.org/servlet/opac?punumber=8766227
>
> which is (apparently) a stable citation page for the standard.
>
> These links may be upgraded to the the forthcoming @-spec facility in the
> future. ( JDK-6251738).
Joe Darcy ha
Hello,
While informative, I think some kind of official link to the IEEE 754
document is more appropriate in this context.
-Joe
On 5/3/2022 2:59 AM, Rony G. Flatscher wrote:
On 03.05.2022 10:28, Raffaello Giulietti wrote:
On Mon, 2 May 2022 22:55:43 GMT, Joe Darcy wrote:
Please review
uced.
>
> This PR in its current form is meant to give the overall shape of the API. It
> is missing implementations to map from, say, method modifiers to access
> flags, taking into account overlaps in bit positions.
>
> The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be fill
On Mon, 2 May 2022 20:30:53 GMT, Joe Darcy wrote:
>> @irisclark does raise an interesting point: If, say, MR 2 doesn’t require a
>> change to the RI then the MR 1 RI is also the MR 2 RI, but its
>> `java.specification.maintenance.version` property will report that it
Please review the addition of @-see links from classes that mention the IEEE
754 floating-point standard to an IEEE page about the standard. The URL in the
initial version of the PR is the top search result on the IEEE home page for
"754 standard".
Another candidate page to use is
On Fri, 29 Apr 2022 17:11:55 GMT, Mark Reinhold wrote:
>> src/java.base/share/classes/java/lang/System.java line 743:
>>
>>> 741: * have the value {@code "1"}; after a second maintenance
>>> 742: * release, this property will have the value {@code "2"},
>>> 743: *
>
> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>
> I'll update copyright years before an integration.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes
1 - 100 of 2101 matches
Mail list logo
