Re: [PATCH] Add get_current_dir_name(3)

2012-01-01 Thread Christopher Faylor
On Sun, Jan 01, 2012 at 01:13:25AM -0600, Yaakov (Cygwin/X) wrote: >On Sun, 2012-01-01 at 01:46 -0500, Christopher Faylor wrote: >> On Sat, Dec 31, 2011 at 08:45:07PM -0600, Yaakov (Cygwin/X) wrote: >> >+extern "C" char * >> >+get_current_dir_name (void) &

Re: [PATCH] Add get_current_dir_name(3)

2011-12-31 Thread Christopher Faylor
On Sat, Dec 31, 2011 at 08:45:07PM -0600, Yaakov (Cygwin/X) wrote: >This patchset adds get_current_dir_name(3), a GNU extension: >[snip] >diff -u -p -r1.644 path.cc >--- path.cc24 Dec 2011 13:11:34 - 1.644 >+++ path.cc27 Dec 2011 11:28:06 - >@@ -2855,6 +2855,27 @@ getwd (char *

Re: [PATCH] Add getpt(3)

2011-12-30 Thread Christopher Faylor
On Fri, Dec 30, 2011 at 12:44:57AM -0600, Yaakov (Cygwin/X) wrote: >getpt(3) is a GNU extension which predates posix_openpt(3): > >http://www.kernel.org/doc/man-pages/online/pages/man3/getpt.3.html > >The code itself is quite simple, but let me preempt some questions: > >1) Yes, portable code shoul

Re: [PATCH] Fix cancellation points list

2011-12-29 Thread Christopher Faylor
On Fri, Dec 30, 2011 at 12:25:25AM -0600, Yaakov (Cygwin/X) wrote: >pthread_rwlock_timedrdlock and pthread_rwlock_timedwrlock aren't >implemented yet. Patch attached. > > >Yaakov > >2011-12-30 Yaakov Selkowitz > > * thread.cc: Mark pthread_rwlock_timedrdlock and > pthread_rwlock_ti

Re: Add support for creating native windows symlinks

2011-12-23 Thread Christopher Faylor
On Fri, Dec 23, 2011 at 01:38:07PM -0800, Russell Davis wrote: >Sigh... I've already addressed all of these ponts (there are simple >ways to handle to all of them). I'm done fighting this battle. Actually, I don't think you did answer all of them. But, regardless, to summarize, what you were prop

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-08 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 07:42:48AM +0100, Christian Franke wrote: >Christopher Faylor wrote: >> On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: >>> Christopher Faylor wrote: >>>> ... >>>> /usr/local/src/trunk/objdir.withada/

Re: Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Dec 08, 2011 at 12:17:11AM +0100, Christian Franke wrote: >Christopher Faylor wrote: >> >> I guess this is why there was a __INSIDE_CYGWIN__ test. >> >> Christian, could you submit a new patch to rectify this problem? > >OK, will try soon. > > >&g

Problem with: Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-12-07 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:17:49PM -0400, Christopher Faylor wrote: >On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: >>Christopher Faylor wrote: >>> On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: >>>> ... >>>> O

Re: ptsname_r

2011-11-10 Thread Christopher Faylor
On Tue, Nov 08, 2011 at 01:04:18AM -0500, Christopher Faylor wrote: >On Mon, Nov 07, 2011 at 01:59:40PM -0700, Eric Blake wrote: >>On 11/07/2011 01:46 PM, Eric Blake wrote: >>>> Thanks. Also, even with your patches of today, ptsname() is still not >>>> thread-safe

Re: ptsname_r

2011-11-07 Thread Christopher Faylor
On Mon, Nov 07, 2011 at 01:59:40PM -0700, Eric Blake wrote: >On 11/07/2011 01:46 PM, Eric Blake wrote: >>> Thanks. Also, even with your patches of today, ptsname() is still not >>> thread-safe; should we be sticking that in a thread-local buffer rather >>> than in static storage, similar to how oth

Re: [PATCH] Prevent restart of crashing non-Cygwin exe

2011-11-05 Thread Christopher Faylor
On Sat, Nov 05, 2011 at 06:00:25PM +0100, Christian Franke wrote: >Christopher Faylor wrote: >> On Thu, Nov 03, 2011 at 01:07:20PM +0100, Corinna Vinschen wrote: >>> On Nov 2 20:53, Christian Franke wrote: >>>> On Jun 24, Corinna Vinschen wrote: >>>>&

Re: Extend faq.using to discuss fork failures

2011-11-04 Thread Christopher Faylor
On Fri, Nov 04, 2011 at 12:22:13PM -0400, Christopher Faylor wrote: >On Fri, Nov 04, 2011 at 01:34:09PM +, Jon TURNEY wrote: >>On 03/11/2011 21:05, Christopher Faylor wrote: >>> I would still prefer eschewing actively negative words like "hostile" and >>

Re: Extend faq.using to discuss fork failures

2011-11-04 Thread Christopher Faylor
On Fri, Nov 04, 2011 at 01:34:09PM +, Jon TURNEY wrote: >On 03/11/2011 21:05, Christopher Faylor wrote: >> I would still prefer eschewing actively negative words like "hostile" and >> just >> neutrally stating that Windows does not use a fork/exec model and doe

Re: [PATCH] Prevent restart of crashing non-Cygwin exe

2011-11-03 Thread Christopher Faylor
On Thu, Nov 03, 2011 at 01:07:20PM +0100, Corinna Vinschen wrote: >On Nov 2 20:53, Christian Franke wrote: >> On Jun 24, Corinna Vinschen wrote: >> >Hi Christian, >> > >> >On Jun 23 19:52, Christian Franke wrote: >> >>If a non-Cygwin .exe started from a Cygwin shell window segfaults, >> >>Cygwin r

Re: Extend faq.using to discuss fork failures

2011-11-03 Thread Christopher Faylor
On Thu, Nov 03, 2011 at 04:35:25PM +, Jon TURNEY wrote: >On 30/08/2011 14:41, Ryan Johnson wrote: >> That sounds reasonable, though I suspect we'd want want to keep the >> concluding >> bits in the FAQ as well. Unfortunately, summertime free time has come to an >> end so I don't know when I'll

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 06:12:35PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: >>> ... >>> OK, __INSIDE_CYGWIN__ is not needed here in practice (but possibly in >>> theory

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-06 Thread Christopher Faylor
On Thu, Oct 06, 2011 at 01:03:41PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: >>> Christopher Faylor wrote: >>>> On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: >&

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 11:17:58PM +0200, Christian Franke wrote: >Christopher Faylor wrote: >> On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: >>> ... >>> diff --git a/winsup/cygwin/include/cygwin/wait.h >>> b/winsup/cygwin/include/cygw

Re: [PATCH] Allow usage of union wait for wait() functions and macros

2011-10-05 Thread Christopher Faylor
On Wed, Oct 05, 2011 at 12:57:44PM +0200, Christian Franke wrote: >The file include/sys/wait.h provides union wait but neither the wait() >functions nor the W*() macros allow to actually use it. Compilation of >cdrkit 1.1.11 fails because the configure check assumes that union wait >is the statu

Re: Fix strace tracing of forked processes when attaching to a process with --pid

2011-09-13 Thread Christopher Faylor
On Tue, Sep 13, 2011 at 01:04:55PM +0100, Jon TURNEY wrote: > >At the moment, --trace-children (enabled by default) only works when the >straced process is started by using strace with a command line. > >This patch uses the undocumented NtSetInformationProcess(ProcessDebugFlags) >call to make --t

Re: [PATCH] Fix strace -T

2011-09-08 Thread Christopher Faylor
On Thu, Sep 08, 2011 at 07:37:29PM +0100, Jon TURNEY wrote: > >strace -T to toggle stracing of a process doesn't seem to work at the moment. >Attached is a patch to make it work again. > >2011-09-08 Jon TURNEY > > * include/sys/strace.h (strace): Add toggle() method > * strace.cc (t

Re: Extend faq.using to discuss fork failures

2011-08-30 Thread Christopher Faylor
On Tue, Aug 30, 2011 at 11:00:20AM +0200, Corinna Vinschen wrote: >Hi Ryan, > >Thanks for the FAQ entry. I had a look now, finally. Two nits: > >On Aug 25 22:08, Ryan Johnson wrote: >> Index: winsup/doc/faq-using.xml >> === >> RCS fi

Re: [PATCH] profile support

2011-08-29 Thread Christopher Faylor
On Tue, Aug 30, 2011 at 05:10:39AM +0900, jojelino wrote: >On 2011-08-23 PM 2:40, Christopher Faylor wrote: >> On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: >>> Index: winsup/cygwin/Makefile.in >>> ===

Re: Overflow cygthreads (those which use simplestub) don't set notify_detached event which may cause timer_delete to hung

2011-08-25 Thread Christopher Faylor
On Thu, Aug 25, 2011 at 08:06:08PM +0100, Rafal Zwierz wrote: >* cygthread.cc (cygthread::simplestub): Notify that the thread has >detached also in freerange thread case. Looks good. I'll check this in. Thanks. cgf

Re: [PATCH] profile support

2011-08-22 Thread Christopher Faylor
On Tue, Aug 23, 2011 at 02:05:06PM +0900, jojelino wrote: >Index: winsup/cygwin/Makefile.in >=== >RCS file: /cvs/src/src/winsup/cygwin/Makefile.in,v >retrieving revision 1.248 >diff -u -p -r1.248 Makefile.in >--- winsup/cygwin/Makefile

Re: [PATCH] additions

2011-08-19 Thread Christopher Faylor
On Fri, Aug 19, 2011 at 03:12:58PM -0500, Yaakov (Cygwin/X) wrote: >This patch adds _PATH_MAILDIR and _PATH_SHELLS to , as found on >Linux and *BSD. This will save me a patch to kdeadmin. > > >Yaakov > >2011-08-19 Yaakov Selkowitz > > * include/paths.h (_PATH_MAILDIR): Define. > (_

Re: [PATCH] Add /proc/devices

2011-08-19 Thread Christopher Faylor
On Fri, Aug 19, 2011 at 02:50:24PM -0500, Yaakov (Cygwin/X) wrote: >On Fri, 2011-08-19 at 10:44 -0400, Christopher Faylor wrote: >> On Fri, Aug 19, 2011 at 01:52:53PM +0200, Corinna Vinschen wrote: >> >On Aug 18 20:54, Yaakov (Cygwin/X) wrote: >> >>

Re: [PATCH] Add /proc/devices

2011-08-19 Thread Christopher Faylor
On Fri, Aug 19, 2011 at 01:52:53PM +0200, Corinna Vinschen wrote: >On Aug 18 20:54, Yaakov (Cygwin/X) wrote: >> On Thu, 2011-08-18 at 21:55 +0200, Corinna Vinschen wrote: >> > > 2011-08-18 Yaakov Selkowitz >> > > >> > > * devices.h (fh_devices): Define DEV_MISC_MAJOR, DEV_MEM_MAJOR, >> > > DE

Re: [PATCH] Add /proc/devices

2011-08-18 Thread Christopher Faylor
On Thu, Aug 18, 2011 at 09:55:37PM +0200, Corinna Vinschen wrote: >On Aug 18 13:50, Yaakov (Cygwin/X) wrote: >> On Thu, 2011-08-04 at 00:20 -0500, Yaakov (Cygwin/X) wrote: >> > This patchset implements /proc/devices[1]: >> > >> > The question is how to handle /dev/tty and /dev/console as the >> >

Re: [Patch] gethostby_helper

2011-08-16 Thread Christopher Faylor
On Tue, Aug 16, 2011 at 07:38:26PM -0400, Pierre A. Humblet wrote: >This patch has already been already applied. >Diff in attachment and also below. > >Pierre > >2011-08-16 Pierre Humblet > > * net.cc (gethostby_helper): Remove DEBUGGING code from and > streamline the second pass.

Re: [PATCH] workaround for sigproc_init

2011-07-31 Thread Christopher Faylor
On Sun, Jul 31, 2011 at 10:26:23AM +0200, Corinna Vinschen wrote: >On Jul 30 17:04, Christopher Faylor wrote: >> On Fri, Jul 29, 2011 at 08:41:10PM +0900, jojelino wrote: >> >As sigproc_init is called during dll initialization, wait_sig thread is >> >not created as soon

Re: [PATCH] you can use this patch to profile cygwin

2011-07-31 Thread Christopher Faylor
On Sun, Jul 31, 2011 at 06:16:56PM +0900, jojelino wrote: >On 2011-07-31 PM 5:26, Corinna Vinschen wrote: >> Erm, I tested on 32 bit. The slowdown occured on all platforms, not >> only 64 bit. 64 bit is still only half as fast in the date loop for >> reason or reasons unknown. >> >> >> Corinna >>

Re: [PATCH] workaround for sigproc_init

2011-07-30 Thread Christopher Faylor
On Fri, Jul 29, 2011 at 08:41:10PM +0900, jojelino wrote: >As sigproc_init is called during dll initialization, wait_sig thread is >not created as soon as possible.(this is known in msdn createthread >reference. http://msdn.microsoft.com/en-us/library/ms682453(v=vs.85).aspx) >And then wait_sig st

Re: [PATCH] workaround for sigproc_init

2011-07-30 Thread Christopher Faylor
On Fri, Jul 29, 2011 at 08:41:10PM +0900, jojelino wrote: >As sigproc_init is called during dll initialization, wait_sig thread is >not created as soon as possible.(this is known in msdn createthread >reference. http://msdn.microsoft.com/en-us/library/ms682453(v=vs.85).aspx) >And then wait_sig st

Re: [PATCH] clock_nanosleep(2)

2011-07-20 Thread Christopher Faylor
On Wed, Jul 20, 2011 at 09:56:54AM +0200, Corinna Vinschen wrote: >I haven't much time right now. If cgf doesn't beat me to it, I'll >review the function later. I have a couple of PriA problems to look into at work so I don't have much time either. cgf

Re: [PATCH] add getconf(1)

2011-07-19 Thread Christopher Faylor
On Tue, Jul 19, 2011 at 09:43:43AM +0200, Corinna Vinschen wrote: >On Jul 18 21:20, Yaakov (Cygwin/X) wrote: >> This patch adds getconf(1) as required by POSIX: > >This looks good. I'm just wondering... on one hand the code seems to >have nothing Cygwin-specifc and could be packed as an external p

Re: [PATCH] update sysconf, confstr, limits

2011-07-18 Thread Christopher Faylor
On Mon, Jul 18, 2011 at 05:26:51PM -0500, Yaakov (Cygwin/X) wrote: >This patch adds return values for recent additions to sysconf() and >confstr(), and adds a couple of missing defines required by >POSIX. > >This patch, plus the one just posted to newlib@, are required for my >next patch, a getcon

Re: [PATCH] fix for sigsegv in gcc 4.6

2011-07-14 Thread Christopher Faylor
On Wed, Jul 13, 2011 at 04:40:21AM +0900, jojelino wrote: >i think it's about 5 month between preceeding one. >missing WINAPI(__stdcall) which should had been added for function >pointer type is now cause of SIGSEGV. hence it is added. >this changes applies to winsup/cygwin/environ,autoload.cc >w

Re: pthread_sigmask bug

2011-07-09 Thread Christopher Faylor
On Sat, Jul 09, 2011 at 07:19:35AM -0600, Eric Blake wrote: >On 07/09/2011 12:58 AM, Corinna Vinschen wrote: >> On Jul 8 17:16, Eric Blake wrote: >>> The current implementation of pthread_sigmask violates POSIX: >> >> PTC? > > winsup/cygwin/ChangeLog |6 ++ > winsup/cygwin/signal.cc | 10

Re: do some adjustment

2011-06-06 Thread Christopher Faylor
On Mon, Jun 06, 2011 at 06:27:25PM +0800, Chiheng Xu wrote: > * dcrt0.cc (dll_crt0_1): remove call to fork_init(). > * fork.cc (fork_init): remove. > * globals.cc (fork_init): add user_data global variable. > * perprocess.h (fork_init): change user_data from macro to variabl

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-30 Thread Christopher Faylor
On Mon, May 30, 2011 at 02:53:51AM -0400, Christopher Faylor wrote: >Actually, I checked in patch 2/5. That completes the set, I think. Nope. I still have to do 4/5. I WILL do that when after sleeping first. cgf

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-29 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 09:45:09AM -0700, Tor Perkins wrote: >2011-03-28 Tor Perkins > > * fhandler_termios.cc (fhandler_termios::bg_check): Do not return EIO > when a process group has no leader as this is allowed and does not imply > an orphaned process group. Add a test for orphaned proce

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Mon, May 30, 2011 at 02:24:49AM -0400, Christopher Faylor wrote: >On Sun, May 29, 2011 at 12:27:45PM -0400, Christopher Faylor wrote: >>On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >>>So, I defined this small function: >>> >>>static void b

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sun, May 29, 2011 at 12:27:45PM -0400, Christopher Faylor wrote: >On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >>So, I defined this small function: >> >>static void break_cmalloc(int depth, int maxdepth) { >> void* x = cmalloc (HEAP_2_DLL, 32);

Re: Bug in cmalloc? Was: Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sun, May 29, 2011 at 01:51:35AM -0400, Ryan Johnson wrote: >So, I defined this small function: > >static void break_cmalloc(int depth, int maxdepth) { > void* x = cmalloc (HEAP_2_DLL, 32); > cfree(x); > if (depth < maxdepth) > break_cmalloc(depth+1, maxdepth); >} > >and calle

Re: Problems with: Improvements to fork handling (2/5)

2011-05-29 Thread Christopher Faylor
On Sat, May 28, 2011 at 09:37:49PM -0700, Daniel Colascione wrote: >On 5/28/11 7:35 PM, Ryan Johnson wrote: >> On 28/05/2011 8:23 PM, Christopher Faylor wrote: >>> On Sat, May 28, 2011 at 06:40:30PM -0400, Ryan Johnson wrote: >>>> On 28/05/2011 4:50 PM, Christopher F

Re: Problems with: Improvements to fork handling (2/5)

2011-05-28 Thread Christopher Faylor
On Sat, May 28, 2011 at 06:40:30PM -0400, Ryan Johnson wrote: >On 28/05/2011 4:50 PM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >>> This patch has the parent sort its dll list topologically by >>> dependencies. Pre

Re: Improvements to fork handling (3/5)

2011-05-28 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:32:09PM -0400, Ryan Johnson wrote: >This patch fixes a bug in the reserve_at function which caused it to >sometimes reserve space needed by the dll it was supposed to help land. >This happens when the dll tries to land in a free region which overlaps >the desired locat

Problems with: Improvements to fork handling (2/5)

2011-05-28 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >This patch has the parent sort its dll list topologically by >dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling >in dependencies automatically, and the latter would then not benefit >from the code which "encour

Re: Improvements to fork handling (2/5)

2011-05-24 Thread Christopher Faylor
On Tue, May 24, 2011 at 12:47:36PM -0400, Ryan Johnson wrote: >The best way to improve performance of this part of fork() would be to >figure out how to force a dll to load in the right place on the first >try. Achieving this admittedly "difficult" task would eliminate multiple >syscalls per dll

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Christopher Faylor
On Mon, May 23, 2011 at 02:52:12PM -0600, Eric Blake wrote: >On 05/23/2011 02:45 PM, Eric Blake wrote: >> On 05/21/2011 07:35 PM, Christopher Faylor wrote: >>> On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >>>> POSIX says that no other function in t

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-23 Thread Christopher Faylor
On Mon, May 23, 2011 at 02:45:43PM -0600, Eric Blake wrote: >Just for the record, I'm having a problem self-building cygwin right >now, from what looks like mingw issues: > >/home/eblake/src/winsup/utils/mingw gcc-4 -B./ -shared >-Wl,--image-base,0x6FBC -Wl,--entry,_DllMainCRTStartup@12 mthr.o

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 04:29:18PM -0400, Christopher Faylor wrote: >...I'd prefer that the testing be done in frok:parent when the >child_copy happens for static and dynamic dlls, maybe by adding a dll >function which first checks that the data/bss can be copied to the same &g

Re: Improvements to fork handling (1/5)

2011-05-22 Thread Christopher Faylor
On Sun, May 22, 2011 at 09:04:40AM -0400, Ryan Johnson wrote: >On 21/05/2011 9:41 PM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: >>> Hi all, >>> >>> This is the first of a series of patches, sent in separate emails

Re: Improvements to fork handling (2/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:37PM -0400, Ryan Johnson wrote: >Hi all, > >This patch has the parent sort its dll list topologically by >dependencies. Previously, attempts to load a DLL_LOAD dll risked pulling >in dependencies automatically, and the latter would then not benefit >from the code wh

Re: Improvements to fork handling (1/5)

2011-05-21 Thread Christopher Faylor
On Wed, May 11, 2011 at 02:31:23PM -0400, Ryan Johnson wrote: >Hi all, > >This is the first of a series of patches, sent in separate emails as >requested. > >The first patch allows a child which failed due to address space >clobbers to report cleanly back to the parent. As a result, DLL_LINK >wh

Re: __xpg_strerror_r should not clobber strerror buffer

2011-05-21 Thread Christopher Faylor
On Sat, May 21, 2011 at 07:26:37PM -0600, Eric Blake wrote: >POSIX says that no other function in the standard should clobber the >strerror buffer. Our strerror_r is a GNU extension, so it can get away >with clobbering the buffer (but if we wanted to fix it, we would have to >separate _my_tls.loca

Re: [PATCH] error.h

2011-05-17 Thread Christopher Faylor
On Tue, May 17, 2011 at 07:20:47PM -0500, Yaakov (Cygwin/X) wrote: >This patch series adds error.h and the error(3) functions, a GNU >extension: > >http://www.kernel.org/doc/man-pages/online/pages/man3/error.3.html > >I implemented this within Cygwin itself instead of newlib, because it is >a GNU e

Re: Improvements to fork handling (1/5)

2011-05-17 Thread Christopher Faylor
On Tue, May 17, 2011 at 07:14:12AM -0400, Ryan Johnson wrote: >Any feedback on these patches? I'll get to them eventually but I have some other Cygwin stuff which is occupying my attention currently. cgf

Re: Improvements to fork handling

2011-05-11 Thread Christopher Faylor
On Wed, May 11, 2011 at 10:21:14AM -0400, Ryan Johnson wrote: >On 11/05/2011 10:13 AM, Christopher Faylor wrote: >> On Wed, May 11, 2011 at 09:59:53AM +0200, Corinna Vinschen wrote: >>> On May 11 02:18, Ryan Johnson wrote: >>>> Please find attached five patches [...

Re: [PATCH] sysinfo

2011-05-06 Thread Christopher Faylor
On Fri, May 06, 2011 at 12:43:22PM +0200, Corinna Vinschen wrote: >Please check in. When you do that, please add ,2010 to the list of copyright dates in sysconf.cc since the file was changed in 2010. cgf

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-05 Thread Christopher Faylor
On Thu, May 05, 2011 at 08:19:24PM +0200, Corinna Vinschen wrote: >On May 5 19:23, Corinna Vinschen wrote: >> On May 5 13:10, Christopher Faylor wrote: >> > On Mon, Apr 04, 2011 at 12:23:00PM -0700, Tor Perkins wrote: >> > > >> > >> Thanks for the pa

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-05-05 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 12:23:00PM -0700, Tor Perkins wrote: > >> Thanks for the patch and the report. I'll take a look at this in detail >> in the next couple of days. However, unfortunately, I think this is a >> large enough submission that it requires an assignment form. > >Thanks for looking

Re: [PATCH] psignal, psiginfo, sys_siglist

2011-05-04 Thread Christopher Faylor
On Wed, May 04, 2011 at 01:18:26PM +0200, Corinna Vinschen wrote: >On May 4 05:52, Yaakov (Cygwin/X) wrote: >> This patch exports psignal() from newlib (once my corresponding patch is >> accepted) and implements psiginfo() and sys_siglist[]. The first two >> are POSIX.1-2008, the latter is in BSD

Re: initialize local variable wait_return

2011-05-04 Thread Christopher Faylor
On Wed, May 04, 2011 at 05:17:31AM -0500, Yaakov (Cygwin/X) wrote: >On Wed, 2011-05-04 at 02:03 -0400, Christopher Faylor wrote: >> On Wed, May 04, 2011 at 11:11:52AM +0800, Chiheng Xu wrote: >> >2011-05-04 Chiheng Xu >> > >> > * fhandler.cc (fhand

Re: initialize local variable wait_return

2011-05-03 Thread Christopher Faylor
On Wed, May 04, 2011 at 11:11:52AM +0800, Chiheng Xu wrote: >2011-05-04 Chiheng Xu > > * fhandler.cc (fhandler_base_overlapped::wait_overlapped): initialize >local variable wait_return , otherwise, gcc-4.3.4 will not compile it. Sorry but this is the wrong solution to this problem. I rew

Re: [PATCH] pthread_attr_getstack{,addr}, pthread_getattr_np

2011-05-03 Thread Christopher Faylor
On Tue, May 03, 2011 at 09:56:35AM +0200, Corinna Vinschen wrote: >On May 2 16:11, Christopher Faylor wrote: >> On Mon, May 02, 2011 at 10:33:09AM -0500, Yaakov (Cygwin/X) wrote: >> >This implements pthread_attr_getstack(), pthread_attr_getstackaddr, and >> >pthread_get

Re: [PATCH] pthread_attr_getstack{,addr}, pthread_getattr_np

2011-05-02 Thread Christopher Faylor
On Mon, May 02, 2011 at 10:33:09AM -0500, Yaakov (Cygwin/X) wrote: >This implements pthread_attr_getstack(), pthread_attr_getstackaddr, and >pthread_getattr_np(), which I need for webkitgtk. > >In essence, I added a stackaddr member to pthread_attr, which is >accessed (slightly differently) by pthr

Re: [PATCH] pthread_getattr_np, pthread_setschedprio

2011-04-14 Thread Christopher Faylor
On Thu, Apr 14, 2011 at 10:00:32PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-10 at 21:30 -0500, Yaakov (Cygwin/X) wrote: >> This patch adds two pthread functions which appear to be "low-hanging >> fruit". >> >> pthread_setschedprio(3) is a POSIX function[1][2] which changes the >> schedulin

Re: [PATCH] Fix for strace manpage

2011-04-12 Thread Christopher Faylor
On Tue, Apr 12, 2011 at 08:17:51PM +0100, Jon TURNEY wrote: > >'man strace' contains the rather confusing text: > >>-T, --toggle >> toggle tracing in a process already being >> >>-u, --usecs >> toggle printing of microseconds timestamp traced. Requires -

Re: [PATCH] implement /proc/swaps

2011-04-10 Thread Christopher Faylor
On Sun, Apr 10, 2011 at 08:59:56PM -0500, Yaakov (Cygwin/X) wrote: >This patch implements /proc/swaps, as found on Linux[1]: > >$ cat /proc/swaps >Filename TypeSizeUsedPriority >/cygdrive/c/pagefile.sysfile4192440 16376

Re: [PATCH] fix make after clean

2011-04-07 Thread Christopher Faylor
On Wed, Apr 06, 2011 at 07:53:02PM -0500, Yaakov (Cygwin/X) wrote: >On Mon, 2011-04-04 at 10:52 -0400, Christopher Faylor wrote: >> The last time I reported that I was using relative paths in the >> gcc/binutils/winsup directory I was told "Don't do that. It isn't

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-06 Thread Christopher Faylor
On Wed, Apr 06, 2011 at 12:54:42PM +0100, Jon TURNEY wrote: >On 05/04/2011 17:21, Christopher Faylor wrote: >> On Tue, Apr 05, 2011 at 05:03:43PM +0100, Jon TURNEY wrote: >>> On 04/04/2011 15:39, Christopher Faylor wrote: >> I'm trying to imagine a scenario where it

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-05 Thread Christopher Faylor
On Tue, Apr 05, 2011 at 05:03:43PM +0100, Jon TURNEY wrote: >On 04/04/2011 15:39, Christopher Faylor wrote: >> On Mon, Apr 04, 2011 at 01:42:54PM +0100, Jon TURNEY wrote: >>> Attached is an updated version of the patch which fixes the warning >>> identified >&

Re: [PATCH] tcsetpgrp fails unexpectedly

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 09:45:09AM -0700, Tor Perkins wrote: > > >I think I've found two problems in fhandler_termios::bg_check(): > > * Cygwin's tcsetpgrp function will return EIO when the process >group for the calling process has no leader. > > * This appears to be caused by a leaderless p

Re: [PATCH] make compatible with glibc

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 04:42:26PM +0200, Corinna Vinschen wrote: >On Apr 4 07:41, Yaakov (Cygwin/X) wrote: >> * include/cygwin/types.h: Move #include to >> end of header so the latter get the dev_t typedef. >> * include/sys/sysmacros.h (gnu_dev_major, gnu_dev_minor, >> gnu_de

Re: [PATCH] fix make after clean

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 02:13:36AM -0500, Yaakov (Cygwin/X) wrote: >On Mon, 2011-04-04 at 00:56 -0500, Yaakov (Cygwin/X) wrote: >> No, I duplicated this on Linux as well (after I tracked down a cocom >> RPM), but that did make me think of other possibilities. The difference >> seems to be if you p

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-04-04 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:42:54PM +0100, Jon TURNEY wrote: >On 30/03/2011 22:29, Christopher Faylor wrote: >> On Wed, Mar 30, 2011 at 11:15:56PM +0200, Corinna Vinschen wrote: >>> Chris, are you going to take a look into this patch? >> >> yep. > >Attached is a

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:34:27AM -0400, Christopher Faylor wrote: >On Mon, Apr 04, 2011 at 01:07:27AM -0400, Christopher Faylor wrote: >>I *am* building on Linux, though, so maybe that's the difference. > >Nope. It works fine on Windows too. I wonder if maybe you somehow

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Mon, Apr 04, 2011 at 01:07:27AM -0400, Christopher Faylor wrote: >I *am* building on Linux, though, so maybe that's the difference. Nope. It works fine on Windows too. cgf

Re: [PATCH] make compatible with glibc

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 07:11:51PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-03 at 19:55 -0400, Christopher Faylor wrote: >> >+#define __INSIDE_CYGWIN_GNU_DEV__ >> >> I'd prefer a more descriptive name like "__DONT_DEFINE_INLINE_GNU_DEV" > >The

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 07:22:42PM -0500, Yaakov (Cygwin/X) wrote: >On Sun, 2011-04-03 at 19:03 -0400, Christopher Faylor wrote: >> This can't be right. In all of the times that I've run a "make clean", >> I have never needed this. A .o relying on .cc is a gi

Re: [PATCH] fix make after clean

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 05:37:38PM -0500, Yaakov (Cygwin/X) wrote: >If you run make clean in winsup/cygwin followed by make -jX, the build >fails because devices.cc is not found; it was removed by make clean but >nothing forced it to be regenerated in time. > >Patch attached. > > >Yaakov > >2011-0

Re: [PATCH] make compatible with glibc

2011-04-03 Thread Christopher Faylor
On Sun, Apr 03, 2011 at 06:37:25PM -0500, Yaakov (Cygwin/X) wrote: >When building Qt Creator, I encountered a compile error because its code >uses 'major' and 'minor' as variable names. Looking at the current >, which is pulled in automatically by , >makes it obvious why that doesn't work. > >Sinc

Re: [PATCH] implement /proc/sysvipc/*

2011-04-01 Thread Christopher Faylor
On Fri, Apr 01, 2011 at 12:05:56PM +0200, Corinna Vinschen wrote: >Chris, do you think there's anything speaking against rearranging this >so that the FH_FS and FH_NETDRIVE definitions are separate from the >stuff under /proc? Or, hang on, we should change all PROC values, >along these lines: > >

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-03-30 Thread Christopher Faylor
On Wed, Mar 30, 2011 at 11:15:56PM +0200, Corinna Vinschen wrote: >Hi Jon, > >On Mar 15 16:46, Corinna Vinschen wrote: >> On Mar 15 11:04, Christopher Faylor wrote: >> > On Tue, Mar 15, 2011 at 08:53:13AM +0100, Corinna Vinschen wrote: >> > >On Mar 14 22:02, Jon

Re: patch for icmp.h

2011-03-30 Thread Christopher Faylor
On Wed, Mar 30, 2011 at 11:37:31AM -0700, John Paul Morrison wrote: >This patch adds missing icmp types and definitions needs for source >compatibility, and it seems to work for raw icmp sockets. >My only changes is renaming __USE_BSD which is used by Linux. It doesn't >look like cygwin has an eq

Re: [PATCH] Fix return value and errno set by sem_init(), sem_destroy() and sem_close()

2011-03-28 Thread Christopher Faylor
On Mon, Mar 28, 2011 at 11:14:03PM +0100, Jon TURNEY wrote: > >While looking into some mysterious failures of sem_init() in python, I was >somewhat surprised to find the following comment in python/thread_pthread.h: > >> /* >> * As of February 2002, Cygwin thread implementations mistakenly report

Re: [PATCH] Export strchrnul (pending newlib patch)

2011-03-28 Thread Christopher Faylor
On Sun, Mar 27, 2011 at 10:38:16PM -0500, Yaakov (Cygwin/X) wrote: >Here's the Cygwin patch to export strchrnul(3) once accepted in newlib. Cygwin already has an implementation of this named strechr written in assembly language. Maybe we should be exporting that. cgf

Re: [PATCH] Add an additional relocation attempt pass to load_after_fork()

2011-03-15 Thread Christopher Faylor
On Tue, Mar 15, 2011 at 08:53:13AM +0100, Corinna Vinschen wrote: >On Mar 14 22:02, Jon TURNEY wrote: >> On 13/03/2011 15:21, Corinna Vinschen wrote: >> > Thanks for the patch, but afaics you don't have a copyright assignment >> > on file with Red Hat. It's unfortunately required for substantial >

Re: provide __xpg_strerror_r

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 10:37:45AM -0700, Eric Blake wrote: >Pushed, and squashed into minor version 236. I've also updated >new-features.sgml. Thanks Eric. cgf

Re: provide __xpg_strerror_r

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 10:50:54AM +0100, Corinna Vinschen wrote: >On Feb 9 21:15, Christopher Faylor wrote: >> On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >> >+/* Newlib's provides declarations for two strerror_r >> >+ variants, according to

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 11:56:52PM +0900, jojelino wrote: >i am sorry for extra line feed. corrected. >requesting review. >Index: winsup/cygwin/dcrt0.cc >=== >RCS file: /cvs/src/src/winsup/cygwin/dcrt0.cc,v >retrieving revision 1.390

Re: [PATCH] for SIGSEGV, compilation error in gcc 4.6

2011-02-10 Thread Christopher Faylor
On Thu, Feb 10, 2011 at 03:15:15PM +0100, Corinna Vinschen wrote: >On Feb 10 21:47, jojelino wrote: >> On 2011-02-10 19:02, Corinna Vinschen wrote: >> >> >Also, it would be nice if you would add more words to explain what your >> >patch is doing. Just a patch with no explanation is not very invit

Re: [PATCH] pthread_yield

2011-02-09 Thread Christopher Faylor
On Wed, Feb 09, 2011 at 11:49:58PM -0600, Yaakov (Cygwin/X) wrote: >pthread_yield(3) was part of the POSIX.1c drafts but never made it into >the final standard. Nevertheless, it is provided by Linux[1], >FreeBSD[2], OpenBSD[3], AIX[4], and possibly other *NIXes. > >"On Linux, this function is im

Re: provide __xpg_strerror_r

2011-02-09 Thread Christopher Faylor
On Wed, Feb 09, 2011 at 05:20:59PM -0700, Eric Blake wrote: >On 02/06/2011 02:54 AM, Corinna Vinschen wrote: >>> We already provide our own strerror() (it provides a better experience >>> for out-of-range values that the newlib interface), but we're currently >>> using the newlib strerror_r() (in s

Re: [PATCH] Crosscompiling configure fix

2011-02-07 Thread Christopher Faylor
On Mon, Feb 07, 2011 at 12:58:57PM +0100, Corinna Vinschen wrote: >On Feb 5 21:34, Peter Foley wrote: >> I've submitted a fix for a problem I came across while trying to build a >> Linux-hosted Cygwin cross compiler. While bootstrapping Cygwin the autoconf >> scripts in winsup/cygwin and winsup/

Re: provide __xpg_strerror_r

2011-02-05 Thread Christopher Faylor
On Sat, Feb 05, 2011 at 01:04:16PM -0700, Eric Blake wrote: >Our strerror_r is lousy (it doesn't even match glibc's behavior); see my >request to the newlib list. We really should just implement strerror_r in errno.cc. It doesn't make sense to have two different implementations cgf

Re: [PATCH] Fix bogus fsync() error

2011-02-01 Thread Christopher Faylor
On Tue, Feb 01, 2011 at 09:47:15AM +0100, Corinna Vinschen wrote: >On Jan 31 20:44, Christian Franke wrote: >> If used on raw devices like /dev/sda fsync() always fails with >> EBADRQC (54) because FlushFileBuffers() always fails with >> ERROR_INVALID_FUNCTION (1). >> >> The attached patch fixes t

Re: [PATCH] Crosscompiling cygserver fix

2011-01-28 Thread Christopher Faylor
On Fri, Jan 28, 2011 at 05:54:20PM -0500, John Foley Junk Mail wrote: >I've submitted a fix for a problem I came across while trying to build a >Linux-hosted Cygwin cross compiler. Some of the code in winsup/cygwin relies >on winsup/cygserver/libcygserver.a, which is currently only compiled on >Cyg

<    1   2   3   4   5   6   7   8   9   10   >