[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-12-06 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2434#discussion_r239486300 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java --- @@ -53,7 +54,13 @@

[GitHub] activemq-artemis pull request #2372: ARTEMIS-2126 web server can leak

2018-12-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2372 ---

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-06 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r239482834 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public

[GitHub] activemq-artemis pull request #2449: ARTEMIS-2191 Makes PostOfficeImpl::rout...

2018-12-05 Thread franz1981
Github user franz1981 closed the pull request at: https://github.com/apache/activemq-artemis/pull/2449 ---

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-04 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238910671 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-12-04 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r238867691 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@

[GitHub] activemq-artemis pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingP...

2018-12-04 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2451 ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types Change the LegacyLDAPSecuritySettingPlugin to interpret the search results based on the order of the returned

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-04 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238785616 --- Diff: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQDestination.java --- @@ -386,14 +386,27 @@ public

[GitHub] activemq-artemis pull request #2450: ARTEMIS-2190 core JMS client leaks temp...

2018-12-04 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2450 ARTEMIS-2190 core JMS client leaks temp dest names You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2449: ARTEMIS-2191 Makes PostOfficeImpl::rout...

2018-12-04 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2449 ARTEMIS-2191 Makes PostOfficeImpl::route common paths inlineable It allows PostOfficeImpl::route to have a better inlining while dealing with common paths that require to be fast.

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-03 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238422596 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java --- @@ -265,6 +266,126 @@ public

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-03 Thread tabish121
Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238416943 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java --- @@ -265,6 +266,126 @@ public

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-03 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2448#discussion_r238413260 --- Diff: tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/TemporaryDestinationTest.java --- @@ -265,6 +266,126 @@

[GitHub] activemq-artemis pull request #2448: ARTEMIS-2189 allow deleting temp dest w...

2018-12-03 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2448 ARTEMIS-2189 allow deleting temp dest when session is closed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2447: Corrected a spelling mistake of "no" to...

2018-12-02 Thread josh-seidel
GitHub user josh-seidel opened a pull request: https://github.com/apache/activemq-artemis/pull/2447 Corrected a spelling mistake of "no" to "not". Corrected a small mistake of "There's no much difference..." to "There's not much difference..." You can merge this pull request into

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

2018-11-29 Thread jdanekrh
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2441#discussion_r237521038 --- Diff: artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java --- @@

[GitHub] activemq-artemis pull request #2446: ARTEMIS-2188 fix address size leak caus...

2018-11-29 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2446 ARTEMIS-2188 fix address size leak caused by large page message When we write a paged large message, addLiveMessage->incrementDelayDeletionCount-> incrementRefCount->onDurableUp

[GitHub] activemq-artemis pull request #2445: ARTEMIS-2187 remove page from softcache...

2018-11-28 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2445 ARTEMIS-2187 remove page from softcache before consumedpage We found some PageCursorInfo in consumedPage map even if these corresponding page file is deleted. Suppose that there

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-28 Thread spyrkob
Github user spyrkob commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2432#discussion_r237094610 --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java --- @@

[GitHub] activemq-artemis pull request #2444: ARTEMIS-2186 Large message incomplete w...

2018-11-27 Thread wy96f
Github user wy96f commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2444#discussion_r236911890 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java --- @@ -1018,6 +1018,7 @@

[GitHub] activemq-artemis pull request #2444: ARTEMIS-2186 Large message incomplete w...

2018-11-27 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2444#discussion_r236681572 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java --- @@ -1018,6

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-27 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r236646355 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@ public

[GitHub] activemq-artemis pull request #2444: ARTEMIS-2186 Large message incomplete w...

2018-11-26 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2444 ARTEMIS-2186 Large message incomplete when server is crashed When sending large message, the large message file on server side is not synced whereas the journal record or paged message is

[GitHub] activemq-artemis pull request #2443: ARTEMIS-2186 Large message incomplete w...

2018-11-26 Thread wy96f
Github user wy96f closed the pull request at: https://github.com/apache/activemq-artemis/pull/2443 ---

[GitHub] activemq-artemis pull request #2443: ARTEMIS-2186 Large message incomplete w...

2018-11-26 Thread wy96f
GitHub user wy96f opened a pull request: https://github.com/apache/activemq-artemis/pull/2443 ARTEMIS-2186 Large message incomplete when server is crashed When sending large message, the large message file on server side is not synced whereas the journal record or paged message is

[GitHub] activemq-artemis pull request #2442: ARTEMIS-2139 Fix setJMSReplyTo for 1.x ...

2018-11-26 Thread franz1981
GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/2442 ARTEMIS-2139 Fix setJMSReplyTo for 1.x clients with enable1xPrefixes You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...

2018-11-25 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2441 Assorted Error Prone-related NO-JIRA fixes to tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis

[GitHub] activemq-artemis pull request #2440: ARTEMIS-2181 Add `static` storage class...

2018-11-25 Thread jdanekrh
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2440 ARTEMIS-2181 Add `static` storage class for an inline function internal to the compile unit You can merge this pull request into a Git repository by running: $ git pull

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-22 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r235842374 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

2018-11-21 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2438#discussion_r235566861 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/BridgeConfiguration.java --- @@ -75,6 +76,8 @@ // The

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

2018-11-21 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2438#discussion_r235527477 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/config/BridgeConfiguration.java --- @@ -75,6 +76,8 @@

[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

2018-11-21 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2439#discussion_r235525451 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java --- @@ -950,6

[GitHub] activemq-artemis pull request #2038: ARTEMIS-1828 CLI option for queue's rou...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2038 ---

[GitHub] activemq-artemis pull request #2439: ARTEMIS-2179 mgmnt method to get cluste...

2018-11-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2439 ARTEMIS-2179 mgmnt method to get cluster-cxn names You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2438: ARTEMIS-2178 routing-type config for co...

2018-11-20 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2438 ARTEMIS-2178 routing-type config for core bridge MULTICAST messages forwarded by a core bridge will not be routed to any ANYCAST queues and vice-versa. Diverts have the ability to

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r235089654 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,11 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234941860 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,11 @@ *

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234926580 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234909113 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,11 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234906424 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@ public

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-20 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234903527 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234767548 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,11 @@ *

[GitHub] activemq-artemis pull request #2437: NO-JIRA doc for divert routing-type

2018-11-19 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2437 NO-JIRA doc for divert routing-type You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis divertDoc

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234697388 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -578,34 +567,41 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234637863 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122 @@ public

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234622813 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234622539 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234622417 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234622321 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -803,139 +799,122

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234546810 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2434#discussion_r234540655 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -3178,138 +3187,7

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234533807 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@ *

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2434#discussion_r234532241 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -3178,138 +3187,7

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-19 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234527890 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234113042 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,11 @@ *

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-15 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r234112554 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@ *

[GitHub] activemq-artemis pull request #2436: NO-JIRA improve logging for test System...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2436 ---

[GitHub] activemq-artemis pull request #2433: ARTEMIS-1938 Update proton-j to 0.30.0 ...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2433 ---

[GitHub] activemq-artemis pull request #2435: NO-JIRA fix QueueControlUsingCoreTest

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2435 ---

[GitHub] activemq-artemis pull request #2436: NO-JIRA improve logging for test System...

2018-11-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2436 NO-JIRA improve logging for test System prop cleanup You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2435: NO-JIRA fix QueueControlUsingCoreTest

2018-11-15 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2435 NO-JIRA fix QueueControlUsingCoreTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-15 Thread spyrkob
Github user spyrkob commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2432#discussion_r233862871 --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java --- @@

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2416 ---

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-15 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2432#discussion_r233860659 --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-11-15 Thread jbertram
Github user jbertram commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2434#discussion_r233854063 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -3178,138 +3187,7 @@ public

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-11-15 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2434#discussion_r233744603 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -3178,138 +3187,7

[GitHub] activemq-artemis pull request #2434: ARTEMIS-1867 FQQN for producers

2018-11-14 Thread jbertram
GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/2434 ARTEMIS-1867 FQQN for producers You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1867-2

[GitHub] activemq-artemis pull request #2433: ARTEMIS-1938 Update proton-j to 0.30.0 ...

2018-11-14 Thread tabish121
GitHub user tabish121 opened a pull request: https://github.com/apache/activemq-artemis/pull/2433 ARTEMIS-1938 Update proton-j to 0.30.0 and Qpid JMS 0.37.0 Update to latest proton-j release and refactor the dispostion code to use the new type enums to better deal with the

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233576260 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7 +982,13 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233559690 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2432#discussion_r233540277 --- Diff: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ---

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233539372 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread ehsavoie
Github user ehsavoie commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233531108 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7 +982,13 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233526079 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@ *

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233520960 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@ *

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233520221 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2432: [ARTEMIS-2176] RA connection properties...

2018-11-14 Thread spyrkob
GitHub user spyrkob opened a pull request: https://github.com/apache/activemq-artemis/pull/2432 [ARTEMIS-2176] RA connection properties are not propagated to XARecov… …eryConfig Possible fix and test for https://issues.apache.org/jira/browse/ARTEMIS-2176 You can

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233518660 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233517904 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233513734 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -564,34 +604,59 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233513078 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -564,34 +604,59 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233512044 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -564,34 +604,59 @@

[GitHub] activemq-artemis pull request #2426: ARTEMIS-2140 queue creation race w/AMQP...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2426 ---

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233497082 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233496401 --- Diff: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java --- @@ -318,6 +320,33 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233496010 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -564,34 +604,59 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233493239 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233493524 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491975 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -1143,20 +1167,17

[GitHub] activemq-artemis pull request #2430: ARTEMIS-2174 Broker reconnect cause OOM...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2430 ---

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491698 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -1133,8 +1158,7 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread franz1981
Github user franz1981 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491522 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@ *

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491363 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -1070,26 +1102,22

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233491147 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -946,119 +994,103

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233490350 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -52,6 +52,62 @@

[GitHub] activemq-artemis pull request #2427: ARTEMIS-2170 Optimized CoreMessage's ch...

2018-11-14 Thread michaelandrepearce
Github user michaelandrepearce commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2427#discussion_r233490193 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java --- @@ -564,34 +604,59 @@

[GitHub] activemq-artemis pull request #2416: [ARTEMIS-2163]: Classloading issue if a...

2018-11-14 Thread clebertsuconic
Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2416#discussion_r233483727 --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java --- @@ -982,7

[GitHub] activemq-artemis pull request #2424: ARTEMIS-2142 Patch Fix ServerJMSMessage...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2424 ---

[GitHub] activemq-artemis pull request #2431: NO-JIRA Prevent maven-source-plugin bei...

2018-11-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/2431 ---

[GitHub] activemq-artemis pull request #2431: NO-JIRA Prevent maven-source-plugin bei...

2018-11-14 Thread sebthom
GitHub user sebthom opened a pull request: https://github.com/apache/activemq-artemis/pull/2431 NO-JIRA Prevent maven-source-plugin being executed twice With the current Maven config, the maven-source-plugin is executed twice, this results in the sources-jars being attached twice

<    1   2   3   4   5   6   7   8   9   10   >