GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1028
correction in doc.
Fixing an assumed typo. I spotted reading the docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
Many thanks Clebert.
Had a brief look over tonight. Seems good. Will spend a bit more time
tomorrow and also take the chance to update my fork.
Sent from my
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic I notice this didn't get merged still. Did I miss
understand and you expected me to make the configuration changes? if so no
worries, just let me know
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic thanks, ill try look into also see if i spot anything.
I assume this is repeatable.
Was using the amqp client, looking at the quiver dependencies
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
Also:
#1:
io.netty.buffer.AdvancedLeakAwareByteBuf.writeBytes(AdvancedLeakAwareByteBuf.java:600)
io.netty.buffer.AbstractByteBuf.readBytes
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic i have re-run with march larger run size, and now able to
reproduce.
So it seems there is a direct memory leak, this occurs with both epoll and
nio
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
i turned on the netty leak detector:
22:55:59,492 SEVERE [io.netty.util.ResourceLeakDetector] LEAK:
ByteBuf.release() was not called before it's garbage-collected. See
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic I though about this but annoyingly theyre named nioBlah as
such just using that would be not directly indicate you're affecting epoll.
Like wise if we were
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
Hi @clebertsuconic i managed to get it running.
Some notes:
I was not able to run your command as is, using the version that comes via
dnf / repo, seems some
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
the only comment is with epoll, i notice the producer was producing faster
than the consumer during the test as such some queue depth occured, with nio
producer and consumer
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic I was thinking this afternoon has 2.0.0 been cut for
tagging? If not then maybe worth trying to get the property change done before
that as a 2.0.0 is a major
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
No haven't touched it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic i just did a complete fresh clone and rebuild of this PR/My
branch which i rebased the other day. It still built ok for me. Should i rebase
again? Maybe some
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1093
@clebertsuconic I have just now rebased and squashed, hope this is what you
were wanting me to do.
---
If your project is set up for it, you can reply to this email and have
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1093
ARTEMIS-994 Support Netty Native Epoll on Linux
The following changes are made to support Epoll.
* Refactored SharedNioEventLoopGroup into renamed SharedEventLoopGroup
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1425
ARTEMIS-1308: Delegate acknowlegde to ClientMessage
ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge
You can merge this pull request into a Git
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
This is def a WIP for a possible solution, but made some progress in IRC
chat. don't think we are there yet entirely.
---
If your project is set up for it, you can reply
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1428
ARTEMIS-1308: Delegate acknowlegde to ClientMessage
ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge
You can merge this pull request into a Git
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
+1 merging, once current tag in flight is done, just quickly to confirm we
agreed we'd immediately re-tag with the console in so we can get end user
feedback asap. @mtaylor you
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1432
ARTEMIS-1313 getAddresses in PostOfficeImpl does not correctly returnâ¦
⦠all addresses
Fix so that getAddresses uses addressInfoMap instead of the mappings so
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1438
NO JIRA: Doc correction
From here, it seems the default is -1 not 0 as originally stated in doc.
https://github.com/apache/activemq-artemis/blob/master/artemis-core
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
Yeah seems that we need to somehow ensure when redelivery or consumer.close
is called to ensure any waiting batched packets are send and confirmed. It
seems some acks are still
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1462
+1, as discussed further bits can be in follow up PR's
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1463
+1 from me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
@clebertsuconic @mtaylor updated screenshot to current PR build. so this
should be good now.
---
If your project is set up for it, you can reply to this email and have your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
Don't merge this yet. Will wait for the console changes to finally merge to
take final screen shots.
---
If your project is set up for it, you can reply to this email
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1457
@clebertsuconic this is to support the original epoll work, we forgot to
document, and obviously the new kqueue bits.
---
If your project is set up for it, you can reply
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1462
Think you should leave out the re-theme for now (this should be separate
PR), lots of CSS issues on position and alignment, and font sizing.
---
If your project is set up
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1459
ARTEMIS-1346 Add initial Management Console Documentation
Added some initial documentation
You can merge this pull request into a Git repository by running:
$ git pull
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1452
Ok so happy we merge this, then, i assume. With he jproton and qpid-jms
bits merged already, i would be keen for this to make it in, before tagging of
2.3.0.
---
If your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1452
@clebertsuconic this is ready.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1449
Hi Guys again,
As @clebertsuconic noted on his PR it seem it was environmental , since the
big restart of jenkins that occured this morning, it seems to have cleared
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276525
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
---
@@ -81,7 +81,7
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1454
@clebertsuconic can someone look at H21 build agent it seems it has a disk
permission issue. TimeUnitsTest is failing and all it is doing is making a file
myfile.txt in a new
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1453
@pgfox can you open a JIRA for this and update the commit message to
include it, e.g.
ARTEMIS- changed log message to state browse/browsing instead of
consume
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276246
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java
---
@@ -115,7 +115,7
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1457
ARTEMIS-1343 Update Confiuring Transports Documentation
Updated to reflect deprecated properties.
Add a new section to cover native transport support (epoll and kqueue
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1461
There is the _properties section (but these are predefined in qpid
(org.apache.qpid.proton.amqp.messaging.Properties). e.g. you cannot add to this
section as far as i can tell
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1461
ARTEMIS-1348 Support LVQ for AMQP
Add support for LVQ, using the same property key as core "_AMQ_LVQ_NAME"
Add test case for AMQP LVQ.
You can merge this pu
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1461
@tabish121
On point 1:
This only is queried (and parsed) if the address is configured for LVQ. I
believe on QPID java broker it is set in the same place
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1461
As i dig through this, it seems the only option if using QPID JMS wrapper
without making that vendor specific (aka that i think should remain agnostic to
artemis), is to use
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1461
Added to test case to check the property in JMS is the consumed message.
Added to test case for it to check the behaviour is identical to Core
protocol
Lastly also I
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1461
So I can confirm the method on interface Message.getLastValueProperty is
only invoked by LastValueQueue.
---
If your project is set up for it, you can reply to this email
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
@clebertsuconic this is to go with the new console, I'm sure there lots
more to add, but thinking it can be an initial with the first release of it.
---
If your project is set
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
Thus why adding this to the Artemis documents
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
@mtaylor Will build your branch and take a screen shot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1459
I redirected/iframed the help to the actual Artemis documents
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1455
@mtaylor it would have been fine if weren't for a bug in their code change
to keep the deprecated method. Would have been easier to spot if they just
removed the method because
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1400
ARTEMIS-128 fix - Unable to configure queues containing "/" in broker.xml
You can merge this pull request into a Git repository by running:
$ git pull https://
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic i believe I've sorted the security, so if secure and admin
role you can login. It be still good to catchup with yourself and @mtaylor on
IRC later today
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1395
don't mean to be a pain, but why don't we use an existing framework,
akka/vert.x? instead of making our own framework we will have to maintain?
---
If your project is set up
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
now includes updated LICENSE file updated for the above licenses not under
ASL, it seems none require any NOTICE update.
---
If your project is set up for it, you can reply
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic @mtaylor I think this is nearing ready for merge. I will
want to quickly catch up with you both maybe IRC on monday?, as need to discuss
something
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
On back of Dan's comment if we can further reduce the size of the war.
Rather than spending the effort in a complex and hard to maintain overlay,
i thought i would see
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic if we can sort authentication, yes. This is what I'd like
to speak to you and @mtaylor on.
---
If your project is set up for it, you can reply to this email
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1400
@mtaylor as discussed in IRC, few comments i would have.
- Address is currently xsd:string already (this is just following suit)
- Duplicate declaration
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1410
Just update, We haven't run full tests, but managed to test this with
original scenario test that this was causing lock up on, for this case it seems
like it no longer locks up
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
You get that if your ide generates overlay. If you just use maven , maven
cleans up, I saw same thing with intellij.
We can add that to the ignores and we should add
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
pushed gitignore and rat exclusion for the build time generated overlays
dir ide's create.
---
If your project is set up for it, you can reply to this email and have your
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1418
NO-JIRA: Update Logo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis LOGO
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
Rebased post 2.2.0 tagging, also updated logo with new logo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic added, also re-skinned slightly so colour/theme match new
logo a little better.
---
If your project is set up for it, you can reply to this email and have your
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1410#discussion_r128417008
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java
---
@@ -19,9 +19,18 @@
import
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1410#discussion_r128416905
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -828,6 +834,11 @@ public
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
addressed:
3) simply removed the feature/tab (isn't required)
4) dashboard is now just a jvm default (no camel)
5) simply removed
9) war is now slimmed down
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
Oh don't merge yet!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
As PR states is WIP , is just to give visibility to all
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
3) section overlaid with references to other products removed.
6) with the reduction of the war and removal of features, this seems to no
longer be generated
2) about
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic i think I've address'ed now 1-9 on the list Dan gave. Only
bit left is adding/updating artemis LICENSE/NOTICE.
Whats the process
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
7 - custom help, with iframe loading the artemis docs (note would be nicer
if we had an alias on the web for
https://activemq.apache.org/artemis/docs/LATEST so we don't have
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
Update on 7) made it use the local user-guide available.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic see i make two commits, one for my work solely (aka setting
up and also the activemq brand plugin) and then another for the artemis-plugin
noting Andy T
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1385
ARTEMIS-1270 Management Console - Hawtio Solution
WIP - Just for review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
re mail thread bits, addressed:
point 1) - url path changed from /hawtio/ to /console/
point 8) fuse properties renamed.
---
If your project is set up for it, you can
Hi Guys,
It's been some time since this discussion thread without seemingly any
movement.
Artemis Project is really suffering from having any kind of management
console. With continued questions and calls from users especially as it's
picking up traction and deployment.
As such could I propose,
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
From here:
http://www.apache.org/legal/resolved.html#category-a
We just have to list the components and the license and point to the
location of the dependency
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
here is list of packaged code/content/jars etc, and their licenses
commons-codec-1.10.jar,ASL
commons-fileupload-1.3.2.jar,ASL
commons-io-2.2.jar,ASL
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1385
@clebertsuconic or anyone can you let me know or point me in the direction
what I need to do re Artemis's license/notice files for each of the license
types. To meet ASF
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
@clebertsuconic @franz1981 i believe i have this PR working except i am
getting one test failure, see below.
https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
@franz1981 i assume it would i thought PR builds merge with master, as such
should pick up, I've forced it to rebuild by doing a whitespace push to see if
its sporadic
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530746
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
@@ -0,0 +1,182
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530890
--- Diff:
artemis-server/src/test/resources/ConfigurationTest-full-config.xml ---
@@ -57,6 +57,10 @@
1234567
37
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530954
--- Diff: docs/user-manual/en/critical-analysis.md ---
@@ -0,0 +1,32 @@
+# Critical Analysis of the broker
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530870
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -477,12 +484,44
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530849
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -477,12 +484,44
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1443
What is the over head of this, latency and throughput?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530423
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -608,6
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530398
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
---
@@ -2064,6 +2072,53
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131530496
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
@@ -0,0 +1,182
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
@franz1981 looks like its sporadic. just done two builds and it didn't
occur again
---
If your project is set up for it, you can reply to this email and have your
reply
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534319
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java
---
@@ -2064,6 +2072,53
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
Have added a test case to ensure perf is at least double when many message,
we expect it to be more as it should no longer block at all and it is, but was
a good way to test
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534288
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
@@ -0,0 +1,182
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534303
--- Diff: docs/user-manual/en/critical-analysis.md ---
@@ -0,0 +1,32 @@
+# Critical Analysis of the broker
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1443#discussion_r131534309
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/critical/CriticalAnalyzerImpl.java
---
@@ -0,0 +1,182
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1428
@jbertram thanks for clarifying my incorrect assumption on how pr build
works.
Have as such took the opportunity to rebase, squash and correct the commit
message
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1447#discussion_r131832623
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -664,7 +664,7 @@ public
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1451
@clebertsuconic failures look related to this PR that was merged
https://github.com/apache/activemq-artemis/pull/1449
---
If your project is set up for it, you can reply
1 - 100 of 1710 matches
Mail list logo
