Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2490#discussion_r245972322
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/amq/QueueConsumerPriorityTest.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r245960681
--- Diff:
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2493
ARTEMIS-2223 when a new consumer is created, no subscription is called.
In the 'MQTTTest.testCleanSession()' test method, when a new consumer is
created, no subscription is
GitHub user CNNJYB opened a pull request:
https://github.com/apache/activemq-artemis/pull/2492
ARTEMIS- why the position remains unchanged if ignored is set to true
I am a bit confused about this, When CursorIterator:next is called during
queue depage, if ignored is set to
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r245879352
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
Github user onlyMIT commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2491#discussion_r245878622
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
---
@@ -117,14
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2491
ARTEMIS-2217 remove state on clean MQTT session disconnect
You can merge this pull request into a Git repository by running:
$ git pull
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2467#discussion_r245777806
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2475
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2490
V2 196
@franz1981 an alternative so we don't have to have a copy of
CopyOnWriteArrayList, it does mean on add or remove consumer we have to invoke
toArray which causes a
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2489
ARTEMIS-2220 Fix PageCursorStressTest::testSimpleCursorWithFilter NPE
FakeQueue is not correctly setting the queue on its PageSubscription,
leading to fail the test due to NPEs when
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245252912
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2481
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245239811
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r245233815
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -120,14 +126,16
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245224854
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r245195927
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -120,6 +128,8 @@ public
Github user wy96f commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245183888
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public boolean
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245095523
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java
---
@@ -1350,7
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245094809
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r245090041
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2484#discussion_r245048241
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java
---
@@ -278,21 +293,26 @@ public
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245030347
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029912
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029854
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029745
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245029528
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245014300
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/*
+
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245013090
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245011975
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245012214
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245010184
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009418
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009864
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008661
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -3080,45 +3053,20 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245009338
--- Diff:
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245008000
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007330
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245007052
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006670
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006519
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java
---
@@ -0,0 +1,34 @@
+/*
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r245006326
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java
---
@@ -21,7 +21,7 @@
import
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244987340
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986539
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244986350
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionCreateConsumerMessage.java
---
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244985399
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ResetableIterator.java
---
@@ -0,0 +1,29 @@
+/*
+
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984864
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -3080,45 +3053,20 @@ private boolean
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244984274
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
---
@@ -2497,45 +2494,36 @@ private void
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244982460
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244980096
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979227
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244979032
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumersImpl.java
---
@@ -0,0 +1,648 @@
+/*
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244978399
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueConsumers.java
---
@@ -0,0 +1,34 @@
+/*
+ *
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244977454
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -727,7
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2488#discussion_r244976790
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/Consumer.java
---
@@ -21,7 +21,7 @@
import
Github user CNNJYB commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244976446
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -309,16
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2488
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in QueueImpl to its own logical
class, to be able to
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2487
---
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2487
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in queueimpl to its own logical
class, to be able to
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2486
---
Github user michaelandrepearce closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2486
---
GitHub user michaelandrepearce reopened a pull request:
https://github.com/apache/activemq-artemis/pull/2486
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in queueimpl to its own logical
class, to be able to
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/2486
ARTEMIS-196 Implement Consumer Priority
Add consumer priority support
Includes refactor of consumer iterating in queueimpl to its own logical
class, to be able to
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244757759
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244756852
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244686021
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244685607
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user CNNJYB commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244657469
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@ -193,7
GitHub user onlyMIT opened a pull request:
https://github.com/apache/activemq-artemis/pull/2485
ARTEMIS-2217 âMQTTSessionStateâ in the âSESSIONS ConcurrentHashMapâ
nâ¦
â¦ever be removed
âMQTTSessionStateâ in the âSESSIONS ConcurrentHashMapâ should be
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470771
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -461,8
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2483#discussion_r244470859
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
---
@@
GitHub user qihongxu opened a pull request:
https://github.com/apache/activemq-artemis/pull/2484
Use a specific executor for pageSyncTimer
Improve paging throughput by using a specific executor for pageSyncTimer
Improving throughput on paging mode is one of our concerns
GitHub user CNNJYB opened a pull request:
https://github.com/apache/activemq-artemis/pull/2483
ARTEMIS-2215 largemessage have been consumed but not deleted
During the backup and live synchronization, the client consumes the
largemessage, then the live crash(the
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r244150563
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -74,6 +74,10 @@
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r244150155
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -363,4 +371,20
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2482#discussion_r244149886
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
---
@@ -74,6 +74,10 @@
GitHub user qihongxu opened a pull request:
https://github.com/apache/activemq-artemis/pull/2482
ARTEMIS-2214 Cache durable in PagedReference
We recently performed a test on artemis broker and found a severe
performance issue.
When paged messages are being consumed,
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2481
ARTEMIS-2213 don't expire critical component in the case of clock back drift
In our production cluster some brokers crashed. There is nothing unusual in
the dump stack. After digging into
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2478#discussion_r243866712
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -335,19 +335,25 @@ public
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2480
ARTEMIS-2212 Avoid using CLQ on ServerConsumerImpl
It would deliver a better performance for the most
common operations eg offer, poll, iterations, size.
You can merge this pull
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2478#discussion_r243843391
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingManagerImpl.java
---
@@ -335,19 +335,25 @@ public
GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/2479
ARTEMIS-2211 Avoid duplicate code for ByteBuffer pooling and alignment
Refactored thread local ByteBuffer pooling for both NIO & MAPPED
seq file factories and used fast branchless
Github user franz1981 commented on the pull request:
https://github.com/apache/activemq-artemis/commit/dfa70680fed37d25aa3a6d0d6a0795e580495b6a#commitcomment-31769915
No need to synchronize it: `stores` is a concurrent hashmap and you can use
the atomic `computeIfAbsent` that use a
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2478
ARTEMIS-2210 PagingStore creation is not properly synchronized
In PagingManagerImpl#getPageStore() the operations on the map 'stores'
are not synchronzed and it's possible that more
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2477
ARTEMIS-2190 move tests
The "jms-tests" module is deprecated and these tests should have never
gone in there. Moving them to the "integration-tests" module.
You can merge this pull
Github user wy96f closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2476
---
GitHub user wy96f opened a pull request:
https://github.com/apache/activemq-artemis/pull/2476
Fix deadlock while getting queue message count during cleanup
ARTEMIS-2123 introduced a deadlock bug.
jstack shows:
Thread 1:
at
Github user ehsavoie commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243354412
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -163,13
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243338608
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243338301
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
Github user ehsavoie commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243331449
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -163,13
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243283678
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@
GitHub user andytaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/2475
ARTEMIS-2144 - tx begin failure in ra doesn't get cleaned up
https://issues.apache.org/jira/browse/ARTEMIS-2144
You can merge this pull request into a Git repository by running:
Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2474#discussion_r243190151
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
---
@@ -163,13
GitHub user ehsavoie opened a pull request:
https://github.com/apache/activemq-artemis/pull/2474
[ARTEMIS-1536]: Incorrect Journal filesize calculation where specified size
is lest that the block size when using AIO.
* If the specified file size is under the fs block size then the
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2473#discussion_r243139995
--- Diff:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
---
@@ -237,28 +236,39 @@ public void
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2473#discussion_r243083234
--- Diff:
artemis-web/src/main/java/org/apache/activemq/artemis/component/WebServerComponent.java
---
@@ -237,28 +236,39 @@ public void
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2470#discussion_r243076837
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
@@ -216,63 +216,63 @@ private static void
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2470#discussion_r243073035
--- Diff:
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/PrintData.java
---
@@ -216,63 +216,63 @@ private
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2464#discussion_r243026861
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerReceiverContext.java
101 - 200 of 7980 matches
Mail list logo
