Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 28, 2019, 5:58 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 23 (patched) > > > > > > nit: unused imports, consider

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- (Updated May 28, 2019, 9:19 p.m.) Review request for atlas, Aadarsh Jajodia,

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/test/java/org/apache/atlas/impala/ImpalaLineageToolIT.java > > Lines 201-205 (patched) > > > > > > Can we also add a unit test which

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 31, 2019, 4:02 a.m.) Review request for atlas, madhan and Sarath

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/#review215608 --- addons/models/1000-Hadoop/1030-hive_model.json Line 727

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 31, 2019, 11:24 p.m.) Review request for atlas, madhan and Sarath

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

> On May 31, 2019, 8:16 p.m., Sarath Subramanian wrote: > > addons/models/1000-Hadoop/1090-impala_model.json > > Lines 193 (patched) > > > > > > we don't need to define a new impala_db_ddl and impala_table_ddl,

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

> On May 24, 2019, 8:14 p.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 561-562 (patched) > > > > > > Maybe use long for both?

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

> On May 31, 2019, 11:48 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/hook/events/BaseImpalaEvent.java > > Lines 633 (patched) > > > > > > impalaDDL => hiveDDL done

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated June 3, 2019, 7:08 p.m.) Review request for atlas, madhan and Sarath

Re: Review Request 70759: ATLAS-3226: Add QueryText for hive_table and hive_db for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70759/ --- (Updated May 30, 2019, 5:06 p.m.) Review request for atlas, madhan and Sarath

Re: Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- (Updated May 29, 2019, 3:29 p.m.) Review request for atlas, Aadarsh Jajodia,

Review Request 70880: ATLAS-3290: Impala Hook should get database name and table name from vertex metadata

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70880/ --- Review request for atlas, madhan and Sarath Subramanian. Repository: atlas

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 2:47 a.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 236 (patched) > > > > > > Add comment for method

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 7:09 p.m., Sridhar K wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/ImpalaHook.java > > Lines 19 (patched) > > > > > > Please package name w.r.t. directories. There are

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 7:27 p.m., Sridhar K wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/BaseImpalaEvent.java > > Lines 107 (patched) > > > > > > getTableNameFromColumn ==>

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 2:35 a.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 2:15 a.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 22, 2019, 5:36 p.m.) Review request for atlas, Fredy Wijaya,

Review Request 70701: ATLAS-3221: Refactor Impala integration code

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70701/ --- Review request for atlas and Sarath Subramanian. Repository: atlas

Review Request 70708: ATLAS-3185: Create process execution for Impala integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70708/ --- Review request for atlas, Aadarsh Jajodia, Madhan Neethiraj, and Sarath

Re: Review Request 70710: ATLAS-3230: Change Impala Hook API Names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70710/ --- (Updated May 24, 2019, 2:49 a.m.) Review request for atlas and Sarath

Review Request 70710: ATLAS-3230: Change Impala Hook API Names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70710/ --- Review request for atlas and Sarath Subramanian. Repository: atlas

Re: Review Request 70710: ATLAS-3230: Change Impala Hook API Names

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70710/ --- (Updated May 24, 2019, 5:25 p.m.) Review request for atlas and Sarath

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 2:47 a.m., Aadarsh Jajodia wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 64 (patched) > > > > > > Replace with > > LOG.info("Importing:

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 11:37 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 48 (patched) > > > > > > we don't need 'args' to be stored as

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 8, 2019, 9:36 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 8, 2019, 7:35 p.m., Xinran Tinney wrote: > > addons/impala-bridge/src/main/resources/import-impala.sh > > Lines 88 (patched) > > > > > > should we remove this since it is printing too much information in

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70619/ --- (Updated May 21, 2019, 10:10 p.m.) Review request for atlas, Fredy Wijaya,

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 6:18 p.m., Sridhar K wrote: > > addons/impala-bridge/pom.xml > > Lines 59 (patched) > > > > > > Can we remove the project version hereand define dependency version > > in root pom.xml file's

Re: Review Request 70619: ATLAS-3080: Integration with Impala Hook API

> On May 21, 2019, 6:18 p.m., Sridhar K wrote: > > addons/impala-bridge-shim/pom.xml > > Lines 41 (patched) > > > > > > Can we remove the project version hereand define dependency version > > in root pom.xml

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 12:54 a.m., Sridhar K wrote: > > addons/impala-bridge/pom.xml > > Lines 65 (patched) > > > > > > Can we please move this version to a variable? done > On May 7, 2019, 12:54 a.m., Sridhar K

Re: Review Request 70505: CDPD-252:parse metadata/Lineage files generated by Impala

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70505/#review214761 ---

Re: Review Request 70505: CDPD-252:parse metadata/Lineage files generated by Impala

> On April 19, 2019, 3:27 p.m., Na Li wrote: > > addons/impala-bridge/src/main/java/org/apache/atlas/impala/bridge/LineageVertex.java > > Lines 27 (patched) > > > > > > can you make the type to be Integer? So it is

Re: Review Request 70505: CDPD-252:parse metadata/Lineage files generated by Impala

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70505/#review214765 ---

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 204 (patched) > > > > > > dependencyType can not

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:41 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/hook/events/CreateImpalaProcess.java > > Lines 193 (patched) > > > > > > consider registering

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageVertex.java > > Lines 39 (patched) > > > > > > make vertexType as enum done - Na

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 4, 2019, 9:23 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 2, 2019, 8:31 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge-shim/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 35 (patched) > > > > > > Shim is not needed for

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 7:38 a.m., Sarath Subramanian wrote: > > addons/impala-bridge-shim/pom.xml > > Lines 28 (patched) > > > > > > shim is not needed; since this will be used as a standalone utility. removed > On

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/ImpalaLineageTool.java > > Lines 54 (patched) > > > > > > It may not be useful to designate a

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 3, 2019, 2:01 a.m., Madhan Neethiraj wrote: > > addons/impala-bridge/src/main/java/org.apache.atlas.impala/model/LineageQuery.java > > Lines 35 (patched) > > > > > > Consider renaming LineageQuery to

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

> On May 7, 2019, 11:37 p.m., Sarath Subramanian wrote: > > addons/impala-bridge/src/main/resources/import-impala.sh > > Lines 60 (patched) > > > > > > why do we hardcode ATLAS lib path here? changed to relative

Re: Review Request 70512: ATLAS-3183: Read Impala lineage record for creating view and send to Atlas

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70512/ --- (Updated May 8, 2019, 7:20 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 70536: ATLAS-3157: Add Integration tests for Hive metastore hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70536/#review214853 ---

Re: Review Request 70536: ATLAS-3157: Add Integration tests for Hive metastore hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70536/#review214855 ---

Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/ --- Review request for atlas, Austin Nobis, Ashutosh Mestry, and Sarath Subramanian.

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 28 (patched) > > > > > > This comment is

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge/src/main/java/org/apache/atlas/ml/governance/MlGovernanceHookTool.java > > Lines 51 (patched) > > > > > > Where or why do we need this? and

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/ --- (Updated Oct. 2, 2019, 11:31 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218238 --- addons/models/1000-Hadoop/-ml_model.json Lines 135 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/#review218237 --- addons/models/1000-Hadoop/-ml_model.json Lines 10 (patched)

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 21, 2019, 4:13 a.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 18, 2019, 11:07 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 27 (patched) > > > > > > Suggest aligning with the CML model deployment statuses for now: > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 21, 2019, 6:51 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 21, 2019, 6:11 p.m., Sarath Subramanian wrote: > > Move the ml model to a new directory in addons/models => > > 4000-MachineLearning > > > > -ml_model.json => 4010-ml_model.json done. Thanks! - Na --- This is an

Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- Review request for atlas, Ashutosh Mestry, Sridhar K, Madhan Neethiraj, and

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 15, 2019, 9:47 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 22, 2019, 8:04 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 6:31 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 269 (patched) > > > > > > I am wondering if we should have a first class entity called "User" > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 22, 2019, 9:58 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 9:08 p.m., Sridhar K wrote: > > addons/models/-Area0/0010-base_model.json > > Lines 203 (patched) > > > > > > Instead of modifying addons/models/-Area0/0010-base_model.json, can > > you

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 23, 2019, 6:29 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 3:27 p.m., Karthik Manamcheri wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 293 (patched) > > > > > > Should this also be an enum? What types are we envisioning?

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 23, 2019, 10:20 p.m., Karthik Manamcheri wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Line 328 (original), 328 (patched) > > > > > > Why do we need this relationship? We can

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 23, 2019, 9:22 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 18, 2019, 11:07 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 27 (patched) > > > > > > Suggest aligning with the CML model deployment statuses for now: > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71619/ --- (Updated Oct. 18, 2019, 2 a.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > > > > > "DataSet" in Atlas has different meaning from the meaning in ML. > > > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 165 (patched) > > > > > > Same comment about metadata: gitCommitId, hyperParameters, > >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:45 p.m., Karthik Manamcheri wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 286 (patched) > > > > > > What is the purpose of "updatedAt"? I removed it. if user wants it, can

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 7:36 p.m., Na Li wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 51 (patched) > > > > > > Those fields are optional. So if some projects cannot provide those > > fields, that is

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 336 (patched) > > > > > > Like model builds, recommend adding an attribute for number of GPU's. done >

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 18 (patched) > > > > > > Can this really be optional? I will drop this attribute, and user

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 16, 2019, 4:28 p.m., Anand Patil wrote: > > addons/models/1000-Hadoop/-ml_model.json > > Lines 10 (patched) > > > > > > Why make project a subtype of dataset? Atlas server has a lot of code that build

Re: Review Request 71619: ATLAS-3464: Define Entities stored in Atlas for ML Governance

> On Oct. 22, 2019, 5:43 p.m., Sridhar K wrote: > > addons/models/4000-MachineLearning/4010-ml_model.json > > Lines 46 (patched) > > > > > > is it different from Name? > > Sridhar K wrote: > We have name

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 35 (patched) > > > > > > How do we know the class

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 3, 2019, 4:55 a.m., radford nguyen wrote: > > addons/ml-bridge/src/main/java/org/apache/atlas/ml/governance/MlGovernanceHookTool.java > > Lines 228 (patched) > > > > > > Apache commons has a built-in

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 3, 2019, 12:10 a.m., Austin Nobis wrote: > > pom.xml > > Lines 766 (patched) > > > > > > I would avoid using lombok if it is not already present in the project. > > Na Li wrote: > I am checking with

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71568/ --- (Updated Oct. 4, 2019, 8:21 p.m.) Review request for atlas, Austin Nobis,

Re: Review Request 71568: ATLAS-3432: Add Machine Learning Governance integration

> On Oct. 2, 2019, 7:56 p.m., Karthik Manamcheri wrote: > > addons/ml-bridge-shim/src/main/java/org/apache/atlas/ml/governance/hooks/GovernanceLineageHook.java > > Lines 28 (patched) > > > > > > This comment is

Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/ --- Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K, and

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72288/#review220154 ---

Re: Review Request 72288: ATLAS-3700: updated attribute-def with an option to append value (instead of overwrite) during partial-updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72288/#review220156 --- Ship it! Ship It! - Na Li On March 31, 2020, 8:13 a.m.,

Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72294/ --- Review request for atlas, Ashutosh Mestry, Karthik Manamcheri, Sridhar K,

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/ --- (Updated March 30, 2020, 11:52 p.m.) Review request for atlas, Ashutosh

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

> On March 30, 2020, 10:14 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 1300 (patched) > > > > > > The following cases are

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/ --- (Updated March 30, 2020, 9:45 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

> On March 30, 2020, 4:46 p.m., Karthik Manamcheri wrote: > > You mention that the desired behavior is that the Map item should be > > appended (instead of overwritten). What do we do for the use-cases where > > the desired behavior is to over-write and not append? Does this change > > allow

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72278/ --- (Updated March 30, 2020, 3:58 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

> On March 30, 2020, 4:46 p.m., Karthik Manamcheri wrote: > > You mention that the desired behavior is that the Map item should be > > appended (instead of overwritten). What do we do for the use-cases where > > the desired behavior is to over-write and not append? Does this change > > allow

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

> On March 30, 2020, 4:59 p.m., Karthik Manamcheri wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 1301 (patched) > > > > > > You can use the .putAll

Re: Review Request 72278: ATLAS-3700: Partial update to Atlas overwrite map entry with different keys

> On March 30, 2020, 4:59 p.m., Karthik Manamcheri wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 1301 (patched) > > > > > > You can use the .putAll