Re: Review Request 75205: Apache Atlas website Import/Export Documentation update : ForType and Additional Information

[Rahul Kurup]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75205/
---

(Updated Sept. 20, 2024, 9:42 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.


Repository: atlas


Description
---

There is some missing information about Import Export functionality that needs 
to be updated in the website:

1. (New page) For Type export as per 
https://issues.apache.org/jira/browse/ATLAS-2422

2. (Updated within respective pages) How import/export affects classifications, 
business metadata and glossary terms that have been assigned to entities.

3. (Update to Incremental Export) Handling zero changes with 
omitZipResponseForEmptyExport flag

This patch aims to update the above information in the website documentation.


Diffs
-

  docs/src/documents/Import-Export/ExportAPI.md 995cee539 
  docs/src/documents/Import-Export/ExportAPIForType.md PRE-CREATION 
  docs/src/documents/Import-Export/IncrementalExport.md 5b28905fe 


Diff: https://reviews.apache.org/r/75205/diff/1/


Testing
---

I have verified that the documentation changes were reflected by using a local 
docz server and have also verified the information by running the commands with 
the mentioned flags and properties.


Thanks,

Rahul Kurup

Re: Review Request 75212: ATLAS-4903 : When migration restarts it results into deletion of edges and vertices.

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75212/#review226940
---


Ship it!




Ship It!

- Jayendra Parab


On Sept. 20, 2024, 5:47 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75212/
> ---
> 
> (Updated Sept. 20, 2024, 5:47 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4903
> https://issues.apache.org/jira/browse/ATLAS-4903
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Here in type hive_process_execution we have  "guid": 
> "a2fc8760-8906-454c-8ad8-23b1fffa7fdb", "typeName": "hive_process"
> 
> show below: 
> "entity": {
> "typeName": "hive_process_execution",
> "attributes": {
> "hostName": "",
> "qualifiedName": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "name": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "queryText": "insert into 
> db_hive_mig_hive.db_hive_mig_hive_tbl_00...2023-10-24T01:53:33.000Z",
> "startTime": 1698112413000,
> "queryPlan": "Not Supported",
> "endTime": 1698112463140,
> "userName": 
> "mailto:hive/quasar-cpvvvn-1.quasar-cpvvvn.root.hwx.s...@qe-infra-ad.cloudera.com";,
> "queryId": "",
> "owner": null,
> "displayName": null,
> "description": null,
> "userDescription": null
> },
> "guid": "b98ef015-6bd9-4343-ad85-24628aa76731",
> "isIncomplete": false,
> "provenanceType": 0,
> "status": "ACTIVE",
> "createTime": 1698112413000,
> "updateTime": 1698112413000,
> "version": 0,
> "relationshipAttributes": {
> "process": {
> "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb",
> "typeName": "hive_process"
> }
> },
> "customAttributes": {
> "__nav_engineType": "\"MR\""
> },
> "businessAttributes": {},
> "proxy": false
> }
> 
> But the  entity with "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb" doesnt 
> have above hive_process_execution in  "processExecutions": [] block
> 
> Hence relationship edge would get created when process_execution  processed 
> but before that when it tries to  process hive_process and finds the 
> relationshipattribute is empty and assu es the edges are unused, further 
> tries to delete the  edges 
> 
> When huge migration data is restarted it is seen that the deleted entities 
> count keeps accumulating due to above issue causing migration to slow down 
> alot and take more time to process data than expected
> 
> This patch only when atlas is in migration mode avoids the code where it can 
> further delete the edges by adding a flag
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  6b395dd17 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
>  f8c9218c6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
>  b73988fd7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
>  7eac8df73 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java e144d3650 
> 
> 
> Diff: https://reviews.apache.org/r/75212/diff/3/
> 
> 
> Testing
> ---
> 
> Migration flag avoids the deletion flow as well as completes migration in 
> expected time span
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 75212: ATLAS-4903 : When migration restarts it results into deletion of edges and vertices.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75212/#review226939
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 20, 2024, 5:47 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75212/
> ---
> 
> (Updated Sept. 20, 2024, 5:47 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4903
> https://issues.apache.org/jira/browse/ATLAS-4903
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Here in type hive_process_execution we have  "guid": 
> "a2fc8760-8906-454c-8ad8-23b1fffa7fdb", "typeName": "hive_process"
> 
> show below: 
> "entity": {
> "typeName": "hive_process_execution",
> "attributes": {
> "hostName": "",
> "qualifiedName": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "name": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "queryText": "insert into 
> db_hive_mig_hive.db_hive_mig_hive_tbl_00...2023-10-24T01:53:33.000Z",
> "startTime": 1698112413000,
> "queryPlan": "Not Supported",
> "endTime": 1698112463140,
> "userName": 
> "mailto:hive/quasar-cpvvvn-1.quasar-cpvvvn.root.hwx.s...@qe-infra-ad.cloudera.com";,
> "queryId": "",
> "owner": null,
> "displayName": null,
> "description": null,
> "userDescription": null
> },
> "guid": "b98ef015-6bd9-4343-ad85-24628aa76731",
> "isIncomplete": false,
> "provenanceType": 0,
> "status": "ACTIVE",
> "createTime": 1698112413000,
> "updateTime": 1698112413000,
> "version": 0,
> "relationshipAttributes": {
> "process": {
> "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb",
> "typeName": "hive_process"
> }
> },
> "customAttributes": {
> "__nav_engineType": "\"MR\""
> },
> "businessAttributes": {},
> "proxy": false
> }
> 
> But the  entity with "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb" doesnt 
> have above hive_process_execution in  "processExecutions": [] block
> 
> Hence relationship edge would get created when process_execution  processed 
> but before that when it tries to  process hive_process and finds the 
> relationshipattribute is empty and assu es the edges are unused, further 
> tries to delete the  edges 
> 
> When huge migration data is restarted it is seen that the deleted entities 
> count keeps accumulating due to above issue causing migration to slow down 
> alot and take more time to process data than expected
> 
> This patch only when atlas is in migration mode avoids the code where it can 
> further delete the edges by adding a flag
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  6b395dd17 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
>  f8c9218c6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
>  b73988fd7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
>  7eac8df73 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java e144d3650 
> 
> 
> Diff: https://reviews.apache.org/r/75212/diff/3/
> 
> 
> Testing
> ---
> 
> Migration flag avoids the deletion flow as well as completes migration in 
> expected time span
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 75212: ATLAS-4903 : When migration restarts it results into deletion of edges and vertices.

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75212/
---

(Updated Sept. 20, 2024, 5:47 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Pinal Shah.


Bugs: ATLAS-4903
https://issues.apache.org/jira/browse/ATLAS-4903


Repository: atlas


Description
---

Here in type hive_process_execution we have  "guid": 
"a2fc8760-8906-454c-8ad8-23b1fffa7fdb", "typeName": "hive_process"

show below: 
"entity": {
"typeName": "hive_process_execution",
"attributes": {
"hostName": "",
"qualifiedName": 
"cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
"name": 
"cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
"queryText": "insert into 
db_hive_mig_hive.db_hive_mig_hive_tbl_00...2023-10-24T01:53:33.000Z",
"startTime": 1698112413000,
"queryPlan": "Not Supported",
"endTime": 1698112463140,
"userName": 
"mailto:hive/quasar-cpvvvn-1.quasar-cpvvvn.root.hwx.s...@qe-infra-ad.cloudera.com";,
"queryId": "",
"owner": null,
"displayName": null,
"description": null,
"userDescription": null
},
"guid": "b98ef015-6bd9-4343-ad85-24628aa76731",
"isIncomplete": false,
"provenanceType": 0,
"status": "ACTIVE",
"createTime": 1698112413000,
"updateTime": 1698112413000,
"version": 0,
"relationshipAttributes": {
"process": {
"guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb",
"typeName": "hive_process"
}
},
"customAttributes": {
"__nav_engineType": "\"MR\""
},
"businessAttributes": {},
"proxy": false
}

But the  entity with "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb" doesnt have 
above hive_process_execution in  "processExecutions": [] block

Hence relationship edge would get created when process_execution  processed but 
before that when it tries to  process hive_process and finds the 
relationshipattribute is empty and assu es the edges are unused, further tries 
to delete the  edges 

When huge migration data is restarted it is seen that the deleted entities 
count keeps accumulating due to above issue causing migration to slow down alot 
and take more time to process data than expected

This patch only when atlas is in migration mode avoids the code where it can 
further delete the edges by adding a flag


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 6b395dd17 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 f8c9218c6 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
 7eac8df73 
  server-api/src/main/java/org/apache/atlas/RequestContext.java e144d3650 


Diff: https://reviews.apache.org/r/75212/diff/3/

Changes: https://reviews.apache.org/r/75212/diff/2-3/


Testing
---

Migration flag avoids the deletion flow as well as completes migration in 
expected time span


Thanks,

chaitali

Re: Review Request 75211: ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter should be removed from referred attributes tab of entity details page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/
---

(Updated Sept. 19, 2024, 7:49 a.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, Madhan Neethiraj, and 
Prasad Pawar.


Summary (updated)
-

ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter 
should be removed from referred attributes tab of entity details page


Bugs: ATLAS-4894
https://issues.apache.org/jira/browse/ATLAS-4894


Repository: atlas


Description
---

In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar a 
entity type), the two filters  'Exclude SubTypes' and 'Exclude 
Sub-classifications' (see attached screenshot) are visible, but do not have any 
functionality in this page because these only work in the context of Basic 
Search. There are no properties being passed to these filters when user visits 
the entity details of the page.

Also from a functional perspective, it doesn't make sense for classifications 
or types to be filtered in an entity details page.

It is better that they should be removed for consistency, as these filters are 
already removed from the 'Schema' tab of hive_table entities.

This fix also include name validation for glossary, term and category.


Diffs
-

  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
f8cfad616 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f 
  dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
  dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
61176b4f6 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73 
  dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
6aa3fe185 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3 
  dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
  dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
f277c4e5f 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
87fc2cd49 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
007b2f24e 


Diff: https://reviews.apache.org/r/75211/diff/1/


Testing
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-
1)profile table in entity detail page.
2)CRUD operation for glossary, term and category

PC has been passed:- 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1694/


Thanks,

Brijesh Bhalala

Re: Review Request 75211: ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter should be removed from 'Tables' tab of hive_db entity details page

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/#review226938
---


Ship it!




Ship It!

- Pinal Shah


On Sept. 18, 2024, 1:58 p.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75211/
> ---
> 
> (Updated Sept. 18, 2024, 1:58 p.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, Madhan Neethiraj, and 
> Prasad Pawar.
> 
> 
> Bugs: ATLAS-4894
> https://issues.apache.org/jira/browse/ATLAS-4894
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar 
> a entity type), the two filters  'Exclude SubTypes' and 'Exclude 
> Sub-classifications' (see attached screenshot) are visible, but do not have 
> any functionality in this page because these only work in the context of 
> Basic Search. There are no properties being passed to these filters when user 
> visits the entity details of the page.
> 
> Also from a functional perspective, it doesn't make sense for classifications 
> or types to be filtered in an entity details page.
> 
> It is better that they should be removed for consistency, as these filters 
> are already removed from the 'Schema' tab of hive_table entities.
> 
> This fix also include name validation for glossary, term and category.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> f8cfad616 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f 
>   dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
> 61176b4f6 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73 
>   dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> 6aa3fe185 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3 
>   dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
> f277c4e5f 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 87fc2cd49 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> 007b2f24e 
> 
> 
> Diff: https://reviews.apache.org/r/75211/diff/1/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 1)profile table in entity detail page.
> 2)CRUD operation for glossary, term and category
> 
> PC has been passed:- 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1694/
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75212: ATLAS-4903 : When migration restarts it results into deletion of edges and vertices.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75212/#review226937
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
Lines 102 (patched)


"(this.isMigrationImport) ? true : false" => "this.isMigrationImport"


- Madhan Neethiraj


On Sept. 19, 2024, 5:55 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75212/
> ---
> 
> (Updated Sept. 19, 2024, 5:55 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4903
> https://issues.apache.org/jira/browse/ATLAS-4903
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Here in type hive_process_execution we have  "guid": 
> "a2fc8760-8906-454c-8ad8-23b1fffa7fdb", "typeName": "hive_process"
> 
> show below: 
> "entity": {
> "typeName": "hive_process_execution",
> "attributes": {
> "hostName": "",
> "qualifiedName": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "name": 
> "cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
> "queryText": "insert into 
> db_hive_mig_hive.db_hive_mig_hive_tbl_00...2023-10-24T01:53:33.000Z",
> "startTime": 1698112413000,
> "queryPlan": "Not Supported",
> "endTime": 1698112463140,
> "userName": 
> "mailto:hive/quasar-cpvvvn-1.quasar-cpvvvn.root.hwx.s...@qe-infra-ad.cloudera.com";,
> "queryId": "",
> "owner": null,
> "displayName": null,
> "description": null,
> "userDescription": null
> },
> "guid": "b98ef015-6bd9-4343-ad85-24628aa76731",
> "isIncomplete": false,
> "provenanceType": 0,
> "status": "ACTIVE",
> "createTime": 1698112413000,
> "updateTime": 1698112413000,
> "version": 0,
> "relationshipAttributes": {
> "process": {
> "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb",
> "typeName": "hive_process"
> }
> },
> "customAttributes": {
> "__nav_engineType": "\"MR\""
> },
> "businessAttributes": {},
> "proxy": false
> }
> 
> But the  entity with "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb" doesnt 
> have above hive_process_execution in  "processExecutions": [] block
> 
> Hence relationship edge would get created when process_execution  processed 
> but before that when it tries to  process hive_process and finds the 
> relationshipattribute is empty and assu es the edges are unused, further 
> tries to delete the  edges 
> 
> When huge migration data is restarted it is seen that the deleted entities 
> count keeps accumulating due to above issue causing migration to slow down 
> alot and take more time to process data than expected
> 
> This patch only when atlas is in migration mode avoids the code where it can 
> further delete the edges by adding a flag
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  6b395dd17 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
>  f8c9218c6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
>  b73988fd7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
>  7eac8df73 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java e144d3650 
> 
> 
> Diff: https://reviews.apache.org/r/75212/diff/2/
> 
> 
> Testing
> ---
> 
> Migration flag avoids the deletion flow as well as completes migration in 
> expected time span
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 75212: ATLAS-4903 : When migration restarts it results into deletion of edges and vertices.

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75212/
---

(Updated Sept. 19, 2024, 5:55 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Pinal Shah.


Bugs: ATLAS-4903
https://issues.apache.org/jira/browse/ATLAS-4903


Repository: atlas


Description
---

Here in type hive_process_execution we have  "guid": 
"a2fc8760-8906-454c-8ad8-23b1fffa7fdb", "typeName": "hive_process"

show below: 
"entity": {
"typeName": "hive_process_execution",
"attributes": {
"hostName": "",
"qualifiedName": 
"cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
"name": 
"cm:6135:db_hive_mig_hive.db_hive_mig_hive_tbl_00@cm:1698112413000:6155:1698112413000:1698112463140",
"queryText": "insert into 
db_hive_mig_hive.db_hive_mig_hive_tbl_00...2023-10-24T01:53:33.000Z",
"startTime": 1698112413000,
"queryPlan": "Not Supported",
"endTime": 1698112463140,
"userName": 
"mailto:hive/quasar-cpvvvn-1.quasar-cpvvvn.root.hwx.s...@qe-infra-ad.cloudera.com";,
"queryId": "",
"owner": null,
"displayName": null,
"description": null,
"userDescription": null
},
"guid": "b98ef015-6bd9-4343-ad85-24628aa76731",
"isIncomplete": false,
"provenanceType": 0,
"status": "ACTIVE",
"createTime": 1698112413000,
"updateTime": 1698112413000,
"version": 0,
"relationshipAttributes": {
"process": {
"guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb",
"typeName": "hive_process"
}
},
"customAttributes": {
"__nav_engineType": "\"MR\""
},
"businessAttributes": {},
"proxy": false
}

But the  entity with "guid": "a2fc8760-8906-454c-8ad8-23b1fffa7fdb" doesnt have 
above hive_process_execution in  "processExecutions": [] block

Hence relationship edge would get created when process_execution  processed but 
before that when it tries to  process hive_process and finds the 
relationshipattribute is empty and assu es the edges are unused, further tries 
to delete the  edges 

When huge migration data is restarted it is seen that the deleted entities 
count keeps accumulating due to above issue causing migration to slow down alot 
and take more time to process data than expected

This patch only when atlas is in migration mode avoids the code where it can 
further delete the edges by adding a flag


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 6b395dd17 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 f8c9218c6 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumerBuilder.java
 7eac8df73 
  server-api/src/main/java/org/apache/atlas/RequestContext.java e144d3650 


Diff: https://reviews.apache.org/r/75212/diff/2/


Testing
---

Migration flag avoids the deletion flow as well as completes migration in 
expected time span


Thanks,

chaitali

Re: Review Request 75211: ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter should be removed from 'Tables' tab of hive_db entity details page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/
---

(Updated Sept. 18, 2024, 1:58 p.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, Madhan Neethiraj, and 
Prasad Pawar.


Bugs: ATLAS-4894
https://issues.apache.org/jira/browse/ATLAS-4894


Repository: atlas


Description
---

In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar a 
entity type), the two filters  'Exclude SubTypes' and 'Exclude 
Sub-classifications' (see attached screenshot) are visible, but do not have any 
functionality in this page because these only work in the context of Basic 
Search. There are no properties being passed to these filters when user visits 
the entity details of the page.

Also from a functional perspective, it doesn't make sense for classifications 
or types to be filtered in an entity details page.

It is better that they should be removed for consistency, as these filters are 
already removed from the 'Schema' tab of hive_table entities.

This fix also include name validation for glossary, term and category.


Diffs
-

  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
f8cfad616 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f 
  dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
  dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
61176b4f6 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73 
  dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
6aa3fe185 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3 
  dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
  dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
f277c4e5f 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
87fc2cd49 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
007b2f24e 


Diff: https://reviews.apache.org/r/75211/diff/1/


Testing (updated)
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-
1)profile table in entity detail page.
2)CRUD operation for glossary, term and category

PC has been passed:- 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1694/


Thanks,

Brijesh Bhalala

Re: Review Request 75211: ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter should be removed from 'Tables' tab of hive_db entity details page

[Prasad Pawar]

> On Sept. 18, 2024, 11:40 a.m., Prasad Pawar wrote:
> >

Ship it!


- Prasad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/#review226933
---


On Sept. 18, 2024, 11:22 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75211/
> ---
> 
> (Updated Sept. 18, 2024, 11:22 a.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4894
> https://issues.apache.org/jira/browse/ATLAS-4894
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar 
> a entity type), the two filters  'Exclude SubTypes' and 'Exclude 
> Sub-classifications' (see attached screenshot) are visible, but do not have 
> any functionality in this page because these only work in the context of 
> Basic Search. There are no properties being passed to these filters when user 
> visits the entity details of the page.
> 
> Also from a functional perspective, it doesn't make sense for classifications 
> or types to be filtered in an entity details page.
> 
> It is better that they should be removed for consistency, as these filters 
> are already removed from the 'Schema' tab of hive_table entities.
> 
> This fix also include name validation for glossary, term and category.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> f8cfad616 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f 
>   dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
> 61176b4f6 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73 
>   dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> 6aa3fe185 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3 
>   dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
> f277c4e5f 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 87fc2cd49 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> 007b2f24e 
> 
> 
> Diff: https://reviews.apache.org/r/75211/diff/1/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 1)profile table in entity detail page.
> 2)CRUD operation for glossary, term and category
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75211: ATLAS-4894: [UI] 'Exclude SubTypes' and 'Exclude Sub-classifications' filter should be removed from 'Tables' tab of hive_db entity details page

[Prasad Pawar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75211/#review226933
---



- Prasad Pawar


On Sept. 18, 2024, 11:22 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75211/
> ---
> 
> (Updated Sept. 18, 2024, 11:22 a.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4894
> https://issues.apache.org/jira/browse/ATLAS-4894
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In UI, When we visit the 'Tables' tab section of a hive_db entity (or similar 
> a entity type), the two filters  'Exclude SubTypes' and 'Exclude 
> Sub-classifications' (see attached screenshot) are visible, but do not have 
> any functionality in this page because these only work in the context of 
> Basic Search. There are no properties being passed to these filters when user 
> visits the entity details of the page.
> 
> Also from a functional perspective, it doesn't make sense for classifications 
> or types to be filtered in an entity details page.
> 
> It is better that they should be removed for consistency, as these filters 
> are already removed from the 'Schema' tab of hive_table entities.
> 
> This fix also include name validation for glossary, term and category.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> f8cfad616 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 3f62d970f 
>   dashboardv2/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv2/public/js/views/search/RelationSearchResultLayoutView.js 
> 61176b4f6 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js c9e57ad73 
>   dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> 6aa3fe185 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 854908da3 
>   dashboardv3/public/js/views/glossary/TermPropertiestLayoutView.js e2bb72d20 
>   dashboardv3/public/js/views/search/RelationSearchResultLayoutView.js 
> f277c4e5f 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js 16db56623 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 77a6fd8c3 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 87fc2cd49 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java 
> 007b2f24e 
> 
> 
> Diff: https://reviews.apache.org/r/75211/diff/1/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 1)profile table in entity detail page.
> 2)CRUD operation for glossary, term and category
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Mandar Ambawane]

Thanks Madhan for the draft report. +1

On Thu, Sep 12, 2024 at 10:55 PM Radhika Kundam 
wrote:

> +1, thanks Madhan for the draft report.
>
> On Wed, Sep 11, 2024 at 2:51 PM Madhan Neethiraj 
> wrote:
>
> > Atlas community,
> >
> >
> >
> > Please review the following draft report for this quarter.
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > ## Description:
> >
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> >
> > to a scalable and extensible set of core foundational governance services
> > -
> >
> > enabling enterprises to effectively and efficiently meet their compliance
> >
> > requirements
> >
> >
> >
> > ## Project Status:
> >
> > Current project status: Ongoing, with low activity
> >
> > Issues for the board: none
> >
> >
> >
> > ## Membership Data:
> >
> > Apache Atlas was founded 2017-06-20 (7 years ago)
> >
> > There are currently 48 committers and 32 PMC members in this project.
> >
> > The Committer-to-PMC ratio is 3:2.
> >
> >
> >
> > Community changes, past quarter:
> >
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> >
> > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> >
> >
> >
> > ## Project Activity:
> >
> > - fixes and improvements in import functionality
> >
> > - performance improvement - utility to analyze hook notifications
> >
> > - improvements in notification processing
> >
> > - UI fixes in handling of deferred tasks
> >
> > - updated versions of dependent libraries
> >
> >
> >
> > ## Community Health:
> >
> > - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter
> > (235 emails compared to 296):
> >
> > - 10 commits in the past quarter, a decrease from 23 commits the previous
> > quarter
> >
> > - 4 code contributors in the past quarter, a decrease from 7 in the
> > previous quarter
> >
> > - 2 new contributors were added in the past quarter - Prashant Satam and
> > Chandra Kanth Peravelli
> >
> >
> >
> > ## Recent releases:
> >
> > - Apache Atlas 2.3.0 was released on 2022-12-06.
> >
> > - Apache Atlas 2.2.0 was released on 2021-08-17.
> >
> > - Apache Atlas 2.1.0 was released on 2020-07-15.
> >
> >
> >
> >
> >
> >
>


-- 
Thanks and Regards,
Mandar V. Ambawane.

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Jayendra Parab]

+1, thanks Madhan for putting this together.

On Thu, Sep 12, 2024 at 10:56 PM Radhika Kundam 
wrote:

> +1, thanks Madhan for the draft report.
>
> On Wed, Sep 11, 2024 at 2:51 PM Madhan Neethiraj 
> wrote:
>
> > Atlas community,
> >
> >
> >
> > Please review the following draft report for this quarter.
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > ## Description:
> >
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> >
> > to a scalable and extensible set of core foundational governance services
> > -
> >
> > enabling enterprises to effectively and efficiently meet their compliance
> >
> > requirements
> >
> >
> >
> > ## Project Status:
> >
> > Current project status: Ongoing, with low activity
> >
> > Issues for the board: none
> >
> >
> >
> > ## Membership Data:
> >
> > Apache Atlas was founded 2017-06-20 (7 years ago)
> >
> > There are currently 48 committers and 32 PMC members in this project.
> >
> > The Committer-to-PMC ratio is 3:2.
> >
> >
> >
> > Community changes, past quarter:
> >
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> >
> > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> >
> >
> >
> > ## Project Activity:
> >
> > - fixes and improvements in import functionality
> >
> > - performance improvement - utility to analyze hook notifications
> >
> > - improvements in notification processing
> >
> > - UI fixes in handling of deferred tasks
> >
> > - updated versions of dependent libraries
> >
> >
> >
> > ## Community Health:
> >
> > - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter
> > (235 emails compared to 296):
> >
> > - 10 commits in the past quarter, a decrease from 23 commits the previous
> > quarter
> >
> > - 4 code contributors in the past quarter, a decrease from 7 in the
> > previous quarter
> >
> > - 2 new contributors were added in the past quarter - Prashant Satam and
> > Chandra Kanth Peravelli
> >
> >
> >
> > ## Recent releases:
> >
> > - Apache Atlas 2.3.0 was released on 2022-12-06.
> >
> > - Apache Atlas 2.2.0 was released on 2021-08-17.
> >
> > - Apache Atlas 2.1.0 was released on 2020-07-15.
> >
> >
> >
> >
> >
> >
>

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Radhika Kundam]

+1, thanks Madhan for the draft report.

On Wed, Sep 11, 2024 at 2:51 PM Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Please review the following draft report for this quarter.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
>
>
>
>
> ## Description:
>
> The mission of Apache Atlas is the creation and maintenance of software
> related
>
> to a scalable and extensible set of core foundational governance services
> -
>
> enabling enterprises to effectively and efficiently meet their compliance
>
> requirements
>
>
>
> ## Project Status:
>
> Current project status: Ongoing, with low activity
>
> Issues for the board: none
>
>
>
> ## Membership Data:
>
> Apache Atlas was founded 2017-06-20 (7 years ago)
>
> There are currently 48 committers and 32 PMC members in this project.
>
> The Committer-to-PMC ratio is 3:2.
>
>
>
> Community changes, past quarter:
>
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
>
>
> ## Project Activity:
>
> - fixes and improvements in import functionality
>
> - performance improvement - utility to analyze hook notifications
>
> - improvements in notification processing
>
> - UI fixes in handling of deferred tasks
>
> - updated versions of dependent libraries
>
>
>
> ## Community Health:
>
> - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter
> (235 emails compared to 296):
>
> - 10 commits in the past quarter, a decrease from 23 commits the previous
> quarter
>
> - 4 code contributors in the past quarter, a decrease from 7 in the
> previous quarter
>
> - 2 new contributors were added in the past quarter - Prashant Satam and
> Chandra Kanth Peravelli
>
>
>
> ## Recent releases:
>
> - Apache Atlas 2.3.0 was released on 2022-12-06.
>
> - Apache Atlas 2.2.0 was released on 2021-08-17.
>
> - Apache Atlas 2.1.0 was released on 2020-07-15.
>
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Nikhil Bonte]

+1

Thanks Madhan for putting this together

On Thu, 12 Sep 2024 at 3:21 AM, Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Please review the following draft report for this quarter.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
>
>
>
>
> ## Description:
>
> The mission of Apache Atlas is the creation and maintenance of software
> related
>
> to a scalable and extensible set of core foundational governance services
> -
>
> enabling enterprises to effectively and efficiently meet their compliance
>
> requirements
>
>
>
> ## Project Status:
>
> Current project status: Ongoing, with low activity
>
> Issues for the board: none
>
>
>
> ## Membership Data:
>
> Apache Atlas was founded 2017-06-20 (7 years ago)
>
> There are currently 48 committers and 32 PMC members in this project.
>
> The Committer-to-PMC ratio is 3:2.
>
>
>
> Community changes, past quarter:
>
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
>
>
> ## Project Activity:
>
> - fixes and improvements in import functionality
>
> - performance improvement - utility to analyze hook notifications
>
> - improvements in notification processing
>
> - UI fixes in handling of deferred tasks
>
> - updated versions of dependent libraries
>
>
>
> ## Community Health:
>
> - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter
> (235 emails compared to 296):
>
> - 10 commits in the past quarter, a decrease from 23 commits the previous
> quarter
>
> - 4 code contributors in the past quarter, a decrease from 7 in the
> previous quarter
>
> - 2 new contributors were added in the past quarter - Prashant Satam and
> Chandra Kanth Peravelli
>
>
>
> ## Recent releases:
>
> - Apache Atlas 2.3.0 was released on 2022-12-06.
>
> - Apache Atlas 2.2.0 was released on 2021-08-17.
>
> - Apache Atlas 2.1.0 was released on 2020-07-15.
>
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[pinal shah]

Looks good to me. Thanks Madhan for putting this together.



On Thu, Sep 12, 2024 at 8:59 AM Sarath Subramanian 
wrote:

> Thanks Madhan for the draft report.
>
> +1
>
> > On Sep 11, 2024, at 2:51 PM, Madhan Neethiraj  wrote:
> >
> > Atlas community,
> >
> >
> >
> > Please review the following draft report for this quarter.
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > ## Description:
> >
> > The mission of Apache Atlas is the creation and maintenance of software
> related
> >
> > to a scalable and extensible set of core foundational governance
> services -
> >
> > enabling enterprises to effectively and efficiently meet their compliance
> >
> > requirements
> >
> >
> >
> > ## Project Status:
> >
> > Current project status: Ongoing, with low activity
> >
> > Issues for the board: none
> >
> >
> >
> > ## Membership Data:
> >
> > Apache Atlas was founded 2017-06-20 (7 years ago)
> >
> > There are currently 48 committers and 32 PMC members in this project.
> >
> > The Committer-to-PMC ratio is 3:2.
> >
> >
> >
> > Community changes, past quarter:
> >
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> >
> > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> >
> >
> >
> > ## Project Activity:
> >
> > - fixes and improvements in import functionality
> >
> > - performance improvement - utility to analyze hook notifications
> >
> > - improvements in notification processing
> >
> > - UI fixes in handling of deferred tasks
> >
> > - updated versions of dependent libraries
> >
> >
> >
> > ## Community Health:
> >
> > - dev@atlas.apache.org had a 21% decrease in traffic in the past
> quarter (235 emails compared to 296):
> >
> > - 10 commits in the past quarter, a decrease from 23 commits the
> previous quarter
> >
> > - 4 code contributors in the past quarter, a decrease from 7 in the
> previous quarter
> >
> > - 2 new contributors were added in the past quarter - Prashant Satam and
> Chandra Kanth Peravelli
> >
> >
> >
> > ## Recent releases:
> >
> > - Apache Atlas 2.3.0 was released on 2022-12-06.
> >
> > - Apache Atlas 2.2.0 was released on 2021-08-17.
> >
> > - Apache Atlas 2.1.0 was released on 2020-07-15.
> >
> >
> >
> >
> >
>

Re: [PR] [MINOR] remove akka.version in pom.xml [atlas]

[via GitHub]

kafsavas commented on PR #245:
URL: https://github.com/apache/atlas/pull/245#issuecomment-2345657677

   Is there a road map for Atlas releases or this project dead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Sarath Subramanian]

Thanks Madhan for the draft report.

+1

> On Sep 11, 2024, at 2:51 PM, Madhan Neethiraj  wrote:
> 
> Atlas community,
> 
> 
> 
> Please review the following draft report for this quarter.
> 
> 
> 
> Thanks,
> 
> Madhan
> 
> 
> 
> 
> 
> 
> 
> 
> 
> ## Description:
> 
> The mission of Apache Atlas is the creation and maintenance of software 
> related
> 
> to a scalable and extensible set of core foundational governance services -
> 
> enabling enterprises to effectively and efficiently meet their compliance
> 
> requirements
> 
> 
> 
> ## Project Status:
> 
> Current project status: Ongoing, with low activity
> 
> Issues for the board: none
> 
> 
> 
> ## Membership Data:
> 
> Apache Atlas was founded 2017-06-20 (7 years ago)
> 
> There are currently 48 committers and 32 PMC members in this project.
> 
> The Committer-to-PMC ratio is 3:2.
> 
> 
> 
> Community changes, past quarter:
> 
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> 
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> 
> 
> 
> ## Project Activity:
> 
> - fixes and improvements in import functionality
> 
> - performance improvement - utility to analyze hook notifications
> 
> - improvements in notification processing
> 
> - UI fixes in handling of deferred tasks
> 
> - updated versions of dependent libraries
> 
> 
> 
> ## Community Health:
> 
> - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter (235 
> emails compared to 296):
> 
> - 10 commits in the past quarter, a decrease from 23 commits the previous 
> quarter
> 
> - 4 code contributors in the past quarter, a decrease from 7 in the previous 
> quarter
> 
> - 2 new contributors were added in the past quarter - Prashant Satam and 
> Chandra Kanth Peravelli
> 
> 
> 
> ## Recent releases:
> 
> - Apache Atlas 2.3.0 was released on 2022-12-06.
> 
> - Apache Atlas 2.2.0 was released on 2021-08-17.
> 
> - Apache Atlas 2.1.0 was released on 2020-07-15.
> 
> 
> 
> 
> 

Re: Request to join Atlas project

[Madhan Neethiraj]

Niket,

Thank you for your interest in contributing to Apache Atlas. Can you please 
send your JIRA account id in https://issues.apache.org/jira? If you haven't 
created an account yet, you can request for one at 
https://selfserve.apache.org/jira-account.html.

Thanks,
Madhan

On 8/1/24, 5:14 AM, "Niket Pasari" mailto:niket.pas...@freestoneinfotech.com>> wrote:


Hi Team,


Can you please add me as a contributor.


Thanks,
Niket Pasari

Re: requestforcontributingtoApacheAtlas

[Madhan Neethiraj]

Hi Chandrakanth,

 

Thank you for your interest in contributing to Apache Atlas. You have been 
added as a contributor. Welcome to Apache Atlas community!

 

Madhan

 

 

From: Chandra Kanth Peravelli 
Date: Tuesday, September 3, 2024 at 9:27 AM
To: Madhan Neethiraj 
Cc: "dev@atlas.apache.org" 
Subject: Re: requestforcontributingtoApacheAtlas

 

Hi Madan, the user id for the JIRA account is peravelli. 

 

Thanks & Regards

Chandrakanth Peravelli



On Sep 3, 2024, at 11:23 AM, Chandra Kanth Peravelli  
wrote:

 

Hi Madhan, 

 

   Thanks much for your reply. I have requested a JIRA id, as per the below 
links shared. 

 

Thanks & Regards,

Chandrakanth Peravelli



On Sep 3, 2024, at 8:27 AM, Madhan Neethiraj  wrote:

 

Chandrakanth,

 

Thank you for your interest in contributing to Apache Atlas. Can you please 
send your Apache JIRA id? If you haven’t created one yet, please sign up for 
one at https://selfserve.apache.org/jira-account.html and send your id.

 

Thanks,

Madhan

 

 

 

From: Chandra Kanth Peravelli 
Date: Monday, August 26, 2024 at 9:18 PM
To: "dev@atlas.apache.org" 
Subject: requestforcontributingtoApacheAtlas

 

Hi Apache atlas team, 

 

Can you please grant privilege to contribute to Apache Atlas for the email 
id: “cperave...@cloudera.com”. 

 

   Kindly let me know if you need anything else from me. 

 

Thanks & Regards

Chandrakanth Peravelli

 

 

Re: requestforcontributingtoApacheAtlas

[Chandra Kanth Peravelli]

Hi Madan, the user id for the JIRA account is peravelli. 

Thanks & Regards
Chandrakanth Peravelli

> On Sep 3, 2024, at 11:23 AM, Chandra Kanth Peravelli 
>  wrote:
> 
> Hi Madhan, 
> 
>Thanks much for your reply. I have requested a JIRA id, as per the below 
> links shared. 
> 
> Thanks & Regards,
> Chandrakanth Peravelli
> 
>> On Sep 3, 2024, at 8:27 AM, Madhan Neethiraj  wrote:
>> 
>> Chandrakanth,
>>  
>> Thank you for your interest in contributing to Apache Atlas. Can you please 
>> send your Apache JIRA id? If you haven’t created one yet, please sign up for 
>> one at https://selfserve.apache.org/jira-account.html and send your id.
>>  
>> Thanks,
>> Madhan
>>  
>>  
>>  
>> From: Chandra Kanth Peravelli 
>> Date: Monday, August 26, 2024 at 9:18 PM
>> To: "dev@atlas.apache.org" 
>> Subject: requestforcontributingtoApacheAtlas
>>  
>> Hi Apache atlas team, 
>>  
>> Can you please grant privilege to contribute to Apache Atlas for the 
>> email id: “cperave...@cloudera.com ”. 
>>  
>>Kindly let me know if you need anything else from me. 
>>  
>> Thanks & Regards
>> Chandrakanth Peravelli
> 

Re: requestforcontributingtoApacheAtlas

[Chandra Kanth Peravelli]

Hi Madhan, 

   Thanks much for your reply. I have requested a JIRA id, as per the below 
links shared. 

Thanks & Regards,
Chandrakanth Peravelli

> On Sep 3, 2024, at 8:27 AM, Madhan Neethiraj  wrote:
> 
> Chandrakanth,
>  
> Thank you for your interest in contributing to Apache Atlas. Can you please 
> send your Apache JIRA id? If you haven’t created one yet, please sign up for 
> one at https://selfserve.apache.org/jira-account.html and send your id.
>  
> Thanks,
> Madhan
>  
>  
>  
> From: Chandra Kanth Peravelli 
> Date: Monday, August 26, 2024 at 9:18 PM
> To: "dev@atlas.apache.org" 
> Subject: requestforcontributingtoApacheAtlas
>  
> Hi Apache atlas team, 
>  
> Can you please grant privilege to contribute to Apache Atlas for the 
> email id: “cperave...@cloudera.com ”. 
>  
>Kindly let me know if you need anything else from me. 
>  
> Thanks & Regards
> Chandrakanth Peravelli

Re: Review Request 75188: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata, labels is edited.

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75188/#review226894
---


Ship it!




Ship It!

- Pinal Shah


On Aug. 24, 2024, 9:14 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75188/
> ---
> 
> (Updated Aug. 24, 2024, 9:14 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When updating the business metadata and Labels on an atlas entity, the 
> 'updateTime' system attribute is not changed.
> 
> 
> Updates to other aspects, such as technical properties and user defined 
> attributes does update the timestamp, but not the business metadata and 
> labels.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
> 
> 
> Diff: https://reviews.apache.org/r/75188/diff/2/
> 
> 
> Testing
> ---
> 
> update time Without patch
> before business metadata update
> 
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after business metadata update
> 
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after applying PATCH
> 
> 
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
> 
> 
> after business metadata update  
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
> 
> 
> Entire json for GET api on entity before applying patch :
> 
> 
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
> 
> 
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.customer_id@cl1",
> "name": "customer_id",
> "comment": "customer id"
> },
> "guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels"

Re: requestforcontributingtoApacheAtlas

[Madhan Neethiraj]

Chandrakanth,

 

Thank you for your interest in contributing to Apache Atlas. Can you please 
send your Apache JIRA id? If you haven’t created one yet, please sign up for 
one at https://selfserve.apache.org/jira-account.html and send your id.

 

Thanks,

Madhan

 

 

 

From: Chandra Kanth Peravelli 
Date: Monday, August 26, 2024 at 9:18 PM
To: "dev@atlas.apache.org" 
Subject: requestforcontributingtoApacheAtlas

 

Hi Apache atlas team, 

 

Can you please grant privilege to contribute to Apache Atlas for the email 
id: “cperave...@cloudera.com”. 

 

   Kindly let me know if you need anything else from me. 

 

Thanks & Regards

Chandrakanth Peravelli

Re: Review Request 75188: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata, labels is edited.

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75188/#review226893
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 24, 2024, 9:14 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75188/
> ---
> 
> (Updated Aug. 24, 2024, 9:14 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4802
> https://issues.apache.org/jira/browse/ATLAS-4802
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When updating the business metadata and Labels on an atlas entity, the 
> 'updateTime' system attribute is not changed.
> 
> 
> Updates to other aspects, such as technical properties and user defined 
> attributes does update the timestamp, but not the business metadata and 
> labels.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
> 
> 
> Diff: https://reviews.apache.org/r/75188/diff/2/
> 
> 
> Testing
> ---
> 
> update time Without patch
> before business metadata update
> 
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after business metadata update
> 
> 
> "createTime": 1703221384530,
> "updateTime": 1703221386989,
> 
> 
> after applying PATCH
> 
> 
> before business metadata update
> "createTime": 1704190056433,
> "updateTime": 1704190059208,
> 
> 
> after business metadata update  
> "createTime": 1704190056433,
> "updateTime": 1704190523323,
> 
> 
> Entire json for GET api on entity before applying patch :
> 
> 
> http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d
> 
> 
> {
> "referredEntities": {
> "a1a27e35-aa0d-472d-8b94-2405d8001a84": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.address@cl1",
> "name": "address",
> "comment": "customer address"
> },
> "guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.name@cl1",
> "name": "name",
> "comment": "customer name"
> },
> "guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "labels": []
> },
> "f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
> "typeName": "Column",
> "attributes": {
> "qualifiedName": "Sales.customer_dim.customer_id@cl1",
> "name": "customer_id",
> "comment": "customer id"
> },
> "guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "isIncomplete": false,
> "status": "ACTIVE",
> "createdBy": "admin",
> "updatedBy": "admin",
> "createTime": 1704190056433,
> "updateTime": 1704190056433,
> "version": 0,
> "classifications": [
> {
> "typeName": "PII",
> "entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
> "entityStatus": "ACTIVE",
> "propagate": true,
> "removePropagationsOnEntityDelete": false
> }
> ],
> "l

Re: Review Request 75193: ATLAS-4848 : Atlas 'updateTime' parameter is not updated when term is added.

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75193/
---

(Updated Aug. 28, 2024, 12:16 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4848
https://issues.apache.org/jira/browse/ATLAS-4848


Repository: atlas


Description
---

Steps to reproduce:
1. Create hive_table testhive1 and perform incremental export for the same with 
changeMarker 0.
2. Now, before 2nd run create and assign term t1 to testhive1 and perform 
incremental export with changeMarker that we got after 1st run.
3. Result is export works but the term assigned to the hive_table entity didn't 
got exported.


Problem:
When term was getting assigned to hive_table entity, it did not updated the 
value of 'updateTime' attribute of that entity and hence,during 2nd run with 
incremental export it didn't exported the term as for incremental export we 
fetch data according to the changeMarker provided.

Fix:
Attribute 'updateTime' value gets updated after the term is assigned to an 
entity.


Diffs
-

  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
8a161e420 


Diff: https://reviews.apache.org/r/75193/diff/1/


Testing (updated)
---

Manual testing was performed.
PC link: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1687/


Thanks,

Priyanshi Shah

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/#review226887
---


Ship it!




Ship It!

- Pinal Shah


On Aug. 23, 2024, 1:47 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75150/
> ---
> 
> (Updated Aug. 23, 2024, 1:47 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4892
> https://issues.apache.org/jira/browse/ATLAS-4892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem:
> 
> During import, if shell entity is present in the importing file, import is 
> getting failed.
> 
> Solution:
> 
> There is mandatory attribute check present which was not allowing to create 
> shell entity and the import was getting failed due to this implementation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  b51951fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  656c9d14b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  2f37eac6b 
> 
> 
> Diff: https://reviews.apache.org/r/75150/diff/6/
> 
> 
> Testing
> ---
> 
> Tested below scenarios :
> 
> 1. Created shell entity through beeline it is working fine.
> 2. Tried with export file which has hive_column as shell entity it is also 
> working fine.
> 3. Had one export file which has shell entity for spark_column_lineage and it 
> worked fine.
> 4. Tried running same exported file which has same shell entity  again .
> 5. Incremental export file should have entity (shell entity in the earlier 
> export) which is now resolved to actual entity.
> 6. Ran export file without having shell entity.
> 7. Created entity through API.
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75188: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata, labels is edited.

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75188/
---

(Updated Aug. 24, 2024, 9:14 a.m.)


Review request for atlas, Jayendra Parab and Pinal Shah.


Bugs: ATLAS-4802
https://issues.apache.org/jira/browse/ATLAS-4802


Repository: atlas


Description
---

When updating the business metadata and Labels on an atlas entity, the 
'updateTime' system attribute is not changed.


Updates to other aspects, such as technical properties and user defined 
attributes does update the timestamp, but not the business metadata and labels.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 


Diff: https://reviews.apache.org/r/75188/diff/2/

Changes: https://reviews.apache.org/r/75188/diff/1-2/


Testing
---

update time Without patch
before business metadata update


"createTime": 1703221384530,
"updateTime": 1703221386989,


after business metadata update


"createTime": 1703221384530,
"updateTime": 1703221386989,


after applying PATCH


before business metadata update
"createTime": 1704190056433,
"updateTime": 1704190059208,


after business metadata update  
"createTime": 1704190056433,
"updateTime": 1704190523323,


Entire json for GET api on entity before applying patch :


http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d


{
"referredEntities": {
"a1a27e35-aa0d-472d-8b94-2405d8001a84": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.address@cl1",
"name": "address",
"comment": "customer address"
},
"guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.name@cl1",
"name": "name",
"comment": "customer name"
},
"guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.customer_id@cl1",
"name": "customer_id",
"comment": "customer id"
},
"guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"06f3f56c-8ed7-4930-93b3-8a4b6f81c505": {
"typeName": "StorageDesc",
"attributes": {
"qualifiedName": "sd:hdfs://host:8000/apps/warehouse/sales@cl1",
"name": "sd:hdfs://host:8000/apps/warehouse/sales"
},
"guid": "06f3f56c-8ed7-4930-93b3-8a4b6f81c505",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190055353,
"updateTime": 170419005

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/#review226886
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 23, 2024, 1:47 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75150/
> ---
> 
> (Updated Aug. 23, 2024, 1:47 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4892
> https://issues.apache.org/jira/browse/ATLAS-4892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem:
> 
> During import, if shell entity is present in the importing file, import is 
> getting failed.
> 
> Solution:
> 
> There is mandatory attribute check present which was not allowing to create 
> shell entity and the import was getting failed due to this implementation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  b51951fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  656c9d14b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  2f37eac6b 
> 
> 
> Diff: https://reviews.apache.org/r/75150/diff/6/
> 
> 
> Testing
> ---
> 
> Tested below scenarios :
> 
> 1. Created shell entity through beeline it is working fine.
> 2. Tried with export file which has hive_column as shell entity it is also 
> working fine.
> 3. Had one export file which has shell entity for spark_column_lineage and it 
> worked fine.
> 4. Tried running same exported file which has same shell entity  again .
> 5. Incremental export file should have entity (shell entity in the earlier 
> export) which is now resolved to actual entity.
> 6. Ran export file without having shell entity.
> 7. Created entity through API.
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/
---

(Updated Aug. 23, 2024, 1:47 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4892
https://issues.apache.org/jira/browse/ATLAS-4892


Repository: atlas


Description
---

Problem:

During import, if shell entity is present in the importing file, import is 
getting failed.

Solution:

There is mandatory attribute check present which was not allowing to create 
shell entity and the import was getting failed due to this implementation.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 b51951fe2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 656c9d14b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 2f37eac6b 


Diff: https://reviews.apache.org/r/75150/diff/6/

Changes: https://reviews.apache.org/r/75150/diff/5-6/


Testing
---

Tested below scenarios :

1. Created shell entity through beeline it is working fine.
2. Tried with export file which has hive_column as shell entity it is also 
working fine.
3. Had one export file which has shell entity for spark_column_lineage and it 
worked fine.
4. Tried running same exported file which has same shell entity  again .
5. Incremental export file should have entity (shell entity in the earlier 
export) which is now resolved to actual entity.
6. Ran export file without having shell entity.
7. Created entity through API.


Thanks,

Priyanshi Shah

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/
---

(Updated Aug. 23, 2024, 1:32 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4892
https://issues.apache.org/jira/browse/ATLAS-4892


Repository: atlas


Description
---

Problem:

During import, if shell entity is present in the importing file, import is 
getting failed.

Solution:

There is mandatory attribute check present which was not allowing to create 
shell entity and the import was getting failed due to this implementation.


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 b51951fe2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 656c9d14b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 2f37eac6b 


Diff: https://reviews.apache.org/r/75150/diff/5/


Testing (updated)
---

Tested below scenarios :

1. Created shell entity through beeline it is working fine.
2. Tried with export file which has hive_column as shell entity it is also 
working fine.
3. Had one export file which has shell entity for spark_column_lineage and it 
worked fine.
4. Tried running same exported file which has same shell entity  again .
5. Incremental export file should have entity (shell entity in the earlier 
export) which is now resolved to actual entity.
6. Ran export file without having shell entity.
7. Created entity through API.


Thanks,

Priyanshi Shah

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

> On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
> > Line 1272 (original), 1271 (patched)
> > 
> >
> > Why is it necessary to skip adding incomplete entities to 
> > context.addUpdated() and context.addCreated() - #1272 and #1294 below?

It is skipped to avoid adding first class/default attributes in the shell 
entity. Eg: shell entity of hive_table will add default attributes like 
rentention,temporary etc. if these methods are not skipped.
Adding those would differ the entity attributes with target cluster


- Priyanshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/#review226865
---


On Aug. 23, 2024, 10:46 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75150/
> ---
> 
> (Updated Aug. 23, 2024, 10:46 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4892
> https://issues.apache.org/jira/browse/ATLAS-4892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem:
> 
> During import, if shell entity is present in the importing file, import is 
> getting failed.
> 
> Solution:
> 
> There is mandatory attribute check present which was not allowing to create 
> shell entity and the import was getting failed due to this implementation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  b51951fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  656c9d14b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  2f37eac6b 
> 
> 
> Diff: https://reviews.apache.org/r/75150/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/
---

(Updated Aug. 23, 2024, 10:46 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4892
https://issues.apache.org/jira/browse/ATLAS-4892


Repository: atlas


Description
---

Problem:

During import, if shell entity is present in the importing file, import is 
getting failed.

Solution:

There is mandatory attribute check present which was not allowing to create 
shell entity and the import was getting failed due to this implementation.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 b51951fe2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 656c9d14b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 2f37eac6b 


Diff: https://reviews.apache.org/r/75150/diff/5/

Changes: https://reviews.apache.org/r/75150/diff/4-5/


Testing
---


Thanks,

Priyanshi Shah

Re: Review Request 74691: ATLAS-4802 : Atlas 'updateTime' parameter is not updated when business metadata, labels is edited.

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74691/
---

(Updated Aug. 23, 2024, 10:24 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4802
https://issues.apache.org/jira/browse/ATLAS-4802


Repository: atlas


Description
---

When updating the business metadata and Labels on an atlas entity, the 
'updateTime' system attribute is not changed.

Updates to other aspects, such as technical properties and user defined 
attributes does update the timestamp, but not the business metadata and labels.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 


Diff: https://reviews.apache.org/r/74691/diff/3/

Changes: https://reviews.apache.org/r/74691/diff/2-3/


Testing
---

update time Without patch
before business metadata update

"createTime": 1703221384530,
"updateTime": 1703221386989,

after business metadata update

"createTime": 1703221384530,
"updateTime": 1703221386989,


after applying PATCH

before business metadata update
"createTime": 1704190056433,
"updateTime": 1704190059208,

after business metadata update
"createTime": 1704190056433,
"updateTime": 1704190523323,

Entire json for GET api on entity before applying patch :

http://localhost:21000/api/atlas/v2/entity/guid/dc1baa88-3a07-4577-9b6b-48982253aa3d

{
"referredEntities": {
"a1a27e35-aa0d-472d-8b94-2405d8001a84": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.address@cl1",
"name": "address",
"comment": "customer address"
},
"guid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "a1a27e35-aa0d-472d-8b94-2405d8001a84",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.name@cl1",
"name": "name",
"comment": "customer name"
},
"guid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "834ba687-c8f1-4a48-a6a0-ef3ddeadf7ee",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"f8ded729-7bad-48dd-9969-c5b36a8d5b9c": {
"typeName": "Column",
"attributes": {
"qualifiedName": "Sales.customer_dim.customer_id@cl1",
"name": "customer_id",
"comment": "customer id"
},
"guid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 1704190056433,
"updateTime": 1704190056433,
"version": 0,
"classifications": [
{
"typeName": "PII",
"entityGuid": "f8ded729-7bad-48dd-9969-c5b36a8d5b9c",
"entityStatus": "ACTIVE",
"propagate": true,
"removePropagationsOnEntityDelete": false
}
],
"labels": []
},
"06f3f56c-8ed7-4930-93b3-8a4b6f81c505": {
"typeName": "StorageDesc",
"attributes": {
"qualifiedName": "sd:hdfs://host:8000/apps/warehouse/sales@cl1",
"name": "sd:hdfs://host:8000/apps/warehouse/sales"
},
"guid": "06f3f56c-8ed7-4930-93b3-8a4b6f81c505",
"isIncomplete": false,
"status": "ACTIVE",
"createdBy": "admin",
"updatedBy": "admin",
"createTime": 17041900553

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

> On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
> > Line 423 (original), 423 (patched)
> > 
> >
> > else block at #427 also needs to be updated to handle shell entity, 
> > right? Please review.
> > 
> > I suggest the following:
> > 
> > #416:  if (value != null) {
> > # ...
> > #418:  } else if (!attributeDef.getIsOptional()) {
> >  if (entityObj.isIncomplete()) {
> >continue;
> >  }

Shell Entity will be instance of AtlasEntity, hence this condition will not 
come for else block


> On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
> > Lines 1254 (patched)
> > 
> >
> > Looking at #1252, this block should be executed only for full-updates 
> > i.e. not partial update. In such case, shouldn't the vertex be updated to 
> > clear is-incomplete flag?
> > 
> > Perhaps #1252 should be replaced with:
> >   if (!isPartialUpdate && (entity.getIsIncomplete() == null || 
> > !entity.getIsIncomplete())) {

For export/import scenario, 
Consider target cluster has "A" shell entity,  export file has again same "A" 
shell entity, in this case we need not to convert it to actual entity, since 
export file has shell entity

Also for imports, isPartialUpdate is explicilty set to false.


- Priyanshi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/#review226865
---


On Aug. 16, 2024, 11:36 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75150/
> ---
> 
> (Updated Aug. 16, 2024, 11:36 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4892
> https://issues.apache.org/jira/browse/ATLAS-4892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem:
> 
> During import, if shell entity is present in the importing file, import is 
> getting failed.
> 
> Solution:
> 
> There is mandatory attribute check present which was not allowing to create 
> shell entity and the import was getting failed due to this implementation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  b51951fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  656c9d14b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  2f37eac6b 
> 
> 
> Diff: https://reviews.apache.org/r/75150/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/#review226865
---




intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Line 1192 (original), 1192 (patched)


To improve readability, consider replacing #1192 with the following:

  if (value == null) {
if (entityObj.getIsIncomplete()) {
  continue;
}



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java
Line 423 (original), 423 (patched)


else block at #427 also needs to be updated to handle shell entity, right? 
Please review.

I suggest the following:

#416:  if (value != null) {
# ...
#418:  } else if (!attributeDef.getIsOptional()) {
 if (entityObj.isIncomplete()) {
   continue;
 }



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Lines 1254 (patched)


Looking at #1252, this block should be executed only for full-updates i.e. 
not partial update. In such case, shouldn't the vertex be updated to clear 
is-incomplete flag?

Perhaps #1252 should be replaced with:
  if (!isPartialUpdate && (entity.getIsIncomplete() == null || 
!entity.getIsIncomplete())) {



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
Line 1272 (original), 1271 (patched)


Why is it necessary to skip adding incomplete entities to 
context.addUpdated() and context.addCreated() - #1272 and #1294 below?



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 289 (original), 296 (patched)


This change will result in change in current behavior:
- when entity.getLabels() is null, retail all existing labels in the entity 
vertex
- else, update entity vertext with the list of entity.getLabels(); if 
entity.getLabels() is empty, all existing labels in the vertex will be cleared

I suggest to revert the change in #296; if this was done to specifically 
address an issue, please add details in the JIRA.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
Lines 41 (patched)


entityGraphMapper can be marked final.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
Lines 78 (patched)


"RequestContext.get().isImportInProgress() && " is not needed in #78, due 
to #65.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
Lines 79 (patched)


entityGraphMapper might be null due to #44. Either the constructor at #43 
should be removed or a null check must be added before #79.


- Madhan Neethiraj


On Aug. 16, 2024, 11:36 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75150/
> ---
> 
> (Updated Aug. 16, 2024, 11:36 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4892
> https://issues.apache.org/jira/browse/ATLAS-4892
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem:
> 
> During import, if shell entity is present in the importing file, import is 
> getting failed.
> 
> Solution:
> 
> There is mandatory attribute check present which was not allowing to create 
> shell entity and the import was getting failed due to this implementation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
>  b51951fe2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  656c9d14b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
>  2f37eac6b 
> 
> 
> Diff: https://reviews.apache.org/r/75150/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/
---

(Updated Aug. 16, 2024, 11:36 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4892
https://issues.apache.org/jira/browse/ATLAS-4892


Repository: atlas


Description
---

Problem:

During import, if shell entity is present in the importing file, import is 
getting failed.

Solution:

There is mandatory attribute check present which was not allowing to create 
shell entity and the import was getting failed due to this implementation.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 b51951fe2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 656c9d14b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 2f37eac6b 


Diff: https://reviews.apache.org/r/75150/diff/4/

Changes: https://reviews.apache.org/r/75150/diff/3-4/


Testing
---


Thanks,

Priyanshi Shah

Re: Review Request 75150: ATLAS-4892 : Export/Import APIs: Unable to import shell entities

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75150/
---

(Updated Aug. 16, 2024, 10:43 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4892
https://issues.apache.org/jira/browse/ATLAS-4892


Repository: atlas


Description
---

Problem:

During import, if shell entity is present in the importing file, import is 
getting failed.

Solution:

There is mandatory attribute check present which was not allowing to create 
shell entity and the import was getting failed due to this implementation.


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java
 b51951fe2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 656c9d14b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java
 2f37eac6b 


Diff: https://reviews.apache.org/r/75150/diff/3/


Testing
---


Thanks,

Priyanshi Shah

Re: Review Request 75111: ATLAS-4888 - Code refactor in /api/atlas/admin/version

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75111/
---

(Updated Aug. 8, 2024, 5:08 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.


Repository: atlas


Description (updated)
---

Code refactor in API - /api/atlas/admin/version


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
475756981 


Diff: https://reviews.apache.org/r/75111/diff/1/


Testing (updated)
---

Tested Following:-

Tested API - /api/atlas/admin/version which works fine without atlas restart 
after the code changes.

Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1678/console


Thanks,

Vinayak Marraiya

Re: Review Request 75110: ATLAS-4859 : NPE during Atlas Import

[Sheetal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75110/#review226780
---


Ship it!




Ship It!

- Sheetal Shah


On Aug. 5, 2024, 4:30 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75110/
> ---
> 
> (Updated Aug. 5, 2024, 4:30 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4859
> https://issues.apache.org/jira/browse/ATLAS-4859
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While doing an incremental import with multiple classifications associated 
> with entities it was giving NPE and import was getting failed.
> 
> Problem:
> This issue occured because Task executor was running in different thread and 
> then the import one and the task which was first in pending state gets 
> completed before coming into implementation of code which handles all pending 
> tasks and hence,it was throwing NullPointerException.
> 
> Solution:
> Fix by adding null check before executing further.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
> 
> 
> Diff: https://reviews.apache.org/r/75110/diff/2/
> 
> 
> Testing
> ---
> 
> Did manual testing for this and also ran PC.
> PC: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1669/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75110: ATLAS-4859 : NPE during Atlas Import

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75110/#review226772
---


Ship it!




Ship It!

- Mandar Ambawane


On Aug. 5, 2024, 11 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75110/
> ---
> 
> (Updated Aug. 5, 2024, 11 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4859
> https://issues.apache.org/jira/browse/ATLAS-4859
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> While doing an incremental import with multiple classifications associated 
> with entities it was giving NPE and import was getting failed.
> 
> Problem:
> This issue occured because Task executor was running in different thread and 
> then the import one and the task which was first in pending state gets 
> completed before coming into implementation of code which handles all pending 
> tasks and hence,it was throwing NullPointerException.
> 
> Solution:
> Fix by adding null check before executing further.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  77ab99a96 
> 
> 
> Diff: https://reviews.apache.org/r/75110/diff/2/
> 
> 
> Testing
> ---
> 
> Did manual testing for this and also ran PC.
> PC: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1669/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75110: ATLAS-4859 : NPE during Atlas Import

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75110/
---

(Updated Aug. 5, 2024, 11 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4859
https://issues.apache.org/jira/browse/ATLAS-4859


Repository: atlas


Description
---

While doing an incremental import with multiple classifications associated with 
entities it was giving NPE and import was getting failed.

Problem:
This issue occured because Task executor was running in different thread and 
then the import one and the task which was first in pending state gets 
completed before coming into implementation of code which handles all pending 
tasks and hence,it was throwing NullPointerException.

Solution:
Fix by adding null check before executing further.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 


Diff: https://reviews.apache.org/r/75110/diff/2/

Changes: https://reviews.apache.org/r/75110/diff/1-2/


Testing
---

Did manual testing for this and also ran PC.
PC: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1669/


Thanks,

Priyanshi Shah

Re: Review Request 75110: ATLAS-4859 : NPE during Atlas Import

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75110/
---

(Updated July 29, 2024, 12:43 p.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4859
https://issues.apache.org/jira/browse/ATLAS-4859


Repository: atlas


Description (updated)
---

While doing an incremental import with multiple classifications associated with 
entities it was giving NPE and import was getting failed.

Problem:
This issue occured because Task executor was running in different thread and 
then the import one and the task which was first in pending state gets 
completed before coming into implementation of code which handles all pending 
tasks and hence,it was throwing NullPointerException.

Solution:
Fix by adding null check before executing further.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 77ab99a96 


Diff: https://reviews.apache.org/r/75110/diff/1/


Testing (updated)
---

Did manual testing for this and also ran PC.
PC: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1669/


Thanks,

Priyanshi Shah

Re: Review Request 74961: ATLAS-4854 : Atlas - Upgrade Spring Security to 5.8.11

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74961/#review226733
---


Ship it!




Ship It!

- Mandar Ambawane


On June 17, 2024, 7:47 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74961/
> ---
> 
> (Updated June 17, 2024, 7:47 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4854
> https://issues.apache.org/jira/browse/ATLAS-4854
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using Spring security version 5.8.5 upgrading it to 5.8.11
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74961/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74965: ATLAS-4844 : Atlas - Upgrade Common Configuration2 to 2.10.1

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74965/#review226732
---


Ship it!




Ship It!

- Mandar Ambawane


On June 17, 2024, 7:46 a.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74965/
> ---
> 
> (Updated June 17, 2024, 7:46 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4844
> https://issues.apache.org/jira/browse/ATLAS-4844
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using common configuration2 version 2.8.0 upgrading it to 
> 2.10.1
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74965/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 75092: ATLAS-4886 : Need to add fields to the response of utility to analyze hook notifications

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75092/
---

(Updated July 18, 2024, 4:10 a.m.)


Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, and Pinal 
Shah.


Bugs: ATLAS-4886
https://issues.apache.org/jira/browse/ATLAS-4886


Repository: atlas


Description (updated)
---

Need to add time related fields to the response of utility like 
notificationStartTime,notificationEndTime,notificationDuration

notificationStartTime =  It is message creation time of the first message 
received from the hook

notificationEndTime =  It is message creation time of the last message received 
from the hook

notificationDuration = It is the difference between the startTime and endTime


Diffs
-

  
tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
 20b106546 


Diff: https://reviews.apache.org/r/75092/diff/2/


Testing (updated)
---

The fields added to response are
   "notificationStartTime":"2024-06-28 19:01:13",
   "notificationEndTime":"2024-06-28 19:02:33",
   "notificationDuration":"DAYS: 0, HOURS: 0, MINUTES: 1, SECONDS: 20"

Response :

{"messages":1321,"notifications":1073,"notificationLengthAvg":33105,"notificationLengthMax":514910,"splitNotifications":1,"splitNotificationLengthAvg":514910,"splitNotificationLengthMax":514910,"entities":496,"notificationEntities":1073,"notificationByType":{"ENTITY_CREATE_V2":1073},"notificationEntityByType":{"hdfs_path":12,"spark_application":475,"rdbms_table":111,"spark_process":475},"entityOperations":{"CREATE":496,"UPDATE":577},"entityOperationsByType":{"CREATE":{"hdfs_path":2,"rdbms_table":3,"spark_application":16,"spark_process":475},"UPDATE":{"hdfs_path":10,"rdbms_table":108,"spark_application":459}},
"notificationStartTime":"2024-06-28 19:01:13",
"notificationEndTime":"2024-06-28 19:02:33",
"notificationDuration":"DAYS: 0, HOURS: 0, MINUTES: 1, SECONDS: 20"
}


Thanks,

Prashant Satam

Re: Request to join Atlas project

[Madhan Neethiraj]

Prashant,

 

Thank you for your interest in contributing to Apache Atlas. You now have 
contributor access.

 

Welcome to Apache Atlas.

 

Thanks,

Madhan

 

 

 

 

From: Prashant Satam 
Date: Wednesday, July 17, 2024 at 3:43 AM
To: "mad...@apache.org" 
Subject: Request to join Atlas project

 

Hi team,

 

I would like to contribute to the Atlas project, Can you please add me as

contributor. My Apache id is : Prashant_Satam

 

Regards,

Prashant Satam

Re: Review Request 75092: ATLAS-4886 : Need to add fields to the response of utility to analyze hook notifications

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75092/
---

(Updated July 17, 2024, 12:07 p.m.)


Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, and Pinal 
Shah.


Bugs: ATLAS-4886
https://issues.apache.org/jira/browse/ATLAS-4886


Repository: atlas


Description
---

Need to add time related fields to the response of utility like 
startTime,endTime,duration

startTime =  It is message creation time of the first message received from the 
hook

endTime =  It is message creation time of the last message received from the 
hook

duration = It is the difference between the startTime and endTime


Diffs
-

  
tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
 20b106546 


Diff: https://reviews.apache.org/r/75092/diff/2/


Testing (updated)
---

the fields added to response are
"startTime":"2024-06-28 19:01:13",
"endTime":"2024-06-28 19:02:33",
"duration":"DAYS: 0, HOURS: 0, MINUTES: 1, SECONDS: 20"

Response :

{"messages":1321,"notifications":1073,"notificationLengthAvg":33105,"notificationLengthMax":514910,"splitNotifications":1,"splitNotificationLengthAvg":514910,"splitNotificationLengthMax":514910,"entities":496,"notificationEntities":1073,"notificationByType":{"ENTITY_CREATE_V2":1073},"notificationEntityByType":{"hdfs_path":12,"spark_application":475,"rdbms_table":111,"spark_process":475},"entityOperations":{"CREATE":496,"UPDATE":577},"entityOperationsByType":{"CREATE":{"hdfs_path":2,"rdbms_table":3,"spark_application":16,"spark_process":475},"UPDATE":{"hdfs_path":10,"rdbms_table":108,"spark_application":459}},
"startTime":"2024-06-28 19:01:13",
"endTime":"2024-06-28 19:02:33",
"duration":"DAYS: 0, HOURS: 0, MINUTES: 1, SECONDS: 20"
}


Thanks,

Prashant Satam

Re: Review Request 75092: ATLAS-4886 : Need to add fields to the response of utility to analyze hook notifications

[Prashant Satam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75092/
---

(Updated July 17, 2024, noon)


Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, and Pinal 
Shah.


Bugs: ATLAS-4886
https://issues.apache.org/jira/browse/ATLAS-4886


Repository: atlas


Description
---

Need to add time related fields to the response of utility like 
startTime,endTime,duration

startTime =  It is message creation time of the first message received from the 
hook

endTime =  It is message creation time of the last message received from the 
hook

duration = It is the difference between the startTime and endTime


Diffs (updated)
-

  
tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
 20b106546 


Diff: https://reviews.apache.org/r/75092/diff/2/

Changes: https://reviews.apache.org/r/75092/diff/1-2/


Testing
---

response :

{"messages":1321,"notifications":1073,"notificationLengthAvg":33105,"notificationLengthMax":514910,"splitNotifications":1,"splitNotificationLengthAvg":514910,"splitNotificationLengthMax":514910,"entities":496,"notificationEntities":1073,"notificationByType":{"ENTITY_CREATE_V2":1073},"notificationEntityByType":{"hdfs_path":12,"spark_application":475,"rdbms_table":111,"spark_process":475},"entityOperations":{"CREATE":496,"UPDATE":577},"entityOperationsByType":{"CREATE":{"hdfs_path":2,"rdbms_table":3,"spark_application":16,"spark_process":475},"UPDATE":{"hdfs_path":10,"rdbms_table":108,"spark_application":459}},"startTime":"2024-06-28
 19:01:13","endTime":"2024-06-28 19:02:33","duration":"DAYS: 0, HOURS: 0, 
MINUTES: 1, SECONDS: 20"}


Thanks,

Prashant Satam

Re: Review Request 75092: ATLAS-4886 : Need to add fields to the response of utility to analyze hook notifications

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75092/#review226691
---




tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
Lines 43 (patched)


Use only required import instead of java.time.*



tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
Lines 191 (patched)


Make the key as "notificationStartTime", "notificationEndTime", 
"notificationDuration"


- Jayendra Parab


On July 17, 2024, 10:19 a.m., Prashant Satam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75092/
> ---
> 
> (Updated July 17, 2024, 10:19 a.m.)
> 
> 
> Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-4886
> https://issues.apache.org/jira/browse/ATLAS-4886
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Need to add time related fields to the response of utility like 
> startTime,endTime,duration
> 
> startTime =  It is message creation time of the first message received from 
> the hook
> 
> endTime =  It is message creation time of the last message received from the 
> hook
> 
> duration = It is the difference between the startTime and endTime
> 
> 
> Diffs
> -
> 
>   
> tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
>  20b106546 
> 
> 
> Diff: https://reviews.apache.org/r/75092/diff/1/
> 
> 
> Testing
> ---
> 
> response :
> 
> {"messages":1321,"notifications":1073,"notificationLengthAvg":33105,"notificationLengthMax":514910,"splitNotifications":1,"splitNotificationLengthAvg":514910,"splitNotificationLengthMax":514910,"entities":496,"notificationEntities":1073,"notificationByType":{"ENTITY_CREATE_V2":1073},"notificationEntityByType":{"hdfs_path":12,"spark_application":475,"rdbms_table":111,"spark_process":475},"entityOperations":{"CREATE":496,"UPDATE":577},"entityOperationsByType":{"CREATE":{"hdfs_path":2,"rdbms_table":3,"spark_application":16,"spark_process":475},"UPDATE":{"hdfs_path":10,"rdbms_table":108,"spark_application":459}},"startTime":"2024-06-28
>  19:01:13","endTime":"2024-06-28 19:02:33","duration":"DAYS: 0, HOURS: 0, 
> MINUTES: 1, SECONDS: 20"}
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>

Re: Review Request 75014: ATLAS-4867 : Improve Metrics API

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/#review226659
---




repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 421 (patched)


How performant are these count() calls? In a deployment with large number 
of entities, it is critical to ensure that these calls don't cause performance 
issues - like by retrieving all vertices and edges to memory.

Alternatively, consider using index queries to retrieve vertex and edge 
counts - similar to how  MetricsService retrieves entity counts.


- Madhan Neethiraj


On July 11, 2024, 1:53 p.m., Paresh Devalia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75014/
> ---
> 
> (Updated July 11, 2024, 1:53 p.m.)
> 
> 
> Review request for atlas, Mandar Ambawane and Pinal Shah.
> 
> 
> Bugs: ATLAS-4867
> https://issues.apache.org/jira/browse/ATLAS-4867
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Metrics API : http://<>/api/atlas/admin/metrics
> 
> 1. There is some information in the Metrics API response, which is not been 
> used like Count of the typeAndSubTypes, Active, deleted, Shell
> Approach:
> Identify time taken by the above counts
> Take reading of metric api
> Take reading of metric api without the above counts
> 
> 
> 2. Also we can get the total number of count of vertices and edges present in 
> graph
> This  helps in estimating the time on Reindexing Patch.
> Also it may be helpful while debugging the escalations
> Approach:
> Embed this count in MetricUtil
> Or
> Create seperate API
> 
> 
> Diffs
> -
> 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  004cab9c8 
>   intg/src/main/java/org/apache/atlas/model/graph/AtlasGraphDetails.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> 9ec2cd2cb 
>   repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 
> a13e07387 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 475756981 
> 
> 
> Diff: https://reviews.apache.org/r/75014/diff/2/
> 
> 
> Testing
> ---
> 
> With typeAndSubTypes data it took 217ms for Metric API 
> Without typeAndSubTypes data, it took 180ms for Metric API 
> Without typeAndSubTypes and include the graph vertex and edge count took 
> almost 300++ ms
> 
> PC build:- 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1662/console
> 
> Create a new API to fetch the graph details.
> 
> Graph API Request :- http://<>/api/atlas/admin/graph
> 
> Response :- 
> {
> "data": {
> "general": {
> "Graph:": {
> "Graph:edgesCount": 286,
> "Graph:verticesCount": 697
> }
> }
> }
> }
> 
> 
> File Attachments
> 
> 
> AtlasGraphDetails.java
>   
> https://reviews.apache.org/media/uploaded/files/2024/07/11/3199de1d-ba43-4951-bc01-d42462c38518__AtlasGraphDetails.java
> AtlasGraphDetails.java
>   
> https://reviews.apache.org/media/uploaded/files/2024/07/11/6da399ce-a9fc-47c7-9acd-32149fcef2e4__AtlasGraphDetails.java
> 
> 
> Thanks,
> 
> Paresh Devalia
> 
>

Re: Review Request 75014: ATLAS-4867 : Improve Metrics API

[Paresh Devalia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/
---

(Updated July 11, 2024, 1:53 p.m.)


Review request for atlas, Mandar Ambawane and Pinal Shah.


Bugs: ATLAS-4867
https://issues.apache.org/jira/browse/ATLAS-4867


Repository: atlas


Description
---

Metrics API : http://<>/api/atlas/admin/metrics

1. There is some information in the Metrics API response, which is not been 
used like Count of the typeAndSubTypes, Active, deleted, Shell
Approach:
Identify time taken by the above counts
Take reading of metric api
Take reading of metric api without the above counts


2. Also we can get the total number of count of vertices and edges present in 
graph
This  helps in estimating the time on Reindexing Patch.
Also it may be helpful while debugging the escalations
Approach:
Embed this count in MetricUtil
Or
Create seperate API


Diffs
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 004cab9c8 
  intg/src/main/java/org/apache/atlas/model/graph/AtlasGraphDetails.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
9ec2cd2cb 
  repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 
a13e07387 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
475756981 


Diff: https://reviews.apache.org/r/75014/diff/2/


Testing
---

With typeAndSubTypes data it took 217ms for Metric API 
Without typeAndSubTypes data, it took 180ms for Metric API 
Without typeAndSubTypes and include the graph vertex and edge count took almost 
300++ ms

PC build:- 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1662/console

Create a new API to fetch the graph details.

Graph API Request :- http://<>/api/atlas/admin/graph

Response :- 
{
"data": {
"general": {
"Graph:": {
"Graph:edgesCount": 286,
"Graph:verticesCount": 697
}
}
}
}


File Attachments (updated)


AtlasGraphDetails.java
  
https://reviews.apache.org/media/uploaded/files/2024/07/11/3199de1d-ba43-4951-bc01-d42462c38518__AtlasGraphDetails.java
AtlasGraphDetails.java
  
https://reviews.apache.org/media/uploaded/files/2024/07/11/6da399ce-a9fc-47c7-9acd-32149fcef2e4__AtlasGraphDetails.java


Thanks,

Paresh Devalia

Re: Review Request 75014: ATLAS-4867 : Improve Metrics API

[Paresh Devalia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/
---

(Updated July 11, 2024, 1:51 p.m.)


Review request for atlas, Mandar Ambawane and Pinal Shah.


Bugs: ATLAS-4867
https://issues.apache.org/jira/browse/ATLAS-4867


Repository: atlas


Description
---

Metrics API : http://<>/api/atlas/admin/metrics

1. There is some information in the Metrics API response, which is not been 
used like Count of the typeAndSubTypes, Active, deleted, Shell
Approach:
Identify time taken by the above counts
Take reading of metric api
Take reading of metric api without the above counts


2. Also we can get the total number of count of vertices and edges present in 
graph
This  helps in estimating the time on Reindexing Patch.
Also it may be helpful while debugging the escalations
Approach:
Embed this count in MetricUtil
Or
Create seperate API


Diffs (updated)
-

  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 004cab9c8 
  intg/src/main/java/org/apache/atlas/model/graph/AtlasGraphDetails.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
9ec2cd2cb 
  repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 
a13e07387 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
475756981 


Diff: https://reviews.apache.org/r/75014/diff/2/

Changes: https://reviews.apache.org/r/75014/diff/1-2/


Testing (updated)
---

With typeAndSubTypes data it took 217ms for Metric API 
Without typeAndSubTypes data, it took 180ms for Metric API 
Without typeAndSubTypes and include the graph vertex and edge count took almost 
300++ ms

PC build:- 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1662/console

Create a new API to fetch the graph details.

Graph API Request :- http://<>/api/atlas/admin/graph

Response :- 
{
"data": {
"general": {
"Graph:": {
"Graph:edgesCount": 286,
"Graph:verticesCount": 697
}
}
}
}


File Attachments (updated)


AtlasGraphDetails.java
  
https://reviews.apache.org/media/uploaded/files/2024/07/11/3199de1d-ba43-4951-bc01-d42462c38518__AtlasGraphDetails.java


Thanks,

Paresh Devalia

Re: Review Request 75007: ATLAS-4866: Export/Import: Skip adding processed guids in audit while importing huge zip

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75007/#review226593
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 25, 2024, 5:15 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75007/
> ---
> 
> (Updated June 25, 2024, 5:15 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Radhika Kundam.
> 
> 
> Bugs: ATLAS-4866
> https://issues.apache.org/jira/browse/ATLAS-4866
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background:** 
> 
> Atlas uses HBase as its store for audit repository.
> 
> After import, atlas store the audit entity with the import information along 
> with all the processed entitiy guids.
> 
> **Issue: **
> 
> When large sized export zipped file is imported, import gives below error, 
> internally import gets succesful, but fail creating audit.
> 
> *{"errorCode":"ATLAS-500-00-001","errorMessage":"org.janusgraph.core.JanusGraphException:
>  Could not commit transaction due to exception during 
> persistence","errorCause":"Could not commit transaction due to exception 
> during persistence"}*
> 
> When size of the entity is greater than "hbase.client.keyvalue.maxsize" 
> property then audit entity creation fails with  exception.
> 
> *Caused by: 
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 1 
> action: org.apache.hadoop.hbase.DoNotRetryIOException: 
> Cell[\x00\x00\x00\x00\x00\x00\x00\x00\x01\x05\xCC\xBB/l:\x00\x06\x18r\xB0\xBE\xFDH\xA00a11ed186467-ve0214-halxg-cloudera-com\xB2\x00\x00\x00\x00\x00\x0D\xB6Y/1715730740890001/Put/vlen=23826488/seqid=0]
>  with size 23826581 exceeds limit of 10485760 bytes
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.checkCellSizeLimit(RSRpcServices.java:906)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:992)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:927)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:892)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2855)
> at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45961)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:387)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:139)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)
> : 1 time, servers with issues: ve0214.halxg.cloudera.com,22101,1715690875185
> at 
> org.apache.hadoop.hbase.client.BatchErrors.makeException(BatchErrors.java:50)
> at 
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.getErrors(AsyncRequestFutureImpl.java:1228)
> at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:434)
> at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:422)
> at 
> org.janusgraph.diskstorage.hbase2.HTable2_0.batch(HTable2_0.java:51)
>  
> **Solution: **
> 
> Hence in this case, storing processed entities guids is skipped while 
> creating ExportImportAuditEntry when size of entity goes beyond the value (in 
> bytes) of below property
> 
> atlas.hbase.client.keyvalue.maxsize
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java
>  3afa17301 
> 
> 
> Diff: https://reviews.apache.org/r/75007/diff/2/
> 
> 
> Testing
> ---
> 
> manually verified through below api, processed entity guids is not stored
> 
> /api/atlas/admin/expimp/audit?userName=admin&operation=IMPORT
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1649/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 75007: ATLAS-4866: Export/Import: Skip adding processed guids in audit while importing huge zip

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75007/
---

(Updated June 25, 2024, 5:15 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
and Radhika Kundam.


Changes
---

addressed review comment


Bugs: ATLAS-4866
https://issues.apache.org/jira/browse/ATLAS-4866


Repository: atlas


Description
---

**Background:** 

Atlas uses HBase as its store for audit repository.

After import, atlas store the audit entity with the import information along 
with all the processed entitiy guids.

**Issue: **

When large sized export zipped file is imported, import gives below error, 
internally import gets succesful, but fail creating audit.

*{"errorCode":"ATLAS-500-00-001","errorMessage":"org.janusgraph.core.JanusGraphException:
 Could not commit transaction due to exception during 
persistence","errorCause":"Could not commit transaction due to exception during 
persistence"}*

When size of the entity is greater than "hbase.client.keyvalue.maxsize" 
property then audit entity creation fails with  exception.

*Caused by: 
org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 1 
action: org.apache.hadoop.hbase.DoNotRetryIOException: 
Cell[\x00\x00\x00\x00\x00\x00\x00\x00\x01\x05\xCC\xBB/l:\x00\x06\x18r\xB0\xBE\xFDH\xA00a11ed186467-ve0214-halxg-cloudera-com\xB2\x00\x00\x00\x00\x00\x0D\xB6Y/1715730740890001/Put/vlen=23826488/seqid=0]
 with size 23826581 exceeds limit of 10485760 bytes
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.checkCellSizeLimit(RSRpcServices.java:906)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:992)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:927)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:892)
at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2855)
at 
org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45961)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:387)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:139)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)
at 
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)
: 1 time, servers with issues: ve0214.halxg.cloudera.com,22101,1715690875185
at 
org.apache.hadoop.hbase.client.BatchErrors.makeException(BatchErrors.java:50)
at 
org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.getErrors(AsyncRequestFutureImpl.java:1228)
at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:434)
at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:422)
at org.janusgraph.diskstorage.hbase2.HTable2_0.batch(HTable2_0.java:51)
 
**Solution: **

Hence in this case, storing processed entities guids is skipped while creating 
ExportImportAuditEntry when size of entity goes beyond the value (in bytes) of 
below property

atlas.hbase.client.keyvalue.maxsize


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java
 3afa17301 


Diff: https://reviews.apache.org/r/75007/diff/2/

Changes: https://reviews.apache.org/r/75007/diff/1-2/


Testing
---

manually verified through below api, processed entity guids is not stored

/api/atlas/admin/expimp/audit?userName=admin&operation=IMPORT

Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1649/console


Thanks,

Pinal Shah

Re: Review Request 75053: ATLAS-4881: minor improvements in notification processing

[Radhika Kundam via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75053/#review226592
---


Ship it!




Ship It!

- Radhika Kundam


On June 24, 2024, 8:10 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75053/
> ---
> 
> (Updated June 24, 2024, 8:10 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra 
> Parab, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, and 
> Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4881
> https://issues.apache.org/jira/browse/ATLAS-4881
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - reduced noise in Atlas server log file by changing log levels during 
> notification processing from info to debug level
> - error handling during notificaiton processing updated to not retry if 
> failure was due to invalid data (like entity-type not found)
> - updated metrics log to include the total time taken to process a 
> notification
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPerfMetrics.java c72b2c3e2 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  7b02ac449 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveDbDDLPreprocessor.java
>  dcff0939d 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java
>  083e343b0 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java
>  83d4d7c1a 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java
>  f930d9f35 
> 
> 
> Diff: https://reviews.apache.org/r/75053/diff/3/
> 
> 
> Testing
> ---
> 
> - verified that notification preprocessing doesn't print logs in info level
> - pre-commit tests run: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1661/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 75007: ATLAS-4866: Export/Import: Skip adding processed guids in audit while importing huge zip

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75007/#review226584
---




repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java
Lines 180 (patched)


Consider moving #180 to #172 so that the overhead in checking for size 
(#173, #174) will only be performed for OPERATION_IMPORT.


- Madhan Neethiraj


On June 24, 2024, 2:58 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75007/
> ---
> 
> (Updated June 24, 2024, 2:58 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Radhika Kundam.
> 
> 
> Bugs: ATLAS-4866
> https://issues.apache.org/jira/browse/ATLAS-4866
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background:** 
> 
> Atlas uses HBase as its store for audit repository.
> 
> After import, atlas store the audit entity with the import information along 
> with all the processed entitiy guids.
> 
> **Issue: **
> 
> When large sized export zipped file is imported, import gives below error, 
> internally import gets succesful, but fail creating audit.
> 
> *{"errorCode":"ATLAS-500-00-001","errorMessage":"org.janusgraph.core.JanusGraphException:
>  Could not commit transaction due to exception during 
> persistence","errorCause":"Could not commit transaction due to exception 
> during persistence"}*
> 
> When size of the entity is greater than "hbase.client.keyvalue.maxsize" 
> property then audit entity creation fails with  exception.
> 
> *Caused by: 
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 1 
> action: org.apache.hadoop.hbase.DoNotRetryIOException: 
> Cell[\x00\x00\x00\x00\x00\x00\x00\x00\x01\x05\xCC\xBB/l:\x00\x06\x18r\xB0\xBE\xFDH\xA00a11ed186467-ve0214-halxg-cloudera-com\xB2\x00\x00\x00\x00\x00\x0D\xB6Y/1715730740890001/Put/vlen=23826488/seqid=0]
>  with size 23826581 exceeds limit of 10485760 bytes
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.checkCellSizeLimit(RSRpcServices.java:906)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doBatchOp(RSRpcServices.java:992)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicBatchOp(RSRpcServices.java:927)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.doNonAtomicRegionMutation(RSRpcServices.java:892)
> at 
> org.apache.hadoop.hbase.regionserver.RSRpcServices.multi(RSRpcServices.java:2855)
> at 
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:45961)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:387)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:139)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:369)
> at 
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:349)
> : 1 time, servers with issues: ve0214.halxg.cloudera.com,22101,1715690875185
> at 
> org.apache.hadoop.hbase.client.BatchErrors.makeException(BatchErrors.java:50)
> at 
> org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.getErrors(AsyncRequestFutureImpl.java:1228)
> at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:434)
> at org.apache.hadoop.hbase.client.HTable.batch(HTable.java:422)
> at 
> org.janusgraph.diskstorage.hbase2.HTable2_0.batch(HTable2_0.java:51)
>  
> **Solution: **
> 
> Hence in this case, storing processed entities guids is skipped while 
> creating ExportImportAuditEntry when size of entity goes beyond the value (in 
> bytes) of below property
> 
> atlas.hbase.client.keyvalue.maxsize
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportImportAuditService.java
>  3afa17301 
> 
> 
> Diff: https://reviews.apache.org/r/75007/diff/1/
> 
> 
> Testing
> ---
> 
> manually verified through below api, processed entity guids is not stored
> 
> /api/atlas/admin/expimp/audit?userName=admin&operation=IMPORT
> 
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1649/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 75053: ATLAS-4881: minor improvements in notification processing

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75053/
---

(Updated June 24, 2024, 3:10 p.m.)


Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra 
Parab, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, and 
Sidharth Mishra.


Changes
---

updated to address the review comment


Bugs: ATLAS-4881
https://issues.apache.org/jira/browse/ATLAS-4881


Repository: atlas


Description
---

- reduced noise in Atlas server log file by changing log levels during 
notification processing from info to debug level
- error handling during notificaiton processing updated to not retry if failure 
was due to invalid data (like entity-type not found)
- updated metrics log to include the total time taken to process a notification


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/utils/AtlasPerfMetrics.java c72b2c3e2 
  
webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 7b02ac449 
  
webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveDbDDLPreprocessor.java
 dcff0939d 
  
webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java
 083e343b0 
  
webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java
 83d4d7c1a 
  
webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java
 f930d9f35 


Diff: https://reviews.apache.org/r/75053/diff/2/

Changes: https://reviews.apache.org/r/75053/diff/1-2/


Testing (updated)
---

- verified that notification preprocessing doesn't print logs in info level
- pre-commit tests run: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1661/


Thanks,

Madhan Neethiraj

Re: Review Request 75053: ATLAS-4881: minor improvements in notification processing

[Radhika Kundam via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75053/#review226583
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
Line 938 (original), 945 (patched)


The current warning message is the same for both scenarios of aborting the 
process, which can be confusing. Please consider using distinct warning 
messages for each scenario to enhance clarity.


- Radhika Kundam


On June 18, 2024, 12:43 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75053/
> ---
> 
> (Updated June 18, 2024, 12:43 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra 
> Parab, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, and 
> Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4881
> https://issues.apache.org/jira/browse/ATLAS-4881
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - reduced noise in Atlas server log file by changing log levels during 
> notification processing from info to debug level
> - error handling during notificaiton processing updated to not retry if 
> failure was due to invalid data (like entity-type not found)
> - updated metrics log to include the total time taken to process a 
> notification
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/utils/AtlasPerfMetrics.java c72b2c3e2 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  7b02ac449 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveDbDDLPreprocessor.java
>  dcff0939d 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HivePreprocessor.java
>  083e343b0 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java
>  83d4d7c1a 
>   
> webapp/src/main/java/org/apache/atlas/notification/preprocessor/PreprocessorContext.java
>  f930d9f35 
> 
> 
> Diff: https://reviews.apache.org/r/75053/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that notification preprocessing doesn't print logs in info level
> - pre-commit tests run: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1654/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 75054: ATLAS-4882: Export/Import: Export exits with 'Found 0 entities'

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75054/#review226581
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 18, 2024, 7:54 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75054/
> ---
> 
> (Updated June 18, 2024, 7:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Radhika PC.
> 
> 
> Bugs: ATLAS-4882
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> please check the jira description 
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java
>  d01d6775a 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
>  5b10c353e 
> 
> 
> Diff: https://reviews.apache.org/r/75054/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 74964: Atlas - Upgrade Nimbus-JOSE-JWT to 9.37.3

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74964/#review226564
---


Ship it!




Ship It!

- Priyanshi Shah


On April 24, 2024, 7:10 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74964/
> ---
> 
> (Updated April 24, 2024, 7:10 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Priyanshi Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4855
> https://issues.apache.org/jira/browse/ATLAS-4855
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is currently pulling in nimbus-jose-jwt 9.8.1. Upgrate it to 9.37.3
> 
> 
> Diffs
> -
> 
>   webapp/pom.xml 7d2d4c952 
> 
> 
> Diff: https://reviews.apache.org/r/74964/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 74961: ATLAS-4854 : Atlas - Upgrade Spring Security to 5.8.11

[Sheetal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74961/#review226563
---


Ship it!




Ship It!

- Sheetal Shah


On June 17, 2024, 1:17 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74961/
> ---
> 
> (Updated June 17, 2024, 1:17 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4854
> https://issues.apache.org/jira/browse/ATLAS-4854
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using Spring security version 5.8.5 upgrading it to 5.8.11
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74961/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74965: ATLAS-4844 : Atlas - Upgrade Common Configuration2 to 2.10.1

[Sheetal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74965/#review226562
---


Ship it!




Ship It!

- Sheetal Shah


On June 17, 2024, 1:16 p.m., Priyanshi Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74965/
> ---
> 
> (Updated June 17, 2024, 1:16 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4844
> https://issues.apache.org/jira/browse/ATLAS-4844
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Atlas is using common configuration2 version 2.8.0 upgrading it to 
> 2.10.1
> 
> 
> Diffs
> -
> 
>   pom.xml 6e6724275 
> 
> 
> Diff: https://reviews.apache.org/r/74965/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done and ran PC
> PC link: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/
> 
> 
> Thanks,
> 
> Priyanshi Shah
> 
>

Re: Review Request 74964: Atlas - Upgrade Nimbus-JOSE-JWT to 9.37.3

[Sheetal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74964/#review226561
---


Ship it!




Ship It!

- Sheetal Shah


On April 25, 2024, 12:40 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74964/
> ---
> 
> (Updated April 25, 2024, 12:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Priyanshi Shah, and Sheetal Shah.
> 
> 
> Bugs: ATLAS-4855
> https://issues.apache.org/jira/browse/ATLAS-4855
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is currently pulling in nimbus-jose-jwt 9.8.1. Upgrate it to 9.37.3
> 
> 
> Diffs
> -
> 
>   webapp/pom.xml 7d2d4c952 
> 
> 
> Diff: https://reviews.apache.org/r/74964/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 75054: ATLAS-4882: Export/Import: Export exits with 'Found 0 entities'

[Pinal Shah]

> On June 18, 2024, 8:04 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
> > Line 41 (original), 41 (patched)
> > 
> >
> > Is removing ".has('__guid')" not needed in line #41, #42, #45?

Above queries are used in VertexExtractor and below is the condition of 
extractor strategy

 return (atlasEntityDef == null || 
atlasEntityDef.getRelationshipAttributeDefs().size() == 0)
? extractors.get(VERTEX_BASED_EXTRACT)
: extractors.get(RELATION_BASED_EXTRACT);

I was not able to verify it, since couldn't get the usecase of the 
vertexExtractor Strategy


- Pinal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75054/#review226559
---


On June 18, 2024, 7:54 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75054/
> ---
> 
> (Updated June 18, 2024, 7:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Radhika PC.
> 
> 
> Bugs: ATLAS-4882
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> please check the jira description 
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java
>  d01d6775a 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
>  5b10c353e 
> 
> 
> Diff: https://reviews.apache.org/r/75054/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 75054: ATLAS-4882: Export/Import: Export exits with 'Found 0 entities'

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75054/#review226559
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
Line 41 (original), 41 (patched)


Is removing ".has('__guid')" not needed in line #41, #42, #45?


- Madhan Neethiraj


On June 18, 2024, 7:54 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75054/
> ---
> 
> (Updated June 18, 2024, 7:54 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Radhika PC.
> 
> 
> Bugs: ATLAS-4882
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> please check the jira description 
> https://issues.apache.org/jira/browse/ATLAS-4882
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/StartEntityFetchByExportRequest.java
>  d01d6775a 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java
>  5b10c353e 
> 
> 
> Diff: https://reviews.apache.org/r/75054/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verified
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 75041: ATLAS-4878: utility to analyze hook notifications

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75041/#review226558
---


Ship it!




Ship It!

- Pinal Shah


On June 13, 2024, 12:19 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75041/
> ---
> 
> (Updated June 13, 2024, 12:19 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra 
> Parab, Mandar Ambawane, Pinal Shah, Radhika Kundam, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4878
> https://issues.apache.org/jira/browse/ATLAS-4878
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This utility analyzes hook notification messages from a file and reports the 
> details listed in README. This utility will be useful in troubleshooting.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 874b944f2 
>   distro/src/main/assemblies/notification-analyzer.xml PRE-CREATION 
>   pom.xml 2f9aedbd2 
>   tools/notification-analyzer/README PRE-CREATION 
>   tools/notification-analyzer/pom.xml PRE-CREATION 
>   tools/notification-analyzer/scripts/notification-analyzer.sh PRE-CREATION 
>   
> tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
>  PRE-CREATION 
>   tools/notification-analyzer/src/main/resources/atlas-application.properties 
> PRE-CREATION 
>   tools/notification-analyzer/src/main/resources/atlas-log4j.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/75041/diff/3/
> 
> 
> Testing
> ---
> 
> - setup and ran the utility using the instructions in README
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74961: ATLAS-4854 : Atlas - Upgrade Spring Security to 5.8.11

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74961/
---

(Updated June 17, 2024, 7:47 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4854
https://issues.apache.org/jira/browse/ATLAS-4854


Repository: atlas


Description
---

Currently Atlas is using Spring security version 5.8.5 upgrading it to 5.8.11


Diffs
-

  pom.xml 6e6724275 


Diff: https://reviews.apache.org/r/74961/diff/1/


Testing (updated)
---

Manual testing done and ran PC
PC link: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/


Thanks,

Priyanshi Shah

Re: Review Request 74965: ATLAS-4844 : Atlas - Upgrade Common Configuration2 to 2.10.1

[Priyanshi Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74965/
---

(Updated June 17, 2024, 7:46 a.m.)


Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
Sheetal Shah.


Bugs: ATLAS-4844
https://issues.apache.org/jira/browse/ATLAS-4844


Repository: atlas


Description
---

Currently Atlas is using common configuration2 version 2.8.0 upgrading it to 
2.10.1


Diffs
-

  pom.xml 6e6724275 


Diff: https://reviews.apache.org/r/74965/diff/1/


Testing (updated)
---

Manual testing done and ran PC
PC link: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1651/


Thanks,

Priyanshi Shah

Re: [PR] Update pom.xml [atlas]

[via GitHub]

smileyboy2019 commented on PR #247:
URL: https://github.com/apache/atlas/pull/247#issuecomment-2172501864

   add flink hook


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Update pom.xml [atlas]

[via GitHub]

smileyboy2019 commented on PR #247:
URL: https://github.com/apache/atlas/pull/247#issuecomment-2172500278

   add flink hook


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/#review226552
---


Ship it!




Ship It!

- Jayendra Parab


On June 14, 2024, 12:52 p.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75049/
> ---
> 
> (Updated June 14, 2024, 12:52 p.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4880
> https://issues.apache.org/jira/browse/ATLAS-4880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas UI  show 'Something went wrong'.
> we need to temporarily disable tasks API call made from UI and don't show the 
> tasks tab on Entity Detail page.
> 
> We need to:
> 
> Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
> default
> Make use of the above property on UI side to show the tasks tab on the entity 
> detail page. This will be in addition to the atlas.tasks.enabled property 
> which is used to enable/disable deferred actions
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/main.js 9c864cf8f 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 9e8cf4721 
>   dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
>   dashboardv3/public/js/main.js 69ffed9ae 
>   dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 53347ddf4 
>   dashboardv3/public/js/utils/Globals.js 056ac640e 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 89d1dd334 
> 
> 
> Diff: https://reviews.apache.org/r/75049/diff/4/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 
> 1)Session API
> 2)Detail Page
> 3)Search Result Page
> 4)Did changes in application properties with server side property 
> atlas.tasks.ui.tab.enabled with value true and  
>   false and verified the Task tab in UI.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Farhan Khan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/#review226548
---


Ship it!




Ship It!

- Farhan Khan


On June 14, 2024, 12:52 p.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75049/
> ---
> 
> (Updated June 14, 2024, 12:52 p.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4880
> https://issues.apache.org/jira/browse/ATLAS-4880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas UI  show 'Something went wrong'.
> we need to temporarily disable tasks API call made from UI and don't show the 
> tasks tab on Entity Detail page.
> 
> We need to:
> 
> Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
> default
> Make use of the above property on UI side to show the tasks tab on the entity 
> detail page. This will be in addition to the atlas.tasks.enabled property 
> which is used to enable/disable deferred actions
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/main.js 9c864cf8f 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 9e8cf4721 
>   dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
>   dashboardv3/public/js/main.js 69ffed9ae 
>   dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 53347ddf4 
>   dashboardv3/public/js/utils/Globals.js 056ac640e 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 89d1dd334 
> 
> 
> Diff: https://reviews.apache.org/r/75049/diff/4/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 
> 1)Session API
> 2)Detail Page
> 3)Search Result Page
> 4)Did changes in application properties with server side property 
> atlas.tasks.ui.tab.enabled with value true and  
>   false and verified the Task tab in UI.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/
---

(Updated June 14, 2024, 12:52 p.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.


Bugs: ATLAS-4880
https://issues.apache.org/jira/browse/ATLAS-4880


Repository: atlas


Description
---

Atlas UI  show 'Something went wrong'.
we need to temporarily disable tasks API call made from UI and don't show the 
tasks tab on Entity Detail page.

We need to:

Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
default
Make use of the above property on UI side to show the tasks tab on the entity 
detail page. This will be in addition to the atlas.tasks.enabled property which 
is used to enable/disable deferred actions


Diffs
-

  dashboardv2/public/js/main.js 9c864cf8f 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
9e8cf4721 
  dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
  dashboardv3/public/js/main.js 69ffed9ae 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
53347ddf4 
  dashboardv3/public/js/utils/Globals.js 056ac640e 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
89d1dd334 


Diff: https://reviews.apache.org/r/75049/diff/4/


Testing (updated)
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-

1)Session API
2)Detail Page
3)Search Result Page
4)Did changes in application properties with server side property 
atlas.tasks.ui.tab.enabled with value true and  
  false and verified the Task tab in UI.


Thanks,

Brijesh Bhalala

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/
---

(Updated June 14, 2024, 12:44 p.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.


Bugs: ATLAS-4880
https://issues.apache.org/jira/browse/ATLAS-4880


Repository: atlas


Description
---

Atlas UI  show 'Something went wrong'.
we need to temporarily disable tasks API call made from UI and don't show the 
tasks tab on Entity Detail page.

We need to:

Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
default
Make use of the above property on UI side to show the tasks tab on the entity 
detail page. This will be in addition to the atlas.tasks.enabled property which 
is used to enable/disable deferred actions


Diffs (updated)
-

  dashboardv2/public/js/main.js 9c864cf8f 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
9e8cf4721 
  dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
  dashboardv3/public/js/main.js 69ffed9ae 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
53347ddf4 
  dashboardv3/public/js/utils/Globals.js 056ac640e 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
89d1dd334 


Diff: https://reviews.apache.org/r/75049/diff/4/

Changes: https://reviews.apache.org/r/75049/diff/3-4/


Testing
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-

1)Session API
2)Detail Page
3)Search Result Page
4)Task Tab is disabled by default


Thanks,

Brijesh Bhalala

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/
---

(Updated June 14, 2024, 12:43 p.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.


Bugs: ATLAS-4880
https://issues.apache.org/jira/browse/ATLAS-4880


Repository: atlas


Description
---

Atlas UI  show 'Something went wrong'.
we need to temporarily disable tasks API call made from UI and don't show the 
tasks tab on Entity Detail page.

We need to:

Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
default
Make use of the above property on UI side to show the tasks tab on the entity 
detail page. This will be in addition to the atlas.tasks.enabled property which 
is used to enable/disable deferred actions


Diffs (updated)
-

  dashboardv2/public/js/main.js 9c864cf8f 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
9e8cf4721 
  dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
  dashboardv3/public/js/main.js 69ffed9ae 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
53347ddf4 
  dashboardv3/public/js/utils/Globals.js 056ac640e 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
89d1dd334 


Diff: https://reviews.apache.org/r/75049/diff/3/

Changes: https://reviews.apache.org/r/75049/diff/2-3/


Testing
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-

1)Session API
2)Detail Page
3)Search Result Page
4)Task Tab is disabled by default


Thanks,

Brijesh Bhalala

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/
---

(Updated June 14, 2024, 11:11 a.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.


Bugs: ATLAS-4880
https://issues.apache.org/jira/browse/ATLAS-4880


Repository: atlas


Description
---

Atlas UI  show 'Something went wrong'.
we need to temporarily disable tasks API call made from UI and don't show the 
tasks tab on Entity Detail page.

We need to:

Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
default
Make use of the above property on UI side to show the tasks tab on the entity 
detail page. This will be in addition to the atlas.tasks.enabled property which 
is used to enable/disable deferred actions


Diffs (updated)
-

  dashboardv2/public/js/main.js 9c864cf8f 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
9e8cf4721 
  dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
  dashboardv3/public/js/main.js 69ffed9ae 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
53347ddf4 
  dashboardv3/public/js/utils/Globals.js 056ac640e 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
89d1dd334 


Diff: https://reviews.apache.org/r/75049/diff/2/

Changes: https://reviews.apache.org/r/75049/diff/1-2/


Testing
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-

1)Session API
2)Detail Page
3)Search Result Page
4)Task Tab is disabled by default


Thanks,

Brijesh Bhalala

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

> On June 14, 2024, 11:02 a.m., Jayendra Parab wrote:
> >

I fix it and update the patch


- Brijesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/#review226546
---


On June 14, 2024, 11:01 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75049/
> ---
> 
> (Updated June 14, 2024, 11:01 a.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4880
> https://issues.apache.org/jira/browse/ATLAS-4880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas UI  show 'Something went wrong'.
> we need to temporarily disable tasks API call made from UI and don't show the 
> tasks tab on Entity Detail page.
> 
> We need to:
> 
> Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
> default
> Make use of the above property on UI side to show the tasks tab on the entity 
> detail page. This will be in addition to the atlas.tasks.enabled property 
> which is used to enable/disable deferred actions
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/main.js 9c864cf8f 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 9e8cf4721 
>   dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
>   dashboardv3/public/js/main.js 69ffed9ae 
>   dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 53347ddf4 
>   dashboardv3/public/js/utils/Globals.js 056ac640e 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 89d1dd334 
> 
> 
> Diff: https://reviews.apache.org/r/75049/diff/1/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 
> 1)Session API
> 2)Detail Page
> 3)Search Result Page
> 4)Task Tab is disabled by default
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/#review226546
---




intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 93 (patched)


Add this enum at the end of the list, after RELATIONSHIP_SEARCH_ENABLED


- Jayendra Parab


On June 14, 2024, 11:01 a.m., Brijesh Bhalala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75049/
> ---
> 
> (Updated June 14, 2024, 11:01 a.m.)
> 
> 
> Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4880
> https://issues.apache.org/jira/browse/ATLAS-4880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas UI  show 'Something went wrong'.
> we need to temporarily disable tasks API call made from UI and don't show the 
> tasks tab on Entity Detail page.
> 
> We need to:
> 
> Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
> default
> Make use of the above property on UI side to show the tasks tab on the entity 
> detail page. This will be in addition to the atlas.tasks.enabled property 
> which is used to enable/disable deferred actions
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/main.js 9c864cf8f 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 9e8cf4721 
>   dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
>   dashboardv3/public/js/main.js 69ffed9ae 
>   dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> 53347ddf4 
>   dashboardv3/public/js/utils/Globals.js 056ac640e 
>   dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 89d1dd334 
> 
> 
> Diff: https://reviews.apache.org/r/75049/diff/1/
> 
> 
> Testing
> ---
> 
> Build the Atlas with below command :-
> mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true
> 
> Valdiated the below scenarios:-
> 
> 1)Session API
> 2)Detail Page
> 3)Search Result Page
> 4)Task Tab is disabled by default
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 75049: ATLAS-4880: Temporarily disable the tasks tab on Entity Detail page

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75049/
---

(Updated June 14, 2024, 11:01 a.m.)


Review request for atlas, Farhan Khan, Jayendra Parab, and Prasad Pawar.


Bugs: ATLAS-4880
https://issues.apache.org/jira/browse/ATLAS-4880


Repository: atlas


Description
---

Atlas UI  show 'Something went wrong'.
we need to temporarily disable tasks API call made from UI and don't show the 
tasks tab on Entity Detail page.

We need to:

Add a server side property atlas.tasks.ui.tab.enabled, which is disabled by 
default
Make use of the above property on UI side to show the tasks tab on the entity 
detail page. This will be in addition to the atlas.tasks.enabled property which 
is used to enable/disable deferred actions


Diffs
-

  dashboardv2/public/js/main.js 9c864cf8f 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
9e8cf4721 
  dashboardv2/public/js/utils/Globals.js 8ea4aafe7 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 428485315 
  dashboardv3/public/js/main.js 69ffed9ae 
  dashboardv3/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
53347ddf4 
  dashboardv3/public/js/utils/Globals.js 056ac640e 
  dashboardv3/public/js/views/detail_page/DetailPageLayoutView.js 940b5b769 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 0868f8b6e 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
89d1dd334 


Diff: https://reviews.apache.org/r/75049/diff/1/


Testing (updated)
---

Build the Atlas with below command :-
mvn clean package -Pdist,embedded-hbase-solr -DskipDocs -Drat.skip=true

Valdiated the below scenarios:-

1)Session API
2)Detail Page
3)Search Result Page
4)Task Tab is disabled by default


Thanks,

Brijesh Bhalala

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Umesh Padashetty]

Thanks for the report, Madhan. Looks good, +1

--
Thanks and Regards,
Umesh Padashetty


On Fri, 14 Jun 2024 at 12:57, Mandar Ambawane <
mandar.ambaw...@freestoneinfotech.com> wrote:

> +1, Thanks Madhan for the draft report.
>
> On Fri, Jun 14, 2024 at 12:36 PM Radhika Kundam 
> wrote:
>
> > +1, Thanks Madhan for the draft report.
> >
> > - Radhika
> >
> > On Fri, Jun 14, 2024 at 5:52 AM Madhan Neethiraj 
> > wrote:
> >
> > > Atlas community,
> > >
> > > Please review the following draft report for this quarter.
> > >
> > > Thanks,
> > > Madhan
> > >
> > >
> > > ## Description:
> > > The mission of Apache Atlas is the creation and maintenance of software
> > > related
> > > to a scalable and extensible set of core foundational governance
> > services -
> > > enabling enterprises to effectively and efficiently meet their
> compliance
> > > requirements
> > >
> > > ## Project Status:
> > > Current project status: Ongoing, with low activity
> > > Issues for the board: there are no issues requiring board attention
> > >
> > > ## Membership Data:
> > > Apache Atlas was founded 2017-06-20 (7 years ago)
> > > There are currently 48 committers and 32 PMC members in this project.
> > > The Committer-to-PMC ratio is 3:2.
> > >
> > > Community changes, past quarter:
> > > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> > >
> > > ## Project Activity:
> > > - improvements in Export/Import functionality
> > > - updates to support ignore patterns in all Atlas hooks
> > > - added support for Chinese characters in Atlas entity attributes
> > > - Docker setup update to address HBase failures
> > > - updated versions of dependent libraries JanusGraph and Tinkerpop
> > >
> > > ## Community Health:
> > > - dev@atlas.apache.org had a 166% increase in traffic in the past
> > quarter
> > > (312
> > >   emails compared to 117)
> > > - 23 commits in the past quarter (64% increase)
> > > - 7 code contributors in the past quarter (40% increase)
> > > - 4 PRs opened on GitHub, past quarter (100% increase)
> > > - 2 PRs closed on GitHub, past quarter (100% increase)
> > >
> > > ## Recent releases:
> > > - Apache Atlas 2.3.0 was released on 2022-12-06
> > > - Apache Atlas 2.2.0 was released on 2021-08-17
> > > - Apache Atlas 2.1.0 was released on 2020-07-15
> > >
> > >
> > >
> > >
> > >
> >
>
>
> --
> Thanks and Regards,
> Mandar V. Ambawane.
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Mandar Ambawane]

+1, Thanks Madhan for the draft report.

On Fri, Jun 14, 2024 at 12:36 PM Radhika Kundam 
wrote:

> +1, Thanks Madhan for the draft report.
>
> - Radhika
>
> On Fri, Jun 14, 2024 at 5:52 AM Madhan Neethiraj 
> wrote:
>
> > Atlas community,
> >
> > Please review the following draft report for this quarter.
> >
> > Thanks,
> > Madhan
> >
> >
> > ## Description:
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> > to a scalable and extensible set of core foundational governance
> services -
> > enabling enterprises to effectively and efficiently meet their compliance
> > requirements
> >
> > ## Project Status:
> > Current project status: Ongoing, with low activity
> > Issues for the board: there are no issues requiring board attention
> >
> > ## Membership Data:
> > Apache Atlas was founded 2017-06-20 (7 years ago)
> > There are currently 48 committers and 32 PMC members in this project.
> > The Committer-to-PMC ratio is 3:2.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> >
> > ## Project Activity:
> > - improvements in Export/Import functionality
> > - updates to support ignore patterns in all Atlas hooks
> > - added support for Chinese characters in Atlas entity attributes
> > - Docker setup update to address HBase failures
> > - updated versions of dependent libraries JanusGraph and Tinkerpop
> >
> > ## Community Health:
> > - dev@atlas.apache.org had a 166% increase in traffic in the past
> quarter
> > (312
> >   emails compared to 117)
> > - 23 commits in the past quarter (64% increase)
> > - 7 code contributors in the past quarter (40% increase)
> > - 4 PRs opened on GitHub, past quarter (100% increase)
> > - 2 PRs closed on GitHub, past quarter (100% increase)
> >
> > ## Recent releases:
> > - Apache Atlas 2.3.0 was released on 2022-12-06
> > - Apache Atlas 2.2.0 was released on 2021-08-17
> > - Apache Atlas 2.1.0 was released on 2020-07-15
> >
> >
> >
> >
> >
>


-- 
Thanks and Regards,
Mandar V. Ambawane.

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Radhika Kundam]

+1, Thanks Madhan for the draft report.

- Radhika

On Fri, Jun 14, 2024 at 5:52 AM Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: there are no issues requiring board attention
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
> ## Project Activity:
> - improvements in Export/Import functionality
> - updates to support ignore patterns in all Atlas hooks
> - added support for Chinese characters in Atlas entity attributes
> - Docker setup update to address HBase failures
> - updated versions of dependent libraries JanusGraph and Tinkerpop
>
> ## Community Health:
> - dev@atlas.apache.org had a 166% increase in traffic in the past quarter
> (312
>   emails compared to 117)
> - 23 commits in the past quarter (64% increase)
> - 7 code contributors in the past quarter (40% increase)
> - 4 PRs opened on GitHub, past quarter (100% increase)
> - 2 PRs closed on GitHub, past quarter (100% increase)
>
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Nikhil Bonte]

+1, Looks good, Thanks Madhan for putting this together



On Fri, 14 Jun 2024 at 5:52 AM, Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: there are no issues requiring board attention
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
> ## Project Activity:
> - improvements in Export/Import functionality
> - updates to support ignore patterns in all Atlas hooks
> - added support for Chinese characters in Atlas entity attributes
> - Docker setup update to address HBase failures
> - updated versions of dependent libraries JanusGraph and Tinkerpop
>
> ## Community Health:
> - dev@atlas.apache.org had a 166% increase in traffic in the past quarter
> (312
>   emails compared to 117)
> - 23 commits in the past quarter (64% increase)
> - 7 code contributors in the past quarter (40% increase)
> - 4 PRs opened on GitHub, past quarter (100% increase)
> - 2 PRs closed on GitHub, past quarter (100% increase)
>
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[pinal shah]

Looks Good +1
Thanks Madhan for putting this together

On Fri, Jun 14, 2024 at 7:42 AM Sarath Subramanian 
wrote:

> Thanks for the draft report Madhan. Looks good +1
>
>
> Thanks,
> Sarath
>
> > On Jun 13, 2024, at 5:23 PM, Madhan Neethiraj  wrote:
> >
> > Atlas community,
> >
> > Please review the following draft report for this quarter.
> >
> > Thanks,
> > Madhan
> >
> >
> > ## Description:
> > The mission of Apache Atlas is the creation and maintenance of software
> related
> > to a scalable and extensible set of core foundational governance
> services -
> > enabling enterprises to effectively and efficiently meet their compliance
> > requirements
> >
> > ## Project Status:
> > Current project status: Ongoing, with low activity
> > Issues for the board: there are no issues requiring board attention
> >
> > ## Membership Data:
> > Apache Atlas was founded 2017-06-20 (7 years ago)
> > There are currently 48 committers and 32 PMC members in this project.
> > The Committer-to-PMC ratio is 3:2.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> >
> > ## Project Activity:
> > - improvements in Export/Import functionality
> > - updates to support ignore patterns in all Atlas hooks
> > - added support for Chinese characters in Atlas entity attributes
> > - Docker setup update to address HBase failures
> > - updated versions of dependent libraries JanusGraph and Tinkerpop
> >
> > ## Community Health:
> > - dev@atlas.apache.org had a 166% increase in traffic in the past
> quarter (312
> >  emails compared to 117)
> > - 23 commits in the past quarter (64% increase)
> > - 7 code contributors in the past quarter (40% increase)
> > - 4 PRs opened on GitHub, past quarter (100% increase)
> > - 2 PRs closed on GitHub, past quarter (100% increase)
> >
> > ## Recent releases:
> > - Apache Atlas 2.3.0 was released on 2022-12-06
> > - Apache Atlas 2.2.0 was released on 2021-08-17
> > - Apache Atlas 2.1.0 was released on 2020-07-15
> >
> >
> >
> >
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Sarath Subramanian]

Thanks for the draft report Madhan. Looks good +1


Thanks,
Sarath

> On Jun 13, 2024, at 5:23 PM, Madhan Neethiraj  wrote:
> 
> Atlas community,
> 
> Please review the following draft report for this quarter.
> 
> Thanks,
> Madhan
> 
> 
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software 
> related
> to a scalable and extensible set of core foundational governance services -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
> 
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: there are no issues requiring board attention
> 
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
> 
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
> 
> ## Project Activity:
> - improvements in Export/Import functionality
> - updates to support ignore patterns in all Atlas hooks
> - added support for Chinese characters in Atlas entity attributes
> - Docker setup update to address HBase failures
> - updated versions of dependent libraries JanusGraph and Tinkerpop
> 
> ## Community Health:
> - dev@atlas.apache.org had a 166% increase in traffic in the past quarter (312
>  emails compared to 117)
> - 23 commits in the past quarter (64% increase)
> - 7 code contributors in the past quarter (40% increase)
> - 4 PRs opened on GitHub, past quarter (100% increase)
> - 2 PRs closed on GitHub, past quarter (100% increase)
> 
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
> 
> 
> 
> 

Re: [PR] hive-metadata [atlas]

[via GitHub]

smileyboy2019 commented on PR #214:
URL: https://github.com/apache/atlas/pull/214#issuecomment-2164283523

   Atals has not been updated in the past two years, is it not maintained
   Atals has not added the latest computing engines such as Flink and Doris, as 
well as a database that integrates lakes and warehouses


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MINOR] remove akka.version in pom.xml [atlas]

[via GitHub]

smileyboy2019 commented on PR #245:
URL: https://github.com/apache/atlas/pull/245#issuecomment-2164281724

   Atals has not been updated in the past two years, is it not maintained
   Atals has not added the latest computing engines such as Flink and Doris, as 
well as a database that integrates lakes and warehouses


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] DG-1432 - Auth policies for MQ related types [atlas]

[via GitHub]

arpit-at closed pull request #246: DG-1432 - Auth policies for MQ related types
URL: https://github.com/apache/atlas/pull/246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] DG-1432 - Auth policies for MQ related types [atlas]

[via GitHub]

arpit-at closed pull request #246: DG-1432 - Auth policies for MQ related types
URL: https://github.com/apache/atlas/pull/246


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 75041: ATLAS-4878: utility to analyze hook notifications

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75041/
---

(Updated June 13, 2024, 12:19 a.m.)


Review request for atlas, Ashutosh Mestry, chaitali, Disha Talreja, Jayendra 
Parab, Mandar Ambawane, Pinal Shah, Radhika Kundam, and Sarath Subramanian.


Changes
---

added following stats as well:
- notificationLengthAvg
- notificationLengthMax
- splitNotifications
- splitNotificationLengthAvg
- splitNotificationLengthMax


Bugs: ATLAS-4878
https://issues.apache.org/jira/browse/ATLAS-4878


Repository: atlas


Description
---

This utility analyzes hook notification messages from a file and reports the 
details listed in README. This utility will be useful in troubleshooting.


Diffs (updated)
-

  distro/pom.xml 874b944f2 
  distro/src/main/assemblies/notification-analyzer.xml PRE-CREATION 
  pom.xml 2f9aedbd2 
  tools/notification-analyzer/README PRE-CREATION 
  tools/notification-analyzer/pom.xml PRE-CREATION 
  tools/notification-analyzer/scripts/notification-analyzer.sh PRE-CREATION 
  
tools/notification-analyzer/src/main/java/org/apache/atlas/tools/NotificationAnalyzer.java
 PRE-CREATION 
  tools/notification-analyzer/src/main/resources/atlas-application.properties 
PRE-CREATION 
  tools/notification-analyzer/src/main/resources/atlas-log4j.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/75041/diff/2/

Changes: https://reviews.apache.org/r/75041/diff/1-2/


Testing
---

- setup and ran the utility using the instructions in README


Thanks,

Madhan Neethiraj

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated June 10, 2024, 12:36 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal 
Shah.


Repository: atlas


Description (updated)
---

Relationship search is now disabled (for backend and UI),by default and the 
value for atlas.relationship.search.enabled is false.
Relationship search will be enabled from backend and UI, if the value for 
atlas.relationship.search.enabled is true.


Diffs
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated June 10, 2024, 12:34 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal 
Shah.


Repository: atlas


Description (updated)
---

Relationship search  is disabled (for backend and UI),by default and the value 
for atlas.relationship.search.enabled is false.
Relationship search will be enabled from backend and UI, if the value for 
atlas.relationship.search.enabled is true.


Diffs
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated June 10, 2024, 12:33 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal 
Shah.


Repository: atlas


Description (updated)
---

Relationship search  is enabled (for backend and UI),by default and the value 
for atlas.relationship.search.enabled is true.
Relationship search will be disabled from backend and UI, if the value for 
atlas.relationship.search.enabled is false.


Diffs
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated June 10, 2024, 12:30 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal 
Shah.


Repository: atlas


Description (updated)
---

Relationship search  is enabled (for backend and UI),by default and the value 
for atlas.relationship.search.enabled is false.
Relationship search will be disabled from backend and UI, if the value for 
atlas.relationship.search.enabled is true.


Diffs
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: Review Request 74851: ATLAS-4822 : Relationship Search feature should be configurable

[Vinayak Marraiya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74851/
---

(Updated June 10, 2024, 12:29 p.m.)


Review request for atlas, Jayendra Parab, Pinal Shah, Prasad Pawar, and Sheetal 
Shah.


Repository: atlas


Description (updated)
---

Relationship search  is enabled (for backend and UI), by default and the value 
for atlas.relationship.search.enabled is false.
Relationship search will be disabled from backend and UI, if the value for 
atlas.relationship.search.enabled is true.


Diffs
-

  dashboardv2/public/css/scss/override.scss 0c5f8bc0d 
  dashboardv2/public/js/main.js f0cea7999 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html f049fa420 
  dashboardv2/public/js/utils/Globals.js 431a24b38 
  dashboardv2/public/js/views/search/SearchLayoutView.js c59a5d83e 
  dashboardv3/public/js/main.js 7423c88c3 
  dashboardv3/public/js/utils/Globals.js 410d82881 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js c81a74fd8 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 
ea7185b35 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 090889e1c 
  
repository/src/main/java/org/apache/atlas/repository/patches/RelationshipTypeNamePatch.java
 c3a9106fa 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
27ec59d37 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java d1d19075f 


Diff: https://reviews.apache.org/r/74851/diff/10/


Testing
---

Tested following:

1. Checked whether default behaviour (relationship search APIs are disabled in 
UI) works.
2. Checked whether following APIs are disabled when property is set to false.
GET/POST /v2/search/relations
GET /v2/search/relationship
3. Checked whether current basic search and dsl search functionalities work 
even when relationship search is disabled.
4. Tested disabling and enabling of property


Precommit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1543/console


Thanks,

Vinayak Marraiya

Re: Review Request 75025: ATLAS-4875: compression type specified for HBase backend store should be used by HBase audit store as well

[Radhika Kundam via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75025/#review226501
---


Ship it!




Ship It!

- Radhika Kundam


On June 1, 2024, 11:48 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75025/
> ---
> 
> (Updated June 1, 2024, 11:48 a.m.)
> 
> 
> Review request for atlas, chaitali, Disha Talreja, Jayendra Parab, Mehul 
> Parikh, Pinal Shah, Radhika Kundam, and Vinayak Marraiya.
> 
> 
> Bugs: ATLAS-4875
> https://issues.apache.org/jira/browse/ATLAS-4875
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated HBase audit store to use the compression type specified for HBase 
> backend store
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  9161cc8ff 
> 
> 
> Diff: https://reviews.apache.org/r/75025/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that quick start tutorial completes successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 75014: ATLAS-4867 : Improve Metrics API

[Paresh Devalia]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75014/
---

(Updated May 28, 2024, 1:40 p.m.)


Review request for atlas, Mandar Ambawane and Pinal Shah.


Bugs: ATLAS-4867
https://issues.apache.org/jira/browse/ATLAS-4867


Repository: atlas


Description
---

Metrics API : http://<>/api/atlas/admin/metrics

1. There is some information in the Metrics API response, which is not been 
used like Count of the typeAndSubTypes, Active, deleted, Shell
Approach:
Identify time taken by the above counts
Take reading of metric api
Take reading of metric api without the above counts


2. Also we can get the total number of count of vertices and edges present in 
graph
This  helps in estimating the time on Reindexing Patch.
Also it may be helpful while debugging the escalations
Approach:
Embed this count in MetricUtil
Or
Create seperate API


Diffs
-

  dashboardv2/public/js/templates/site/Statistics_Timeline_tmlp.html 09f76a0a8 
  dashboardv2/public/js/utils/Enums.js 00bbe103d 
  dashboardv2/public/js/views/site/StatisticsTimelineView.js d7caa60e7 
  dashboardv3/public/js/templates/site/Statistics_Timeline_tmlp.html 09f76a0a8 
  dashboardv3/public/js/utils/Enums.js 00bbe103d 
  dashboardv3/public/js/views/site/StatisticsTimelineView.js d7caa60e7 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
 004cab9c8 
  intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java c968302b7 
  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
9ec2cd2cb 
  repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 
a13e07387 


Diff: https://reviews.apache.org/r/75014/diff/1/


Testing (updated)
---

With typeAndSubTypes data it took 217ms for Metric API 
Without typeAndSubTypes data, it took 180ms for Metric API 
Without typeAndSubTypes and include the graph vertex and edge count took almost 
300++ ms

Also Vertex and Edge count include in Statstics UI > Server Statstics > Graph 
Details


Thanks,

Paresh Devalia

Re: Review Request 74954: ATLAS-4846 : Source the atlas-env file in ATLAS import script to get all the argument

[Sheetal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74954/#review226488
---


Ship it!




Ship It!

- Sheetal Shah


On April 12, 2024, 11:31 a.m., Paresh Devalia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74954/
> ---
> 
> (Updated April 12, 2024, 11:31 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4846
> https://issues.apache.org/jira/browse/ATLAS-4846
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> User has to run manually export command to get all the argument which are 
> set, to run the Atlas import script.
> 
> The problem is not with the Atlas service itself but with these scripts:
> 
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-kafka.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hbase.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hive.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-impala.sh
>  
> 
> Need to set argument before this script are being called.
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/src/bin/import-hbase.sh 8ae735034 
>   addons/hive-bridge/src/bin/import-hive.sh 951be5ba2 
>   addons/impala-bridge/src/main/resources/import-impala.sh b440f2d05 
>   addons/kafka-bridge/src/bin/import-kafka.sh 8fe27748a 
> 
> 
> Diff: https://reviews.apache.org/r/74954/diff/3/
> 
> 
> Testing
> ---
> 
> Testing:- Manually create the cluster and ran the import script.
> 
> 
> Thanks,
> 
> Paresh Devalia
> 
>

Re: Review Request 74954: ATLAS-4846 : Source the atlas-env file in ATLAS import script to get all the argument

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74954/#review226487
---


Ship it!




Ship It!

- Mandar Ambawane


On April 12, 2024, 6:01 a.m., Paresh Devalia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74954/
> ---
> 
> (Updated April 12, 2024, 6:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and 
> Sheetal Shah.
> 
> 
> Bugs: ATLAS-4846
> https://issues.apache.org/jira/browse/ATLAS-4846
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> User has to run manually export command to get all the argument which are 
> set, to run the Atlas import script.
> 
> The problem is not with the Atlas service itself but with these scripts:
> 
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-kafka.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hbase.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-hive.sh
> /opt/cloudera/parcels/CDH/lib/atlas/hook-bin/import-impala.sh
>  
> 
> Need to set argument before this script are being called.
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/src/bin/import-hbase.sh 8ae735034 
>   addons/hive-bridge/src/bin/import-hive.sh 951be5ba2 
>   addons/impala-bridge/src/main/resources/import-impala.sh b440f2d05 
>   addons/kafka-bridge/src/bin/import-kafka.sh 8fe27748a 
> 
> 
> Diff: https://reviews.apache.org/r/74954/diff/3/
> 
> 
> Testing
> ---
> 
> Testing:- Manually create the cluster and ran the import script.
> 
> 
> Thanks,
> 
> Paresh Devalia
> 
>