[jira] [Commented] (AVRO-3210) how the Avro Schema with Union type can accept the ‘normal JSON’

2021-10-04 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424120#comment-17424120 ] Zoltan Farkas commented on AVRO-3210: - This issue is basically a duplicate of AVRO-1582 I have been

[jira] [Commented] (AVRO-3135) Add schema serialization/deserialization hooks, to aid implementation of "schema references"

2021-10-04 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424117#comment-17424117 ] Zoltan Farkas commented on AVRO-3135: - I have a PR for this available: https://github.com/apache/avro

RFC on https://github.com/apache/avro/pull/1217

2021-05-16 Thread Zoltan Farkas
Hello avro devs, I have created a small PR to add some extension point to schema read/write: https://github.com/apache/avro/pull/1217 The main use case for this is described at:

[jira] [Created] (AVRO-3135) Add schema serialization/deserialization hooks, to aid implementation of "schema references"

2021-05-11 Thread Zoltan Farkas (Jira)
Zoltan Farkas created AVRO-3135: --- Summary: Add schema serialization/deserialization hooks, to aid implementation of "schema references" Key: AVRO-3135 URL: https://issues.apache.org/jira/browse

[jira] [Created] (AVRO-2938) Make Conversion more generic.

2020-10-09 Thread Zoltan Farkas (Jira)
Zoltan Farkas created AVRO-2938: --- Summary: Make Conversion more generic. Key: AVRO-2938 URL: https://issues.apache.org/jira/browse/AVRO-2938 Project: Apache Avro Issue Type: Improvement

[jira] [Created] (AVRO-2936) Small optimization of GenericData.addLogicalTypeConversion

2020-10-05 Thread Zoltan Farkas (Jira)
Zoltan Farkas created AVRO-2936: --- Summary: Small optimization of GenericData.addLogicalTypeConversion Key: AVRO-2936 URL: https://issues.apache.org/jira/browse/AVRO-2936 Project: Apache Avro

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-05-09 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103258#comment-17103258 ] Zoltan Farkas commented on AVRO-2278: - [~anhldbk] to clarify we are discussing here the semantics

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100864#comment-17100864 ] Zoltan Farkas commented on AVRO-2278: - There is basically one behavior that we are changing here

[jira] [Updated] (AVRO-1607) Minor performance enhancement

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-1607: Description: In SpecificData.getClass, line 164: {code} case UNION: List types

[jira] [Commented] (AVRO-1603) maven avro plugin to also generate avsc files.

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-1603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100790#comment-17100790 ] Zoltan Farkas commented on AVRO-1603: - One other reason for this is to instead of having the avro

[jira] [Resolved] (AVRO-1580) Use newer version of surefire, 2.17 instead of 2.12

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas resolved AVRO-1580. - Resolution: Fixed > Use newer version of surefire, 2.17 instead of 2

[jira] [Comment Edited] (AVRO-2278) GenericData.Record field getter not correct

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100697#comment-17100697 ] Zoltan Farkas edited comment on AVRO-2278 at 5/6/20, 11:49 AM: --- [~rskraba

[jira] [Comment Edited] (AVRO-2278) GenericData.Record field getter not correct

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100697#comment-17100697 ] Zoltan Farkas edited comment on AVRO-2278 at 5/6/20, 11:48 AM: --- [~rskraba

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-05-06 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100697#comment-17100697 ] Zoltan Farkas commented on AVRO-2278: - [~rskraba] what about controlling this behavior with a System

Re: Community governance

2020-05-05 Thread Zoltan Farkas
Should we start using a chat product (like Gitter or similar?) For example, this discussion was classified as Junk by the email tooling I use… cheers —Z > On May 5, 2020, at 5:03 AM, Driesprong, Fokko wrote: > > For the releases, the information is on Github: >

Re: Proposal: RFCs for Avro 2.x

2020-04-29 Thread Zoltan Farkas
I am all for expanding the core types… the current logical type shortcuts in the IDL lang will make this a bit more interesting to implement (I think they confuse more than they help)… Regarding ID based field tracking, I am not sure I understand what problem does it solve, and there might be

[jira] [Updated] (AVRO-2278) GenericData.Record field getter not correct

2020-04-28 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-2278: Affects Version/s: 1.9.2 > GenericData.Record field getter not corr

[jira] [Assigned] (AVRO-2278) GenericData.Record field getter not correct

2020-04-28 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas reassigned AVRO-2278: --- Assignee: Zoltan Farkas > GenericData.Record field getter not corr

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-04-28 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094476#comment-17094476 ] Zoltan Farkas commented on AVRO-2278: - updated PR. > GenericData.Record field getter not corr

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-04-28 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094455#comment-17094455 ] Zoltan Farkas commented on AVRO-2278: - [~rskraba] Excellent points! I would make all accesses by index

Re: PR review request for AVRO-2278

2020-04-27 Thread Zoltan Farkas
Anyone? —Z > On Apr 24, 2020, at 8:10 AM, Zoltan Farkas wrote: > > Anyone has time to review/merge the following pull request? > > https://github.com/apache/avro/pull/864 > <https://github.com/apache/avro/pull/864> > > thank you > > —Zoltan Farkas

PR review request for AVRO-2278

2020-04-24 Thread Zoltan Farkas
Anyone has time to review/merge the following pull request? https://github.com/apache/avro/pull/864 <https://github.com/apache/avro/pull/864> thank you —Zoltan Farkas

[jira] [Commented] (AVRO-2278) GenericData.Record field getter not correct

2020-04-23 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090604#comment-17090604 ] Zoltan Farkas commented on AVRO-2278: - Created PR: https://github.com/apache/avro/pull/864

Re: Decimal type, limitation on scale

2020-03-02 Thread Zoltan Farkas
+dev adding the dev mailing list, maybe somebody there can answer the reasoning. when comparing sql server with Oracle and Postgress: https://docs.microsoft.com/en-us/sql/t-sql/data-types/decimal-and-numeric-transact-sql?view=sql-server-ver15

[jira] [Commented] (AVRO-2742) Schema.Parser.parse() does not validate namespace

2020-02-19 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039936#comment-17039936 ] Zoltan Farkas commented on AVRO-2742: - [~rskraba] before I went the path of disabling name validation

[jira] [Commented] (AVRO-2742) Schema.Parser.parse() does not validate namespace

2020-02-18 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039480#comment-17039480 ] Zoltan Farkas commented on AVRO-2742: - [~radai] right now, you do restrict yourself to generic records

[jira] [Commented] (AVRO-2742) Schema.Parser.parse() does not validate namespace

2020-02-18 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039445#comment-17039445 ] Zoltan Farkas commented on AVRO-2742: - Well the schema parser, explicitly allows to disable name

[jira] [Resolved] (AVRO-2057) JsonDecoder.skipChildren does not skip map/records correctly

2020-01-31 Thread Zoltan Farkas (Jira)
[ https://issues.apache.org/jira/browse/AVRO-2057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas resolved AVRO-2057. - Resolution: Implemented Looks like this was resolved by another chamge

[jira] [Created] (AVRO-2716) Unused local variable

2020-01-23 Thread Zoltan Farkas (Jira)
Zoltan Farkas created AVRO-2716: --- Summary: Unused local variable Key: AVRO-2716 URL: https://issues.apache.org/jira/browse/AVRO-2716 Project: Apache Avro Issue Type: Bug Affects Versions

Re: Avro to GraphQL

2019-11-25 Thread Zoltan Farkas
This is something I have also thought about… Eventually went down the path of SQL with apache calcite + jax rs…. You can achieve similar outcomes (get multiple resources in one request, compatible evolution…) Here is a quick writeup + poc:

[jira] [Commented] (AVRO-2418) BUG in schema resolver, when resolving map<> to union {null, map<>}

2019-06-13 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863292#comment-16863292 ] Zoltan Farkas commented on AVRO-2418: - Se PR for fix: https://github.com/apache/avro/pull/543 >

[jira] [Created] (AVRO-2418) BUG in schema resolver, when resolving map<> to union {null, map<>}

2019-06-13 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2418: --- Summary: BUG in schema resolver, when resolving map<> to union {null, map<>} Key: AVRO-2418 URL: https://issues.apache.org/jira/browse/AVRO-2418 Project:

[jira] [Created] (AVRO-2412) Improved default value reading

2019-05-31 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2412: --- Summary: Improved default value reading Key: AVRO-2412 URL: https://issues.apache.org/jira/browse/AVRO-2412 Project: Apache Avro Issue Type: Improvement

[jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2019-05-24 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-1723: Fix Version/s: 1.9.0 > Add support for forward declarations in avro

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2019-05-24 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847769#comment-16847769 ] Zoltan Farkas commented on AVRO-1723: - [~davidcarltonsumo] should be part of 1.9.0, I see the changes

[jira] [Commented] (AVRO-2201) avro-maven-plugin should be able to import schema from generated specificrecord

2019-03-31 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806129#comment-16806129 ] Zoltan Farkas commented on AVRO-2201: - Another way to achieve a similar result is to publish

[jira] [Commented] (AVRO-2137) avro JsonDecoding additional field in array type

2019-02-28 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781145#comment-16781145 ] Zoltan Farkas commented on AVRO-2137: - Yup, that is correct, incidentally I hit the same issue today

[jira] [Commented] (AVRO-2328) Support distinguishing between LocalDateTime and Instant semantics in timestamps

2019-02-28 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780956#comment-16780956 ] Zoltan Farkas commented on AVRO-2328: - In my fork (zolyfarkas/avro) I implemented a "instant&quo

[jira] [Comment Edited] (AVRO-2137) avro JsonDecoding additional field in array type

2019-02-28 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780913#comment-16780913 ] Zoltan Farkas edited comment on AVRO-2137 at 2/28/19 9:06 PM: -- I am

[jira] [Commented] (AVRO-2137) avro JsonDecoding additional field in array type

2019-02-28 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780913#comment-16780913 ] Zoltan Farkas commented on AVRO-2137: - I am not seeing this in my fork (https://github.com/zolyfarkas

[jira] [Commented] (AVRO-2164) Make Decimal a first class type.

2018-12-29 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730697#comment-16730697 ] Zoltan Farkas commented on AVRO-2164: - One more thing I stumbled upon, Currently

Re: [jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

2018-12-14 Thread Zoltan Farkas
Daniel, can you please take a look at my comment on this PR: https://github.com/apache/avro/pull/224/files ? I believe there might still be issues with this implementation in certain situations. Thanks! —Z > On Dec 11, 2018, at 1:18 PM,

[jira] [Created] (AVRO-2284) Incorrect EnumSymbol initialization in TestReadingWritingDataInEvolvedSchemas.java

2018-12-13 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2284: --- Summary: Incorrect EnumSymbol initialization in TestReadingWritingDataInEvolvedSchemas.java Key: AVRO-2284 URL: https://issues.apache.org/jira/browse/AVRO-2284 Project

[jira] [Updated] (AVRO-2278) GenericData.Record field getter not correct

2018-11-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-2278: Summary: GenericData.Record field getter not correct (was: GenericData.Record field getter

[jira] [Created] (AVRO-2278) GenericData.Record field getter no correct

2018-11-27 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2278: --- Summary: GenericData.Record field getter no correct Key: AVRO-2278 URL: https://issues.apache.org/jira/browse/AVRO-2278 Project: Apache Avro Issue Type: Bug

[jira] [Commented] (AVRO-2269) Improve variances seen across Perf.java runs

2018-11-15 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688925#comment-16688925 ] Zoltan Farkas commented on AVRO-2269: - instead or re-inventing the wheel...Perf.java should

[jira] [Commented] (AVRO-1124) RESTful service for holding schemas

2018-11-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686565#comment-16686565 ] Zoltan Farkas commented on AVRO-1124: - I have recently published an example of what I described

[jira] [Commented] (AVRO-2254) Unions with 2 records declared downward fail

2018-11-11 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682877#comment-16682877 ] Zoltan Farkas commented on AVRO-2254: - [~nkollar] Nandor, can you please review the fix I am

Re: Static Analysis

2018-11-07 Thread Zoltan Farkas
+1 for static analysis. here is what codacy looks like on the avro fork I use: https://app.codacy.com/project/zolyfarkas/avro/dashboard —Z > On Nov 7, 2018, at 10:01 AM, Michael A. Smith wrote: > > Now that the Yetus/Travis integration is running (yay), I hope it's not > premature to

[jira] [Commented] (AVRO-2164) Make Decimal a first class type.

2018-11-05 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675887#comment-16675887 ] Zoltan Farkas commented on AVRO-2164: - I am in favor of making decimal a first class type. One extra

[jira] [Commented] (AVRO-2032) Unable to decode JSON-encoded Double.NaN, Double.POSITIVE_INFINITY or Double.NEGATIVE_INFINITY

2018-06-01 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498449#comment-16498449 ] Zoltan Farkas commented on AVRO-2032: - I resolved this issue in my fork, it is fairly a small fix

Re: WELCOME to dev@avro.apache.org

2018-03-22 Thread Zoltan Farkas
The following is also pretty low hanging fruit (one line change): https://issues.apache.org/jira/browse/AVRO-2057 —Z > On Mar 22, 2018, at 11:55 AM, Bridger Howell wrote: > > Not a committer, but I'd like to chime in and say that I'd absolutely love > to see another set of

[jira] [Commented] (AVRO-2035) enable validation of default values in schemas by default

2018-02-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373777#comment-16373777 ] Zoltan Farkas commented on AVRO-2035: - [~cutting] looks good. thanks! > enable validation of defa

[jira] [Commented] (AVRO-2132) Avro IDL: Support dot ('.') character in property annotation names

2018-02-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373418#comment-16373418 ] Zoltan Farkas commented on AVRO-2132: - [~cutting] [~kdrakon] I just looked at this commit and tried

[jira] [Commented] (AVRO-2150) Improved idl syntax support for "marker properties"

2018-02-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373288#comment-16373288 ] Zoltan Farkas commented on AVRO-2150: - Implementation of this is trivial, see: https://github.com

[jira] [Created] (AVRO-2150) Improved idl syntax support for "marker properties"

2018-02-22 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2150: --- Summary: Improved idl syntax support for "marker properties" Key: AVRO-2150 URL: https://issues.apache.org/jira/browse/AVRO-2150 Project: Avro

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2018-01-16 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327575#comment-16327575 ] Zoltan Farkas commented on AVRO-1340: - [~cutting] I believe the best place to define a fallback symbol

[jira] [Comment Edited] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829 ] Zoltan Farkas edited comment on AVRO-2118 at 12/14/17 1:39 PM: --- created PR

[jira] [Commented] (AVRO-2118) Rat tool fails over several files.

2017-12-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290829#comment-16290829 ] Zoltan Farkas commented on AVRO-2118: - will create a PR, and add the details to this JIRA. > Rat t

Re: Licensing problem (LGPL in codebase!!)

2017-12-13 Thread Zoltan Farkas
avro/compiler/schema > > Some of these files do not have a copyright block (fixable), yet some have > this: > > /* > > * Copyright (c) 2001 - 2016, Zoltan Farkas All Rights Reserved. > * > * This library is free software; you can redistribute it and/or > * modify it

[jira] [Commented] (AVRO-1810) GenericDatumWriter broken with Enum

2017-09-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166749#comment-16166749 ] Zoltan Farkas commented on AVRO-1810: - [~howellbridger] java.lang.Enum equals, hashCode, compareTo

[jira] [Comment Edited] (AVRO-1810) GenericDatumWriter broken with Enum

2017-09-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166377#comment-16166377 ] Zoltan Farkas edited comment on AVRO-1810 at 9/14/17 5:58 PM: -- The way I

[jira] [Commented] (AVRO-1810) GenericDatumWriter broken with Enum

2017-09-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166377#comment-16166377 ] Zoltan Farkas commented on AVRO-1810: - The way I resolved this in my for was to make the Generated

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-09-05 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154576#comment-16154576 ] Zoltan Farkas commented on AVRO-1340: - I am not sure I like a enum defined like: "

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-09-01 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151176#comment-16151176 ] Zoltan Farkas commented on AVRO-1340: - [~cutting] There is https://issues.apache.org/jira/browse/AVRO

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

2017-08-30 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147312#comment-16147312 ] Zoltan Farkas commented on AVRO-2072: - [~nkollar] Missed that part of the spec, the patch behavior

[jira] [Comment Edited] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

2017-08-30 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147229#comment-16147229 ] Zoltan Farkas edited comment on AVRO-2072 at 8/30/17 1:22 PM: -- I executed

[jira] [Commented] (AVRO-2072) ResolvingGrammarGenerator doesn't implement schema resolution correctly for unions

2017-08-30 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147229#comment-16147229 ] Zoltan Farkas commented on AVRO-2072: - I executed this against my branch... which is ahead

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143208#comment-16143208 ] Zoltan Farkas commented on AVRO-1340: - Removing a value would only be possible if a fallback exists

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143186#comment-16143186 ] Zoltan Farkas commented on AVRO-1340: - In you example if v2 symbols are identical with v1 symbols

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143153#comment-16143153 ] Zoltan Farkas commented on AVRO-1340: - FELIX> Can v1 have no "fallbackSymbol&quo

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-26 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142833#comment-16142833 ] Zoltan Farkas commented on AVRO-1340: - Anyone opinions on my previous suggestion? I have implemented

[jira] [Comment Edited] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137220#comment-16137220 ] Zoltan Farkas edited comment on AVRO-1340 at 8/22/17 7:29 PM: -- [~cutting] what

[jira] [Comment Edited] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137220#comment-16137220 ] Zoltan Farkas edited comment on AVRO-1340 at 8/22/17 7:29 PM: -- [~cutting] what

[jira] [Comment Edited] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137220#comment-16137220 ] Zoltan Farkas edited comment on AVRO-1340 at 8/22/17 7:26 PM: -- [~cutting] what

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-22 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137220#comment-16137220 ] Zoltan Farkas commented on AVRO-1340: - [~cutting] what do you thing about the following: 1) Symbol

[jira] [Created] (AVRO-2068) Improve EnumSchema constructor performance

2017-08-22 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2068: --- Summary: Improve EnumSchema constructor performance Key: AVRO-2068 URL: https://issues.apache.org/jira/browse/AVRO-2068 Project: Avro Issue Type: Improvement

[jira] [Created] (AVRO-2057) JsonDecoder.skipChildren does not skip map/records correctly

2017-07-18 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2057: --- Summary: JsonDecoder.skipChildren does not skip map/records correctly Key: AVRO-2057 URL: https://issues.apache.org/jira/browse/AVRO-2057 Project: Avro Issue

[jira] [Commented] (AVRO-1575) Platform specific end of line hardcoded in unit test causes test failure on Windows.

2017-05-30 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029363#comment-16029363 ] Zoltan Farkas commented on AVRO-1575: - This can be closed. > Platform specific end of line hardco

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-18 Thread Zoltan Farkas
Thiru, when you get a chance can you look at the last version of the PR? thank you —Z > On May 14, 2017, at 7:50 PM, Zoltan Farkas (JIRA) <j...@apache.org> wrote: > > >[ > https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.i

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-14 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009886#comment-16009886 ] Zoltan Farkas commented on AVRO-1723: - [~thiru_mg] I have updated the PR to redo the guava code

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-12 Thread Zoltan Farkas
Thiruvalluvan, anything else we need to do before merging this in? let me know thank you —Z > On May 10, 2017, at 2:45 PM, Zoltan Farkas <zolyfar...@yahoo.com.INVALID> > wrote: > > Anything else left to do? > > let me know > > thank you > > —

Re: [jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-10 Thread Zoltan Farkas
e/AVRO-1723 >>Project: Avro >> Issue Type: Improvement >> Affects Versions: 1.8.0 >> Reporter: Zoltan Farkas >> Assignee: Zoltan Farkas >>Attachments: AVRO-1723.patch >> >> >> Currently R

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-04 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997230#comment-15997230 ] Zoltan Farkas commented on AVRO-1723: - Let me know if I need to do anything else. > Add supp

[jira] [Created] (AVRO-2031) GenericData.writeEscapedString should be static

2017-05-01 Thread Zoltan Farkas (JIRA)
Zoltan Farkas created AVRO-2031: --- Summary: GenericData.writeEscapedString should be static Key: AVRO-2031 URL: https://issues.apache.org/jira/browse/AVRO-2031 Project: Avro Issue Type

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-05-01 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990923#comment-15990923 ] Zoltan Farkas commented on AVRO-1723: - Looks good! thank you! > Add support for forward declarati

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-30 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990376#comment-15990376 ] Zoltan Farkas commented on AVRO-1723: - [~thiru_mg] Thanks for review. your cleanup + fixes looks good

https://github.com/apache/avro Empty?

2017-04-28 Thread Zoltan Farkas
Anybody aware of issues with GitHub repo? I am getting: This repository is empty. —Z

Re: Anyone available to review/merge pull request for AVRO-1723 ?

2017-04-28 Thread Zoltan Farkas
Thanks! --z > On Apr 28, 2017, at 11:47 AM, Thiruvalluvan MG <thiru...@yahoo.com.INVALID> > wrote: > > I'll take a look. > Thanks > Thiru > >On Friday, 28 April 2017 8:58 PM, Zoltan Farkas > <zolyfar...@yahoo.com.INVALID> wrote: > > > Any

Re: Anyone available to review/merge pull request for AVRO-1723 ?

2017-04-28 Thread Zoltan Farkas
Anyone who has some time to review this? —Z > On Apr 25, 2017, at 8:01 PM, Zoltan Farkas <zolyfar...@yahoo.com.INVALID> > wrote: > > let me know > > thank you > > —Z

[jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-26 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-1723: Release Note: With this patch recursive data structures will be supported in IDL: record SampleNode

[jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-26 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-1723: Release Note: With this patch recursive data structures will be supported in IDL: {code} record

Anyone available to review/merge pull request for AVRO-1723 ?

2017-04-25 Thread Zoltan Farkas
let me know thank you —Z

[jira] [Commented] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-25 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983499#comment-15983499 ] Zoltan Farkas commented on AVRO-1723: - Can somebody review the pull request? thank you > Add supp

Re: [jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-24 Thread Zoltan Farkas
Anyone available to review this pull request? thank you —Z > On Apr 10, 2017, at 12:12 PM, Zoltan Farkas <zolyfar...@yahoo.com.INVALID> > wrote: > > Hi, I have updated my pull request with latest suggestions from Ryan, > > can somebody review this pull

Fwd: [jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-10 Thread Zoltan Farkas
Hi, I have updated my pull request with latest suggestions from Ryan, can somebody review this pull request and let me know if there is anything left? thank you —Z > Begin forwarded message: > > From: "Zoltan Farkas (JIRA)" <j...@apache.org> > Subject: [jira] [Upda

[jira] [Updated] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-06 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas updated AVRO-1723: Release Note: Pull request available: https://github.com/apache/avro/pull/79 Status

[jira] [Assigned] (AVRO-1723) Add support for forward declarations in avro IDL

2017-04-06 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Farkas reassigned AVRO-1723: --- Assignee: Zoltan Farkas > Add support for forward declarations in avro

[jira] [Commented] (AVRO-1997) Avro Field.defaultVal broken for Fixed fields.

2017-02-28 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888614#comment-15888614 ] Zoltan Farkas commented on AVRO-1997: - [~busbey] Here is the release note to describe the original

Re: Anybody has time to review/merge AVRO-1997 ?

2017-02-27 Thread Zoltan Farkas
> It looks like Suraj did a review on the PR ~20 days ago, but his > feedback was never addressed. > > On Mon, Feb 27, 2017 at 3:23 PM, Zoltan Farkas > <zolyfar...@yahoo.com.invalid> wrote: >> Jira link: >> >> https://issues.apache.org/jira/browse/AVRO-1997

  1   2   3   >