Re: Java > 8 support

+1 to adding Jenkins jobs that test with Java 11. Might it also be possible to add a second java precommit that runs a subset of the tests on Java 11? Andrew On Thu, Oct 18, 2018 at 8:52 AM Scott Wegner wrote: > If we just want to validate our produced artifacts work with Java11, I > believe

Re: Java > 8 support

If we just want to validate our produced artifacts work with Java11, I believe it would be easy to start running some of our Jenkins jobs on Java 11. beam_PostRelease_NightlyCandidate [1] is a good candidate: it runs the quickstart examples across all runners from the SNAPSHOT published maven

Re: Java > 8 support

Yes, Kenn I was talking about building artifacts (because this is the strictest way to validate the compatiblity of our code base and find issues with some of the classpath/code generation we use or with the dependencies). I agree 100% with you, the real deal is to validate that we can use Java 8

Re: Java > 8 support

On Thu, Oct 18, 2018 at 4:55 AM Kenneth Knowles wrote: > Just to add to what Luke said: The reason we had those Java 8-only modules > was because some underlying tech (example: Gearpump) required Java 8. If an > engine requires something then it is OK for a user who chooses the runner > for that

Re: Java > 8 support

Just to add to what Luke said: The reason we had those Java 8-only modules was because some underlying tech (example: Gearpump) required Java 8. If an engine requires something then it is OK for a user who chooses the runner for that engine to also be subject to that requirement. Otherwise I would

Re: Java > 8 support

When we were supporting Java 7, there were Java 8 based modules in Maven. We can follow a similar pattern where Java11 (or any other version) have their own projects and as the base Java version moves up, we can merge those modules back in to simplify the set of modules being developed. On Wed,

Re: Java > 8 support

I want to give more context on the previous work towards Java 11 support. The issue was not necessarily that gradle was not ok to support Java 11, but this is also a good point Lukasz. Months ago, we built a maven profile that basically set up Java to be strictly compatible with the ‘minimal’

Re: Java > 8 support

FYI: If I'm correct, migrating to Java 11 may require Migrating to Gradle 5, which to me is ok, but there are some issues on the way (such as [1] or maybe more that I'm not aware of). I did some research and it seems that Groovy 2.4.15 (the default version of Groovy for Gradle 4.10.2) is unable

Re: Java > 8 support

FWIW, the issue regarding java 11 support to gradle might be helpful here [1]. Quoting: "there are only some minor corner cases that don't work. Overall Java 11 support is pretty solid already" but some users reported problems in comments with Checkstyle plugin and MacOS + Gradle4.10.2 (this might

Re: Java > 8 support

Hello all, If I understand you correctly Ismael, a good amount of 'beam-sdks-java-core' tests are already passing with Java 11, so the amount of work necessary on the core module should be relatively small. Is this correct? Are there improvements that may be missing in terms of modularization?

Re: Java > 8 support

Thanks for the clarification Ismaël. * • **Arif Kasim* * • * Strategic Cloud Engineer * • *Google, Inc. • arifka...@google.com On Wed, Oct 10, 2018 at 9:41 AM Ismaël Mejía wrote: > Just wanted to clarify, there is already a JIRA for ongoing work on > Java 11 support. >

Re: Java > 8 support

Just wanted to clarify, there is already a JIRA for ongoing work on Java 11 support. https://issues.apache.org/jira/browse/BEAM-2530 I led the initial work on supporting what at the time was Java 9/10, so far the biggest blockers were around the ApiSurface tests (not at all compatible with these

Re: Java > 8 support

@Reuven: bytebuddy by itself no but the way beam tries to inject the proxy class is. There are other strategies you can use in bytebuddy which work. Romain Manni-Bucau @rmannibucau | Blog | Old Blog

Re: Java > 8 support

Hi, I mean that some IO dependency, especially for the tests should be updated for the build with J9. The runtime should work with J9, but not the build. Regards JB On 06/10/2018 17:45, Romain Manni-Bucau wrote: > I dont think so JB - until you want to use jlink but it is out of scope > of

Re: Java > 8 support

Romain, do you have any more details on the ByteBuddy incompatibility? Is ByteBuddy incompatible with the Java 11 JRE, or just with new language features? On Fri, Oct 5, 2018 at 10:20 AM Romain Manni-Bucau wrote: > Hi Arif, > > AFAIK bytebuddy code is not java 11 friendly otherwise it runs (but

Re: Java > 8 support

I dont think so JB - until you want to use jlink but it is out of scope of beam - and since j9 didnt break unsafe it should work. Le sam. 6 oct. 2018 17:23, Jean-Baptiste Onofré a écrit : > Same thing, it requires some change in the dependency, especially for > the Jigsaw modules. > > Regards >

Re: Java > 8 support

Same thing, it requires some change in the dependency, especially for the Jigsaw modules. Regards JB On 06/10/2018 15:01, Arif Kasim wrote: > Thanks all. What about Java 9 support? > > > > > > > > > > *  •  **Arif Kasim** > **  • * Strategic Cloud

Re: Java > 8 support

Thanks all. What about Java 9 support? * • **Arif Kasim* * • * Strategic Cloud Engineer * • *Google, Inc. • arifka...@google.com On Fri, Oct 5, 2018 at 7:20 PM Romain Manni-Bucau wrote: > Hi Arif, > > AFAIK bytebuddy code is not java 11 friendly otherwise it runs (but it > means

Re: Java > 8 support

Hi Arif, AFAIK bytebuddy code is not java 11 friendly otherwise it runs (but it means your pipeline is very very simple since it does not have a dofn ;)) if your engine supports it. Also note that the modules not being named you can have to use some weird import names or even unstable ones if you

Re: Java > 8 support

Hi Arif, Java 8 is supported but we also plan some update in the core (like removing joda-time to use "native" Java 8 lib). I guess you are mostly asking for Java 11, I just try a rough build and indeed, we have lot of changes/updates to do. I did the update to Java 11 in Apache Karaf, and it

Java > 8 support

Hello, What's the status of java version > 8 support for beam? Thanks. -Arif.