GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-ui/pull/112
DSL editor: support referencing `brooklyn.parameters`
Allows a blueprint to use `brooklyn.parameters`, and to reference that
parameter using the DSL editor.
For example, I wrote
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/111
LGTM; merging.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/109
Sure, happy to merge and we can make subsequent improvements in other PRs.
Merging now.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1016
LGTM - merging.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/109
@ahgittin for 'template', is that really what it means in the product from
a user's perspective? Something declared as a 'template' will appear in the
quick launch, whereas other things
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1014
[WIP] Subtype setting config val: use as keyâs default val
**For review/feedback only - failing unit tests.**
Otherwise if another blueprint uses this subtype, it does not see
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/97
Description sounds sensible to me, and scanning through the code I didn't
see anything obviously wrong!
I've tested it in `npm run start` mode, and all the relevant
blueprint-composer
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1011
Fix requiredUnless config key constraint, with attributeWhenReady
Previously this caused the entityâs startup to hang.
You can merge this pull request into a Git repository by running
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/90
Ah, you beat me to it @tbouron (and I should have refreshed my browser page
to see your comment!). The build worked after you requested the retest. My
retest was unnecessary.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/90
retest this please
Failed with seemingly unrelated failure in a different module:
```
[ERROR] Failed to execute goal
com.github.eirslett:frontend-maven-plugin:1.3:npm (npm
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-ui/pull/90
DSL editor: allow ref to entity anywhere
This change means that the DSL editor will let you choose a reference to an
entity in any config key (rather than only if the config key is of type
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/74
retest this please
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/79
LGTM; I grep'ed for uses of `getTypeVersion` to check if anything was using
the old name - all looks good. Merging.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
Thanks @kemitix - looks good, merging now.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1003
LGTM; happy for this to be merged (once confusion with the
identical-looking https://github.com/apache/brooklyn-server/pull/1005 is
cleared up).
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1006
This looks identical to https://github.com/apache/brooklyn-server/pull/1003
- is it? Can we close your PR @grkvlt and merge @frogfather 's original?
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1005
@grkvlt did your test work? Are you happy to close this?
Ping me if you want to discuss PR builds - I've been working on our build
configuration in jenkins.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1008
@kemitix I completely agree about the tests being cryptic. Passing four
booleans in a row in a method signature is an anti-pattern: it is hard to read
and very error-prone
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1008
retest this please
Changed test config, to enable `Delete workspace before build starts`
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1008
Adds constraint (required|forbidden)unlessAnyOf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
constraint
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/76
retest this please
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1004
Thanks @geomacy - variable renamed; merging.
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1004
BROOKLYN-602: fix config key order for yaml overrides
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server fix
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn/pull/23
jenkins: fix npm build, removing docker -u
npm writes to ~/.npm, and reads ~/.npmrc. But user 910 does
not exist in container, so has no home directory. Therefore
npm fails. Reverting `-u
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn/pull/19
LGTM; thanks @slachiewicz - merging.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
The PR build's test failures look related to the change, e.g.:
```
2018-09-28 10:56:56,059 INFO - TESTNG FAILED CONFIGURATION: "Surefire
test" - @B
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-client/pull/70
Thanks @frogfather - LGTM, and jenkins PR build worked. Merging now.
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-ui/pull/76
Composer palette: search entity tags
The palette should also search the entity's tags, when filtering. People
can use tags to categorise or provide additional metadata, so this is useful
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn/pull/22
Jenkins pipeline: fix `user.name`
User 910 is unknown in the docker container, so `${id -un 910}` does not
return a name. We donât care what `user.name` it has, as long as there is one
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/74#discussion_r220589038
--- Diff: pom.xml ---
@@ -99,7 +99,8 @@
3.0.1
3.0.0
1.3
-
6.0.6
+6.0.6
--- End diff
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1002
Eye-balling the changes, they look good. A few things to raise:
1. Would be good to upgrade our jetty.version to 9.4.x (from 9.3.24) to
match karaf's version. But @kemitix has tested
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn/pull/21
Merging now, to test build.
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn/pull/21
Jenkins: use pipeline, and donât bind-mount .m2
Copies the configuration approach in
https://github.com/apache/brooklyn-library/blob/master/Jenkinsfile, to be used
by
https
Github user aledsage closed the pull request at:
https://github.com/apache/brooklyn-library/pull/162
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/162
retest this please
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/162
retest this please
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/162
DO NOT MERGE - for testing PR builds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-library test-pr
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/154
retest this please
(just using this to test
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-pull-requests-pipeline/)
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/161
jenkins: add settings.xml for 'mvn deploy'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-library
fix-jenkins
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/160
I've created
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker-pipeline/.
The first run failed due to the rat check, which this PR fixes.
Merging
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/160
@tbouron I suspect that the `Jenkinsfile` has no effect, and that it just
uses the configuration in
https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/1000
retest this please
Jenkins failure was an environment problem I believe:
```
Caused by: hudson.plugins.git.GitException: Command "git fetch --tags
--progres
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/72#discussion_r219920469
--- Diff:
ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
---
@@ -275,20 +275,54 @@ function BlueprintService
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/1000
Config constraints: add more tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/brooklyn-server
config-constraints
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/154
@tbouron I think you're right that we don't need this PR - for example,
https://builds.apache.org/job/brooklyn-library-master-docker/335 passed and its
console output included
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/160
jenkins: don't bind mount .m2
As per the recommendations from Apache Infra in INFRA-16417 (comments [1]
and [2]).
[1]
https://issues.apache.org/jira/browse/INFRA-16417
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/158
Thanks @slachiewicz - merging now.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-library/pull/159
@tbouron will do, but will first confirm that brooklyn-library master build
works, and will also look to see if/how we can avoid the bind mount of the
writable directories.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/268
LGTM - merging.
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-library/pull/159
Jenkins docker: use non-root user
Implementing part of the advice from infra in
https://issues.apache.org/jira/browse/INFRA-16417
---
They advised we use `-u 910:910
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/999
Looks good - happy to merge, after I've build + run tests locally.
The jenkins PR build is still failing with the error below (I suspect it's
a network connection problem while
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/126#discussion_r219619890
--- Diff: all/pom.xml ---
@@ -36,11 +36,35 @@
+
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-dist/pull/126#discussion_r219619308
--- Diff: all/pom.xml ---
@@ -36,11 +36,35 @@
+east we've attempted to do this! -->
--- End d
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219558955
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219557804
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219567394
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java ---
@@ -218,4 +228,88 @@ public LocationConfigConstraints
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219567021
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java ---
@@ -218,4 +228,88 @@ public LocationConfigConstraints
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219560576
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219559231
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/999#discussion_r219561614
--- Diff:
core/src/main/java/org/apache/brooklyn/core/objs/ConstraintSerialization.java
---
@@ -0,0 +1,369 @@
+/*
+ * Licensed
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/999
retest this please
Build failure was environmental:
```
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from
git
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/998
Pom tidy, and version upgrades
See individual commits (the first one just moves stuff around).
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/997
Add testMergeMapsPreferringSecondOnConflict
Following on from https://github.com/apache/brooklyn-server/pull/996, this
adds a test for that functionality.
You can merge this pull request
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/989#discussion_r218311895
--- Diff:
test-support/src/main/java/org/apache/brooklyn/test/LogWatcher.java ---
@@ -268,17 +248,14 @@ public void assertHasEvent
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/992
LGTM; merging.
---
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/71#discussion_r218071640
--- Diff:
ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js
---
@@ -235,6 +235,9 @@ function controller
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-ui/pull/71#discussion_r218076598
--- Diff:
ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html
---
@@ -61,7 +61,7 @@
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/70
retest this please
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/995
Main change was reviewed in #994; therefore merging this now.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/70
Jenkins failed because https://github.com/apache/brooklyn-server/pull/995
is not yet merged. Error was:
```
Message: Unable to resolve root: missing requirement [root] osgi.identity
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/994
Suggest we close this, and instead merge:
https://github.com/apache/brooklyn-server/pull/995
https://github.com/apache/brooklyn-ui/pull/70
If jenkins builds work for those
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-ui/pull/70
Bump karaf to 4.1.6 (from 4.1.2)
See https://github.com/apache/brooklyn-server/pull/995
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/995
Bump karaf to 4.1.6 (from 4.1.2)
Bumping jetty version to 9.3.24 (from 9.3.14) done in #991 clashes with
jetty that ships in karaf 4.1.2, breaking the build. Therefore bumping karaf
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/994
Confirmed that with *my* build (with the additional edits I listed above),
the `brooklyn-dist/karaf/apache-brooklyn/target/assembly` works.
I suggest we also change
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/994
Eye-balling what karaf 4.1.6 ships with, what we have in the brooklyn based
on 4.1.2, and what dependencies we declare in the poms, there are a few
discrepancies:
```
Karaf
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/994
I changed a few more things as well when looking at this:
In `pom.xml`:
```
4.1.6
```
In `karaf/features/pom.xml`:
```
[4.1.6,)
```
https
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/991
LGTM. Merging now.
The failing test looks unrelated
(`VanillaSoftwareProcessYamlTest.testAlternativeServiceUpPolling`). Confirmed
it passed locally for me. Looking at the test, I
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/990
Revert "This closes #988"
This reverts commit f6ad11846de2d9ba2e9004648179270e3ca3c25f, reversing
changes made to c782aae54f424e317c0999f5cde3fab19bc45cfb.
Thi
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-ui/pull/68
LGTM, merging.
@tbouron is you get a chance to take a look post-merge, that would be
appreciated.
---
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/988
Fix AutoScalerPolicyRebindTest: when highlights change, request re-peâ¦
â¦rsist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/987
Fix DSL recursive-reference detection
As per the code comment, I broke this in
https://github.com/apache/brooklyn-server/pull/971. This PR fixes it.
You can merge this pull request
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/986
BROOKLYN-600: cleanup entities on deploy-failure
Fix for https://issues.apache.org/jira/browse/BROOKLYN-600
Note the `LocalEntityManager. discardPremanaged(Entity)` is a bit more
GitHub user aledsage opened a pull request:
https://github.com/apache/brooklyn-server/pull/985
BROOKLYN-599: fix getApplication()
Fixes https://issues.apache.org/jira/browse/BROOKLYN-599
You can merge this pull request into a Git repository by running:
$ git pull https
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/984
+1, LGTM; waiting for jenkins to finish running tests.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/971
Thanks @geomacy @nakomis - merging now. Brooklyn issues are probably the
best way to record and track further improvements, I think.
---
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/971
Thanks @geomacy @nakomis
I've added `testDslLocationIndexOutOfBounds`, which asserts that we get a
nice exception when one tries to retrieve in anger the config value that has
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214612451
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/text/StringEscapesTest.java
---
@@ -115,4 +117,80 @@ public void testJavaLists
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214640708
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/text/StringEscapesTest.java
---
@@ -115,4 +117,80 @@ public void testJavaLists
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214615588
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java ---
@@ -365,7 +365,7 @@ public RuntimeException getException
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214611925
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -315,12 +320,121 @@ else if (c
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214640867
--- Diff:
utils/common/src/test/java/org/apache/brooklyn/util/text/StringEscapesTest.java
---
@@ -115,4 +117,80 @@ public void testJavaLists
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214612997
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/flags/MethodCoercions.java ---
@@ -87,13 +89,23 @@ public boolean apply(@Nullable
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214610344
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -315,12 +320,121 @@ else if (c
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214619292
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/guava/Maybe.java ---
@@ -501,6 +501,6 @@ public boolean equals(Object obj
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214642777
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -315,12 +320,121 @@ else if (c
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214607884
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -315,12 +320,121 @@ else if (c
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214554995
--- Diff:
core/src/main/java/org/apache/brooklyn/core/config/ConfigConstraints.java ---
@@ -149,19 +153,28 @@ public ConfigConstraints(T
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214608331
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/text/StringEscapes.java ---
@@ -315,12 +320,121 @@ else if (c
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/982#discussion_r214606998
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java ---
@@ -251,9 +255,23 @@ public ResolverBuilderPretype(Object v
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-docs/pull/262
LGTM; merging.
---
1 - 100 of 1967 matches
Mail list logo
