[GitHub] cloudstack issue #1808: CLOUDSTACK-9648: Fix release script to update checks...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1808 This in reference to a query on user@, where a user failed to build from source tarball due to incorrect version set in tools/checkstyle/pom.xml. @jburwell this needs to be included

[GitHub] cloudstack pull request #1808: CLOUDSTACK-9648: Fix release script to update...

2016-12-01 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1808 CLOUDSTACK-9648: Fix release script to update checkstyle pom This fixes build_asf.sh release script to update checkstyle pom.xml with the provided new version. You can merge this pull

Re: [DISCUSS] Bountycastle upgrade

2016-12-01 Thread Rohit Yadav
John, I'll have a look at where/how the fingerprint method is used, if necessary I'll upgrade it to use SHA-256. Thanks for the pointers. Regards. From: John Kinsella Sent: 02 December 2016 13:12:12 To: dev@cloudstack.apache.org Subject:

[ALERT] Github Pull Requests Travis runs on hold

2016-12-01 Thread Rohit Yadav
All, It seems that TravisCI is experiencing issues in their infra [1][2], and furthermore they have introduced changes in their default environment [3] yesterday due to which MySQL installation fails while deploying a simulator based environment. Due to these issues, TravisCI won't be

Re: [DISCUSS] Bountycastle upgrade

2016-12-01 Thread John Kinsella
2 thoughts: 1) I know this is partially git’s fault on the diff, and i know this is a standard gripe from me, but for reviewers things are much easier if syntax/whitespace changes are separated out into a separate patch from logic/functionality. 2) One thing that caught my eye was the SHA-1

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1622 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1622 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1622 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1807 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1519 Thanks @dsclose can you help review PR #1659 and see that all of your changes are ported too, in which you may close your PR. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1807 Pinging for review -- @jburwell @abhinandanprateek @borisstoyanov @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1807: CLOUDSTACK-9633: Revert addition of `vhd` ext...

2016-12-01 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1807 CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes introduced in commit

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-01 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90595496 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7 @@ public

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1659 Test lgtm, @murali-reddy are we good on this PR? I'm seeing some failures though not sure if they related to your changes. /cc @jburwell @abhinandanprateek --- If your project is set up for

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 Test lgtm, based on the test results I'm seeing no new failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1764 Thanks @marcaurele @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1764 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1748 @mike-tutkowski you please fix the git commit summary (not the PR summary) in the requested format? Thanks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1799 Test LGTM. @abhinandanprateek @murali-reddy can you give a final review/lgtm? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

2016-12-01 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1726#discussion_r90594621 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1765#discussion_r90594670 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -100,36 +100,25

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill @jayapalu thanks for your work, can you rebase against latest master, fix the conflicts. Also use the JIRA id in the git commit summary. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1795: CLOUDSTACK-9625:Unable to scale VM from any offering...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1795 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1796: CLOUDSTACK-9626: Instance fails to start after unsuc...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1796 @sudhansu7 this may be useful, can you at least change the PR's base branch to 4.9? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1798 @marcaurele one of the component tests have failed, please have a look and/or push -f to rekick Travis. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1803: CLOUDSTACK-9636: The host alerts box should b...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1804: CLOUDSTACK-9639: Unable to create shared network wit...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1804 @nitin-maharana this looks useful, can you change the base branch for the PR to 4.9, rebase your PR branch against 4.9? Can you add a marvin test for this? --- If your project is set up for

[GitHub] cloudstack issue #1805: CLOUDSTACK-9637: Template create from snapshot does ...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1805 Nice fix, @sudhansu7 this looks useful, can you change the base branch for the PR to 4.9, rebase your PR branch against 4.9? --- If your project is set up for it, you can reply to this email and

[DISCUSS] Bountycastle upgrade

2016-12-01 Thread Rohit Yadav
All, I've sent a PR that will upgrade bountycastle dependency to the latest version [1]. In terms of security, an upgrade is necessary though it would also require for users (who are upgrading to 4.9.1.0, 4.10.0.0 or later) to destroy old systemvms such as CPVM and SSVM so the agents that

[GitHub] cloudstack issue #1794: added more guest os

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1794 @karuturi ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack pull request #1800: CLOUDSTACK-9633:test_snapshot is failing due ...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1800 Thanks @syed I'll go ahead and merge this, as the changes confirm. I'm okay that moving (4.10+) fwd we've `.vhd` extension in snapshot files. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1765 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

2016-12-01 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1765#discussion_r90590680 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -100,36 +100,25 @@ protected

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1765 @jburwell rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1797 @sudhansu7 could you please either add or update an existing a Marvin test case to verify this change? Also, this change seems like it would be useful for LTS users. Could you please

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1799 Tests look good so far, I'm waiting for a vmware specific test run to complete. Some failures in kvm, xen are known intermittent failures. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1802 @murali-reddy can you have a look at why private_gw failed again for vmware? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r90589284 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List volumes,

[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/873#discussion_r90589240 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1746,10 +1747,10 @@ public boolean storagePoolHasEnoughSpace(List volumes,

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/873 Test LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1257 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @sureshanaparti sorry, this is a restricted command to avoid resource abuse issues. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1579 Travis is failing due to an env issue in their VMs, I'm investigating it with #1806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1618: [CLOUDSTACK-9643] Now returning os info with the lis...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1618 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1618: [CLOUDSTACK-9643] Now returning os info with the lis...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1618 Thanks @ProjectMoon @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1622 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1566: [CLOUDSTACK-9645] Followup fix for #1162: Add suppor...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1566 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1622 Thanks @ProjectMoon @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1566: [CLOUDSTACK-9645] Followup fix for #1162: Add suppor...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1566 LGTM. Thanks @ProjectMoon @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1806: travis: cleanup apt before installing package...

2016-12-01 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1806 travis: cleanup apt before installing packages This aims at fixing recent Travis failures. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-12-01 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-12-01 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1799 CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55 - Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning

[GitHub] cloudstack pull request #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/828 I looked at the failure, all of them are environment related or known intermittent failures. I'll proceed with merging this. LGTM. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 Trillian test result (tid-537) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34106 seconds Marvin logs:

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

2016-12-01 Thread nitin-maharana
Github user nitin-maharana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1804#discussion_r90584766 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3092,8 +3092,12 @@ public Vlan

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 Trillian test result (tid-534) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 26155 seconds Marvin logs:

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 Trillian test result (tid-536) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 25203 seconds Marvin logs:

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1659 Trillian test result (tid-532) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35829 seconds Marvin logs:

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1659 Trillian test result (tid-533) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35604 seconds Marvin logs:

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 Trillian test result (tid-525) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Total time taken: 34869 seconds Marvin logs:

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-302 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan test centos6 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1257 Addressed all the changes suggested and rebased against latest master. - Used CollectionUtils.isEmpty() as suggested. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1257#discussion_r90532049 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -138,6 +142,8 @@ @Inject

[GitHub] cloudstack issue #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1248 This PR is no longer valid since #1257 replaces this. Closing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host...

2016-12-01 Thread sureshanaparti
Github user sureshanaparti closed the pull request at: https://github.com/apache/cloudstack/pull/1248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/828 Trillian test result (tid-520) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 6 Total time taken: 38128 seconds Marvin logs:

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90520113 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java --- @@ -0,0 +1,310 @@ +// +//

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1802 Coupled with @rhtyd's explanation, we can merge this PR if the current blueorganutan run comes up clean. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1765 @abhinandanprateek could you please rebase this PR to pick up the fixes to the broken tests? I want to make sure that this PR doesn't introduce any side-effects that break the test runs.

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/873 @abhinandanprateek @murali-reddy @jburwell this may be useful for 4.9/lts, would you like to review? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/873 LGTM. Travis failure was due to an intermittent issue with oobm test, which has been fixed now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1802 @jburwell the issue was with an intermittent test that sometimes fail when clocks get skewed in virtualized environment: ` HypervisorUtilsTest.checkVolumeFileForActivityTest:68 Didn't block long

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 @jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests --- If your project is set up

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1802 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1802 @murali-reddy @rhtyd can you investigate the Travis failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510869 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,43 @@ +// +//

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510701 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java --- @@ -0,0 +1,63 @@ +// +// Licensed

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90510516 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

2016-12-01 Thread sgoeminn
Github user sgoeminn commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1579#discussion_r90509963 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -387,41 +400,39 @@ public boolean

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-12-01 Thread sudhansu7
Github user sudhansu7 commented on the issue: https://github.com/apache/cloudstack/pull/1763 @rhtyd @jburwell I think the fix for CLOUDSTACK-9376 will not address below scenario. I will test this and confirm. 1. templatefilter=all or isofilter=all is applicable

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1799 Thanks @jburwell I'll get this re-tested against both Travis and Trillian. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1799 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

2016-12-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1799 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-12-01 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1799 CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55 - Upgrades Maven dependency version to v1.55 - Fixes bountycastle usages and issues - Adds timeout to jetty/annotation scanning

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

2016-12-01 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-12-01 Thread Syed Ahmed
I'll take a look at this. It's been some moths but afaik I added that extension because previously that code wasn't working. I'll take a look in detail and let you guys know On Thu, Dec 1, 2016 at 11:34 mike-tutkowski wrote: > Github user mike-tutkowski commented on the

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1763 @rhtyd can you investigate why the fix for this issue in 4.5 was not pulled forward? For traceability purposes, it would be preferable to forward merge the fix than commit a new version of

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 Packaging result: ✔centos6 ✖centos7 ✖debian. JID-299 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1786: CLOUDSTACK-9618: Load Balancer configuration ...

2016-12-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1786#discussion_r90487461 --- Diff: plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java --- @@ -260,7 +264,7 @@ public boolean

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-12-01 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1800 Thanks, @rhtyd I've been trying to get test_snapshots.py to fail in my environment, but haven't been able to. I'll let @syed answer your question, Rohit, since that is a change

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/873 Trillian test result (tid-519) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27196 seconds Marvin logs:

[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: concurrent.snapshots.threshold.perh...

2016-12-01 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1776 @priyankparihar could you please provide further explanation as to how this fix addresses the issue of `concurrent.snapshots.threshold.perhost` not being validated? Also, is there an

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

2016-12-01 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1802 @murali-reddy a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

  1   2   3   >