Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-21 Thread Hugo Trippaers
Forgot to mention that this is pushed to master so we can test it before we drag it to 4.3 Cheers, Hugo On 21 feb. 2014, at 14:56, Hugo Trippaers trip...@gmail.com wrote: Heya, Just pushed commit ac00ab0087ca8f59184121697f7ac4343a694093 Author: Hugo Trippaers htrippa

Re: Review Request 18353: Removed compile time dependency of mysql-connecotr-java

2014-02-21 Thread Hugo Trippaers
in the source code to com.mysql. Those should be removed or made optional. I've taken this change into commit ac00ab0087ca8f59184121697f7ac4343a694093 Cheers, Hugo - Hugo Trippaers On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-21 Thread Hugo Trippaers
Packages already depend on the mysql connector, so no changes there. We do need to configure tomcat to include the os provided mysql-connector into the class path of the application. Cheers, Hugo On 21 feb. 2014, at 14:57, Hugo Trippaers trip...@gmail.com wrote: Forgot to mention

Re: [DISCUSS] Policy blocker?

2014-02-21 Thread Hugo Trippaers
Damodar, Did you see my review comments? Cheers, Hugo On 21 feb. 2014, at 16:00, Damoder Reddy damoder.re...@citrix.com wrote: Initially I thought my change caused to bundle the mysql-connector-java into RPM in 4.3... but after did more analysis I found that mysql-connector is already

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-20 Thread Hugo Trippaers
not make sense to vCenter. Ofcourse this would not block deployment of the template in itself. Removing this section ( vbox:Machine.../vbox:Machine) would make it cleaner. Regards, Sateesh -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-20 Thread Hugo Trippaers
upgrade from 4.2.1 (production database) to 4.3.0 Tested RPM packages on CentOS 6.5 x64 Verified fixes/workarounds for reported bugs: CLOUDSTACK-5883 CLOUDSTACK-5884 CLOUDSTACK-5979 Cheers, Hugo On 20 feb. 2014, at 11:02, Hugo Trippaers trip...@gmail.com wrote: Hi All

Re: Master blocker CLOUDSTACK-6130

2014-02-20 Thread Hugo Trippaers
Hey, Should be fixed by: commit ba7ff5369cc602c7e0c8d788b6617f27123c2328 Author: Hugo Trippaers htrippa...@schubergphilis.com Date: Thu Feb 20 14:04:51 2014 +0100 Fix parameter index in getCount function. @Talluri, Agreed. However with the current way of testing it is really hard

Re: Master blocker CLOUDSTACK-6130

2014-02-20 Thread Hugo Trippaers
Sent from my iPhone On 20 feb. 2014, at 18:31, Srikanteswararao Talluri srikanteswararao.tall...@citrix.com wrote: On 20/02/14 7:14 pm, Hugo Trippaers h...@trippaers.nl wrote: Hey, Should be fixed by: commit ba7ff5369cc602c7e0c8d788b6617f27123c2328 Author: Hugo Trippaers

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-19 Thread Hugo Trippaers
-1 (binding) I’m trying to upgrade an existing cloudstack installation from version 4.2.1 to version 4.3 and this is flinging because the database checker can’t find the correct systemvm templates for the 4.3 release. I found the release notes at

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-19 Thread Hugo Trippaers
: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581 geoff.higginbot...@shapeblue.com -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: 19 February 2014 10:56 To: dev@cloudstack.apache.org Subject: Re: [VOTE] Apache CloudStack 4.3.0

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-19 Thread Hugo Trippaers
as described in ticket CLOUDSTACK-5883. Cheers, Hugo On 19 feb. 2014, at 14:03, Hugo Trippaers trip...@gmail.com wrote: Geoff, Just commit the changes, you have the commit bit. ;-) Cheers, Hugo On 19 feb. 2014, at 12:56, Geoff Higginbottom geoff.higginbot...@shapeblue.com wrote

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-19 Thread Hugo Trippaers
: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: 19 February 2014 10:56 To: dev@cloudstack.apache.org Subject: Re: [VOTE] Apache CloudStack 4.3.0 (sixth round) -1 (binding) I'm trying to upgrade an existing cloudstack installation from version 4.2.1 to version 4.3

Re: Review Request 17843: CLOUDSTACK-6058: Update the java binding used to the latest one that came with XenServer 6.2 sp1

2014-02-19 Thread Hugo Trippaers
project on github (https://github.com/xapi-project/xen-api-sdk)? It would be nice if we could just depend on that project instead of having to include a copy in our own source tree. - Hugo Trippaers On Feb. 19, 2014, 7:31 p.m., Sanjay Tripathi wrote

Re: [VOTE] Apache CloudStack 4.3.0 (sixth round)

2014-02-19 Thread Hugo Trippaers
Animesh, Before we agree to use these templates, please detail how these are build. The current process is not transparent to the developer community so for now i’m -1 on using these templates. The process should be clear end-to-end before we can reasonably be expected to vote on a release as

Re: Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-18 Thread Hugo Trippaers
: Antonio Fornie afor...@schubergphilis.com Date: Wed Feb 5 10:01:06 2014 +0100 Nvp and rest refactoring and more tests Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 6, 2014, 12:53 p.m., Antonio Fornie wrote

Re: VmWare SDK to vijava

2014-02-18 Thread Hugo Trippaers
Chiradeep, Whats the progress on this? Cheers, Hugo On 22 jan. 2014, at 23:35, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Reached out to @strikesme and @danwendlandt On 1/21/14 10:14 PM, Hugo Trippaers htrippa...@schubergphilis.com wrote: We are now again at the exact same

Re: [VOTE] Apache CloudStack 4.3.0 (fifth round)

2014-02-18 Thread Hugo Trippaers
Sent from my iPhone On 18 feb. 2014, at 20:09, Sheng Yang sh...@yasker.org wrote: I don't understand why it's a blocker for release. 1. There is no correlated BUG ID. There was a bug id, it was closed as it was resolved and committed to the 4.3-forward tree. 2. Unit test is good, but

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-18 Thread Hugo Trippaers
master? Anything we missed? - Hugo Trippaers On Feb. 14, 2014, 2:48 p.m., Miguel Ferreira wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18114

Re: Review Request 18213: Fix and add some Rest unit and IT tests. Remove duplication of site pugin declaration. Fix by adding a missing type of RoutingConfig.

2014-02-18 Thread Hugo Trippaers
: Antonio Fornie afor...@schubergphilis.com Date: Tue Feb 18 17:02:12 2014 +0100 Fix and add some Rest unit and IT tests. Fix by adding a missing type of RoutingConfig. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 18, 2014, 4:09 p.m., Antonio

Re: Review Request 18165: FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable in 1 class; adding 5 tests to cover the changes in the equals() methods.

2014-02-15 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18165/#review34568 --- Heya, did you test this with devcloud as well? - Hugo Trippaers

Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs

2014-02-14 Thread Hugo Trippaers
/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java https://reviews.apache.org/r/18066/#comment64581 In the original code this would not be executed, why execute it now? - Hugo Trippaers On Feb. 13, 2014, 11:32 a.m., Wilder Rodrigues

Re: Review Request 18067: Fixed scary bug according to find bugs. (SBP find bugs hackaton)

2014-02-14 Thread Hugo Trippaers
: Sander Botman sbot...@schubergphilis.com Date: Tue Feb 11 17:45:00 2014 +0100 Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 13, 2014, 11:38 a.m

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Hugo Trippaers
/InMemoryEventBus.java https://reviews.apache.org/r/18072/#comment64583 Why recreate the map? utils/src/com/cloud/utils/UuidUtils.java https://reviews.apache.org/r/18072/#comment64582 UUID.fromString? And use this method in your other patch where you verify UUIDs? - Hugo Trippaers

Re: Review Request 18069: Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value

2014-02-14 Thread Hugo Trippaers
: wrodrigues wrodrig...@schubergphilis.com Date: Mon Feb 10 15:13:56 2014 +0100 fixing FindBugs scariest for replaceFirst() method call that does not assign the return value Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 13, 2014, 12:07 p.m

Re: Review Request 18068: Adding fixes and unit tests for cloud-engine-api scariest bugs found by FindBugs

2014-02-14 Thread Hugo Trippaers
: wrodrigues wrodrig...@schubergphilis.com Date: Mon Feb 10 18:20:15 2014 +0100 adding fix and unit tests for cloud-engine-api scariest Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 13, 2014, 12:08 p.m., Wilder Rodrigues wrote

Re: Review Request 18077: Findbugs Fixes

2014-02-14 Thread Hugo Trippaers
: Alex Hitchins a...@alexhitchins.com Date: Mon Feb 10 15:27:47 2014 + Findbugs - Long equality fix. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com commit c36c7e7de60cd1eb8310d16045dffb9df2105ada Author: Alex Hitchins a...@alexhitchins.com Date: Wed Feb 12 10:30:54

Re: Review Request 18079: Findbugs Fixes

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18079/#review34473 --- Duplicatee from 18077, please close - Hugo Trippaers On Feb. 13

Re: Review Request 18078: Findbugs Fixes

2014-02-14 Thread Hugo Trippaers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18078/#review34474 --- Duplicate from 18077, please close. - Hugo Trippaers On Feb. 13

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-14 Thread Hugo Trippaers
to version 4 - Add PowerMock dependency Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 14, 2014, 11:46 a.m., Miguel Ferreira wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 18114: Fix findbugs findings in cloudstack-service-console-proxy-rdpclient

2014-02-14 Thread Hugo Trippaers
to version 4 - Add PowerMock dependency Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 14, 2014, 11:46 a.m., Miguel Ferreira wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 18115: Eliminated findbugs findings in rdp console proxy (useless assignment to local variable)

2014-02-14 Thread Hugo Trippaers
: Ian Southam isout...@schubergphilis.com Date: Mon Feb 10 16:04:48 2014 +0100 Findbugs finding Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 14, 2014, 12:03 p.m., Ian Southam wrote

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
? The current patch consists of several patch files. - Hugo Trippaers On Feb. 14, 2014, 12:10 p.m., Ian Southam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
? The current patch consists of several patch files. - Hugo Trippaers On Feb. 14, 2014, 12:10 p.m., Ian Southam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
? The current patch consists of several patch files. - Hugo Trippaers On Feb. 14, 2014, 12:10 p.m., Ian Southam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18116

Re: Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb

2014-02-14 Thread Hugo Trippaers
: Miguel Ferreira mferre...@shubergphilis.com Date: Mon Feb 10 20:05:23 2014 +0100 Fix findbugs findings in cloud-plugin-network-elb Findings: - comparing Longs by reference - possible null pointer dereference Signed-off-by: Hugo Trippaers htrippa

Re: Review Request 18116: Fix and test GroupBy SQL query creation

2014-02-14 Thread Hugo Trippaers
: Antonio Fornie afor...@schubergphilis.com Date: Tue Feb 11 15:10:23 2014 +0100 Fix and test GroupBy SQL query creation Signed-off-by: Ian Southam isout...@schubergphilis.com Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 14, 2014, 2:10 p.m

Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l

2014-02-14 Thread Hugo Trippaers
: wrodrigues wrodrig...@schubergphilis.com Date: Tue Feb 11 11:15:55 2014 +0100 Fixes on Contrail and Mon InMemory plugins; adding comments about the changes. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Feb. 14, 2014, 2:43 p.m., Wilder Rodrigues

Findbugs findings fixed this week

2014-02-14 Thread Hugo Trippaers
of this week and we will for sure do this again. Cheers, Ian, Alex, Antonio, Wilder, Miguel, Sander, Daan and Hugo - Hugo Trippaers Schuberg Philis Boeingavenue 271 1119 PD Schiphol-Rijk http://www.schubergphilis.com/ +31 207506553 +31 6 510 555 19

Re: Template for Java 7 in Master branch

2014-02-10 Thread Hugo Trippaers
bit systemvm template using Java 7? Some of us are using VM provisioned from Vmware ESX as our hypervisor host due to resource limitation, unfortunately it only supports 32-bit template not 64 bit. Thanks -min On 2/8/14 4:05 AM, Hugo Trippaers h...@trippaers.nl wrote: Sheng, Use

Re: Template for Java 7 in Master branch

2014-02-08 Thread Hugo Trippaers
Sheng, Use the templates build from master (after build 77) from jenkins.buildacloud.org. Those templates have java 7. http://jenkins.buildacloud.org/job/build-systemvm-master/ Cheers, Hugo On 8 feb. 2014, at 02:10, Sheng Yang sh...@yasker.org wrote: BTW, the error result in SSVM and CPVM

Re: Code quality, QA, etc

2014-02-07 Thread Hugo Trippaers
Hey David, I would make a distinction between code issues and functional issues. Occasionally somebody just plainly breaks the build, i’m guilty of that myself actually, and thats just plain stupid. Luckily we have Jenkins to catch these errors quickly. I’m in a continuous struggle with

[ANNOUNCE] New Committer: Chris Suich

2014-02-06 Thread Hugo Trippaers
The Project Management Committee (PMC) for Apache CloudStack has asked Chris Suich to become a committer and we are pleased to announce that he has accepted. Being a committer allows many contributors to contribute more autonomously. For developers, it makes it easier to submit changes and

Re: Review Request 17638: Rest client moved to utils. Nvp extended.

2014-02-05 Thread Hugo Trippaers
/RESTValidationStrategy.java https://reviews.apache.org/r/17638/#comment63278 This is a Nicira specific URI, should be replaced with a variable? utils/src/com/cloud/utils/rest/RESTValidationStrategy.java https://reviews.apache.org/r/17638/#comment63280 Nicira specific? - Hugo Trippaers

Re: Review Request 16080: Move Netscaler plugin from non-oss to oss and upgrade the nitro API to 10.1

2014-02-05 Thread Hugo Trippaers
: Syed Ahmed sah...@cloudops.com Date: Wed Feb 5 14:03:49 2014 +0100 Review 16080 Move Netscaler plugin from non-oss to oss and upgrade the nitro API to 10.1 Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Dec. 6, 2013, 3:49 p.m., Syed Ahmed wrote

Found a little gem among the reviews..

2014-02-05 Thread Hugo Trippaers
Just pushed review 16080 through. Netscaler plugin is now part of the regular build! :-) Cheers, Hugo

Re: Build failed in Jenkins: build-master #242

2014-02-05 Thread Hugo Trippaers
Me bad :-( Forgot to commit a file as part of the fix. Will push it in a few. Cheers, Hugo On 5 feb. 2014, at 19:17, jenk...@cloudstack.org wrote: See http://jenkins.buildacloud.org/job/build-master/242/changes Changes: [rajesh.battala] Fixed agent code to handle untagged public vlan

Contrail issues in current master

2014-02-01 Thread Hugo Trippaers
Hey Contrail friends, I’m noticing some issues with the contrail plugin in current master. When you startup CloudStack master with a fresh database it will die with a NullPointerException at ContrailManagerImpl.java:locateVpcOffering(). After killing and restarting CloudStack it works fine.

Java 7 in systemvm

2014-01-31 Thread Hugo Trippaers
Heya, I just pulled the commits by Abhinandan Prateek into master. With the switch to java 7 on master we need ire 7 in the systemvms. If you are testing with master be sure to download the latest systemvm builds (after commit id d578d7ef85a7304aec18a207a35535f62eed0e0b). Otherwise starting

Re: [ANNOUNCE] Switched to Java 7

2014-01-30 Thread Hugo Trippaers
:09PM +0100, Hugo Trippaers wrote: I have some trouble getting into the rpmbuilders, so i can?t configure those. I need root permissions for those boxes and i don?t have that. Hey Hugo - just saw this. I see the build failed in the last run but can't tell if it used Java7 JDK

[JENKINS] Jenkins the spammer

2014-01-29 Thread Hugo Trippaers
Hey guys, Ofter the last few weeks we had a lot of problems with Jenkins actually reporting build problems that were actually infrastructure related. I try and explain the issues and how we try to prevent them from happening in the future. The GIT plugin used by jenkins has a build in timeout

RE: Release Managers for 4.3.1 and 4.4.0

2014-01-29 Thread Hugo Trippaers
Hey guys, We've discussed this internally in our company and we want to put in the effort to drive the 4.4 release. Daan and me are not quite sure yet who will be picking this up when the time comes, but one of us will step up to be the release manager. That said, I fully agree with Edison

Re: Review Request 17307: Juniper Contrail Plugin fixes

2014-01-28 Thread Hugo Trippaers
: Sachchidanand Vaidya vaidy...@juniper.net Date: Wed Jan 8 00:26:46 2014 -0800 These are additional fixes to make Juniper Contrail plugin work - Hugo Trippaers On Jan. 24, 2014, 8:06 a.m., Sachchidanand Vaidya wrote

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Hugo Trippaers
as it seems to contain the most issues. On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers h...@trippaers.nl wrote: I've also added a job to master with the Findbugs report and the cobertura code coverage report. Good stuff, we have a 12% coverage of our classes with unit tests. Huge

Re: Jetty on Windows

2014-01-28 Thread Hugo Trippaers
Hey Alex, Did you reinitialize the database prior to running the jetty target? Cheers, Hugo On 28 jan. 2014, at 11:42, Alex Hitchins alex.hitch...@shapeblue.com wrote: All, I'm successfully getting the UI to build and getting it to run on my windows machine through Jetty. That said, I

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Hugo Trippaers
. Thanks Animesh -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, January 28, 2014 1:29 AM To: dev Subject: Re: Findbugs report on 4.3-forward Hey Animesh, I agree with Daan here. We focussed on the bugs with a findbugs

Re: Findbugs report on 4.3-forward

2014-01-28 Thread Hugo Trippaers
Sent from my iPhone On 28 jan. 2014, at 23:50, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: -Original Message- From: Hugo Trippaers [mailto:trip...@gmail.com] Sent: Tuesday, January 28, 2014 2:37 PM To: dev@cloudstack.apache.org Cc: dev@cloudstack.apache.org

Re: [ANNOUNCE] Switched to Java 7

2014-01-27 Thread Hugo Trippaers
Working on it :-) Sent from my iPhone On 27 jan. 2014, at 13:57, Wido den Hollander w...@widodh.nl wrote: On 01/27/2014 12:04 PM, Wido den Hollander wrote: Hi, As promised [0], I switched the master [1] branch to Java 7 this morning. The builds all work on my Ubuntu 12.04 system,

Re: [ANNOUNCE] Switched to Java 7

2014-01-27 Thread Hugo Trippaers
I have some trouble getting into the rpmbuilders, so i can’t configure those. I need root permissions for those boxes and i don’t have that. The cloudstack-slaves will be fixed to support jdk 7. Cheers, Hugo On 27 jan. 2014, at 14:18, Hugo Trippaers trip...@gmail.com wrote: Working

Re: Findbugs report on 4.3-forward

2014-01-27 Thread Hugo Trippaers
. Thanks, Ian On 25 January 2014 22:26, Daan Hoogland daan.hoogl...@gmail.com wrote: or reply to this mail with the filename you are working on I'll be looking at the server package as it seems to contain the most issues. On Sat, Jan 25, 2014 at 4:00 PM, Hugo Trippaers h...@trippaers.nl

Findbugs report on 4.3-forward

2014-01-25 Thread Hugo Trippaers
Hey all, I’ve made Jenkins run the findbugs analysis on 4.3-forward. Is there somebody who is willing to help triage the findings? Maybe there is some stuff that we need to fix? the url is http://jenkins.buildacloud.org/job/cloudstack-4.3-forward-maven-build/3/findbugsResult/ Cheers, Hugo

Re: Findbugs report on 4.3-forward

2014-01-25 Thread Hugo Trippaers
Hoogland daan.hoogl...@gmail.com wrote: H Hugo, I'll spend some time on it tonight. Do you have a work load distribution scheme or is it random access? ;) regards On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers h...@trippaers.nl wrote: Hey all, I've made Jenkins run the findbugs analysis

Re: Findbugs report on 4.3-forward

2014-01-25 Thread Hugo Trippaers
On 25 jan. 2014, at 14:13, Daan Hoogland daan.hoogl...@gmail.com wrote: H Hugo, I'll spend some time on it tonight. Do you have a work load distribution scheme or is it random access? ;) regards On Sat, Jan 25, 2014 at 12:39 PM, Hugo Trippaers h...@trippaers.nl wrote: Hey all, I've

Re: Master build failing with LICENSE error

2014-01-24 Thread Hugo Trippaers
Hey guys, I’ve absolutely no clue what might be causing this. For me and Jenkins the build works without any problems. To make sure i’ve cleaned my entire tree and maven repository, but still the master build works. Which command,settings or profiles are you guys using to build master? The

Fwd: New Defects reported by Coverity Scan for cloudstack

2014-01-24 Thread Hugo Trippaers
FYI Sent from my iPhone Begin forwarded message: From: scan-ad...@coverity.com Date: 24 januari 2014 13:22:59 CET Subject: New Defects reported by Coverity Scan for cloudstack Hi, Please find the latest report on new defect(s) introduced to cloudstack found with Coverity Scan.

Re: [CANCELLED] [VOTE] Apache CloudStack 4.3.0 (first round)

2014-01-24 Thread Hugo Trippaers
Animesh, I'll put the fixes in tomorrow. I was traveling to the European CloudStack usergroup and didn't have enough opportunity to do all the fixes. I'll also try and get a findbugs report in Jenkins about the 4.3 branch. Cheers, Hugo Sent from my iPhone On 24 jan. 2014, at 20:15, Animesh

Re: [VOTE] Apache CloudStack 4.3.0 (first round)

2014-01-23 Thread Hugo Trippaers
Thanks Animesh, Great to see the first RC for 4.3. I’ve been running some findbugs analysis on master and found several issues that also seem to be present in the 4.3 branch. I’ve made two commit on master that fixed some issues that i spotted (c2da2803476d55e814ec0d849482bd07c4f9f8f1 and

Re: [VOTE] Apache CloudStack 4.3.0 (first round)

2014-01-23 Thread Hugo Trippaers
abhinandan.prat...@citrix.com wrote: Long values till at least 128 are cached, the ref being same, the == operator is guaranteed to work for values from -127 to 128. It the value can go beyond that range then this is a potential mine. -abhi On 23/01/14 1:51 pm, Hugo Trippaers h...@trippaers.nl wrote

Re: [ANNOUNCE] Switch to Java 7 in master branch on Monday Jan 27th 2014

2014-01-23 Thread Hugo Trippaers
+1 Cheers, Hugo On 23 jan. 2014, at 14:02, Alex Huang alex.hu...@citrix.com wrote: Sounds good. Thanks Wido! --Alex -Original Message- From: Wido den Hollander [mailto:w...@widodh.nl] Sent: Thursday, January 23, 2014 10:49 AM To: dev@cloudstack.apache.org Subject:

mycila maven-license-plugin?

2014-01-22 Thread Hugo Trippaers
Heya, In the past there have been several occasions where people missed the required headers when committing a files (and a disproportionate amount of those commits were mine ;-) ). Look at how other projects solve that issue i ran into the mycila license plugin. This is a maven plugin that

Re: checkstyle problems...

2014-01-22 Thread Hugo Trippaers
: That sounds good, Hugo - thanks! On Thu, Jan 16, 2014 at 2:53 AM, Hugo Trippaers h...@trippaers.nl wrote: Yeah, swapping out branches is a tricky thing in eclipse. I generally use two workspaces, one for master and one for current release branch. I noticed that when you swap branches

Re: [ISSUES] Master VMware is broken

2014-01-22 Thread Hugo Trippaers
=Hugo+Trippaers;st=author htrippa...@schubergphilis.comhttps://git-wip-us.apache.org/repos/asf?p= cloudstack.git;a=search;h=b20add810e5751f53946f695b6223a8016f104a5;s=htrip pa...@schubergphilis.com;st=author Wed, 22 Jan 2014 08:34:46 + (09:34 +0100) committer Hugo Trippaershttps

Re: Location of the 4.3 System VM Templates

2014-01-22 Thread Hugo Trippaers
The best location for the system vm images is http://jenkins.buildacloud.org/view/4.3/job/cloudstack-4.3-systemvm/. There we have the systemvm images that belong to the latest build agains the 4.3 tree. Look for the 'Last Successful Artifacts’ on that page. Cheers, Hugo On 23 jan. 2014, at

Re: VmWare SDK to vijava

2014-01-21 Thread Hugo Trippaers
Heya, Does anyone know about the current status the legal discussions around including the WSDL or code generated by parsing the WSDL? I would really like to have the vmware support in the normal build instead of just in the noredist build. It would probably boost adoption amongst people

Re: xentools on systemvmtemplate not visible to xen

2014-01-21 Thread Hugo Trippaers
Hey Abhi, i don’t think the xentools are installed. At least they are not in the postinstall.sh Cheers, Hugo On 21 jan. 2014, at 12:27, Abhinandan Prateek abhinandan.prat...@citrix.com wrote: The xentools are installed on systemvm templates but still xenserver is unable to recognise

Re: VmWare SDK to vijava

2014-01-21 Thread Hugo Trippaers
Let's not repeat the previous discussion. We allready agreed that the wsdl is the way forward. However we can't get any legal entity to say that it is ok to do so. Hence my proposal to at least move forward even if it means to temporarily use vijava. I really don't care what we do, as long

Re: VmWare SDK to vijava

2014-01-21 Thread Hugo Trippaers
Chiradeep, Even on the generated sources nobody seems willing to state that it is ok to include them at the moment. Otherwise I would have put them in already. Hugo Sent from my iPhone On 21 jan. 2014, at 19:32, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: Suboptimal for?

Re: VmWare SDK to vijava

2014-01-21 Thread Hugo Trippaers
Vittal chiradeep.vit...@citrix.com wrote: Apparently we can https://communities.vmware.com/docs/DOC-7983 http://markmail.org/thread/ttamcfb4d6azzbw7 On 1/21/14 2:46 PM, Hugo Trippaers trip...@gmail.com wrote: Chiradeep, Even on the generated sources nobody seems willing to state

Re: VmWare SDK to vijava

2014-01-21 Thread Hugo Trippaers
going to chase this ticket? Hugo Sent from my iPhone On 22 jan. 2014, at 07:04, Hugo Trippaers trip...@gmail.com wrote: Kelven, Chiradeep, What license governs the redistribution, what do we include in our notice file and is that license compatible with the ASF license policy? Hugo

snapshot releases for checkstyle and xapi

2014-01-21 Thread Hugo Trippaers
Hey, pulling this into a separate discussion from the release discussion. The idea with -SNAPSHOT releases is that maven knows that this version is under active development and it should always try to download a more recent build. Hence in your master branch all releases will be tagged with

Review Request 17115: CLOUDSTACK-5883 Convert ovf file to proper format for ESXi

2014-01-20 Thread Hugo Trippaers
into cloudstack and created an instance based on these templates. (32 and 64 bit) Thanks, Hugo Trippaers

CLOUDSTACK-5883

2014-01-20 Thread Hugo Trippaers
Hey Animesh, I’ve got the fix ready for CLOUDSTACK-5883, can you commit the review 17115 into 4.3 branch if you approve? Cheers, Hugo

Re: Review Request 17115: CLOUDSTACK-5883 Convert ovf file to proper format for ESXi

2014-01-20 Thread Hugo Trippaers
in the ova. - Hugo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17115/#review32288 --- On Jan. 20, 2014, 8:59 a.m., Hugo Trippaers wrote

Review Request 17124: CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select switch name, type and vlan token. Change preference to use the tags set on the physical network.

2014-01-20 Thread Hugo Trippaers
, deploy instance, test connectivity Create network offering with tag for network 2, deploy instance, test connectivity Thanks, Hugo Trippaers

Re: systemvm templates

2014-01-20 Thread Hugo Trippaers
the patch for review for ASF. -abhi On 18/01/14 12:45 pm, Hugo Trippaers trip...@gmail.com wrote: Hey Abhi, Do you have more details on this? A stacktrace or error log would be great. I would really need to see the details before we make a decision on this. Cheers, Hugo Sent

Re: systemvm templates

2014-01-17 Thread Hugo Trippaers
Abhi, I have the debian 7.0.0 isis local on the jenkins server, so we don’t depend on the external URLs. Do you want to switch master to the new image? No trouble for me to make it happen. Cheers, Hugo On 17 jan. 2014, at 17:12, Abhinandan Prateek abhinandan.prat...@citrix.com wrote:

Re: Revert update packages list before getting jre 7

2014-01-17 Thread Hugo Trippaers
...@citrix.com wrote: I have reverted another related one fc2e7ec70a1cc48a10a168ec3df607b49a7bcdf6, that was updating the jre to version 7. -abhi On 17/01/14 10:11 pm, Hugo Trippaers h...@trippaers.nl wrote: Hey guys, I just reverted commit fa6536152a17dfd03b6eb10b2a1e0868fc9e134c

Re: systemvm templates

2014-01-17 Thread Hugo Trippaers
update. jre7 is a absolute necessity for VMWare template. Once I have a successful local build I will update the thread. -abhi On 17/01/14 10:20 pm, Hugo Trippaers h...@trippaers.nl wrote: Abhi, I have the debian 7.0.0 isis local on the jenkins server, so we don¹t depend

Re: systemvm templates

2014-01-17 Thread Hugo Trippaers
. In the current template jre7 package is not available by default, needs apt- get update. jre7 is a absolute necessity for VMWare template. Once I have a successful local build I will update the thread. -abhi On 17/01/14 10:20 pm, Hugo Trippaers h...@trippaers.nl wrote: Abhi, I have the debian

Re: checkstyle problems...

2014-01-16 Thread Hugo Trippaers
files and started over completely. After that, I started seeing the problems. --Alex -Original Message- From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers Sent: Tuesday, January 14, 2014 11:31 PM To: dev Subject: Re: checkstyle problems... Hey guys

RAT build failure

2014-01-16 Thread Hugo Trippaers
Edison, Can you have a look at the new nexenta code? It appears to break the RAT build due to missing headers. Cheers, Hugo

Re: git commit: updated refs/heads/4.3 to f562579

2014-01-16 Thread Hugo Trippaers
This would mean some pretty interesting upgrade steps for folks. This would have to be thoroughly tested before bringing this into a release I think. +1 on postponing this to 4.4 Cheers, Hugo Sent from my iPhone On 16 jan. 2014, at 18:41, David Nalley da...@gnsa.us wrote: Why are we now

Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes

2014-01-16 Thread Hugo Trippaers
? The release 4.3 is effectively closed by now. Cheers, Hugo - Hugo Trippaers On Jan. 16, 2014, 6:53 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16974

Re: checkstyle problems...

2014-01-15 Thread Hugo Trippaers
. This should get the workspace rebuild time back to normal. Reference: http://sourceforge.net/p/eclipse-cs/feature-requests/140/ Cheers, Hugo On 15 jan. 2014, at 08:31, Hugo Trippaers trip...@gmail.com wrote: Hey guys, There are two ideas behind using checkstyle a i’ve currently

The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a clean installation

2014-01-15 Thread Hugo Trippaers
Sateesh, The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a clean installation of CloudStack at the moment. The error is this: 2014-01-15 15:07:19,166 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the database com.cloud.utils.exception.CloudRuntimeException:

Re: The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a clean installation

2014-01-15 Thread Hugo Trippaers
Should be fixed: commit 9aaea28d0dedc370888d346d55c81b95486f131b Author: Hugo Trippaers htrippa...@schubergphilis.com Date: Wed Jan 15 15:20:48 2014 +0100 Fix typo diff --git a/engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java b/engine/schema/src/com/cloud/upgrade/dao

Re: The commit ba96c8cadfa4b1dc7ee74fdb26ba5cea87e29b91 breaks a clean installation

2014-01-15 Thread Hugo Trippaers
Hat On Jan 15, 2014, at 9:22 AM, Hugo Trippaers h...@trippaers.nl wrote: Should be fixed: commit 9aaea28d0dedc370888d346d55c81b95486f131b Author: Hugo Trippaers htrippa...@schubergphilis.com Date: Wed Jan 15 15:20:48 2014 +0100 Fix typo diff --git a/engine/schema/src/com/cloud

Re: ApiXmlDocWriter

2014-01-15 Thread Hugo Trippaers
Hey David, The api’s you mention will only be discovered if you generate the apidocs with the noredist flag enabled. Otherwise those modules will be excluded from the build and ignored in API docs. So we should make a process where we generate the docs using the noredist procedure probably.

Re: Review Request 16858: Looking for keystore template in incorrect location

2014-01-14 Thread Hugo Trippaers
: Ian Southam isout...@gmail.com Date: Tue Jan 14 14:59:54 2014 +0100 Invalid reference to a class which has been moved Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Jan. 14, 2014, 2:05 p.m., Ian Southam wrote

Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

2014-01-14 Thread Hugo Trippaers
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11981/ --- (Updated June 19, 2013, 9:28 p.m.) Review request for cloudstack and Hugo Trippaers. Repository: cloudstack-git Description

Re: checkstyle problems...

2014-01-14 Thread Hugo Trippaers
but I don't know checkstyle very well so I'm hoping Hugo has a better solution. --Alex -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Tuesday, January 14, 2014 12:01 PM To: dev@cloudstack.apache.org Cc: Hugo Trippaers (htrippa

<    1   2   3   4   5   6   >