[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread likitha
Github user likitha commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117526563 Yes, now in addition to HyperV, even in case of VMware we want CS to chose the host containing the VM as the endpoint when the storage actions is 'MIGRATEVOLUME'.

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread sateesh-chodapuneedi
Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117537697 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack-cloudmonkey pull request: Dockerfile

2015-07-01 Thread runseb
Github user runseb commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/7#issuecomment-117538042 LGTM, feel free to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117541379 Hi @likitha And what about DeleteVolume? It now supports only VMware, but the MigrateVolume supports both VMware and HyperV. It would be nice to

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread sebgoa
On Jun 26, 2015, at 1:32 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Team, Would like to enhance usage server to provide quota management service to cloudstack. This will provide better control on resource usage; and a common denomination to measure resource usage.

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Erik Weber
On Fri, Jun 26, 2015 at 1:32 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Team, Would like to enhance usage server to provide quota management service to cloudstack. This will provide better control on resource usage; and a common denomination to measure resource

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Rohit Yadav
On 01-Jul-2015, at 10:58 am, Erik Weber terbol...@gmail.com wrote: I am a bit slow nowadays (vacation_mode = True), would you mind describing how this differs from the current account/global limits? I think the global limits and quota are quite different, Account/Global limits are per

Custom dictionary implementation

2015-07-01 Thread Ramzi Youssefi
Hello everyone, I'm implementing a UI Plugin and I would like to have a custom dictionary for the labels. Could you guys please provide an example on how to do this? I need three different languages and I would like to have the labels in the dictionary within the plugin. Any help would be

RE: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Rajesh Battala
+1 Nice feature to have -Original Message- From: Abhinandan Prateek [mailto:abhinandan.prat...@shapeblue.com] Sent: Friday, June 26, 2015 5:03 PM To: CloudStack Dev Subject: [PROPOSAL] Quota management service for cloudstack Team, Would like to enhance usage server to provide

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread John Burwell
All, I think we should stick to 2 votes per PR. Defining types of PRs becomes difficult bordering on the arbitrary — adding a process complexity and the potential to start debating if a particular PR is one type or another. I agree regarding the fast forward, and feel that all PRs should

[GitHub] cloudstack pull request: CLOUDSTACK-8603: Random list VM failures ...

2015-07-01 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/551 CLOUDSTACK-8603: Random list VM failures at scale (more than 1000 VMs… …) when VM has resource tags There is no 'removed' field on the resource_tags table. So 'id' based search

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread John Burwell
Congratulations and welcome Wilder. --- John Burwell (@john_burwell) VP of Software Engineering, ShapeBlue (571) 403-2411 | +44 20 3603 0542 http://www.shapeblue.com On Jul 1, 2015, at 1:45 PM, Somesh Naidu somesh.na...@citrix.com wrote: Congratulations Wilder! Regards, Somesh

Re: [GitHub] cloudstack pull request: As an operator I want to be able to chang...

2015-07-01 Thread John Burwell
Daan, I disagree regarding the squash. As I read through the list of commits, they read as a series of small commits that do not explain the overall change. When this batch of small of commits is merged into the large history of master, the intent of this work will be lost. In my opinion,

Timezone for snapshot policy ACS 4.3.2 - wrong interpretation or not

2015-07-01 Thread Andrija Panic
Hi, can anyone shed some light on the problem I see with time zones while creating scheduled snapshot policies... Im creating scheduled snapshot for 1 volume, I keep 1 last snapshot, I set timezone to i.e. Europe/Zurich, scheduled to run at 1AM after midnight. After I check DB, in

Build failed in Jenkins: simulator-singlerun #1330

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1330/ -- Started by upstream project build-master-simulator build number 2147 originally caused by: Started by upstream project build-master build number 2441 originally caused by: Started by an

Build failed in Jenkins: simulator-singlerun #1329

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1329/ -- Started by upstream project build-master-simulator build number 2146 originally caused by: Started by an SCM change [EnvInject] - Loading node environment variables. Building remotely on

[GitHub] cloudstack pull request: CLOUDSTACK-8600. Upon detaching a disk, d...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/545 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: GitHub master

2015-07-01 Thread koushik-das
GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/550 GitHub master Patch for CLOUDSTACK-8603. Refer to the bug for details. You can merge this pull request into a Git repository by running: $ git pull

Build failed in Jenkins: simulator-singlerun #1331

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1331/ -- Started by upstream project build-master-simulator build number 2148 originally caused by: Started by upstream project build-master build number 2442 originally caused by: Started by an

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-07-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/546#issuecomment-117653714 @wilderrodrigues LGTM, and Travis is green though there is no way for me to test it against the real h/w. Please go ahead with the merge. --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Allow custom command role ACL files on cl...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread wilderrodrigues
GitHub user wilderrodrigues opened a pull request: https://github.com/apache/cloudstack/pull/549 CLOUDSTACK-8180 - RouterVM does no longer provide X-ForwardedFor header with Loadbalancer Hi @remibergsma and @DaanHoogland The option forwardfor in the haproxy has been

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117576939 Thanks for fixing it, LGTM. Small comment: I see two commits with the same first line. Personally I'd prefer to see from the first line what a commit

RE: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Koushik Das
I like the concept of quota. But I am thinking whether this should be a core part of CS or developed as a plugin. Cloud coins example given below may be a plugin, based on which decision to allow/disallow operation is made. Another plugin could be to allow/disallow operations based on VM count

Build failed in Jenkins: simulator-singlerun #1328

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1328/ -- Started by upstream project build-master-simulator build number 2145 originally caused by: Started by an SCM change Started by an SCM change [EnvInject] - Loading node environment

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread likitha
Github user likitha commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117559997 Thanks for taking the time to review @wilderrodrigues. I have updated the issue description. As far as 'StorageAction.DELETEVOLUME' is concerned I am not

Build failed in Jenkins: build-4.5 #493

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/build-4.5/493/changes Changes: [Rohit Yadav] appliance: bump systemvm template version to 4.5.2 -- [...truncated 2970 lines...] T E S T S --- [INFO] Starting

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Rohit Yadav
On 01-Jul-2015, at 12:31 pm, Koushik Das koushik@citrix.com wrote: I like the concept of quota. But I am thinking whether this should be a core part of CS or developed as a plugin. It will be a separate plugin, not part of the core CS though we may need to refactor the core to allow

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Abhinandan Prateek
On 01-Jul-2015, at 2:20 pm, sebgoa run...@gmail.com wrote: On Jun 26, 2015, at 1:32 PM, Abhinandan Prateek abhinandan.prat...@shapeblue.com wrote: Team, Would like to enhance usage server to provide quota management service to cloudstack. This will provide better control on resource

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

2015-07-01 Thread likitha
GitHub user likitha opened a pull request: https://github.com/apache/cloudstack/pull/548 CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat… …a for volume. Update chain info of a volume after migration. You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/541 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-07-01 Thread bhaisaab
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117646467 @wilderrodrigues LGTM, meld the commits to one maybe? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-07-01 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/536#issuecomment-117600568 I guess a better fix needs to be worked on, closing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117583894 @remibergsma I also think it's a bit annoying the commits with the same message, but we have to inform the jira issue. Next time I will

Running VMs stopped upon CloudStack agent disconnected and re-connecting to management server

2015-07-01 Thread Indra Pramana
Dear all, I am using CloudStack version 4.2.0 with KVM hypervisor. I notice a strange behaviour when an agent got disconnected from the management server and I restarted the cloudstack-agent service to reconnect, it takes very long time to reconnect. And most of the time, it will stop most -- if

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Daan Hoogland
On Wed, Jul 1, 2015 at 8:44 PM, John Burwell john.burw...@shapeblue.com wrote: All, I think we should stick to 2 votes per PR. Defining types of PRs becomes difficult bordering on the arbitrary — adding a process complexity and the potential to start debating if a particular PR is one type

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117815608 Yep... Agree. That's what I also suggested in my reply. We are getting better... Next one will be perfect. :) Thanks, guys!

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117802350 @wilderrodrigues @remibergsma @bhaisaab why not just put the the ticket ID in the commit message? something like: * CLOUDSTACK-8180: adding this

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Erik Weber
On Wed, Jul 1, 2015 at 7:48 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi, On 25-Jun-2015, at 4:38 pm, Sebastien Goasguen run...@gmail.com wrote: A few of us are in Amsterdam at DevOps days. We are chatting about release management procedure. Remi is working on a set of

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Daan Hoogland
I'm afraid I don't agree on some of points here, Rohit. On Wed, Jul 1, 2015 at 7:48 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: ... Some suggestions and comments to improve PR reviewing/merging: - Let's merge the PR commits in a fast forward way instead of doing a branch merge that

[GitHub] cloudstack pull request: CLOUDSTACK-8180 - RouterVM does no longer...

2015-07-01 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/549#issuecomment-117813307 I agree, ticket id is enough. Sent from my iPhone On 01 Jul 2015, at 21:35, Miguel Ferreira notificati...@github.com wrote:

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread David Nalley
On Wed, Jul 1, 2015 at 3:39 AM, sebgoa run...@gmail.com wrote: On Jul 1, 2015, at 9:35 AM, Wilder Rodrigues wrodrig...@schubergphilis.com wrote: Nice! I spent couple of hours this morning to review a few PRs. But we still have too many of them and not many people reviewing/testing,

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Rafael Fonseca
Well deserved indeed. Parabéns Wilder! Sent from my iThing On Jul 1, 2015 7:13 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC.

[ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Rohit Yadav
The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC. Please join me in congratulating him. On behalf of the Apache CloudStack PMC, Rohit Yadav --- Rohit Yadav Software Architect,

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Remi Bergsma
Awesome news Wilder! :-) Sent from my iPhone On 01 Jul 2015, at 19:12, Rohit Yadav rohit.ya...@shapeblue.com wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC. Please

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Rohit Yadav
Hi, On 25-Jun-2015, at 4:38 pm, Sebastien Goasguen run...@gmail.com wrote: A few of us are in Amsterdam at DevOps days. We are chatting about release management procedure. Remi is working on a set of principles that he will put on the wiki to start a [DISCUSS]. However to get started on

RE: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Somesh Naidu
Congratulations Wilder! Regards, Somesh -Original Message- From: Rafael Fonseca [mailto:rsafons...@gmail.com] Sent: Wednesday, July 01, 2015 1:43 PM To: dev Subject: Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack Well deserved indeed. Parabéns Wilder! Sent from my

[GitHub] cloudstack pull request: GitHub master

2015-07-01 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/550#issuecomment-117765057 Discarding this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: GitHub master

2015-07-01 Thread koushik-das
Github user koushik-das closed the pull request at: https://github.com/apache/cloudstack/pull/550 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Mike Tutkowski
Congratulations! :) On Wed, Jul 1, 2015 at 11:12 AM, Rohit Yadav rohit.ya...@shapeblue.com wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC. Please join me in congratulating

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Nux!
Parabéns! :) -- Sent from the Delta quadrant using Borg technology! Nux! www.nux.ro - Original Message - From: Rohit Yadav rohit.ya...@shapeblue.com To: dev dev@cloudstack.apache.org Sent: Wednesday, 1 July, 2015 18:12:36 Subject: [ANNOUNCE] Wilder Rodrigues as a new PMC member of

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-07-01 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/535#discussion_r33650706 --- Diff: framework/config/src/org/apache/cloudstack/framework/config/ConfigKey.java --- @@ -122,6 +122,13 @@ public boolean equals(Object obj) {

[GitHub] cloudstack pull request: CLOUDSTACK-8566: Filter sensitive details...

2015-07-01 Thread karuturi
Github user karuturi commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/536#discussion_r33651106 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -203,9 +201,22 @@ public void execute() {

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/531 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Wilder Rodrigues
Nice! I spent couple of hours this morning to review a few PRs. But we still have too many of them and not many people reviewing/testing, which makes the process a bit slow. From the guys who usually review PRs, who is currently on holidays? Cheers, Wilder On 29 Jun 2015, at 11:27, sebgoa

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread sebgoa
On Jul 1, 2015, at 9:35 AM, Wilder Rodrigues wrodrig...@schubergphilis.com wrote: Nice! I spent couple of hours this morning to review a few PRs. But we still have too many of them and not many people reviewing/testing, which makes the process a bit slow. I expect this week to get

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/531#issuecomment-117517482 @DaanHoogland I already merged :) Got a LGTM from @karuturi Thanks, guys! --- If your project is set up for it, you can reply

Build failed in Jenkins: simulator-singlerun #1327

2015-07-01 Thread jenkins
See http://jenkins.buildacloud.org/job/simulator-singlerun/1327/ -- Started by upstream project build-master-simulator build number 2144 originally caused by: Started by an SCM change Started by upstream project build-master build number 2439 originally

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread likitha
Github user likitha commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117515627 @wilderrodrigues , Background - 1. When CS tries to live migrate a volume, it chooses a host endpoint to perform the migration by selecting any host that

[GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117517309 Hi @likitha I understood what the issue says, but what I really meant concerns what the code does. The only practical change in the code

[GitHub] cloudstack pull request: Cleanup stale files in /tmp which is fill...

2015-07-01 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/531#issuecomment-117517228 @wilderrodrigues let's stick to that for now (I kind of did the last few findbugs thing to see what happened with them:) LGTM --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8590 Refactoring NiciraNVP res...

2015-07-01 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/546#issuecomment-117896507 shouldnt we wait for another review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [PROPOSAL] Quota management service for cloudstack

2015-07-01 Thread Koushik Das
On 01-Jul-2015, at 4:44 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: On 01-Jul-2015, at 12:31 pm, Koushik Das koushik@citrix.com wrote: I like the concept of quota. But I am thinking whether this should be a core part of CS or developed as a plugin. It will be a separate

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Rajani Karuturi
Congratulations Wilder.. ~Rajani On Thu, Jul 2, 2015 at 7:48 AM, Rajesh Battala rajesh.batt...@citrix.com wrote: Hearty Congratulations Wilder Rodrigues -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Wednesday, July 1, 2015 10:43 PM To: dev

RE: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Koushik Das
Congrats Wilder! -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Wednesday, 1 July 2015 22:43 To: dev Subject: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack The Project Management Committee (PMC) for Apache CloudStack are pleased to

RE: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Sateesh Chodapuneedi
Hearty Congratulations Wilder :-) Regards, Sateesh -Original Message- From: Erik Weber [mailto:terbol...@gmail.com] Sent: Thursday, July 2, 2015 1:08 AM To: dev Subject: Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack The Project Management Committee (PMC) for

Re: [PROPOSAL] Commit to master through PR only

2015-07-01 Thread Rajani Karuturi
I do the same Erik. Sometimes I merge the changes from the authors branch directly without creating a local copy (using the command mentioned in the pull request mail). +1 on 2 manual reviews per PR irrespective of how trivial it is. -1 on squashed commits. If the author thinks that the change

[GitHub] cloudstack pull request: Config drive changes for vm migration

2015-07-01 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/552 Config drive changes for vm migration On vm migration attaching it in destination host is taken care in this patch. In this patch only xenserver resource changes are added. You can merge

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Erik Weber
On Wed, Jul 1, 2015 at 7:12 PM, Rohit Yadav rohit.ya...@shapeblue.com wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC. Please join me in congratulating him.

RE: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Rajesh Battala
Hearty Congratulations Wilder Rodrigues -Original Message- From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com] Sent: Wednesday, July 1, 2015 10:43 PM To: dev Subject: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack The Project Management Committee (PMC) for Apache

Re: [ANNOUNCE] Wilder Rodrigues as a new PMC member of CloudStack

2015-07-01 Thread Milamber
Congratulations Wilder! On 01/07/2015 17:12, Rohit Yadav wrote: The Project Management Committee (PMC) for Apache CloudStack are pleased to announce that Wilder Rodrigues (ekho) has accepted our invitation to join the PMC. Please join me in congratulating him. On behalf of the Apache

[GitHub] cloudstack pull request: findbugs: impossible cast(s) fixed by cha...

2015-07-01 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/538#issuecomment-117444046 Hi @DaanHoogland @K0zka als added a unit tests to cover his changes. Check this class: CreateSecondaryStagingStoreCmdTest Any chance to

[GitHub] cloudstack pull request: findbugs equals(obj) implementations go a...

2015-07-01 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/535#issuecomment-117444526 @wilderrodrigues Guava provides [EqualsTester](http://guava-libraries.googlecode.com/svn-history/r144/trunk/javadoc/com/google/common/testing/EqualsTester.html) to