[GitHub] cloudstack issue #1808: CLOUDSTACK-9648: Fix release script to update checks...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1808
  
This in reference to a query on user@, where a user failed to build from 
source tarball due to incorrect version set in tools/checkstyle/pom.xml.

@jburwell this needs to be included before we cut the next RCs, otherwise 
future tarballs may fail to build. Thanks.
/cc @murali-reddy @abhinandanprateek @borisstoyanov review please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1808: CLOUDSTACK-9648: Fix release script to update...

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1808

CLOUDSTACK-9648: Fix release script to update checkstyle pom

This fixes build_asf.sh release script to update checkstyle pom.xml with the
provided new version.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 
fix-release-script-checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1808.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1808


commit 77d2984494aa5fb32662c990503ae4f251fc4c6f
Author: Rohit Yadav 
Date:   2016-12-02T07:53:41Z

CLOUDSTACK-9648: Fix release script to update checkstyle pom

This fixes build_asf.sh release script to update checkstyle pom.xml with the
provided new version.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Bountycastle upgrade

[Rohit Yadav]

John,


I'll have a look at where/how the fingerprint method is used, if necessary I'll 
upgrade it to use SHA-256. Thanks for the pointers.


Regards.


From: John Kinsella 
Sent: 02 December 2016 13:12:12
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Bountycastle upgrade

2 thoughts:

1) I know this is partially git’s fault on the diff, and i know this is a 
standard gripe from me, but for reviewers things are much easier if 
syntax/whitespace changes are separated out into a separate patch from 
logic/functionality.
2) One thing that caught my eye was the SHA-1 use on the fingerprint. That got 
me looking around the codebase, and I see SHA-1/SHA1 sprinkled around. It’s not 
considered secure anymore [1]. Some of the uses are just for naming, that’s 
fine. I don’t think any of the use I saw was OMGFIXNOW. But at some point might 
be nice to replace all that with SHA-256. Would require a data migration, 
though.
3) Awesome, run with it. :)

John
1: https://en.wikipedia.org/wiki/SHA-1#Cryptanalysis_and_validation


rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

> On Dec 1, 2016, at 10:17 PM, Rohit Yadav  wrote:
>
> All,
>
>
> I've sent a PR that will upgrade bountycastle dependency to the latest 
> version [1]. In terms of security, an upgrade is necessary though it would 
> also require for users (who are upgrading to 4.9.1.0, 4.10.0.0 or later) to 
> destroy old systemvms such as CPVM and SSVM so the agents that will be 
> started in new system vms will use the same dependency jar (version/release) 
> and use the same cipher suites as the mgmt server (i.e. there will be no 
> SSL-based communication issue afterwards) as provided by bountycastle v1.55.
>
>
> Thoughts, feedback?
>
>
> [1] https://github.com/apache/cloudstack/pull/1799
>
>
> Regards.
>
> rohit.ya...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
>
>
>

[ALERT] Github Pull Requests Travis runs on hold

[Rohit Yadav]

All,


It seems that TravisCI is experiencing issues in their infra [1][2], and 
furthermore they have introduced changes in their default environment [3] 
yesterday due to which MySQL installation fails while deploying a simulator 
based environment. Due to these issues, TravisCI won't be available for testing 
and validation of PRs.


PR authors, this is to share with you so that you're aware and that failing PRs 
may not be because of your changes but issues in the CI itself. I'll work on 
this as soon as TravisCI's infra is back, and upgrade our Travis build scripts 
to compensate for new environment changes.


[1] https://twitter.com/traviscistatus/status/804568035256242176

[2] https://twitter.com/traviscistatus/status/804577337979219969

[3] https://docs.travis-ci.com/user/build-environment-updates/2016-12-01/


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

Re: [DISCUSS] Bountycastle upgrade

[John Kinsella]

2 thoughts:

1) I know this is partially git’s fault on the diff, and i know this is a 
standard gripe from me, but for reviewers things are much easier if 
syntax/whitespace changes are separated out into a separate patch from 
logic/functionality.
2) One thing that caught my eye was the SHA-1 use on the fingerprint. That got 
me looking around the codebase, and I see SHA-1/SHA1 sprinkled around. It’s not 
considered secure anymore [1]. Some of the uses are just for naming, that’s 
fine. I don’t think any of the use I saw was OMGFIXNOW. But at some point might 
be nice to replace all that with SHA-256. Would require a data migration, 
though.
3) Awesome, run with it. :)

John
1: https://en.wikipedia.org/wiki/SHA-1#Cryptanalysis_and_validation

> On Dec 1, 2016, at 10:17 PM, Rohit Yadav  wrote:
> 
> All,
> 
> 
> I've sent a PR that will upgrade bountycastle dependency to the latest 
> version [1]. In terms of security, an upgrade is necessary though it would 
> also require for users (who are upgrading to 4.9.1.0, 4.10.0.0 or later) to 
> destroy old systemvms such as CPVM and SSVM so the agents that will be 
> started in new system vms will use the same dependency jar (version/release) 
> and use the same cipher suites as the mgmt server (i.e. there will be no 
> SSL-based communication issue afterwards) as provided by bountycastle v1.55.
> 
> 
> Thoughts, feedback?
> 
> 
> [1] https://github.com/apache/cloudstack/pull/1799
> 
> 
> Regards.
> 
> rohit.ya...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK
> @shapeblue
> 
> 
> 

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-303


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1807
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1519: Cloudstack 9339: Virtual Routers do not handle Multi...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1519
  
Thanks @dsclose can you help review PR #1659 and see that all of your 
changes are ported too, in which you may close your PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1807
  
Pinging for review -- @jburwell @abhinandanprateek @borisstoyanov 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1807: CLOUDSTACK-9633: Revert addition of `vhd` ext...

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1807

CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots

This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes
introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed 
the
snapshot file name to include a `vhd` extension.

With this change, CloudStack users should not hit upgrade issues.

Reference: 
https://github.com/apache/cloudstack/pull/1600#pullrequestreview-10955963

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack xen-vhd-extension-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1807


commit 2f24ebb7773653de9e389ca6637c47530e7eba46
Author: Rohit Yadav 
Date:   2016-12-02T07:14:16Z

CLOUDSTACK-9633: Revert addition of `vhd` extention to snapshots

This reverts commit f1fd325c085cd61336ac616ba76e2c1f3f916cd1 and changes
introduced in commit f46651e6721106941deeb6b5e6bf51d7e9efc61c that changed 
the
snapshot file name to include a `vhd` extension.

With this change, CloudStack users should not hit upgrade issues.

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1600#discussion_r90595496
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
 ---
@@ -538,7 +562,7 @@ public Answer backupSnapshot(final CopyCommand cmd) {
 final String[] tmp = result.split("#");
 snapshotBackupUuid = tmp[0];
 physicalSize = Long.parseLong(tmp[1]);
-finalPath = folder + File.separator + 
snapshotBackupUuid;
+finalPath = folder + File.separator + 
snapshotBackupUuid + ".vhd";
--- End diff --

While I would want to add the extension, but I think we should revert this 
specific change, as otherwise it would add upgrade complexities. Given the 
short time for next RCs, such a change can be properly addressed in future with 
tooling around upgrading/renaming the files and paths.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Test lgtm, @murali-reddy are we good on this PR? I'm seeing some failures 
though not sure if they related to your changes. /cc @jburwell 
@abhinandanprateek 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
Test lgtm, based on the test results I'm seeing no new failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1764
  
Thanks @marcaurele 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1764: CLOUDSTACK-9597: Should not fetch resource count for...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1764
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1748: CLOUDSTACK-9620: KVM enhancements for managed storag...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1748
  
@mike-tutkowski you please fix the git commit summary (not the PR summary) 
in the requested format? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Test LGTM. @abhinandanprateek @murali-reddy can you give a final 
review/lgtm?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1726: CLOUDSTACK-9560 Root volume of deleted VM lef...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1726#discussion_r90594621
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
 if(downloadUrlCurrentAgeInSecs < 
_downloadUrlExpirationInterval){  // URL hasnt expired yet
 continue;
 }
-
-s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + 
volumeOnImageStore.getVolumeId());
+long volumeId = volumeOnImageStore.getVolumeId();
+s_logger.debug("Removing download url " + 
volumeOnImageStore.getExtractUrl() + " for volume id " + volumeId);
 
 // Remove it from image store
 ImageStoreEntity secStore = (ImageStoreEntity) 
_dataStoreMgr.getDataStore(volumeOnImageStore.getDataStoreId(), 
DataStoreRole.Image);
 
secStore.deleteExtractUrl(volumeOnImageStore.getInstallPath(), 
volumeOnImageStore.getExtractUrl(), Upload.Type.VOLUME);
 
 // Now expunge it from DB since this entry was created 
only for download purpose
 _volumeStoreDao.expunge(volumeOnImageStore.getId());
+Volume volume = _volumeDao.findById(volumeId);
+if (volume != null && volume.getState() == 
Volume.State.Expunged)
+{
+_volumeDao.remove(volumeId);
+}
--- End diff --

@yvsubhash ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1765#discussion_r90594670
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
 ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, 
final String path) {
 PBD pbd = null;
 
 try {
-final String srname = hypervisorResource.getHost().getUuid() + 
path.trim();
-
-final Set srs = SR.getByNameLabel(conn, srname);
-
-if (srs != null && !srs.isEmpty()) {
-return srs.iterator().next();
+final String srname = path.trim();
--- End diff --

The SR for a template that is to be copied to primary is temporarily 
mounted on Xen, after the copy is complete, it is unmounted and SR forgotten on 
Xen. The SR is temporary and for the current operation only. Having said that 
it does not really make a difference. @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill @jayapalu thanks for your work, can you rebase against latest 
master, fix the conflicts. Also use the JIRA id in the git commit summary. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1795: CLOUDSTACK-9625:Unable to scale VM from any offering...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1795
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1796: CLOUDSTACK-9626: Instance fails to start after unsuc...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1796
  
@sudhansu7 this may be useful, can you at least change the PR's base branch 
to 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1798: CLOUDSTACK-9631: API: affinitygroupids or affinitygr...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1798
  
@marcaurele one of the component tests have failed, please have a look 
and/or push -f to rekick Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1803: CLOUDSTACK-9636: The host alerts box should b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1803


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1804: CLOUDSTACK-9639: Unable to create shared network wit...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1804
  
@nitin-maharana  this looks useful, can you change the base branch for the 
PR to 4.9, rebase your PR branch against 4.9? Can you add a marvin test for 
this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1805: CLOUDSTACK-9637: Template create from snapshot does ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1805
  
Nice fix, @sudhansu7 this looks useful, can you change the base branch for 
the PR to 4.9, rebase your PR branch against 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] Bountycastle upgrade

[Rohit Yadav]

All,


I've sent a PR that will upgrade bountycastle dependency to the latest version 
[1]. In terms of security, an upgrade is necessary though it would also require 
for users (who are upgrading to 4.9.1.0, 4.10.0.0 or later) to destroy old 
systemvms such as CPVM and SSVM so the agents that will be started in new 
system vms will use the same dependency jar (version/release) and use the same 
cipher suites as the mgmt server (i.e. there will be no SSL-based communication 
issue afterwards) as provided by bountycastle v1.55.


Thoughts, feedback?


[1] https://github.com/apache/cloudstack/pull/1799


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1794: added more guest os

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1794
  
@karuturi ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1800: CLOUDSTACK-9633:test_snapshot is failing due ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1800


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1800
  
Thanks @syed I'll go ahead and merge this, as the changes confirm. I'm okay 
that moving (4.10+) fwd we've `.vhd` extension in snapshot files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1765#discussion_r90590680
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
 ---
@@ -100,36 +100,25 @@ protected SR createFileSR(final Connection conn, 
final String path) {
 PBD pbd = null;
 
 try {
-final String srname = hypervisorResource.getHost().getUuid() + 
path.trim();
-
-final Set srs = SR.getByNameLabel(conn, srname);
-
-if (srs != null && !srs.isEmpty()) {
-return srs.iterator().next();
+final String srname = path.trim();
--- End diff --

@abhinandanprateek ping, do you think changing the SR name can cause 
upgrade issues?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@jburwell rebased. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1797: CLOUDSTACK-9630: Cannot use listNics API as advertis...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1797
  
@sudhansu7 could you please either add or update an existing a Marvin test 
case to verify this change?

Also, this change seems like it would be useful for LTS users.  Could you 
please change the base branch to 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Tests look good so far, I'm waiting for a vmware specific test run to 
complete. Some failures in kvm, xen are known intermittent failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@murali-reddy can you have a look at why private_gw failed again for vmware?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/873#discussion_r90589284
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List 
volumes, StoragePool pool,
 }
 
 // allocated space includes templates
+s_logger.debug("Destination pool id: " + pool.getId());
--- End diff --

Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to 
prevent unnecessary/expensive string concatenation when `DEBUG` logging is not 
enabled.  Also, please add context to message to explain what operation is 
being performed for the destination pool.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #873: CLOUDSTACK-8896: allocated percentage of stora...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/873#discussion_r90589240
  
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1746,10 +1747,10 @@ public boolean 
storagePoolHasEnoughSpace(List volumes, StoragePool pool,
 allocatedSizeWithTemplate = 
_capacityMgr.getAllocatedPoolCapacity(poolVO, tmpl);
 }
 }
-
-if (volumeVO.getState() != Volume.State.Ready) {
-totalAskingSize += 
getDataObjectSizeIncludingHypervisorSnapshotReserve(volumeVO, pool);
-
+// A ready state volume is already allocated in a pool. so the 
asking size is zero for it.
+// In case the volume is moving across pools or is not ready 
yet, the asking size has to be computed
+s_logger.debug("pool id for the volume with id: " + 
volumeVO.getId() + " is: " + volumeVO.getPoolId());
--- End diff --

Please wrap this `DEBUG` log in an `if (s_logger.isDebugEnabled)` check to 
prevent unnecessary/expensive string concatenation when `DEBUG` logging is not 
enabled.

Minor nit: grammatically, the `:` character after `is` is unnecessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
Test LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@sureshanaparti sorry, this is a restricted command to avoid resource abuse 
issues.
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1579
  
Travis is failing due to an env issue in their VMs, I'm investigating it 
with #1806 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1618: [CLOUDSTACK-9643] Now returning os info with the lis...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1618
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1618: [CLOUDSTACK-9643] Now returning os info with the lis...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1618
  
Thanks @ProjectMoon 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1566: [CLOUDSTACK-9645] Followup fix for #1162: Add suppor...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1566
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1622: [CLOUDSTACK-9644] Adding missing bits field to Templ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1622
  
Thanks @ProjectMoon 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1566: [CLOUDSTACK-9645] Followup fix for #1162: Add suppor...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1566
  
LGTM. Thanks @ProjectMoon 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1806: travis: cleanup apt before installing package...

[rhtyd]

GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1806

travis: cleanup apt before installing packages

This aims at fixing recent Travis failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4.8-travis-apt-clean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1806.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1806


commit 405e97ec63678bfcc77202b713e14bdc22586409
Author: Rohit Yadav 
Date:   2016-12-02T05:20:52Z

travis: cleanup apt before installing packages

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1799


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1799

CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55

- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
- Picks up PR #1510 by Daan

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack bcprov-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1799


commit 81fb8af81f3e4731f9423d1cd806323068795ce3
Author: Rohit Yadav 
Date:   2016-11-30T09:31:28Z

CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55

- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
- Fixes servlet issue, uses servlet 3.1.0
- Picks up PR #1510 by Daan

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/828


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/828
  
I looked at the failure, all of them are environment related or known 
intermittent failures. I'll proceed with merging this. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
Trillian test result (tid-537)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34106 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1802-t537-vmware-55u3.zip
Test completed. 37 look ok, 6 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_VPC_default_routes | `Failure` | 239.44 | test_vpc_router_nics.py
test_01_vpc_site2site_vpn | `Error` | 472.66 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | `Error` | 730.42 | test_vpc_vpn.py
test_06_download_detached_volume | `Error` | 60.74 | test_volumes.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 0.00 | 
test_vm_life_cycle.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | 
test_vm_life_cycle.py
test_01_create_template | `Error` | 20.37 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 661.65 | 
test_templates.py
test_02_vpc_privategw_static_routes | `Error` | 651.29 | 
test_privategw_acl.py
test_01_vpc_remote_access_vpn | Success | 162.65 | test_vpc_vpn.py
test_01_VPC_nics_after_destroy | Success | 656.49 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 637.34 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1584.72 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 699.14 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 602.84 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1247.36 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 31.10 | test_volumes.py
test_05_detach_volume | Success | 105.30 | test_volumes.py
test_04_delete_attached_volume | Success | 15.36 | test_volumes.py
test_03_download_attached_volume | Success | 25.68 | test_volumes.py
test_02_attach_volume | Success | 58.90 | test_volumes.py
test_01_create_volume | Success | 533.23 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.35 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 199.43 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 192.04 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 167.06 | test_vm_snapshots.py
test_CreateTemplateWithDuplicateName | Success | 394.67 | test_templates.py
test_10_destroy_cpvm | Success | 272.35 | test_ssvm.py
test_09_destroy_ssvm | Success | 264.42 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.76 | test_ssvm.py
test_07_reboot_ssvm | Success | 189.79 | test_ssvm.py
test_06_stop_cpvm | Success | 208.01 | test_ssvm.py
test_05_stop_ssvm | Success | 209.91 | test_ssvm.py
test_04_cpvm_internals | Success | 1.63 | test_ssvm.py
test_03_ssvm_internals | Success | 3.90 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.16 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.18 | test_ssvm.py
test_01_snapshot_root_disk | Success | 71.80 | test_snapshots.py
test_04_change_offering_small | Success | 97.43 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.18 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.20 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 171.58 | test_routers.py
test_08_start_router | Success | 136.60 | test_routers.py
test_07_stop_router | Success | 25.49 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.07 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.87 | test_routers.py
test_03_restart_network_cleanup | Success | 181.87 | test_routers.py
test_02_router_internal_adv | Success | 1.09 | test_routers.py
test_01_router_internal_basic | Success | 0.60 | test_routers.py
test_router_dhcphosts | Success | 154.99 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 22.46 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 5.12 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 35.51 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.11 | test_regions.py
test_create_pvlan_network | Success | 5.47 | test_pvlan.py
test_dedicatePublicIpRange | Success | 1.49 | test_public_ip_range.py
test_04_rvpc_privategw_static_routes | Success | 1041.45 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 1044.72 | 
test_privategw_acl.py

[GitHub] cloudstack pull request #1804: CLOUDSTACK-9639: Unable to create shared netw...

[nitin-maharana]

Github user nitin-maharana commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1804#discussion_r90584766
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -3092,8 +3092,12 @@ public Vlan createVlanAndPublicIpRange(final long 
zoneId, final long networkId,
 final String guestNetworkCidr = zone.getGuestNetworkCidr();
 if (guestNetworkCidr != null) {
 if (NetUtils.isNetworksOverlap(newCidr, guestNetworkCidr)) 
{
-throw new InvalidParameterValueException("The new IP 
range you have specified has  overlapped with the guest network in zone: " + 
zone.getName()
-+ ". Please specify a different 
gateway/netmask.");
+// when adding shared network with same cidr of zone 
guest cidr,
+// if the specified vlan is not present in zone, 
physical network, allow to create the network as the isolation is based on VLAN.
+if (_zoneDao.findVnet(zoneId, physicalNetworkId, 
vlanId).size() > 0) {
--- End diff --

@jburwell : Thanks for your suggestion. I will consider this change. The 
effect would be same if we put all the conditions with && operator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Trillian test result (tid-534)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26155 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1799-t534-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.95 
| test_vpc_redundant.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.70 | 
test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 154.11 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 170.07 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.22 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 256.30 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 277.63 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 556.61 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 517.70 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1453.95 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 565.63 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 671.02 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.66 | test_volumes.py
test_08_resize_volume | Success | 15.47 | test_volumes.py
test_07_resize_fail | Success | 20.52 | test_volumes.py
test_06_download_detached_volume | Success | 15.32 | test_volumes.py
test_05_detach_volume | Success | 100.29 | test_volumes.py
test_04_delete_attached_volume | Success | 10.24 | test_volumes.py
test_03_download_attached_volume | Success | 15.44 | test_volumes.py
test_02_attach_volume | Success | 44.43 | test_volumes.py
test_01_create_volume | Success | 711.72 | test_volumes.py
test_deploy_vm_multiple | Success | 278.16 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.72 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.20 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 41.09 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.89 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.92 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.34 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 60.64 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.32 | test_templates.py
test_03_delete_template | Success | 5.16 | test_templates.py
test_02_edit_template | Success | 90.16 | test_templates.py
test_01_create_template | Success | 40.66 | test_templates.py
test_10_destroy_cpvm | Success | 166.76 | test_ssvm.py
test_09_destroy_ssvm | Success | 193.79 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.66 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.69 | test_ssvm.py
test_06_stop_cpvm | Success | 131.87 | test_ssvm.py
test_05_stop_ssvm | Success | 134.66 | test_ssvm.py
test_04_cpvm_internals | Success | 1.25 | test_ssvm.py
test_03_ssvm_internals | Success | 3.49 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.40 | test_snapshots.py
test_04_change_offering_small | Success | 239.96 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.07 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py
test_01_create_service_offering | Success | 0.14 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.23 | test_secondary_storage.py
test_09_reboot_router | Success | 40.35 | test_routers.py
test_08_start_router | Success | 30.33 | test_routers.py
test_07_stop_router | Success | 10.22 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.75 | test_routers.py
test_03_restart_network_cleanup | Success | 60.65 | test_routers.py
test_02_router_internal_adv | 

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
Trillian test result (tid-536)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25203 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1802-t536-kvm-centos7.zip
Test completed. 42 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 346.18 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 628.85 | test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 156.23 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 71.39 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 297.05 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 307.10 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 528.13 | test_vpc_router_nics.py
test_04_rvpc_network_garbage_collector_nics | Success | 1319.90 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 546.18 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 752.71 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1259.18 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.64 | test_volumes.py
test_08_resize_volume | Success | 15.58 | test_volumes.py
test_07_resize_fail | Success | 20.59 | test_volumes.py
test_06_download_detached_volume | Success | 15.43 | test_volumes.py
test_05_detach_volume | Success | 100.25 | test_volumes.py
test_04_delete_attached_volume | Success | 10.25 | test_volumes.py
test_03_download_attached_volume | Success | 15.38 | test_volumes.py
test_02_attach_volume | Success | 44.53 | test_volumes.py
test_01_create_volume | Success | 740.87 | test_volumes.py
test_deploy_vm_multiple | Success | 270.33 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.04 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.44 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.16 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 36.52 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.23 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 126.21 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.08 | test_vm_life_cycle.py
test_02_start_vm | Success | 5.13 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.32 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 70.75 | test_templates.py
test_08_list_system_templates | Success | 0.07 | test_templates.py
test_07_list_public_templates | Success | 0.07 | test_templates.py
test_05_template_permissions | Success | 0.09 | test_templates.py
test_04_extract_template | Success | 5.21 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 65.77 | test_templates.py
test_10_destroy_cpvm | Success | 193.14 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.36 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.71 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.78 | test_ssvm.py
test_06_stop_cpvm | Success | 131.62 | test_ssvm.py
test_05_stop_ssvm | Success | 133.91 | test_ssvm.py
test_04_cpvm_internals | Success | 1.01 | test_ssvm.py
test_03_ssvm_internals | Success | 3.44 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.20 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 12.43 | test_snapshots.py
test_04_change_offering_small | Success | 209.85 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.09 | test_service_offerings.py
test_01_create_service_offering | Success | 0.14 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.24 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.29 | test_secondary_storage.py
test_09_reboot_router | Success | 35.32 | test_routers.py
test_08_start_router | Success | 25.30 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.73 | test_routers.py
test_03_restart_network_cleanup | Success | 55.55 | test_routers.py
test_02_router_internal_adv | Success | 1.05 | test_routers.py
test_01_router_internal_basic | Success | 0.62 | test_routers.py

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Trillian test result (tid-532)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35829 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1659-t532-vmware-55u3.zip
Test completed. 44 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_redundant_vpc_site2site_vpn | `Failure` | 475.07 | test_vpc_vpn.py
test_04_rvpc_privategw_static_routes | `Failure` | 982.62 | 
test_privategw_acl.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 
216.66 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 126.29 | 
test_internal_lb.py
test_01_vpc_site2site_vpn | `Error` | 543.04 | test_vpc_vpn.py
test_05_rvpc_multi_tiers | `Error` | 132.69 | test_vpc_redundant.py
test_01_vpc_remote_access_vpn | Success | 177.06 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 340.74 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 814.99 | test_vpc_router_nics.py
test_04_rvpc_network_garbage_collector_nics | Success | 1554.98 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 725.91 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 727.82 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1509.99 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 31.12 | test_volumes.py
test_06_download_detached_volume | Success | 95.77 | test_volumes.py
test_05_detach_volume | Success | 105.30 | test_volumes.py
test_04_delete_attached_volume | Success | 15.25 | test_volumes.py
test_03_download_attached_volume | Success | 25.46 | test_volumes.py
test_02_attach_volume | Success | 63.85 | test_volumes.py
test_01_create_volume | Success | 549.55 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.17 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 200.26 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 368.24 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 159.06 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 309.06 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.86 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.22 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 86.36 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.11 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.15 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.15 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.28 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 287.25 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.05 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 15.27 | test_templates.py
test_03_delete_template | Success | 5.12 | test_templates.py
test_02_edit_template | Success | 90.15 | test_templates.py
test_01_create_template | Success | 141.01 | test_templates.py
test_10_destroy_cpvm | Success | 322.22 | test_ssvm.py
test_09_destroy_ssvm | Success | 274.20 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.75 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.57 | test_ssvm.py
test_06_stop_cpvm | Success | 201.97 | test_ssvm.py
test_05_stop_ssvm | Success | 178.60 | test_ssvm.py
test_04_cpvm_internals | Success | 1.36 | test_ssvm.py
test_03_ssvm_internals | Success | 3.40 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.22 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 71.72 | test_snapshots.py
test_04_change_offering_small | Success | 122.06 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.13 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 141.00 | test_routers.py
test_08_start_router | Success | 110.79 | test_routers.py
test_07_stop_router | Success | 25.25 | test_routers.py

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
Trillian test result (tid-533)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35604 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1659-t533-xenserver-65sp1.zip
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_rvpc_multi_tiers | `Failure` | 618.66 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1390.72 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 669.12 
| test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 883.45 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 396.07 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 156.21 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 687.83 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 484.63 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 702.60 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 993.18 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1097.71 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.61 | test_volumes.py
test_08_resize_volume | Success | 90.70 | test_volumes.py
test_07_resize_fail | Success | 100.72 | test_volumes.py
test_06_download_detached_volume | Success | 20.26 | test_volumes.py
test_05_detach_volume | Success | 100.24 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.20 | test_volumes.py
test_02_attach_volume | Success | 10.77 | test_volumes.py
test_01_create_volume | Success | 388.38 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 186.32 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 105.88 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 247.51 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 41.73 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.13 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 75.91 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.09 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.12 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.17 | test_vm_life_cycle.py
test_02_start_vm | Success | 30.23 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.22 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 162.03 | test_templates.py
test_08_list_system_templates | Success | 0.02 | test_templates.py
test_07_list_public_templates | Success | 0.03 | test_templates.py
test_05_template_permissions | Success | 0.04 | test_templates.py
test_04_extract_template | Success | 5.47 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 85.63 | test_templates.py
test_10_destroy_cpvm | Success | 261.56 | test_ssvm.py
test_09_destroy_ssvm | Success | 259.12 | test_ssvm.py
test_08_reboot_cpvm | Success | 161.57 | test_ssvm.py
test_07_reboot_ssvm | Success | 143.90 | test_ssvm.py
test_06_stop_cpvm | Success | 171.81 | test_ssvm.py
test_05_stop_ssvm | Success | 199.34 | test_ssvm.py
test_04_cpvm_internals | Success | 1.13 | test_ssvm.py
test_03_ssvm_internals | Success | 3.56 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
test_01_snapshot_root_disk | Success | 31.33 | test_snapshots.py
test_04_change_offering_small | Success | 121.07 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
test_01_create_service_offering | Success | 0.06 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.10 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.13 | test_secondary_storage.py
test_01_scale_vm | Success | 5.13 | test_scale_vm.py
test_09_reboot_router | Success | 75.41 | test_routers.py
test_08_start_router | Success | 60.34 | test_routers.py
test_07_stop_router | Success | 15.14 | test_routers.py
test_06_router_advanced | Success | 0.04 | test_routers.py
test_05_router_basic | Success | 0.03 | 

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Trillian test result (tid-525)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6
Total time taken: 34869 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1799-t525-xenserver-65sp1.zip
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_network_garbage_collector_nics | `Failure` | 1458.32 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 621.42 
| test_vpc_redundant.py
test_01_vpc_site2site_vpn | `Error` | 910.77 | test_vpc_vpn.py
test_05_rvpc_multi_tiers | `Error` | 87.08 | test_vpc_redundant.py
test_01_vpc_remote_access_vpn | Success | 178.02 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 640.99 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 478.60 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 614.90 | test_vpc_router_nics.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 1003.67 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 1061.20 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 21.11 | test_volumes.py
test_08_resize_volume | Success | 116.48 | test_volumes.py
test_07_resize_fail | Success | 121.76 | test_volumes.py
test_06_download_detached_volume | Success | 35.62 | test_volumes.py
test_05_detach_volume | Success | 105.43 | test_volumes.py
test_04_delete_attached_volume | Success | 15.44 | test_volumes.py
test_03_download_attached_volume | Success | 20.70 | test_volumes.py
test_02_attach_volume | Success | 21.13 | test_volumes.py
test_01_create_volume | Success | 438.17 | test_volumes.py
test_03_delete_vm_snapshots | Success | 280.37 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 222.04 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 101.38 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 319.05 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 27.16 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.21 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 67.59 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.23 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 15.71 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 20.33 | test_vm_life_cycle.py
test_02_start_vm | Success | 25.37 | test_vm_life_cycle.py
test_01_stop_vm | Success | 30.73 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 136.27 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.21 | test_templates.py
test_03_delete_template | Success | 5.14 | test_templates.py
test_02_edit_template | Success | 90.20 | test_templates.py
test_01_create_template | Success | 65.80 | test_templates.py
test_10_destroy_cpvm | Success | 196.78 | test_ssvm.py
test_09_destroy_ssvm | Success | 229.46 | test_ssvm.py
test_08_reboot_cpvm | Success | 121.83 | test_ssvm.py
test_07_reboot_ssvm | Success | 154.08 | test_ssvm.py
test_06_stop_cpvm | Success | 166.87 | test_ssvm.py
test_05_stop_ssvm | Success | 169.08 | test_ssvm.py
test_04_cpvm_internals | Success | 1.12 | test_ssvm.py
test_03_ssvm_internals | Success | 3.48 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.17 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py
test_01_snapshot_root_disk | Success | 31.68 | test_snapshots.py
test_04_change_offering_small | Success | 96.22 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.10 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.48 | test_secondary_storage.py
test_01_scale_vm | Success | 5.28 | test_scale_vm.py
test_09_reboot_router | Success | 65.57 | test_routers.py
test_08_start_router | Success | 50.51 | test_routers.py
test_07_stop_router | Success | 15.27 | test_routers.py
test_06_router_advanced | Success | 0.07 | test_routers.py
test_05_router_basic | Success | 0.07 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.57 | test_routers.py

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-302


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
@blueorangutan test centos6 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1257
  
Addressed all the changes suggested and rebased against latest master.
- Used CollectionUtils.isEmpty() as suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host...

[sureshanaparti]

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1257#discussion_r90532049
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -138,6 +142,8 @@
 @Inject
 private NetworkModel _netMgr;
 @Inject
+private HostDao _hostDao;
--- End diff --

@rodrigo93 This fix was part of the jira CLOUDSTACK-9175. Maintained the 
same conventions as in this class. The underscore "_" is prepended to all the 
member variables of the class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1248
  
This PR is no longer valid since #1257 replaces this. Closing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1248: CLOUDSTACK-9175: [VMware DRS] Adding new host...

[sureshanaparti]

Github user sureshanaparti closed the pull request at:

https://github.com/apache/cloudstack/pull/1248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #828: CLOUDSTACK-8854: Apple Mac OS/X VM get created withou...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/828
  
Trillian test result (tid-520)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 6
Total time taken: 38128 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr828-t520-vmware-55u3.zip
Test completed. 45 look ok, 4 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 298.90 | 
test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 371.24 | 
test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 376.41 | 
test_privategw_acl.py
test_isolate_network_password_server | `Failure` | 70.23 | 
test_password_server.py
test_01_vpc_site2site_vpn | `Error` | 534.15 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | `Error` | 759.89 | test_vpc_vpn.py
test_02_redundant_VPC_default_routes | `Error` | 127.73 | 
test_vpc_redundant.py
test_01_vpc_remote_access_vpn | Success | 207.34 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 382.36 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 759.86 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 726.30 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1612.85 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 772.88 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1527.91 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 30.97 | test_volumes.py
test_06_download_detached_volume | Success | 60.91 | test_volumes.py
test_05_detach_volume | Success | 100.31 | test_volumes.py
test_04_delete_attached_volume | Success | 20.29 | test_volumes.py
test_03_download_attached_volume | Success | 25.44 | test_volumes.py
test_02_attach_volume | Success | 64.27 | test_volumes.py
test_01_create_volume | Success | 522.40 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.25 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 229.30 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 151.42 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 161.70 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 274.10 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.94 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 76.48 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 10.17 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.16 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.27 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.16 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 372.73 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 15.27 | test_templates.py
test_03_delete_template | Success | 5.14 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 287.74 | test_templates.py
test_10_destroy_cpvm | Success | 267.25 | test_ssvm.py
test_09_destroy_ssvm | Success | 239.41 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.82 | test_ssvm.py
test_07_reboot_ssvm | Success | 188.99 | test_ssvm.py
test_06_stop_cpvm | Success | 202.25 | test_ssvm.py
test_05_stop_ssvm | Success | 169.08 | test_ssvm.py
test_04_cpvm_internals | Success | 1.38 | test_ssvm.py
test_03_ssvm_internals | Success | 3.78 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 36.61 | test_snapshots.py
test_04_change_offering_small | Success | 127.21 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.09 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 146.16 | test_routers.py
test_08_start_router | Success | 141.09 | test_routers.py

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

[sgoeminn]

Github user sgoeminn commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1579#discussion_r90520113
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
 ---
@@ -0,0 +1,310 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.network.resource;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import javax.naming.ConfigurationException;
+
+import net.nuage.vsp.acs.client.api.model.NuageVspUser;
+import net.nuage.vsp.acs.client.api.model.VspHost;
+import net.nuage.vsp.acs.client.common.NuageVspApiVersion;
+
+import org.apache.commons.lang.builder.ToStringBuilder;
+
+import com.cloud.util.NuageVspUtil;
+
+public class NuageVspResourceConfiguration {
--- End diff --

It's conceptual far more clear with the current class. Furthermore, this 
class is not only a wrapper around a Map but also contains a Builder.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
Coupled with @rhtyd's explanation, we can merge this PR if the current 
blueorganutan run comes up clean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1765
  
@abhinandanprateek could you please rebase this PR to pick up the fixes to 
the broken tests?  I want to make sure that this PR doesn't introduce any 
side-effects that break the test runs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
@abhinandanprateek @murali-reddy @jburwell this may be useful for 4.9/lts, 
would you like to review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
LGTM. Travis failure was due to an intermittent issue with oobm test, which 
has been fixed now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@jburwell the issue was with an intermittent test that sometimes fail when 
clocks get skewed in virtualized environment: `  
HypervisorUtilsTest.checkVolumeFileForActivityTest:68 Didn't block long enough, 
expected at least 2000 and got 1003`. I'll try to fix this in a separate PR.

Since, changes are all in integration test specific code. We can merge this 
once it passes, based on the last runs, the failure with private gw is not seen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@jburwell a Trillian-Jenkins matrix job (centos6 mgmt + xs65sp1, centos7 
mgmt + vmware55u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@murali-reddy @rhtyd can you investigate the Travis failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-301


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

[sgoeminn]

Github user sgoeminn commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1579#discussion_r90510869
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
 ---
@@ -0,0 +1,43 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api.manager;
+
+import com.cloud.agent.api.Command;
+import com.cloud.network.resource.NuageVspResourceConfiguration;
+
+public class UpdateNuageVspDeviceCommand extends Command {
--- End diff --

We added it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

[sgoeminn]

Github user sgoeminn commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1579#discussion_r90510701
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
 ---
@@ -0,0 +1,63 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package com.cloud.agent.api.manager;
+
+import com.cloud.agent.api.Command;
+import net.nuage.vsp.acs.client.api.model.VspDomainCleanUp;
+
+public class CleanUpDomainCommand extends Command {
+
+private final VspDomainCleanUp _domainCleanUp;
+
+public CleanUpDomainCommand(VspDomainCleanUp domainCleanUp) {
--- End diff --

We added a null check (Preconditions.checkNotNull(domainCleanUp);).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

[sgoeminn]

Github user sgoeminn commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1579#discussion_r90510516
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
 ---
@@ -387,41 +400,39 @@ public boolean canEnableIndividualServices() {
 
 @Override
 public boolean destroy(Network network, ReservationContext context) 
throws ConcurrentOperationException, ResourceUnavailableException {
-if (!canHandle(network, Service.Connectivity)) {
-return false;
-}
-
-return true;
+return canHandle(network, Service.Connectivity);
 }
 
 @Override
 public boolean verifyServicesCombination(Set services) {
-// This element can only function in a NuageVsp based
-// SDN network, so Connectivity needs to be present here
-if (!services.contains(Service.Connectivity)) {
-s_logger.warn("Unable to support services combination without 
Connectivity service provided by Nuage VSP.");
-return false;
+final Sets.SetView missingServices = 
Sets.difference(REQUIRED_SERVICES, services);
+final Sets.SetView unsupportedServices = 
Sets.intersection(UNSUPPORTED_SERVICES, services);
+final Sets.SetView wantedServices = 
Sets.intersection(NUAGE_ONLY_SERVICES, new HashSet<>());
+
+if (!missingServices.isEmpty()) {
+throw new UnsupportedServiceException("Provider " + 
Provider.NuageVsp + " requires services: " + missingServices);
 }
 
-if (!services.contains(Service.SourceNat)) {
-s_logger.warn("Unable to support services combination without 
SourceNat service provided by Nuage VSP.");
+if (!unsupportedServices.isEmpty()) {
+// NuageVsp doesn't implement any of these services.
+// So if these services are requested, we can't handle it.
+s_logger.debug("Unable to support services combination. The 
services " + unsupportedServices + " are not supported by Nuage VSP.");
--- End diff --

It's a user action that can cause this logging. We don't want this message 
to show up as a warning in the server logs, because for example it would be 
troublesome for system admins who get notified of each warning.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1579: CLOUDSTACK-9403 : Support for shared networks...

[sgoeminn]

Github user sgoeminn commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1579#discussion_r90509963
  
--- Diff: 
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
 ---
@@ -387,41 +400,39 @@ public boolean canEnableIndividualServices() {
 
 @Override
 public boolean destroy(Network network, ReservationContext context) 
throws ConcurrentOperationException, ResourceUnavailableException {
-if (!canHandle(network, Service.Connectivity)) {
-return false;
-}
-
-return true;
+return canHandle(network, Service.Connectivity);
 }
 
 @Override
 public boolean verifyServicesCombination(Set services) {
--- End diff --

We added a Preconditions.checkNotNull check on services.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-300


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

[sudhansu7]

Github user sudhansu7 commented on the issue:

https://github.com/apache/cloudstack/pull/1763
  
@rhtyd @jburwell 

I think the fix for CLOUDSTACK-9376 will not address below scenario. I will 
test this and confirm. 

1. templatefilter=all or isofilter=all is applicable only to admin
and domain admin.
2. With templatefilter=all or isofilter=all below are the visiblity
of templates in system.
a. admin should be able to see all templates/iso in system.
b. domain admin should be able to see all public template and
templates under its domain tree (including sub domain).
c. domain admin in a project context should be able to see all public
 templates and templates registered as project account and templates
 which are shared(using updateTemplatePermission api) with project account.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
Thanks @jburwell I'll get this re-tested against both Travis and Trillian.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1799: CLOUDSTACK-9632: Upgrade bouncy castle to version 1....

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1799
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

[rhtyd]

GitHub user rhtyd reopened a pull request:

https://github.com/apache/cloudstack/pull/1799

CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55

- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
- Picks up PR #1510 by Daan

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack bcprov-upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1799.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1799


commit 056f6e6b5e77ad0d6fa9fc98e8795f845b2c5bb0
Author: Rohit Yadav 
Date:   2016-11-30T09:31:28Z

CLOUDSTACK-9632: Upgrade bouncy castle to version 1.55

- Upgrades Maven dependency version to v1.55
- Fixes bountycastle usages and issues
- Adds timeout to jetty/annotation scanning
- Picks up PR #1510 by Daan

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1799: CLOUDSTACK-9632: Upgrade bouncy castle to ver...

[rhtyd]

Github user rhtyd closed the pull request at:

https://github.com/apache/cloudstack/pull/1799


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

[Syed Ahmed]

I'll take a look at this. It's been some moths but afaik I added that
extension because previously that code wasn't working. I'll take a look in
detail and let you guys know
On Thu, Dec 1, 2016 at 11:34 mike-tutkowski  wrote:

> Github user mike-tutkowski commented on the issue:
>
> https://github.com/apache/cloudstack/pull/1800
>
> Thanks, @rhtyd I've been trying to get test_snapshots.py to fail in my
> environment, but haven't been able to.
>
> I'll let @syed answer your question, Rohit, since that is a change he
> put in.
>
> If we do need/want to change that, let's do it in #1749 as I have that
> PR open to fix a couple issues I found with regards to snapshots on managed
> storage (specifically with regards to storing them on secondary storage, if
> that option is passed into the command).
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1763
  
@rhtyd can you investigate why the fix for this issue in 4.5 was not pulled 
forward?  For traceability purposes, it would be preferable to forward merge 
the fix than commit a new version of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
Packaging result: ✔centos6 ✖centos7 ✖debian. JID-299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1786: CLOUDSTACK-9618: Load Balancer configuration ...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1786#discussion_r90487461
  
--- Diff: 
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
 ---
@@ -260,7 +264,7 @@ public boolean applyLBRules(Network config, 
List rules) throw
 Map lbCapabilities = new HashMap();
 
 // Specifies that the RoundRobin and Leastconn algorithms are 
supported for load balancing rules
-lbCapabilities.put(Capability.SupportedLBAlgorithms, 
"roundrobin,leastconn");
+lbCapabilities.put(Capability.SupportedLBAlgorithms, 
"roundrobin,leastconn,source");
--- End diff --

The list of strings declared on this line must be sync with the list used 
to validate the algorithm on line 237.  Therefore, please consider extracting 
this list to a constant `ImmutableSet`, `SUPPORTED_ALGORITHMS` in order 
to ensure cohesion between declaration and validation.  With this change, the 
validateLBRule can be re-implemented as follows:

```java
public boolean validateLBRule(Network network, LoadBalancingRule rule) {
Preconditions.checkArgument(network != null, "validateLBRule requires a 
non-null network");
Preconditions.checkArgument(rule != null, "validateLBRule requires a 
non-null rule");

return (canHandle(network, Service.Lb)) : 
SUPPORTED_ALGORITHMS.contains(rule.getAlgorithm()) : true;
}
```

This line can be re-implemented as follows:

```java
lbCapabilities.put(Capability.SupportedLBAlgorithms, 
Joiner.on(",").join(SUPPORTED_ALGORITHMS));
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1800
  
Thanks, @rhtyd I've been trying to get test_snapshots.py to fail in my 
environment, but haven't been able to.

I'll let @syed answer your question, Rohit, since that is a change he put 
in.

If we do need/want to change that, let's do it in #1749 as I have that PR 
open to fix a couple issues I found with regards to snapshots on managed 
storage (specifically with regards to storing them on secondary storage, if 
that option is passed into the command).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #873: CLOUDSTACK-8896: allocated percentage of storage pool...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/873
  
Trillian test result (tid-519)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27196 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr873-t519-kvm-centos7.zip
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 870.17 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 379.81 
| test_vpc_redundant.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 245.11 | 
test_internal_lb.py
ContextSuite context=TestVPCRedundancy>:teardown | `Error` | 535.18 | 
test_vpc_redundant.py
test_01_vpc_site2site_vpn | Success | 165.81 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 81.27 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 341.36 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 323.55 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 608.23 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 530.07 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1421.98 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 575.32 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 15.60 | test_volumes.py
test_08_resize_volume | Success | 15.36 | test_volumes.py
test_07_resize_fail | Success | 20.47 | test_volumes.py
test_06_download_detached_volume | Success | 15.37 | test_volumes.py
test_05_detach_volume | Success | 100.29 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.28 | test_volumes.py
test_02_attach_volume | Success | 73.73 | test_volumes.py
test_01_create_volume | Success | 712.51 | test_volumes.py
test_deploy_vm_multiple | Success | 248.44 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.80 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.93 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.78 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.81 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 100.86 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.07 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 40.54 | test_templates.py
test_10_destroy_cpvm | Success | 161.54 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.60 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.63 | test_ssvm.py
test_06_stop_cpvm | Success | 161.76 | test_ssvm.py
test_05_stop_ssvm | Success | 139.47 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 3.45 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.12 | test_ssvm.py
test_01_snapshot_root_disk | Success | 16.35 | test_snapshots.py
test_04_change_offering_small | Success | 246.70 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 35.30 | test_routers.py
test_07_stop_router | Success | 10.19 | test_routers.py
test_06_router_advanced | Success | 0.07 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.76 | test_routers.py
test_03_restart_network_cleanup | Success | 75.61 | test_routers.py

[GitHub] cloudstack issue #1776: CLOUDSTACK-9603: concurrent.snapshots.threshold.perh...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1776
  
@priyankparihar could you please provide further explanation as to how this 
fix addresses the issue of `concurrent.snapshots.threshold.perhost` not being 
validated?

Also, is there an existing Marvin test case and/or unit test that verifies 
this fix?  If not, could you please add one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1802: CLOUDSTACK-9635: fix test_privategw_acl.py

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1802
  
@murali-reddy a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---