Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/182#issuecomment-111340031
a few nits, but LGTM! Thanks for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r3228
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -102,6 +102,19 @@ function hasCustomRules() {
return fs.existsSync(path.join(ROOT
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r32287669
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -245,18 +258,29 @@ var builders
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r32287653
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -245,18 +258,29 @@ var builders
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#discussion_r31235221
--- Diff: src/android/SplashScreen.java ---
@@ -91,7 +91,9 @@ protected void pluginInitialize() {
firstShow = false
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103934974
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30717099
--- Diff: src/executil.js ---
@@ -52,7 +52,7 @@ function execHelper(cmdAndArgs, silent, allowError) {
var result = superspawn.spawn(cmdAndArgs[0
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-103903180
Looks like this pr breaks tests. Could you please address? (run "npm test")
---
If your project is set up for it, you can reply to this email and have
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103703256
Awesome addition!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30661704
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist'
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30661261
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist'
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30661140
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
--- End diff --
missing header
---
If your project is set up for it, you can reply to
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/162#issuecomment-99489147
Merged. would be great if you could do another PR to update the docs:
https://github.com/apache/cordova-docs/blob/master/docs/en/edge/guide/platforms/android
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/162#issuecomment-99489261
(and thanks!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/212#discussion_r29683101
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -228,3 +228,4 @@ plugman.commands = {
};
module.exports = plugman;
+
--- End
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/211#issuecomment-99094530
Thanks Matt!
JIRA for this: https://issues.apache.org/jira/browse/CB-8956
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/212#discussion_r29671237
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -89,9 +90,12 @@ plugman.commands = {
plugman.owner(cli_opts.argv.remain
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugman/pull/83#discussion_r29583217
--- Diff: main.js ---
@@ -60,6 +61,9 @@ var cli_opts = nopt(known_opts, shortHands);
var cmd = cli_opts.argv.remain.shift
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/175#discussion_r29046696
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -130,6 +147,18 @@ public void onCreate(Bundle savedInstanceState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/175#discussion_r29046647
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -115,8 +116,24 @@ public void onCreate(Bundle savedInstanceState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/175#discussion_r29046516
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -115,8 +116,24 @@ public void onCreate(Bundle savedInstanceState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/175#discussion_r29046326
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -130,6 +147,18 @@ public void onCreate(Bundle savedInstanceState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045956
--- Diff: src/android/SplashScreen.java ---
@@ -254,8 +262,12 @@ public void run
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/45#discussion_r29045852
--- Diff: README.md ---
@@ -54,12 +54,18 @@ In your `config.xml`, you need to add the following
preferences
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28882407
--- Diff: www/Camera.js ---
@@ -72,4 +72,8 @@ cameraExport.cleanup = function(successCallback,
errorCallback) {
exec(successCallback
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28882307
--- Diff: src/android/CameraLauncher.java ---
@@ -632,73 +645,79 @@ else if (destType == FILE_URI || destType ==
NATIVE_URI
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28881896
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +167,15 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#discussion_r28881787
--- Diff: src/android/CameraLauncher.java ---
@@ -163,7 +167,15 @@ else if ((srcType == PHOTOLIBRARY) || (srcType ==
SAVEDPHOTOALBUM
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94831626
just went to have a look but the diff has changes that you didn't make in
it. Can you try rebasing?
---
If your project is set up for it, you can
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93614422
@boynet - your fiddle doesn't use the regex that's checked in.
http://jsfiddle.net/hakxc2uv/
shows that the regexp as-is works fine for yo
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/174#issuecomment-93529519
I do believe that the first letter of the name cannot be a number, which is
what the current regexp checks for (non-first characters can be numbers)
---
If
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/173#discussion_r28009343
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -95,6 +95,9 @@ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-docs/pull/267#issuecomment-90716706
Do we still want this change given that both gradle and ant-style are
accepted? I'm thinking no since I find gradle-style makes more sense. If so,
though, ne
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/277#discussion_r27888531
--- Diff: docs/en/edge/guide/platforms/android/tools.md ---
@@ -85,6 +85,43 @@ AVD is available as a target, you're prompted to select
on
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/277#discussion_r27888508
--- Diff: docs/en/edge/guide/platforms/android/tools.md ---
@@ -85,6 +85,43 @@ AVD is available as a target, you're prompted to select
on
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/172#issuecomment-90602838
Was this PR opened by mistake? Missing a description.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-90591245
This was merged. Will be applicable for cordova-android@4.0.0
---
If your project is set up for it, you can reply to this email and have your
reply
Github user agrieve closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88668426
Merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88620427
(esp. for debug signing keys, it's important that they are used not just
when packaging for release)
---
If your project is set up for it, you can rep
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88620279
Sorry - just realized one more thing. You'll need to add the new flags to
lib/run.js as well or else they won't work with the "cordova run&quo
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/162#discussion_r27606969
--- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
---
@@ -199,7 +199,19 @@ private void initWebViewSettings
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27593203
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27591881
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/164#issuecomment-88295360
Just a couple more comments then we are good to go! Thanks for working
through this with me. Feel free to rebase & squash commits.
---
If your project is
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536972
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -360,9 +391,15 @@ function parseOpts(options, resolvedTarget) {
var multiValueArgs
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536475
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +500,18 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536261
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/171#issuecomment-88189256
Awesome! Merged and made one minor change: Removed onCordovaInit from
CordovaInterface (but left it in CordovaInterfaceImpl). If it were to be called
from
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27482230
--- Diff: framework/src/org/apache/cordova/CordovaWebViewImpl.java ---
@@ -500,6 +500,7 @@ public void onPageFinishedLoading(String url
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27482005
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/171#discussion_r27481986
--- Diff: framework/src/org/apache/cordova/CordovaInterfaceImpl.java ---
@@ -119,4 +130,29 @@ public void onSaveInstanceState(Bundle outState
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27446516
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446385
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446338
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446076
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -297,6 +320,14 @@ var builders = {
var distributionUrl =
'distributi
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446058
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446054
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +457,31 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446047
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27446020
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +609,54 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445404
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27445351
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -372,6 +409,7 @@ function parseOpts(options, resolvedTarget) {
if
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/15#discussion_r27444603
--- Diff: keyboard/src/android/Keyboard.java ---
@@ -0,0 +1,124 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/15#discussion_r2735
--- Diff: keyboard/src/android/Keyboard.java ---
@@ -0,0 +1,124 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444238
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27444149
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/79#issuecomment-87881548
Thanks for fixing this up!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#issuecomment-87767088
Good stuff! A few minor comments then we're good to go I think!
---
If your project is set up for it, you can reply to this email and have
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413370
--- Diff: src/android/SplashScreen.java ---
@@ -194,9 +263,25 @@ public void run() {
// TODO: Use the background
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413236
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27413145
--- Diff: src/android/SplashScreen.java ---
@@ -151,13 +193,40 @@ public Object onMessage(String id, Object data
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/43#discussion_r27412851
--- Diff: src/android/SplashScreen.java ---
@@ -37,6 +39,19 @@ Licensed to the Apache Software Foundation (ASF) under
one
import
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugins/pull/18#issuecomment-87696102
Merged this in, but last I recall discussing the plugin on the dev
mailinglist, I don't think anyone was interested in pursuing it. Might try
raising the su
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/15#discussion_r27393159
--- Diff: keyboard/src/android/Keyboard.java ---
@@ -0,0 +1,124 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugins/pull/15#discussion_r27393052
--- Diff: keyboard/src/android/Keyboard.java ---
@@ -0,0 +1,124 @@
+/*
+ Licensed to the Apache Software Foundation (ASF) under one
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/170#discussion_r27391907
--- Diff: framework/src/org/apache/cordova/CordovaActivity.java ---
@@ -314,10 +318,52 @@ public void startActivityForResult(Intent intent, int
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-87076470
Install the plugin with the --link flag, and then you should be able to
edit it in the projects and the changes will be reflected in the repo (it
creates
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/194#issuecomment-86956650
Nice clean-up! Let me know when comments are addressed and I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27298165
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -223,11 +211,13 @@ module.exports = {
* @param {Boolean} determines if we are using
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/194#discussion_r27298069
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -0,0 +1,76 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27270342
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/168#issuecomment-86521912
Great questions.
The statics are meant to prevent multiple splash screens from showing if
there is more than one CordovaWebView within a project
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/40#issuecomment-85662478
The next version of the plugin will be installable by this name, it's just
not working yet.
---
If your project is set up for it, you can rep
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/26#issuecomment-85620698
I'd prefer not to open up the internals of the plugin, as that would
increase the maintenance burden by broadening its API. It's no
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704510
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -542,5 +653,12 @@ module.exports.help = function() {
console.log('\'--v
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704402
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -530,8 +589,60 @@ module.exports.findBestApkForArchitecture =
function(buildResults, arch
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704343
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -422,11 +477,15 @@ function parseOpts(options, resolvedTarget) {
module.exports.runClean
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r26704092
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -409,7 +442,29 @@ function parseOpts(options, resolvedTarget) {
console.warn
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/84#issuecomment-82483511
Thanks @mnill for your work here. Subclassing `File` was a bit too crazy to
put into the main code, but I've now added support for assets with
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/104#issuecomment-82476143
Why not just enable ARC on the file? Cordova & its plugins now assume ARC
to be enabled, so problems will just keep popping up without it I think.
--
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-82477043
Changes look good I think, but I've sadly landed some code before looking
at this that causes it to not merge cleanly. Would you be able to rebase?
-
Github user agrieve closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user agrieve opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/2
Test PR for github / JIRA integration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agrieve/cordova-plugin-whitelist patch-1
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/2#issuecomment-79145875
Test CB-4789
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/65#issuecomment-77190993
Change looks awesome! It's a bit much to pull in all at once though. Could
you rebase this into three distinct commits (error msgs, dropbox fix, ga
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25779722
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25725351
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings =
rc
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691445
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
"dependencies": {
"bplist-parser": "0.0.6",
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691366
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25691265
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) {
return
1 - 100 of 336 matches
Mail list logo
